Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuffs to do #6

Open
5 of 19 tasks
EZForever opened this issue Mar 9, 2021 · 3 comments
Open
5 of 19 tasks

Stuffs to do #6

EZForever opened this issue Mar 9, 2021 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@EZForever
Copy link
Owner

EZForever commented Mar 9, 2021

Kept here to replace TODO.md in the repo. Items marked "(?)" are still under consideration.


Emergency changes

Fabric Loader v0.12.0 introduces a massive refactor on mod loading mechanics, which breaks ThatOrThis completely. A rewrite needs to be done before it's too late. As the rewrite will break compatibility with Fabric Loader v0.11.x, support for these versions will be dropped on ThatOrThis v0.3.0.


Stuffs to a better & cleaner config schema: (Include in v0.3.0?)

  • Improve config schema robustness by allowing optional fields to be unset (Not a easy thing to do with Gson)
    • Introduce external libriaries (jackson / JSON5) instead? (Relocate classes to avoid conflict)
  • Predicates for rules/options? (Make a rule depend on rule conditions #21 has a brilliant idea)
  • Add tooltips to GENERATED rules' buttons (text from modmenu.descriptionTranslation.XXX? Format?)
  • Customizable/fixed namespace for ruleset translation (make text fields optional in the process)
  • Recover from mod conflicts ("safe mode"/load default/last-good choices)
  • Online tool for v0.2.x~v0.3.0 transition

EZForever added a commit that referenced this issue Mar 10, 2021
Trying to do:
- Integrate config button to ModMenu one
- Show filtered out mods in debug log
- Check for `LanguageAdapter`s and GrossFabricHacks entrypoints on injecting a mod
- Manual reload on invalid configs (#7)

TODO moved to #6.
@EZForever EZForever pinned this issue Jul 24, 2021
@EZForever EZForever changed the title Misc stuffs to do Stuffs to do Jul 24, 2021
@EZForever EZForever added the help wanted Extra attention is needed label Aug 28, 2021
@JustSimplyKyle
Copy link

Have you gathered enough interest?
(yes this is two years later)

@SettingDust
Copy link
Contributor

SettingDust commented Aug 26, 2023

Have you gathered enough interest? (yes this is two years later)

@JustSimplyKyle Similar mod by me https://modrinth.com/mod/mod-sets

@JustSimplyKyle
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants