Fix Beloved Rapture Menu issues #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not used but does not hurt...
They are disabled when EasyRpg-Mode is active as I consider this bad practice. Can result in hard-to-find bugs.
…file with Unicode encoding Maniac Patch appears to do something similiar
…dividable by the tile size. Rename the screen variables in the Parallax code as the same name (var shadowing) is confusing. Fixes incorrect scrolling of the map in Beloved Rapture
fdelapena
approved these changes
Nov 9, 2024
Thats another regression caused by the requirement of an ID for the SpriteEffect. Replaced the assert with a debug log as this already caused 3 issues.
|
Fixed the "Monster with hue change"-crash and added a workaround to prevent further crashes related to bitmaps without an ID when having Effects applied... |
fdelapena
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work on the battle events motivated me to fix the non-battle issues :)
What this doesn't fix is the wrong font size, guess they replaced the font in the exe with a different one. So the metrics are different.
Fix #3128