add ISO8601 duration formatting #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1e4c3c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fubhy
force-pushed
the
duration-format-iso
branch
from
88a9ef1 to
3489bac
Compare
effect-bot
force-pushed
the
next-minor
branch
6 times, most recently
from
bbe556f to
df7f007
Compare
|
I can't think of an argument against imho |
effect-bot
force-pushed
the
next-minor
branch
from
df7f007 to
d425963
Compare
Alright, let's do it then! |
fubhy
force-pushed
the
duration-format-iso
branch
from
b9d4a6f to
1e4c3c0
Compare
effect-bot
force-pushed
the
next-minor
branch
9 times, most recently
from
147d0a7 to
0e9616f
Compare
effect-bot
force-pushed
the
next-minor
branch
10 times, most recently
from
2940151 to
71c9d49
Compare
gcanti
approved these changes
Feb 5, 2025
fubhy
commented
Feb 5, 2025
| /** | ||
| * Formats a Duration into an ISO8601 duration string. | ||
| * | ||
| * The ISO8601 duration format is generally specified as P[n]Y[n]M[n]DT[n]H[n]M[n]S. However, since |
There was a problem hiding this comment.
@gcanti whoops. I forgot to remove this comment. I decided to go with 30 days per month qnd 365 days per year instead.
effect-bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
effect-bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
effect-bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should we add this? If so, I'd add a parser implementation too. The spec isn't clear on how to deal with months and years but I left them out anyways for now which is in line with our existing Duration implementation which also doesn't handle those.
Closes #4319