Fix CLI -h to display default values (#4400) #4402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f2f14f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
IMax153
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
This change looks great @Delusion2056 ! Thank you so much for the PR and the help with this :)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
ArgsandOptionsin@effect/clidid not correctly display default values in the help output whenwithDefaultwas used. If the fallback value was wrapped inOption.some, the internal object details were printed instead of the expected default value.Fix attempted is:
effect/Inspectablemodule.ArgsandOptionsdisplay expected default values in their help output.A few basic test cases were added for both
ArgsandOptions. Snapshots used due to deep partial object matching getting messy without custom matchers. (Unless I missed something.)Related
Args.withDefault#4400