#29: fix Implicit memory aliasing

EinStack · Dec 20, 2023 · 4f9eda0 · 4f9eda0
1 parent 843997d
commit 4f9eda0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/pkg/providers/openai/openai_test.go b/pkg/providers/openai/openai_test.go
@@ -9,7 +9,7 @@ import (
 func TestOpenAIClient(t *testing.T) {
 	// Initialize the OpenAI client
 
-	_ = t
+	var _ = t
 
 	poolName := "default"
 	modelName := "gpt-3.5-turbo"

diff --git a/pkg/providers/openai/openaiclient.go b/pkg/providers/openai/openaiclient.go
@@ -106,12 +106,13 @@ func (c *Client) NewClient(poolName string, modelName string) (*Client, error) {
 
 	// Find the pool with the specified name
 	var selectedPool *providers.Pool
-	for _, pool := range config.Gateway.Pools {
+	for i := range config.Gateway.Pools {
+		pool := &config.Gateway.Pools[i]
 		if pool.Name == poolName {
-			selectedPool = &pool
+			selectedPool = pool
 			break
 		}
-	}
+}
 
 	// Check if the pool was found
 	if selectedPool == nil {
@@ -121,9 +122,10 @@ func (c *Client) NewClient(poolName string, modelName string) (*Client, error) {
 
 	// Find the OpenAI provider in the selected pool with the specified model
 	var selectedProvider *providers.Provider
-	for _, provider := range selectedPool.Providers {
+	for i := range selectedPool.Providers {
+		provider := &selectedPool.Providers[i]
 		if provider.Provider == providerName && provider.Model == modelName {
-			selectedProvider = &provider
+			selectedProvider = provider
 			break
 		}
 	}