Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Add error code field to the non-streaming chat errors #235

Closed
roma-glushko opened this issue May 4, 2024 · 0 comments · Fixed by #236
Closed

[API] Add error code field to the non-streaming chat errors #235

roma-glushko opened this issue May 4, 2024 · 0 comments · Fixed by #236
Assignees
@roma-glushko
Labels
api:http area:api model:language type:breaking 💥 Introduces a breaking changes to API, configuration or behavior introduced before type:enhancement New feature or request
Milestone
Glide: Public Pre...

Comments

@roma-glushko
Copy link
Member

roma-glushko commented May 4, 2024 •
edited
Loading

Let's add

  • the error code field to the non-streaming error messages to make that schema consistent with the streaming errors
  • don't return 500 in case of no healthy model is in the router pool. Return 503 instead
  • Separate the expected failure case (e.g. no model is available) from unexpected internal errors (e.g. nil pointer exceptions)
  • make sure all response fields are consistently returned in camelCase
@roma-glushko roma-glushko self-assigned this May 4, 2024
@roma-glushko roma-glushko added this to the Glide: Public Preview milestone May 4, 2024
@roma-glushko roma-glushko added type:enhancement New feature or request type:breaking 💥 Introduces a breaking changes to API, configuration or behavior introduced before labels May 4, 2024
@roma-glushko roma-glushko changed the title [Chat] Add error code field to the non-streaming chat errors [API] Add error code field to the non-streaming chat errors May 5, 2024
roma-glushko added a commit that referenced this issue May 5, 2024
@roma-glushko
#235: Extended the non-streaming chat error schema with new fields to…
99f5bb8 
… give clients more context around the error
@roma-glushko roma-glushko linked a pull request May 5, 2024 that will close this issue
🔧 💥 #235: Extended the non-streaming chat error schema with new fields to give clients more context around the error #236
Merged
roma-glushko added a commit that referenced this issue May 5, 2024
@roma-glushko
#235: Updated OpenAPI specs
1c529ff
roma-glushko added a commit that referenced this issue May 5, 2024
@roma-glushko
#235 Fixed references
bbf779f
roma-glushko added a commit that referenced this issue May 5, 2024
@roma-glushko
#235: Removed bruno files
f69257a
roma-glushko added a commit that referenced this issue May 5, 2024
@roma-glushko
#235 Updated field name styling
ba91171
roma-glushko added a commit that referenced this issue May 6, 2024
@roma-glushko
#235: Made router config opaque & moved routers and health check sche…
b52c02d 
…mas to the api/schema package
roma-glushko added a commit that referenced this issue May 12, 2024
@roma-glushko
#235: Removed error namespaces
571d1db
roma-glushko added a commit that referenced this issue May 12, 2024
@roma-glushko
#235: Changed the name for overrides not to clash with defined statem…
4374f69 
…ents in some languages
roma-glushko added a commit that referenced this issue May 12, 2024
@roma-glushko
#235: Updated the example in the readme
78f70ef
roma-glushko added a commit that referenced this issue May 12, 2024
@roma-glushko
🔧 💥 #235: Extended the non-streaming chat error schema with new field…
3fa5b45 
…s to give clients more context around the error (#236)

- Introduced a new error type to hold useful context like HTTP response status, error name, message
- If all providers are unavailable, we are not throwing 500 error anymore but 503
- Start throwing unknown_error with 500 status on unexpected exceptions
- Predefined all static HTTP errors instead of creating them every time they occur
- Introduced the name field on the error schema
- Changed the req/response schema to snake_case (hopefully, to stick with it forever)
- Removed Bruno collections (it doesn't cover all our needs like websocket or gRPC protocol)
- Moved all schemas to `api/schema` package
- Made router list API opaque
- Changed the field name for overrides not to clash with defined statements in some languages
gernest added a commit to gernest/glide that referenced this issue May 15, 2024
@gernest
Merge branch 'develop' into instrument-gateway
e44df0e 
* develop:
  🔧 💥 EinStack#235: Extended the non-streaming chat error schema with new fields to give clients more context around the error (EinStack#236)
  🔧 EinStack#220 Instrument API server (EinStack#255)
  🔧 EinStack#248 Disable span and metrics by default (EinStack#254)
@roma-glushko roma-glushko mentioned this issue Jun 24, 2024
Merged
roma-glushko added a commit that referenced this issue Jun 24, 2024
@roma-glushko
📦 Release: v0.1.0-rc.1 (#280)
1e2b16f 
The first major update with breaking changes to the language chat schemas 
and begging of work on instrumenting the gateway with OpenTelemetry.

### Added

- 🔧 Use github.com/EinStack/glide as module name to support go install cmd (@gernest)
- ✨🔧 Setup Open Telemetry Metrics and Traces (#237) (@gernest)
-  🔧 #221 Add B3 trace propagator (#242) (@gernest)
- 🔧 #241 Support overriding OTEL resource attributes (#243) (@gernest)
- 🔧 #248 Disable span and metrics by default (#254) (@gernest)
- 🔧 #220 Instrument API server with observability signals (#255) (@gernest)
- 🔧 #164 Make client connection pool configurable across all providers (#251) (@daesu)
- 🔧 Instrument gateway process (#256) (@gernest)
- 🔧 #262: adding connection pool for chat request and response (#271) (@tom-fitz)

### Changed

- 🔧 #238 Implements human-readable durations in config (#253) (@ppmdo)
- 🔧 #266: removing omitempty from response definition (#267) (@tom-fitz)

#### Breaking Changes

- 🔧 💥 #235: Extended the non-streaming chat error schema with new fields to give clients more context around the error (#236) (@roma-glushko)
- 💥 Convert all camelCase config fields to the snake_case in the provider configs (#260) (@roma-glushko)
- ✨💥 #153: Allow to pass multiple model-specific param overrides (#264) (@roma-glushko)

### Fixed

- 🐛 #217: Set build info correctly in Glide images (#218) (@roma-glushko)

### Security

- 🔒 Updated golang to 1.22.4 to address CVE-2024-24790 (#276) (@STAR-173)

### Miscellaneous

- 📝 Defined a way to manage EinStack Glide project (#234) (@roma-glushko)
- 👷 #219: Setup local telemetry stack with Jaeger, Grafana, VictoriaMetrics and OTEL Collector (#225) (@roma-glushko)
- 👷‍♂️ Added a new GH action to watch for glide activity stream (#239, #244) (@roma-glushko)
- ✨ Switched to the new docs (@roma-glushko)
- 🔧 #240: Automatically install air (#277, #270) (@ppmdo, @roma-glushko)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roma-glushko roma-glushko

Labels
api:http area:api model:language type:breaking 💥 Introduces a breaking changes to API, configuration or behavior introduced before type:enhancement New feature or request
Projects
None yet
Milestone
Glide: Public Preview
1 participant
@roma-glushko