Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove account field from UnifiedFullViewingKey #522

Closed
nuttycom opened this issue Sep 6, 2022 · 1 comment
Closed

Remove account field from UnifiedFullViewingKey #522

nuttycom opened this issue Sep 6, 2022 · 1 comment
Assignees
@LukasKorba
Labels
C-tech-debt Technical debt that should be paid-in-full, eventually. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Milestone
iOS Zashi 1.3

Comments

@nuttycom
Copy link
Contributor

nuttycom commented Sep 6, 2022

Why is the UFVK carrying around its account ID? This might be okay, but it will cause problems if we want a wallet to be able to use UFVKs that do not correspond to the wallet's accounts; this will make it harder to implement the feature that I want where a wallet can import a UFVK to obtain watch-only functionality for a cold wallet. If this could be handled separately it would be good to make that breaking change to the API now, while we're making other breaking API changes.

Originally posted by @nuttycom in #491 (comment)
@nuttycom nuttycom mentioned this issue Sep 6, 2022
Merged
14 tasks
@nuttycom nuttycom added this to the UAs in Mobile SDKs milestone Oct 6, 2022
@nuttycom nuttycom removed this from the UAs in Mobile SDKs milestone Apr 9, 2024
@nuttycom nuttycom added the C-tech-debt Technical debt that should be paid-in-full, eventually. label Apr 9, 2024
@str4d str4d added this to the iOS Zashi 1.3 milestone Nov 20, 2024
@true-jared true-jared added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 5, 2024
@LukasKorba LukasKorba mentioned this issue Dec 5, 2024
Merged
14 tasks
@str4d
Copy link
Collaborator

str4d commented Jan 18, 2025

Closed by #1517.

@str4d str4d closed this as completed Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukasKorba LukasKorba

Labels
C-tech-debt Technical debt that should be paid-in-full, eventually. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
iOS Zashi 1.3
Development

No branches or pull requests
4 participants
@nuttycom @str4d @LukasKorba @true-jared