Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not forecast last day available on data? #1

Open
avilarenan opened this issue Sep 20, 2021 · 0 comments
Open

Does not forecast last day available on data? #1

avilarenan opened this issue Sep 20, 2021 · 0 comments

Comments

@avilarenan
Copy link

Hello! Greetings from brazil!

First of all, thanks for the awesome work and for sharing the code!

I just realized that in line 23 of file curateData.py there is a -1:
new_df = new_df.iloc[n_steps:-1, :]

Just tried to run without this -1, this way we use the last window of data to forecast the last point of data available and everything seems to work just fine. But I am using another data source, I did not test against you original data source.
new_df = new_df.iloc[n_steps:, :]

Any reason for using the -1?

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant