From 7a8032bb88b322e0cf86948c0865858e7234d4f1 Mon Sep 17 00:00:00 2001
From: ElliotNB <elliot.bradshaw@transformativemed.com>
Date: Thu, 28 Jun 2018 00:16:33 -0700
Subject: [PATCH] Remove try finally to restore performance.

---
 observable-slim.js     | 26 ++++++++++++++++----------
 observable-slim.min.js |  2 +-
 2 files changed, 17 insertions(+), 11 deletions(-)

diff --git a/observable-slim.js b/observable-slim.js
index 142304f..4775836 100644
--- a/observable-slim.js
+++ b/observable-slim.js
@@ -90,21 +90,27 @@ var ObservableSlim = (function() {
  			if (domDelay === true) {
 				setTimeout(function() {
 					if (numChanges === changes.length) {
+
+						// we create a copy of changes before passing it to the observer functions because even if the observer function
+						// throws an error, we still need to ensure that changes is reset to an empty array so that old changes don't persist
+						var changesCopy = changes.slice(0);
+						changes = [];
+
 						// invoke any functions that are observing changes
-						try {
-							for (var i = 0; i < observable.observers.length; i++) observable.observers[i](changes);
-						} finally {
-							changes = [];
-						}
+						for (var i = 0; i < observable.observers.length; i++) observable.observers[i](changesCopy);
+
 					}
 				},10);
 			} else {
+
+				// we create a copy of changes before passing it to the observer functions because even if the observer function
+				// throws an error, we still need to ensure that changes is reset to an empty array so that old changes don't persist
+				var changesCopy = changes.slice(0);
+				changes = [];
+
 				// invoke any functions that are observing changes
-				try {
-					for (var i = 0; i < observable.observers.length; i++) observable.observers[i](changes);
-				} finally {
-					changes = [];
-				}
+				for (var i = 0; i < observable.observers.length; i++) observable.observers[i](changesCopy);
+
 			}
 		};
 
diff --git a/observable-slim.min.js b/observable-slim.min.js
index 3c80c54..71ba881 100644
--- a/observable-slim.min.js
+++ b/observable-slim.min.js
@@ -1 +1 @@
-var ObservableSlim=function(){var u=[],d=[],x=[],P=null,f=function(e,l,r,n){var v=r||null,i=n||"",g=[],h=function(e,r,n){var t=null;return t=e instanceof Array?""!==i?i:r:""!==i?i+"."+r:r,!0===n&&(t="/"+t.replace(/\./g,"/")),t},b=function(r){if(!0!==v.paused)if(!0===l)setTimeout(function(){if(r===g.length)try{for(var e=0;e<v.observers.length;e++)v.observers[e](g)}finally{g=[]}},10);else try{for(var e=0;e<v.observers.length;e++)v.observers[e](g)}finally{g=[]}},y=new Proxy(e,{get:function(t,e){if("__getTarget"===e)return t;if("__isProxy"===e)return!0;if("__getParent"===e)return function(e){if(void 0===e)e=1;var r,n=h(t,"__getParent").split(".");return n.splice(-(e+1),e+1),r=v.parentProxy,n.join(".").split(".").reduce(function(e,r){return e?e[r]:void 0},r||self)};var r=t[e];if(!(r instanceof Object&&null!==r&&t.hasOwnProperty(e)))return r;!0===r.__isProxy&&(r=r.__getTarget);for(var n=-1,o=v.targets,a=0,s=o.length;a<s;a++)if(r===o[a]){n=a;break}return-1<n?v.proxies[n]:f(r,l,v,""!==i?i+"."+e:e)},deleteProperty:function(e,r){var n=!0;P===y&&(n=!1,P=null);var t=Object.assign({},e);if(g.push({type:"delete",target:e,property:r,newValue:null,previousValue:t[r],currentPath:h(e,r),jsonPointer:h(e,r,!0),proxy:y}),!0===n){for(var o=0,a=d.length;o<a&&e!==d[o];o++);for(var s=x[o],l=s.length;l--;)s[l].proxy!==y&&(P=s[l].proxy,delete s[l].proxy[r]);v.changesPaused||delete e[r]}return b(g.length),!0},set:function(t,e,r,n){var o=!0;P===y&&(o=!1,P=null);var a=t[e];if(a!==r||!1===o){var s=!0,l=typeof a,i="update";if("undefined"===l&&(i="add"),g.push({type:i,target:t,property:e,newValue:r,previousValue:n[e],currentPath:h(t,e),jsonPointer:h(t,e,!0),proxy:y}),!0===o){for(var u=0,f=d.length;u<f&&t!==d[u];u++);if(s=u<f){var p=x[u],c=0;for(f=p.length;c<f;c++)p[c].proxy!==y&&(P=p[c].proxy,p[c].proxy[e]=r);setTimeout(function(){if("object"===l&&null!==a){for(var e=Object.keys(t),r=0,n=e.length;r<n;r++)if(t[e[r]]===a)return;!function e(r){for(var n=Object.keys(r),t=0,o=n.length;t<o;t++){var a=r[n[t]];a instanceof Object&&null!==a&&e(a)}var s=-1;for(t=0,o=d.length;t<o;t++)if(r===d[t]){s=t;break}if(-1<s){for(var l=x[s],i=l.length;i--;)if(v===l[i].observable){l.splice(i,1);break}0==l.length&&(x.splice(s,1),d.splice(s,1))}}(a)}},1e4)}v.changesPaused||(t[e]=r)}s&&b(g.length)}return!0}});null===v?(v={parentTarget:e,domDelay:l,parentProxy:y,observers:[],targets:[e],proxies:[y],paused:!1,path:i,changesPaused:!1},u.push(v)):(v.targets.push(e),v.proxies.push(y));for(var t={target:e,proxy:y,observable:v},o=-1,a=0,s=d.length;a<s;a++)if(e===d[a]){o=a;break}return-1<o?x[o].push(t):(d.push(e),x.push([t]),o=d.length-1),y};return{create:function(e,r,n){if(!0===e.__isProxy)e=e.__getTarget;var t=f(e,r);return"function"==typeof n&&this.observe(t,n),function e(r){for(var n=r.__getTarget,t=Object.keys(n),o=0,a=t.length;o<a;o++){var s=t[o];n[s]instanceof Object&&null!==n[s]&&e(r[s])}}(t),t},observe:function(e,r){for(var n=u.length;n--;)if(u[n].parentProxy===e){u[n].observers.push(r);break}},pause:function(e){for(var r=u.length,n=!1;r--;)if(u[r].parentProxy===e){n=u[r].paused=!0;break}if(0==n)throw new Error("ObseravableSlim could not pause observable -- matching proxy not found.")},resume:function(e){for(var r=u.length,n=!1;r--;)if(u[r].parentProxy===e){n=!(u[r].paused=!1);break}if(0==n)throw new Error("ObseravableSlim could not resume observable -- matching proxy not found.")},pauseChanges:function(e){for(var r=u.length,n=!1;r--;)if(u[r].parentProxy===e){n=u[r].changesPaused=!0;break}if(0==n)throw new Error("ObseravableSlim could not pause changes on observable -- matching proxy not found.")},resumeChanges:function(e){for(var r=u.length,n=!1;r--;)if(u[r].parentProxy===e){n=!(u[r].changesPaused=!1);break}if(0==n)throw new Error("ObseravableSlim could not resume changes on observable -- matching proxy not found.")},remove:function(e){for(var r=null,n=!1,t=u.length;t--;)if(u[t].parentProxy===e){r=u[t],n=!0;break}for(var o=x.length;o--;)for(var a=x[o].length;a--;)x[o][a].observable===r&&(x[o].splice(a,1),0===x[o].length&&(x.splice(o,1),d.splice(o,1)));!0===n&&u.splice(t,1)}}}();try{module.exports=ObservableSlim}catch(e){}
\ No newline at end of file
+var ObservableSlim=function(){var u=[],d=[],x=[],P=null,f=function(e,l,r,n){var v=r||null,i=n||"",g=[],h=function(e,r,n){var t=null;return t=e instanceof Array?""!==i?i:r:""!==i?i+"."+r:r,!0===n&&(t="/"+t.replace(/\./g,"/")),t},b=function(n){if(!0!==v.paused)if(!0===l)setTimeout(function(){if(n===g.length){var e=g.slice(0);g=[];for(var r=0;r<v.observers.length;r++)v.observers[r](e)}},10);else{var e=g.slice(0);g=[];for(var r=0;r<v.observers.length;r++)v.observers[r](e)}},y=new Proxy(e,{get:function(t,e){if("__getTarget"===e)return t;if("__isProxy"===e)return!0;if("__getParent"===e)return function(e){if(void 0===e)e=1;var r,n=h(t,"__getParent").split(".");return n.splice(-(e+1),e+1),r=v.parentProxy,n.join(".").split(".").reduce(function(e,r){return e?e[r]:void 0},r||self)};var r=t[e];if(!(r instanceof Object&&null!==r&&t.hasOwnProperty(e)))return r;!0===r.__isProxy&&(r=r.__getTarget);for(var n=-1,o=v.targets,a=0,s=o.length;a<s;a++)if(r===o[a]){n=a;break}return-1<n?v.proxies[n]:f(r,l,v,""!==i?i+"."+e:e)},deleteProperty:function(e,r){var n=!0;P===y&&(n=!1,P=null);var t=Object.assign({},e);if(g.push({type:"delete",target:e,property:r,newValue:null,previousValue:t[r],currentPath:h(e,r),jsonPointer:h(e,r,!0),proxy:y}),!0===n){for(var o=0,a=d.length;o<a&&e!==d[o];o++);for(var s=x[o],l=s.length;l--;)s[l].proxy!==y&&(P=s[l].proxy,delete s[l].proxy[r]);v.changesPaused||delete e[r]}return b(g.length),!0},set:function(t,e,r,n){var o=!0;P===y&&(o=!1,P=null);var a=t[e];if(a!==r||!1===o){var s=!0,l=typeof a,i="update";if("undefined"===l&&(i="add"),g.push({type:i,target:t,property:e,newValue:r,previousValue:n[e],currentPath:h(t,e),jsonPointer:h(t,e,!0),proxy:y}),!0===o){for(var u=0,f=d.length;u<f&&t!==d[u];u++);if(s=u<f){var p=x[u],c=0;for(f=p.length;c<f;c++)p[c].proxy!==y&&(P=p[c].proxy,p[c].proxy[e]=r);setTimeout(function(){if("object"===l&&null!==a){for(var e=Object.keys(t),r=0,n=e.length;r<n;r++)if(t[e[r]]===a)return;!function e(r){for(var n=Object.keys(r),t=0,o=n.length;t<o;t++){var a=r[n[t]];a instanceof Object&&null!==a&&e(a)}var s=-1;for(t=0,o=d.length;t<o;t++)if(r===d[t]){s=t;break}if(-1<s){for(var l=x[s],i=l.length;i--;)if(v===l[i].observable){l.splice(i,1);break}0==l.length&&(x.splice(s,1),d.splice(s,1))}}(a)}},1e4)}v.changesPaused||(t[e]=r)}s&&b(g.length)}return!0}});null===v?(v={parentTarget:e,domDelay:l,parentProxy:y,observers:[],targets:[e],proxies:[y],paused:!1,path:i,changesPaused:!1},u.push(v)):(v.targets.push(e),v.proxies.push(y));for(var t={target:e,proxy:y,observable:v},o=-1,a=0,s=d.length;a<s;a++)if(e===d[a]){o=a;break}return-1<o?x[o].push(t):(d.push(e),x.push([t]),o=d.length-1),y};return{create:function(e,r,n){if(!0===e.__isProxy)e=e.__getTarget;var t=f(e,r);return"function"==typeof n&&this.observe(t,n),function e(r){for(var n=r.__getTarget,t=Object.keys(n),o=0,a=t.length;o<a;o++){var s=t[o];n[s]instanceof Object&&null!==n[s]&&e(r[s])}}(t),t},observe:function(e,r){for(var n=u.length;n--;)if(u[n].parentProxy===e){u[n].observers.push(r);break}},pause:function(e){for(var r=u.length,n=!1;r--;)if(u[r].parentProxy===e){n=u[r].paused=!0;break}if(0==n)throw new Error("ObseravableSlim could not pause observable -- matching proxy not found.")},resume:function(e){for(var r=u.length,n=!1;r--;)if(u[r].parentProxy===e){n=!(u[r].paused=!1);break}if(0==n)throw new Error("ObseravableSlim could not resume observable -- matching proxy not found.")},pauseChanges:function(e){for(var r=u.length,n=!1;r--;)if(u[r].parentProxy===e){n=u[r].changesPaused=!0;break}if(0==n)throw new Error("ObseravableSlim could not pause changes on observable -- matching proxy not found.")},resumeChanges:function(e){for(var r=u.length,n=!1;r--;)if(u[r].parentProxy===e){n=!(u[r].changesPaused=!1);break}if(0==n)throw new Error("ObseravableSlim could not resume changes on observable -- matching proxy not found.")},remove:function(e){for(var r=null,n=!1,t=u.length;t--;)if(u[t].parentProxy===e){r=u[t],n=!0;break}for(var o=x.length;o--;)for(var a=x[o].length;a--;)x[o][a].observable===r&&(x[o].splice(a,1),0===x[o].length&&(x.splice(o,1),d.splice(o,1)));!0===n&&u.splice(t,1)}}}();try{module.exports=ObservableSlim}catch(e){}
\ No newline at end of file