Revert update to egui 0.27 #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit db01a34.
emilk
force-pushed
the
revert-201-antoine/egui-0.27.0
branch
from
3e88b4c
to
dcf4d91
Compare
abey79
added a commit
to abey79/puffin
that referenced
this pull request
May 17, 2024
This reverts commit 2d7d3c6.
3 tasks
emilk
pushed a commit
that referenced
this pull request
May 17, 2024
### Checklist * [x] I have read the [Contributor Guide](../CONTRIBUTING.md) * [x] I have read and agree to the [Code of Conduct](../CODE_OF_CONDUCT.md) * [x] I have added a description of my changes and why I'd like them included in the section below ### Description of Changes This PR cancels the revert (#208) of egui 0.27.1 update (#201) and fix the flamegraph interaction bug it introduced whenever the flamegraph's scroll area was active. ### Related Issues * Closes #207 * Closes #205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puffin-egui: Incorrect flamegraph frame selection input handling #205The update to egui 0.27 broke scrolling and selection of scopes in the flamegraph.
I'll revert it, and then we don't merge things without testing them next time.