Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet switching causes you to see the other wallets balance #1822

Open
eitjuh opened this issue May 16, 2022 · 2 comments
Open

Wallet switching causes you to see the other wallets balance #1822

eitjuh opened this issue May 16, 2022 · 2 comments
Assignees
Labels
bug P0 Very critical bug, needs to be solved before feature launch

Comments

@eitjuh
Copy link
Contributor

eitjuh commented May 16, 2022

See https://allinbits.slack.com/archives/C02AXJ0K9F1/p1652459599620349

@eitjuh eitjuh added the bug P0 Very critical bug, needs to be solved before feature launch label May 16, 2022
@clockworkgr
Copy link
Collaborator

can someone who can reproduce it check the vuex state in vue dev tools?

when signing in with a different account/connecting a wallet it should dispatch SIGN_OUT which

  • removes all previous account subscriptions
  • waits for any existing requests to complete
  • deletes account related data from the store

@Dawntraoz
Copy link
Contributor

can someone who can reproduce it check the vuex state in vue dev tools?

when signing in with a different account/connecting a wallet it should dispatch SIGN_OUT which

  • removes all previous account subscriptions
  • waits for any existing requests to complete
  • deletes account related data from the store

Just checking that the issue is different if we check the portfolio vs the asset detail page. The SIGN_OUT is being called as I can see the call in Vue Devtools, but something is not being refreshed in the view 🤔

This video shows how it's not working properly when you are navigating in the app from Portfolio > Assets detail page, but it's working if you refresh the page and then start connecting/disconnecting the wallet.

Screen.Recording.2022-06-13.at.10.54.13.mov

@eitjuh maybe will be nice to list all the pages that are having issues and which ones not, so it's easy to find what is misused or not defined properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P0 Very critical bug, needs to be solved before feature launch
Projects
None yet
Development

No branches or pull requests

4 participants