Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/ adjusted swap data structure #204

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat/ adjusted swap data structure #204

wants to merge 3 commits into from

Conversation

faboweb
Copy link
Contributor

@faboweb faboweb commented May 31, 2022 •
edited
Loading

closes #177

@clockworkgr @luciorubeens is that data structure correct?

window.emeris.signTransaction({
    chainId: 'cosmos-hub', 
    signingAddress: 'cosmos16slmknhr8p9c254dk8xctkwl6340p0k8g8levh', 
    messages: [
        { 
            type: 'swap', 
            data: [{
                from: { denom: 'uatom', amount: 1 }, 
                to: { denom: 'uosmo' }, 
                chain_name: 'cosmos-hub', 
                orderPrice: 2
            },{
                from: { denom: 'uosmo', amount: 1 }, 
                to: { denom: 'uregen' }, 
                chain_name: 'cosmos-hub', 
                orderPrice: 4
            }]
        },
    ],
    fee: {
        gas: "200000",
        amount: [{
amount: 2000,
        denom: 'uatom'}]
    }
    }).then(console.log)
    ```

@faboweb faboweb marked this pull request as ready for review May 31, 2022 03:06
@github-actions
Copy link

github-actions bot commented May 31, 2022 •
edited
Loading

Visit the preview URL for this PR (updated for commit e8fde0a):

https://emeris-extension--pr204-feat-new-swap-hpjlfuct.web.app

(expires Tue, 07 Jun 2022 10:46:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@clockworkgr
Copy link
Collaborator

Doesn't seem like it:

https://github.com/EmerisHQ/emeris-libraries/blob/develop/packages/types/src/EmerisTransactions.ts#L131-L143

@faboweb
Copy link
Contributor Author

faboweb commented May 31, 2022 •
edited
Loading

order price vanished from the abstract?

Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clockworkgr clockworkgr Awaiting requested review from clockworkgr clockworkgr is a code owner

@luciorubeens luciorubeens Awaiting requested review from luciorubeens luciorubeens is a code owner

@eitjuh eitjuh Awaiting requested review from eitjuh

@pranaybaldev pranaybaldev Awaiting requested review from pranaybaldev

@Raymahni Raymahni Awaiting requested review from Raymahni

@caudurodev caudurodev Awaiting requested review from caudurodev

@fl-y fl-y Awaiting requested review from fl-y

@mihailmarcu mihailmarcu Awaiting requested review from mihailmarcu

@Dawntraoz Dawntraoz Awaiting requested review from Dawntraoz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle new Swap data structure
2 participants
@faboweb @clockworkgr