Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Inconsistency in router navigation #193

Open
Dawntraoz opened this issue May 19, 2022 · 1 comment · May be fixed by #199 or #212
Open

Bug: Inconsistency in router navigation #193

Dawntraoz opened this issue May 19, 2022 · 1 comment · May be fixed by #199 or #212
Assignees
Labels
bug Something isn't working

Comments

@Dawntraoz
Copy link
Contributor

What is the problem

At the moment, the EE Header component is rendering a 'Go Back' arrow that is expecting a route path to go to or will use the .go(-1) expecting to go back to the previous route.

The problem is that if you are in a flow and the arrow is using the .go(-1) and you go further and then try to go back, will go to the next screen and not to the previous screen, because it was the last visited one.

Screen recording for clarification:

https://images.zenhubusercontent.com/479516074/f211082e-b842-4c7c-a8a1-57b8ce23faa9/screen_recording_2022_05_19_at_16_22_52.mov

What should be happening

The user should be able to follow the flow to the right while clicking on buttons, and go to the left while clicking on the header arrow.

Guess we need to get rid of router.go(-1) and be able to pass the corresponding route path when needed.

@Dawntraoz Dawntraoz added the bug Something isn't working label May 19, 2022
@Dawntraoz
Copy link
Contributor Author

cc @josietyleung @eitjuh

@Dawntraoz Dawntraoz self-assigned this May 24, 2022
@Dawntraoz Dawntraoz linked a pull request May 27, 2022 that will close this issue
@Dawntraoz Dawntraoz linked a pull request Jun 13, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant