Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speaking error if the extension is not unlocked #70

Open
faboweb opened this issue Apr 25, 2022 · 1 comment
Open

Speaking error if the extension is not unlocked #70

faboweb opened this issue Apr 25, 2022 · 1 comment
Assignees
Labels
good first issue Good for newcomers

Comments

@faboweb
Copy link
Contributor

faboweb commented Apr 25, 2022

Describe the bug
A clear and concise description of what the bug is.

When the extension is locked, some commands just fail or show weird errors.

To Reproduce
Steps to reproduce the behavior:

  • have a locked extension (by i.e. reloading it in brave://extensions/)
  • execute a signing command

Expected behavior
A clear and concise description of what you expected to happen.

The commands should open the extension and prompt the user to unlock it.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here. (OS/Browser/Any other information)

@faboweb faboweb added the good first issue Good for newcomers label Apr 25, 2022
@faboweb
Copy link
Contributor Author

faboweb commented Apr 25, 2022

A bit more complicated. Could hook into the background entry point where enable is also handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants