Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install with composer on symfony 4 #14

Open
zoomtronic opened this issue Jan 15, 2020 · 4 comments
Open

Can't install with composer on symfony 4 #14

zoomtronic opened this issue Jan 15, 2020 · 4 comments

Comments

@zoomtronic
Copy link
Contributor

Hi !

Trying to install your bundle and i came across this error with composer
emmedy/h5p-bundle dev-master requires symfony/framework-bundle ~2.7|~3.0 -> no matching package found.

Is it possible to change those values in your composer.json to a minimum requierement instead of a maximum of 3.0 ?

Thanks :)

@nieck
Copy link
Member

nieck commented Jan 16, 2020

Hi, which version of Symfony are you using?

I currently use 3.4. Symfony 4 is not tested with this bundle. So I cannot just change the maximum version in the composer file.

But you are free to fork the project, update composer.json and test it with Symfony 4.

@zoomtronic
Copy link
Contributor Author

Hi,

I'm on symfony 4 but I found a bundle working on sf4 & 5,
https://github.com/jorisdugue/h5p-bundle

@nieck
Copy link
Member

nieck commented Jan 23, 2020

Thanks, I was not aware of the existence of that bundle. This guy just copied my code and changed 'emmedy' to his own name. So he didn't make a fork. That's not how Github is supposed to be used i think.

He forgot the license file btw :D

I will merge his changes later, but you're free to use that repo of course.

@jorisdugue
Copy link
Contributor

Hi @nieck

I just update the package for symfony 4 and 5 and fix many bug.

For information I did a fork but the time to do my test (private repository) it totally crashed on git... x)

And I did not forget the license as you saw it is present on the repository 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants