Fix tests and update readme example #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 28, 2024 22:38
Several dataframe attributes were dropped in 2018 hence they should be removed from the docs
The date parsing arguments are about to be removed from pandas read_csv. Using pd.to_datetime should be future-ready.
|
Hello @JrtPec , let me know if you have a problem with me self-merging these changes? There is no change in functionality, just some fixes to the existing ones |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the following changes:
It also seems like knmi added another H to HH in the data output, despite not zero-padding these numbers in the csv output. Therefore, the YYYYMMDD_H index was renamed to YYYYMMDD_HH
Do let me know if you see any problems with this approach.
This closes #16 and #17 and fixes the tests.