Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Crafting does not save NBT properly #1260

Open
ArcticRaven opened this issue Apr 5, 2021 · 1 comment
Open

Custom Crafting does not save NBT properly #1260

ArcticRaven opened this issue Apr 5, 2021 · 1 comment
Labels
status:pending Pending acceptance or closure. type:bug Incorrect behavior, not working as intended version:five Issue related to CB5

Comments

@ArcticRaven
Copy link

Versions

CraftBook version: 3.10.3;4680-f1ee2df AND 5.0.0;4696-73809ea
Bukkit version: PurPur-1022

Describe the bug
Item NBT data is not being saved properly when using custom crafting. It CAN store that information before the server restarts, however after restarting, it only saves name and lore. This prevents items from retaining custommodeldata, and custom NBT attributes on items.

To Reproduce

  1. Create recipe with the resulting item having custom NBT flags
  2. Restart the server
  3. Attempt to craft that custom item and the data is gone.

Expected behavior
I would expect that this information would continue to be applicable for items - this makes Craftbook much more integral and compatible with other resources and custom items, so its a very important feature (at least, to me)

Screenshots
image
This is the item as it should be:
image
And this is the resulting item after restarting the server:
image

Additional context
The custom item in the example is using MMOItems - however all of that item data is attached to the item itself, which shouldn't cause issues like this. There was an issue with this before back in 2014 - however with ProtocolLib and many other updates and resources coming to fruition since that last report - I feel that this should really be revisited.

@ArcticRaven ArcticRaven added status:pending Pending acceptance or closure. type:bug Incorrect behavior, not working as intended labels Apr 5, 2021
@me4502
Copy link
Member

me4502 commented Apr 6, 2021

As discussed in Discord, this is due to limitations in the Spigot API, and cannot be resolved until CB5 where we will drop Spigot support and require Paper. This still is waiting on multiple Paper and WorldEdit changes, however.

@me4502 me4502 added the version:five Issue related to CB5 label Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:pending Pending acceptance or closure. type:bug Incorrect behavior, not working as intended version:five Issue related to CB5
Projects
None yet
Development

No branches or pull requests

2 participants