Force IPv4 ping in start-automated-server.bat #4044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ping does not respond with a TTL if the server responds with an IPv6 address. This essentially means that the script will think the user does not have internet, if they have a public IPv6 address. Forcing IPv4 in the ping command, ensures TTL gets returned, and the startup can proceed. Closes EnigmaticaModpacks#4043
|
Thanks for the fix, but I've decided to remedy the issue by removing the check entirely 👍 |
NielsPilgaard
added a commit
that referenced
this pull request
Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping does not respond with a TTL if the server responds with an IPv6 address. This essentially means that the script will think the user does not have internet, if they have a public IPv6 address. Forcing IPv4 in
the ping command, ensures TTL gets returned, and the startup can proceed.
As far as I could see, the bash script did not have that same check, so I reckon it should not be necessary to make a fix there.
Closes #4043