Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option to ignore match threshold for partial matches #109

Open
ojalaquellueva opened this issue Feb 6, 2024 · 2 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@ojalaquellueva
Copy link
Member

ojalaquellueva commented Feb 6, 2024

If a species name cannot be matched, the TNRS may still return a partial match on the genus. For some users this is a useful feature. However, because partial matches will generally have low overall match scores due to the unmatched epithets and possibly authors, the default match threshold of 0.53 often causes partial matches to be hidden, even when the partial match is a perfect match, at rank.

To address this issue, I suggest we add a new option "Allow partial matches below threshold". This would be a On/Off toggle button below the Sources option. Default setting would be off. If set to on, the match threshold filter would be applied only to results that do not contain the string "%partial%" in the plain English warning column. Partial matches would not be filtered.

@ojalaquellueva ojalaquellueva added the enhancement New feature or request label Feb 6, 2024
@ojalaquellueva
Copy link
Member Author

See related closed issue #105 for details.

@ojalaquellueva
Copy link
Member Author

Just realized: this feature can only be implemented in TNRSweb interface, as it depends on the value of Match Threshold set by the user. It will require developing an alternative function which ignores match_threshold if warnings LIKE "%partial%" (or the equivalent integer values in the integer warnings columns; may run faster using an IN list of integer values).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants