") unless element.parent&.name == "div"
div = element.parent
- div['class'] = 'op-uc-figure--content'
+ div["class"] = "op-uc-figure--content"
end
end
end
diff --git a/lib/open_project/text_formatting/filters/link_attribute_filter.rb b/lib/open_project/text_formatting/filters/link_attribute_filter.rb
index 524b0c574876..0cafb12a650a 100644
--- a/lib/open_project/text_formatting/filters/link_attribute_filter.rb
+++ b/lib/open_project/text_formatting/filters/link_attribute_filter.rb
@@ -31,7 +31,7 @@ module Filters
class LinkAttributeFilter < HTML::Pipeline::Filter
def call
links.each do |node|
- node['target'] = context.fetch(:target, '_top')
+ node["target"] = context.fetch(:target, "_top")
end
doc
diff --git a/lib/open_project/text_formatting/filters/macro_filter.rb b/lib/open_project/text_formatting/filters/macro_filter.rb
index 578eb8d3d1a4..782b44cf55b7 100644
--- a/lib/open_project/text_formatting/filters/macro_filter.rb
+++ b/lib/open_project/text_formatting/filters/macro_filter.rb
@@ -38,7 +38,7 @@ def self.register(*macros)
end
def call
- doc.search('macro').each do |macro|
+ doc.search("macro").each do |macro|
registered.each do |macro_class|
next unless macro_applies?(macro_class, macro)
@@ -69,19 +69,19 @@ def macro_error_placeholder(macro_class, message)
ApplicationController.helpers.content_tag :macro,
"#{I18n.t(:macro_execution_error,
macro_name: macro_class.identifier)} (#{message})",
- class: 'macro-unavailable',
+ class: "macro-unavailable",
data: { macro_name: macro_class.identifier }
end
def macro_placeholder(macro_class)
ApplicationController.helpers.content_tag :macro,
- I18n.t('macros.placeholder', macro_name: macro_class.identifier),
- class: 'macro-placeholder',
+ I18n.t("macros.placeholder", macro_name: macro_class.identifier),
+ class: "macro-placeholder",
data: { macro_name: macro_class.identifier }
end
def macro_applies?(macro_class, element)
- ((element['class'] || '').split & Array(macro_class.identifier)).any?
+ ((element["class"] || "").split & Array(macro_class.identifier)).any?
end
end
end
diff --git a/lib/open_project/text_formatting/filters/macros/child_pages.rb b/lib/open_project/text_formatting/filters/macros/child_pages.rb
index a552eeb03e5a..e9b4c7dcc8d3 100644
--- a/lib/open_project/text_formatting/filters/macros/child_pages.rb
+++ b/lib/open_project/text_formatting/filters/macros/child_pages.rb
@@ -28,7 +28,7 @@
module OpenProject::TextFormatting::Filters::Macros
module ChildPages
- HTML_CLASS = 'child_pages'.freeze
+ HTML_CLASS = "child_pages".freeze
module_function
@@ -48,7 +48,7 @@ def insert_child_pages(macro, pipeline_context)
end
def is?(macro)
- macro['class'].include?(HTML_CLASS)
+ macro["class"].include?(HTML_CLASS)
end
def render_tree(include_parent, page)
diff --git a/lib/open_project/text_formatting/filters/macros/child_pages/child_pages_context.rb b/lib/open_project/text_formatting/filters/macros/child_pages/child_pages_context.rb
index de750eaf6705..01376e5beb83 100644
--- a/lib/open_project/text_formatting/filters/macros/child_pages/child_pages_context.rb
+++ b/lib/open_project/text_formatting/filters/macros/child_pages/child_pages_context.rb
@@ -31,15 +31,15 @@ class ChildPagesContext
attr_reader(:page_value, :include_parent, :user, :page)
def initialize(macro, pipeline_context)
- @page_value = macro['data-page']
- @include_parent = macro['data-include-parent'].to_s == 'true'
+ @page_value = macro["data-page"]
+ @include_parent = macro["data-include-parent"].to_s == "true"
@user = pipeline_context[:current_user]
@page = fetch_page(pipeline_context)
end
def check
if @page.nil? || !@user.allowed_in_project?(:view_wiki_pages, @page.wiki.project)
- raise I18n.t('macros.wiki_child_pages.errors.page_not_found', name: @page_value)
+ raise I18n.t("macros.wiki_child_pages.errors.page_not_found", name: @page_value)
end
end
diff --git a/lib/open_project/text_formatting/filters/macros/create_work_package_link.rb b/lib/open_project/text_formatting/filters/macros/create_work_package_link.rb
index 9303fe32d45c..767dcadde080 100644
--- a/lib/open_project/text_formatting/filters/macros/create_work_package_link.rb
+++ b/lib/open_project/text_formatting/filters/macros/create_work_package_link.rb
@@ -32,7 +32,7 @@ class << self
include OpenProject::StaticRouting::UrlHelpers
end
- HTML_CLASS = 'create_work_package_link'.freeze
+ HTML_CLASS = "create_work_package_link".freeze
module_function
@@ -46,29 +46,29 @@ def apply(macro, result:, context:)
def work_package_link(macro, context)
project = context[:project]
- raise I18n.t('macros.create_work_package_link.errors.no_project_context') if project.nil?
+ raise I18n.t("macros.create_work_package_link.errors.no_project_context") if project.nil?
- type_name = macro['data-type']
- class_name = macro['data-classes'] == 'button' ? 'button' : nil
+ type_name = macro["data-type"]
+ class_name = macro["data-classes"] == "button" ? "button" : nil
if type_name.present?
type = project.types.find_by(name: type_name)
if type.nil?
raise I18n.t(
- 'macros.create_work_package_link.errors.invalid_type',
+ "macros.create_work_package_link.errors.invalid_type",
type: type_name,
project: project.name
)
end
ApplicationController.helpers.link_to(
- I18n.t('macros.create_work_package_link.link_name_type', type_name:),
+ I18n.t("macros.create_work_package_link.link_name_type", type_name:),
new_project_work_packages_path(project_id: project.identifier, type: type.id),
class: class_name
)
else
ApplicationController.helpers.link_to(
- I18n.t('macros.create_work_package_link.link_name'),
+ I18n.t("macros.create_work_package_link.link_name"),
new_project_work_packages_path(project_id: project.identifier),
class: class_name
)
diff --git a/lib/open_project/text_formatting/filters/macros/embedded_table.rb b/lib/open_project/text_formatting/filters/macros/embedded_table.rb
index bd24d0a37471..23b898a03a2d 100644
--- a/lib/open_project/text_formatting/filters/macros/embedded_table.rb
+++ b/lib/open_project/text_formatting/filters/macros/embedded_table.rb
@@ -28,8 +28,8 @@
module OpenProject::TextFormatting::Filters::Macros
module EmbeddedTable
- CUSTOM_ELEMENT = 'opce-macro-embedded-table'.freeze
- HTML_CLASS = 'embedded-table'.freeze
+ CUSTOM_ELEMENT = "opce-macro-embedded-table".freeze
+ HTML_CLASS = "embedded-table".freeze
module_function
@@ -39,11 +39,11 @@ def identifier
def apply(macro, **)
macro.name = CUSTOM_ELEMENT
- macro['class'] = macro['class'].gsub('op-uc-placeholder', '').squish
+ macro["class"] = macro["class"].gsub("op-uc-placeholder", "").squish
end
def is?(macro)
- macro['class'].include?(HTML_CLASS)
+ macro["class"].include?(HTML_CLASS)
end
end
end
diff --git a/lib/open_project/text_formatting/filters/macros/include_wiki_page.rb b/lib/open_project/text_formatting/filters/macros/include_wiki_page.rb
index 7e0f07bc7373..d08778b6d740 100644
--- a/lib/open_project/text_formatting/filters/macros/include_wiki_page.rb
+++ b/lib/open_project/text_formatting/filters/macros/include_wiki_page.rb
@@ -28,7 +28,7 @@
module OpenProject::TextFormatting::Filters::Macros
module IncludeWikiPage
- HTML_CLASS = 'include_wiki_page'.freeze
+ HTML_CLASS = "include_wiki_page".freeze
module_function
@@ -37,7 +37,7 @@ def identifier
end
def apply(*)
- raise I18n.t('macros.include_wiki_page.removed')
+ raise I18n.t("macros.include_wiki_page.removed")
end
end
end
diff --git a/lib/open_project/text_formatting/filters/macros/toc.rb b/lib/open_project/text_formatting/filters/macros/toc.rb
index f3285c54ff58..ae6898543088 100644
--- a/lib/open_project/text_formatting/filters/macros/toc.rb
+++ b/lib/open_project/text_formatting/filters/macros/toc.rb
@@ -28,7 +28,7 @@
module OpenProject::TextFormatting::Filters::Macros
module Toc
- HTML_CLASS = 'toc'.freeze
+ HTML_CLASS = "toc".freeze
module_function
@@ -37,7 +37,7 @@ def identifier
end
def apply(macro, result:, context:)
- raise 'The HTML::Pipeline::TableOfContentsFilters needs to run before.' unless result[:toc]
+ raise "The HTML::Pipeline::TableOfContentsFilters needs to run before." unless result[:toc]
macro.replace(result[:toc])
end
diff --git a/lib/open_project/text_formatting/filters/mention_filter.rb b/lib/open_project/text_formatting/filters/mention_filter.rb
index bed2223d97dc..7cec5461df1c 100644
--- a/lib/open_project/text_formatting/filters/mention_filter.rb
+++ b/lib/open_project/text_formatting/filters/mention_filter.rb
@@ -35,7 +35,7 @@ class MentionFilter < HTML::Pipeline::Filter
include OpenProject::StaticRouting::UrlHelpers
def call
- doc.search('mention').each do |mention|
+ doc.search("mention").each do |mention|
anchor = mention_anchor(mention)
mention.replace(anchor) if anchor
end
@@ -63,28 +63,28 @@ def mention_anchor(mention)
def user_mention(user)
link_to_user(user,
only_path: context[:only_path],
- class: 'user-mention')
+ class: "user-mention")
end
def group_mention(group)
link_to_group(group,
only_path: context[:only_path],
- class: 'user-mention')
+ class: "user-mention")
end
def work_package_mention(work_package)
link_to("##{work_package.id}",
work_package_path_or_url(id: work_package.id, only_path: context[:only_path]),
- class: 'issue work_package preview-trigger')
+ class: "issue work_package preview-trigger")
end
def class_from_mention(mention)
- mention_class = case mention.attributes['data-type'].value
- when 'user'
+ mention_class = case mention.attributes["data-type"].value
+ when "user"
User
- when 'group'
+ when "group"
Group
- when 'work_package'
+ when "work_package"
WorkPackage
else
raise ArgumentError
@@ -97,7 +97,7 @@ def class_from_mention(mention)
def controller; end
def mention_id(mention)
- attribute_value = mention.attributes['data-id']&.value
+ attribute_value = mention.attributes["data-id"]&.value
id_match = attribute_value&.match(/\d+/)
diff --git a/lib/open_project/text_formatting/filters/pattern_matcher_filter.rb b/lib/open_project/text_formatting/filters/pattern_matcher_filter.rb
index 1bc20b093894..45bea7695166 100644
--- a/lib/open_project/text_formatting/filters/pattern_matcher_filter.rb
+++ b/lib/open_project/text_formatting/filters/pattern_matcher_filter.rb
@@ -41,7 +41,7 @@ def self.matchers
end
def call
- doc.search('.//text()').each do |node|
+ doc.search(".//text()").each do |node|
next if has_ancestor?(node, PREFORMATTED_BLOCKS)
self.class.matchers.each do |matcher|
diff --git a/lib/open_project/text_formatting/filters/relative_link_filter.rb b/lib/open_project/text_formatting/filters/relative_link_filter.rb
index 171e7a085111..e4b2a1b30f26 100644
--- a/lib/open_project/text_formatting/filters/relative_link_filter.rb
+++ b/lib/open_project/text_formatting/filters/relative_link_filter.rb
@@ -37,7 +37,7 @@ def call
rewriter = ::OpenProject::TextFormatting::Helpers::LinkRewriter.new context
doc.css('a[href^="/"]').each do |node|
- node['href'] = rewriter.replace node['href']
+ node["href"] = rewriter.replace node["href"]
end
doc
diff --git a/lib/open_project/text_formatting/filters/sanitization_filter.rb b/lib/open_project/text_formatting/filters/sanitization_filter.rb
index 730080eb5865..e6179fbac5d7 100644
--- a/lib/open_project/text_formatting/filters/sanitization_filter.rb
+++ b/lib/open_project/text_formatting/filters/sanitization_filter.rb
@@ -38,22 +38,22 @@ def allowlist
attributes: base[:attributes].deep_merge(
# Whitelist class and data-* attributes on all macros
- 'macro' => ['class', :data],
+ "macro" => ["class", :data],
# mentions
- 'mention' => %w[data-type data-text data-id class],
+ "mention" => %w[data-type data-text data-id class],
# add styles to tables
- 'figure' => %w[class style],
+ "figure" => %w[class style],
# allow inline image styles
- 'img' => %w[src alt longdesc style],
- 'table' => ['style'],
- 'th' => ['style'],
- 'tr' => ['style'],
- 'td' => ['style']
+ "img" => %w[src alt longdesc style],
+ "table" => ["style"],
+ "th" => ["style"],
+ "tr" => ["style"],
+ "td" => ["style"]
),
# Add rel attribute to prevent tabnabbing
add_attributes: {
- 'a' => { 'rel' => 'noopener noreferrer' }
+ "a" => { "rel" => "noopener noreferrer" }
},
# Add custom transformer logic for more complex modifications
@@ -80,14 +80,14 @@ def todo_list_transformer
name = env[:node_name]
table = env[:node]
- next unless name == 'table'
+ next unless name == "table"
# Support both the old css ('todo-list__label') as well as the new one
# ('op-uc-list_task-list').
- table.css('label.todo-list__label, .op-uc-list_task-list label').each do |label|
+ table.css("label.todo-list__label, .op-uc-list_task-list label").each do |label|
# table.css('.op-uc-list_task-list label').each do |label|
- checkbox = label.css('input[type=checkbox]').first
- li_node = label.ancestors.detect { |node| node.name == 'li' }
+ checkbox = label.css("input[type=checkbox]").first
+ li_node = label.ancestors.detect { |node| node.name == "li" }
# assign all children of the label to its parent
# that might be the LI, or another element (code, link)
@@ -103,7 +103,7 @@ def todo_list_transformer
to_add = li_node == parent ? label.children : parent
li_node.add_child to_add
else
- checked = checkbox.attr('checked') == 'checked' ? 'x' : ' '
+ checked = checkbox.attr("checked") == "checked" ? "x" : " "
checkbox.unlink
# Ensure the task list text is be added as first child to the LI
@@ -127,11 +127,11 @@ def code_block_transformer
name = env[:node_name]
code = env[:node]
- next unless name == 'code'
+ next unless name == "code"
parent = code.parent
- if parent&.name == 'pre'
+ if parent&.name == "pre"
parent.children = code.children
end
}
diff --git a/lib/open_project/text_formatting/filters/setting_macros_filter.rb b/lib/open_project/text_formatting/filters/setting_macros_filter.rb
index 6de5724ea397..4c12fd5613e4 100644
--- a/lib/open_project/text_formatting/filters/setting_macros_filter.rb
+++ b/lib/open_project/text_formatting/filters/setting_macros_filter.rb
@@ -49,7 +49,7 @@ def call
html.gsub(self.class.regexp) do |matched_string|
variable = ($1.presence || $2.presence).dup
- variable.delete!('\\')
+ variable.delete!("\\")
if ALLOWED_SETTINGS.include?(variable)
send variable
@@ -66,7 +66,7 @@ def host_name
end
def base_url
- url_helpers.root_url.chomp('/')
+ url_helpers.root_url.chomp("/")
end
def url_helpers
@@ -76,7 +76,7 @@ def url_helpers
##
# Faster inclusion check before the regex is being applied
def applicable?
- html.include?('{{opSetting:') || html.include?('%7B%7BopSetting:')
+ html.include?("{{opSetting:") || html.include?("%7B%7BopSetting:")
end
end
end
diff --git a/lib/open_project/text_formatting/filters/table_of_contents_filter.rb b/lib/open_project/text_formatting/filters/table_of_contents_filter.rb
index eb5b5cb3c04a..68c9426eb5ef 100644
--- a/lib/open_project/text_formatting/filters/table_of_contents_filter.rb
+++ b/lib/open_project/text_formatting/filters/table_of_contents_filter.rb
@@ -36,17 +36,17 @@ class TableOfContentsFilter < HTML::Pipeline::TableOfContentsFilter
def initialize(doc, context = nil, result = nil)
super(doc, context, result)
- @headings ||= doc.css('h1, h2, h3, h4, h5, h6')
+ @headings ||= doc.css("h1, h2, h3, h4, h5, h6")
@ids = Set.new
end
def add_header_link(node, id)
link = content_tag(:a,
- '',
- class: 'op-uc-link_permalink icon-link',
- 'aria-hidden': true,
+ "",
+ class: "op-uc-link_permalink icon-link",
+ "aria-hidden": true,
href: "##{id}")
- node['id'] = id
+ node["id"] = id
node.add_child(link)
end
@@ -55,8 +55,8 @@ def add_header_link(node, id)
def get_unique_id(text)
# Build id from text
id = ascii_downcase(text)
- id.gsub!(PUNCTUATION_REGEXP, '') # remove punctuation
- id.tr!(' ', '-') # replace spaces with dash
+ id.gsub!(PUNCTUATION_REGEXP, "") # remove punctuation
+ id.tr!(" ", "-") # replace spaces with dash
while ids.add?(id).nil?
id += SecureRandom.hex(4)
@@ -72,12 +72,12 @@ def get_unique_id(text)
# that prefix is used if it matches the calculated number.
def process_item(node, number)
text = node.text
- return ''.html_safe unless text.present?
+ return "".html_safe unless text.present?
id = get_unique_id(text)
add_header_link(node, id)
- content_tag(:li, class: 'op-uc-toc--list-item') do
+ content_tag(:li, class: "op-uc-toc--list-item") do
anchor_tag(text, number, id)
end
end
@@ -87,7 +87,7 @@ def get_heading_number(parent_number, num_in_level)
end
def render_nested(level = 0, parent_number = "")
- result = ''.html_safe
+ result = "".html_safe
num_in_level = 0
while headings.length > 0
@@ -102,7 +102,7 @@ def render_nested(level = 0, parent_number = "")
result << process_item(node, current_number)
elsif level < node_level
# Render a child list
- result << (content_tag(:ul, class: 'op-uc-toc--list') do
+ result << (content_tag(:ul, class: "op-uc-toc--list") do
render_nested(node_level, num_in_level > 0 ? get_heading_number(parent_number, num_in_level) : "")
end)
elsif level > node_level
@@ -120,7 +120,7 @@ def call
end
def process!
- result[:toc] = content_tag(:nav, class: 'op-uc-toc') do
+ result[:toc] = content_tag(:nav, class: "op-uc-toc") do
if headings.empty?
I18n.t(:label_wiki_toc_empty)
else
@@ -136,9 +136,9 @@ def process!
def anchor_tag(text, number, id)
parsed_text = text.match(Regexp.new("^(#{number}[.)]*)?(.+)$"))
number = parsed_text[1] || number
- number_span = content_tag(:span, number, class: 'op-uc-toc--list-item-number')
- content_span = content_tag(:span, parsed_text[2].strip, class: 'op-uc-toc--list-item-title')
- content_tag(:a, number_span + content_span, href: "##{id}", class: 'op-uc-toc--item-link')
+ number_span = content_tag(:span, number, class: "op-uc-toc--list-item-number")
+ content_span = content_tag(:span, parsed_text[2].strip, class: "op-uc-toc--list-item-title")
+ content_tag(:a, number_span + content_span, href: "##{id}", class: "op-uc-toc--item-link")
end
end
end
diff --git a/lib/open_project/text_formatting/filters/task_list_filter.rb b/lib/open_project/text_formatting/filters/task_list_filter.rb
index 8271c7a4ef8d..f9a01b4f46f6 100644
--- a/lib/open_project/text_formatting/filters/task_list_filter.rb
+++ b/lib/open_project/text_formatting/filters/task_list_filter.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'task_list/filter'
+require "task_list/filter"
module OpenProject::TextFormatting
module Filters
@@ -60,7 +60,7 @@ def filter!
list_items(doc).reverse_each do |li|
next if list_items(li.parent).empty?
- add_css_class(li.parent, 'op-uc-list_task-list')
+ add_css_class(li.parent, "op-uc-list_task-list")
outer, inner =
if p = li.xpath(ItemParaSelector)[0]
diff --git a/lib/open_project/text_formatting/formats/markdown/formatter.rb b/lib/open_project/text_formatting/formats/markdown/formatter.rb
index f494b0022b17..6ba5f1c3d33a 100644
--- a/lib/open_project/text_formatting/formats/markdown/formatter.rb
+++ b/lib/open_project/text_formatting/formats/markdown/formatter.rb
@@ -25,7 +25,7 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'task_list/filter'
+require "task_list/filter"
module OpenProject::TextFormatting::Formats::Markdown
class Formatter < OpenProject::TextFormatting::Formats::BaseFormatter
diff --git a/lib/open_project/text_formatting/formats/markdown/helper.rb b/lib/open_project/text_formatting/formats/markdown/helper.rb
index 096fac1eac8a..2152cedbe9c0 100644
--- a/lib/open_project/text_formatting/formats/markdown/helper.rb
+++ b/lib/open_project/text_formatting/formats/markdown/helper.rb
@@ -49,10 +49,10 @@ def wikitoolbar_for(field_id, **context)
# Pass an optional resource to the CKEditor instance
resource = context.fetch(:resource, {})
- helpers.angular_component_tag 'ckeditor-augmented-textarea',
+ helpers.angular_component_tag "ckeditor-augmented-textarea",
inputs: {
textareaSelector: "##{field_id}",
- editorType: context[:editor_type] || 'full',
+ editorType: context[:editor_type] || "full",
previewContext: context[:preview_context],
resource:,
macros: context.fetch(:macros, true)
diff --git a/lib/open_project/text_formatting/formats/plain/helper.rb b/lib/open_project/text_formatting/formats/plain/helper.rb
index 54cc212f2808..4a0b0b4756e1 100644
--- a/lib/open_project/text_formatting/formats/plain/helper.rb
+++ b/lib/open_project/text_formatting/formats/plain/helper.rb
@@ -30,7 +30,7 @@ module OpenProject::TextFormatting::Formats
module Plain
class Helper
def wikitoolbar_for(*_args)
- ''.html_safe
+ "".html_safe
end
end
end
diff --git a/lib/open_project/text_formatting/helpers/link_rewriter.rb b/lib/open_project/text_formatting/helpers/link_rewriter.rb
index 8994e981f6bc..8ff40a3c6801 100644
--- a/lib/open_project/text_formatting/helpers/link_rewriter.rb
+++ b/lib/open_project/text_formatting/helpers/link_rewriter.rb
@@ -41,7 +41,7 @@ def initialize(context)
##
# Test whether the given URL is relative and we need to replace it
def applicable?(url)
- context[:only_path] == false && url.start_with?('/')
+ context[:only_path] == false && url.start_with?("/")
end
##
diff --git a/lib/open_project/text_formatting/matchers/attribute_macros.rb b/lib/open_project/text_formatting/matchers/attribute_macros.rb
index c232313ca50b..74aeba28f599 100644
--- a/lib/open_project/text_formatting/matchers/attribute_macros.rb
+++ b/lib/open_project/text_formatting/matchers/attribute_macros.rb
@@ -47,7 +47,7 @@ def self.regexp
##
# Faster inclusion check before the regex is being applied
def self.applicable?(content)
- content.include?('Label:') || content.include?('Value:')
+ content.include?("Label:") || content.include?("Value:")
end
def self.process_match(m, _matched_string, _context)
@@ -60,7 +60,7 @@ def self.process_match(m, _matched_string, _context)
type = m[2].downcase
ApplicationController.helpers.content_tag "opce-macro-attribute-#{type}",
- '',
+ "",
data: macro_attributes
end
end
diff --git a/lib/open_project/text_formatting/matchers/link_handlers/colon_separator.rb b/lib/open_project/text_formatting/matchers/link_handlers/colon_separator.rb
index 8d3b74c16138..286827a578e6 100644
--- a/lib/open_project/text_formatting/matchers/link_handlers/colon_separator.rb
+++ b/lib/open_project/text_formatting/matchers/link_handlers/colon_separator.rb
@@ -38,7 +38,7 @@ def self.allowed_prefixes
# Condition: Separator is ':'
# Condition: Prefix is present, checked to be one of the allowed values
def applicable?
- matcher.sep == ':' && valid_prefix? && oid.present?
+ matcher.sep == ":" && valid_prefix? && oid.present?
end
# Documents:
@@ -82,18 +82,18 @@ def oid
def render_version
if project && (version = project.versions.find_by(name: oid))
link_to h(version.name),
- { only_path: context[:only_path], controller: '/versions', action: 'show', id: version },
- class: 'version'
+ { only_path: context[:only_path], controller: "/versions", action: "show", id: version },
+ class: "version"
end
end
def render_commit
if project&.repository &&
- (changeset = Changeset.where(['repository_id = ? AND scmid LIKE ?', project.repository.id, "#{oid}%"]).first)
+ (changeset = Changeset.where(["repository_id = ? AND scmid LIKE ?", project.repository.id, "#{oid}%"]).first)
link_to h("#{matcher.project_prefix}#{matcher.identifier}"),
- { only_path: context[:only_path], controller: '/repositories', action: 'revision', project_id: project,
+ { only_path: context[:only_path], controller: "/repositories", action: "revision", project_id: project,
rev: changeset.identifier },
- class: 'changeset',
+ class: "changeset",
title: truncate_single_line(changeset.comments, length: 100)
end
end
@@ -106,13 +106,13 @@ def render_source
anchor = $5
link_to h("#{matcher.project_prefix}#{matcher.prefix}:#{oid}"),
named_route(:entry_revision_project_repository,
- action: 'entry',
+ action: "entry",
project_id: project.identifier,
repo_path: path.to_s,
rev:,
anchor:,
- format: (matcher.prefix == 'export' ? 'raw' : nil)),
- class: (matcher.prefix == 'export' ? 'source download' : 'source')
+ format: (matcher.prefix == "export" ? "raw" : nil)),
+ class: (matcher.prefix == "export" ? "source download" : "source")
end
end
alias :render_export :render_source
@@ -121,23 +121,23 @@ def render_attachment
attachments = context[:attachments] || context[:object].try(:attachments)
if attachments && attachment = attachments.detect { |a| a.filename == oid }
link_to h(attachment.filename),
- { only_path: context[:only_path], controller: '/attachments', action: 'download', id: attachment },
- class: 'attachment'
+ { only_path: context[:only_path], controller: "/attachments", action: "download", id: attachment },
+ class: "attachment"
end
end
def render_project
p = Project
- .where(['projects.identifier = :s OR LOWER(projects.name) = :s', { s: oid.downcase }])
+ .where(["projects.identifier = :s OR LOWER(projects.name) = :s", { s: oid.downcase }])
.first
if p
- link_to_project(p, { only_path: context[:only_path] }, class: 'project')
+ link_to_project(p, { only_path: context[:only_path] }, class: "project")
end
end
def render_user
if (user = User.find_by(login: oid))
- link_to_user(user, only_path: context[:only_path], class: 'user-mention')
+ link_to_user(user, only_path: context[:only_path], class: "user-mention")
end
end
@@ -145,39 +145,39 @@ def render_document
scope = project ? project.documents : Document
document = scope
.visible
- .where(['LOWER(title) = :s', { s: oid.downcase }])
+ .where(["LOWER(title) = :s", { s: oid.downcase }])
.first
if document
link_to document.title,
{ only_path: context[:only_path],
- controller: '/documents',
- action: 'show',
+ controller: "/documents",
+ action: "show",
id: document.id },
- class: 'document'
+ class: "document"
end
end
def render_meeting
scope = project ? project.meetings : Meeting
meeting = scope
- .where(['LOWER(title) = :s', { s: oid.downcase }])
+ .where(["LOWER(title) = :s", { s: oid.downcase }])
.first
if meeting && meeting.visible?(User.current)
link_to meeting.title,
- { only_path: context[:only_path], controller: '/meetings', action: 'show', id: meeting.id },
- class: 'meeting'
+ { only_path: context[:only_path], controller: "/meetings", action: "show", id: meeting.id },
+ class: "meeting"
end
end
# view is the user-facing name of work package queries
# query is the technical/internal name of the concept
def render_view
- if oid == 'default'
- link_to 'Work packages',
- { controller: 'work_packages', action: 'index', project_id: project.id },
- class: 'query'
+ if oid == "default"
+ link_to "Work packages",
+ { controller: "work_packages", action: "index", project_id: project.id },
+ class: "query"
end
end
end
diff --git a/lib/open_project/text_formatting/matchers/link_handlers/hash_separator.rb b/lib/open_project/text_formatting/matchers/link_handlers/hash_separator.rb
index 2e4fc02d2f2f..bc09f43adf82 100644
--- a/lib/open_project/text_formatting/matchers/link_handlers/hash_separator.rb
+++ b/lib/open_project/text_formatting/matchers/link_handlers/hash_separator.rb
@@ -38,7 +38,7 @@ def self.allowed_prefixes
# Condition: Separator is '#'
# Condition: Prefix is present, checked to be one of the allowed values
def applicable?
- matcher.sep == '#' && valid_prefix? && oid.present?
+ matcher.sep == "#" && valid_prefix? && oid.present?
end
# Examples:
@@ -60,8 +60,8 @@ def render_version
version = Version.find_by(id: oid)
if version
link_to h(version.name),
- { only_path: context[:only_path], controller: '/versions', action: 'show', id: version },
- class: 'version'
+ { only_path: context[:only_path], controller: "/versions", action: "show", id: version },
+ class: "version"
end
end
@@ -69,10 +69,10 @@ def render_document
if document = Document.visible.find_by_id(oid)
link_to document.title,
{ only_path: context[:only_path],
- controller: '/documents',
- action: 'show',
+ controller: "/documents",
+ action: "show",
id: document },
- class: 'document'
+ class: "document"
end
end
@@ -81,24 +81,24 @@ def render_meeting
if meeting&.visible?(User.current)
link_to meeting.title,
{ only_path: context[:only_path],
- controller: '/meetings',
- action: 'show',
+ controller: "/meetings",
+ action: "show",
id: oid },
- class: 'meeting'
+ class: "meeting"
end
end
def render_message
message = Message.includes(:parent).find_by(id: oid)
if message
- link_to_message(message, { only_path: context[:only_path] }, class: 'message')
+ link_to_message(message, { only_path: context[:only_path] }, class: "message")
end
end
def render_project
p = Project.find_by(id: oid)
if p
- link_to_project(p, { only_path: context[:only_path] }, class: 'project')
+ link_to_project(p, { only_path: context[:only_path] }, class: "project")
end
end
@@ -107,7 +107,7 @@ def render_user
if user
link_to_user(user,
only_path: context[:only_path],
- class: 'user-mention')
+ class: "user-mention")
end
end
@@ -117,7 +117,7 @@ def render_group
if group
link_to_group(group,
only_path: context[:only_path],
- class: 'user-mention')
+ class: "user-mention")
end
end
@@ -129,7 +129,7 @@ def render_view
if query
link_to_query(query,
{ only_path: context[:only_path] },
- class: 'query')
+ class: "query")
end
end
end
diff --git a/lib/open_project/text_formatting/matchers/link_handlers/revisions.rb b/lib/open_project/text_formatting/matchers/link_handlers/revisions.rb
index e9a7a312013e..180b6bcd4bca 100644
--- a/lib/open_project/text_formatting/matchers/link_handlers/revisions.rb
+++ b/lib/open_project/text_formatting/matchers/link_handlers/revisions.rb
@@ -34,7 +34,7 @@ class Revisions < Base
# Condition: Separator is r
# Condition: Prefix is nil
def applicable?
- matcher.prefix.nil? && matcher.sep == 'r'
+ matcher.prefix.nil? && matcher.sep == "r"
end
#
@@ -49,9 +49,9 @@ def call
if changeset
link_to(h("#{matcher.project_prefix}r#{matcher.identifier}"),
- { only_path: context[:only_path], controller: '/repositories', action: 'revision', project_id: project,
+ { only_path: context[:only_path], controller: "/repositories", action: "revision", project_id: project,
rev: changeset.revision },
- class: 'changeset',
+ class: "changeset",
title: truncate_single_line(changeset.comments, length: 100))
end
end
diff --git a/lib/open_project/text_formatting/matchers/link_handlers/work_packages.rb b/lib/open_project/text_formatting/matchers/link_handlers/work_packages.rb
index f45fa3668664..fe62c3d2b433 100644
--- a/lib/open_project/text_formatting/matchers/link_handlers/work_packages.rb
+++ b/lib/open_project/text_formatting/matchers/link_handlers/work_packages.rb
@@ -48,8 +48,8 @@ def call
# prohibits links to things like #0123
return if wp_id.to_s != matcher.identifier
- if matcher.sep == '##' || matcher.sep == '###'
- render_work_package_macro(wp_id, detailed: (matcher.sep === '###'))
+ if matcher.sep == "##" || matcher.sep == "###"
+ render_work_package_macro(wp_id, detailed: (matcher.sep === "###"))
else
render_work_package_link(wp_id)
end
@@ -58,15 +58,15 @@ def call
private
def render_work_package_macro(wp_id, detailed: false)
- ApplicationController.helpers.content_tag 'opce-macro-wp-quickinfo',
- '',
+ ApplicationController.helpers.content_tag "opce-macro-wp-quickinfo",
+ "",
data: { id: wp_id, detailed: }
end
def render_work_package_link(wp_id)
link_to("##{wp_id}",
work_package_path_or_url(id: wp_id, only_path: context[:only_path]),
- class: 'issue work_package preview-trigger')
+ class: "issue work_package preview-trigger")
end
end
end
diff --git a/lib/open_project/text_formatting/matchers/wiki_links_matcher.rb b/lib/open_project/text_formatting/matchers/wiki_links_matcher.rb
index fc59e10a8ee9..1d429b95ea56 100644
--- a/lib/open_project/text_formatting/matchers/wiki_links_matcher.rb
+++ b/lib/open_project/text_formatting/matchers/wiki_links_matcher.rb
@@ -138,8 +138,8 @@ def link_from_match
else
wiki_page_id = wiki_page.nil? ? WikiPage.slug(page) : wiki_page.slug
url_for(only_path: context[:only_path],
- controller: '/wiki',
- action: 'show',
+ controller: "/wiki",
+ action: "show",
project_id: project.identifier,
title: wiki_page.nil? ? wiki_title.strip : nil,
id: wiki_page_id,
@@ -148,7 +148,7 @@ def link_from_match
link_to h(wiki_title),
url,
- class: ('wiki-page' + (wiki_page ? '' : ' new'))
+ class: ("wiki-page" + (wiki_page ? "" : " new"))
end
end
end
diff --git a/lib/open_project/text_formatting/renderer.rb b/lib/open_project/text_formatting/renderer.rb
index 031df74c7963..b96f381aedab 100644
--- a/lib/open_project/text_formatting/renderer.rb
+++ b/lib/open_project/text_formatting/renderer.rb
@@ -31,7 +31,7 @@ module Renderer
module_function
def format_text(text, options = {})
- return '' if text.blank?
+ return "" if text.blank?
formatter(plain: options.delete(:plain))
.new(options)
diff --git a/lib/open_project/text_formatting/truncation.rb b/lib/open_project/text_formatting/truncation.rb
index d4ce0da5037f..fbb15996b8cf 100644
--- a/lib/open_project/text_formatting/truncation.rb
+++ b/lib/open_project/text_formatting/truncation.rb
@@ -34,7 +34,7 @@ module Truncation
# Truncates and returns the string as a single line
def truncate_single_line(string, *)
- truncate(string.to_s, *).gsub(%r{[\r\n]+}m, ' ').html_safe
+ truncate(string.to_s, *).gsub(%r{[\r\n]+}m, " ").html_safe
end
end
end
diff --git a/lib/open_project/translations/pluralization_backend.rb b/lib/open_project/translations/pluralization_backend.rb
index 86fb982d9a7f..803b577cde20 100644
--- a/lib/open_project/translations/pluralization_backend.rb
+++ b/lib/open_project/translations/pluralization_backend.rb
@@ -17,7 +17,7 @@
# the l10n files of some eastern european languages
# (e.g. Russian, Hungarian, Polish)
-require 'i18n/backend/pluralization'
+require "i18n/backend/pluralization"
module OpenProject
module Translations
diff --git a/lib/open_project/ui/extensible_tabs.rb b/lib/open_project/ui/extensible_tabs.rb
index 94b367ec4a48..58144496cd43 100644
--- a/lib/open_project/ui/extensible_tabs.rb
+++ b/lib/open_project/ui/extensible_tabs.rb
@@ -58,8 +58,8 @@ def add(key, **entry)
def core_user_tabs
[
{
- name: 'general',
- partial: 'users/general',
+ name: "general",
+ partial: "users/general",
path: ->(params) { edit_user_path(params[:user], tab: :general) },
label: :label_general,
only_if: ->(context) {
@@ -67,36 +67,36 @@ def core_user_tabs
}
},
{
- name: 'memberships',
- partial: 'individual_principals/memberships',
+ name: "memberships",
+ partial: "individual_principals/memberships",
path: ->(params) { edit_user_path(params[:user], tab: :memberships) },
label: :label_project_plural
},
{
- name: 'groups',
- partial: 'users/groups',
+ name: "groups",
+ partial: "users/groups",
path: ->(params) { edit_user_path(params[:user], tab: :groups) },
label: :label_group_plural,
only_if: ->(*) { User.current.admin? && Group.any? }
},
{
- name: 'global_roles',
- partial: 'principals/global_roles',
+ name: "global_roles",
+ partial: "principals/global_roles",
path: ->(params) { edit_user_path(params[:user], tab: :global_roles) },
label: :label_global_roles,
only_if: ->(*) { User.current.admin? }
},
{
- name: 'notifications',
- partial: 'users/notifications',
+ name: "notifications",
+ partial: "users/notifications",
path: ->(params) { edit_user_path(params[:user], tab: :notifications) },
- label: :'notifications.settings.title'
+ label: :"notifications.settings.title"
},
{
- name: 'reminders',
- partial: 'users/reminders',
+ name: "reminders",
+ partial: "users/reminders",
path: ->(params) { edit_user_path(params[:user], tab: :reminders) },
- label: :'reminders.settings.title'
+ label: :"reminders.settings.title"
}
]
end
@@ -105,14 +105,14 @@ def core_user_tabs
def core_placeholder_user_tabs
[
{
- name: 'general',
- partial: 'placeholder_users/general',
+ name: "general",
+ partial: "placeholder_users/general",
path: ->(params) { edit_placeholder_user_path(params[:placeholder_user], tab: :general) },
label: :label_general
},
{
- name: 'memberships',
- partial: 'individual_principals/memberships',
+ name: "memberships",
+ partial: "individual_principals/memberships",
path: ->(params) { edit_placeholder_user_path(params[:placeholder_user], tab: :memberships) },
label: :label_project_plural
}
diff --git a/lib/redmine/ciphering.rb b/lib/redmine/ciphering.rb
index 695fe50ee01a..062d83d438e7 100644
--- a/lib/redmine/ciphering.rb
+++ b/lib/redmine/ciphering.rb
@@ -37,22 +37,22 @@ def encrypt_text(text)
if cipher_key.blank?
text
else
- c = OpenSSL::Cipher.new('aes-256-cbc')
+ c = OpenSSL::Cipher.new("aes-256-cbc")
iv = c.random_iv
c.encrypt
c.key = cipher_key
c.iv = iv
e = c.update(text.to_s)
e << c.final
- 'aes-256-cbc:' + [e, iv].map { |v| Base64.encode64(v).strip }.join('--')
+ "aes-256-cbc:" + [e, iv].map { |v| Base64.encode64(v).strip }.join("--")
end
end
def decrypt_text(text)
if text && match = text.match(/\Aaes-256-cbc:(.+)\Z/)
text = match[1]
- c = OpenSSL::Cipher.new('aes-256-cbc')
- e, iv = text.split('--').map { |s| Base64.decode64(s) }
+ c = OpenSSL::Cipher.new("aes-256-cbc")
+ e, iv = text.split("--").map { |s| Base64.decode64(s) }
c.decrypt
c.key = cipher_key
c.iv = iv
@@ -64,7 +64,7 @@ def decrypt_text(text)
end
def cipher_key
- key = OpenProject::Configuration['database_cipher_key'].to_s
+ key = OpenProject::Configuration["database_cipher_key"].to_s
# With aes-256-cbc chosen to be the cipher,
# keys need to be 32 bytes long. Ruby < 2.4 used to silently truncate the
# key to the desired length but with
diff --git a/lib/redmine/codeset_util.rb b/lib/redmine/codeset_util.rb
index 2a876f921286..81166aa442d7 100644
--- a/lib/redmine/codeset_util.rb
+++ b/lib/redmine/codeset_util.rb
@@ -31,52 +31,52 @@ module CodesetUtil
def self.replace_invalid_utf8(str)
return str if str.nil?
- str.force_encoding('UTF-8')
+ str.force_encoding("UTF-8")
if str.valid_encoding?
str
else
- str.encode('US-ASCII',
+ str.encode("US-ASCII",
invalid: :replace,
undef: :replace,
- replace: '?')
- .encode('UTF-8')
+ replace: "?")
+ .encode("UTF-8")
end
end
def self.to_utf8(str, encoding)
return str if str.nil?
- str.force_encoding('ASCII-8BIT')
+ str.force_encoding("ASCII-8BIT")
if str.empty?
- str.force_encoding('UTF-8')
+ str.force_encoding("UTF-8")
return str
end
- enc = encoding.presence || 'UTF-8'
- if enc.upcase == 'UTF-8'
- str.force_encoding('UTF-8')
+ enc = encoding.presence || "UTF-8"
+ if enc.upcase == "UTF-8"
+ str.force_encoding("UTF-8")
if !str.valid_encoding?
- str = str.encode('US-ASCII', invalid: :replace,
- undef: :replace, replace: '?').encode('UTF-8')
+ str = str.encode("US-ASCII", invalid: :replace,
+ undef: :replace, replace: "?").encode("UTF-8")
end
else
str.force_encoding(enc)
- str = str.encode('UTF-8', invalid: :replace,
- undef: :replace, replace: '?')
+ str = str.encode("UTF-8", invalid: :replace,
+ undef: :replace, replace: "?")
end
str
end
def self.from_utf8(str, encoding)
- str ||= ''
+ str ||= ""
str = str.dup if str.frozen?
- str.force_encoding('UTF-8')
- if encoding.upcase == 'UTF-8'
+ str.force_encoding("UTF-8")
+ if encoding.upcase == "UTF-8"
replace_invalid_utf8(str)
else
str.encode(encoding,
invalid: :replace,
undef: :replace,
- replace: '?')
+ replace: "?")
end
end
end
diff --git a/lib/redmine/diff_table.rb b/lib/redmine/diff_table.rb
index a48fac8c0999..34d9cc87cb7a 100644
--- a/lib/redmine/diff_table.rb
+++ b/lib/redmine/diff_table.rb
@@ -33,7 +33,7 @@ class DiffTable < Array
# Initialize with a Diff file and the type of Diff View
# The type view must be inline or sbs (side_by_side)
- def initialize(type = 'inline')
+ def initialize(type = "inline")
@parsing = false
@added = 0
@removed = 0
@@ -75,7 +75,7 @@ def each_line
end
def inspect
- puts '### DIFF TABLE ###'
+ puts "### DIFF TABLE ###"
puts "file : #{file_name}"
each(&:inspect)
end
@@ -88,7 +88,7 @@ def escapeHTML(line)
end
def diff_for_added_line
- if @type == 'sbs' && @removed > 0 && @added < @removed
+ if @type == "sbs" && @removed > 0 && @added < @removed
self[-(@removed - @added)]
else
diff = Diff.new
@@ -97,20 +97,20 @@ def diff_for_added_line
end
end
- def parse_line(line, _type = 'inline')
- if line[0, 1] == '+'
+ def parse_line(line, _type = "inline")
+ if line[0, 1] == "+"
diff = diff_for_added_line
diff.line_right = line[1..-1]
diff.nb_line_right = @line_num_r
- diff.type_diff_right = 'diff_in'
+ diff.type_diff_right = "diff_in"
@line_num_r += 1
@added += 1
true
- elsif line[0, 1] == '-'
+ elsif line[0, 1] == "-"
diff = Diff.new
diff.line_left = line[1..-1]
diff.nb_line_left = @line_num_l
- diff.type_diff_left = 'diff_out'
+ diff.type_diff_left = "diff_out"
self << diff
@line_num_l += 1
@removed += 1
@@ -127,7 +127,7 @@ def parse_line(line, _type = 'inline')
@line_num_l += 1
@line_num_r += 1
true
- elsif line[0, 1] = '\\'
+ elsif line[0, 1] = "\\"
true
else
false
@@ -139,7 +139,7 @@ def write_offsets
if @added > 0 && @added == @removed
@added.times do |i|
line = self[-(1 + i)]
- removed = @type == 'sbs' ? line : self[-(1 + @added + i)]
+ removed = @type == "sbs" ? line : self[-(1 + @added + i)]
offsets = offsets(removed.line_left, line.line_right)
removed.offsets = line.offsets = offsets
end
diff --git a/lib/redmine/gmail.rb b/lib/redmine/gmail.rb
index 8040f1a7e0f3..f02399654bcd 100644
--- a/lib/redmine/gmail.rb
+++ b/lib/redmine/gmail.rb
@@ -1,5 +1,5 @@
-require 'google/apis/gmail_v1'
-require 'googleauth'
+require "google/apis/gmail_v1"
+require "googleauth"
module Redmine
module Gmail
@@ -12,7 +12,7 @@ def check(gmail_options = {}, options = {})
gmail = Google::Apis::GmailV1::GmailService.new
gmail.authorization = authenticate(credentials, username)
- gmail.list_user_messages('me', q: query, max_results: gmail_options[:max_emails]).messages.each do |message|
+ gmail.list_user_messages("me", q: query, max_results: gmail_options[:max_emails]).messages.each do |message|
receive(message.id, gmail, gmail_options, options)
end
end
@@ -28,7 +28,7 @@ def authenticate(credentials, user_id)
end
def receive(message_id, gmail, gmail_options, options)
- email = gmail.get_user_message('me', message_id, format: "raw")
+ email = gmail.get_user_message("me", message_id, format: "raw")
msg = email.raw
raise "Messages was not successfully handled." unless MailHandler.receive(msg, options)
@@ -42,7 +42,7 @@ def receive(message_id, gmail, gmail_options, options)
def message_received(message_id, gmail, _gmail_options)
log_debug { "Message #{message_id} successfully received" }
- modify_request = Google::Apis::GmailV1::ModifyThreadRequest.new(remove_label_ids: ['UNREAD'])
+ modify_request = Google::Apis::GmailV1::ModifyThreadRequest.new(remove_label_ids: ["UNREAD"])
gmail.modify_message("me", message_id, modify_request)
end
@@ -50,7 +50,7 @@ def message_error(message_id, gmail, gmail_options)
log_debug { "Message #{message_id} can not be processed" }
if gmail_options[:read_on_failure]
- modify_request = Google::Apis::GmailV1::ModifyThreadRequest.new(remove_label_ids: ['UNREAD'])
+ modify_request = Google::Apis::GmailV1::ModifyThreadRequest.new(remove_label_ids: ["UNREAD"])
gmail.modify_message("me", message_id, modify_request)
end
end
diff --git a/lib/redmine/helpers/diff.rb b/lib/redmine/helpers/diff.rb
index 1f4919fcacdf..fadd8d47de40 100644
--- a/lib/redmine/helpers/diff.rb
+++ b/lib/redmine/helpers/diff.rb
@@ -36,9 +36,9 @@ class Diff
def initialize(content_to, content_from)
@words = content_to.to_s.split(/(\s+)/)
- @words = @words.select { |word| word != ' ' }
+ @words = @words.select { |word| word != " " }
words_from = content_from.to_s.split(/(\s+)/)
- words_from = words_from.select { |word| word != ' ' }
+ words_from = words_from.select { |word| word != " " }
@diff = words_from.diff @words
end
@@ -52,16 +52,16 @@ def to_html
add_at = nil
add_to = nil
del_at = nil
- deleted = ''
+ deleted = ""
diff.each do |change|
pos = change[1]
- if change[0] == '+'
+ if change[0] == "+"
add_at ||= pos + dels
add_to = pos + dels
words_add += 1
else
del_at ||= pos
- deleted << (' ' + h(change[2]))
+ deleted << (" " + h(change[2]))
words_del += 1
end
end
@@ -69,7 +69,7 @@ def to_html
words[add_at] =
('').html_safe + words[add_at]
words[add_to] =
- words[add_to] + ('').html_safe
+ words[add_to] + ('").html_safe
end
if del_at
@@ -77,13 +77,13 @@ def to_html
WorkPackage.human_attribute_name(:begin_deletion) +
'').html_safe + deleted +
('').html_safe
+ WorkPackage.human_attribute_name(:end_deletion) + "").html_safe
dels += 1
del_off += words_del
words_del = 0
end
end
- words.join(' ')
+ words.join(" ")
end
def additions
diff --git a/lib/redmine/imap.rb b/lib/redmine/imap.rb
index 2fdf0f0e8338..77293bb34c61 100644
--- a/lib/redmine/imap.rb
+++ b/lib/redmine/imap.rb
@@ -26,17 +26,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'net/imap'
+require "net/imap"
module Redmine
module IMAP
class << self
def check(imap_options = {}, options = {})
- folder = imap_options[:folder].presence || 'INBOX'
+ folder = imap_options[:folder].presence || "INBOX"
imap = connect_imap(imap_options)
imap.select(folder)
- imap.search(['NOT', 'SEEN']).each do |message_id|
+ imap.search(["NOT", "SEEN"]).each do |message_id|
receive(message_id, imap, imap_options, options)
end
@@ -46,8 +46,8 @@ def check(imap_options = {}, options = {})
private
def connect_imap(imap_options)
- host = imap_options[:host] || '127.0.0.1'
- port = imap_options[:port] || '143'
+ host = imap_options[:host] || "127.0.0.1"
+ port = imap_options[:port] || "143"
verify_mode = imap_options[:ssl_verification] ? OpenSSL::SSL::VERIFY_PEER : OpenSSL::SSL::VERIFY_NONE
ssl_params =
if imap_options[:ssl]
@@ -64,7 +64,7 @@ def connect_imap(imap_options)
end
def receive(message_id, imap, imap_options, options)
- msg = imap.fetch(message_id, 'RFC822')[0].attr['RFC822']
+ msg = imap.fetch(message_id, "RFC822")[0].attr["RFC822"]
raise "Message was not successfully handled." unless MailHandler.receive(msg, options)
message_received(message_id, imap, imap_options)
@@ -80,17 +80,17 @@ def message_received(message_id, imap, imap_options)
imap.copy(message_id, imap_options[:move_on_success])
end
- imap.store(message_id, '+FLAGS', %i[Seen Deleted])
+ imap.store(message_id, "+FLAGS", %i[Seen Deleted])
end
def message_error(message_id, imap, imap_options)
log_debug { "Message #{message_id} can not be processed" }
- imap.store(message_id, '+FLAGS', [:Seen])
+ imap.store(message_id, "+FLAGS", [:Seen])
if imap_options[:move_on_failure]
imap.copy(message_id, imap_options[:move_on_failure])
- imap.store(message_id, '+FLAGS', [:Deleted])
+ imap.store(message_id, "+FLAGS", [:Deleted])
end
end
diff --git a/lib/redmine/menu_manager/menu_controller.rb b/lib/redmine/menu_manager/menu_controller.rb
index af8bb8b06756..4a01365c19d3 100644
--- a/lib/redmine/menu_manager/menu_controller.rb
+++ b/lib/redmine/menu_manager/menu_controller.rb
@@ -53,7 +53,7 @@ def menu_item(id, options = {})
end
def current_menu_item(actions = :default, &block)
- raise ArgumentError '#current_menu_item requires a block' unless block
+ raise ArgumentError "#current_menu_item requires a block" unless block
if actions == :default
menu_items[controller_path.to_sym][:default] = block
@@ -80,7 +80,7 @@ def current_menu_item
elsif @current_menu_item.is_a?(Proc)
@current_menu_item.call(self)
else
- raise ArgumentError 'Invalid'
+ raise ArgumentError "Invalid"
end
@current_menu_item_determined = true
diff --git a/lib/redmine/menu_manager/menu_helper.rb b/lib/redmine/menu_manager/menu_helper.rb
index 842087b135d0..5a94f02ad66b 100644
--- a/lib/redmine/menu_manager/menu_helper.rb
+++ b/lib/redmine/menu_manager/menu_helper.rb
@@ -61,14 +61,14 @@ def render_menu(menu, project = nil)
end
first_level = any_item_selected?(select_leafs(menu_items)) || !current_menu_item_part_of_menu?(menu, project)
- classes = first_level ? 'open' : 'closed'
+ classes = first_level ? "open" : "closed"
if links.present?
- content_tag('ul',
+ content_tag("ul",
safe_join(links, "\n"),
class: "menu_root #{classes}",
data: {
- 'menus--main-target': 'root'
+ "menus--main-target": "root"
})
end
end
@@ -105,7 +105,7 @@ def render_menu_dropdown(label_node, options = {}, &)
content_tag :li, class: "op-app-menu--item op-app-menu--item_has-dropdown #{options[:menu_item_class]}" do
concat(label_node)
concat(content_tag(:ul,
- style: 'display:none',
+ style: "display:none",
id: options[:drop_down_id],
class: "op-app-menu--dropdown #{options.fetch(:drop_down_class, '')}",
&))
@@ -114,11 +114,11 @@ def render_menu_dropdown(label_node, options = {}, &)
def render_drop_down_label_node(label, selected, options = {})
options[:title] ||= selected ? t(:description_current_position) + label : label
- options[:aria] = { haspopup: 'true' }
+ options[:aria] = { haspopup: "true" }
options[:class] = "op-app-menu--item-action #{options[:class]} #{selected ? 'selected' : ''}"
options[:span_class] = "op-app-menu--item-title #{options[:span_class]}"
- link_to('#', options) do
+ link_to("#", options) do
concat(op_icon(options[:icon])) if options[:icon]
concat(you_are_here_info(selected).html_safe)
concat(content_tag(:span, label, class: options[:span_class]))
@@ -127,7 +127,7 @@ def render_drop_down_label_node(label, selected, options = {})
end
def render_menu_node(node, project = nil)
- return '' unless allowed_node?(node, User.current, project)
+ return "" unless allowed_node?(node, User.current, project)
if node.has_children? || !node.child_menus.nil?
render_menu_node_with_children(node, project)
@@ -150,7 +150,7 @@ def render_menu_node_with_children(node, project = nil)
def render_wrapped_menu_parent_node(node, project)
html_id = node.html_options[:id] || node.name
- content_tag(:div, class: 'main-item-wrapper', id: "#{html_id}-wrapper") do
+ content_tag(:div, class: "main-item-wrapper", id: "#{html_id}-wrapper") do
concat render_single_menu_node(node, project)
concat render_menu_toggler
end
@@ -158,16 +158,16 @@ def render_wrapped_menu_parent_node(node, project)
def render_wrapped_single_node(node, project)
html_id = node.html_options[:id] || node.name
- content_tag(:div, class: 'main-item-wrapper', id: "#{html_id}-wrapper") do
+ content_tag(:div, class: "main-item-wrapper", id: "#{html_id}-wrapper") do
render_single_menu_node(node, project)
end
end
def render_menu_toggler
content_tag(:button,
- class: 'toggler main-menu-toggler',
+ class: "toggler main-menu-toggler",
type: :button,
- data: { action: 'menus--main#descend' }) do
+ data: { action: "menus--main#descend" }) do
render(Primer::Beta::Octicon.new("arrow-right", size: :small))
end
end
@@ -180,7 +180,7 @@ def render_visible_children_list(node, project)
if items.present?
capture do
concat render_children_menu_header(node, project)
- concat content_tag(:ul, safe_join(items, "\n"), class: 'main-menu--children')
+ concat content_tag(:ul, safe_join(items, "\n"), class: "main-menu--children")
end
end
end
@@ -191,7 +191,7 @@ def render_unattached_children_list(node, project)
if items.present?
capture do
concat render_children_menu_header(node, project)
- concat content_tag(:ul, items, class: 'main-menu--children unattached')
+ concat content_tag(:ul, items, class: "main-menu--children unattached")
end
end
end
@@ -199,9 +199,9 @@ def render_unattached_children_list(node, project)
def render_children_menu_header(node, project)
caption, url, = extract_node_details(node, project)
- content_tag(:div, class: 'main-menu--children-menu-header') do
+ content_tag(:div, class: "main-menu--children-menu-header") do
concat render_children_back_up_link(node)
- concat link_to(caption, url, class: 'main-menu--parent-node ellipsis')
+ concat link_to(caption, url, class: "main-menu--parent-node ellipsis")
end
end
@@ -209,41 +209,41 @@ def render_children_back_up_link(node)
content_tag(
:a,
render(Primer::Beta::Octicon.new("arrow-left", size: :small)),
- title: I18n.t('js.label_up'),
- class: 'main-menu--arrow-left-to-project',
+ title: I18n.t("js.label_up"),
+ class: "main-menu--arrow-left-to-project",
data: {
- action: 'menus--main#ascend',
- 'tour-selector': "main-menu--arrow-left_#{node.name}"
+ action: "menus--main#ascend",
+ "tour-selector": "main-menu--arrow-left_#{node.name}"
}
)
end
# rubocop:disable Metrics/AbcSize
- def render_single_menu_node(item, project = nil, menu_class = 'op-menu')
+ def render_single_menu_node(item, project = nil, menu_class = "op-menu")
caption, url, selected = extract_node_details(item, project)
- link_text = ''.html_safe
- link_text << spot_icon(item.icon, size: '1_25') if item.icon(project).present?
- badge_class = item.badge(project).present? ? " #{menu_class}--item-title_has-badge" : ''
+ link_text = "".html_safe
+ link_text << spot_icon(item.icon, size: "1_25") if item.icon(project).present?
+ badge_class = item.badge(project).present? ? " #{menu_class}--item-title_has-badge" : ""
link_text << content_tag(:span,
class: "#{menu_class}--item-title#{badge_class}",
lang: menu_item_locale(item)) do
- title_text = ''.html_safe + content_tag(:span, caption, class: 'ellipsis') + badge_for(item)
+ title_text = "".html_safe + content_tag(:span, caption, class: "ellipsis") + badge_for(item)
if item.enterprise_feature.present? && !EnterpriseToken.allows_to?(item.enterprise_feature)
- title_text << (''.html_safe + spot_icon('enterprise-addons', size: '1_25', classnames: 'upsale-colored'))
+ title_text << ("".html_safe + spot_icon("enterprise-addons", size: "1_25", classnames: "upsale-colored"))
end
title_text
end
if item.icon_after.present?
- link_text << (''.html_safe + spot_icon(item.icon_after, size: '1_25', classnames: "trailing-icon"))
+ link_text << ("".html_safe + spot_icon(item.icon_after, size: "1_25", classnames: "trailing-icon"))
end
html_options = item.html_options(selected:)
html_options[:title] ||= selected ? t(:description_current_position) + caption : caption
html_options[:class] = "#{html_options[:class]} #{menu_class}--item-action"
- html_options['data-test-selector'] = "#{menu_class}--item-action"
- html_options['target'] = '_blank' if item.icon_after.present? && item.icon_after == 'external-link'
+ html_options["data-test-selector"] = "#{menu_class}--item-action"
+ html_options["target"] = "_blank" if item.icon_after.present? && item.icon_after == "external-link"
link_to link_text, url, html_options
end
@@ -268,10 +268,10 @@ def first_level_menu_items_for(menu, project = nil, &)
def menu_node_options(node)
{
- class: node_or_children_selected?(node) ? 'open' : nil,
+ class: node_or_children_selected?(node) ? "open" : nil,
data: {
name: node.name,
- 'menus--main-target': 'item'
+ "menus--main-target": "item"
}
}.compact
end
@@ -280,7 +280,7 @@ def menu_node_options(node)
def render_unattached_children_menu(node, project)
return nil unless node.child_menus
- ''.tap do |child_html|
+ "".tap do |child_html|
unattached_children = node.child_menus.call(project)
# Tree nodes support #each so we need to do object detection
if unattached_children.is_a? Array
@@ -288,7 +288,7 @@ def render_unattached_children_menu(node, project)
child_html << content_tag(:li, render_unattached_menu_item(child, project))
end
else
- raise Redmine::MenuManager::MenuError, ':child_menus must be an array of MenuItems'
+ raise Redmine::MenuManager::MenuError, ":child_menus must be an array of MenuItems"
end
end.html_safe
end
@@ -296,7 +296,7 @@ def render_unattached_children_menu(node, project)
def render_unattached_menu_item(menu_item, project)
unless menu_item.is_a? Redmine::MenuManager::MenuItem
raise Redmine::MenuManager::MenuError,
- ':child_menus must be an array of MenuItems'
+ ":child_menus must be an array of MenuItems"
end
if User.current.allowed_in_project?(menu_item.url(project), project)
@@ -314,7 +314,7 @@ def render_single_node_or_partial(node, project)
render_single_menu_node(node, project)
end
- content_tag('li',
+ content_tag("li",
content,
class: "#{node.partial ? 'partial ' : ''}main-menu-item",
data: { name: node.name })
@@ -357,7 +357,7 @@ def node_url(node, project)
case node.url(project)
when NilClass
- '#'
+ "#"
when Hash
engine.url_for(project.nil? ? node.url(project) : { node.param => project }.merge(node.url(project)))
when Symbol
@@ -443,7 +443,7 @@ def node_engine(node)
def no_wiki_menu_item_selected?(item)
no_menu_item_wiki_prefix? &&
- item.name == current_menu_item.to_s.gsub(/^no-menu-item-/, '').to_sym
+ item.name == current_menu_item.to_s.gsub(/^no-menu-item-/, "").to_sym
end
def no_menu_item_wiki_prefix?
@@ -455,10 +455,10 @@ def wiki_prefix?
end
def badge_for(item)
- badge = ''.html_safe
+ badge = "".html_safe
if item.badge(@project).present?
- badge += content_tag('span', I18n.t(item.badge(@project)), class: 'main-item--badge')
+ badge += content_tag("span", I18n.t(item.badge(@project)), class: "main-item--badge")
end
badge
end
diff --git a/lib/redmine/menu_manager/menu_item.rb b/lib/redmine/menu_manager/menu_item.rb
index b194744705d0..4e6c5891959d 100644
--- a/lib/redmine/menu_manager/menu_item.rb
+++ b/lib/redmine/menu_manager/menu_item.rb
@@ -43,7 +43,7 @@ class Redmine::MenuManager::MenuItem < Redmine::MenuManager::TreeNode
def initialize(name, url, options)
raise ArgumentError, "Invalid option :if for menu item '#{name}'" if options[:if] && !options[:if].respond_to?(:call)
raise ArgumentError, "Invalid option :html for menu item '#{name}'" if options[:html] && !options[:html].is_a?(Hash)
- raise ArgumentError, 'Cannot set the :parent to be the same as this item' if options[:parent] == name.to_sym
+ raise ArgumentError, "Cannot set the :parent to be the same as this item" if options[:parent] == name.to_sym
if options[:children] && !options[:children].respond_to?(:call)
raise ArgumentError,
@@ -63,7 +63,7 @@ def initialize(name, url, options)
# Adds a unique class to each menu item based on its name
@html_options[:class] = [
@html_options[:class], "#{@name.to_s.dasherize}-menu-item"
- ].compact.join(' ')
+ ].compact.join(" ")
@parent = options[:parent]
@child_menus = options[:children]
@last = options[:last] || false
@@ -81,7 +81,7 @@ def caption(project = nil)
c = @name.to_s.humanize if c.blank?
c
elsif @caption.nil?
- l_or_humanize(name, prefix: 'label_')
+ l_or_humanize(name, prefix: "label_")
else
@caption.is_a?(Symbol) ? I18n.t(@caption) : @caption
end
@@ -145,7 +145,7 @@ def skip_permissions_check?
def html_options(options = {})
if options[:selected]
o = @html_options.dup
- o[:class] += ' selected'
+ o[:class] += " selected"
o
else
@html_options
@@ -153,7 +153,7 @@ def html_options(options = {})
end
def add_condition(new_condition)
- raise ArgumentError, 'Condition needs to be callable' unless new_condition.respond_to?(:call)
+ raise ArgumentError, "Condition needs to be callable" unless new_condition.respond_to?(:call)
old_condition = @condition
@condition = if old_condition.respond_to?(:call)
diff --git a/lib/redmine/menu_manager/top_menu/help_menu.rb b/lib/redmine/menu_manager/top_menu/help_menu.rb
index bc3d8ab98a70..61368f1ffc15 100644
--- a/lib/redmine/menu_manager/top_menu/help_menu.rb
+++ b/lib/redmine/menu_manager/top_menu/help_menu.rb
@@ -28,16 +28,16 @@
module Redmine::MenuManager::TopMenu::HelpMenu
def render_help_top_menu_node(item = help_menu_item)
- cache_key = ['help_top_menu_node',
+ cache_key = ["help_top_menu_node",
OpenProject::Static::Links.links,
I18n.locale,
OpenProject::Static::Links.help_link,
EnterpriseToken.active?]
OpenProject::Cache.fetch(cache_key) do
if OpenProject::Static::Links.help_link_overridden?
- content_tag('li',
- render_single_menu_node(item, nil, 'op-app-menu'),
- class: 'op-app-menu--item op-app-help op-app-help_overridden')
+ content_tag("li",
+ render_single_menu_node(item, nil, "op-app-menu"),
+ class: "op-app-menu--item op-app-help op-app-help_overridden")
else
render_help_dropdown
end
@@ -45,19 +45,19 @@ def render_help_top_menu_node(item = help_menu_item)
end
def render_help_dropdown
- link_to_help_pop_up = link_to '#',
+ link_to_help_pop_up = link_to "#",
title: I18n.t(:label_help),
- class: 'op-app-menu--item-action',
- aria: { haspopup: 'true' } do
- spot_icon('help', size: '1_25', classnames: 'op-app-help--icon')
+ class: "op-app-menu--item-action",
+ aria: { haspopup: "true" } do
+ spot_icon("help", size: "1_25", classnames: "op-app-help--icon")
end
render_menu_dropdown(
link_to_help_pop_up,
- menu_item_class: 'op-app-help hidden-for-mobile',
- drop_down_class: 'op-menu'
+ menu_item_class: "op-app-help hidden-for-mobile",
+ drop_down_class: "op-menu"
) do
- result = ''.html_safe
+ result = "".html_safe
render_onboarding result
render_help_and_support result
render_additional_resources result
@@ -69,36 +69,36 @@ def render_help_dropdown
private
def render_onboarding(result)
- result << content_tag(:li, class: 'op-menu--item') do
- content_tag(:span, I18n.t('top_menu.getting_started'),
- class: 'op-menu--headline',
- title: I18n.t('top_menu.getting_started'))
+ result << content_tag(:li, class: "op-menu--item") do
+ content_tag(:span, I18n.t("top_menu.getting_started"),
+ class: "op-menu--headline",
+ title: I18n.t("top_menu.getting_started"))
end
result << render_onboarding_menu_item
- result << content_tag(:hr, '', class: 'op-menu--separator')
+ result << content_tag(:hr, "", class: "op-menu--separator")
end
def render_onboarding_menu_item
- controller.render_to_string(partial: 'onboarding/menu_item')
+ controller.render_to_string(partial: "onboarding/menu_item")
end
def render_help_and_support(result)
- result << content_tag(:li, class: 'op-menu--item') do
- content_tag :span, I18n.t('top_menu.help_and_support'),
- class: 'op-menu--headline',
- title: I18n.t('top_menu.help_and_support')
+ result << content_tag(:li, class: "op-menu--item") do
+ content_tag :span, I18n.t("top_menu.help_and_support"),
+ class: "op-menu--headline",
+ title: I18n.t("top_menu.help_and_support")
end
if EnterpriseToken.show_banners?
result << static_link_item(:upsale,
href_suffix: "/?utm_source=unknown&utm_medium=op-instance&utm_campaign=ee-upsale-help-menu")
end
result << static_link_item(:user_guides)
- result << content_tag(:li, class: 'op-menu--item') do
- link_to I18n.t('label_videos'),
+ result << content_tag(:li, class: "op-menu--item") do
+ link_to I18n.t("label_videos"),
OpenProject::Configuration.youtube_channel,
- title: I18n.t('label_videos'),
- class: 'op-menu--item-action',
- target: '_blank', rel: 'noopener'
+ title: I18n.t("label_videos"),
+ class: "op-menu--item-action",
+ target: "_blank", rel: "noopener"
end
result << static_link_item(:shortcuts)
result << static_link_item(:forums)
@@ -108,15 +108,15 @@ def render_help_and_support(result)
:enterprise_support_as_community
end
result << static_link_item(enterprise_support_link_key)
- result << content_tag(:hr, '', class: 'op-menu--separator')
+ result << content_tag(:hr, "", class: "op-menu--separator")
end
def render_additional_resources(result)
- result << content_tag(:li, class: 'op-menu--item') do
+ result << content_tag(:li, class: "op-menu--item") do
content_tag :span,
- I18n.t('top_menu.additional_resources'),
- class: 'op-menu--headline',
- title: I18n.t('top_menu.additional_resources')
+ I18n.t("top_menu.additional_resources"),
+ class: "op-menu--headline",
+ title: I18n.t("top_menu.additional_resources")
end
if OpenProject::Static::Links.has? :impressum
@@ -144,12 +144,12 @@ def render_additional_resources(result)
def static_link_item(key, options = {})
link = OpenProject::Static::Links.links[key]
label = I18n.t(link[:label])
- content_tag(:li, class: 'op-menu--item') do
+ content_tag(:li, class: "op-menu--item") do
link_to label,
"#{link[:href]}#{options[:href_suffix]}",
title: label,
- target: '_blank',
- class: 'op-menu--item-action', rel: 'noopener'
+ target: "_blank",
+ class: "op-menu--item-action", rel: "noopener"
end
end
end
diff --git a/lib/redmine/menu_manager/top_menu/projects_menu.rb b/lib/redmine/menu_manager/top_menu/projects_menu.rb
index 6a4bad3039a3..6669dae3e249 100644
--- a/lib/redmine/menu_manager/top_menu/projects_menu.rb
+++ b/lib/redmine/menu_manager/top_menu/projects_menu.rb
@@ -28,8 +28,8 @@
module Redmine::MenuManager::TopMenu::ProjectsMenu
def render_projects_top_menu_node
- return '' if User.current.anonymous? and Setting.login_required?
- return '' if User.current.anonymous? and User.current.number_of_known_projects.zero?
+ return "" if User.current.anonymous? and Setting.login_required?
+ return "" if User.current.anonymous? and User.current.number_of_known_projects.zero?
render_projects_dropdown
end
@@ -37,8 +37,8 @@ def render_projects_top_menu_node
private
def render_projects_dropdown
- content_tag(:li, class: 'op-app-menu--item') do
- angular_component_tag('op-header-project-select')
+ content_tag(:li, class: "op-app-menu--item") do
+ angular_component_tag("op-header-project-select")
end
end
diff --git a/lib/redmine/menu_manager/top_menu/quick_add_menu.rb b/lib/redmine/menu_manager/top_menu/quick_add_menu.rb
index b7ea71177219..4ba20e17838d 100644
--- a/lib/redmine/menu_manager/top_menu/quick_add_menu.rb
+++ b/lib/redmine/menu_manager/top_menu/quick_add_menu.rb
@@ -39,16 +39,16 @@ def render_quick_add_menu
def render_quick_add_dropdown
render_menu_dropdown_with_items(
- label: '',
+ label: "",
label_options: {
- title: I18n.t('menus.quick_add.label'),
- icon: 'icon-add op-quick-add-menu--icon',
- class: 'op-quick-add-menu--button'
+ title: I18n.t("menus.quick_add.label"),
+ icon: "icon-add op-quick-add-menu--icon",
+ class: "op-quick-add-menu--button"
},
items: first_level_menu_items_for(:quick_add_menu, @project),
options: {
- drop_down_id: 'quick-add-menu',
- menu_item_class: 'op-quick-add-menu'
+ drop_down_id: "quick-add-menu",
+ menu_item_class: "op-quick-add-menu"
},
project: @project
) do
@@ -61,7 +61,7 @@ def render_quick_add_dropdown
def work_package_quick_add_items
return unless any_types?
- concat content_tag(:hr, '', class: 'op-menu--separator')
+ concat content_tag(:hr, "", class: "op-menu--separator")
concat work_package_type_heading
visible_types
@@ -73,10 +73,10 @@ def work_package_quick_add_items
end
def work_package_type_heading
- content_tag(:li, class: 'op-menu--item') do
+ content_tag(:li, class: "op-menu--item") do
content_tag :span,
I18n.t(:label_work_package_plural),
- class: 'op-menu--headline'
+ class: "op-menu--headline"
end
end
@@ -91,7 +91,7 @@ def visible_types
end
def work_package_create_link(type_id, type_name)
- content_tag(:li, class: 'op-menu--item') do
+ content_tag(:li, class: "op-menu--item") do
if in_project_context?
link_to type_name,
new_project_work_packages_path(project_id: @project.identifier, type: type_id),
diff --git a/lib/redmine/menu_manager/top_menu_helper.rb b/lib/redmine/menu_manager/top_menu_helper.rb
index 7552fffacfb6..1a8f5498bda5 100644
--- a/lib/redmine/menu_manager/top_menu_helper.rb
+++ b/lib/redmine/menu_manager/top_menu_helper.rb
@@ -32,7 +32,7 @@ module Redmine::MenuManager::TopMenuHelper
include Redmine::MenuManager::TopMenu::QuickAddMenu
def render_top_menu_left
- content_tag :ul, class: 'op-app-menu op-app-menu_drop-left' do
+ content_tag :ul, class: "op-app-menu op-app-menu_drop-left" do
safe_join top_menu_left_menu_items
end
end
@@ -44,24 +44,24 @@ def top_menu_left_menu_items
end
def render_top_menu_center
- content_tag :div, class: 'op-logo' do
- mode_class = User.current.pref.high_contrast_theme? ? 'op-logo--link_high_contrast' : ''
- link_to(I18n.t('label_home'),
+ content_tag :div, class: "op-logo" do
+ mode_class = User.current.pref.high_contrast_theme? ? "op-logo--link_high_contrast" : ""
+ link_to(I18n.t("label_home"),
configurable_home_url,
class: "op-logo--link #{mode_class}")
end
end
def render_top_menu_search
- content_tag :div, class: 'op-app-search' do
+ content_tag :div, class: "op-app-search" do
render_global_search_input
end
end
def render_global_search_input
- angular_component_tag 'opce-global-search',
+ angular_component_tag "opce-global-search",
inputs: {
- placeholder: I18n.t('global_search.placeholder', app_title: Setting.app_title)
+ placeholder: I18n.t("global_search.placeholder", app_title: Setting.app_title)
}
end
@@ -73,7 +73,7 @@ def render_top_menu_right
end
def top_menu_right_node
- content_tag(:ul, class: 'op-app-menu') do
+ content_tag(:ul, class: "op-app-menu") do
safe_join top_menu_right_menu_items
end
end
@@ -88,11 +88,11 @@ def top_menu_right_menu_items
private
def render_notification_top_menu_node
- return ''.html_safe unless User.current.logged?
- return ''.html_safe if Setting.notifications_hidden?
+ return "".html_safe unless User.current.logged?
+ return "".html_safe if Setting.notifications_hidden?
- content_tag('li', class: 'op-app-menu--item', title: I18n.t('mail.notification.center')) do
- angular_component_tag 'op-in-app-notification-bell',
+ content_tag("li", class: "op-app-menu--item", title: I18n.t("mail.notification.center")) do
+ angular_component_tag "op-in-app-notification-bell",
inputs: {
interval: Setting.notifications_polling_interval
}
@@ -110,26 +110,26 @@ def render_user_top_menu_node(items = first_level_menu_items_for(:account_menu))
end
def render_login_drop_down
- url = { controller: '/account', action: 'login' }
+ url = { controller: "/account", action: "login" }
link = link_to url,
- class: 'op-app-menu--item-action',
+ class: "op-app-menu--item-action",
title: I18n.t(:label_login) do
- concat content_tag(:span, I18n.t(:label_login), class: 'op-app-menu--item-title hidden-for-mobile')
- concat content_tag(:i, '', class: 'op-app-menu--item-dropdown-indicator button--dropdown-indicator hidden-for-mobile')
- concat content_tag(:i, '', class: 'icon2 icon-user hidden-for-desktop')
+ concat content_tag(:span, I18n.t(:label_login), class: "op-app-menu--item-title hidden-for-mobile")
+ concat content_tag(:i, "", class: "op-app-menu--item-dropdown-indicator button--dropdown-indicator hidden-for-mobile")
+ concat content_tag(:i, "", class: "icon2 icon-user hidden-for-desktop")
end
- render_menu_dropdown(link, menu_item_class: '') do
+ render_menu_dropdown(link, menu_item_class: "") do
render_login_partial
end
end
def render_direct_login
link = link_to signin_path,
- class: 'op-app-menu--item-action login',
+ class: "op-app-menu--item-action login",
title: I18n.t(:label_login) do
- concat content_tag(:span, I18n.t(:label_login), class: 'op-app-menu--item-title hidden-for-mobile')
- concat content_tag(:i, '', class: 'icon2 icon-user hidden-for-desktop')
+ concat content_tag(:span, I18n.t(:label_login), class: "op-app-menu--item-title hidden-for-mobile")
+ concat content_tag(:i, "", class: "icon2 icon-user hidden-for-desktop")
end
content_tag :li, class: "" do
@@ -138,25 +138,25 @@ def render_direct_login
end
def render_user_drop_down(items)
- avatar = avatar(User.current, class: 'op-top-menu-user-avatar')
+ avatar = avatar(User.current, class: "op-top-menu-user-avatar")
render_menu_dropdown_with_items(
- label: avatar.presence || '',
+ label: avatar.presence || "",
label_options: {
title: User.current.name,
- class: 'op-top-menu-user',
- icon: (avatar.present? ? 'overridden-by-avatar' : 'icon-user')
+ class: "op-top-menu-user",
+ icon: (avatar.present? ? "overridden-by-avatar" : "icon-user")
},
items:,
- options: { drop_down_id: 'user-menu', menu_item_class: 'last-child' }
+ options: { drop_down_id: "user-menu", menu_item_class: "last-child" }
)
end
def render_login_partial
partial =
if OpenProject::Configuration.disable_password_login?
- 'account/omniauth_login'
+ "account/omniauth_login"
else
- 'account/login'
+ "account/login"
end
render partial:
@@ -165,10 +165,10 @@ def render_login_partial
def render_module_top_menu_node(items = more_top_menu_items)
unless items.empty?
render_menu_dropdown_with_items(
- label: '',
- label_options: { icon: 'icon-menu', title: I18n.t('label_modules') },
+ label: "",
+ label_options: { icon: "icon-menu", title: I18n.t("label_modules") },
items:,
- options: { drop_down_id: 'more-menu', drop_down_class: 'drop-down--modules ', menu_item_class: 'hidden-for-mobile' }
+ options: { drop_down_id: "more-menu", drop_down_class: "drop-down--modules ", menu_item_class: "hidden-for-mobile" }
)
end
end
@@ -176,7 +176,7 @@ def render_module_top_menu_node(items = more_top_menu_items)
def render_main_top_menu_nodes(items = main_top_menu_items)
items.map do |item|
render_menu_node(item)
- end.join(' ')
+ end.join(" ")
end
# Menu items for the main top menu
diff --git a/lib/redmine/menu_manager/tree_node.rb b/lib/redmine/menu_manager/tree_node.rb
index 840ac44edb82..cbf977f9d313 100644
--- a/lib/redmine/menu_manager/tree_node.rb
+++ b/lib/redmine/menu_manager/tree_node.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'tree' # gem install rubytree
+require "tree" # gem install rubytree
class Redmine::MenuManager::TreeNode < Tree::TreeNode
attr_reader :last_items_count
@@ -40,7 +40,7 @@ def initialize(name, content = nil)
# parent is set to be the receiver. The child is added as the first child in
# the current list of children for the receiver node.
def prepend(child)
- raise(ArgumentError, 'Child already added') if @children_hash.has_key?(child.name)
+ raise(ArgumentError, "Child already added") if @children_hash.has_key?(child.name)
@children_hash[child.name] = child
@children = [child] + @children
@@ -52,7 +52,7 @@ def prepend(child)
# parent is set to be the receiver. The child is added at the position
# into the current list of children for the receiver node.
def add_at(child, position)
- raise(ArgumentError, 'Child already added') if @children_hash.has_key?(child.name)
+ raise(ArgumentError, "Child already added") if @children_hash.has_key?(child.name)
@children_hash[child.name] = child
@children = @children.insert(position, child)
@@ -61,7 +61,7 @@ def add_at(child, position)
end
def add_last(child)
- raise(ArgumentError, 'Child already added') if @children_hash.has_key?(child.name)
+ raise(ArgumentError, "Child already added") if @children_hash.has_key?(child.name)
@children_hash[child.name] = child
@children << child
@@ -74,7 +74,7 @@ def add_last(child)
# parent is set to be the receiver. The child is added as the last child in
# the current list of children for the receiver node.
def add(child)
- raise(ArgumentError, 'Child already added') if @children_hash.has_key?(child.name)
+ raise(ArgumentError, "Child already added") if @children_hash.has_key?(child.name)
@children_hash[key!(child)] = child
position = @children.size - @last_items_count
diff --git a/lib/redmine/menu_manager/wiki_menu_helper.rb b/lib/redmine/menu_manager/wiki_menu_helper.rb
index 7100704410c3..221dd8e5bd48 100644
--- a/lib/redmine/menu_manager/wiki_menu_helper.rb
+++ b/lib/redmine/menu_manager/wiki_menu_helper.rb
@@ -28,7 +28,7 @@
module Redmine::MenuManager::WikiMenuHelper
def build_wiki_menus(project)
- return unless project.enabled_module_names.include? 'wiki'
+ return unless project.enabled_module_names.include? "wiki"
project_wiki = project.wiki
return if project_wiki.nil?
@@ -46,11 +46,11 @@ def build_wiki_menus(project)
def push_wiki_main_menu(menu, main_item, project)
menu.push main_item.menu_identifier,
- { controller: '/wiki', action: 'show', id: main_item.slug },
+ { controller: "/wiki", action: "show", id: main_item.slug },
caption: main_item.title,
after: :meetings,
- icon: 'wiki',
- html: { class: 'wiki-menu--main-item' }
+ icon: "wiki",
+ html: { class: "wiki-menu--main-item" }
if project.wiki.pages.any?
push_wiki_menu_partial(main_item, menu)
@@ -62,9 +62,9 @@ def push_wiki_main_menu(menu, main_item, project)
def push_wiki_menu_subitem(menu, main_item, child)
menu.push child.menu_identifier,
- { controller: '/wiki', action: 'show', id: child.slug },
+ { controller: "/wiki", action: "show", id: child.slug },
caption: child.title,
- html: { class: 'wiki-menu--sub-item' },
+ html: { class: "wiki-menu--sub-item" },
parent: main_item.menu_identifier
rescue ArgumentError => e
Rails.logger.error "Failed to add wiki item #{child.slug} to wiki menu: #{e}. Deleting it."
@@ -93,9 +93,9 @@ def wiki_main_items(wiki)
def push_wiki_menu_partial(main_item, menu)
menu.push :wiki_menu_partial,
- { controller: '/wiki', action: 'show' },
+ { controller: "/wiki", action: "show" },
parent: main_item.menu_identifier,
- partial: 'wiki/menu_pages_tree',
+ partial: "wiki/menu_pages_tree",
last: true
end
end
diff --git a/lib/redmine/platform.rb b/lib/redmine/platform.rb
index 87a54085dae9..d83ab3852073 100644
--- a/lib/redmine/platform.rb
+++ b/lib/redmine/platform.rb
@@ -30,8 +30,8 @@ module Redmine
module Platform
class << self
def mswin?
- (RUBY_PLATFORM =~ /(:?mswin|mingw)/) || (RUBY_PLATFORM == 'java' && (ENV.fetch('OS') do
- ENV.fetch('os', nil)
+ (RUBY_PLATFORM =~ /(:?mswin|mingw)/) || (RUBY_PLATFORM == "java" && (ENV.fetch("OS") do
+ ENV.fetch("os", nil)
end) =~ /windows/i)
end
end
diff --git a/lib/redmine/plugin.rb b/lib/redmine/plugin.rb
index af0cac68c5ae..cea695486dca 100644
--- a/lib/redmine/plugin.rb
+++ b/lib/redmine/plugin.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require Rails.root.join('config/constants/open_project/activity')
+require Rails.root.join("config/constants/open_project/activity")
module Redmine # :nodoc:
class PluginError < StandardError
@@ -79,7 +79,7 @@ class Plugin
@deferred_plugins = {}
cattr_accessor :public_directory
- self.public_directory = Rails.public_path.join('plugin_assets')
+ self.public_directory = Rails.public_path.join("plugin_assets")
class << self
attr_reader :registered_plugins, :deferred_plugins
@@ -240,11 +240,11 @@ def requires_redmine_plugin(plugin_name, arg)
arg.assert_valid_keys(:version, :version_or_higher)
plugin = Plugin.find(plugin_name)
- current = plugin.version.split('.').map(&:to_i)
+ current = plugin.version.split(".").map(&:to_i)
arg.each do |k, v|
v = [] << v unless v.is_a?(Array)
- versions = v.map { |s| s.split('.').map(&:to_i) }
+ versions = v.map { |s| s.split(".").map(&:to_i) }
case k
when :version_or_higher
raise ArgumentError.new("wrong number of versions (#{versions.size} for 1)") unless versions.size == 1
@@ -376,7 +376,7 @@ def project_module(name, options = {}, &)
#
# Note that :view_scrums permission is required to view these events in the activity view.
def activity_provider(*)
- ActiveSupport::Deprecation.warn('Use ActsAsOpEngine#activity_provider instead.')
+ ActiveSupport::Deprecation.warn("Use ActsAsOpEngine#activity_provider instead.")
OpenProject::Activity.register(*)
end
@@ -405,14 +405,14 @@ def mirror_assets
source_files -= source_dirs
unless source_files.empty?
- base_target_dir = File.join(destination, File.dirname(source_files.first).gsub(source, ''))
+ base_target_dir = File.join(destination, File.dirname(source_files.first).gsub(source, ""))
FileUtils.mkdir_p(base_target_dir)
end
source_dirs.each do |dir|
# strip down these paths so we have simple, relative paths we can
# add to the destination
- target_dir = File.join(destination, dir.gsub(source, ''))
+ target_dir = File.join(destination, dir.gsub(source, ""))
begin
FileUtils.mkdir_p(target_dir)
rescue StandardError => e
@@ -421,7 +421,7 @@ def mirror_assets
end
source_files.each do |file|
- target = File.join(destination, file.gsub(source, ''))
+ target = File.join(destination, file.gsub(source, ""))
unless File.exist?(target) && FileUtils.identical?(file, target)
FileUtils.cp(file, target)
end
diff --git a/lib/redmine/pop3.rb b/lib/redmine/pop3.rb
index 90a14fb3ed9a..a8b784f05b94 100644
--- a/lib/redmine/pop3.rb
+++ b/lib/redmine/pop3.rb
@@ -26,27 +26,27 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'net/pop'
+require "net/pop"
module Redmine
module POP3
class << self
def check(pop_options = {}, options = {})
- host = pop_options[:host] || '127.0.0.1'
- port = pop_options[:port] || '110'
- apop = (pop_options[:apop].to_s == '1')
- delete_unprocessed = (pop_options[:delete_unprocessed].to_s == '1')
+ host = pop_options[:host] || "127.0.0.1"
+ port = pop_options[:port] || "110"
+ apop = (pop_options[:apop].to_s == "1")
+ delete_unprocessed = (pop_options[:delete_unprocessed].to_s == "1")
pop = Net::POP3.APOP(apop).new(host, port)
logger.debug "Connecting to #{host}..." if logger && logger.debug?
pop.start(pop_options[:username], pop_options[:password]) do |pop_session|
if pop_session.mails.empty?
- logger.debug 'No email to process' if logger && logger.debug?
+ logger.debug "No email to process" if logger && logger.debug?
else
logger.debug "#{pop_session.mails.size} email(s) to process..." if logger && logger.debug?
pop_session.each_mail do |msg|
message = msg.pop
- message_id = (message =~ /^Message-ID: (.*)/ ? $1 : '').strip
+ message_id = (message =~ /^Message-ID: (.*)/ ? $1 : "").strip
if MailHandler.receive(message, options)
msg.delete
logger.debug "--> Message #{message_id} processed and deleted from the server" if logger && logger.debug?
diff --git a/lib/redmine/unified_diff.rb b/lib/redmine/unified_diff.rb
index 1f7e66e71297..a748835ef06d 100644
--- a/lib/redmine/unified_diff.rb
+++ b/lib/redmine/unified_diff.rb
@@ -34,7 +34,7 @@ class UnifiedDiff < Array
def initialize(diff, options = {})
options.assert_valid_keys(:type, :max_lines)
diff = diff.split("\n") if diff.is_a?(String)
- @diff_type = options[:type] || 'inline'
+ @diff_type = options[:type] || "inline"
lines = 0
@truncated = false
diff_table = DiffTable.new(@diff_type)
@@ -45,7 +45,7 @@ def initialize(diff, options = {})
# TODO: UTF-16 and Japanese CP932 which is incompatible with ASCII
# In Japan, difference between file path encoding
# and file contents encoding is popular.
- line.force_encoding('ASCII-8BIT')
+ line.force_encoding("ASCII-8BIT")
end
unless diff_table.add_line line
line.force_encoding(line_encoding) if line_encoding
diff --git a/lib/redmine/views/other_formats_builder.rb b/lib/redmine/views/other_formats_builder.rb
index 31a62c6232ac..7375670b6737 100644
--- a/lib/redmine/views/other_formats_builder.rb
+++ b/lib/redmine/views/other_formats_builder.rb
@@ -34,12 +34,12 @@ def initialize(view)
end
def link_to(name, options = {})
- return if Setting.table_exists? && !Setting.feeds_enabled? && name == 'Atom'
+ return if Setting.table_exists? && !Setting.feeds_enabled? && name == "Atom"
url = { format: name.to_s.downcase }.merge(options.delete(:url) || {})
caption = options.delete(:caption) || name
- html_options = { class: "icon icon-#{name.to_s.downcase}", rel: 'nofollow' }.merge(options)
- @view.content_tag('span', @view.link_to(caption, url, html_options))
+ html_options = { class: "icon icon-#{name.to_s.downcase}", rel: "nofollow" }.merge(options)
+ @view.content_tag("span", @view.link_to(caption, url, html_options))
end
end
end
diff --git a/lib/tabular_form_builder.rb b/lib/tabular_form_builder.rb
index e7f92f79b2c6..5e1287b5a1af 100644
--- a/lib/tabular_form_builder.rb
+++ b/lib/tabular_form_builder.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'action_view/helpers/form_helper'
-require 'securerandom'
+require "action_view/helpers/form_helper"
+require "securerandom"
class TabularFormBuilder < ActionView::Helpers::FormBuilder
include Redmine::I18n
@@ -44,7 +44,7 @@ def self.tag_with_label_method(selector, &)
input_options, label_options = extract_from options
if field_has_errors?(field)
- input_options[:class] << ' -error'
+ input_options[:class] << " -error"
end
label = label_for_field(field, label_options)
@@ -85,14 +85,14 @@ def label(method, text = nil, options = {}, &)
def date_picker(field, options = {})
options[:class] = Array(options[:class])
- options[:container_class] ||= '-xslim'
+ options[:container_class] ||= "-xslim"
merge_required_attributes(options[:required], options)
options[:visible_overflow] = true
input_options, label_options = extract_from options
if field_has_errors?(field)
- input_options[:class] << ' -error'
+ input_options[:class] << " -error"
end
@object_name.to_s.sub!(/\[\]$/, "") || @object_name.to_s.sub!(/\[\]\]$/, "]")
@@ -103,13 +103,13 @@ def date_picker(field, options = {})
name: field_name(field, index: options[:index])
}
- if options.dig(:data, :'remote-field-key')
- inputs['remote-field-key'] = options.dig(:data, :'remote-field-key')
- inputs[:inputClassNames] = 'remote-field--input'
+ if options.dig(:data, :"remote-field-key")
+ inputs["remote-field-key"] = options.dig(:data, :"remote-field-key")
+ inputs[:inputClassNames] = "remote-field--input"
end
if !options[:show_ignore_non_working_days].nil?
- inputs['show-ignore-non-working-days'] = options[:show_ignore_non_working_days]
+ inputs["show-ignore-non-working-days"] = options[:show_ignore_non_working_days]
end
if options[:required]
@@ -117,7 +117,7 @@ def date_picker(field, options = {})
end
label = label_for_field(field, label_options)
- input = angular_component_tag('op-basic-single-date-picker',
+ input = angular_component_tag("op-basic-single-date-picker",
class: options[:class],
inputs:)
(label + container_wrap_field(input, :date_picker, options))
@@ -130,13 +130,13 @@ def radio_button(field, value, options = {}, *args)
label_options[:for] = "#{sanitized_object_name}_#{field}_#{value.downcase}"
if field_has_errors?(field)
- input_options[:class] << ' -error'
+ input_options[:class] << " -error"
end
label = label_for_field(field, label_options)
input = super(field, value, input_options, *args)
- (label + container_wrap_field(input, 'radio-button', options))
+ (label + container_wrap_field(input, "radio-button", options))
end
def select(field, choices, options = {}, html_options = {})
@@ -146,17 +146,17 @@ def select(field, choices, options = {}, html_options = {})
end
if field_has_errors?(field)
- html_options[:class] << ' -error'
+ html_options[:class] << " -error"
end
merge_required_attributes(options[:required], html_options)
- label_for_field(field, options) + container_wrap_field(super, 'select', options)
+ label_for_field(field, options) + container_wrap_field(super, "select", options)
end
def collection_select(field, collection, value_method, text_method, options = {}, html_options = {})
html_options[:class] = Array(html_options[:class]) + %w(form--select)
- label_for_field(field, options) + container_wrap_field(super, 'select', options)
+ label_for_field(field, options) + container_wrap_field(super, "select", options)
end
def collection_check_box(field,
@@ -166,7 +166,7 @@ def collection_check_box(field,
options = {})
label_for = :"#{sanitized_object_name}_#{field}_#{checked_value}"
- unchecked_value = options.delete(:unchecked_value) { '' }
+ unchecked_value = options.delete(:unchecked_value) { "" }
input_options = options.reverse_merge(multiple: true,
checked:,
@@ -207,17 +207,17 @@ def container_wrap_field(field_html, selector, options = {})
if prefix
ret.prepend content_tag(:span,
prefix.html_safe,
- class: 'form--field-affix',
+ class: "form--field-affix",
id: options[:prefix_id],
- 'aria-hidden': true)
+ "aria-hidden": true)
end
if suffix
ret.concat content_tag(:span,
suffix.html_safe,
- class: 'form--field-affix',
+ class: "form--field-affix",
id: options[:suffix_id],
- 'aria-hidden': true)
+ "aria-hidden": true)
end
field_container_wrap_field(ret, options)
@@ -225,7 +225,7 @@ def container_wrap_field(field_html, selector, options = {})
def merge_required_attributes(required, options = nil)
if required
- options.merge!(required: true, 'aria-required': 'true')
+ options.merge!(required: true, "aria-required": "true")
end
end
@@ -233,14 +233,14 @@ def field_container_wrap_field(field_html, options = {})
if options[:no_label]
field_html
else
- classes = options[:visible_overflow] ? '-visible-overflow' : ''
+ classes = options[:visible_overflow] ? "-visible-overflow" : ""
content_tag(:span, field_html, class: options[:no_class] ? classes : "#{classes} form--field-container")
end
end
def field_container_css_class(selector, options)
classes = if TEXT_LIKE_FIELDS.include?(selector)
- 'form--text-field-container'
+ "form--text-field-container"
else
"form--#{selector.to_s.tr('_', '-')}-container"
end
@@ -253,7 +253,7 @@ def field_container_css_class(selector, options)
##
# Create a wrapper for the text formatting toolbar for this field
def text_formatting_wrapper(target_id, options)
- return ''.html_safe if target_id.blank?
+ return "".html_safe if target_id.blank?
::OpenProject::TextFormatting::Formats
.rich_helper
@@ -271,7 +271,7 @@ def field_css_class(selector)
# Returns a label tag for the given field
def label_for_field(field, options = {})
- return ''.html_safe if options[:no_label]
+ return "".html_safe if options[:no_label]
label_options = {
class: label_for_field_class(options[:class]),
@@ -285,7 +285,7 @@ def label_for_field(field, options = {})
# Render a help text icon
if options[:help_text]
- content << content_tag('attribute-help-text', '', data: options[:help_text])
+ content << content_tag("attribute-help-text", "", data: options[:help_text])
end
label_options[:lang] = options[:lang]
@@ -296,10 +296,10 @@ def label_for_field(field, options = {})
def label_for_field_errors(content, options, field)
if field_has_errors?(field)
- options[:class] << ' -error'
- error_label = I18n.t('errors.field_erroneous_label',
- full_errors: @object.errors.full_messages_for(field).join(' '))
- content << content_tag('p', error_label, class: 'hidden-for-sighted')
+ options[:class] << " -error"
+ error_label = I18n.t("errors.field_erroneous_label",
+ full_errors: @object.errors.full_messages_for(field).join(" "))
+ content << content_tag("p", error_label, class: "hidden-for-sighted")
end
end
@@ -309,7 +309,7 @@ def label_for_field_for(options, label_options, _field)
def label_for_field_prefix(content, options)
if options[:prefix]
- content << content_tag(:span, options[:prefix].html_safe, class: 'hidden-for-sighted')
+ content << content_tag(:span, options[:prefix].html_safe, class: "hidden-for-sighted")
end
end
@@ -349,7 +349,7 @@ def extract_from(options)
if options[:suffix]
options[:suffix_id] ||= SecureRandom.uuid
- input_options[:'aria-describedby'] ||= options[:suffix_id]
+ input_options[:"aria-describedby"] ||= options[:suffix_id]
end
if options[:prefix]
options[:prefix_id] ||= SecureRandom.uuid
@@ -359,7 +359,7 @@ def extract_from(options)
end
def sanitized_object_name
- object_name.to_s.gsub(/\]\[|[^-a-zA-Z0-9:.]/, '_').sub(/_$/, '')
+ object_name.to_s.gsub(/\]\[|[^-a-zA-Z0-9:.]/, "_").sub(/_$/, "")
end
def title_from_context(method)
diff --git a/lib/tasks/api.rake b/lib/tasks/api.rake
index 5e55b6cf1356..1a09e7e5925d 100644
--- a/lib/tasks/api.rake
+++ b/lib/tasks/api.rake
@@ -27,7 +27,7 @@
#++
namespace :api do
- desc 'Print all api routes'
+ desc "Print all api routes"
task routes: [:environment] do
puts <<~HEADER
@@ -40,7 +40,7 @@ namespace :api do
.sort_by { |route| route.path + route.request_method }
.each do |api|
method = api.request_method.ljust(10)
- path = api.path.gsub(/\A\/:version/, "/api/v3").gsub(/\(\/?\.:format\)/, '')
+ path = api.path.gsub(/\A\/:version/, "/api/v3").gsub(/\(\/?\.:format\)/, "")
puts "#{method} #{path}"
end
diff --git a/lib/tasks/assets.rake b/lib/tasks/assets.rake
index cc86882c6741..b2a3ffe3b8d3 100644
--- a/lib/tasks/assets.rake
+++ b/lib/tasks/assets.rake
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'open_project/assets'
+require "open_project/assets"
# The ng build task must run before assets:environment task.
# Otherwise Sprockets cannot find the files that webpack produces.
-Rake::Task['assets:precompile']
+Rake::Task["assets:precompile"]
.clear_prerequisites
.enhance(%w[assets:compile_environment assets:prepare_op])
@@ -38,37 +38,37 @@ namespace :assets do
# In this task, set prerequisites for the assets:precompile task
task compile_environment: :prepare_op do
# Turn the yarn:install task into a noop.
- Rake::Task['yarn:install']
+ Rake::Task["yarn:install"]
.clear
- Rake::Task['assets:environment'].invoke
+ Rake::Task["assets:environment"].invoke
end
- desc 'Prepare locales and angular assets'
+ desc "Prepare locales and angular assets"
task prepare_op: %i[export_locales angular]
- desc 'Compile assets with webpack'
+ desc "Compile assets with webpack"
task :angular do
# We skip angular compilation if backend was requested
# but frontend was not explicitly set
- if ENV['RECOMPILE_RAILS_ASSETS'] == 'true' && ENV['RECOMPILE_ANGULAR_ASSETS'] != 'true'
+ if ENV["RECOMPILE_RAILS_ASSETS"] == "true" && ENV["RECOMPILE_ANGULAR_ASSETS"] != "true"
next
end
OpenProject::Assets.clear!
puts "Linking frontend plugins"
- Rake::Task['openproject:plugins:register_frontend'].invoke
+ Rake::Task["openproject:plugins:register_frontend"].invoke
puts "Building angular frontend"
- Dir.chdir Rails.root.join('frontend') do
+ Dir.chdir Rails.root.join("frontend") do
cmd =
- if ENV['CI']
- 'npm run build:ci'
- elsif ENV['OPENPROJECT_ANGULAR_UGLIFY'] == 'false'
- 'npm run build:fast'
+ if ENV["CI"]
+ "npm run build:ci"
+ elsif ENV["OPENPROJECT_ANGULAR_UGLIFY"] == "false"
+ "npm run build:fast"
else
- 'npm run build'
+ "npm run build"
end
sh(cmd) do |ok, res|
@@ -76,20 +76,20 @@ namespace :assets do
end
end
- Rake::Task['assets:rebuild_manifest'].invoke
+ Rake::Task["assets:rebuild_manifest"].invoke
end
- desc 'Write angular assets manifest'
+ desc "Write angular assets manifest"
task :rebuild_manifest do
puts "Writing angular assets manifest"
OpenProject::Assets.rebuild_manifest!
end
- desc 'Export frontend locale files'
+ desc "Export frontend locale files"
task export_locales: :environment do
puts "Exporting I18n.js locales"
time = Benchmark.realtime do
- I18nJS.call(config_file: Rails.root.join('config/i18n.yml'))
+ I18nJS.call(config_file: Rails.root.join("config/i18n.yml"))
end
puts "=> Done in #{time.round(2)}s"
end
diff --git a/lib/tasks/attachment_migrations.rake b/lib/tasks/attachment_migrations.rake
index caa7f8eaddb9..ad10d18f0a52 100644
--- a/lib/tasks/attachment_migrations.rake
+++ b/lib/tasks/attachment_migrations.rake
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative 'shared/user_feedback'
+require_relative "shared/user_feedback"
-require 'tasks/shared/legacy_attachment'
-require 'tasks/shared/attachment_migration'
+require "tasks/shared/legacy_attachment"
+require "tasks/shared/attachment_migration"
module Migrations
##
@@ -41,7 +41,7 @@ module Migrations
class CurrentWikiPage < ::ActiveRecord::Base
self.table_name = "wiki_pages"
- has_one :content, class_name: 'CurrentWikiContent', foreign_key: 'page_id', dependent: :destroy
+ has_one :content, class_name: "CurrentWikiContent", foreign_key: "page_id", dependent: :destroy
end
class CurrentWikiContent < ::ActiveRecord::Base
@@ -56,12 +56,12 @@ namespace :migrations do
include Tasks::Shared::UserFeedback
include Tasks::Shared::AttachmentMigration
- desc 'Removes all attachments from versions and projects'
+ desc "Removes all attachments from versions and projects"
task delete_from_projects_and_versions: :environment do |_task|
try_delete_attachments_from_projects_and_versions
end
- desc 'Creates special wiki pages for each project and version moving the attachments there.'
+ desc "Creates special wiki pages for each project and version moving the attachments there."
task move_to_wiki: :environment do |_task|
Project.transaction do
if Journal.count > 0
@@ -75,7 +75,7 @@ namespace :migrations do
end
end
- desc 'Moves old attachment files to their correct new path under carrierwave.'
+ desc "Moves old attachment files to their correct new path under carrierwave."
task move_old_files: :environment do |_task|
count = Attachment.count
diff --git a/lib/tasks/attachments.rake b/lib/tasks/attachments.rake
index f8624bf46f3e..bc4c88f73850 100644
--- a/lib/tasks/attachments.rake
+++ b/lib/tasks/attachments.rake
@@ -27,15 +27,15 @@
#++
namespace :attachments do
- desc 'Clear all attachments created before yesterday'
+ desc "Clear all attachments created before yesterday"
task clear: [:environment] do
Attachment.clean_cached_files!
end
- desc 'Copies all attachments from the current to the given storage.'
+ desc "Copies all attachments from the current to the given storage."
task :copy_to, [:to] => :environment do |_task, args|
if args.empty?
- puts 'rake attachments:copy_to[file|fog]'
+ puts "rake attachments:copy_to[file|fog]"
exit 1
end
@@ -56,7 +56,7 @@ namespace :attachments do
if target_uploader == :fog && (
OpenProject::Configuration.fog_credentials.empty? ||
OpenProject::Configuration.fog_directory.nil?)
- puts 'the fog storage is not configured'
+ puts "the fog storage is not configured"
exit 1
end
@@ -68,9 +68,9 @@ namespace :attachments do
STDOUT.flush
if store! attachment
- puts ' ok'
+ puts " ok"
else
- puts ' failed (missing file)'
+ puts " failed (missing file)"
end
end
end
@@ -80,7 +80,7 @@ namespace :attachments do
# which uses the destination uploader to store the original attachment's
# file in the target location.
def self.store!(attachment)
- return nil unless attachment.attributes['file'].present? &&
+ return nil unless attachment.attributes["file"].present? &&
File.exist?(attachment.file.path)
new.tap do |target|
@@ -93,7 +93,7 @@ namespace :attachments do
##
# Pretends to be a plain old Attachment in order not to break store paths.
def self.to_s
- 'attachment'
+ "attachment"
end
end
@@ -106,12 +106,12 @@ namespace :attachments do
target_attachment.store_all! attachments
end
- desc 'Extract text content from attachment that were not extracted yet synchronously.'
+ desc "Extract text content from attachment that were not extracted yet synchronously."
task extract_fulltext_where_missing: :environment do
Attachment.extract_fulltext_where_missing(run_now: true)
end
- desc 'Extract text content from attachment that were not extracted yet.'
+ desc "Extract text content from attachment that were not extracted yet."
task schedule_fulltext_extraction_where_missing: :environment do
Attachment.extract_fulltext_where_missing(run_now: false)
end
diff --git a/lib/tasks/backup.rake b/lib/tasks/backup.rake
index 1b521ca8e959..71d3cbd3f4b3 100644
--- a/lib/tasks/backup.rake
+++ b/lib/tasks/backup.rake
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'pathname'
+require "pathname"
namespace :backup do
namespace :database do
- desc 'Creates a database dump which can be used as a backup.'
+ desc "Creates a database dump which can be used as a backup."
task :create, [:path_to_backup] => [:environment] do |_task, args|
args.with_defaults(path_to_backup: default_db_filename)
Pathname(args[:path_to_backup]).dirname.mkpath
@@ -48,9 +48,9 @@ namespace :backup do
Kernel.system(pg_env, *pg_dump_call)
end
- desc 'Restores a database dump created by the :create task.'
+ desc "Restores a database dump created by the :create task."
task :restore, [:path_to_backup] => [:environment] do |_task, args|
- raise 'You must provide the path to the database dump' unless args[:path_to_backup]
+ raise "You must provide the path to the database dump" unless args[:path_to_backup]
raise "File '#{args[:path_to_backup]}' is not readable" unless File.readable?(args[:path_to_backup])
include OpenProject::PostgresEnvironment
@@ -73,19 +73,19 @@ namespace :backup do
def default_db_filename
filename = "openproject-#{Rails.env}-db-#{date_string}.backup"
- Rails.root.join('backup', sanitize_filename(filename))
+ Rails.root.join("backup", sanitize_filename(filename))
end
def date_string
- Time.now.strftime('%Y%m%dT%H%M%S%z') # e.g. "20141020T165335+0200"
+ Time.now.strftime("%Y%m%dT%H%M%S%z") # e.g. "20141020T165335+0200"
end
def sanitize_filename(filename)
- filename.gsub(/[^0-9A-Za-z.-]/, '_')
+ filename.gsub(/[^0-9A-Za-z.-]/, "_")
end
end
- desc 'Allows user-initiated backups right away, skipping the cooldown period after a new token was created.'
+ desc "Allows user-initiated backups right away, skipping the cooldown period after a new token was created."
task allow_now: :environment do
date = DateTime.now - OpenProject::Configuration.backup_initial_waiting_period
diff --git a/lib/tasks/ciphering.rake b/lib/tasks/ciphering.rake
index 335dabcdfaec..c95a3c13e86d 100644
--- a/lib/tasks/ciphering.rake
+++ b/lib/tasks/ciphering.rake
@@ -27,19 +27,19 @@
#++
namespace :db do
- desc 'Encrypts SCM and LDAP passwords in the database.'
+ desc "Encrypts SCM and LDAP passwords in the database."
task encrypt: :environment do
unless Repository.encrypt_all(:password) &&
LdapAuthSource.encrypt_all(:account_password)
- raise 'Some objects could not be saved after encryption, update was rolled back.'
+ raise "Some objects could not be saved after encryption, update was rolled back."
end
end
- desc 'Decrypts SCM and LDAP passwords in the database.'
+ desc "Decrypts SCM and LDAP passwords in the database."
task decrypt: :environment do
unless Repository.decrypt_all(:password) &&
LdapAuthSource.decrypt_all(:account_password)
- raise 'Some objects could not be saved after decryption, update was rolled back.'
+ raise "Some objects could not be saved after decryption, update was rolled back."
end
end
end
diff --git a/lib/tasks/code.rake b/lib/tasks/code.rake
index d87587a6269f..8f442606495d 100644
--- a/lib/tasks/code.rake
+++ b/lib/tasks/code.rake
@@ -27,18 +27,18 @@
#++
namespace :code do
- desc 'Fix line endings of all source files'
+ desc "Fix line endings of all source files"
task :fix_line_endings do
- Dir.chdir(File.join(File.dirname(__FILE__), '../..')) do
- files = Dir['**/**{.rb,.html.erb,.rhtml,.rjs,.plain.erb,.rxml,.yml,.rake,.eml}']
+ Dir.chdir(File.join(File.dirname(__FILE__), "../..")) do
+ files = Dir["**/**{.rb,.html.erb,.rhtml,.rjs,.plain.erb,.rxml,.yml,.rake,.eml}"]
files.reject! do |f|
- f.include?('lib_static/plugins') ||
- f.include?('lib_static/diff')
+ f.include?("lib_static/plugins") ||
+ f.include?("lib_static/diff")
end
# handle files in chunks of 50 to avoid too long command lines
while (slice = files.slice!(0, 50)).present?
- system('ruby', '-i', '-pe', 'gsub(/\s+\z/,"\n")', *slice)
+ system("ruby", "-i", "-pe", 'gsub(/\s+\z/,"\n")', *slice)
end
end
end
diff --git a/lib/tasks/copyright.rake b/lib/tasks/copyright.rake
index ffa603a4dd89..399cb7e431da 100644
--- a/lib/tasks/copyright.rake
+++ b/lib/tasks/copyright.rake
@@ -30,31 +30,31 @@ namespace :copyright do
def short_copyright(format, options = {})
case format
when :ruby, :rb
- short_copyright_line('#', options)
+ short_copyright_line("#", options)
when :js, :sass, :ts
- short_copyright_line('//', options)
+ short_copyright_line("//", options)
when :css
- short_copyright_surrounding('/*', '*/', options)
+ short_copyright_surrounding("/*", "*/", options)
when :sql
- short_copyright_line('-- ', options)
+ short_copyright_line("-- ", options)
when :erb
- short_copyright_surrounding('<%#', '#%>', options)
+ short_copyright_surrounding("<%#", "#%>", options)
when :rdoc
- "----------\n#{short_copyright_line(' ', options)}\n----------\n".gsub(' -- copyright', "==== copyright\n")
+ "----------\n#{short_copyright_line(' ', options)}\n----------\n".gsub(" -- copyright", "==== copyright\n")
when :md
- short_copyright_surrounding('', options)
+ short_copyright_surrounding("", options)
else
raise "Undefined format #{format}"
end
end
def copyright_file(options = {})
- path = 'COPYRIGHT_short'
+ path = "COPYRIGHT_short"
if options[:path]
- path = File.join(options[:path], 'COPYRIGHT_short') if File.exist?(File.join(options[:path],
- 'COPYRIGHT_short'))
- path = File.join(options[:path], 'COPYRIGHT_short.md') if File.exist?(File.join(options[:path],
- 'COPYRIGHT_short.md'))
+ path = File.join(options[:path], "COPYRIGHT_short") if File.exist?(File.join(options[:path],
+ "COPYRIGHT_short"))
+ path = File.join(options[:path], "COPYRIGHT_short.md") if File.exist?(File.join(options[:path],
+ "COPYRIGHT_short.md"))
end
path
end
@@ -108,12 +108,12 @@ namespace :copyright do
def rewrite_copyright(ending, additional_excludes, format, path, options = {})
regexp = options[:regex] || copyright_regexp(format)
- path = '.' if path.nil?
+ path = "." if path.nil?
copyright = options[:copyright] || short_copyright(format, path:)
file_list = options[:file_list] || Dir[File.absolute_path(path) + "/**/*.#{ending}"]
excluded = exluded_paths.concat(additional_excludes)
- raise 'Path not found' unless Dir.exist?(path)
+ raise "Path not found" unless Dir.exist?(path)
file_list.each do |file_name|
# Skip 3rd party code
@@ -130,135 +130,135 @@ namespace :copyright do
end
end
- desc 'Update special files, which do not have an ending'
+ desc "Update special files, which do not have an ending"
task :update_special_files, :arg1 do |_task, args|
# ruby-like files
file_list = %w{Gemfile Rakefile config.ru .travis.yml .gitignore}.map do |f|
File.absolute_path f
end
- rewrite_copyright('rb', [], :rb, args[:arg1], file_list:)
+ rewrite_copyright("rb", [], :rb, args[:arg1], file_list:)
end
- desc 'Update the copyright on .rb source files'
+ desc "Update the copyright on .rb source files"
task :update_rb, :arg1 do |_task, args|
excluded = (%w(acts_as_tree rfpdf verification).map { |dir| "lib_static/plugins/#{dir}" })
- rewrite_copyright('rb', excluded, :rb, args[:arg1])
+ rewrite_copyright("rb", excluded, :rb, args[:arg1])
end
- desc 'Update the copyright on .rake source files'
+ desc "Update the copyright on .rake source files"
task :update_rake, :arg1 do |_task, args|
- rewrite_copyright('rake', [], :rb, args[:arg1])
+ rewrite_copyright("rake", [], :rb, args[:arg1])
end
- desc 'Update the copyright on .yml source files'
+ desc "Update the copyright on .yml source files"
task :update_yml, :arg1 do |_task, args|
- rewrite_copyright('yml', [], :rb, args[:arg1])
+ rewrite_copyright("yml", [], :rb, args[:arg1])
end
- desc 'Update the copyright on .yml.example source files'
+ desc "Update the copyright on .yml.example source files"
task :update_yml_example, :arg1 do |_task, args|
- rewrite_copyright('yml.example', [], :rb, args[:arg1])
+ rewrite_copyright("yml.example", [], :rb, args[:arg1])
end
- desc 'Update the copyright on .rb.example source files'
+ desc "Update the copyright on .rb.example source files"
task :update_rb_example, :arg1 do |_task, args|
- rewrite_copyright('rb.example', [], :rb, args[:arg1])
+ rewrite_copyright("rb.example", [], :rb, args[:arg1])
end
- desc 'Update the copyright on .rjs source files'
+ desc "Update the copyright on .rjs source files"
task :update_rjs, :arg1 do |_task, args|
- rewrite_copyright('rjs', [], :rb, args[:arg1])
+ rewrite_copyright("rjs", [], :rb, args[:arg1])
end
- desc 'Update the copyright on .feature source files'
+ desc "Update the copyright on .feature source files"
task :update_feature, :arg1 do |_task, args|
- rewrite_copyright('feature', [], :rb, args[:arg1])
+ rewrite_copyright("feature", [], :rb, args[:arg1])
end
- desc 'Update the copyright on .css source files'
+ desc "Update the copyright on .css source files"
task :update_css, :arg1 do |_task, args|
excluded = []
- rewrite_copyright('css', excluded, :css, args[:arg1])
+ rewrite_copyright("css", excluded, :css, args[:arg1])
end
- desc 'Update the copyright on .css.erb source files'
+ desc "Update the copyright on .css.erb source files"
task :update_css_erb, :arg1 do |_task, args|
excluded = []
- rewrite_copyright('css.erb', excluded, :css, args[:arg1])
+ rewrite_copyright("css.erb", excluded, :css, args[:arg1])
end
- desc 'Update the copyright on .sass source files'
+ desc "Update the copyright on .sass source files"
task :update_sass, :arg1 do |_task, args|
excluded = %w(
app/assets/stylesheets/default.css.sass
)
- rewrite_copyright('sass', excluded, :sass, args[:arg1])
+ rewrite_copyright("sass", excluded, :sass, args[:arg1])
end
- desc 'Update the copyright on .sql source files'
+ desc "Update the copyright on .sql source files"
task :update_sql, :arg1 do |_task, args|
- rewrite_copyright('sql', [], :sql, args[:arg1])
+ rewrite_copyright("sql", [], :sql, args[:arg1])
end
- desc 'Update the copyright on .js source files'
+ desc "Update the copyright on .js source files"
task :update_js, :arg1 do |_task, args|
excluded = []
- rewrite_copyright('js', excluded, :js, args[:arg1])
+ rewrite_copyright("js", excluded, :js, args[:arg1])
end
- desc 'Update the copyright on .js.erb source files'
+ desc "Update the copyright on .js.erb source files"
task :update_js_erb, :arg1 do |_task, args|
- excluded = ['app/assets/javascripts/application.js.erb']
+ excluded = ["app/assets/javascripts/application.js.erb"]
- rewrite_copyright('js.erb', excluded, :erb, args[:arg1])
+ rewrite_copyright("js.erb", excluded, :erb, args[:arg1])
end
- desc 'Update the copyright on .rdoc source files'
+ desc "Update the copyright on .rdoc source files"
task :update_rdoc, :arg1 do |_task, args|
- excluded = ['README.rdoc',
- 'LICENSE',
- 'COPYRIGHT',
- 'COPYRIGHT_short']
+ excluded = ["README.rdoc",
+ "LICENSE",
+ "COPYRIGHT",
+ "COPYRIGHT_short"]
- rewrite_copyright('rdoc', excluded, :rdoc, args[:arg1], position: :bottom)
+ rewrite_copyright("rdoc", excluded, :rdoc, args[:arg1], position: :bottom)
end
- desc 'Update the copyright on .html.erb source files'
+ desc "Update the copyright on .html.erb source files"
task :update_html_erb, :arg1 do |_task, args|
- rewrite_copyright('html.erb', [], :erb, args[:arg1])
+ rewrite_copyright("html.erb", [], :erb, args[:arg1])
end
- desc 'Update the copyright on .json.erb source files'
+ desc "Update the copyright on .json.erb source files"
task :update_json_erb, :arg1 do |_task, args|
- rewrite_copyright('json.erb', [], :erb, args[:arg1])
+ rewrite_copyright("json.erb", [], :erb, args[:arg1])
end
- desc 'Update the copyright on .atom.builder source files'
+ desc "Update the copyright on .atom.builder source files"
task :update_atom_builder, :arg1 do |_task, args|
- rewrite_copyright('atom.builder', [], :rb, args[:arg1])
+ rewrite_copyright("atom.builder", [], :rb, args[:arg1])
end
- desc 'Update the copyright on .text.erb source files'
+ desc "Update the copyright on .text.erb source files"
task :update_text_erb, :arg1 do |_task, args|
- rewrite_copyright('text.erb', [], :erb, args[:arg1])
+ rewrite_copyright("text.erb", [], :erb, args[:arg1])
end
- desc 'Update the copyright on .ts source files'
+ desc "Update the copyright on .ts source files"
task :update_typescript, :arg1 do |_task, args|
- rewrite_copyright('ts', [], :ts, args[:arg1])
+ rewrite_copyright("ts", [], :ts, args[:arg1])
end
- desc 'Update the copyright on all source files'
+ desc "Update the copyright on all source files"
task :update, :arg1 do |_task, args|
%w{
css rb js js_erb css_erb html_erb json_erb text_erb atom_builder rake
feature rdoc rjs sql yml yml_example rb_example special_files sass
}.each do |t|
- Rake::Task['copyright:update_' + t.to_s].invoke(args[:arg1])
+ Rake::Task["copyright:update_" + t.to_s].invoke(args[:arg1])
end
end
end
diff --git a/lib/tasks/copyright_authors.rake b/lib/tasks/copyright_authors.rake
index fd5440a8a6af..9e54370af658 100644
--- a/lib/tasks/copyright_authors.rake
+++ b/lib/tasks/copyright_authors.rake
@@ -28,7 +28,7 @@
namespace :copyright do
namespace :authors do
- desc 'Shows contributors of a repository'
+ desc "Shows contributors of a repository"
task :show, :arg1 do |_task, args|
contribution_periods = contribution_periods_of_repository(args[:arg1])
formatted_periods = format_contribution_periods(contribution_periods)
@@ -46,7 +46,7 @@ namespace :copyright do
def contribution_periods_of_repository(path)
contributions = []
contribution_periods = []
- path = '.' if path.nil?
+ path = "." if path.nil?
log = `git --git-dir #{path}/.git log --date=short --pretty=format:"%ad %aN"`
log.scan(CONTRIBUTION_REGEX).each do |m|
diff --git a/lib/tasks/cron.rake b/lib/tasks/cron.rake
index 2d153f1df01b..c821efa35c31 100644
--- a/lib/tasks/cron.rake
+++ b/lib/tasks/cron.rake
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-namespace 'openproject:cron' do
- desc 'Ensure the cron-like background jobs are properly unscheduled if needed'
+namespace "openproject:cron" do
+ desc "Ensure the cron-like background jobs are properly unscheduled if needed"
task schedule: [:environment] do
Storages::ManageNextcloudIntegrationJob.disable_cron_job_if_needed
end
diff --git a/lib/tasks/database.rake b/lib/tasks/database.rake
index 799e9bf25c4f..0c63bea6bd84 100644
--- a/lib/tasks/database.rake
+++ b/lib/tasks/database.rake
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-namespace 'db:sessions' do
- desc 'Expire old sessions from the sessions table'
- task :expire, [:days_ago] => [:environment, 'db:load_config'] do |_task, args|
+namespace "db:sessions" do
+ desc "Expire old sessions from the sessions table"
+ task :expire, [:days_ago] => [:environment, "db:load_config"] do |_task, args|
# sessions expire after 30 days of inactivity by default
days_ago = Integer(args[:days_ago] || 30)
expiration_time = Date.today - days_ago.days
@@ -38,9 +38,9 @@ namespace 'db:sessions' do
end
end
-namespace 'openproject' do
- namespace 'db' do
- desc 'Ensure database version compatibility'
+namespace "openproject" do
+ namespace "db" do
+ desc "Ensure database version compatibility"
task check_connection: %w[environment db:load_config] do
ActiveRecord::Base.establish_connection
ActiveRecord::Base.connection.execute "SELECT 1;"
@@ -53,7 +53,7 @@ namespace 'openproject' do
Kernel.exit 1
end
- desc 'Ensure database version compatibility'
+ desc "Ensure database version compatibility"
task ensure_database_compatibility: %w[openproject:db:check_connection] do
##
# Ensure database server version is compatible
diff --git a/lib/tasks/delete_documents.rake b/lib/tasks/delete_documents.rake
index 8fc996e51f24..c4030f6fff59 100644
--- a/lib/tasks/delete_documents.rake
+++ b/lib/tasks/delete_documents.rake
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative 'shared/user_feedback'
+require_relative "shared/user_feedback"
namespace :migrations do
namespace :documents do
@@ -35,28 +35,28 @@ namespace :migrations do
# rubocop:disable Rails/ApplicationRecord
class TemporaryDocument < ActiveRecord::Base
belongs_to :project
- belongs_to :category, class_name: 'DocumentCategory'
+ belongs_to :category, class_name: "DocumentCategory"
end
# rubocop:enable Rails/ApplicationRecord
- desc 'Removes all documents'
+ desc "Removes all documents"
task delete: :environment do |_task|
try_delete_documents
end
def try_delete_documents
if !$stdout.isatty || user_agrees_to_delete_all_documents
- puts 'Delete all attachments attached to projects or versions...'
+ puts "Delete all attachments attached to projects or versions..."
TemporaryDocument.destroy_all
- Attachment.where(container_type: ['Document']).destroy_all
+ Attachment.where(container_type: ["Document"]).destroy_all
end
rescue StandardError
- raise 'Cannot delete documents! There may be migrations missing...?'
+ raise "Cannot delete documents! There may be migrations missing...?"
end
def user_agrees_to_delete_all_documents
- questions = ['CAUTION: This rake task will delete ALL documents!',
+ questions = ["CAUTION: This rake task will delete ALL documents!",
"DISCLAIMER: This is the final warning: You're going to lose information!"]
ask_for_confirmation(questions)
diff --git a/lib/tasks/dependencies.rake b/lib/tasks/dependencies.rake
index 123bea60e69b..45684039e5f8 100644
--- a/lib/tasks/dependencies.rake
+++ b/lib/tasks/dependencies.rake
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'open3'
+require "open3"
namespace :openproject do
namespace :dependencies do
- desc 'Updates everything that is updatable automatically especially dependencies'
+ desc "Updates everything that is updatable automatically especially dependencies"
task update: %w[openproject:dependencies:update:gems]
namespace :update do
@@ -40,9 +40,9 @@ namespace :openproject do
.filter_map(&)
end
- desc 'Update gems to the extend the Gemfile allows in individual commits'
+ desc "Update gems to the extend the Gemfile allows in individual commits"
task :gems do
- out, _process = Open3.capture3('bundle', 'outdated', '--parseable')
+ out, _process = Open3.capture3("bundle", "outdated", "--parseable")
parsed = parse_capture(out) do |line|
line.match(/(\S+) \(newest ([0-9.]+), installed ([0-9.]+)(?:, requested .{0,2} ([0-9.]+))?\)/).to_a[1..4]
@@ -50,12 +50,12 @@ namespace :openproject do
parsed.map(&:first).each do |gem|
puts "Updating #{gem}"
- _out, error = Open3.capture3('bundle', 'update', gem)
+ _out, error = Open3.capture3("bundle", "update", gem)
if error.present?
puts "Attempted to update #{gem} but failed: #{error}"
else
- out, _process = Open3.capture3('git', 'diff', 'Gemfile.lock')
+ out, _process = Open3.capture3("git", "diff", "Gemfile.lock")
parsed = parse_capture(out) do |line|
line.match(/\A\+\s{4}(\S+) \(([0-9.]+)\)\z/).to_a[1..2]
@@ -65,8 +65,8 @@ namespace :openproject do
puts " #{gem}: #{version}"
end
- Open3.capture3('git', 'add', 'Gemfile.lock')
- Open3.capture3('git', 'commit', '-m', "bump #{parsed.map(&:first).join(' & ')}")
+ Open3.capture3("git", "add", "Gemfile.lock")
+ Open3.capture3("git", "commit", "-m", "bump #{parsed.map(&:first).join(' & ')}")
end
end
end
diff --git a/lib/tasks/deprecated.rake b/lib/tasks/deprecated.rake
index 043385c5d165..931b898c4719 100644
--- a/lib/tasks/deprecated.rake
+++ b/lib/tasks/deprecated.rake
@@ -39,11 +39,11 @@ def removed_task(name, message)
end
end
-deprecated_task :load_default_data, 'redmine:load_default_data'
+deprecated_task :load_default_data, "redmine:load_default_data"
-plugin_migrate_message = ':install:migrations is used now to copy' +
- ' migrations to the rails application directory.' +
- ' After installation, use db:migrate.'
-removed_task 'db:migrate_plugins', plugin_migrate_message
-removed_task 'db:migrate:plugin', plugin_migrate_message
-removed_task 'redmine:plugins:migrate', plugin_migrate_message
+plugin_migrate_message = ":install:migrations is used now to copy" +
+ " migrations to the rails application directory." +
+ " After installation, use db:migrate."
+removed_task "db:migrate_plugins", plugin_migrate_message
+removed_task "db:migrate:plugin", plugin_migrate_message
+removed_task "redmine:plugins:migrate", plugin_migrate_message
diff --git a/lib/tasks/email.rake b/lib/tasks/email.rake
index 51d07ed09c60..040fb749adc5 100644
--- a/lib/tasks/email.rake
+++ b/lib/tasks/email.rake
@@ -138,15 +138,15 @@ namespace :redmine do
task receive_imap: :environment do
imap_options = {
- host: ENV.fetch('host', nil),
- port: ENV.fetch('port', nil),
- ssl: ActiveRecord::Type::Boolean.new.cast(ENV.fetch('ssl', true)),
- ssl_verification: ActiveRecord::Type::Boolean.new.cast(ENV.fetch('ssl_verification', true)),
- username: ENV.fetch('username', nil),
- password: ENV.fetch('password', nil),
- folder: ENV.fetch('folder', nil),
- move_on_success: ENV.fetch('move_on_success', nil),
- move_on_failure: ENV.fetch('move_on_failure', nil)
+ host: ENV.fetch("host", nil),
+ port: ENV.fetch("port", nil),
+ ssl: ActiveRecord::Type::Boolean.new.cast(ENV.fetch("ssl", true)),
+ ssl_verification: ActiveRecord::Type::Boolean.new.cast(ENV.fetch("ssl_verification", true)),
+ username: ENV.fetch("username", nil),
+ password: ENV.fetch("password", nil),
+ folder: ENV.fetch("folder", nil),
+ move_on_success: ENV.fetch("move_on_success", nil),
+ move_on_failure: ENV.fetch("move_on_failure", nil)
}
Redmine::IMAP.check(imap_options, options_from_env)
@@ -169,12 +169,12 @@ namespace :redmine do
END_DESC
task receive_pop3: :environment do
- pop_options = { host: ENV.fetch('host', nil),
- port: ENV.fetch('port', nil),
- apop: ENV.fetch('apop', nil),
- username: ENV.fetch('username', nil),
- password: ENV.fetch('password', nil),
- delete_unprocessed: ENV.fetch('delete_unprocessed', nil) }
+ pop_options = { host: ENV.fetch("host", nil),
+ port: ENV.fetch("port", nil),
+ apop: ENV.fetch("apop", nil),
+ username: ENV.fetch("username", nil),
+ password: ENV.fetch("password", nil),
+ delete_unprocessed: ENV.fetch("delete_unprocessed", nil) }
Redmine::POP3.check(pop_options, options_from_env)
end
@@ -194,22 +194,22 @@ namespace :redmine do
task receive_gmail: :environment do
gmail_options = {
- credentials: ENV.fetch('credentials', nil),
- user_id: ENV.fetch('user_id', nil),
- query: ENV.fetch('query', nil),
- read_on_failure: ActiveRecord::Type::Boolean.new.cast(ENV.fetch('read_on_failure', 1)),
- max_emails: ENV.fetch('max_emails', 1000)
+ credentials: ENV.fetch("credentials", nil),
+ user_id: ENV.fetch("user_id", nil),
+ query: ENV.fetch("query", nil),
+ read_on_failure: ActiveRecord::Type::Boolean.new.cast(ENV.fetch("read_on_failure", 1)),
+ max_emails: ENV.fetch("max_emails", 1000)
}
Redmine::Gmail.check(gmail_options, options_from_env)
end
- desc 'Send a test email to the user with the provided login name'
+ desc "Send a test email to the user with the provided login name"
task :test, [:login] => :environment do |_task, args|
login = args[:login]
if login.blank?
abort I18n.t(:notice_email_error,
- default: 'Please include the user login to test with. Example: redmine:email:test[example-login]')
+ default: "Please include the user login to test with. Example: redmine:email:test[example-login]")
end
user = User.find_by_login(login)
@@ -231,13 +231,13 @@ namespace :redmine do
def options_from_env
{ issue: {} }.tap do |options|
- default_fields = ENV.fetch('default_fields', '').split
+ default_fields = ENV.fetch("default_fields", "").split
default_fields |= %w[project status type category priority assigned_to version]
default_fields.each { |field| options[:issue][field.to_sym] = ENV[field] if ENV[field].present? }
- options[:allow_override] = ENV['allow_override'] if ENV['allow_override']
- options[:unknown_user] = ENV['unknown_user'] if ENV['unknown_user']
- options[:no_permission_check] = ENV['no_permission_check'] if ENV['no_permission_check']
+ options[:allow_override] = ENV["allow_override"] if ENV["allow_override"]
+ options[:unknown_user] = ENV["unknown_user"] if ENV["unknown_user"]
+ options[:no_permission_check] = ENV["no_permission_check"] if ENV["no_permission_check"]
end
end
end
diff --git a/lib/tasks/environment.rake b/lib/tasks/environment.rake
index 80602b621c2c..b4e5844f984a 100644
--- a/lib/tasks/environment.rake
+++ b/lib/tasks/environment.rake
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-namespace 'environment' do
- desc 'Force application to eager load if configured (does not happen by default for rake tasks)'
+namespace "environment" do
+ desc "Force application to eager load if configured (does not happen by default for rake tasks)"
task :full do
warn "Forcefully loading the application. Use :environment to avoid eager loading."
@@ -36,7 +36,7 @@ namespace 'environment' do
Rails.application.require_environment!
end
- desc 'Eager load the application (only applicable in dev mode)'
+ desc "Eager load the application (only applicable in dev mode)"
task eager_load: :environment do
Zeitwerk::Loader.eager_load_all if Rails.env.development?
end
diff --git a/lib/tasks/extract_fixtures.rake b/lib/tasks/extract_fixtures.rake
index 08aac442c5f0..1a1e5397e940 100644
--- a/lib/tasks/extract_fixtures.rake
+++ b/lib/tasks/extract_fixtures.rake
@@ -30,12 +30,12 @@ desc 'Create YAML test fixtures from data in an existing database.
Defaults to development database. Set RAILS_ENV to override.'
task extract_fixtures: :environment do
- sql = 'SELECT * FROM %s'
- skip_tables = ['schema_info']
+ sql = "SELECT * FROM %s"
+ skip_tables = ["schema_info"]
ActiveRecord::Base.establish_connection
(ActiveRecord::Base.connection.tables - skip_tables).each do |table_name|
- i = '000'
- File.open(Rails.root.join("#{table_name}.yml"), 'w') do |file|
+ i = "000"
+ File.open(Rails.root.join("#{table_name}.yml"), "w") do |file|
data = ActiveRecord::Base.connection.select_all(sql % table_name)
file.write data.inject({}) { |hash, record|
# cast extracted values
diff --git a/lib/tasks/fetch_changesets.rake b/lib/tasks/fetch_changesets.rake
index 20e6204d0e02..a61199b93cb0 100644
--- a/lib/tasks/fetch_changesets.rake
+++ b/lib/tasks/fetch_changesets.rake
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-desc 'Fetch changesets from the repositories'
+desc "Fetch changesets from the repositories"
namespace :redmine do
task fetch_changesets: :environment do
diff --git a/lib/tasks/git.rake b/lib/tasks/git.rake
index 86bb6b8c2d51..f3481a29b7eb 100644
--- a/lib/tasks/git.rake
+++ b/lib/tasks/git.rake
@@ -27,19 +27,19 @@
#++
namespace :git do
- desc 'Clean up your locale and remote repository'
+ desc "Clean up your locale and remote repository"
task :clean do
# FIXME: change this to master once we are there
- main_branch = 'dev'
+ main_branch = "dev"
excluded_branches = [
main_branch,
- 'release/4.0',
- 'release/4.1',
- 'release/4.2'
- ].join('|')
+ "release/4.0",
+ "release/4.1",
+ "release/4.2"
+ ].join("|")
# symbolic-ref gives us sth. like "refs/heads/foo" and we just need 'foo'
- current_branch = `git symbolic-ref HEAD`.chomp.split('/').last
+ current_branch = `git symbolic-ref HEAD`.chomp.split("/").last
# we don't want to remove the current branch
excluded_branches << current_branch
@@ -48,28 +48,28 @@ namespace :git do
if $CHILD_STATUS.exitstatus == 0
puts "WARNING: You are on branch #{current_branch}, NOT #{main_branch}."
else
- puts 'WARNING: You are not on a branch'
+ puts "WARNING: You are not on a branch"
end
puts
end
- puts 'Updating to most current code from origin ...'
+ puts "Updating to most current code from origin ..."
`git fetch origin`
- puts 'Pruning remote origin ...'
+ puts "Pruning remote origin ..."
`git remote prune origin`
- puts 'Fetching merged branches...'
+ puts "Fetching merged branches..."
remote_branches = `git branch -r --merged`
.split("\n")
.map(&:strip)
.reject do |b|
- !b.starts_with?('origin') ||
- excluded_branches.include?(b.split('/').drop(1).join('/'))
+ !b.starts_with?("origin") ||
+ excluded_branches.include?(b.split("/").drop(1).join("/"))
end
local_branches = `git branch --merged`
- .gsub(/^\* /, '')
+ .gsub(/^\* /, "")
.split("\n")
.map(&:strip)
.reject { |b| excluded_branches.include?(b) }
@@ -77,10 +77,10 @@ namespace :git do
if remote_branches.empty? && local_branches.empty?
puts "No existing branches have been merged into #{current_branch}."
else
- puts 'This will remove the following branches:'
+ puts "This will remove the following branches:"
puts remote_branches.join("\n")
puts local_branches.join("\n")
- puts 'Proceed? (y/n)'
+ puts "Proceed? (y/n)"
if /^y/i.match?(STDIN.gets)
remote_branches.each do |b|
@@ -92,9 +92,9 @@ namespace :git do
end
# Remove local branches
- `git branch -d #{local_branches.join(' ')}`
+ `git branch -d #{local_branches.join(" ")}`
else
- puts 'No branches removed.'
+ puts "No branches removed."
end
end
end
diff --git a/lib/tasks/jdbc.rake b/lib/tasks/jdbc.rake
index 0ad1c904b82e..d4758b30160f 100644
--- a/lib/tasks/jdbc.rake
+++ b/lib/tasks/jdbc.rake
@@ -31,6 +31,6 @@
#
# This file allows you to use Rails' various db:* tasks with JDBC.
if defined?(JRUBY_VERSION)
- require 'jdbc_adapter'
- require 'jdbc_adapter/rake_tasks'
+ require "jdbc_adapter"
+ require "jdbc_adapter/rake_tasks"
end
diff --git a/lib/tasks/ldap.rake b/lib/tasks/ldap.rake
index b94bd892a2fc..90bb6e867de1 100644
--- a/lib/tasks/ldap.rake
+++ b/lib/tasks/ldap.rake
@@ -38,34 +38,34 @@ namespace :ldap do
args
end
- desc 'Synchronize existing users from the LDAP auth source' \
+ desc "Synchronize existing users from the LDAP auth source" \
'rake ldap:sync name="" users='
task sync: :environment do
args = parse_args
ldap = LdapAuthSource.find_by!(name: args.fetch(:name))
- logins = args.fetch(:logins, '').split(/\s*,\s*/)
+ logins = args.fetch(:logins, "").split(/\s*,\s*/)
Ldap::SynchronizeUsersService
.new(ldap, logins)
.call
end
- desc 'Synchronize users from the LDAP auth source with an optional filter.' \
- 'Note: If you omit the filter, ALL users are imported.' \
+ desc "Synchronize users from the LDAP auth source with an optional filter." \
+ "Note: If you omit the filter, ALL users are imported." \
'rake ldap:import_from_filter name="" filter='
task import_from_filter: :environment do
args = parse_args
ldap = LdapAuthSource.find_by!(name: args.fetch(:name))
# Parse filter string if available
- filter = Net::LDAP::Filter.from_rfc2254 args.fetch(:filter, 'objectClass = *')
+ filter = Net::LDAP::Filter.from_rfc2254 args.fetch(:filter, "objectClass = *")
Ldap::ImportUsersFromFilterService
.new(ldap, filter)
.call
end
- desc 'Synchronize a list of user logins with the LDAP auth source' \
+ desc "Synchronize a list of user logins with the LDAP auth source" \
'rake ldap:import_from_user_list name=" users='
task import_from_user_list: :environment do
args = parse_args
@@ -80,7 +80,7 @@ namespace :ldap do
.call
end
- desc 'Register a LDAP auth source for the given LDAP URL and attribute mapping: ' \
+ desc "Register a LDAP auth source for the given LDAP URL and attribute mapping: " \
'rake ldap:register["url= name= onthefly=map_{login,firstname,lastname,mail,admin}=attribute,filter_string"]'
task register: :environment do
args = parse_args
@@ -99,7 +99,7 @@ namespace :ldap do
source.attributes = {
host: url.host,
port: url.port,
- tls_mode: url.scheme == 'ldaps' ? 'start_tls' : 'plain_ldap',
+ tls_mode: url.scheme == "ldaps" ? "start_tls" : "plain_ldap",
account: url.user,
account_password: url.password,
base_dn: url.dn,
diff --git a/lib/tasks/load_default_data.rake b/lib/tasks/load_default_data.rake
index 2dd21d10ad9b..398e13920d0e 100644
--- a/lib/tasks/load_default_data.rake
+++ b/lib/tasks/load_default_data.rake
@@ -26,40 +26,40 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-desc 'Load Redmine default configuration data. Language is chosen interactively or by setting REDMINE_LANG environment variable.'
+desc "Load Redmine default configuration data. Language is chosen interactively or by setting REDMINE_LANG environment variable."
namespace :redmine do
task load_default_data: :environment do
include Redmine::I18n
- set_language_if_valid('en')
+ set_language_if_valid("en")
- envlang = ENV.fetch('REDMINE_LANG', nil)
+ envlang = ENV.fetch("REDMINE_LANG", nil)
if !envlang || !set_language_if_valid(envlang)
puts
loop do
- print 'Select language: '
- print valid_languages.collect(&:to_s).sort.join(', ')
+ print "Select language: "
+ print valid_languages.collect(&:to_s).sort.join(", ")
print " [#{current_language}] "
STDOUT.flush
lang = STDIN.gets.chomp!
break if lang.empty?
break if set_language_if_valid(lang)
- puts 'Unknown language!'
+ puts "Unknown language!"
end
STDOUT.flush
- puts '===================================='
+ puts "===================================="
end
begin
Redmine::DefaultData::Loader.load(current_language)
- puts 'Default configuration data loaded.'
+ puts "Default configuration data loaded."
rescue Redmine::DefaultData::DataAlreadyLoaded => e
puts e
rescue StandardError => e
- puts 'Error: ' + e.message
+ puts "Error: " + e.message
puts e.backtrace.join("\n")
- puts 'Default configuration data was not loaded.'
+ puts "Default configuration data was not loaded."
end
end
end
diff --git a/lib/tasks/metrics.rake b/lib/tasks/metrics.rake
index f2a0fd7afd34..bcd3cc6d20fa 100644
--- a/lib/tasks/metrics.rake
+++ b/lib/tasks/metrics.rake
@@ -27,7 +27,7 @@
#++
begin
- require 'metric_fu'
+ require "metric_fu"
rescue LoadError
# Metric-fu not installed
# http://metric-fu.rubyforge.org/
diff --git a/lib/tasks/packager.rake b/lib/tasks/packager.rake
index 5889594920c3..b00116f14f19 100644
--- a/lib/tasks/packager.rake
+++ b/lib/tasks/packager.rake
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'open3'
+require "open3"
namespace :packager do
def shell_setup(cmd, raise_on_error: true)
- out_and_err, status = Open3.capture2e(ENV.fetch('APP_NAME', nil), *cmd)
+ out_and_err, status = Open3.capture2e(ENV.fetch("APP_NAME", nil), *cmd)
if status.exitstatus != 0 && raise_on_error
raise "Aborting packager setup due to error in installation. Output: #{out_and_err}"
@@ -38,23 +38,23 @@ namespace :packager do
##
# Allow scripts to run before environment is loaded
- task before_postinstall: ['setup:relative_root']
+ task before_postinstall: ["setup:relative_root"]
#
# Allow scripts to run with environment loaded once,
# avoids to load the environment multiple times.
# Removes older assets
- task postinstall: [:environment, 'assets:clean', 'setup:scm'] do
+ task postinstall: [:environment, "assets:clean", "setup:scm"] do
# We need to precompile assets when either
# 1. packager requested it
# 2. user requested frontend compilation with RECOMPILE_ANGULAR_ASSETS
- if ENV['RECOMPILE_RAILS_ASSETS'] == 'true' || ENV['RECOMPILE_ANGULAR_ASSETS'] == 'true'
- Rake::Task['assets:precompile'].invoke
- FileUtils.chmod_R 'a+rx', "#{ENV.fetch('APP_HOME', nil)}/public/assets/"
+ if ENV["RECOMPILE_RAILS_ASSETS"] == "true" || ENV["RECOMPILE_ANGULAR_ASSETS"] == "true"
+ Rake::Task["assets:precompile"].invoke
+ FileUtils.chmod_R "a+rx", "#{ENV.fetch('APP_HOME', nil)}/public/assets/"
# Unset rails request to recompile
# but keep RECOMPILE_ANGULAR_ASSETS as it's user defined
- shell_setup(['config:set', 'RECOMPILE_RAILS_ASSETS=""'])
+ shell_setup(["config:set", 'RECOMPILE_RAILS_ASSETS=""'])
end
# Clear any caches
@@ -62,73 +62,73 @@ namespace :packager do
# Persist configuration
Setting.sys_api_enabled = 1
- Setting.sys_api_key = ENV.fetch('SYS_API_KEY', nil)
- Setting.host_name = ENV.fetch('SERVER_HOSTNAME', Setting.host_name) if Setting.host_name_writable?
+ Setting.sys_api_key = ENV.fetch("SYS_API_KEY", nil)
+ Setting.host_name = ENV.fetch("SERVER_HOSTNAME", Setting.host_name) if Setting.host_name_writable?
# SERVER_PROTOCOL is set by the packager apache2 addon
# other SERVER_PROTOCOL_xxx variables can be manually set by user
- if ENV['SERVER_PROTOCOL_HTTPS_NO_HSTS']
+ if ENV["SERVER_PROTOCOL_HTTPS_NO_HSTS"]
# Allow setting only HTTPS setting without enabling FORCE__SSL
# due to external proxy configuration. This avoids activation of HSTS headers.
- shell_setup(['config:set', "OPENPROJECT_HTTPS=true"])
- shell_setup(['config:set', "OPENPROJECT_HSTS=false"])
- elsif ENV['SERVER_PROTOCOL_FORCE_HTTPS'] || ENV.fetch('SERVER_PROTOCOL', Setting.protocol) == 'https'
+ shell_setup(["config:set", "OPENPROJECT_HTTPS=true"])
+ shell_setup(["config:set", "OPENPROJECT_HSTS=false"])
+ elsif ENV["SERVER_PROTOCOL_FORCE_HTTPS"] || ENV.fetch("SERVER_PROTOCOL", Setting.protocol) == "https"
# Allow overriding the protocol setting from ENV
# to allow instances where SSL is terminated earlier to respect that setting
- shell_setup(['config:set', "OPENPROJECT_HTTPS=true"])
- shell_setup(['config:set', "OPENPROJECT_HSTS=true"])
+ shell_setup(["config:set", "OPENPROJECT_HTTPS=true"])
+ shell_setup(["config:set", "OPENPROJECT_HSTS=true"])
else
- shell_setup(['config:set', "OPENPROJECT_HTTPS=false"])
- shell_setup(['config:set', "OPENPROJECT_HSTS=false"])
+ shell_setup(["config:set", "OPENPROJECT_HTTPS=false"])
+ shell_setup(["config:set", "OPENPROJECT_HSTS=false"])
end
# Run customization step, if it is defined.
# Use to define custom postinstall steps required after each configure,
# or to configure products.
- if Rake::Task.task_defined?('packager:customize')
- Rake::Task['packager:customize'].invoke
+ if Rake::Task.task_defined?("packager:customize")
+ Rake::Task["packager:customize"].invoke
end
end
namespace :setup do
task :relative_root do
- old_relative_root = ENV.fetch('RAILS_RELATIVE_URL_ROOT', '')
- relative_root = ENV.fetch('SERVER_PATH_PREFIX', '/')
+ old_relative_root = ENV.fetch("RAILS_RELATIVE_URL_ROOT", "")
+ relative_root = ENV.fetch("SERVER_PATH_PREFIX", "/")
- if relative_root != '/' || "#{old_relative_root}/" != relative_root
+ if relative_root != "/" || "#{old_relative_root}/" != relative_root
# Rails expects relative root not to have a trailing slash,
# but most of our packager setup scripts require it, thus remove it here.
- new_root = relative_root.chomp('/')
+ new_root = relative_root.chomp("/")
- shell_setup(['config:set', "RAILS_RELATIVE_URL_ROOT=#{new_root}"])
+ shell_setup(["config:set", "RAILS_RELATIVE_URL_ROOT=#{new_root}"])
end
end
task :scm do
- svn_path = ENV.fetch('SVN_REPOSITORIES', '')
- git_path = ENV.fetch('GIT_REPOSITORIES', '')
+ svn_path = ENV.fetch("SVN_REPOSITORIES", "")
+ git_path = ENV.fetch("GIT_REPOSITORIES", "")
# SCM configuration may have been skipped
if svn_path.present? || git_path.present?
- base_url = URI::Generic.build(scheme: ENV.fetch('SERVER_PROTOCOL', nil), host: ENV.fetch('SERVER_HOSTNAME', nil))
- prefix = ENV.fetch('SERVER_PATH_PREFIX', nil)
+ base_url = URI::Generic.build(scheme: ENV.fetch("SERVER_PROTOCOL", nil), host: ENV.fetch("SERVER_HOSTNAME", nil))
+ prefix = ENV.fetch("SERVER_PATH_PREFIX", nil)
checkout_data = Setting.repository_checkout_data
if svn_path.present?
# migrate previous repositories with reposman to managed
- Rake::Task['scm:migrate:managed'].invoke("file://#{svn_path}")
- checkout_data['subversion'] = { 'enabled' => 1, 'base_url' => URI.join(base_url, prefix, 'svn').to_s }
+ Rake::Task["scm:migrate:managed"].invoke("file://#{svn_path}")
+ checkout_data["subversion"] = { "enabled" => 1, "base_url" => URI.join(base_url, prefix, "svn").to_s }
end
if git_path.present?
- checkout_data['git'] = { 'enabled' => 1, 'base_url' => URI.join(base_url, prefix, 'git').to_s }
+ checkout_data["git"] = { "enabled" => 1, "base_url" => URI.join(base_url, prefix, "git").to_s }
end
Setting.repository_checkout_data = checkout_data
# Output any remnants of existing repositories in the currently
# configured paths of Git and Subversion.
- Rake::Task['scm:find_unassociated'].invoke
+ Rake::Task["scm:find_unassociated"].invoke
end
end
end
diff --git a/lib/tasks/parallel_testing.rake b/lib/tasks/parallel_testing.rake
index 35df1506cc7d..09027a1d2ae2 100644
--- a/lib/tasks/parallel_testing.rake
+++ b/lib/tasks/parallel_testing.rake
@@ -26,16 +26,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'optparse'
+require "optparse"
begin
- Bundler.gem('parallel_tests')
+ Bundler.gem("parallel_tests")
rescue Gem::LoadError
# In case parallel_tests is not provided, the whole of the parallel task group will not work.
return
end
-require 'parallel_tests/tasks'
+require "parallel_tests/tasks"
# Remove task added by parallel_tests as it conflicts with our own.
# Having both will lead to both being executed.
Rake::Task["parallel:features"].clear if Rake::Task.task_defined?("parallel:features")
@@ -54,11 +54,11 @@ namespace :parallel do
if parseable_args
OptionParser.new do |opts|
opts.banner = "Usage: rails #{args[0]} -- [options]"
- opts.on("-n ARG", "--group-number ARG", Integer) { |num_cpus| options[:num_cpus] = num_cpus || ENV.fetch('GROUP', nil) }
+ opts.on("-n ARG", "--group-number ARG", Integer) { |num_cpus| options[:num_cpus] = num_cpus || ENV.fetch("GROUP", nil) }
opts.on("-o ARG", "--only-group ARG", Integer) do |group_number|
- options[:group] = group_number || ENV.fetch('GROUP_SIZE', nil)
+ options[:group] = group_number || ENV.fetch("GROUP_SIZE", nil)
end
- opts.on("-s ARG", "--seed ARG", Integer) { |seed| options[:seed] = seed || ENV.fetch('CI_SEED', nil) } if allow_seed
+ opts.on("-s ARG", "--seed ARG", Integer) { |seed| options[:seed] = seed || ENV.fetch("CI_SEED", nil) } if allow_seed
end.parse!(parseable_args)
end
@@ -67,7 +67,7 @@ namespace :parallel do
end
def group_option_string(parsed_options)
- group_options = parsed_options ? "-n #{parsed_options[:num_cpus]}" : ''
+ group_options = parsed_options ? "-n #{parsed_options[:num_cpus]}" : ""
group_options += " --only-group #{parsed_options[:group]}" if parsed_options[:group]
group_options
@@ -77,18 +77,18 @@ namespace :parallel do
# Returns all spec folder paths
# of the core, modules and plugins
def all_spec_paths
- spec_folders = ['spec'] + Plugins::LoadPathHelper.spec_load_paths
- spec_folders.join(' ')
+ spec_folders = ["spec"] + Plugins::LoadPathHelper.spec_load_paths
+ spec_folders.join(" ")
end
##
# Returns all spec folder paths
# of the core, modules and plugins
def plugin_spec_paths
- Plugins::LoadPathHelper.spec_load_paths.join(' ')
+ Plugins::LoadPathHelper.spec_load_paths.join(" ")
end
- def run_specs(parsed_options, folders, pattern = '', additional_options: nil, runtime_filename: nil)
+ def run_specs(parsed_options, folders, pattern = "", additional_options: nil, runtime_filename: nil)
check_for_pending_migrations
group_options = group_option_string(parsed_options)
@@ -109,17 +109,17 @@ namespace :parallel do
sh cmd
end
- desc 'Run all suites in parallel (one after another)'
- task all: ['parallel:plugins:specs',
- 'parallel:plugins:features',
+ desc "Run all suites in parallel (one after another)"
+ task all: ["parallel:plugins:specs",
+ "parallel:plugins:features",
:rspec]
namespace :plugins do
- desc 'Run all plugin tests in parallel'
- task all: ['parallel:plugins:specs',
- 'parallel:plugins:features']
+ desc "Run all plugin tests in parallel"
+ task all: ["parallel:plugins:specs",
+ "parallel:plugins:features"]
- desc 'Run plugin specs in parallel'
+ desc "Run plugin specs in parallel"
task specs: [:environment] do
ParallelParser.with_args(ARGV) do |options|
ARGV.each { |a| task(a.to_sym) {} }
@@ -128,7 +128,7 @@ namespace :parallel do
end
end
- desc 'Run plugin unit specs in parallel'
+ desc "Run plugin unit specs in parallel"
task units: [:environment] do
pattern = "--pattern 'spec/(?!features/)'"
@@ -139,7 +139,7 @@ namespace :parallel do
end
end
- desc 'Run plugin feature specs in parallel'
+ desc "Run plugin feature specs in parallel"
task features: [:environment] do
pattern = "--pattern 'spec/features'"
@@ -151,7 +151,7 @@ namespace :parallel do
end
end
- desc 'Run spec in parallel (custom task)'
+ desc "Run spec in parallel (custom task)"
task :specs do
ParallelParser.with_args(ARGV) do |options|
ARGV.each { |a| task(a.to_sym) {} }
@@ -160,7 +160,7 @@ namespace :parallel do
end
end
- desc 'Run feature specs in parallel'
+ desc "Run feature specs in parallel"
task features: [:environment] do
pattern = "--pattern 'spec/features/'"
@@ -171,7 +171,7 @@ namespace :parallel do
end
end
- desc 'Run unit specs in parallel'
+ desc "Run unit specs in parallel"
task units: [:environment] do
pattern = "--pattern 'spec/(?!features/)'"
diff --git a/lib/tasks/permissions.rake b/lib/tasks/permissions.rake
index a1f7bf67c501..7da1dc8e9e8e 100644
--- a/lib/tasks/permissions.rake
+++ b/lib/tasks/permissions.rake
@@ -27,9 +27,9 @@
#++
namespace :redmine do
- desc 'List all permissions and the actions registered with them'
+ desc "List all permissions and the actions registered with them"
task permissions: :environment do
- puts 'Permission Name - controller/action pairs'
+ puts "Permission Name - controller/action pairs"
OpenProject::AccessControl.permissions.sort { |a, b| a.name.to_s <=> b.name.to_s }.each do |permission|
puts ":#{permission.name} - #{permission.controller_actions.join(', ')}"
end
diff --git a/lib/tasks/plugin_specs.rake b/lib/tasks/plugin_specs.rake
index 48a461ac3a51..ab77d4100c13 100644
--- a/lib/tasks/plugin_specs.rake
+++ b/lib/tasks/plugin_specs.rake
@@ -43,15 +43,15 @@
#
begin
- require 'rspec/core/rake_task'
+ require "rspec/core/rake_task"
namespace :spec do
- desc 'Run core and plugin specs'
+ desc "Run core and plugin specs"
RSpec::Core::RakeTask.new(all: [:environment]) do |t|
- t.pattern = [Rails.root.join('spec').to_s] + Plugins::LoadPathHelper.spec_load_paths
+ t.pattern = [Rails.root.join("spec").to_s] + Plugins::LoadPathHelper.spec_load_paths
end
- desc 'Run plugin specs'
+ desc "Run plugin specs"
RSpec::Core::RakeTask.new(plugins: [:environment]) do |t|
t.pattern = Plugins::LoadPathHelper.spec_load_paths
@@ -59,7 +59,7 @@ begin
# we exit with positive message
if t.pattern.empty?
puts
- puts '##### There are no specs for OpenProject plugins to be run.'
+ puts "##### There are no specs for OpenProject plugins to be run."
puts
exit(0)
end
diff --git a/lib/tasks/plugins.rake b/lib/tasks/plugins.rake
index 02eff3cbf6db..72aad4baad4c 100644
--- a/lib/tasks/plugins.rake
+++ b/lib/tasks/plugins.rake
@@ -25,12 +25,12 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'bundler'
-require 'json'
+require "bundler"
+require "json"
namespace :openproject do
namespace :plugins do
- desc 'Register plugins from the :opf_plugins bundle group to the frontend'
+ desc "Register plugins from the :opf_plugins bundle group to the frontend"
task register_frontend: [:environment] do
OpenProject::Plugins::FrontendLinking.regenerate!
end
diff --git a/lib/tasks/release.rake b/lib/tasks/release.rake
index e9d02806a1d2..8de8348a64fb 100644
--- a/lib/tasks/release.rake
+++ b/lib/tasks/release.rake
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'fileutils'
+require "fileutils"
-desc 'Package up a OpenProject release from git. example: `rake release[1.1.0]`'
+desc "Package up a OpenProject release from git. example: `rake release[1.1.0]`"
task :release, [:version] do |_task, args|
version = args[:version]
- abort 'Missing version in the form of 1.0.0' unless version.present?
+ abort "Missing version in the form of 1.0.0" unless version.present?
- dir = Pathname.new(ENV.fetch('HOME', nil)) + 'dev' + 'openproject' + 'packages'
+ dir = Pathname.new(ENV.fetch("HOME", nil)) + "dev" + "openproject" + "packages"
FileUtils.mkdir_p dir
commands = [
@@ -47,6 +47,6 @@ task :release, [:version] do |_task, args|
"zip -r -9 openproject-#{version}.zip openproject-#{version}",
"md5sum openproject-#{version}.tar.gz openproject-#{version}.zip > openproject-#{version}.md5sum",
"echo 'Release ready'"
- ].join(' && ')
+ ].join(" && ")
system(commands)
end
diff --git a/lib/tasks/reregister_password_migrations.rake b/lib/tasks/reregister_password_migrations.rake
index ec38358031cf..9bab7aeef36e 100644
--- a/lib/tasks/reregister_password_migrations.rake
+++ b/lib/tasks/reregister_password_migrations.rake
@@ -29,7 +29,7 @@
namespace :migrations do
namespace :strong_passwords do
def migrations_to_reregister
- @migrations_to_reregister ||= ['20130628092725']
+ @migrations_to_reregister ||= ["20130628092725"]
end
desc "Prepares database schema changed by the plug-in 'Strong Passwords' for follow-up migrations"
@@ -44,7 +44,7 @@ namespace :migrations do
end
def strong_passwords_changed_schema
- User.column_names.include? 'failed_login_on'
+ User.column_names.include? "failed_login_on"
end
def rename_strong_password_columns
@@ -63,7 +63,7 @@ namespace :migrations do
end
def schema_name
- ActiveRecord::Base.connection.quote_table_name 'schema_migrations'
+ ActiveRecord::Base.connection.quote_table_name "schema_migrations"
end
def quote_value(name)
diff --git a/lib/tasks/scm.rake b/lib/tasks/scm.rake
index 4472dfa4897e..3d3d8d74fe69 100644
--- a/lib/tasks/scm.rake
+++ b/lib/tasks/scm.rake
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'pathname'
+require "pathname"
def scan_repositories(path)
repositories = Pathname.new(path).children.select(&:directory?)
@@ -34,7 +34,7 @@ def scan_repositories(path)
repositories.each do |repo|
# Repository may be suffixed by '.git' and the like
- identifier = repo.basename.to_s.split('.')[0]
+ identifier = repo.basename.to_s.split(".")[0]
missing << identifier if Project.find_by(identifier:).nil?
end
@@ -42,9 +42,9 @@ def scan_repositories(path)
end
namespace :scm do
- desc 'List repositories in the current managed path that do not have an associated project'
+ desc "List repositories in the current managed path that do not have an associated project"
task find_unassociated: :environment do
- scm = OpenProject::Configuration['scm']
+ scm = OpenProject::Configuration["scm"]
if scm.nil?
abort "No repository configuration is set.\n" \
"(Configuration resides under key 'scm' in `config/configuration.yaml`)"
@@ -52,7 +52,7 @@ namespace :scm do
scm.each_pair do |vendor, config|
vendor = vendor.to_s.classify
- managed = config['manages']
+ managed = config["manages"]
repo_class = Repository.const_get(vendor)
if managed.nil?
@@ -100,30 +100,30 @@ namespace :scm do
end
end
- desc 'Setup a repository checkout base URL for the given vendor: rake scm:set_checkout_url[git=, subversion=]'
+ desc "Setup a repository checkout base URL for the given vendor: rake scm:set_checkout_url[git=, subversion=]"
task set_checkout_url: :environment do |_t, args|
checkout_data = Setting.repository_checkout_data
args.extras.each do |tuple|
- vendor, base_url = tuple.split('=')
+ vendor, base_url = tuple.split("=")
unless OpenProject::SCM::Manager.enabled?(vendor.to_sym)
puts "Vendor #{vendor} is not enabled, skipping."
next
end
- checkout_data[vendor] = { 'enabled' => 1, 'base_url' => base_url }
+ checkout_data[vendor] = { "enabled" => 1, "base_url" => base_url }
end
Setting.repository_checkout_data = checkout_data
end
namespace :migrate do
- desc 'Migrate existing repositories to managed for a given URL prefix'
+ desc "Migrate existing repositories to managed for a given URL prefix"
task managed: :environment do |_task, args|
urls = args.extras
abort "Requires at least one URL prefix to identify existing repositories" if urls.length < 1
urls.each do |url|
- Repository.where('url LIKE ?', "#{url}%").update_all(scm_type: :managed)
+ Repository.where("url LIKE ?", "#{url}%").update_all(scm_type: :managed)
end
end
end
diff --git a/lib/tasks/secret_token.rake b/lib/tasks/secret_token.rake
index 83b578fe757a..72a9a297d420 100644
--- a/lib/tasks/secret_token.rake
+++ b/lib/tasks/secret_token.rake
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-desc 'Generates a secret token file.'
+desc "Generates a secret token file."
-file 'config/secret_token.yml' do
- path = Rails.root.join('config/secret_token.yml').to_s
+file "config/secret_token.yml" do
+ path = Rails.root.join("config/secret_token.yml").to_s
secret = SecureRandom.hex(64)
File.write(path, <<~"EOF")
secret_token: '#{secret}'
EOF
end
-desc 'Generates a secret token file.'
-task generate_secret_token: ['config/secret_token.yml']
+desc "Generates a secret token file."
+task generate_secret_token: ["config/secret_token.yml"]
diff --git a/lib/tasks/setting.rake b/lib/tasks/setting.rake
index 302b8d1f4dcb..fa376bfbf351 100644
--- a/lib/tasks/setting.rake
+++ b/lib/tasks/setting.rake
@@ -27,17 +27,17 @@
#++
namespace :setting do
- desc 'Allow to set a Setting: rake setting:set[key1=value1,key2=value2]'
+ desc "Allow to set a Setting: rake setting:set[key1=value1,key2=value2]"
task set: :environment do |_t, args|
args.extras.each do |tuple|
- key, value = tuple.split('=')
+ key, value = tuple.split("=")
setting = Setting.find_or_initialize_by(name: key)
setting.set_value! value, force: true
setting.save!
end
end
- desc 'Allow to get a Setting: rake setting:get[key]'
+ desc "Allow to get a Setting: rake setting:get[key]"
task :get, [:key] => :environment do |_t, args|
setting = Setting.find_by(name: args[:key])
unless setting.nil?
@@ -45,10 +45,10 @@ namespace :setting do
end
end
- desc 'Allow to set a Setting read from an ENV var. Example: rake setting:set_to_env[smtp_address=SMTP_HOST]'
+ desc "Allow to set a Setting read from an ENV var. Example: rake setting:set_to_env[smtp_address=SMTP_HOST]"
task set_to_env: :environment do |_t, args|
args.extras.each do |tuple|
- setting_name, env_var_name = tuple.split('=')
+ setting_name, env_var_name = tuple.split("=")
next unless Settings::Definition.exists? setting_name
next unless ENV.has_key? env_var_name
@@ -59,7 +59,7 @@ namespace :setting do
end
end
- desc 'List the supported environment variables to override settings'
+ desc "List the supported environment variables to override settings"
task available_envs: :environment do
Settings::Definition.all.sort.each do |_name, definition|
puts "#{Settings::Definition.possible_env_names(definition).first} " \
diff --git a/lib/tasks/shared/attachment_migration.rb b/lib/tasks/shared/attachment_migration.rb
index f3cbb6d71f13..a2579c5aea6a 100644
--- a/lib/tasks/shared/attachment_migration.rb
+++ b/lib/tasks/shared/attachment_migration.rb
@@ -134,16 +134,16 @@ def attachments_page!(wiki, name:)
def try_delete_attachments_from_projects_and_versions
if !$stdout.isatty || user_agrees_to_delete_versions_and_projects_documents
- puts 'Delete all attachments attached to projects or versions...'
+ puts "Delete all attachments attached to projects or versions..."
- Attachment.where(container_type: ['Version', 'Project']).destroy_all
+ Attachment.where(container_type: ["Version", "Project"]).destroy_all
end
rescue StandardError
- raise 'Cannot delete attachments from projects and versions! There may be migrations missing...?'
+ raise "Cannot delete attachments from projects and versions! There may be migrations missing...?"
end
def user_agrees_to_delete_versions_and_projects_documents
- questions = ['CAUTION: This rake task will delete ALL attachments attached to versions or projects!',
+ questions = ["CAUTION: This rake task will delete ALL attachments attached to versions or projects!",
"DISCLAIMER: This is the final warning: You're going to lose information!"]
ask_for_confirmation(questions)
diff --git a/lib/tasks/shared/legacy_attachment.rb b/lib/tasks/shared/legacy_attachment.rb
index fc60ad9d990e..257c12cbebd0 100644
--- a/lib/tasks/shared/legacy_attachment.rb
+++ b/lib/tasks/shared/legacy_attachment.rb
@@ -37,7 +37,7 @@ def migrate_attachment(attachment)
if file_name && File.readable?(file)
FileUtils.move file, new_file unless file == new_file
attachment.file = File.open(new_file)
- attachment.filename = ''
+ attachment.filename = ""
attachment.save!
FileUtils.rm_f new_file
@@ -101,7 +101,7 @@ def legacy_file_name(file_name)
# This method strips the leading timestamp from a given file name and returns the plain,
# original file name.
def strip_timestamp_from_filename(file)
- Pathname(file).dirname + Pathname(file).basename.to_s.gsub(/^[^_]+_/, '')
+ Pathname(file).dirname + Pathname(file).basename.to_s.gsub(/^[^_]+_/, "")
end
end
end
diff --git a/lib/tasks/shared/user_feedback.rb b/lib/tasks/shared/user_feedback.rb
index 4fe0dbbd4615..eb251a0c244a 100644
--- a/lib/tasks/shared/user_feedback.rb
+++ b/lib/tasks/shared/user_feedback.rb
@@ -40,7 +40,7 @@ def ask_confirmation_question(question)
puts question
puts "\nDo you want to continue? [y/N]"
- STDIN.gets.chomp == 'y'
+ STDIN.gets.chomp == "y"
end
end
end
diff --git a/lib/tasks/testing.rake b/lib/tasks/testing.rake
index 75bce82fa003..a8dcc416422e 100644
--- a/lib/tasks/testing.rake
+++ b/lib/tasks/testing.rake
@@ -27,7 +27,7 @@
#++
namespace :test do
- desc 'runs all tests'
+ desc "runs all tests"
namespace :suite do
task run: [:spec]
end
@@ -35,6 +35,6 @@ end
%w(spec).each do |type|
if Rake::Task.task_defined?("#{type}:prepare")
- Rake::Task["#{type}:prepare"].enhance(['assets:prepare_op'])
+ Rake::Task["#{type}:prepare"].enhance(["assets:prepare_op"])
end
end
diff --git a/lib/tasks/time_entry_activities.rake b/lib/tasks/time_entry_activities.rake
index b45ab73fb904..ba248d0766af 100644
--- a/lib/tasks/time_entry_activities.rake
+++ b/lib/tasks/time_entry_activities.rake
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'pg'
+require "pg"
-namespace 'openproject' do
- desc 'Fixes an error in the migration to 10.4 by fetching data from a backup.'
+namespace "openproject" do
+ desc "Fixes an error in the migration to 10.4 by fetching data from a backup."
task :reassign_time_entry_activities do
- unless ENV['BACKUP_DATABASE_URL']
+ unless ENV["BACKUP_DATABASE_URL"]
puts <<~MSG
@@ -67,7 +67,7 @@ namespace 'openproject' do
entries = begin
connection = ActiveRecord::Base
- .establish_connection(ENV.fetch('BACKUP_DATABASE_URL', nil))
+ .establish_connection(ENV.fetch("BACKUP_DATABASE_URL", nil))
.connection
if connection.select_all(check_statement).any?
@@ -96,7 +96,7 @@ namespace 'openproject' do
next
end
- entries_string = entries.map { |entry| "(#{entry['id']}, #{entry['activity_id']})" }.join(', ')
+ entries_string = entries.map { |entry| "(#{entry['id']}, #{entry['activity_id']})" }.join(", ")
update_statement = <<~SQL
UPDATE time_entries
diff --git a/lib/tasks/version.rake b/lib/tasks/version.rake
index 32e8b7d6b373..8e387bf6f779 100644
--- a/lib/tasks/version.rake
+++ b/lib/tasks/version.rake
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'open_project/version'
-desc 'Displays the current version of OpenProject'
+require "open_project/version"
+desc "Displays the current version of OpenProject"
task :version do
puts OpenProject::VERSION.to_semver
end
diff --git a/lib/tasks/watchers.rake b/lib/tasks/watchers.rake
index 0d27b2b944f6..e984ed6b52ed 100644
--- a/lib/tasks/watchers.rake
+++ b/lib/tasks/watchers.rake
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-desc 'Removes watchers from what they can no longer view.'
+desc "Removes watchers from what they can no longer view."
namespace :redmine do
namespace :watchers do
diff --git a/lib/tasks/yardoc.rake b/lib/tasks/yardoc.rake
index fce28a76ca24..53ada3b9e709 100644
--- a/lib/tasks/yardoc.rake
+++ b/lib/tasks/yardoc.rake
@@ -27,21 +27,21 @@
#++
begin
- require 'yard'
+ require "yard"
YARD::Rake::YardocTask.new do |t|
- files = ['lib/**/*.rb', 'app/**/*.rb']
- files << Dir['vendor/plugins/**/*.rb'].reject { |f| f.include?('test') } # Exclude test files
+ files = ["lib/**/*.rb", "app/**/*.rb"]
+ files << Dir["vendor/plugins/**/*.rb"].reject { |f| f.include?("test") } # Exclude test files
t.files = files
- static_files = ['doc/CHANGELOG.rdoc',
- 'doc/COPYING.rdoc',
- 'doc/COPYRIGHT.rdoc',
- 'doc/INSTALL.rdoc',
- 'doc/RUNNING_TESTS.rdoc',
- 'doc/UPGRADING.rdoc'].join(',')
+ static_files = ["doc/CHANGELOG.rdoc",
+ "doc/COPYING.rdoc",
+ "doc/COPYRIGHT.rdoc",
+ "doc/INSTALL.rdoc",
+ "doc/RUNNING_TESTS.rdoc",
+ "doc/UPGRADING.rdoc"].join(",")
- t.options += ['--output-dir', './doc/app', '--files', static_files]
+ t.options += ["--output-dir", "./doc/app", "--files", static_files]
end
rescue LoadError
# yard not installed (gem install yard)
diff --git a/lib_static/open_project/appsignal.rb b/lib_static/open_project/appsignal.rb
index 5e08cf028efe..123be1d255a3 100644
--- a/lib_static/open_project/appsignal.rb
+++ b/lib_static/open_project/appsignal.rb
@@ -31,7 +31,7 @@ module Appsignal
module_function
def enabled?
- ENV['APPSIGNAL_ENABLED'] == 'true'
+ ENV["APPSIGNAL_ENABLED"] == "true"
end
def exception_handler(message, log_context = {})
diff --git a/lib_static/open_project/authentication.rb b/lib_static/open_project/authentication.rb
index b4758ce562fa..65f2fbb40e09 100644
--- a/lib_static/open_project/authentication.rb
+++ b/lib_static/open_project/authentication.rb
@@ -24,7 +24,7 @@
#
# See COPYRIGHT and LICENSE files for more details.
-require 'open_project/authentication/manager'
+require "open_project/authentication/manager"
module OpenProject
##
@@ -237,7 +237,7 @@ module WWWAuthenticate
module_function
def pick_auth_scheme(supported_schemes, default_scheme, request_headers = {})
- req_scheme = request_headers['HTTP_X_AUTHENTICATION_SCHEME']
+ req_scheme = request_headers["HTTP_X_AUTHENTICATION_SCHEME"]
if supported_schemes.include? req_scheme
req_scheme
@@ -247,11 +247,11 @@ def pick_auth_scheme(supported_schemes, default_scheme, request_headers = {})
end
def default_auth_scheme
- 'Basic'
+ "Basic"
end
def default_realm
- 'OpenProject API'
+ "OpenProject API"
end
def scope_realm(scope = nil)
diff --git a/lib_static/open_project/authentication/failure_app.rb b/lib_static/open_project/authentication/failure_app.rb
index b3b78981885e..f0b10392e32b 100644
--- a/lib_static/open_project/authentication/failure_app.rb
+++ b/lib_static/open_project/authentication/failure_app.rb
@@ -33,22 +33,22 @@ def handle_failure(warden)
end
def unauthorized(env)
- [401, unauthorized_header(env), ['unauthorized']]
+ [401, unauthorized_header(env), ["unauthorized"]]
end
def warden(env)
- env['warden']
+ env["warden"]
end
def warden_options(env)
- Hash(env['warden.options'])
+ Hash(env["warden.options"])
end
def unauthorized_header(env)
header = OpenProject::Authentication::WWWAuthenticate
.response_header(scope: scope(env), request_headers: env)
- { 'WWW-Authenticate' => header }
+ { "WWW-Authenticate" => header }
end
def scope(env)
diff --git a/lib_static/open_project/authentication/strategies/warden/anonymous_fallback.rb b/lib_static/open_project/authentication/strategies/warden/anonymous_fallback.rb
index c5fcc973dcdf..64a3589e0f2c 100644
--- a/lib_static/open_project/authentication/strategies/warden/anonymous_fallback.rb
+++ b/lib_static/open_project/authentication/strategies/warden/anonymous_fallback.rb
@@ -1,4 +1,4 @@
-require 'warden/basic_auth'
+require "warden/basic_auth"
module OpenProject
module Authentication
@@ -36,7 +36,7 @@ def authenticate_user(_username, _password)
private
def session
- env['rack.session']
+ env["rack.session"]
end
end
end
diff --git a/lib_static/open_project/authentication/strategies/warden/doorkeeper_oauth.rb b/lib_static/open_project/authentication/strategies/warden/doorkeeper_oauth.rb
index 3a4076f6578d..7e7fcbf06d60 100644
--- a/lib_static/open_project/authentication/strategies/warden/doorkeeper_oauth.rb
+++ b/lib_static/open_project/authentication/strategies/warden/doorkeeper_oauth.rb
@@ -1,4 +1,4 @@
-require 'doorkeeper/grape/authorization_decorator'
+require "doorkeeper/grape/authorization_decorator"
module OpenProject
module Authentication
@@ -17,7 +17,7 @@ def valid?
def authenticate!
token = ::Doorkeeper::OAuth::Token.authenticate(decorated_request,
*Doorkeeper.configuration.access_token_methods)
- return fail!('invalid token') unless token&.acceptable?(scope)
+ return fail!("invalid token") unless token&.acceptable?(scope)
if token.resource_owner_id.nil?
authenticate_client_credentials(token)
diff --git a/lib_static/open_project/authentication/strategies/warden/global_basic_auth.rb b/lib_static/open_project/authentication/strategies/warden/global_basic_auth.rb
index 9a0916672dd2..a28ebca96088 100644
--- a/lib_static/open_project/authentication/strategies/warden/global_basic_auth.rb
+++ b/lib_static/open_project/authentication/strategies/warden/global_basic_auth.rb
@@ -1,4 +1,4 @@
-require 'warden/basic_auth'
+require "warden/basic_auth"
module OpenProject
module Authentication
@@ -40,7 +40,7 @@ def self.configure!(config = openproject_config)
end
if config[:password].blank?
- raise ArgumentError, 'password must not be empty'
+ raise ArgumentError, "password must not be empty"
end
@configuration = config
diff --git a/lib_static/open_project/authentication/strategies/warden/session.rb b/lib_static/open_project/authentication/strategies/warden/session.rb
index 2ece36b4c2d1..6d8ec7ae5674 100644
--- a/lib_static/open_project/authentication/strategies/warden/session.rb
+++ b/lib_static/open_project/authentication/strategies/warden/session.rb
@@ -1,4 +1,4 @@
-require 'open_project/authentication/session_expiry'
+require "open_project/authentication/session_expiry"
module OpenProject
module Authentication
@@ -31,15 +31,15 @@ def authenticate!
end
def xml_request_header_set?
- request.env['HTTP_X_REQUESTED_WITH'.freeze] == 'XMLHttpRequest'.freeze
+ request.env["HTTP_X_REQUESTED_WITH".freeze] == "XMLHttpRequest".freeze
end
def user_id
- Hash(session)['user_id']
+ Hash(session)["user_id"]
end
def session
- env['rack.session']
+ env["rack.session"]
end
end
end
diff --git a/lib_static/open_project/authentication/strategies/warden/user_basic_auth.rb b/lib_static/open_project/authentication/strategies/warden/user_basic_auth.rb
index 93bf7bc3a66b..04b12cc103b5 100644
--- a/lib_static/open_project/authentication/strategies/warden/user_basic_auth.rb
+++ b/lib_static/open_project/authentication/strategies/warden/user_basic_auth.rb
@@ -1,4 +1,4 @@
-require 'warden/basic_auth'
+require "warden/basic_auth"
module OpenProject
module Authentication
@@ -13,7 +13,7 @@ module Warden
# as the user name and the API key as the password.
class UserBasicAuth < ::Warden::Strategies::BasicAuth
def self.user
- 'apikey'
+ "apikey"
end
def valid?
diff --git a/lib_static/open_project/configuration.rb b/lib_static/open_project/configuration.rb
index 1ef566bbb8fc..7595925fcd1a 100644
--- a/lib_static/open_project/configuration.rb
+++ b/lib_static/open_project/configuration.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative 'configuration/helpers'
-require_relative 'configuration/asset_host'
+require_relative "configuration/helpers"
+require_relative "configuration/asset_host"
module OpenProject
module Configuration
extend Helpers
- TRUE_VALUES = ['true', true, '1'].freeze
+ TRUE_VALUES = ["true", true, "1"].freeze
class << self
# Returns a configuration setting
@@ -49,7 +49,7 @@ def []=(name, value)
def cache_store_configuration
# rails defaults to :file_store, use :mem_cache_store when :memcache is configured in configuration.yml
# Also use :mem_cache_store for when :dalli_store is configured
- cache_store = self['rails_cache_store'].try(:to_sym)
+ cache_store = self["rails_cache_store"].try(:to_sym)
cache_config =
case cache_store
@@ -59,7 +59,7 @@ def cache_store_configuration
memcache_configuration
# default to :file_store
when NilClass, :file_store
- [:file_store, Rails.root.join('tmp/cache')]
+ [:file_store, Rails.root.join("tmp/cache")]
else
[cache_store]
end
@@ -72,8 +72,8 @@ def cache_store_configuration
def cache_store_parameters
mapping = {
- 'cache_expires_in_seconds' => %i[expires_in to_i],
- 'cache_namespace' => %i[namespace to_s]
+ "cache_expires_in_seconds" => %i[expires_in to_i],
+ "cache_namespace" => %i[namespace to_s]
}
parameters = {}
mapping.each_pair do |from, to|
@@ -89,12 +89,12 @@ def cache_store_parameters
def memcache_configuration
cache_config = [:mem_cache_store]
- cache_config << self['cache_memcache_server'] if self['cache_memcache_server']
+ cache_config << self["cache_memcache_server"] if self["cache_memcache_server"]
cache_config
end
def redis_cache_configuration
- url = String(self['cache_redis_url']).split(",").map(&:strip)
+ url = String(self["cache_redis_url"]).split(",").map(&:strip)
raise ArgumentError, "CACHE_SERVER is set to redis, but CACHE_REDIS_URL is not set." if url.blank?
[
@@ -109,7 +109,7 @@ def redis_cache_configuration
end
def method_missing(name, *, &)
- setting_name = name.to_s.sub(/\?$/, '')
+ setting_name = name.to_s.sub(/\?$/, "")
definition = Settings::Definition[setting_name]
@@ -123,7 +123,7 @@ def method_missing(name, *, &)
end
def respond_to_missing?(name, include_private = false)
- Settings::Definition.exists?(name.to_s.sub(/\?$/, '')) || super
+ Settings::Definition.exists?(name.to_s.sub(/\?$/, "")) || super
end
def define_config_methods(definition)
diff --git a/lib_static/open_project/configuration/helpers.rb b/lib_static/open_project/configuration/helpers.rb
index dc8cc35c6ded..2307e25abe92 100644
--- a/lib_static/open_project/configuration/helpers.rb
+++ b/lib_static/open_project/configuration/helpers.rb
@@ -35,7 +35,7 @@ module Helpers
def direct_uploads
return false unless direct_uploads_supported?
- self['direct_uploads']
+ self["direct_uploads"]
end
##
@@ -66,7 +66,7 @@ def using_amazon_s3?
end
def using_custom_remote_storage_hosts?
- self['remote_storage_upload_host'].present? && self['remote_storage_download_host'].present?
+ self["remote_storage_upload_host"].present? && self["remote_storage_download_host"].present?
end
def direct_uploads?
@@ -76,9 +76,9 @@ def direct_uploads?
# Augur connect host
def enterprise_trial_creation_host
if Rails.env.production?
- self['enterprise_trial_creation_host']
+ self["enterprise_trial_creation_host"]
else
- 'https://start.openproject-edge.com'
+ "https://start.openproject-edge.com"
end
end
@@ -95,13 +95,13 @@ def remote_storage_aws?
end
def remote_storage_upload_host
- self['remote_storage_upload_host'].presence ||
+ self["remote_storage_upload_host"].presence ||
(remote_storage_aws? && "#{fog_directory}.s3.amazonaws.com") ||
nil
end
def remote_storage_download_host
- self['remote_storage_download_host'].presence ||
+ self["remote_storage_download_host"].presence ||
(remote_storage_aws? && "#{fog_directory}.s3.#{fog_credentials[:region]}.amazonaws.com") ||
nil
end
@@ -115,7 +115,7 @@ def remote_storage_hosts
end
def attachments_storage_path
- Rails.root.join(self['attachments_storage_path'] || 'files')
+ Rails.root.join(self["attachments_storage_path"] || "files")
end
def use_iam_profile?
@@ -123,11 +123,11 @@ def use_iam_profile?
end
def fog_credentials
- (Hash(self['fog'])['credentials'] || {}).map { |key, value| [key.to_sym, value] }.to_h
+ (Hash(self["fog"])["credentials"] || {}).map { |key, value| [key.to_sym, value] }.to_h
end
def fog_directory
- Hash(self['fog'])['directory']
+ Hash(self["fog"])["directory"]
end
def file_uploader
@@ -135,7 +135,7 @@ def file_uploader
end
def hidden_menu_items
- menus = self['hidden_menu_items'].map do |label, nodes|
+ menus = self["hidden_menu_items"].map do |label, nodes|
[label, array(nodes)]
end
@@ -145,7 +145,7 @@ def hidden_menu_items
##
# Whether we're running a bim edition
def bim?
- self['edition'] == 'bim'
+ self["edition"] == "bim"
end
def available_file_uploaders
@@ -156,42 +156,42 @@ def available_file_uploaders
# Do not load Fog uploader unless configured,
# it will fail with missing configuration
unless OpenProject::Configuration.fog_credentials.empty?
- uploaders[:fog] = '::FogFileUploader'.constantize
+ uploaders[:fog] = "::FogFileUploader".constantize
end
uploaders
end
def web_workers
- Integer(web['workers'].presence)
+ Integer(web["workers"].presence)
end
def web_timeout
- Integer(ENV['RACK_TIMEOUT_SERVICE_TIMEOUT'].presence || web['timeout'].presence)
+ Integer(ENV["RACK_TIMEOUT_SERVICE_TIMEOUT"].presence || web["timeout"].presence)
end
def web_wait_timeout
- Integer(ENV['RACK_TIMEOUT_WAIT_TIMEOUT'].presence || web['wait_timeout'].presence)
+ Integer(ENV["RACK_TIMEOUT_WAIT_TIMEOUT"].presence || web["wait_timeout"].presence)
end
def web_min_threads
- Integer(ENV['RAILS_MIN_THREADS'].presence || web['min_threads'].presence)
+ Integer(ENV["RAILS_MIN_THREADS"].presence || web["min_threads"].presence)
end
def web_max_threads
- Integer(ENV['RAILS_MAX_THREADS'].presence || web['max_threads'].presence)
+ Integer(ENV["RAILS_MAX_THREADS"].presence || web["max_threads"].presence)
end
def statsd_host
- ENV['STATSD_HOST'].presence || statsd['host'].presence
+ ENV["STATSD_HOST"].presence || statsd["host"].presence
end
def statsd_port
- Integer(ENV['STATSD_PORT'].presence || statsd['port'].presence)
+ Integer(ENV["STATSD_PORT"].presence || statsd["port"].presence)
end
def lookbook_enabled?
- self['lookbook_enabled']
+ self["lookbook_enabled"]
end
private
@@ -201,7 +201,7 @@ def lookbook_enabled?
# Either the value already is an array or a string with values separated by spaces.
# In the latter case the string will be split and the values returned as an array.
def array(value)
- if value.is_a?(String) && value.include?(' ')
+ if value.is_a?(String) && value.include?(" ")
value.split
else
Array(value)
diff --git a/lib_static/open_project/database.rb b/lib_static/open_project/database.rb
index a46437f1f230..cb19c1744b08 100644
--- a/lib_static/open_project/database.rb
+++ b/lib_static/open_project/database.rb
@@ -25,7 +25,7 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'semantic'
+require "semantic"
module OpenProject
# This module provides some information about the currently used database
@@ -34,8 +34,8 @@ module OpenProject
# syntax differences.
module Database
- DB_VALUE_FALSE = 'f'.freeze
- DB_VALUE_TRUE = 't'.freeze
+ DB_VALUE_FALSE = "f".freeze
+ DB_VALUE_TRUE = "t".freeze
class InsufficientVersionError < StandardError; end
@@ -56,7 +56,7 @@ def self.supported_adapters
def self.required_version
{
numeric: 100000, # PG_VERSION_NUM
- string: '10.0.0'
+ string: "10.0.0"
}
end
@@ -64,7 +64,7 @@ def self.required_version
# Check pending database migrations
# and cache the result for up to one hour
def self.migrations_pending?(ensure_fresh: false)
- cache_key = OpenProject::Cache::CacheKey.key('database_migrations')
+ cache_key = OpenProject::Cache::CacheKey.key("database_migrations")
cached_result = Rails.cache.read(cache_key)
# Ensure cache is busted if result is positive or unset
@@ -168,13 +168,13 @@ def self.mysql?(_arg = nil)
# Set the +raw+ argument to true to return the unmangled string
# from the database.
def self.version(raw = false)
- @version ||= ActiveRecord::Base.connection.select_value('SELECT version()')
+ @version ||= ActiveRecord::Base.connection.select_value("SELECT version()")
raw ? @version : @version.match(/\APostgreSQL ([\d.]+)/i)[1]
end
def self.numeric_version
- ActiveRecord::Base.connection.select_value('SHOW server_version_num;').to_i
+ ActiveRecord::Base.connection.select_value("SHOW server_version_num;").to_i
end
# Return if the version of the underlying database engine is capable of TSVECTOR features, needed for full-text
diff --git a/lib_static/open_project/notifications.rb b/lib_static/open_project/notifications.rb
index 1aa73e1caad0..9d657b19e853 100644
--- a/lib_static/open_project/notifications.rb
+++ b/lib_static/open_project/notifications.rb
@@ -45,7 +45,7 @@ module Notifications
# @raises ArgumentError if no block is given.
def subscribe(name, clear_subscriptions: false, &block)
# if no block is given, raise an error
- raise ArgumentError, 'please provide a block as a callback' unless block
+ raise ArgumentError, "please provide a block as a callback" unless block
if clear_subscriptions
subscriptions[name].each do |sub|
diff --git a/lib_static/plugins/acts_as_attachable/init.rb b/lib_static/plugins/acts_as_attachable/init.rb
index 4f838b82a430..76c348ec5c98 100644
--- a/lib_static/plugins/acts_as_attachable/init.rb
+++ b/lib_static/plugins/acts_as_attachable/init.rb
@@ -26,5 +26,5 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.dirname(__FILE__) + '/lib/acts_as_attachable'
+require File.dirname(__FILE__) + "/lib/acts_as_attachable"
ActiveRecord::Base.include Redmine::Acts::Attachable
diff --git a/lib_static/plugins/acts_as_customizable/init.rb b/lib_static/plugins/acts_as_customizable/init.rb
index 2e49a5a27557..00ed9f5ddbfa 100644
--- a/lib_static/plugins/acts_as_customizable/init.rb
+++ b/lib_static/plugins/acts_as_customizable/init.rb
@@ -26,6 +26,6 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.dirname(__FILE__) + '/lib/acts_as_customizable'
-require File.dirname(__FILE__) + '/lib/human_attribute_name'
+require File.dirname(__FILE__) + "/lib/acts_as_customizable"
+require File.dirname(__FILE__) + "/lib/human_attribute_name"
ActiveRecord::Base.include Redmine::Acts::Customizable
diff --git a/lib_static/plugins/acts_as_event/init.rb b/lib_static/plugins/acts_as_event/init.rb
index 52f3facdfca0..6798887f35f4 100644
--- a/lib_static/plugins/acts_as_event/init.rb
+++ b/lib_static/plugins/acts_as_event/init.rb
@@ -26,5 +26,5 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.dirname(__FILE__) + '/lib/acts_as_event'
+require File.dirname(__FILE__) + "/lib/acts_as_event"
ActiveRecord::Base.include Redmine::Acts::Event
diff --git a/lib_static/plugins/acts_as_event/lib/acts_as_event.rb b/lib_static/plugins/acts_as_event/lib/acts_as_event.rb
index 63c80385db50..c7e97375de59 100644
--- a/lib_static/plugins/acts_as_event/lib/acts_as_event.rb
+++ b/lib_static/plugins/acts_as_event/lib/acts_as_event.rb
@@ -45,8 +45,8 @@ def acts_as_event(options = {})
title: :title,
description: :description,
author: :author,
- url: { controller: '/welcome' },
- name: Proc.new { ::I18n.t(name.underscore, scope: 'events') },
+ url: { controller: "/welcome" },
+ name: Proc.new { ::I18n.t(name.underscore, scope: "events") },
type: name.underscore.dasherize }
cattr_accessor :event_options
diff --git a/lib_static/plugins/acts_as_journalized/init.rb b/lib_static/plugins/acts_as_journalized/init.rb
index f01cea372593..b31f802d4330 100644
--- a/lib_static/plugins/acts_as_journalized/init.rb
+++ b/lib_static/plugins/acts_as_journalized/init.rb
@@ -26,5 +26,5 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'acts_as_journalized'
+require "acts_as_journalized"
ActiveRecord::Base.include(Acts::Journalized)
diff --git a/lib_static/plugins/acts_as_journalized/lib/acts/journalized/data_class.rb b/lib_static/plugins/acts_as_journalized/lib/acts/journalized/data_class.rb
index 835c9e01147a..f90b2708525f 100644
--- a/lib_static/plugins/acts_as_journalized/lib/acts/journalized/data_class.rb
+++ b/lib_static/plugins/acts_as_journalized/lib/acts/journalized/data_class.rb
@@ -12,7 +12,7 @@ module ClassMethods
def journal_class
namespace = name.deconstantize
- if namespace == 'Journal'
+ if namespace == "Journal"
self
else
"Journal::#{base_class.name}Journal".constantize
diff --git a/lib_static/plugins/acts_as_journalized/lib/acts/journalized/file_link_journal_differ.rb b/lib_static/plugins/acts_as_journalized/lib/acts/journalized/file_link_journal_differ.rb
index 2d9aaaa92600..d0d0f49dd93f 100644
--- a/lib_static/plugins/acts_as_journalized/lib/acts/journalized/file_link_journal_differ.rb
+++ b/lib_static/plugins/acts_as_journalized/lib/acts/journalized/file_link_journal_differ.rb
@@ -55,22 +55,22 @@ def changes_on_file_links(previous, current)
end
def all_file_link_ids(previous, current)
- current.pluck('file_link_id') | previous.pluck('file_link_id')
+ current.pluck("file_link_id") | previous.pluck("file_link_id")
end
def cleanup_changes(changes) = changes.reject { |_, (first, last)| first == last }
def pair_changes(ids, previous, current)
ids.index_with do |id|
- [select_journals(previous.select { |attributes| attributes['file_link_id'] == id }),
- select_journals(current.select { |attributes| attributes['file_link_id'] == id })]
+ [select_journals(previous.select { |attributes| attributes["file_link_id"] == id }),
+ select_journals(current.select { |attributes| attributes["file_link_id"] == id })]
end
end
def select_journals(journals)
return if journals.empty?
- journals.sort.map { |hash| hash.slice('link_name', 'storage_name') }.last
+ journals.sort.map { |hash| hash.slice("link_name", "storage_name") }.last
end
end
end
diff --git a/lib_static/plugins/acts_as_journalized/lib/acts/journalized/options.rb b/lib_static/plugins/acts_as_journalized/lib/acts/journalized/options.rb
index 1b8bd66d793f..999eaa113b14 100644
--- a/lib_static/plugins/acts_as_journalized/lib/acts/journalized/options.rb
+++ b/lib_static/plugins/acts_as_journalized/lib/acts/journalized/options.rb
@@ -101,7 +101,7 @@ def has_many_journals_options
def options_with_defaults(options)
{
- class_name: 'Journal',
+ class_name: "Journal",
dependent: :destroy,
foreign_key: :journable_id,
timestamp: :updated_at,
diff --git a/lib_static/plugins/acts_as_journalized/lib/journal_formatter.rb b/lib_static/plugins/acts_as_journalized/lib/journal_formatter.rb
index c9935fe0db70..1eb2e6d81ff2 100644
--- a/lib_static/plugins/acts_as_journalized/lib/journal_formatter.rb
+++ b/lib_static/plugins/acts_as_journalized/lib/journal_formatter.rb
@@ -49,16 +49,16 @@
# It provides the hooks to apply different formatting to the details
# of a specific journal.
-require_relative 'journal_formatter_cache'
-require_relative 'journal_formatter/base'
-require_relative 'journal_formatter/attribute'
-require_relative 'journal_formatter/datetime'
-require_relative 'journal_formatter/day_count'
-require_relative 'journal_formatter/decimal'
-require_relative 'journal_formatter/fraction'
-require_relative 'journal_formatter/id'
-require_relative 'journal_formatter/named_association'
-require_relative 'journal_formatter/plaintext'
+require_relative "journal_formatter_cache"
+require_relative "journal_formatter/base"
+require_relative "journal_formatter/attribute"
+require_relative "journal_formatter/datetime"
+require_relative "journal_formatter/day_count"
+require_relative "journal_formatter/decimal"
+require_relative "journal_formatter/fraction"
+require_relative "journal_formatter/id"
+require_relative "journal_formatter/named_association"
+require_relative "journal_formatter/plaintext"
module JournalFormatter
mattr_accessor :formatters, :registered_fields
diff --git a/lib_static/plugins/acts_as_journalized/lib/journal_formatter/base.rb b/lib_static/plugins/acts_as_journalized/lib/journal_formatter/base.rb
index dc490eef492f..7b0adeec29d2 100644
--- a/lib_static/plugins/acts_as_journalized/lib/journal_formatter/base.rb
+++ b/lib_static/plugins/acts_as_journalized/lib/journal_formatter/base.rb
@@ -67,10 +67,10 @@ def format_details(key, values, _options = {})
def format_html_details(label, old_value, value)
label = content_tag(:strong, label)
- old_value = content_tag('i', h(old_value)) if old_value.present?
- old_value = content_tag('strike', old_value) if old_value and value.blank?
- value = content_tag('i', h(value)) if value.present?
- value ||= ''
+ old_value = content_tag("i", h(old_value)) if old_value.present?
+ old_value = content_tag("strike", old_value) if old_value and value.blank?
+ value = content_tag("i", h(value)) if value.present?
+ value ||= ""
[label, old_value, value]
end
diff --git a/lib_static/plugins/acts_as_journalized/lib/journal_formatter/day_count.rb b/lib_static/plugins/acts_as_journalized/lib/journal_formatter/day_count.rb
index 7e6768e5033c..3fdf3927f4ab 100644
--- a/lib_static/plugins/acts_as_journalized/lib/journal_formatter/day_count.rb
+++ b/lib_static/plugins/acts_as_journalized/lib/journal_formatter/day_count.rb
@@ -29,7 +29,7 @@
module JournalFormatter
class DayCount < Attribute
def format_values(values)
- values.map { |v| I18n.t('datetime.distance_in_words.x_days', count: v.to_i) unless v.nil? }
+ values.map { |v| I18n.t("datetime.distance_in_words.x_days", count: v.to_i) unless v.nil? }
end
end
end
diff --git a/lib_static/plugins/acts_as_journalized/lib/journal_formatter/named_association.rb b/lib_static/plugins/acts_as_journalized/lib/journal_formatter/named_association.rb
index c74488aba0f2..aba45919c635 100644
--- a/lib_static/plugins/acts_as_journalized/lib/journal_formatter/named_association.rb
+++ b/lib_static/plugins/acts_as_journalized/lib/journal_formatter/named_association.rb
@@ -29,7 +29,7 @@
module JournalFormatter
class NamedAssociation < Attribute
def render(key_with_id, values, options = { html: true })
- key = key_with_id.to_s.delete_suffix('_id')
+ key = key_with_id.to_s.delete_suffix("_id")
label, old_value, value = format_details(key, values, cache: options[:cache])
if options[:html]
diff --git a/lib_static/plugins/acts_as_searchable/init.rb b/lib_static/plugins/acts_as_searchable/init.rb
index 1aeff22a2aad..feddfbdb7d66 100644
--- a/lib_static/plugins/acts_as_searchable/init.rb
+++ b/lib_static/plugins/acts_as_searchable/init.rb
@@ -26,5 +26,5 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.dirname(__FILE__) + '/lib/acts_as_searchable'
+require File.dirname(__FILE__) + "/lib/acts_as_searchable"
ActiveRecord::Base.include Redmine::Acts::Searchable
diff --git a/lib_static/plugins/acts_as_searchable/lib/acts_as_searchable.rb b/lib_static/plugins/acts_as_searchable/lib/acts_as_searchable.rb
index 24c7bed37ee6..6f036542b3e3 100644
--- a/lib_static/plugins/acts_as_searchable/lib/acts_as_searchable.rb
+++ b/lib_static/plugins/acts_as_searchable/lib/acts_as_searchable.rb
@@ -47,7 +47,7 @@ def acts_as_searchable(options = {})
self.searchable_options = options
if searchable_options[:columns].nil?
- raise ArgumentError, 'No searchable column defined.'
+ raise ArgumentError, "No searchable column defined."
end
searchable_options[:columns] = Array(searchable_options[:columns])
@@ -85,7 +85,7 @@ def search(tokens, projects = nil, options = {})
tokens = Array(tokens)
projects = [] << projects unless projects.nil? || projects.is_a?(Array)
- find_order = "#{searchable_options[:order_column]} " + (options[:before] ? 'DESC' : 'ASC')
+ find_order = "#{searchable_options[:order_column]} " + (options[:before] ? "DESC" : "ASC")
token_clauses = searchable_column_conditions
@@ -97,7 +97,7 @@ def search(tokens, projects = nil, options = {})
token_clauses += Array(searchable_custom_fields_conditions)
end
- sql = (["(#{token_clauses.join(' OR ')})"] * tokens.size).join(' AND ')
+ sql = (["(#{token_clauses.join(' OR ')})"] * tokens.size).join(" AND ")
if tsv_clauses.present?
sql << (" OR #{tsv_clauses.join(' OR ')}")
@@ -112,7 +112,7 @@ def search(tokens, projects = nil, options = {})
results = []
results_count = 0
- where(project_conditions.join(' AND ')).scoping do
+ where(project_conditions.join(" AND ")).scoping do
where(find_conditions)
.includes(searchable_options[:include])
.references(searchable_options[:references])
@@ -122,7 +122,7 @@ def search(tokens, projects = nil, options = {})
results = all
if options[:offset]
- results = results.where("(#{searchable_options[:date_column]} " + (options[:before] ? '<' : '>') + "'#{connection.quoted_date(options[:offset])}')")
+ results = results.where("(#{searchable_options[:date_column]} " + (options[:before] ? "<" : ">") + "'#{connection.quoted_date(options[:offset])}')")
end
results = results.limit(options[:limit]) if options[:limit]
end
@@ -160,7 +160,7 @@ def searchable_tsv_column_conditions(tokens)
tsv_condition =
OpenProject::FullTextSearch.tsv_where(tsv_column[:table_name],
tsv_column[:column_name],
- tokens.join(' '),
+ tokens.join(" "),
normalization: tsv_column[:normalization_type])
if tsv_column[:scope]
subquery_condition(tsv_column[:scope], tsv_condition)
@@ -175,7 +175,7 @@ def searchable_custom_fields_conditions
searchable: true).pluck(:id)
if searchable_custom_field_ids.any?
custom_field_condition =
- CustomValue.select('1').where(customized_type: name)
+ CustomValue.select("1").where(customized_type: name)
.where("customized_id=#{table_name}.id AND value ILIKE ?")
.where(custom_field_id: searchable_custom_field_ids)
diff --git a/lib_static/plugins/acts_as_watchable/init.rb b/lib_static/plugins/acts_as_watchable/init.rb
index 8f6c4a98b155..0a2265a04afc 100644
--- a/lib_static/plugins/acts_as_watchable/init.rb
+++ b/lib_static/plugins/acts_as_watchable/init.rb
@@ -27,7 +27,7 @@
#++
# Include hook code here
-require File.dirname(__FILE__) + '/lib/acts_as_watchable'
-require File.dirname(__FILE__) + '/lib/acts_as_watchable/routes.rb'
+require File.dirname(__FILE__) + "/lib/acts_as_watchable"
+require File.dirname(__FILE__) + "/lib/acts_as_watchable/routes.rb"
ActiveRecord::Base.include Redmine::Acts::Watchable
diff --git a/lib_static/plugins/load_path_helper.rb b/lib_static/plugins/load_path_helper.rb
index 927383e43979..76392582a1c1 100644
--- a/lib_static/plugins/load_path_helper.rb
+++ b/lib_static/plugins/load_path_helper.rb
@@ -29,7 +29,7 @@
module Plugins
module LoadPathHelper
def self.spec_load_paths
- plugin_load_paths.map { |path| File.join(path, 'spec') }
+ plugin_load_paths.map { |path| File.join(path, "spec") }
.keep_if { |path| File.directory?(path) }
end
diff --git a/lib_static/plugins/verification/Rakefile b/lib_static/plugins/verification/Rakefile
index 9694ba045e28..ac03d0c29f2d 100644
--- a/lib_static/plugins/verification/Rakefile
+++ b/lib_static/plugins/verification/Rakefile
@@ -1,22 +1,22 @@
-require 'rake'
-require 'rake/testtask'
-require 'rake/rdoctask'
+require "rake"
+require "rake/testtask"
+require "rake/rdoctask"
-desc 'Default: run unit tests.'
+desc "Default: run unit tests."
task default: :test
-desc 'Test the verification plugin.'
+desc "Test the verification plugin."
Rake::TestTask.new(:test) do |t|
- t.libs << 'lib'
- t.libs << 'test'
- t.pattern = 'test/**/*_test.rb'
+ t.libs << "lib"
+ t.libs << "test"
+ t.pattern = "test/**/*_test.rb"
end
-desc 'Generate documentation for the verification plugin.'
+desc "Generate documentation for the verification plugin."
Rake::RDocTask.new(:rdoc) do |rdoc|
- rdoc.rdoc_dir = 'rdoc'
- rdoc.title = 'Verification'
- rdoc.options << '--line-numbers' << '--inline-source'
- rdoc.rdoc_files.include('README')
- rdoc.rdoc_files.include('lib/**/*.rb')
+ rdoc.rdoc_dir = "rdoc"
+ rdoc.title = "Verification"
+ rdoc.options << "--line-numbers" << "--inline-source"
+ rdoc.rdoc_files.include("README")
+ rdoc.rdoc_files.include("lib/**/*.rb")
end
diff --git a/lib_static/plugins/verification/init.rb b/lib_static/plugins/verification/init.rb
index c8ead8716251..19db4135cee8 100644
--- a/lib_static/plugins/verification/init.rb
+++ b/lib_static/plugins/verification/init.rb
@@ -1,3 +1,3 @@
# Include hook code here
-require 'action_controller/verification'
+require "action_controller/verification"
diff --git a/lib_static/redmine/diff.rb b/lib_static/redmine/diff.rb
index 399eb69ea17d..9f2667b8b146 100644
--- a/lib_static/redmine/diff.rb
+++ b/lib_static/redmine/diff.rb
@@ -34,20 +34,20 @@ class Diff
attr_accessor :nb_line_left, :line_left, :nb_line_right, :line_right, :type_diff_right, :type_diff_left, :offsets
def initialize
- self.nb_line_left = ''
- self.nb_line_right = ''
- self.line_left = ''
- self.line_right = ''
- self.type_diff_right = ''
- self.type_diff_left = ''
+ self.nb_line_left = ""
+ self.nb_line_right = ""
+ self.line_left = ""
+ self.line_right = ""
+ self.type_diff_right = ""
+ self.type_diff_left = ""
end
def type_diff
- type_diff_right == 'diff_in' ? type_diff_right : type_diff_left
+ type_diff_right == "diff_in" ? type_diff_right : type_diff_left
end
def line
- type_diff_right == 'diff_in' ? line_right : line_left
+ type_diff_right == "diff_in" ? line_right : line_left
end
def html_line_left
@@ -63,7 +63,7 @@ def html_line
end
def inspect
- puts '### Start Line Diff ###'
+ puts "### Start Line Diff ###"
puts nb_line_left
puts line_left
puts nb_line_right
@@ -74,7 +74,7 @@ def inspect
def line_to_html(line, offsets)
line_to_html_raw(line, offsets).tap do |html_str|
- html_str.force_encoding('UTF-8')
+ html_str.force_encoding("UTF-8")
end
end
diff --git a/lib_static/redmine/diff/array_string_diff.rb b/lib_static/redmine/diff/array_string_diff.rb
index 372653a9e0e7..23df8bdeb7a0 100644
--- a/lib_static/redmine/diff/array_string_diff.rb
+++ b/lib_static/redmine/diff/array_string_diff.rb
@@ -159,11 +159,11 @@ def match(_ai, _bi)
end
def discarda(i, elem)
- @curdiffs.push ['-', i, elem]
+ @curdiffs.push ["-", i, elem]
end
def discardb(i, elem)
- @curdiffs.push ['+', i, elem]
+ @curdiffs.push ["+", i, elem]
end
def compact
diff --git a/lib_static/redmine/diff/diffable.rb b/lib_static/redmine/diff/diffable.rb
index 3612aa9d26c2..602ed6671537 100644
--- a/lib_static/redmine/diff/diffable.rb
+++ b/lib_static/redmine/diff/diffable.rb
@@ -85,7 +85,7 @@ def replacenextlarger(value, high = nil)
def patch(diff)
newary = nil
newary = if diff.difftype == String
- diff.difftype.new('')
+ diff.difftype.new("")
else
diff.difftype.new
end
@@ -94,14 +94,14 @@ def patch(diff)
diff.diffs.each do |d|
d.each do |mod|
case mod[0]
- when '-'
+ when "-"
while ai < mod[1]
newary << self[ai]
ai += 1
bi += 1
end
ai += 1
- when '+'
+ when "+"
while bi < mod[1]
newary << self[ai]
ai += 1
@@ -110,7 +110,7 @@ def patch(diff)
newary << mod[2]
bi += 1
else
- raise 'Unknown diff action'
+ raise "Unknown diff action"
end
end
end
diff --git a/lib_static/redmine/i18n.rb b/lib_static/redmine/i18n.rb
index 354dc007c44d..856fc67c9407 100644
--- a/lib_static/redmine/i18n.rb
+++ b/lib_static/redmine/i18n.rb
@@ -31,16 +31,16 @@ module I18n
include ActionView::Helpers::NumberHelper
IN_CONTEXT_TRANSLATION_CODE = :lol
- IN_CONTEXT_TRANSLATION_NAME = 'In-Context Crowdin Translation'.freeze
+ IN_CONTEXT_TRANSLATION_NAME = "In-Context Crowdin Translation".freeze
def self.included(base)
base.extend Redmine::I18n
end
def self.all_languages
- @@all_languages ||= Rails.root.glob('config/locales/**/*.yml')
- .map { |f| f.basename.to_s.split('.').first }
- .reject! { |l| l.start_with?('js-') }
+ @@all_languages ||= Rails.root.glob("config/locales/**/*.yml")
+ .map { |f| f.basename.to_s.split(".").first }
+ .reject! { |l| l.start_with?("js-") }
.uniq
.sort
end
@@ -63,7 +63,7 @@ def localized_float(number, locale: ::I18n.locale, precision: 2)
number_with_precision(number, locale:, precision:)
rescue StandardError => e
Rails.logger.error("Failed to localize float number #{number}: #{e}")
- ('%.2f' % hours.to_f)
+ ("%.2f" % hours.to_f)
end
def format_date(date)
@@ -143,16 +143,16 @@ def format_time(time, include_date = true)
else
(time.utc? ? time.to_time.localtime : time)
end
- (include_date ? "#{format_date(local)} " : '') +
+ (include_date ? "#{format_date(local)} " : "") +
(Setting.time_format.blank? ? ::I18n.l(local, format: :time) : local.strftime(Setting.time_format))
end
def day_name(day)
- ::I18n.t('date.day_names')[day % 7]
+ ::I18n.t("date.day_names")[day % 7]
end
def month_name(month)
- ::I18n.t('date.month_names')[month]
+ ::I18n.t("date.month_names")[month]
end
def valid_languages
@@ -189,8 +189,8 @@ def current_language
def all_attribute_translations(locale)
@cached_attribute_translations ||= {}
@cached_attribute_translations[locale] ||= begin
- general_attributes = ::I18n.t('attributes', locale:)
- ::I18n.t('activerecord.attributes',
+ general_attributes = ::I18n.t("attributes", locale:)
+ ::I18n.t("activerecord.attributes",
locale:).inject(general_attributes) do |attr_t, model_t|
attr_t.merge(model_t.last || {})
end
diff --git a/lib_static/rubocop/cop/open_project/add_preview_for_view_component.rb b/lib_static/rubocop/cop/open_project/add_preview_for_view_component.rb
index 0fd4f82ff286..4083b3407558 100644
--- a/lib_static/rubocop/cop/open_project/add_preview_for_view_component.rb
+++ b/lib_static/rubocop/cop/open_project/add_preview_for_view_component.rb
@@ -30,14 +30,14 @@
module RuboCop::Cop::OpenProject
class AddPreviewForViewComponent < RuboCop::Cop::Base
- COMPONENT_PATH = '/app/components/'
- PREVIEW_PATH = '/lookbook/previews/'
+ COMPONENT_PATH = "/app/components/"
+ PREVIEW_PATH = "/lookbook/previews/"
def on_class(node)
path = node.loc.expression.source_buffer.name
- return unless path.include?(COMPONENT_PATH) && path.end_with?('.rb')
+ return unless path.include?(COMPONENT_PATH) && path.end_with?(".rb")
- preview_path = path.sub(COMPONENT_PATH, PREVIEW_PATH).sub('.rb', '_preview.rb')
+ preview_path = path.sub(COMPONENT_PATH, PREVIEW_PATH).sub(".rb", "_preview.rb")
unless File.exist?(preview_path)
message = "Missing Lookbook preview for #{path}. Expected preview to exist at #{preview_path}."
diff --git a/lib_static/rubocop/cop/open_project/no_do_end_block_with_rspec_capybara_matcher_in_expect.rb b/lib_static/rubocop/cop/open_project/no_do_end_block_with_rspec_capybara_matcher_in_expect.rb
index 908be8973ce8..70160c2ff298 100644
--- a/lib_static/rubocop/cop/open_project/no_do_end_block_with_rspec_capybara_matcher_in_expect.rb
+++ b/lib_static/rubocop/cop/open_project/no_do_end_block_with_rspec_capybara_matcher_in_expect.rb
@@ -62,7 +62,7 @@ class NoDoEndBlockWithRSpecCapybaraMatcherInExpect < RuboCop::Cop::Base
["have_#{matcher_type}", "have_no_#{matcher_type}"]
end
- MSG = 'The `do .. end` block is associated with `to` and not with Capybara matcher `%s`.'.freeze
+ MSG = "The `do .. end` block is associated with `to` and not with Capybara matcher `%s`.".freeze
def_node_matcher :expect_to_with_block?, <<~PATTERN
# ruby-parse output
diff --git a/lib_static/rubocop/cop/open_project/use_service_result_factory_methods.rb b/lib_static/rubocop/cop/open_project/use_service_result_factory_methods.rb
index c51f19b8b2d9..5be797405c47 100644
--- a/lib_static/rubocop/cop/open_project/use_service_result_factory_methods.rb
+++ b/lib_static/rubocop/cop/open_project/use_service_result_factory_methods.rb
@@ -39,8 +39,8 @@ module RuboCop::Cop::OpenProject
class UseServiceResultFactoryMethods < RuboCop::Cop::Base
extend RuboCop::Cop::AutoCorrector
- MSG = 'Use ServiceResult.%s(...) instead of ServiceResult.new(success: %s, ...).'.freeze
- MSG_IMPLICIT_FAILURE = 'Use ServiceResult.failure instead of ServiceResult.new.'.freeze
+ MSG = "Use ServiceResult.%s(...) instead of ServiceResult.new(success: %s, ...).".freeze
+ MSG_IMPLICIT_FAILURE = "Use ServiceResult.failure instead of ServiceResult.new.".freeze
def_node_matcher :service_result_constructor?, <<~PATTERN
(send
@@ -104,7 +104,7 @@ def add_offense_if_explicit_success_argument(node)
def add_offense_for_implicit_failure(node)
add_offense(node.loc.selector, message: MSG_IMPLICIT_FAILURE) do |corrector|
- corrector.replace(node.loc.selector, 'failure')
+ corrector.replace(node.loc.selector, "failure")
end
end
@@ -113,7 +113,7 @@ def success_value(success_argument)
end
def factory_method(success_argument)
- success_argument.value.source == 'true' ? 'success' : 'failure'
+ success_argument.value.source == "true" ? "success" : "failure"
end
def removal_range(node, success_argument)
diff --git a/lookbook/previews/op_turbo/stream_component_preview.rb b/lookbook/previews/op_turbo/stream_component_preview.rb
index d58958d44658..3435051359ed 100644
--- a/lookbook/previews/op_turbo/stream_component_preview.rb
+++ b/lookbook/previews/op_turbo/stream_component_preview.rb
@@ -6,7 +6,7 @@ class StreamComponentPreview < Lookbook::Preview
# Renders a turbo-stream tag with given action and target
# @param _action select { choices: [append, prepend, replace, update, remove, before, after] }
# @param target text
- def default(_action: 'append', target: 'model_id')
+ def default(_action: "append", target: "model_id")
template = template_example_from_action(_action, target)
render_with_template(locals: { template:, action: _action, target: })
end
diff --git a/lookbook/previews/open_project/common/attribute_component_preview.rb b/lookbook/previews/open_project/common/attribute_component_preview.rb
index ab26e9b25adc..d2fc29903efb 100644
--- a/lookbook/previews/open_project/common/attribute_component_preview.rb
+++ b/lookbook/previews/open_project/common/attribute_component_preview.rb
@@ -5,9 +5,9 @@ class AttributeComponentPreview < Lookbook::Preview
# @param id
# @param name
# @param text
- def default(id: 'attribute_modal',
- name: 'Description',
- text: 'This button is only visible when the text is truncated or includes a figure or macro.')
+ def default(id: "attribute_modal",
+ name: "Description",
+ text: "This button is only visible when the text is truncated or includes a figure or macro.")
render OpenProject::Common::AttributeComponent.new(id, name, text)
end
end
diff --git a/lookbook/previews/open_project/common/dialog_preview.rb b/lookbook/previews/open_project/common/dialog_preview.rb
index 2bcfe75f238b..602a8e6fa790 100644
--- a/lookbook/previews/open_project/common/dialog_preview.rb
+++ b/lookbook/previews/open_project/common/dialog_preview.rb
@@ -34,10 +34,10 @@ class DialogPreview < Lookbook::Preview
# @param dialog_title
# @param dialog_id
# @param form_id
- def form(button_text: 'Show form dialog',
- dialog_title: 'Dialog title',
- dialog_id: 'dialog-id',
- form_id: 'form-id')
+ def form(button_text: "Show form dialog",
+ dialog_title: "Dialog title",
+ dialog_id: "dialog-id",
+ form_id: "form-id")
render_with_template(locals: { button_text:, dialog_title:, dialog_id:, form_id: })
end
@@ -45,10 +45,10 @@ def form(button_text: 'Show form dialog',
# @param dialog_title
# @param dialog_id
# @param message
- def confirmation(button_text: 'Show confirmation dialog',
- dialog_title: 'Do the action',
- dialog_id: 'dialog-id',
- message: 'Are you sure?')
+ def confirmation(button_text: "Show confirmation dialog",
+ dialog_title: "Do the action",
+ dialog_id: "dialog-id",
+ message: "Are you sure?")
render_with_template(locals: { button_text:, dialog_title:, dialog_id:, message: })
end
@@ -56,10 +56,10 @@ def confirmation(button_text: 'Show confirmation dialog',
# @param dialog_title
# @param dialog_id
# @param message
- def confirm_deletion(button_text: 'Delete XYZ',
- dialog_title: 'Delete XYZ',
- dialog_id: 'dialog-id',
- message: 'Are you sure you want to delete the item?')
+ def confirm_deletion(button_text: "Delete XYZ",
+ dialog_title: "Delete XYZ",
+ dialog_id: "dialog-id",
+ message: "Are you sure you want to delete the item?")
render_with_template(locals: { button_text:, dialog_title:, dialog_id:, message: })
end
end
diff --git a/lookbook/previews/open_project/common/duration_component_preview.rb b/lookbook/previews/open_project/common/duration_component_preview.rb
index 63d9f3f729f2..b558b48fe02f 100644
--- a/lookbook/previews/open_project/common/duration_component_preview.rb
+++ b/lookbook/previews/open_project/common/duration_component_preview.rb
@@ -6,7 +6,7 @@ class DurationComponentPreview < Lookbook::Preview
# @param type select { choices: [seconds, minutes, hours, days, weeks, months, years] }
# @param separator text
# @param abbreviated toggle
- def default(duration: 1234, type: :minutes, separator: ', ', abbreviated: false)
+ def default(duration: 1234, type: :minutes, separator: ", ", abbreviated: false)
render OpenProject::Common::DurationComponent.new(duration, type, separator:, abbreviated:)
end
@@ -15,7 +15,7 @@ def system_arguments
end
def iso8601
- render OpenProject::Common::DurationComponent.new('P3DT12H5M', :seconds, color: :subtle)
+ render OpenProject::Common::DurationComponent.new("P3DT12H5M", :seconds, color: :subtle)
end
end
end
diff --git a/lookbook/previews/open_project/common/filters_component_preview.rb b/lookbook/previews/open_project/common/filters_component_preview.rb
index 5af621b45fe4..2050984ab684 100644
--- a/lookbook/previews/open_project/common/filters_component_preview.rb
+++ b/lookbook/previews/open_project/common/filters_component_preview.rb
@@ -7,11 +7,11 @@ def default
render(Projects::ProjectsFiltersComponent.new(query: @query)) do |component|
component.with_button(
tag: :a,
- href: '',
+ href: "",
scheme: :primary,
size: :medium,
aria: { label: I18n.t(:label_project_new) },
- data: { 'test-selector': 'project-new-button' }
+ data: { "test-selector": "project-new-button" }
) do |button|
button.with_leading_visual_icon(icon: :plus)
Project.model_name.human
diff --git a/lookbook/previews/open_project/common/relative_time_component_preview.rb b/lookbook/previews/open_project/common/relative_time_component_preview.rb
index 2bc228ce2885..5c1d3dd5eaac 100644
--- a/lookbook/previews/open_project/common/relative_time_component_preview.rb
+++ b/lookbook/previews/open_project/common/relative_time_component_preview.rb
@@ -6,7 +6,7 @@ def default(datetime: (Time.now - 123456.seconds))
render OpPrimer::RelativeTimeComponent.new(datetime:)
end
- def german_locale(datetime: Time.parse('2023-10-25T09:06:03Z'))
+ def german_locale(datetime: Time.parse("2023-10-25T09:06:03Z"))
I18n.with_locale(:de) do
render OpPrimer::RelativeTimeComponent.new(datetime:)
end
diff --git a/lookbook/previews/open_project/common/submenu_component_preview.rb b/lookbook/previews/open_project/common/submenu_component_preview.rb
index 32578675ccda..3d88e3aef13a 100644
--- a/lookbook/previews/open_project/common/submenu_component_preview.rb
+++ b/lookbook/previews/open_project/common/submenu_component_preview.rb
@@ -9,21 +9,21 @@ def default
OpenProject::Menu::MenuGroup.new(
header: nil,
children: [
- OpenProject::Menu::MenuItem.new(title: I18n.t('members.menu.all'), href: '', selected: true),
- OpenProject::Menu::MenuItem.new(title: I18n.t('members.menu.locked'), href: '', selected: false),
- OpenProject::Menu::MenuItem.new(title: I18n.t('members.menu.invited'), href: '', selected: false)
+ OpenProject::Menu::MenuItem.new(title: I18n.t("members.menu.all"), href: "", selected: true),
+ OpenProject::Menu::MenuItem.new(title: I18n.t("members.menu.locked"), href: "", selected: false),
+ OpenProject::Menu::MenuItem.new(title: I18n.t("members.menu.invited"), href: "", selected: false)
]
),
OpenProject::Menu::MenuGroup.new(
- header: I18n.t('members.menu.project_roles'),
+ header: I18n.t("members.menu.project_roles"),
children: [
- OpenProject::Menu::MenuItem.new(title: 'ROLE X', href: '', selected: false)
+ OpenProject::Menu::MenuItem.new(title: "ROLE X", href: "", selected: false)
]
),
OpenProject::Menu::MenuGroup.new(
- header: I18n.t('members.menu.groups'),
+ header: I18n.t("members.menu.groups"),
children: [
- OpenProject::Menu::MenuItem.new(title: 'GROUP X', href: '', selected: false)
+ OpenProject::Menu::MenuItem.new(title: "GROUP X", href: "", selected: false)
]
)
]
diff --git a/lookbook/previews/open_project/deprecated/on_off_status_component_preview.rb b/lookbook/previews/open_project/deprecated/on_off_status_component_preview.rb
index 2ab8c002cfbc..c52f1657bec3 100644
--- a/lookbook/previews/open_project/deprecated/on_off_status_component_preview.rb
+++ b/lookbook/previews/open_project/deprecated/on_off_status_component_preview.rb
@@ -6,20 +6,20 @@ class OnOffStatusComponentPreview < Lookbook::Preview
def default
render ::Components::OnOffStatusComponent.new({
is_on: true,
- on_text: 'Is enabled',
- on_description: 'Text when enabled',
- off_text: 'Is disabled',
- off_description: 'Text when disabled'
+ on_text: "Is enabled",
+ on_description: "Text when enabled",
+ off_text: "Is disabled",
+ off_description: "Text when disabled"
})
end
def off
render ::Components::OnOffStatusComponent.new({
is_on: false,
- on_text: 'Is enabled',
- on_description: 'Text when enabled',
- off_text: 'Is disabled',
- off_description: 'Text when disabled'
+ on_text: "Is enabled",
+ on_description: "Text when enabled",
+ off_text: "Is disabled",
+ off_description: "Text when disabled"
})
end
end
diff --git a/lookbook/previews/open_project/storages/admin/oauth_access_grant_nudge_modal_component_preview.rb b/lookbook/previews/open_project/storages/admin/oauth_access_grant_nudge_modal_component_preview.rb
index 0eac94a0f167..ffeb552e93b5 100644
--- a/lookbook/previews/open_project/storages/admin/oauth_access_grant_nudge_modal_component_preview.rb
+++ b/lookbook/previews/open_project/storages/admin/oauth_access_grant_nudge_modal_component_preview.rb
@@ -6,7 +6,7 @@ class OAuthAccessGrantNudgeModalComponentPreview < Lookbook::Preview
# @param authorized toggle Denotes whether access has been granted and renders a success state
def default(authorized: false)
project_storage = FactoryBot.build_stubbed(:project_storage)
- render_with_template(locals: { project_storage:, authorized:, confirm_button_url: '#' })
+ render_with_template(locals: { project_storage:, authorized:, confirm_button_url: "#" })
end
end
end
diff --git a/modules/auth_plugins/lib/omni_auth/flexible_strategy.rb b/modules/auth_plugins/lib/omni_auth/flexible_strategy.rb
index f48399bcafb9..634176927f80 100644
--- a/modules/auth_plugins/lib/omni_auth/flexible_strategy.rb
+++ b/modules/auth_plugins/lib/omni_auth/flexible_strategy.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'open_project/plugins/auth_plugin'
+require "open_project/plugins/auth_plugin"
module OmniAuth
module FlexibleStrategy
diff --git a/modules/auth_plugins/lib/open_project/auth_plugins.rb b/modules/auth_plugins/lib/open_project/auth_plugins.rb
index dd0ae4678a2a..e88f61b4b166 100644
--- a/modules/auth_plugins/lib/open_project/auth_plugins.rb
+++ b/modules/auth_plugins/lib/open_project/auth_plugins.rb
@@ -28,9 +28,9 @@
module OpenProject
module AuthPlugins
- require 'open_project/plugins/auth_plugin'
- require 'omni_auth/flexible_builder'
- require 'omni_auth/flexible_strategy'
- require 'open_project/auth_plugins/engine'
+ require "open_project/plugins/auth_plugin"
+ require "omni_auth/flexible_builder"
+ require "omni_auth/flexible_strategy"
+ require "open_project/auth_plugins/engine"
end
end
diff --git a/modules/auth_plugins/lib/open_project/auth_plugins/engine.rb b/modules/auth_plugins/lib/open_project/auth_plugins/engine.rb
index 4710fdb474eb..b0bbbdf94b46 100644
--- a/modules/auth_plugins/lib/open_project/auth_plugins/engine.rb
+++ b/modules/auth_plugins/lib/open_project/auth_plugins/engine.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'open_project/plugins'
+require "open_project/plugins"
module OpenProject::AuthPlugins
class Engine < ::Rails::Engine
@@ -34,8 +34,8 @@ class Engine < ::Rails::Engine
include OpenProject::Plugins::ActsAsOpEngine
- register 'openproject-auth_plugins',
- author_url: 'https://www.openproject.org',
+ register "openproject-auth_plugins",
+ author_url: "https://www.openproject.org",
bundled: true
config.to_prepare do
diff --git a/modules/auth_plugins/lib/open_project/auth_plugins/hooks.rb b/modules/auth_plugins/lib/open_project/auth_plugins/hooks.rb
index 031c3df232a8..0c0effbaf9ad 100644
--- a/modules/auth_plugins/lib/open_project/auth_plugins/hooks.rb
+++ b/modules/auth_plugins/lib/open_project/auth_plugins/hooks.rb
@@ -28,7 +28,7 @@
module OpenProject::AuthPlugins
class Hooks < OpenProject::Hook::ViewListener
- render_on :view_account_login_auth_provider, partial: 'hooks/login/providers'
- render_on :view_layouts_base_html_head, partial: 'hooks/login/providers_css'
+ render_on :view_account_login_auth_provider, partial: "hooks/login/providers"
+ render_on :view_layouts_base_html_head, partial: "hooks/login/providers_css"
end
end
diff --git a/modules/auth_plugins/lib/open_project/plugins/auth_plugin.rb b/modules/auth_plugins/lib/open_project/plugins/auth_plugin.rb
index 642f7f30aaf5..050a735ce4ba 100644
--- a/modules/auth_plugins/lib/open_project/plugins/auth_plugin.rb
+++ b/modules/auth_plugins/lib/open_project/plugins/auth_plugin.rb
@@ -54,7 +54,7 @@ def self.providers_for(strategy)
def self.login_provider_for(user)
return unless user.identity_url
- provider_name = user.identity_url.split(':').first
+ provider_name = user.identity_url.split(":").first
find_provider_by_name(provider_name)
end
@@ -81,7 +81,7 @@ def self.filtered_strategies(strategy_key, options)
def self.filtered_strategy?(_strategy_key, provider)
name = provider[:name]&.to_s
- !EnterpriseToken.show_banners? || name == 'developer'
+ !EnterpriseToken.show_banners? || name == "developer"
end
def self.strategy_key(strategy)
diff --git a/modules/auth_plugins/lib/openproject-auth_plugins.rb b/modules/auth_plugins/lib/openproject-auth_plugins.rb
index 2d1d186cce7c..7efad25ca404 100644
--- a/modules/auth_plugins/lib/openproject-auth_plugins.rb
+++ b/modules/auth_plugins/lib/openproject-auth_plugins.rb
@@ -26,4 +26,4 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'open_project/auth_plugins'
+require "open_project/auth_plugins"
diff --git a/modules/auth_plugins/openproject-auth_plugins.gemspec b/modules/auth_plugins/openproject-auth_plugins.gemspec
index 960e2305f20e..0b85d8ea90c9 100644
--- a/modules/auth_plugins/openproject-auth_plugins.gemspec
+++ b/modules/auth_plugins/openproject-auth_plugins.gemspec
@@ -1,16 +1,16 @@
Gem::Specification.new do |s|
- s.name = 'openproject-auth_plugins'
- s.version = '1.0.0'
- s.authors = 'OpenProject GmbH'
- s.email = 'info@openproject.com'
- s.summary = 'OpenProject Auth Plugins'
- s.description = 'Integration of OmniAuth strategy providers for authentication in Openproject.'
- s.license = 'GPLv3'
+ s.name = "openproject-auth_plugins"
+ s.version = "1.0.0"
+ s.authors = "OpenProject GmbH"
+ s.email = "info@openproject.com"
+ s.summary = "OpenProject Auth Plugins"
+ s.description = "Integration of OmniAuth strategy providers for authentication in Openproject."
+ s.license = "GPLv3"
- s.files = Dir['{app,config,db,lib}/**/*'] + %w(doc/CHANGELOG.md README.md)
+ s.files = Dir["{app,config,db,lib}/**/*"] + %w(doc/CHANGELOG.md README.md)
- s.add_dependency 'omniauth', '~> 1.0'
+ s.add_dependency "omniauth", "~> 1.0"
- s.add_development_dependency 'rspec', '~> 2.14'
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.add_development_dependency "rspec", "~> 2.14"
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/auth_plugins/spec/features/auth_provider_spec.rb b/modules/auth_plugins/spec/features/auth_provider_spec.rb
index d841c69eda78..b00d99cd90d1 100644
--- a/modules/auth_plugins/spec/features/auth_provider_spec.rb
+++ b/modules/auth_plugins/spec/features/auth_provider_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'rendering the login buttons', :js do
+RSpec.describe "rendering the login buttons", :js do
let(:providers) do
[
- { name: 'mock_auth' }
+ { name: "mock_auth" }
]
end
@@ -39,15 +39,15 @@
allow(OpenProject::Plugins::AuthPlugin).to receive(:providers).and_return(providers)
end
- describe 'in a public project', with_settings: { login_required: false } do
+ describe "in a public project", with_settings: { login_required: false } do
let(:public_project) { build(:project, public: true) }
- it 'renders correctly' do
+ it "renders correctly" do
visit project_path(public_project)
- page.find('a', text: 'Sign in').click
- item = page.find('a.auth-provider', text: 'mock_auth')
- expect(item[:href]).to end_with '/auth/mock_auth'
+ page.find("a", text: "Sign in").click
+ item = page.find("a.auth-provider", text: "mock_auth")
+ expect(item[:href]).to end_with "/auth/mock_auth"
end
end
end
diff --git a/modules/auth_plugins/spec/requests/auth_plugins_spec.rb b/modules/auth_plugins/spec/requests/auth_plugins_spec.rb
index 2f44ae81ee72..56f906533842 100644
--- a/modules/auth_plugins/spec/requests/auth_plugins_spec.rb
+++ b/modules/auth_plugins/spec/requests/auth_plugins_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'open_project/auth_plugins'
+require "spec_helper"
+require "open_project/auth_plugins"
RSpec.describe OpenProject::Plugins::AuthPlugin, with_ee: %i[board_view] do
let(:dummy_engine_klass) do
@@ -35,13 +35,13 @@
end
let(:strategies) { {} }
let(:providers_a) do
- lambda { [{ name: 'a1' }, { name: 'a2' }] }
+ lambda { [{ name: "a1" }, { name: "a2" }] }
end
let(:providers_b) do
- lambda { [{ name: 'b1' }] }
+ lambda { [{ name: "b1" }] }
end
let(:providers_c) do
- lambda { [{ name: 'c1' }] }
+ lambda { [{ name: "c1" }] }
end
let(:middlewares) { [] }
@@ -59,11 +59,11 @@
}
allow(described_class).to receive(:strategies).and_return(strategies)
- allow(dummy_engine_klass).to receive(:engine_name).and_return('foobar')
+ allow(dummy_engine_klass).to receive(:engine_name).and_return("foobar")
allow(dummy_engine_klass).to receive(:initializer) { |_, &block| app.instance_eval(&block) }
end
- describe 'ProviderBuilder' do
+ describe "ProviderBuilder" do
before do
pa = providers_a.call
pb = providers_b.call
@@ -89,16 +89,16 @@
end
end
- it 'registers all strategies' do
+ it "registers all strategies" do
expect(strategies.keys.to_a).to eq %i[strategy_a strategy_b]
end
- it 'registers register each strategy (i.e. middleware) only once' do
+ it "registers register each strategy (i.e. middleware) only once" do
expect(middlewares.size).to eq 2
expect(middlewares).to eq %i[strategy_a strategy_b]
end
- it 'associates the correct providers with their respective strategies' do
+ it "associates the correct providers with their respective strategies" do
described_class.providers_for(:strategy_a)
expect(described_class.providers_for(:strategy_a)).to eq [providers_a.call, providers_c.call].flatten
expect(described_class.providers_for(:strategy_b)).to eq providers_b.call
diff --git a/modules/auth_plugins/spec/requests/flexible_strategy_spec.rb b/modules/auth_plugins/spec/requests/flexible_strategy_spec.rb
index 07afc46259bd..de4d14befb0d 100644
--- a/modules/auth_plugins/spec/requests/flexible_strategy_spec.rb
+++ b/modules/auth_plugins/spec/requests/flexible_strategy_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OmniAuth::FlexibleStrategy do
class MockStrategy
@@ -40,14 +40,14 @@ def request_phase
def env_for(url, opts = {})
Rack::MockRequest.env_for(url, opts).tap do |env|
- env['rack.session'] = {}
+ env["rack.session"] = {}
end
end
- let(:app) { ->(env) { [200, env, 'ok'] } }
+ let(:app) { ->(env) { [200, env, "ok"] } }
let(:middleware) { MockStrategy.new(app) }
- let(:provider_a) { { name: 'provider_a', identifier: 'a' } }
- let(:provider_b) { { name: 'provider_b', identifier: 'b' } }
+ let(:provider_a) { { name: "provider_a", identifier: "a" } }
+ let(:provider_b) { { name: "provider_b", identifier: "b" } }
before do
allow(OpenProject::Plugins::AuthPlugin).to receive(:providers_for).with(MockStrategy) {
@@ -55,49 +55,49 @@ def env_for(url, opts = {})
}
end
- describe 'request call' do
- it 'matches the registered providers' do
+ describe "request call" do
+ it "matches the registered providers" do
[provider_a, provider_b].each do |pro|
code, env = middleware.call env_for("http://www.example.com/auth/#{pro[:name]}")
- strategy = env['omniauth.strategy']
+ strategy = env["omniauth.strategy"]
# check that the correct provider has been initialised
expect(strategy.options.identifier).to eq pro[:identifier]
end
end
- it 'does not match other paths' do
- code, env = middleware.call env_for('http://www.example.com/auth/other_provider')
+ it "does not match other paths" do
+ code, env = middleware.call env_for("http://www.example.com/auth/other_provider")
- expect(env).not_to include 'omniauth.strategy' # no hit
+ expect(env).not_to include "omniauth.strategy" # no hit
end
end
- describe 'callback call' do
+ describe "callback call" do
before do
- allow_any_instance_of(MockStrategy).to receive(:callback_phase).and_return(['hit'])
+ allow_any_instance_of(MockStrategy).to receive(:callback_phase).and_return(["hit"])
end
- it 'matches the registered providers' do
+ it "matches the registered providers" do
[provider_a, provider_b].each do |pro|
code, = middleware.call env_for("http://www.example.com/auth/#{pro[:name]}/callback")
- expect(code).to eq 'hit'
+ expect(code).to eq "hit"
end
end
- it 'does not match other paths' do
- code, env = middleware.call env_for('http://www.example.com/auth/other_provider/callback')
+ it "does not match other paths" do
+ code, env = middleware.call env_for("http://www.example.com/auth/other_provider/callback")
expect(code).to eq 200
- expect(env).not_to include 'omniauth.strategy' # no hit
+ expect(env).not_to include "omniauth.strategy" # no hit
end
end
- describe 'calling strategies' do
+ describe "calling strategies" do
let(:provider_with_mapping) do
{
- name: 'provider_with_mapping',
+ name: "provider_with_mapping",
openproject_attribute_map: Proc.new do |auth|
{ uid: auth[:info][:myUsername], mail: auth[:extra][:raw_info][:myMail] }
end
@@ -105,8 +105,8 @@ def env_for(url, opts = {})
end
let(:auth_hash) do
{
- info: { myUsername: 'foo', myFullName: 'Foo Bar' },
- extra: { raw_info: { myMail: 'foo@example.com' } }
+ info: { myUsername: "foo", myFullName: "Foo Bar" },
+ extra: { raw_info: { myMail: "foo@example.com" } }
}
end
@@ -114,20 +114,20 @@ def env_for(url, opts = {})
middleware.providers = [provider_a, provider_with_mapping]
end
- context 'with a mapping set' do
- it 'returns an attribute hash' do
- _, env = middleware.call env_for('http://www.example.com/auth/provider_with_mapping')
+ context "with a mapping set" do
+ it "returns an attribute hash" do
+ _, env = middleware.call env_for("http://www.example.com/auth/provider_with_mapping")
- strategy = env['omniauth.strategy']
- expect(strategy.name).to eq('provider_with_mapping')
+ strategy = env["omniauth.strategy"]
+ expect(strategy.name).to eq("provider_with_mapping")
attribute_map = strategy.omniauth_hash_to_user_attributes(auth_hash)
- expect(attribute_map).to eq(uid: 'foo', mail: 'foo@example.com')
+ expect(attribute_map).to eq(uid: "foo", mail: "foo@example.com")
end
end
- context 'without a mapping set' do
- it 'returns an empty hash' do
- middleware.call env_for('http://www.example.com/auth/provider_a')
+ context "without a mapping set" do
+ it "returns an empty hash" do
+ middleware.call env_for("http://www.example.com/auth/provider_a")
attribute_map = middleware.omniauth_hash_to_user_attributes(auth_hash)
expect(attribute_map).to eq({})
diff --git a/modules/auth_plugins/spec/views/base.html.erb_spec.rb b/modules/auth_plugins/spec/views/base.html.erb_spec.rb
index 6c8be160c3d6..0b889b7ac432 100644
--- a/modules/auth_plugins/spec/views/base.html.erb_spec.rb
+++ b/modules/auth_plugins/spec/views/base.html.erb_spec.rb
@@ -26,31 +26,31 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'layouts/base' do
- describe 'authenticator plugin' do
+RSpec.describe "layouts/base" do
+ describe "authenticator plugin" do
include Redmine::MenuManager::MenuHelper
helper Redmine::MenuManager::MenuHelper
let(:anonymous) { build_stubbed(:anonymous) }
before do
- allow(view).to receive(:current_menu_item).and_return('overview')
+ allow(view).to receive(:current_menu_item).and_return("overview")
allow(view).to receive(:default_breadcrumb)
allow(view).to receive(:current_user).and_return anonymous
allow(OpenProject::Plugins::AuthPlugin).to receive(:providers).and_return([provider])
end
- context 'with an authenticator with given icon' do
+ context "with an authenticator with given icon" do
let(:provider) do
- { name: 'foob_auth', icon: 'image.png' }
+ { name: "foob_auth", icon: "image.png" }
end
before do
render
end
- it 'adds the CSS to render the icon' do
+ it "adds the CSS to render the icon" do
expect(rendered).to have_text(/background-image:(?:.*)image.png/)
end
end
diff --git a/modules/auth_plugins/spec/views/hooks/login/_providers.html.erb_spec.rb b/modules/auth_plugins/spec/views/hooks/login/_providers.html.erb_spec.rb
index 9704a2c5077f..aba4e9cc368b 100644
--- a/modules/auth_plugins/spec/views/hooks/login/_providers.html.erb_spec.rb
+++ b/modules/auth_plugins/spec/views/hooks/login/_providers.html.erb_spec.rb
@@ -26,34 +26,34 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'rendering the login buttons for all providers' do
+RSpec.describe "rendering the login buttons for all providers" do
let(:providers) do
[
- { name: 'mock_auth' },
- { name: 'test_auth', display_name: 'Test' },
- { name: 'foob_auth', icon: 'foobar.png' }
+ { name: "mock_auth" },
+ { name: "test_auth", display_name: "Test" },
+ { name: "foob_auth", icon: "foobar.png" }
]
end
before do
allow(OpenProject::Plugins::AuthPlugin).to receive(:providers).and_return(providers)
- render partial: 'hooks/login/providers', handlers: [:erb], formats: [:html]
+ render partial: "hooks/login/providers", handlers: [:erb], formats: [:html]
end
- it 'shows the mock_auth button with the name as its label' do
+ it "shows the mock_auth button with the name as its label" do
expect(rendered).to match /#{providers[0][:name]}/
end
- it 'shows the test_auth button with the given display_name as its label' do
+ it "shows the test_auth button with the given display_name as its label" do
expect(rendered).to match /#{providers[1][:display_name]}/
end
- context 'with relative url root', with_config: { rails_relative_url_root: '/foobar' } do
- it 'renders correctly' do
- expect(rendered).to include '/foobar/auth/mock_auth'
+ context "with relative url root", with_config: { rails_relative_url_root: "/foobar" } do
+ it "renders correctly" do
+ expect(rendered).to include "/foobar/auth/mock_auth"
end
end
end
diff --git a/modules/auth_saml/lib/open_project/auth_saml.rb b/modules/auth_saml/lib/open_project/auth_saml.rb
index acff9141c17c..4b478050337a 100644
--- a/modules/auth_saml/lib/open_project/auth_saml.rb
+++ b/modules/auth_saml/lib/open_project/auth_saml.rb
@@ -1,5 +1,5 @@
module OpenProject
module AuthSaml
- require 'open_project/auth_saml/engine'
+ require "open_project/auth_saml/engine"
end
end
diff --git a/modules/auth_saml/lib/openproject-auth_saml.rb b/modules/auth_saml/lib/openproject-auth_saml.rb
index 5c30b502dc4d..2b6c4fa39730 100644
--- a/modules/auth_saml/lib/openproject-auth_saml.rb
+++ b/modules/auth_saml/lib/openproject-auth_saml.rb
@@ -1 +1 @@
-require 'open_project/auth_saml'
+require "open_project/auth_saml"
diff --git a/modules/auth_saml/openproject-auth_saml.gemspec b/modules/auth_saml/openproject-auth_saml.gemspec
index aa82a8641de9..00f0550855e7 100644
--- a/modules/auth_saml/openproject-auth_saml.gemspec
+++ b/modules/auth_saml/openproject-auth_saml.gemspec
@@ -1,15 +1,15 @@
Gem::Specification.new do |s|
- s.name = 'openproject-auth_saml'
- s.version = '1.0.0'
- s.authors = 'Cyril Rohr'
- s.email = 'cyril.rohr@gmail.com'
- s.homepage = 'https://github.com/finnlabs/openproject-auth_saml'
- s.summary = 'OmniAuth SAML / Single-Sign On'
- s.description = 'Adds the OmniAuth SAML provider to OpenProject'
- s.license = 'MIT'
+ s.name = "openproject-auth_saml"
+ s.version = "1.0.0"
+ s.authors = "Cyril Rohr"
+ s.email = "cyril.rohr@gmail.com"
+ s.homepage = "https://github.com/finnlabs/openproject-auth_saml"
+ s.summary = "OmniAuth SAML / Single-Sign On"
+ s.description = "Adds the OmniAuth SAML provider to OpenProject"
+ s.license = "MIT"
- s.files = Dir['{app,lib}/**/*'] + %w(README.md)
+ s.files = Dir["{app,lib}/**/*"] + %w(README.md)
- s.add_dependency 'omniauth-saml', '~> 1.10.1'
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.add_dependency "omniauth-saml", "~> 1.10.1"
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/auth_saml/spec/lib/open_project/auth_saml_spec.rb b/modules/auth_saml/spec/lib/open_project/auth_saml_spec.rb
index 15e56eac81c3..4aff710610ec 100644
--- a/modules/auth_saml/spec/lib/open_project/auth_saml_spec.rb
+++ b/modules/auth_saml/spec/lib/open_project/auth_saml_spec.rb
@@ -1,5 +1,5 @@
-require File.dirname(__FILE__) + '/../../spec_helper'
-require 'open_project/auth_saml'
+require File.dirname(__FILE__) + "/../../spec_helper"
+require "open_project/auth_saml"
RSpec.describe OpenProject::AuthSaml do
before do
@@ -31,8 +31,8 @@
}
) do
it "contains the configuration from OpenProject::Configuration (or settings.yml) by default" do
- expect(config[:my_saml][:name]).to eq 'saml'
- expect(config[:my_saml][:display_name]).to eq 'My SSO'
+ expect(config[:my_saml][:name]).to eq "saml"
+ expect(config[:my_saml][:display_name]).to eq "My SSO"
end
context(
@@ -52,13 +52,13 @@
}
) do
it "overrides the existing configuration where defined" do
- expect(config[:my_saml][:name]).to eq 'saml'
- expect(config[:my_saml][:display_name]).to eq 'Your SSO'
+ expect(config[:my_saml][:name]).to eq "saml"
+ expect(config[:my_saml][:display_name]).to eq "Your SSO"
end
it "defines new providers if given" do
- expect(config[:new_saml][:name]).to eq 'new_saml'
- expect(config[:new_saml][:display_name]).to eq 'Another SAML'
+ expect(config[:new_saml][:name]).to eq "new_saml"
+ expect(config[:new_saml][:display_name]).to eq "Another SAML"
end
end
end
diff --git a/modules/auth_saml/spec/requests/saml_provider_callback_spec.rb b/modules/auth_saml/spec/requests/saml_provider_callback_spec.rb
index 9cecd9a5a43b..18f901de5fcd 100644
--- a/modules/auth_saml/spec/requests/saml_provider_callback_spec.rb
+++ b/modules/auth_saml/spec/requests/saml_provider_callback_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'SAML provider callback', with_ee: %i[openid_providers] do
+RSpec.describe "SAML provider callback", with_ee: %i[openid_providers] do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -42,32 +42,32 @@
{ SAMLResponse: saml_response }
end
- let(:issuer) { 'https://foobar.org' }
- let(:fingerprint) { 'b711a422a0579da630063cbfac448f90be5ae23f' }
+ let(:issuer) { "https://foobar.org" }
+ let(:fingerprint) { "b711a422a0579da630063cbfac448f90be5ae23f" }
let(:config) do
{
- 'name' => 'saml',
- 'display_name' => 'SAML',
- 'assertion_consumer_service_url' => 'http://localhost:3000/auth/saml/callback',
- 'issuer' => issuer,
- 'idp_cert_fingerprint' => fingerprint,
- 'idp_sso_target_url' => 'https://foobar.org/login',
- 'idp_slo_target_url' => 'https://foobar.org/logout',
- 'security' => {
- 'digest_method' => 'http://www.w3.org/2001/04/xmlenc#sha256',
- 'check_idp_cert_expiration' => false
+ "name" => "saml",
+ "display_name" => "SAML",
+ "assertion_consumer_service_url" => "http://localhost:3000/auth/saml/callback",
+ "issuer" => issuer,
+ "idp_cert_fingerprint" => fingerprint,
+ "idp_sso_target_url" => "https://foobar.org/login",
+ "idp_slo_target_url" => "https://foobar.org/logout",
+ "security" => {
+ "digest_method" => "http://www.w3.org/2001/04/xmlenc#sha256",
+ "check_idp_cert_expiration" => false
},
- 'attribute_statements' => {
- 'email' => ['email', 'urn:oid:0.9.2342.19200300.100.1.3'],
- 'login' => ['uid', 'email', 'urn:oid:0.9.2342.19200300.100.1.3'],
- 'first_name' => ['givenName', 'urn:oid:2.5.4.42'],
- 'last_name' => ['sn', 'urn:oid:2.5.4.4']
+ "attribute_statements" => {
+ "email" => ["email", "urn:oid:0.9.2342.19200300.100.1.3"],
+ "login" => ["uid", "email", "urn:oid:0.9.2342.19200300.100.1.3"],
+ "first_name" => ["givenName", "urn:oid:2.5.4.42"],
+ "last_name" => ["sn", "urn:oid:2.5.4.4"]
}
}
end
- let(:request) { post '/auth/saml/callback', body }
+ let(:request) { post "/auth/saml/callback", body }
subject do
Timecop.freeze("2023-04-19T09:37:00Z".to_datetime) { request }
@@ -79,31 +79,31 @@
}
end
- shared_examples 'request fails' do
- it 'redirects to the failure page' do
+ shared_examples "request fails" do
+ it "redirects to the failure page" do
expect(subject.status).to eq(302)
- expect(subject.headers['Location']).to eq("/auth/failure?message=invalid_ticket&strategy=saml")
+ expect(subject.headers["Location"]).to eq("/auth/failure?message=invalid_ticket&strategy=saml")
end
end
- it 'redirects user when no errors occured' do
+ it "redirects user when no errors occured" do
expect(subject.status).to eq(302)
- expect(subject.headers['Location']).to eq("http://example.org/two_factor_authentication/request")
+ expect(subject.headers["Location"]).to eq("http://example.org/two_factor_authentication/request")
end
- context 'with an invalid timestamp' do
+ context "with an invalid timestamp" do
subject do
Timecop.freeze("2023-04-15T09:37:00Z".to_datetime) do
request
end
end
- it_behaves_like 'request fails'
+ it_behaves_like "request fails"
end
- context 'with an invalid fingerprint' do
- let(:fingerprint) { 'invalid' }
+ context "with an invalid fingerprint" do
+ let(:fingerprint) { "invalid" }
- it_behaves_like 'request fails'
+ it_behaves_like "request fails"
end
end
diff --git a/modules/avatars/app/controllers/avatars/avatar_controller.rb b/modules/avatars/app/controllers/avatars/avatar_controller.rb
index f32fc0b71ec9..39dc2c32acf3 100644
--- a/modules/avatars/app/controllers/avatars/avatar_controller.rb
+++ b/modules/avatars/app/controllers/avatars/avatar_controller.rb
@@ -7,7 +7,7 @@ def show
send_file @avatar.diskfile,
filename: filename_for_content_disposition(@avatar.filename),
type: @avatar.content_type,
- disposition: 'inline'
+ disposition: "inline"
rescue StandardError => e
Rails.logger.error "Failed to render avatar for #{@avatar&.id}: #{e.message}"
head :not_found
diff --git a/modules/avatars/app/controllers/avatars/my_avatar_controller.rb b/modules/avatars/app/controllers/avatars/my_avatar_controller.rb
index 8d515c286cfc..5acbbdeb17ab 100644
--- a/modules/avatars/app/controllers/avatars/my_avatar_controller.rb
+++ b/modules/avatars/app/controllers/avatars/my_avatar_controller.rb
@@ -3,11 +3,11 @@ class MyAvatarController < BaseController
before_action :require_login
before_action :set_user
- layout 'my'
+ layout "my"
menu_item :avatar
def show
- render 'avatars/my/avatar'
+ render "avatars/my/avatar"
end
private
diff --git a/modules/avatars/app/controllers/avatars/users_controller.rb b/modules/avatars/app/controllers/avatars/users_controller.rb
index 6fccfc160e29..d4846468fc98 100644
--- a/modules/avatars/app/controllers/avatars/users_controller.rb
+++ b/modules/avatars/app/controllers/avatars/users_controller.rb
@@ -3,7 +3,7 @@ class UsersController < BaseController
before_action :require_admin
before_action :find_user
- layout 'admin', except: :show
+ layout "admin", except: :show
def show
redirect_to redirect_path
@@ -12,7 +12,7 @@ def show
private
def redirect_path
- edit_user_path(@user, tab: 'avatar')
+ edit_user_path(@user, tab: "avatar")
end
def find_user
diff --git a/modules/avatars/app/helpers/avatar_helper.rb b/modules/avatars/app/helpers/avatar_helper.rb
index 6f0e192c1d57..23a72db9b623 100644
--- a/modules/avatars/app/helpers/avatar_helper.rb
+++ b/modules/avatars/app/helpers/avatar_helper.rb
@@ -25,7 +25,7 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'gravatar_image_tag'
+require "gravatar_image_tag"
module AvatarHelper
include ::GravatarImageTag
@@ -45,11 +45,11 @@ module AvatarHelper
# Returns the avatar image tag for the given +user+ if avatars are enabled
# +user+ can be a User or a string that will be scanned for an email address (eg. 'joe ')
- def avatar(principal, size: 'default', hide_name: true, name_classes: '', **)
+ def avatar(principal, size: "default", hide_name: true, name_classes: "", **)
build_principal_avatar_tag(principal, size:, hide_name:, name_classes:, **)
rescue StandardError => e
Rails.logger.error "Failed to create avatar for #{principal}: #{e}"
- ''.html_safe
+ "".html_safe
end
def avatar_url(user, options = {})
@@ -58,11 +58,11 @@ def avatar_url(user, options = {})
elsif avatar_manager.gravatar_enabled?
build_gravatar_image_url user, options
else
- ''.html_safe
+ "".html_safe
end
rescue StandardError => e
Rails.logger.error "Failed to create avatar url for #{user}: #{e}"
- ''.html_safe
+ "".html_safe
end
def local_avatar?(user)
@@ -78,7 +78,7 @@ def avatar_manager
def build_gravatar_image_url(user, options = {})
mail = extract_email_address(user)
- raise ArgumentError.new('Invalid Mail') if mail.blank?
+ raise ArgumentError.new("Invalid Mail") if mail.blank?
opts = options.merge(gravatar: default_gravatar_options)
# gravatar_image_url expects gravatar options as second arg
@@ -99,7 +99,7 @@ def build_principal_avatar_tag(user, **)
id: user.id
}
- angular_component_tag 'opce-principal',
+ angular_component_tag "opce-principal",
class: tag_options[:class],
inputs: {
principal:,
@@ -107,13 +107,13 @@ def build_principal_avatar_tag(user, **)
size: tag_options[:size],
hideName: tag_options[:hide_name],
nameClasses: tag_options[:name_classes],
- title: tag_options.fetch(:title, '')
+ title: tag_options.fetch(:title, "")
}
end
def merge_default_avatar_options(user, options)
default_options = {
- size: 'default',
+ size: "default",
hide_name: true
}
diff --git a/modules/avatars/app/models/users/avatars.rb b/modules/avatars/app/models/users/avatars.rb
index 164e78dafa3a..f2918cd83b1e 100644
--- a/modules/avatars/app/models/users/avatars.rb
+++ b/modules/avatars/app/models/users/avatars.rb
@@ -29,7 +29,7 @@ module Avatars
class_methods do
def get_local_avatar(user_id)
- Attachment.find_by(container_id: user_id, container_type: 'Principal', description: 'avatar')
+ Attachment.find_by(container_id: user_id, container_type: "Principal", description: "avatar")
end
end
@@ -41,7 +41,7 @@ def reload(*args)
def local_avatar_attachment
defined?(@local_avatar_attachment) || begin
- @local_avatar_attachment = attachments.find_by(description: 'avatar')
+ @local_avatar_attachment = attachments.find_by(description: "avatar")
end
@local_avatar_attachment
@@ -53,7 +53,7 @@ def local_avatar_attachment=(file)
@local_avatar_attachment = Attachments::CreateService
.new(user: User.system, contract_class: EmptyContract)
- .call(file:, container: self, filename: file.original_filename, description: 'avatar')
+ .call(file:, container: self, filename: file.original_filename, description: "avatar")
.result
touch
diff --git a/modules/avatars/app/services/avatars/update_service.rb b/modules/avatars/app/services/avatars/update_service.rb
index 549c777d0a6d..0501de9aa781 100644
--- a/modules/avatars/app/services/avatars/update_service.rb
+++ b/modules/avatars/app/services/avatars/update_service.rb
@@ -1,4 +1,4 @@
-require 'fastimage'
+require "fastimage"
module ::Avatars
class UpdateService
diff --git a/modules/avatars/config/routes.rb b/modules/avatars/config/routes.rb
index 68dbc9272e5e..29da5f695560 100644
--- a/modules/avatars/config/routes.rb
+++ b/modules/avatars/config/routes.rb
@@ -1,14 +1,14 @@
Rails.application.routes.draw do
# Update my avatar
- scope 'my' do
- resource :avatar, controller: 'avatars/my_avatar', as: 'edit_my_avatar', only: %i[show update destroy]
+ scope "my" do
+ resource :avatar, controller: "avatars/my_avatar", as: "edit_my_avatar", only: %i[show update destroy]
end
# Get the current avatar
- get '/users/:id/avatar', controller: 'avatars/avatar', action: :show, as: 'user_avatar'
+ get "/users/:id/avatar", controller: "avatars/avatar", action: :show, as: "user_avatar"
# Update another user's avatar
- scope 'users/:id' do
- resource :avatar, controller: 'avatars/users', as: 'edit_user_avatar', only: %i[show update destroy]
+ scope "users/:id" do
+ resource :avatar, controller: "avatars/users", as: "edit_user_avatar", only: %i[show update destroy]
end
end
diff --git a/modules/avatars/lib/api/v3/users/user_avatar_api.rb b/modules/avatars/lib/api/v3/users/user_avatar_api.rb
index ae8804c6b7f1..dfd3395f723e 100644
--- a/modules/avatars/lib/api/v3/users/user_avatar_api.rb
+++ b/modules/avatars/lib/api/v3/users/user_avatar_api.rb
@@ -37,7 +37,7 @@ class UserAvatarAPI < ::API::OpenProjectAPI
set_cache_headers
end
- get '/avatar' do
+ get "/avatar" do
cache_seconds = @user == current_user ? nil : avatar_link_expires_in
if (local_avatar = local_avatar?(@user))
diff --git a/modules/avatars/lib/open_project/avatars/engine.rb b/modules/avatars/lib/open_project/avatars/engine.rb
index ec2264f77965..f171db497fcc 100644
--- a/modules/avatars/lib/open_project/avatars/engine.rb
+++ b/modules/avatars/lib/open_project/avatars/engine.rb
@@ -22,31 +22,31 @@ class Engine < ::Rails::Engine
include OpenProject::Plugins::ActsAsOpEngine
- register 'openproject-avatars',
- author_url: 'https://www.openproject.org',
+ register "openproject-avatars",
+ author_url: "https://www.openproject.org",
settings: {
default: {
enable_gravatars: !Rails.env.test?,
enable_local_avatars: !Rails.env.test?
},
- partial: 'settings/openproject_avatars',
+ partial: "settings/openproject_avatars",
menu_item: :user_avatars
},
bundled: true do
add_menu_item :my_menu, :avatar,
- { controller: '/avatars/my_avatar', action: 'show' },
- caption: ->(*) { I18n.t('avatars.label_avatar') },
+ { controller: "/avatars/my_avatar", action: "show" },
+ caption: ->(*) { I18n.t("avatars.label_avatar") },
if: ->(*) { ::OpenProject::Avatars::AvatarManager::avatars_enabled? },
- icon: 'image1'
+ icon: "image1"
end
- add_api_endpoint 'API::V3::Users::UsersAPI', :id do
+ add_api_endpoint "API::V3::Users::UsersAPI", :id do
mount ::API::V3::Users::UserAvatarAPI
end
add_tab_entry :user,
- name: 'avatar',
- partial: 'avatars/users/avatar_tab',
+ name: "avatar",
+ partial: "avatars/users/avatar_tab",
path: ->(params) { edit_user_path(params[:user], tab: :avatar) },
label: :label_avatar,
only_if: ->(*) { User.current.admin? && ::OpenProject::Avatars::AvatarManager.avatars_enabled? }
diff --git a/modules/avatars/lib/openproject-avatars.rb b/modules/avatars/lib/openproject-avatars.rb
index 333a86ce4969..7458724c7f19 100644
--- a/modules/avatars/lib/openproject-avatars.rb
+++ b/modules/avatars/lib/openproject-avatars.rb
@@ -1 +1 @@
-require 'open_project/avatars'
+require "open_project/avatars"
diff --git a/modules/avatars/openproject-avatars.gemspec b/modules/avatars/openproject-avatars.gemspec
index d05a3ef1201f..469c5ed82950 100644
--- a/modules/avatars/openproject-avatars.gemspec
+++ b/modules/avatars/openproject-avatars.gemspec
@@ -1,16 +1,16 @@
Gem::Specification.new do |s|
s.name = "openproject-avatars"
- s.version = '1.0.0'
+ s.version = "1.0.0"
s.authors = "OpenProject GmbH"
s.email = "info@openproject.com"
- s.summary = 'OpenProject Avatars'
- s.description = 'This plugin allows OpenProject users to upload a picture to be used ' \
- 'as an avatar or use registered images from Gravatar.'
- s.license = 'GPLv3'
+ s.summary = "OpenProject Avatars"
+ s.description = "This plugin allows OpenProject users to upload a picture to be used " \
+ "as an avatar or use registered images from Gravatar."
+ s.license = "GPLv3"
s.files = Dir["{app,config,db,lib}/**/*"] + %w(README.md)
- s.add_dependency 'fastimage', '~> 2.2.0'
- s.add_dependency 'gravatar_image_tag', '~> 1.2.0'
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.add_dependency "fastimage", "~> 2.2.0"
+ s.add_dependency "gravatar_image_tag", "~> 1.2.0"
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/avatars/spec/controllers/avatars/avatar_controller_spec.rb b/modules/avatars/spec/controllers/avatars/avatar_controller_spec.rb
index b510b99e11ea..e4dbd8bdd8aa 100644
--- a/modules/avatars/spec/controllers/avatars/avatar_controller_spec.rb
+++ b/modules/avatars/spec/controllers/avatars/avatar_controller_spec.rb
@@ -1,5 +1,5 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
-require File.expand_path(File.dirname(__FILE__) + '/../../shared_examples')
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
+require File.expand_path(File.dirname(__FILE__) + "/../../shared_examples")
RSpec.describe Avatars::AvatarController do
include_context "there are users with and without avatars"
@@ -9,18 +9,18 @@
allow(OpenProject::Avatars::AvatarManager).to receive(:local_avatars_enabled?).and_return enabled
end
- describe ':show' do
+ describe ":show" do
let(:redirect_path) { user_avatar_url(target_user.id) }
let(:action) { get :show, params: { id: target_user.id } }
- context 'as anonymous' do
+ context "as anonymous" do
let(:target_user) { user_with_avatar }
let(:current_user) { User.anonymous }
- it_behaves_like 'an action checked for required login'
+ it_behaves_like "an action checked for required login"
end
- describe 'when logged in' do
+ describe "when logged in" do
let(:user) { create(:user) }
before do
@@ -28,29 +28,29 @@
action
end
- context 'when avatars enabled' do
- context 'when user has avatar' do
+ context "when avatars enabled" do
+ context "when user has avatar" do
let(:target_user) { user_with_avatar }
- it 'renders the send file' do
+ it "renders the send file" do
expect(response.status).to eq 200
end
end
- context 'when user has no avatar' do
+ context "when user has no avatar" do
let(:target_user) { user_without_avatar }
- it 'renders 404' do
+ it "renders 404" do
expect(response.status).to eq 404
end
end
end
- context 'when avatars disabled' do
+ context "when avatars disabled" do
let(:enabled) { false }
let(:target_user) { user_with_avatar }
- it 'renders a 404' do
+ it "renders a 404" do
expect(response.status).to eq 404
end
end
diff --git a/modules/avatars/spec/controllers/avatars/my_controller_spec.rb b/modules/avatars/spec/controllers/avatars/my_controller_spec.rb
index 836a6c79e691..636327804265 100644
--- a/modules/avatars/spec/controllers/avatars/my_controller_spec.rb
+++ b/modules/avatars/spec/controllers/avatars/my_controller_spec.rb
@@ -1,5 +1,5 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
-require File.expand_path(File.dirname(__FILE__) + '/../../shared_examples')
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
+require File.expand_path(File.dirname(__FILE__) + "/../../shared_examples")
RSpec.describe Avatars::MyAvatarController do
include_context "there are users with and without avatars"
@@ -11,43 +11,43 @@
allow(OpenProject::Avatars::AvatarManager).to receive(:avatars_enabled?).and_return enabled
end
- describe '#show' do
+ describe "#show" do
before do
get :show
end
- it 'renders the edit action' do
+ it "renders the edit action" do
expect(response).to be_successful
- expect(response).to render_template 'avatars/my/avatar'
+ expect(response).to render_template "avatars/my/avatar"
end
end
- describe '#update' do
- context 'when not logged in' do
+ describe "#update" do
+ context "when not logged in" do
let(:user) { User.anonymous }
- it 'renders 403' do
+ it "renders 403" do
post :update
expect(response).to redirect_to signin_path(back_url: edit_my_avatar_url)
end
end
- context 'when not enabled' do
+ context "when not enabled" do
let(:enabled) { false }
- it 'renders 404' do
+ it "renders 404" do
post :update
expect(response.status).to eq 404
end
end
- it 'returns invalid method for post request' do
+ it "returns invalid method for post request" do
post :update
expect(response).not_to be_successful
expect(response.status).to eq 405
end
- it 'calls the service for put' do
+ it "calls the service for put" do
expect_any_instance_of(Avatars::UpdateService)
.to receive(:replace)
.and_return(ServiceResult.success)
@@ -57,7 +57,7 @@
expect(response.status).to eq 200
end
- it 'calls the service for put' do
+ it "calls the service for put" do
expect_any_instance_of(Avatars::UpdateService)
.to receive(:replace)
.and_return(ServiceResult.failure)
@@ -68,27 +68,27 @@
end
end
- describe '#delete' do
- it 'returns invalid method for post request' do
+ describe "#delete" do
+ it "returns invalid method for post request" do
post :destroy
expect(response).not_to be_successful
expect(response.status).to eq 405
end
- it 'calls the service for delete' do
+ it "calls the service for delete" do
expect_any_instance_of(Avatars::UpdateService)
.to receive(:destroy)
- .and_return(ServiceResult.success(result: 'message'))
+ .and_return(ServiceResult.success(result: "message"))
delete :destroy
- expect(flash[:notice]).to include 'message'
+ expect(flash[:notice]).to include "message"
expect(flash[:error]).not_to be_present
expect(response).to redirect_to controller.send :redirect_path
end
- it 'calls the service for delete' do
+ it "calls the service for delete" do
result = ServiceResult.failure
- result.errors.add :base, 'error'
+ result.errors.add :base, "error"
expect_any_instance_of(Avatars::UpdateService)
.to receive(:destroy)
@@ -97,7 +97,7 @@
delete :destroy
expect(response).not_to be_successful
expect(flash[:notice]).not_to be_present
- expect(flash[:error]).to include 'error'
+ expect(flash[:error]).to include "error"
expect(response).to redirect_to controller.send :redirect_path
end
end
diff --git a/modules/avatars/spec/controllers/avatars/users_controller_spec.rb b/modules/avatars/spec/controllers/avatars/users_controller_spec.rb
index e72e6b763b69..387803007d95 100644
--- a/modules/avatars/spec/controllers/avatars/users_controller_spec.rb
+++ b/modules/avatars/spec/controllers/avatars/users_controller_spec.rb
@@ -1,5 +1,5 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
-require File.expand_path(File.dirname(__FILE__) + '/../../shared_examples')
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
+require File.expand_path(File.dirname(__FILE__) + "/../../shared_examples")
RSpec.describe Avatars::UsersController do
include_context "there are users with and without avatars"
@@ -12,60 +12,60 @@
allow(OpenProject::Avatars::AvatarManager).to receive(:avatars_enabled?).and_return enabled
end
- describe ':show' do
+ describe ":show" do
let(:target_user) { user_without_avatar }
- context 'as admin' do
+ context "as admin" do
before do
get :show, params: { id: target_user.id }
end
- it 'renders the edit action' do
- expect(response).to redirect_to edit_user_path(target_user, tab: 'avatar')
+ it "renders the edit action" do
+ expect(response).to redirect_to edit_user_path(target_user, tab: "avatar")
end
end
- context 'as another user' do
+ context "as another user" do
let(:current_user) { create(:user) }
before do
get :show, params: { id: target_user.id }
end
- it 'renders 403' do
+ it "renders 403" do
expect(response.status).to eq 403
end
end
end
- describe '#update' do
+ describe "#update" do
let(:target_user) { user_without_avatar }
- context 'when not logged in' do
+ context "when not logged in" do
let(:current_user) { User.anonymous }
- it 'renders 403' do
+ it "renders 403" do
post :update, params: { id: target_user.id }
expect(response).to redirect_to signin_path(back_url: edit_user_avatar_url(target_user))
end
end
- context 'when not enabled' do
+ context "when not enabled" do
let(:enabled) { false }
- it 'renders 404' do
+ it "renders 404" do
put :update, params: { id: target_user.id }
expect(response.status).to eq 404
end
end
- it 'returns invalid method for post request' do
+ it "returns invalid method for post request" do
post :update, params: { id: target_user.id }
expect(response).not_to be_successful
expect(response.status).to eq 405
end
- it 'calls the service for put' do
+ it "calls the service for put" do
expect_any_instance_of(Avatars::UpdateService)
.to receive(:replace)
.and_return(ServiceResult.success)
@@ -75,7 +75,7 @@
expect(response.status).to eq 200
end
- it 'calls the service for put' do
+ it "calls the service for put" do
expect_any_instance_of(Avatars::UpdateService)
.to receive(:replace)
.and_return(ServiceResult.failure)
@@ -86,38 +86,38 @@
end
end
- describe '#delete' do
+ describe "#delete" do
let(:target_user) { user_without_avatar }
- context 'when not logged in' do
+ context "when not logged in" do
let(:current_user) { User.anonymous }
- it 'redirect to login' do
+ it "redirect to login" do
delete :destroy, params: { id: target_user.id }
expect(response).to redirect_to signin_path(back_url: edit_user_avatar_url(target_user))
end
end
- it 'returns invalid method for post request' do
+ it "returns invalid method for post request" do
post :destroy, params: { id: target_user.id }
expect(response).not_to be_successful
expect(response.status).to eq 405
end
- it 'calls the service for delete' do
+ it "calls the service for delete" do
expect_any_instance_of(Avatars::UpdateService)
.to receive(:destroy)
- .and_return(ServiceResult.success(result: 'message'))
+ .and_return(ServiceResult.success(result: "message"))
delete :destroy, params: { id: target_user.id }
- expect(flash[:notice]).to include 'message'
+ expect(flash[:notice]).to include "message"
expect(flash[:error]).not_to be_present
expect(response).to redirect_to controller.send :redirect_path
end
- it 'calls the service for delete' do
+ it "calls the service for delete" do
result = ServiceResult.failure
- result.errors.add :base, 'error'
+ result.errors.add :base, "error"
expect_any_instance_of(Avatars::UpdateService)
.to receive(:destroy)
@@ -126,7 +126,7 @@
delete :destroy, params: { id: target_user.id }
expect(response).not_to be_successful
expect(flash[:notice]).not_to be_present
- expect(flash[:error]).to include 'error'
+ expect(flash[:error]).to include "error"
expect(response).to redirect_to controller.send :redirect_path
end
end
diff --git a/modules/avatars/spec/factories/avatar_attachment_factory.rb b/modules/avatars/spec/factories/avatar_attachment_factory.rb
index 3568750e686b..2ea50145ae2c 100644
--- a/modules/avatars/spec/factories/avatar_attachment_factory.rb
+++ b/modules/avatars/spec/factories/avatar_attachment_factory.rb
@@ -1,12 +1,12 @@
FactoryBot.define do
- factory :avatar_attachment, class: 'Attachment' do
+ factory :avatar_attachment, class: "Attachment" do
author factory: :user
container factory: :work_package
description { "avatar" }
filename { "avatar.jpg" }
content_type { "image/jpeg" }
file do
- File.open(File.expand_path('../fixtures/valid.jpg', __dir__))
+ File.open(File.expand_path("../fixtures/valid.jpg", __dir__))
end
end
end
diff --git a/modules/avatars/spec/features/my_avatar_spec.rb b/modules/avatars/spec/features/my_avatar_spec.rb
index ebd46183184f..5724b0bd0102 100644
--- a/modules/avatars/spec/features/my_avatar_spec.rb
+++ b/modules/avatars/spec/features/my_avatar_spec.rb
@@ -1,7 +1,7 @@
-require 'spec_helper'
-require_relative 'shared_avatar_examples'
+require "spec_helper"
+require_relative "shared_avatar_examples"
-RSpec.describe 'My avatar management', :js do
+RSpec.describe "My avatar management", :js do
include Rails.application.routes.url_helpers
let(:user) { create(:user) }
@@ -12,21 +12,21 @@
login_as user
end
- it_behaves_like 'avatar management'
+ it_behaves_like "avatar management"
- describe 'none enabled' do
+ describe "none enabled" do
before do
allow(Setting)
.to receive(:plugin_openproject_avatars)
.and_return({})
end
- it 'renders 404 when visiting and does not render the menu item' do
+ it "renders 404 when visiting and does not render the menu item" do
visit edit_my_avatar_path
- expect(page).to have_text '[Error 404]'
+ expect(page).to have_text "[Error 404]"
visit my_account_path
- expect(page).to have_no_css '.avatar-menu-item'
+ expect(page).to have_no_css ".avatar-menu-item"
end
end
end
diff --git a/modules/avatars/spec/features/shared_avatar_examples.rb b/modules/avatars/spec/features/shared_avatar_examples.rb
index 5fccae30fa89..72fc8c3ee155 100644
--- a/modules/avatars/spec/features/shared_avatar_examples.rb
+++ b/modules/avatars/spec/features/shared_avatar_examples.rb
@@ -1,14 +1,14 @@
-require 'fastimage'
+require "fastimage"
-RSpec.shared_examples 'avatar management' do
- let(:image_base_path) { File.expand_path(File.dirname(__FILE__) + '/../fixtures/') }
+RSpec.shared_examples "avatar management" do
+ let(:image_base_path) { File.expand_path(File.dirname(__FILE__) + "/../fixtures/") }
let(:enable_gravatars) { false }
let(:enable_local_avatars) { false }
let(:plugin_settings) do
{
- 'enable_gravatars' => enable_gravatars,
- 'enable_local_avatars' => enable_local_avatars
+ "enable_gravatars" => enable_gravatars,
+ "enable_local_avatars" => enable_local_avatars
}
end
@@ -18,57 +18,57 @@
.and_return(plugin_settings)
end
- describe 'only gravatars enabled' do
+ describe "only gravatars enabled" do
let(:enable_gravatars) { true }
- it 'shows the gravatar avatar' do
+ it "shows the gravatar avatar" do
visit avatar_management_path
- expect(page).to have_css('.form--fieldset-legend', text: 'GRAVATAR')
- expect(page).to have_css('.avatars--current-gravatar')
+ expect(page).to have_css(".form--fieldset-legend", text: "GRAVATAR")
+ expect(page).to have_css(".avatars--current-gravatar")
# Local not rendered
- expect(page).to have_no_css('.form--fieldset-legend', text: 'CUSTOM AVATAR')
- expect(page).to have_no_css('.avatars--current-local-avatar', text: 'none')
+ expect(page).to have_no_css(".form--fieldset-legend", text: "CUSTOM AVATAR")
+ expect(page).to have_no_css(".avatars--current-local-avatar", text: "none")
end
end
- describe 'only local avatars enabled' do
+ describe "only local avatars enabled" do
let(:enable_local_avatars) { true }
- it 'can upload a new image' do
+ it "can upload a new image" do
visit avatar_management_path
- expect(page).to have_css('.form--fieldset-legend', text: 'CUSTOM AVATAR')
- expect(page).to have_css('.avatars--current-local-avatar', text: 'none')
+ expect(page).to have_css(".form--fieldset-legend", text: "CUSTOM AVATAR")
+ expect(page).to have_css(".avatars--current-local-avatar", text: "none")
# Gravatars not rendered
- expect(page).to have_no_css('.form--fieldset-legend', text: 'GRAVATAR')
+ expect(page).to have_no_css(".form--fieldset-legend", text: "GRAVATAR")
# Attach a new invalid image
- find_by_id('avatar_file_input').set UploadedFile.load_from(File.join(image_base_path, 'invalid.txt')).path
+ find_by_id("avatar_file_input").set UploadedFile.load_from(File.join(image_base_path, "invalid.txt")).path
# Expect error
- expect(page).to have_css('.form--label.-error')
- expect(page).to have_css('.avatars--error-pane', text: 'Allowed formats are jpg, png, gif')
+ expect(page).to have_css(".form--label.-error")
+ expect(page).to have_css(".avatars--error-pane", text: "Allowed formats are jpg, png, gif")
# Attach new image
visit avatar_management_path
- expect(page).to have_css('.avatars--current-local-avatar', text: 'none')
- find_by_id('avatar_file_input').set UploadedFile.load_from(File.join(image_base_path, 'too_big.jpg')).path
+ expect(page).to have_css(".avatars--current-local-avatar", text: "none")
+ find_by_id("avatar_file_input").set UploadedFile.load_from(File.join(image_base_path, "too_big.jpg")).path
# Expect not error, since ng-file-upload resizes the image
- expect(page).to have_no_css('.form--label.-error')
- expect(page).to have_no_css('.avatars--error-pane span')
+ expect(page).to have_no_css(".form--label.-error")
+ expect(page).to have_no_css(".avatars--error-pane span")
# Expect preview
- expect(page).to have_css('.preview img')
+ expect(page).to have_css(".preview img")
# Click button
- click_on 'Update'
+ click_on "Update"
# Expect avatar rendered
- expect(page).to have_css('.form--fieldset-legend', text: 'CUSTOM AVATAR')
- avatar_tag = find('.avatars--current-local-avatar img')
+ expect(page).to have_css(".form--fieldset-legend", text: "CUSTOM AVATAR")
+ avatar_tag = find(".avatars--current-local-avatar img")
expect(avatar_tag[:src]).to include user_avatar_path(target_user)
# Expect the avatar to be resized
@@ -79,27 +79,27 @@
# Delete the avatar
accept_alert do
- find('.avatars--local-avatar-delete-link').click
+ find(".avatars--local-avatar-delete-link").click
end
- expect(page).to have_css('.avatars--current-local-avatar', text: 'none', wait: 20)
+ expect(page).to have_css(".avatars--current-local-avatar", text: "none", wait: 20)
end
end
- describe 'both local avatars enabled' do
+ describe "both local avatars enabled" do
let(:enable_gravatars) { true }
let(:enable_local_avatars) { true }
- it 'renders both sections' do
+ it "renders both sections" do
visit avatar_management_path
# Gravatar
- expect(page).to have_css('.form--fieldset-legend', text: 'GRAVATAR')
- expect(page).to have_css('.avatars--current-gravatar')
+ expect(page).to have_css(".form--fieldset-legend", text: "GRAVATAR")
+ expect(page).to have_css(".avatars--current-gravatar")
# Local
- expect(page).to have_css('.form--fieldset-legend', text: 'CUSTOM AVATAR')
- expect(page).to have_css('.avatars--current-local-avatar', text: 'none')
+ expect(page).to have_css(".form--fieldset-legend", text: "CUSTOM AVATAR")
+ expect(page).to have_css(".avatars--current-local-avatar", text: "none")
end
end
end
diff --git a/modules/avatars/spec/features/user_avatar_spec.rb b/modules/avatars/spec/features/user_avatar_spec.rb
index 4f8ba9fbcfbc..8259b67d33c1 100644
--- a/modules/avatars/spec/features/user_avatar_spec.rb
+++ b/modules/avatars/spec/features/user_avatar_spec.rb
@@ -1,43 +1,43 @@
-require 'spec_helper'
-require_relative 'shared_avatar_examples'
+require "spec_helper"
+require_relative "shared_avatar_examples"
-RSpec.describe 'User avatar management', :js do
+RSpec.describe "User avatar management", :js do
include Rails.application.routes.url_helpers
let(:user) { create(:admin) }
- let(:avatar_management_path) { edit_user_path(target_user, tab: 'avatar') }
+ let(:avatar_management_path) { edit_user_path(target_user, tab: "avatar") }
before do
login_as user
end
- context 'when user is admin' do
+ context "when user is admin" do
let(:target_user) { create(:user) }
- it_behaves_like 'avatar management'
+ it_behaves_like "avatar management"
end
- context 'when user is self' do
+ context "when user is self" do
let(:user) { create(:user) }
let(:target_user) { user }
- it 'forbids the user to access' do
+ it "forbids the user to access" do
visit avatar_management_path
- expect(page).to have_text('[Error 403]')
+ expect(page).to have_text("[Error 403]")
end
end
- context 'when user is another user' do
+ context "when user is another user" do
let(:target_user) { create(:user) }
let(:user) { create(:user) }
- it 'forbids the user to access' do
+ it "forbids the user to access" do
visit avatar_management_path
- expect(page).to have_text('[Error 403]')
+ expect(page).to have_text("[Error 403]")
end
end
- describe 'none enabled' do
+ describe "none enabled" do
let(:target_user) { create(:user) }
before do
@@ -46,9 +46,9 @@
.and_return({})
end
- it 'does not render the user edit tab' do
+ it "does not render the user edit tab" do
visit edit_user_path(user)
- expect(page).to have_no_css '#tab-avatar'
+ expect(page).to have_no_css "#tab-avatar"
end
end
end
diff --git a/modules/avatars/spec/helpers/avatar_helper_spec.rb b/modules/avatars/spec/helpers/avatar_helper_spec.rb
index 1a09bdfb6ffa..bee8c25b06e6 100644
--- a/modules/avatars/spec/helpers/avatar_helper_spec.rb
+++ b/modules/avatars/spec/helpers/avatar_helper_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe AvatarHelper, with_settings: { protocol: 'http' } do
+RSpec.describe AvatarHelper, with_settings: { protocol: "http" } do
include AngularHelper
let(:user) { build_stubbed(:user) }
@@ -11,8 +11,8 @@
let(:enable_local_avatars) { false }
let(:plugin_settings) do
{
- 'enable_gravatars' => enable_gravatars,
- 'enable_local_avatars' => enable_local_avatars
+ "enable_gravatars" => enable_gravatars,
+ "enable_local_avatars" => enable_local_avatars
}
end
@@ -31,14 +31,14 @@ def expected_user_avatar_tag(user)
id: user.id
}
- angular_component_tag 'opce-principal',
+ angular_component_tag "opce-principal",
inputs: {
principal:,
hideName: true,
- nameClasses: '',
+ nameClasses: "",
link: nil,
title: user.name,
- size: 'default'
+ size: "default"
}
end
@@ -51,16 +51,16 @@ def gravatar_expected_url(digest, options = {})
host =
if ssl
- 'https://secure.gravatar.com'
+ "https://secure.gravatar.com"
else
- 'http://gravatar.com'
+ "http://gravatar.com"
end
"#{host}/avatar/#{digest}?default=404&secure=#{ssl}"
end
- describe 'gravatar and local' do
- context 'when enabled' do
+ describe "gravatar and local" do
+ context "when enabled" do
let(:enable_gravatars) { true }
let(:enable_local_avatars) { true }
@@ -75,7 +75,7 @@ def gravatar_expected_url(digest, options = {})
end
end
- context 'when gravatar disabled' do
+ context "when gravatar disabled" do
let(:enable_gravatars) { false }
let(:enable_local_avatars) { true }
@@ -84,7 +84,7 @@ def gravatar_expected_url(digest, options = {})
end
end
- context 'when all disabled' do
+ context "when all disabled" do
let(:enable_gravatars) { false }
let(:enable_local_avatars) { false }
@@ -94,8 +94,8 @@ def gravatar_expected_url(digest, options = {})
end
end
- describe '#avatar_url' do
- context 'when enabled' do
+ describe "#avatar_url" do
+ context "when enabled" do
let(:enable_gravatars) { true }
let(:enable_local_avatars) { true }
@@ -110,7 +110,7 @@ def gravatar_expected_url(digest, options = {})
end
end
- context 'when gravatar disabled' do
+ context "when gravatar disabled" do
let(:enable_gravatars) { false }
let(:enable_local_avatars) { true }
@@ -119,94 +119,94 @@ def gravatar_expected_url(digest, options = {})
end
end
- context 'when all disabled' do
+ context "when all disabled" do
let(:enable_gravatars) { false }
let(:enable_local_avatars) { false }
it "returns blank" do
- expect(helper.avatar_url(user)).to eq ''
+ expect(helper.avatar_url(user)).to eq ""
end
end
end
- context 'when gravatar enabled' do
+ context "when gravatar enabled" do
let(:enable_gravatars) { true }
let(:enable_local_avatars) { false }
- describe 'ssl dependent on protocol settings' do
- context 'with https protocol', with_config: { https: true } do
+ describe "ssl dependent on protocol settings" do
+ context "with https protocol", with_config: { https: true } do
it "is set to secure if protocol is 'https'" do
expect(helper.default_gravatar_options[:secure]).to be true
end
end
- context 'with http protocol', with_config: { https: false } do
+ context "with http protocol", with_config: { https: false } do
it "is set to unsecure if protocol is 'http'" do
expect(helper.default_gravatar_options[:secure]).to be false
end
end
end
- context 'with http', with_config: { https: false } do
- it 'returns a gravatar image tag if a user is provided' do
+ context "with http", with_config: { https: false } do
+ it "returns a gravatar image tag if a user is provided" do
expect(helper.avatar(user)).to be_html_eql(expected_user_avatar_tag(user))
end
- it 'returns a gravatar url if a user is provided' do
+ it "returns a gravatar url if a user is provided" do
expect(helper.avatar_url(user)).to eq(gravatar_expected_url(mail_digest))
end
end
- context 'with https', with_config: { https: true } do
- it 'returns a gravatar image tag without ssl if the request was no ssl required' do
+ context "with https", with_config: { https: true } do
+ it "returns a gravatar image tag without ssl if the request was no ssl required" do
expect(helper.avatar(user)).to be_html_eql(expected_user_avatar_tag(user))
end
- it 'returns a gravatar image tag with ssl if the request was ssl required' do
+ it "returns a gravatar image tag with ssl if the request was ssl required" do
expect(helper.avatar_url(user)).to eq(gravatar_expected_url(mail_digest, ssl: true))
end
end
- it 'returns an empty string if a non parsable (e-mail) string is provided' do
- expect(helper.avatar('just the name')).to eq('')
+ it "returns an empty string if a non parsable (e-mail) string is provided" do
+ expect(helper.avatar("just the name")).to eq("")
end
- it 'returns an empty string if nil is provided' do
- expect(helper.avatar(nil)).to eq('')
+ it "returns an empty string if nil is provided" do
+ expect(helper.avatar(nil)).to eq("")
end
- it 'returns an empty string if a parsable e-mail with default avatar is provided' do
- mail = ''
+ it "returns an empty string if a parsable e-mail with default avatar is provided" do
+ mail = ""
- expect(helper.avatar(mail)).to eq('')
+ expect(helper.avatar(mail)).to eq("")
end
- it 'returns an empty string if a non parsable (e-mail) string url is provided' do
- expect(helper.avatar_url('just the name')).to eq('')
+ it "returns an empty string if a non parsable (e-mail) string url is provided" do
+ expect(helper.avatar_url("just the name")).to eq("")
end
- it 'returns an empty string if nil url is provided' do
- expect(helper.avatar_url(nil)).to eq('')
+ it "returns an empty string if nil url is provided" do
+ expect(helper.avatar_url(nil)).to eq("")
end
end
- context 'when all disabled' do
+ context "when all disabled" do
let(:enable_gravatars) { false }
let(:enable_local_avatars) { false }
- it 'returns an empty string for avatar if gravatar is disabled' do
+ it "returns an empty string for avatar if gravatar is disabled" do
expect(helper.avatar(user)).to be_html_eql(expected_user_avatar_tag(user))
end
- it 'returns an empty string for avatar_url if gravatar is disabled' do
- expect(helper.avatar_url(user)).to eq('')
+ it "returns an empty string for avatar_url if gravatar is disabled" do
+ expect(helper.avatar_url(user)).to eq("")
end
end
- context 'with system user' do
+ context "with system user" do
let(:user) { User.system }
- it 'renders the avatar as user type (Regression #37278)' do
+ it "renders the avatar as user type (Regression #37278)" do
expect(helper.avatar(user)).to be_html_eql(expected_user_avatar_tag(user))
end
end
diff --git a/modules/avatars/spec/lib/api/v3/users/user_representer_spec.rb b/modules/avatars/spec/lib/api/v3/users/user_representer_spec.rb
index 7e7897dde6e5..9a8c37ee17f0 100644
--- a/modules/avatars/spec/lib/api/v3/users/user_representer_spec.rb
+++ b/modules/avatars/spec/lib/api/v3/users/user_representer_spec.rb
@@ -26,40 +26,40 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Users::UserRepresenter do
let(:user) { build_stubbed(:user, status: 1) }
let(:current_user) { build_stubbed(:user) }
let(:representer) { described_class.create(user, current_user:) }
- context 'generation' do
+ context "generation" do
subject(:generated) { representer.to_json }
- describe 'avatar', with_settings: { protocol: 'http' } do
+ describe "avatar", with_settings: { protocol: "http" } do
before do
allow(Setting).to receive(:plugin_openproject_avatars)
.and_return(enable_gravatars: true)
- user.mail = 'foo@bar.com'
+ user.mail = "foo@bar.com"
end
- it 'has an url to gravatar if settings permit and mail is set' do
- expect(parse_json(subject, 'avatar')).to start_with('http://gravatar.com/avatar')
+ it "has an url to gravatar if settings permit and mail is set" do
+ expect(parse_json(subject, "avatar")).to start_with("http://gravatar.com/avatar")
end
- it 'is blank if gravatar is disabled' do
+ it "is blank if gravatar is disabled" do
allow(Setting)
.to receive(:plugin_openproject_avatars)
.and_return(enable_gravatars: false)
- expect(parse_json(subject, 'avatar')).to be_blank
+ expect(parse_json(subject, "avatar")).to be_blank
end
- it 'is blank if email is missing (e.g. anonymous)' do
+ it "is blank if email is missing (e.g. anonymous)" do
user.mail = nil
- expect(parse_json(subject, 'avatar')).to be_blank
+ expect(parse_json(subject, "avatar")).to be_blank
end
end
end
diff --git a/modules/avatars/spec/requests/user_avatar_api_spec.rb b/modules/avatars/spec/requests/user_avatar_api_spec.rb
index 0bf052b37da7..182d1e32e17e 100644
--- a/modules/avatars/spec/requests/user_avatar_api_spec.rb
+++ b/modules/avatars/spec/requests/user_avatar_api_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'API v3 User avatar resource', content_type: :json do
+RSpec.describe "API v3 User avatar resource", content_type: :json do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -43,7 +43,7 @@
login_as current_user
end
- describe '/avatar', with_settings: { protocol: 'http' } do
+ describe "/avatar", with_settings: { protocol: "http" } do
before do
allow(Setting)
.to receive(:plugin_openproject_avatars)
@@ -54,17 +54,17 @@
get api_v3_paths.user(other_user.id) + "/avatar"
end
- context 'with neither enabled' do
+ context "with neither enabled" do
let(:gravatars) { false }
let(:local_avatars) { false }
- it 'renders a 404' do
+ it "renders a 404" do
expect(response.status).to eq 404
end
end
- shared_examples_for 'cache headers set to 24 hours' do
- it 'has the cache headers set to 24 hours' do
+ shared_examples_for "cache headers set to 24 hours" do
+ it "has the cache headers set to 24 hours" do
expect(response.headers["Cache-Control"]).to eq "public, max-age=86400"
expect(response.headers["Expires"]).to be_present
@@ -75,19 +75,19 @@
end
end
- context 'when gravatar enabled' do
+ context "when gravatar enabled" do
let(:gravatars) { true }
let(:local_avatars) { false }
- it 'redirects to gravatar' do
+ it "redirects to gravatar" do
expect(response.status).to eq 302
expect(response.location).to match /gravatar\.com/
end
- it_behaves_like 'cache headers set to 24 hours'
+ it_behaves_like "cache headers set to 24 hours"
end
- context 'with local avatar' do
+ context "with local avatar" do
let(:gravatars) { true }
let(:local_avatars) { true }
@@ -97,13 +97,13 @@
u
end
- it 'serves the attachment file' do
+ it "serves the attachment file" do
expect(response.status).to eq 200
end
- it_behaves_like 'cache headers set to 24 hours'
+ it_behaves_like "cache headers set to 24 hours"
- context 'with external file storage (S3)' do
+ context "with external file storage (S3)" do
let(:setup) do
allow_any_instance_of(Attachment).to receive(:external_storage?).and_return true
@@ -116,7 +116,7 @@
# we test that Attachment#external_url works in `attachments_spec.rb`
# so here we just make sue it's called accordingly when the external
# storage is configured
- it 'redirects to temporary external URL' do
+ it "redirects to temporary external URL" do
expect(response.status).to eq 302
expect(response.location).to eq "external URL"
end
diff --git a/modules/avatars/spec/services/avatars/update_service_spec.rb b/modules/avatars/spec/services/avatars/update_service_spec.rb
index ecad4d42f2db..9f270955b5d7 100644
--- a/modules/avatars/spec/services/avatars/update_service_spec.rb
+++ b/modules/avatars/spec/services/avatars/update_service_spec.rb
@@ -1,4 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
RSpec.describe Avatars::UpdateService do
let(:user_without_avatar) { build_stubbed(:user) }
@@ -10,25 +10,25 @@
let(:instance) { described_class.new user }
- describe 'replace' do
+ describe "replace" do
end
- describe 'delete' do
+ describe "delete" do
subject { instance.destroy }
- context 'user has avatar' do
+ context "user has avatar" do
let(:user) { user_with_avatar }
- it 'destroys the attachment' do
+ it "destroys the attachment" do
expect_any_instance_of(Attachment).to receive(:destroy).and_return true
expect(subject).to be_success
end
end
- context 'user has no avatar' do
+ context "user has no avatar" do
let(:user) { user_without_avatar }
- it 'returns an error' do
+ it "returns an error" do
expect(subject).not_to be_success
expect(subject.errors[:base]).to include I18n.t(:unable_to_delete_avatar)
end
diff --git a/modules/avatars/spec/shared_examples.rb b/modules/avatars/spec/shared_examples.rb
index 7b90b3106492..d3a8c5197ff8 100644
--- a/modules/avatars/spec/shared_examples.rb
+++ b/modules/avatars/spec/shared_examples.rb
@@ -91,7 +91,7 @@
end
RSpec.shared_context "there are users with and without avatars" do
- let(:base_path) { File.expand_path 'fixtures', __dir__ }
+ let(:base_path) { File.expand_path "fixtures", __dir__ }
let(:user_without_avatar) { create(:user) }
let(:user_with_avatar) do
u = create(:user)
@@ -99,21 +99,21 @@
u
end
let(:avatar_file) do
- file = File.new(File.join(base_path, 'valid.jpg'), 'r')
- testfile = Rack::Test::UploadedFile.new(file.path, 'valid.jpg')
+ file = File.new(File.join(base_path, "valid.jpg"), "r")
+ testfile = Rack::Test::UploadedFile.new(file.path, "valid.jpg")
allow(testfile).to receive(:tempfile).and_return(file)
testfile
end
let(:large_avatar_file) do
- file = File.new(File.join(base_path, 'too_big.jpg'), 'r')
- testfile = Rack::Test::UploadedFile.new(file.path, 'too_big.jpg')
+ file = File.new(File.join(base_path, "too_big.jpg"), "r")
+ testfile = Rack::Test::UploadedFile.new(file.path, "too_big.jpg")
allow(testfile).to receive(:tempfile).and_return(file)
testfile
end
let(:bogus_avatar_file) do
- file = File.new(File.join(base_path, 'invalid.jpg'), 'r')
- testfile = Rack::Test::UploadedFile.new(file.path, 'invalid.jpg')
+ file = File.new(File.join(base_path, "invalid.jpg"), "r")
+ testfile = Rack::Test::UploadedFile.new(file.path, "invalid.jpg")
allow(testfile).to receive(:tempfile).and_return(file)
testfile
end
diff --git a/modules/avatars/spec/spec_helper.rb b/modules/avatars/spec/spec_helper.rb
index f8ec36959dea..671fd6c8666d 100644
--- a/modules/avatars/spec/spec_helper.rb
+++ b/modules/avatars/spec/spec_helper.rb
@@ -1 +1 @@
-require 'spec_helper'
+require "spec_helper"
diff --git a/modules/backlogs/app/controllers/backlogs_settings_controller.rb b/modules/backlogs/app/controllers/backlogs_settings_controller.rb
index 2e323868e7a7..fbf39f9bd0d9 100644
--- a/modules/backlogs/app/controllers/backlogs_settings_controller.rb
+++ b/modules/backlogs/app/controllers/backlogs_settings_controller.rb
@@ -27,7 +27,7 @@
#++
class BacklogsSettingsController < ApplicationController
- layout 'admin'
+ layout "admin"
menu_item :backlogs_settings
before_action :require_admin
diff --git a/modules/backlogs/app/controllers/projects/settings/backlogs_controller.rb b/modules/backlogs/app/controllers/projects/settings/backlogs_controller.rb
index fb7ae526d69d..5e6b7609b72a 100644
--- a/modules/backlogs/app/controllers/projects/settings/backlogs_controller.rb
+++ b/modules/backlogs/app/controllers/projects/settings/backlogs_controller.rb
@@ -48,11 +48,11 @@ def update
def rebuild_positions
@project.rebuild_positions
- flash[:notice] = I18n.t('backlogs.positions_rebuilt_successfully')
+ flash[:notice] = I18n.t("backlogs.positions_rebuilt_successfully")
redirect_to_backlogs_settings
rescue ActiveRecord::ActiveRecordError
- flash[:error] = I18n.t('backlogs.positions_could_not_be_rebuilt')
+ flash[:error] = I18n.t("backlogs.positions_could_not_be_rebuilt")
log_rebuild_position_error
diff --git a/modules/backlogs/app/controllers/rb_application_controller.rb b/modules/backlogs/app/controllers/rb_application_controller.rb
index 8bd3bd894350..943046df3321 100644
--- a/modules/backlogs/app/controllers/rb_application_controller.rb
+++ b/modules/backlogs/app/controllers/rb_application_controller.rb
@@ -36,7 +36,7 @@ class RbApplicationController < ApplicationController
# Use special backlogs layout to initialize stimulus side-loading legacy backlogs scripts
# and CSS from frontend
- layout 'backlogs'
+ layout "backlogs"
private
@@ -55,9 +55,9 @@ def load_sprint_and_project
def check_if_plugin_is_configured
settings = Setting.plugin_openproject_backlogs
- if settings['story_types'].blank? || settings['task_type'].blank?
+ if settings["story_types"].blank? || settings["task_type"].blank?
respond_to do |format|
- format.html { render template: 'shared/not_configured' }
+ format.html { render template: "shared/not_configured" }
end
end
end
diff --git a/modules/backlogs/app/controllers/rb_impediments_controller.rb b/modules/backlogs/app/controllers/rb_impediments_controller.rb
index fefc5c5328cb..925e7c579eff 100644
--- a/modules/backlogs/app/controllers/rb_impediments_controller.rb
+++ b/modules/backlogs/app/controllers/rb_impediments_controller.rb
@@ -54,7 +54,7 @@ def respond_with_impediment(call)
@include_meta = true
respond_to do |format|
- format.html { render partial: 'impediment', object: @impediment, status:, locals: { errors: call.errors } }
+ format.html { render partial: "impediment", object: @impediment, status:, locals: { errors: call.errors } }
end
end
diff --git a/modules/backlogs/app/controllers/rb_queries_controller.rb b/modules/backlogs/app/controllers/rb_queries_controller.rb
index 64e688e7d2c0..317f8f9a6419 100644
--- a/modules/backlogs/app/controllers/rb_queries_controller.rb
+++ b/modules/backlogs/app/controllers/rb_queries_controller.rb
@@ -32,19 +32,19 @@ class RbQueriesController < RbApplicationController
def show
filters = []
if @sprint_id
- filters.push(filter_object('status_id', '*'))
- filters.push(filter_object('version_id', '=', [@sprint_id]))
+ filters.push(filter_object("status_id", "*"))
+ filters.push(filter_object("version_id", "=", [@sprint_id]))
# Note: We need a filter for backlogs_work_package_type but currently it's not possible for plugins to introduce new filter types
else
- filters.push(filter_object('status_id', 'o'))
- filters.push(filter_object('version_id', '!*', [@sprint_id]))
+ filters.push(filter_object("status_id", "o"))
+ filters.push(filter_object("version_id", "!*", [@sprint_id]))
# Same as above
end
query = {
f: filters,
- c: ['type', 'status', 'priority', 'subject', 'assigned_to', 'updated_at', 'position'],
- t: 'position:desc'
+ c: ["type", "status", "priority", "subject", "assigned_to", "updated_at", "position"],
+ t: "position:desc"
}
redirect_to project_work_packages_with_query_path(@project, query)
diff --git a/modules/backlogs/app/controllers/rb_sprints_controller.rb b/modules/backlogs/app/controllers/rb_sprints_controller.rb
index f5d06eec108a..da4bfe67838f 100644
--- a/modules/backlogs/app/controllers/rb_sprints_controller.rb
+++ b/modules/backlogs/app/controllers/rb_sprints_controller.rb
@@ -38,7 +38,7 @@ def update
status = (result ? 200 : 400)
respond_to do |format|
- format.html { render partial: 'sprint', status:, object: @sprint }
+ format.html { render partial: "sprint", status:, object: @sprint }
end
end
diff --git a/modules/backlogs/app/controllers/rb_stories_controller.rb b/modules/backlogs/app/controllers/rb_stories_controller.rb
index 97f702ebddc1..c8228d1847b8 100644
--- a/modules/backlogs/app/controllers/rb_stories_controller.rb
+++ b/modules/backlogs/app/controllers/rb_stories_controller.rb
@@ -66,7 +66,7 @@ def respond_with_story(call)
story = call.result
respond_to do |format|
- format.html { render partial: 'story', object: story, status:, locals: { errors: call.errors } }
+ format.html { render partial: "story", object: story, status:, locals: { errors: call.errors } }
end
end
diff --git a/modules/backlogs/app/controllers/rb_taskboards_controller.rb b/modules/backlogs/app/controllers/rb_taskboards_controller.rb
index f59629643157..0499ac87196c 100644
--- a/modules/backlogs/app/controllers/rb_taskboards_controller.rb
+++ b/modules/backlogs/app/controllers/rb_taskboards_controller.rb
@@ -35,7 +35,7 @@ def show
@statuses = Type.find(Task.type).statuses
@story_ids = @sprint.stories(@project).map(&:id)
@last_updated = Task.children_of(@story_ids)
- .order(Arel.sql('updated_at DESC'))
+ .order(Arel.sql("updated_at DESC"))
.first
end
diff --git a/modules/backlogs/app/controllers/rb_tasks_controller.rb b/modules/backlogs/app/controllers/rb_tasks_controller.rb
index 3ecfb17e5594..a73c0521c6a5 100644
--- a/modules/backlogs/app/controllers/rb_tasks_controller.rb
+++ b/modules/backlogs/app/controllers/rb_tasks_controller.rb
@@ -60,7 +60,7 @@ def respond_with_task(call)
@include_meta = true
respond_to do |format|
- format.html { render partial: 'task', object: @task, status:, locals: { errors: call.errors } }
+ format.html { render partial: "task", object: @task, status:, locals: { errors: call.errors } }
end
end
diff --git a/modules/backlogs/app/controllers/rb_wikis_controller.rb b/modules/backlogs/app/controllers/rb_wikis_controller.rb
index 7e9b9b958550..27dfecb52e94 100644
--- a/modules/backlogs/app/controllers/rb_wikis_controller.rb
+++ b/modules/backlogs/app/controllers/rb_wikis_controller.rb
@@ -32,10 +32,10 @@ class RbWikisController < RbApplicationController
#
# NOTE: The methods #show and #edit create a template page when called.
def show
- redirect_to controller: '/wiki', action: 'index', project_id: @project.id, id: @sprint.wiki_page
+ redirect_to controller: "/wiki", action: "index", project_id: @project.id, id: @sprint.wiki_page
end
def edit
- redirect_to controller: '/wiki', action: 'edit', project_id: @project.id, id: @sprint.wiki_page
+ redirect_to controller: "/wiki", action: "edit", project_id: @project.id, id: @sprint.wiki_page
end
end
diff --git a/modules/backlogs/app/controllers/version_settings_controller.rb b/modules/backlogs/app/controllers/version_settings_controller.rb
index 57e3a48de612..1d4518d217ab 100644
--- a/modules/backlogs/app/controllers/version_settings_controller.rb
+++ b/modules/backlogs/app/controllers/version_settings_controller.rb
@@ -36,6 +36,6 @@ def edit
def authorize
# Everyone with the right to edit versions has the right to edit version
# settings
- super('versions', 'edit')
+ super("versions", "edit")
end
end
diff --git a/modules/backlogs/app/controllers/work_package_boxes_controller.rb b/modules/backlogs/app/controllers/work_package_boxes_controller.rb
index df86563a0c1e..3ecd44c4c207 100644
--- a/modules/backlogs/app/controllers/work_package_boxes_controller.rb
+++ b/modules/backlogs/app/controllers/work_package_boxes_controller.rb
@@ -44,7 +44,7 @@ def show
@time_entry = TimeEntry.new
respond_to do |format|
- format.js { render partial: 'show' }
+ format.js { render partial: "show" }
end
end
@@ -56,7 +56,7 @@ def edit
@journal = @work_package.last_journal
respond_to do |format|
- format.js { render partial: 'edit' }
+ format.js { render partial: "edit" }
end
end
@@ -67,12 +67,12 @@ def update
@work_package.reload
load_journals
respond_to do |format|
- format.js { render partial: 'show' }
+ format.js { render partial: "show" }
end
else
@journal = @work_package.last_journal
respond_to do |format|
- format.js { render partial: 'edit' }
+ format.js { render partial: "edit" }
end
end
end
diff --git a/modules/backlogs/app/helpers/burndown_charts_helper.rb b/modules/backlogs/app/helpers/burndown_charts_helper.rb
index ebfcd9f63375..82869b7d3a99 100644
--- a/modules/backlogs/app/helpers/burndown_charts_helper.rb
+++ b/modules/backlogs/app/helpers/burndown_charts_helper.rb
@@ -38,7 +38,7 @@ def yaxis_labels(burndown)
labels << "[#{mvalue * 25}, '#{I18n.t('backlogs.points')}']"
- result = labels.join(', ')
+ result = labels.join(", ")
result.html_safe
end
@@ -51,7 +51,7 @@ def xaxis_labels(burndown)
if (i % entries_displayed) == 0
"[#{i + 1}, '#{escape_javascript(::I18n.t('date.abbr_day_names')[d.wday % 7])} #{d.strftime('%d/%m')}']"
end
- end.join(',').html_safe +
+ end.join(",").html_safe +
", [#{burndown.days.length + 1},
'#{I18n.t('backlogs.date')}']".html_safe
end
@@ -60,7 +60,7 @@ def dataseries(burndown)
dataset = {}
burndown.series.each do |s|
dataset[s.first] = {
- label: I18n.t('backlogs.' + s.first.to_s),
+ label: I18n.t("backlogs." + s.first.to_s),
data: s.last.enum_for(:each_with_index).map { |val, i| [i + 1, val] }
}
end
@@ -69,7 +69,7 @@ def dataseries(burndown)
end
def burndown_series_checkboxes(burndown)
- boxes = ''
+ boxes = ""
burndown.series(:all).map { |s| s.first.to_s }.sort.each do |series|
boxes += "#{I18n.t('backlogs.' + series.to_s)} "
end
diff --git a/modules/backlogs/app/helpers/rb_common_helper.rb b/modules/backlogs/app/helpers/rb_common_helper.rb
index 45e770190f71..024b26bb2a16 100644
--- a/modules/backlogs/app/helpers/rb_common_helper.rb
+++ b/modules/backlogs/app/helpers/rb_common_helper.rb
@@ -32,15 +32,15 @@ def assignee_id_or_empty(story)
end
def assignee_name_or_empty(story)
- story.blank? || story.assigned_to.blank? ? '' : "#{story.assigned_to.firstname} #{story.assigned_to.lastname}"
+ story.blank? || story.assigned_to.blank? ? "" : "#{story.assigned_to.firstname} #{story.assigned_to.lastname}"
end
def blocks_ids(ids)
- ids.sort.join(',')
+ ids.sort.join(",")
end
def build_inline_style(task)
- is_assigned_task?(task) ? color_style(task) : ''
+ is_assigned_task?(task) ? color_style(task) : ""
end
def color_style(task)
@@ -51,9 +51,9 @@ def color_style(task)
def color_contrast_class(task)
if is_assigned_task?(task)
- color_contrast(background_color_hex(task)) ? 'light' : 'dark'
+ color_contrast(background_color_hex(task)) ? "light" : "dark"
else
- ''
+ ""
end
end
@@ -95,7 +95,7 @@ def is_assigned_task?(task)
def background_color_hex(task)
background_color = get_backlogs_preference(task.assigned_to, :task_color)
- background_color_hex = background_color.sub("#", '0x').hex
+ background_color_hex = background_color.sub("#", "0x").hex
end
def id_or_empty(item)
@@ -108,7 +108,7 @@ def shortened_id(record)
end
def work_package_link_or_empty(work_package)
- modal_link_to_work_package(work_package.id, work_package, class: 'prevent_edit') unless work_package.new_record?
+ modal_link_to_work_package(work_package.id, work_package, class: "prevent_edit") unless work_package.new_record?
end
def modal_link_to_work_package(title, work_package, options = {})
@@ -117,21 +117,21 @@ def modal_link_to_work_package(title, work_package, options = {})
def modal_link_to(title, path, options = {})
html_id = "modal_work_package_#{SecureRandom.hex(10)}"
- link_to(title, path, options.merge(id: html_id, target: '_blank'))
+ link_to(title, path, options.merge(id: html_id, target: "_blank"))
end
def sprint_link_or_empty(item)
item_id = item.id.to_s
text = (item_id.length > 8 ? "#{item_id[0..1]}...#{item_id[-4..-1]}" : item_id)
if item.new_record?
- ''
+ ""
else
- link_to(text, backlogs_project_sprint_path(id: item.id, project_id: item.project.identifier), class: 'prevent_edit')
+ link_to(text, backlogs_project_sprint_path(id: item.id, project_id: item.project.identifier), class: "prevent_edit")
end
end
def mark_if_closed(story)
- !story.new_record? && work_package_status_for_id(story.status_id).is_closed? ? 'closed' : ''
+ !story.new_record? && work_package_status_for_id(story.status_id).is_closed? ? "closed" : ""
end
def story_points_or_empty(story)
@@ -147,11 +147,11 @@ def status_label_or_default(story)
end
def sprint_html_id_or_empty(sprint)
- sprint.id.nil? ? '' : "sprint_#{sprint.id}"
+ sprint.id.nil? ? "" : "sprint_#{sprint.id}"
end
def story_html_id_or_empty(story)
- story.id.nil? ? '' : "story_#{story.id}"
+ story.id.nil? ? "" : "story_#{story.id}"
end
def type_id_or_empty(story)
@@ -159,22 +159,22 @@ def type_id_or_empty(story)
end
def type_name_or_empty(story)
- return '' if story.type_id.nil?
+ return "" if story.type_id.nil?
type = backlogs_types_by_id[story.type_id]
- return '' if type.nil?
+ return "" if type.nil?
h(type.name)
end
def date_string_with_milliseconds(d, add = 0)
- return '' if d.blank?
+ return "" if d.blank?
- d.strftime('%B %d, %Y %H:%M:%S') + '.' + ((d.to_f % 1) + add).to_s.split('.')[1]
+ d.strftime("%B %d, %Y %H:%M:%S") + "." + ((d.to_f % 1) + add).to_s.split(".")[1]
end
def remaining_hours(item)
- item.remaining_hours.blank? || item.remaining_hours == 0 ? '' : item.remaining_hours
+ item.remaining_hours.blank? || item.remaining_hours == 0 ? "" : item.remaining_hours
end
def available_story_types
@@ -204,9 +204,9 @@ def available_statuses_by_type
end
def show_burndown_link(project, sprint)
- link_to(I18n.t('backlogs.show_burndown_chart'),
+ link_to(I18n.t("backlogs.show_burndown_chart"),
backlogs_project_sprint_burndown_chart_path(project.identifier, sprint),
- class: 'show_burndown_chart button',
+ class: "show_burndown_chart button",
target: :_blank, rel: :noopener)
end
@@ -242,15 +242,15 @@ def all_workflows
end
def all_work_package_status
- @all_work_package_status ||= Status.order(Arel.sql('position ASC'))
+ @all_work_package_status ||= Status.order(Arel.sql("position ASC"))
end
def backlogs_types
@backlogs_types ||= begin
- backlogs_ids = Setting.plugin_openproject_backlogs['story_types']
- backlogs_ids << Setting.plugin_openproject_backlogs['task_type']
+ backlogs_ids = Setting.plugin_openproject_backlogs["story_types"]
+ backlogs_ids << Setting.plugin_openproject_backlogs["task_type"]
- Type.where(id: backlogs_ids).order(Arel.sql('position ASC'))
+ Type.where(id: backlogs_ids).order(Arel.sql("position ASC"))
end
end
@@ -263,7 +263,7 @@ def backlogs_types_by_id
def story_types
@story_types ||= begin
- backlogs_type_ids = Setting.plugin_openproject_backlogs['story_types'].map(&:to_i)
+ backlogs_type_ids = Setting.plugin_openproject_backlogs["story_types"].map(&:to_i)
backlogs_types.select { |t| backlogs_type_ids.include?(t.id) }
end
@@ -277,7 +277,7 @@ def story_types_by_id
end
def get_backlogs_preference(assignee, attr)
- assignee.is_a?(User) ? assignee.backlogs_preference(attr) : '#24B3E7'
+ assignee.is_a?(User) ? assignee.backlogs_preference(attr) : "#24B3E7"
end
def template_story
diff --git a/modules/backlogs/app/helpers/rb_master_backlogs_helper.rb b/modules/backlogs/app/helpers/rb_master_backlogs_helper.rb
index 7b6347281c85..1eeb39b3484b 100644
--- a/modules/backlogs/app/helpers/rb_master_backlogs_helper.rb
+++ b/modules/backlogs/app/helpers/rb_master_backlogs_helper.rb
@@ -31,12 +31,12 @@ module RbMasterBacklogsHelper
def render_backlog_menu(backlog)
# associated javascript defined in taskboard.js
- content_tag(:div, class: 'backlog-menu') do
+ content_tag(:div, class: "backlog-menu") do
[
- content_tag(:div, '', class: "menu-trigger icon-context icon-pulldown icon-small"),
- content_tag(:ul, class: 'items') do
+ content_tag(:div, "", class: "menu-trigger icon-context icon-pulldown icon-small"),
+ content_tag(:ul, class: "items") do
backlog_menu_items_for(backlog).map do |item|
- content_tag(:li, item, class: 'item')
+ content_tag(:li, item, class: "item")
end.join.html_safe
end
].join.html_safe
@@ -63,14 +63,14 @@ def common_backlog_menu_items_for(backlog)
if current_user.allowed_in_project?(:add_work_packages, @project)
items[:new_story] = content_tag(:a,
- I18n.t('backlogs.add_new_story'),
- href: '#',
- class: 'add_new_story')
+ I18n.t("backlogs.add_new_story"),
+ href: "#",
+ class: "add_new_story")
end
items[:stories_tasks] = link_to(I18n.t(:label_stories_tasks),
- controller: '/rb_queries',
- action: 'show',
+ controller: "/rb_queries",
+ action: "show",
project_id: @project,
sprint_id: backlog.sprint)
@@ -86,7 +86,7 @@ def properties_link(backlog)
version_path = edit_version_path(backlog.sprint, back_url: back_path, project_id: @project.id)
- link_to(I18n.t(:'backlogs.properties'), version_path)
+ link_to(I18n.t(:"backlogs.properties"), version_path)
end
def sprint_backlog_menu_items_for(backlog)
@@ -94,24 +94,24 @@ def sprint_backlog_menu_items_for(backlog)
if current_user.allowed_in_project?(:view_taskboards, @project)
items[:task_board] = link_to(I18n.t(:label_task_board),
- { controller: '/rb_taskboards',
- action: 'show',
+ { controller: "/rb_taskboards",
+ action: "show",
project_id: @project,
sprint_id: backlog.sprint },
- class: 'show_task_board')
+ class: "show_task_board")
end
if backlog.sprint.has_burndown?
items[:burndown] = content_tag(:a,
- I18n.t('backlogs.show_burndown_chart'),
- href: '#',
- class: 'show_burndown_chart')
+ I18n.t("backlogs.show_burndown_chart"),
+ href: "#",
+ class: "show_burndown_chart")
end
- if @project.module_enabled? 'wiki'
+ if @project.module_enabled? "wiki"
items[:wiki] = link_to(I18n.t(:label_wiki),
- controller: '/rb_wikis',
- action: 'edit',
+ controller: "/rb_wikis",
+ action: "edit",
project_id: @project,
sprint_id: backlog.sprint)
end
diff --git a/modules/backlogs/app/helpers/version_settings_helper.rb b/modules/backlogs/app/helpers/version_settings_helper.rb
index 439672e11c71..4d9abbdf1b6e 100644
--- a/modules/backlogs/app/helpers/version_settings_helper.rb
+++ b/modules/backlogs/app/helpers/version_settings_helper.rb
@@ -30,15 +30,15 @@ module VersionSettingsHelper
def version_settings_fields(version, project)
setting = version_setting_for_project(version, project)
- content_tag :div, class: 'form--field' do
+ content_tag :div, class: "form--field" do
[
- styled_label_tag(name_for_setting_attributes('display'), t(:label_column_in_backlog)),
+ styled_label_tag(name_for_setting_attributes("display"), t(:label_column_in_backlog)),
content_tag(:div,
- styled_select_tag(name_for_setting_attributes('display'),
- options_for_select(position_display_options, setting.display), container_class: '-xslim'),
- class: 'form--field-container'),
+ styled_select_tag(name_for_setting_attributes("display"),
+ options_for_select(position_display_options, setting.display), container_class: "-xslim"),
+ class: "form--field-container"),
version_hidden_id_field(setting),
- hidden_field_tag('project_id', project.id)
+ hidden_field_tag("project_id", project.id)
].join.html_safe
end
end
@@ -46,9 +46,9 @@ def version_settings_fields(version, project)
private
def version_hidden_id_field(setting)
- return '' unless setting.id
+ return "" unless setting.id
- hidden_field_tag(name_for_setting_attributes('id'), setting.id)
+ hidden_field_tag(name_for_setting_attributes("id"), setting.id)
end
def version_setting_for_project(version, project)
@@ -74,11 +74,11 @@ def position_display_options
def humanize_display_option(option)
case option
when ::VersionSetting::DISPLAY_NONE
- t('version_settings_display_option_none')
+ t("version_settings_display_option_none")
when ::VersionSetting::DISPLAY_LEFT
- t('version_settings_display_option_left')
+ t("version_settings_display_option_left")
when ::VersionSetting::DISPLAY_RIGHT
- t('version_settings_display_option_right')
+ t("version_settings_display_option_right")
end
end
end
diff --git a/modules/backlogs/app/models/backlog.rb b/modules/backlogs/app/models/backlog.rb
index b27aa221f9a5..472afd1536b3 100644
--- a/modules/backlogs/app/models/backlog.rb
+++ b/modules/backlogs/app/models/backlog.rb
@@ -49,9 +49,9 @@ def self.sprint_backlogs(project)
def initialize(options = {})
options = options.with_indifferent_access
- @sprint = options['sprint']
- @stories = options['stories']
- @owner_backlog = options['owner_backlog']
+ @sprint = options["sprint"]
+ @stories = options["stories"]
+ @owner_backlog = options["owner_backlog"]
end
def updated_at
diff --git a/modules/backlogs/app/models/burndown.rb b/modules/backlogs/app/models/burndown.rb
index e33b7af1c7ed..6a7b1cdba29b 100644
--- a/modules/backlogs/app/models/burndown.rb
+++ b/modules/backlogs/app/models/burndown.rb
@@ -34,7 +34,7 @@ def initialize(sprint, project, _burn_direction = nil)
series_data = OpenProject::Backlogs::Burndown::SeriesRawData.new(project,
sprint,
- points: ['story_points'])
+ points: ["story_points"])
series_data.collect_data
@@ -65,7 +65,7 @@ def calculate_series(series_data)
end
def calculate_ideals(data)
- (['story_points'] & data.collect_names).each do |ideal|
+ (["story_points"] & data.collect_names).each do |ideal|
calculate_ideal(ideal, data.unit_for(ideal))
end
end
@@ -79,7 +79,7 @@ def calculate_ideal(name, unit)
ideal[i] = max - (delta * i)
end
- make_series name.to_s + '_ideal', unit, ideal
+ make_series name.to_s + "_ideal", unit, ideal
end
def make_series(name, units, data)
diff --git a/modules/backlogs/app/models/sprint.rb b/modules/backlogs/app/models/sprint.rb
index 05c89d8bd1a5..f0e6f7317e47 100644
--- a/modules/backlogs/app/models/sprint.rb
+++ b/modules/backlogs/app/models/sprint.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'date'
+require "date"
class Sprint < Version
scope :open_sprints, lambda { |project|
@@ -46,7 +46,7 @@ class Sprint < Version
" OR (#{Project.table_name}.lft >= #{project.root.lft} AND #{Project.table_name}.rgt <= #{project.root.rgt} AND #{Version.table_name}.sharing = 'tree')" +
" OR (#{Project.table_name}.lft < #{project.lft} AND #{Project.table_name}.rgt > #{project.rgt} AND #{Version.table_name}.sharing IN ('hierarchy', 'descendants'))" +
" OR (#{Project.table_name}.lft > #{project.lft} AND #{Project.table_name}.rgt < #{project.rgt} AND #{Version.table_name}.sharing = 'hierarchy')" +
- '))')
+ "))")
.includes(:project)
.references(:projects)
}
@@ -54,13 +54,13 @@ class Sprint < Version
scope :displayed_left, lambda { |project|
joins(sanitize_sql_array([
"LEFT OUTER JOIN (SELECT * from #{VersionSetting.table_name}" +
- ' WHERE project_id = ? ) version_settings' +
- ' ON version_settings.version_id = versions.id',
+ " WHERE project_id = ? ) version_settings" +
+ " ON version_settings.version_id = versions.id",
project.id
]))
.where([
- '(version_settings.project_id = ? AND version_settings.display = ?)' +
- ' OR (version_settings.project_id is NULL)',
+ "(version_settings.project_id = ? AND version_settings.display = ?)" +
+ " OR (version_settings.project_id is NULL)",
project.id,
VersionSetting::DISPLAY_LEFT
])
@@ -76,7 +76,7 @@ class Sprint < Version
}
scope :displayed_right, lambda { |project|
- where(['version_settings.project_id = ? AND version_settings.display = ?',
+ where(["version_settings.project_id = ? AND version_settings.display = ?",
project.id, VersionSetting::DISPLAY_RIGHT])
.includes(:version_settings)
.references(:version_settings)
@@ -96,14 +96,14 @@ def has_wiki_page
page = project.wiki.find_page(wiki_page_title)
return false if !page
- template = project.wiki.find_page(Setting.plugin_openproject_backlogs['wiki_template'])
+ template = project.wiki.find_page(Setting.plugin_openproject_backlogs["wiki_template"])
return false if template && page.text == template.text
true
end
def wiki_page
- return '' unless project.wiki
+ return "" unless project.wiki
create_wiki_page(name) unless project.wiki.find_page(name)
update_attribute(:wiki_page_title, name) if wiki_page_title.blank?
@@ -124,13 +124,13 @@ def has_burndown?
end
def activity
- bd = burndown('up')
+ bd = burndown("up")
return false if bd.blank?
# Assume a sprint is active if it's only 2 days old
return true if bd.remaining_hours.size <= 2
- WorkPackage.exists?(['version_id = ? and ((updated_at between ? and ?) or (created_at between ? and ?))',
+ WorkPackage.exists?(["version_id = ? and ((updated_at between ? and ?) or (created_at between ? and ?))",
id, -2.days.from_now, Time.now, -2.days.from_now, Time.now])
end
@@ -142,9 +142,9 @@ def burndown(project, burn_direction = nil)
def self.generate_burndown(only_current = true)
conditions = if only_current
- ['? BETWEEN start_date AND effective_date', Date.today]
+ ["? BETWEEN start_date AND effective_date", Date.today]
else
- '1 = 1'
+ "1 = 1"
end
Version.where(conditions).each(&:burndown)
@@ -159,7 +159,7 @@ def impediments(project)
private
def create_wiki_page(page_title, author: User.current)
- template = project.wiki.find_page(Setting.plugin_openproject_backlogs['wiki_template'])
+ template = project.wiki.find_page(Setting.plugin_openproject_backlogs["wiki_template"])
page_text = if template
"h1. #{name}\n\n#{template.text}"
else
diff --git a/modules/backlogs/app/models/story.rb b/modules/backlogs/app/models/story.rb
index be1688399edf..c51b6ace74ff 100644
--- a/modules/backlogs/app/models/story.rb
+++ b/modules/backlogs/app/models/story.rb
@@ -66,7 +66,7 @@ def self.at_rank(project_id, sprint_id, rank)
end
def self.types
- types = Setting.plugin_openproject_backlogs['story_types']
+ types = Setting.plugin_openproject_backlogs["story_types"]
return [] if types.blank?
types.map { |type| Integer(type) }
@@ -91,12 +91,12 @@ def direct_tasks_and_subtasks
def set_points(p)
init_journal(User.current)
- if p.blank? || p == '-'
+ if p.blank? || p == "-"
update_attribute(:story_points, nil)
return
end
- if p.downcase == 's'
+ if p.downcase == "s"
update_attribute(:story_points, 0)
return
end
@@ -148,11 +148,11 @@ def rank
end
def self.condition(project_id, sprint_ids, extras = [])
- c = ['project_id = ? AND type_id in (?) AND version_id in (?)',
+ c = ["project_id = ? AND type_id in (?) AND version_id in (?)",
project_id, Story.types, sprint_ids]
if extras.size > 0
- c[0] += ' ' + extras.shift
+ c[0] += " " + extras.shift
c += extras
end
diff --git a/modules/backlogs/app/models/task.rb b/modules/backlogs/app/models/task.rb
index 0dc5331f7dc3..28a80d679cb6 100644
--- a/modules/backlogs/app/models/task.rb
+++ b/modules/backlogs/app/models/task.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'date'
+require "date"
class Task < WorkPackage
extend OpenProject::Backlogs::Mixins::PreventIssueSti
def self.type
- task_type = Setting.plugin_openproject_backlogs['task_type']
+ task_type = Setting.plugin_openproject_backlogs["task_type"]
task_type.blank? ? nil : task_type.to_i
end
diff --git a/modules/backlogs/app/services/tasks/create_service.rb b/modules/backlogs/app/services/tasks/create_service.rb
index bacda2758475..c8cfb39efcee 100644
--- a/modules/backlogs/app/services/tasks/create_service.rb
+++ b/modules/backlogs/app/services/tasks/create_service.rb
@@ -33,7 +33,7 @@ def initialize(user:)
self.user = user
end
- def call(attributes: {}, prev: '')
+ def call(attributes: {}, prev: "")
attributes[:type_id] = Task.type
create_call = WorkPackages::CreateService
diff --git a/modules/backlogs/app/services/tasks/update_service.rb b/modules/backlogs/app/services/tasks/update_service.rb
index e3e814c6cb43..8a9e1a2229d8 100644
--- a/modules/backlogs/app/services/tasks/update_service.rb
+++ b/modules/backlogs/app/services/tasks/update_service.rb
@@ -34,7 +34,7 @@ def initialize(user:, task:)
self.task = task
end
- def call(attributes: {}, prev: '')
+ def call(attributes: {}, prev: "")
create_call = WorkPackages::UpdateService
.new(user:,
model: task)
diff --git a/modules/backlogs/config/routes.rb b/modules/backlogs/config/routes.rb
index bbf91c0a55e6..205abc85f970 100644
--- a/modules/backlogs/config/routes.rb
+++ b/modules/backlogs/config/routes.rb
@@ -27,8 +27,8 @@
#++
Rails.application.routes.draw do
- scope '', as: 'backlogs' do
- scope 'projects/:project_id', as: 'project' do
+ scope "", as: "backlogs" do
+ scope "projects/:project_id", as: "project" do
resources :backlogs, controller: :rb_master_backlogs, only: :index
resources :sprints, controller: :rb_sprints, only: %i[show update] do
@@ -51,22 +51,22 @@
end
end
- scope 'projects/:project_id', as: 'project', module: 'projects' do
- namespace 'settings' do
+ scope "projects/:project_id", as: "project", module: "projects" do
+ namespace "settings" do
resource :backlogs, only: %i[show update] do
member do
- post 'rebuild_positions' => 'backlogs#rebuild_positions'
+ post "rebuild_positions" => "backlogs#rebuild_positions"
end
end
end
end
- get 'projects/:project_id/versions/:id/edit' => 'version_settings#edit'
+ get "projects/:project_id/versions/:id/edit" => "version_settings#edit"
- scope 'admin' do
+ scope "admin" do
resource :backlogs,
only: %i[show update],
controller: :backlogs_settings,
- as: 'admin_backlogs_settings'
+ as: "admin_backlogs_settings"
end
end
diff --git a/modules/backlogs/db/migrate/20180323151208_to_v710_aggregated_backlogs_migrations.rb b/modules/backlogs/db/migrate/20180323151208_to_v710_aggregated_backlogs_migrations.rb
index 6da8c2cfc3db..298acb827e99 100644
--- a/modules/backlogs/db/migrate/20180323151208_to_v710_aggregated_backlogs_migrations.rb
+++ b/modules/backlogs/db/migrate/20180323151208_to_v710_aggregated_backlogs_migrations.rb
@@ -39,18 +39,18 @@ class ToV710AggregatedBacklogsMigrations < ActiveRecord::Migration[5.1]
def up
Migration::MigrationSquasher.squash(migrations) do
- create_table 'version_settings', id: :integer do |t|
- t.integer 'project_id'
- t.integer 'version_id'
- t.integer 'display'
- t.datetime 'created_at', null: false
- t.datetime 'updated_at', null: false
+ create_table "version_settings", id: :integer do |t|
+ t.integer "project_id"
+ t.integer "version_id"
+ t.integer "display"
+ t.datetime "created_at", null: false
+ t.datetime "updated_at", null: false
end
- add_index 'version_settings', ['project_id', 'version_id'], name: 'index_version_settings_on_project_id_and_version_id'
+ add_index "version_settings", ["project_id", "version_id"], name: "index_version_settings_on_project_id_and_version_id"
- create_table 'done_statuses_for_project', id: false do |t|
- t.integer 'project_id'
- t.integer 'status_id'
+ create_table "done_statuses_for_project", id: false do |t|
+ t.integer "project_id"
+ t.integer "status_id"
end
add_column :work_packages, :position, :integer
@@ -65,13 +65,13 @@ def up
status_id
project_id
type_id],
- name: 'work_package_journal_on_burndown_attributes'
+ name: "work_package_journal_on_burndown_attributes"
end
end
def down
- drop_table 'version_settings'
- drop_table 'done_statuses_for_project'
+ drop_table "version_settings"
+ drop_table "done_statuses_for_project"
remove_column :work_packages, :position
remove_column :work_packages, :story_points
@@ -81,14 +81,14 @@ def down
remove_column :work_package_journals, :remaining_hours
remove_index :work_package_journals,
- name: 'work_package_journal_on_burndown_attributes'
+ name: "work_package_journal_on_burndown_attributes"
end
private
def migrations
MIGRATION_FILES.split.map do |m|
- m.gsub(/_.*\z/, '')
+ m.gsub(/_.*\z/, "")
end
end
end
diff --git a/modules/backlogs/lib/api/v3/queries/schemas/backlogs_type_dependency_representer.rb b/modules/backlogs/lib/api/v3/queries/schemas/backlogs_type_dependency_representer.rb
index 177a4e418218..40e91a9b1f9c 100644
--- a/modules/backlogs/lib/api/v3/queries/schemas/backlogs_type_dependency_representer.rb
+++ b/modules/backlogs/lib/api/v3/queries/schemas/backlogs_type_dependency_representer.rb
@@ -56,7 +56,7 @@ def href_callback; end
private
def type
- '[1]BacklogsType'
+ "[1]BacklogsType"
end
end
end
diff --git a/modules/backlogs/lib/open_project/backlogs.rb b/modules/backlogs/lib/open_project/backlogs.rb
index a7aba6385876..7e037d20dcb6 100644
--- a/modules/backlogs/lib/open_project/backlogs.rb
+++ b/modules/backlogs/lib/open_project/backlogs.rb
@@ -28,6 +28,6 @@
module OpenProject
module Backlogs
- require 'open_project/backlogs/engine'
+ require "open_project/backlogs/engine"
end
end
diff --git a/modules/backlogs/lib/open_project/backlogs/burndown/series_raw_data.rb b/modules/backlogs/lib/open_project/backlogs/burndown/series_raw_data.rb
index 53139ab9b87b..f95971ad6ca3 100644
--- a/modules/backlogs/lib/open_project/backlogs/burndown/series_raw_data.rb
+++ b/modules/backlogs/lib/open_project/backlogs/burndown/series_raw_data.rb
@@ -49,11 +49,11 @@ def collect_data
initialize_self_for_collection
data_for_dates(collected_days).each do |day_data|
- date = day_data['date']
+ date = day_data["date"]
date = Date.parse(date) unless date.is_a?(Date)
day_data.each do |key, value|
- next if key == 'date'
+ next if key == "date"
self[key][date] = value.to_f
end
@@ -112,7 +112,7 @@ def data_for_dates(dates)
end
def authoritative_journal_for_date(dates)
- raise 'dates must not be empty!' if dates.empty?
+ raise "dates must not be empty!" if dates.empty?
<<-SQL
SELECT
@@ -158,11 +158,11 @@ def authoritative_journal_for_date(dates)
end
def dates_of_interest_join_table(dates)
- raise 'dates must not be empty!' if dates.empty?
+ raise "dates must not be empty!" if dates.empty?
@date_join ||= dates.map do |date|
"SELECT CAST('#{date}' AS DATE) AS date"
- end.join(' UNION ')
+ end.join(" UNION ")
end
def and_status_query
@@ -174,7 +174,7 @@ def and_status_query
open_status_ids = non_closed_statuses - done_statuses_for_project
if open_status_ids.empty?
- ''
+ ""
else
"AND (#{Journal::WorkPackageJournal.table_name}.status_id IN (#{open_status_ids.join(',')}))"
end
@@ -198,7 +198,7 @@ def ignore_if_has_parent
end
def collected_from_children?(key, story)
- key == 'remaining_hours' && story_has_children?(story)
+ key == "remaining_hours" && story_has_children?(story)
end
def collected_types
diff --git a/modules/backlogs/lib/open_project/backlogs/engine.rb b/modules/backlogs/lib/open_project/backlogs/engine.rb
index 7b76092b3c3e..b4d870efeacd 100644
--- a/modules/backlogs/lib/open_project/backlogs/engine.rb
+++ b/modules/backlogs/lib/open_project/backlogs/engine.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'open_project/plugins'
-require_relative 'patches/api/work_package_representer'
-require_relative 'patches/api/work_package_schema_representer'
+require "open_project/plugins"
+require_relative "patches/api/work_package_representer"
+require_relative "patches/api/work_package_schema_representer"
module OpenProject::Backlogs
class Engine < ::Rails::Engine
@@ -37,10 +37,10 @@ class Engine < ::Rails::Engine
def self.settings
{
default: {
- 'story_types' => nil,
- 'task_type' => nil,
- 'points_burn_direction' => 'up',
- 'wiki_template' => ''
+ "story_types" => nil,
+ "task_type" => nil,
+ "points_burn_direction" => "up",
+ "wiki_template" => ""
},
menu_item: :backlogs_settings
}
@@ -48,25 +48,25 @@ def self.settings
include OpenProject::Plugins::ActsAsOpEngine
- register('openproject-backlogs',
- author_url: 'https://www.openproject.org',
+ register("openproject-backlogs",
+ author_url: "https://www.openproject.org",
bundled: true,
settings:) do
Rails.application.reloader.to_prepare do
OpenProject::AccessControl.permission(:add_work_packages).tap do |add|
- add.controller_actions << 'rb_stories/create'
- add.controller_actions << 'rb_tasks/create'
- add.controller_actions << 'rb_impediments/create'
+ add.controller_actions << "rb_stories/create"
+ add.controller_actions << "rb_tasks/create"
+ add.controller_actions << "rb_impediments/create"
end
OpenProject::AccessControl.permission(:edit_work_packages).tap do |edit|
- edit.controller_actions << 'rb_stories/update'
- edit.controller_actions << 'rb_tasks/update'
- edit.controller_actions << 'rb_impediments/update'
+ edit.controller_actions << "rb_stories/update"
+ edit.controller_actions << "rb_tasks/update"
+ edit.controller_actions << "rb_impediments/update"
end
OpenProject::AccessControl.permission(:change_work_package_status).tap do |edit|
- edit.controller_actions << 'rb_stories/update'
+ edit.controller_actions << "rb_stories/update"
end
end
@@ -93,7 +93,7 @@ def self.settings
permission :select_done_statuses,
{
- 'projects/settings/backlogs': %i[show update rebuild_positions]
+ "projects/settings/backlogs": %i[show update rebuild_positions]
},
permissible_on: :project,
require: :member
@@ -111,14 +111,14 @@ def self.settings
menu :project_menu,
:backlogs,
- { controller: '/rb_master_backlogs', action: :index },
+ { controller: "/rb_master_backlogs", action: :index },
caption: :project_module_backlogs,
after: :work_packages,
- icon: 'backlogs'
+ icon: "backlogs"
menu :project_menu,
:settings_backlogs,
- { controller: '/projects/settings/backlogs', action: :show },
+ { controller: "/projects/settings/backlogs", action: :show },
caption: :label_backlogs,
parent: :settings,
before: :settings_storage
@@ -147,13 +147,13 @@ def self.settings
# Add available settings to the user preferences
UserPreferences::Schema.merge!(
- 'definitions/UserPreferences/properties',
+ "definitions/UserPreferences/properties",
{
- 'backlogs_task_color' => {
- 'type' => 'string'
+ "backlogs_task_color" => {
+ "type" => "string"
},
- 'backlogs_versions_default_fold_state' => {
- 'type' => 'string',
+ "backlogs_versions_default_fold_state" => {
+ "type" => "string",
"enum" => %w[open closed]
}
}
diff --git a/modules/backlogs/lib/open_project/backlogs/hooks/layout_hook.rb b/modules/backlogs/lib/open_project/backlogs/hooks/layout_hook.rb
index 7b32d83e5e23..a8c974fe816f 100644
--- a/modules/backlogs/lib/open_project/backlogs/hooks/layout_hook.rb
+++ b/modules/backlogs/lib/open_project/backlogs/hooks/layout_hook.rb
@@ -34,16 +34,16 @@ def view_versions_show_bottom(context = {})
version = context[:version]
project = version.project
- return '' unless project.module_enabled? 'backlogs'
+ return "" unless project.module_enabled? "backlogs"
- snippet = ''
+ snippet = ""
if User.current.allowed_in_project?(:edit_wiki_pages, project)
snippet += ''
snippet += link_to I18n.t(:button_edit_wiki),
- { controller: '/rb_wikis', action: 'edit', project_id: project.id, sprint_id: version.id },
- class: 'icon icon-edit'
- snippet += ''
+ { controller: "/rb_wikis", action: "edit", project_id: project.id, sprint_id: version.id },
+ class: "icon icon-edit"
+ snippet += ""
# This wouldn't be necessary if the schedules plugin didn't disable the
# contextual hook
@@ -60,7 +60,7 @@ def view_versions_show_bottom(context = {})
def view_my_settings(context = {})
context[:controller].send(
:render_to_string,
- partial: 'shared/view_my_settings',
+ partial: "shared/view_my_settings",
locals: {
user: context[:user],
color: context[:user].backlogs_preference(:task_color),
@@ -87,17 +87,17 @@ def controller_work_package_new_after_save(context = {})
end
if params[:copy_tasks]
- params[:copy_tasks] += ':' if params[:copy_tasks].exclude?(':')
+ params[:copy_tasks] += ":" if params[:copy_tasks].exclude?(":")
action, id = *params[:copy_tasks].split(":")
story = (id.nil? ? nil : Story.find(Integer(id)))
- if !story.nil? && action != 'none'
+ if !story.nil? && action != "none"
tasks = story.tasks
case action
- when 'open'
+ when "open"
tasks = tasks.select { |t| !t.closed? }
- when 'all', 'none'
+ when "all", "none"
else
raise "Unexpected value #{params[:copy_tasks]}"
end
diff --git a/modules/backlogs/lib/open_project/backlogs/hooks/user_settings_hook.rb b/modules/backlogs/lib/open_project/backlogs/hooks/user_settings_hook.rb
index 5b42eb85fb4f..aef7c396a1ac 100644
--- a/modules/backlogs/lib/open_project/backlogs/hooks/user_settings_hook.rb
+++ b/modules/backlogs/lib/open_project/backlogs/hooks/user_settings_hook.rb
@@ -40,11 +40,11 @@ def service_update_user_before_save(context = {})
backlogs_params = params.delete(:backlogs)
return unless backlogs_params
- versions_default_fold_state = backlogs_params[:versions_default_fold_state] || 'open'
+ versions_default_fold_state = backlogs_params[:versions_default_fold_state] || "open"
user.backlogs_preference(:versions_default_fold_state, versions_default_fold_state)
- color = backlogs_params[:task_color] || ''
- if color == '' || color.match(/^#[A-Fa-f0-9]{6}$/)
+ color = backlogs_params[:task_color] || ""
+ if color == "" || color.match(/^#[A-Fa-f0-9]{6}$/)
user.backlogs_preference(:task_color, color)
end
end
diff --git a/modules/backlogs/lib/open_project/backlogs/list.rb b/modules/backlogs/lib/open_project/backlogs/list.rb
index 33056fbae73a..f103e92dbb09 100644
--- a/modules/backlogs/lib/open_project/backlogs/list.rb
+++ b/modules/backlogs/lib/open_project/backlogs/list.rb
@@ -45,7 +45,7 @@ module OpenProject::Backlogs::List
# Also sanitize_sql seems to be unavailable in a sensible way. Therefore
# we're using send to circumvent visibility work_packages.
def scope_condition
- self.class.send(:sanitize_sql, ['project_id = ? AND version_id = ? AND type_id IN (?)',
+ self.class.send(:sanitize_sql, ["project_id = ? AND version_id = ? AND type_id IN (?)",
project_id, version_id, types])
end
@@ -88,8 +88,8 @@ def set_list_position(new_position, _raise_exception_if_save_fails = false)
end
def fix_other_work_package_positions
- if changes.slice('project_id', 'type_id', 'version_id').present?
- if changes.slice('project_id', 'version_id').blank? and
+ if changes.slice("project_id", "type_id", "version_id").present?
+ if changes.slice("project_id", "version_id").blank? and
Story.types.include?(type_id.to_i) and
Story.types.include?(type_id_was.to_i)
return
@@ -132,8 +132,8 @@ def fix_other_work_package_positions
end
def fix_own_work_package_position
- if changes.slice('project_id', 'type_id', 'version_id').present?
- if changes.slice('project_id', 'version_id').blank? and
+ if changes.slice("project_id", "type_id", "version_id").present?
+ if changes.slice("project_id", "version_id").blank? and
Story.types.include?(type_id.to_i) and
Story.types.include?(type_id_was.to_i)
return
diff --git a/modules/backlogs/lib/open_project/backlogs/mixins/prevent_issue_sti.rb b/modules/backlogs/lib/open_project/backlogs/mixins/prevent_issue_sti.rb
index 657da7830f33..ccbe648a48e6 100644
--- a/modules/backlogs/lib/open_project/backlogs/mixins/prevent_issue_sti.rb
+++ b/modules/backlogs/lib/open_project/backlogs/mixins/prevent_issue_sti.rb
@@ -31,13 +31,13 @@ module PreventIssueSti
# Overrides ActiveRecord::Inheritance::ClassMethods#sti_name
# so that stories are stored and found with type-attribute = "WorkPackage"
def sti_name
- 'WorkPackage'
+ "WorkPackage"
end
# Overrides ActiveRecord::Inheritance::ClassMethods#find_sti_classes
# so that stories are instantiated correctly despite sti_name being "WorkPackage"
def find_sti_class(type_name)
- type_name = to_s if type_name == 'WorkPackage'
+ type_name = to_s if type_name == "WorkPackage"
super(type_name)
end
diff --git a/modules/backlogs/lib/open_project/backlogs/patches/api/work_package_schema_representer.rb b/modules/backlogs/lib/open_project/backlogs/patches/api/work_package_schema_representer.rb
index 44f39c86f0a8..afef2720cd37 100644
--- a/modules/backlogs/lib/open_project/backlogs/patches/api/work_package_schema_representer.rb
+++ b/modules/backlogs/lib/open_project/backlogs/patches/api/work_package_schema_representer.rb
@@ -36,7 +36,7 @@ module WorkPackageSchemaRepresenter
def extension
->(*) do
schema :position,
- type: 'Integer',
+ type: "Integer",
required: false,
writable: false,
show_if: ->(*) {
@@ -44,7 +44,7 @@ def extension
}
schema :story_points,
- type: 'Integer',
+ type: "Integer",
required: false,
show_if: ->(*) {
backlogs_constraint_passed?(:story_points)
diff --git a/modules/backlogs/lib/open_project/backlogs/patches/project_patch.rb b/modules/backlogs/lib/open_project/backlogs/patches/project_patch.rb
index 4fa563522f13..7cbfe46b1d54 100644
--- a/modules/backlogs/lib/open_project/backlogs/patches/project_patch.rb
+++ b/modules/backlogs/lib/open_project/backlogs/patches/project_patch.rb
@@ -29,7 +29,7 @@
module OpenProject::Backlogs::Patches::ProjectPatch
def self.included(base)
base.class_eval do
- has_and_belongs_to_many :done_statuses, join_table: :done_statuses_for_project, class_name: '::Status'
+ has_and_belongs_to_many :done_statuses, join_table: :done_statuses_for_project, class_name: "::Status"
include InstanceMethods
end
@@ -44,7 +44,7 @@ def rebuild_positions
end
def backlogs_enabled?
- module_enabled? 'backlogs'
+ module_enabled? "backlogs"
end
end
end
diff --git a/modules/backlogs/lib/open_project/backlogs/patches/project_seeder_patch.rb b/modules/backlogs/lib/open_project/backlogs/patches/project_seeder_patch.rb
index 34a33c6dc2d3..ac5428da97f0 100644
--- a/modules/backlogs/lib/open_project/backlogs/patches/project_seeder_patch.rb
+++ b/modules/backlogs/lib/open_project/backlogs/patches/project_seeder_patch.rb
@@ -35,11 +35,11 @@ module InstanceMethods
def seed_versions
super
- version_data = Array(project_data.lookup('versions'))
+ version_data = Array(project_data.lookup("versions"))
return if version_data.blank?
versions = version_data
- .filter_map { |data| Version.find_by(name: data['name']) }
+ .filter_map { |data| Version.find_by(name: data["name"]) }
versions.each do |version|
display = version_settings_display_map[version.name] || VersionSetting::DISPLAY_NONE
@@ -51,11 +51,11 @@ def seed_versions
# This relies on the names from the core's `config/locales/en.seeders.yml`.
def version_settings_display_map
{
- 'Sprint 1' => VersionSetting::DISPLAY_LEFT,
- 'Sprint 2' => VersionSetting::DISPLAY_LEFT,
- 'Bug Backlog' => VersionSetting::DISPLAY_RIGHT,
- 'Product Backlog' => VersionSetting::DISPLAY_RIGHT,
- 'Wish List' => VersionSetting::DISPLAY_RIGHT
+ "Sprint 1" => VersionSetting::DISPLAY_LEFT,
+ "Sprint 2" => VersionSetting::DISPLAY_LEFT,
+ "Bug Backlog" => VersionSetting::DISPLAY_RIGHT,
+ "Product Backlog" => VersionSetting::DISPLAY_RIGHT,
+ "Wish List" => VersionSetting::DISPLAY_RIGHT
}
end
end
diff --git a/modules/backlogs/lib/open_project/backlogs/patches/set_attributes_service_patch.rb b/modules/backlogs/lib/open_project/backlogs/patches/set_attributes_service_patch.rb
index b34115f6e32d..c52e2f56192e 100644
--- a/modules/backlogs/lib/open_project/backlogs/patches/set_attributes_service_patch.rb
+++ b/modules/backlogs/lib/open_project/backlogs/patches/set_attributes_service_patch.rb
@@ -72,8 +72,8 @@ def ancestor_chain(parent_id)
ancestors = real_parent
.ancestors
.includes(project: :enabled_modules)
- .order_by_ancestors('desc')
- .select('work_packages.*, COALESCE(max_depth.depth, 0)')
+ .order_by_ancestors("desc")
+ .select("work_packages.*, COALESCE(max_depth.depth, 0)")
ancestors = [real_parent] + ancestors
end
diff --git a/modules/backlogs/lib/open_project/backlogs/patches/setting_seeder_patch.rb b/modules/backlogs/lib/open_project/backlogs/patches/setting_seeder_patch.rb
index f1d01da5b3a5..5685dd37888a 100644
--- a/modules/backlogs/lib/open_project/backlogs/patches/setting_seeder_patch.rb
+++ b/modules/backlogs/lib/open_project/backlogs/patches/setting_seeder_patch.rb
@@ -37,8 +37,8 @@ module InstanceMethods
def data
original_data = super
- unless original_data['default_projects_modules'].include? 'backlogs'
- original_data['default_projects_modules'] << 'backlogs'
+ unless original_data["default_projects_modules"].include? "backlogs"
+ original_data["default_projects_modules"] << "backlogs"
end
original_data
diff --git a/modules/backlogs/lib/open_project/backlogs/patches/update_service_patch.rb b/modules/backlogs/lib/open_project/backlogs/patches/update_service_patch.rb
index 0951b77da48d..db34b78537c7 100644
--- a/modules/backlogs/lib/open_project/backlogs/patches/update_service_patch.rb
+++ b/modules/backlogs/lib/open_project/backlogs/patches/update_service_patch.rb
@@ -59,8 +59,8 @@ def sorted_descendants(work_package)
work_package
.descendants
.includes(project: :enabled_modules)
- .order_by_ancestors('asc')
- .select('work_packages.*')
+ .order_by_ancestors("asc")
+ .select("work_packages.*")
end
def descendant_tasks_of(descendants)
diff --git a/modules/backlogs/lib/open_project/backlogs/patches/user_patch.rb b/modules/backlogs/lib/open_project/backlogs/patches/user_patch.rb
index 293885a9e9ee..0efed1a4ee31 100644
--- a/modules/backlogs/lib/open_project/backlogs/patches/user_patch.rb
+++ b/modules/backlogs/lib/open_project/backlogs/patches/user_patch.rb
@@ -66,9 +66,9 @@ def write_backlogs_preference(attr, new_value)
def compute_backlogs_preference(attr)
case attr
when :task_color
- ('#%0.6x' % rand(0xFFFFFF)).upcase
+ ("#%0.6x" % rand(0xFFFFFF)).upcase
when :versions_default_fold_state
- 'open'
+ "open"
else
raise "Unsupported attribute '#{attr}'"
end
diff --git a/modules/backlogs/lib/open_project/backlogs/patches/version_patch.rb b/modules/backlogs/lib/open_project/backlogs/patches/version_patch.rb
index 6c989697471e..f58593b0d333 100644
--- a/modules/backlogs/lib/open_project/backlogs/patches/version_patch.rb
+++ b/modules/backlogs/lib/open_project/backlogs/patches/version_patch.rb
@@ -42,7 +42,7 @@ def rebuild_story_positions(project = self.project)
WorkPackage.transaction do
# Remove position from all non-stories
- WorkPackage.where(['project_id = ? AND type_id NOT IN (?) AND position IS NOT NULL', project, Story.types])
+ WorkPackage.where(["project_id = ? AND type_id NOT IN (?) AND position IS NOT NULL", project, Story.types])
.update_all(position: nil)
rebuild_positions(work_packages.where(project_id: project), Story.types)
@@ -80,12 +80,12 @@ def rebuild_positions(scope, type_ids)
wo_position = scope
.where(type_id: type_ids,
position: nil)
- .order(Arel.sql('id'))
+ .order(Arel.sql("id"))
w_position = scope
.where(type_id: type_ids)
.where.not(position: nil)
- .order(Arel.sql('COALESCE(position, 0), id'))
+ .order(Arel.sql("COALESCE(position, 0), id"))
(w_position + wo_position).each_with_index do |work_package, index|
work_package.update_column(:position, index + 1)
diff --git a/modules/backlogs/lib/open_project/backlogs/patches/versions/row_component_patch.rb b/modules/backlogs/lib/open_project/backlogs/patches/versions/row_component_patch.rb
index 33a74b108e8d..0f6979f2dd47 100644
--- a/modules/backlogs/lib/open_project/backlogs/patches/versions/row_component_patch.rb
+++ b/modules/backlogs/lib/open_project/backlogs/patches/versions/row_component_patch.rb
@@ -36,9 +36,9 @@ def button_links
def backlogs_edit_link
return if version.project == table.project || !table.project.module_enabled?("backlogs")
- helpers.link_to_if_authorized '',
- { controller: '/versions', action: 'edit', id: version, project_id: table.project.id },
- class: 'icon icon-edit',
+ helpers.link_to_if_authorized "",
+ { controller: "/versions", action: "edit", id: version, project_id: table.project.id },
+ class: "icon icon-edit",
title: t(:button_edit)
end
end
diff --git a/modules/backlogs/lib/open_project/backlogs/patches/versions_controller_patch.rb b/modules/backlogs/lib/open_project/backlogs/patches/versions_controller_patch.rb
index 0c881c69b5ca..accb410bdfcd 100644
--- a/modules/backlogs/lib/open_project/backlogs/patches/versions_controller_patch.rb
+++ b/modules/backlogs/lib/open_project/backlogs/patches/versions_controller_patch.rb
@@ -47,7 +47,7 @@ def whitelist_update_params
# (column=left|right|none) can be stored when current project does not
# equal the version project (which is valid in inherited versions)
if permitted_params.version.present? && permitted_params.version[:version_settings_attributes].present?
- params['version'] = { version_settings_attributes: permitted_params.version[:version_settings_attributes] }
+ params["version"] = { version_settings_attributes: permitted_params.version[:version_settings_attributes] }
else
# This is an unfortunate hack giving how plugins work at the moment.
# In this else branch we want the `version` to be an empty hash.
@@ -68,9 +68,9 @@ def find_project_and_version
# This forces the current project for the nested version settings in order
# to prevent it from being set through firebug etc. #mass_assignment
def add_project_to_version_settings_attributes
- if permitted_params.version['version_settings_attributes'].present?
- params['version']['version_settings_attributes'].each do |attr_hash|
- attr_hash['project_id'] = @project.id
+ if permitted_params.version["version_settings_attributes"].present?
+ params["version"]["version_settings_attributes"].each do |attr_hash|
+ attr_hash["project_id"] = @project.id
end
end
end
diff --git a/modules/backlogs/lib/open_project/backlogs/patches/work_package_patch.rb b/modules/backlogs/lib/open_project/backlogs/patches/work_package_patch.rb
index c7ec5ad1451c..6e0a5d307dd4 100644
--- a/modules/backlogs/lib/open_project/backlogs/patches/work_package_patch.rb
+++ b/modules/backlogs/lib/open_project/backlogs/patches/work_package_patch.rb
@@ -33,8 +33,8 @@ module OpenProject::Backlogs::Patches::WorkPackagePatch
prepend InstanceMethods
extend ClassMethods
- register_journal_formatted_fields(:decimal, 'story_points')
- register_journal_formatted_fields(:decimal, 'position')
+ register_journal_formatted_fields(:decimal, "story_points")
+ register_journal_formatted_fields(:decimal, "position")
validates_numericality_of :story_points, only_integer: true,
allow_nil: true,
@@ -110,7 +110,7 @@ def blocks
end
def backlogs_enabled?
- !!project.try(:module_enabled?, 'backlogs')
+ !!project.try(:module_enabled?, "backlogs")
end
def in_backlogs_type?
diff --git a/modules/backlogs/lib/open_project/backlogs/query_backlogs_select.rb b/modules/backlogs/lib/open_project/backlogs/query_backlogs_select.rb
index ed96c9b7fafc..64287826355b 100644
--- a/modules/backlogs/lib/open_project/backlogs/query_backlogs_select.rb
+++ b/modules/backlogs/lib/open_project/backlogs/query_backlogs_select.rb
@@ -36,7 +36,7 @@ class QueryBacklogsSelect < Queries::WorkPackages::Selects::WorkPackageSelect
summable: true
},
position: {
- default_order: 'asc',
+ default_order: "asc",
# Sort by position only, always show work_packages without a position at the end
sortable: "CASE WHEN #{WorkPackage.table_name}.position IS NULL THEN 1 ELSE 0 END ASC, #{WorkPackage.table_name}.position"
}
diff --git a/modules/backlogs/lib/open_project/backlogs/work_package_filter.rb b/modules/backlogs/lib/open_project/backlogs/work_package_filter.rb
index e2c662d33ae5..e8a6f952601f 100644
--- a/modules/backlogs/lib/open_project/backlogs/work_package_filter.rb
+++ b/modules/backlogs/lib/open_project/backlogs/work_package_filter.rb
@@ -26,16 +26,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'story'
-require 'task'
+require "story"
+require "task"
module OpenProject::Backlogs
class WorkPackageFilter < ::Queries::WorkPackages::Filter::WorkPackageFilter
def allowed_values
- [[I18n.t('backlogs.story'), 'story'],
- [I18n.t('backlogs.task'), 'task'],
- [I18n.t('backlogs.impediment'), 'impediment'],
- [I18n.t('backlogs.any'), 'any']]
+ [[I18n.t("backlogs.story"), "story"],
+ [I18n.t("backlogs.task"), "task"],
+ [I18n.t("backlogs.impediment"), "impediment"],
+ [I18n.t("backlogs.any"), "any"]]
end
def available?
@@ -60,7 +60,7 @@ def human_name
end
def dependency_class
- '::API::V3::Queries::Schemas::BacklogsTypeDependencyRepresenter'
+ "::API::V3::Queries::Schemas::BacklogsTypeDependencyRepresenter"
end
def ar_object_filter?
@@ -86,28 +86,28 @@ def backlogs_enabled?
end
def sql_for_field(values)
- selected_values = if values.include?('any')
- ['story', 'task']
+ selected_values = if values.include?("any")
+ ["story", "task"]
else
values
end
sql_parts = selected_values.map do |val|
case val
- when 'story'
+ when "story"
sql_for_story
- when 'task'
+ when "task"
sql_for_task
- when 'impediment'
+ when "impediment"
sql_for_impediment
end
end
case operator
- when '='
- sql_parts.join(' OR ')
- when '!'
- 'NOT (' + sql_parts.join(' OR ') + ')'
+ when "="
+ sql_parts.join(" OR ")
+ when "!"
+ "NOT (" + sql_parts.join(" OR ") + ")"
end
end
@@ -116,7 +116,7 @@ def db_table
end
def sql_for_story
- story_types = Story.types.map(&:to_s).join(',')
+ story_types = Story.types.map(&:to_s).join(",")
"(#{db_table}.type_id IN (#{story_types}))"
end
diff --git a/modules/backlogs/lib/openproject-backlogs.rb b/modules/backlogs/lib/openproject-backlogs.rb
index 04918798b753..5c8388d7eafe 100644
--- a/modules/backlogs/lib/openproject-backlogs.rb
+++ b/modules/backlogs/lib/openproject-backlogs.rb
@@ -26,4 +26,4 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'open_project/backlogs'
+require "open_project/backlogs"
diff --git a/modules/backlogs/openproject-backlogs.gemspec b/modules/backlogs/openproject-backlogs.gemspec
index 69fe162f5f9a..c6ba6b8fc6bf 100644
--- a/modules/backlogs/openproject-backlogs.gemspec
+++ b/modules/backlogs/openproject-backlogs.gemspec
@@ -1,15 +1,15 @@
# Describe your gem and declare its dependencies:
Gem::Specification.new do |s|
- s.name = 'openproject-backlogs'
- s.version = '1.0.0'
- s.authors = 'OpenProject GmbH'
- s.email = 'info@openproject.com'
- s.summary = 'OpenProject Backlogs'
- s.description = 'This module adds features enabling agile teams to work with OpenProject in Scrum projects.'
- s.files = Dir['{app,config,db,lib,doc}/**/*', 'README.md']
+ s.name = "openproject-backlogs"
+ s.version = "1.0.0"
+ s.authors = "OpenProject GmbH"
+ s.email = "info@openproject.com"
+ s.summary = "OpenProject Backlogs"
+ s.description = "This module adds features enabling agile teams to work with OpenProject in Scrum projects."
+ s.files = Dir["{app,config,db,lib,doc}/**/*", "README.md"]
- s.add_dependency 'acts_as_list', '~> 1.1.0'
+ s.add_dependency "acts_as_list", "~> 1.1.0"
- s.add_development_dependency 'factory_girl_rails', '~> 4.0'
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.add_development_dependency "factory_girl_rails", "~> 4.0"
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/backlogs/spec/api/work_package_resource_spec.rb b/modules/backlogs/spec/api/work_package_resource_spec.rb
index f52ae22faf3a..8954e078c884 100644
--- a/modules/backlogs/spec/api/work_package_resource_spec.rb
+++ b/modules/backlogs/spec/api/work_package_resource_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'API v3 Work package resource' do
+RSpec.describe "API v3 Work package resource" do
include Rack::Test::Methods
include Capybara::RSpecMatchers
@@ -47,8 +47,8 @@
allow(Story).to receive(:types).and_return([work_package.type_id])
end
- describe '#get' do
- shared_context 'query work package' do
+ describe "#get" do
+ shared_context "query work package" do
before do
allow(User).to receive(:current).and_return(current_user)
get wp_path
@@ -57,29 +57,29 @@
subject { last_response.body }
end
- context 'backlogs activated' do
- include_context 'query work package'
+ context "backlogs activated" do
+ include_context "query work package"
- it { is_expected.to be_json_eql(work_package.story_points.to_json).at_path('storyPoints') }
+ it { is_expected.to be_json_eql(work_package.story_points.to_json).at_path("storyPoints") }
end
- context 'backlogs deactivated' do
+ context "backlogs deactivated" do
let(:project) do
- create(:project, disable_modules: 'backlogs')
+ create(:project, disable_modules: "backlogs")
end
- include_context 'query work package'
+ include_context "query work package"
it { expect(last_response.status).to be 200 }
- it { is_expected.not_to have_json_path('storyPoints') }
+ it { is_expected.not_to have_json_path("storyPoints") }
end
end
- describe '#patch' do
+ describe "#patch" do
let(:valid_params) do
{
- _type: 'WorkPackage',
+ _type: "WorkPackage",
lockVersion: work_package.lock_version
}
end
@@ -88,14 +88,14 @@
before do
allow(User).to receive(:current).and_return current_user
- patch wp_path, params.to_json, 'CONTENT_TYPE' => 'application/json'
+ patch wp_path, params.to_json, "CONTENT_TYPE" => "application/json"
end
- describe 'storyPoints' do
+ describe "storyPoints" do
let(:params) { valid_params.merge(storyPoints: 12) }
it { expect(subject.status).to eq(200) }
- it { expect(subject.body).to be_json_eql(12.to_json).at_path('storyPoints') }
+ it { expect(subject.body).to be_json_eql(12.to_json).at_path("storyPoints") }
end
end
end
diff --git a/modules/backlogs/spec/api/work_packages/form_resource_spec.rb b/modules/backlogs/spec/api/work_packages/form_resource_spec.rb
index 7ece81d2fee8..d779a3628f08 100644
--- a/modules/backlogs/spec/api/work_packages/form_resource_spec.rb
+++ b/modules/backlogs/spec/api/work_packages/form_resource_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'API v3 Work package form resource' do
+RSpec.describe "API v3 Work package form resource" do
include Rack::Test::Methods
include Capybara::RSpecMatchers
@@ -42,42 +42,42 @@
allow(Story).to receive(:types).and_return([work_package.type_id])
end
- describe '#post' do
- shared_examples_for 'valid payload' do
+ describe "#post" do
+ shared_examples_for "valid payload" do
subject { response.body }
it { expect(response.status).to eq(200) }
- it { is_expected.to have_json_path('_embedded/payload') }
+ it { is_expected.to have_json_path("_embedded/payload") }
- it { is_expected.to have_json_path('_embedded/payload/lockVersion') }
+ it { is_expected.to have_json_path("_embedded/payload/lockVersion") }
- it { is_expected.to have_json_path('_embedded/payload/subject') }
+ it { is_expected.to have_json_path("_embedded/payload/subject") }
- it_behaves_like 'API V3 formattable', '_embedded/payload/description' do
- let(:format) { 'markdown' }
+ it_behaves_like "API V3 formattable", "_embedded/payload/description" do
+ let(:format) { "markdown" }
let(:raw) { defined?(raw_value) ? raw_value : work_package.description.to_s }
let(:html) do
- defined?(html_value) ? html_value : ('
' + work_package.description.to_s + '
')
+ defined?(html_value) ? html_value : ('
' + work_package.description.to_s + "
")
end
end
end
- shared_examples_for 'having no errors' do
+ shared_examples_for "having no errors" do
it {
- expect(subject.body).to be_json_eql({}.to_json).at_path('_embedded/validationErrors')
+ expect(subject.body).to be_json_eql({}.to_json).at_path("_embedded/validationErrors")
}
end
- shared_examples_for 'having an error' do |property|
+ shared_examples_for "having an error" do |property|
it { expect(subject.body).to have_json_path("_embedded/validationErrors/#{property}") }
- describe 'error body' do
+ describe "error body" do
let(:error_path) { "_embedded/validationErrors/#{property}" }
- let(:error_id) { 'urn:openproject-org:api:v3:errors:PropertyConstraintViolation'.to_json }
+ let(:error_id) { "urn:openproject-org:api:v3:errors:PropertyConstraintViolation".to_json }
let(:error_body) do
- parse_json(subject.body)['_embedded']['validationErrors'][property]
+ parse_json(subject.body)["_embedded"]["validationErrors"][property]
end
it { expect(subject.body).to have_json_path(error_path) }
@@ -93,47 +93,47 @@
let(:current_user) { authorized_user }
let(:valid_params) do
{
- _type: 'WorkPackage',
+ _type: "WorkPackage",
lockVersion: work_package.lock_version
}
end
let(:valid_params) do
{
- _type: 'WorkPackage',
+ _type: "WorkPackage",
lockVersion: work_package.lock_version
}
end
subject(:response) { last_response }
- shared_context 'post request' do
+ shared_context "post request" do
before do
allow(User).to receive(:current).and_return current_user
- post post_path, (params ? params.to_json : nil), 'CONTENT_TYPE' => 'application/json'
+ post post_path, (params ? params.to_json : nil), "CONTENT_TYPE" => "application/json"
end
end
- describe 'storyPoints' do
- include_context 'post request'
+ describe "storyPoints" do
+ include_context "post request"
- context 'valid storyPoints' do
+ context "valid storyPoints" do
let(:params) { valid_params.merge(storyPoints: 42) }
- it_behaves_like 'valid payload'
+ it_behaves_like "valid payload"
- it_behaves_like 'having no errors'
+ it_behaves_like "having no errors"
- it 'responds with updated story points' do
- expect(subject.body).to be_json_eql(42.to_json).at_path('_embedded/payload/storyPoints')
+ it "responds with updated story points" do
+ expect(subject.body).to be_json_eql(42.to_json).at_path("_embedded/payload/storyPoints")
end
end
- context 'invalid storyPoints' do
- let(:params) { valid_params.merge(storyPoints: 'two') }
+ context "invalid storyPoints" do
+ let(:params) { valid_params.merge(storyPoints: "two") }
- it_behaves_like 'valid payload'
+ it_behaves_like "valid payload"
- it_behaves_like 'having an error', 'storyPoints'
+ it_behaves_like "having an error", "storyPoints"
end
end
end
diff --git a/modules/backlogs/spec/api/work_packages/work_package_schema_representer_spec.rb b/modules/backlogs/spec/api/work_packages/work_package_schema_representer_spec.rb
index dec0f1099f97..aaab18330d76 100644
--- a/modules/backlogs/spec/api/work_packages/work_package_schema_representer_spec.rb
+++ b/modules/backlogs/spec/api/work_packages/work_package_schema_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::WorkPackages::Schema::WorkPackageSchemaRepresenter do
let(:custom_field) { build(:custom_field) }
@@ -50,34 +50,34 @@
allow(work_package).to receive(:leaf?).and_return(true)
end
- describe 'storyPoints' do
+ describe "storyPoints" do
subject { representer.to_json }
- it_behaves_like 'has basic schema properties' do
- let(:path) { 'storyPoints' }
- let(:type) { 'Integer' }
- let(:name) { I18n.t('activerecord.attributes.work_package.story_points') }
+ it_behaves_like "has basic schema properties" do
+ let(:path) { "storyPoints" }
+ let(:type) { "Integer" }
+ let(:name) { I18n.t("activerecord.attributes.work_package.story_points") }
let(:required) { false }
let(:writable) { true }
end
- context 'when backlogs module is disabled' do
+ context "when backlogs module is disabled" do
before do
allow(schema.project).to receive(:backlogs_enabled?).and_return(false)
end
- it 'does not show story points' do
- expect(subject).not_to have_json_path('storyPoints')
+ it "does not show story points" do
+ expect(subject).not_to have_json_path("storyPoints")
end
end
- context 'not a story' do
+ context "not a story" do
before do
allow(schema.type).to receive(:story?).and_return(false)
end
- it 'does not show story points' do
- expect(subject).not_to have_json_path('storyPoints')
+ it "does not show story points" do
+ expect(subject).not_to have_json_path("storyPoints")
end
end
end
diff --git a/modules/backlogs/spec/contracts/work_packages/base_contract_spec.rb b/modules/backlogs/spec/contracts/work_packages/base_contract_spec.rb
index d2cde5da4e5e..c867c39eefb2 100644
--- a/modules/backlogs/spec/contracts/work_packages/base_contract_spec.rb
+++ b/modules/backlogs/spec/contracts/work_packages/base_contract_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WorkPackages::BaseContract, type: :model do
shared_let(:type_feature) { create(:type_feature) }
@@ -45,15 +45,15 @@
end
let(:instance) { described_class.new(work_package, user) }
- let(:version1) { build_stubbed(:version, name: 'Version1', project: p) }
- let(:version2) { build_stubbed(:version, name: 'Version2', project: p) }
+ let(:version1) { build_stubbed(:version, name: "Version1", project: p) }
+ let(:version2) { build_stubbed(:version, name: "Version2", project: p) }
let(:issue_priority) { build(:priority) }
- let(:status) { build_stubbed(:status, name: 'status 1', is_default: true) }
+ let(:status) { build_stubbed(:status, name: "status 1", is_default: true) }
let(:story) do
build_stubbed(:work_package,
- subject: 'Story',
+ subject: "Story",
project:,
type: type_feature,
version: version1,
@@ -64,7 +64,7 @@
let(:story2) do
build_stubbed(:work_package,
- subject: 'Story2',
+ subject: "Story2",
project:,
type: type_feature,
version: version1,
@@ -75,7 +75,7 @@
let(:task) do
build_stubbed(:work_package,
- subject: 'Task',
+ subject: "Task",
type: type_task,
version: version1,
project:,
@@ -86,7 +86,7 @@
let(:task2) do
build_stubbed(:work_package,
- subject: 'Task2',
+ subject: "Task2",
type: type_task,
version: version1,
project:,
@@ -97,7 +97,7 @@
let(:bug) do
build_stubbed(:work_package,
- subject: 'Bug',
+ subject: "Bug",
type: type_bug,
version: version1,
project:,
@@ -108,7 +108,7 @@
let(:bug2) do
build_stubbed(:work_package,
- subject: 'Bug2',
+ subject: "Bug2",
type: type_bug,
version: version1,
project:,
@@ -141,122 +141,122 @@
.to receive(:relatable)
.and_return(relatable_scope)
- allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ 'points_burn_direction' => 'down',
- 'wiki_template' => '',
- 'story_types' => [type_feature.id],
- 'task_type' => type_task.id.to_s })
+ allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ "points_burn_direction" => "down",
+ "wiki_template" => "",
+ "story_types" => [type_feature.id],
+ "task_type" => type_task.id.to_s })
end
- describe 'story_points' do
+ describe "story_points" do
let(:work_package) { task }
- it 'is writable' do
+ it "is writable" do
work_package.story_points = 5
expect(subject).to be_truthy
end
end
- shared_examples_for 'is valid' do
- it 'is valid' do
+ shared_examples_for "is valid" do
+ it "is valid" do
expect(subject).to be_truthy
end
end
- describe 'version being restricted' do
- shared_examples_for 'version not being restricted by the parent' do
+ describe "version being restricted" do
+ shared_examples_for "version not being restricted by the parent" do
before do
work_package.parent ||= parent
end
- describe 'WITHOUT a version and the parent also having no version' do
+ describe "WITHOUT a version and the parent also having no version" do
before do
parent.version = nil
work_package.version = nil
end
- include_examples 'is valid'
+ include_examples "is valid"
end
- describe 'WITHOUT a version and the parent having a version' do
+ describe "WITHOUT a version and the parent having a version" do
before do
parent.version = version1
work_package.version = nil
end
- include_examples 'is valid'
+ include_examples "is valid"
end
- describe 'WITH a version and the parent having a different version' do
+ describe "WITH a version and the parent having a different version" do
before do
parent.version = version1
work_package.version = version2
end
- include_examples 'is valid'
+ include_examples "is valid"
end
- describe 'WITH a version and the parent having the same version' do
+ describe "WITH a version and the parent having the same version" do
before do
parent.version = version1
work_package.version = version1
end
- include_examples 'is valid'
+ include_examples "is valid"
end
- describe 'WITH a version and the parent having no version' do
+ describe "WITH a version and the parent having no version" do
before do
parent.version = nil
work_package.version = version1
end
- include_examples 'is valid'
+ include_examples "is valid"
end
end
- shared_examples_for 'version without restriction' do
- describe 'WITHOUT a version' do
+ shared_examples_for "version without restriction" do
+ describe "WITHOUT a version" do
before do
work_package.version = nil
end
- include_examples 'is valid'
+ include_examples "is valid"
end
- describe 'WITH a version' do
+ describe "WITH a version" do
before do
work_package.version = version1
end
- include_examples 'is valid'
+ include_examples "is valid"
end
end
- describe 'WITH a story' do
+ describe "WITH a story" do
let(:work_package) { story }
- describe 'WITHOUT a parent work_package' do
- it_behaves_like 'version without restriction'
+ describe "WITHOUT a parent work_package" do
+ it_behaves_like "version without restriction"
end
describe "WITH a story as its parent" do
let(:parent) { story2 }
- it_behaves_like 'version not being restricted by the parent'
+ it_behaves_like "version not being restricted by the parent"
end
describe "WITH a non backlogs tracked work_package as its parent" do
let(:parent) { bug }
- it_behaves_like 'version not being restricted by the parent'
+ it_behaves_like "version not being restricted by the parent"
end
end
- describe 'WITH a task' do
+ describe "WITH a task" do
let(:work_package) { task }
- describe 'WITHOUT a parent work_package (would then be an impediment)' do
- it_behaves_like 'version without restriction'
+ describe "WITHOUT a parent work_package (would then be an impediment)" do
+ it_behaves_like "version without restriction"
end
describe "WITH a task as its parent" do
@@ -266,115 +266,115 @@
let(:parent) { task2 }
- it_behaves_like 'version not being restricted by the parent'
+ it_behaves_like "version not being restricted by the parent"
end
describe "WITH a story as its parent" do
let(:parent) { story }
- it_behaves_like 'version not being restricted by the parent'
+ it_behaves_like "version not being restricted by the parent"
end
describe "WITH a non backlogs tracked work_package as its parent" do
let(:parent) { bug }
- it_behaves_like 'version not being restricted by the parent'
+ it_behaves_like "version not being restricted by the parent"
end
end
- describe 'WITH a non backlogs work_package' do
+ describe "WITH a non backlogs work_package" do
let(:work_package) { bug }
- describe 'WITHOUT a parent work_package' do
- it_behaves_like 'version without restriction'
+ describe "WITHOUT a parent work_package" do
+ it_behaves_like "version without restriction"
end
describe "WITH a task as its parent" do
let(:parent) { task2 }
- it_behaves_like 'version not being restricted by the parent'
+ it_behaves_like "version not being restricted by the parent"
end
describe "WITH a story as its parent" do
let(:parent) { story }
- it_behaves_like 'version not being restricted by the parent'
+ it_behaves_like "version not being restricted by the parent"
end
describe "WITH a non backlogs tracked work_package as its parent" do
let(:parent) { bug2 }
- it_behaves_like 'version not being restricted by the parent'
+ it_behaves_like "version not being restricted by the parent"
end
end
end
- describe 'parent has to be in same project' do
- shared_examples_for 'project id unrestricted by parent' do
- describe 'WITH the parent having a different project' do
+ describe "parent has to be in same project" do
+ shared_examples_for "project id unrestricted by parent" do
+ describe "WITH the parent having a different project" do
before do
parent.project = other_project
work_package.parent = parent
end
- include_examples 'is valid'
+ include_examples "is valid"
end
- describe 'WITH the work_package having a different project' do
+ describe "WITH the work_package having a different project" do
before do
work_package.parent = parent
work_package.project = other_project
end
- include_examples 'is valid'
+ include_examples "is valid"
end
end
- describe 'WITH a task' do
+ describe "WITH a task" do
let(:work_package) { task }
- describe 'WITH a story as its parent' do
+ describe "WITH a story as its parent" do
let(:parent) { story }
- include_examples 'project id unrestricted by parent'
+ include_examples "project id unrestricted by parent"
end
- describe 'WITH a non backlogs work package as its parent' do
+ describe "WITH a non backlogs work package as its parent" do
let(:parent) { bug }
- include_examples 'project id unrestricted by parent'
+ include_examples "project id unrestricted by parent"
end
end
- describe 'WITH a story' do
+ describe "WITH a story" do
let(:work_package) { story }
- describe 'WITH a story as its parent' do
+ describe "WITH a story as its parent" do
let(:parent) { story2 }
- include_examples 'project id unrestricted by parent'
+ include_examples "project id unrestricted by parent"
end
- describe 'WITH a non backlogs work package as its parent' do
+ describe "WITH a non backlogs work package as its parent" do
let(:parent) { bug }
- include_examples 'project id unrestricted by parent'
+ include_examples "project id unrestricted by parent"
end
end
- describe 'WITH a non backlogs work package' do
+ describe "WITH a non backlogs work package" do
let(:work_package) { bug }
- describe 'WITH a story as its parent' do
+ describe "WITH a story as its parent" do
let(:parent) { story }
- include_examples 'project id unrestricted by parent'
+ include_examples "project id unrestricted by parent"
end
- describe 'WITH a non backlogs work package as its parent' do
+ describe "WITH a non backlogs work package as its parent" do
let(:parent) { bug2 }
- include_examples 'project id unrestricted by parent'
+ include_examples "project id unrestricted by parent"
end
end
end
diff --git a/modules/backlogs/spec/contracts/work_packages/create_contract_spec.rb b/modules/backlogs/spec/contracts/work_packages/create_contract_spec.rb
index e9d275655783..336bb852c919 100644
--- a/modules/backlogs/spec/contracts/work_packages/create_contract_spec.rb
+++ b/modules/backlogs/spec/contracts/work_packages/create_contract_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WorkPackages::CreateContract do
let(:work_package) { build(:work_package, author: other_user, project:) }
@@ -52,19 +52,19 @@
subject(:contract) { described_class.new(work_package, user) }
- describe 'story points' do
+ describe "story points" do
before do
contract.validate
end
- context 'when not changed' do
- it('is valid') { expect(contract.errors.symbols_for(:story_points)).to be_empty }
+ context "when not changed" do
+ it("is valid") { expect(contract.errors.symbols_for(:story_points)).to be_empty }
end
- context 'when changed' do
- let(:changed_values) { ['story_points'] }
+ context "when changed" do
+ let(:changed_values) { ["story_points"] }
- it('is valid') { expect(contract.errors.symbols_for(:story_points)).to be_empty }
+ it("is valid") { expect(contract.errors.symbols_for(:story_points)).to be_empty }
end
end
end
diff --git a/modules/backlogs/spec/contracts/work_packages/update_contract_spec.rb b/modules/backlogs/spec/contracts/work_packages/update_contract_spec.rb
index 318c2752a47c..ad4acf54c67d 100644
--- a/modules/backlogs/spec/contracts/work_packages/update_contract_spec.rb
+++ b/modules/backlogs/spec/contracts/work_packages/update_contract_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WorkPackages::UpdateContract do
let(:work_package) do
@@ -58,15 +58,15 @@
allow(work_package).to receive(:changed).and_return(changed_values)
end
- describe 'story points' do
- context 'has not changed' do
- it('is valid') { expect(contract.errors.empty?).to be true }
+ describe "story points" do
+ context "has not changed" do
+ it("is valid") { expect(contract.errors.empty?).to be true }
end
- context 'has changed' do
- let(:changed_values) { ['story_points'] }
+ context "has changed" do
+ let(:changed_values) { ["story_points"] }
- it('is valid') { expect(contract.errors.empty?).to be true }
+ it("is valid") { expect(contract.errors.empty?).to be true }
end
end
end
diff --git a/modules/backlogs/spec/controllers/backlogs_settings_controller_spec.rb b/modules/backlogs/spec/controllers/backlogs_settings_controller_spec.rb
index e69f92e34c72..cd0116e2550f 100644
--- a/modules/backlogs/spec/controllers/backlogs_settings_controller_spec.rb
+++ b/modules/backlogs/spec/controllers/backlogs_settings_controller_spec.rb
@@ -26,29 +26,29 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe BacklogsSettingsController do
current_user { build_stubbed(:admin) }
- describe 'GET show' do
- it 'performs that request' do
+ describe "GET show" do
+ it "performs that request" do
get :show
expect(response).to be_successful
expect(response).to render_template :show
end
- context 'as regular user' do
+ context "as regular user" do
current_user { build_stubbed(:user) }
- it 'fails' do
+ it "fails" do
get :show
expect(response.status).to eq 403
end
end
end
- describe 'PUT update' do
+ describe "PUT update" do
subject do
put :update,
params: {
@@ -59,14 +59,14 @@
}
end
- context 'with invalid settings (Regression test #35157)' do
- let(:task_type) { '1234' }
- let(:story_types) { ['1234'] }
+ context "with invalid settings (Regression test #35157)" do
+ let(:task_type) { "1234" }
+ let(:story_types) { ["1234"] }
- it 'does not update the settings' do
+ it "does not update the settings" do
expect(Setting)
.not_to(receive(:[]=))
- .with('plugin_openproject_backlogs')
+ .with("plugin_openproject_backlogs")
subject
@@ -75,14 +75,14 @@
end
end
- context 'with valid settings' do
- let(:task_type) { '1234' }
- let(:story_types) { ['5555'] }
+ context "with valid settings" do
+ let(:task_type) { "1234" }
+ let(:story_types) { ["5555"] }
- it 'does update the settings' do
+ it "does update the settings" do
expect(Setting)
.to(receive(:[]=))
- .with('plugin_openproject_backlogs', { story_types: ['5555'], task_type: '1234' })
+ .with("plugin_openproject_backlogs", { story_types: ["5555"], task_type: "1234" })
subject
@@ -91,13 +91,13 @@
expect(flash[:error]).to be_nil
end
- context 'with a non-admin' do
+ context "with a non-admin" do
current_user { build_stubbed(:user) }
- it 'does not update the settings' do
+ it "does not update the settings" do
expect(Setting)
.not_to(receive(:[]=))
- .with('plugin_openproject_backlogs')
+ .with("plugin_openproject_backlogs")
subject
diff --git a/modules/backlogs/spec/controllers/versions_controller_spec.rb b/modules/backlogs/spec/controllers/versions_controller_spec.rb
index d3b21652a47b..87b7a37d33a8 100644
--- a/modules/backlogs/spec/controllers/versions_controller_spec.rb
+++ b/modules/backlogs/spec/controllers/versions_controller_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe VersionsController do
let(:version) do
create(:version,
- sharing: 'system')
+ sharing: "system")
end
let(:other_project) do
@@ -51,7 +51,7 @@
before do
# Create a version assigned to a project
@oldVersionName = version.name
- @newVersionName = 'NewVersionName'
+ @newVersionName = "NewVersionName"
# Create params to update version
@params = {}
@@ -60,19 +60,19 @@
login_as current_user
end
- describe 'update' do
- it 'does not allow to update versions from different projects' do
+ describe "update" do
+ it "does not allow to update versions from different projects" do
@params[:project_id] = other_project.id
- patch 'update', params: @params
+ patch "update", params: @params
version.reload
expect(response).to redirect_to project_settings_versions_path(other_project)
expect(version.name).to eq(@oldVersionName)
end
- it 'allows to update versions from the version project' do
+ it "allows to update versions from the version project" do
@params[:project_id] = version.project.id
- patch 'update', params: @params
+ patch "update", params: @params
version.reload
expect(response).to redirect_to project_settings_versions_path(version.project)
diff --git a/modules/backlogs/spec/factories/impediment_factory.rb b/modules/backlogs/spec/factories/impediment_factory.rb
index 56bdcd3d7fc8..3b4e977b0e9d 100644
--- a/modules/backlogs/spec/factories/impediment_factory.rb
+++ b/modules/backlogs/spec/factories/impediment_factory.rb
@@ -29,8 +29,8 @@
FactoryBot.define do
factory :impediment do
association :type, factory: :type_task
- subject { 'Impeding progress' }
- description { 'Unable to print recipes' }
+ subject { "Impeding progress" }
+ description { "Unable to print recipes" }
association :priority
association :author, factory: :user
end
diff --git a/modules/backlogs/spec/factories/sprint_factory.rb b/modules/backlogs/spec/factories/sprint_factory.rb
index 01736ae033d4..a07f1b94bf2f 100644
--- a/modules/backlogs/spec/factories/sprint_factory.rb
+++ b/modules/backlogs/spec/factories/sprint_factory.rb
@@ -28,9 +28,9 @@
FactoryBot.define do
factory :sprint do
- name { 'version' }
+ name { "version" }
effective_date { Date.today + 14.days }
- sharing { 'none' }
- status { 'open' }
+ sharing { "none" }
+ status { "open" }
end
end
diff --git a/modules/backlogs/spec/factories/story_factory.rb b/modules/backlogs/spec/factories/story_factory.rb
index 1e67a1a083ca..8ed31eac28e1 100644
--- a/modules/backlogs/spec/factories/story_factory.rb
+++ b/modules/backlogs/spec/factories/story_factory.rb
@@ -30,7 +30,7 @@
factory :story do
priority factory: :priority
sequence(:subject) { |n| "story#{n}" }
- description { 'story story story' }
+ description { "story story story" }
type factory: :type_feature
author factory: :user
end
diff --git a/modules/backlogs/spec/factories/task_factory.rb b/modules/backlogs/spec/factories/task_factory.rb
index 99056543ee5d..455bf2b2e4a1 100644
--- a/modules/backlogs/spec/factories/task_factory.rb
+++ b/modules/backlogs/spec/factories/task_factory.rb
@@ -29,8 +29,8 @@
FactoryBot.define do
factory :task do
association :type, factory: :type_task
- subject { 'Printing Recipes' }
- description { 'Just printing recipes' }
+ subject { "Printing Recipes" }
+ description { "Just printing recipes" }
association :priority
association :author, factory: :user
end
diff --git a/modules/backlogs/spec/features/backlogs/change_status_spec.rb b/modules/backlogs/spec/features/backlogs/change_status_spec.rb
index b332b60ea907..4c636c7435c6 100644
--- a/modules/backlogs/spec/features/backlogs/change_status_spec.rb
+++ b/modules/backlogs/spec/features/backlogs/change_status_spec.rb
@@ -28,10 +28,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../../support/pages/backlogs'
+require "spec_helper"
+require_relative "../../support/pages/backlogs"
-RSpec.describe 'Backlogs context menu', :js, :with_cuprite do
+RSpec.describe "Backlogs context menu", :js, :with_cuprite do
shared_let(:story_type) { create(:type_feature) }
shared_let(:task_type) { create(:type_task) }
shared_let(:project) { create(:project, types: [story_type, task_type]) }
@@ -50,10 +50,10 @@
shared_let(:sprint) do
create(:version,
project:,
- name: 'Sprint')
+ name: "Sprint")
end
- shared_let(:new_status) { create(:default_status, name: 'New') }
- shared_let(:in_progress_status) { create(:status, name: 'In progress') }
+ shared_let(:new_status) { create(:default_status, name: "New") }
+ shared_let(:in_progress_status) { create(:status, name: "In progress") }
shared_let(:default_priority) { create(:default_priority) }
shared_let(:story) do
create(:work_package,
@@ -77,8 +77,8 @@
before do
allow(Setting)
.to receive(:plugin_openproject_backlogs)
- .and_return('story_types' => [story_type.id.to_s],
- 'task_type' => task_type.id.to_s)
+ .and_return("story_types" => [story_type.id.to_s],
+ "task_type" => task_type.id.to_s)
login_as(user)
end
@@ -99,26 +99,26 @@ def expect_fields(enabled: [], disabled: [], none: [])
# this test acts as a control for the other tests in this file as it's easy to
# expect a field to not be present, and have the test still pass when the
# field is renamed.
- context 'when the user has edit_work_packages permission' do
- it 'is possible to edit any story field' do
+ context "when the user has edit_work_packages permission" do
+ it "is possible to edit any story field" do
backlogs_page.visit!
backlogs_page.enter_edit_story_mode(story)
expect_fields(enabled: %i[type subject status story_points])
- backlogs_page.alter_attributes_in_edit_story_mode(story, subject: 'Hello subject')
+ backlogs_page.alter_attributes_in_edit_story_mode(story, subject: "Hello subject")
backlogs_page.save_story_from_edit_mode(story)
- expect(story.reload.subject).to eq('Hello subject')
+ expect(story.reload.subject).to eq("Hello subject")
end
end
- context 'when the user has only change_work_package_status permission' do
+ context "when the user has only change_work_package_status permission" do
before do
- RolePermission.where(permission: 'edit_work_packages').delete_all
+ RolePermission.where(permission: "edit_work_packages").delete_all
end
- it 'is only possible to edit status field of stories' do
+ it "is only possible to edit status field of stories" do
backlogs_page.visit!
backlogs_page.enter_edit_story_mode(story, text: story.status.name)
@@ -131,12 +131,12 @@ def expect_fields(enabled: [], disabled: [], none: [])
end
end
- context 'when the user has neither change_work_package_status nor edit_work_packages permission' do
+ context "when the user has neither change_work_package_status nor edit_work_packages permission" do
before do
- RolePermission.where(permission: ['change_work_package_status', 'edit_work_packages']).delete_all
+ RolePermission.where(permission: ["change_work_package_status", "edit_work_packages"]).delete_all
end
- it 'is not possible to edit any story field' do
+ it "is not possible to edit any story field" do
backlogs_page.visit!
backlogs_page.enter_edit_story_mode(story)
diff --git a/modules/backlogs/spec/features/backlogs/context_menu_spec.rb b/modules/backlogs/spec/features/backlogs/context_menu_spec.rb
index 1f071629b111..f6a602bd5180 100644
--- a/modules/backlogs/spec/features/backlogs/context_menu_spec.rb
+++ b/modules/backlogs/spec/features/backlogs/context_menu_spec.rb
@@ -28,10 +28,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../../support/pages/backlogs'
+require "spec_helper"
+require_relative "../../support/pages/backlogs"
-RSpec.describe 'Backlogs context menu', :js, :with_cuprite do
+RSpec.describe "Backlogs context menu", :js, :with_cuprite do
shared_let(:story_type) { create(:type_feature) }
shared_let(:task_type) { create(:type_task) }
shared_let(:project) { create(:project, types: [story_type, task_type]) }
@@ -45,7 +45,7 @@
shared_let(:sprint) do
create(:version,
project:,
- name: 'Sprint',
+ name: "Sprint",
start_date: Date.yesterday,
effective_date: Date.tomorrow)
end
@@ -65,8 +65,8 @@
before do
allow(Setting)
.to receive(:plugin_openproject_backlogs)
- .and_return('story_types' => [story_type.id.to_s],
- 'task_type' => task_type.id.to_s)
+ .and_return("story_types" => [story_type.id.to_s],
+ "task_type" => task_type.id.to_s)
login_as(user)
end
@@ -77,19 +77,19 @@ def within_backlog_context_menu(&)
backlogs_page.within_backlog_menu(sprint, &)
end
- context 'when the backlog is a sprint backlog (displayed on the left, the default)' do
- it 'displays all menu entries' do
+ context "when the backlog is a sprint backlog (displayed on the left, the default)" do
+ it "displays all menu entries" do
within_backlog_context_menu do |menu|
- expect(menu).to have_link I18n.t('backlogs.add_new_story')
- expect(menu).to have_link I18n.t('label_stories_tasks')
- expect(menu).to have_link I18n.t('label_task_board')
- expect(menu).to have_link I18n.t('backlogs.show_burndown_chart')
- expect(menu).to have_link I18n.t('label_wiki')
+ expect(menu).to have_link I18n.t("backlogs.add_new_story")
+ expect(menu).to have_link I18n.t("label_stories_tasks")
+ expect(menu).to have_link I18n.t("label_task_board")
+ expect(menu).to have_link I18n.t("backlogs.show_burndown_chart")
+ expect(menu).to have_link I18n.t("label_wiki")
end
end
end
- context 'when the backlog is an owner backlog (displayed on the right)' do
+ context "when the backlog is an owner backlog (displayed on the right)" do
let!(:version_setting) do
create(:version_setting,
project:,
@@ -99,71 +99,71 @@ def within_backlog_context_menu(&)
it 'only displays the "New story" and "Stories/Tasks" menu entries' do
within_backlog_context_menu do |menu|
- expect(menu).to have_link I18n.t('backlogs.add_new_story')
- expect(menu).to have_link I18n.t('label_stories_tasks')
- expect(menu).to have_no_link I18n.t('label_task_board')
- expect(menu).to have_no_link I18n.t('backlogs.show_burndown_chart')
- expect(menu).to have_no_link I18n.t('label_wiki')
+ expect(menu).to have_link I18n.t("backlogs.add_new_story")
+ expect(menu).to have_link I18n.t("label_stories_tasks")
+ expect(menu).to have_no_link I18n.t("label_task_board")
+ expect(menu).to have_no_link I18n.t("backlogs.show_burndown_chart")
+ expect(menu).to have_no_link I18n.t("label_wiki")
end
end
end
- context 'when the sprint does not have a start date' do
+ context "when the sprint does not have a start date" do
before do
sprint.update(start_date: nil)
end
it 'does not display the "Burndown chart" menu entry' do
within_backlog_context_menu do |menu|
- expect(menu).to have_no_link I18n.t('backlogs.show_burndown_chart')
+ expect(menu).to have_no_link I18n.t("backlogs.show_burndown_chart")
end
end
end
- context 'when the sprint does not have an effective date' do
+ context "when the sprint does not have an effective date" do
before do
sprint.update(effective_date: nil)
end
it 'does not display the "Burndown chart" menu entry' do
within_backlog_context_menu do |menu|
- expect(menu).to have_no_link I18n.t('backlogs.show_burndown_chart')
+ expect(menu).to have_no_link I18n.t("backlogs.show_burndown_chart")
end
end
end
- context 'when the user does not have add_work_packages permission' do
+ context "when the user does not have add_work_packages permission" do
before do
- RolePermission.where(permission: 'add_work_packages').delete_all
+ RolePermission.where(permission: "add_work_packages").delete_all
end
it 'does not display the "New story" menu entry' do
within_backlog_context_menu do |menu|
- expect(menu).to have_no_link I18n.t('backlogs.add_new_story')
+ expect(menu).to have_no_link I18n.t("backlogs.add_new_story")
end
end
end
- context 'when the user does not have view_taskboards permission' do
+ context "when the user does not have view_taskboards permission" do
before do
- RolePermission.where(permission: 'view_taskboards').delete_all
+ RolePermission.where(permission: "view_taskboards").delete_all
end
it 'does not display the "Task board" menu entry' do
within_backlog_context_menu do |menu|
- expect(menu).to have_no_link I18n.t('label_task_board')
+ expect(menu).to have_no_link I18n.t("label_task_board")
end
end
end
- context 'when the wiki module is not enabled' do
+ context "when the wiki module is not enabled" do
before do
- project.enabled_module_names -= ['wiki']
+ project.enabled_module_names -= ["wiki"]
end
it 'does not display the "Wiki" menu entry' do
within_backlog_context_menu do |menu|
- expect(menu).to have_no_link I18n.t('label_wiki')
+ expect(menu).to have_no_link I18n.t("label_wiki")
end
end
end
diff --git a/modules/backlogs/spec/features/backlogs/create_story_spec.rb b/modules/backlogs/spec/features/backlogs/create_story_spec.rb
index 61f1b7d206b2..5068b7f5bb8e 100644
--- a/modules/backlogs/spec/features/backlogs/create_story_spec.rb
+++ b/modules/backlogs/spec/features/backlogs/create_story_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Backlogs', :js, :with_cuprite do
+RSpec.describe "Backlogs", :js, :with_cuprite do
let(:story_type) do
create(:type_feature)
end
@@ -93,57 +93,57 @@
allow(Setting)
.to receive(:plugin_openproject_backlogs)
- .and_return('story_types' => [story_type.id.to_s,
+ .and_return("story_types" => [story_type.id.to_s,
story_type2.id.to_s,
inactive_story_type.id.to_s],
- 'task_type' => task_type.id.to_s)
+ "task_type" => task_type.id.to_s)
end
- it 'allows creating a new story' do
+ it "allows creating a new story" do
visit backlogs_project_backlogs_path(project)
within("#backlog_#{backlog_version.id}", wait: 10) do
- menu = find('.backlog-menu')
+ menu = find(".backlog-menu")
menu.click
- click_link 'New Story'
- fill_in 'Subject', with: "The new story"
- fill_in 'Story Points', with: "5"
+ click_link "New Story"
+ fill_in "Subject", with: "The new story"
+ fill_in "Story Points", with: "5"
# inactive types should not be selectable
# but the user can choose from the active types
expect(page)
- .to have_no_css('option', text: inactive_story_type.name)
+ .to have_no_css("option", text: inactive_story_type.name)
- select story_type2.name, from: 'Type'
+ select story_type2.name, from: "Type"
# saving the new story
- find(:css, 'input[name=subject]').native.send_key :return
+ find(:css, "input[name=subject]").native.send_key :return
# velocity should be summed up immediately
expect(page)
- .to have_css('.velocity', text: "12")
+ .to have_css(".velocity", text: "12")
# this will ensure that the page refresh is through before we check the order
menu.click
- click_link 'New Story'
- fill_in 'Subject', with: "Another story"
+ click_link "New Story"
+ fill_in "Subject", with: "Another story"
end
# the order is kept even after a page refresh -> it is persisted in the db
page.driver.refresh
expect(page)
- .to have_no_content 'Another story'
+ .to have_no_content "Another story"
expect(page)
- .to have_css '.story:nth-of-type(1)', text: 'The new story'
+ .to have_css ".story:nth-of-type(1)", text: "The new story"
expect(page)
- .to have_css '.story:nth-of-type(2)', text: existing_story1.subject
+ .to have_css ".story:nth-of-type(2)", text: existing_story1.subject
expect(page)
- .to have_css '.story:nth-of-type(3)', text: existing_story2.subject
+ .to have_css ".story:nth-of-type(3)", text: existing_story2.subject
# created with the selected type
expect(page)
- .to have_css '.story:nth-of-type(1) .type_id', text: story_type2.name
+ .to have_css ".story:nth-of-type(1) .type_id", text: story_type2.name
end
end
diff --git a/modules/backlogs/spec/features/backlogs_in_backlog_view_spec.rb b/modules/backlogs/spec/features/backlogs_in_backlog_view_spec.rb
index bca7a75a26a7..5f2ef0ded3b3 100644
--- a/modules/backlogs/spec/features/backlogs_in_backlog_view_spec.rb
+++ b/modules/backlogs/spec/features/backlogs_in_backlog_view_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../support/pages/backlogs'
+require "spec_helper"
+require_relative "../support/pages/backlogs"
-RSpec.describe 'Backlogs in backlog view', :js,
+RSpec.describe "Backlogs in backlog view", :js,
with_cuprite: false do
let!(:project) do
create(:project,
@@ -82,7 +82,7 @@
let!(:other_project_sprint) do
create(:version,
project: other_project,
- sharing: 'system',
+ sharing: "system",
start_date: Date.today - 10.days,
effective_date: Date.today + 10.days)
end
@@ -101,11 +101,11 @@
login_as current_user
allow(Setting)
.to receive(:plugin_openproject_backlogs)
- .and_return('story_types' => [story.id.to_s],
- 'task_type' => task.id.to_s)
+ .and_return("story_types" => [story.id.to_s],
+ "task_type" => task.id.to_s)
end
- it 'displays stories which are editable' do
+ it "displays stories which are editable" do
backlogs_page.visit!
backlogs_page
@@ -132,9 +132,9 @@
# The backlogs can be folded by default
visit my_settings_path
- check 'Show versions folded'
+ check "Show versions folded"
- click_button 'Save'
+ click_button "Save"
backlogs_page.visit!
@@ -150,7 +150,7 @@
# Alter the attributes of the sprint
sleep(0.5)
backlogs_page
- .edit_backlog(sprint, name: '')
+ .edit_backlog(sprint, name: "")
backlogs_page
.expect_and_dismiss_error("Name can't be blank.")
@@ -159,7 +159,7 @@
backlogs_page
.edit_backlog(sprint,
- name: 'New sprint name',
+ name: "New sprint name",
start_date: Date.today + 5.days,
effective_date: Date.today + 20.days)
@@ -168,7 +168,7 @@
sprint.reload
expect(sprint.name)
- .to eql 'New sprint name'
+ .to eql "New sprint name"
expect(sprint.start_date)
.to eql Date.today + 5.days
@@ -179,11 +179,11 @@
# Alter displaying a sprints as a backlog
backlogs_page
- .click_in_backlog_menu(sprint, 'Properties')
+ .click_in_backlog_menu(sprint, "Properties")
- select 'right', from: 'Column in backlog'
+ select "right", from: "Column in backlog"
- click_button 'Save'
+ click_button "Save"
backlogs_page
.expect_and_dismiss_toaster(message: "Successful update.")
@@ -200,11 +200,11 @@
# Alter displaying a backlog as a sprint
backlogs_page
- .click_in_backlog_menu(backlog, 'Properties')
+ .click_in_backlog_menu(backlog, "Properties")
- select 'left', from: 'Column in backlog'
+ select "left", from: "Column in backlog"
- click_button 'Save'
+ click_button "Save"
backlogs_page
.expect_and_dismiss_toaster(message: "Successful update.")
@@ -222,11 +222,11 @@
# Alter displaying a version not at all
backlogs_page
- .click_in_backlog_menu(backlog, 'Properties')
+ .click_in_backlog_menu(backlog, "Properties")
- select 'none', from: 'Column in backlog'
+ select "none", from: "Column in backlog"
- click_button 'Save'
+ click_button "Save"
backlogs_page
.expect_and_dismiss_toaster(message: "Successful update.")
@@ -244,11 +244,11 @@
# Inherited versions can also be modified
backlogs_page
- .click_in_backlog_menu(other_project_sprint, 'Properties')
+ .click_in_backlog_menu(other_project_sprint, "Properties")
- select 'none', from: 'Column in backlog'
+ select "none", from: "Column in backlog"
- click_button 'Save'
+ click_button "Save"
backlogs_page
.expect_and_dismiss_toaster(message: "Successful update.")
diff --git a/modules/backlogs/spec/features/empty_backlogs_spec.rb b/modules/backlogs/spec/features/empty_backlogs_spec.rb
index ec3124e0af89..561dcdb2eb7f 100644
--- a/modules/backlogs/spec/features/empty_backlogs_spec.rb
+++ b/modules/backlogs/spec/features/empty_backlogs_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Empty backlogs project',
+RSpec.describe "Empty backlogs project",
:js, :with_cuprite do
shared_let(:story) { create(:type_feature) }
shared_let(:task) { create(:type_task) }
@@ -39,31 +39,31 @@
login_as current_user
allow(Setting)
.to receive(:plugin_openproject_backlogs)
- .and_return('story_types' => [story.id.to_s],
- 'task_type' => task.id.to_s)
+ .and_return("story_types" => [story.id.to_s],
+ "task_type" => task.id.to_s)
visit backlogs_project_backlogs_path(project)
end
- context 'as admin' do
+ context "as admin" do
let(:current_user) { create(:admin) }
- it 'shows a no results box with action' do
- expect(page).to have_css('.generic-table--no-results-container', text: I18n.t(:backlogs_empty_title))
- expect(page).to have_css('.generic-table--no-results-description', text: I18n.t(:backlogs_empty_action_text))
+ it "shows a no results box with action" do
+ expect(page).to have_css(".generic-table--no-results-container", text: I18n.t(:backlogs_empty_title))
+ expect(page).to have_css(".generic-table--no-results-description", text: I18n.t(:backlogs_empty_action_text))
- link = page.find '.generic-table--no-results-description a'
+ link = page.find ".generic-table--no-results-description a"
expect(link[:href]).to include(new_project_version_path(project))
end
end
- context 'as regular member' do
+ context "as regular member" do
let(:role) { create(:project_role, permissions: %i(view_master_backlog)) }
let(:current_user) { create(:user, member_with_roles: { project => role }) }
- it 'only shows a no results box' do
- expect(page).to have_css('.generic-table--no-results-container', text: I18n.t(:backlogs_empty_title))
- expect(page).to have_no_css('.generic-table--no-results-description')
+ it "only shows a no results box" do
+ expect(page).to have_css(".generic-table--no-results-container", text: I18n.t(:backlogs_empty_title))
+ expect(page).to have_no_css(".generic-table--no-results-description")
end
end
end
diff --git a/modules/backlogs/spec/features/impediments_spec.rb b/modules/backlogs/spec/features/impediments_spec.rb
index b39a86c14d68..30f023bc7864 100644
--- a/modules/backlogs/spec/features/impediments_spec.rb
+++ b/modules/backlogs/spec/features/impediments_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Impediments on taskboard', :js,
+RSpec.describe "Impediments on taskboard", :js,
with_cuprite: false do
let!(:project) do
create(:project,
@@ -104,87 +104,87 @@
login_as current_user
allow(Setting)
.to receive(:plugin_openproject_backlogs)
- .and_return('story_types' => [story.id.to_s],
- 'task_type' => task.id.to_s)
+ .and_return("story_types" => [story.id.to_s],
+ "task_type" => task.id.to_s)
end
- it 'allows creating and updating impediments' do
+ it "allows creating and updating impediments" do
visit backlogs_project_sprint_taskboard_path(project, sprint)
- find('#impediments .add_new').click
+ find("#impediments .add_new").click
- fill_in 'subject', with: 'New impediment'
- fill_in 'blocks_ids', with: task1.id
- select current_user.name, from: 'assigned_to_id'
- click_on 'OK'
+ fill_in "subject", with: "New impediment"
+ fill_in "blocks_ids", with: task1.id
+ select current_user.name, from: "assigned_to_id"
+ click_on "OK"
# Saves successfully
expect(page)
- .to have_css('div.impediment', text: 'New impediment')
+ .to have_css("div.impediment", text: "New impediment")
expect(page)
- .to have_no_css('div.impediment.error', text: 'New impediment')
+ .to have_no_css("div.impediment.error", text: "New impediment")
# Attempt to create a new impediment with the id of a story from another sprint
- find('#impediments .add_new').click
+ find("#impediments .add_new").click
- fill_in 'subject', with: 'Other sprint impediment'
- fill_in 'blocks_ids', with: other_story.id
- click_on 'OK'
+ fill_in "subject", with: "Other sprint impediment"
+ fill_in "blocks_ids", with: other_story.id
+ click_on "OK"
# Saves unsuccessfully
expect(page)
- .to have_css('div.impediment', text: 'Other sprint impediment')
+ .to have_css("div.impediment", text: "Other sprint impediment")
expect(page)
- .to have_css('div.impediment.error', text: 'Other sprint impediment')
+ .to have_css("div.impediment.error", text: "Other sprint impediment")
expect(page)
- .to have_css('#msgBox',
+ .to have_css("#msgBox",
text: "IDs of blocked work packages can only contain IDs of work packages in the current sprint.")
- click_on 'OK'
+ click_on "OK"
# Attempt to create a new impediment with a non existing id
- find('#impediments .add_new').click
+ find("#impediments .add_new").click
- fill_in 'subject', with: 'Invalid id impediment'
- fill_in 'blocks_ids', with: '0'
- click_on 'OK'
+ fill_in "subject", with: "Invalid id impediment"
+ fill_in "blocks_ids", with: "0"
+ click_on "OK"
# Saves unsuccessfully
expect(page)
- .to have_css('div.impediment', text: 'Invalid id impediment')
+ .to have_css("div.impediment", text: "Invalid id impediment")
expect(page)
- .to have_css('div.impediment.error', text: 'Invalid id impediment')
+ .to have_css("div.impediment.error", text: "Invalid id impediment")
expect(page)
- .to have_css('#msgBox',
+ .to have_css("#msgBox",
text: "IDs of blocked work packages can only contain IDs of work packages in the current sprint.")
- click_on 'OK'
+ click_on "OK"
# Attempt to create a new impediment without specifying the blocked story/task
- find('#impediments .add_new').click
+ find("#impediments .add_new").click
- fill_in 'subject', with: 'Unblocking impediment'
- click_on 'OK'
+ fill_in "subject", with: "Unblocking impediment"
+ click_on "OK"
# Saves unsuccessfully
expect(page)
- .to have_css('div.impediment', text: 'Unblocking impediment')
+ .to have_css("div.impediment", text: "Unblocking impediment")
expect(page)
- .to have_css('div.impediment.error', text: 'Unblocking impediment')
+ .to have_css("div.impediment.error", text: "Unblocking impediment")
expect(page)
- .to have_css('#msgBox', text: "IDs of blocked work packages must contain the ID of at least one ticket")
- click_on 'OK'
+ .to have_css("#msgBox", text: "IDs of blocked work packages must contain the ID of at least one ticket")
+ click_on "OK"
# Updating an impediment
- find('#impediments .subject', text: 'New impediment').click
+ find("#impediments .subject", text: "New impediment").click
- fill_in 'subject', with: 'Updated impediment'
- fill_in 'blocks_ids', with: story.id
- click_on 'OK'
+ fill_in "subject", with: "Updated impediment"
+ fill_in "blocks_ids", with: story.id
+ click_on "OK"
# Saves successfully
expect(page)
- .to have_css('div.impediment', text: 'Updated impediment')
+ .to have_css("div.impediment", text: "Updated impediment")
expect(page)
- .to have_no_css('div.impediment.error', text: 'Updated impediment')
+ .to have_no_css("div.impediment.error", text: "Updated impediment")
end
end
diff --git a/modules/backlogs/spec/features/resolved_status_spec.rb b/modules/backlogs/spec/features/resolved_status_spec.rb
index 3938d14c3028..f2b36fba478a 100644
--- a/modules/backlogs/spec/features/resolved_status_spec.rb
+++ b/modules/backlogs/spec/features/resolved_status_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Resolved status' do
+RSpec.describe "Resolved status" do
let!(:project) do
create(:project,
enabled_module_names: %w(backlogs))
@@ -48,13 +48,13 @@
login_as current_user
end
- it 'allows setting a status as done although it is not closed' do
- settings_page.visit_tab! 'backlogs'
+ it "allows setting a status as done although it is not closed" do
+ settings_page.visit_tab! "backlogs"
check status.name
- click_button 'Save'
+ click_button "Save"
- settings_page.expect_toast(message: 'Successful update')
+ settings_page.expect_toast(message: "Successful update")
expect(page)
.to have_checked_field(status.name)
diff --git a/modules/backlogs/spec/features/stories_in_backlog_spec.rb b/modules/backlogs/spec/features/stories_in_backlog_spec.rb
index b2980a8b3cf8..7aa717869846 100644
--- a/modules/backlogs/spec/features/stories_in_backlog_spec.rb
+++ b/modules/backlogs/spec/features/stories_in_backlog_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../support/pages/backlogs'
+require "spec_helper"
+require_relative "../support/pages/backlogs"
-RSpec.describe 'Stories in backlog', :js,
+RSpec.describe "Stories in backlog", :js,
with_cuprite: false do
let!(:project) do
create(:project,
@@ -135,11 +135,11 @@
login_as current_user
allow(Setting)
.to receive(:plugin_openproject_backlogs)
- .and_return('story_types' => [story.id.to_s, other_story.id.to_s],
- 'task_type' => task.id.to_s)
+ .and_return("story_types" => [story.id.to_s, other_story.id.to_s],
+ "task_type" => task.id.to_s)
end
- it 'displays stories which are editable' do
+ it "displays stories which are editable" do
backlogs_page.visit!
# All stories are visible in their sprint/backlog
@@ -172,16 +172,16 @@
SeleniumHubWaiter.wait
# Creating a story
backlogs_page
- .click_in_backlog_menu(sprint, 'New Story')
+ .click_in_backlog_menu(sprint, "New Story")
SeleniumHubWaiter.wait
backlogs_page
- .edit_new_story(subject: 'New story',
+ .edit_new_story(subject: "New story",
story_points: 10)
new_story = nil
retry_block do
- new_story = WorkPackage.find_by(subject: 'New story')
+ new_story = WorkPackage.find_by(subject: "New story")
raise "Expected story" unless new_story
end
@@ -204,16 +204,16 @@
SeleniumHubWaiter.wait
backlogs_page
.edit_story(sprint_story1,
- subject: 'Altered story1',
+ subject: "Altered story1",
story_points: 15)
retry_block do
sprint_story1.reload
- raise "Expected story to be renamed" unless sprint_story1.subject == 'Altered story1'
+ raise "Expected story to be renamed" unless sprint_story1.subject == "Altered story1"
end
backlogs_page
- .expect_for_story(sprint_story1, subject: 'Altered story1')
+ .expect_for_story(sprint_story1, subject: "Altered story1")
# Updating the story_points of a story will update the velocity of the sprint
backlogs_page
@@ -266,14 +266,14 @@
SeleniumHubWaiter.wait
backlogs_page
.alter_attributes_in_edit_story_mode(backlog_story1,
- subject: 'Altered backlog story1',
+ subject: "Altered backlog story1",
status: other_status.name)
backlogs_page
.save_story_from_edit_mode(backlog_story1)
retry_block do
backlog_story1.reload
- raise "Expected story to be renamed" unless backlog_story1.subject == 'Altered backlog story1'
+ raise "Expected story to be renamed" unless backlog_story1.subject == "Altered backlog story1"
end
expect(backlog_story1.status)
@@ -281,7 +281,7 @@
backlogs_page
.expect_for_story(backlog_story1,
- subject: 'Altered backlog story1',
+ subject: "Altered backlog story1",
status: other_status.name)
SeleniumHubWaiter.wait
@@ -303,14 +303,14 @@
backlogs_page
.expect_for_story(backlog_story1,
- subject: 'Altered backlog story1',
+ subject: "Altered backlog story1",
status: default_status.name,
type: other_story.name)
# Clicking would lead to having the burndown chart opened in another tab
# which seems hard to test with selenium.
backlogs_page
- .expect_in_backlog_menu(sprint, 'Burndown Chart')
+ .expect_in_backlog_menu(sprint, "Burndown Chart")
# One can switch to the work package page by clicking on the id
# Clicking on it will open the wp in another tab which seems to trip up selenium.
@@ -319,7 +319,7 @@
# Go to the index page of work packages within that sprint via the menu
backlogs_page
- .click_in_backlog_menu(sprint, 'Stories/Tasks')
+ .click_in_backlog_menu(sprint, "Stories/Tasks")
wp_table = Pages::WorkPackagesTable.new(project)
diff --git a/modules/backlogs/spec/features/tasks_on_taskboard_spec.rb b/modules/backlogs/spec/features/tasks_on_taskboard_spec.rb
index 3965468c0f5b..24b37f5251c5 100644
--- a/modules/backlogs/spec/features/tasks_on_taskboard_spec.rb
+++ b/modules/backlogs/spec/features/tasks_on_taskboard_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../support/pages/taskboard'
+require "spec_helper"
+require_relative "../support/pages/taskboard"
-RSpec.describe 'Tasks on taskboard', :js,
+RSpec.describe "Tasks on taskboard", :js,
with_cuprite: false do
let!(:project) do
create(:project,
@@ -141,11 +141,11 @@
login_as current_user
allow(Setting)
.to receive(:plugin_openproject_backlogs)
- .and_return('story_types' => [story.id.to_s, other_story.id.to_s],
- 'task_type' => task.id.to_s)
+ .and_return("story_types" => [story.id.to_s, other_story.id.to_s],
+ "task_type" => task.id.to_s)
end
- it 'displays stories which are editable' do
+ it "displays stories which are editable" do
taskboard_page.visit!
# All stories of the sprint are visible
@@ -235,18 +235,18 @@
# There is a button to the burndown chart
expect(page)
.to have_css("a[href='#{backlogs_project_sprint_burndown_chart_path(project, sprint)}']",
- text: 'Burndown Chart')
+ text: "Burndown Chart")
# Tasks can get a color per assigned user
visit my_settings_path
- fill_in 'Task color', with: '#FBC4B3'
+ fill_in "Task color", with: "#FBC4B3"
- click_button 'Save'
+ click_button "Save"
taskboard_page.visit!
taskboard_page
- .expect_color_for_task('#FBC4B3', story1_task)
+ .expect_color_for_task("#FBC4B3", story1_task)
end
end
diff --git a/modules/backlogs/spec/features/work_packages/filter_spec.rb b/modules/backlogs/spec/features/work_packages/filter_spec.rb
index 364659094f90..33a5f20b3ac9 100644
--- a/modules/backlogs/spec/features/work_packages/filter_spec.rb
+++ b/modules/backlogs/spec/features/work_packages/filter_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Filter by backlog type', :js do
+RSpec.describe "Filter by backlog type", :js do
let(:story_type) do
type = create(:type_feature)
project.types << type
@@ -74,23 +74,23 @@
allow(Setting)
.to receive(:plugin_openproject_backlogs)
- .and_return('story_types' => [story_type.id.to_s],
- 'task_type' => task_type.id.to_s)
+ .and_return("story_types" => [story_type.id.to_s],
+ "task_type" => task_type.id.to_s)
wp_table.visit!
end
- it 'allows filtering, saving and retaining the filter' do
+ it "allows filtering, saving and retaining the filter" do
filters.open
- filters.add_filter_by('Backlog type', 'is (OR)', 'Story', 'backlogsWorkPackageType')
+ filters.add_filter_by("Backlog type", "is (OR)", "Story", "backlogsWorkPackageType")
wp_table.expect_work_package_listed work_package_with_story_type
wp_table.ensure_work_package_not_listed! work_package_with_task_type
- wp_table.save_as('Some query name')
+ wp_table.save_as("Some query name")
- filters.remove_filter 'backlogsWorkPackageType'
+ filters.remove_filter "backlogsWorkPackageType"
wp_table.expect_work_package_listed work_package_with_story_type, work_package_with_task_type
@@ -103,6 +103,6 @@
filters.open
- filters.expect_filter_by('Backlog type', 'is (OR)', 'Story', 'backlogsWorkPackageType')
+ filters.expect_filter_by("Backlog type", "is (OR)", "Story", "backlogsWorkPackageType")
end
end
diff --git a/modules/backlogs/spec/features/work_packages/story_points_spec.rb b/modules/backlogs/spec/features/work_packages/story_points_spec.rb
index 76de80282441..e9e5f8ff3d1d 100644
--- a/modules/backlogs/spec/features/work_packages/story_points_spec.rb
+++ b/modules/backlogs/spec/features/work_packages/story_points_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work packages having story points', :js, :with_cuprite do
+RSpec.describe "Work packages having story points", :js, :with_cuprite do
before do
login_as current_user
- allow(Setting).to receive(:plugin_openproject_backlogs).and_return('points_burn_direction' => 'down',
- 'wiki_template' => '',
- 'story_types' => [story_type.id.to_s],
- 'task_type' => task_type.id.to_s)
+ allow(Setting).to receive(:plugin_openproject_backlogs).and_return("points_burn_direction" => "down",
+ "wiki_template" => "",
+ "story_types" => [story_type.id.to_s],
+ "task_type" => task_type.id.to_s)
end
let(:current_user) { create(:admin) }
@@ -46,7 +46,7 @@
let(:story_type) { create(:type_feature) }
let(:task_type) { create(:type_feature) }
- describe 'showing the story points on the work package show page' do
+ describe "showing the story points on the work package show page" do
let(:story_points) { 42 }
let(:story_with_sp) do
create(:story,
@@ -57,7 +57,7 @@
story_points:)
end
- it 'is displayed' do
+ it "is displayed" do
wp_page = Pages::FullWorkPackage.new(story_with_sp)
wp_page.visit!
diff --git a/modules/backlogs/spec/helpers/version_settings_helper_spec.rb b/modules/backlogs/spec/helpers/version_settings_helper_spec.rb
index 545ddea42370..d694f6a55c2f 100644
--- a/modules/backlogs/spec/helpers/version_settings_helper_spec.rb
+++ b/modules/backlogs/spec/helpers/version_settings_helper_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe VersionSettingsHelper do
- describe '#position_display_options' do
+ describe "#position_display_options" do
before do
- @expected_options = [[I18n.t('version_settings_display_option_none'), 1],
- [I18n.t('version_settings_display_option_left'), 2],
- [I18n.t('version_settings_display_option_right'), 3]]
+ @expected_options = [[I18n.t("version_settings_display_option_none"), 1],
+ [I18n.t("version_settings_display_option_left"), 2],
+ [I18n.t("version_settings_display_option_right"), 3]]
end
it { expect(helper.send(:position_display_options)).to eql @expected_options }
diff --git a/modules/backlogs/spec/models/backlog_spec.rb b/modules/backlogs/spec/models/backlog_spec.rb
index 12cf765bd802..5730d6897dfb 100644
--- a/modules/backlogs/spec/models/backlog_spec.rb
+++ b/modules/backlogs/spec/models/backlog_spec.rb
@@ -26,24 +26,24 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Backlog do
let(:project) { build(:project) }
before do
@feature = create(:type_feature)
- allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ 'story_types' => [@feature.id.to_s],
- 'task_type' => '0' })
+ allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ "story_types" => [@feature.id.to_s],
+ "task_type" => "0" })
@status = create(:status)
end
- describe 'Class Methods' do
- describe '#owner_backlogs' do
- describe 'WITH one open version defined in the project' do
+ describe "Class Methods" do
+ describe "#owner_backlogs" do
+ describe "WITH one open version defined in the project" do
before do
@project = project
- @work_packages = [create(:work_package, subject: 'work_package1', project: @project, type: @feature,
+ @work_packages = [create(:work_package, subject: "work_package1", project: @project, type: @feature,
status: @status)]
@version = create(:version, project:, work_packages: @work_packages)
@version_settings = @version.version_settings.create(display: VersionSetting::DISPLAY_RIGHT, project:)
diff --git a/modules/backlogs/spec/models/burndown_spec.rb b/modules/backlogs/spec/models/burndown_spec.rb
index 44072a954dc7..ae8fe6ad4ad2 100644
--- a/modules/backlogs/spec/models/burndown_spec.rb
+++ b/modules/backlogs/spec/models/burndown_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Burndown do
def set_attribute_journalized(story, attribute, value, day)
@@ -54,19 +54,19 @@ def set_attribute_journalized(story, attribute, value, day)
project
end
- let(:issue_open) { create(:status, name: 'status 1', is_default: true) }
- let(:issue_closed) { create(:status, name: 'status 2', is_closed: true) }
- let(:issue_resolved) { create(:status, name: 'status 3', is_closed: false) }
+ let(:issue_open) { create(:status, name: "status 1", is_default: true) }
+ let(:issue_closed) { create(:status, name: "status 2", is_closed: true) }
+ let(:issue_resolved) { create(:status, name: "status 3", is_closed: false) }
before do
Rails.cache.clear
login_as(user)
- allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ 'points_burn_direction' => 'down',
- 'wiki_template' => '',
- 'story_types' => [type_feature.id.to_s],
- 'task_type' => type_task.id.to_s })
+ allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ "points_burn_direction" => "down",
+ "wiki_template" => "",
+ "story_types" => [type_feature.id.to_s],
+ "task_type" => type_task.id.to_s })
project.save!
@@ -79,35 +79,35 @@ def set_attribute_journalized(story, attribute, value, day)
end
end
- describe 'Sprint Burndown' do
- describe 'WITH the today date fixed to April 4th, 2011 and having a 10 (working days) sprint' do
+ describe "Sprint Burndown" do
+ describe "WITH the today date fixed to April 4th, 2011 and having a 10 (working days) sprint" do
before do
- allow(Time).to receive(:now).and_return(Time.utc(2011, 'apr', 4, 20, 15, 1))
+ allow(Time).to receive(:now).and_return(Time.utc(2011, "apr", 4, 20, 15, 1))
allow(Date).to receive(:today).and_return(Date.civil(2011, 4, 4))
end
- describe 'WITH having a version in the future' do
+ describe "WITH having a version in the future" do
before do
version.start_date = Time.zone.today + 1.day
version.effective_date = Time.zone.today + 6.days
version.save!
end
- it 'generates a burndown' do
+ it "generates a burndown" do
expect(sprint.burndown(project).series[:story_points]).to be_empty
end
end
- describe 'WITH having a 10 (working days) sprint and being 5 (working) days into it' do
+ describe "WITH having a 10 (working days) sprint and being 5 (working) days into it" do
before do
version.start_date = Time.zone.today - 7.days
version.effective_date = Time.zone.today + 6.days
version.save!
end
- describe 'WITH 1 story assigned to the sprint' do
+ describe "WITH 1 story assigned to the sprint" do
let(:story) do
- build(:story, subject: 'Story 1',
+ build(:story, subject: "Story 1",
project:,
version:,
type: type_feature,
@@ -117,7 +117,7 @@ def set_attribute_journalized(story, attribute, value, day)
updated_at: Time.zone.today - 20.days)
end
- describe 'WITH the story having story_point defined on creation' do
+ describe "WITH the story having story_point defined on creation" do
before do
story.story_points = 9
story.save!
@@ -126,7 +126,7 @@ def set_attribute_journalized(story, attribute, value, day)
subject(:burndown) { described_class.new(sprint, project) }
- describe 'WITH the story being closed and opened again within the sprint duration' do
+ describe "WITH the story being closed and opened again within the sprint duration" do
before do
set_attribute_journalized story, :status_id=, issue_closed.id, 6.days.ago
set_attribute_journalized story, :status_id=, issue_open.id, 3.days.ago
@@ -153,7 +153,7 @@ def set_attribute_journalized(story, attribute, value, day)
end
end
- describe 'WITH 10 stories assigned to the sprint' do
+ describe "WITH 10 stories assigned to the sprint" do
let!(:stories) do
stories = []
@@ -174,21 +174,21 @@ def set_attribute_journalized(story, attribute, value, day)
stories
end
- describe 'WITH each story having story points defined at start' do
+ describe "WITH each story having story points defined at start" do
before do
stories.each_with_index do |s, _i|
set_attribute_journalized s, :story_points=, 10, version.start_date - 3.days
end
end
- describe 'WITH 5 stories having been reduced to 0 story points, one story per day' do
+ describe "WITH 5 stories having been reduced to 0 story points, one story per day" do
before do
5.times do |i|
set_attribute_journalized stories[i], :story_points=, nil, version.start_date + i.days + 1.hour
end
end
- describe 'THEN' do
+ describe "THEN" do
subject(:burndown) { described_class.new(sprint, project) }
it { expect(burndown.story_points).to eql [90.0, 80.0, 70.0, 60.0, 50.0, 50.0] }
diff --git a/modules/backlogs/spec/models/impediment_spec.rb b/modules/backlogs/spec/models/impediment_spec.rb
index a8da3ece88ad..f83610b6b799 100644
--- a/modules/backlogs/spec/models/impediment_spec.rb
+++ b/modules/backlogs/spec/models/impediment_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Impediment do
let(:user) { @user ||= create(:user) }
@@ -74,38 +74,38 @@
before do
allow(Setting)
.to receive(:plugin_openproject_backlogs)
- .and_return({ 'points_burn_direction' => 'down',
- 'wiki_template' => '',
- 'story_types' => [type_feature.id.to_s],
- 'task_type' => type_task.id.to_s })
+ .and_return({ "points_burn_direction" => "down",
+ "wiki_template" => "",
+ "story_types" => [type_feature.id.to_s],
+ "task_type" => type_task.id.to_s })
login_as user
end
- describe 'instance methods' do
- describe 'blocks_ids=/blocks_ids' do
- describe 'WITH an integer' do
+ describe "instance methods" do
+ describe "blocks_ids=/blocks_ids" do
+ describe "WITH an integer" do
it do
impediment.blocks_ids = 2
expect(impediment.blocks_ids).to eql [2]
end
end
- describe 'WITH a string' do
+ describe "WITH a string" do
it do
- impediment.blocks_ids = '1, 2, 3'
+ impediment.blocks_ids = "1, 2, 3"
expect(impediment.blocks_ids).to eql [1, 2, 3]
end
end
- describe 'WITH an array' do
+ describe "WITH an array" do
it do
impediment.blocks_ids = [1, 2, 3]
expect(impediment.blocks_ids).to eql [1, 2, 3]
end
end
- describe 'WITH loading from the backend' do
+ describe "WITH loading from the backend" do
before do
feature.version = version
feature.save
diff --git a/modules/backlogs/spec/models/issue_position_spec.rb b/modules/backlogs/spec/models/issue_position_spec.rb
index d4424f7b4c64..9916174b41cb 100644
--- a/modules/backlogs/spec/models/issue_position_spec.rb
+++ b/modules/backlogs/spec/models/issue_position_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WorkPackage do
- describe 'Story positions' do
+ describe "Story positions" do
def build_work_package(options)
build(:work_package, options.reverse_merge(version_id: sprint_1.id,
priority_id: priority.id,
@@ -46,31 +46,31 @@ def create_work_package(options)
let(:priority) { create(:priority_normal) }
let(:project) { create(:project) }
- let(:story_type) { create(:type, name: 'Story') }
- let(:epic_type) { create(:type, name: 'Epic') }
- let(:task_type) { create(:type, name: 'Task') }
- let(:other_type) { create(:type, name: 'Feedback') }
+ let(:story_type) { create(:type, name: "Story") }
+ let(:epic_type) { create(:type, name: "Epic") }
+ let(:task_type) { create(:type, name: "Task") }
+ let(:other_type) { create(:type, name: "Feedback") }
- let(:sprint_1) { create(:version, project_id: project.id, name: 'Sprint 1') }
- let(:sprint_2) { create(:version, project_id: project.id, name: 'Sprint 2') }
+ let(:sprint_1) { create(:version, project_id: project.id, name: "Sprint 1") }
+ let(:sprint_2) { create(:version, project_id: project.id, name: "Sprint 2") }
- let(:work_package_1) { create_work_package(subject: 'WorkPackage 1', version_id: sprint_1.id) }
- let(:work_package_2) { create_work_package(subject: 'WorkPackage 2', version_id: sprint_1.id) }
- let(:work_package_3) { create_work_package(subject: 'WorkPackage 3', version_id: sprint_1.id) }
- let(:work_package_4) { create_work_package(subject: 'WorkPackage 4', version_id: sprint_1.id) }
- let(:work_package_5) { create_work_package(subject: 'WorkPackage 5', version_id: sprint_1.id) }
+ let(:work_package_1) { create_work_package(subject: "WorkPackage 1", version_id: sprint_1.id) }
+ let(:work_package_2) { create_work_package(subject: "WorkPackage 2", version_id: sprint_1.id) }
+ let(:work_package_3) { create_work_package(subject: "WorkPackage 3", version_id: sprint_1.id) }
+ let(:work_package_4) { create_work_package(subject: "WorkPackage 4", version_id: sprint_1.id) }
+ let(:work_package_5) { create_work_package(subject: "WorkPackage 5", version_id: sprint_1.id) }
- let(:work_package_a) { create_work_package(subject: 'WorkPackage a', version_id: sprint_2.id) }
- let(:work_package_b) { create_work_package(subject: 'WorkPackage b', version_id: sprint_2.id) }
- let(:work_package_c) { create_work_package(subject: 'WorkPackage c', version_id: sprint_2.id) }
+ let(:work_package_a) { create_work_package(subject: "WorkPackage a", version_id: sprint_2.id) }
+ let(:work_package_b) { create_work_package(subject: "WorkPackage b", version_id: sprint_2.id) }
+ let(:work_package_c) { create_work_package(subject: "WorkPackage c", version_id: sprint_2.id) }
let(:feedback_1) do
- create_work_package(subject: 'Feedback 1', version_id: sprint_1.id,
+ create_work_package(subject: "Feedback 1", version_id: sprint_1.id,
type_id: other_type.id)
end
let(:task_1) do
- create_work_package(subject: 'Task 1', version_id: sprint_1.id,
+ create_work_package(subject: "Task 1", version_id: sprint_1.id,
type_id: task_type.id)
end
@@ -87,9 +87,9 @@ def create_work_package(options)
Version.delete_all
# Enable and configure backlogs
- project.enabled_module_names = project.enabled_module_names + ['backlogs']
- allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ 'story_types' => [story_type.id, epic_type.id],
- 'task_type' => task_type.id })
+ project.enabled_module_names = project.enabled_module_names + ["backlogs"]
+ allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ "story_types" => [story_type.id, epic_type.id],
+ "task_type" => task_type.id })
# Otherwise the type id's from the previous test are still active
WorkPackage.instance_variable_set(:@backlogs_types, nil)
@@ -110,42 +110,42 @@ def create_work_package(options)
work_package_c.move_to_bottom
end
- describe '- Creating a work_package in a sprint' do
- it 'adds it to the bottom of the list' do
- new_work_package = create_work_package(subject: 'Newest WorkPackage', version_id: sprint_1.id)
+ describe "- Creating a work_package in a sprint" do
+ it "adds it to the bottom of the list" do
+ new_work_package = create_work_package(subject: "Newest WorkPackage", version_id: sprint_1.id)
expect(new_work_package).not_to be_new_record
expect(new_work_package).to be_last
end
- it 'does not reorder the existing work_packages' do
- new_work_package = create_work_package(subject: 'Newest WorkPackage', version_id: sprint_1.id)
+ it "does not reorder the existing work_packages" do
+ new_work_package = create_work_package(subject: "Newest WorkPackage", version_id: sprint_1.id)
expect([work_package_1, work_package_2, work_package_3, work_package_4,
work_package_5].each(&:reload).map(&:position)).to eq([1, 2, 3, 4, 5])
end
end
- describe '- Removing a work_package from the sprint' do
- it 'reorders the remaining work_packages' do
+ describe "- Removing a work_package from the sprint" do
+ it "reorders the remaining work_packages" do
work_package_2.version = sprint_2
work_package_2.save!
- expect(sprint_1.work_packages.order(Arel.sql('id'))).to eq([work_package_1, work_package_3, work_package_4,
+ expect(sprint_1.work_packages.order(Arel.sql("id"))).to eq([work_package_1, work_package_3, work_package_4,
work_package_5])
- expect(sprint_1.work_packages.order(Arel.sql('id')).each(&:reload).map(&:position)).to eq([1, 2, 3, 4])
+ expect(sprint_1.work_packages.order(Arel.sql("id")).each(&:reload).map(&:position)).to eq([1, 2, 3, 4])
end
end
- describe '- Adding a work_package to a sprint' do
- it 'adds it to the bottom of the list' do
+ describe "- Adding a work_package to a sprint" do
+ it "adds it to the bottom of the list" do
work_package_a.version = sprint_1
work_package_a.save!
expect(work_package_a).to be_last
end
- it 'does not reorder the existing work_packages' do
+ it "does not reorder the existing work_packages" do
work_package_a.version = sprint_1
work_package_a.save!
@@ -154,8 +154,8 @@ def create_work_package(options)
end
end
- describe '- Deleting a work_package in a sprint' do
- it 'reorders the existing work_packages' do
+ describe "- Deleting a work_package in a sprint" do
+ it "reorders the existing work_packages" do
work_package_3.destroy
expect([work_package_1, work_package_2, work_package_4,
@@ -163,9 +163,9 @@ def create_work_package(options)
end
end
- describe '- Changing the type' do
- describe 'by moving a story to another story type' do
- it 'keeps all positions in the sprint in tact' do
+ describe "- Changing the type" do
+ describe "by moving a story to another story type" do
+ it "keeps all positions in the sprint in tact" do
work_package_3.type = epic_type
work_package_3.save!
@@ -174,15 +174,15 @@ def create_work_package(options)
end
end
- describe 'by moving a story to a non-backlogs type' do
- it 'removes it from any list' do
+ describe "by moving a story to a non-backlogs type" do
+ it "removes it from any list" do
work_package_3.type = other_type
work_package_3.save!
expect(work_package_3).not_to be_in_list
end
- it 'reorders the remaining stories' do
+ it "reorders the remaining stories" do
work_package_3.type = other_type
work_package_3.save!
@@ -191,15 +191,15 @@ def create_work_package(options)
end
end
- describe 'by moving a story to the task type' do
- it 'removes it from any list' do
+ describe "by moving a story to the task type" do
+ it "removes it from any list" do
work_package_3.type = task_type
work_package_3.save!
expect(work_package_3).not_to be_in_list
end
- it 'reorders the remaining stories' do
+ it "reorders the remaining stories" do
work_package_3.type = task_type
work_package_3.save!
@@ -208,15 +208,15 @@ def create_work_package(options)
end
end
- describe 'by moving a task to the story type' do
- it 'adds it to the bottom of the list' do
+ describe "by moving a task to the story type" do
+ it "adds it to the bottom of the list" do
task_1.type = story_type
task_1.save!
expect(task_1).to be_last
end
- it 'does not reorder the existing stories' do
+ it "does not reorder the existing stories" do
task_1.type = story_type
task_1.save!
@@ -225,15 +225,15 @@ def create_work_package(options)
end
end
- describe 'by moving a non-backlogs work_package to a story type' do
- it 'adds it to the bottom of the list' do
+ describe "by moving a non-backlogs work_package to a story type" do
+ it "adds it to the bottom of the list" do
feedback_1.type = story_type
feedback_1.save!
expect(feedback_1).to be_last
end
- it 'does not reorder the existing stories' do
+ it "does not reorder the existing stories" do
feedback_1.type = story_type
feedback_1.save!
@@ -243,7 +243,7 @@ def create_work_package(options)
end
end
- describe '- Moving work_packages between projects' do
+ describe "- Moving work_packages between projects" do
# N.B.: You cannot move a ticket to another project and change the
# 'version' at the same time. On the other hand, OpenProject tries
# to keep the 'version' if possible (e.g. within project
@@ -255,14 +255,14 @@ def create_work_package(options)
let(:shared_sprint) do
create(:version,
project_id: project.id,
- name: 'Shared Sprint',
- sharing: 'descendants')
+ name: "Shared Sprint",
+ sharing: "descendants")
end
let(:version_go_live) do
create(:version,
project_id: project_wo_backlogs.id,
- name: 'Go-Live')
+ name: "Go-Live")
end
shared_let(:admin) { create(:admin) }
@@ -274,8 +274,8 @@ def move_to_project(work_package, project)
end
before do
- project_wo_backlogs.enabled_module_names = project_wo_backlogs.enabled_module_names - ['backlogs']
- sub_project_wo_backlogs.enabled_module_names = sub_project_wo_backlogs.enabled_module_names - ['backlogs']
+ project_wo_backlogs.enabled_module_names = project_wo_backlogs.enabled_module_names - ["backlogs"]
+ sub_project_wo_backlogs.enabled_module_names = sub_project_wo_backlogs.enabled_module_names - ["backlogs"]
project_wo_backlogs.types = [story_type, task_type, other_type]
sub_project_wo_backlogs.types = [story_type, task_type, other_type]
@@ -286,10 +286,10 @@ def move_to_project(work_package, project)
version_go_live
end
- describe '- Moving an work_package from a project without backlogs to a backlogs_enabled project' do
- describe 'if the version may not be kept' do
+ describe "- Moving an work_package from a project without backlogs to a backlogs_enabled project" do
+ describe "if the version may not be kept" do
let(:work_package_i) do
- create_work_package(subject: 'WorkPackage I',
+ create_work_package(subject: "WorkPackage I",
version_id: version_go_live.id,
project_id: project_wo_backlogs.id)
end
@@ -298,7 +298,7 @@ def move_to_project(work_package, project)
work_package_i
end
- it 'sets the version_id to nil' do
+ it "sets the version_id to nil" do
result = move_to_project(work_package_i, project)
expect(result).to be_truthy
@@ -306,7 +306,7 @@ def move_to_project(work_package, project)
expect(work_package_i.version).to be_nil
end
- it 'removes it from any list' do
+ it "removes it from any list" do
result = move_to_project(work_package_i, project)
expect(result).to be_truthy
@@ -315,9 +315,9 @@ def move_to_project(work_package, project)
end
end
- describe 'if the version may be kept' do
+ describe "if the version may be kept" do
let(:work_package_i) do
- create_work_package(subject: 'WorkPackage I',
+ create_work_package(subject: "WorkPackage I",
version_id: shared_sprint.id,
project_id: sub_project_wo_backlogs.id)
end
@@ -326,7 +326,7 @@ def move_to_project(work_package, project)
work_package_i
end
- it 'keeps the version_id' do
+ it "keeps the version_id" do
result = move_to_project(work_package_i, project)
expect(result).to be_truthy
@@ -334,7 +334,7 @@ def move_to_project(work_package, project)
expect(work_package_i.version).to eq(shared_sprint)
end
- it 'adds it to the bottom of the list' do
+ it "adds it to the bottom of the list" do
result = move_to_project(work_package_i, project)
expect(result).to be_truthy
@@ -344,9 +344,9 @@ def move_to_project(work_package, project)
end
end
- describe '- Moving an work_package away from backlogs_enabled project to a project without backlogs' do
- describe 'if the version may not be kept' do
- it 'sets the version_id to nil' do
+ describe "- Moving an work_package away from backlogs_enabled project to a project without backlogs" do
+ describe "if the version may not be kept" do
+ it "sets the version_id to nil" do
result = move_to_project(work_package_3, project_wo_backlogs)
expect(result).to be_truthy
@@ -354,7 +354,7 @@ def move_to_project(work_package, project)
expect(work_package_3.version).to be_nil
end
- it 'removes it from any list' do
+ it "removes it from any list" do
result = move_to_project(work_package_3, sub_project_wo_backlogs)
expect(result).to be_truthy
@@ -362,7 +362,7 @@ def move_to_project(work_package, project)
expect(work_package_3).not_to be_in_list
end
- it 'reorders the remaining work_packages' do
+ it "reorders the remaining work_packages" do
result = move_to_project(work_package_3, sub_project_wo_backlogs)
expect(result).to be_truthy
@@ -372,17 +372,17 @@ def move_to_project(work_package, project)
end
end
- describe 'if the version may be kept' do
+ describe "if the version may be kept" do
let(:work_package_i) do
- create_work_package(subject: 'WorkPackage I',
+ create_work_package(subject: "WorkPackage I",
version_id: shared_sprint.id)
end
let(:work_package_ii) do
- create_work_package(subject: 'WorkPackage II',
+ create_work_package(subject: "WorkPackage II",
version_id: shared_sprint.id)
end
let(:work_package_iii) do
- create_work_package(subject: 'WorkPackage III',
+ create_work_package(subject: "WorkPackage III",
version_id: shared_sprint.id)
end
@@ -394,7 +394,7 @@ def move_to_project(work_package, project)
expect([work_package_i, work_package_ii, work_package_iii].map(&:position)).to eq([1, 2, 3])
end
- it 'keeps the version_id' do
+ it "keeps the version_id" do
result = move_to_project(work_package_ii, sub_project_wo_backlogs)
expect(result).to be_truthy
@@ -402,7 +402,7 @@ def move_to_project(work_package, project)
expect(work_package_ii.version).to eq(shared_sprint)
end
- it 'removes it from any list' do
+ it "removes it from any list" do
result = move_to_project(work_package_ii, sub_project_wo_backlogs)
expect(result).to be_truthy
@@ -410,7 +410,7 @@ def move_to_project(work_package, project)
expect(work_package_ii).not_to be_in_list
end
- it 'reorders the remaining work_packages' do
+ it "reorders the remaining work_packages" do
result = move_to_project(work_package_ii, sub_project_wo_backlogs)
expect(result).to be_truthy
diff --git a/modules/backlogs/spec/models/issue_spec.rb b/modules/backlogs/spec/models/issue_spec.rb
index db0e315e3f75..b74cc1c25031 100644
--- a/modules/backlogs/spec/models/issue_spec.rb
+++ b/modules/backlogs/spec/models/issue_spec.rb
@@ -26,66 +26,66 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WorkPackage do
- describe 'validations' do
+ describe "validations" do
let(:work_package) do
build(:work_package)
end
- describe 'story points' do
+ describe "story points" do
before do
- work_package.project.enabled_module_names += ['backlogs']
+ work_package.project.enabled_module_names += ["backlogs"]
end
- it 'allows empty values' do
+ it "allows empty values" do
expect(work_package.story_points).to be_nil
expect(work_package).to be_valid
end
- it 'allows values greater than or equal to 0' do
- work_package.story_points = '0'
+ it "allows values greater than or equal to 0" do
+ work_package.story_points = "0"
expect(work_package).to be_valid
- work_package.story_points = '1'
+ work_package.story_points = "1"
expect(work_package).to be_valid
end
- it 'allows values less than 10.000' do
- work_package.story_points = '9999'
+ it "allows values less than 10.000" do
+ work_package.story_points = "9999"
expect(work_package).to be_valid
end
- it 'disallows negative values' do
- work_package.story_points = '-1'
+ it "disallows negative values" do
+ work_package.story_points = "-1"
expect(work_package).not_to be_valid
end
- it 'disallows greater or equal than 10.000' do
- work_package.story_points = '10000'
+ it "disallows greater or equal than 10.000" do
+ work_package.story_points = "10000"
expect(work_package).not_to be_valid
- work_package.story_points = '10001'
+ work_package.story_points = "10001"
expect(work_package).not_to be_valid
end
- it 'disallows string values, that are not numbers' do
- work_package.story_points = 'abc'
+ it "disallows string values, that are not numbers" do
+ work_package.story_points = "abc"
expect(work_package).not_to be_valid
end
- it 'disallows non-integers' do
- work_package.story_points = '1.3'
+ it "disallows non-integers" do
+ work_package.story_points = "1.3"
expect(work_package).not_to be_valid
end
end
end
- describe 'definition of done' do
+ describe "definition of done" do
before do
- @status_resolved = build(:status, name: 'Resolved', is_default: false)
- @status_open = build(:status, name: 'Open', is_default: true)
+ @status_resolved = build(:status, name: "Resolved", is_default: false)
+ @status_open = build(:status, name: "Open", is_default: true)
@project = build(:project)
@project.done_statuses = [@status_resolved]
@project.types = [build(:type_feature)]
@@ -111,23 +111,23 @@
end
end
- describe 'backlogs_enabled?' do
+ describe "backlogs_enabled?" do
let(:project) { build(:project) }
let(:work_package) { build(:work_package) }
- it 'is false without a project' do
+ it "is false without a project" do
work_package.project = nil
expect(work_package).not_to be_backlogs_enabled
end
- it 'is true with a project having the backlogs module' do
- project.enabled_module_names = project.enabled_module_names + ['backlogs']
+ it "is true with a project having the backlogs module" do
+ project.enabled_module_names = project.enabled_module_names + ["backlogs"]
work_package.project = project
expect(work_package).to be_backlogs_enabled
end
- it 'is false with a project not having the backlogs module' do
+ it "is false with a project not having the backlogs module" do
work_package.project = project
work_package.project.enabled_module_names = nil
diff --git a/modules/backlogs/spec/models/sprint_spec.rb b/modules/backlogs/spec/models/sprint_spec.rb
index 8a2cd8dbcbb6..f431691c3e19 100644
--- a/modules/backlogs/spec/models/sprint_spec.rb
+++ b/modules/backlogs/spec/models/sprint_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Sprint do
let(:sprint) { build(:sprint) }
let(:project) { build(:project) }
- describe 'Class Methods' do
- describe '#displayed_left' do
- describe 'WITH display set to left' do
+ describe "Class Methods" do
+ describe "#displayed_left" do
+ describe "WITH display set to left" do
before do
sprint.version_settings = [build(:version_setting, project:,
display: VersionSetting::DISPLAY_LEFT)]
@@ -47,10 +47,10 @@
}
end
- describe 'WITH a version setting defined for another project' do
+ describe "WITH a version setting defined for another project" do
before do
- another_project = build(:project, name: 'another project',
- identifier: 'another project')
+ another_project = build(:project, name: "another project",
+ identifier: "another project")
sprint.version_settings = [build(:version_setting, project: another_project,
display: VersionSetting::DISPLAY_RIGHT)]
@@ -61,7 +61,7 @@
it { expect(Sprint.displayed_left(project)).to contain_exactly(sprint) }
end
- describe 'WITH no version setting defined' do
+ describe "WITH no version setting defined" do
before do
sprint.project = project
sprint.save!
@@ -70,7 +70,7 @@
it { expect(Sprint.displayed_left(project)).to contain_exactly(sprint) }
end
- context 'WITH a shared version from another project' do
+ context "WITH a shared version from another project" do
let!(:parent_project) { create(:project, identifier: "parent", name: "Parent") }
let!(:home_project) do
@@ -91,13 +91,13 @@
let(:displayed) { Sprint.apply_to(sister_project).displayed_left(sister_project) }
- describe 'WITH no version settings' do
+ describe "WITH no version settings" do
it "includes the shared version by default" do
expect(displayed).to contain_exactly(version)
end
end
- describe 'WITH display = left in home project' do
+ describe "WITH display = left in home project" do
before do
VersionSetting.create version:, project: home_project, display: VersionSetting::DISPLAY_LEFT
end
@@ -107,7 +107,7 @@
end
end
- describe 'WITH display = none in home project' do
+ describe "WITH display = none in home project" do
before do
VersionSetting.create version:, project: home_project, display: VersionSetting::DISPLAY_NONE
end
@@ -117,7 +117,7 @@
end
end
- describe 'WITH display = left in sister project' do
+ describe "WITH display = left in sister project" do
before do
VersionSetting.create version:, project: sister_project, display: VersionSetting::DISPLAY_LEFT
end
@@ -127,7 +127,7 @@
end
end
- describe 'WITH display = none in sister project' do
+ describe "WITH display = none in sister project" do
before do
VersionSetting.create version:, project: sister_project, display: VersionSetting::DISPLAY_NONE
end
@@ -137,7 +137,7 @@
end
end
- describe 'WITH display = left in home project and display = left in sister project' do
+ describe "WITH display = left in home project and display = left in sister project" do
before do
VersionSetting.create version:, project: home_project, display: VersionSetting::DISPLAY_LEFT
VersionSetting.create version:, project: sister_project, display: VersionSetting::DISPLAY_LEFT
@@ -148,7 +148,7 @@
end
end
- describe 'WITH display = left in home project and display = none in sister project' do
+ describe "WITH display = left in home project and display = none in sister project" do
before do
VersionSetting.create version:, project: home_project, display: VersionSetting::DISPLAY_LEFT
VersionSetting.create version:, project: sister_project, display: VersionSetting::DISPLAY_NONE
@@ -159,7 +159,7 @@
end
end
- describe 'WITH display = none in home project and display = left in sister project' do
+ describe "WITH display = none in home project and display = left in sister project" do
before do
VersionSetting.create version:, project: home_project, display: VersionSetting::DISPLAY_NONE
VersionSetting.create version:, project: sister_project, display: VersionSetting::DISPLAY_LEFT
@@ -170,7 +170,7 @@
end
end
- describe 'WITH display = none in home project and display = none in sister project' do
+ describe "WITH display = none in home project and display = none in sister project" do
before do
VersionSetting.create version:, project: home_project, display: VersionSetting::DISPLAY_NONE
VersionSetting.create version:, project: sister_project, display: VersionSetting::DISPLAY_NONE
@@ -183,7 +183,7 @@
end
end
- describe '#displayed_right' do
+ describe "#displayed_right" do
before do
sprint.version_settings = [build(:version_setting, project:, display: VersionSetting::DISPLAY_RIGHT)]
sprint.project = project
@@ -193,66 +193,66 @@
it { expect(Sprint.displayed_right(project)).to contain_exactly(sprint) }
end
- describe '#order_by_date' do
+ describe "#order_by_date" do
before do
- @sprint1 = create(:sprint, name: 'sprint1', project:, start_date: Date.today + 2.days)
- @sprint2 = create(:sprint, name: 'sprint2', project:, start_date: Date.today + 1.day,
+ @sprint1 = create(:sprint, name: "sprint1", project:, start_date: Date.today + 2.days)
+ @sprint2 = create(:sprint, name: "sprint2", project:, start_date: Date.today + 1.day,
effective_date: Date.today + 3.days)
- @sprint3 = create(:sprint, name: 'sprint3', project:, start_date: Date.today + 1.day,
+ @sprint3 = create(:sprint, name: "sprint3", project:, start_date: Date.today + 1.day,
effective_date: Date.today + 2.days)
end
- it 'sorts the dates correctly', :aggregate_failures do
+ it "sorts the dates correctly", :aggregate_failures do
expect(Sprint.order_by_date[0]).to eql @sprint3
expect(Sprint.order_by_date[1]).to eql @sprint2
expect(Sprint.order_by_date[2]).to eql @sprint1
end
end
- describe '#apply_to' do
+ describe "#apply_to" do
before do
project.save
@other_project = create(:project)
end
- describe 'WITH the version being shared system wide' do
+ describe "WITH the version being shared system wide" do
before do
- @version = create(:sprint, name: 'systemwide', project: @other_project, sharing: 'system')
+ @version = create(:sprint, name: "systemwide", project: @other_project, sharing: "system")
end
it { expect(Sprint.apply_to(project).size).to eq(1) }
it { expect(Sprint.apply_to(project)[0]).to eql(@version) }
end
- describe 'WITH the version being shared from a parent project' do
+ describe "WITH the version being shared from a parent project" do
before do
project.update(parent: @other_project)
project.reload
- @version = create(:sprint, name: 'descended', project: @other_project, sharing: 'descendants')
+ @version = create(:sprint, name: "descended", project: @other_project, sharing: "descendants")
end
it { expect(Sprint.apply_to(project).size).to eq(1) }
it { expect(Sprint.apply_to(project)[0]).to eql(@version) }
end
- describe 'WITH the version being shared within the tree' do
+ describe "WITH the version being shared within the tree" do
before do
@parent_project = create(:project)
@other_project.update(parent: @parent_project)
project.update(parent: @parent_project)
project.reload
- @version = create(:sprint, name: 'treed', project: @other_project, sharing: 'tree')
+ @version = create(:sprint, name: "treed", project: @other_project, sharing: "tree")
end
it { expect(Sprint.apply_to(project).size).to eq(1) }
it { expect(Sprint.apply_to(project)[0]).to eql(@version) }
end
- describe 'WITH the version being shared within the tree' do
+ describe "WITH the version being shared within the tree" do
before do
@descendant_project = create(:project, parent: project)
project.reload
- @version = create(:sprint, name: 'hierar', project: @descendant_project, sharing: 'hierarchy')
+ @version = create(:sprint, name: "hierar", project: @descendant_project, sharing: "hierarchy")
end
it { expect(Sprint.apply_to(project).size).to eq(1) }
@@ -261,7 +261,7 @@
end
end
- describe '#wiki_page' do
+ describe "#wiki_page" do
let(:wiki) { create :wiki, project: }
let(:wiki_page) { WikiPage.where(wiki:, title: sprint.wiki_page).first }
let(:user) { create :user }
@@ -277,7 +277,7 @@
sprint.wiki_page
end
- it 'creates a new wiki page if none is present' do
+ it "creates a new wiki page if none is present" do
expect { subject }.not_to raise_error
expect(wiki_page.text).to start_with("h1. #{sprint.name}")
diff --git a/modules/backlogs/spec/models/story_spec.rb b/modules/backlogs/spec/models/story_spec.rb
index 9dfdcf892028..7afd89074d8c 100644
--- a/modules/backlogs/spec/models/story_spec.rb
+++ b/modules/backlogs/spec/models/story_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Story do
let(:user) { @user ||= create(:user) }
let(:role) { @role ||= create(:project_role) }
- let(:status1) { @status1 ||= create(:status, name: 'status 1', is_default: true) }
+ let(:status1) { @status1 ||= create(:status, name: "status 1", is_default: true) }
let(:type_feature) { @type_feature ||= create(:type_feature) }
let(:version) { @version ||= create(:version, project:) }
let(:version2) { create(:version, project:) }
@@ -74,15 +74,15 @@
before do
ActionController::Base.perform_caching = false
- allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ 'points_burn_direction' => 'down',
- 'wiki_template' => '',
- 'story_types' => [type_feature.id.to_s],
- 'task_type' => task_type.id.to_s })
+ allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ "points_burn_direction" => "down",
+ "wiki_template" => "",
+ "story_types" => [type_feature.id.to_s],
+ "task_type" => task_type.id.to_s })
project.types << task_type
end
- describe 'Class methods' do
- describe '#backlogs' do
+ describe "Class methods" do
+ describe "#backlogs" do
describe "WITH one sprint
WITH the sprint having 1 story" do
before do
@@ -148,7 +148,7 @@
describe "WITH one sprint
WITH the sprint having one story in this project and one story in another project" do
before do
- version.sharing = 'system'
+ version.sharing = "system"
version.save!
another_project = create(:project)
diff --git a/modules/backlogs/spec/models/task_spec.rb b/modules/backlogs/spec/models/task_spec.rb
index 0d64afcf9003..ea23dac4ce76 100644
--- a/modules/backlogs/spec/models/task_spec.rb
+++ b/modules/backlogs/spec/models/task_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Task do
let(:task_type) { create(:type) }
@@ -42,10 +42,10 @@
before do
allow(Setting)
.to receive(:plugin_openproject_backlogs)
- .and_return({ 'task_type' => task_type.id.to_s })
+ .and_return({ "task_type" => task_type.id.to_s })
end
- describe 'having custom journables', with_settings: { journal_aggregation_time_minutes: 0 } do
+ describe "having custom journables", with_settings: { journal_aggregation_time_minutes: 0 } do
let(:user) { create(:user) }
let(:role) do
create(:project_role, permissions: %i[add_work_packages manage_subtasks manage_work_packages view_work_packages])
@@ -56,16 +56,16 @@
project.members << member
end
- describe 'with unchanged custom field' do
- let(:custom_field) { create(:work_package_custom_field, name: 'TestingCustomField', field_format: 'text') }
+ describe "with unchanged custom field" do
+ let(:custom_field) { create(:work_package_custom_field, name: "TestingCustomField", field_format: "text") }
before do
project.work_package_custom_fields << custom_field
task_type.custom_fields << custom_field
end
- it 'must have the same journal when resaved' do
- task.custom_field_values = { custom_field.id => 'Example CF text' }
+ it "must have the same journal when resaved" do
+ task.custom_field_values = { custom_field.id => "Example CF text" }
task.save!
expect(task.journals.last.customizable_journals.count).to eq 1
@@ -81,10 +81,10 @@
end
end
- describe 'with attachment' do
+ describe "with attachment" do
let(:attachment) { build(:attachment) }
- it 'must have the same journal when resaved' do
+ it "must have the same journal when resaved" do
task.attachments << attachment
task.save!
diff --git a/modules/backlogs/spec/models/user_spec.rb b/modules/backlogs/spec/models/user_spec.rb
index ef77d12a029b..33a61133072f 100644
--- a/modules/backlogs/spec/models/user_spec.rb
+++ b/modules/backlogs/spec/models/user_spec.rb
@@ -26,21 +26,21 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe User do
- describe 'backlogs_preference' do
- describe 'task_color' do
- it 'reads from and writes to a user preference' do
+ describe "backlogs_preference" do
+ describe "task_color" do
+ it "reads from and writes to a user preference" do
u = create(:user)
- u.backlogs_preference(:task_color, '#FFCC33')
+ u.backlogs_preference(:task_color, "#FFCC33")
- expect(u.backlogs_preference(:task_color)).to eq('#FFCC33')
+ expect(u.backlogs_preference(:task_color)).to eq("#FFCC33")
u.reload
- expect(u.backlogs_preference(:task_color)).to eq('#FFCC33')
+ expect(u.backlogs_preference(:task_color)).to eq("#FFCC33")
end
- it 'computes a random color and persists it, when none is set' do
+ it "computes a random color and persists it, when none is set" do
u = create(:user)
u.backlogs_preference(:task_color, nil)
u.save!
diff --git a/modules/backlogs/spec/models/version_setting_spec.rb b/modules/backlogs/spec/models/version_setting_spec.rb
index c507b7a717ea..914c37a9fe48 100644
--- a/modules/backlogs/spec/models/version_setting_spec.rb
+++ b/modules/backlogs/spec/models/version_setting_spec.rb
@@ -26,17 +26,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe VersionSetting do
let(:version_setting) { build(:version_setting) }
it { is_expected.to belong_to(:project) }
it { is_expected.to belong_to(:version) }
- it { expect(VersionSetting.column_names).to include('display') }
+ it { expect(VersionSetting.column_names).to include("display") }
- describe 'Instance Methods' do
- describe 'WITH display set to left' do
+ describe "Instance Methods" do
+ describe "WITH display set to left" do
before do
version_setting.display_left!
end
@@ -44,7 +44,7 @@
it { expect(version_setting.display_left?).to be_truthy }
end
- describe 'WITH display set to right' do
+ describe "WITH display set to right" do
before do
version_setting.display_right!
end
@@ -52,7 +52,7 @@
it { expect(version_setting.display_right?).to be_truthy }
end
- describe 'WITH display set to none' do
+ describe "WITH display set to none" do
before do
version_setting.display_none!
end
diff --git a/modules/backlogs/spec/models/version_spec.rb b/modules/backlogs/spec/models/version_spec.rb
index 2902b8779e5b..6b8d2672220d 100644
--- a/modules/backlogs/spec/models/version_spec.rb
+++ b/modules/backlogs/spec/models/version_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Version do
it { is_expected.to have_many :version_settings }
- describe 'rebuild positions' do
+ describe "rebuild positions" do
def build_work_package(options = {})
build(:work_package, options.reverse_merge(version_id: version.id,
priority_id: priority.id,
@@ -45,14 +45,14 @@ def create_work_package(options = {})
let(:status) { create(:status) }
let(:priority) { create(:priority_normal) }
- let(:project) { create(:project, name: 'Project 1', types: [epic_type, story_type, task_type, other_type]) }
+ let(:project) { create(:project, name: "Project 1", types: [epic_type, story_type, task_type, other_type]) }
- let(:epic_type) { create(:type, name: 'Epic') }
- let(:story_type) { create(:type, name: 'Story') }
- let(:task_type) { create(:type, name: 'Task') }
- let(:other_type) { create(:type, name: 'Other') }
+ let(:epic_type) { create(:type, name: "Epic") }
+ let(:story_type) { create(:type, name: "Story") }
+ let(:task_type) { create(:type, name: "Task") }
+ let(:other_type) { create(:type, name: "Other") }
- let(:version) { create(:version, project_id: project.id, name: 'Version') }
+ let(:version) { create(:version, project_id: project.id, name: "Version") }
shared_let(:admin) { create(:admin) }
@@ -75,9 +75,9 @@ def move_to_project(work_package, project)
Version.delete_all
# Enable and configure backlogs
- project.enabled_module_names = project.enabled_module_names + ['backlogs']
- allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ 'story_types' => [epic_type.id, story_type.id],
- 'task_type' => task_type.id })
+ project.enabled_module_names = project.enabled_module_names + ["backlogs"]
+ allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ "story_types" => [epic_type.id, story_type.id],
+ "task_type" => task_type.id })
# Otherwise the type id's from the previous test are still active
WorkPackage.instance_variable_set(:@backlogs_types, nil)
@@ -86,9 +86,9 @@ def move_to_project(work_package, project)
version
end
- it 'moves an work_package to a project where backlogs is disabled while using versions' do
- project2 = create(:project, name: 'Project 2', types: [epic_type, story_type, task_type, other_type])
- project2.enabled_module_names = project2.enabled_module_names - ['backlogs']
+ it "moves an work_package to a project where backlogs is disabled while using versions" do
+ project2 = create(:project, name: "Project 2", types: [epic_type, story_type, task_type, other_type])
+ project2.enabled_module_names = project2.enabled_module_names - ["backlogs"]
project2.save!
project2.reload
@@ -127,7 +127,7 @@ def move_to_project(work_package, project)
expect(work_package1.version_id).to eq(version.id)
end
- it 'rebuilds positions' do
+ it "rebuilds positions" do
e1 = create_work_package(type_id: epic_type.id)
s2 = create_work_package(type_id: story_type.id)
s3 = create_work_package(type_id: story_type.id)
@@ -150,7 +150,7 @@ def move_to_project(work_package, project)
work_packages = version
.work_packages
.where(project_id: project)
- .order(Arel.sql('COALESCE(position, 0) ASC, id ASC'))
+ .order(Arel.sql("COALESCE(position, 0) ASC, id ASC"))
expect(work_packages.map(&:position)).to eq([nil, nil, 1, 2, 3, 4, 5])
expect(work_packages.map(&:subject)).to eq([t3, o9, e1, s2, s5, s3, s4].map(&:subject))
diff --git a/modules/backlogs/spec/models/work_package_spec.rb b/modules/backlogs/spec/models/work_package_spec.rb
index 948bf9b8e25a..48f0a2922103 100644
--- a/modules/backlogs/spec/models/work_package_spec.rb
+++ b/modules/backlogs/spec/models/work_package_spec.rb
@@ -26,64 +26,64 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WorkPackage do
- describe '#backlogs_types' do
- it 'returns all the ids of types that are configures to be considered backlogs types' do
- allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ 'story_types' => [1], 'task_type' => 2 })
+ describe "#backlogs_types" do
+ it "returns all the ids of types that are configures to be considered backlogs types" do
+ allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ "story_types" => [1], "task_type" => 2 })
expect(described_class.backlogs_types).to contain_exactly(1, 2)
end
- it 'returns an empty array if nothing is defined' do
+ it "returns an empty array if nothing is defined" do
allow(Setting).to receive(:plugin_openproject_backlogs).and_return({})
expect(described_class.backlogs_types).to eq([])
end
- it 'reflects changes to the configuration' do
- allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ 'story_types' => [1], 'task_type' => 2 })
+ it "reflects changes to the configuration" do
+ allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ "story_types" => [1], "task_type" => 2 })
expect(described_class.backlogs_types).to contain_exactly(1, 2)
- allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ 'story_types' => [3], 'task_type' => 4 })
+ allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ "story_types" => [3], "task_type" => 4 })
expect(described_class.backlogs_types).to contain_exactly(3, 4)
end
end
- describe '#story' do
+ describe "#story" do
shared_let(:project) { create(:project) }
shared_let(:status) { create(:status) }
- shared_let(:story_type) { create(:type, name: 'Story') }
- shared_let(:task_type) { create(:type, name: 'Task') }
+ shared_let(:story_type) { create(:type, name: "Story") }
+ shared_let(:task_type) { create(:type, name: "Task") }
before do
- allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ 'story_types' => [story_type.id],
- 'task_type' => task_type.id })
+ allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ "story_types" => [story_type.id],
+ "task_type" => task_type.id })
end
- context 'for a WorkPackage' do
+ context "for a WorkPackage" do
let(:work_package) { build_stubbed(:work_package) }
- it 'returns nil' do
+ it "returns nil" do
expect(work_package.story).to be_nil
end
end
- context 'for a Story' do
+ context "for a Story" do
let(:story) { create(:story, project:, status:, type: story_type) }
- it 'returns self' do
+ it "returns self" do
expect(story.story).to eq(story)
end
end
- context 'for a Task' do
+ context "for a Task" do
let(:parent_parent_story) { create(:story, project:, status:, type: story_type) }
let(:parent_story) { create(:story, parent: parent_parent_story, project:, status:, type: story_type) }
let(:task) { create(:task, parent: parent_story, project:, status:, type: task_type) }
- it 'returns the closest WorkPackage ancestor being a Story' do
+ it "returns the closest WorkPackage ancestor being a Story" do
expect(task.story).to eq(described_class.find(parent_story.id))
# transform the parent_story into a task
diff --git a/modules/backlogs/spec/routing/rb_burndown_charts_routing_spec.rb b/modules/backlogs/spec/routing/rb_burndown_charts_routing_spec.rb
index 684bb8c8f29d..5f6bc086009d 100644
--- a/modules/backlogs/spec/routing/rb_burndown_charts_routing_spec.rb
+++ b/modules/backlogs/spec/routing/rb_burndown_charts_routing_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe RbBurndownChartsController do
- describe 'routing' do
+ describe "routing" do
it {
- expect(get('/projects/project_42/sprints/21/burndown_chart')).to route_to(controller: 'rb_burndown_charts',
- action: 'show',
- project_id: 'project_42',
- sprint_id: '21')
+ expect(get("/projects/project_42/sprints/21/burndown_chart")).to route_to(controller: "rb_burndown_charts",
+ action: "show",
+ project_id: "project_42",
+ sprint_id: "21")
}
end
end
diff --git a/modules/backlogs/spec/routing/rb_impediments_routing_spec.rb b/modules/backlogs/spec/routing/rb_impediments_routing_spec.rb
index 34d22f569a9a..8df132edc93d 100644
--- a/modules/backlogs/spec/routing/rb_impediments_routing_spec.rb
+++ b/modules/backlogs/spec/routing/rb_impediments_routing_spec.rb
@@ -26,23 +26,23 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe RbImpedimentsController do
- describe 'routing' do
+ describe "routing" do
it {
- expect(post('/projects/project_42/sprints/21/impediments')).to route_to(controller: 'rb_impediments',
- action: 'create',
- project_id: 'project_42',
- sprint_id: '21')
+ expect(post("/projects/project_42/sprints/21/impediments")).to route_to(controller: "rb_impediments",
+ action: "create",
+ project_id: "project_42",
+ sprint_id: "21")
}
it {
- expect(put('/projects/project_42/sprints/21/impediments/85')).to route_to(controller: 'rb_impediments',
- action: 'update',
- project_id: 'project_42',
- sprint_id: '21',
- id: '85')
+ expect(put("/projects/project_42/sprints/21/impediments/85")).to route_to(controller: "rb_impediments",
+ action: "update",
+ project_id: "project_42",
+ sprint_id: "21",
+ id: "85")
}
end
end
diff --git a/modules/backlogs/spec/routing/rb_master_backlogs_routing_spec.rb b/modules/backlogs/spec/routing/rb_master_backlogs_routing_spec.rb
index 4a33b7bd8b0f..5e7dbfb5a801 100644
--- a/modules/backlogs/spec/routing/rb_master_backlogs_routing_spec.rb
+++ b/modules/backlogs/spec/routing/rb_master_backlogs_routing_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe RbMasterBacklogsController do
- describe 'routing' do
+ describe "routing" do
it {
- expect(get('/projects/project_42/backlogs')).to route_to(controller: 'rb_master_backlogs',
- action: 'index',
- project_id: 'project_42')
+ expect(get("/projects/project_42/backlogs")).to route_to(controller: "rb_master_backlogs",
+ action: "index",
+ project_id: "project_42")
}
end
end
diff --git a/modules/backlogs/spec/routing/rb_queries_routing_spec.rb b/modules/backlogs/spec/routing/rb_queries_routing_spec.rb
index 366051e6fe39..6d6b20cfe98d 100644
--- a/modules/backlogs/spec/routing/rb_queries_routing_spec.rb
+++ b/modules/backlogs/spec/routing/rb_queries_routing_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe RbQueriesController do
- describe 'routing' do
+ describe "routing" do
it {
- expect(get('/projects/project_42/sprints/21/query')).to route_to(controller: 'rb_queries',
- action: 'show',
- project_id: 'project_42',
- sprint_id: '21')
+ expect(get("/projects/project_42/sprints/21/query")).to route_to(controller: "rb_queries",
+ action: "show",
+ project_id: "project_42",
+ sprint_id: "21")
}
end
end
diff --git a/modules/backlogs/spec/routing/rb_sprints_routing_spec.rb b/modules/backlogs/spec/routing/rb_sprints_routing_spec.rb
index 8cab06b4c360..4a30bfa9ddc1 100644
--- a/modules/backlogs/spec/routing/rb_sprints_routing_spec.rb
+++ b/modules/backlogs/spec/routing/rb_sprints_routing_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe RbSprintsController do
- describe 'routing' do
+ describe "routing" do
it {
- expect(put('/projects/project_42/sprints/21')).to route_to(controller: 'rb_sprints',
- action: 'update',
- project_id: 'project_42',
- id: '21')
+ expect(put("/projects/project_42/sprints/21")).to route_to(controller: "rb_sprints",
+ action: "update",
+ project_id: "project_42",
+ id: "21")
}
end
end
diff --git a/modules/backlogs/spec/routing/rb_stories_routing_spec.rb b/modules/backlogs/spec/routing/rb_stories_routing_spec.rb
index 8762e0b0e8bf..5a63623375fe 100644
--- a/modules/backlogs/spec/routing/rb_stories_routing_spec.rb
+++ b/modules/backlogs/spec/routing/rb_stories_routing_spec.rb
@@ -26,23 +26,23 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe RbStoriesController do
- describe 'routing' do
+ describe "routing" do
it {
- expect(post('/projects/project_42/sprints/21/stories')).to route_to(controller: 'rb_stories',
- action: 'create',
- project_id: 'project_42',
- sprint_id: '21')
+ expect(post("/projects/project_42/sprints/21/stories")).to route_to(controller: "rb_stories",
+ action: "create",
+ project_id: "project_42",
+ sprint_id: "21")
}
it {
- expect(put('/projects/project_42/sprints/21/stories/85')).to route_to(controller: 'rb_stories',
- action: 'update',
- project_id: 'project_42',
- sprint_id: '21',
- id: '85')
+ expect(put("/projects/project_42/sprints/21/stories/85")).to route_to(controller: "rb_stories",
+ action: "update",
+ project_id: "project_42",
+ sprint_id: "21",
+ id: "85")
}
end
end
diff --git a/modules/backlogs/spec/routing/rb_taskboards_routing_spec.rb b/modules/backlogs/spec/routing/rb_taskboards_routing_spec.rb
index 2921132d50f8..4e523d793ade 100644
--- a/modules/backlogs/spec/routing/rb_taskboards_routing_spec.rb
+++ b/modules/backlogs/spec/routing/rb_taskboards_routing_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe RbTaskboardsController do
- describe 'routing' do
+ describe "routing" do
it {
- expect(get('/projects/project_42/sprints/21/taskboard')).to route_to(controller: 'rb_taskboards',
- action: 'show',
- project_id: 'project_42',
- sprint_id: '21')
+ expect(get("/projects/project_42/sprints/21/taskboard")).to route_to(controller: "rb_taskboards",
+ action: "show",
+ project_id: "project_42",
+ sprint_id: "21")
}
end
end
diff --git a/modules/backlogs/spec/routing/rb_tasks_routing_spec.rb b/modules/backlogs/spec/routing/rb_tasks_routing_spec.rb
index 5101f514800c..11c561235abc 100644
--- a/modules/backlogs/spec/routing/rb_tasks_routing_spec.rb
+++ b/modules/backlogs/spec/routing/rb_tasks_routing_spec.rb
@@ -26,23 +26,23 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe RbTasksController do
- describe 'routing' do
+ describe "routing" do
it {
- expect(post('/projects/project_42/sprints/21/tasks')).to route_to(controller: 'rb_tasks',
- action: 'create',
- project_id: 'project_42',
- sprint_id: '21')
+ expect(post("/projects/project_42/sprints/21/tasks")).to route_to(controller: "rb_tasks",
+ action: "create",
+ project_id: "project_42",
+ sprint_id: "21")
}
it {
- expect(put('/projects/project_42/sprints/21/tasks/85')).to route_to(controller: 'rb_tasks',
- action: 'update',
- project_id: 'project_42',
- sprint_id: '21',
- id: '85')
+ expect(put("/projects/project_42/sprints/21/tasks/85")).to route_to(controller: "rb_tasks",
+ action: "update",
+ project_id: "project_42",
+ sprint_id: "21",
+ id: "85")
}
end
end
diff --git a/modules/backlogs/spec/routing/rb_wikis_routing_spec.rb b/modules/backlogs/spec/routing/rb_wikis_routing_spec.rb
index a31d60c10b78..5c11ea03601b 100644
--- a/modules/backlogs/spec/routing/rb_wikis_routing_spec.rb
+++ b/modules/backlogs/spec/routing/rb_wikis_routing_spec.rb
@@ -26,22 +26,22 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe RbWikisController do
- describe 'routing' do
+ describe "routing" do
it {
- expect(get('/projects/project_42/sprints/21/wiki')).to route_to(controller: 'rb_wikis',
- action: 'show',
- project_id: 'project_42',
- sprint_id: '21')
+ expect(get("/projects/project_42/sprints/21/wiki")).to route_to(controller: "rb_wikis",
+ action: "show",
+ project_id: "project_42",
+ sprint_id: "21")
}
it {
- expect(get('/projects/project_42/sprints/21/wiki/edit')).to route_to(controller: 'rb_wikis',
- action: 'edit',
- project_id: 'project_42',
- sprint_id: '21')
+ expect(get("/projects/project_42/sprints/21/wiki/edit")).to route_to(controller: "rb_wikis",
+ action: "edit",
+ project_id: "project_42",
+ sprint_id: "21")
}
end
end
diff --git a/modules/backlogs/spec/services/impediments/create_services_spec.rb b/modules/backlogs/spec/services/impediments/create_services_spec.rb
index 17d9f0b2786b..e23d47455464 100644
--- a/modules/backlogs/spec/services/impediments/create_services_spec.rb
+++ b/modules/backlogs/spec/services/impediments/create_services_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Impediments::CreateService do
let(:instance) { described_class.new(user:) }
- let(:impediment_subject) { 'Impediment A' }
+ let(:impediment_subject) { "Impediment A" }
let(:user) { create(:user) }
let(:role) { create(:project_role, permissions: %i(add_work_packages assign_versions work_package_assigned)) }
@@ -57,18 +57,18 @@
project
end
- let(:status1) { create(:status, name: 'status 1', is_default: true) }
+ let(:status1) { create(:status, name: "status 1", is_default: true) }
before do
- allow(Setting).to receive(:plugin_openproject_backlogs).and_return('points_burn_direction' => 'down',
- 'wiki_template' => '',
- 'story_types' => [type_feature.id.to_s],
- 'task_type' => type_task.id.to_s)
+ allow(Setting).to receive(:plugin_openproject_backlogs).and_return("points_burn_direction" => "down",
+ "wiki_template" => "",
+ "story_types" => [type_feature.id.to_s],
+ "task_type" => type_task.id.to_s)
login_as user
end
- shared_examples_for 'impediment creation' do
+ shared_examples_for "impediment creation" do
it { expect(subject.subject).to eql impediment_subject }
it { expect(subject.author).to eql User.current }
it { expect(subject.project).to eql project }
@@ -79,21 +79,21 @@
it { expect(subject.assigned_to).to eql user }
end
- shared_examples_for 'impediment creation with 1 blocking relationship' do
- it_behaves_like 'impediment creation'
+ shared_examples_for "impediment creation with 1 blocking relationship" do
+ it_behaves_like "impediment creation"
it { expect(subject.blocks_relations.size).to eq(1) }
it { expect(subject.blocks_relations[0].to).to eql feature }
end
- shared_examples_for 'impediment creation with no blocking relationship' do
- it_behaves_like 'impediment creation'
+ shared_examples_for "impediment creation with no blocking relationship" do
+ it_behaves_like "impediment creation"
it { expect(subject.blocks_relations.size).to eq(0) }
end
- describe 'WITH a blocking relationship to a story' do
- describe 'WITH the story having the same version' do
+ describe "WITH a blocking relationship to a story" do
+ describe "WITH the story having the same version" do
subject do
call = instance.call(attributes: { subject: impediment_subject,
assigned_to_id: user.id,
@@ -110,12 +110,12 @@
feature.save
end
- it_behaves_like 'impediment creation with 1 blocking relationship'
+ it_behaves_like "impediment creation with 1 blocking relationship"
it { expect(subject).not_to be_new_record }
it { expect(subject.blocks_relations[0]).not_to be_new_record }
end
- describe 'WITH the story having another version' do
+ describe "WITH the story having another version" do
subject do
call = instance.call(attributes: { subject: impediment_subject,
assigned_to_id: user.id,
@@ -128,11 +128,11 @@
end
before do
- feature.version = create(:version, project:, name: 'another version')
+ feature.version = create(:version, project:, name: "another version")
feature.save
end
- it_behaves_like 'impediment creation with no blocking relationship'
+ it_behaves_like "impediment creation with no blocking relationship"
it { expect(subject).to be_new_record }
it {
@@ -141,19 +141,19 @@
}
end
- describe 'WITH the story being non existent' do
+ describe "WITH the story being non existent" do
subject do
call = instance.call(attributes: { subject: impediment_subject,
assigned_to_id: user.id,
priority_id: priority.id,
- blocks_ids: '0',
+ blocks_ids: "0",
status_id: status1.id,
version_id: version.id,
project_id: project.id })
call.result
end
- it_behaves_like 'impediment creation with no blocking relationship'
+ it_behaves_like "impediment creation with no blocking relationship"
it { expect(subject).to be_new_record }
it {
@@ -163,11 +163,11 @@
end
end
- describe 'WITHOUT a blocking relationship defined' do
+ describe "WITHOUT a blocking relationship defined" do
subject do
call = instance.call(attributes: { subject: impediment_subject,
assigned_to_id: user.id,
- blocks_ids: '',
+ blocks_ids: "",
priority_id: priority.id,
status_id: status1.id,
version_id: version.id,
@@ -175,7 +175,7 @@
call.result
end
- it_behaves_like 'impediment creation with no blocking relationship'
+ it_behaves_like "impediment creation with no blocking relationship"
it { expect(subject).to be_new_record }
it {
diff --git a/modules/backlogs/spec/services/impediments/update_service_spec.rb b/modules/backlogs/spec/services/impediments/update_service_spec.rb
index 04c34cde9892..4c1e385d4914 100644
--- a/modules/backlogs/spec/services/impediments/update_service_spec.rb
+++ b/modules/backlogs/spec/services/impediments/update_service_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Impediments::UpdateService, type: :model do
let(:instance) { described_class.new(user:, impediment:) }
@@ -62,8 +62,8 @@
project
end
- let(:status1) { create(:status, name: 'status 1', is_default: true) }
- let(:status2) { create(:status, name: 'status 2') }
+ let(:status1) { create(:status, name: "status 1", is_default: true) }
+ let(:status2) { create(:status, name: "status 2") }
let(:type_workflow) do
Workflow.create(type_id: type_task.id,
old_status: status1,
@@ -80,10 +80,10 @@
end
before do
- allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ 'points_burn_direction' => 'down',
- 'wiki_template' => '',
- 'story_types' => [type_feature.id.to_s],
- 'task_type' => type_task.id.to_s })
+ allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ "points_burn_direction" => "down",
+ "wiki_template" => "",
+ "story_types" => [type_feature.id.to_s],
+ "task_type" => type_task.id.to_s })
login_as user
@@ -98,7 +98,7 @@
impediment.save
end
- shared_examples_for 'impediment update' do
+ shared_examples_for "impediment update" do
it { expect(subject.author).to eql user }
it { expect(subject.project).to eql project }
it { expect(subject.version).to eql version }
@@ -108,16 +108,16 @@
it { expect(subject.blocks_ids).to eql blocks.split(/\D+/).map(&:to_i) }
end
- shared_examples_for 'impediment update with changed blocking relationship' do
- it_behaves_like 'impediment update'
+ shared_examples_for "impediment update with changed blocking relationship" do
+ it_behaves_like "impediment update"
it { expect(subject.relations.size).to eq(1) }
it { expect(subject.relations[0]).not_to be_new_record }
it { expect(subject.relations[0].to).to eql story }
it { expect(subject.relations[0].relation_type).to eql Relation::TYPE_BLOCKS }
end
- shared_examples_for 'impediment update with unchanged blocking relationship' do
- it_behaves_like 'impediment update'
+ shared_examples_for "impediment update with unchanged blocking relationship" do
+ it_behaves_like "impediment update"
it { expect(subject.relations.size).to eq(1) }
it { expect(subject.relations[0]).not_to be_changed }
it { expect(subject.relations[0].to).to eql feature }
@@ -131,10 +131,10 @@
call.result
end
- describe 'WHEN changing the blocking relationship to another story' do
+ describe "WHEN changing the blocking relationship to another story" do
let(:story) do
build(:work_package,
- subject: 'another story',
+ subject: "another story",
type: type_feature,
project:,
author: user,
@@ -149,16 +149,16 @@
story.save!
end
- describe 'WITH the story having the same version' do
- it_behaves_like 'impediment update with changed blocking relationship'
+ describe "WITH the story having the same version" do
+ it_behaves_like "impediment update with changed blocking relationship"
it { expect(subject).not_to be_changed }
end
- describe 'WITH the story having another version' do
- let(:story_version) { create(:version, project:, name: 'another version') }
+ describe "WITH the story having another version" do
+ let(:story_version) { create(:version, project:, name: "another version") }
- it_behaves_like 'impediment update with unchanged blocking relationship'
- it 'is not saved successfully' do
+ it_behaves_like "impediment update with unchanged blocking relationship"
+ it "is not saved successfully" do
expect(subject).to be_changed
end
@@ -168,11 +168,11 @@
}
end
- describe 'WITH the story being non existent' do
- let(:blocks) { '0' }
+ describe "WITH the story being non existent" do
+ let(:blocks) { "0" }
- it_behaves_like 'impediment update with unchanged blocking relationship'
- it 'is not saved successfully' do
+ it_behaves_like "impediment update with unchanged blocking relationship"
+ it "is not saved successfully" do
expect(subject).to be_changed
end
@@ -183,11 +183,11 @@
end
end
- describe 'WITHOUT a blocking relationship defined' do
- let(:blocks) { '' }
+ describe "WITHOUT a blocking relationship defined" do
+ let(:blocks) { "" }
- it_behaves_like 'impediment update with unchanged blocking relationship'
- it 'is not saved successfully' do
+ it_behaves_like "impediment update with unchanged blocking relationship"
+ it "is not saved successfully" do
expect(subject).to be_changed
end
diff --git a/modules/backlogs/spec/services/stories/create_service_spec.rb b/modules/backlogs/spec/services/stories/create_service_spec.rb
index 1d9876cf3feb..4f0caf212801 100644
--- a/modules/backlogs/spec/services/stories/create_service_spec.rb
+++ b/modules/backlogs/spec/services/stories/create_service_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Stories::CreateService, type: :model do
let(:priority) { create(:priority) }
@@ -60,14 +60,14 @@
priority:,
parent_id: story.id,
remaining_hours:,
- subject: 'some subject'
+ subject: "some subject"
}
end
let(:version) { create(:version, project:) }
let(:story) do
- project.enabled_module_names += ['backlogs']
+ project.enabled_module_names += ["backlogs"]
create(:story,
version:,
@@ -88,18 +88,18 @@
subject
end
- context 'with the story having remaining_hours' do
+ context "with the story having remaining_hours" do
let(:remaining_hours) { 15.0 }
- it 'does update the parents remaining hours' do
+ it "does update the parents remaining hours" do
expect(story.reload.derived_remaining_hours).to eq(15)
end
end
- context 'with the subtask not having remaining_hours' do
+ context "with the subtask not having remaining_hours" do
let(:remaining_hours) { nil }
- it 'does not note remaining hours to be changed' do
+ it "does not note remaining hours to be changed" do
expect(story.reload.remaining_hours).to be_nil
end
end
diff --git a/modules/backlogs/spec/services/work_packages/update_service_version_inheritance_spec.rb b/modules/backlogs/spec/services/work_packages/update_service_version_inheritance_spec.rb
index c0a131cfe255..7da27199da3c 100644
--- a/modules/backlogs/spec/services/work_packages/update_service_version_inheritance_spec.rb
+++ b/modules/backlogs/spec/services/work_packages/update_service_version_inheritance_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WorkPackages::UpdateService, "version inheritance", type: :model do
let(:type_feature) { build(:type_feature) }
@@ -37,7 +37,7 @@
let(:role) { build(:project_role) }
let(:user) { build(:admin) }
let(:issue_priority) { build(:priority) }
- let(:status) { build(:status, name: 'status 1', is_default: true) }
+ let(:status) { build(:status, name: "status 1", is_default: true) }
let(:project) do
p = build(:project,
@@ -46,15 +46,15 @@
roles: [role])],
types: [type_feature, type_task, type_bug])
- p.versions << build(:version, name: 'Version1', project: p)
- p.versions << build(:version, name: 'Version2', project: p)
+ p.versions << build(:version, name: "Version1", project: p)
+ p.versions << build(:version, name: "Version2", project: p)
p
end
let(:story) do
story = build(:work_package,
- subject: 'Story',
+ subject: "Story",
project:,
type: type_feature,
version: version1,
@@ -66,7 +66,7 @@
let(:story2) do
story = build(:work_package,
- subject: 'Story2',
+ subject: "Story2",
project:,
type: type_feature,
version: version1,
@@ -78,7 +78,7 @@
let(:story3) do
story = build(:work_package,
- subject: 'Story3',
+ subject: "Story3",
project:,
type: type_feature,
version: version1,
@@ -90,7 +90,7 @@
let(:task) do
build(:work_package,
- subject: 'Task',
+ subject: "Task",
type: type_task,
version: version1,
project:,
@@ -101,7 +101,7 @@
let(:task2) do
build(:work_package,
- subject: 'Task2',
+ subject: "Task2",
type: type_task,
version: version1,
project:,
@@ -112,7 +112,7 @@
let(:task3) do
build(:work_package,
- subject: 'Task3',
+ subject: "Task3",
type: type_task,
version: version1,
project:,
@@ -123,7 +123,7 @@
let(:task4) do
build(:work_package,
- subject: 'Task4',
+ subject: "Task4",
type: type_task,
version: version1,
project:,
@@ -134,7 +134,7 @@
let(:task5) do
build(:work_package,
- subject: 'Task5',
+ subject: "Task5",
type: type_task,
version: version1,
project:,
@@ -145,7 +145,7 @@
let(:task6) do
build(:work_package,
- subject: 'Task6',
+ subject: "Task6",
type: type_task,
version: version1,
project:,
@@ -156,7 +156,7 @@
let(:bug) do
build(:work_package,
- subject: 'Bug',
+ subject: "Bug",
type: type_bug,
version: version1,
project:,
@@ -167,7 +167,7 @@
let(:bug2) do
build(:work_package,
- subject: 'Bug2',
+ subject: "Bug2",
type: type_bug,
version: version1,
project:,
@@ -178,7 +178,7 @@
let(:bug3) do
build(:work_package,
- subject: 'Bug3',
+ subject: "Bug3",
type: type_bug,
version: version1,
project:,
@@ -190,10 +190,10 @@
before do
project.save!
- allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ 'points_burn_direction' => 'down',
- 'wiki_template' => '',
- 'story_types' => [type_feature.id],
- 'task_type' => type_task.id.to_s })
+ allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ "points_burn_direction" => "down",
+ "wiki_template" => "",
+ "story_types" => [type_feature.id],
+ "task_type" => type_task.id.to_s })
end
def standard_child_layout
@@ -222,7 +222,7 @@ def standard_child_layout
child.reload
end
- describe 'WHEN changing version' do
+ describe "WHEN changing version" do
let(:instance) { described_class.new(user:, model: parent) }
shared_examples_for "changing parent's version changes child's version" do
@@ -273,65 +273,65 @@ def standard_child_layout
end
end
- describe 'WITH backlogs enabled' do
+ describe "WITH backlogs enabled" do
before do
- project.enabled_module_names += ['backlogs']
+ project.enabled_module_names += ["backlogs"]
end
- describe 'WITH a story' do
+ describe "WITH a story" do
let(:parent) { story }
- describe 'WITH a task as child' do
+ describe "WITH a task as child" do
let(:child) { task2 }
it_behaves_like "changing parent's version changes child's version"
end
- describe 'WITH a non backlogs work_package as child' do
+ describe "WITH a non backlogs work_package as child" do
let(:child) { bug2 }
it_behaves_like "changing parent's version does not change child's version"
end
- describe 'WITH a story as a child' do
+ describe "WITH a story as a child" do
let(:child) { story2 }
it_behaves_like "changing parent's version does not change child's version"
end
end
- describe 'WITH a task (impediment) without a parent' do
+ describe "WITH a task (impediment) without a parent" do
let(:parent) { task }
- describe 'WITH a task as child' do
+ describe "WITH a task as child" do
let(:child) { task2 }
it_behaves_like "changing parent's version changes child's version"
end
- describe 'WITH a non backlogs work_package as child' do
+ describe "WITH a non backlogs work_package as child" do
let(:child) { bug }
it_behaves_like "changing parent's version does not change child's version"
end
end
- describe 'WITH a non backlogs work_package' do
+ describe "WITH a non backlogs work_package" do
let(:parent) { bug }
- describe 'WITH a task as child' do
+ describe "WITH a task as child" do
let(:child) { task }
it_behaves_like "changing parent's version does not change child's version"
end
- describe 'WITH a non backlogs work_package as child' do
+ describe "WITH a non backlogs work_package as child" do
let(:child) { bug2 }
it_behaves_like "changing parent's version does not change child's version"
end
- describe 'WITH a story as a child' do
+ describe "WITH a story as a child" do
let(:child) { story }
it_behaves_like "changing parent's version does not change child's version"
@@ -339,34 +339,34 @@ def standard_child_layout
end
end
- describe 'WITH backlogs disabled' do
+ describe "WITH backlogs disabled" do
before do
- project.enabled_module_names = project.enabled_module_names.find_all { |n| n != 'backlogs' }
+ project.enabled_module_names = project.enabled_module_names.find_all { |n| n != "backlogs" }
end
- describe 'WITH a story' do
+ describe "WITH a story" do
let(:parent) { story }
- describe 'WITH a task as child' do
+ describe "WITH a task as child" do
let(:child) { task2 }
it_behaves_like "changing parent's version does not change child's version"
end
- describe 'WITH a non backlogs work_package as child' do
+ describe "WITH a non backlogs work_package as child" do
let(:child) { bug2 }
it_behaves_like "changing parent's version does not change child's version"
end
- describe 'WITH a story as a child' do
+ describe "WITH a story as a child" do
let(:child) { story2 }
it_behaves_like "changing parent's version does not change child's version"
end
end
- describe 'WITH a task' do
+ describe "WITH a task" do
before do
bug2.save!
task.parent_id = bug2.id # so that it is considered a task
@@ -375,51 +375,51 @@ def standard_child_layout
let(:parent) { task }
- describe 'WITH a task as child' do
+ describe "WITH a task as child" do
let(:child) { task2 }
it_behaves_like "changing parent's version does not change child's version"
end
- describe 'WITH a non backlogs work_package as child' do
+ describe "WITH a non backlogs work_package as child" do
let(:child) { bug }
it_behaves_like "changing parent's version does not change child's version"
end
end
- describe 'WITH a task (impediment) without a parent' do
+ describe "WITH a task (impediment) without a parent" do
let(:parent) { task }
- describe 'WITH a task as child' do
+ describe "WITH a task as child" do
let(:child) { task2 }
it_behaves_like "changing parent's version does not change child's version"
end
- describe 'WITH a non backlogs work_package as child' do
+ describe "WITH a non backlogs work_package as child" do
let(:child) { bug }
it_behaves_like "changing parent's version does not change child's version"
end
end
- describe 'WITH a non backlogs work_package' do
+ describe "WITH a non backlogs work_package" do
let(:parent) { bug }
- describe 'WITH a task as child' do
+ describe "WITH a task as child" do
let(:child) { task }
it_behaves_like "changing parent's version does not change child's version"
end
- describe 'WITH a non backlogs work_package as child' do
+ describe "WITH a non backlogs work_package as child" do
let(:child) { bug2 }
it_behaves_like "changing parent's version does not change child's version"
end
- describe 'WITH a story as a child' do
+ describe "WITH a story as a child" do
let(:child) { story }
it_behaves_like "changing parent's version does not change child's version"
@@ -428,7 +428,7 @@ def standard_child_layout
end
end
- describe 'WHEN changing the parent_id' do
+ describe "WHEN changing the parent_id" do
let(:instance) { described_class.new(user:, model: child) }
shared_examples_for "changing the child's parent_issue to the parent changes child's version" do
@@ -473,27 +473,27 @@ def standard_child_layout
end
end
- describe 'WITH backogs enabled' do
+ describe "WITH backogs enabled" do
before do
- story.project.enabled_module_names += ['backlogs']
+ story.project.enabled_module_names += ["backlogs"]
end
- describe 'WITH a story as parent' do
+ describe "WITH a story as parent" do
let(:parent) { story }
- describe 'WITH a story as child' do
+ describe "WITH a story as child" do
let(:child) { story2 }
it_behaves_like "changing the child's parent to the parent leaves child's version"
end
- describe 'WITH a task as child' do
+ describe "WITH a task as child" do
let(:child) { task2 }
it_behaves_like "changing the child's parent_issue to the parent changes child's version"
end
- describe 'WITH a non-backlogs work_package as child' do
+ describe "WITH a non-backlogs work_package as child" do
let(:child) { bug2 }
it_behaves_like "changing the child's parent to the parent leaves child's version"
@@ -515,7 +515,7 @@ def standard_child_layout
it_behaves_like "changing the child's parent_issue to the parent changes child's version"
end
- describe 'WITH a task as parent' do
+ describe "WITH a task as parent" do
before do
story.save!
task.parent_id = story.id
@@ -528,51 +528,51 @@ def standard_child_layout
# 'version_id'
let(:parent) { story }
- describe 'WITH a task as child' do
+ describe "WITH a task as child" do
let(:child) { task2 }
it_behaves_like "changing the child's parent_issue to the parent changes child's version"
end
- describe 'WITH a non-backlogs work_package as child' do
+ describe "WITH a non-backlogs work_package as child" do
let(:child) { bug2 }
it_behaves_like "changing the child's parent to the parent leaves child's version"
end
end
- describe 'WITH an impediment (task) as parent' do
+ describe "WITH an impediment (task) as parent" do
let(:parent) { task }
- describe 'WITH a task as child' do
+ describe "WITH a task as child" do
let(:child) { task2 }
it_behaves_like "changing the child's parent_issue to the parent changes child's version"
end
- describe 'WITH a non-backlogs work_package as child' do
+ describe "WITH a non-backlogs work_package as child" do
let(:child) { bug2 }
it_behaves_like "changing the child's parent to the parent leaves child's version"
end
end
- describe 'WITH a non-backlogs work_package as parent' do
+ describe "WITH a non-backlogs work_package as parent" do
let(:parent) { bug }
- describe 'WITH a story as child' do
+ describe "WITH a story as child" do
let(:child) { story2 }
it_behaves_like "changing the child's parent to the parent leaves child's version"
end
- describe 'WITH a task as child' do
+ describe "WITH a task as child" do
let(:child) { task2 }
it_behaves_like "changing the child's parent to the parent leaves child's version"
end
- describe 'WITH a non-backlogs work_package as child' do
+ describe "WITH a non-backlogs work_package as child" do
let(:child) { bug2 }
it_behaves_like "changing the child's parent to the parent leaves child's version"
diff --git a/modules/backlogs/spec/support/pages/backlogs.rb b/modules/backlogs/spec/support/pages/backlogs.rb
index b78299799342..df0e167833c6 100644
--- a/modules/backlogs/spec/support/pages/backlogs.rb
+++ b/modules/backlogs/spec/support/pages/backlogs.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'support/pages/page'
+require "support/pages/page"
module Pages
class Backlogs < Page
@@ -40,13 +40,13 @@ def initialize(project)
def enter_edit_story_mode(story, text: nil)
text ||= story.subject
within_story(story) do
- find(:css, '.editable', text:).click
+ find(:css, ".editable", text:).click
end
end
def enter_edit_backlog_mode(backlog)
within_backlog(backlog) do
- find('.start_date.editable').click
+ find(".start_date.editable").click
end
end
@@ -77,11 +77,11 @@ def alter_attributes_in_edit_backlog_mode(backlog, attributes)
attributes.each do |key, value|
case key
when :name
- find('input[name=name]').set value
+ find("input[name=name]").set value
when :start_date
- find('input[name=start_date]').set value
+ find("input[name=start_date]").set value
when :effective_date
- find('input[name=effective_date]').set value
+ find("input[name=effective_date]").set value
else
raise NotImplementedError
end
@@ -93,7 +93,7 @@ def save_story_from_edit_mode(story)
save_proc = ->(*) do
field = find_field(disabled: false, match: :first)
keys = [:return]
- keys << :return if field.tag_name == 'select' # select field needs a second return key sent for some reason
+ keys << :return if field.tag_name == "select" # select field needs a second return key sent for some reason
field.send_keys(*keys)
expect(page).to have_no_field(WorkPackage.human_attribute_name(:subject))
@@ -109,15 +109,15 @@ def save_story_from_edit_mode(story)
def save_backlog_from_edit_mode(backlog)
within_backlog(backlog) do
- find('input[name=name]').native.send_key :return
+ find("input[name=name]").native.send_key :return
expect(page)
- .to have_css('.start_date.editable')
+ .to have_css(".start_date.editable")
end
end
def wait_for_save_completion
- expect(page).to have_no_css('.ajax-indicator')
+ expect(page).to have_no_css(".ajax-indicator")
end
def edit_backlog(backlog, attributes)
@@ -137,7 +137,7 @@ def edit_story(story, attributes)
end
def edit_new_story(attributes)
- within('.story.editing') do
+ within(".story.editing") do
alter_attributes_in_edit_story_mode(nil, attributes)
save_story_from_edit_mode(nil)
@@ -146,7 +146,7 @@ def edit_new_story(attributes)
def click_in_backlog_menu(backlog, item_name)
within_backlog_menu(backlog) do |menu|
- menu.find('.item', text: item_name).click
+ menu.find(".item", text: item_name).click
end
end
@@ -160,7 +160,7 @@ def drag_in_sprint(moved, target, before: true)
def fold_backlog(backlog)
within_backlog(backlog) do
- find('.toggler').click
+ find(".toggler").click
end
end
@@ -194,13 +194,13 @@ def expect_for_story(story, attributes)
case key
when :subject
expect(page)
- .to have_css('div.subject', text: value)
+ .to have_css("div.subject", text: value)
when :status
expect(page)
- .to have_css('div.status_id', text: value)
+ .to have_css("div.status_id", text: value)
when :type
expect(page)
- .to have_css('div.type_id', text: value)
+ .to have_css("div.type_id", text: value)
else
raise NotImplementedError
end
@@ -217,7 +217,7 @@ def expect_story_link_to_wp_page(story)
def expect_status_options(story, statuses)
within_story(story) do
- expect(all('.status_id option').map { |n| n.text.strip })
+ expect(all(".status_id option").map { |n| n.text.strip })
.to match_array(statuses.map(&:name))
end
end
@@ -232,7 +232,7 @@ def expect_velocity(backlog, velocity)
def expect_stories_in_order(backlog, *stories)
within_backlog(backlog) do
ids = stories.map { |s| "story_#{s.id}" }
- existing_ids_in_order = all(ids.map { |id| "##{id}" }.join(', ')).pluck(:id)
+ existing_ids_in_order = all(ids.map { |id| "##{id}" }.join(", ")).pluck(:id)
expect(existing_ids_in_order)
.to eql(ids)
@@ -241,22 +241,22 @@ def expect_stories_in_order(backlog, *stories)
def expect_in_backlog_menu(backlog, item_name)
within_backlog(backlog) do
- find('.header .menu-trigger').click
+ find(".header .menu-trigger").click
expect(page)
- .to have_css('.header .backlog-menu .item', text: item_name)
+ .to have_css(".header .backlog-menu .item", text: item_name)
# Close it again for next test
- find('.header .menu-trigger').click
+ find(".header .menu-trigger").click
end
end
def expect_and_dismiss_error(message)
- within '.ui-dialog' do
+ within ".ui-dialog" do
expect(page)
.to have_content message
- click_button('OK')
+ click_button("OK")
end
end
@@ -266,7 +266,7 @@ def path
def within_backlog_menu(backlog, &)
within_backlog(backlog) do
- menu = find('.backlog-menu')
+ menu = find(".backlog-menu")
menu.click
yield menu
diff --git a/modules/backlogs/spec/support/pages/taskboard.rb b/modules/backlogs/spec/support/pages/taskboard.rb
index 37e71332d3f9..3dcc4ed1d00b 100644
--- a/modules/backlogs/spec/support/pages/taskboard.rb
+++ b/modules/backlogs/spec/support/pages/taskboard.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'support/pages/page'
+require "support/pages/page"
module Pages
class Taskboard < Page
@@ -70,8 +70,8 @@ def add_task(story, attributes)
change_attributes_in_modal(attributes)
- expect(page).to have_no_css('.ui-dialog')
- expect(page).to have_no_css('#work_package_')
+ expect(page).to have_no_css(".ui-dialog")
+ expect(page).to have_no_css("#work_package_")
end
def update_task(task, attributes)
@@ -79,7 +79,7 @@ def update_task(task, attributes)
change_attributes_in_modal(attributes)
- expect(page).to have_no_css('.ui-dialog')
+ expect(page).to have_no_css(".ui-dialog")
sleep(0.5)
end
@@ -112,19 +112,19 @@ def story_selector(story)
end
def change_attributes_in_modal(attributes)
- within '.ui-dialog' do
+ within ".ui-dialog" do
attributes.each do |key, value|
case key
when :subject
- fill_in 'Subject', with: value
+ fill_in "Subject", with: value
when :assignee
- select value, from: 'Assignee'
+ select value, from: "Assignee"
when :remaining_hours
- fill_in 'Remaining work', with: value
+ fill_in "Remaining work", with: value
end
end
- click_button 'OK'
+ click_button "OK"
end
end
end
diff --git a/modules/backlogs/spec/views/rb_burndown_charts/show_spec.rb b/modules/backlogs/spec/views/rb_burndown_charts/show_spec.rb
index 3d2492afe9ef..f9d545a01cfb 100644
--- a/modules/backlogs/spec/views/rb_burndown_charts/show_spec.rb
+++ b/modules/backlogs/spec/views/rb_burndown_charts/show_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'rb_burndown_charts/show' do
+RSpec.describe "rb_burndown_charts/show" do
let(:user1) { create(:user) }
let(:user2) { create(:user) }
let(:role_allowed) do
@@ -88,25 +88,25 @@
end
before do
- allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ 'story_types' => [type_feature.id],
- 'task_type' => type_task.id })
+ allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ "story_types" => [type_feature.id],
+ "task_type" => type_task.id })
view.extend BurndownChartsHelper
# We directly force the creation of stories,statuses by calling the method
stories
end
- describe 'burndown chart' do
- it 'renders a version with dates' do
+ describe "burndown chart" do
+ it "renders a version with dates" do
assign(:sprint, sprint)
assign(:project, project)
assign(:burndown, sprint.burndown(project))
render
- expect(view).to render_template(partial: '_burndown', count: 1)
+ expect(view).to render_template(partial: "_burndown", count: 1)
end
- it 'renders a version without dates' do
+ it "renders a version without dates" do
sprint.start_date = nil
sprint.effective_date = nil
sprint.save
@@ -116,8 +116,8 @@
render
- expect(view).to render_template(partial: '_burndown', count: 0)
- expect(rendered).to include(I18n.t('backlogs.no_burndown_data'))
+ expect(view).to render_template(partial: "_burndown", count: 0)
+ expect(rendered).to include(I18n.t("backlogs.no_burndown_data"))
end
end
end
diff --git a/modules/backlogs/spec/views/rb_master_backlogs/index.html.erb_spec.rb b/modules/backlogs/spec/views/rb_master_backlogs/index.html.erb_spec.rb
index 5397fba52b76..d3dbcff4e5ed 100644
--- a/modules/backlogs/spec/views/rb_master_backlogs/index.html.erb_spec.rb
+++ b/modules/backlogs/spec/views/rb_master_backlogs/index.html.erb_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'rb_master_backlogs/index' do
+RSpec.describe "rb_master_backlogs/index" do
let(:user) { create(:user) }
let(:role_allowed) do
create(:project_role,
@@ -72,8 +72,8 @@
let(:sprint) { create(:sprint, project:) }
before do
- allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ 'story_types' => [type_feature.id],
- 'task_type' => type_task.id })
+ allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ "story_types" => [type_feature.id],
+ "task_type" => type_task.id })
view.extend RbCommonHelper
view.extend RbMasterBacklogsHelper
allow(view).to receive(:current_user).and_return(user)
diff --git a/modules/backlogs/spec/views/rb_taskboards/show_spec.rb b/modules/backlogs/spec/views/rb_taskboards/show_spec.rb
index 434f3f11ef44..195ba65fd29d 100644
--- a/modules/backlogs/spec/views/rb_taskboards/show_spec.rb
+++ b/modules/backlogs/spec/views/rb_taskboards/show_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'rb_taskboards/show' do
+RSpec.describe "rb_taskboards/show" do
let(:user1) { create(:user) }
let(:user2) { create(:user) }
let(:role_allowed) do
@@ -86,8 +86,8 @@
end
before do
- allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ 'story_types' => [type_feature.id],
- 'task_type' => type_task.id })
+ allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ "story_types" => [type_feature.id],
+ "task_type" => type_task.id })
view.extend RbCommonHelper
view.extend TaskboardsHelper
@@ -99,8 +99,8 @@
stories
end
- describe 'story blocks' do
- it 'contains the story id' do
+ describe "story blocks" do
+ it "contains the story id" do
render
stories.each do |story|
@@ -108,7 +108,7 @@
end
end
- it 'has a title containing the story subject' do
+ it "has a title containing the story subject" do
render
stories.each do |story|
@@ -116,7 +116,7 @@
end
end
- it 'contains the story status' do
+ it "contains the story status" do
render
stories.each do |story|
@@ -124,21 +124,21 @@
end
end
- it 'contains the user it is assigned to' do
+ it "contains the user it is assigned to" do
story_a.update(assigned_to: user1)
story_c.update(assigned_to: user2)
render
stories.each do |story|
- expected_text = story.assigned_to ? story.assigned_to.name : 'Unassigned'
+ expected_text = story.assigned_to ? story.assigned_to.name : "Unassigned"
expect(rendered).to have_css("#story_#{story.id} .assigned_to_id", text: expected_text)
end
end
end
- describe 'create buttons' do
- it 'renders clickable + buttons for all stories with the right permissions' do
+ describe "create buttons" do
+ it "renders clickable + buttons for all stories with the right permissions" do
allow(User).to receive(:current).and_return(user1)
render
@@ -146,13 +146,13 @@
stories.each do |story|
assert_select "tr.story_#{story.id} td.add_new" do |td|
expect(td.count).to eq 1
- expect(td.first).to have_content '+'
- expect(td.first[:class]).to include 'clickable'
+ expect(td.first).to have_content "+"
+ expect(td.first[:class]).to include "clickable"
end
end
end
- it 'does not render a clickable + buttons for all stories without the right permissions' do
+ it "does not render a clickable + buttons for all stories without the right permissions" do
allow(User).to receive(:current).and_return(user2)
render
@@ -160,90 +160,90 @@
stories.each do |story|
assert_select "tr.story_#{story.id} td.add_new" do |td|
expect(td.count).to eq 1
- expect(td.first).to have_no_content '+'
- expect(td.first[:class]).not_to include 'clickable'
+ expect(td.first).to have_no_content "+"
+ expect(td.first[:class]).not_to include "clickable"
end
end
end
- it 'renders clickable + buttons for impediments with the right permissions' do
+ it "renders clickable + buttons for impediments with the right permissions" do
allow(User).to receive(:current).and_return(user1)
render
stories.each do |_story|
- assert_select '#impediments td.add_new' do |td|
+ assert_select "#impediments td.add_new" do |td|
expect(td.count).to eq 1
- expect(td.first).to have_content '+'
- expect(td.first[:class]).to include 'clickable'
+ expect(td.first).to have_content "+"
+ expect(td.first[:class]).to include "clickable"
end
end
end
- it 'does not render a clickable + buttons for impediments without the right permissions' do
+ it "does not render a clickable + buttons for impediments without the right permissions" do
allow(User).to receive(:current).and_return(user2)
render
stories.each do |_story|
- assert_select '#impediments td.add_new' do |td|
+ assert_select "#impediments td.add_new" do |td|
expect(td.count).to eq 1
- expect(td.first).to have_no_content '+'
- expect(td.first[:class]).not_to include 'clickable'
+ expect(td.first).to have_no_content "+"
+ expect(td.first[:class]).not_to include "clickable"
end
end
end
end
- describe 'update tasks or impediments' do
- it 'allows edit and drag for all tasks with the right permissions' do
+ describe "update tasks or impediments" do
+ it "allows edit and drag for all tasks with the right permissions" do
allow(User).to receive(:current).and_return(user1)
task
impediment
render
- assert_select '.model.work_package.task' do |task|
+ assert_select ".model.work_package.task" do |task|
expect(task.count).to eq 1
- expect(task.first).to have_no_css '.task.prevent_edit'
+ expect(task.first).to have_no_css ".task.prevent_edit"
end
end
- it 'does not allow to edit and drag for all tasks without the right permissions' do
+ it "does not allow to edit and drag for all tasks without the right permissions" do
allow(User).to receive(:current).and_return(user2)
task
impediment
render
- assert_select '.model.work_package.task' do |task|
+ assert_select ".model.work_package.task" do |task|
expect(task.count).to eq 1
- expect(task.first).to have_css '.task.prevent_edit'
+ expect(task.first).to have_css ".task.prevent_edit"
end
end
- it 'allows edit and drag for all impediments with the right permissions' do
+ it "allows edit and drag for all impediments with the right permissions" do
allow(User).to receive(:current).and_return(user1)
task
impediment
render
- assert_select '.model.work_package.impediment' do |impediment|
+ assert_select ".model.work_package.impediment" do |impediment|
expect(impediment.count).to eq 3 # 2 additional for the task and the invisible form
- expect(impediment.first).to have_no_css '.impediment.prevent_edit'
+ expect(impediment.first).to have_no_css ".impediment.prevent_edit"
end
end
- it 'does not allow to edit and drag for all impediments without the right permissions' do
+ it "does not allow to edit and drag for all impediments without the right permissions" do
allow(User).to receive(:current).and_return(user2)
task
impediment
render
- assert_select '.model.work_package.impediment' do |impediment|
+ assert_select ".model.work_package.impediment" do |impediment|
expect(impediment.count).to eq 3 # 2 additional for the task and the invisible form
- expect(impediment.first).to have_css '.impediment.prevent_edit'
+ expect(impediment.first).to have_css ".impediment.prevent_edit"
end
end
end
diff --git a/modules/backlogs/spec/views/shared/not_configured_spec.rb b/modules/backlogs/spec/views/shared/not_configured_spec.rb
index 8279829222d7..79cb4ed2eba7 100644
--- a/modules/backlogs/spec/views/shared/not_configured_spec.rb
+++ b/modules/backlogs/spec/views/shared/not_configured_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'shared/not_configured' do
- it 'renders without errors' do
+RSpec.describe "shared/not_configured" do
+ it "renders without errors" do
render
end
end
diff --git a/modules/bim/Gemfile b/modules/bim/Gemfile
index 851fabc21ddb..3be9c3cd812e 100644
--- a/modules/bim/Gemfile
+++ b/modules/bim/Gemfile
@@ -1,2 +1,2 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
gemspec
diff --git a/modules/bim/app/components/bim/ifc_models/row_component.rb b/modules/bim/app/components/bim/ifc_models/row_component.rb
index 224a62b11ef6..3e7f4b3bd71f 100644
--- a/modules/bim/app/components/bim/ifc_models/row_component.rb
+++ b/modules/bim/app/components/bim/ifc_models/row_component.rb
@@ -14,7 +14,7 @@ def title
def default?
if model.is_default?
- helpers.op_icon 'icon icon-checkmark'
+ helpers.op_icon "icon icon-checkmark"
end
end
@@ -34,7 +34,7 @@ def processing
class: "ifc-models--conversion-status")
if model.conversion_error_message
- content << ': '.html_safe
+ content << ": ".html_safe
content << content_tag(:span,
model.conversion_error_message,
class: "ifc-models--conversion-status-error",
@@ -65,26 +65,26 @@ def button_links
end
def delete_link
- link_to '',
+ link_to "",
bcf_project_ifc_model_path(model.project, model),
- class: 'icon icon-delete',
+ class: "icon icon-delete",
data: { confirm: I18n.t(:text_are_you_sure) },
title: I18n.t(:button_delete),
method: :delete
end
def download_link
- link_to '',
+ link_to "",
API::V3::Utilities::PathHelper::ApiV3Path.attachment_content(model.ifc_attachment&.id),
- class: 'icon icon-download',
+ class: "icon icon-download",
title: I18n.t(:button_download),
download: true
end
def edit_link
- link_to '',
+ link_to "",
edit_bcf_project_ifc_model_path(model.project, model),
- class: 'icon icon-edit',
+ class: "icon icon-edit",
accesskey: helpers.accesskey(:edit),
title: I18n.t(:button_edit)
end
diff --git a/modules/bim/app/components/bim/ifc_models/table_component.rb b/modules/bim/app/components/bim/ifc_models/table_component.rb
index db381543671c..a015adc27140 100644
--- a/modules/bim/app/components/bim/ifc_models/table_component.rb
+++ b/modules/bim/app/components/bim/ifc_models/table_component.rb
@@ -13,24 +13,24 @@ def sortable?
def inline_create_link
link_to(new_bcf_project_ifc_model_path,
- class: 'wp-inline-create--add-link',
- title: I18n.t('ifc_models.label_new_ifc_model')) do
- helpers.op_icon('icon icon-add')
+ class: "wp-inline-create--add-link",
+ title: I18n.t("ifc_models.label_new_ifc_model")) do
+ helpers.op_icon("icon icon-add")
end
end
def empty_row_message
- I18n.t 'ifc_models.no_results'
+ I18n.t "ifc_models.no_results"
end
def headers
[
- ['title', { caption: IfcModel.human_attribute_name(:title) }],
- ['is_default', { caption: IfcModel.human_attribute_name(:is_default) }],
- ['created_at', { caption: IfcModel.human_attribute_name(:created_at) }],
- ['updated_at', { caption: IfcModel.human_attribute_name(:updated_at) }],
- ['uploader', { caption: IfcModel.human_attribute_name(:uploader) }],
- ['processing', { caption: I18n.t('ifc_models.conversion_status.label') }]
+ ["title", { caption: IfcModel.human_attribute_name(:title) }],
+ ["is_default", { caption: IfcModel.human_attribute_name(:is_default) }],
+ ["created_at", { caption: IfcModel.human_attribute_name(:created_at) }],
+ ["updated_at", { caption: IfcModel.human_attribute_name(:updated_at) }],
+ ["uploader", { caption: IfcModel.human_attribute_name(:uploader) }],
+ ["processing", { caption: I18n.t("ifc_models.conversion_status.label") }]
]
end
end
diff --git a/modules/bim/app/controllers/bim/bcf/api/root.rb b/modules/bim/app/controllers/bim/bcf/api/root.rb
index d2dfa44703c6..aac9d5a7f132 100644
--- a/modules/bim/app/controllers/bim/bcf/api/root.rb
+++ b/modules/bim/app/controllers/bim/bcf/api/root.rb
@@ -43,7 +43,7 @@ class Root < ::API::RootAPI
authentication_scope OpenProject::Authentication::Scope::BCF_V2_1
- version '2.1', using: :path do
+ version "2.1", using: :path do
# /auth
mount ::Bim::Bcf::API::V2_1::AuthAPI
# /current-user
diff --git a/modules/bim/app/controllers/bim/bcf/api/v2_1/comments/api.rb b/modules/bim/app/controllers/bim/bcf/api/v2_1/comments/api.rb
index e6899cf3c636..e2c3e2a53655 100644
--- a/modules/bim/app/controllers/bim/bcf/api/v2_1/comments/api.rb
+++ b/modules/bim/app/controllers/bim/bcf/api/v2_1/comments/api.rb
@@ -76,7 +76,7 @@ def transform_update_parameter(params)
.mount
params do
- requires :comment_guid, type: String, desc: 'The comment\'s UUID'
+ requires :comment_guid, type: String, desc: "The comment's UUID"
end
route_param :comment_guid, regexp: /\A[a-f0-9-]+\z/ do
diff --git a/modules/bim/app/controllers/bim/bcf/api/v2_1/current_user_api.rb b/modules/bim/app/controllers/bim/bcf/api/v2_1/current_user_api.rb
index 5a6409051c48..5adefc6538a6 100644
--- a/modules/bim/app/controllers/bim/bcf/api/v2_1/current_user_api.rb
+++ b/modules/bim/app/controllers/bim/bcf/api/v2_1/current_user_api.rb
@@ -28,7 +28,7 @@
module Bim::Bcf::API::V2_1
class CurrentUserAPI < ::API::OpenProjectAPI
- resources :'current-user' do
+ resources :"current-user" do
get &::Bim::Bcf::API::V2_1::Endpoints::Show.new(model: User,
instance_generator: ->(*) { current_user }).mount
end
diff --git a/modules/bim/app/controllers/bim/bcf/api/v2_1/topics_api.rb b/modules/bim/app/controllers/bim/bcf/api/v2_1/topics_api.rb
index 13e53a7299bf..edd23bc3b2e4 100644
--- a/modules/bim/app/controllers/bim/bcf/api/v2_1/topics_api.rb
+++ b/modules/bim/app/controllers/bim/bcf/api/v2_1/topics_api.rb
@@ -68,13 +68,13 @@ def default_put_params
get &::Bim::Bcf::API::V2_1::Endpoints::Index
.new(model: Bim::Bcf::Issue,
- api_name: 'Topics',
+ api_name: "Topics",
scope: -> { topics })
.mount
post &::Bim::Bcf::API::V2_1::Endpoints::Create
.new(model: Bim::Bcf::Issue,
- api_name: 'Topics',
+ api_name: "Topics",
params_modifier: ->(attributes) {
transform_attributes(attributes)
.merge(project: @project)
@@ -88,12 +88,12 @@ def default_put_params
get &::Bim::Bcf::API::V2_1::Endpoints::Show
.new(model: Bim::Bcf::Issue,
- api_name: 'Topics')
+ api_name: "Topics")
.mount
put &::Bim::Bcf::API::V2_1::Endpoints::Update
.new(model: Bim::Bcf::Issue,
- api_name: 'Topics',
+ api_name: "Topics",
params_modifier: ->(attributes) {
transform_attributes(attributes)
.reverse_merge(default_put_params)
@@ -102,7 +102,7 @@ def default_put_params
delete &::Bim::Bcf::API::V2_1::Endpoints::Delete
.new(model: Bim::Bcf::Issue,
- api_name: 'Topics')
+ api_name: "Topics")
.mount
mount ::Bim::Bcf::API::V2_1::Viewpoints::API
diff --git a/modules/bim/app/controllers/bim/bcf/api/v2_1/viewpoints/api.rb b/modules/bim/app/controllers/bim/bcf/api/v2_1/viewpoints/api.rb
index 098096bdeef4..f3dabf931590 100644
--- a/modules/bim/app/controllers/bim/bcf/api/v2_1/viewpoints/api.rb
+++ b/modules/bim/app/controllers/bim/bcf/api/v2_1/viewpoints/api.rb
@@ -67,7 +67,7 @@ class API < ::API::OpenProjectAPI
.mount
get :bitmaps do
- raise NotImplementedError, 'Bitmaps are not yet implemented.'
+ raise NotImplementedError, "Bitmaps are not yet implemented."
end
namespace :snapshot, &::API::Helpers::AttachmentRenderer.content_endpoint(&-> {
diff --git a/modules/bim/app/controllers/bim/bcf/issues_controller.rb b/modules/bim/app/controllers/bim/bcf/issues_controller.rb
index e90753492954..ab1b84313ccd 100644
--- a/modules/bim/app/controllers/bim/bcf/issues_controller.rb
+++ b/modules/bim/app/controllers/bim/bcf/issues_controller.rb
@@ -53,21 +53,21 @@ def index
def prepare_import
render_next
rescue StandardError => e
- flash[:error] = I18n.t('bcf.bcf_xml.import_failed', error: e.message)
+ flash[:error] = I18n.t("bcf.bcf_xml.import_failed", error: e.message)
redirect_to action: :upload
end
def configure_import
render_next
rescue StandardError => e
- flash[:error] = I18n.t('bcf.bcf_xml.import_failed', error: e.message)
+ flash[:error] = I18n.t("bcf.bcf_xml.import_failed", error: e.message)
redirect_to action: :upload
end
def perform_import
import_file
rescue StandardError => e
- flash[:error] = I18n.t('bcf.bcf_xml.import_failed', error: e.message)
+ flash[:error] = I18n.t("bcf.bcf_xml.import_failed", error: e.message)
redirect_to action: :upload
ensure
@bcf_attachment&.destroy
@@ -98,8 +98,8 @@ def import_canceled?
unknown_statuses_action
invalid_people_action
unknown_mails_action
- non_members_action].map { |key| params.dig(:import_options, key) }.include? 'cancel'
- flash[:notice] = I18n.t('bcf.bcf_xml.import_canceled')
+ non_members_action].map { |key| params.dig(:import_options, key) }.include? "cancel"
+ flash[:notice] = I18n.t("bcf.bcf_xml.import_canceled")
redirect_to_bcf_issues_list
end
end
@@ -110,8 +110,8 @@ def set_import_options
unknown_statuses_action: params.dig(:import_options, :unknown_statuses_action).presence || "use_default",
unknown_priorities_action: params.dig(:import_options, :unknown_priorities_action).presence || "use_default",
invalid_people_action: params.dig(:import_options, :invalid_people_action).presence || "anonymize",
- unknown_mails_action: params.dig(:import_options, :unknown_mails_action).presence || 'invite',
- non_members_action: params.dig(:import_options, :non_members_action).presence || 'chose',
+ unknown_mails_action: params.dig(:import_options, :unknown_mails_action).presence || "invite",
+ non_members_action: params.dig(:import_options, :non_members_action).presence || "chose",
unknown_types_chose_ids: params.dig(:import_options, :unknown_types_chose_ids) || [],
unknown_statuses_chose_ids: params.dig(:import_options, :unknown_statuses_chose_ids) || [],
unknown_priorities_chose_ids: params.dig(:import_options, :unknown_priorities_chose_ids) || [],
@@ -140,7 +140,7 @@ def render_next
end
def render_config_invalid_people
- render 'bim/bcf/issues/configure_invalid_people'
+ render "bim/bcf/issues/configure_invalid_people"
end
def render_config_invalid_people?
@@ -148,7 +148,7 @@ def render_config_invalid_people?
end
def render_config_unknown_types
- render 'bim/bcf/issues/configure_unknown_types'
+ render "bim/bcf/issues/configure_unknown_types"
end
def render_config_unknown_types?
@@ -156,7 +156,7 @@ def render_config_unknown_types?
end
def render_config_unknown_statuses
- render 'bim/bcf/issues/configure_unknown_statuses'
+ render "bim/bcf/issues/configure_unknown_statuses"
end
def render_config_unknown_statuses?
@@ -168,12 +168,12 @@ def render_config_unknown_priorities?
end
def render_config_unknown_priorities
- render 'bim/bcf/issues/configure_unknown_priorities'
+ render "bim/bcf/issues/configure_unknown_priorities"
end
def render_config_unknown_mails
@roles = ProjectRole.givable
- render 'bim/bcf/issues/configure_unknown_mails'
+ render "bim/bcf/issues/configure_unknown_mails"
end
def render_config_unknown_mails?
@@ -182,7 +182,7 @@ def render_config_unknown_mails?
def render_config_non_members
@roles = ProjectRole.givable
- render 'bim/bcf/issues/configure_non_members'
+ render "bim/bcf/issues/configure_non_members"
end
def render_config_non_members?
@@ -197,7 +197,7 @@ def get_persisted_file
@bcf_attachment = Attachment.find_by!(id: session[:bcf_file_id], author: current_user)
@bcf_xml_file = File.new @bcf_attachment.local_path
rescue ActiveRecord::RecordNotFound
- flash[:error] = I18n.t('bcf.bcf_xml.import.bcf_file_not_found')
+ flash[:error] = I18n.t("bcf.bcf_xml.import.bcf_file_not_found")
redirect_to action: :upload
end
@@ -226,7 +226,7 @@ def create_attachment
def check_file_param
path = params[:bcf_file]&.path
unless path && File.readable?(path)
- flash[:error] = I18n.t('bcf.bcf_xml.import_failed', error: 'File missing or not readable')
+ flash[:error] = I18n.t("bcf.bcf_xml.import_failed", error: "File missing or not readable")
redirect_to action: :upload
end
end
@@ -234,7 +234,7 @@ def check_file_param
def check_bcf_version
unless @importer.bcf_version_valid?
flash[:error] =
- I18n.t('bcf.bcf_xml.import_failed_unsupported_bcf_version',
+ I18n.t("bcf.bcf_xml.import_failed_unsupported_bcf_version",
minimal_version: OpenProject::Bim::BcfXml::Importer::MINIMUM_BCF_VERSION)
redirect_to action: :upload
end
diff --git a/modules/bim/app/controllers/bim/ifc_models/ifc_models_controller.rb b/modules/bim/app/controllers/bim/ifc_models/ifc_models_controller.rb
index c85222270839..6c64972e7752 100644
--- a/modules/bim/app/controllers/bim/ifc_models/ifc_models_controller.rb
+++ b/modules/bim/app/controllers/bim/ifc_models/ifc_models_controller.rb
@@ -110,7 +110,7 @@ def direct_upload_finished
whitelist: false
flash[:notice] = if new_model
- t('ifc_models.flash_messages.upload_successful')
+ t("ifc_models.flash_messages.upload_successful")
else
t(:notice_successful_update)
end
@@ -137,7 +137,7 @@ def create
@ifc_model = service_result.result
if service_result.success?
- flash[:notice] = t('ifc_models.flash_messages.upload_successful')
+ flash[:notice] = t("ifc_models.flash_messages.upload_successful")
redirect_to action: :index
else
render action: :new
@@ -203,7 +203,7 @@ def find_all_ifc_models
def permitted_model_params
params
.require(:bim_ifc_models_ifc_model)
- .permit('title', 'ifc_attachment', 'is_default')
+ .permit("title", "ifc_attachment", "is_default")
end
def find_ifc_model_object
diff --git a/modules/bim/app/controllers/bim/ifc_models/ifc_viewer_controller.rb b/modules/bim/app/controllers/bim/ifc_models/ifc_viewer_controller.rb
index 231a3d438da6..a42ca41b3dd9 100644
--- a/modules/bim/app/controllers/bim/ifc_models/ifc_viewer_controller.rb
+++ b/modules/bim/app/controllers/bim/ifc_models/ifc_viewer_controller.rb
@@ -56,7 +56,7 @@ def find_all_ifc_models
@ifc_models = @project
.ifc_models
.includes(:attachments)
- .order('created_at ASC')
+ .order("created_at ASC")
end
def set_default_models
diff --git a/modules/bim/app/models/bim/bcf/issue.rb b/modules/bim/app/models/bim/bcf/issue.rb
index 7ff39b8889dd..c8470efec47b 100644
--- a/modules/bim/app/models/bim/bcf/issue.rb
+++ b/modules/bim/app/models/bim/bcf/issue.rb
@@ -41,11 +41,11 @@ def of_project(project)
end
def imported_title
- markup_doc.xpath('//Topic/Title').text
+ markup_doc.xpath("//Topic/Title").text
end
def markup_doc
- @markup_doc ||= Nokogiri::XML markup, nil, 'UTF-8'
+ @markup_doc ||= Nokogiri::XML markup, nil, "UTF-8"
end
def invalidate_markup_cache
diff --git a/modules/bim/app/models/bim/bcf/viewpoint.rb b/modules/bim/app/models/bim/bcf/viewpoint.rb
index ba286c74c823..2ca305139063 100644
--- a/modules/bim/app/models/bim/bcf/viewpoint.rb
+++ b/modules/bim/app/models/bim/bcf/viewpoint.rb
@@ -51,14 +51,14 @@ def self.has_uuid?(uuid)
validates :issue, presence: true
def raw_json_viewpoint
- attributes_before_type_cast['json_viewpoint']
+ attributes_before_type_cast["json_viewpoint"]
end
def snapshot
if attachments.loaded?
- attachments.detect { |a| a.description == 'snapshot' }
+ attachments.detect { |a| a.description == "snapshot" }
else
- attachments.find_by_description('snapshot')
+ attachments.find_by_description("snapshot")
end
end
@@ -74,7 +74,7 @@ def snapshot=(file)
def build_snapshot(file, user: User.current)
::Attachments::BuildService
.bypass_whitelist(user:)
- .call(file:, container: self, filename: file.original_filename, description: 'snapshot')
+ .call(file:, container: self, filename: file.original_filename, description: "snapshot")
.result
end
end
diff --git a/modules/bim/app/models/bim/ifc_models/ifc_model.rb b/modules/bim/app/models/bim/ifc_models/ifc_model.rb
index 5c9b01f5f9f7..802057a180ae 100644
--- a/modules/bim/app/models/bim/ifc_models/ifc_model.rb
+++ b/modules/bim/app/models/bim/ifc_models/ifc_model.rb
@@ -20,7 +20,7 @@ class IfcModel < ApplicationRecord
view_permission: :view_ifc_models
belongs_to :project
- belongs_to :uploader, class_name: 'User'
+ belongs_to :uploader, class_name: "User"
validates :title, presence: true
validates :project, presence: true
diff --git a/modules/bim/app/models/bim/queries/work_packages/filter/bcf_issue_associated_filter.rb b/modules/bim/app/models/bim/queries/work_packages/filter/bcf_issue_associated_filter.rb
index 4b99bfcbcda4..6f11c17ef740 100644
--- a/modules/bim/app/models/bim/queries/work_packages/filter/bcf_issue_associated_filter.rb
+++ b/modules/bim/app/models/bim/queries/work_packages/filter/bcf_issue_associated_filter.rb
@@ -43,11 +43,11 @@ def allowed_values
def where
if associated?
- ::Queries::Operators::All.sql_for_field(values, ::Bim::Bcf::Issue.table_name, 'id')
+ ::Queries::Operators::All.sql_for_field(values, ::Bim::Bcf::Issue.table_name, "id")
elsif not_associated?
- ::Queries::Operators::None.sql_for_field(values, ::Bim::Bcf::Issue.table_name, 'id')
+ ::Queries::Operators::None.sql_for_field(values, ::Bim::Bcf::Issue.table_name, "id")
else
- raise 'Unsupported operator or value'
+ raise "Unsupported operator or value"
end
end
@@ -60,7 +60,7 @@ def type_strategy
end
def dependency_class
- '::API::V3::Queries::Schemas::BooleanFilterDependencyRepresenter'
+ "::API::V3::Queries::Schemas::BooleanFilterDependencyRepresenter"
end
def available?
@@ -70,13 +70,13 @@ def available?
private
def associated?
- (operator == '=' && values.first == OpenProject::Database::DB_VALUE_TRUE) ||
- (operator == '!' && values.first == OpenProject::Database::DB_VALUE_FALSE)
+ (operator == "=" && values.first == OpenProject::Database::DB_VALUE_TRUE) ||
+ (operator == "!" && values.first == OpenProject::Database::DB_VALUE_FALSE)
end
def not_associated?
- (operator == '=' && values.first == OpenProject::Database::DB_VALUE_FALSE) ||
- (operator == '!' && values.first == OpenProject::Database::DB_VALUE_TRUE)
+ (operator == "=" && values.first == OpenProject::Database::DB_VALUE_FALSE) ||
+ (operator == "!" && values.first == OpenProject::Database::DB_VALUE_TRUE)
end
end
end
diff --git a/modules/bim/app/models/bim/queries/work_packages/selects/bcf_thumbnail_select.rb b/modules/bim/app/models/bim/queries/work_packages/selects/bcf_thumbnail_select.rb
index b68efe0b36a6..f651aa110528 100644
--- a/modules/bim/app/models/bim/queries/work_packages/selects/bcf_thumbnail_select.rb
+++ b/modules/bim/app/models/bim/queries/work_packages/selects/bcf_thumbnail_select.rb
@@ -29,7 +29,7 @@
module ::Bim::Queries::WorkPackages::Selects
class BcfThumbnailSelect < Queries::WorkPackages::Selects::WorkPackageSelect
def caption
- I18n.t('attributes.bcf_thumbnail')
+ I18n.t("attributes.bcf_thumbnail")
end
def self.instances(_context = nil)
diff --git a/modules/bim/app/representers/bim/bcf/api/v2_1/errors/error_representer.rb b/modules/bim/app/representers/bim/bcf/api/v2_1/errors/error_representer.rb
index 5d41c480c70b..437e589683ab 100644
--- a/modules/bim/app/representers/bim/bcf/api/v2_1/errors/error_representer.rb
+++ b/modules/bim/app/representers/bim/bcf/api/v2_1/errors/error_representer.rb
@@ -30,7 +30,7 @@ module Bim::Bcf::API::V2_1::Errors
class ErrorRepresenter < Bim::Bcf::API::V2_1::BaseRepresenter
property :message,
getter: ->(*) {
- [message].concat(Array(errors).map(&:message)).compact.join(' ')
+ [message].concat(Array(errors).map(&:message)).compact.join(" ")
},
render_nil: true
end
diff --git a/modules/bim/app/representers/bim/bcf/api/v2_1/project_extensions/representer.rb b/modules/bim/app/representers/bim/bcf/api/v2_1/project_extensions/representer.rb
index a30cefb2e01d..6acebfc5ccb7 100644
--- a/modules/bim/app/representers/bim/bcf/api/v2_1/project_extensions/representer.rb
+++ b/modules/bim/app/representers/bim/bcf/api/v2_1/project_extensions/representer.rb
@@ -70,12 +70,12 @@ class ProjectExtensions::Representer < BaseRepresenter
property :project_actions,
getter: ->(decorator:, **) {
[].tap do |actions|
- actions << 'update' if decorator.allowed?(:edit_project)
+ actions << "update" if decorator.allowed?(:edit_project)
if decorator.allowed?(:manage_bcf)
- actions << 'viewTopic' << 'createTopic'
+ actions << "viewTopic" << "createTopic"
elsif decorator.allowed?(:view_linked_issues)
- actions << 'viewTopic'
+ actions << "viewTopic"
end
end
}
diff --git a/modules/bim/app/representers/bim/bcf/api/v2_1/viewpoints/coloring_representer.rb b/modules/bim/app/representers/bim/bcf/api/v2_1/viewpoints/coloring_representer.rb
index 9ff060ae3c5a..1d7b8b007ec4 100644
--- a/modules/bim/app/representers/bim/bcf/api/v2_1/viewpoints/coloring_representer.rb
+++ b/modules/bim/app/representers/bim/bcf/api/v2_1/viewpoints/coloring_representer.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative 'base_representer'
+require_relative "base_representer"
module Bim::Bcf::API::V2_1::Viewpoints
class ColoringRepresenter < BaseRepresenter
diff --git a/modules/bim/app/representers/bim/bcf/api/v2_1/viewpoints/full_representer.rb b/modules/bim/app/representers/bim/bcf/api/v2_1/viewpoints/full_representer.rb
index 12f683a50073..0030fa1c2dd9 100644
--- a/modules/bim/app/representers/bim/bcf/api/v2_1/viewpoints/full_representer.rb
+++ b/modules/bim/app/representers/bim/bcf/api/v2_1/viewpoints/full_representer.rb
@@ -25,7 +25,7 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative 'base_representer'
+require_relative "base_representer"
module Bim::Bcf::API::V2_1::Viewpoints
class FullRepresenter < BaseRepresenter
diff --git a/modules/bim/app/representers/bim/bcf/api/v2_1/viewpoints/selection_representer.rb b/modules/bim/app/representers/bim/bcf/api/v2_1/viewpoints/selection_representer.rb
index 6f00e5b8ace6..234c81b5d1d2 100644
--- a/modules/bim/app/representers/bim/bcf/api/v2_1/viewpoints/selection_representer.rb
+++ b/modules/bim/app/representers/bim/bcf/api/v2_1/viewpoints/selection_representer.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative 'base_representer'
+require_relative "base_representer"
module Bim::Bcf::API::V2_1::Viewpoints
class SelectionRepresenter < BaseRepresenter
diff --git a/modules/bim/app/representers/bim/bcf/api/v2_1/viewpoints/single_representer.rb b/modules/bim/app/representers/bim/bcf/api/v2_1/viewpoints/single_representer.rb
index b47a50ce02b1..a0da415c2501 100644
--- a/modules/bim/app/representers/bim/bcf/api/v2_1/viewpoints/single_representer.rb
+++ b/modules/bim/app/representers/bim/bcf/api/v2_1/viewpoints/single_representer.rb
@@ -45,7 +45,7 @@ class Viewpoints::SingleRepresenter < BaseRepresenter
property :clipping_planes
def to_json(*)
- represented.read_attribute_before_type_cast('json_viewpoint')
+ represented.read_attribute_before_type_cast("json_viewpoint")
end
end
end
diff --git a/modules/bim/app/representers/bim/bcf/api/v2_1/viewpoints/visibility_representer.rb b/modules/bim/app/representers/bim/bcf/api/v2_1/viewpoints/visibility_representer.rb
index 35d89e0ff988..fe21e47760e4 100644
--- a/modules/bim/app/representers/bim/bcf/api/v2_1/viewpoints/visibility_representer.rb
+++ b/modules/bim/app/representers/bim/bcf/api/v2_1/viewpoints/visibility_representer.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative 'base_representer'
+require_relative "base_representer"
module Bim::Bcf::API::V2_1::Viewpoints
class VisibilityRepresenter < BaseRepresenter
diff --git a/modules/bim/app/seeders/bim/basic_data/setting_seeder.rb b/modules/bim/app/seeders/bim/basic_data/setting_seeder.rb
index fe8b80117e5f..618e87bbaa6d 100644
--- a/modules/bim/app/seeders/bim/basic_data/setting_seeder.rb
+++ b/modules/bim/app/seeders/bim/basic_data/setting_seeder.rb
@@ -30,11 +30,11 @@ module BasicData
class SettingSeeder < ::BasicData::SettingSeeder
def data
super.tap do |original_data|
- unless original_data['default_projects_modules'].include? 'bim'
- original_data['default_projects_modules'] << 'bim'
+ unless original_data["default_projects_modules"].include? "bim"
+ original_data["default_projects_modules"] << "bim"
end
- original_data['attachment_max_size'] = 512 * 1024 # 512MB
+ original_data["attachment_max_size"] = 512 * 1024 # 512MB
end
end
end
diff --git a/modules/bim/app/seeders/bim/demo_data/bcf_xml_seeder.rb b/modules/bim/app/seeders/bim/demo_data/bcf_xml_seeder.rb
index 038cfbaae20c..66762a3fbf5d 100644
--- a/modules/bim/app/seeders/bim/demo_data/bcf_xml_seeder.rb
+++ b/modules/bim/app/seeders/bim/demo_data/bcf_xml_seeder.rb
@@ -37,18 +37,18 @@ def initialize(project, project_data)
end
def seed_data!
- filename = project_data.lookup('bcf_xml_file')
+ filename = project_data.lookup("bcf_xml_file")
return if filename.blank?
- print_status ' ↳ Import BCF XML file'
+ print_status " ↳ Import BCF XML file"
import_options = {
- invalid_people_action: 'anonymize',
- unknown_mails_action: 'anonymize',
- non_members_action: 'anonymize'
+ invalid_people_action: "anonymize",
+ unknown_mails_action: "anonymize",
+ non_members_action: "anonymize"
}
- bcf_xml_file = Rails.root.join('modules/bim/files', filename).to_s
+ bcf_xml_file = Rails.root.join("modules/bim/files", filename).to_s
importer = ::OpenProject::Bim::BcfXml::Importer.new(bcf_xml_file, project, current_user: admin_user)
importer.import!(import_options).flatten
end
diff --git a/modules/bim/app/seeders/bim/demo_data/ifc_model_seeder.rb b/modules/bim/app/seeders/bim/demo_data/ifc_model_seeder.rb
index b1170c000453..70edf450fdb6 100644
--- a/modules/bim/app/seeders/bim/demo_data/ifc_model_seeder.rb
+++ b/modules/bim/app/seeders/bim/demo_data/ifc_model_seeder.rb
@@ -37,10 +37,10 @@ def initialize(project, project_data)
end
def seed_data!
- models = project_data.lookup('ifc_models')
+ models = project_data.lookup("ifc_models")
return if models.blank?
- print_status ' ↳ Import IFC Models'
+ print_status " ↳ Import IFC Models"
models.each do |model|
seed_model model
@@ -50,7 +50,7 @@ def seed_data!
private
def seed_model(model)
- xkt_data = get_xkt_file(model['file'])
+ xkt_data = get_xkt_file(model["file"])
if xkt_data.nil?
print_status "\n ↳ Missing converted data for ifc model"
@@ -60,9 +60,9 @@ def seed_model(model)
end
def create_model(model, user, xkt_data)
- model_container = create_model_container project, user, model['name'], model['default']
+ model_container = create_model_container project, user, model["name"], model["default"]
- add_ifc_model_attachment model_container, user, xkt_data, 'xkt'
+ add_ifc_model_attachment model_container, user, xkt_data, "xkt"
end
def create_model_container(project, user, title, default)
@@ -87,7 +87,7 @@ def add_ifc_model_attachment(model_container, user, file, description)
end
def get_xkt_file(name)
- xkt_path = OpenProject::Bim::Engine.root.join('files/ifc_models', name, "#{name}.xkt")
+ xkt_path = OpenProject::Bim::Engine.root.join("files/ifc_models", name, "#{name}.xkt")
return unless xkt_path.exist?
File.new(xkt_path)
diff --git a/modules/bim/app/services/bim/bcf/issues/transform_attributes_service.rb b/modules/bim/app/services/bim/bcf/issues/transform_attributes_service.rb
index a3b771a4e5ea..c4c398317a2a 100644
--- a/modules/bim/app/services/bim/bcf/issues/transform_attributes_service.rb
+++ b/modules/bim/app/services/bim/bcf/issues/transform_attributes_service.rb
@@ -47,7 +47,7 @@ def title(attributes)
if attributes[:title]
attributes[:title]
elsif attributes[:import_options]
- '(Imported BCF issue contained no title)'
+ "(Imported BCF issue contained no title)"
end
end
@@ -121,9 +121,9 @@ def work_package_attributes(attributes)
end
def missing_status(status_name, import_options)
- if import_options[:unknown_statuses_action] == 'use_default'
+ if import_options[:unknown_statuses_action] == "use_default"
::Status.default
- elsif import_options[:unknown_statuses_action] == 'chose' &&
+ elsif import_options[:unknown_statuses_action] == "chose" &&
import_options[:unknown_statuses_chose_ids].any?
::Status.find_by(id: import_options[:unknown_statuses_chose_ids].first)
elsif status_name
@@ -132,9 +132,9 @@ def missing_status(status_name, import_options)
end
def missing_priority(priority_name, import_options)
- if import_options[:unknown_priorities_action] == 'use_default'
+ if import_options[:unknown_priorities_action] == "use_default"
# NOP The 'use_default' case gets already covered by OP.
- elsif import_options[:unknown_priorities_action] == 'chose' &&
+ elsif import_options[:unknown_priorities_action] == "chose" &&
import_options[:unknown_priorities_chose_ids].any?
::IssuePriority.find_by(id: import_options[:unknown_priorities_chose_ids].first)
elsif priority_name
@@ -145,9 +145,9 @@ def missing_priority(priority_name, import_options)
def missing_type(type_name, import_options)
types = project.types
- if import_options[:unknown_types_action] == 'use_default'
+ if import_options[:unknown_types_action] == "use_default"
types.default&.first
- elsif import_options[:unknown_types_action] == 'chose' &&
+ elsif import_options[:unknown_types_action] == "chose" &&
import_options[:unknown_types_chose_ids].any?
types.find_by(id: import_options[:unknown_types_chose_ids].first)
elsif type_name
@@ -156,7 +156,7 @@ def missing_type(type_name, import_options)
end
def missing_assignee(assignee_name, import_options)
- if import_options[:invalid_people_action] != 'anonymize' && assignee_name
+ if import_options[:invalid_people_action] != "anonymize" && assignee_name
Users::InexistentUser.new
end
end
diff --git a/modules/bim/app/services/bim/bcf/viewpoints/create_service.rb b/modules/bim/app/services/bim/bcf/viewpoints/create_service.rb
index dac14ab483e0..60691267cf72 100644
--- a/modules/bim/app/services/bim/bcf/viewpoints/create_service.rb
+++ b/modules/bim/app/services/bim/bcf/viewpoints/create_service.rb
@@ -33,7 +33,7 @@ class CreateService < ::BaseServices::Create
def persist(service_result)
# snapshot base64 data must not get stored
- service_result.result.json_viewpoint['snapshot']&.delete('snapshot_data')
+ service_result.result.json_viewpoint["snapshot"]&.delete("snapshot_data")
super(service_result)
end
diff --git a/modules/bim/app/services/bim/bcf/viewpoints/set_attributes_service.rb b/modules/bim/app/services/bim/bcf/viewpoints/set_attributes_service.rb
index 90e7d4676f2f..5f0ab9d8d7be 100644
--- a/modules/bim/app/services/bim/bcf/viewpoints/set_attributes_service.rb
+++ b/modules/bim/app/services/bim/bcf/viewpoints/set_attributes_service.rb
@@ -38,7 +38,7 @@ def set_attributes(params)
end
def set_default_attributes(_params)
- viewpoint['guid'] = model.uuid
+ viewpoint["guid"] = model.uuid
end
def set_snapshot
@@ -60,7 +60,7 @@ def set_snapshot
end
def snapshot_data_complete?
- viewpoint['snapshot'] &&
+ viewpoint["snapshot"] &&
snapshot_extension &&
snapshot_base64 &&
snapshot_url_parts.length > 1
@@ -70,22 +70,22 @@ def snapshot_content_type
# Return nil when the extension is not within the specified set
# which will lead to the snapshot not being created.
# The contract will catch the error.
- return unless viewpoint['snapshot']
+ return unless viewpoint["snapshot"]
- case viewpoint['snapshot']['snapshot_type']
- when 'png'
- 'image/png'
- when 'jpg'
- 'image/jpeg'
+ case viewpoint["snapshot"]["snapshot_type"]
+ when "png"
+ "image/png"
+ when "jpg"
+ "image/jpeg"
end
end
def snapshot_extension
- viewpoint['snapshot']['snapshot_type']
+ viewpoint["snapshot"]["snapshot_type"]
end
def snapshot_base64
- viewpoint['snapshot']['snapshot_data']
+ viewpoint["snapshot"]["snapshot_data"]
end
def snapshot_binary_contents
diff --git a/modules/bim/app/services/bim/ifc_models/set_attributes_service.rb b/modules/bim/app/services/bim/ifc_models/set_attributes_service.rb
index 4fdf325d0f52..a5e4b3cbe03e 100644
--- a/modules/bim/app/services/bim/ifc_models/set_attributes_service.rb
+++ b/modules/bim/app/services/bim/ifc_models/set_attributes_service.rb
@@ -60,7 +60,7 @@ def validate_and_result
end
def set_title
- model.title ||= model.ifc_attachment&.file&.filename&.gsub(/\.\w+$/, '')
+ model.title ||= model.ifc_attachment&.file&.filename&.gsub(/\.\w+$/, "")
end
def set_ifc_attachment(ifc_attachment)
@@ -76,7 +76,7 @@ def set_ifc_attachment(ifc_attachment)
else
::Attachments::BuildService
.bypass_whitelist(user:)
- .call(file: ifc_attachment, container: model, filename: ifc_attachment.original_filename, description: 'ifc')
+ .call(file: ifc_attachment, container: model, filename: ifc_attachment.original_filename, description: "ifc")
end
end
end
diff --git a/modules/bim/app/services/bim/ifc_models/view_converter_service.rb b/modules/bim/app/services/bim/ifc_models/view_converter_service.rb
index a632ac0ce093..91befa11aa20 100644
--- a/modules/bim/app/services/bim/ifc_models/view_converter_service.rb
+++ b/modules/bim/app/services/bim/ifc_models/view_converter_service.rb
@@ -25,7 +25,7 @@
#
# See COPYRIGHT and LICENSE files for more details.
# +
-require 'open3'
+require "open3"
module Bim
module IfcModels
@@ -47,7 +47,7 @@ def self.available?
def self.available_commands
@available_commands ||= PIPELINE_COMMANDS.select do |command|
- _, status = Open3.capture2e('which', command)
+ _, status = Open3.capture2e("which", command)
status.exitstatus.zero?
end
end
@@ -125,23 +125,23 @@ def save_xkt(xkt_path)
def convert_to_collada(ifc_filepath)
Rails.logger.debug { "Converting #{ifc_model.inspect} to DAE" }
- convert!(ifc_filepath, 'dae') do |target_file|
+ convert!(ifc_filepath, "dae") do |target_file|
# To include IfcSpace entities, which by default are excluded by
# IfcConvert, together with IfcOpeningElement, we need to over-
# write the default exclude parameter to only exclude
# IfcOpeningElements.
# https://github.com/IfcOpenShell/IfcOpenShell/wiki#ifconvert
- Open3.capture2e('IfcConvert',
- '--use-element-guids',
- '--no-progress',
- '--verbose',
- '--threads',
- '4',
+ Open3.capture2e("IfcConvert",
+ "--use-element-guids",
+ "--no-progress",
+ "--verbose",
+ "--threads",
+ "4",
ifc_filepath,
target_file,
- '--exclude',
- 'entities',
- 'IfcOpeningElement')
+ "--exclude",
+ "entities",
+ "IfcOpeningElement")
end
end
@@ -152,8 +152,8 @@ def convert_to_collada(ifc_filepath)
def convert_to_gltf(dae_filepath)
Rails.logger.debug { "Converting #{ifc_model.inspect} to GLTF" }
- convert!(dae_filepath, 'gltf') do |target_file|
- Open3.capture2e('COLLADA2GLTF', '--materialsCommon', '-i', dae_filepath, '-o', target_file)
+ convert!(dae_filepath, "gltf") do |target_file|
+ Open3.capture2e("COLLADA2GLTF", "--materialsCommon", "-i", dae_filepath, "-o", target_file)
end
end
@@ -166,8 +166,8 @@ def convert_to_xkt(gltf_filepath)
metadata_file = convert_metadata(link_to_ifc_file)
- convert!(gltf_filepath, 'xkt') do |target_file|
- Open3.capture2e('gltf2xkt', '-s', gltf_filepath, '-m', metadata_file, '-o', target_file)
+ convert!(gltf_filepath, "xkt") do |target_file|
+ Open3.capture2e("gltf2xkt", "-s", gltf_filepath, "-m", metadata_file, "-o", target_file)
end
end
@@ -178,8 +178,8 @@ def convert_to_xkt(gltf_filepath)
def convert_metadata(ifc_filepath)
Rails.logger.debug { "Retrieving metadata of #{ifc_model.inspect}" }
- convert!(ifc_filepath, 'json') do |target_file|
- Open3.capture2e('xeokit-metadata', ifc_filepath, target_file)
+ convert!(ifc_filepath, "json") do |target_file|
+ Open3.capture2e("xeokit-metadata", ifc_filepath, target_file)
end
end
@@ -188,7 +188,7 @@ def convert_metadata(ifc_filepath)
def convert!(source_file, ext)
raise ArgumentError, "missing working directory" unless working_directory.present?
- filename = File.basename(source_file, '.*')
+ filename = File.basename(source_file, ".*")
target_filename = "#{filename}.#{ext}"
target_file = File.join(working_directory, target_filename)
@@ -204,7 +204,7 @@ def convert!(source_file, ext)
def validate!
unless self.class.available?
missing = PIPELINE_COMMANDS - self.class.available_commands
- raise I18n.t('ifc_models.conversion.missing_commands', names: missing.join(", "))
+ raise I18n.t("ifc_models.conversion.missing_commands", names: missing.join(", "))
end
true
diff --git a/modules/bim/config/routes.rb b/modules/bim/config/routes.rb
index be8a4a4b0639..3cffff4a3596 100644
--- a/modules/bim/config/routes.rb
+++ b/modules/bim/config/routes.rb
@@ -27,11 +27,11 @@
#++
Rails.application.routes.draw do
- scope '', as: 'bcf' do
- mount Bim::Bcf::API::Root => '/api/bcf'
+ scope "", as: "bcf" do
+ mount Bim::Bcf::API::Root => "/api/bcf"
- scope 'projects/:project_id', as: 'project' do
- resources :issues, controller: 'bim/bcf/issues' do
+ scope "projects/:project_id", as: "project" do
+ resources :issues, controller: "bim/bcf/issues" do
get :upload, action: :upload, on: :collection
post :prepare_import, action: :prepare_import, on: :collection
post :configure_import, action: :configure_import, on: :collection
@@ -39,10 +39,10 @@
end
# IFC viewer frontend
- get 'bcf(/*state)', to: 'bim/ifc_models/ifc_viewer#show', as: :frontend
+ get "bcf(/*state)", to: "bim/ifc_models/ifc_viewer#show", as: :frontend
# IFC model management
- resources :ifc_models, controller: 'bim/ifc_models/ifc_models' do
+ resources :ifc_models, controller: "bim/ifc_models/ifc_models" do
collection do
get :defaults
get :direct_upload_finished
diff --git a/modules/bim/db/migrate/20201105154216_seed_custom_style_with_bim_theme.rb b/modules/bim/db/migrate/20201105154216_seed_custom_style_with_bim_theme.rb
index a116bee6acb4..ec93d9fa1e10 100644
--- a/modules/bim/db/migrate/20201105154216_seed_custom_style_with_bim_theme.rb
+++ b/modules/bim/db/migrate/20201105154216_seed_custom_style_with_bim_theme.rb
@@ -80,19 +80,19 @@ def set_custom_style
def theme
{
- theme: 'OpenProject BIM',
+ theme: "OpenProject BIM",
colors: {
- 'primary-color' => "#3270DB",
- 'primary-color-dark' => "#163473",
- 'alternative-color' => "#349939",
- 'header-bg-color' => "#05002C",
- 'header-item-bg-hover-color' => "#163473",
- 'content-link-color' => "#275BB5",
- 'main-menu-bg-color' => "#0E2045",
- 'main-menu-bg-selected-background' => "#3270DB",
- 'main-menu-bg-hover-background' => "#163473"
+ "primary-color" => "#3270DB",
+ "primary-color-dark" => "#163473",
+ "alternative-color" => "#349939",
+ "header-bg-color" => "#05002C",
+ "header-item-bg-hover-color" => "#163473",
+ "content-link-color" => "#275BB5",
+ "main-menu-bg-color" => "#0E2045",
+ "main-menu-bg-selected-background" => "#3270DB",
+ "main-menu-bg-hover-background" => "#163473"
},
- logo: 'bim/logo_openproject_bim_big.png'
+ logo: "bim/logo_openproject_bim_big.png"
}
end
end
diff --git a/modules/bim/db/migrate/20210521080035_update_xkt_to_version8.rb b/modules/bim/db/migrate/20210521080035_update_xkt_to_version8.rb
index e50e27833862..29fc86feac4e 100644
--- a/modules/bim/db/migrate/20210521080035_update_xkt_to_version8.rb
+++ b/modules/bim/db/migrate/20210521080035_update_xkt_to_version8.rb
@@ -27,17 +27,17 @@
#++
class UpdateXktToVersion8 < ActiveRecord::Migration[6.1]
- SEEDED_MODEL_DATA = { 'Hospital - Architecture (cc-by-sa-3.0 Autodesk Inc.)' => 'hospital_architecture',
- 'Hospital - Structural (cc-by-sa-3.0 Autodesk Inc.)' => 'hospital_structural',
- 'Hospital - Mechanical (cc-by-sa-3.0 Autodesk Inc.)' => 'hospital_mechanical' }.freeze
+ SEEDED_MODEL_DATA = { "Hospital - Architecture (cc-by-sa-3.0 Autodesk Inc.)" => "hospital_architecture",
+ "Hospital - Structural (cc-by-sa-3.0 Autodesk Inc.)" => "hospital_structural",
+ "Hospital - Mechanical (cc-by-sa-3.0 Autodesk Inc.)" => "hospital_mechanical" }.freeze
# Note: rails 7.1 breaks the class' ancestor chain, and raises an error, when a class
# with an enum definition without a database field is being referenced.
# Re-defining the IfcModel class without the enum to avoid the issue.
class IfcModel < ApplicationRecord
- has_many :attachments, -> { where(container_type: 'Bim::IfcModels::IfcModel') },
+ has_many :attachments, -> { where(container_type: "Bim::IfcModels::IfcModel") },
foreign_key: :container_id,
- class_name: 'Attachment'
+ class_name: "Attachment"
end
def up
@@ -72,18 +72,18 @@ def migrate_all_ifc_models
cleanup_metadata_attachment(ifc_model)
# We have seeded models that do not have an IFC attachment. They cannot get converted as an IFC file is
# necessary.
- next if ifc_model.attachments.find_by(description: 'ifc').nil?
+ next if ifc_model.attachments.find_by(description: "ifc").nil?
::Bim::IfcModels::IfcConversionJob.perform_later(ifc_model)
end
end
def cleanup_metadata_attachment(ifc_model)
- ifc_model.attachments.find_by(description: 'metadata')&.destroy
+ ifc_model.attachments.find_by(description: "metadata")&.destroy
end
def update_demo_xkt_models
- project = Project.find_by(identifier: 'demo-bcf-management-project')
+ project = Project.find_by(identifier: "demo-bcf-management-project")
return unless project
ifc_models = project.ifc_models.joins(:attachments)
diff --git a/modules/bim/db/migrate/20211011204301_add_column_conversion_status_to_ifc_model.rb b/modules/bim/db/migrate/20211011204301_add_column_conversion_status_to_ifc_model.rb
index afe00f07d9aa..8a57d7d4b1a2 100644
--- a/modules/bim/db/migrate/20211011204301_add_column_conversion_status_to_ifc_model.rb
+++ b/modules/bim/db/migrate/20211011204301_add_column_conversion_status_to_ifc_model.rb
@@ -28,16 +28,16 @@
class AddColumnConversionStatusToIfcModel < ActiveRecord::Migration[6.1]
class MigrationAttachment < ApplicationRecord
- self.table_name = 'attachments'
+ self.table_name = "attachments"
end
# Note: rails 7.1 breaks the class' ancestor chain, and raises an error, when a class
# with an enum definition without a database field is being referenced.
# Re-defining the IfcModel class without the enum to avoid the issue.
class IfcModel < ApplicationRecord
- has_many :attachments, -> { where(container_type: 'Bim::IfcModels::IfcModel') },
+ has_many :attachments, -> { where(container_type: "Bim::IfcModels::IfcModel") },
foreign_key: :container_id,
- class_name: 'MigrationAttachment'
+ class_name: "MigrationAttachment"
end
def up
diff --git a/modules/bim/lib/api/bim/bcf_xml/v1/bcf_xml_api.rb b/modules/bim/lib/api/bim/bcf_xml/v1/bcf_xml_api.rb
index 3da1b9920e15..3607a8be5578 100644
--- a/modules/bim/lib/api/bim/bcf_xml/v1/bcf_xml_api.rb
+++ b/modules/bim/lib/api/bim/bcf_xml/v1/bcf_xml_api.rb
@@ -35,7 +35,7 @@ class BcfXmlAPI < ::API::OpenProjectAPI
resources :projects do
route_param :id do
- namespace 'bcf_xml' do
+ namespace "bcf_xml" do
helpers do
# Global helper to set allowed content_types
# This may be overridden when multipart is allowed (file uploads)
@@ -48,7 +48,7 @@ def allowed_content_types
end
def post_request?
- request.env['REQUEST_METHOD'] == 'POST'
+ request.env["REQUEST_METHOD"] == "POST"
end
def import_options
@@ -71,8 +71,8 @@ def find_project
updated_query = ::API::V3::UpdateQueryFromV3ParamsService.new(query, User.current).call(params)
exporter = ::OpenProject::Bim::BcfXml::Exporter.new(updated_query.result)
- header['Content-Disposition'] = "attachment; filename=\"#{exporter.bcf_filename}\""
- env['api.format'] = :binary
+ header["Content-Disposition"] = "attachment; filename=\"#{exporter.bcf_filename}\""
+ env["api.format"] = :binary
exporter.export!.content.read
end
@@ -90,7 +90,7 @@ def find_project
current_user: User.current)
unless importer.bcf_version_valid?
- error_message = I18n.t('bcf.bcf_xml.import_failed_unsupported_bcf_version',
+ error_message = I18n.t("bcf.bcf_xml.import_failed_unsupported_bcf_version",
minimal_version: OpenProject::Bim::BcfXml::Importer::MINIMUM_BCF_VERSION)
raise API::Errors::UnsupportedMediaType.new(error_message)
diff --git a/modules/bim/lib/open_project/bim/bcf_json/viewpoint_reader.rb b/modules/bim/lib/open_project/bim/bcf_json/viewpoint_reader.rb
index 36e7240f16f4..241ee594ef1d 100644
--- a/modules/bim/lib/open_project/bim/bcf_json/viewpoint_reader.rb
+++ b/modules/bim/lib/open_project/bim/bcf_json/viewpoint_reader.rb
@@ -1,11 +1,11 @@
# frozen_string_literal: true
-require 'bigdecimal'
+require "bigdecimal"
module OpenProject::Bim
module BcfJson
class ViewpointReader
- ROOT_NODE ||= 'VisualizationInfo'
+ ROOT_NODE ||= "VisualizationInfo"
attr_reader :uuid, :xml
@@ -57,13 +57,13 @@ def transformations
end
def remove_keys(hash)
- hash.delete 'xmlns:xsi'
- hash.delete 'xmlns:xsd'
- hash.delete 'VisualizationInfo' unless hash['VisualizationInfo']
+ hash.delete "xmlns:xsi"
+ hash.delete "xmlns:xsd"
+ hash.delete "VisualizationInfo" unless hash["VisualizationInfo"]
end
def set_uuid(hash)
- hash['guid'] = uuid
+ hash["guid"] = uuid
end
def transform_keys(hash)
@@ -74,13 +74,13 @@ def transform_keys(hash)
##
# Transform perspective_camera into json float values
def transform_orthogonal_camera(hash)
- transform_camera hash, 'orthogonal_camera'
+ transform_camera hash, "orthogonal_camera"
end
##
# Transform orthogonal_camera into json float values
def transform_perspective_camera(hash)
- transform_camera hash, 'perspective_camera'
+ transform_camera hash, "perspective_camera"
end
def transform_camera(hash, key)
@@ -96,33 +96,33 @@ def transform_camera(hash, key)
end
def transform_lines(hash)
- return unless hash['lines']
+ return unless hash["lines"]
- hash['lines'] = [hash['lines']['line']].flatten(1).map! do |line|
+ hash["lines"] = [hash["lines"]["line"]].flatten(1).map! do |line|
line.deep_transform_values! { |val| to_numeric(val) }
end
end
def transform_clipping_planes(hash)
- return unless hash['clipping_planes']
+ return unless hash["clipping_planes"]
- hash['clipping_planes'] = [hash['clipping_planes']['clipping_plane']].flatten(1).map! do |plane|
+ hash["clipping_planes"] = [hash["clipping_planes"]["clipping_plane"]].flatten(1).map! do |plane|
plane.deep_transform_values! { |val| to_numeric(val) }
end
end
def transform_bitmaps(hash)
- return unless hash['bitmaps']
+ return unless hash["bitmaps"]
# Bitmaps can be multiple items within the root bitmaps node
# this is different from the other entries
# https://github.com/buildingSMART/BCF-XML/pull/44/files
- bitmaps = Array.wrap(hash['bitmaps'])
+ bitmaps = Array.wrap(hash["bitmaps"])
- hash['bitmaps'] = bitmaps.map! do |bitmap|
- bitmap['bitmap_type'] = bitmap.delete('bitmap').downcase
- bitmap['bitmap_data'] = bitmap.delete('reference')
- bitmap['height'] = to_numeric(bitmap['height'])
+ hash["bitmaps"] = bitmaps.map! do |bitmap|
+ bitmap["bitmap_type"] = bitmap.delete("bitmap").downcase
+ bitmap["bitmap_data"] = bitmap.delete("reference")
+ bitmap["height"] = to_numeric(bitmap["height"])
%w[location normal up].each do |key|
next unless bitmap.key?(key)
@@ -138,50 +138,50 @@ def transform_bitmaps(hash)
##
# Move selections up the tree from the nested XML node
def transform_selections(hash)
- return unless (selections = hash.dig('components', 'selection', 'component'))
+ return unless (selections = hash.dig("components", "selection", "component"))
# Ensure selections are an array
selections = Array.wrap(selections)
# Skip any components that have no guid
- selections.select! { |item| item['ifc_guid'] }
+ selections.select! { |item| item["ifc_guid"] }
- hash['components']['selection'] = selections
+ hash["components"]["selection"] = selections
end
##
# Move coloring up the tree from the nested XML node
def transform_coloring(hash)
- return unless (colors = hash.dig('components', 'coloring', 'color'))
+ return unless (colors = hash.dig("components", "coloring", "color"))
# avoid Array(colors) since that deconstructs the array
colors = Array.wrap(colors)
- hash['components']['coloring'] = colors.map do |entry|
+ hash["components"]["coloring"] = colors.map do |entry|
# Prepend hash for hex color
- entry['color'] = "##{entry['color']}"
+ entry["color"] = "##{entry['color']}"
# Fix items name
- entry['components'] = Array.wrap(entry.delete('component'))
+ entry["components"] = Array.wrap(entry.delete("component"))
entry
end
end
def transform_visibility(hash)
- return unless (visibility = hash.dig('components', 'visibility'))
+ return unless (visibility = hash.dig("components", "visibility"))
- visibility['default_visibility'] = visibility['default_visibility'] == 'true'
+ visibility["default_visibility"] = visibility["default_visibility"] == "true"
# Hoist exceptions components up from the nested XML node
- exceptions = visibility.dig('exceptions', 'component')
- visibility['exceptions'] = Array.wrap(exceptions) if exceptions
+ exceptions = visibility.dig("exceptions", "component")
+ visibility["exceptions"] = Array.wrap(exceptions) if exceptions
# Move view_setup_hints
- view_setup_hints = hash.dig('components', 'view_setup_hints')
- visibility['view_setup_hints'] = view_setup_hints.transform_values { |val| val == 'true' } if view_setup_hints
+ view_setup_hints = hash.dig("components", "view_setup_hints")
+ visibility["view_setup_hints"] = view_setup_hints.transform_values { |val| val == "true" } if view_setup_hints
# Remove the old node
- hash['components'].delete('view_setup_hints')
+ hash["components"].delete("view_setup_hints")
end
def to_numeric(anything)
diff --git a/modules/bim/lib/open_project/bim/bcf_xml.rb b/modules/bim/lib/open_project/bim/bcf_xml.rb
index 2819f10f9fa3..c6348b9fedc6 100644
--- a/modules/bim/lib/open_project/bim/bcf_xml.rb
+++ b/modules/bim/lib/open_project/bim/bcf_xml.rb
@@ -1,5 +1,5 @@
module OpenProject::Bim
module Bcf
- require_relative 'bcf_xml/importer'
+ require_relative "bcf_xml/importer"
end
end
diff --git a/modules/bim/lib/open_project/bim/bcf_xml/base_writer.rb b/modules/bim/lib/open_project/bim/bcf_xml/base_writer.rb
index 5886370087d3..3bdb912969c4 100644
--- a/modules/bim/lib/open_project/bim/bcf_xml/base_writer.rb
+++ b/modules/bim/lib/open_project/bim/bcf_xml/base_writer.rb
@@ -22,7 +22,7 @@ def root_node_attributes
# Initial markup file as basic BCF compliant xml
def build_markup_document
Nokogiri::XML::Builder
- .new(encoding: 'UTF-8') do |xml|
+ .new(encoding: "UTF-8") do |xml|
xml.comment created_by_comment
xml.send(root_node,
"xmlns:xsi" => "http://www.w3.org/2001/XMLSchema-instance",
diff --git a/modules/bim/lib/open_project/bim/bcf_xml/exporter.rb b/modules/bim/lib/open_project/bim/bcf_xml/exporter.rb
index b0693a94e914..661e24a7b370 100644
--- a/modules/bim/lib/open_project/bim/bcf_xml/exporter.rb
+++ b/modules/bim/lib/open_project/bim/bcf_xml/exporter.rb
@@ -1,9 +1,9 @@
-require 'fileutils'
+require "fileutils"
module OpenProject::Bim::BcfXml
class Exporter < ::WorkPackage::Exports::QueryExporter
def initialize(object, options = {})
- object.add_filter('bcf_issue_associated', '=', ['t'])
+ object.add_filter("bcf_issue_associated", "=", ["t"])
super(object, options)
end
@@ -31,13 +31,13 @@ def success(zip)
.new format: :xls,
content: zip,
title: bcf_filename,
- mime_type: 'application/octet-stream'
+ mime_type: "application/octet-stream"
end
def bcf_filename
# We often have an internal query name that is not meant
# for public use or was given by a user.
- if query.name.present? && query.name != '_'
+ if query.name.present? && query.name != "_"
return sane_filename("#{query.name}.bcf")
end
@@ -104,7 +104,7 @@ def topic_folder_for(dir, issue)
##
# Write each work package BCF
def topic_markup_file(issue_dir, issue)
- File.join(issue_dir, 'markup.bcf').tap do |file|
+ File.join(issue_dir, "markup.bcf").tap do |file|
dump_file file, issue.markup
end
end
diff --git a/modules/bim/lib/open_project/bim/bcf_xml/importer.rb b/modules/bim/lib/open_project/bim/bcf_xml/importer.rb
index 14048ace0f42..494eb60dec74 100644
--- a/modules/bim/lib/open_project/bim/bcf_xml/importer.rb
+++ b/modules/bim/lib/open_project/bim/bcf_xml/importer.rb
@@ -1,6 +1,6 @@
-require 'activerecord-import'
-require_relative 'issue_reader'
-require_relative 'aggregations'
+require "activerecord-import"
+require_relative "issue_reader"
+require_relative "aggregations"
module OpenProject::Bim::BcfXml
class Importer
@@ -12,8 +12,8 @@ class Importer
unknown_statuses_action: "use_default",
unknown_priorities_action: "use_default",
invalid_people_action: "anonymize",
- unknown_mails_action: 'invite',
- non_members_action: 'chose',
+ unknown_mails_action: "invite",
+ non_members_action: "chose",
unknown_types_chose_ids: [],
unknown_statuses_chose_ids: [],
unknown_priorities_chose_ids: [],
@@ -51,10 +51,10 @@ def aggregations
def bcf_version_valid?
Zip::File.open(@file) do |zip|
- zip_entry = zip.find { |entry| entry.name.end_with?('bcf.version') }
+ zip_entry = zip.find { |entry| entry.name.end_with?("bcf.version") }
markup = zip_entry.get_input_stream.read
- doc = Nokogiri::XML(markup, nil, 'UTF-8')
- bcf_version = doc.xpath('/Version').first['VersionId']
+ doc = Nokogiri::XML(markup, nil, "UTF-8")
+ bcf_version = doc.xpath("/Version").first["VersionId"]
return Gem::Version.new(bcf_version) >= Gem::Version.new(MINIMUM_BCF_VERSION)
end
rescue StandardError => _e
@@ -89,8 +89,8 @@ def create_or_add_missing_members(options)
end
def treat_invalid_people(options)
- if aggregations.invalid_people.any? && !(options[:invalid_people_action] == 'anonymize')
- raise StandardError.new 'Invalid people found in import. Use valid email addresses.'
+ if aggregations.invalid_people.any? && !(options[:invalid_people_action] == "anonymize")
+ raise StandardError.new "Invalid people found in import. Use valid email addresses."
end
end
@@ -98,8 +98,8 @@ def treat_invalid_people(options)
# Invite all unknown email addresses and add them
def treat_unknown_mails(options)
if treat_unknown_mails?(options)
- raise StandardError.new 'For inviting new users you need admin privileges.' unless User.current.admin?
- raise StandardError.new 'Enterprise Edition user limit reached.' unless enterprise_allow_new_users?
+ raise StandardError.new "For inviting new users you need admin privileges." unless User.current.admin?
+ raise StandardError.new "Enterprise Edition user limit reached." unless enterprise_allow_new_users?
aggregations.unknown_mails.each do |mail|
add_unknown_mail(mail, options)
@@ -114,7 +114,7 @@ def treat_non_members(options)
if treat_non_members?(options)
unless User.current.allowed_in_project?(:manage_members, project)
- raise StandardError.new 'For adding members to the project you need admin privileges.'
+ raise StandardError.new "For adding members to the project you need admin privileges."
end
aggregations.non_members.each do |user|
@@ -144,13 +144,13 @@ def add_non_member(user, options)
def treat_unknown_mails?(options)
aggregations.unknown_mails.any? &&
- options[:unknown_mails_action] == 'invite' &&
+ options[:unknown_mails_action] == "invite" &&
options[:unknown_mails_invite_role_ids].any?
end
def treat_non_members?(options)
aggregations.non_members.any? &&
- options[:non_members_action] == 'chose' &&
+ options[:non_members_action] == "chose" &&
options[:non_members_chose_role_ids].any?
end
@@ -186,7 +186,7 @@ def synchronize_topics(zip, import_options)
# Yields topic bcf files (that contain topic entries and their uuid) from the ZIP files
# while skipping all other entries
def yield_markup_bcf_files(zip)
- zip.select { |entry| entry.name.end_with?('markup.bcf') }
+ zip.select { |entry| entry.name.end_with?("markup.bcf") }
end
def enterprise_allow_new_users?
diff --git a/modules/bim/lib/open_project/bim/bcf_xml/issue_reader.rb b/modules/bim/lib/open_project/bim/bcf_xml/issue_reader.rb
index 2584154a75f6..8e2ddec1ea25 100644
--- a/modules/bim/lib/open_project/bim/bcf_xml/issue_reader.rb
+++ b/modules/bim/lib/open_project/bim/bcf_xml/issue_reader.rb
@@ -2,7 +2,7 @@
# Extracts sections of a BCF markup file
# manually. If we want to extract the entire markup,
# this should be turned into a representable/xml decorator
-require_relative 'file_entry'
+require_relative "file_entry"
module OpenProject::Bim::BcfXml
class IssueReader
@@ -57,7 +57,7 @@ def synchronize_with_work_package
if call.success?
issue.work_package = call.result
- create_wp_comment(user, I18n.t('bcf.bcf_xml.import_update_comment')) if is_update
+ create_wp_comment(user, I18n.t("bcf.bcf_xml.import_update_comment")) if is_update
else
issue.errors.merge!(call.errors)
Rails.logger.error "Failed to synchronize BCF #{issue.uuid} with work package: #{call.errors.full_messages.join('; ')}"
@@ -226,13 +226,13 @@ def initialize_issue
##
# Get the topic name of an entry
def topic_uuid
- entry.name.split('/').first
+ entry.name.split("/").first
end
##
# Get an entry within the uuid
def as_file_entry(filename)
- file_entry = zip.find_entry [topic_uuid, filename].join('/')
+ file_entry = zip.find_entry [topic_uuid, filename].join("/")
if file_entry
FileEntry.new(file_entry.get_input_stream, filename:)
@@ -242,7 +242,7 @@ def as_file_entry(filename)
##
# Read an entry as string
def read_entry(filename)
- file_entry = zip.find_entry [topic_uuid, filename].join('/')
+ file_entry = zip.find_entry [topic_uuid, filename].join("/")
file_entry.get_input_stream.read
end
@@ -317,7 +317,7 @@ def import_is_outdated(issue)
errors = ActiveModel::Errors.new(issue)
errors.add :base,
:conflict,
- message: I18n.t('bcf.bcf_xml.import.work_package_has_newer_changes',
+ message: I18n.t("bcf.bcf_xml.import.work_package_has_newer_changes",
bcf_uuid: issue.uuid)
ServiceResult.failure(errors:)
diff --git a/modules/bim/lib/open_project/bim/bcf_xml/issue_writer.rb b/modules/bim/lib/open_project/bim/bcf_xml/issue_writer.rb
index f29441b67cce..0973e86eb851 100644
--- a/modules/bim/lib/open_project/bim/bcf_xml/issue_writer.rb
+++ b/modules/bim/lib/open_project/bim/bcf_xml/issue_writer.rb
@@ -38,7 +38,7 @@ def initialize(work_package)
super()
# Remember root markup node for easier access
- @markup_node = markup_doc.at_xpath('/Markup')
+ @markup_node = markup_doc.at_xpath("/Markup")
end
def update
@@ -77,7 +77,7 @@ def build_markup_document
##
# Update the topic node, or create it
def topic
- topic_node = fetch(markup_node, 'Topic')
+ topic_node = fetch(markup_node, "Topic")
topic_attributes topic_node
@@ -120,77 +120,77 @@ def prepend_into_or_insert(parent_node, node)
end
def topic_attributes(topic_node)
- topic_node['Guid'] = issue.uuid
- topic_node['TopicType'] = work_package.type.name # TODO: Looks wrong to me. Probably better to use original TopicType?
- topic_node['TopicStatus'] = work_package.status.name
+ topic_node["Guid"] = issue.uuid
+ topic_node["TopicType"] = work_package.type.name # TODO: Looks wrong to me. Probably better to use original TopicType?
+ topic_node["TopicStatus"] = work_package.status.name
end
def topic_title(topic_node)
- target = fetch(topic_node, 'Title')
+ target = fetch(topic_node, "Title")
target.content = work_package.subject
end
def topic_creation_date(topic_node)
- target = fetch(topic_node, 'CreationDate')
+ target = fetch(topic_node, "CreationDate")
target.content = to_bcf_datetime(work_package.created_at)
end
def topic_modified_date(topic_node)
- target = fetch(topic_node, 'ModifiedDate')
+ target = fetch(topic_node, "ModifiedDate")
target.content = to_bcf_datetime(work_package.updated_at)
end
def topic_description(topic_node)
- target = fetch(topic_node, 'Description')
+ target = fetch(topic_node, "Description")
target.content = work_package.description
end
def topic_creation_author(topic_node)
- target = fetch(topic_node, 'CreationAuthor')
+ target = fetch(topic_node, "CreationAuthor")
target.content = work_package.author.mail
end
def topic_reference_link(topic_node)
- target = fetch(topic_node, 'ReferenceLink')
+ target = fetch(topic_node, "ReferenceLink")
target.content = url_helpers.work_package_url(work_package)
end
def topic_priority(topic_node)
if priority = work_package.priority
- target = fetch(topic_node, 'Priority')
+ target = fetch(topic_node, "Priority")
target.content = priority.name
end
end
def topic_assigned_to(topic_node)
if assignee = work_package.assigned_to
- target = fetch(topic_node, 'AssignedTo')
+ target = fetch(topic_node, "AssignedTo")
target.content = assignee.mail
end
end
def topic_modified_author(topic_node)
if journal = work_package.journals.select(:user_id).last
- target = fetch(topic_node, 'ModifiedAuthor')
+ target = fetch(topic_node, "ModifiedAuthor")
target.content = journal.user.mail if journal.user_id
end
end
def topic_due_date(topic_node)
if work_package.due_date
- target = fetch(topic_node, 'DueDate')
+ target = fetch(topic_node, "DueDate")
target.content = to_bcf_date(work_package.due_date.to_datetime)
end
end
def replace_comments
- markup_node.xpath('./Comment').remove
+ markup_node.xpath("./Comment").remove
Nokogiri::XML::Builder.with(markup_node, &method(:comments))
end
def replace_viewpoints
- markup_node.xpath('./Viewpoints').remove
+ markup_node.xpath("./Viewpoints").remove
Nokogiri::XML::Builder.with(markup_node, &method(:viewpoints))
end
diff --git a/modules/bim/lib/open_project/bim/bcf_xml/markup_extractor.rb b/modules/bim/lib/open_project/bim/bcf_xml/markup_extractor.rb
index e3eb14222486..49bbe82c463c 100644
--- a/modules/bim/lib/open_project/bim/bcf_xml/markup_extractor.rb
+++ b/modules/bim/lib/open_project/bim/bcf_xml/markup_extractor.rb
@@ -10,7 +10,7 @@ class MarkupExtractor
def initialize(entry)
@markup = entry.get_input_stream.read
- @doc = Nokogiri::XML markup, nil, 'UTF-8'
+ @doc = Nokogiri::XML markup, nil, "UTF-8"
end
def uuid
@@ -50,36 +50,36 @@ def modified_author
end
def creation_date
- extract_date_time '/Markup/Topic/CreationDate'
+ extract_date_time "/Markup/Topic/CreationDate"
end
def modified_date
- extract_date_time '/Markup/Topic/ModifiedDate'
+ extract_date_time "/Markup/Topic/ModifiedDate"
end
def due_date
- extract_date_time '/Markup/Topic/DueDate'
+ extract_date_time "/Markup/Topic/DueDate"
rescue ArgumentError
nil
end
def viewpoints
- doc.xpath('/Markup/Viewpoints').map do |node|
+ doc.xpath("/Markup/Viewpoints").map do |node|
{
- uuid: node['Guid'],
- viewpoint: extract_from_node('Viewpoint', node),
- snapshot: extract_from_node('Snapshot', node)
+ uuid: node["Guid"],
+ viewpoint: extract_from_node("Viewpoint", node),
+ snapshot: extract_from_node("Snapshot", node)
}.with_indifferent_access
end
end
def comments
- doc.xpath('/Markup/Comment').map do |node|
+ doc.xpath("/Markup/Comment").map do |node|
{
- uuid: node['Guid'],
+ uuid: node["Guid"],
date: extract_date_time("Date", node),
- author: extract_from_node('Author', node),
- comment: extract_from_node('Comment', node),
+ author: extract_from_node("Author", node),
+ comment: extract_from_node("Comment", node),
viewpoint_uuid: comment_viewpoint_uuid(node),
modified_date: extract_date_time("ModifiedDate", node),
modified_author: extract_from_node("ModifiedAuthor", node)
@@ -103,8 +103,8 @@ def people
private
def comment_viewpoint_uuid(node)
- viewpoint_node = node.at('Viewpoint')
- extract_from_node('@Guid', viewpoint_node, attribute: true) if viewpoint_node
+ viewpoint_node = node.at("Viewpoint")
+ extract_from_node("@Guid", viewpoint_node, attribute: true) if viewpoint_node
end
def extract_date_time(path, node = nil)
@@ -113,14 +113,14 @@ def extract_date_time(path, node = nil)
Time.iso8601(date_time) unless date_time.nil?
end
- def extract(path, prefix: '/Markup/Topic/'.freeze, attribute: false)
- path = [prefix, path.to_s].join('')
+ def extract(path, prefix: "/Markup/Topic/".freeze, attribute: false)
+ path = [prefix, path.to_s].join("")
extract_from_node(path, doc, attribute:)
end
def extract_from_node(path, node, attribute: false)
- suffix = attribute ? '' : '/text()'.freeze
- path = [path.to_s, suffix].join('')
+ suffix = attribute ? "" : "/text()".freeze
+ path = [path.to_s, suffix].join("")
node.xpath(path).to_s.presence
end
end
diff --git a/modules/bim/lib/open_project/bim/bcf_xml/viewpoint_writer.rb b/modules/bim/lib/open_project/bim/bcf_xml/viewpoint_writer.rb
index 5b7c4abc963a..993d54ae6cf8 100644
--- a/modules/bim/lib/open_project/bim/bcf_xml/viewpoint_writer.rb
+++ b/modules/bim/lib/open_project/bim/bcf_xml/viewpoint_writer.rb
@@ -20,8 +20,8 @@ def doc
Nokogiri::XML::Builder.with(viewpoint_node) do |xml|
components xml
- camera('orthogonal_camera', xml)
- camera('perspective_camera', xml)
+ camera("orthogonal_camera", xml)
+ camera("perspective_camera", xml)
lines xml
clipping_planes xml
@@ -47,7 +47,7 @@ def dig_json(*)
end
def components(xml)
- return unless dig_json('components')
+ return unless dig_json("components")
xml.Components do
view_setup_hints xml
@@ -58,13 +58,13 @@ def components(xml)
end
def view_setup_hints(xml)
- return unless (setup_hash = dig_json('components', 'visibility', 'view_setup_hints'))
+ return unless (setup_hash = dig_json("components", "visibility", "view_setup_hints"))
xml.ViewSetupHints(camelized(setup_hash))
end
def selected_components(xml)
- return unless (selected = dig_json('components', 'selection'))
+ return unless (selected = dig_json("components", "selection"))
xml.Selection do
selected.each do |comp_hash|
@@ -74,10 +74,10 @@ def selected_components(xml)
end
def visibility(xml)
- return unless (visibility_hash = dig_json 'components', 'visibility')
+ return unless (visibility_hash = dig_json "components", "visibility")
- xml.Visibility(DefaultVisibility: visibility_hash['default_visibility']) do
- exceptions = visibility_hash['exceptions']
+ xml.Visibility(DefaultVisibility: visibility_hash["default_visibility"]) do
+ exceptions = visibility_hash["exceptions"]
next unless exceptions
xml.Exceptions do
@@ -89,12 +89,12 @@ def visibility(xml)
end
def coloring(xml)
- return unless (colors = dig_json 'components', 'coloring')
+ return unless (colors = dig_json "components", "coloring")
xml.Coloring do
Array.wrap(colors).each do |color|
- xml.Color Color: color['color'].delete_prefix('#') do
- Array.wrap(color['components']).each do |comp_hash|
+ xml.Color Color: color["color"].delete_prefix("#") do
+ Array.wrap(color["components"]).each do |comp_hash|
xml.Component camelized(comp_hash)
end
end
@@ -112,49 +112,49 @@ def camera(type, xml)
to_xml_coords(coords, xml)
end
end
- xml.FieldOfView convert_float(camera['field_of_view']) if type == 'perspective_camera'
- xml.ViewToWorldScale convert_float(camera['view_to_world_scale']) if type == 'orthogonal_camera'
+ xml.FieldOfView convert_float(camera["field_of_view"]) if type == "perspective_camera"
+ xml.ViewToWorldScale convert_float(camera["view_to_world_scale"]) if type == "orthogonal_camera"
end
end
def lines(xml)
- return unless (lines = dig_json 'lines')
+ return unless (lines = dig_json "lines")
xml.Lines do
Array.wrap(lines).each do |line|
xml.Line do
- xml.StartPoint { to_xml_coords(line['start_point'], xml) }
- xml.EndPoint { to_xml_coords(line['end_point'], xml) }
+ xml.StartPoint { to_xml_coords(line["start_point"], xml) }
+ xml.EndPoint { to_xml_coords(line["end_point"], xml) }
end
end
end
end
def clipping_planes(xml)
- return unless (planes = dig_json 'clipping_planes')
+ return unless (planes = dig_json "clipping_planes")
xml.ClippingPlanes do
Array.wrap(planes).each do |plane|
xml.ClippingPlane do
- xml.Location { to_xml_coords(plane['location'], xml) }
- xml.Direction { to_xml_coords(plane['direction'], xml) }
+ xml.Location { to_xml_coords(plane["location"], xml) }
+ xml.Direction { to_xml_coords(plane["direction"], xml) }
end
end
end
end
def bitmaps(xml)
- return unless (entries = dig_json 'bitmaps')
+ return unless (entries = dig_json "bitmaps")
# Bitmaps are rendered flat, whyever that is
entries.each do |bitmap|
xml.Bitmaps do
- xml.Bitmap bitmap['bitmap_type'].upcase
- xml.Reference bitmap['bitmap_data']
- xml.Location { to_xml_coords bitmap['location'], xml }
- xml.Normal { to_xml_coords bitmap['normal'], xml }
- xml.Up { to_xml_coords bitmap['up'], xml }
- xml.Height convert_float(bitmap['height'])
+ xml.Bitmap bitmap["bitmap_type"].upcase
+ xml.Reference bitmap["bitmap_data"]
+ xml.Location { to_xml_coords bitmap["location"], xml }
+ xml.Normal { to_xml_coords bitmap["normal"], xml }
+ xml.Up { to_xml_coords bitmap["up"], xml }
+ xml.Height convert_float(bitmap["height"])
end
end
end
@@ -165,7 +165,7 @@ def camelized(hash)
hash.transform_keys do |key|
# `camelize` uses the inflections of ActiveSupport. There we defined inflections for `IFC`. However, here we
# don't want that applied here. `ifc_foo` shall be converted to `IfcFoo` and not to `IFCFoo`.
- key.camelize.gsub("IFC", 'Ifc')
+ key.camelize.gsub("IFC", "Ifc")
end
end
@@ -173,7 +173,7 @@ def camelized(hash)
# Convert a float to BCF format that strips
# insignificant zeros
def convert_float(val)
- val.to_s.gsub(/(\.)0+$/, '')
+ val.to_s.gsub(/(\.)0+$/, "")
end
##
diff --git a/modules/bim/lib/open_project/bim/engine.rb b/modules/bim/lib/open_project/bim/engine.rb
index 3a9bd2ed922b..6a7422c6e528 100644
--- a/modules/bim/lib/open_project/bim/engine.rb
+++ b/modules/bim/lib/open_project/bim/engine.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'open_project/plugins'
+require "open_project/plugins"
module OpenProject::Bim
class Engine < ::Rails::Engine
@@ -34,8 +34,8 @@ class Engine < ::Rails::Engine
include OpenProject::Plugins::ActsAsOpEngine
- register 'openproject-bim',
- author_url: 'https://www.openproject.org',
+ register "openproject-bim",
+ author_url: "https://www.openproject.org",
bundled: true,
settings: {
default: {}
@@ -45,23 +45,23 @@ class Engine < ::Rails::Engine
if: ->(*) { OpenProject::Configuration.bim? }) do
permission :view_ifc_models,
{
- 'bim/ifc_models/ifc_models': %i[index show defaults],
- 'bim/ifc_models/ifc_viewer': %i[show]
+ "bim/ifc_models/ifc_models": %i[index show defaults],
+ "bim/ifc_models/ifc_viewer": %i[show]
},
permissible_on: :project,
contract_actions: { ifc_models: %i[read] }
permission :manage_ifc_models,
- { 'bim/ifc_models/ifc_models': %i[index show destroy edit update create new] },
+ { "bim/ifc_models/ifc_models": %i[index show destroy edit update create new] },
permissible_on: :project,
dependencies: %i[view_ifc_models],
contract_actions: { ifc_models: %i[create update destroy] }
permission :view_linked_issues,
- { 'bim/bcf/issues': %i[index] },
+ { "bim/bcf/issues": %i[index] },
permissible_on: :project,
dependencies: %i[view_work_packages],
contract_actions: { bcf: %i[read] }
permission :manage_bcf,
- { 'bim/bcf/issues': %i[index upload prepare_import configure_import perform_import] },
+ { "bim/bcf/issues": %i[index upload prepare_import configure_import perform_import] },
permissible_on: :project,
dependencies: %i[view_linked_issues
view_work_packages
@@ -91,25 +91,25 @@ class Engine < ::Rails::Engine
Rails.application.reloader.to_prepare do
OpenProject::AccessControl
.permission(:view_work_packages)
- .controller_actions << 'bim/bcf/issues/redirect_to_bcf_issues_list'
+ .controller_actions << "bim/bcf/issues/redirect_to_bcf_issues_list"
end
::Redmine::MenuManager.map(:project_menu) do |menu|
menu.push(:ifc_models,
- { controller: '/bim/ifc_models/ifc_models', action: 'defaults' },
- caption: :'bcf.label_bcf',
+ { controller: "/bim/ifc_models/ifc_models", action: "defaults" },
+ caption: :"bcf.label_bcf",
after: :work_packages,
- icon: 'bcf',
+ icon: "bcf",
badge: :label_new)
menu.push :ifc_viewer_panels,
- { controller: '/bim/ifc_models/ifc_models', action: 'defaults' },
+ { controller: "/bim/ifc_models/ifc_models", action: "defaults" },
parent: :ifc_models,
- partial: '/bim/ifc_models/ifc_models/panels'
+ partial: "/bim/ifc_models/ifc_models/panels"
end
end
- class_inflection_override('v2_1' => 'V2_1')
+ class_inflection_override("v2_1" => "V2_1")
assets %w(bim/logo_openproject_bim_big.png bim/logo_openproject_bim_big_coloured.png)
@@ -142,7 +142,7 @@ class Engine < ::Rails::Engine
{
href: bcf_v2_1_paths.topics(represented.project.identifier),
- title: 'Convert to BCF',
+ title: "Convert to BCF",
payload: { reference_links: [api_v3_paths.work_package(represented.id)] },
method: :post
}
@@ -161,14 +161,14 @@ class Engine < ::Rails::Engine
end
extend_api_response(:v3, :work_packages, :work_package_collection) do
- require_relative 'patches/api/v3/export_formats'
+ require_relative "patches/api/v3/export_formats"
prepend Patches::API::V3::ExportFormats
end
extend_api_response(:v3, :work_packages, :schema, :work_package_schema) do
schema :bcf_thumbnail,
- type: 'BCF Thumbnail',
+ type: "BCF Thumbnail",
required: false,
writable: false,
show_if: ->(*) { represented&.project&.module_enabled?(:bim) }
@@ -202,7 +202,7 @@ class Engine < ::Rails::Engine
OpenProject::Bim::Hooks::Hook
end
- initializer 'bim.bcf.register_mimetypes' do
+ initializer "bim.bcf.register_mimetypes" do
Mime::Type.register "application/octet-stream", :bcf unless Mime::Type.lookup_by_extension(:bcf)
Mime::Type.register "application/octet-stream", :bcfzip unless Mime::Type.lookup_by_extension(:bcfzip)
end
@@ -232,15 +232,15 @@ class Engine < ::Rails::Engine
end
::API::Root.class_eval do
- content_type :binary, 'application/octet-stream'
+ content_type :binary, "application/octet-stream"
default_format :binary
- version 'v1', using: :path do
+ version "v1", using: :path do
mount ::API::Bim::BcfXml::V1::BcfXmlAPI
end
end
end
add_view :Bim,
- contract_strategy: 'Bim::Views::ContractStrategy'
+ contract_strategy: "Bim::Views::ContractStrategy"
end
end
diff --git a/modules/bim/lib/open_project/bim/hooks.rb b/modules/bim/lib/open_project/bim/hooks.rb
index 5f01bbb2247d..da0f0aabdda4 100644
--- a/modules/bim/lib/open_project/bim/hooks.rb
+++ b/modules/bim/lib/open_project/bim/hooks.rb
@@ -34,7 +34,7 @@ class Hook < OpenProject::Hook::Listener
def admin_information_checklist(*)
[
- [:'extraction.available.ifc_convert', ::Bim::IfcModels::ViewConverterService.available?]
+ [:"extraction.available.ifc_convert", ::Bim::IfcModels::ViewConverterService.available?]
]
end
end
diff --git a/modules/bim/lib/open_project/bim/patches/activity_representer_patch.rb b/modules/bim/lib/open_project/bim/patches/activity_representer_patch.rb
index e2a3cc682025..aa3adeae56ff 100644
--- a/modules/bim/lib/open_project/bim/patches/activity_representer_patch.rb
+++ b/modules/bim/lib/open_project/bim/patches/activity_representer_patch.rb
@@ -34,7 +34,7 @@ def self.included(base) # :nodoc:
module InstanceMethods
def _type
if represented.bcf_comment.present?
- 'Activity::BcfComment'
+ "Activity::BcfComment"
else
super
end
diff --git a/modules/bim/lib/open_project/bim/patches/api/v3/export_formats.rb b/modules/bim/lib/open_project/bim/patches/api/v3/export_formats.rb
index 741e75383ce2..0357422b20a2 100644
--- a/modules/bim/lib/open_project/bim/patches/api/v3/export_formats.rb
+++ b/modules/bim/lib/open_project/bim/patches/api/v3/export_formats.rb
@@ -10,7 +10,7 @@ def representation_formats
def representation_format_bcf
representation_format :bcf,
- mime_type: 'application/octet-stream'
+ mime_type: "application/octet-stream"
end
end
end
diff --git a/modules/bim/lib/open_project/bim/patches/attachment_patch.rb b/modules/bim/lib/open_project/bim/patches/attachment_patch.rb
index 3dcaea8eb112..597a2e37d453 100644
--- a/modules/bim/lib/open_project/bim/patches/attachment_patch.rb
+++ b/modules/bim/lib/open_project/bim/patches/attachment_patch.rb
@@ -53,7 +53,7 @@ def ifc_content_disposition
end
def ifc_file_name
- title = container.title.sub /\.ifc\Z/, ''
+ title = container.title.sub /\.ifc\Z/, ""
title.to_localized_slug(locale: :en) + ".ifc"
end
diff --git a/modules/bim/lib/open_project/bim/patches/color_themes_patch.rb b/modules/bim/lib/open_project/bim/patches/color_themes_patch.rb
index 4adfb0554174..07071eda11f1 100644
--- a/modules/bim/lib/open_project/bim/patches/color_themes_patch.rb
+++ b/modules/bim/lib/open_project/bim/patches/color_themes_patch.rb
@@ -1,6 +1,6 @@
-require 'open_project/custom_styles/design'
+require "open_project/custom_styles/design"
-OpenProject::CustomStyles::ColorThemes::BIM_THEME_NAME = 'OpenProject BIM'.freeze
+OpenProject::CustomStyles::ColorThemes::BIM_THEME_NAME = "OpenProject BIM".freeze
module OpenProject::Bim
module Patches
@@ -24,16 +24,16 @@ def bim_theme
{
theme: OpenProject::CustomStyles::ColorThemes::BIM_THEME_NAME,
colors: {
- 'primary-button-color' => OpenProject::CustomStyles::ColorThemes::PRIMER_PRIMARY_BUTTON_COLOR,
- 'header-bg-color' => "#05002C",
- 'header-item-bg-hover-color' => "#163473",
- 'accent-color' => "#275BB5",
- 'main-menu-bg-color' => "#0E2045",
- 'main-menu-bg-selected-background' => "#3270DB",
- 'main-menu-bg-hover-background' => "#163473"
+ "primary-button-color" => OpenProject::CustomStyles::ColorThemes::PRIMER_PRIMARY_BUTTON_COLOR,
+ "header-bg-color" => "#05002C",
+ "header-item-bg-hover-color" => "#163473",
+ "accent-color" => "#275BB5",
+ "main-menu-bg-color" => "#0E2045",
+ "main-menu-bg-selected-background" => "#3270DB",
+ "main-menu-bg-hover-background" => "#163473"
# TODO 'new-feature-teaser-image' => '#{image-url("bim/new_feature_teaser.jpg")}'
},
- logo: 'bim/logo_openproject_bim_big.png'
+ logo: "bim/logo_openproject_bim_big.png"
}
end
end
diff --git a/modules/bim/lib/open_project/bim/patches/journal_patch.rb b/modules/bim/lib/open_project/bim/patches/journal_patch.rb
index 54a6d5f5e986..eb64bd81ce18 100644
--- a/modules/bim/lib/open_project/bim/patches/journal_patch.rb
+++ b/modules/bim/lib/open_project/bim/patches/journal_patch.rb
@@ -29,7 +29,7 @@
module OpenProject::Bim::Patches::JournalPatch
def self.included(base)
base.class_eval do
- has_one :bcf_comment, class_name: 'Bim::Bcf::Comment', foreign_key: 'journal_id'
+ has_one :bcf_comment, class_name: "Bim::Bcf::Comment", foreign_key: "journal_id"
end
end
end
diff --git a/modules/bim/lib/open_project/bim/patches/project_patch.rb b/modules/bim/lib/open_project/bim/patches/project_patch.rb
index f9a1419f9219..ce7305057b06 100644
--- a/modules/bim/lib/open_project/bim/patches/project_patch.rb
+++ b/modules/bim/lib/open_project/bim/patches/project_patch.rb
@@ -29,7 +29,7 @@
module OpenProject::Bim::Patches::ProjectPatch
def self.included(base)
base.class_eval do
- has_many :ifc_models, class_name: 'Bim::IfcModels::IfcModel', foreign_key: 'project_id'
+ has_many :ifc_models, class_name: "Bim::IfcModels::IfcModel", foreign_key: "project_id"
end
end
end
diff --git a/modules/bim/lib/open_project/bim/patches/query_builder_patch.rb b/modules/bim/lib/open_project/bim/patches/query_builder_patch.rb
index 78b95d13f4b7..1f298eefb6da 100644
--- a/modules/bim/lib/open_project/bim/patches/query_builder_patch.rb
+++ b/modules/bim/lib/open_project/bim/patches/query_builder_patch.rb
@@ -44,7 +44,7 @@ def set_bcf_issue_associated_filter!(filters)
if value = config[:bcf_issue_associated].presence
filters[:bcf_issue_associated] = {
operator: "=",
- values: [value ? 't' : 'f']
+ values: [value ? "t" : "f"]
}
end
end
diff --git a/modules/bim/lib/open_project/bim/patches/type_patch.rb b/modules/bim/lib/open_project/bim/patches/type_patch.rb
index c55f6069b00d..7269c2b6dc76 100644
--- a/modules/bim/lib/open_project/bim/patches/type_patch.rb
+++ b/modules/bim/lib/open_project/bim/patches/type_patch.rb
@@ -42,7 +42,7 @@ module InstanceMethods
private
def default_attribute?(active_cfs, key)
- super(active_cfs, key) && key != 'bcf_thumbnail'
+ super(active_cfs, key) && key != "bcf_thumbnail"
end
end
end
diff --git a/modules/bim/lib/open_project/bim/patches/work_package_board_seeder_patch.rb b/modules/bim/lib/open_project/bim/patches/work_package_board_seeder_patch.rb
index 0368ba9aa075..c87a0345c546 100644
--- a/modules/bim/lib/open_project/bim/patches/work_package_board_seeder_patch.rb
+++ b/modules/bim/lib/open_project/bim/patches/work_package_board_seeder_patch.rb
@@ -9,10 +9,10 @@ def seed_data!
return unless OpenProject::Configuration.bim?
- if board_data = project_data.lookup('boards.bcf')
- print_status ' ↳ Creating demo BCF board' do
+ if board_data = project_data.lookup("boards.bcf")
+ print_status " ↳ Creating demo BCF board" do
seed_bcf_board(board_data)
- Setting.boards_demo_data_available = 'true'
+ Setting.boards_demo_data_available = "true"
end
end
end
@@ -22,8 +22,8 @@ def seed_bcf_board(board_data)
board =
::Boards::Grid.new(
project:,
- name: board_data.lookup('name'),
- options: { 'type' => 'action', 'attribute' => 'status', 'highlightingMode' => 'type' },
+ name: board_data.lookup("name"),
+ options: { "type" => "action", "attribute" => "status", "highlightingMode" => "type" },
widgets:,
column_count: widgets.count,
row_count: 1
@@ -36,8 +36,8 @@ def seed_bcf_board_widgets
Grids::Widget.new start_row: 1, end_row: 2,
start_column: i + 1, end_column: i + 2,
options: { query_id: query.id,
- filters: [{ status: { operator: '=', values: query.filters[0].values } }] },
- identifier: 'work_package_query'
+ filters: [{ status: { operator: "=", values: query.filters[0].values } }] },
+ identifier: "work_package_query"
end
end
@@ -54,10 +54,10 @@ def seed_bcf_board_queries
query.name = status.name
# Set filter by this status
- query.add_filter('status_id', '=', [status.id])
+ query.add_filter("status_id", "=", [status.id])
# Set manual sort filter
- query.sort_criteria = [[:manual_sorting, 'asc']]
+ query.sort_criteria = [[:manual_sorting, "asc"]]
query.save!
end
diff --git a/modules/bim/lib/open_project/bim/patches/work_package_patch.rb b/modules/bim/lib/open_project/bim/patches/work_package_patch.rb
index ac005067fc8e..4445e2544f8c 100644
--- a/modules/bim/lib/open_project/bim/patches/work_package_patch.rb
+++ b/modules/bim/lib/open_project/bim/patches/work_package_patch.rb
@@ -29,7 +29,7 @@
module OpenProject::Bim::Patches::WorkPackagePatch
def self.included(base)
base.class_eval do
- has_one :bcf_issue, class_name: '::Bim::Bcf::Issue', foreign_key: 'work_package_id'
+ has_one :bcf_issue, class_name: "::Bim::Bcf::Issue", foreign_key: "work_package_id"
def bcf_issue?
bcf_issue.present?
diff --git a/modules/bim/lib/open_project/bim/patches/work_package_seeder_patch.rb b/modules/bim/lib/open_project/bim/patches/work_package_seeder_patch.rb
index d71158d9a832..c6ec74ab9560 100644
--- a/modules/bim/lib/open_project/bim/patches/work_package_seeder_patch.rb
+++ b/modules/bim/lib/open_project/bim/patches/work_package_seeder_patch.rb
@@ -5,14 +5,14 @@ def self.included(base) # :nodoc:
module InstanceMethods
def create_or_update_work_package(attributes)
- uuid = attributes['bcf_issue_uuid']
+ uuid = attributes["bcf_issue_uuid"]
if uuid
time_tracking_attributes = time_tracking_attributes(attributes)
work_package = find_bcf_issue(uuid)
work_package.update_columns(created_at: Time.current,
author_id: admin_user.id,
- assigned_to_id: find_principal(attributes['assigned_to']).id,
+ assigned_to_id: find_principal(attributes["assigned_to"]).id,
start_date: time_tracking_attributes[:start_date],
due_date: time_tracking_attributes[:due_date],
duration: time_tracking_attributes[:duration],
@@ -25,9 +25,9 @@ def create_or_update_work_package(attributes)
end
def update_parent(work_package, attributes)
- return unless attributes['parent']
+ return unless attributes["parent"]
- parent = find_work_package(attributes['parent'])
+ parent = find_work_package(attributes["parent"])
return if parent.nil?
work_package.parent = parent
@@ -37,7 +37,7 @@ def update_parent(work_package, attributes)
def find_bcf_issue(uuid)
WorkPackage
.joins(:bcf_issue)
- .where(project_id: project.id, 'bcf_issues.uuid': uuid)
+ .where(project_id: project.id, "bcf_issues.uuid": uuid)
.references(:bcf_issue).first
end
end
diff --git a/modules/bim/lib/open_project/bim/work_package/exporter/formatters/bcf_thumbnail.rb b/modules/bim/lib/open_project/bim/work_package/exporter/formatters/bcf_thumbnail.rb
index 704c05302639..7cd2f8b681c2 100644
--- a/modules/bim/lib/open_project/bim/work_package/exporter/formatters/bcf_thumbnail.rb
+++ b/modules/bim/lib/open_project/bim/work_package/exporter/formatters/bcf_thumbnail.rb
@@ -5,7 +5,7 @@ def self.apply?(name, _export_format)
end
def format(work_package, **_options)
- work_package&.bcf_issue&.viewpoints&.any? ? "x" : ''
+ work_package&.bcf_issue&.viewpoints&.any? ? "x" : ""
end
end
end
diff --git a/modules/bim/lib/openproject-bim.rb b/modules/bim/lib/openproject-bim.rb
index e34b067c5cd1..1da56ebecc67 100644
--- a/modules/bim/lib/openproject-bim.rb
+++ b/modules/bim/lib/openproject-bim.rb
@@ -1 +1 @@
-require 'open_project/bim'
+require "open_project/bim"
diff --git a/modules/bim/lib/tasks/openproject-bim.rake b/modules/bim/lib/tasks/openproject-bim.rake
index 7a28b393e846..31a11d7406b5 100644
--- a/modules/bim/lib/tasks/openproject-bim.rake
+++ b/modules/bim/lib/tasks/openproject-bim.rake
@@ -87,17 +87,17 @@ class Seedifier
end
def calc_status(work_package)
- prefix = ''
+ prefix = ""
if ["Resolved"].include?(work_package.status.name)
- prefix = 'bim.'
+ prefix = "bim."
end
"#{prefix}default_status_#{calc_low_dash(work_package.status.name.downcase)}"
end
def calc_type(work_package)
- prefix = ''
+ prefix = ""
if ["Issue", "Clash", "Remark", "Request"].include?(work_package.type.name)
- prefix = 'bim.'
+ prefix = "bim."
end
"#{prefix}default_type_#{calc_low_dash(work_package.type.name.downcase)}"
end
@@ -114,7 +114,7 @@ class Seedifier
@written_work_packages_ids << work_package.id
- predecessors = work_package.follows.sort_by(&:start_date).map { |predecessor| { to: predecessor.subject, type: 'follows' } }
+ predecessors = work_package.follows.sort_by(&:start_date).map { |predecessor| { to: predecessor.subject, type: "follows" } }
children = work_package.children.sort_by(&:start_date).filter_map { |child| seedify_work_package(child, project) }
diff --git a/modules/bim/openproject-bcf.gemspec b/modules/bim/openproject-bcf.gemspec
index 5d12e0efd007..e7628fdac0d0 100644
--- a/modules/bim/openproject-bcf.gemspec
+++ b/modules/bim/openproject-bcf.gemspec
@@ -10,7 +10,7 @@ Gem::Specification.new do |s|
s.files = Dir["{app,config,db,lib}/**/*", "CHANGELOG.md", "README.rdoc"]
- s.add_dependency 'activerecord-import'
- s.add_dependency 'rubyzip', '~> 2.3.0'
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.add_dependency "activerecord-import"
+ s.add_dependency "rubyzip", "~> 2.3.0"
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/bim/spec/api/v3/activities/activity_representer_spec.rb b/modules/bim/spec/api/v3/activities/activity_representer_spec.rb
index c0276c2af013..982cc6e543fc 100644
--- a/modules/bim/spec/api/v3/activities/activity_representer_spec.rb
+++ b/modules/bim/spec/api/v3/activities/activity_representer_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../../../support/bcf_topic_with_stubbed_comment'
+require "spec_helper"
+require_relative "../../../support/bcf_topic_with_stubbed_comment"
RSpec.describe API::V3::Activities::ActivityRepresenter do
include API::Bim::Utilities::PathHelper
- include_context 'bcf_topic with stubbed comment'
+ include_context "bcf_topic with stubbed comment"
let(:other_user) { build_stubbed(:user) }
let(:project) do
work_package.project
@@ -70,23 +70,23 @@
subject(:generated) { representer.to_json }
- describe 'type' do
- context 'if a bcf_comment is present' do
- let(:notes) { '' }
+ describe "type" do
+ context "if a bcf_comment is present" do
+ let(:notes) { "" }
- it 'is Activity::BcfComment' do
+ it "is Activity::BcfComment" do
expect(subject)
- .to be_json_eql('Activity::BcfComment'.to_json)
- .at_path('_type')
+ .to be_json_eql("Activity::BcfComment".to_json)
+ .at_path("_type")
end
end
end
- describe '_links' do
- describe 'bcfViewpoints' do
- context 'if a viewpoint is present' do
- it_behaves_like 'has a link collection' do
- let(:link) { 'bcfViewpoints' }
+ describe "_links" do
+ describe "bcfViewpoints" do
+ context "if a viewpoint is present" do
+ it_behaves_like "has a link collection" do
+ let(:link) { "bcfViewpoints" }
let(:hrefs) do
[
{
@@ -96,34 +96,34 @@
end
end
- context 'if no comment is present' do
+ context "if no comment is present" do
let(:bcf_comment) { nil }
- it_behaves_like 'has no link' do
- let(:link) { 'bcfViewpoints' }
+ it_behaves_like "has no link" do
+ let(:link) { "bcfViewpoints" }
end
end
- context 'if no viewpoint is linked' do
+ context "if no viewpoint is linked" do
before do
allow(bcf_comment)
.to receive(:viewpoint)
.and_return nil
end
- it_behaves_like 'has a link collection' do
- let(:link) { 'bcfViewpoints' }
+ it_behaves_like "has a link collection" do
+ let(:link) { "bcfViewpoints" }
let(:hrefs) do
[]
end
end
end
- context 'if permission is lacking' do
+ context "if permission is lacking" do
let(:permissions) { %i[] }
- it_behaves_like 'has no link' do
- let(:link) { 'bcfViewpoints' }
+ it_behaves_like "has no link" do
+ let(:link) { "bcfViewpoints" }
end
end
end
diff --git a/modules/bim/spec/api/v3/queries/filters/query_filter_instance_representer_spec.rb b/modules/bim/spec/api/v3/queries/filters/query_filter_instance_representer_spec.rb
index 15d96e604815..6d6f2077bc2c 100644
--- a/modules/bim/spec/api/v3/queries/filters/query_filter_instance_representer_spec.rb
+++ b/modules/bim/spec/api/v3/queries/filters/query_filter_instance_representer_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Filters::QueryFilterInstanceRepresenter do
- let(:operator) { '=' }
+ let(:operator) { "=" }
let(:filter) do
Bim::Queries::WorkPackages::Filter::BcfIssueAssociatedFilter
.create!(name: "bcf_issue_associated", operator:, values:)
@@ -37,17 +37,17 @@
let(:representer) { described_class.new(filter) }
- describe 'generation' do
+ describe "generation" do
subject { representer.to_json }
- context 'with a bool bcf_associated_filter' do
+ context "with a bool bcf_associated_filter" do
context "with 't' as filter value" do
let(:values) { [OpenProject::Database::DB_VALUE_TRUE] }
it "has `true` for 'values'" do
expect(subject)
.to be_json_eql([true].to_json)
- .at_path('values')
+ .at_path("values")
end
end
@@ -57,17 +57,17 @@
it "has `true` for 'values'" do
expect(subject)
.to be_json_eql([false].to_json)
- .at_path('values')
+ .at_path("values")
end
end
context "with something as filter value" do
- let(:values) { ['blubs'] }
+ let(:values) { ["blubs"] }
it "has `false` for 'values'" do
expect(subject)
.to be_json_eql([false].to_json)
- .at_path('values')
+ .at_path("values")
end
end
end
diff --git a/modules/bim/spec/api/v3/work_packages/work_package_representer_spec.rb b/modules/bim/spec/api/v3/work_packages/work_package_representer_spec.rb
index ef72f59fef2c..e78020abc6c1 100644
--- a/modules/bim/spec/api/v3/work_packages/work_package_representer_spec.rb
+++ b/modules/bim/spec/api/v3/work_packages/work_package_representer_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../../../support/bcf_topic_with_stubbed_comment'
+require_relative "../../../support/bcf_topic_with_stubbed_comment"
RSpec.describe API::V3::WorkPackages::WorkPackageRepresenter do
include API::V3::Utilities::PathHelper
include API::Bim::Utilities::PathHelper
- include_context 'bcf_topic with stubbed comment'
+ include_context "bcf_topic with stubbed comment"
let(:project) do
work_package.project
@@ -60,38 +60,38 @@
subject(:generated) { representer.to_json }
- include_context 'eager loaded work package representer'
+ include_context "eager loaded work package representer"
- describe '_links' do
- describe 'bcfTopic' do
- context 'if a topic is present' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'bcfTopic' }
+ describe "_links" do
+ describe "bcfTopic" do
+ context "if a topic is present" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "bcfTopic" }
let(:href) { "/api/bcf/2.1/projects/#{project.identifier}/topics/#{bcf_topic.uuid}" }
end
end
- context 'if no topic is present' do
+ context "if no topic is present" do
let(:bcf_topic) { nil }
- it_behaves_like 'has no link' do
- let(:link) { 'bcfTopic' }
+ it_behaves_like "has no link" do
+ let(:link) { "bcfTopic" }
end
end
- context 'if permission is lacking' do
+ context "if permission is lacking" do
let(:permissions) { %i[view_work_packages] }
- it_behaves_like 'has no link' do
- let(:link) { 'bcfTopic' }
+ it_behaves_like "has no link" do
+ let(:link) { "bcfTopic" }
end
end
end
- describe 'bcfViewpoints' do
- context 'if a viewpoint is present' do
- it_behaves_like 'has a link collection' do
- let(:link) { 'bcfViewpoints' }
+ describe "bcfViewpoints" do
+ context "if a viewpoint is present" do
+ it_behaves_like "has a link collection" do
+ let(:link) { "bcfViewpoints" }
let(:hrefs) do
[
{
@@ -101,66 +101,66 @@
end
end
- context 'if no topic is present' do
+ context "if no topic is present" do
let(:bcf_topic) { nil }
- it_behaves_like 'has no link' do
- let(:link) { 'bcfViewpoints' }
+ it_behaves_like "has no link" do
+ let(:link) { "bcfViewpoints" }
end
end
- context 'if no viewpoint is present' do
+ context "if no viewpoint is present" do
before do
allow(bcf_topic)
.to receive(:viewpoints)
.and_return []
end
- it_behaves_like 'has a link collection' do
- let(:link) { 'bcfViewpoints' }
+ it_behaves_like "has a link collection" do
+ let(:link) { "bcfViewpoints" }
let(:hrefs) do
[]
end
end
end
- context 'if permission is lacking' do
+ context "if permission is lacking" do
let(:permissions) { %i[view_work_packages] }
- it_behaves_like 'has no link' do
- let(:link) { 'bcfViewpoints' }
+ it_behaves_like "has no link" do
+ let(:link) { "bcfViewpoints" }
end
end
end
end
- describe 'convertBCF' do
- let(:link) { 'convertBCF' }
+ describe "convertBCF" do
+ let(:link) { "convertBCF" }
- context 'if no bcf issue is assigned yet' do
+ context "if no bcf issue is assigned yet" do
let(:bcf_topic) { nil }
- it_behaves_like 'has a titled link' do
- let(:title) { 'Convert to BCF' }
+ it_behaves_like "has a titled link" do
+ let(:title) { "Convert to BCF" }
let(:href) { "/api/bcf/2.1/projects/#{project.identifier}/topics" }
end
- it 'signalizes the payload' do
+ it "signalizes the payload" do
expect(subject)
.to be_json_eql({ reference_links: ["/api/v3/work_packages/#{work_package.id}"] }.to_json)
- .at_path('_links/convertBCF/payload')
+ .at_path("_links/convertBCF/payload")
end
end
- context 'if a bcf issue is assigned' do
- it_behaves_like 'has no link'
+ context "if a bcf issue is assigned" do
+ it_behaves_like "has no link"
end
- context 'if no bcf issue iss assigned but the user lacks permission' do
+ context "if no bcf issue iss assigned but the user lacks permission" do
let(:bcf_topic) { nil }
let(:permissions) { %i[view_linked_issues view_work_packages] }
- it_behaves_like 'has no link'
+ it_behaves_like "has no link"
end
end
end
diff --git a/modules/bim/spec/bcf/bcf_xml/exporter_spec.rb b/modules/bim/spec/bcf/bcf_xml/exporter_spec.rb
index 0a710b6834ba..e464ac90ecd9 100644
--- a/modules/bim/spec/bcf/bcf_xml/exporter_spec.rb
+++ b/modules/bim/spec/bcf/bcf_xml/exporter_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::Bim::BcfXml::Exporter do
let(:query) { build(:global_query) }
@@ -42,7 +42,7 @@
subject { described_class.new(query) }
context "one WP without BCF issue associated" do
- it '#work_packages' do
+ it "#work_packages" do
expect(subject.work_packages.count).to be(0)
end
end
@@ -54,7 +54,7 @@
bcf_issue
end
- it '#work_packages' do
+ it "#work_packages" do
expect(subject.work_packages.count).to be(1)
end
end
diff --git a/modules/bim/spec/bcf/bcf_xml/importer_spec.rb b/modules/bim/spec/bcf/bcf_xml/importer_spec.rb
index 3b83d63d3609..43f57af4a89c 100644
--- a/modules/bim/spec/bcf/bcf_xml/importer_spec.rb
+++ b/modules/bim/spec/bcf/bcf_xml/importer_spec.rb
@@ -26,20 +26,20 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::Bim::BcfXml::Importer do
- let(:filename) { 'MaximumInformation.bcf' }
+ let(:filename) { "MaximumInformation.bcf" }
let(:file) do
Rack::Test::UploadedFile.new(
Rails.root.join("modules/bim/spec/fixtures/files/#{filename}").to_s,
- 'application/octet-stream'
+ "application/octet-stream"
)
end
- let(:type) { create(:type, name: 'Issue', is_standard: true, is_default: true) }
+ let(:type) { create(:type, name: "Issue", is_standard: true, is_default: true) }
let(:project) do
create(:project,
- identifier: 'bim_project',
+ identifier: "bim_project",
enabled_module_names: %w[bim work_package_tracking],
types: [type])
end
@@ -75,24 +75,24 @@
bcf_manager_member
end
- describe '#to_listing' do
- context 'without sufficient permissions' do
- context 'no add_work_packages permission' do
- pending 'test that importing user has add_work_packages permission'
+ describe "#to_listing" do
+ context "without sufficient permissions" do
+ context "no add_work_packages permission" do
+ pending "test that importing user has add_work_packages permission"
end
- context 'no manage_members permission' do
- pending 'test that non members should not be able to prepare an import'
+ context "no manage_members permission" do
+ pending "test that non members should not be able to prepare an import"
end
end
end
- describe '#import!' do
- it 'imports successfully' do
+ describe "#import!" do
+ it "imports successfully" do
expect(subject.import!).to be_present
end
- it 'creates 2 work packages' do
+ it "creates 2 work packages" do
subject.import!
expect(Bim::Bcf::Issue.count).to eql 2
@@ -100,10 +100,10 @@
end
end
- context 'with a viewpoint and snapshot' do
- let(:filename) { 'issue-with-viewpoint.bcf' }
+ context "with a viewpoint and snapshot" do
+ let(:filename) { "issue-with-viewpoint.bcf" }
- it 'imports that viewpoint successfully' do
+ it "imports that viewpoint successfully" do
expect(subject.import!).to be_present
expect(Bim::Bcf::Issue.count).to eq 1
diff --git a/modules/bim/spec/bcf/bcf_xml/issue_reader_spec.rb b/modules/bim/spec/bcf/bcf_xml/issue_reader_spec.rb
index e4befa91f421..27aa5d3c9700 100644
--- a/modules/bim/spec/bcf/bcf_xml/issue_reader_spec.rb
+++ b/modules/bim/spec/bcf/bcf_xml/issue_reader_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::Bim::BcfXml::IssueReader do
let(:absolute_file_path) { "63E78882-7C6A-4BF7-8982-FC478AFB9C97/markup.bcf" }
- let(:type) { create(:type, name: 'Issue', is_standard: true, is_default: true) }
+ let(:type) { create(:type, name: "Issue", is_standard: true, is_default: true) }
let(:project) do
create(:project,
- identifier: 'bim_project',
+ identifier: "bim_project",
types: [type])
end
let(:manage_bcf_role) do
@@ -104,20 +104,20 @@
allow(User).to receive(:current).and_return(bcf_manager)
end
- context 'on initial import' do
+ context "on initial import" do
let(:bcf_issue) { subject.extract! }
- context 'with happy path, everything has a match' do
- it 'WP start date gets initialized with BCF CreationDate' do
+ context "with happy path, everything has a match" do
+ it "WP start date gets initialized with BCF CreationDate" do
expect(bcf_issue.work_package.start_date).to eql(subject.extractor.creation_date.to_date)
end
- it 'Bim::Bcf::Issue get initialized with the GUID form the XML file' do
+ it "Bim::Bcf::Issue get initialized with the GUID form the XML file" do
expect(bcf_issue.uuid).to eql("63E78882-7C6A-4BF7-8982-FC478AFB9C97")
end
end
- context 'Topic does not provide any title, status, type or priority' do
+ context "Topic does not provide any title, status, type or priority" do
let(:markup) do
<<-MARKUP
@@ -131,18 +131,18 @@
MARKUP
end
- context 'with no import options provided' do
+ context "with no import options provided" do
let(:bcf_issue) { subject.extract! }
- it 'sets a status' do
+ it "sets a status" do
expect(bcf_issue.work_package.status).to eql(Status.default)
end
- it 'sets a type' do
+ it "sets a type" do
expect(bcf_issue.work_package.type).to eql(type)
end
- it 'ignores missing priority' do
+ it "ignores missing priority" do
# as it gets set automatically when creating new work packages.
expect(bcf_issue.work_package.priority).to eql(priority)
end
@@ -150,8 +150,8 @@
end
end
- context 'on updating import' do
- describe '#update_comment' do
+ context "on updating import" do
+ describe "#update_comment" do
let(:work_package) { create(:work_package) }
let!(:bcf_issue) { create(:bcf_issue_with_comment, work_package:) }
@@ -159,18 +159,18 @@
allow(subject).to receive(:issue).and_return(bcf_issue)
end
- it '#update_comment' do
+ it "#update_comment" do
modified_time = Time.now + 1.minute
- comment_data = { uuid: bcf_issue.comments.first.uuid, comment: 'Updated comment', modified_date: modified_time }
+ comment_data = { uuid: bcf_issue.comments.first.uuid, comment: "Updated comment", modified_date: modified_time }
expect(subject).to receive(:update_comment_viewpoint_by_uuid)
subject.send(:update_comment, comment_data)
- expect(bcf_issue.comments.first.journal.notes).to eql('Updated comment')
+ expect(bcf_issue.comments.first.journal.notes).to eql("Updated comment")
expect(bcf_issue.comments.first.journal.created_at.utc.to_s).to eql(modified_time.utc.to_s)
end
- it '#update_comment_viewpoint_by_uuid' do
+ it "#update_comment_viewpoint_by_uuid" do
bcf_comment = bcf_issue.comments.first
viewpoint = bcf_comment.viewpoint
bcf_comment.viewpoint = nil
@@ -182,7 +182,7 @@
expect(bcf_comment.viewpoint).to be_nil
end
- it '#viewpoint_by_uuid' do
+ it "#viewpoint_by_uuid" do
expect(subject.send(:viewpoint_by_uuid, nil)).to be_nil
expect(subject.send(:viewpoint_by_uuid,
bcf_issue.comments.first.viewpoint.uuid)).to eql(bcf_issue.comments.first.viewpoint)
diff --git a/modules/bim/spec/bcf/bcf_xml/issue_writer_spec.rb b/modules/bim/spec/bcf/bcf_xml/issue_writer_spec.rb
index 9cf3f54c0070..d281882b2ed5 100644
--- a/modules/bim/spec/bcf/bcf_xml/issue_writer_spec.rb
+++ b/modules/bim/spec/bcf/bcf_xml/issue_writer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::Bim::BcfXml::IssueWriter do
let(:project) { create(:project) }
@@ -91,7 +91,7 @@
end
let(:priority) { create(:priority_low) }
let(:due_date) { DateTime.now }
- let(:type) { create(:type, name: 'Issue') }
+ let(:type) { create(:type, name: "Issue") }
let(:work_package) do
create(:work_package,
project_id: project.id,
@@ -117,23 +117,23 @@
it "updates the Topic node" do
work_package.reload
- expect(subject.at('Markup')).to be_present
- expect(subject.at('Topic')).to be_present
-
- expect(subject.at('Topic/@Guid').content).to eql bcf_issue.uuid
- expect(subject.at('Topic/@TopicStatus').content).to eql work_package.status.name
- expect(subject.at('Topic/@TopicType').content).to eql 'Issue'
-
- expect(subject.at('Topic/Title').content).to eql work_package.subject
- expect(subject.at('Topic/CreationDate').content).to eql work_package.created_at.iso8601
- expect(subject.at('Topic/ModifiedDate').content).to eql work_package.updated_at.iso8601
- expect(subject.at('Topic/Description').content).to eql work_package.description
- expect(subject.at('Topic/CreationAuthor').content).to eql work_package.author.mail
- expect(subject.at('Topic/ReferenceLink').content).to eql url_helpers.work_package_url(work_package)
- expect(subject.at('Topic/Priority').content).to eql work_package.priority.name
- expect(subject.at('Topic/ModifiedAuthor').content).to eql work_package.journals.last.user.mail
- expect(subject.at('Topic/AssignedTo').content).to eql work_package.assigned_to.mail
- expect(subject.at('Topic/DueDate').content).to eql work_package.due_date.to_datetime.iso8601
+ expect(subject.at("Markup")).to be_present
+ expect(subject.at("Topic")).to be_present
+
+ expect(subject.at("Topic/@Guid").content).to eql bcf_issue.uuid
+ expect(subject.at("Topic/@TopicStatus").content).to eql work_package.status.name
+ expect(subject.at("Topic/@TopicType").content).to eql "Issue"
+
+ expect(subject.at("Topic/Title").content).to eql work_package.subject
+ expect(subject.at("Topic/CreationDate").content).to eql work_package.created_at.iso8601
+ expect(subject.at("Topic/ModifiedDate").content).to eql work_package.updated_at.iso8601
+ expect(subject.at("Topic/Description").content).to eql work_package.description
+ expect(subject.at("Topic/CreationAuthor").content).to eql work_package.author.mail
+ expect(subject.at("Topic/ReferenceLink").content).to eql url_helpers.work_package_url(work_package)
+ expect(subject.at("Topic/Priority").content).to eql work_package.priority.name
+ expect(subject.at("Topic/ModifiedAuthor").content).to eql work_package.journals.last.user.mail
+ expect(subject.at("Topic/AssignedTo").content).to eql work_package.assigned_to.mail
+ expect(subject.at("Topic/DueDate").content).to eql work_package.due_date.to_datetime.iso8601
end
end
@@ -148,59 +148,59 @@ def valid_markup?(doc)
end
end
- shared_examples_for 'valid markup' do
- it 'produces valid markup' do
+ shared_examples_for "valid markup" do
+ it "produces valid markup" do
expect(valid_markup?(subject)).to be_truthy
end
end
- context 'no markup present yet' do
+ context "no markup present yet" do
let(:markup) { nil }
- it_behaves_like 'writes Topic'
- it_behaves_like 'valid markup'
+ it_behaves_like "writes Topic"
+ it_behaves_like "valid markup"
end
- context 'markup already present' do
- it_behaves_like 'writes Topic'
- it_behaves_like 'valid markup'
+ context "markup already present" do
+ it_behaves_like "writes Topic"
+ it_behaves_like "valid markup"
it "maintains existing nodes and attributes untouched" do
- expect(subject.at('Index').content).to eql "0"
- expect(subject.at('BimSnippet')['SnippetType']).to eql "JSON"
+ expect(subject.at("Index").content).to eql "0"
+ expect(subject.at("BimSnippet")["SnippetType"]).to eql "JSON"
end
- it 'exports all BCF comments' do
- expect(subject.at('/Markup/Comment[1]/Comment').content).to eql("Some BCF comment.")
+ it "exports all BCF comments" do
+ expect(subject.at("/Markup/Comment[1]/Comment").content).to eql("Some BCF comment.")
end
- it 'creates BCF comments for comments that were created within OP.' do
- work_package.journal_notes = 'Some note created in OP.'
+ it "creates BCF comments for comments that were created within OP." do
+ work_package.journal_notes = "Some note created in OP."
work_package.save!
- expect(subject.at('/Markup/Comment[2]/Comment').content).to eql("Some note created in OP.")
+ expect(subject.at("/Markup/Comment[2]/Comment").content).to eql("Some note created in OP.")
expect(Bim::Bcf::Comment.count).to be(2)
end
- it 'replaces the BCF viewpoints names to use its uuid only' do
+ it "replaces the BCF viewpoints names to use its uuid only" do
uuid = bcf_issue.viewpoints.first.uuid
viewpoint_node = subject.at("/Markup/Viewpoints[@Guid='#{uuid}']")
- expect(viewpoint_node.at('Viewpoint').content).to eql("#{uuid}.bcfv")
- expect(viewpoint_node.at('Snapshot').content).to eql("#{uuid}.png")
+ expect(viewpoint_node.at("Viewpoint").content).to eql("#{uuid}.bcfv")
+ expect(viewpoint_node.at("Snapshot").content).to eql("#{uuid}.png")
end
end
- context 'when bcf_issue snapshot is false' do
+ context "when bcf_issue snapshot is false" do
let(:vp_snapshot) { false }
- it_behaves_like 'writes Topic'
- it_behaves_like 'valid markup'
+ it_behaves_like "writes Topic"
+ it_behaves_like "valid markup"
- it 'does not provides a Snapshot node' do
+ it "does not provides a Snapshot node" do
uuid = bcf_issue.viewpoints.first.uuid
viewpoint_node = subject.at("/Markup/Viewpoints[@Guid='#{uuid}']")
- expect(viewpoint_node.at('Viewpoint').content).to eql("#{uuid}.bcfv")
- expect(viewpoint_node.at('Snapshot')).to be_nil
+ expect(viewpoint_node.at("Viewpoint").content).to eql("#{uuid}.bcfv")
+ expect(viewpoint_node.at("Snapshot")).to be_nil
end
end
diff --git a/modules/bim/spec/bcf/bcf_xml/markup_extractor_spec.rb b/modules/bim/spec/bcf/bcf_xml/markup_extractor_spec.rb
index 110f71ce8642..12ee82ef136e 100644
--- a/modules/bim/spec/bcf/bcf_xml/markup_extractor_spec.rb
+++ b/modules/bim/spec/bcf/bcf_xml/markup_extractor_spec.rb
@@ -26,103 +26,103 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::Bim::BcfXml::MarkupExtractor do
- let(:filename) { 'MaximumInformation.bcf' }
+ let(:filename) { "MaximumInformation.bcf" }
let(:file) do
Rack::Test::UploadedFile.new(
Rails.root.join("modules/bim/spec/fixtures/files/#{filename}").to_s,
- 'application/octet-stream'
+ "application/octet-stream"
)
end
let(:entries) do
Zip::File.open(file) do |zip|
- zip.select { |entry| entry.name.end_with?('markup.bcf') }
+ zip.select { |entry| entry.name.end_with?("markup.bcf") }
end
end
subject { described_class.new(entries.first) }
- it '#initialize' do
+ it "#initialize" do
expect(subject).to be_a described_class
expect(subject.markup).to be_a String
expect(subject.doc).to be_a Nokogiri::XML::Document
end
- it '#uuid' do
- expect(subject.uuid).to eql '63E78882-7C6A-4BF7-8982-FC478AFB9C97'
+ it "#uuid" do
+ expect(subject.uuid).to eql "63E78882-7C6A-4BF7-8982-FC478AFB9C97"
end
- it '#title' do
- expect(subject.title).to eql 'Maximum Content'
+ it "#title" do
+ expect(subject.title).to eql "Maximum Content"
end
- it '#priority' do
- expect(subject.priority).to eql 'High'
+ it "#priority" do
+ expect(subject.priority).to eql "High"
end
- it '#status' do
- expect(subject.status).to eql 'Open'
+ it "#status" do
+ expect(subject.status).to eql "Open"
end
- it '#description' do
- expect(subject.description).to eql 'This is a topic with all information present.'
+ it "#description" do
+ expect(subject.description).to eql "This is a topic with all information present."
end
- it '#author' do
- expect(subject.author).to eql 'mike@example.com'
+ it "#author" do
+ expect(subject.author).to eql "mike@example.com"
end
- it '#modified_author' do
- expect(subject.modified_author).to eql 'mike@example.com'
+ it "#modified_author" do
+ expect(subject.modified_author).to eql "mike@example.com"
end
- it '#assignee' do
- expect(subject.assignee).to eql 'andy@example.com'
+ it "#assignee" do
+ expect(subject.assignee).to eql "andy@example.com"
end
- it '#due_date' do
+ it "#due_date" do
expect(subject.due_date).to be_nil
end
- it '#creation_date' do
- expect(subject.creation_date).to eql(Time.iso8601('2015-06-21T12:00:00Z'))
+ it "#creation_date" do
+ expect(subject.creation_date).to eql(Time.iso8601("2015-06-21T12:00:00Z"))
end
- it '#modified_date' do
- expect(subject.modified_date).to eql(Time.iso8601('2015-06-21T14:22:47Z'))
+ it "#modified_date" do
+ expect(subject.modified_date).to eql(Time.iso8601("2015-06-21T14:22:47Z"))
end
- it '#viewpoints' do
+ it "#viewpoints" do
expect(subject.viewpoints.size).to be 3
- expect(subject.viewpoints.first[:uuid]).to eql '8dc86298-9737-40b4-a448-98a9e953293a'
- expect(subject.viewpoints.first[:viewpoint]).to eql 'Viewpoint_8dc86298-9737-40b4-a448-98a9e953293a.bcfv'
- expect(subject.viewpoints.first[:snapshot]).to eql 'Snapshot_8dc86298-9737-40b4-a448-98a9e953293a.png'
+ expect(subject.viewpoints.first[:uuid]).to eql "8dc86298-9737-40b4-a448-98a9e953293a"
+ expect(subject.viewpoints.first[:viewpoint]).to eql "Viewpoint_8dc86298-9737-40b4-a448-98a9e953293a.bcfv"
+ expect(subject.viewpoints.first[:snapshot]).to eql "Snapshot_8dc86298-9737-40b4-a448-98a9e953293a.png"
end
- it '#comments' do
+ it "#comments" do
expect(subject.comments.size).to be 4
- expect(subject.comments.first[:uuid]).to eql('780FAE52-C432-42BE-ADEA-FF3E7A8CD8E1')
- expect(subject.comments.first[:date]).to eql(Time.iso8601('2015-08-31T12:40:17Z'))
- expect(subject.comments.first[:modified_date]).to eql(Time.iso8601('2015-08-31T16:07:11Z'))
- expect(subject.comments.first[:author]).to eql('mike@example.com')
- expect(subject.comments.first[:modified_author]).to eql('mike@example.com')
+ expect(subject.comments.first[:uuid]).to eql("780FAE52-C432-42BE-ADEA-FF3E7A8CD8E1")
+ expect(subject.comments.first[:date]).to eql(Time.iso8601("2015-08-31T12:40:17Z"))
+ expect(subject.comments.first[:modified_date]).to eql(Time.iso8601("2015-08-31T16:07:11Z"))
+ expect(subject.comments.first[:author]).to eql("mike@example.com")
+ expect(subject.comments.first[:modified_author]).to eql("mike@example.com")
expect(subject.comments.first[:comment]).to(
eql("This comment contained some spllng errs.\nHopefully, the modifier did catch them all.")
)
- expect(subject.comments.first[:viewpoint_uuid]).to eql('8dc86298-9737-40b4-a448-98a9e953293a')
+ expect(subject.comments.first[:viewpoint_uuid]).to eql("8dc86298-9737-40b4-a448-98a9e953293a")
end
- it '#people' do
+ it "#people" do
expect(subject.people.size).to be 2
- expect(subject.people.first).to eql 'andy@example.com'
- expect(subject.people.second).to eql 'mike@example.com'
+ expect(subject.people.first).to eql "andy@example.com"
+ expect(subject.people.second).to eql "mike@example.com"
end
- it '#mail_addresses' do
+ it "#mail_addresses" do
expect(subject.mail_addresses.size).to be 2
- expect(subject.mail_addresses.first).to eql 'andy@example.com'
- expect(subject.mail_addresses.second).to eql 'mike@example.com'
+ expect(subject.mail_addresses.first).to eql "andy@example.com"
+ expect(subject.mail_addresses.second).to eql "mike@example.com"
end
end
diff --git a/modules/bim/spec/contracts/bcf/issues/create_contract_spec.rb b/modules/bim/spec/contracts/bcf/issues/create_contract_spec.rb
index 4b5a1690a240..77df368b7a49 100644
--- a/modules/bim/spec/contracts/bcf/issues/create_contract_spec.rb
+++ b/modules/bim/spec/contracts/bcf/issues/create_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Bim::Bcf::Issues::CreateContract do
- it_behaves_like 'issues contract' do
+ it_behaves_like "issues contract" do
let(:issue) do
Bim::Bcf::Issue.new(uuid: issue_uuid,
work_package: issue_work_package,
diff --git a/modules/bim/spec/contracts/bcf/issues/shared_contract_examples.rb b/modules/bim/spec/contracts/bcf/issues/shared_contract_examples.rb
index 7ff69baba396..9bf8b11c34b3 100644
--- a/modules/bim/spec/contracts/bcf/issues/shared_contract_examples.rb
+++ b/modules/bim/spec/contracts/bcf/issues/shared_contract_examples.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.shared_examples_for 'issues contract' do
+RSpec.shared_examples_for "issues contract" do
let(:current_user) do
build_stubbed(:user)
end
@@ -39,7 +39,7 @@
end
end
- let(:issue_uuid) { 'issue uuid' }
+ let(:issue_uuid) { "issue uuid" }
let(:project) { build_stubbed(:project) }
let(:issue_work_package) { build_stubbed(:work_package, project:) }
let(:issue_work_package_id) do
@@ -68,59 +68,59 @@ def expect_valid(valid, symbols = {})
end
end
- shared_examples 'is valid' do
- it 'is valid' do
+ shared_examples "is valid" do
+ it "is valid" do
expect_valid(true)
end
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
- context 'if the uuid is nil' do
+ context "if the uuid is nil" do
let(:issue_uuid) { nil }
- it_behaves_like 'is valid' # as the uuid will be set
+ it_behaves_like "is valid" # as the uuid will be set
end
- context 'if the work_package_id is nil' do
+ context "if the work_package_id is nil" do
let(:issue_work_package) { nil }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, work_package: %i(blank))
end
end
- context 'if the user lacks permission' do
+ context "if the user lacks permission" do
let(:permissions) { [] }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, base: %i(error_unauthorized))
end
end
- context 'if the stage is written' do
+ context "if the stage is written" do
before do
- issue.stage = 'some stage'
+ issue.stage = "some stage"
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, stage: %i(error_readonly))
end
end
- context 'if labels is written' do
+ context "if labels is written" do
before do
issue.labels = %w(some labels)
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, labels: %i(error_readonly))
end
end
- context 'if index is nil' do
+ context "if index is nil" do
let(:issue_index) { nil }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
end
diff --git a/modules/bim/spec/contracts/bcf/issues/update_contract_spec.rb b/modules/bim/spec/contracts/bcf/issues/update_contract_spec.rb
index a17020e28501..8ae95ab19026 100644
--- a/modules/bim/spec/contracts/bcf/issues/update_contract_spec.rb
+++ b/modules/bim/spec/contracts/bcf/issues/update_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Bim::Bcf::Issues::UpdateContract do
- it_behaves_like 'issues contract' do
+ it_behaves_like "issues contract" do
let(:issue) do
build_stubbed(:bcf_issue,
work_package: issue_work_package).tap do |i|
@@ -42,12 +42,12 @@
subject(:contract) { described_class.new(issue, current_user) }
- context 'if work_package is altered' do
+ context "if work_package is altered" do
before do
issue.work_package = build_stubbed(:work_package)
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, work_package_id: %i(error_readonly))
end
end
diff --git a/modules/bim/spec/contracts/bcf/viewpoints/create_contract_spec.rb b/modules/bim/spec/contracts/bcf/viewpoints/create_contract_spec.rb
index 211f25aeae37..d61866046250 100644
--- a/modules/bim/spec/contracts/bcf/viewpoints/create_contract_spec.rb
+++ b/modules/bim/spec/contracts/bcf/viewpoints/create_contract_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Bim::Bcf::Viewpoints::CreateContract do
let(:viewpoint) do
@@ -34,12 +34,12 @@
issue: viewpoint_issue,
json_viewpoint: viewpoint_json_viewpoint)
end
- let(:viewpoint_uuid) { 'issue uuid' }
+ let(:viewpoint_uuid) { "issue uuid" }
let(:viewpoint_json_viewpoint) do
{
- 'snapshot' => {
- 'snapshot_data' => 'some contents',
- 'snapshot_type' => 'jpg'
+ "snapshot" => {
+ "snapshot_data" => "some contents",
+ "snapshot_type" => "jpg"
}
}
end
@@ -70,148 +70,148 @@ def expect_valid(valid, symbols = {})
end
end
- shared_examples 'is valid' do
- it 'is valid' do
+ shared_examples "is valid" do
+ it "is valid" do
expect_valid(true)
end
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
- context 'if the uuid is nil' do
+ context "if the uuid is nil" do
let(:issue_uuid) { nil }
- it_behaves_like 'is valid' # as the uuid will be set
+ it_behaves_like "is valid" # as the uuid will be set
end
- context 'if the issue is nil' do
+ context "if the issue is nil" do
let(:viewpoint_issue) { nil }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, issue: %i(blank))
end
end
- context 'if the json_viewpoint is nil' do
+ context "if the json_viewpoint is nil" do
let(:viewpoint_json_viewpoint) { nil }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(blank))
end
end
- context 'if the user lacks permission' do
+ context "if the user lacks permission" do
let(:permissions) { [] }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, base: %i(error_unauthorized))
end
end
- context 'json_viewpoint' do
- context 'with something different that a hash' do
+ context "json_viewpoint" do
+ context "with something different that a hash" do
let(:viewpoint_json_viewpoint) do
- 'some non hash'
+ "some non hash"
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(no_json))
end
end
- context 'with an unsupported key' do
+ context "with an unsupported key" do
let(:viewpoint_json_viewpoint) do
{
- 'some_key' => true
+ "some_key" => true
}
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(unsupported_key))
end
end
- describe 'snapshot' do
+ describe "snapshot" do
let(:viewpoint_json_viewpoint) do
{
- 'snapshot' => {
- 'snapshot_data' => 'some content',
- 'snapshot_type' => 'jpg'
+ "snapshot" => {
+ "snapshot_data" => "some content",
+ "snapshot_type" => "jpg"
}
}
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
- context 'with a type other than png or jpg' do
+ context "with a type other than png or jpg" do
let(:viewpoint_json_viewpoint) do
{
- 'snapshot' => {
- 'snapshot_data' => 'some content',
- 'snapshot_type' => 'some'
+ "snapshot" => {
+ "snapshot_data" => "some content",
+ "snapshot_type" => "some"
}
}
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(snapshot_type_unsupported))
end
end
- context 'without a type' do
+ context "without a type" do
let(:viewpoint_json_viewpoint) do
{
- 'snapshot' => {
- 'snapshot_data' => 'some content'
+ "snapshot" => {
+ "snapshot_data" => "some content"
}
}
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(snapshot_type_unsupported))
end
end
- context 'without data' do
+ context "without data" do
let(:viewpoint_json_viewpoint) do
{
- 'snapshot' => {
- 'snapshot_type' => 'jpg'
+ "snapshot" => {
+ "snapshot_type" => "jpg"
}
}
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(snapshot_data_blank))
end
end
- context 'without snapshot' do
+ context "without snapshot" do
let(:viewpoint_json_viewpoint) do
{
index: 10
}
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
end
- describe 'index' do
- context 'with a non integer value' do
+ describe "index" do
+ context "with a non integer value" do
let(:viewpoint_json_viewpoint) do
{
- 'index' => 'something'
+ "index" => "something"
}
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(index_not_integer))
end
end
end
- describe 'orthogonal_camera' do
+ describe "orthogonal_camera" do
let(:valid_json) do
{
orthogonal_camera: {
@@ -239,65 +239,65 @@ def expect_valid(valid, symbols = {})
valid_json
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
- context 'with an additional property' do
+ context "with an additional property" do
let(:viewpoint_json_viewpoint) do
- valid_json['orthogonal_camera']['superfluous_property'] = 123
+ valid_json["orthogonal_camera"]["superfluous_property"] = 123
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_orthogonal_camera))
end
end
- context 'with a missing property' do
+ context "with a missing property" do
let(:viewpoint_json_viewpoint) do
- valid_json['orthogonal_camera'].delete(:camera_direction)
+ valid_json["orthogonal_camera"].delete(:camera_direction)
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_orthogonal_camera))
end
end
- context 'with a missing dimension in one of the directions' do
+ context "with a missing dimension in one of the directions" do
let(:viewpoint_json_viewpoint) do
- valid_json['orthogonal_camera'][:camera_direction].delete(:y)
+ valid_json["orthogonal_camera"][:camera_direction].delete(:y)
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_orthogonal_camera))
end
end
- context 'with a non number in one of the directions' do
+ context "with a non number in one of the directions" do
let(:viewpoint_json_viewpoint) do
- valid_json['orthogonal_camera'][:camera_direction][:z] = "sdfjsdkf"
+ valid_json["orthogonal_camera"][:camera_direction][:z] = "sdfjsdkf"
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_orthogonal_camera))
end
end
- context 'with a non number in for view_to_world_scale' do
+ context "with a non number in for view_to_world_scale" do
let(:viewpoint_json_viewpoint) do
- valid_json['orthogonal_camera'][:view_to_world_scale] = "sdfjsdkf"
+ valid_json["orthogonal_camera"][:view_to_world_scale] = "sdfjsdkf"
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_orthogonal_camera))
end
end
end
- describe 'perspective_camera' do
+ describe "perspective_camera" do
let(:valid_json) do
{
perspective_camera: {
@@ -325,65 +325,65 @@ def expect_valid(valid, symbols = {})
valid_json
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
- context 'with an additional property' do
+ context "with an additional property" do
let(:viewpoint_json_viewpoint) do
- valid_json['perspective_camera']['superfluous_property'] = 123
+ valid_json["perspective_camera"]["superfluous_property"] = 123
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_perspective_camera))
end
end
- context 'with a missing property' do
+ context "with a missing property" do
let(:viewpoint_json_viewpoint) do
- valid_json['perspective_camera'].delete(:camera_direction)
+ valid_json["perspective_camera"].delete(:camera_direction)
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_perspective_camera))
end
end
- context 'with a missing dimension in one of the directions' do
+ context "with a missing dimension in one of the directions" do
let(:viewpoint_json_viewpoint) do
- valid_json['perspective_camera'][:camera_direction].delete(:y)
+ valid_json["perspective_camera"][:camera_direction].delete(:y)
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_perspective_camera))
end
end
- context 'with a non number in one of the directions' do
+ context "with a non number in one of the directions" do
let(:viewpoint_json_viewpoint) do
- valid_json['perspective_camera'][:camera_direction][:z] = "sdfjsdkf"
+ valid_json["perspective_camera"][:camera_direction][:z] = "sdfjsdkf"
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_perspective_camera))
end
end
- context 'with a non number in for view_to_world_scale' do
+ context "with a non number in for view_to_world_scale" do
let(:viewpoint_json_viewpoint) do
- valid_json['perspective_camera'][:field_of_view] = "sdfjsdkf"
+ valid_json["perspective_camera"][:field_of_view] = "sdfjsdkf"
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_perspective_camera))
end
end
end
- describe 'lines' do
+ describe "lines" do
let(:valid_json) do
{
lines: [
@@ -419,66 +419,66 @@ def expect_valid(valid, symbols = {})
valid_json
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
- context 'with a non array for lines' do
+ context "with a non array for lines" do
let(:viewpoint_json_viewpoint) do
{
"lines" => { "some" => "value" }
}
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_lines))
end
end
- context 'with an additional property for one line' do
+ context "with an additional property for one line" do
let(:viewpoint_json_viewpoint) do
- valid_json['lines'][1]['superfluous_property'] = 123
+ valid_json["lines"][1]["superfluous_property"] = 123
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_lines))
end
end
- context 'with a missing property' do
+ context "with a missing property" do
let(:viewpoint_json_viewpoint) do
- valid_json['lines'][1].delete(:start_point)
+ valid_json["lines"][1].delete(:start_point)
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_lines))
end
end
- context 'with a missing dimension in one of the lines' do
+ context "with a missing dimension in one of the lines" do
let(:viewpoint_json_viewpoint) do
- valid_json['lines'][1][:end_point].delete(:y)
+ valid_json["lines"][1][:end_point].delete(:y)
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_lines))
end
end
- context 'with a non number in one of the points' do
+ context "with a non number in one of the points" do
let(:viewpoint_json_viewpoint) do
- valid_json['lines'][1][:start_point][:z] = "sdfjsdkf"
+ valid_json["lines"][1][:start_point][:z] = "sdfjsdkf"
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_lines))
end
end
end
- describe 'clipping_planes' do
+ describe "clipping_planes" do
let(:valid_json) do
{
clipping_planes: [
@@ -514,66 +514,66 @@ def expect_valid(valid, symbols = {})
valid_json
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
- context 'with a non array for lines' do
+ context "with a non array for lines" do
let(:viewpoint_json_viewpoint) do
{
"clipping_planes" => { "some" => "value" }
}
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_clipping_planes))
end
end
- context 'with an additional property for one line' do
+ context "with an additional property for one line" do
let(:viewpoint_json_viewpoint) do
- valid_json['clipping_planes'][1]['superfluous_property'] = 123
+ valid_json["clipping_planes"][1]["superfluous_property"] = 123
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_clipping_planes))
end
end
- context 'with a missing property' do
+ context "with a missing property" do
let(:viewpoint_json_viewpoint) do
- valid_json['clipping_planes'][1].delete(:direction)
+ valid_json["clipping_planes"][1].delete(:direction)
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_clipping_planes))
end
end
- context 'with a missing dimension in one of the lines' do
+ context "with a missing dimension in one of the lines" do
let(:viewpoint_json_viewpoint) do
- valid_json['clipping_planes'][1][:direction].delete(:y)
+ valid_json["clipping_planes"][1][:direction].delete(:y)
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_clipping_planes))
end
end
- context 'with a non number in one of the points' do
+ context "with a non number in one of the points" do
let(:viewpoint_json_viewpoint) do
- valid_json['clipping_planes'][1][:location][:z] = "sdfjsdkf"
+ valid_json["clipping_planes"][1][:location][:z] = "sdfjsdkf"
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_clipping_planes))
end
end
end
- describe 'bitmaps' do
+ describe "bitmaps" do
let(:viewpoint_json_viewpoint) do
{
bitmaps: [
@@ -582,12 +582,12 @@ def expect_valid(valid, symbols = {})
}.stringify_keys
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(bitmaps_not_writable))
end
end
- describe 'components' do
+ describe "components" do
let(:valid_json) do
{
components:
@@ -649,316 +649,316 @@ def expect_valid(valid, symbols = {})
valid_json
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
- context 'with a non hash' do
+ context "with a non hash" do
let(:viewpoint_json_viewpoint) do
{
"components" => 534
}
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with an additional property' do
+ context "with an additional property" do
let(:viewpoint_json_viewpoint) do
- valid_json['components']['superfluous_property'] = 123
+ valid_json["components"]["superfluous_property"] = 123
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with missing visibility property' do
+ context "with missing visibility property" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'].delete(:visibility)
+ valid_json["components"].delete(:visibility)
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with missing selection property' do
+ context "with missing selection property" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'].delete(:selection)
+ valid_json["components"].delete(:selection)
valid_json
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'with missing coloring property' do
+ context "with missing coloring property" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'].delete(:coloring)
+ valid_json["components"].delete(:coloring)
valid_json
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'with selection property not being an array of hashes' do
+ context "with selection property not being an array of hashes" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:selection] = ["blubs"]
+ valid_json["components"][:selection] = ["blubs"]
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with a property of the selection property not being string' do
+ context "with a property of the selection property not being string" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:selection][1][:ifcguid] = 345
+ valid_json["components"][:selection][1][:ifcguid] = 345
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with a component of the selection property having an unknown property' do
+ context "with a component of the selection property having an unknown property" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:selection][1]['superfluous'] = "sdsdsf"
+ valid_json["components"][:selection][1]["superfluous"] = "sdsdsf"
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with a component of the selection property being empty' do
+ context "with a component of the selection property being empty" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:selection][1] = {}
+ valid_json["components"][:selection][1] = {}
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with coloring property not being an array of hashes' do
+ context "with coloring property not being an array of hashes" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:coloring] = ["blubs"]
+ valid_json["components"][:coloring] = ["blubs"]
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with a coloring of the coloring property lacking a property' do
+ context "with a coloring of the coloring property lacking a property" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:coloring][1].delete(:color)
+ valid_json["components"][:coloring][1].delete(:color)
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with having an invalid color for coloring property' do
+ context "with having an invalid color for coloring property" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:coloring][1][:color] = '#ff54zzzz'
+ valid_json["components"][:coloring][1][:color] = "#ff54zzzz"
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with having a non string for color of a coloring property' do
+ context "with having a non string for color of a coloring property" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:coloring][1][:color] = 123456
+ valid_json["components"][:coloring][1][:color] = 123456
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with having a non array of hashes for components of a coloring property' do
+ context "with having a non array of hashes for components of a coloring property" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:coloring][1][:components] = ['blubs']
+ valid_json["components"][:coloring][1][:components] = ["blubs"]
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with having an invalid property in for a components of a coloring property' do
+ context "with having an invalid property in for a components of a coloring property" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:coloring][1][:components][0]['superfluous'] = 'blubs'
+ valid_json["components"][:coloring][1][:components][0]["superfluous"] = "blubs"
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with visibility property not being a hashes' do
+ context "with visibility property not being a hashes" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:visibility] = 'blubs'
+ valid_json["components"][:visibility] = "blubs"
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with visibility property having an unknown property' do
+ context "with visibility property having an unknown property" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:visibility]['superfluous'] = 'blubs'
+ valid_json["components"][:visibility]["superfluous"] = "blubs"
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with visibility property being an empty hash' do
+ context "with visibility property being an empty hash" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:visibility] = {}
+ valid_json["components"][:visibility] = {}
valid_json
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'with visibility property lacking a property' do
+ context "with visibility property lacking a property" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:visibility].delete(:exceptions)
+ valid_json["components"][:visibility].delete(:exceptions)
valid_json
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'with default_visibility of the visibility property being a non boolean' do
+ context "with default_visibility of the visibility property being a non boolean" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:visibility][:default_visibility] = 'blubs'
+ valid_json["components"][:visibility][:default_visibility] = "blubs"
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with components of the visibility property not being an array of hashes' do
+ context "with components of the visibility property not being an array of hashes" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:visibility][:exceptions] = ['blubs']
+ valid_json["components"][:visibility][:exceptions] = ["blubs"]
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with components of the visibility property having an invalid property' do
+ context "with components of the visibility property having an invalid property" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:visibility][:exceptions][0]['superfluous'] = 'blubs'
+ valid_json["components"][:visibility][:exceptions][0]["superfluous"] = "blubs"
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with on property of a components of the visibility property being a non string' do
+ context "with on property of a components of the visibility property being a non string" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:visibility][:exceptions][0][:originating_system] = 124
+ valid_json["components"][:visibility][:exceptions][0][:originating_system] = 124
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with view_setup_hints not being a hash' do
+ context "with view_setup_hints not being a hash" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:visibility][:view_setup_hints] = []
+ valid_json["components"][:visibility][:view_setup_hints] = []
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with view_setup_hints being an empty hash' do
+ context "with view_setup_hints being an empty hash" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:visibility][:view_setup_hints] = {}
+ valid_json["components"][:visibility][:view_setup_hints] = {}
valid_json
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'with view_setup_hints having an unknown parameter' do
+ context "with view_setup_hints having an unknown parameter" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:visibility][:view_setup_hints]['superfluous'] = 'blubs'
+ valid_json["components"][:visibility][:view_setup_hints]["superfluous"] = "blubs"
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
- context 'with a property of view_setup_hints being a non boolean' do
+ context "with a property of view_setup_hints being a non boolean" do
let(:viewpoint_json_viewpoint) do
- valid_json['components'][:visibility][:view_setup_hints][:openings_visible] = 'blubs'
+ valid_json["components"][:visibility][:view_setup_hints][:openings_visible] = "blubs"
valid_json
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(invalid_components))
end
end
end
- describe 'guid' do
- context 'with the same value the model has' do
+ describe "guid" do
+ context "with the same value the model has" do
let(:viewpoint_json_viewpoint) do
{
- 'guid' => viewpoint_uuid
+ "guid" => viewpoint_uuid
}
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'with a different value than the model has' do
+ context "with a different value than the model has" do
let(:viewpoint_json_viewpoint) do
{
- 'guid' => viewpoint_uuid + 'something'
+ "guid" => viewpoint_uuid + "something"
}
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, json_viewpoint: %i(mismatching_guid))
end
end
diff --git a/modules/bim/spec/contracts/ifc_models/create_contract_spec.rb b/modules/bim/spec/contracts/ifc_models/create_contract_spec.rb
index 7484466bcb46..2ea156c9bf21 100644
--- a/modules/bim/spec/contracts/ifc_models/create_contract_spec.rb
+++ b/modules/bim/spec/contracts/ifc_models/create_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Bim::IfcModels::CreateContract do
- it_behaves_like 'ifc model contract' do
+ it_behaves_like "ifc model contract" do
let(:ifc_model) do
Bim::IfcModels::IfcModel.new(project: model_project,
title: model_title,
diff --git a/modules/bim/spec/contracts/ifc_models/shared_contract_examples.rb b/modules/bim/spec/contracts/ifc_models/shared_contract_examples.rb
index 892bcbc2ef36..2beb40033c10 100644
--- a/modules/bim/spec/contracts/ifc_models/shared_contract_examples.rb
+++ b/modules/bim/spec/contracts/ifc_models/shared_contract_examples.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.shared_examples_for 'ifc model contract' do
+RSpec.shared_examples_for "ifc model contract" do
let(:current_user) { build_stubbed(:user) }
let(:other_user) { build_stubbed(:user) }
let(:model_project) { build_stubbed(:project) }
let(:ifc_attachment) { build_stubbed(:attachment, author: model_user) }
let(:model_user) { current_user }
- let(:model_title) { 'some title' }
+ let(:model_title) { "some title" }
before do
allow(ifc_model)
@@ -58,86 +58,86 @@ def expect_valid(valid, symbols = {})
end
end
- shared_examples 'is valid' do
- it 'is valid' do
+ shared_examples "is valid" do
+ it "is valid" do
expect_valid(true)
end
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
- context 'if the title is nil' do
+ context "if the title is nil" do
let(:model_title) { nil }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, title: %i(blank))
end
end
- context 'if the title is blank' do
- let(:model_title) { '' }
+ context "if the title is blank" do
+ let(:model_title) { "" }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, title: %i(blank))
end
end
- context 'if the project is nil' do
+ context "if the project is nil" do
let(:model_project) { nil }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, project: %i(blank))
end
end
- context 'if there is no ifc attachment' do
+ context "if there is no ifc attachment" do
let(:ifc_attachment) { nil }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, base: %i(ifc_attachment_missing))
end
end
- context 'if the new ifc file is no valid ifc file' do
- let(:ifc_file) { FileHelpers.mock_uploaded_file name: "model.ifc", content_type: 'application/binary', binary: true }
+ context "if the new ifc file is no valid ifc file" do
+ let(:ifc_file) { FileHelpers.mock_uploaded_file name: "model.ifc", content_type: "application/binary", binary: true }
let(:ifc_attachment) do
Attachments::BuildService
.bypass_whitelist(user: current_user)
- .call(file: ifc_file, filename: 'model.ifc')
+ .call(file: ifc_file, filename: "model.ifc")
.result
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, base: %i(invalid_ifc_file))
end
end
- context 'if the new ifc file is a valid ifc file' do
+ context "if the new ifc file is a valid ifc file" do
let(:ifc_file) do
- FileHelpers.mock_uploaded_file name: "model.ifc", content_type: 'application/binary', binary: true, content: "ISO-10303-21;"
+ FileHelpers.mock_uploaded_file name: "model.ifc", content_type: "application/binary", binary: true, content: "ISO-10303-21;"
end
let(:ifc_attachment) do
Attachments::BuildService
.bypass_whitelist(user: current_user)
- .call(file: ifc_file, filename: 'model.ifc')
+ .call(file: ifc_file, filename: "model.ifc")
.result
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if user is not allowed to manage ifc models' do
+ context "if user is not allowed to manage ifc models" do
let(:permissions) { [] }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, base: %i(error_unauthorized))
end
end
- context 'if user of attachment and uploader are different' do
+ context "if user of attachment and uploader are different" do
let(:ifc_attachment) { build_stubbed(:attachment, author: other_user) }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, uploader_id: %i(invalid))
end
end
diff --git a/modules/bim/spec/contracts/ifc_models/update_contract_spec.rb b/modules/bim/spec/contracts/ifc_models/update_contract_spec.rb
index 422c0bae85a0..10297d9c4f26 100644
--- a/modules/bim/spec/contracts/ifc_models/update_contract_spec.rb
+++ b/modules/bim/spec/contracts/ifc_models/update_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Bim::IfcModels::UpdateContract do
- it_behaves_like 'ifc model contract' do
+ it_behaves_like "ifc model contract" do
subject(:contract) { described_class.new(ifc_model, current_user) }
let(:ifc_model) do
@@ -53,34 +53,34 @@
let(:uploader_user) { model_user }
let(:changed_by_system) { false }
- context 'if the uploader changes' do
+ context "if the uploader changes" do
let(:model_user) { build_stubbed(:user) }
let(:uploader_user) { other_user }
let(:current_user) { other_user }
let(:ifc_attachment) { build_stubbed(:attachment, author: other_user) }
- it 'is invalid as not writable' do
+ it "is invalid as not writable" do
expect_valid(false, uploader_id: %i(error_readonly))
end
end
- context 'if the uploader changes' do
+ context "if the uploader changes" do
let(:model_user) { build_stubbed(:user) }
let(:uploader_user) { other_user }
let(:current_user) { other_user }
let(:ifc_attachment) { build_stubbed(:attachment, author: other_user) }
let(:changed_by_system) { true }
- it 'is invalid as does not match' do
+ it "is invalid as does not match" do
expect_valid(false, uploader_id: %i(invalid))
end
end
- context 'if the uploader does not change and the current user is different from the uploader' do
+ context "if the uploader does not change and the current user is different from the uploader" do
let(:current_user) { other_user }
let(:model_user) { build_stubbed(:user) }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
end
end
diff --git a/modules/bim/spec/contracts/views/create_contract_bim_spec.rb b/modules/bim/spec/contracts/views/create_contract_bim_spec.rb
index eae212202e5a..154a87dc36ca 100644
--- a/modules/bim/spec/contracts/views/create_contract_bim_spec.rb
+++ b/modules/bim/spec/contracts/views/create_contract_bim_spec.rb
@@ -26,18 +26,18 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
-require 'contracts/views/shared_contract_examples'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
+require "contracts/views/shared_contract_examples"
RSpec.describe Views::CreateContract do
- it_behaves_like 'view contract', true do
+ it_behaves_like "view contract", true do
let(:view) do
View.new(query: view_query,
type: view_type)
end
let(:view_type) do
- 'bim'
+ "bim"
end
let(:permissions) do
%i[view_work_packages
@@ -52,48 +52,48 @@
described_class.new(view, current_user)
end
- describe 'validation' do
- context 'with the type being nil' do
+ describe "validation" do
+ context "with the type being nil" do
let(:view_type) { nil }
- it_behaves_like 'contract is invalid', type: :inclusion
+ it_behaves_like "contract is invalid", type: :inclusion
end
- context 'with the type not being one of the configured' do
- let(:view_type) { 'blubs' }
+ context "with the type not being one of the configured" do
+ let(:view_type) { "blubs" }
- it_behaves_like 'contract is invalid', type: :inclusion
+ it_behaves_like "contract is invalid", type: :inclusion
end
- context 'without the :view_ifc_models permission' do
+ context "without the :view_ifc_models permission" do
let(:permissions) { %i[view_work_packages save_queries save_bcf_queries] }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
- context 'without the :save_bcf_queries permission' do
+ context "without the :save_bcf_queries permission" do
let(:permissions) { %i[view_ifc_models view_work_packages save_queries] }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
- context 'with a public query and without the :manage_public_bcf_queries permission' do
+ context "with a public query and without the :manage_public_bcf_queries permission" do
let(:query_public) { true }
let(:permissions) { %i[view_ifc_models view_work_packages save_queries save_bcf_queries manage_public_queries] }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
- context 'with a public query and all necessary permissions' do
+ context "with a public query and all necessary permissions" do
let(:query_public) { true }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'with a private query and all necessary permissions' do
+ context "with a private query and all necessary permissions" do
let(:permissions) { %i[view_work_packages view_ifc_models save_queries save_bcf_queries] }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
end
end
diff --git a/modules/bim/spec/controllers/issues_controller_spec.rb b/modules/bim/spec/controllers/issues_controller_spec.rb
index f80460faac86..62a2f1afda06 100644
--- a/modules/bim/spec/controllers/issues_controller_spec.rb
+++ b/modules/bim/spec/controllers/issues_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Bim::Bcf::IssuesController do
let(:manage_bcf_role) do
@@ -42,7 +42,7 @@
let(:non_member) { create(:user) }
let(:project) do
- create(:project, enabled_module_names: %w[bim], identifier: 'bim_project')
+ create(:project, enabled_module_names: %w[bim], identifier: "bim_project")
end
let(:member) do
create(:member,
@@ -63,11 +63,11 @@
login_as(bcf_manager)
end
- shared_examples_for 'check permissions' do
- context 'without sufficient permissions' do
+ shared_examples_for "check permissions" do
+ context "without sufficient permissions" do
before { action }
- context 'not member of project' do
+ context "not member of project" do
let(:bcf_manager_member) {}
it 'returns "not authorized"' do
@@ -75,7 +75,7 @@
end
end
- context 'no manage_bcf permission' do
+ context "no manage_bcf permission" do
let(:bcf_manager_member) do
create(:member,
project:,
@@ -90,7 +90,7 @@
end
end
- describe '#prepare_import' do
+ describe "#prepare_import" do
let(:params) do
{
project_id: project.identifier.to_s,
@@ -101,16 +101,16 @@
post :prepare_import, params:
end
- context 'with valid BCF file' do
- let(:filename) { 'MaximumInformation.bcf' }
+ context "with valid BCF file" do
+ let(:filename) { "MaximumInformation.bcf" }
let(:file) do
Rack::Test::UploadedFile.new(
Rails.root.join("modules/bim/spec/fixtures/files/#{filename}").to_s,
- 'application/zip'
+ "application/zip"
)
end
- it 'is successful' do
+ it "is successful" do
expect { action }.to change { Attachment.count }.by(1)
expect(response).to be_successful
end
@@ -118,27 +118,27 @@
it_behaves_like "check permissions"
end
- context 'with invalid BCF file' do
+ context "with invalid BCF file" do
let(:file) { FileHelpers.mock_uploaded_file }
- it 'redirects back to where we started from' do
+ it "redirects back to where we started from" do
expect { action }.not_to change { Attachment.count }
- expect(response).to redirect_to '/projects/bim_project/issues/upload'
+ expect(response).to redirect_to "/projects/bim_project/issues/upload"
end
end
end
- describe '#configure_import' do
+ describe "#configure_import" do
let(:action) do
post :configure_import, params: { project_id: project.identifier.to_s }
end
- context 'with valid BCF file' do
- let(:filename) { 'MaximumInformation.bcf' }
+ context "with valid BCF file" do
+ let(:filename) { "MaximumInformation.bcf" }
let(:file) do
Rack::Test::UploadedFile.new(
Rails.root.join("modules/bim/spec/fixtures/files/#{filename}").to_s,
- 'application/octet-stream'
+ "application/octet-stream"
)
end
@@ -147,7 +147,7 @@
allow(Attachment).to receive(:find_by).and_return(Attachment.new)
end
- it 'is successful' do
+ it "is successful" do
expect { action }.not_to change { Attachment.count }
expect(response).to be_successful
end
@@ -156,17 +156,17 @@
end
end
- describe '#perform_import' do
+ describe "#perform_import" do
let(:action) do
post :perform_import, params: { project_id: project.identifier.to_s }
end
- context 'with valid BCF file' do
- let(:filename) { 'MaximumInformation.bcf' }
+ context "with valid BCF file" do
+ let(:filename) { "MaximumInformation.bcf" }
let(:file) do
Rack::Test::UploadedFile.new(
Rails.root.join("modules/bim/spec/fixtures/files/#{filename}").to_s,
- 'application/octet-stream'
+ "application/octet-stream"
)
end
@@ -175,7 +175,7 @@
allow(Attachment).to receive(:find_by).and_return(Attachment.new)
end
- it 'is successful' do
+ it "is successful" do
expect { action }.not_to change { Attachment.count }
expect(response).to be_successful
end
diff --git a/modules/bim/spec/controllers/work_packages_controller_spec.rb b/modules/bim/spec/controllers/work_packages_controller_spec.rb
index 01909e7fc1d6..23f146acb7ad 100644
--- a/modules/bim/spec/controllers/work_packages_controller_spec.rb
+++ b/modules/bim/spec/controllers/work_packages_controller_spec.rb
@@ -26,18 +26,18 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WorkPackagesController do
before do
login_as current_user
end
- let(:stub_project) { build_stubbed(:project, identifier: 'test_project', public: false) }
+ let(:stub_project) { build_stubbed(:project, identifier: "test_project", public: false) }
let(:current_user) { build_stubbed(:user) }
let(:work_packages) { [build_stubbed(:work_package)] }
- describe 'index' do
+ describe "index" do
let(:query) do
build_stubbed(:query)
end
@@ -47,12 +47,12 @@
allow(controller).to receive(:retrieve_query).and_return(query)
end
- describe 'bcf' do
- let(:mime_type) { 'bcf' }
+ describe "bcf" do
+ let(:mime_type) { "bcf" }
let(:export_storage) { build_stubbed(:work_packages_export) }
before do
- service_instance = double('service_instance')
+ service_instance = double("service_instance")
allow(WorkPackages::Exports::ScheduleService)
.to receive(:new)
@@ -62,19 +62,19 @@
allow(service_instance)
.to receive(:call)
.with(query:, mime_type: mime_type.to_sym, params: anything)
- .and_return(ServiceResult.failure(result: 'uuid of the export job'))
+ .and_return(ServiceResult.failure(result: "uuid of the export job"))
end
- it 'redirects to the export' do
- get 'index', params: { format: 'bcf' }
- expect(response).to redirect_to job_status_path('uuid of the export job')
+ it "redirects to the export" do
+ get "index", params: { format: "bcf" }
+ expect(response).to redirect_to job_status_path("uuid of the export job")
end
- context 'with json accept' do
- it 'fulfills the defined should_receives' do
- request.headers['Accept'] = 'application/json'
- get 'index', params: { format: 'bcf' }
- expect(response.body).to eq({ job_id: 'uuid of the export job' }.to_json)
+ context "with json accept" do
+ it "fulfills the defined should_receives" do
+ request.headers["Accept"] = "application/json"
+ get "index", params: { format: "bcf" }
+ expect(response.body).to eq({ job_id: "uuid of the export job" }.to_json)
end
end
end
diff --git a/modules/bim/spec/factories/bcf_comment_factory.rb b/modules/bim/spec/factories/bcf_comment_factory.rb
index 5aeb2a08d65e..2a10e6715b3f 100644
--- a/modules/bim/spec/factories/bcf_comment_factory.rb
+++ b/modules/bim/spec/factories/bcf_comment_factory.rb
@@ -27,7 +27,7 @@
#++
FactoryBot.define do
- factory :bcf_comment, class: '::Bim::Bcf::Comment' do
+ factory :bcf_comment, class: "::Bim::Bcf::Comment" do
transient do
author { nil }
end
@@ -38,7 +38,7 @@
else
create(:work_package_journal, user: evaluator.author)
end
- bcf_comment.journal.update_attribute(:notes, 'Some BCF comment.')
+ bcf_comment.journal.update_attribute(:notes, "Some BCF comment.")
bcf_comment.journal.save
bcf_comment.save
end
diff --git a/modules/bim/spec/factories/bcf_issue_factory.rb b/modules/bim/spec/factories/bcf_issue_factory.rb
index 55c9b2db6f73..a24ac7d5c755 100644
--- a/modules/bim/spec/factories/bcf_issue_factory.rb
+++ b/modules/bim/spec/factories/bcf_issue_factory.rb
@@ -27,7 +27,7 @@
#++
FactoryBot.define do
- factory :bcf_issue, class: '::Bim::Bcf::Issue' do
+ factory :bcf_issue, class: "::Bim::Bcf::Issue" do
markup do
<<-MARKUP
diff --git a/modules/bim/spec/factories/bcf_viewpoint_attachment_factory.rb b/modules/bim/spec/factories/bcf_viewpoint_attachment_factory.rb
index bab80b0e1fe2..27567f0907ee 100644
--- a/modules/bim/spec/factories/bcf_viewpoint_attachment_factory.rb
+++ b/modules/bim/spec/factories/bcf_viewpoint_attachment_factory.rb
@@ -27,7 +27,7 @@
#++
FactoryBot.define do
- factory :bcf_viewpoint_attachment, class: 'Attachment' do
+ factory :bcf_viewpoint_attachment, class: "Attachment" do
description { "snapshot" }
filename { "image.png" }
content_type { "image/jpeg" }
@@ -35,7 +35,7 @@
file do
Rack::Test::UploadedFile.new(
Rails.root.join("spec/fixtures/files/image.png"),
- 'image/png',
+ "image/png",
true
)
end
diff --git a/modules/bim/spec/factories/bcf_viewpoint_factory.rb b/modules/bim/spec/factories/bcf_viewpoint_factory.rb
index 6a4fb633402d..3baa3902cbc4 100644
--- a/modules/bim/spec/factories/bcf_viewpoint_factory.rb
+++ b/modules/bim/spec/factories/bcf_viewpoint_factory.rb
@@ -27,7 +27,7 @@
#++
FactoryBot.define do
- factory :bcf_viewpoint, class: '::Bim::Bcf::Viewpoint' do
+ factory :bcf_viewpoint, class: "::Bim::Bcf::Viewpoint" do
new_uuid = SecureRandom.uuid
uuid { new_uuid }
viewpoint_name { "full_viewpoint.bcfv" }
diff --git a/modules/bim/spec/factories/ifc_model_factory.rb b/modules/bim/spec/factories/ifc_model_factory.rb
index cdb4f9a6c88b..cc8693408e05 100644
--- a/modules/bim/spec/factories/ifc_model_factory.rb
+++ b/modules/bim/spec/factories/ifc_model_factory.rb
@@ -27,7 +27,7 @@
#++
FactoryBot.define do
- factory :ifc_model, class: '::Bim::IfcModels::IfcModel' do
+ factory :ifc_model, class: "::Bim::IfcModels::IfcModel" do
sequence(:title) { |n| "Unconverted IFC model #{n}" }
project factory: :project
uploader factory: :user
@@ -36,7 +36,7 @@
ifc_attachment do
Rack::Test::UploadedFile.new(
Rails.root.join("modules/bim/spec/fixtures/files/minimal.ifc").to_s,
- 'application/binary'
+ "application/binary"
)
end
@@ -56,7 +56,7 @@
xkt_attachment do
Rack::Test::UploadedFile.new(
Rails.root.join("modules/bim/spec/fixtures/files/minimal.xkt").to_s,
- 'application/binary'
+ "application/binary"
)
end
end
@@ -69,7 +69,7 @@
end
end
- factory :ifc_model_without_ifc_attachment, class: '::Bim::IfcModels::IfcModel' do
+ factory :ifc_model_without_ifc_attachment, class: "::Bim::IfcModels::IfcModel" do
sequence(:title) { |n| "Model without ifc_attachment #{n}" }
project factory: :project
uploader factory: :user
diff --git a/modules/bim/spec/factories/xml_viewpoint_factory.rb b/modules/bim/spec/factories/xml_viewpoint_factory.rb
index b6a03fb95d8a..6d39db3ecca5 100644
--- a/modules/bim/spec/factories/xml_viewpoint_factory.rb
+++ b/modules/bim/spec/factories/xml_viewpoint_factory.rb
@@ -27,7 +27,7 @@
#++
FactoryBot.define do
- factory :xml_viewpoint, class: 'OpenStruct' do
+ factory :xml_viewpoint, class: "OpenStruct" do
uuid { SecureRandom.uuid }
viewpoint_name { "full_viewpoint.bcfv" }
viewpoint do
diff --git a/modules/bim/spec/features/bcf/api_authorization_spec.rb b/modules/bim/spec/features/bcf/api_authorization_spec.rb
index eeb822dcb723..86ee75b12cb6 100644
--- a/modules/bim/spec/features/bcf/api_authorization_spec.rb
+++ b/modules/bim/spec/features/bcf/api_authorization_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'authorization for BCF api', :js, with_config: { edition: 'bim' } do
+RSpec.describe "authorization for BCF api", :js, with_config: { edition: "bim" } do
let!(:user) { create(:admin) }
let(:client_secret) { app.plaintext_secret }
- let(:scope) { 'bcf_v2_1' }
+ let(:scope) { "bcf_v2_1" }
let!(:project) { create(:project, enabled_module_names: [:bim]) }
def oauth_path(client_id)
@@ -39,38 +39,38 @@ def oauth_path(client_id)
end
before do
- login_with user.login, 'adminADMIN!'
+ login_with user.login, "adminADMIN!"
visit oauth_applications_path
end
- it 'can create and later authorize and manage an OAuth application grant and then use the access token for the bcf api' do
+ it "can create and later authorize and manage an OAuth application grant and then use the access token for the bcf api" do
# Initially empty
- expect(page).to have_css('.generic-table--empty-row', text: 'There is currently nothing to display')
+ expect(page).to have_css(".generic-table--empty-row", text: "There is currently nothing to display")
# Create application
- find('.button', text: 'Add').click
- fill_in 'application_name', with: 'My API application'
+ find(".button", text: "Add").click
+ fill_in "application_name", with: "My API application"
# Limit to bcf access
check scope
# Fill invalid redirect_uri
- fill_in 'application_redirect_uri', with: "not a url!"
- click_on 'Create'
+ fill_in "application_redirect_uri", with: "not a url!"
+ click_on "Create"
- expect(page).to have_css('.errorExplanation', text: 'Redirect URI must be an absolute URI.')
- fill_in 'application_redirect_uri', with: "urn:ietf:wg:oauth:2.0:oob\nhttps://localhost/my/callback"
- click_on 'Create'
+ expect(page).to have_css(".errorExplanation", text: "Redirect URI must be an absolute URI.")
+ fill_in "application_redirect_uri", with: "urn:ietf:wg:oauth:2.0:oob\nhttps://localhost/my/callback"
+ click_on "Create"
- expect(page).to have_css('.op-toast.-success', text: 'Successful creation.')
+ expect(page).to have_css(".op-toast.-success", text: "Successful creation.")
- expect(page).to have_css('.attributes-key-value--key',
- text: 'Client ID')
- expect(page).to have_css('.attributes-key-value--value',
+ expect(page).to have_css(".attributes-key-value--key",
+ text: "Client ID")
+ expect(page).to have_css(".attributes-key-value--value",
text: "urn:ietf:wg:oauth:2.0:oob\nhttps://localhost/my/callback")
# Should print secret on initial visit
- expect(page).to have_css('.attributes-key-value--key', text: 'Client secret')
- client_secret = page.first('.attributes-key-value--value code').text
+ expect(page).to have_css(".attributes-key-value--key", text: "Client secret")
+ client_secret = page.first(".attributes-key-value--value code").text
expect(client_secret).to match /\w+/
app = Doorkeeper::Application.first
@@ -78,17 +78,17 @@ def oauth_path(client_id)
visit oauth_path app.uid
# We get to the authorization screen
- expect(page).to have_css('h2', text: 'Authorize My API application')
+ expect(page).to have_css("h2", text: "Authorize My API application")
# With the correct scope printed
- expect(page).to have_css('li strong', text: I18n.t('oauth.scopes.bcf_v2_1'))
- expect(page).to have_css('li', text: I18n.t('oauth.scopes.bcf_v2_1_text'))
+ expect(page).to have_css("li strong", text: I18n.t("oauth.scopes.bcf_v2_1"))
+ expect(page).to have_css("li", text: I18n.t("oauth.scopes.bcf_v2_1_text"))
# Authorize
find('input.button[value="Authorize"]').click
# Expect auth token
- code = find_by_id('authorization_code').text
+ code = find_by_id("authorization_code").text
# And also have a grant for this application
user.oauth_grants.reload
@@ -108,18 +108,18 @@ def oauth_path(client_id)
expect(response).to eq 200
body = JSON.parse(session.response.body)
- expect(body['access_token']).to be_present
- expect(body['refresh_token']).to be_present
- expect(body['scope']).to eq scope
+ expect(body["access_token"]).to be_present
+ expect(body["refresh_token"]).to be_present
+ expect(body["scope"]).to eq scope
- access_token = body['access_token']
+ access_token = body["access_token"]
# Should show that grant in my account
visit my_account_path
- click_on 'Access token'
+ click_on "Access token"
expect(page).to have_css("#oauth-application-grant-#{app.id}", text: app.name)
- expect(page).to have_css('td', text: app.name)
+ expect(page).to have_css("td", text: app.name)
# While being logged in, the api can be accessed with the session
visit("/api/bcf/2.1/projects/#{project.id}")
@@ -135,7 +135,7 @@ def oauth_path(client_id)
# - The register method is not recognized by selenium-webdriver with Chrome
# 120 with old headless
if page.driver.browser.respond_to?(:register)
- page.driver.browser.register(username: 'foo', password: 'bar', uri: /does_not_match/)
+ page.driver.browser.register(username: "foo", password: "bar", uri: /does_not_match/)
end
# While not being logged in and without a token, the api cannot be accessed
visit("/api/bcf/2.1/projects/#{project.id}")
diff --git a/modules/bim/spec/features/bcf/bcf_snapshot_column_spec.rb b/modules/bim/spec/features/bcf/bcf_snapshot_column_spec.rb
index 02a41b1a13b4..593e39859644 100644
--- a/modules/bim/spec/features/bcf/bcf_snapshot_column_spec.rb
+++ b/modules/bim/spec/features/bcf/bcf_snapshot_column_spec.rb
@@ -1,7 +1,7 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'BCF snapshot column', :js,
- with_config: { edition: 'bim' } do
+RSpec.describe "BCF snapshot column", :js,
+ with_config: { edition: "bim" } do
let(:project) { create(:project, enabled_module_names: %w[bim work_package_tracking]) }
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
let(:permissions) { %i[add_work_packages view_work_packages view_linked_issues] }
@@ -13,7 +13,7 @@
end
let!(:query) do
query = build(:query, user:, project:)
- query.column_names = ['subject', 'bcf_thumbnail']
+ query.column_names = ["subject", "bcf_thumbnail"]
query.filters.clear
query.show_hierarchies = false
@@ -25,7 +25,7 @@
login_as(user)
end
- it 'shows BCF snapshot column correctly (Regression)' do
+ it "shows BCF snapshot column correctly (Regression)" do
wp_table.visit_query query
wp_table.expect_work_package_listed(work_package)
diff --git a/modules/bim/spec/features/bcf/create_spec.rb b/modules/bim/spec/features/bcf/create_spec.rb
index 5ade3b6bd11a..c3c4b34f575f 100644
--- a/modules/bim/spec/features/bcf/create_spec.rb
+++ b/modules/bim/spec/features/bcf/create_spec.rb
@@ -1,7 +1,7 @@
-require_relative '../../spec_helper'
+require_relative "../../spec_helper"
-RSpec.describe 'Create BCF', :js,
- with_config: { edition: 'bim' } do
+RSpec.describe "Create BCF", :js,
+ with_config: { edition: "bim" } do
let(:project) do
create(:project,
types: [type, type_with_cf],
@@ -31,7 +31,7 @@
create(:integer_wp_custom_field)
end
- shared_examples 'bcf details creation' do |with_viewpoints:|
+ shared_examples "bcf details creation" do |with_viewpoints:|
it "can create a new #{with_viewpoints ? 'bcf' : 'plain'} work package" do
create_page = index_page.create_wp_by_button(type)
@@ -70,7 +70,7 @@
create_page.save!
index_page.expect_and_dismiss_toaster(
- message: 'Successful creation. Click here to open this work package in fullscreen view.'
+ message: "Successful creation. Click here to open this work package in fullscreen view."
)
if with_viewpoints
@@ -98,46 +98,46 @@
login_as(user)
end
- context 'with all permissions' do
- context 'when on default view' do
+ context "with all permissions" do
+ context "when on default view" do
before do
index_page.visit_and_wait_until_finished_loading!
end
- it_behaves_like 'bcf details creation', with_viewpoints: true
+ it_behaves_like "bcf details creation", with_viewpoints: true
end
- context 'when going to split table view first' do
+ context "when going to split table view first" do
before do
index_page.visit_and_wait_until_finished_loading!
- index_page.switch_view 'Viewer and table'
+ index_page.switch_view "Viewer and table"
end
- it_behaves_like 'bcf details creation', with_viewpoints: true
+ it_behaves_like "bcf details creation", with_viewpoints: true
end
- context 'when going to cards view first' do
+ context "when going to cards view first" do
before do
index_page.visit_and_wait_until_finished_loading!
- index_page.switch_view 'Cards'
+ index_page.switch_view "Cards"
end
- it_behaves_like 'bcf details creation', with_viewpoints: false
+ it_behaves_like "bcf details creation", with_viewpoints: false
end
- context 'when going to table view first' do
+ context "when going to table view first" do
before do
index_page.visit_and_wait_until_finished_loading!
- index_page.switch_view 'Table'
+ index_page.switch_view "Table"
end
- it_behaves_like 'bcf details creation', with_viewpoints: false
+ it_behaves_like "bcf details creation", with_viewpoints: false
end
- context 'when starting on the details page of an existing work package' do
+ context "when starting on the details page of an existing work package" do
let(:work_package) { create(:work_package, project:) }
before do
@@ -146,29 +146,29 @@
index_page.expect_details_path
end
- it_behaves_like 'bcf details creation', with_viewpoints: true
+ it_behaves_like "bcf details creation", with_viewpoints: true
end
end
- context 'without add_work_packages permission' do
+ context "without add_work_packages permission" do
let(:permissions) { %i[view_ifc_models manage_bcf view_work_packages] }
- it 'has the create button disabled' do
+ it "has the create button disabled" do
index_page.visit_and_wait_until_finished_loading!
index_page.expect_wp_create_button_disabled
end
end
- context 'with add_work_packages but without manage_bcf permission' do
+ context "with add_work_packages but without manage_bcf permission" do
let(:permissions) { %i[view_ifc_models view_work_packages add_work_packages] }
- context 'when on default view' do
+ context "when on default view" do
before do
index_page.visit_and_wait_until_finished_loading!
end
- it_behaves_like 'bcf details creation', with_viewpoints: false
+ it_behaves_like "bcf details creation", with_viewpoints: false
end
end
end
diff --git a/modules/bim/spec/features/bcf/export_spec.rb b/modules/bim/spec/features/bcf/export_spec.rb
index a18724bd9af7..91509031f210 100644
--- a/modules/bim/spec/features/bcf/export_spec.rb
+++ b/modules/bim/spec/features/bcf/export_spec.rb
@@ -25,17 +25,17 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../../support/pages/ifc_models/show_default'
+require "spec_helper"
+require_relative "../../support/pages/ifc_models/show_default"
-RSpec.describe 'bcf export', :js,
- with_config: { edition: 'bim' } do
- let(:status) { create(:status, name: 'New', is_default: true) }
- let(:closed_status) { create(:closed_status, name: 'Closed') }
+RSpec.describe "bcf export", :js,
+ with_config: { edition: "bim" } do
+ let(:status) { create(:status, name: "New", is_default: true) }
+ let(:closed_status) { create(:closed_status, name: "Closed") }
let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) }
- let!(:open_work_package) { create(:work_package, project:, subject: 'Open WP', status:) }
- let!(:closed_work_package) { create(:work_package, project:, subject: 'Closed WP', status: closed_status) }
+ let!(:open_work_package) { create(:work_package, project:, subject: "Open WP", status:) }
+ let!(:closed_work_package) { create(:work_package, project:, subject: "Closed WP", status: closed_status) }
let!(:open_bcf_issue) { create(:bcf_issue, work_package: open_work_package) }
let!(:closed_bcf_issue) { create(:bcf_issue, work_package: closed_work_package) }
@@ -75,17 +75,17 @@
def export_into_bcf_extractor
DownloadList.clear
- page.find('.export-bcf-button').click
+ page.find(".export-bcf-button").click
# Expect to get a response regarding queuing
- expect(page).to have_content(I18n.t('js.job_status.generic_messages.in_queue'),
+ expect(page).to have_content(I18n.t("js.job_status.generic_messages.in_queue"),
wait: 10)
perform_enqueued_jobs
expect(page).to have_text("completed successfully")
# Close the modal
- page.find('.spot-modal-overlay').click
+ page.find(".spot-modal-overlay").click
@download_list.refresh_from(page)
@@ -97,7 +97,7 @@ def export_into_bcf_extractor
).extractor_list
end
- it 'can export the open and closed BCF issues (Regression #30953)' do
+ it "can export the open and closed BCF issues (Regression #30953)" do
model_page.visit!
wp_cards.expect_work_package_listed(open_work_package)
wp_cards.expect_work_package_not_listed(closed_work_package)
@@ -106,12 +106,12 @@ def export_into_bcf_extractor
# Expect only the open issue
extractor_list = export_into_bcf_extractor
expect(extractor_list.length).to eq(1)
- expect(extractor_list.first[:title]).to eq('Open WP')
+ expect(extractor_list.first[:title]).to eq("Open WP")
model_page.visit!
# Change the query to show all statuses
filters.open
- filters.remove_filter('status')
+ filters.remove_filter("status")
filters.expect_filter_count(0)
wp_cards.expect_work_package_listed(open_work_package, closed_work_package)
@@ -121,6 +121,6 @@ def export_into_bcf_extractor
expect(extractor_list.length).to eq(2)
titles = extractor_list.pluck(:title)
- expect(titles).to contain_exactly('Open WP', 'Closed WP')
+ expect(titles).to contain_exactly("Open WP", "Closed WP")
end
end
diff --git a/modules/bim/spec/features/bcf_view_management_spec.rb b/modules/bim/spec/features/bcf_view_management_spec.rb
index d153b63df102..b512690e4df2 100644
--- a/modules/bim/spec/features/bcf_view_management_spec.rb
+++ b/modules/bim/spec/features/bcf_view_management_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/ifc_models/show_default'
-require_relative '../../../../spec/features/views/shared_examples'
+require_relative "../support/pages/ifc_models/show_default"
+require_relative "../../../../spec/features/views/shared_examples"
-RSpec.describe 'bcf view management', :js, with_config: { edition: 'bim' } do
+RSpec.describe "bcf view management", :js, with_config: { edition: "bim" } do
let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) }
let(:bcf_page) { Pages::IfcModels::ShowDefault.new(project) }
let(:role) do
@@ -63,9 +63,9 @@
bcf_page.visit_and_wait_until_finished_loading!
end
- it_behaves_like 'module specific query view management' do
+ it_behaves_like "module specific query view management" do
let(:module_page) { bcf_page }
- let(:default_name) { 'All open' }
+ let(:default_name) { "All open" }
let(:initial_filter_count) { 0 }
end
end
diff --git a/modules/bim/spec/features/bim_filter_spec.rb b/modules/bim/spec/features/bim_filter_spec.rb
index 78fcde873f70..d649529d3a27 100644
--- a/modules/bim/spec/features/bim_filter_spec.rb
+++ b/modules/bim/spec/features/bim_filter_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/ifc_models/show'
-require_relative '../support/pages/ifc_models/show_default'
+require_relative "../support/pages/ifc_models/show"
+require_relative "../support/pages/ifc_models/show_default"
-RSpec.describe 'BIM filter spec', :js, with_config: { edition: 'bim' } do
+RSpec.describe "BIM filter spec", :js, with_config: { edition: "bim" } do
let(:project) { create(:project, enabled_module_names: %w(bim work_package_tracking)) }
let(:open_status) { create(:status, is_closed: false) }
let(:closed_status) { create(:status, is_closed: true) }
@@ -60,28 +60,28 @@
model_page.finished_loading
end
- context 'on default page' do
+ context "on default page" do
before do
# Per default all open work packages are shown
filters.expect_loaded
filters.expect_filter_count 1
filters.open
- filters.expect_filter_by('Status', 'open', nil)
+ filters.expect_filter_by("Status", "open", nil)
card_view.expect_work_package_listed wp1
card_view.expect_work_package_not_listed wp2
end
- it 'shows a filter button when there is a list shown' do
+ it "shows a filter button when there is a list shown" do
model_page.page_shows_a_filter_button true
- model_page.switch_view 'Viewer'
+ model_page.switch_view "Viewer"
model_page.page_shows_a_filter_button false
end
- it 'the filter is applied even after browser back' do
+ it "the filter is applied even after browser back" do
# Change filter
- filters.set_operator('Status', 'closed', nil)
+ filters.set_operator("Status", "closed", nil)
filters.expect_filter_count 1
card_view.expect_work_package_listed wp2
@@ -93,15 +93,15 @@
filters.expect_loaded
filters.expect_filter_count 1
- filters.expect_filter_by('Status', 'open', nil)
+ filters.expect_filter_by("Status", "open", nil)
card_view.expect_work_package_listed wp1
card_view.expect_work_package_not_listed wp2
end
- it 'the filter is applied even after reload' do
+ it "the filter is applied even after reload" do
# Change filter
- filters.set_operator('Status', 'closed', nil)
+ filters.set_operator("Status", "closed", nil)
filters.expect_filter_count 1
card_view.expect_work_package_listed wp2
@@ -113,7 +113,7 @@
filters.expect_loaded
filters.expect_filter_count 1
filters.open
- filters.expect_filter_by('Status', 'closed', nil)
+ filters.expect_filter_by("Status", "closed", nil)
card_view.expect_work_package_listed wp2
card_view.expect_work_package_not_listed wp1
diff --git a/modules/bim/spec/features/bim_navigation_spec.rb b/modules/bim/spec/features/bim_navigation_spec.rb
index 8c519796f9cd..45a1473b378a 100644
--- a/modules/bim/spec/features/bim_navigation_spec.rb
+++ b/modules/bim/spec/features/bim_navigation_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative '../spec_helper'
+require_relative "../spec_helper"
-RSpec.describe 'BIM navigation spec', :js, with_config: { edition: 'bim' } do
+RSpec.describe "BIM navigation spec", :js, with_config: { edition: "bim" } do
let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) }
let!(:work_package) { create(:work_package, project:) }
let(:role) do
@@ -57,13 +57,13 @@
model
end
- shared_examples 'can switch from split to viewer to list-only' do
+ shared_examples "can switch from split to viewer to list-only" do
before do
model_page.visit!
model_page.finished_loading
end
- context 'deep link on the page' do
+ context "deep link on the page" do
before do
model_page.visit!
model_page.finished_loading
@@ -73,22 +73,22 @@
model_page.model_viewer_shows_a_toolbar true
model_page.page_shows_a_toolbar true
model_tree.sidebar_shows_viewer_menu true
- expect(page).to have_test_selector('op-wp-card-view')
+ expect(page).to have_test_selector("op-wp-card-view")
card_view.expect_work_package_listed work_package
end
- it 'can switch between the different view modes' do
+ it "can switch between the different view modes" do
# Opening details view with info icon
card_view.click_info_icon(work_package)
details_view.ensure_page_loaded
details_view.expect_subject
- details_view.switch_to_tab tab: 'Activity'
- details_view.expect_tab 'Activity'
+ details_view.switch_to_tab tab: "Activity"
+ details_view.expect_tab "Activity"
# Going to full screen and back again
details_view.switch_to_fullscreen
- full_view.expect_tab 'Activity'
+ full_view.expect_tab "Activity"
full_view.go_back
details_view.ensure_page_loaded
@@ -99,16 +99,16 @@
card_view.expect_work_package_listed(work_package)
# Go to viewer only
- model_page.switch_view 'Viewer'
+ model_page.switch_view "Viewer"
model_page.model_viewer_visible true
- expect(page).not_to have_test_selector('op-wp-card-view')
+ expect(page).not_to have_test_selector("op-wp-card-view")
# Go to list only
- model_page.switch_view 'Cards'
+ model_page.switch_view "Cards"
model_page.model_viewer_visible false
- expect(page).to have_test_selector('op-wp-card-view')
+ expect(page).to have_test_selector("op-wp-card-view")
card_view.expect_work_package_listed work_package
# Go to details view
@@ -116,21 +116,21 @@
details_view.ensure_page_loaded
details_view.expect_subject
- details_view.switch_to_tab tab: 'Activity'
- details_view.expect_tab 'Activity'
+ details_view.switch_to_tab tab: "Activity"
+ details_view.expect_tab "Activity"
details_view.close
details_view.expect_closed
end
- it 'after deleting an WP in full view it returns to the model and list view (see #33317)' do
+ it "after deleting an WP in full view it returns to the model and list view (see #33317)" do
# Go to full single view
card_view.open_split_view_by_info_icon(work_package)
details_view.switch_to_fullscreen
- full_view.expect_tab 'Activity'
+ full_view.expect_tab "Activity"
# Delete via the context menu
- find('#action-show-more-dropdown-menu .button').click
- find('.menu-item', text: 'Delete').click
+ find("#action-show-more-dropdown-menu .button").click
+ find(".menu-item", text: "Delete").click
destroy_modal.expect_listed(work_package)
destroy_modal.confirm_deletion
@@ -147,26 +147,26 @@
details_view.ensure_page_loaded
details_view.expect_subject
- details_view.switch_to_tab tab: 'Relations'
+ details_view.switch_to_tab tab: "Relations"
details_view.switch_to_fullscreen
- full_view.expect_tab 'Relations'
+ full_view.expect_tab "Relations"
full_view.go_back
- details_view.expect_tab 'Relations'
+ details_view.expect_tab "Relations"
end
end
end
- context 'on default page' do
+ context "on default page" do
let(:model_page) { Pages::IfcModels::ShowDefault.new project }
- it_behaves_like 'can switch from split to viewer to list-only'
+ it_behaves_like "can switch from split to viewer to list-only"
end
- context 'on show page' do
+ context "on show page" do
let(:model_page) { Pages::IfcModels::Show.new project, model.id }
- it_behaves_like 'can switch from split to viewer to list-only'
+ it_behaves_like "can switch from split to viewer to list-only"
end
end
diff --git a/modules/bim/spec/features/card_view/bulk_actions_spec.rb b/modules/bim/spec/features/card_view/bulk_actions_spec.rb
index 21a38d67b9d0..d193548e266f 100644
--- a/modules/bim/spec/features/card_view/bulk_actions_spec.rb
+++ b/modules/bim/spec/features/card_view/bulk_actions_spec.rb
@@ -1,20 +1,20 @@
-require 'spec_helper'
-require_relative '../../support/pages/ifc_models/show_default'
+require "spec_helper"
+require_relative "../../support/pages/ifc_models/show_default"
-RSpec.describe 'Copy work packages through Rails view', :js, :with_cuprite, with_config: { edition: 'bim' } do
- shared_let(:project) { create(:project, name: 'Source', enabled_module_names: %i[bim work_package_tracking]) }
+RSpec.describe "Copy work packages through Rails view", :js, :with_cuprite, with_config: { edition: "bim" } do
+ shared_let(:project) { create(:project, name: "Source", enabled_module_names: %i[bim work_package_tracking]) }
shared_let(:dev) do
create(:user,
- firstname: 'Dev',
- lastname: 'Guy',
+ firstname: "Dev",
+ lastname: "Guy",
member_with_permissions: { project => %i[view_work_packages work_package_assigned
view_ifc_models view_linked_issues] })
end
shared_let(:mover) do
create(:user,
- firstname: 'Manager',
- lastname: 'Guy',
+ firstname: "Manager",
+ lastname: "Guy",
member_with_permissions: {
project => %i[view_work_packages view_ifc_models view_linked_issues
copy_work_packages move_work_packages manage_subtasks assign_versions edit_work_packages
@@ -38,72 +38,72 @@
expect_angular_frontend_initialized
wp_table.expect_work_package_listed work_package, work_package2
- wp_table.switch_view 'Cards'
+ wp_table.switch_view "Cards"
loading_indicator_saveguard
# Select all work packages
- find('body').send_keys [:control, 'a']
+ find("body").send_keys [:control, "a"]
end
- describe 'accessing the bulk copy from the card view' do
- context 'with permissions' do
+ describe "accessing the bulk copy from the card view" do
+ context "with permissions" do
let(:current_user) { mover }
- it 'does allow to copy' do
+ it "does allow to copy" do
context_menu.open_for work_package, card_view: true
- context_menu.expect_options 'Bulk copy'
+ context_menu.expect_options "Bulk copy"
end
end
- context 'without permission' do
+ context "without permission" do
let(:current_user) { dev }
- it 'does not allow to copy' do
+ it "does not allow to copy" do
context_menu.open_for work_package, card_view: true
- context_menu.expect_no_options 'Bulk copy'
+ context_menu.expect_no_options "Bulk copy"
end
end
end
- describe 'accessing the bulk move from the card view' do
- context 'with permissions' do
+ describe "accessing the bulk move from the card view" do
+ context "with permissions" do
let(:current_user) { mover }
- it 'does allow to move' do
+ it "does allow to move" do
context_menu.open_for work_package, card_view: true
- context_menu.expect_options 'Bulk change of project'
+ context_menu.expect_options "Bulk change of project"
end
end
- context 'without permission' do
+ context "without permission" do
let(:current_user) { dev }
- it 'does not allow to move' do
+ it "does not allow to move" do
context_menu.open_for work_package, card_view: true
- context_menu.expect_no_options 'Bulk change of project'
+ context_menu.expect_no_options "Bulk change of project"
end
end
end
- describe 'accessing the bulk edit from the card view' do
- context 'with permissions' do
+ describe "accessing the bulk edit from the card view" do
+ context "with permissions" do
let(:current_user) { mover }
- it 'does allow to edit' do
+ it "does allow to edit" do
context_menu.open_for work_package, card_view: true
- context_menu.expect_options 'Bulk edit'
+ context_menu.expect_options "Bulk edit"
end
- context 'with a project budget' do
+ context "with a project budget" do
let!(:budget) { create(:budget, project:) }
- it 'updates all the work packages' do
+ it "updates all the work packages" do
context_menu.open_for work_package, card_view: true
- context_menu.choose 'Bulk edit'
+ context_menu.choose "Bulk edit"
- select budget.subject, from: 'work_package_budget_id'
- click_on 'Submit'
- wp_table.expect_and_dismiss_toaster message: 'Successful update.'
+ select budget.subject, from: "work_package_budget_id"
+ click_on "Submit"
+ wp_table.expect_and_dismiss_toaster message: "Successful update."
expect(work_package.reload.budget_id).to eq(budget.id)
expect(work_package2.reload.budget_id).to eq(budget.id)
@@ -111,12 +111,12 @@
end
end
- context 'without permission' do
+ context "without permission" do
let(:current_user) { dev }
- it 'does not allow to edit' do
+ it "does not allow to edit" do
context_menu.open_for work_package, card_view: true
- context_menu.expect_no_options 'Bulk edit'
+ context_menu.expect_no_options "Bulk edit"
end
end
end
diff --git a/modules/bim/spec/features/card_view/context_menu_spec.rb b/modules/bim/spec/features/card_view/context_menu_spec.rb
index e4613f35a0ef..8fb3c2af7044 100644
--- a/modules/bim/spec/features/card_view/context_menu_spec.rb
+++ b/modules/bim/spec/features/card_view/context_menu_spec.rb
@@ -1,8 +1,8 @@
-require 'spec_helper'
-require_relative '../../../../../spec/features/work_packages/table/context_menu/context_menu_shared_examples'
-require_relative '../../support/pages/ifc_models/show_default'
+require "spec_helper"
+require_relative "../../../../../spec/features/work_packages/table/context_menu/context_menu_shared_examples"
+require_relative "../../support/pages/ifc_models/show_default"
-RSpec.describe 'Work Package table hierarchy and sorting', :js, :with_cuprite, with_config: { edition: 'bim' } do
+RSpec.describe "Work Package table hierarchy and sorting", :js, :with_cuprite, with_config: { edition: "bim" } do
shared_let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking costs]) }
let(:wp_table) { Pages::IfcModels::ShowDefault.new(project) }
@@ -11,33 +11,33 @@
shared_let(:work_package) do
create(:work_package,
project:,
- subject: 'Parent')
+ subject: "Parent")
end
shared_let(:wp_child1) do
create(:work_package,
project:,
parent: work_package,
- subject: 'WP child 1')
+ subject: "WP child 1")
end
shared_let(:wp_child2) do
create(:work_package,
project:,
parent: work_package,
- subject: 'WP child 2')
+ subject: "WP child 2")
end
shared_let(:menu) { Components::WorkPackages::ContextMenu.new }
shared_current_user { create(:admin) }
- it 'does not show indentation context in card view' do
+ it "does not show indentation context in card view" do
wp_table.visit!
loading_indicator_saveguard
wp_table.expect_work_package_listed(work_package, wp_child1, wp_child2)
- wp_table.switch_view 'Cards'
- expect(page).to have_test_selector('op-wp-single-card', count: 3)
+ wp_table.switch_view "Cards"
+ expect(page).to have_test_selector("op-wp-single-card", count: 3)
# Expect indent-able for none
hierarchy.expect_indent(work_package, indent: false, outdent: false, card_view: true)
@@ -45,7 +45,7 @@
hierarchy.expect_indent(wp_child2, indent: false, outdent: false, card_view: true)
end
- it_behaves_like 'provides a single WP context menu' do
+ it_behaves_like "provides a single WP context menu" do
let(:open_context_menu) do
-> {
# Go to table
@@ -54,7 +54,7 @@
wp_table.expect_work_package_listed(work_package)
- wp_table.switch_view 'Cards'
+ wp_table.switch_view "Cards"
loading_indicator_saveguard
# Open context menu
diff --git a/modules/bim/spec/features/card_view/select_card_spec.rb b/modules/bim/spec/features/card_view/select_card_spec.rb
index 2f1033ba71c7..6eacafcc38c8 100644
--- a/modules/bim/spec/features/card_view/select_card_spec.rb
+++ b/modules/bim/spec/features/card_view/select_card_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../../support/pages/ifc_models/show_default'
+require "spec_helper"
+require_relative "../../support/pages/ifc_models/show_default"
-RSpec.describe 'Selecting cards in the card view (regression #31962)', :js, with_config: { edition: 'bim' } do
+RSpec.describe "Selecting cards in the card view (regression #31962)", :js, with_config: { edition: "bim" } do
let(:user) { create(:admin) }
let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) }
let(:wp_table) { Pages::IfcModels::ShowDefault.new(project) }
@@ -45,12 +45,12 @@
login_as(user)
wp_table.visit!
- wp_table.switch_view 'Cards'
+ wp_table.switch_view "Cards"
cards.expect_work_package_listed work_package1, work_package2, work_package3
end
- describe 'selecting cards' do
- it 'can select and deselect all cards' do
+ describe "selecting cards" do
+ it "can select and deselect all cards" do
# Select all
cards.select_all_work_packages
cards.expect_work_package_selected work_package1, true
@@ -64,7 +64,7 @@
cards.expect_work_package_selected work_package3, false
end
- it 'can select and deselect single cards' do
+ it "can select and deselect single cards" do
# Select a card
cards.select_work_package work_package1
cards.expect_work_package_selected work_package1, true
@@ -84,7 +84,7 @@
cards.expect_work_package_selected work_package3, false
end
- it 'can select and deselect range of cards' do
+ it "can select and deselect range of cards" do
# Select the first WP
cards.select_work_package work_package1
cards.expect_work_package_selected work_package1, true
@@ -105,20 +105,20 @@
end
end
- describe 'opening' do
- it 'the full screen view via double click' do
+ describe "opening" do
+ it "the full screen view via double click" do
cards.open_full_screen_by_doubleclick(work_package1)
- expect(page).to have_css('.work-packages--details--subject',
+ expect(page).to have_css(".work-packages--details--subject",
text: work_package1.subject)
end
- it 'the split screen of the selected WP' do
+ it "the split screen of the selected WP" do
cards.open_split_view_by_info_icon(work_package2)
split_wp = Pages::SplitWorkPackage.new(work_package2)
split_wp.expect_attributes Subject: work_package2.subject
end
- it 'can move between card details using info icon (Regression #33451)' do
+ it "can move between card details using info icon (Regression #33451)" do
# move to first details
split = cards.open_split_view_by_info_icon work_package1
split.expect_subject
diff --git a/modules/bim/spec/features/card_view/wp_card_status_spec.rb b/modules/bim/spec/features/card_view/wp_card_status_spec.rb
index b9aa237ff826..7e2ed39bfd99 100644
--- a/modules/bim/spec/features/card_view/wp_card_status_spec.rb
+++ b/modules/bim/spec/features/card_view/wp_card_status_spec.rb
@@ -26,17 +26,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../../support/pages/ifc_models/show_default'
+require "spec_helper"
+require_relative "../../support/pages/ifc_models/show_default"
-RSpec.describe 'Update status from WP card', :js, :with_cuprite, with_config: { edition: 'bim' } do
+RSpec.describe "Update status from WP card", :js, :with_cuprite, with_config: { edition: "bim" } do
let(:manager_role) do
create(:project_role, permissions: %i[view_work_packages edit_work_packages view_ifc_models view_linked_issues])
end
let(:manager) do
create(:user,
- firstname: 'Manager',
- lastname: 'Guy',
+ firstname: "Manager",
+ lastname: "Guy",
member_with_roles: { project => manager_role })
end
let(:status1) { create(:status) }
@@ -49,7 +49,7 @@
project:,
type:,
status: status1,
- subject: 'Foobar')
+ subject: "Foobar")
end
let!(:workflow) do
@@ -70,14 +70,14 @@
loading_indicator_saveguard
wp_table.expect_work_package_listed(work_package)
- wp_table.switch_view 'Cards'
+ wp_table.switch_view "Cards"
end
- it 'can update the status through the button' do
+ it "can update the status through the button" do
status_button = wp_card_view.status_button(work_package)
status_button.update status2.name
- wp_card_view.expect_and_dismiss_toaster message: 'Successful update.'
+ wp_card_view.expect_and_dismiss_toaster message: "Successful update."
status_button.expect_text status2.name
work_package.reload
diff --git a/modules/bim/spec/features/display_representations/switch_display_representations_spec.rb b/modules/bim/spec/features/display_representations/switch_display_representations_spec.rb
index 25900df6917c..83585ec50fad 100644
--- a/modules/bim/spec/features/display_representations/switch_display_representations_spec.rb
+++ b/modules/bim/spec/features/display_representations/switch_display_representations_spec.rb
@@ -26,20 +26,20 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../../support/pages/ifc_models/show_default'
+require "spec_helper"
+require_relative "../../support/pages/ifc_models/show_default"
-RSpec.describe 'Switching work package view',
- :js, with_config: { edition: 'bim' }, with_ee: %i[conditional_highlighting] do
+RSpec.describe "Switching work package view",
+ :js, with_config: { edition: "bim" }, with_ee: %i[conditional_highlighting] do
let(:user) { create(:admin) }
let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) }
let(:wp_page) { Pages::IfcModels::ShowDefault.new(project) }
let(:highlighting) { Components::WorkPackages::Highlighting.new }
let(:cards) { Pages::WorkPackageCards.new(project) }
- let(:priority1) { create(:issue_priority, color: create(:color, hexcode: '#123456')) }
- let(:priority2) { create(:issue_priority, color: create(:color, hexcode: '#332211')) }
- let(:status) { create(:status, color: create(:color, hexcode: '#654321')) }
+ let(:priority1) { create(:issue_priority, color: create(:color, hexcode: "#123456")) }
+ let(:priority2) { create(:issue_priority, color: create(:color, hexcode: "#332211")) }
+ let(:status) { create(:status, color: create(:color, hexcode: "#654321")) }
let(:wp_1) do
create(:work_package,
@@ -65,15 +65,15 @@
wp_page.expect_work_package_listed wp_1, wp_2
end
- context 'switching to card view' do
+ context "switching to card view" do
before do
# Enable card representation
- wp_page.switch_view 'Cards'
+ wp_page.switch_view "Cards"
loading_indicator_saveguard
cards.expect_work_package_listed wp_1, wp_2
end
- it 'saves the representation in the query' do
+ it "saves the representation in the query" do
# After refresh the WP are still displayed as cards
page.driver.browser.navigate.refresh
cards.expect_work_package_listed wp_1, wp_2
diff --git a/modules/bim/spec/features/ifc_models/direct_ifc_upload_spec.rb b/modules/bim/spec/features/ifc_models/direct_ifc_upload_spec.rb
index e8f9acd7de36..f6e7a9c0be22 100644
--- a/modules/bim/spec/features/ifc_models/direct_ifc_upload_spec.rb
+++ b/modules/bim/spec/features/ifc_models/direct_ifc_upload_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'ifc_upload_shared_examples'
+require "spec_helper"
+require_relative "ifc_upload_shared_examples"
-RSpec.describe 'direct IFC upload', :js, with_config: { edition: 'bim' }, with_direct_uploads: :redirect do
- it_behaves_like 'can upload an IFC file' do
+RSpec.describe "direct IFC upload", :js, with_config: { edition: "bim" }, with_direct_uploads: :redirect do
+ it_behaves_like "can upload an IFC file" do
# with direct upload, we don't get the model name
- let(:model_name) { 'model.ifc' }
+ let(:model_name) { "model.ifc" }
end
end
diff --git a/modules/bim/spec/features/ifc_models/ifc_upload_shared_examples.rb b/modules/bim/spec/features/ifc_models/ifc_upload_shared_examples.rb
index 37c1b3a6f146..14bf5cb68a15 100644
--- a/modules/bim/spec/features/ifc_models/ifc_upload_shared_examples.rb
+++ b/modules/bim/spec/features/ifc_models/ifc_upload_shared_examples.rb
@@ -1,7 +1,7 @@
-RSpec.shared_examples 'can upload an IFC file' do
+RSpec.shared_examples "can upload an IFC file" do
let(:user) { create(:admin) }
let(:project) { create(:project, enabled_module_names: %i[bim]) }
- let(:ifc_fixture) { UploadedFile.load_from('modules/bim/spec/fixtures/files/minimal.ifc') }
+ let(:ifc_fixture) { UploadedFile.load_from("modules/bim/spec/fixtures/files/minimal.ifc") }
let(:set_tick_is_default_after_file) { true }
before do
@@ -10,13 +10,13 @@
allow_any_instance_of(Bim::IfcModels::BaseContract).to receive(:ifc_attachment_is_ifc).and_return true
end
- shared_examples 'allows uploading an IFC file' do
- it 'allows uploading an IFC file' do
+ shared_examples "allows uploading an IFC file" do
+ it "allows uploading an IFC file" do
visit new_bcf_project_ifc_model_path(project_id: project.identifier)
- page.find_by_id('bim_ifc_models_ifc_model_is_default').set(true) unless set_tick_is_default_after_file
+ page.find_by_id("bim_ifc_models_ifc_model_is_default").set(true) unless set_tick_is_default_after_file
page.attach_file("file", ifc_fixture.path, visible: :all)
- page.find_by_id('bim_ifc_models_ifc_model_is_default').set true if set_tick_is_default_after_file
+ page.find_by_id("bim_ifc_models_ifc_model_is_default").set true if set_tick_is_default_after_file
click_on "Create"
@@ -31,13 +31,13 @@
end
end
- context 'when setting checkbox is_default before selecting file' do
+ context "when setting checkbox is_default before selecting file" do
let(:set_tick_is_default_after_file) { false }
- it_behaves_like 'allows uploading an IFC file'
+ it_behaves_like "allows uploading an IFC file"
end
- context 'when setting checkbox is_default after selecting file' do
- it_behaves_like 'allows uploading an IFC file'
+ context "when setting checkbox is_default after selecting file" do
+ it_behaves_like "allows uploading an IFC file"
end
end
diff --git a/modules/bim/spec/features/ifc_models/regular_ifc_upload_spec.rb b/modules/bim/spec/features/ifc_models/regular_ifc_upload_spec.rb
index d52fd4f7b9fc..e9ceec4c3ecc 100644
--- a/modules/bim/spec/features/ifc_models/regular_ifc_upload_spec.rb
+++ b/modules/bim/spec/features/ifc_models/regular_ifc_upload_spec.rb
@@ -26,11 +26,11 @@
# See docs/COPYRIGHT.rdoc for more details.
#++
-require 'spec_helper'
-require_relative 'ifc_upload_shared_examples'
+require "spec_helper"
+require_relative "ifc_upload_shared_examples"
-RSpec.describe 'IFC upload', :js, with_config: { edition: 'bim' } do
- it_behaves_like 'can upload an IFC file' do
- let(:model_name) { 'minimal.ifc' }
+RSpec.describe "IFC upload", :js, with_config: { edition: "bim" } do
+ it_behaves_like "can upload an IFC file" do
+ let(:model_name) { "minimal.ifc" }
end
end
diff --git a/modules/bim/spec/features/model_management_spec.rb b/modules/bim/spec/features/model_management_spec.rb
index 427d82c23f3d..d52c6da37655 100644
--- a/modules/bim/spec/features/model_management_spec.rb
+++ b/modules/bim/spec/features/model_management_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/ifc_models/index'
+require_relative "../support/pages/ifc_models/index"
-RSpec.describe 'model management', :js, with_config: { edition: 'bim' } do
+RSpec.describe "model management", :js, with_config: { edition: "bim" } do
let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) }
let(:index_page) { Pages::IfcModels::Index.new(project) }
let(:role) { create(:project_role, permissions: %i[view_ifc_models manage_bcf manage_ifc_models view_work_packages]) }
@@ -53,7 +53,7 @@
uploader: user)
end
- context 'with all permissions' do
+ context "with all permissions" do
before do
login_as(user)
model
@@ -61,17 +61,17 @@
index_page.visit!
end
- it 'I can perform all actions on the models' do
+ it "I can perform all actions on the models" do
index_page.model_listed true, model.title
index_page.add_model_allowed true
index_page.edit_model_allowed model.title, true
index_page.delete_model_allowed model.title, true
- index_page.edit_model model.title, 'My super cool new name'
- index_page.delete_model 'My super cool new name'
+ index_page.edit_model model.title, "My super cool new name"
+ index_page.delete_model "My super cool new name"
end
- it 'I can see single models and the defaults' do
+ it "I can see single models and the defaults" do
index_page.model_listed true, model.title
index_page.show_model model
index_page.bcf_buttons true
@@ -83,7 +83,7 @@
end
end
- context 'with only viewing permissions' do
+ context "with only viewing permissions" do
let(:view_role) { create(:project_role, permissions: %i[view_ifc_models view_work_packages]) }
let(:view_user) do
create(:user,
@@ -97,14 +97,14 @@
index_page.visit!
end
- it 'I can see, but not edit models' do
+ it "I can see, but not edit models" do
index_page.model_listed true, model.title
index_page.add_model_allowed false
index_page.edit_model_allowed model.title, false
index_page.delete_model_allowed model.title, false
end
- it 'I can see single models and the defaults' do
+ it "I can see single models and the defaults" do
index_page.model_listed true, model.title
index_page.show_model model
@@ -115,7 +115,7 @@
end
end
- context 'without any permissions' do
+ context "without any permissions" do
let(:no_permissions_role) { create(:project_role, permissions: %i[]) }
let(:user_without_permissions) do
create(:user,
@@ -129,8 +129,8 @@
end
it "I can't see any models and perform no actions" do
- expected = '[Error 403] You are not authorized to access this page.'
- expect(page).to have_css('.op-toast.-error', text: expected)
+ expected = "[Error 403] You are not authorized to access this page."
+ expect(page).to have_css(".op-toast.-error", text: expected)
index_page.add_model_allowed false
end
diff --git a/modules/bim/spec/features/model_viewer_spec.rb b/modules/bim/spec/features/model_viewer_spec.rb
index 5d094cceff77..d8116b348ed7 100644
--- a/modules/bim/spec/features/model_viewer_spec.rb
+++ b/modules/bim/spec/features/model_viewer_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative '../spec_helper'
+require_relative "../spec_helper"
-RSpec.describe 'model viewer', :js, with_config: { edition: 'bim' } do
+RSpec.describe "model viewer", :js, with_config: { edition: "bim" } do
let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) }
# TODO: Add empty viewpoint and stub method to load viewpoints once defined
let(:work_package) { create(:work_package, project:) }
@@ -49,15 +49,15 @@
let(:model_tree) { Components::XeokitModelTree.new }
let(:card_view) { Pages::WorkPackageCards.new(project) }
- context 'with all permissions' do
- describe 'showing a model' do
+ context "with all permissions" do
+ describe "showing a model" do
before do
login_as(user)
work_package
show_model_page.visit_and_wait_until_finished_loading!
end
- it 'loads and shows the viewer correctly' do
+ it "loads and shows the viewer correctly" do
show_model_page.model_viewer_visible true
show_model_page.model_viewer_shows_a_toolbar true
show_model_page.page_shows_a_toolbar true
@@ -65,12 +65,12 @@
model_tree.expect_model_management_available visible: true
end
- it 'shows a work package list as cards next to the viewer' do
+ it "shows a work package list as cards next to the viewer" do
show_model_page.model_viewer_visible true
card_view.expect_work_package_listed work_package
end
- it 'can trigger creation, update and deletion of IFC models from within the model tree view' do
+ it "can trigger creation, update and deletion of IFC models from within the model tree view" do
model_tree.click_add_model
expect(page).to have_current_path new_bcf_project_ifc_model_path(project)
@@ -83,22 +83,22 @@
model_tree.select_model_menu_item(model.title, "Delete")
show_model_page.finished_loading
- expect(page).to have_text(I18n.t('js.ifc_models.empty_warning'))
+ expect(page).to have_text(I18n.t("js.ifc_models.empty_warning"))
end
end
- context 'in a project with no model' do
+ context "in a project with no model" do
let!(:model) { nil }
- it 'shows a warning that no IFC models exist yet' do
+ it "shows a warning that no IFC models exist yet" do
login_as user
visit defaults_bcf_project_ifc_models_path(project)
- expect(page).to have_css('.op-toast.-info', text: I18n.t('js.ifc_models.empty_warning'))
+ expect(page).to have_css(".op-toast.-info", text: I18n.t("js.ifc_models.empty_warning"))
end
end
end
- context 'with only viewing permissions' do
+ context "with only viewing permissions" do
let(:view_role) { create(:project_role, permissions: %i[view_ifc_models view_work_packages view_linked_issues]) }
let(:view_user) do
create(:user,
@@ -110,7 +110,7 @@
show_model_page.visit_and_wait_until_finished_loading!
end
- it 'loads and shows the viewer correctly, but has no possibility to edit the model' do
+ it "loads and shows the viewer correctly, but has no possibility to edit the model" do
show_model_page.model_viewer_visible true
show_model_page.model_viewer_shows_a_toolbar true
show_model_page.page_shows_a_toolbar false
@@ -119,7 +119,7 @@
end
end
- context 'without any permissions' do
+ context "without any permissions" do
let(:no_permissions_role) { create(:project_role, permissions: %i[]) }
let(:user_without_permissions) do
create(:user,
@@ -132,9 +132,9 @@
show_model_page.visit!
end
- it 'shows no viewer' do
- expected = '[Error 403] You are not authorized to access this page.'
- expect(page).to have_css('.op-toast.-error', text: expected)
+ it "shows no viewer" do
+ expected = "[Error 403] You are not authorized to access this page."
+ expect(page).to have_css(".op-toast.-error", text: expected)
show_model_page.model_viewer_visible false
show_model_page.model_viewer_shows_a_toolbar false
@@ -142,7 +142,7 @@
model_tree.sidebar_shows_viewer_menu false
end
- it 'shows no work package list next to the viewer' do
+ it "shows no work package list next to the viewer" do
show_model_page.model_viewer_visible false
card_view.expect_work_package_not_listed work_package
end
diff --git a/modules/bim/spec/features/revit_add_in/bim_revit_add_in_navigation_spec.rb b/modules/bim/spec/features/revit_add_in/bim_revit_add_in_navigation_spec.rb
index 3f158eb52b47..78c58997b58e 100644
--- a/modules/bim/spec/features/revit_add_in/bim_revit_add_in_navigation_spec.rb
+++ b/modules/bim/spec/features/revit_add_in/bim_revit_add_in_navigation_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative '../../spec_helper'
+require_relative "../../spec_helper"
-RSpec.describe 'BIM Revit Add-in navigation spec', :js,
- driver: :chrome_revit_add_in, with_config: { edition: 'bim' } do
+RSpec.describe "BIM Revit Add-in navigation spec", :js,
+ driver: :chrome_revit_add_in, with_config: { edition: "bim" } do
let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) }
let!(:work_package) { create(:work_package, project:) }
let(:role) do
@@ -51,74 +51,74 @@
# Guard to ensure toolbar is completely loaded and doesn't rerender again.
# At first there is no badge. It gets set later and only then the toolbar's
# switches are ready to test.
- model_page.find('#work-packages-filter-toggle-button .badge', text: '1')
+ model_page.find("#work-packages-filter-toggle-button .badge", text: "1")
end
let(:full_create) { Pages::FullWorkPackageCreate.new }
- it 'show the right elements on the page' do
+ it "show the right elements on the page" do
# shows "Cards" view by default
- model_page.expect_view_toggle_at 'Cards'
+ model_page.expect_view_toggle_at "Cards"
# shows no viewer
model_page.model_viewer_visible false
# shows a toolbar' do
model_page.page_has_a_toolbar
# menu has no viewer options
- model_page.has_no_menu_item_with_text? 'Viewer'
+ model_page.has_no_menu_item_with_text? "Viewer"
end
- it 'the user menu has an option to go to the add-in settings' do
- within '.op-app-header' do
+ it "the user menu has an option to go to the add-in settings" do
+ within ".op-app-header" do
page.find("a[title='#{user.name}']").click
- expect(page).to have_css('li', text: I18n.t('js.revit.revit_add_in_settings'))
+ expect(page).to have_css("li", text: I18n.t("js.revit.revit_add_in_settings"))
end
end
- it 'opens new work package form in full view' do
- find('.add-work-package', wait: 10).click
+ it "opens new work package form in full view" do
+ find(".add-work-package", wait: 10).click
# The only type to select is 'NONE'
- find('.menu-item', text: 'NONE', wait: 10).click
+ find(".menu-item", text: "NONE", wait: 10).click
full_create.edit_field(:subject).expect_active!
- expect(page).to have_css('.work-packages-partitioned-page--content-right', visible: :all)
+ expect(page).to have_css(".work-packages-partitioned-page--content-right", visible: :all)
end
- it 'shows work package details page in full view on Cards display mode' do
+ it "shows work package details page in full view on Cards display mode" do
model_page.click_info_icon(work_package)
- expect(page).to have_css('.work-packages-partitioned-page--content-left', text: work_package.subject)
- expect(page).to have_css('.work-packages-partitioned-page--content-right', visible: :all)
+ expect(page).to have_css(".work-packages-partitioned-page--content-left", text: work_package.subject)
+ expect(page).to have_css(".work-packages-partitioned-page--content-right", visible: :all)
end
- context 'with the table display mode' do
+ context "with the table display mode" do
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
- it 'shows work package details page in full view on Table display mode' do
- model_page.switch_view 'Table'
+ it "shows work package details page in full view on Table display mode" do
+ model_page.switch_view "Table"
loading_indicator_saveguard
- expect(page).to have_css('.work-package-table')
+ expect(page).to have_css(".work-package-table")
wp_table.expect_work_package_listed work_package
wp_table.open_split_view work_package
- expect(page).to have_css('.work-packages-partitioned-page--content-left', text: work_package.subject)
- expect(page).to have_css('.work-packages-partitioned-page--content-right', visible: false)
+ expect(page).to have_css(".work-packages-partitioned-page--content-left", text: work_package.subject)
+ expect(page).to have_css(".work-packages-partitioned-page--content-right", visible: false)
end
end
- context 'Creating BCFs' do
+ context "Creating BCFs" do
let!(:status) { create(:default_status) }
let!(:priority) { create(:priority, is_default: true) }
- it 'redirects correctly' do
+ it "redirects correctly" do
create_page = model_page.create_wp_by_button(build(:type_standard))
expect(page).to have_current_path /bcf\/new$/, ignore_query: true
- create_page.subject_field.set('Some subject')
+ create_page.subject_field.set("Some subject")
create_page.save!
sleep(5)
- last_work_package = WorkPackage.find_by(subject: 'Some subject')
+ last_work_package = WorkPackage.find_by(subject: "Some subject")
# The currently working routes seem weird as they duplicate the work package ID.
expect(page).to(
have_current_path(/bcf\/show\/#{last_work_package.id}\/details\/#{last_work_package.id}\/overview$/,
@@ -129,12 +129,12 @@
end
context "when signed out" do
- it 'the user menu has an option to go to the add-in settings' do
+ it "the user menu has an option to go to the add-in settings" do
visit home_path
click_link I18n.t(:label_login)
- expect(page).to have_text(I18n.t('js.revit.revit_add_in_settings'))
+ expect(page).to have_text(I18n.t("js.revit.revit_add_in_settings"))
end
end
end
diff --git a/modules/bim/spec/features/revit_add_in/bim_revit_add_in_refresh_button_spec.rb b/modules/bim/spec/features/revit_add_in/bim_revit_add_in_refresh_button_spec.rb
index 758064b33da2..f5b3f187d10b 100644
--- a/modules/bim/spec/features/revit_add_in/bim_revit_add_in_refresh_button_spec.rb
+++ b/modules/bim/spec/features/revit_add_in/bim_revit_add_in_refresh_button_spec.rb
@@ -26,10 +26,10 @@
# See docs/COPYRIGHT.rdoc for more details.
#++
-require_relative '../../spec_helper'
+require_relative "../../spec_helper"
-RSpec.describe 'BIM Revit Add-in navigation spec', :js,
- driver: :chrome_revit_add_in, with_config: { edition: 'bim' } do
+RSpec.describe "BIM Revit Add-in navigation spec", :js,
+ driver: :chrome_revit_add_in, with_config: { edition: "bim" } do
let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) }
let!(:work_package) { create(:work_package, project:) }
let(:role) do
@@ -50,17 +50,17 @@
model_page.visit!
end
- it 'click on refresh button reloads information' do
+ it "click on refresh button reloads information" do
# Context BCF cards view
model_page.page_shows_a_filter_button(true)
- work_package.update_attribute(:subject, 'Refreshed while in cards view')
+ work_package.update_attribute(:subject, "Refreshed while in cards view")
model_page.click_refresh_button
- expect(page).to have_text('Refreshed while in cards view')
+ expect(page).to have_text("Refreshed while in cards view")
# Context BCF full view
model_page.click_info_icon(work_package)
- work_package.update_attribute(:subject, 'Refreshed while in full view')
+ work_package.update_attribute(:subject, "Refreshed while in full view")
model_page.click_refresh_button
- expect(page).to have_text('Refreshed while in full view')
+ expect(page).to have_text("Refreshed while in full view")
end
end
diff --git a/modules/bim/spec/features/show_default_spec.rb b/modules/bim/spec/features/show_default_spec.rb
index 3163e734062b..f8e25ba0a87d 100644
--- a/modules/bim/spec/features/show_default_spec.rb
+++ b/modules/bim/spec/features/show_default_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative '../spec_helper'
+require_relative "../spec_helper"
-RSpec.describe 'show default model', :js, with_config: { edition: 'bim' } do
+RSpec.describe "show default model", :js, with_config: { edition: "bim" } do
let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) }
let(:index_page) { Pages::IfcModels::Index.new(project) }
let(:show_default_page) { Pages::IfcModels::ShowDefault.new(project) }
@@ -53,16 +53,16 @@
model
end
- context 'when the work package module not loaded' do
+ context "when the work package module not loaded" do
let(:project) { create(:project, enabled_module_names: [:bim]) }
- it 'shows an error loading the page' do
+ it "shows an error loading the page" do
show_default_page.visit!
- show_default_page.expect_toast(type: :error, message: 'Your view is erroneous and could not be processed')
+ show_default_page.expect_toast(type: :error, message: "Your view is erroneous and could not be processed")
end
end
- context 'with everything ready' do
+ context "with everything ready" do
let(:old_work_package) { create(:work_package, project:) }
let(:new_work_package) { create(:work_package, project:) }
@@ -74,30 +74,30 @@
show_default_page.finished_loading
end
- it 'loads and shows the viewer and WPs correctly' do
+ it "loads and shows the viewer and WPs correctly" do
show_default_page.model_viewer_visible true
show_default_page.model_viewer_shows_a_toolbar true
show_default_page.page_shows_a_toolbar true
model_tree.sidebar_shows_viewer_menu true
# Check the order of work packages: Latest first
- expect(show_default_page.find_all('.op-wp-single-card--content-id').map(&:text)).to(
+ expect(show_default_page.find_all(".op-wp-single-card--content-id").map(&:text)).to(
eql(["##{new_work_package.id}", "##{old_work_package.id}"])
)
end
end
- context 'with the default model not being processed' do
+ context "with the default model not being processed" do
before do
model.xkt_attachment.destroy
show_default_page.visit!
end
- it 'renders a notification' do
+ it "renders a notification" do
show_default_page
.expect_toast(type: :info,
- message: I18n.t(:'ifc_models.processing_notice.processing_default'))
+ message: I18n.t(:"ifc_models.processing_notice.processing_default"))
end
end
end
diff --git a/modules/bim/spec/features/viewer/create_viewpoint_spec.rb b/modules/bim/spec/features/viewer/create_viewpoint_spec.rb
index 10084b3cfbf0..01216e678fe2 100644
--- a/modules/bim/spec/features/viewer/create_viewpoint_spec.rb
+++ b/modules/bim/spec/features/viewer/create_viewpoint_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative '../../spec_helper'
+require_relative "../../spec_helper"
-RSpec.describe 'Create viewpoint from BCF details page', :js, with_config: { edition: 'bim' } do
+RSpec.describe "Create viewpoint from BCF details page", :js, with_config: { edition: "bim" } do
let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) }
let(:user) { create(:admin) }
let!(:model) do
create(:ifc_model_minimal_converted,
- title: 'minimal',
+ title: "minimal",
project:,
uploader: user)
end
@@ -48,7 +48,7 @@
login_as(user)
end
- shared_examples 'can create a viewpoint from the BCF details page' do
+ shared_examples "can create a viewpoint from the BCF details page" do
it do
show_model_page.visit!
show_model_page.finished_loading
@@ -59,8 +59,8 @@
bcf_details.ensure_page_loaded
bcf_details.expect_viewpoint_count(0)
- model_tree.select_sidebar_tab('Objects')
- model_tree.expect_checked('minimal')
+ model_tree.select_sidebar_tab("Objects")
+ model_tree.expect_checked("minimal")
# Expand all nodes until the storeys get listed.
model_tree.expand_tree
@@ -84,8 +84,8 @@
sleep 1
# Uncheck the second checkbox for testing
- model_tree.select_sidebar_tab('Objects')
- model_tree.expect_checked('minimal')
+ model_tree.select_sidebar_tab("Objects")
+ model_tree.expect_checked("minimal")
model_tree.expand_tree
model_tree.expand_tree
model_tree.expand_tree
@@ -94,16 +94,16 @@
end
end
- context 'with a work package with BCF' do
+ context "with a work package with BCF" do
let!(:work_package) { create(:work_package, project:) }
let!(:bcf) { create(:bcf_issue, work_package:) }
- it_behaves_like 'can create a viewpoint from the BCF details page'
+ it_behaves_like "can create a viewpoint from the BCF details page"
end
- context 'with a work package without BCF' do
+ context "with a work package without BCF" do
let!(:work_package) { create(:work_package, project:) }
- it_behaves_like 'can create a viewpoint from the BCF details page'
+ it_behaves_like "can create a viewpoint from the BCF details page"
end
end
diff --git a/modules/bim/spec/features/viewer/delete_viewpoint_spec.rb b/modules/bim/spec/features/viewer/delete_viewpoint_spec.rb
index e5f9c38800d3..1d144c5c97ae 100644
--- a/modules/bim/spec/features/viewer/delete_viewpoint_spec.rb
+++ b/modules/bim/spec/features/viewer/delete_viewpoint_spec.rb
@@ -26,19 +26,19 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative '../../spec_helper'
+require_relative "../../spec_helper"
-RSpec.describe 'Delete viewpoint in model viewer', :js, with_config: { edition: 'bim' } do
+RSpec.describe "Delete viewpoint in model viewer", :js, with_config: { edition: "bim" } do
let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) }
let(:user) { create(:admin) }
let!(:work_package) { create(:work_package, project:) }
let!(:bcf) { create(:bcf_issue, work_package:) }
- let!(:viewpoint) { create(:bcf_viewpoint, issue: bcf, viewpoint_name: 'minimal_hidden_except_one') }
+ let!(:viewpoint) { create(:bcf_viewpoint, issue: bcf, viewpoint_name: "minimal_hidden_except_one") }
let!(:model) do
create(:ifc_model_minimal_converted,
- title: 'minimal',
+ title: "minimal",
project:,
uploader: user)
end
@@ -51,7 +51,7 @@
bcf_details.visit!
end
- it 'can delete the viewpoint through the gallery' do
+ it "can delete the viewpoint through the gallery" do
bcf_details.ensure_page_loaded
bcf_details.expect_viewpoint_count 1
bcf_details.show_current_viewpoint
diff --git a/modules/bim/spec/features/viewer/show_viewpoint_spec.rb b/modules/bim/spec/features/viewer/show_viewpoint_spec.rb
index 9b0bcf7108de..05bd18da885d 100644
--- a/modules/bim/spec/features/viewer/show_viewpoint_spec.rb
+++ b/modules/bim/spec/features/viewer/show_viewpoint_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative '../../spec_helper'
+require_relative "../../spec_helper"
-RSpec.describe 'Show viewpoint in model viewer', :js, with_config: { edition: 'bim' } do
+RSpec.describe "Show viewpoint in model viewer", :js, with_config: { edition: "bim" } do
let(:project) do
create(:project,
enabled_module_names: %i[bim work_package_tracking],
@@ -39,11 +39,11 @@
let!(:work_package) { create(:work_package, project:) }
let!(:bcf) { create(:bcf_issue, work_package:) }
- let!(:viewpoint) { create(:bcf_viewpoint, issue: bcf, viewpoint_name: 'minimal_hidden_except_one') }
+ let!(:viewpoint) { create(:bcf_viewpoint, issue: bcf, viewpoint_name: "minimal_hidden_except_one") }
let!(:model) do
create(:ifc_model_minimal_converted,
- title: 'minimal',
+ title: "minimal",
project:,
uploader: user)
end
@@ -53,16 +53,16 @@
let(:card_view) { Pages::WorkPackageCards.new(project) }
let(:bcf_details) { Pages::BcfDetailsPage.new(work_package, project) }
- shared_examples 'has the minimal viewpoint shown' do
- it 'loads the minimal viewpoint in the viewer' do
- model_tree.select_sidebar_tab 'Objects'
+ shared_examples "has the minimal viewpoint shown" do
+ it "loads the minimal viewpoint in the viewer" do
+ model_tree.select_sidebar_tab "Objects"
model_tree.expand_tree
model_tree.expand_tree
model_tree.expand_tree
retry_block do
- model_tree.expect_checked 'minimal'
+ model_tree.expect_checked "minimal"
model_tree.all_checkboxes.each do |label, checkbox|
- expect_checked = ['minimal', 'IfcSite', '0hOGUplITAJP95dJaHmSyV', '4OG'].include?(label.text)
+ expect_checked = ["minimal", "IfcSite", "0hOGUplITAJP95dJaHmSyV", "4OG"].include?(label.text)
if expect_checked != checkbox.checked?
raise "Expected #{label.text} to be #{expect_checked ? 'checked' : 'unchecked'}, but wasn't."
end
@@ -78,7 +78,7 @@
card_view.expect_work_package_listed(work_package)
end
- context 'clicking on the card' do
+ context "clicking on the card" do
before do
# We need to wait a bit for xeokit to be initialized
# otherwise the viewpoint selection won't go through
@@ -88,10 +88,10 @@
card_view.expect_work_package_selected(work_package, true)
end
- it_behaves_like 'has the minimal viewpoint shown'
+ it_behaves_like "has the minimal viewpoint shown"
end
- context 'when in details view' do
+ context "when in details view" do
before do
card_view.click_info_icon(work_package)
bcf_details.expect_viewpoint_count(1)
@@ -102,14 +102,14 @@
bcf_details.show_current_viewpoint
end
- it_behaves_like 'has the minimal viewpoint shown'
+ it_behaves_like "has the minimal viewpoint shown"
end
- context 'when in work packages details view' do
+ context "when in work packages details view" do
let(:wp_details) { Pages::SplitWorkPackage.new(work_package, project) }
shared_examples "moves to the BCF page" do
- it 'moves to the bcf page' do
+ it "moves to the bcf page" do
wp_details.visit!
bcf_details.expect_viewpoint_count(1)
bcf_details.show_current_viewpoint
@@ -122,7 +122,7 @@
end
context "current project is the work package's project" do
- it_behaves_like 'moves to the BCF page'
+ it_behaves_like "moves to the BCF page"
end
context "current project is a parent of the work package's project" do
@@ -132,7 +132,7 @@
it_behaves_like "moves to the BCF page"
end
- context 'when user does not have view_linked_issues permission' do
+ context "when user does not have view_linked_issues permission" do
let(:permissions) { %i[view_ifc_models view_work_packages] }
let(:user) do
@@ -140,10 +140,10 @@
member_with_permissions: { project => permissions })
end
- it 'does not show the viewpoint' do
+ it "does not show the viewpoint" do
wp_details.visit!
bcf_details.expect_viewpoint_count(0)
- expect(page).to have_no_css('h3.attributes-group--header-text', text: 'BCF')
+ expect(page).to have_no_css("h3.attributes-group--header-text", text: "BCF")
end
end
end
diff --git a/modules/bim/spec/lib/api/v3/work_packages/eager_loading/cache_checksum_integration_spec.rb b/modules/bim/spec/lib/api/v3/work_packages/eager_loading/cache_checksum_integration_spec.rb
index 239b6512dc8d..7a8912cad956 100644
--- a/modules/bim/spec/lib/api/v3/work_packages/eager_loading/cache_checksum_integration_spec.rb
+++ b/modules/bim/spec/lib/api/v3/work_packages/eager_loading/cache_checksum_integration_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++require 'rspec'
-require 'spec_helper'
-require Rails.root + 'spec/lib/api/v3/work_packages/eager_loading/eager_loading_mock_wrapper'
+require "spec_helper"
+require Rails.root + "spec/lib/api/v3/work_packages/eager_loading/eager_loading_mock_wrapper"
RSpec.describe API::V3::WorkPackages::EagerLoading::Checksum do
let!(:bcf_issue) do
@@ -38,7 +38,7 @@
create(:work_package)
end
- describe '.apply' do
+ describe ".apply" do
let!(:orig_checksum) do
EagerLoadingMockWrapper
.wrap(described_class, [work_package])
@@ -53,7 +53,7 @@
.cache_checksum
end
- it 'produces a different checksum on changes to the bcf issue id' do
+ it "produces a different checksum on changes to the bcf issue id" do
bcf_issue.delete
create(:bcf_issue,
work_package:)
@@ -62,7 +62,7 @@
.not_to eql orig_checksum
end
- it 'produces a different checksum on changes to the bcf issue' do
+ it "produces a different checksum on changes to the bcf issue" do
bcf_issue.update_column(:updated_at, Time.now + 10.seconds)
expect(new_checksum)
diff --git a/modules/bim/spec/lib/open_project/access_control_spec.rb b/modules/bim/spec/lib/open_project/access_control_spec.rb
index 6c77bca0e2bc..f7b3c1555cc8 100644
--- a/modules/bim/spec/lib/open_project/access_control_spec.rb
+++ b/modules/bim/spec/lib/open_project/access_control_spec.rb
@@ -26,50 +26,50 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::AccessControl do
- describe '.sorted_module_names' do
- context 'with bim disabled' do
+ describe ".sorted_module_names" do
+ context "with bim disabled" do
before do
allow(OpenProject::Configuration)
.to receive(:bim?)
.and_return false
end
- context 'if including disabled modules' do
- it 'includes the bim module' do
+ context "if including disabled modules" do
+ it "includes the bim module" do
expect(subject.sorted_module_names)
- .to include('bim')
+ .to include("bim")
end
end
- context 'if excluding disabled modules' do
- it 'does not include the bim module' do
+ context "if excluding disabled modules" do
+ it "does not include the bim module" do
expect(subject.sorted_module_names(include_disabled: false))
- .not_to include('bim')
+ .not_to include("bim")
end
end
end
- context 'with bim enabled' do
+ context "with bim enabled" do
before do
allow(OpenProject::Configuration)
.to receive(:bim?)
.and_return true
end
- context 'if including disabled modules' do
- it 'includes the bim module' do
+ context "if including disabled modules" do
+ it "includes the bim module" do
expect(subject.sorted_module_names)
- .to include('bim')
+ .to include("bim")
end
end
- context 'if excluding disabled modules' do
- it 'includes the bim module' do
+ context "if excluding disabled modules" do
+ it "includes the bim module" do
expect(subject.sorted_module_names(include_disabled: false))
- .to include('bim')
+ .to include("bim")
end
end
end
diff --git a/modules/bim/spec/lib/open_project/bcf/bcf_json/faster_converter_spec.rb b/modules/bim/spec/lib/open_project/bcf/bcf_json/faster_converter_spec.rb
index 77522a686dca..3503942470d8 100644
--- a/modules/bim/spec/lib/open_project/bcf/bcf_json/faster_converter_spec.rb
+++ b/modules/bim/spec/lib/open_project/bcf/bcf_json/faster_converter_spec.rb
@@ -28,40 +28,40 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::Bim::BcfJson::FasterConverter do
def pps(hash)
- PP.pp(hash, +'')
+ PP.pp(hash, +"")
end
- describe '.xml_to_hash' do
- it 'deals with single tag without params' do
+ describe ".xml_to_hash" do
+ it "deals with single tag without params" do
xml = <<~XML
XML
- expect(described_class.xml_to_hash(xml)).to eq(Hash.from_xml(xml)), 'should be identical to reference implementation'
+ expect(described_class.xml_to_hash(xml)).to eq(Hash.from_xml(xml)), "should be identical to reference implementation"
expect(described_class.xml_to_hash(xml))
.to eq("Component" => nil)
end
- it 'deals with single tag with params' do
+ it "deals with single tag with params" do
xml = <<~XML
XML
- expect(described_class.xml_to_hash(xml)).to eq(Hash.from_xml(xml)), 'should be identical to reference implementation'
+ expect(described_class.xml_to_hash(xml)).to eq(Hash.from_xml(xml)), "should be identical to reference implementation"
expect(described_class.xml_to_hash(xml))
.to eq("Component" => { "IfcGuid" => "3_LMnKT5PDNvFeWnu3ys5Q" })
end
- it 'deals with single tag with inner tags' do
+ it "deals with single tag with inner tags" do
xml = <<~XML
Revit1110420
XML
- expect(described_class.xml_to_hash(xml)).to eq(Hash.from_xml(xml)), 'should be identical to reference implementation'
+ expect(described_class.xml_to_hash(xml)).to eq(Hash.from_xml(xml)), "should be identical to reference implementation"
expect(described_class.xml_to_hash(xml))
.to eq(
"Component" => {
@@ -72,7 +72,7 @@ def pps(hash)
)
end
- it 'deals with multiple similar tags with inner tags' do
+ it "deals with multiple similar tags with inner tags" do
xml = <<~XML
@@ -85,7 +85,7 @@ def pps(hash)
XML
- expect(described_class.xml_to_hash(xml)).to eq(Hash.from_xml(xml)), 'should be identical to reference implementation'
+ expect(described_class.xml_to_hash(xml)).to eq(Hash.from_xml(xml)), "should be identical to reference implementation"
expect(described_class.xml_to_hash(xml))
.to eq(
"root" => {
@@ -97,38 +97,38 @@ def pps(hash)
)
end
- it 'deals with outer tag + multiple similar inner tags' do
+ it "deals with outer tag + multiple similar inner tags" do
xml = <<~XML
XML
- expect(described_class.xml_to_hash(xml)).to eq(Hash.from_xml(xml)), 'should be identical to reference implementation'
+ expect(described_class.xml_to_hash(xml)).to eq(Hash.from_xml(xml)), "should be identical to reference implementation"
expect(described_class.xml_to_hash(xml))
.to eq("Color" => { "Component" => [nil, nil] })
end
- it 'deals with outer tag with params + multiple similar inner tags' do
+ it "deals with outer tag with params + multiple similar inner tags" do
xml = <<~XML
XML
- expect(described_class.xml_to_hash(xml)).to eq(Hash.from_xml(xml)), 'should be identical to reference implementation'
+ expect(described_class.xml_to_hash(xml)).to eq(Hash.from_xml(xml)), "should be identical to reference implementation"
expect(described_class.xml_to_hash(xml))
.to eq("Color" => { "Color" => "3498db", "Component" => [nil, nil] })
end
- it 'deals with outer tag with params + multiple similar inner tags with params' do
+ it "deals with outer tag with params + multiple similar inner tags with params" do
xml = <<~XML
XML
- expect(described_class.xml_to_hash(xml)).to eq(Hash.from_xml(xml)), 'should be identical to reference implementation'
+ expect(described_class.xml_to_hash(xml)).to eq(Hash.from_xml(xml)), "should be identical to reference implementation"
expect(described_class.xml_to_hash(xml))
.to eq(
"Color" => {
@@ -141,7 +141,7 @@ def pps(hash)
)
end
- it 'deals with outer tag + multiple similar inner tags with inner tags' do
+ it "deals with outer tag + multiple similar inner tags with inner tags" do
xml = <<~XML
@@ -152,7 +152,7 @@ def pps(hash)
XML
- expect(described_class.xml_to_hash(xml)).to eq(Hash.from_xml(xml)), 'should be identical to reference implementation'
+ expect(described_class.xml_to_hash(xml)).to eq(Hash.from_xml(xml)), "should be identical to reference implementation"
expect(described_class.xml_to_hash(xml))
.to eq(
"Color" => {
@@ -164,7 +164,7 @@ def pps(hash)
)
end
- it 'deals with outer tag + mixed similar inner tags' do
+ it "deals with outer tag + mixed similar inner tags" do
xml = <<~XML
@@ -174,7 +174,7 @@ def pps(hash)
XML
- expect(described_class.xml_to_hash(xml)).to eq(Hash.from_xml(xml)), 'should be identical to reference implementation'
+ expect(described_class.xml_to_hash(xml)).to eq(Hash.from_xml(xml)), "should be identical to reference implementation"
expect(described_class.xml_to_hash(xml))
.to eq(
"Color" => {
diff --git a/modules/bim/spec/lib/open_project/bcf/bcf_json/viewpoint_reader_shared_examples.rb b/modules/bim/spec/lib/open_project/bcf/bcf_json/viewpoint_reader_shared_examples.rb
index 855b8df54cfd..6e6b5c027f11 100644
--- a/modules/bim/spec/lib/open_project/bcf/bcf_json/viewpoint_reader_shared_examples.rb
+++ b/modules/bim/spec/lib/open_project/bcf/bcf_json/viewpoint_reader_shared_examples.rb
@@ -26,102 +26,102 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.shared_examples 'viewpoint keys' do
+RSpec.shared_examples "viewpoint keys" do
let(:expected) { %w[guid components orthogonal_camera perspective_camera lines clipping_planes bitmaps] }
- it 'has only allowed keys' do
+ it "has only allowed keys" do
expect(subject.keys - expected).to be_empty
end
- it 'always has the guid set to the viewpoint' do
- expect(subject.keys).to include 'guid'
- expect(subject['guid']).to eq(xml_viewpoint.uuid)
+ it "always has the guid set to the viewpoint" do
+ expect(subject.keys).to include "guid"
+ expect(subject["guid"]).to eq(xml_viewpoint.uuid)
end
- it 'always has the perspective_camera OR orthogonal camera set' do
+ it "always has the perspective_camera OR orthogonal camera set" do
expect(subject.keys)
- .to include('perspective_camera')
- .or include('orthogonal_camera')
+ .to include("perspective_camera")
+ .or include("orthogonal_camera")
end
end
-RSpec.shared_examples 'has camera' do |camera_type|
- it 'has a camera object' do
+RSpec.shared_examples "has camera" do |camera_type|
+ it "has a camera object" do
# camera xyz floats
expect(subject.dig(camera_type)).to be_a(Hash)
- expect(subject.dig(camera_type, 'field_of_view')).to be_a(Numeric) if camera_type == 'perspective_camera'
- expect(subject.dig(camera_type, 'view_to_world_scale')).to be_a(Numeric) if camera_type == 'orthogonal_camera'
+ expect(subject.dig(camera_type, "field_of_view")).to be_a(Numeric) if camera_type == "perspective_camera"
+ expect(subject.dig(camera_type, "view_to_world_scale")).to be_a(Numeric) if camera_type == "orthogonal_camera"
%w[camera_view_point camera_direction camera_up_vector].each do |key|
camera_vp = subject.dig(camera_type, key)
expect(camera_vp).to be_a(Hash)
- expect(camera_vp.keys).to contain_exactly 'x', 'y', 'z'
+ expect(camera_vp.keys).to contain_exactly "x", "y", "z"
expect(camera_vp.values).to all(be_a(Numeric))
end
end
end
-RSpec.shared_examples 'has lines' do
- it 'has a lines entry' do
- lines = subject['lines']
+RSpec.shared_examples "has lines" do
+ it "has a lines entry" do
+ lines = subject["lines"]
expect(lines).to be_a(Array)
lines.each do |line|
expect(line).to be_a(Hash)
- expect(line.keys).to contain_exactly 'start_point', 'end_point'
- expect(line['start_point'].keys).to contain_exactly 'x', 'y', 'z'
- expect(line['start_point'].values).to all(be_a(Numeric))
- expect(line['end_point'].keys).to contain_exactly 'x', 'y', 'z'
- expect(line['end_point'].values).to all(be_a(Numeric))
+ expect(line.keys).to contain_exactly "start_point", "end_point"
+ expect(line["start_point"].keys).to contain_exactly "x", "y", "z"
+ expect(line["start_point"].values).to all(be_a(Numeric))
+ expect(line["end_point"].keys).to contain_exactly "x", "y", "z"
+ expect(line["end_point"].values).to all(be_a(Numeric))
end
end
end
-RSpec.shared_examples 'has clipping planes' do
- it 'has a lines entry' do
- clipping_planes = subject['clipping_planes']
+RSpec.shared_examples "has clipping planes" do
+ it "has a lines entry" do
+ clipping_planes = subject["clipping_planes"]
expect(clipping_planes).to be_a(Array)
clipping_planes.each do |plane|
expect(plane).to be_a(Hash)
- expect(plane.keys).to contain_exactly 'location', 'direction'
- expect(plane['location'].keys).to contain_exactly 'x', 'y', 'z'
- expect(plane['location'].values).to all(be_a(Numeric))
- expect(plane['direction'].keys).to contain_exactly 'x', 'y', 'z'
- expect(plane['direction'].values).to all(be_a(Numeric))
+ expect(plane.keys).to contain_exactly "location", "direction"
+ expect(plane["location"].keys).to contain_exactly "x", "y", "z"
+ expect(plane["location"].values).to all(be_a(Numeric))
+ expect(plane["direction"].keys).to contain_exactly "x", "y", "z"
+ expect(plane["direction"].values).to all(be_a(Numeric))
end
end
end
-RSpec.shared_examples 'has bitmaps' do
- it 'has a bitmaps entry' do
- bitmaps = subject['bitmaps']
+RSpec.shared_examples "has bitmaps" do
+ it "has a bitmaps entry" do
+ bitmaps = subject["bitmaps"]
expect(bitmaps).to be_a(Array)
bitmaps.each do |bitmap|
expect(bitmap).to be_a(Hash)
- expect(bitmap.keys).to contain_exactly 'bitmap_type', 'bitmap_data', 'location', 'normal', 'up', 'height'
- expect(bitmap['location'].keys).to contain_exactly 'x', 'y', 'z'
- expect(bitmap['location'].values).to all(be_a(Numeric))
- expect(bitmap['normal'].keys).to contain_exactly 'x', 'y', 'z'
- expect(bitmap['normal'].values).to all(be_a(Numeric))
- expect(bitmap['up'].keys).to contain_exactly 'x', 'y', 'z'
- expect(bitmap['up'].values).to all(be_a(Numeric))
- expect(bitmap['height']).to be_a(Numeric)
+ expect(bitmap.keys).to contain_exactly "bitmap_type", "bitmap_data", "location", "normal", "up", "height"
+ expect(bitmap["location"].keys).to contain_exactly "x", "y", "z"
+ expect(bitmap["location"].values).to all(be_a(Numeric))
+ expect(bitmap["normal"].keys).to contain_exactly "x", "y", "z"
+ expect(bitmap["normal"].values).to all(be_a(Numeric))
+ expect(bitmap["up"].keys).to contain_exactly "x", "y", "z"
+ expect(bitmap["up"].values).to all(be_a(Numeric))
+ expect(bitmap["height"]).to be_a(Numeric)
end
end
end
-RSpec.shared_examples 'has components selection' do
- it 'has components selections' do
- selection = subject.dig('components', 'selection')
+RSpec.shared_examples "has components selection" do
+ it "has components selections" do
+ selection = subject.dig("components", "selection")
expect(selection).to be_a(Array)
selection.each do |item|
expect(item).to be_a(Hash)
- expect(item.keys).to include 'ifc_guid'
+ expect(item.keys).to include "ifc_guid"
# Has only allowed keys
expect(item.keys - %w[ifc_guid originating_system authoring_tool_id]).to be_empty
@@ -129,53 +129,53 @@
end
end
-RSpec.shared_examples 'has components coloring' do
- it 'has components coloring' do
- coloring = subject.dig('components', 'coloring')
+RSpec.shared_examples "has components coloring" do
+ it "has components coloring" do
+ coloring = subject.dig("components", "coloring")
expect(coloring).to be_a(Array)
coloring.each do |item|
expect(item).to be_a(Hash)
- expect(item.keys).to include 'color', 'components'
- expect(item['color']).to match /\A#[a-f0-9]{6}\Z/i
- expect(item['components']).to be_a(Array)
+ expect(item.keys).to include "color", "components"
+ expect(item["color"]).to match /\A#[a-f0-9]{6}\Z/i
+ expect(item["components"]).to be_a(Array)
- item['components'].each do |component|
+ item["components"].each do |component|
expect(component).to be_a(Hash)
- expect(component.keys).to include 'ifc_guid'
+ expect(component.keys).to include "ifc_guid"
end
end
end
end
-RSpec.shared_examples 'has components visibility' do
- it 'has components visibility' do
- visibility = subject.dig('components', 'visibility')
+RSpec.shared_examples "has components visibility" do
+ it "has components visibility" do
+ visibility = subject.dig("components", "visibility")
expect(visibility).to be_a(Hash)
expect(visibility.keys - %w[default_visibility exceptions view_setup_hints]).to be_empty
- expect(visibility['default_visibility']).to be_boolean
- Array(visibility['exceptions']).each do |item|
+ expect(visibility["default_visibility"]).to be_boolean
+ Array(visibility["exceptions"]).each do |item|
expect(item).to be_a(Hash)
- expect(item.keys).to include 'ifc_guid'
+ expect(item.keys).to include "ifc_guid"
end
- hints = visibility['view_setup_hints']
+ hints = visibility["view_setup_hints"]
expect(hints).to be_a(Hash)
- expect(hints.keys).to contain_exactly 'spaces_visible', 'space_boundaries_visible', 'openings_visible'
+ expect(hints.keys).to contain_exactly "spaces_visible", "space_boundaries_visible", "openings_visible"
expect(hints.values).to all(be_boolean)
end
end
-RSpec.shared_examples 'matches the JSON counterpart' do
- it 'matches the JSON viewpoint counterpart' do
+RSpec.shared_examples "matches the JSON counterpart" do
+ it "matches the JSON viewpoint counterpart" do
path = OpenProject::Bim::Engine.root.join("spec/fixtures/viewpoints/#{xml_viewpoint.viewpoint_name}.json")
raise "Expected #{path} to be readable for JSON comparison" unless path.readable?
json = path.read
# Replace the static GUID with the one from this viewpoint
- json.gsub! '{{UUID}}', xml_viewpoint.uuid
+ json.gsub! "{{UUID}}", xml_viewpoint.uuid
expect(subject.to_json).to be_json_eql(json)
end
diff --git a/modules/bim/spec/lib/open_project/bcf/bcf_json/viewpoint_reader_spec.rb b/modules/bim/spec/lib/open_project/bcf/bcf_json/viewpoint_reader_spec.rb
index 133f9250cc64..6d3ded2ed3d6 100644
--- a/modules/bim/spec/lib/open_project/bcf/bcf_json/viewpoint_reader_spec.rb
+++ b/modules/bim/spec/lib/open_project/bcf/bcf_json/viewpoint_reader_spec.rb
@@ -26,71 +26,71 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'viewpoint_reader_shared_examples'
+require "spec_helper"
+require_relative "viewpoint_reader_shared_examples"
RSpec.describe OpenProject::Bim::BcfJson::ViewpointReader do
let(:instance) { described_class.new xml_viewpoint.uuid, xml_viewpoint.viewpoint }
subject { instance.result }
- describe 'with empty example' do
+ describe "with empty example" do
let_it_be(:xml_viewpoint) do
- build_stubbed(:xml_viewpoint, viewpoint_name: 'empty.bcfv')
+ build_stubbed(:xml_viewpoint, viewpoint_name: "empty.bcfv")
end
- it_behaves_like 'matches the JSON counterpart'
+ it_behaves_like "matches the JSON counterpart"
end
- describe 'with minimal example' do
+ describe "with minimal example" do
let_it_be(:xml_viewpoint) do
- build_stubbed(:xml_viewpoint, viewpoint_name: 'minimal.bcfv')
+ build_stubbed(:xml_viewpoint, viewpoint_name: "minimal.bcfv")
end
- it_behaves_like 'viewpoint keys'
- it_behaves_like 'has camera', 'orthogonal_camera'
+ it_behaves_like "viewpoint keys"
+ it_behaves_like "has camera", "orthogonal_camera"
- it_behaves_like 'matches the JSON counterpart'
+ it_behaves_like "matches the JSON counterpart"
end
- describe 'with full viewpoint' do
+ describe "with full viewpoint" do
let_it_be(:xml_viewpoint) do
- build_stubbed(:xml_viewpoint, viewpoint_name: 'full_viewpoint.bcfv')
+ build_stubbed(:xml_viewpoint, viewpoint_name: "full_viewpoint.bcfv")
end
- it_behaves_like 'viewpoint keys'
- it_behaves_like 'has camera', 'perspective_camera'
- it_behaves_like 'has lines'
- it_behaves_like 'has clipping planes'
- it_behaves_like 'has bitmaps'
- it_behaves_like 'has components selection'
- it_behaves_like 'has components coloring'
- it_behaves_like 'has components visibility'
+ it_behaves_like "viewpoint keys"
+ it_behaves_like "has camera", "perspective_camera"
+ it_behaves_like "has lines"
+ it_behaves_like "has clipping planes"
+ it_behaves_like "has bitmaps"
+ it_behaves_like "has components selection"
+ it_behaves_like "has components coloring"
+ it_behaves_like "has components visibility"
- it_behaves_like 'matches the JSON counterpart'
+ it_behaves_like "matches the JSON counterpart"
end
- describe 'with real-world neuhaus_sc_1 example' do
+ describe "with real-world neuhaus_sc_1 example" do
let_it_be(:xml_viewpoint) do
- build_stubbed(:xml_viewpoint, viewpoint_name: 'neubau_sc_1.bcfv')
+ build_stubbed(:xml_viewpoint, viewpoint_name: "neubau_sc_1.bcfv")
end
- it_behaves_like 'viewpoint keys'
- it_behaves_like 'has camera', 'perspective_camera'
- it_behaves_like 'has components selection'
+ it_behaves_like "viewpoint keys"
+ it_behaves_like "has camera", "perspective_camera"
+ it_behaves_like "has components selection"
- it_behaves_like 'matches the JSON counterpart'
+ it_behaves_like "matches the JSON counterpart"
end
- describe 'with empty XML nodes' do
+ describe "with empty XML nodes" do
let_it_be(:xml_viewpoint) do
- build_stubbed(:xml_viewpoint, viewpoint_name: 'empty_nodes.bcfv')
+ build_stubbed(:xml_viewpoint, viewpoint_name: "empty_nodes.bcfv")
end
- it 'ignores empty nodes' do
- expect(subject['lines']).to be_nil
- expect(subject['clipping_planes']).to be_nil
- expect(subject.dig('components', 'coloring')).to be_nil
+ it "ignores empty nodes" do
+ expect(subject["lines"]).to be_nil
+ expect(subject["clipping_planes"]).to be_nil
+ expect(subject.dig("components", "coloring")).to be_nil
end
end
end
diff --git a/modules/bim/spec/lib/open_project/bcf/bcf_xml/viewpoint_writer_spec.rb b/modules/bim/spec/lib/open_project/bcf/bcf_xml/viewpoint_writer_spec.rb
index 1b8294dc91c1..52ef99c8d9a4 100644
--- a/modules/bim/spec/lib/open_project/bcf/bcf_xml/viewpoint_writer_spec.rb
+++ b/modules/bim/spec/lib/open_project/bcf/bcf_xml/viewpoint_writer_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'compare-xml'
+require "spec_helper"
+require "compare-xml"
RSpec.describe OpenProject::Bim::BcfXml::ViewpointWriter do
let(:writer_instance) { described_class.new json_resource }
@@ -37,8 +37,8 @@
subject { writer_instance.doc }
- shared_examples 'converts back to xml' do
- it 'the output of writer is XML-equal to the provided XML viewpoint' do
+ shared_examples "converts back to xml" do
+ it "the output of writer is XML-equal to the provided XML viewpoint" do
results = CompareXML.equivalent?(
subject,
xml_comparison,
@@ -52,45 +52,45 @@
end
end
- it 'contains the root node' do
- expect(writer_instance.doc.at('VisualizationInfo')).to be_present
+ it "contains the root node" do
+ expect(writer_instance.doc.at("VisualizationInfo")).to be_present
end
- it 'goes full circle comparing back to JSON' do
+ it "goes full circle comparing back to JSON" do
expect(reader_instance.to_json).to be_json_eql json_comparison
end
end
- describe 'with minimal example' do
+ describe "with minimal example" do
let_it_be(:json_resource) do
- build_stubbed(:bcf_viewpoint, uuid: '{{UUID}}', viewpoint_name: 'minimal.bcfv')
+ build_stubbed(:bcf_viewpoint, uuid: "{{UUID}}", viewpoint_name: "minimal.bcfv")
end
let_it_be(:xml_resource) do
- build_stubbed(:xml_viewpoint, uuid: '{{UUID}}', viewpoint_name: 'minimal.bcfv')
+ build_stubbed(:xml_viewpoint, uuid: "{{UUID}}", viewpoint_name: "minimal.bcfv")
end
- it_behaves_like 'converts back to xml'
+ it_behaves_like "converts back to xml"
end
- describe 'with full viewpoint' do
+ describe "with full viewpoint" do
let_it_be(:json_resource) do
- build_stubbed(:bcf_viewpoint, uuid: '{{UUID}}', viewpoint_name: 'full_viewpoint.bcfv')
+ build_stubbed(:bcf_viewpoint, uuid: "{{UUID}}", viewpoint_name: "full_viewpoint.bcfv")
end
let_it_be(:xml_resource) do
- build_stubbed(:xml_viewpoint, uuid: '{{UUID}}', viewpoint_name: 'full_viewpoint.bcfv')
+ build_stubbed(:xml_viewpoint, uuid: "{{UUID}}", viewpoint_name: "full_viewpoint.bcfv")
end
- it_behaves_like 'converts back to xml'
+ it_behaves_like "converts back to xml"
end
- describe 'with real-world neuhaus_sc_1 example' do
+ describe "with real-world neuhaus_sc_1 example" do
let_it_be(:json_resource) do
- build_stubbed(:bcf_viewpoint, uuid: '{{UUID}}', viewpoint_name: 'neubau_sc_1.bcfv')
+ build_stubbed(:bcf_viewpoint, uuid: "{{UUID}}", viewpoint_name: "neubau_sc_1.bcfv")
end
let_it_be(:xml_resource) do
- build_stubbed(:xml_viewpoint, uuid: '{{UUID}}', viewpoint_name: 'neubau_sc_1_fixed.bcfv')
+ build_stubbed(:xml_viewpoint, uuid: "{{UUID}}", viewpoint_name: "neubau_sc_1_fixed.bcfv")
end
- it_behaves_like 'converts back to xml'
+ it_behaves_like "converts back to xml"
end
end
diff --git a/modules/bim/spec/lib/open_project/bim/work_package/exporter/formatters/bcf_thumbnail_spec.rb b/modules/bim/spec/lib/open_project/bim/work_package/exporter/formatters/bcf_thumbnail_spec.rb
index 55c9a1df84b6..48af35805ad1 100644
--- a/modules/bim/spec/lib/open_project/bim/work_package/exporter/formatters/bcf_thumbnail_spec.rb
+++ b/modules/bim/spec/lib/open_project/bim/work_package/exporter/formatters/bcf_thumbnail_spec.rb
@@ -26,20 +26,20 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::Bim::WorkPackage::Exporter::Formatters::BcfThumbnail do
- describe '::apply?' do
- it 'returns TRUE the bcf thumbnail' do
+ describe "::apply?" do
+ it "returns TRUE the bcf thumbnail" do
expect(described_class).to be_apply(:bcf_thumbnail, :whatever)
end
- it 'returns FALSE for any other class' do
+ it "returns FALSE for any other class" do
expect(described_class).not_to be_apply(:whatever, :whatever)
end
end
- describe '::format' do
+ describe "::format" do
let(:work_package_with_viewpoint) { create(:work_package) }
let(:bcf_issue) { create(:bcf_issue_with_viewpoint, work_package: work_package_with_viewpoint) }
let(:work_package_without_viewpoint) { create(:work_package) }
@@ -49,11 +49,11 @@
end
it 'returns "x" for work packages that have BCF issues with at least one viewpoint' do
- expect(described_class.new(:bcf_thumbnail).format(work_package_with_viewpoint)).to eql('x')
+ expect(described_class.new(:bcf_thumbnail).format(work_package_with_viewpoint)).to eql("x")
end
it 'returns "" for work packages without viewpoints attached' do
- expect(described_class.new(:bcf_thumbnail).format(work_package_without_viewpoint)).to eql('')
+ expect(described_class.new(:bcf_thumbnail).format(work_package_without_viewpoint)).to eql("")
end
end
end
diff --git a/modules/bim/spec/models/bcf/issue_spec.rb b/modules/bim/spec/models/bcf/issue_spec.rb
index ed3dceada295..5a51c265bbb6 100644
--- a/modules/bim/spec/models/bcf/issue_spec.rb
+++ b/modules/bim/spec/models/bcf/issue_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Bim::Bcf::Issue do
let(:type) { create(:type, name: "Issue [BCF]") }
let(:work_package) { create(:work_package, type:) }
let(:issue) { create(:bcf_issue, work_package:) }
- describe '#markup_doc' do
+ describe "#markup_doc" do
subject { issue }
it "returns a Nokogiri::XML::Document" do
@@ -47,17 +47,17 @@
it "invalidates the cache after an update of the issue" do
first_fetched_doc = subject.markup_doc
- subject.markup = subject.markup + ' '
+ subject.markup = subject.markup + " "
subject.save
expect(subject.markup_doc).not_to eql(first_fetched_doc)
end
end
- describe '.of_project' do
+ describe ".of_project" do
let!(:other_work_package) { create(:work_package, type:) }
let!(:other_issue) { create(:bcf_issue, work_package: other_work_package) }
- it 'returns all issues of the provided project' do
+ it "returns all issues of the provided project" do
expect(described_class.of_project(issue.project))
.to contain_exactly(issue)
end
diff --git a/modules/bim/spec/models/ifc_model_spec.rb b/modules/bim/spec/models/ifc_model_spec.rb
index c2b25b892b23..b08e2a6f402e 100644
--- a/modules/bim/spec/models/ifc_model_spec.rb
+++ b/modules/bim/spec/models/ifc_model_spec.rb
@@ -1,14 +1,14 @@
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Bim::IfcModels::IfcModel do
subject { described_class.new params }
- let(:params) { { title: 'foo', is_default: true } }
+ let(:params) { { title: "foo", is_default: true } }
- describe 'converted?' do
+ describe "converted?" do
let(:attachment) { build(:attachment) }
- it 'is converted when the xkt attachment is present' do
+ it "is converted when the xkt attachment is present" do
expect(subject).not_to be_converted
allow(subject).to receive(:xkt_attachment).and_return(attachment)
@@ -17,11 +17,11 @@
end
end
- describe 'ifc_attachment=' do
+ describe "ifc_attachment=" do
let(:project) { create(:project, enabled_module_names: %i[bim]) }
let(:ifc_attachment) { subject.ifc_attachment }
let(:new_attachment) do
- FileHelpers.mock_uploaded_file name: "model.ifc", content_type: 'application/binary', binary: true
+ FileHelpers.mock_uploaded_file name: "model.ifc", content_type: "application/binary", binary: true
end
subject { create(:ifc_model_minimal_converted, project:) }
@@ -31,7 +31,7 @@
member_with_permissions: { project => %i[manage_ifc_models] })
end
- it 'replaces the previous attachment' do
+ it "replaces the previous attachment" do
expect(ifc_attachment).to be_present
expect(subject.xkt_attachment).to be_present
expect(subject).to be_converted
diff --git a/modules/bim/spec/models/queries/views/filters/type_filter_spec.rb b/modules/bim/spec/models/queries/views/filters/type_filter_spec.rb
index e01a704ba0c9..2b317989242d 100644
--- a/modules/bim/spec/models/queries/views/filters/type_filter_spec.rb
+++ b/modules/bim/spec/models/queries/views/filters/type_filter_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Queries::Views::Filters::TypeFilter do
let(:current_user) { create(:user) }
@@ -35,12 +35,12 @@
login_as(current_user)
end
- it_behaves_like 'basic query filter' do
+ it_behaves_like "basic query filter" do
let(:class_key) { :type }
let(:type) { :list_optional }
- describe '#allowed_values' do
- it 'includes the Bim views' do
+ describe "#allowed_values" do
+ it "includes the Bim views" do
expected_bim_view = %w[Views::Bim Views::Bim]
expect(([expected_bim_view] - instance.allowed_values).size).to be 0
diff --git a/modules/bim/spec/models/queries/work_packages/filter/bcf_issue_associated_filter_spec.rb b/modules/bim/spec/models/queries/work_packages/filter/bcf_issue_associated_filter_spec.rb
index c6f5af71fe1d..842ab1773ed9 100644
--- a/modules/bim/spec/models/queries/work_packages/filter/bcf_issue_associated_filter_spec.rb
+++ b/modules/bim/spec/models/queries/work_packages/filter/bcf_issue_associated_filter_spec.rb
@@ -25,26 +25,26 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Bim::Queries::WorkPackages::Filter::BcfIssueAssociatedFilter do
- include_context 'filter tests'
+ include_context "filter tests"
let(:values) { [OpenProject::Database::DB_VALUE_TRUE] }
- it_behaves_like 'basic query filter' do
+ it_behaves_like "basic query filter" do
let(:class_key) { :bcf_issue_associated }
let(:type) { :list }
- describe '#available?' do
- context 'if bim is enabled', with_config: { edition: 'bim' } do
- it 'is available' do
+ describe "#available?" do
+ context "if bim is enabled", with_config: { edition: "bim" } do
+ it "is available" do
expect(instance)
.to be_available
end
end
- context 'if bim is disabled' do
- it 'is not available' do
+ context "if bim is disabled" do
+ it "is not available" do
expect(instance)
.not_to be_available
end
diff --git a/modules/bim/spec/models/queries/work_packages/selects/bcf_thumbnail_select_spec.rb b/modules/bim/spec/models/queries/work_packages/selects/bcf_thumbnail_select_spec.rb
index 5539de18bde2..d5425cca907c 100644
--- a/modules/bim/spec/models/queries/work_packages/selects/bcf_thumbnail_select_spec.rb
+++ b/modules/bim/spec/models/queries/work_packages/selects/bcf_thumbnail_select_spec.rb
@@ -1,21 +1,21 @@
-require 'spec_helper'
+require "spec_helper"
require Rails.root.join("spec/models/queries/work_packages/selects/shared_query_select_specs").to_s
RSpec.describe Bim::Queries::WorkPackages::Selects::BcfThumbnailSelect do
let(:instance) { described_class.new(:query_column) }
- it_behaves_like 'query column'
+ it_behaves_like "query column"
- describe 'instances' do
- context 'bim edition', with_config: { edition: 'bim' } do
- it 'the bcf_thumbnail column exists' do
+ describe "instances" do
+ context "bim edition", with_config: { edition: "bim" } do
+ it "the bcf_thumbnail column exists" do
expect(described_class.instances.map(&:name))
.to include :bcf_thumbnail
end
end
- context 'vanilla edition' do
- it 'the bcf_thumbnail column does not exist' do
+ context "vanilla edition" do
+ it "the bcf_thumbnail column does not exist" do
expect(described_class.instances.map(&:name))
.not_to include :bcf_thumbnail
end
diff --git a/modules/bim/spec/models/type_spec.rb b/modules/bim/spec/models/type_spec.rb
index 647b222dff92..c38f6929b3ad 100644
--- a/modules/bim/spec/models/type_spec.rb
+++ b/modules/bim/spec/models/type_spec.rb
@@ -26,18 +26,18 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Type do
let(:type) { create(:type, name: "Issue") }
- it 'bcf_thumbnail is available as a WorkPackageRepresenter attribute' do
+ it "bcf_thumbnail is available as a WorkPackageRepresenter attribute" do
expect(API::V3::WorkPackages::Schema::WorkPackageSchemaRepresenter.representable_attrs.keys).to(
- include('bcf_thumbnail')
+ include("bcf_thumbnail")
)
end
- it 'bcf_thumbnail is not within the attributes of the default form configuration' do
- expect(type.attribute_groups.map(&:attributes).flatten).not_to include('bcf_thumbnail')
+ it "bcf_thumbnail is not within the attributes of the default form configuration" do
+ expect(type.attribute_groups.map(&:attributes).flatten).not_to include("bcf_thumbnail")
end
end
diff --git a/modules/bim/spec/representers/bcf/api/v2_1/auth/single_representer_rendering_spec.rb b/modules/bim/spec/representers/bcf/api/v2_1/auth/single_representer_rendering_spec.rb
index 20361488a6e1..83eb3e25c127 100644
--- a/modules/bim/spec/representers/bcf/api/v2_1/auth/single_representer_rendering_spec.rb
+++ b/modules/bim/spec/representers/bcf/api/v2_1/auth/single_representer_rendering_spec.rb
@@ -26,49 +26,49 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../shared_examples'
+require_relative "../shared_examples"
-RSpec.describe Bim::Bcf::API::V2_1::Auth::SingleRepresenter, 'rendering' do
+RSpec.describe Bim::Bcf::API::V2_1::Auth::SingleRepresenter, "rendering" do
let(:instance) { described_class.new(nil) }
include OpenProject::StaticRouting::UrlHelpers
subject { instance.to_json }
- describe 'attributes' do
+ describe "attributes" do
before do
allow(OpenProject::Configuration)
.to receive(:rails_relative_url_root)
- .and_return('/blubs')
+ .and_return("/blubs")
end
- context 'oauth2_auth_url' do
- it_behaves_like 'attribute' do
+ context "oauth2_auth_url" do
+ it_behaves_like "attribute" do
let(:value) { "http://localhost:3000/blubs/oauth/authorize" }
- let(:path) { 'oauth2_auth_url' }
+ let(:path) { "oauth2_auth_url" }
end
end
- context 'oauth2_token_url' do
- it_behaves_like 'attribute' do
+ context "oauth2_token_url" do
+ it_behaves_like "attribute" do
let(:value) { "http://localhost:3000/blubs/oauth/token" }
- let(:path) { 'oauth2_token_url' }
+ let(:path) { "oauth2_token_url" }
end
end
- context 'http_basic_supported' do
- it_behaves_like 'attribute' do
+ context "http_basic_supported" do
+ it_behaves_like "attribute" do
let(:value) { false }
- let(:path) { 'http_basic_supported' }
+ let(:path) { "http_basic_supported" }
end
end
- context 'supported_oauth2_flows' do
- it_behaves_like 'attribute' do
+ context "supported_oauth2_flows" do
+ it_behaves_like "attribute" do
let(:value) { %w(authorization_code_grant client_credentials) }
- let(:path) { 'supported_oauth2_flows' }
+ let(:path) { "supported_oauth2_flows" }
end
end
end
diff --git a/modules/bim/spec/representers/bcf/api/v2_1/project_extensions/representer_spec.rb b/modules/bim/spec/representers/bcf/api/v2_1/project_extensions/representer_spec.rb
index 65c7c97dcc1f..9c4fc09aebec 100644
--- a/modules/bim/spec/representers/bcf/api/v2_1/project_extensions/representer_spec.rb
+++ b/modules/bim/spec/representers/bcf/api/v2_1/project_extensions/representer_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../shared_examples'
+require_relative "../shared_examples"
-RSpec.describe Bim::Bcf::API::V2_1::ProjectExtensions::Representer, 'rendering' do
- let(:type_task) { build_stubbed(:type_task, name: 'My BCF type') }
+RSpec.describe Bim::Bcf::API::V2_1::ProjectExtensions::Representer, "rendering" do
+ let(:type_task) { build_stubbed(:type_task, name: "My BCF type") }
let(:status) { build_stubbed(:status) }
let(:user) { build_stubbed(:user) }
let(:project) do
@@ -41,7 +41,7 @@
let(:priority) { build_stubbed(:priority) }
let(:user) { build_stubbed(:user) }
let(:contract) do
- double('contract',
+ double("contract",
user:,
model: work_package,
assignable_types: [type_task],
@@ -59,134 +59,134 @@
end
end
- shared_examples_for 'empty when lacking manage bcf' do
+ shared_examples_for "empty when lacking manage bcf" do
let(:permissions) { %i[edit_project] }
- it_behaves_like 'attribute' do
+ it_behaves_like "attribute" do
let(:value) { [] }
end
end
- describe 'attributes' do
- describe 'topic_type' do
- let(:path) { 'topic_type' }
+ describe "attributes" do
+ describe "topic_type" do
+ let(:path) { "topic_type" }
- it_behaves_like 'attribute' do
+ it_behaves_like "attribute" do
let(:value) { [type_task.name] }
end
- it_behaves_like 'empty when lacking manage bcf'
+ it_behaves_like "empty when lacking manage bcf"
end
- describe 'topic_status' do
- let(:path) { 'topic_status' }
+ describe "topic_status" do
+ let(:path) { "topic_status" }
- it_behaves_like 'attribute' do
+ it_behaves_like "attribute" do
let(:value) { [status.name] }
end
- it_behaves_like 'empty when lacking manage bcf'
+ it_behaves_like "empty when lacking manage bcf"
end
- describe 'topic_actions' do
- let(:path) { 'topic_actions' }
+ describe "topic_actions" do
+ let(:path) { "topic_actions" }
- it_behaves_like 'attribute' do
+ it_behaves_like "attribute" do
let(:value) { %w[update updateRelatedTopics updateFiles createViewpoint] }
end
- it_behaves_like 'empty when lacking manage bcf'
+ it_behaves_like "empty when lacking manage bcf"
end
- describe 'priority' do
- let(:path) { 'priority' }
+ describe "priority" do
+ let(:path) { "priority" }
- it_behaves_like 'attribute' do
+ it_behaves_like "attribute" do
let(:value) { [priority.name] }
end
- it_behaves_like 'empty when lacking manage bcf'
+ it_behaves_like "empty when lacking manage bcf"
end
- describe 'user_id_type' do
- let(:path) { 'user_id_type' }
+ describe "user_id_type" do
+ let(:path) { "user_id_type" }
let(:permissions) { %i[manage_bcf view_members edit_project] }
- it_behaves_like 'attribute' do
+ it_behaves_like "attribute" do
let(:value) { [user.mail] }
end
- it_behaves_like 'empty when lacking manage bcf'
+ it_behaves_like "empty when lacking manage bcf"
- context 'when lacking view_members' do
+ context "when lacking view_members" do
let(:permissions) { %i[manage_bcf edit_project] }
- it_behaves_like 'attribute' do
+ it_behaves_like "attribute" do
let(:value) { [] }
end
end
end
- describe 'project_actions' do
- let(:path) { 'project_actions' }
+ describe "project_actions" do
+ let(:path) { "project_actions" }
- it_behaves_like 'attribute' do
+ it_behaves_like "attribute" do
let(:value) { %w(update viewTopic createTopic) }
end
- context 'with only view_linked_issues' do
+ context "with only view_linked_issues" do
let(:permissions) { %i[view_linked_issues] }
- it_behaves_like 'attribute' do
+ it_behaves_like "attribute" do
let(:value) { %w[viewTopic] }
end
end
- context 'when lacking manage_bcf' do
+ context "when lacking manage_bcf" do
let(:permissions) { %i[edit_project] }
- it_behaves_like 'attribute' do
- let(:value) { ['update'] }
+ it_behaves_like "attribute" do
+ let(:value) { ["update"] }
end
end
- context 'when lacking edit_project' do
+ context "when lacking edit_project" do
let(:permissions) { %i[manage_bcf] }
- it_behaves_like 'attribute' do
+ it_behaves_like "attribute" do
let(:value) { %w[viewTopic createTopic] }
end
end
end
- describe 'topic_label' do
- let(:path) { 'topic_label' }
+ describe "topic_label" do
+ let(:path) { "topic_label" }
- it_behaves_like 'attribute' do
+ it_behaves_like "attribute" do
let(:value) { [] }
end
end
- describe 'snippet_type' do
- let(:path) { 'snippet_type' }
+ describe "snippet_type" do
+ let(:path) { "snippet_type" }
- it_behaves_like 'attribute' do
+ it_behaves_like "attribute" do
let(:value) { [] }
end
end
- describe 'stage' do
- let(:path) { 'stage' }
+ describe "stage" do
+ let(:path) { "stage" }
- it_behaves_like 'attribute' do
+ it_behaves_like "attribute" do
let(:value) { [] }
end
end
- describe 'comment_actions' do
- let(:path) { 'comment_actions' }
+ describe "comment_actions" do
+ let(:path) { "comment_actions" }
- it_behaves_like 'attribute' do
+ it_behaves_like "attribute" do
let(:value) { [] }
end
end
diff --git a/modules/bim/spec/representers/bcf/api/v2_1/projects/single_representer_rendering_spec.rb b/modules/bim/spec/representers/bcf/api/v2_1/projects/single_representer_rendering_spec.rb
index 00a15812a1f0..0c243b5db8cd 100644
--- a/modules/bim/spec/representers/bcf/api/v2_1/projects/single_representer_rendering_spec.rb
+++ b/modules/bim/spec/representers/bcf/api/v2_1/projects/single_representer_rendering_spec.rb
@@ -26,29 +26,29 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../shared_examples'
+require_relative "../shared_examples"
-RSpec.describe Bim::Bcf::API::V2_1::Projects::SingleRepresenter, 'rendering' do
+RSpec.describe Bim::Bcf::API::V2_1::Projects::SingleRepresenter, "rendering" do
let(:project) { build_stubbed(:project) }
let(:instance) { described_class.new(project) }
subject { instance.to_json }
- describe 'attributes' do
- context 'project_id' do
- it_behaves_like 'attribute' do
+ describe "attributes" do
+ context "project_id" do
+ it_behaves_like "attribute" do
let(:value) { project.id }
- let(:path) { 'project_id' }
+ let(:path) { "project_id" }
end
end
- context 'name' do
- it_behaves_like 'attribute' do
+ context "name" do
+ it_behaves_like "attribute" do
let(:value) { project.name }
- let(:path) { 'name' }
+ let(:path) { "name" }
end
end
end
diff --git a/modules/bim/spec/representers/bcf/api/v2_1/shared_examples.rb b/modules/bim/spec/representers/bcf/api/v2_1/shared_examples.rb
index 8590df5de8cc..6343845f397c 100644
--- a/modules/bim/spec/representers/bcf/api/v2_1/shared_examples.rb
+++ b/modules/bim/spec/representers/bcf/api/v2_1/shared_examples.rb
@@ -1,5 +1,5 @@
-RSpec.shared_examples_for 'attribute' do
- it 'reflects the value in the object' do
+RSpec.shared_examples_for "attribute" do
+ it "reflects the value in the object" do
expect(subject)
.to be_json_eql(value.to_json)
.at_path(path)
diff --git a/modules/bim/spec/representers/bcf/api/v2_1/topics/single_representer_rendering_spec.rb b/modules/bim/spec/representers/bcf/api/v2_1/topics/single_representer_rendering_spec.rb
index 49ba96f022fb..03b0a3f7ec1a 100644
--- a/modules/bim/spec/representers/bcf/api/v2_1/topics/single_representer_rendering_spec.rb
+++ b/modules/bim/spec/representers/bcf/api/v2_1/topics/single_representer_rendering_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../shared_examples'
+require_relative "../shared_examples"
-RSpec.describe Bim::Bcf::API::V2_1::Topics::SingleRepresenter, 'rendering' do
+RSpec.describe Bim::Bcf::API::V2_1::Topics::SingleRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
let(:assignee) { build_stubbed(:user) }
@@ -77,7 +77,7 @@
mock.allow_in_project *permissions, project: work_package.project
end
- contract = double('contract',
+ contract = double("contract",
model: issue,
user: current_user,
assignable_statuses: statuses)
@@ -90,148 +90,148 @@
subject { instance.to_json }
- describe 'attributes' do
- context 'guid' do
- it_behaves_like 'attribute' do
+ describe "attributes" do
+ context "guid" do
+ it_behaves_like "attribute" do
let(:value) { issue.uuid }
- let(:path) { 'guid' }
+ let(:path) { "guid" }
end
end
- context 'topic_type' do
- it_behaves_like 'attribute' do
+ context "topic_type" do
+ it_behaves_like "attribute" do
let(:value) { type.name }
- let(:path) { 'topic_type' }
+ let(:path) { "topic_type" }
end
end
- context 'topic_status' do
- it_behaves_like 'attribute' do
+ context "topic_status" do
+ it_behaves_like "attribute" do
let(:value) { status.name }
- let(:path) { 'topic_status' }
+ let(:path) { "topic_status" }
end
end
- context 'priority' do
- it_behaves_like 'attribute' do
+ context "priority" do
+ it_behaves_like "attribute" do
let(:value) { priority.name }
- let(:path) { 'priority' }
+ let(:path) { "priority" }
end
end
- context 'reference_links' do
- it_behaves_like 'attribute' do
+ context "reference_links" do
+ it_behaves_like "attribute" do
let(:value) { [api_v3_paths.work_package(work_package.id)] }
- let(:path) { 'reference_links' }
+ let(:path) { "reference_links" }
end
end
- context 'title' do
- it_behaves_like 'attribute' do
+ context "title" do
+ it_behaves_like "attribute" do
let(:value) { work_package.subject }
- let(:path) { 'title' }
+ let(:path) { "title" }
end
end
- context 'index' do
- it_behaves_like 'attribute' do
+ context "index" do
+ it_behaves_like "attribute" do
let(:value) { issue.index }
- let(:path) { 'index' }
+ let(:path) { "index" }
end
end
- context 'labels' do
- it_behaves_like 'attribute' do
+ context "labels" do
+ it_behaves_like "attribute" do
let(:value) { issue.labels }
- let(:path) { 'labels' }
+ let(:path) { "labels" }
end
end
- context 'creation_date' do
- it_behaves_like 'attribute' do
+ context "creation_date" do
+ it_behaves_like "attribute" do
let(:value) { work_package.created_at.iso8601(3) }
- let(:path) { 'creation_date' }
+ let(:path) { "creation_date" }
end
end
- context 'creation_author' do
- it_behaves_like 'attribute' do
+ context "creation_author" do
+ it_behaves_like "attribute" do
let(:value) { work_package.author.mail }
- let(:path) { 'creation_author' }
+ let(:path) { "creation_author" }
end
end
- context 'modified_date' do
- it_behaves_like 'attribute' do
+ context "modified_date" do
+ it_behaves_like "attribute" do
let(:value) { work_package.updated_at.iso8601(3) }
- let(:path) { 'modified_date' }
+ let(:path) { "modified_date" }
end
end
- context 'modified_author' do
- it_behaves_like 'attribute' do
+ context "modified_author" do
+ it_behaves_like "attribute" do
let(:value) { modifier.mail }
- let(:path) { 'modified_author' }
+ let(:path) { "modified_author" }
end
end
- context 'description' do
- it_behaves_like 'attribute' do
+ context "description" do
+ it_behaves_like "attribute" do
let(:value) { work_package.description }
- let(:path) { 'description' }
+ let(:path) { "description" }
end
end
- context 'due_date' do
- it_behaves_like 'attribute' do
+ context "due_date" do
+ it_behaves_like "attribute" do
let(:value) { work_package.due_date.iso8601 }
- let(:path) { 'due_date' }
+ let(:path) { "due_date" }
end
end
- context 'assigned_to' do
- it_behaves_like 'attribute' do
+ context "assigned_to" do
+ it_behaves_like "attribute" do
let(:value) { work_package.assigned_to.mail }
- let(:path) { 'assigned_to' }
+ let(:path) { "assigned_to" }
end
end
- context 'stage' do
- it_behaves_like 'attribute' do
+ context "stage" do
+ it_behaves_like "attribute" do
let(:value) { issue.stage }
- let(:path) { 'stage' }
+ let(:path) { "stage" }
end
end
end
- describe 'authorization' do
- context 'if the user has manage_bcf permission' do
- it 'lists the actions' do
+ describe "authorization" do
+ context "if the user has manage_bcf permission" do
+ it "lists the actions" do
expect(subject)
.to be_json_eql(%w[update updateRelatedTopics updateFiles createViewpoint].to_json)
- .at_path('authorization/topic_actions')
+ .at_path("authorization/topic_actions")
end
- it 'lists the allowed statuses' do
+ it "lists the allowed statuses" do
expect(subject)
.to be_json_eql(statuses.map(&:name).to_json)
- .at_path('authorization/topic_status')
+ .at_path("authorization/topic_status")
end
end
- context 'if the user lacks manage_bcf permission' do
+ context "if the user lacks manage_bcf permission" do
let(:permissions) { [] }
- it 'signals lack of available actions' do
+ it "signals lack of available actions" do
expect(subject)
.to be_json_eql([])
- .at_path('authorization/topic_actions')
+ .at_path("authorization/topic_actions")
end
- it 'lists no allowed status' do
+ it "lists no allowed status" do
expect(subject)
.to be_json_eql([].to_json)
- .at_path('authorization/topic_status')
+ .at_path("authorization/topic_status")
end
end
end
diff --git a/modules/bim/spec/representers/bcf/api/v2_1/users/single_representer_rendering_spec.rb b/modules/bim/spec/representers/bcf/api/v2_1/users/single_representer_rendering_spec.rb
index 4a921c116ea1..cf70db4832fd 100644
--- a/modules/bim/spec/representers/bcf/api/v2_1/users/single_representer_rendering_spec.rb
+++ b/modules/bim/spec/representers/bcf/api/v2_1/users/single_representer_rendering_spec.rb
@@ -26,29 +26,29 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../shared_examples'
+require_relative "../shared_examples"
-RSpec.describe Bim::Bcf::API::V2_1::Users::SingleRepresenter, 'rendering' do
+RSpec.describe Bim::Bcf::API::V2_1::Users::SingleRepresenter, "rendering" do
let(:user) { build_stubbed(:user) }
let(:instance) { described_class.new(user) }
subject { instance.to_json }
- describe 'attributes' do
- context 'id' do
- it_behaves_like 'attribute' do
+ describe "attributes" do
+ context "id" do
+ it_behaves_like "attribute" do
let(:value) { user.mail }
- let(:path) { 'id' }
+ let(:path) { "id" }
end
end
- context 'name' do
- it_behaves_like 'attribute' do
+ context "name" do
+ it_behaves_like "attribute" do
let(:value) { user.name }
- let(:path) { 'name' }
+ let(:path) { "name" }
end
end
end
diff --git a/modules/bim/spec/representers/bcf/api/v2_1/viewpoints/single_representer_rendering_spec.rb b/modules/bim/spec/representers/bcf/api/v2_1/viewpoints/single_representer_rendering_spec.rb
index cf9670544cf6..dcbf25e0ad14 100644
--- a/modules/bim/spec/representers/bcf/api/v2_1/viewpoints/single_representer_rendering_spec.rb
+++ b/modules/bim/spec/representers/bcf/api/v2_1/viewpoints/single_representer_rendering_spec.rb
@@ -26,18 +26,18 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../shared_examples'
+require_relative "../shared_examples"
-RSpec.describe Bim::Bcf::API::V2_1::Viewpoints::SingleRepresenter, 'rendering' do
+RSpec.describe Bim::Bcf::API::V2_1::Viewpoints::SingleRepresenter, "rendering" do
let(:viewpoint) { build_stubbed(:bcf_viewpoint) }
let(:instance) { described_class.new(viewpoint) }
subject { instance.to_json }
- it 'renders only the json_viewpoint attribute (as root)' do
+ it "renders only the json_viewpoint attribute (as root)" do
expect(subject)
- .to be_json_eql(viewpoint.read_attribute_before_type_cast('json_viewpoint'))
+ .to be_json_eql(viewpoint.read_attribute_before_type_cast("json_viewpoint"))
end
end
diff --git a/modules/bim/spec/representers/bcf/api/v2_1/viewpoints/single_representers_parsing_spec.rb b/modules/bim/spec/representers/bcf/api/v2_1/viewpoints/single_representers_parsing_spec.rb
index 1b5aec7bcdbd..58591ccc3171 100644
--- a/modules/bim/spec/representers/bcf/api/v2_1/viewpoints/single_representers_parsing_spec.rb
+++ b/modules/bim/spec/representers/bcf/api/v2_1/viewpoints/single_representers_parsing_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe Bim::Bcf::API::V2_1::Viewpoints::SingleRepresenter, 'rendering' do
+RSpec.describe Bim::Bcf::API::V2_1::Viewpoints::SingleRepresenter, "rendering" do
let(:struct) do
OpenStruct.new
end
@@ -84,7 +84,7 @@
subject { representer.from_hash(hash).to_h.to_json }
- shared_examples_for 'parses' do |attribute|
+ shared_examples_for "parses" do |attribute|
it attribute do
expect(subject)
.to be_json_eql(hash[attribute].to_json)
@@ -92,24 +92,24 @@
end
end
- it 'does not parse uuid' do
+ it "does not parse uuid" do
expect(subject)
- .not_to have_json_path('guid')
+ .not_to have_json_path("guid")
end
- it_behaves_like 'parses', 'index'
+ it_behaves_like "parses", "index"
- it_behaves_like 'parses', 'orthogonal_camera'
+ it_behaves_like "parses", "orthogonal_camera"
- it_behaves_like 'parses', 'perspective_camera'
+ it_behaves_like "parses", "perspective_camera"
- it_behaves_like 'parses', 'lines'
+ it_behaves_like "parses", "lines"
- it_behaves_like 'parses', 'clipping_planes'
+ it_behaves_like "parses", "clipping_planes"
- it_behaves_like 'parses', 'bitmaps' # in order to throw a not writable error)
+ it_behaves_like "parses", "bitmaps" # in order to throw a not writable error)
- it_behaves_like 'parses', 'snapshot'
+ it_behaves_like "parses", "snapshot"
- it_behaves_like 'parses', 'components'
+ it_behaves_like "parses", "components"
end
diff --git a/modules/bim/spec/requests/api/bcf/v2_1/auth_api_spec.rb b/modules/bim/spec/requests/api/bcf/v2_1/auth_api_spec.rb
index a60ec1ddcbfa..cd66bac52cfc 100644
--- a/modules/bim/spec/requests/api/bcf/v2_1/auth_api_spec.rb
+++ b/modules/bim/spec/requests/api/bcf/v2_1/auth_api_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-require_relative 'shared_responses'
+require_relative "shared_responses"
-RSpec.describe 'BCF 2.1 auth resource', content_type: :json do
+RSpec.describe "BCF 2.1 auth resource", content_type: :json do
include Rack::Test::Methods
let(:current_user) do
@@ -40,7 +40,7 @@
subject(:response) { last_response }
- describe 'GET /api/bcf/2.1/auth' do
+ describe "GET /api/bcf/2.1/auth" do
let(:path) { "/api/bcf/2.1/auth" }
before do
@@ -48,7 +48,7 @@
get path
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
{
oauth2_auth_url: "http://localhost:3000/oauth/authorize",
diff --git a/modules/bim/spec/requests/api/bcf/v2_1/comments_api_spec.rb b/modules/bim/spec/requests/api/bcf/v2_1/comments_api_spec.rb
index 5ad57c0ba904..f9ef244d9890 100644
--- a/modules/bim/spec/requests/api/bcf/v2_1/comments_api_spec.rb
+++ b/modules/bim/spec/requests/api/bcf/v2_1/comments_api_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-require_relative 'shared_responses'
+require_relative "shared_responses"
-RSpec.describe 'BCF 2.1 comments resource', content_type: :json do
+RSpec.describe "BCF 2.1 comments resource", content_type: :json do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -70,7 +70,7 @@
subject(:response) { last_response }
- describe 'GET /api/bcf/2.1/projects/:project_id/topics/:topic_guid/comments' do
+ describe "GET /api/bcf/2.1/projects/:project_id/topics/:topic_guid/comments" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics/#{bcf_issue.uuid}/comments" }
let(:current_user) { view_only_user }
let(:comments) { bcf_comment }
@@ -81,7 +81,7 @@
get path
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:comments) { [bcf_comment, bcf_answer, bcf_comment_to_viewpoint] }
let(:expected_body) do
@@ -132,10 +132,10 @@
end
end
- context 'with edit comments permission' do
+ context "with edit comments permission" do
let(:current_user) { edit_user }
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
[
{
@@ -159,14 +159,14 @@
end
end
- context 'without view permissions' do
+ context "without view permissions" do
let(:current_user) { user_without_permission }
- it_behaves_like 'bcf api not allowed response'
+ it_behaves_like "bcf api not allowed response"
end
end
- describe 'POST /api/bcf/2.1/projects/:project_id/topics/:topic_guid/comments' do
+ describe "POST /api/bcf/2.1/projects/:project_id/topics/:topic_guid/comments" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics/#{bcf_issue.uuid}/comments" }
let(:current_user) { edit_user }
let(:params) do
@@ -180,7 +180,7 @@
post path, params.to_json
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_status) { 201 }
let(:expected_body) do
comment = Bim::Bcf::Comment.last.reload
@@ -205,13 +205,13 @@
end
end
- context 'if user has no permission to write comments' do
+ context "if user has no permission to write comments" do
let(:current_user) { view_only_user }
- it_behaves_like 'bcf api not allowed response'
+ it_behaves_like "bcf api not allowed response"
end
- context 'if request contains viewpoint guid' do
+ context "if request contains viewpoint guid" do
let(:params) do
{
comment: "this is a comment to a specific viewpoint",
@@ -219,7 +219,7 @@
}
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_status) { 201 }
let(:expected_body) do
comment = Bim::Bcf::Comment.last.reload
@@ -244,7 +244,7 @@
end
end
- context 'if the viewpoint guid does not exist' do
+ context "if the viewpoint guid does not exist" do
let(:params) do
{
comment: "this is a comment to a specific viewpoint",
@@ -252,13 +252,13 @@
}
end
- it_behaves_like 'bcf api unprocessable response' do
- let(:message) { 'Viewpoint does not exist.' }
+ it_behaves_like "bcf api unprocessable response" do
+ let(:message) { "Viewpoint does not exist." }
end
end
end
- context 'if request contains reply comment' do
+ context "if request contains reply comment" do
let(:params) do
{
comment: "this is a reply comment to another comment",
@@ -266,7 +266,7 @@
}
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_status) { 201 }
let(:expected_body) do
comment = Bim::Bcf::Comment.last.reload
@@ -291,7 +291,7 @@
end
end
- context 'if the comment guid does not exist' do
+ context "if the comment guid does not exist" do
let(:params) do
{
comment: "this is a reply comment to another comment",
@@ -299,13 +299,13 @@
}
end
- it_behaves_like 'bcf api unprocessable response' do
- let(:message) { 'Bcf comment does not exist.' }
+ it_behaves_like "bcf api unprocessable response" do
+ let(:message) { "Bcf comment does not exist." }
end
end
end
- context 'if request contains reply comment and viewpoint reference' do
+ context "if request contains reply comment and viewpoint reference" do
let(:params) do
{
comment: "this is a reply comment to another comment with a specific reference to a viewpoint",
@@ -314,7 +314,7 @@
}
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_status) { 201 }
let(:expected_body) do
comment = Bim::Bcf::Comment.last.reload
@@ -339,7 +339,7 @@
end
end
- context 'if the comment guid does not exist' do
+ context "if the comment guid does not exist" do
let(:params) do
{
comment: "this is a reply comment to another comment",
@@ -348,12 +348,12 @@
}
end
- it_behaves_like 'bcf api unprocessable response' do
- let(:message) { 'Bcf comment does not exist.' }
+ it_behaves_like "bcf api unprocessable response" do
+ let(:message) { "Bcf comment does not exist." }
end
end
- context 'if the viewpoint guid does not exist' do
+ context "if the viewpoint guid does not exist" do
let(:params) do
{
comment: "this is a reply comment to another comment",
@@ -362,12 +362,12 @@
}
end
- it_behaves_like 'bcf api unprocessable response' do
- let(:message) { 'Viewpoint does not exist.' }
+ it_behaves_like "bcf api unprocessable response" do
+ let(:message) { "Viewpoint does not exist." }
end
end
- context 'if the comment and viewpoint guid does not exist' do
+ context "if the comment and viewpoint guid does not exist" do
let(:params) do
{
comment: "this is a reply comment to another comment",
@@ -376,14 +376,14 @@
}
end
- it_behaves_like 'bcf api unprocessable response' do
- let(:message) { 'Multiple field constraints have been violated. Viewpoint does not exist. Bcf comment does not exist.' }
+ it_behaves_like "bcf api unprocessable response" do
+ let(:message) { "Multiple field constraints have been violated. Viewpoint does not exist. Bcf comment does not exist." }
end
end
end
end
- describe 'PUT /api/bcf/2.1/projects/:project_id/topics/:topic_guid/comments' do
+ describe "PUT /api/bcf/2.1/projects/:project_id/topics/:topic_guid/comments" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics/#{bcf_issue.uuid}/comments" }
let(:current_user) { edit_user }
let(:params) { { comment: "This is a bad comment update ... " } }
@@ -393,10 +393,10 @@
put path, params.to_json
end
- it_behaves_like 'bcf api method not allowed response'
+ it_behaves_like "bcf api method not allowed response"
end
- describe 'GET /api/bcf/2.1/projects/:project_id/topics/:topic_guid/comments/:comment_guid' do
+ describe "GET /api/bcf/2.1/projects/:project_id/topics/:topic_guid/comments/:comment_guid" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics/#{bcf_issue.uuid}/comments/#{bcf_comment.uuid}" }
let(:current_user) { view_only_user }
let(:comments) { [bcf_comment, bcf_answer, bcf_comment_to_viewpoint] }
@@ -407,7 +407,7 @@
get path
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
{
guid: bcf_comment.uuid,
@@ -424,10 +424,10 @@
end
end
- context 'if user has editing permissions' do
+ context "if user has editing permissions" do
let(:current_user) { edit_user }
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
{
guid: bcf_comment.uuid,
@@ -449,21 +449,21 @@
end
end
- context 'if comment id does not exist' do
+ context "if comment id does not exist" do
let(:invalid_id) { "1337" }
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics/#{bcf_issue.uuid}/comments/#{invalid_id}" }
- it_behaves_like 'bcf api not found response'
+ it_behaves_like "bcf api not found response"
end
- context 'without view permissions' do
+ context "without view permissions" do
let(:current_user) { user_without_permission }
- it_behaves_like 'bcf api not allowed response'
+ it_behaves_like "bcf api not allowed response"
end
end
- describe 'PUT /api/bcf/2.1/projects/:project_id/topics/:topic_guid/comments/:comment_guid' do
+ describe "PUT /api/bcf/2.1/projects/:project_id/topics/:topic_guid/comments/:comment_guid" do
let(:updated_comment) { bcf_comment }
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics/#{bcf_issue.uuid}/comments/#{updated_comment.uuid}" }
let(:current_user) { edit_user }
@@ -474,7 +474,7 @@
put path, params.to_json
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
{
guid: updated_comment.uuid,
@@ -496,13 +496,13 @@
end
end
- context 'if user has no edit permissions' do
+ context "if user has no edit permissions" do
let(:current_user) { view_only_user }
- it_behaves_like 'bcf api not allowed response'
+ it_behaves_like "bcf api not allowed response"
end
- context 'if viewpoint reference and reply to is changed' do
+ context "if viewpoint reference and reply to is changed" do
let(:params) do
{
comment: "A new updated text",
@@ -511,7 +511,7 @@
}
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
{
guid: updated_comment.uuid,
@@ -534,7 +534,7 @@
end
end
- context 'if an invalid viewpoint guid is given' do
+ context "if an invalid viewpoint guid is given" do
let(:params) do
{
comment: "A new updated text",
@@ -542,12 +542,12 @@
}
end
- it_behaves_like 'bcf api unprocessable response' do
- let(:message) { 'Viewpoint does not exist.' }
+ it_behaves_like "bcf api unprocessable response" do
+ let(:message) { "Viewpoint does not exist." }
end
end
- context 'if an invalid comment guid is given' do
+ context "if an invalid comment guid is given" do
let(:params) do
{
comment: "A new updated text",
@@ -555,12 +555,12 @@
}
end
- it_behaves_like 'bcf api unprocessable response' do
- let(:message) { 'Bcf comment does not exist.' }
+ it_behaves_like "bcf api unprocessable response" do
+ let(:message) { "Bcf comment does not exist." }
end
end
- context 'if the updated comment contains viewpoint reference and is a reply, but update does not set those attributes' do
+ context "if the updated comment contains viewpoint reference and is a reply, but update does not set those attributes" do
let(:updated_comment) do
create(:bcf_comment,
issue: bcf_issue,
@@ -571,7 +571,7 @@
let(:params) { { comment: "Only change the comment text and leave the reply and viewpoint guid empty." } }
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
{
guid: updated_comment.uuid,
@@ -595,7 +595,7 @@
end
end
- describe 'POST /api/bcf/2.1/projects/:project_id/topics/:topic_guid/comments/:comment_guid' do
+ describe "POST /api/bcf/2.1/projects/:project_id/topics/:topic_guid/comments/:comment_guid" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics/#{bcf_issue.uuid}/comments/#{bcf_comment.uuid}" }
let(:current_user) { edit_user }
let(:params) { { comment: "This is an invalid try to create a comment ..." } }
@@ -605,6 +605,6 @@
post path, params.to_json
end
- it_behaves_like 'bcf api method not allowed response'
+ it_behaves_like "bcf api method not allowed response"
end
end
diff --git a/modules/bim/spec/requests/api/bcf/v2_1/current_user_api_spec.rb b/modules/bim/spec/requests/api/bcf/v2_1/current_user_api_spec.rb
index 9b226a1a9be4..3e099a8c13f6 100644
--- a/modules/bim/spec/requests/api/bcf/v2_1/current_user_api_spec.rb
+++ b/modules/bim/spec/requests/api/bcf/v2_1/current_user_api_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-require_relative 'shared_responses'
+require_relative "shared_responses"
-RSpec.describe 'BCF 2.1 current-user resource', content_type: :json do
+RSpec.describe "BCF 2.1 current-user resource", content_type: :json do
include Rack::Test::Methods
let(:current_user) do
@@ -40,7 +40,7 @@
subject(:response) { last_response }
- describe 'GET /api/bcf/2.1/current-user' do
+ describe "GET /api/bcf/2.1/current-user" do
let(:path) { "/api/bcf/2.1/current-user" }
before do
@@ -48,7 +48,7 @@
get path
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
{
id: current_user.mail,
diff --git a/modules/bim/spec/requests/api/bcf/v2_1/project_extensions_api_spec.rb b/modules/bim/spec/requests/api/bcf/v2_1/project_extensions_api_spec.rb
index 34d9a7ac2d37..6e7f880c0f25 100644
--- a/modules/bim/spec/requests/api/bcf/v2_1/project_extensions_api_spec.rb
+++ b/modules/bim/spec/requests/api/bcf/v2_1/project_extensions_api_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-require_relative 'shared_responses'
+require_relative "shared_responses"
-RSpec.describe 'BCF 2.1 project extensions resource', content_type: :json do
+RSpec.describe "BCF 2.1 project extensions resource", content_type: :json do
include Rack::Test::Methods
shared_let(:type_task) { create(:type_task) }
shared_let(:status) { create(:default_status) }
@@ -41,7 +41,7 @@
let(:path) { "/api/bcf/2.1/projects/#{project.id}/extensions" }
- context 'with only view_project permissions' do
+ context "with only view_project permissions" do
let(:current_user) do
create(:user,
member_with_permissions: { project => [:view_project] })
@@ -52,7 +52,7 @@
get path
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
{
topic_type: [],
@@ -70,7 +70,7 @@
end
end
- context 'with edit permissions in project' do
+ context "with edit permissions in project" do
let(:current_user) do
create(:user,
member_with_permissions: { project => %i[view_project edit_project manage_bcf view_members work_package_assigned] })
@@ -87,7 +87,7 @@
get path
end
- it_behaves_like 'bcf api successful response expectation' do
+ it_behaves_like "bcf api successful response expectation" do
let(:expectations) do
->(body) {
hash = JSON.parse(body)
@@ -97,15 +97,15 @@
stage snippet_type priority topic_label
]
- expect(hash['topic_type']).to include type_task.name
- expect(hash['topic_status']).to include status.name
+ expect(hash["topic_type"]).to include type_task.name
+ expect(hash["topic_status"]).to include status.name
- expect(hash['user_id_type']).to include(other_user.mail, current_user.mail)
+ expect(hash["user_id_type"]).to include(other_user.mail, current_user.mail)
- expect(hash['project_actions']).to eq %w[update viewTopic createTopic]
+ expect(hash["project_actions"]).to eq %w[update viewTopic createTopic]
- expect(hash['topic_actions']).to eq %w[update updateRelatedTopics updateFiles createViewpoint]
- expect(hash['comment_actions']).to eq []
+ expect(hash["topic_actions"]).to eq %w[update updateRelatedTopics updateFiles createViewpoint]
+ expect(hash["comment_actions"]).to eq []
}
end
end
diff --git a/modules/bim/spec/requests/api/bcf/v2_1/projects_api_spec.rb b/modules/bim/spec/requests/api/bcf/v2_1/projects_api_spec.rb
index 0ce928e33865..34a12b1c7e3b 100644
--- a/modules/bim/spec/requests/api/bcf/v2_1/projects_api_spec.rb
+++ b/modules/bim/spec/requests/api/bcf/v2_1/projects_api_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-require_relative 'shared_responses'
+require_relative "shared_responses"
-RSpec.describe 'BCF 2.1 projects resource', content_type: :json do
+RSpec.describe "BCF 2.1 projects resource", content_type: :json do
include Rack::Test::Methods
let(:view_only_user) do
@@ -49,7 +49,7 @@
subject(:response) { last_response }
- describe 'GET /api/bcf/2.1/projects/:project_id' do
+ describe "GET /api/bcf/2.1/projects/:project_id" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}" }
let(:current_user) { view_only_user }
@@ -58,7 +58,7 @@
get path
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
{
project_id: project.id,
@@ -67,20 +67,20 @@
end
end
- context 'lacking permissions' do
+ context "lacking permissions" do
let(:current_user) { non_member_user }
- it_behaves_like 'bcf api not found response'
+ it_behaves_like "bcf api not found response"
end
end
- describe 'PUT /api/bcf/2.1/projects/:project_id' do
+ describe "PUT /api/bcf/2.1/projects/:project_id" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}" }
let(:current_user) { edit_user }
let(:params) do
{
- name: 'new project name'
+ name: "new project name"
}
end
@@ -89,41 +89,41 @@
put path, params.to_json
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
{
project_id: project.id,
- name: 'new project name'
+ name: "new project name"
}
end
end
- context 'lacking view permissions' do
+ context "lacking view permissions" do
let(:current_user) { non_member_user }
- it_behaves_like 'bcf api not found response'
+ it_behaves_like "bcf api not found response"
end
- context 'lacking edit permissions' do
+ context "lacking edit permissions" do
let(:current_user) { view_only_user }
- it_behaves_like 'bcf api not allowed response'
+ it_behaves_like "bcf api not allowed response"
end
- context 'attempting to alter the id' do
+ context "attempting to alter the id" do
let(:params) do
{
project_id: 0
}
end
- it_behaves_like 'bcf api unprocessable response' do
- let(:message) { 'ID was attempted to be written but is not writable.' }
+ it_behaves_like "bcf api unprocessable response" do
+ let(:message) { "ID was attempted to be written but is not writable." }
end
end
end
- describe 'GET /api/bcf/2.1/projects' do
+ describe "GET /api/bcf/2.1/projects" do
let(:path) { "/api/bcf/2.1/projects" }
let(:current_user) { view_only_user }
let!(:invisible_project) { create(:project, enabled_module_names: [:bcf]) }
@@ -141,7 +141,7 @@
get path
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
[
{
diff --git a/modules/bim/spec/requests/api/bcf/v2_1/shared_responses.rb b/modules/bim/spec/requests/api/bcf/v2_1/shared_responses.rb
index abbec151a276..d3f1e3381bc1 100644
--- a/modules/bim/spec/requests/api/bcf/v2_1/shared_responses.rb
+++ b/modules/bim/spec/requests/api/bcf/v2_1/shared_responses.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-RSpec.shared_examples_for 'bcf api successful response' do
+RSpec.shared_examples_for "bcf api successful response" do
def expect_identical_without_time(subject, expected_body)
body = Array.wrap(JSON.parse(subject.body))
expected = Array.wrap(expected_body)
@@ -37,8 +37,8 @@ def expect_identical_without_time(subject, expected_body)
expected_item.stringify_keys!
# Remove date strings and compare separately
- subject_modified_date = subject_body.delete('modified_date')&.to_time
- expected_modified_date = expected_item.delete('modified_date')&.to_time
+ subject_modified_date = subject_body.delete("modified_date")&.to_time
+ expected_modified_date = expected_item.delete("modified_date")&.to_time
if expected_modified_date
expect(subject_modified_date).to be_within(10.seconds).of(expected_modified_date)
@@ -46,8 +46,8 @@ def expect_identical_without_time(subject, expected_body)
expect(subject_modified_date).to eql(expected_modified_date)
end
- subject_created_date = subject_body.delete('date')&.to_time
- expected_created_date = expected_item.delete('date')&.to_time
+ subject_created_date = subject_body.delete("date")&.to_time
+ expected_created_date = expected_item.delete("date")&.to_time
if expected_created_date
expect(subject_created_date).to be_within(10.seconds).of(expected_created_date)
@@ -59,7 +59,7 @@ def expect_identical_without_time(subject, expected_body)
end
end
- it 'responds correctly with the expected body', :aggregate_failures do
+ it "responds correctly with the expected body", :aggregate_failures do
expect(subject.status)
.to eql(defined?(expected_status) ? expected_status : 200)
@@ -69,68 +69,68 @@ def expect_identical_without_time(subject, expected_body)
expect_identical_without_time(subject, expected_body)
end
- expect(subject.headers['Content-Type']).to eql 'application/json; charset=utf-8' unless defined?(no_content)
+ expect(subject.headers["Content-Type"]).to eql "application/json; charset=utf-8" unless defined?(no_content)
end
end
-RSpec.shared_examples_for 'bcf api successful response expectation' do
- it 'responds correctly with the expected body', :aggregate_failures do
+RSpec.shared_examples_for "bcf api successful response expectation" do
+ it "responds correctly with the expected body", :aggregate_failures do
expect(subject.status).to eq 200
instance_exec(subject.body, &expectations)
- expect(subject.headers['Content-Type']).to eql 'application/json; charset=utf-8'
+ expect(subject.headers["Content-Type"]).to eql "application/json; charset=utf-8"
end
end
-RSpec.shared_examples_for 'bcf api not found response' do
+RSpec.shared_examples_for "bcf api not found response" do
let(:expect404) do
- { message: 'The requested resource could not be found.' }
+ { message: "The requested resource could not be found." }
end
- it 'responds 404 NOT FOUND', :aggregate_failures do
+ it "responds 404 NOT FOUND", :aggregate_failures do
expect(subject.status).to eq 404
expect(subject.body).to be_json_eql(expect404.to_json)
- expect(subject.headers['Content-Type']).to eql 'application/json; charset=utf-8'
+ expect(subject.headers["Content-Type"]).to eql "application/json; charset=utf-8"
end
end
-RSpec.shared_examples_for 'bcf api method not allowed response' do
+RSpec.shared_examples_for "bcf api method not allowed response" do
let(:expect405) { "405 Not Allowed" }
- it 'responds 405 METHOD NOT ALLOWED', :aggregate_failures do
+ it "responds 405 METHOD NOT ALLOWED", :aggregate_failures do
expect(subject.status).to eq 405
expect(subject.body).to eql(expect405)
- expect(subject.headers['Content-Type']).to eql 'application/json; charset=utf-8'
+ expect(subject.headers["Content-Type"]).to eql "application/json; charset=utf-8"
end
end
-RSpec.shared_examples_for 'bcf api not allowed response' do
+RSpec.shared_examples_for "bcf api not allowed response" do
let(:expect403) do
- { message: 'You are not authorized to access this resource.' }
+ { message: "You are not authorized to access this resource." }
end
- it 'responds 403 NOT ALLOWED', :aggregate_failures do
+ it "responds 403 NOT ALLOWED", :aggregate_failures do
expect(subject.status).to eq 403
expect(subject.body).to be_json_eql(expect403.to_json)
- expect(subject.headers['Content-Type']).to eql 'application/json; charset=utf-8'
+ expect(subject.headers["Content-Type"]).to eql "application/json; charset=utf-8"
end
end
-RSpec.shared_examples_for 'bcf api unprocessable response' do
+RSpec.shared_examples_for "bcf api unprocessable response" do
let(:expect422) do
{ message: }
end
- it 'responds 422 UNPROCESSABLE ENTITY', :aggregate_failures do
+ it "responds 422 UNPROCESSABLE ENTITY", :aggregate_failures do
expect(subject.status).to eq 422
expect(subject.body).to be_json_eql(expect422.to_json)
- expect(subject.headers['Content-Type']).to eql 'application/json; charset=utf-8'
+ expect(subject.headers["Content-Type"]).to eql "application/json; charset=utf-8"
end
end
-RSpec.shared_examples_for 'bcf api not implemented response' do
- it 'responds 501 not implemented', :aggregate_failures do
+RSpec.shared_examples_for "bcf api not implemented response" do
+ it "responds 501 not implemented", :aggregate_failures do
expect(subject.status).to be 501
expected = {
@@ -138,6 +138,6 @@ def expect_identical_without_time(subject, expected_body)
}
expect(subject.body).to be_json_eql(expected.to_json)
- expect(subject.headers['Content-Type']).to eql 'application/json; charset=utf-8'
+ expect(subject.headers["Content-Type"]).to eql "application/json; charset=utf-8"
end
end
diff --git a/modules/bim/spec/requests/api/bcf/v2_1/topics_api_spec.rb b/modules/bim/spec/requests/api/bcf/v2_1/topics_api_spec.rb
index bf22e20f7273..ec068c9c42a6 100644
--- a/modules/bim/spec/requests/api/bcf/v2_1/topics_api_spec.rb
+++ b/modules/bim/spec/requests/api/bcf/v2_1/topics_api_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-require_relative 'shared_responses'
+require_relative "shared_responses"
-RSpec.describe 'BCF 2.1 topics resource', content_type: :json do
+RSpec.describe "BCF 2.1 topics resource", content_type: :json do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -99,7 +99,7 @@
subject(:response) { last_response }
- describe 'GET /api/bcf/2.1/projects/:project_id/topics' do
+ describe "GET /api/bcf/2.1/projects/:project_id/topics" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics" }
let(:current_user) { view_only_user }
@@ -110,7 +110,7 @@
get path
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
work_package.reload
[
@@ -142,22 +142,22 @@
end
end
- context 'lacking permission to see project' do
+ context "lacking permission to see project" do
let(:current_user) { non_member_user }
- it_behaves_like 'bcf api not found response'
+ it_behaves_like "bcf api not found response"
end
- context 'lacking permission to see linked issues' do
+ context "lacking permission to see linked issues" do
let(:current_user) { only_member_user }
- it_behaves_like 'bcf api not allowed response'
+ it_behaves_like "bcf api not allowed response"
end
- context 'having edit permission' do
+ context "having edit permission" do
let(:current_user) { edit_member_user }
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
work_package.reload
@@ -192,7 +192,7 @@
end
end
- describe 'GET /api/bcf/2.1/projects/:project_id/topics/:uuid' do
+ describe "GET /api/bcf/2.1/projects/:project_id/topics/:uuid" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics/#{bcf_issue.uuid}" }
let(:current_user) { view_only_user }
@@ -203,7 +203,7 @@
get path
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
work_package.reload
@@ -234,28 +234,28 @@
end
end
- context 'lacking permission to see project' do
+ context "lacking permission to see project" do
let(:current_user) { non_member_user }
- it_behaves_like 'bcf api not found response'
+ it_behaves_like "bcf api not found response"
end
- context 'invalid uuid' do
+ context "invalid uuid" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics/0" }
- it_behaves_like 'bcf api not found response'
+ it_behaves_like "bcf api not found response"
end
- context 'lacking permission to see linked issues' do
+ context "lacking permission to see linked issues" do
let(:current_user) { only_member_user }
- it_behaves_like 'bcf api not allowed response'
+ it_behaves_like "bcf api not allowed response"
end
- context 'having edit permission' do
+ context "having edit permission" do
let(:current_user) { edit_member_user }
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
work_package.reload
@@ -288,7 +288,7 @@
end
end
- describe 'DELETE /api/bcf/2.1/projects/:project_id/topics/:uuid' do
+ describe "DELETE /api/bcf/2.1/projects/:project_id/topics/:uuid" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics/#{bcf_issue.uuid}" }
let(:current_user) { edit_and_delete_member_user }
@@ -299,169 +299,169 @@
delete path
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_status) { 204 }
let(:expected_body) { nil }
let(:no_content) { true }
end
- it 'deletes the Bcf Issue as well as the belonging Work Package' do
+ it "deletes the Bcf Issue as well as the belonging Work Package" do
expect(WorkPackage.where(id: work_package.id)).to be_empty
expect(Bim::Bcf::Issue.where(id: bcf_issue.id)).to be_empty
end
- context 'lacking permission to delete bcf' do
+ context "lacking permission to delete bcf" do
let(:current_user) { edit_member_user }
- it_behaves_like 'bcf api not allowed response'
+ it_behaves_like "bcf api not allowed response"
- it 'deletes neither the Work Package nor the Bcf Issue' do
+ it "deletes neither the Work Package nor the Bcf Issue" do
expect(WorkPackage.where(id: work_package.id)).to contain_exactly(work_package)
expect(Bim::Bcf::Issue.where(id: bcf_issue.id)).to contain_exactly(bcf_issue)
end
end
end
- shared_examples_for 'topics api write invalid parameters errors' do
- context 'without a title' do
+ shared_examples_for "topics api write invalid parameters errors" do
+ context "without a title" do
let(:params) do
{}
end
- it_behaves_like 'bcf api unprocessable response' do
+ it_behaves_like "bcf api unprocessable response" do
let(:message) do
"Title can't be blank."
end
end
end
- context 'with an inexistent status' do
+ context "with an inexistent status" do
let(:params) do
{
- title: 'Some title',
- topic_status: 'Some non existing status'
+ title: "Some title",
+ topic_status: "Some non existing status"
}
end
- it_behaves_like 'bcf api unprocessable response' do
+ it_behaves_like "bcf api unprocessable response" do
let(:message) do
"Status does not exist."
end
end
end
- context 'with an inexistent priority' do
+ context "with an inexistent priority" do
let(:params) do
{
- title: 'Some title',
- priority: 'Some non existing priority'
+ title: "Some title",
+ priority: "Some non existing priority"
}
end
- it_behaves_like 'bcf api unprocessable response' do
+ it_behaves_like "bcf api unprocessable response" do
let(:message) do
"Priority does not exist."
end
end
end
- context 'with an inexistent type' do
+ context "with an inexistent type" do
let(:params) do
{
- title: 'Some title',
- topic_type: 'Some non existing type'
+ title: "Some title",
+ topic_type: "Some non existing type"
}
end
- it_behaves_like 'bcf api unprocessable response' do
+ it_behaves_like "bcf api unprocessable response" do
let(:message) do
"Type does not exist."
end
end
end
- context 'with an inexistent assigned_to' do
+ context "with an inexistent assigned_to" do
let(:params) do
{
- title: 'Some title',
- assigned_to: 'Some non existing assignee'
+ title: "Some title",
+ assigned_to: "Some non existing assignee"
}
end
- it_behaves_like 'bcf api unprocessable response' do
+ it_behaves_like "bcf api unprocessable response" do
let(:message) do
"Assignee does not exist."
end
end
end
- context 'with two inexistent related resources' do
+ context "with two inexistent related resources" do
let(:params) do
{
- title: 'Some title',
- assigned_to: 'Some non existing assignee',
- topic_type: 'Some non existing type'
+ title: "Some title",
+ assigned_to: "Some non existing assignee",
+ topic_type: "Some non existing type"
}
end
- it_behaves_like 'bcf api unprocessable response' do
+ it_behaves_like "bcf api unprocessable response" do
let(:message) do
"Multiple field constraints have been violated. Type does not exist. Assignee does not exist."
end
end
end
- context 'with a label' do
+ context "with a label" do
let(:params) do
{
- title: 'Some title',
- labels: ['some label']
+ title: "Some title",
+ labels: ["some label"]
}
end
- it_behaves_like 'bcf api unprocessable response' do
+ it_behaves_like "bcf api unprocessable response" do
let(:message) do
"Labels was attempted to be written but is not writable."
end
end
end
- context 'with a stage' do
+ context "with a stage" do
let(:params) do
{
- title: 'Some title',
- stage: 'some stage'
+ title: "Some title",
+ stage: "some stage"
}
end
- it_behaves_like 'bcf api unprocessable response' do
+ it_behaves_like "bcf api unprocessable response" do
let(:message) do
"Stage was attempted to be written but is not writable."
end
end
end
- context 'with reference links' do
+ context "with reference links" do
let(:params) do
{
- title: 'Some title',
+ title: "Some title",
reference_links: [
"/some/relative/links"
]
}
end
- it_behaves_like 'bcf api unprocessable response' do
+ it_behaves_like "bcf api unprocessable response" do
let(:message) do
"Reference links was attempted to be written but is not writable."
end
end
end
- context 'with bim_snippet' do
+ context "with bim_snippet" do
let(:params) do
{
- title: 'Some title',
+ title: "Some title",
bim_snippet: {
snippet_type: "clash",
is_external: true,
@@ -471,7 +471,7 @@
}
end
- it_behaves_like 'bcf api unprocessable response' do
+ it_behaves_like "bcf api unprocessable response" do
let(:message) do
"Bim snippet was attempted to be written but is not writable."
end
@@ -479,7 +479,7 @@
end
end
- describe 'POST /api/bcf/2.1/projects/:project_id/topics' do
+ describe "POST /api/bcf/2.1/projects/:project_id/topics" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics" }
let(:current_user) { edit_member_user }
let(:type) do
@@ -518,7 +518,7 @@
let!(:default_priority) do
create(:default_priority)
end
- let(:description) { 'some description' }
+ let(:description) { "some description" }
let(:stage) { nil }
let(:labels) { [] }
let(:index) { 5 }
@@ -527,7 +527,7 @@
topic_type: type.name,
topic_status: status.name,
priority: priority.name,
- title: 'BCF topic 101',
+ title: "BCF topic 101",
labels:,
stage:,
index:,
@@ -543,7 +543,7 @@
post path, params.to_json
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_status) { 201 }
let(:expected_body) do
issue = Bim::Bcf::Issue.last.reload
@@ -554,7 +554,7 @@
topic_type: type.name,
topic_status: status.name,
priority: priority.name,
- title: 'BCF topic 101',
+ title: "BCF topic 101",
labels:,
index:,
reference_links: [
@@ -614,14 +614,14 @@ def expected_body_for_bcf_issue(
}
end
- context 'with minimal parameters' do
+ context "with minimal parameters" do
let(:params) do
{
- title: 'BCF topic 101'
+ title: "BCF topic 101"
}
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_status) { 201 }
let(:expected_body) do
expected_body_for_bcf_issue(
@@ -634,7 +634,7 @@ def expected_body_for_bcf_issue(
end
end
- context 'with an existing work package' do
+ context "with an existing work package" do
let!(:existing_work_package) do
create(:work_package, author: assignee, assigned_to: assignee, project:)
end
@@ -648,7 +648,7 @@ def expected_body_for_bcf_issue(
}
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_status) { 201 }
let(:expected_body) do
expected_body_for_bcf_issue(
@@ -661,7 +661,7 @@ def expected_body_for_bcf_issue(
end
end
- context 'with a non-existing work package' do
+ context "with a non-existing work package" do
let(:params) do
{
title: "A new BCF topic",
@@ -671,12 +671,12 @@ def expected_body_for_bcf_issue(
}
end
- it_behaves_like 'bcf api unprocessable response' do
+ it_behaves_like "bcf api unprocessable response" do
let(:message) { "Work package does not exist." }
end
end
- context 'with a work package where the user is not a bcf manager' do
+ context "with a work package where the user is not a bcf manager" do
let(:current_user) { view_only_user }
let(:params) do
@@ -694,7 +694,7 @@ def expected_body_for_bcf_issue(
end
end
- context 'with a work package in another project' do
+ context "with a work package in another project" do
let!(:foreign_work_package) { create(:work_package) }
let(:params) do
@@ -712,7 +712,7 @@ def expected_body_for_bcf_issue(
end
end
- context 'with a work package that already belongs to a BCF issue' do
+ context "with a work package that already belongs to a BCF issue" do
let(:params) do
{
title: "A BCF topic that shouldn't be",
@@ -722,22 +722,22 @@ def expected_body_for_bcf_issue(
}
end
- it_behaves_like 'bcf api unprocessable response' do
+ it_behaves_like "bcf api unprocessable response" do
let(:message) { "Work package has already been taken." }
end
end
end
- it_behaves_like 'topics api write invalid parameters errors'
+ it_behaves_like "topics api write invalid parameters errors"
- context 'if not allowed to add topics' do
+ context "if not allowed to add topics" do
let(:current_user) { view_only_user }
- it_behaves_like 'bcf api not allowed response'
+ it_behaves_like "bcf api not allowed response"
end
end
- describe 'PUT /api/bcf/2.1/projects/:project_id/topics/:guid' do
+ describe "PUT /api/bcf/2.1/projects/:project_id/topics/:guid" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics/#{bcf_issue.uuid}" }
let(:current_user) { edit_member_user }
let!(:type) do
@@ -775,14 +775,14 @@ def expected_body_for_bcf_issue(
let!(:default_priority) do
create(:default_priority)
end
- let(:description) { 'some description' }
+ let(:description) { "some description" }
let(:index) { 5 }
let(:params) do
{
topic_type: type.name,
topic_status: status.name,
priority: priority.name,
- title: 'BCF topic 101',
+ title: "BCF topic 101",
index:,
due_date: Date.today.iso8601,
assigned_to: view_only_user.mail,
@@ -796,7 +796,7 @@ def expected_body_for_bcf_issue(
put path, params.to_json
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
work_package.reload
@@ -805,7 +805,7 @@ def expected_body_for_bcf_issue(
topic_type: type.name,
topic_status: status.name,
priority: priority.name,
- title: 'BCF topic 101',
+ title: "BCF topic 101",
labels: [],
index:,
reference_links: [
@@ -827,15 +827,15 @@ def expected_body_for_bcf_issue(
end
end
- context 'with only the minimally required property (title)' do
- let(:new_title) { 'New title' }
+ context "with only the minimally required property (title)" do
+ let(:new_title) { "New title" }
let(:params) do
{
title: new_title
}
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
reloaded_work_package = WorkPackage.find(work_package.id)
@@ -867,12 +867,12 @@ def expected_body_for_bcf_issue(
end
end
- it_behaves_like 'topics api write invalid parameters errors'
+ it_behaves_like "topics api write invalid parameters errors"
- context 'if not allowed to alter topics' do
+ context "if not allowed to alter topics" do
let(:current_user) { view_only_user }
- it_behaves_like 'bcf api not allowed response'
+ it_behaves_like "bcf api not allowed response"
end
end
end
diff --git a/modules/bim/spec/requests/api/bcf/v2_1/viewpoints_api_spec.rb b/modules/bim/spec/requests/api/bcf/v2_1/viewpoints_api_spec.rb
index 8ae31ca303cb..f843c7c467c2 100644
--- a/modules/bim/spec/requests/api/bcf/v2_1/viewpoints_api_spec.rb
+++ b/modules/bim/spec/requests/api/bcf/v2_1/viewpoints_api_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-require_relative 'shared_responses'
+require_relative "shared_responses"
-RSpec.describe 'BCF 2.1 viewpoints resource', content_type: :json do
+RSpec.describe "BCF 2.1 viewpoints resource", content_type: :json do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -67,7 +67,7 @@
subject(:response) { last_response }
- describe 'GET /api/bcf/2.1/projects/:project_id/topics/:topic/viewpoints' do
+ describe "GET /api/bcf/2.1/projects/:project_id/topics/:topic/viewpoints" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics/#{bcf_issue.uuid}/viewpoints" }
let(:current_user) { view_only_user }
@@ -76,18 +76,18 @@
get path
end
- it_behaves_like 'bcf api successful response' do
- let(:expected_body) { [viewpoint_json.except('components')] }
+ it_behaves_like "bcf api successful response" do
+ let(:expected_body) { [viewpoint_json.except("components")] }
end
- context 'lacking permission to see project' do
+ context "lacking permission to see project" do
let(:current_user) { non_member_user }
- it_behaves_like 'bcf api not found response'
+ it_behaves_like "bcf api not found response"
end
end
- describe 'GET /api/bcf/2.1/projects/:project_id/topics/:uuid/viewpoints/:uuid' do
+ describe "GET /api/bcf/2.1/projects/:project_id/topics/:uuid/viewpoints/:uuid" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics/#{bcf_issue.uuid}/viewpoints/#{viewpoint.uuid}" }
let(:current_user) { view_only_user }
@@ -97,24 +97,24 @@
get path
end
- it_behaves_like 'bcf api successful response' do
- let(:expected_body) { viewpoint_json.except('components') }
+ it_behaves_like "bcf api successful response" do
+ let(:expected_body) { viewpoint_json.except("components") }
end
- context 'lacking permission to see project' do
+ context "lacking permission to see project" do
let(:current_user) { non_member_user }
- it_behaves_like 'bcf api not found response'
+ it_behaves_like "bcf api not found response"
end
- context 'invalid uuid' do
+ context "invalid uuid" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics/0/viewpoints" }
- it_behaves_like 'bcf api not found response'
+ it_behaves_like "bcf api not found response"
end
end
- describe 'DELETE /api/bcf/2.1/projects/:project_id/topics/:uuid/viewpoints/:uuid' do
+ describe "DELETE /api/bcf/2.1/projects/:project_id/topics/:uuid/viewpoints/:uuid" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics/#{bcf_issue.uuid}/viewpoints/#{viewpoint.uuid}" }
let(:current_user) { create_user }
@@ -125,13 +125,13 @@
end
shared_examples "successfully deletes the viewpoint" do
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_status) { 204 }
let(:expected_body) { nil }
let(:no_content) { true }
end
- it 'deletes the viewpoint' do
+ it "deletes the viewpoint" do
expect(Bim::Bcf::Viewpoint.where(id: viewpoint.id)).not_to be_exist
end
end
@@ -151,22 +151,22 @@
it_behaves_like "successfully deletes the viewpoint"
end
- context 'lacking permission to see project' do
+ context "lacking permission to see project" do
let(:current_user) { non_member_user }
- it_behaves_like 'bcf api not found response'
+ it_behaves_like "bcf api not found response"
end
- context 'lacking permission to delete' do
+ context "lacking permission to delete" do
let(:current_user) { view_only_user }
- it_behaves_like 'bcf api not allowed response'
+ it_behaves_like "bcf api not allowed response"
end
- context 'invalid uuid' do
+ context "invalid uuid" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics/#{bcf_issue.uuid}/viewpoints/#{viewpoint.uuid}1" }
- it_behaves_like 'bcf api not found response'
+ it_behaves_like "bcf api not found response"
end
end
@@ -181,27 +181,27 @@
get path
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
- { section => viewpoint_json.dig('components', section) }
+ { section => viewpoint_json.dig("components", section) }
end
end
end
end
- describe 'GET /api/bcf/2.1/projects/:project_id/topics/:uuid/viewpoints/:uuid/snapshot' do
+ describe "GET /api/bcf/2.1/projects/:project_id/topics/:uuid/viewpoints/:uuid/snapshot" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics/#{bcf_issue.uuid}/viewpoints/#{viewpoint.uuid}/snapshot" }
let(:current_user) { view_only_user }
- context 'when snapshot present' do
+ context "when snapshot present" do
before do
login_as(current_user)
get path
end
- it 'responds with the attachment with the appropriate content type and cache headers' do
+ it "responds with the attachment with the appropriate content type and cache headers" do
expect(subject.status).to eq 200
- expect(subject.headers['Content-Type']).to eq 'image/png'
+ expect(subject.headers["Content-Type"]).to eq "image/png"
max_age = OpenProject::Configuration.fog_download_url_expires_in - 10
@@ -215,18 +215,18 @@
end
end
- context 'when snapshot not present' do
+ context "when snapshot not present" do
before do
login_as(current_user)
viewpoint.snapshot.destroy
get path
end
- it_behaves_like 'bcf api not found response'
+ it_behaves_like "bcf api not found response"
end
end
- describe 'GET /api/bcf/2.1/projects/:project_id/topics/:uuid/viewpoints/:uuid/bitmaps' do
+ describe "GET /api/bcf/2.1/projects/:project_id/topics/:uuid/viewpoints/:uuid/bitmaps" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics/#{bcf_issue.uuid}/viewpoints/#{viewpoint.uuid}/bitmaps" }
let(:current_user) { view_only_user }
@@ -235,12 +235,12 @@
get path
end
- it_behaves_like 'bcf api not implemented response' do
- let(:expected_message) { 'Bitmaps are not yet implemented.' }
+ it_behaves_like "bcf api not implemented response" do
+ let(:expected_message) { "Bitmaps are not yet implemented." }
end
end
- describe 'POST /api/bcf/2.1/projects/:project_id/topics/:topic/viewpoints' do
+ describe "POST /api/bcf/2.1/projects/:project_id/topics/:topic/viewpoints" do
let(:path) { "/api/bcf/2.1/projects/#{project.id}/topics/#{bcf_issue.uuid}/viewpoints" }
let(:current_user) { create_user }
let(:params) do
@@ -251,7 +251,7 @@
"snapshot_type" => "png",
"snapshot_data" => "data:image/png;base64,SGVsbG8gV29ybGQh"
}
- ).except('bitmaps', 'guid')
+ ).except("bitmaps", "guid")
end
before do
@@ -259,7 +259,7 @@
post path, params.to_json
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
new_viewpoint = Bim::Bcf::Viewpoint.last
@@ -271,7 +271,7 @@
let(:expected_status) { 201 }
end
- it 'creates the viewpoint with an attachment for the snapshot' do
+ it "creates the viewpoint with an attachment for the snapshot" do
expect(Bim::Bcf::Viewpoint.count)
.to be 2
@@ -279,19 +279,19 @@
.to be 1
end
- context 'lacking permission to see project' do
+ context "lacking permission to see project" do
let(:current_user) { non_member_user }
- it_behaves_like 'bcf api not found response'
+ it_behaves_like "bcf api not found response"
end
- context 'lacking manage_bcf permission' do
+ context "lacking manage_bcf permission" do
let(:current_user) { view_only_user }
- it_behaves_like 'bcf api not allowed response'
+ it_behaves_like "bcf api not allowed response"
end
- context 'providing a number for a perspective that might be transformed into a BigDecimal (by the Oj gem)' do
+ context "providing a number for a perspective that might be transformed into a BigDecimal (by the Oj gem)" do
let(:params) do
attributes_for(:bcf_viewpoint)[:json_viewpoint]
.merge(
@@ -313,10 +313,10 @@
},
"field_of_view" => 60
}
- ).except('bitmaps')
+ ).except("bitmaps")
end
- it_behaves_like 'bcf api successful response' do
+ it_behaves_like "bcf api successful response" do
let(:expected_body) do
new_viewpoint = Bim::Bcf::Viewpoint.last
@@ -327,13 +327,13 @@
let(:expected_status) { 201 }
end
- it 'creates the viewpoint with an attachment for the snapshot' do
+ it "creates the viewpoint with an attachment for the snapshot" do
expect(Bim::Bcf::Viewpoint.count)
.to be 2
end
end
- context 'providing an invalid viewpoint json by having an invalid snapshot type' do
+ context "providing an invalid viewpoint json by having an invalid snapshot type" do
let(:params) do
attributes_for(:bcf_viewpoint)[:json_viewpoint]
.merge(
@@ -342,15 +342,15 @@
"snapshot_type" => "tiff",
"snapshot_data" => "SGVsbG8gV29ybGQh"
}
- ).except('bitmaps')
+ ).except("bitmaps")
end
- it_behaves_like 'bcf api unprocessable response' do
- let(:message) { I18n.t('activerecord.errors.models.bim/bcf/viewpoint.snapshot_type_unsupported') }
+ it_behaves_like "bcf api unprocessable response" do
+ let(:message) { I18n.t("activerecord.errors.models.bim/bcf/viewpoint.snapshot_type_unsupported") }
end
end
- context 'providing an invalid viewpoint json by not having snapshot_data' do
+ context "providing an invalid viewpoint json by not having snapshot_data" do
let(:params) do
attributes_for(:bcf_viewpoint)[:json_viewpoint]
.merge(
@@ -358,25 +358,25 @@
{
"snapshot_type" => "jpg"
}
- ).except('bitmaps')
+ ).except("bitmaps")
end
- it_behaves_like 'bcf api unprocessable response' do
- let(:message) { I18n.t('activerecord.errors.models.bim/bcf/viewpoint.snapshot_data_blank') }
+ it_behaves_like "bcf api unprocessable response" do
+ let(:message) { I18n.t("activerecord.errors.models.bim/bcf/viewpoint.snapshot_data_blank") }
end
end
- context 'providing an invalid viewpoint json by writing bitmaps and having a string for the integer' do
+ context "providing an invalid viewpoint json by writing bitmaps and having a string for the integer" do
let(:params) do
attributes_for(:bcf_viewpoint)[:json_viewpoint]
- .merge('index' => 'some invalid index')
+ .merge("index" => "some invalid index")
end
- it_behaves_like 'bcf api unprocessable response' do
+ it_behaves_like "bcf api unprocessable response" do
let(:message) do
- [I18n.t('api_v3.errors.multiple_errors'),
- I18n.t('activerecord.errors.models.bim/bcf/viewpoint.index_not_integer'),
- I18n.t('activerecord.errors.models.bim/bcf/viewpoint.bitmaps_not_writable')].join(" ")
+ [I18n.t("api_v3.errors.multiple_errors"),
+ I18n.t("activerecord.errors.models.bim/bcf/viewpoint.index_not_integer"),
+ I18n.t("activerecord.errors.models.bim/bcf/viewpoint.bitmaps_not_writable")].join(" ")
end
end
end
diff --git a/modules/bim/spec/requests/api/bcf_xml/v1/bcf_xml_api_spec.rb b/modules/bim/spec/requests/api/bcf_xml/v1/bcf_xml_api_spec.rb
index 69cb65849fd9..eff4ecfab576 100644
--- a/modules/bim/spec/requests/api/bcf_xml/v1/bcf_xml_api_spec.rb
+++ b/modules/bim/spec/requests/api/bcf_xml/v1/bcf_xml_api_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'BCF XML API v1 bcf_xml resource' do
+RSpec.describe "BCF XML API v1 bcf_xml resource" do
include Rack::Test::Methods
- let!(:status) { create(:status, name: 'New', is_default: true) }
- let!(:type) { create(:type, name: 'Issue', is_standard: true, is_default: true) }
+ let!(:status) { create(:status, name: "New", is_default: true) }
+ let!(:type) { create(:type, name: "Issue", is_standard: true, is_default: true) }
let!(:priority) { create(:issue_priority, name: "Mega high", is_default: true) }
let!(:project) { create(:project, enabled_module_names: %w[bim work_package_tracking], types: [type]) }
@@ -44,11 +44,11 @@
let(:bcf_issue) { create(:bcf_issue_with_comment, work_package:) }
let(:role) { create(:project_role, permissions:) }
let(:permissions) { %i(view_work_packages view_linked_issues) }
- let(:filename) { 'MaximumInformation.bcf' }
+ let(:filename) { "MaximumInformation.bcf" }
let(:bcf_xml_file) do
Rack::Test::UploadedFile.new(
Rails.root.join("modules/bim/spec/fixtures/files/#{filename}").to_s,
- 'application/octet-stream'
+ "application/octet-stream"
)
end
@@ -60,32 +60,32 @@
OpenProject::Cache.clear
end
- describe 'GET /api/bcf_xml_api/v1/projects//bcf_xml' do
+ describe "GET /api/bcf_xml_api/v1/projects//bcf_xml" do
let(:path) { "/api/bcf_xml_api/v1/projects/#{project.identifier}/bcf_xml" }
- context 'without params' do
+ context "without params" do
before do
bcf_issue
get path
end
- it 'responds 200 OK' do
+ it "responds 200 OK" do
expect(subject.status).to eq(200)
end
- it 'responds with correct Content-Type' do
+ it "responds with correct Content-Type" do
expect(subject.content_type)
.to eql("application/octet-stream")
end
- it 'responds with correct Content-Disposition' do
+ it "responds with correct Content-Disposition" do
expect(subject.header["Content-Disposition"])
.to match(/attachment; filename="OpenProject_Work_packages_\d\d\d\d-\d\d-\d\d.bcf"/)
end
- it 'responds with a correct .bcf file in the body' do
- expect(zip_has_file?(subject.body, 'bcf.version')).to be_truthy
+ it "responds with a correct .bcf file in the body" do
+ expect(zip_has_file?(subject.body, "bcf.version")).to be_truthy
expect(zip_has_file?(subject.body, "#{bcf_issue.uuid}/markup.bcf")).to be_truthy
end
@@ -98,7 +98,7 @@
end
end
- context 'with params filter on work package subject' do
+ context "with params filter on work package subject" do
let(:escaped_query_params) do
CGI.escape("[{\"subject\":{\"operator\":\"!~\",\"values\":[\"#{work_package.subject}\"]}}]")
end
@@ -112,13 +112,13 @@
get path
end
- it 'excludes the work package from the .bcf file' do
+ it "excludes the work package from the .bcf file" do
expect(zip_has_file?(subject.body, "#{bcf_issue.uuid}/markup.bcf")).to be_falsey
end
end
end
- describe 'POST /api/bcf_xml_api/v1/projects//bcf_xml' do
+ describe "POST /api/bcf_xml_api/v1/projects//bcf_xml" do
let(:permissions) { %i(view_work_packages add_work_packages edit_work_packages manage_bcf view_linked_issues) }
let(:path) { "/api/bcf_xml_api/v1/projects/#{project.identifier}/bcf_xml" }
let(:params) do
@@ -131,10 +131,10 @@
work_package
expect(project.work_packages.count).to be(1)
- post path, params, 'CONTENT_TYPE' => 'multipart/form-data'
+ post path, params, "CONTENT_TYPE" => "multipart/form-data"
end
- context 'without import conflicts' do
+ context "without import conflicts" do
it "creates two new work packages" do
expect(subject.status).to be(201)
expect(project.work_packages.count).to be(3)
@@ -153,7 +153,7 @@
end
context "with unsupported BCF version (2.0)" do
- let(:filename) { 'bcf_2_0_dummy.bcf' }
+ let(:filename) { "bcf_2_0_dummy.bcf" }
it "returns a status 415" do
expect(subject.status).to be(415)
diff --git a/modules/bim/spec/seeders/root_seeder_bim_edition_spec.rb b/modules/bim/spec/seeders/root_seeder_bim_edition_spec.rb
index e3605cdec9b8..56f195dbce1a 100644
--- a/modules/bim/spec/seeders/root_seeder_bim_edition_spec.rb
+++ b/modules/bim/spec/seeders/root_seeder_bim_edition_spec.rb
@@ -26,26 +26,26 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../../../../spec/seeders/root_seeder_shared_examples'
+require "spec_helper"
+require_relative "../../../../spec/seeders/root_seeder_shared_examples"
RSpec::Matchers.define_negated_matcher :not_start_with, :start_with
RSpec.describe RootSeeder,
- 'BIM edition',
- with_config: { edition: 'bim' } do
+ "BIM edition",
+ with_config: { edition: "bim" } do
include RootSeederTestHelpers
- shared_examples 'creates BIM demo data' do
+ shared_examples "creates BIM demo data" do
def group_name(reference)
- root_seeder.seed_data.find_reference(reference)['name']
+ root_seeder.seed_data.find_reference(reference)["name"]
end
- it 'creates an admin user' do
+ it "creates an admin user" do
expect(User.not_builtin.where(admin: true).count).to eq 1
end
- it 'creates the BIM demo data' do
+ it "creates the BIM demo data" do
expect(Project.count).to eq 4
expect(EnabledModule.count).to eq 23
expect(WorkPackage.count).to eq 76
@@ -60,12 +60,12 @@ def group_name(reference)
expect(Boards::Grid.count).to eq 2
end
- it 'creates follows and parent-child relations' do
+ it "creates follows and parent-child relations" do
expect(Relation.follows.count).to eq 35
expect(WorkPackage.where.not(parent: nil).count).to eq 55
end
- it 'assigns work packages to groups' do
+ it "assigns work packages to groups" do
count_by_assignee =
WorkPackage
.joins(:assigned_to)
@@ -83,7 +83,7 @@ def group_name(reference)
)
end
- it 'adds additional permissions from modules' do
+ it "adds additional permissions from modules" do
# do not test for all permissions but only some of them to ensure the ones
# for BIM got processed
member_role = root_seeder.seed_data.find_reference(:default_role_member)
@@ -93,35 +93,35 @@ def group_name(reference)
)
end
- include_examples 'it creates records', model: Color, expected_count: 144
- include_examples 'it creates records', model: DocumentCategory, expected_count: 3
- include_examples 'it creates records', model: IssuePriority, expected_count: 4
- include_examples 'it creates records', model: Status, expected_count: 4
- include_examples 'it creates records', model: TimeEntryActivity, expected_count: 3
- include_examples 'it creates records', model: Workflow, expected_count: 273
+ include_examples "it creates records", model: Color, expected_count: 144
+ include_examples "it creates records", model: DocumentCategory, expected_count: 3
+ include_examples "it creates records", model: IssuePriority, expected_count: 4
+ include_examples "it creates records", model: Status, expected_count: 4
+ include_examples "it creates records", model: TimeEntryActivity, expected_count: 3
+ include_examples "it creates records", model: Workflow, expected_count: 273
end
- describe 'demo data' do
+ describe "demo data" do
shared_let(:root_seeder) { described_class.new }
before_all do
- with_edition('bim') do
+ with_edition("bim") do
root_seeder.seed_data!
end
end
- include_examples 'creates BIM demo data'
+ include_examples "creates BIM demo data"
- include_examples 'no email deliveries'
+ include_examples "no email deliveries"
- context 'when run a second time' do
+ context "when run a second time" do
before_all do
- with_edition('bim') do
+ with_edition("bim") do
described_class.new.seed_data!
end
end
- it 'does not create additional data' do
+ it "does not create additional data" do
expect(Project.count).to eq 4
expect(WorkPackage.count).to eq 76
expect(Wiki.count).to eq 3
@@ -137,11 +137,11 @@ def group_name(reference)
end
end
- describe 'demo data mock-translated in another language' do
+ describe "demo data mock-translated in another language" do
shared_let(:root_seeder) { described_class.new }
before_all do
- with_edition('bim') do
+ with_edition("bim") do
# simulate a translation by changing the returned string on `I18n#t` calls
allow(I18n).to receive(:t).and_wrap_original do |m, *args, **kw|
original_translation = m.call(*args, **kw)
@@ -152,43 +152,43 @@ def group_name(reference)
end
end
- include_examples 'creates BIM demo data'
+ include_examples "creates BIM demo data"
- it 'has all Query.name translated' do
- expect(Query.pluck(:name)).to all(start_with('tr: '))
+ it "has all Query.name translated" do
+ expect(Query.pluck(:name)).to all(start_with("tr: "))
end
- context 'for work packages NOT related to a BCF issue' do
- let(:work_packages) { WorkPackage.left_joins(:bcf_issue).where('bcf_issues.id': nil) }
+ context "for work packages NOT related to a BCF issue" do
+ let(:work_packages) { WorkPackage.left_joins(:bcf_issue).where("bcf_issues.id": nil) }
%w[subject description].each do |field|
it "have their #{field} field translated" do
- expect(work_packages.pluck(:subject)).to all(start_with('tr: '))
+ expect(work_packages.pluck(:subject)).to all(start_with("tr: "))
end
end
end
# TODO: the data coming from BCF files should be translated too
# This is recorded in the implementation work package 47998
- context 'for work packages related to a BCF issue' do
- let(:work_packages) { WorkPackage.joins(:bcf_issue).where.not('bcf_issues.id': nil) }
+ context "for work packages related to a BCF issue" do
+ let(:work_packages) { WorkPackage.joins(:bcf_issue).where.not("bcf_issues.id": nil) }
%w[subject description].each do |field|
it "have NOT their #{field} field translated" do
- expect(work_packages.pluck(:subject)).to all(not_start_with('tr: '))
+ expect(work_packages.pluck(:subject)).to all(not_start_with("tr: "))
end
end
end
end
- describe 'demo data with a non-English language set with OPENPROJECT_DEFAULT__LANGUAGE',
+ describe "demo data with a non-English language set with OPENPROJECT_DEFAULT__LANGUAGE",
:settings_reset do
shared_let(:root_seeder) { described_class.new }
before_all do
- with_env('OPENPROJECT_DEFAULT__LANGUAGE' => 'de') do
+ with_env("OPENPROJECT_DEFAULT__LANGUAGE" => "de") do
reset(:default_language) # Settings are a pain to reset
- with_edition('bim') do
+ with_edition("bim") do
root_seeder.seed_data!
end
ensure
@@ -196,46 +196,46 @@ def group_name(reference)
end
end
- it 'seeds with the specified language' do
- expect(Status.where(name: 'Neu')).to exist
- expect(Type.where(name: 'Meilenstein')).to exist
- expect(Color.where(name: 'Gelb')).to exist
+ it "seeds with the specified language" do
+ expect(Status.where(name: "Neu")).to exist
+ expect(Type.where(name: "Meilenstein")).to exist
+ expect(Color.where(name: "Gelb")).to exist
end
- include_examples 'creates BIM demo data'
+ include_examples "creates BIM demo data"
end
- describe 'demo data with development data' do
+ describe "demo data with development data" do
shared_let(:root_seeder) { described_class.new(seed_development_data: true) }
before_all do
- with_edition('bim') do
+ with_edition("bim") do
root_seeder.seed_data!
end
end
- it 'creates 1 additional admin user with German locale' do
+ it "creates 1 additional admin user with German locale" do
admins = User.not_builtin.where(admin: true)
expect(admins.count).to eq 2
expect(admins.pluck(:language)).to match_array(%w[en de])
end
- it 'creates 5 additional projects for development' do
+ it "creates 5 additional projects for development" do
expect(Project.count).to eq 9
end
- it 'creates 4 additional work packages for development' do
+ it "creates 4 additional work packages for development" do
expect(WorkPackage.count).to eq 80
end
- it 'creates 1 project with custom fields' do
+ it "creates 1 project with custom fields" do
expect(CustomField.count).to eq 12
end
- it 'creates 2 additional types for development' do
+ it "creates 2 additional types for development" do
expect(Type.count).to eq 9
end
- include_examples 'no email deliveries'
+ include_examples "no email deliveries"
end
end
diff --git a/modules/bim/spec/services/bcf/issues/create_service_spec.rb b/modules/bim/spec/services/bcf/issues/create_service_spec.rb
index 79df527c74f0..5bc9adf1f994 100644
--- a/modules/bim/spec/services/bcf/issues/create_service_spec.rb
+++ b/modules/bim/spec/services/bcf/issues/create_service_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'services/base_services/behaves_like_create_service'
+require "spec_helper"
+require "services/base_services/behaves_like_create_service"
RSpec.describe Bim::Bcf::Issues::CreateService, type: :model do
- it_behaves_like 'BaseServices create service' do
+ it_behaves_like "BaseServices create service" do
let(:model_class) { Bim::Bcf::Issue }
let(:factory) { :bcf_issue }
let(:work_package) { build_stubbed(:work_package) }
@@ -42,10 +42,10 @@
.and_return(wp_call)
end
- context 'when WP service call fails' do
+ context "when WP service call fails" do
let(:wp_call) { ServiceResult.failure(result: work_package) }
- it 'returns with that call immediately' do
+ it "returns with that call immediately" do
expect(subject).to eq wp_call
end
end
diff --git a/modules/bim/spec/services/bcf/viewpoints/create_service_spec.rb b/modules/bim/spec/services/bcf/viewpoints/create_service_spec.rb
index f7d1ec74fe93..38af78d04714 100644
--- a/modules/bim/spec/services/bcf/viewpoints/create_service_spec.rb
+++ b/modules/bim/spec/services/bcf/viewpoints/create_service_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Bim::Bcf::Viewpoints::CreateService, type: :model do
let(:user) { build_stubbed(:user) }
let(:contract_class) do
- double('contract_class', '<=': true)
+ double("contract_class", "<=": true)
end
let(:viewpoint_valid) { true }
let(:instance) do
@@ -51,7 +51,7 @@
true
end
let(:set_attributes_errors) do
- double('set_attributes_errors')
+ double("set_attributes_errors")
end
let(:set_attributes_result) do
ServiceResult.new result: created_viewpoint,
@@ -72,7 +72,7 @@
viewpoint
end
let!(:set_attributes_service) do
- service = double('set_attributes_service_instance')
+ service = double("set_attributes_service_instance")
allow(Bim::Bcf::Viewpoints::SetAttributesService)
.to receive(:new)
@@ -87,19 +87,19 @@
.and_return(set_attributes_result)
end
- describe '#call' do
+ describe "#call" do
subject { instance.call(call_attributes) }
- it 'is successful' do
+ it "is successful" do
expect(subject.success?).to be_truthy
end
- it 'returns the result of the SetAttributesService' do
+ it "returns the result of the SetAttributesService" do
expect(subject)
.to eql set_attributes_result
end
- it 'persists the viewpoint' do
+ it "persists the viewpoint" do
expect(created_viewpoint)
.to receive(:save)
.and_return(viewpoint_valid)
@@ -107,24 +107,24 @@
subject
end
- it 'returns a viewpoint' do
+ it "returns a viewpoint" do
expect(subject.result)
.to eql created_viewpoint
end
- context 'if the SetAttributeService is unsuccessful' do
+ context "if the SetAttributeService is unsuccessful" do
let(:set_attributes_success) { false }
- it 'is unsuccessful' do
+ it "is unsuccessful" do
expect(subject.success?).to be_falsey
end
- it 'returns the result of the SetAttributesService' do
+ it "returns the result of the SetAttributesService" do
expect(subject)
.to eql set_attributes_result
end
- it 'does not persist the changes' do
+ it "does not persist the changes" do
expect(created_viewpoint)
.not_to receive(:save)
@@ -138,10 +138,10 @@
end
end
- context 'when the viewpoint is invalid' do
+ context "when the viewpoint is invalid" do
let(:viewpoint_valid) { false }
- it 'is unsuccessful' do
+ it "is unsuccessful" do
expect(subject.success?).to be_falsey
end
diff --git a/modules/bim/spec/services/bcf/viewpoints/set_attributes_service_spec.rb b/modules/bim/spec/services/bcf/viewpoints/set_attributes_service_spec.rb
index d01b15b15f15..fd10ae778339 100644
--- a/modules/bim/spec/services/bcf/viewpoints/set_attributes_service_spec.rb
+++ b/modules/bim/spec/services/bcf/viewpoints/set_attributes_service_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Bim::Bcf::Viewpoints::SetAttributesService, type: :model do
let(:user) { build_stubbed(:user) }
let(:contract_class) do
- contract = double('contract_class')
+ contract = double("contract_class")
allow(contract)
.to receive(:new)
@@ -41,11 +41,11 @@
contract
end
let(:contract_instance) do
- double('contract_instance', validate: contract_valid, errors: contract_errors)
+ double("contract_instance", validate: contract_valid, errors: contract_errors)
end
let(:contract_valid) { true }
let(:contract_errors) do
- double('contract_errors')
+ double("contract_errors")
end
let(:viewpoint_valid) { true }
let(:instance) do
@@ -65,13 +65,13 @@
.and_return true
end
- describe 'call' do
+ describe "call" do
# We only expect the service to be called for new records. As viewpoints
# are immutable.
- context 'for a new record' do
+ context "for a new record" do
let(:call_attributes) do
attributes = attributes_for(:bcf_viewpoint)
- attributes[:json_viewpoint].delete('guid')
+ attributes[:json_viewpoint].delete("guid")
attributes[:json_viewpoint]["snapshot"] = {
"snapshot_type" => "png",
"snapshot_data" => "data:image/png;base64,SGVsbG8gV29ybGQh"
@@ -91,15 +91,15 @@
subject { instance.call(call_attributes) }
- it 'is successful' do
+ it "is successful" do
expect(subject.success?).to be_truthy
end
- it 'sets the attributes with the uuid added to the json_viewpoint' do
+ it "sets the attributes with the uuid added to the json_viewpoint" do
subject
expected_attributes = attributes_for(:bcf_viewpoint)
- expected_attributes[:json_viewpoint]['guid'] = viewpoint.uuid
+ expected_attributes[:json_viewpoint]["guid"] = viewpoint.uuid
expected_attributes[:json_viewpoint]["snapshot"] = {
"snapshot_type" => "png",
"snapshot_data" => "data:image/png;base64,SGVsbG8gV29ybGQh"
@@ -109,30 +109,30 @@
.to eql expected_attributes
end
- it 'sets the snapshot attachment based on the data in the json_viewpoint' do
+ it "sets the snapshot attachment based on the data in the json_viewpoint" do
subject
expect(viewpoint.attachments.size)
.to be 1
expect(viewpoint.attachments.first.file.read)
- .to eql 'Hello World!'
+ .to eql "Hello World!"
expect(viewpoint.attachments.first.filename)
- .to eql 'snapshot.png'
+ .to eql "snapshot.png"
end
- it 'does not persist the viewpoint' do
+ it "does not persist the viewpoint" do
expect(viewpoint)
.not_to receive(:save)
subject
end
- context 'with an unsupported snapshot type' do
+ context "with an unsupported snapshot type" do
let(:call_attributes) do
attributes = attributes_for(:bcf_viewpoint)
- attributes[:json_viewpoint].delete('guid')
+ attributes[:json_viewpoint].delete("guid")
attributes[:json_viewpoint]["snapshot"] = {
"snapshot_type" => "tif",
"snapshot_data" => "data:image/png;base64,SGVsbG8gV29ybGQh"
@@ -140,7 +140,7 @@
attributes
end
- it 'sets no snapshot attachment' do
+ it "sets no snapshot attachment" do
subject
expect(viewpoint.attachments.size)
diff --git a/modules/bim/spec/services/ifc_models/create_service_spec.rb b/modules/bim/spec/services/ifc_models/create_service_spec.rb
index 4c219aafe828..ad5acfa00619 100644
--- a/modules/bim/spec/services/ifc_models/create_service_spec.rb
+++ b/modules/bim/spec/services/ifc_models/create_service_spec.rb
@@ -1,19 +1,19 @@
-require 'spec_helper'
-require 'services/base_services/behaves_like_create_service'
+require "spec_helper"
+require "services/base_services/behaves_like_create_service"
RSpec.describe Bim::IfcModels::CreateService do
- it_behaves_like 'BaseServices create service' do
+ it_behaves_like "BaseServices create service" do
let(:model_class) { Bim::IfcModels::IfcModel }
let(:factory) { :ifc_model }
let(:conversion_job) do
- double('ifc_conversion_job').tap do |job|
+ double("ifc_conversion_job").tap do |job|
allow(job).to receive(:perform_later)
- stub_const('Bim::IfcModels::IfcConversionJob', job)
+ stub_const("Bim::IfcModels::IfcConversionJob", job)
end
end
- it 'queues a conversion job' do
+ it "queues a conversion job" do
expect(conversion_job)
.to(receive(:perform_later))
.with(model_instance)
@@ -21,20 +21,20 @@
subject
end
- context 'if the SetAttributeService is unsuccessful' do
+ context "if the SetAttributeService is unsuccessful" do
let(:set_attributes_success) { false }
- it 'queues no conversion job' do
+ it "queues no conversion job" do
expect(conversion_job).not_to receive(:perform_later)
subject
end
end
- context 'when the model is invalid' do
+ context "when the model is invalid" do
let(:model_save_result) { false }
- it 'queues no conversion job' do
+ it "queues no conversion job" do
expect(conversion_job).not_to receive(:perform_later)
subject
diff --git a/modules/bim/spec/services/ifc_models/set_attributes_service_spec.rb b/modules/bim/spec/services/ifc_models/set_attributes_service_spec.rb
index fbfaa9a51860..07ce9d6ff408 100644
--- a/modules/bim/spec/services/ifc_models/set_attributes_service_spec.rb
+++ b/modules/bim/spec/services/ifc_models/set_attributes_service_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Bim::IfcModels::SetAttributesService, type: :model do
shared_let(:project) { create(:project, enabled_module_names: %i[bim]) }
@@ -35,7 +35,7 @@
let(:other_user) { build_stubbed(:user) }
let(:contract_class) do
- contract = double('contract_class')
+ contract = double("contract_class")
allow(contract)
.to receive(:new)
@@ -45,11 +45,11 @@
contract
end
let(:contract_instance) do
- double('contract_instance', validate: contract_valid, errors: contract_errors)
+ double("contract_instance", validate: contract_valid, errors: contract_errors)
end
let(:contract_valid) { true }
let(:contract_errors) do
- double('contract_errors')
+ double("contract_errors")
end
let(:model_valid) { true }
let(:instance) do
@@ -58,7 +58,7 @@
contract_class:)
end
let(:call_attributes) { {} }
- let(:ifc_file) { FileHelpers.mock_uploaded_file(name: "model_2.ifc", content_type: 'application/binary', binary: true) }
+ let(:ifc_file) { FileHelpers.mock_uploaded_file(name: "model_2.ifc", content_type: "application/binary", binary: true) }
let(:model) do
create(:ifc_model, project:, uploader: other_user)
end
@@ -68,7 +68,7 @@
login_as(user)
end
- describe 'call' do
+ describe "call" do
let(:call_attributes) do
{
project_id: other_project.id
@@ -87,48 +87,48 @@
subject { instance.call(call_attributes) }
- it 'is successful' do
+ it "is successful" do
expect(subject.success?).to be_truthy
end
- it 'sets the attributes' do
+ it "sets the attributes" do
subject
expect(model.attributes.slice(*model.changed).symbolize_keys)
.to eql call_attributes.merge(uploader_id: user.id)
end
- it 'does not persist the model' do
+ it "does not persist the model" do
expect(model)
.not_to receive(:save)
subject
end
- context 'for a new record' do
+ context "for a new record" do
let(:model) do
Bim::IfcModels::IfcModel.new project:
end
- context 'with an ifc_attachment' do
+ context "with an ifc_attachment" do
let(:call_attributes) do
{
ifc_attachment: ifc_file
}
end
- it 'is successful' do
+ it "is successful" do
expect(subject.success?).to be_truthy
end
- it 'sets the title to the attachment`s filename' do
+ it "sets the title to the attachment`s filename" do
subject
expect(model.title)
- .to eql 'model_2'
+ .to eql "model_2"
end
- it 'sets the uploader to the attachment`s author (which is the current user)' do
+ it "sets the uploader to the attachment`s author (which is the current user)" do
subject
expect(model.uploader)
@@ -137,19 +137,19 @@
end
end
- context 'for an existing model' do
- context 'with an ifc_attachment' do
+ context "for an existing model" do
+ context "with an ifc_attachment" do
let(:call_attributes) do
{
ifc_attachment: ifc_file
}
end
- it 'is successful' do
+ it "is successful" do
expect(subject.success?).to be_truthy
end
- it 'does not alter the title' do
+ it "does not alter the title" do
title_before = model.title
subject
@@ -158,14 +158,14 @@
.to eql title_before
end
- it 'sets the uploader to the attachment`s author (which is the current user)' do
+ it "sets the uploader to the attachment`s author (which is the current user)" do
subject
expect(model.uploader)
.to eql user
end
- it 'marks existing attachments for destruction' do
+ it "marks existing attachments for destruction" do
ifc_attachment = model.ifc_attachment
subject
diff --git a/modules/bim/spec/services/ifc_models/update_service_spec.rb b/modules/bim/spec/services/ifc_models/update_service_spec.rb
index 2a7b0f52ea95..116c7066bcb7 100644
--- a/modules/bim/spec/services/ifc_models/update_service_spec.rb
+++ b/modules/bim/spec/services/ifc_models/update_service_spec.rb
@@ -1,9 +1,9 @@
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Bim::IfcModels::UpdateService do
let(:user) { build_stubbed(:user) }
let(:contract_class) do
- double('contract_class', '<=': true)
+ double("contract_class", "<=": true)
end
let(:model_valid) { true }
let(:instance) do
@@ -11,12 +11,12 @@
model:,
contract_class:)
end
- let(:call_attributes) { { name: 'Some name', identifier: 'Some identifier' } }
+ let(:call_attributes) { { name: "Some name", identifier: "Some identifier" } }
let(:set_attributes_success) do
true
end
let(:set_attributes_errors) do
- double('set_attributes_errors')
+ double("set_attributes_errors")
end
let(:set_attributes_result) do
ServiceResult.new result: model,
@@ -37,7 +37,7 @@
end
end
let!(:set_attributes_service) do
- service = double('set_attributes_service_instance')
+ service = double("set_attributes_service_instance")
allow(Bim::IfcModels::SetAttributesService)
.to receive(:new)
@@ -52,11 +52,11 @@
.and_return(set_attributes_result)
end
let(:conversion_job) do
- double('ifc_conversion_job').tap do |job|
+ double("ifc_conversion_job").tap do |job|
allow(job)
.to receive(:perform_later)
- stub_const('Bim::IfcModels::IfcConversionJob', job)
+ stub_const("Bim::IfcModels::IfcConversionJob", job)
end
end
let(:ifc_attachment) { build_stubbed(:attachment) }
@@ -73,19 +73,19 @@
let(:attachment_marked_for_destruction) { false }
let(:attachments) { [ifc_attachment, other_attachment] }
- describe 'call' do
+ describe "call" do
subject { instance.call(call_attributes) }
- it 'is successful' do
+ it "is successful" do
expect(subject.success?).to be_truthy
end
- it 'returns the result of the SetAttributesService' do
+ it "returns the result of the SetAttributesService" do
expect(subject)
.to eql set_attributes_result
end
- it 'persists the model' do
+ it "persists the model" do
expect(model)
.to receive(:save)
.and_return(model_valid)
@@ -93,34 +93,34 @@
subject
end
- it 'returns the model' do
+ it "returns the model" do
expect(subject.result)
.to eql model
end
- it 'schedules no conversion job' do
+ it "schedules no conversion job" do
expect(conversion_job)
.not_to receive(:perform_later)
subject
end
- it 'leaves attachments not marked for destruction' do
+ it "leaves attachments not marked for destruction" do
expect(other_attachment)
.not_to receive(:destroy)
subject
end
- context 'if the attachment is altered' do
+ context "if the attachment is altered" do
let(:attachment_marked_for_destruction) { true }
let(:call_attributes) do
- { name: 'Some name',
- identifier: 'Some identifier',
+ { name: "Some name",
+ identifier: "Some identifier",
ifc_attachment: }
end
- it 'schedules conversion job' do
+ it "schedules conversion job" do
expect(conversion_job)
.to receive(:perform_later)
.with(model)
@@ -128,7 +128,7 @@
subject
end
- it 'destroys all attachments marked for destruction' do
+ it "destroys all attachments marked for destruction" do
expect(other_attachment)
.to receive(:destroy)
@@ -141,19 +141,19 @@
end
end
- context 'if the SetAttributeService is unsuccessful' do
+ context "if the SetAttributeService is unsuccessful" do
let(:set_attributes_success) { false }
- it 'is unsuccessful' do
+ it "is unsuccessful" do
expect(subject.success?).to be_falsey
end
- it 'returns the result of the SetAttributesService' do
+ it "returns the result of the SetAttributesService" do
expect(subject)
.to eql set_attributes_result
end
- it 'does not persist the changes' do
+ it "does not persist the changes" do
expect(model)
.not_to receive(:save)
@@ -166,7 +166,7 @@
expect(subject.errors).to eql set_attributes_errors
end
- context 'if the attachment is altered' do
+ context "if the attachment is altered" do
let(:attachment_marked_for_destruction) { true }
before do
@@ -175,14 +175,14 @@
.and_return(true)
end
- it 'schedules no conversion job' do
+ it "schedules no conversion job" do
expect(conversion_job)
.not_to receive(:perform_later)
subject
end
- it 'does not destroy attachments marked for destruction' do
+ it "does not destroy attachments marked for destruction" do
expect(other_attachment)
.not_to receive(:destroy)
@@ -191,10 +191,10 @@
end
end
- context 'if the model is invalid' do
+ context "if the model is invalid" do
let(:model_valid) { false }
- it 'is unsuccessful' do
+ it "is unsuccessful" do
expect(subject.success?).to be_falsey
end
diff --git a/modules/bim/spec/services/ifc_models/view_conversion_service_spec.rb b/modules/bim/spec/services/ifc_models/view_conversion_service_spec.rb
index b309bad50d3f..2561c1b1e716 100644
--- a/modules/bim/spec/services/ifc_models/view_conversion_service_spec.rb
+++ b/modules/bim/spec/services/ifc_models/view_conversion_service_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Bim::IfcModels::ViewConverterService do
let(:model) { build(:ifc_model) }
@@ -9,12 +9,12 @@
described_class.instance_variable_set(:@available_commands, nil)
end
- shared_context 'with available pipeline commands' do |available|
+ shared_context "with available pipeline commands" do |available|
before do
# Mock the call to Open3 to test available commands
allow(Open3)
.to(receive(:capture2e))
- .with('which', any_args)
+ .with("which", any_args)
.and_wrap_original do |_, *args|
matches = if available.is_a?(Array)
available.include?(args[1])
@@ -28,47 +28,47 @@
end
end
- describe '#available_commands' do
+ describe "#available_commands" do
subject { described_class }
- context 'with only one available command' do
- include_context 'with available pipeline commands', %w[IfcConvert]
+ context "with only one available command" do
+ include_context "with available pipeline commands", %w[IfcConvert]
- it 'is not available' do
+ it "is not available" do
expect(subject).not_to be_available
end
end
- context 'with all available commands' do
- include_context 'with available pipeline commands', described_class::PIPELINE_COMMANDS
+ context "with all available commands" do
+ include_context "with available pipeline commands", described_class::PIPELINE_COMMANDS
- it 'is available' do
+ it "is available" do
expect(subject).to be_available
end
end
end
- describe '#call' do
+ describe "#call" do
before do
allow(model).to receive(:processing!).and_call_original
end
- context 'if not available?' do
- include_context 'with available pipeline commands', false
+ context "if not available?" do
+ include_context "with available pipeline commands", false
- it 'returns an error' do
+ it "returns an error" do
expect(model).to receive(:processing!).and_call_original
expect(described_class).not_to be_available
result = subject.call
- expect(result.errors[:base].first).to include 'The following IFC converter commands are missing'
+ expect(result.errors[:base].first).to include "The following IFC converter commands are missing"
# Expect that the model's conversion status gets updated
expect(model).to be_error
- expect(model.conversion_error_message).to include('The following IFC converter commands are missing')
+ expect(model.conversion_error_message).to include("The following IFC converter commands are missing")
end
end
- context 'if available' do
+ context "if available" do
let(:working_directory) { Dir.mktmpdir }
let(:ifc_model_file_name) { "büro.ifc" }
let(:ifc_model_path) { File.join working_directory, ifc_model_file_name }
@@ -90,7 +90,7 @@
FileUtils.remove_entry working_directory
end
- it 'performs the conversion and returns the save result' do
+ it "performs the conversion and returns the save result" do
allow(model).to receive(:processing!).and_call_original
# mocking all convert! calls so they do nothing but create an empty dummy result file
@@ -144,7 +144,7 @@
expect(model.conversion_error_message).to be_nil
end
- it 'calls the conversion and returns error' do
+ it "calls the conversion and returns error" do
expect(subject)
.to(receive(:perform_conversion!))
@@ -157,7 +157,7 @@
end
end
- describe '#change_basename' do
+ describe "#change_basename" do
it "returns the new basename" do
path = "/tmp/file.xml"
new_path = subject.send(:change_basename, path, "/home/model.xml", ".json")
diff --git a/modules/bim/spec/spec_helper.rb b/modules/bim/spec/spec_helper.rb
index 6f31639d8784..720e50a81b14 100644
--- a/modules/bim/spec/spec_helper.rb
+++ b/modules/bim/spec/spec_helper.rb
@@ -27,6 +27,6 @@
#++
# -- load spec_helper from OpenProject core
-require 'spec_helper'
+require "spec_helper"
-Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].each { |f| require f }
+Dir[File.join(File.dirname(__FILE__), "support/**/*.rb")].each { |f| require f }
diff --git a/modules/bim/spec/support/bcf_topic_with_stubbed_comment.rb b/modules/bim/spec/support/bcf_topic_with_stubbed_comment.rb
index 08e3c52ca1e8..f2071b0aa349 100644
--- a/modules/bim/spec/support/bcf_topic_with_stubbed_comment.rb
+++ b/modules/bim/spec/support/bcf_topic_with_stubbed_comment.rb
@@ -1,5 +1,5 @@
-RSpec.shared_context 'bcf_topic with stubbed comment' do |attributes = {}|
- let(:attachment) { build_stubbed(:attachment, description: 'snapshot') }
+RSpec.shared_context "bcf_topic with stubbed comment" do |attributes = {}|
+ let(:attachment) { build_stubbed(:attachment, description: "snapshot") }
let(:viewpoint) { build_stubbed(:bcf_viewpoint, attachments: [attachment]) }
let(:bcf_comment) { build_stubbed(:bcf_comment, viewpoint:) }
let(:bcf_topic) do
diff --git a/modules/bim/spec/support/components/bcf_details_viewpoints.rb b/modules/bim/spec/support/components/bcf_details_viewpoints.rb
index 084f468b0fcd..900830517179 100644
--- a/modules/bim/spec/support/components/bcf_details_viewpoints.rb
+++ b/modules/bim/spec/support/components/bcf_details_viewpoints.rb
@@ -29,27 +29,27 @@
module Components
module BcfDetailsViewpoints
def expect_viewpoint_count(number)
- expect(page).to have_css('a.ngx-gallery-thumbnail', visible: :all, count: number, wait: 20)
+ expect(page).to have_css("a.ngx-gallery-thumbnail", visible: :all, count: number, wait: 20)
end
def expect_no_viewpoint_addable
- expect(page).to have_no_css('a.button', text: 'Viewpoint')
+ expect(page).to have_no_css("a.button", text: "Viewpoint")
end
def next_viewpoint
- page.find('.icon-arrow-right2.ngx-gallery-icon-content').click
+ page.find(".icon-arrow-right2.ngx-gallery-icon-content").click
end
def previous_viewpoint
- page.find('.icon-arrow-left2.ngx-gallery-icon-content').click
+ page.find(".icon-arrow-left2.ngx-gallery-icon-content").click
end
def show_current_viewpoint
- page.find('.icon-view-model.ngx-gallery-icon-content').click
+ page.find(".icon-view-model.ngx-gallery-icon-content").click
end
def delete_current_viewpoint(confirm: true)
- page.find('.icon-delete.ngx-gallery-icon-content').click
+ page.find(".icon-delete.ngx-gallery-icon-content").click
if confirm
page.driver.browser.switch_to.alert.accept
@@ -59,7 +59,7 @@ def delete_current_viewpoint(confirm: true)
end
def add_viewpoint
- page.find('a.button', text: 'Viewpoint').click
+ page.find("a.button", text: "Viewpoint").click
end
end
end
diff --git a/modules/bim/spec/support/components/xeokit_model_tree.rb b/modules/bim/spec/support/components/xeokit_model_tree.rb
index 94589268d6b3..f278b8447910 100644
--- a/modules/bim/spec/support/components/xeokit_model_tree.rb
+++ b/modules/bim/spec/support/components/xeokit_model_tree.rb
@@ -33,8 +33,8 @@ class XeokitModelTree
include RSpec::Matchers
def sidebar_shows_viewer_menu(visible)
- selector = '.xeokit-tab'
- tabs = ['Models', 'Objects', 'Classes', 'Storeys']
+ selector = ".xeokit-tab"
+ tabs = ["Models", "Objects", "Classes", "Storeys"]
tabs.each do |tab|
expect(page).to have_conditional_selector(visible, selector, text: tab)
@@ -42,53 +42,53 @@ def sidebar_shows_viewer_menu(visible)
end
def expect_model_management_available(visible: true)
- selector = '.xeokit-btn.xeokit-addModel'
+ selector = ".xeokit-btn.xeokit-addModel"
expect(page).to have_conditional_selector(visible, selector)
end
def click_add_model
- selector = '.xeokit-btn.xeokit-addModel'
+ selector = ".xeokit-btn.xeokit-addModel"
page.find(selector).click
end
def select_model_menu_item(model_name, item_label)
- page.find('.xeokit-form-check span', text: model_name).right_click
- page.find('.xeokit-context-menu-item', text: item_label).click
+ page.find(".xeokit-form-check span", text: model_name).right_click
+ page.find(".xeokit-context-menu-item", text: item_label).click
end
def select_sidebar_tab(tab)
- selector = '.xeokit-tab'
+ selector = ".xeokit-tab"
page.find(selector, text: tab).click
end
def expand_tree
- page.all('.xeokit-tree-panel a.plus').map(&:click)
+ page.all(".xeokit-tree-panel a.plus").map(&:click)
end
def expect_checked(label)
page
- .find('.xeokit-tree-panel li span', text: label, wait: 10)
- .sibling('input[type=checkbox]:checked')
+ .find(".xeokit-tree-panel li span", text: label, wait: 10)
+ .sibling("input[type=checkbox]:checked")
end
def expect_unchecked(label)
page
- .find('.xeokit-tree-panel li span', text: label, wait: 10)
- .sibling('input[type=checkbox]:not(:checked)')
+ .find(".xeokit-tree-panel li span", text: label, wait: 10)
+ .sibling("input[type=checkbox]:not(:checked)")
end
def all_checkboxes
page
- .all('.xeokit-tree-panel li span')
- .map { |item| [item, item.sibling('input[type=checkbox]')] }
+ .all(".xeokit-tree-panel li span")
+ .map { |item| [item, item.sibling("input[type=checkbox]")] }
end
- def expect_tree_panel_selected(selected, tab = 'Models')
+ def expect_tree_panel_selected(selected, tab = "Models")
within (".xeokit-#{tab.downcase}.xeokit-tree-panel") do
if selected
- expect(page.find('input', match: :first)).to be_checked
+ expect(page.find("input", match: :first)).to be_checked
else
- expect(page.find('input', match: :first)).not_to be_checked
+ expect(page.find("input", match: :first)).not_to be_checked
end
end
end
diff --git a/modules/bim/spec/support/pages/bcf/create_split.rb b/modules/bim/spec/support/pages/bcf/create_split.rb
index 4369b543d827..2b26a275ca09 100644
--- a/modules/bim/spec/support/pages/bcf/create_split.rb
+++ b/modules/bim/spec/support/pages/bcf/create_split.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'support/pages/page'
-require 'support/pages/work_packages/abstract_work_package_create'
-require_relative '../../components/bcf_details_viewpoints'
+require "support/pages/page"
+require "support/pages/work_packages/abstract_work_package_create"
+require_relative "../../components/bcf_details_viewpoints"
module Pages
module BCF
@@ -47,7 +47,7 @@ def initialize(project:, model_id: nil, type_id: nil)
# Override delete viewpoint since we don't have confirm alert
def delete_viewpoint_at_position(index)
- page.all('.icon-delete.ngx-gallery-icon-content')[index].click
+ page.all(".icon-delete.ngx-gallery-icon-content")[index].click
end
def path
diff --git a/modules/bim/spec/support/pages/ifc_models/bcf_details_page.rb b/modules/bim/spec/support/pages/ifc_models/bcf_details_page.rb
index 45b8e249a63a..67d85d5e8bfc 100644
--- a/modules/bim/spec/support/pages/ifc_models/bcf_details_page.rb
+++ b/modules/bim/spec/support/pages/ifc_models/bcf_details_page.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'support/pages/work_packages/split_work_package'
-require_relative '../../components/bcf_details_viewpoints'
+require "support/pages/work_packages/split_work_package"
+require_relative "../../components/bcf_details_viewpoints"
module Pages
class BcfDetailsPage < Pages::SplitWorkPackage
@@ -35,7 +35,7 @@ class BcfDetailsPage < Pages::SplitWorkPackage
protected
- def path(tab = 'overview')
+ def path(tab = "overview")
bcf_project_frontend_path project, "details/#{work_package.id}/#{tab}"
end
end
diff --git a/modules/bim/spec/support/pages/ifc_models/index.rb b/modules/bim/spec/support/pages/ifc_models/index.rb
index e52dd174af6a..d30941bcea2c 100644
--- a/modules/bim/spec/support/pages/ifc_models/index.rb
+++ b/modules/bim/spec/support/pages/ifc_models/index.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'support/pages/page'
-require 'support/pages/work_packages/concerns/work_package_by_button_creator'
+require "support/pages/page"
+require "support/pages/work_packages/concerns/work_package_by_button_creator"
module Pages
module IfcModels
@@ -43,55 +43,55 @@ def path
end
def model_listed(listed, model_name)
- within '.generic-table' do
+ within ".generic-table" do
expect(page).to (listed ? have_text(model_name) : have_no_text(model_name))
end
end
def add_model_allowed(allowed)
if allowed
- click_toolbar_button 'IFC model'
+ click_toolbar_button "IFC model"
expect_correct_page_loaded '.button[type="submit"]'
expect(page).to have_current_path new_bcf_project_ifc_model_path(project)
visit!
else
- expect(page).to have_no_css('.button.-primary', text: 'IFC model')
+ expect(page).to have_no_css(".button.-primary", text: "IFC model")
end
end
def bcf_buttons(allowed)
- expect(page).to have_conditional_selector(allowed, '.toolbar-item', text: 'Import')
- expect(page).to have_conditional_selector(allowed, '.toolbar-item', text: 'Export')
+ expect(page).to have_conditional_selector(allowed, ".toolbar-item", text: "Import")
+ expect(page).to have_conditional_selector(allowed, ".toolbar-item", text: "Export")
end
def edit_model_allowed(model_name, allowed)
row = find_model_table_row model_name
within row do
- expect(page).to (allowed ? have_css('.icon-edit') : have_no_selector('.icon-edit'))
+ expect(page).to (allowed ? have_css(".icon-edit") : have_no_selector(".icon-edit"))
end
end
def delete_model_allowed(model_name, allowed)
row = find_model_table_row model_name
within row do
- expect(page).to (allowed ? have_css('.icon-edit') : have_no_selector('.icon-edit'))
+ expect(page).to (allowed ? have_css(".icon-edit") : have_no_selector(".icon-edit"))
end
end
def edit_model(model_name, new_name)
- click_table_icon model_name, '.icon-edit'
+ click_table_icon model_name, ".icon-edit"
change_model_name model_name, new_name
- click_on 'Save'
+ click_on "Save"
model_listed true, new_name
expect(page).to have_current_path bcf_project_ifc_models_path(project), ignore_query: true
end
def delete_model(model_name)
- click_table_icon model_name, '.icon-delete'
+ click_table_icon model_name, ".icon-delete"
page.driver.browser.switch_to.alert.accept
@@ -112,7 +112,7 @@ def expect_model_active(model, active = true)
end
def show_defaults(models = [])
- click_toolbar_button 'Show defaults'
+ click_toolbar_button "Show defaults"
expect_correct_page_loaded '[data-test-selector="op-ifc-viewer--container"]'
@@ -124,20 +124,20 @@ def show_defaults(models = [])
private
def find_model_table_row(model_name)
- within '.generic-table' do
- page.find('td', text: model_name).find(:xpath, '..')
+ within ".generic-table" do
+ page.find("td", text: model_name).find(:xpath, "..")
end
end
def click_model_link(model_name)
- within '.generic-table' do
- page.find('td a', text: model_name).click
+ within ".generic-table" do
+ page.find("td a", text: model_name).click
end
end
def click_toolbar_button(name)
- within '.toolbar' do
- page.find('.button', text: name).click
+ within ".toolbar" do
+ page.find(".button", text: name).click
end
end
@@ -154,8 +154,8 @@ def expect_correct_page_loaded(checked_selector)
def change_model_name(model_name, new_name)
expect(page).to have_css('input[type="file"]')
- expect(page).to have_field('bim_ifc_models_ifc_model[title]', with: model_name)
- fill_in 'bim_ifc_models_ifc_model[title]', with: new_name
+ expect(page).to have_field("bim_ifc_models_ifc_model[title]", with: model_name)
+ fill_in "bim_ifc_models_ifc_model[title]", with: new_name
end
end
end
diff --git a/modules/bim/spec/support/pages/ifc_models/show.rb b/modules/bim/spec/support/pages/ifc_models/show.rb
index 326db80a0f4d..7e99a8f0c980 100644
--- a/modules/bim/spec/support/pages/ifc_models/show.rb
+++ b/modules/bim/spec/support/pages/ifc_models/show.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative 'show_default'
+require_relative "show_default"
module Pages
module IfcModels
diff --git a/modules/bim/spec/views/bim/ifc_models/ifc_models/index.html.erb_spec.rb b/modules/bim/spec/views/bim/ifc_models/ifc_models/index.html.erb_spec.rb
index fa71df317e39..161b8fe54f19 100644
--- a/modules/bim/spec/views/bim/ifc_models/ifc_models/index.html.erb_spec.rb
+++ b/modules/bim/spec/views/bim/ifc_models/ifc_models/index.html.erb_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'bim/ifc_models/ifc_models/index' do
+RSpec.describe "bim/ifc_models/ifc_models/index" do
let(:project) { create(:project, enabled_module_names: %i[bim]) }
let(:ifc_model) do
create(:ifc_model,
@@ -59,15 +59,15 @@
allow(User).to receive(:current).and_return(user)
end
- context 'with permission manage_ifc_models' do
- context 'with ifc_attachment' do
- it 'lists the IFC model with all three buttons' do
+ context "with permission manage_ifc_models" do
+ context "with ifc_attachment" do
+ it "lists the IFC model with all three buttons" do
render
- expect(rendered).to have_text('office.ifc')
- expect(rendered).to have_link('Download')
- expect(rendered).to have_link('Delete')
- expect(rendered).to have_link('Edit')
- expect(rendered).to have_text('Pending')
+ expect(rendered).to have_text("office.ifc")
+ expect(rendered).to have_link("Download")
+ expect(rendered).to have_link("Delete")
+ expect(rendered).to have_link("Edit")
+ expect(rendered).to have_text("Pending")
end
end
@@ -75,38 +75,38 @@
context "with conversion_status '#{state}'" do
before do
ifc_model.conversion_status = Bim::IfcModels::IfcModel.conversion_statuses[state.to_sym]
- ifc_model.conversion_error_message = "Conversion went wrong" if state == 'error'
+ ifc_model.conversion_error_message = "Conversion went wrong" if state == "error"
render
end
it 'renders the conversion status to be "Processing"' do
expect(rendered).to have_text(state.capitalize)
- expect(rendered).to have_text('Conversion went wrong') if state == 'error'
+ expect(rendered).to have_text("Conversion went wrong") if state == "error"
end
end
end
- context 'without ifc_attachment' do
+ context "without ifc_attachment" do
let(:ifc_model) do
create(:ifc_model_without_ifc_attachment,
title: "office.ifc",
project:)
end
- it 'lists the IFC model with all but the download button' do
+ it "lists the IFC model with all but the download button" do
render
- expect(rendered).to have_text('office.ifc')
- expect(rendered).to have_no_link('Download')
- expect(rendered).to have_link('Delete')
- expect(rendered).to have_link('Edit')
+ expect(rendered).to have_text("office.ifc")
+ expect(rendered).to have_no_link("Download")
+ expect(rendered).to have_link("Delete")
+ expect(rendered).to have_link("Edit")
end
end
end
- context 'without permission manage_ifc_models' do
- it 'only shows the download button' do
+ context "without permission manage_ifc_models" do
+ it "only shows the download button" do
render
- expect(rendered).to have_link('Download')
+ expect(rendered).to have_link("Download")
end
end
end
diff --git a/modules/bim/spec/workers/ifc_conversion_job_spec.rb b/modules/bim/spec/workers/ifc_conversion_job_spec.rb
index 0edbe69c7633..9f50dce0b797 100644
--- a/modules/bim/spec/workers/ifc_conversion_job_spec.rb
+++ b/modules/bim/spec/workers/ifc_conversion_job_spec.rb
@@ -1,11 +1,11 @@
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Bim::IfcModels::IfcConversionJob, type: :job do
let(:model) { build(:ifc_model) }
subject { described_class.perform_now(model) }
- it 'calls the conversion service' do
+ it "calls the conversion service" do
expect(Bim::IfcModels::ViewConverterService)
.to receive_message_chain(:new, :call)
.and_return ServiceResult.success
diff --git a/modules/bim/spec/workers/work_packages/exports/export_job_spec.rb b/modules/bim/spec/workers/work_packages/exports/export_job_spec.rb
index 5bef01651caa..1ed3e82dfecd 100644
--- a/modules/bim/spec/workers/work_packages/exports/export_job_spec.rb
+++ b/modules/bim/spec/workers/work_packages/exports/export_job_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WorkPackages::ExportJob do
let(:user) { build_stubbed(:user) }
- let(:attachment) { double('Attachment', id: 1234) }
+ let(:attachment) { double("Attachment", id: 1234) }
let(:export) do
build_stubbed(:work_packages_export)
end
@@ -52,19 +52,19 @@
job.tap(&:perform_now)
end
- describe '#perform' do
- context 'with the bcf mime type' do
+ describe "#perform" do
+ context "with the bcf mime type" do
let(:mime_type) { :bcf }
let(:exporter) { OpenProject::Bim::BcfXml::Exporter }
let(:exporter_instance) { instance_double(exporter) }
- it 'issues an OpenProject::Bim::BcfXml::Exporter export' do
- result = Exports::Result.new(format: 'blubs',
+ it "issues an OpenProject::Bim::BcfXml::Exporter export" do
+ result = Exports::Result.new(format: "blubs",
title: "some_title.#{mime_type}",
- content: 'some content',
+ content: "some content",
mime_type: "application/octet-stream")
- service = double('attachments create service')
+ service = double("attachments create service")
expect(Attachments::CreateService)
.to receive(:bypass_whitelist)
@@ -83,8 +83,8 @@
# expect to create a status
expect(subject.job_status).to be_present
- expect(subject.job_status[:status]).to eq 'success'
- expect(subject.job_status[:payload]['download']).to eq '/api/v3/attachments/1234/content'
+ expect(subject.job_status[:status]).to eq "success"
+ expect(subject.job_status[:payload]["download"]).to eq "/api/v3/attachments/1234/content"
end
end
end
diff --git a/modules/boards/app/components/boards/add_button_component.rb b/modules/boards/app/components/boards/add_button_component.rb
index f8063e881f54..08714e9d5ed8 100644
--- a/modules/boards/app/components/boards/add_button_component.rb
+++ b/modules/boards/app/components/boards/add_button_component.rb
@@ -44,15 +44,15 @@ def dynamic_path
end
def id
- 'add-board-button'
+ "add-board-button"
end
def accessibility_label_text
- I18n.t('boards.label_create_new_board')
+ I18n.t("boards.label_create_new_board")
end
def label_text
- I18n.t('boards.label_board')
+ I18n.t("boards.label_board")
end
end
end
diff --git a/modules/boards/app/components/boards/row_component.rb b/modules/boards/app/components/boards/row_component.rb
index b5c90c82916a..d6ddbb333833 100644
--- a/modules/boards/app/components/boards/row_component.rb
+++ b/modules/boards/app/components/boards/row_component.rb
@@ -45,9 +45,9 @@ def created_at
def type
case model.board_type
when :action
- t('boards.board_types.action', attribute: t(model.board_type_attribute, scope: 'boards.board_type_attributes'))
+ t("boards.board_types.action", attribute: t(model.board_type_attribute, scope: "boards.board_type_attributes"))
else
- t('boards.board_types.free')
+ t("boards.board_types.free")
end
end
@@ -58,13 +58,13 @@ def button_links
def delete_link
if render_delete_link?
link_to(
- '',
+ "",
work_package_board_path(model),
method: :delete,
- class: 'icon icon-delete',
+ class: "icon icon-delete",
data: {
confirm: I18n.t(:text_are_you_sure),
- 'test-selector': "board-remove-#{model.id}"
+ "test-selector": "board-remove-#{model.id}"
},
title: t(:button_delete)
)
diff --git a/modules/boards/app/components/boards/table_component.rb b/modules/boards/app/components/boards/table_component.rb
index ccd8fc3f2c85..ea2e90cc8912 100644
--- a/modules/boards/app/components/boards/table_component.rb
+++ b/modules/boards/app/components/boards/table_component.rb
@@ -38,9 +38,9 @@ def initial_sort_correlation
end
def sortable_columns_correlation
- super.merge(name: 'grids.name',
- project_name: 'projects.name',
- created_at: 'grids.created_at')
+ super.merge(name: "grids.name",
+ project_name: "projects.name",
+ created_at: "grids.created_at")
end
def paginated?
@@ -50,7 +50,7 @@ def paginated?
def headers
@headers ||= [
[:name, { caption: Boards::Grid.human_attribute_name(:name) }],
- current_project.blank? ? [:project_name, { caption: I18n.t('attributes.project') }] : nil,
+ current_project.blank? ? [:project_name, { caption: I18n.t("attributes.project") }] : nil,
[:type, { caption: Boards::Grid.human_attribute_name(:type) }],
[:created_at, { caption: Boards::Grid.human_attribute_name(:created_at) }]
].compact
diff --git a/modules/boards/app/controllers/boards/boards_controller.rb b/modules/boards/app/controllers/boards/boards_controller.rb
index 5897ca8d997f..4d60fabb1085 100644
--- a/modules/boards/app/controllers/boards/boards_controller.rb
+++ b/modules/boards/app/controllers/boards/boards_controller.rb
@@ -19,11 +19,11 @@ class BoardsController < BaseController
menu_item :boards
def index
- render 'index', locals: { menu_name: project_or_global_menu }
+ render "index", locals: { menu_name: project_or_global_menu }
end
def show
- render layout: 'angular/angular'
+ render layout: "angular/angular"
end
def new; end
@@ -51,7 +51,7 @@ def destroy
render json: { redirect_url: project_work_package_boards_path(@project) }
end
format.html do
- redirect_to action: 'index', project_id: @project
+ redirect_to action: "index", project_id: @project
end
end
end
@@ -94,7 +94,7 @@ def ensure_board_type_not_restricted
end
def restricted_board_type?
- !EnterpriseToken.allows_to?(:board_view) && board_grid_params[:attribute] != 'basic'
+ !EnterpriseToken.allows_to?(:board_view) && board_grid_params[:attribute] != "basic"
end
def service_call
@@ -108,12 +108,12 @@ def service_call
def service_class
{
- 'basic' => Boards::BasicBoardCreateService,
- 'status' => Boards::StatusBoardCreateService,
- 'assignee' => Boards::AssigneeBoardCreateService,
- 'version' => Boards::VersionBoardCreateService,
- 'subproject' => Boards::SubprojectBoardCreateService,
- 'subtasks' => Boards::SubtasksBoardCreateService
+ "basic" => Boards::BasicBoardCreateService,
+ "status" => Boards::StatusBoardCreateService,
+ "assignee" => Boards::AssigneeBoardCreateService,
+ "version" => Boards::VersionBoardCreateService,
+ "subproject" => Boards::SubprojectBoardCreateService,
+ "subtasks" => Boards::SubtasksBoardCreateService
}.fetch(board_grid_params[:attribute])
end
diff --git a/modules/boards/app/helpers/boards_helper.rb b/modules/boards/app/helpers/boards_helper.rb
index 1e6d36690383..60f7fe4acc55 100644
--- a/modules/boards/app/helpers/boards_helper.rb
+++ b/modules/boards/app/helpers/boards_helper.rb
@@ -9,12 +9,12 @@ module BoardsHelper
def board_types
[
- build_board_type_attributes('basic', 'lists', false),
- build_board_type_attributes('status', 'status'),
- build_board_type_attributes('assignee', 'assignees'),
- build_board_type_attributes('version', 'version'),
- build_board_type_attributes('subproject', 'subproject'),
- build_board_type_attributes('subtasks', 'parent-child')
+ build_board_type_attributes("basic", "lists", false),
+ build_board_type_attributes("status", "status"),
+ build_board_type_attributes("assignee", "assignees"),
+ build_board_type_attributes("version", "version"),
+ build_board_type_attributes("subproject", "subproject"),
+ build_board_type_attributes("subtasks", "parent-child")
]
end
diff --git a/modules/boards/app/models/boards/grid.rb b/modules/boards/app/models/boards/grid.rb
index 9c3cfd2cf698..46249d0a374d 100644
--- a/modules/boards/app/models/boards/grid.rb
+++ b/modules/boards/app/models/boards/grid.rb
@@ -67,7 +67,7 @@ def delete_queries
def contained_query_ids
widgets
- .filter_map { |w| w.options['queryId'] || w.options['query_id'] }
+ .filter_map { |w| w.options["queryId"] || w.options["query_id"] }
end
end
end
diff --git a/modules/boards/app/representers/api/v3/boards/widgets/board_options_representer.rb b/modules/boards/app/representers/api/v3/boards/widgets/board_options_representer.rb
index 11c88ef7eef7..c4eb25fdbede 100644
--- a/modules/boards/app/representers/api/v3/boards/widgets/board_options_representer.rb
+++ b/modules/boards/app/representers/api/v3/boards/widgets/board_options_representer.rb
@@ -33,12 +33,12 @@ module Widgets
class BoardOptionsRepresenter < ::API::V3::Grids::Widgets::DefaultOptionsRepresenter
property :queryId,
getter: ->(represented:, **) {
- represented['queryId'] || represented['query_id']
+ represented["queryId"] || represented["query_id"]
}
property :filters,
getter: ->(represented:, **) {
- represented['filters']
+ represented["filters"]
}
end
end
diff --git a/modules/boards/app/services/boards/base_create_service.rb b/modules/boards/app/services/boards/base_create_service.rb
index d3538f94906b..5a8150acef41 100644
--- a/modules/boards/app/services/boards/base_create_service.rb
+++ b/modules/boards/app/services/boards/base_create_service.rb
@@ -61,23 +61,23 @@ def default_create_query_params(params)
end
def query_name
- raise 'Define the query name'
+ raise "Define the query name"
end
def query_filters
- raise 'Define the query filters'
+ raise "Define the query filters"
end
def query_sort_criteria
- [[:manual_sorting, 'asc'], [:id, 'asc']]
+ [[:manual_sorting, "asc"], [:id, "asc"]]
end
def options_for_grid(params)
{}.tap do |options|
- if params[:attribute] == 'basic'
- options[:type] = 'free'
+ if params[:attribute] == "basic"
+ options[:type] = "free"
else
- options[:type] = 'action'
+ options[:type] = "action"
options[:attribute] = params[:attribute]
end
end
@@ -86,7 +86,7 @@ def options_for_grid(params)
def options_for_widgets(_params)
return [] if no_widgets_initially?
- raise 'Define the options for the grid widgets'
+ raise "Define the options for the grid widgets"
end
def row_count_for_board
diff --git a/modules/boards/app/services/boards/basic_board_create_service.rb b/modules/boards/app/services/boards/basic_board_create_service.rb
index 65705f1576ea..03535632a181 100644
--- a/modules/boards/app/services/boards/basic_board_create_service.rb
+++ b/modules/boards/app/services/boards/basic_board_create_service.rb
@@ -5,11 +5,11 @@ class BasicBoardCreateService < BaseCreateService
private
def query_name
- 'Unnamed list'
+ "Unnamed list"
end
def query_filters
- [{ manual_sort: { operator: 'ow', values: [] } }]
+ [{ manual_sort: { operator: "ow", values: [] } }]
end
def options_for_widgets(params)
diff --git a/modules/boards/app/services/boards/copy/widgets_dependent_service.rb b/modules/boards/app/services/boards/copy/widgets_dependent_service.rb
index b5d6ae143bc9..885cb3411862 100644
--- a/modules/boards/app/services/boards/copy/widgets_dependent_service.rb
+++ b/modules/boards/app/services/boards/copy/widgets_dependent_service.rb
@@ -31,7 +31,7 @@ class WidgetsDependentService < ::Grids::Copy::WidgetsDependentService
protected
def duplicate_widget(widget, _new_board, _params)
- unless widget.identifier == 'work_package_query'
+ unless widget.identifier == "work_package_query"
raise "Expected widget work_package_query, got #{widget.identifier}"
end
diff --git a/modules/boards/app/services/boards/status_board_create_service.rb b/modules/boards/app/services/boards/status_board_create_service.rb
index 500dfdd170c3..0fa468f13bf5 100644
--- a/modules/boards/app/services/boards/status_board_create_service.rb
+++ b/modules/boards/app/services/boards/status_board_create_service.rb
@@ -9,7 +9,7 @@ def query_name
end
def query_filters
- [{ status_id: { operator: '=', values: [default_status.id.to_s] } }]
+ [{ status_id: { operator: "=", values: [default_status.id.to_s] } }]
end
def default_status
diff --git a/modules/boards/app/services/boards/version_board_create_service.rb b/modules/boards/app/services/boards/version_board_create_service.rb
index d841b7778da6..d7b518de823a 100644
--- a/modules/boards/app/services/boards/version_board_create_service.rb
+++ b/modules/boards/app/services/boards/version_board_create_service.rb
@@ -43,7 +43,7 @@ def query_name(version)
end
def query_filters(version)
- [{ version_id: { operator: '=', values: [version.id.to_s] } }]
+ [{ version_id: { operator: "=", values: [version.id.to_s] } }]
end
def options_for_widgets(params)
diff --git a/modules/boards/config/routes.rb b/modules/boards/config/routes.rb
index 8a5e952698a3..84550482ad2b 100644
--- a/modules/boards/config/routes.rb
+++ b/modules/boards/config/routes.rb
@@ -1,15 +1,15 @@
Rails.application.routes.draw do
resources :boards,
- controller: 'boards/boards',
+ controller: "boards/boards",
only: %i[index new create destroy],
as: :work_package_boards
- scope 'projects/:project_id', as: 'project' do
+ scope "projects/:project_id", as: "project" do
resources :boards,
- controller: 'boards/boards',
+ controller: "boards/boards",
only: %i[index show new create],
as: :work_package_boards do
- get '(/*state)' => 'boards/boards#show', on: :member, as: '', constraints: { id: /\d+/ }
+ get "(/*state)" => "boards/boards#show", on: :member, as: "", constraints: { id: /\d+/ }
end
end
end
diff --git a/modules/boards/lib/open_project/boards/engine.rb b/modules/boards/lib/open_project/boards/engine.rb
index f022670b0c71..cf55f642ba1e 100644
--- a/modules/boards/lib/open_project/boards/engine.rb
+++ b/modules/boards/lib/open_project/boards/engine.rb
@@ -22,18 +22,18 @@ class Engine < ::Rails::Engine
include OpenProject::Plugins::ActsAsOpEngine
- register 'openproject-boards',
- author_url: 'https://www.openproject.org',
+ register "openproject-boards",
+ author_url: "https://www.openproject.org",
bundled: true,
settings: {} do
project_module :board_view, dependencies: :work_package_tracking, order: 80 do
permission :show_board_views,
- { 'boards/boards': %i[index show] },
+ { "boards/boards": %i[index show] },
permissible_on: :project,
dependencies: :view_work_packages,
contract_actions: { boards: %i[read] }
permission :manage_board_views,
- { 'boards/boards': %i[index show new create destroy] },
+ { "boards/boards": %i[index show new create destroy] },
permissible_on: :project,
dependencies: :manage_public_queries,
contract_actions: { boards: %i[create update destroy] }
@@ -41,18 +41,18 @@ class Engine < ::Rails::Engine
menu :project_menu,
:boards,
- { controller: '/boards/boards', action: :index },
- caption: :'boards.label_boards',
+ { controller: "/boards/boards", action: :index },
+ caption: :"boards.label_boards",
after: :work_packages,
- icon: 'boards'
+ icon: "boards"
menu :project_menu,
:board_menu,
- { controller: '/boards/boards', action: :index },
+ { controller: "/boards/boards", action: :index },
parent: :boards,
- partial: 'boards/boards/menu_board',
+ partial: "boards/boards/menu_board",
last: true,
- caption: :'boards.label_boards'
+ caption: :"boards.label_boards"
should_render_global_menu_item = Proc.new do
(User.current.logged? || !Setting.login_required?) &&
@@ -61,21 +61,21 @@ class Engine < ::Rails::Engine
menu :top_menu,
:boards,
- { controller: '/boards/boards', action: 'index' },
+ { controller: "/boards/boards", action: "index" },
context: :modules,
caption: :project_module_board_view,
before: :news,
after: :team_planners,
- icon: 'boards',
+ icon: "boards",
if: should_render_global_menu_item
menu :global_menu,
:boards,
- { controller: '/boards/boards', action: 'index' },
+ { controller: "/boards/boards", action: "index" },
caption: :project_module_board_view,
before: :news,
after: :team_planners,
- icon: 'boards',
+ icon: "boards",
if: should_render_global_menu_item
end
diff --git a/modules/boards/lib/open_project/boards/grid_registration.rb b/modules/boards/lib/open_project/boards/grid_registration.rb
index ae5c95ebb270..5cae40fc53d0 100644
--- a/modules/boards/lib/open_project/boards/grid_registration.rb
+++ b/modules/boards/lib/open_project/boards/grid_registration.rb
@@ -1,13 +1,13 @@
module OpenProject
module Boards
class GridRegistration < ::Grids::Configuration::Registration
- grid_class 'Boards::Grid'
+ grid_class "Boards::Grid"
to_scope :project_work_package_boards_path
- widgets 'work_package_query'
+ widgets "work_package_query"
- widget_strategy 'work_package_query' do
- options_representer '::API::V3::Boards::Widgets::BoardOptionsRepresenter'
+ widget_strategy "work_package_query" do
+ options_representer "::API::V3::Boards::Widgets::BoardOptionsRepresenter"
end
defaults -> {
@@ -23,7 +23,7 @@ def from_scope(scope)
recognized = ::OpenProject::StaticRouting.recognize_route(scope)
return if recognized.nil?
- if recognized[:controller] == 'boards/boards'
+ if recognized[:controller] == "boards/boards"
recognized.slice(:project_id, :id, :user_id)&.merge(class: ::Boards::Grid)
end
end
diff --git a/modules/boards/lib/open_project/boards/patches/setting_seeder_patch.rb b/modules/boards/lib/open_project/boards/patches/setting_seeder_patch.rb
index 61f63c826c02..33d746e1f3e3 100644
--- a/modules/boards/lib/open_project/boards/patches/setting_seeder_patch.rb
+++ b/modules/boards/lib/open_project/boards/patches/setting_seeder_patch.rb
@@ -35,8 +35,8 @@ module InstanceMethods
def data
original_data = super
- unless original_data['default_projects_modules'].include? 'board_view'
- original_data['default_projects_modules'] << 'board_view'
+ unless original_data["default_projects_modules"].include? "board_view"
+ original_data["default_projects_modules"] << "board_view"
end
original_data
diff --git a/modules/boards/lib/openproject-boards.rb b/modules/boards/lib/openproject-boards.rb
index cde0d2155d02..afe1e82a2e7c 100644
--- a/modules/boards/lib/openproject-boards.rb
+++ b/modules/boards/lib/openproject-boards.rb
@@ -1 +1 @@
-require 'open_project/boards'
+require "open_project/boards"
diff --git a/modules/boards/openproject-boards.gemspec b/modules/boards/openproject-boards.gemspec
index 62f15d85f5ed..806f8d977704 100644
--- a/modules/boards/openproject-boards.gemspec
+++ b/modules/boards/openproject-boards.gemspec
@@ -1,12 +1,12 @@
Gem::Specification.new do |s|
- s.name = 'openproject-boards'
- s.version = '1.0.0'
- s.authors = 'OpenProject GmbH'
- s.email = 'info@openproject.com'
- s.summary = 'OpenProject Boards'
- s.description = 'Provides board views'
- s.license = 'GPLv3'
+ s.name = "openproject-boards"
+ s.version = "1.0.0"
+ s.authors = "OpenProject GmbH"
+ s.email = "info@openproject.com"
+ s.summary = "OpenProject Boards"
+ s.description = "Provides board views"
+ s.license = "GPLv3"
- s.files = Dir['{app,config,db,lib}/**/*']
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.files = Dir["{app,config,db,lib}/**/*"]
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/boards/spec/contracts/boards/create_contract_spec.rb b/modules/boards/spec/contracts/boards/create_contract_spec.rb
index 8ec469cabb46..4db2e8890aec 100644
--- a/modules/boards/spec/contracts/boards/create_contract_spec.rb
+++ b/modules/boards/spec/contracts/boards/create_contract_spec.rb
@@ -28,30 +28,30 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe Boards::CreateContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:project) { build_stubbed(:project) }
- let(:name) { 'My Board' }
+ let(:name) { "My Board" }
let(:user) { build_stubbed(:user) }
let(:grid) do
build_stubbed(:board_grid, project:, name:)
end
let(:contract) { described_class.new(grid, user) }
- context 'when :project not provided' do
+ context "when :project not provided" do
let(:project) { nil }
- it_behaves_like 'contract is invalid', project: :blank
+ it_behaves_like "contract is invalid", project: :blank
end
- context 'when :name not provided' do
+ context "when :name not provided" do
let(:name) { nil }
- it_behaves_like 'contract is invalid', name: :blank
+ it_behaves_like "contract is invalid", name: :blank
end
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
diff --git a/modules/boards/spec/contracts/grids/create_contract_spec.rb b/modules/boards/spec/contracts/grids/create_contract_spec.rb
index c203c5993d3e..c8ad7ff0ec02 100644
--- a/modules/boards/spec/contracts/grids/create_contract_spec.rb
+++ b/modules/boards/spec/contracts/grids/create_contract_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe Grids::CreateContract, 'for Boards::Grid' do
+RSpec.describe Grids::CreateContract, "for Boards::Grid" do
let(:project) { build_stubbed(:project) }
let(:instance) { described_class.new(grid, user) }
let(:user) { build_stubbed(:user) }
@@ -36,17 +36,17 @@
create(:board_grid, project:)
end
- include_context 'model contract'
+ include_context "model contract"
- describe 'user_id' do
- it_behaves_like 'is not writable' do
+ describe "user_id" do
+ it_behaves_like "is not writable" do
let(:attribute) { :user_id }
let(:value) { 5 }
end
end
- describe 'project_id' do
- it_behaves_like 'is writable' do
+ describe "project_id" do
+ it_behaves_like "is writable" do
let(:attribute) { :project_id }
let(:value) { 5 }
end
diff --git a/modules/boards/spec/factories/board_factory.rb b/modules/boards/spec/factories/board_factory.rb
index 3bb311789483..a01ac756fa1c 100644
--- a/modules/boards/spec/factories/board_factory.rb
+++ b/modules/boards/spec/factories/board_factory.rb
@@ -1,12 +1,12 @@
FactoryBot.define do
- factory :board_grid, class: 'Boards::Grid' do
+ factory :board_grid, class: "Boards::Grid" do
project
- name { 'My board' }
+ name { "My board" }
row_count { 1 }
column_count { 4 }
end
- factory :board_grid_with_query, class: 'Boards::Grid' do
+ factory :board_grid_with_query, class: "Boards::Grid" do
project
sequence(:name) { |n| "Board with query #{n}" }
row_count { 1 }
@@ -18,25 +18,25 @@
callback(:after_build) do |board, evaluator| # this is also done after :create
query = evaluator.query || begin
- build(:public_query, name: 'List 1', project: board.project).tap do |q|
- q.sort_criteria = [[:manual_sorting, 'asc']]
- q.add_filter(:manual_sort, 'ow', [])
+ build(:public_query, name: "List 1", project: board.project).tap do |q|
+ q.sort_criteria = [[:manual_sorting, "asc"]]
+ q.add_filter(:manual_sort, "ow", [])
q.save!
end
end
board.widgets << create(:grid_widget,
- identifier: 'work_package_query',
+ identifier: "work_package_query",
start_row: 1,
end_row: 2,
start_column: 1,
end_column: 1,
- options: { 'queryId' => query.id,
+ options: { "queryId" => query.id,
"filters" => [{ "manualSort" => { "operator" => "ow", "values" => [] } }] })
end
end
- factory :board_grid_with_queries, class: 'Boards::Grid' do
+ factory :board_grid_with_queries, class: "Boards::Grid" do
project
sequence(:name) { |n| "Board with query #{n}" }
row_count { 1 }
@@ -49,26 +49,26 @@
callback(:after_build) do |board, evaluator| # this is also done after :create
evaluator.num_queries.times do |i|
query = build(:public_query, name: "List #{i + 1}", project: board.project).tap do |q|
- q.sort_criteria = [[:manual_sorting, 'asc']]
- q.add_filter(:manual_sort, 'ow', [])
+ q.sort_criteria = [[:manual_sorting, "asc"]]
+ q.add_filter(:manual_sort, "ow", [])
q.save!
end
board.widgets << create(:grid_widget,
- identifier: 'work_package_query',
+ identifier: "work_package_query",
start_row: 1,
end_row: 2,
start_column: 1,
end_column: 1,
- options: { 'queryId' => query.id,
+ options: { "queryId" => query.id,
"filters" => [{ "manualSort" => { "operator" => "ow", "values" => [] } }] })
end
end
end
- factory :subproject_board, class: 'Boards::Grid' do
+ factory :subproject_board, class: "Boards::Grid" do
project
- name { 'My board' }
+ name { "My board" }
row_count { 1 }
column_count { 4 }
@@ -79,24 +79,24 @@
callback(:after_create) do |board, evaluator| # this is also done after :create
evaluator.projects_columns.each do |project|
query = build(:public_query, name: project.name, project: board.project).tap do |q|
- q.sort_criteria = [[:manual_sorting, 'asc']]
- q.add_filter('only_subproject_id', '=', [project.id.to_s])
+ q.sort_criteria = [[:manual_sorting, "asc"]]
+ q.add_filter("only_subproject_id", "=", [project.id.to_s])
q.save!
end
filters = [{ "onlySubproject" => { "operator" => "=", "values" => [project.id.to_s] } }]
board.widgets << create(:grid_widget,
- identifier: 'work_package_query',
+ identifier: "work_package_query",
start_row: 1,
end_row: 2,
start_column: 1,
end_column: 1,
- options: { 'queryId' => query.id,
- 'filters' => filters })
+ options: { "queryId" => query.id,
+ "filters" => filters })
end
- board.options = { 'type' => 'action', 'attribute' => 'subproject' }
+ board.options = { "type" => "action", "attribute" => "subproject" }
board.save!
end
end
diff --git a/modules/boards/spec/features/action_boards/assignee_board_spec.rb b/modules/boards/spec/features/action_boards/assignee_board_spec.rb
index 2e052f9c39e5..811b6b3bba4e 100644
--- a/modules/boards/spec/features/action_boards/assignee_board_spec.rb
+++ b/modules/boards/spec/features/action_boards/assignee_board_spec.rb
@@ -26,16 +26,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../support/board_index_page'
-require_relative '../support/board_page'
+require "spec_helper"
+require_relative "../support/board_index_page"
+require_relative "../support/board_page"
-RSpec.describe 'Assignee action board', :js,
+RSpec.describe "Assignee action board", :js,
with_ee: %i[board_view] do
let(:bobself_user) do
create(:user,
- firstname: 'Bob',
- lastname: 'Self',
+ firstname: "Bob",
+ lastname: "Self",
member_with_roles: { project => role })
end
let(:admin) { create(:admin) }
@@ -58,13 +58,13 @@
let!(:foobar_user) do
create(:user,
- firstname: 'Foo',
- lastname: 'Bar',
+ firstname: "Foo",
+ lastname: "Bar",
member_with_roles: { project => role })
end
let!(:group) do
- create(:group, name: 'Grouped').tap do |group|
+ create(:group, name: "Grouped").tap do |group|
create(:member,
principal: group,
project:,
@@ -76,43 +76,43 @@
create(:work_package,
project:,
assigned_to: bobself_user,
- subject: 'Some Task')
+ subject: "Some Task")
end
- context 'in a project with members' do
+ context "in a project with members" do
before do
login_as(bobself_user)
end
- it 'allows to move a task between two assignees' do
+ it "allows to move a task between two assignees" do
# Move to the board index page
board_index.visit!
# Create new board
- board_page = board_index.create_board title: 'My Assignee Board',
- action: 'Assignee',
+ board_page = board_index.create_board title: "My Assignee Board",
+ action: "Assignee",
expect_empty: true
# Expect no assignees to be present
board_page.expect_empty
# Add myself to the board list
- board_page.add_list option: 'Bob Self'
- board_page.expect_list 'Bob Self'
+ board_page.add_list option: "Bob Self"
+ board_page.expect_list "Bob Self"
# Add the other user to the board list
- board_page.add_list option: 'Foo Bar'
- board_page.expect_list 'Foo Bar'
+ board_page.add_list option: "Foo Bar"
+ board_page.expect_list "Foo Bar"
# Add grouped list
- board_page.add_list option: 'Grouped'
- board_page.expect_list 'Grouped'
+ board_page.add_list option: "Grouped"
+ board_page.expect_list "Grouped"
# There is now only the none option left
- board_page.expect_list_option '(none)'
+ board_page.expect_list_option "(none)"
board_page.board(reload: true) do |board|
- expect(board.name).to eq 'My Assignee Board'
+ expect(board.name).to eq "My Assignee Board"
queries = board.contained_queries
expect(queries.count).to eq(3)
@@ -120,9 +120,9 @@
foo = queries.second
grouped = queries.last
- expect(bob.name).to eq 'Bob Self'
- expect(foo.name).to eq 'Foo Bar'
- expect(grouped.name).to eq 'Grouped'
+ expect(bob.name).to eq "Bob Self"
+ expect(foo.name).to eq "Foo Bar"
+ expect(grouped.name).to eq "Grouped"
expect(bob.filters.first.name).to eq :assigned_to_id
expect(bob.filters.first.values).to eq [bobself_user.id.to_s]
@@ -136,33 +136,33 @@
# First, expect work package to be assigned to "Bob self"
# For this, test the Bob self column to contain the work package
- board_page.expect_card 'Bob Self', 'Some Task'
+ board_page.expect_card "Bob Self", "Some Task"
# Then, move the work package from one column to the next one
- board_page.move_card(0, from: 'Bob Self', to: 'Foo Bar')
+ board_page.move_card(0, from: "Bob Self", to: "Foo Bar")
# Then, the work package should be in the other column
# and assigned to "Foo Bar" user
- board_page.expect_card 'Foo Bar', 'Some Task'
- board_page.expect_card 'Bob Self', 'Some Task', present: false
+ board_page.expect_card "Foo Bar", "Some Task"
+ board_page.expect_card "Bob Self", "Some Task", present: false
# Expect to have changed the avatar
- within_test_selector('op-wp-single-card--content-assignee') do
- expect(page).to have_css('.op-avatar_mini', text: 'FB', wait: 10)
+ within_test_selector("op-wp-single-card--content-assignee") do
+ expect(page).to have_css(".op-avatar_mini", text: "FB", wait: 10)
end
work_package.reload
expect(work_package.assigned_to).to eq(foobar_user)
# Move to group column
- board_page.move_card(0, from: 'Foo Bar', to: 'Grouped')
- board_page.expect_card 'Grouped', 'Some Task'
- board_page.expect_card 'Foo Bar', 'Some Task', present: false
- board_page.expect_card 'Bob Self', 'Some Task', present: false
+ board_page.move_card(0, from: "Foo Bar", to: "Grouped")
+ board_page.expect_card "Grouped", "Some Task"
+ board_page.expect_card "Foo Bar", "Some Task", present: false
+ board_page.expect_card "Bob Self", "Some Task", present: false
# Expect to have changed the avatar
- within_test_selector('op-wp-single-card--content-assignee') do
- expect(page).to have_css('.op-avatar_mini', text: 'GG', wait: 10)
+ within_test_selector("op-wp-single-card--content-assignee") do
+ expect(page).to have_css(".op-avatar_mini", text: "GG", wait: 10)
end
work_package.reload
@@ -172,28 +172,28 @@
card = board_page.card_for(work_package)
split_view = card.open_details_view
split_view.expect_subject
- split_view.edit_field(:assignee).update('Foo Bar')
- split_view.expect_and_dismiss_toaster message: 'Successful update.'
+ split_view.edit_field(:assignee).update("Foo Bar")
+ split_view.expect_and_dismiss_toaster message: "Successful update."
work_package.reload
expect(work_package.assigned_to).to eq(foobar_user)
- board_page.expect_card('Foo Bar', 'Some Task', present: true)
- board_page.expect_card('Grouped', 'Some Task', present: false)
+ board_page.expect_card("Foo Bar", "Some Task", present: true)
+ board_page.expect_card("Grouped", "Some Task", present: false)
# Reassign to grouped
- board_page.reference 'Grouped', work_package
- board_page.expect_card('Grouped', 'Some Task', present: true)
- board_page.expect_card('Foo Bar', 'Some Task', present: false)
+ board_page.reference "Grouped", work_package
+ board_page.expect_card("Grouped", "Some Task", present: true)
+ board_page.expect_card("Foo Bar", "Some Task", present: false)
end
end
- context 'in a project without members' do
+ context "in a project without members" do
before do
login_as(admin)
end
- it 'shows a warning when there are no members to add as a list with a link to add a new member' do
+ it "shows a warning when there are no members to add as a list with a link to add a new member" do
# Move to the board index page
other_board_index.visit!
@@ -204,8 +204,8 @@
board_page.expect_empty
# Add none to the list
- board_page.add_list option: '(none)'
- board_page.expect_list '(none)'
+ board_page.add_list option: "(none)"
+ board_page.expect_list "(none)"
board_page.open_add_list_modal
board_page.add_list_modal_shows_warning true, with_link: true
diff --git a/modules/boards/spec/features/action_boards/custom_field_filters_spec.rb b/modules/boards/spec/features/action_boards/custom_field_filters_spec.rb
index dae5cc3c5f11..dd8995e58fb4 100644
--- a/modules/boards/spec/features/action_boards/custom_field_filters_spec.rb
+++ b/modules/boards/spec/features/action_boards/custom_field_filters_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../support//board_index_page'
-require_relative '../support/board_page'
+require "spec_helper"
+require_relative "../support//board_index_page"
+require_relative "../support/board_page"
-RSpec.describe 'Custom field filter in boards', :js, with_ee: %i[board_view] do
+RSpec.describe "Custom field filter in boards", :js, with_ee: %i[board_view] do
let(:user) do
create(:user,
member_with_roles: { project => role })
@@ -47,14 +47,14 @@
end
let!(:priority) { create(:default_priority) }
- let!(:open_status) { create(:default_status, name: 'Open') }
- let!(:closed_status) { create(:status, is_closed: true, name: 'Closed') }
+ let!(:open_status) { create(:default_status, name: "Open") }
+ let!(:closed_status) { create(:status, is_closed: true, name: "Closed") }
let!(:work_package) do
wp = build(:work_package,
project:,
type:,
- subject: 'Foo',
+ subject: "Foo",
status: open_status)
wp.custom_field_values = {
@@ -87,21 +87,21 @@ def custom_value_for(str)
login_as(user)
end
- it 'can add a case-insensitive list (Regression #35744)' do
+ it "can add a case-insensitive list (Regression #35744)" do
board_index.visit!
# Create new board
- board_page = board_index.create_board action: 'Status'
+ board_page = board_index.create_board action: "Status"
# expect lists of default status
- board_page.expect_list 'Open'
+ board_page.expect_list "Open"
# Add a filter for CF value A and B
filters.expect_filter_count 0
filters.open
filters.add_filter_by(custom_field.name,
- 'is (OR)',
+ "is (OR)",
%w[A B],
custom_field.attribute_name(:camel_case))
@@ -110,21 +110,21 @@ def custom_value_for(str)
# Save that filter
board_page.save
- board_page.add_list option: 'Closed', query: 'closed'
- board_page.expect_list 'Closed'
+ board_page.add_list option: "Closed", query: "closed"
+ board_page.expect_list "Closed"
# Expect card to be present
- board_page.expect_card('Open', 'Foo', present: true)
+ board_page.expect_card("Open", "Foo", present: true)
# Move card to list closed
- board_page.move_card(0, from: 'Open', to: 'Closed')
+ board_page.move_card(0, from: "Open", to: "Closed")
- board_page.expect_card('Closed', 'Foo', present: true)
- board_page.expect_card('Open', 'Foo', present: false)
+ board_page.expect_card("Closed", "Foo", present: true)
+ board_page.expect_card("Open", "Foo", present: false)
# Expect custom field to be unchanged
work_package.reload
cv = work_package.custom_value_for(custom_field).typed_value
- expect(cv).to eq 'B'
+ expect(cv).to eq "B"
end
end
diff --git a/modules/boards/spec/features/action_boards/status_board_spec.rb b/modules/boards/spec/features/action_boards/status_board_spec.rb
index b1ccb56bd53b..417369d630b6 100644
--- a/modules/boards/spec/features/action_boards/status_board_spec.rb
+++ b/modules/boards/spec/features/action_boards/status_board_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../support//board_index_page'
-require_relative '../support/board_page'
+require "spec_helper"
+require_relative "../support//board_index_page"
+require_relative "../support/board_page"
-RSpec.describe 'Status action board', :js, with_ee: %i[board_view] do
+RSpec.describe "Status action board", :js, with_ee: %i[board_view] do
let(:user) do
create(:user,
member_with_roles: { project => role })
@@ -50,10 +50,10 @@
end
let!(:priority) { create(:default_priority) }
- let!(:open_status) { create(:default_status, name: 'Open') }
- let!(:whatever_status) { create(:status, name: 'Whatever') }
- let!(:closed_status) { create(:status, is_closed: true, name: 'Closed') }
- let!(:work_package) { create(:work_package, project:, subject: 'Foo', status: whatever_status) }
+ let!(:open_status) { create(:default_status, name: "Open") }
+ let!(:whatever_status) { create(:status, name: "Whatever") }
+ let!(:closed_status) { create(:status, is_closed: true, name: "Closed") }
+ let!(:work_package) { create(:work_package, project:, subject: "Foo", status: whatever_status) }
let(:filters) { Components::WorkPackages::Filters.new }
@@ -91,21 +91,21 @@
login_as(user)
end
- context 'with full boards permissions' do
- it 'can add a case-insensitive list (Regression #35744)' do
+ context "with full boards permissions" do
+ it "can add a case-insensitive list (Regression #35744)" do
board_index.visit!
# Create new board
- board_page = board_index.create_board action: 'Status'
+ board_page = board_index.create_board action: "Status"
# expect lists of default status
- board_page.expect_list 'Open'
+ board_page.expect_list "Open"
- board_page.add_list option: 'Closed', query: 'closed'
- board_page.expect_list 'Closed'
+ board_page.add_list option: "Closed", query: "closed"
+ board_page.expect_list "Closed"
end
- it 'does not change moving card project when filtering on projects (Bug #44895)' do
+ it "does not change moving card project when filtering on projects (Bug #44895)" do
other_project = create(:project,
types: [type],
enabled_module_names: %i[work_package_tracking board_view],
@@ -113,13 +113,13 @@
board_index.visit!
# Create new board
- board_page = board_index.create_board action: 'Status'
+ board_page = board_index.create_board action: "Status"
- board_page.add_list option: 'Whatever'
- board_page.expect_list 'Whatever'
+ board_page.add_list option: "Whatever"
+ board_page.expect_list "Whatever"
# Add item
- board_page.add_card 'Open', 'New Task'
+ board_page.add_card "Open", "New Task"
# Add projects filter
board_page.filters.open
@@ -127,7 +127,7 @@
# board_page.filters.add_filter('Project')
# board_page.filters.add_filter_by('Project', 'is (OR)', [other_project.name, project.name])
- board_page.filters.add_filter_by('Project', 'is not', other_project.name)
+ board_page.filters.add_filter_by("Project", "is not", other_project.name)
board_page.filters.expect_filter_count 1
# wait for the chain of debounces:
@@ -139,40 +139,40 @@
loading_indicator_saveguard
# move card
- board_page.move_card(0, from: 'Open', to: 'Whatever')
+ board_page.move_card(0, from: "Open", to: "Whatever")
board_page.wait_for_lists_reload
- board_page.expect_card('Whatever', 'New Task', present: true)
+ board_page.expect_card("Whatever", "New Task", present: true)
- wp_task = WorkPackage.find_by(subject: 'New Task')
+ wp_task = WorkPackage.find_by(subject: "New Task")
- expect(wp_task.status).to eq(whatever_status), 'Moving the card should have updated the status'
- expect(wp_task.project).to eq(project), 'Moving the card should not change the project'
+ expect(wp_task.status).to eq(whatever_status), "Moving the card should have updated the status"
+ expect(wp_task.project).to eq(project), "Moving the card should not change the project"
end
- it 'allows management of boards', with_settings: { login_required: false } do
+ it "allows management of boards", with_settings: { login_required: false } do
board_index.visit!
# Create new board
- board_page = board_index.create_board title: 'My Status Board',
- action: 'Status'
+ board_page = board_index.create_board title: "My Status Board",
+ action: "Status"
# expect lists of default status
- board_page.expect_list 'Open'
+ board_page.expect_list "Open"
- board_page.add_list option: 'Closed'
- board_page.expect_list 'Closed'
+ board_page.add_list option: "Closed"
+ board_page.expect_list "Closed"
board_page.board(reload: true) do |board|
- expect(board.name).to eq 'My Status Board'
+ expect(board.name).to eq "My Status Board"
queries = board.contained_queries
expect(queries.count).to eq(2)
open = queries.first
closed = queries.last
- expect(open.name).to eq 'Open'
- expect(closed.name).to eq 'Closed'
+ expect(open.name).to eq "Open"
+ expect(closed.name).to eq "Closed"
expect(open.filters.first.name).to eq :status_id
expect(open.filters.first.values).to eq [open_status.id.to_s]
@@ -182,29 +182,29 @@
end
# Create new list
- board_page.add_list option: 'Whatever'
- board_page.expect_list 'Whatever'
+ board_page.add_list option: "Whatever"
+ board_page.expect_list "Whatever"
# Add item
- board_page.add_card 'Open', 'Task 1'
+ board_page.add_card "Open", "Task 1"
sleep 2
# Expect added to query
queries = board_page.board(reload: true).contained_queries
expect(queries.count).to eq 3
- first = queries.find_by(name: 'Open')
- second = queries.find_by(name: 'Closed')
+ first = queries.find_by(name: "Open")
+ second = queries.find_by(name: "Closed")
expect(first.ordered_work_packages.count).to eq(1)
expect(second.ordered_work_packages).to be_empty
# Expect work package to be saved in query first
subjects = WorkPackage.where(id: first.ordered_work_packages.pluck(:work_package_id)).pluck(:subject, :status_id)
- expect(subjects).to contain_exactly(['Task 1', open_status.id])
+ expect(subjects).to contain_exactly(["Task 1", open_status.id])
# Move item to Closed
- board_page.move_card(0, from: 'Open', to: 'Closed')
- board_page.expect_card('Open', 'Task 1', present: false)
- board_page.expect_card('Closed', 'Task 1', present: true)
+ board_page.move_card(0, from: "Open", to: "Closed")
+ board_page.expect_card("Open", "Task 1", present: false)
+ board_page.expect_card("Closed", "Task 1", present: true)
# Expect work package to be saved in query second
sleep 2
@@ -214,17 +214,17 @@
end
subjects = WorkPackage.where(id: second.ordered_work_packages.pluck(:work_package_id)).pluck(:subject, :status_id)
- expect(subjects).to contain_exactly(['Task 1', closed_status.id])
+ expect(subjects).to contain_exactly(["Task 1", closed_status.id])
# Try to drag to whatever, which has no workflow
- board_page.move_card(0, from: 'Closed', to: 'Whatever')
+ board_page.move_card(0, from: "Closed", to: "Whatever")
board_page.expect_and_dismiss_toaster(
type: :error,
message: "Status is invalid because no valid transition exists from old to new status for the current user's roles."
)
- board_page.expect_card('Open', 'Task 1', present: false)
- board_page.expect_card('Whatever', 'Task 1', present: false)
- board_page.expect_card('Closed', 'Task 1', present: true)
+ board_page.expect_card("Open", "Task 1", present: false)
+ board_page.expect_card("Whatever", "Task 1", present: false)
+ board_page.expect_card("Closed", "Task 1", present: true)
# Add filter
# Filter for Task
@@ -233,14 +233,14 @@
# Expect that status is not available for global filter selection
filters.open_available_filter_list
- filters.expect_available_filter 'Status', present: false
+ filters.expect_available_filter "Status", present: false
- filters.quick_filter 'Task'
+ filters.quick_filter "Task"
board_page.expect_changed
sleep 2
- board_page.expect_card('Closed', 'Task 1', present: true)
- board_page.expect_card('Whatever', work_package.subject, present: false)
+ board_page.expect_card("Closed", "Task 1", present: true)
+ board_page.expect_card("Whatever", work_package.subject, present: false)
# Expect query props to be present
url = URI.parse(page.current_url).query
@@ -251,7 +251,7 @@
# Expect filter to be saved in board
board_page.board(reload: true) do |board|
- expect(board.options[:filters]).to eq [{ search: { operator: '**', values: ['Task'] } }]
+ expect(board.options[:filters]).to eq [{ search: { operator: "**", values: ["Task"] } }]
end
# Revisit board
@@ -260,67 +260,67 @@
# Expect filter to be present
filters.expect_filter_count 1
filters.open
- filters.expect_quick_filter 'Task'
+ filters.expect_quick_filter "Task"
# No query props visible
board_page.expect_not_changed
# Remove query
- board_page.remove_list 'Whatever'
+ board_page.remove_list "Whatever"
queries = board_page.board(reload: true).contained_queries
expect(queries.count).to eq(2)
- expect(queries.first.name).to eq 'Open'
- expect(queries.last.name).to eq 'Closed'
+ expect(queries.first.name).to eq "Open"
+ expect(queries.last.name).to eq "Closed"
expect(queries.first.ordered_work_packages).to be_empty
subjects = WorkPackage.where(id: second.ordered_work_packages.pluck(:work_package_id))
- expect(subjects.pluck(:subject, :status_id)).to contain_exactly(['Task 1', closed_status.id])
+ expect(subjects.pluck(:subject, :status_id)).to contain_exactly(["Task 1", closed_status.id])
# Open remaining in split view
wp = second.ordered_work_packages.first.work_package
card = board_page.card_for(wp)
split_view = card.open_details_view
split_view.expect_subject
- split_view.edit_field(:status).update('Open')
- split_view.expect_and_dismiss_toaster message: 'Successful update.'
+ split_view.edit_field(:status).update("Open")
+ split_view.expect_and_dismiss_toaster message: "Successful update."
wp.reload
expect(wp.status).to eq(open_status)
- board_page.expect_card('Open', 'Task 1', present: true)
- board_page.expect_card('Closed', 'Task 1', present: false)
+ board_page.expect_card("Open", "Task 1", present: true)
+ board_page.expect_card("Closed", "Task 1", present: false)
# Re-add task 1 to closed
- board_page.reference('Closed', subjects.first)
+ board_page.reference("Closed", subjects.first)
- board_page.expect_card('Open', 'Task 1', present: false)
- board_page.expect_card('Closed', 'Task 1', present: true)
+ board_page.expect_card("Open", "Task 1", present: false)
+ board_page.expect_card("Closed", "Task 1", present: true)
- aggregate_failures 'allows to access the board publicly (Regression #51850)' do
+ aggregate_failures "allows to access the board publicly (Regression #51850)" do
project.update!(public: true)
login_as User.anonymous
board_page.visit!
- board_page.expect_card('Closed', 'Task 1', present: true)
+ board_page.expect_card("Closed", "Task 1", present: true)
end
end
- it 'shows the default column only once (regression #40858)' do
+ it "shows the default column only once (regression #40858)" do
board_index.visit!
# Create new board
- board_page = board_index.create_board action: 'Status'
+ board_page = board_index.create_board action: "Status"
# expect lists of default status
- board_page.expect_list 'Open'
+ board_page.expect_list "Open"
expect(board_page.list_count).to eq(1)
board_index.visit!
# Create another status board
- second_board_page = board_index.create_board action: 'Status', via_toolbar: false
+ second_board_page = board_index.create_board action: "Status", via_toolbar: false
# Expect only one list with the default status
- second_board_page.expect_list 'Open'
+ second_board_page.expect_list "Open"
expect(second_board_page.list_count).to eq(1)
end
end
diff --git a/modules/boards/spec/features/action_boards/status_type_moving_board_spec.rb b/modules/boards/spec/features/action_boards/status_type_moving_board_spec.rb
index 9713303aabdc..7c2120298ac6 100644
--- a/modules/boards/spec/features/action_boards/status_type_moving_board_spec.rb
+++ b/modules/boards/spec/features/action_boards/status_type_moving_board_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../support//board_index_page'
-require_relative '../support/board_page'
+require "spec_helper"
+require_relative "../support//board_index_page"
+require_relative "../support/board_page"
-RSpec.describe 'Status action board', :js, with_ee: %i[board_view] do
+RSpec.describe "Status action board", :js, with_ee: %i[board_view] do
let(:user) do
create(:user,
member_with_roles: { project => role })
@@ -50,21 +50,21 @@
let(:board_index) { Pages::BoardIndex.new(project) }
let!(:priority) { create(:default_priority) }
- let!(:open_status) { create(:default_status, name: 'Open') }
- let!(:closed_status) { create(:status, is_closed: true, name: 'Closed') }
+ let!(:open_status) { create(:default_status, name: "Open") }
+ let!(:closed_status) { create(:status, is_closed: true, name: "Closed") }
let(:task_wp) do
create(:work_package,
project:,
type: type_task,
- subject: 'Open task item',
+ subject: "Open task item",
status: open_status)
end
let(:bug_wp) do
create(:work_package,
project:,
type: type_bug,
- subject: 'Closed bug item',
+ subject: "Closed bug item",
status: closed_status)
end
@@ -106,23 +106,23 @@
login_as(user)
end
- it 'allows moving of types between lists without changing filters (Regression #30817)' do
+ it "allows moving of types between lists without changing filters (Regression #30817)" do
board_index.visit!
# Create new board
- board_page = board_index.create_board action: 'Status'
+ board_page = board_index.create_board action: "Status"
# expect lists of default status
- board_page.expect_list 'Open'
+ board_page.expect_list "Open"
- board_page.add_list option: 'Closed'
- board_page.expect_list 'Closed'
+ board_page.add_list option: "Closed"
+ board_page.expect_list "Closed"
filters.expect_filter_count 0
filters.open
- filters.add_filter_by('Type', 'is (OR)', [type_task.name, type_bug.name])
- filters.expect_filter_by('Type', 'is (OR)', [type_task.name, type_bug.name])
+ filters.add_filter_by("Type", "is (OR)", [type_task.name, type_bug.name])
+ filters.expect_filter_by("Type", "is (OR)", [type_task.name, type_bug.name])
# Wait a bit before saving the page to ensure both values are processed
sleep 2
@@ -131,27 +131,27 @@
board_page.save
# Move task to closed
- board_page.move_card(0, from: 'Open', to: 'Closed')
+ board_page.move_card(0, from: "Open", to: "Closed")
- board_page.expect_card('Closed', 'Open task item', present: true)
+ board_page.expect_card("Closed", "Open task item", present: true)
# Expect type unchanged
- board_page.card_for(task_wp).expect_type 'Task'
- board_page.card_for(bug_wp).expect_type 'Bug'
+ board_page.card_for(task_wp).expect_type "Task"
+ board_page.card_for(bug_wp).expect_type "Bug"
# Wait a bit before moving the items too fast
sleep 2
# Move bug to open
- board_page.move_card_by_name('Closed bug item', from: 'Closed', to: 'Open')
+ board_page.move_card_by_name("Closed bug item", from: "Closed", to: "Open")
board_page.wait_for_lists_reload
- board_page.expect_card('Closed', 'Closed bug item', present: false)
- board_page.expect_card('Open', 'Closed bug item', present: true)
+ board_page.expect_card("Closed", "Closed bug item", present: false)
+ board_page.expect_card("Open", "Closed bug item", present: true)
# Expect type unchanged
- board_page.card_for(task_wp).expect_type 'Task'
- board_page.card_for(bug_wp).expect_type 'Bug'
+ board_page.card_for(task_wp).expect_type "Task"
+ board_page.card_for(bug_wp).expect_type "Bug"
sleep 2
diff --git a/modules/boards/spec/features/action_boards/subproject_board_spec.rb b/modules/boards/spec/features/action_boards/subproject_board_spec.rb
index 42d6e3bccb28..8b3f667cef96 100644
--- a/modules/boards/spec/features/action_boards/subproject_board_spec.rb
+++ b/modules/boards/spec/features/action_boards/subproject_board_spec.rb
@@ -26,24 +26,24 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../support//board_index_page'
-require_relative '../support/board_page'
+require "spec_helper"
+require_relative "../support//board_index_page"
+require_relative "../support/board_page"
-RSpec.describe 'Subproject action board', :js, with_ee: %i[board_view] do
+RSpec.describe "Subproject action board", :js, with_ee: %i[board_view] do
let(:user) do
create(:user,
member_with_roles: { project => role })
end
let(:type) { create(:type_standard) }
let(:project) do
- create(:project, name: 'Parent', types: [type], enabled_module_names: %i[work_package_tracking board_view])
+ create(:project, name: "Parent", types: [type], enabled_module_names: %i[work_package_tracking board_view])
end
let(:subproject1) do
- create(:project, parent: project, name: 'Child 1', types: [type], enabled_module_names: %i[work_package_tracking])
+ create(:project, parent: project, name: "Child 1", types: [type], enabled_module_names: %i[work_package_tracking])
end
let(:subproject2) do
- create(:project, parent: project, name: 'Child 2', types: [type], enabled_module_names: %i[work_package_tracking])
+ create(:project, parent: project, name: "Child 2", types: [type], enabled_module_names: %i[work_package_tracking])
end
let(:role) { create(:project_role, permissions:) }
@@ -55,8 +55,8 @@
end
let!(:priority) { create(:default_priority) }
- let!(:open_status) { create(:default_status, name: 'Open') }
- let!(:work_package) { create(:work_package, project: subproject1, subject: 'Foo', status: open_status) }
+ let!(:open_status) { create(:default_status, name: "Open") }
+ let!(:work_package) { create(:work_package, project: subproject1, subject: "Foo", status: open_status) }
before do
subproject1
@@ -65,7 +65,7 @@
login_as(user)
end
- context 'without the move_work_packages permission' do
+ context "without the move_work_packages permission" do
let(:permissions) do
%i[show_board_views manage_board_views add_work_packages
edit_work_packages view_work_packages manage_public_queries]
@@ -75,23 +75,23 @@
create(:user, member_with_roles: { project => role, subproject1 => role, subproject2 => role })
end
- it 'does not allow to move work packages' do
+ it "does not allow to move work packages" do
board_index.visit!
# Create new board
- board_page = board_index.create_board action: 'Subproject', expect_empty: true
+ board_page = board_index.create_board action: "Subproject", expect_empty: true
# Expect we can add a child 1
- board_page.add_list option: 'Child 1'
- board_page.expect_list 'Child 1'
+ board_page.add_list option: "Child 1"
+ board_page.expect_list "Child 1"
# Expect one work package there
- board_page.expect_card 'Child 1', 'Foo'
- board_page.expect_movable 'Child 1', 'Foo', movable: false
+ board_page.expect_card "Child 1", "Foo"
+ board_page.expect_movable "Child 1", "Foo", movable: false
end
end
- context 'with permissions in all subprojects' do
+ context "with permissions in all subprojects" do
let(:user) do
create(:user, member_with_roles: { project => role, subproject1 => role, subproject2 => role })
end
@@ -101,66 +101,66 @@
member_with_roles: { project => role })
end
- it 'allows management of subproject work packages' do
+ it "allows management of subproject work packages" do
board_index.visit!
# Create new board
- board_page = board_index.create_board title: 'My Subproject Board',
- action: 'Subproject',
+ board_page = board_index.create_board title: "My Subproject Board",
+ action: "Subproject",
expect_empty: true
# Expect we can add a child 1
- board_page.add_list option: 'Child 1'
- board_page.expect_list 'Child 1'
+ board_page.add_list option: "Child 1"
+ board_page.expect_list "Child 1"
# Expect one work package there
- board_page.expect_card 'Child 1', 'Foo'
+ board_page.expect_card "Child 1", "Foo"
# Expect move permission to be granted
- board_page.expect_movable 'Child 1', 'Foo', movable: true
+ board_page.expect_movable "Child 1", "Foo", movable: true
board_page.board(reload: true) do |board|
- expect(board.name).to eq 'My Subproject Board'
+ expect(board.name).to eq "My Subproject Board"
queries = board.contained_queries
expect(queries.count).to eq(1)
query = queries.first
- expect(query.name).to eq 'Child 1'
+ expect(query.name).to eq "Child 1"
expect(query.filters.first.name).to eq :only_subproject_id
expect(query.filters.first.values).to eq [subproject1.id.to_s]
end
# Create new list
- board_page.add_list option: 'Child 2'
- board_page.expect_list 'Child 2'
+ board_page.add_list option: "Child 2"
+ board_page.expect_list "Child 2"
- board_page.expect_cards_in_order 'Child 2'
+ board_page.expect_cards_in_order "Child 2"
# Add item
- board_page.add_card 'Child 1', 'Task 1'
+ board_page.add_card "Child 1", "Task 1"
sleep 2
# Expect added to query
queries = board_page.board(reload: true).contained_queries
expect(queries.count).to eq 2
- first = queries.find_by(name: 'Child 1')
- second = queries.find_by(name: 'Child 2')
+ first = queries.find_by(name: "Child 1")
+ second = queries.find_by(name: "Child 2")
expect(first.ordered_work_packages.count).to eq(1)
expect(second.ordered_work_packages).to be_empty
# Expect work package to be saved in query first
subjects = WorkPackage.where(id: first.ordered_work_packages.pluck(:work_package_id)).pluck(:subject, :project_id)
- expect(subjects).to contain_exactly(['Task 1', subproject1.id])
+ expect(subjects).to contain_exactly(["Task 1", subproject1.id])
# Move item to Child 2 list
- board_page.move_card(0, from: 'Child 1', to: 'Child 2')
+ board_page.move_card(0, from: "Child 1", to: "Child 2")
# TODO: The board reloading is flickering after the move_card action.
# It needs to be fixed.
- board_page.expect_card('Child 1', 'Task 1', present: false)
- board_page.expect_card('Child 2', 'Task 1', present: true)
+ board_page.expect_card("Child 1", "Task 1", present: false)
+ board_page.expect_card("Child 2", "Task 1", present: true)
# Expect work package to be saved in query second
retry_block(args: { tries: 3, base_interval: 5 }) do
@@ -169,11 +169,11 @@
end
subjects = WorkPackage.where(id: second.ordered_work_packages.pluck(:work_package_id)).pluck(:subject, :project_id)
- expect(subjects).to contain_exactly(['Task 1', subproject2.id])
+ expect(subjects).to contain_exactly(["Task 1", subproject2.id])
end
end
- context 'with permissions in only one subproject' do
+ context "with permissions in only one subproject" do
let(:user) do
create(:user,
# The membership in subproject2 gets removed later on
@@ -199,13 +199,13 @@
Member.where(project: subproject2, principal: user).destroy_all
end
- it 'displays only the columns for the projects in which the current user has permission' do
+ it "displays only the columns for the projects in which the current user has permission" do
board_page.visit!
board_page.expect_card subproject1.name, work_package.subject
# No error is to be displayed as erroneous columns are filtered out
- expect(page).to have_no_css('.op-toast.-error')
+ expect(page).to have_no_css(".op-toast.-error")
board_page.expect_no_list(subproject2.name)
expect(page)
@@ -213,7 +213,7 @@
end
end
- context 'with an archived subproject' do
+ context "with an archived subproject" do
let(:user) do
create(:user, member_with_roles: { project => role, subproject1 => role, subproject2 => role })
end
@@ -231,7 +231,7 @@
subproject2.update! active: false
end
- it 'displays only the columns for the projects in which the current user has permission' do
+ it "displays only the columns for the projects in which the current user has permission" do
board_page.visit!
board_page.expect_list subproject1.name
@@ -239,7 +239,7 @@
board_page.open_and_fill_add_list_modal subproject2.name
- expect(page).to have_no_css('.ng-option', text: subproject2.name)
+ expect(page).to have_no_css(".ng-option", text: subproject2.name)
end
end
end
diff --git a/modules/boards/spec/features/action_boards/subtasks_board_spec.rb b/modules/boards/spec/features/action_boards/subtasks_board_spec.rb
index 6bba1883ccea..a469996be5e7 100644
--- a/modules/boards/spec/features/action_boards/subtasks_board_spec.rb
+++ b/modules/boards/spec/features/action_boards/subtasks_board_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../support//board_index_page'
-require_relative '../support/board_page'
+require "spec_helper"
+require_relative "../support//board_index_page"
+require_relative "../support/board_page"
-RSpec.describe 'Subtasks action board', :js, with_ee: %i[board_view] do
+RSpec.describe "Subtasks action board", :js, with_ee: %i[board_view] do
let(:type) { create(:type_standard) }
let(:project) { create(:project, types: [type], enabled_module_names: %i[work_package_tracking board_view]) }
let(:role) { create(:project_role, permissions:) }
@@ -43,89 +43,89 @@
let(:board_index) { Pages::BoardIndex.new(project) }
let!(:priority) { create(:default_priority) }
- let!(:open_status) { create(:default_status, name: 'Open') }
- let!(:parent) { create(:work_package, project:, subject: 'Parent WP', status: open_status) }
- let!(:child) { create(:work_package, project:, subject: 'Child WP', parent:, status: open_status) }
+ let!(:open_status) { create(:default_status, name: "Open") }
+ let!(:parent) { create(:work_package, project:, subject: "Parent WP", status: open_status) }
+ let!(:child) { create(:work_package, project:, subject: "Child WP", parent:, status: open_status) }
before do
login_as(user)
end
- context 'without the manage_subtasks permission' do
+ context "without the manage_subtasks permission" do
let(:permissions) do
%i[show_board_views manage_board_views add_work_packages
edit_work_packages view_work_packages manage_public_queries]
end
- it 'does not allow to move work packages' do
+ it "does not allow to move work packages" do
board_index.visit!
# Create new board
- board_page = board_index.create_board action: 'Parent-child', expect_empty: true
+ board_page = board_index.create_board action: "Parent-child", expect_empty: true
# Expect we can add a work package column
- board_page.add_list option: 'Parent WP'
- board_page.expect_list 'Parent WP'
+ board_page.add_list option: "Parent WP"
+ board_page.expect_list "Parent WP"
# Expect one work package there
- board_page.expect_card 'Parent WP', 'Child'
- board_page.expect_movable 'Parent WP', 'Child', movable: false
+ board_page.expect_card "Parent WP", "Child"
+ board_page.expect_movable "Parent WP", "Child", movable: false
end
end
- context 'with all permissions' do
- let!(:other_wp) { create(:work_package, project:, subject: 'Other WP', status: open_status) }
+ context "with all permissions" do
+ let!(:other_wp) { create(:work_package, project:, subject: "Other WP", status: open_status) }
let(:permissions) do
%i[show_board_views manage_board_views add_work_packages
edit_work_packages view_work_packages manage_public_queries manage_subtasks]
end
- it 'allows management of subtasks work packages' do
+ it "allows management of subtasks work packages" do
board_index.visit!
# Create new board
- board_page = board_index.create_board title: 'My Parent-child Board',
- action: 'Parent-child',
+ board_page = board_index.create_board title: "My Parent-child Board",
+ action: "Parent-child",
expect_empty: true
# Expect we can add a child 1
- board_page.add_list option: 'Parent WP'
- board_page.expect_list 'Parent WP'
+ board_page.add_list option: "Parent WP"
+ board_page.expect_list "Parent WP"
# Expect one work package there
- board_page.expect_card 'Parent WP', 'Child'
+ board_page.expect_card "Parent WP", "Child"
# Expect move permission to be granted
- board_page.expect_movable 'Parent WP', 'Child', movable: true
+ board_page.expect_movable "Parent WP", "Child", movable: true
board_page.board(reload: true) do |board|
- expect(board.name).to eq 'My Parent-child Board'
+ expect(board.name).to eq "My Parent-child Board"
queries = board.contained_queries
expect(queries.count).to eq(1)
query = queries.first
- expect(query.name).to eq 'Parent WP'
+ expect(query.name).to eq "Parent WP"
expect(query.filters.first.name).to eq :parent
expect(query.filters.first.values).to eq [parent.id.to_s]
end
# Create new list
- board_page.add_list option: 'Other WP'
- board_page.expect_list 'Other WP'
+ board_page.add_list option: "Other WP"
+ board_page.expect_list "Other WP"
- board_page.expect_cards_in_order 'Other WP'
+ board_page.expect_cards_in_order "Other WP"
# Add item
- board_page.add_card 'Parent WP', 'Second child'
+ board_page.add_card "Parent WP", "Second child"
sleep 2
# Expect added to query
queries = board_page.board(reload: true).contained_queries
expect(queries.count).to eq 2
- first = queries.find_by(name: 'Parent WP')
- second = queries.find_by(name: 'Other WP')
+ first = queries.find_by(name: "Parent WP")
+ second = queries.find_by(name: "Other WP")
expect(first.ordered_work_packages.count).to eq(1)
expect(second.ordered_work_packages).to be_empty
@@ -134,11 +134,11 @@
expect(wp.parent_id).to eq parent.id
# Move item to Child 2 list
- board_page.move_card(0, from: 'Parent WP', to: 'Other WP')
+ board_page.move_card(0, from: "Parent WP", to: "Other WP")
board_page.wait_for_lists_reload
- board_page.expect_card('Parent WP', 'Second child', present: false)
- board_page.expect_card('Other WP', 'Second child', present: true)
+ board_page.expect_card("Parent WP", "Second child", present: false)
+ board_page.expect_card("Other WP", "Second child", present: true)
# Expect work package to be saved in query second
sleep 2
@@ -151,34 +151,34 @@
expect(wp.parent_id).to eq other_wp.id
# Reference back
- board_page.reference('Parent WP', wp)
+ board_page.reference("Parent WP", wp)
- board_page.expect_card('Parent WP', 'Second child', present: true)
- board_page.expect_card('Other WP', 'Second child', present: false)
+ board_page.expect_card("Parent WP", "Second child", present: true)
+ board_page.expect_card("Other WP", "Second child", present: false)
end
- it 'prevents adding a work package to its own column' do
+ it "prevents adding a work package to its own column" do
board_index.visit!
- board_page = board_index.create_board action: 'Parent-child', expect_empty: true
- board_page.add_list option: 'Parent WP'
- board_page.expect_list 'Parent WP'
- board_page.expect_card 'Parent WP', 'Child'
+ board_page = board_index.create_board action: "Parent-child", expect_empty: true
+ board_page.add_list option: "Parent WP"
+ board_page.expect_list "Parent WP"
+ board_page.expect_card "Parent WP", "Child"
- board_page.add_list option: 'Child WP'
- board_page.expect_list 'Child WP'
+ board_page.add_list option: "Child WP"
+ board_page.expect_list "Child WP"
# Try to move child to itself
- board_page.move_card(0, from: 'Parent WP', to: 'Child WP')
+ board_page.move_card(0, from: "Parent WP", to: "Child WP")
board_page.expect_and_dismiss_toaster type: :error,
- message: I18n.t('js.boards.error_cannot_move_into_self')
+ message: I18n.t("js.boards.error_cannot_move_into_self")
child.reload
expect(child.parent).to eq parent
end
end
- describe 'with German language (regression #40031)' do
+ describe "with German language (regression #40031)" do
let!(:german_user) { create(:admin, language: :de) }
let(:permissions) do
%i[show_board_views manage_board_views add_work_packages
@@ -190,12 +190,12 @@
login_as german_user
end
- it 'can add lists via the add modal' do
+ it "can add lists via the add modal" do
board_index.visit!
- board_page = board_index.create_board action: I18n.t('js.boards.board_type.board_type_title.subtasks'), expect_empty: true
- board_page.add_list option: 'Parent WP'
- board_page.expect_list 'Parent WP'
- board_page.expect_card 'Parent WP', 'Child'
+ board_page = board_index.create_board action: I18n.t("js.boards.board_type.board_type_title.subtasks"), expect_empty: true
+ board_page.add_list option: "Parent WP"
+ board_page.expect_list "Parent WP"
+ board_page.expect_card "Parent WP", "Child"
end
end
end
diff --git a/modules/boards/spec/features/action_boards/version_board_spec.rb b/modules/boards/spec/features/action_boards/version_board_spec.rb
index 6b38237eed34..c4effe02ddd1 100644
--- a/modules/boards/spec/features/action_boards/version_board_spec.rb
+++ b/modules/boards/spec/features/action_boards/version_board_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../support//board_index_page'
-require_relative '../support/board_page'
+require "spec_helper"
+require_relative "../support//board_index_page"
+require_relative "../support/board_page"
-RSpec.describe 'Version action board', :js, with_ee: %i[board_view] do
+RSpec.describe "Version action board", :js, with_ee: %i[board_view] do
let(:user) do
create(:user, member_with_roles: { project => role, second_project => role })
end
@@ -56,29 +56,29 @@
%i[show_board_views manage_board_views view_work_packages manage_public_queries]
end
- let!(:open_version) { create(:version, project:, name: 'Open version') }
- let!(:other_version) { create(:version, project:, name: 'A second version') }
- let!(:different_project_version_) { create(:version, project: second_project, name: 'Version of another project') }
- let!(:shared_version) { create(:version, project: second_project, name: 'Shared version', sharing: 'system') }
- let!(:closed_version) { create(:version, project:, status: 'closed', name: 'Closed version') }
+ let!(:open_version) { create(:version, project:, name: "Open version") }
+ let!(:other_version) { create(:version, project:, name: "A second version") }
+ let!(:different_project_version_) { create(:version, project: second_project, name: "Version of another project") }
+ let!(:shared_version) { create(:version, project: second_project, name: "Shared version", sharing: "system") }
+ let!(:closed_version) { create(:version, project:, status: "closed", name: "Closed version") }
- let!(:work_package) { create(:work_package, project:, subject: 'Foo', version: open_version) }
- let!(:closed_version_wp) { create(:work_package, project:, subject: 'Closed', version: closed_version) }
+ let!(:work_package) { create(:work_package, project:, subject: "Foo", version: open_version) }
+ let!(:closed_version_wp) { create(:work_package, project:, subject: "Closed", version: closed_version) }
let(:filters) { Components::WorkPackages::Filters.new }
def create_new_version_board
board_index.visit!
# Create new board
- board_page = board_index.create_board title: 'My Version Board',
- action: 'Version'
+ board_page = board_index.create_board title: "My Version Board",
+ action: "Version"
# expect lists of open versions
- board_page.expect_list 'Open version'
- board_page.expect_list 'A second version'
- board_page.expect_no_list 'Shared version'
- board_page.expect_no_list 'Closed version'
- board_page.expect_no_list 'Version of another project'
+ board_page.expect_list "Open version"
+ board_page.expect_list "A second version"
+ board_page.expect_no_list "Shared version"
+ board_page.expect_no_list "Closed version"
+ board_page.expect_no_list "Version of another project"
board_page
end
@@ -87,29 +87,29 @@ def create_new_version_board
project
end
- context 'with full boards permissions' do
+ context "with full boards permissions" do
before do
login_as(user)
end
- it 'allows management of boards' do
+ it "allows management of boards" do
board_page = create_new_version_board
- board_page.expect_card 'Open version', work_package.subject, present: true
+ board_page.expect_card "Open version", work_package.subject, present: true
- board_page.expect_list_option 'Shared version'
- board_page.expect_list_option 'Closed version'
+ board_page.expect_list_option "Shared version"
+ board_page.expect_list_option "Closed version"
board_page.board(reload: true) do |board|
- expect(board.name).to eq 'My Version Board'
+ expect(board.name).to eq "My Version Board"
queries = board.contained_queries
expect(queries.count).to eq(2)
- open = queries.detect { |q| q.name == 'Open version' }
- second_open = queries.detect { |q| q.name == 'A second version' }
+ open = queries.detect { |q| q.name == "Open version" }
+ second_open = queries.detect { |q| q.name == "A second version" }
- expect(open.name).to eq 'Open version'
- expect(second_open.name).to eq 'A second version'
+ expect(open.name).to eq "Open version"
+ expect(second_open.name).to eq "A second version"
expect(open.filters.first.name).to eq :version_id
expect(open.filters.first.values).to eq [open_version.id.to_s]
@@ -119,30 +119,30 @@ def create_new_version_board
end
# Add item
- board_page.add_list option: 'Shared version'
- board_page.expect_list 'Shared version'
- board_page.add_card 'Open version', 'Task 1'
+ board_page.add_list option: "Shared version"
+ board_page.expect_list "Shared version"
+ board_page.add_card "Open version", "Task 1"
sleep 2
# Expect added to query
queries = board_page.board(reload: true).contained_queries
expect(queries.count).to eq 3
- first = queries.find_by(name: 'Open version')
- second = queries.find_by(name: 'A second version')
+ first = queries.find_by(name: "Open version")
+ second = queries.find_by(name: "A second version")
expect(first.ordered_work_packages.count).to eq(1)
expect(second.ordered_work_packages).to be_empty
# Expect work package to be saved in query first
subjects = WorkPackage.where(id: first.ordered_work_packages.pluck(:work_package_id)).pluck(:subject, :version_id)
# Only the explicitly added item is now contained in sort order
- expect(subjects).to contain_exactly(['Task 1', open_version.id])
+ expect(subjects).to contain_exactly(["Task 1", open_version.id])
# Move item to Closed
- board_page.move_card(0, from: 'Open version', to: 'A second version')
+ board_page.move_card(0, from: "Open version", to: "A second version")
board_page.wait_for_lists_reload
- board_page.expect_card('Open version', 'Task 1', present: false)
- board_page.expect_card('A second version', 'Task 1', present: true)
+ board_page.expect_card("Open version", "Task 1", present: false)
+ board_page.expect_card("A second version", "Task 1", present: true)
# Expect work package to be saved in query second
sleep 2
@@ -152,7 +152,7 @@ def create_new_version_board
end
subjects = WorkPackage.where(id: second.ordered_work_packages.pluck(:work_package_id)).pluck(:subject, :version_id)
- expect(subjects).to contain_exactly(['Task 1', other_version.id])
+ expect(subjects).to contain_exactly(["Task 1", other_version.id])
# Add filter
# Filter for Task
@@ -161,14 +161,14 @@ def create_new_version_board
# Expect that version is not available for global filter selection
filters.open_available_filter_list
- filters.expect_available_filter 'Version', present: false
+ filters.expect_available_filter "Version", present: false
- filters.quick_filter 'Task'
+ filters.quick_filter "Task"
board_page.expect_changed
sleep 2
- board_page.expect_card('Open version', 'Foo', present: false)
- board_page.expect_card('A second version', 'Task 1', present: true)
+ board_page.expect_card("Open version", "Foo", present: false)
+ board_page.expect_card("A second version", "Task 1", present: true)
# Expect query props to be present
url = URI.parse(page.current_url).query
@@ -179,7 +179,7 @@ def create_new_version_board
# Expect filter to be saved in board
board_page.board(reload: true) do |board|
- expect(board.options[:filters]).to eq [{ search: { operator: '**', values: ['Task'] } }]
+ expect(board.options[:filters]).to eq [{ search: { operator: "**", values: ["Task"] } }]
end
# Revisit board
@@ -188,93 +188,93 @@ def create_new_version_board
# Expect filter to be present
filters.expect_filter_count 1
filters.open
- filters.expect_quick_filter 'Task'
+ filters.expect_quick_filter "Task"
# No query props visible
board_page.expect_not_changed
# Remove query
- board_page.remove_list 'Shared version'
+ board_page.remove_list "Shared version"
queries = board_page.board(reload: true).contained_queries
expect(queries.count).to eq(2)
- expect(queries.map(&:name)).to contain_exactly 'Open version', 'A second version'
+ expect(queries.map(&:name)).to contain_exactly "Open version", "A second version"
- board_page.expect_card('Open version', 'Foo', present: false)
- board_page.expect_card('A second version', 'Task 1', present: true)
+ board_page.expect_card("Open version", "Foo", present: false)
+ board_page.expect_card("A second version", "Task 1", present: true)
subjects = WorkPackage.where(id: second.ordered_work_packages.pluck(:work_package_id)).pluck(:subject, :version_id)
- expect(subjects).to contain_exactly(['Task 1', other_version.id])
+ expect(subjects).to contain_exactly(["Task 1", other_version.id])
# Open remaining in split view
work_package = second.ordered_work_packages.first.work_package
card = board_page.card_for(work_package)
split_view = card.open_details_view
split_view.expect_subject
- split_view.edit_field(:version).update('Open version')
- split_view.expect_and_dismiss_toaster message: 'Successful update.'
+ split_view.edit_field(:version).update("Open version")
+ split_view.expect_and_dismiss_toaster message: "Successful update."
work_package.reload
expect(work_package.version).to eq(open_version)
- board_page.expect_card('Open version', 'Task 1', present: true)
- board_page.expect_card('A second version', 'Task 1', present: false)
+ board_page.expect_card("Open version", "Task 1", present: true)
+ board_page.expect_card("A second version", "Task 1", present: false)
end
- it 'allows adding new and closed versions from within the board' do
+ it "allows adding new and closed versions from within the board" do
board_page = create_new_version_board
# Add new version (and list)
- board_page.add_list_with_new_value 'Completely new version'
- board_page.expect_list 'Completely new version'
+ board_page.add_list_with_new_value "Completely new version"
+ board_page.expect_list "Completely new version"
visit project_settings_versions_path(project)
- expect(page).to have_content 'Completely new version'
- expect(page).to have_content 'Closed version'
+ expect(page).to have_content "Completely new version"
+ expect(page).to have_content "Closed version"
board_page.visit!
- board_page.expect_list 'Open version'
- board_page.expect_list 'A second version'
- board_page.expect_list 'Completely new version'
- board_page.expect_card('Open version', 'Foo')
+ board_page.expect_list "Open version"
+ board_page.expect_list "A second version"
+ board_page.expect_list "Completely new version"
+ board_page.expect_card("Open version", "Foo")
queries = board_page.board(reload: true).contained_queries
- closed = queries.find_by(name: 'Closed version')
+ closed = queries.find_by(name: "Closed version")
expect(closed).to be_nil
retry_block(screenshot: true) do
board_page.add_list option: closed_version.name
end
- board_page.expect_list 'Closed version'
+ board_page.expect_list "Closed version"
expect(page).to have_css("#{test_selector('op-version-board-header')}.-closed")
# Can open that version
- board_page.click_list_dropdown 'Closed version', 'Open version'
+ board_page.click_list_dropdown "Closed version", "Open version"
expect(page).to have_no_css("#{test_selector('op-version-board-header')}.-closed")
closed_version.reload
- expect(closed_version.status).to eq 'open'
+ expect(closed_version.status).to eq "open"
# Can lock that version
- board_page.click_list_dropdown 'Closed version', 'Lock version'
+ board_page.click_list_dropdown "Closed version", "Lock version"
expect(page).to have_css("#{test_selector('op-version-board-header')}.-locked")
closed_version.reload
- expect(closed_version.status).to eq 'locked'
+ expect(closed_version.status).to eq "locked"
# We can move out of the locked version
- board_page.move_card(0, from: 'Closed version', to: 'Open version')
+ board_page.move_card(0, from: "Closed version", to: "Open version")
- board_page.expect_card('Open version', 'Closed', present: true)
- board_page.expect_card('Closed version', 'Closed', present: false)
+ board_page.expect_card("Open version", "Closed", present: true)
+ board_page.expect_card("Closed version", "Closed", present: false)
# Expect work package to be saved in query second
sleep 2
queries = board_page.board(reload: true).contained_queries
- open = queries.find_by(name: 'Open version')
- closed = queries.find_by(name: 'Closed version')
+ open = queries.find_by(name: "Open version")
+ closed = queries.find_by(name: "Closed version")
retry_block do
expect(open.reload.ordered_work_packages.count).to eq(2)
@@ -288,21 +288,21 @@ def create_new_version_board
expect(closed_version_wp.version_id).to eq(open_version.id)
# But we can not move back to closed
- board_page.move_card(0, from: 'Open version', to: 'Closed version')
- board_page.expect_card('Open version', 'Closed', present: true)
- board_page.expect_card('Closed version', 'Closed', present: false)
- board_page.expect_card('Closed version', 'Foo', present: false)
+ board_page.move_card(0, from: "Open version", to: "Closed version")
+ board_page.expect_card("Open version", "Closed", present: true)
+ board_page.expect_card("Closed version", "Closed", present: false)
+ board_page.expect_card("Closed version", "Foo", present: false)
# We can reference the work package back
- board_page.reference('A second version', work_package)
+ board_page.reference("A second version", work_package)
- board_page.expect_card('A second version', 'Foo', present: true)
- board_page.expect_card('Open version', 'Foo', present: false)
- board_page.expect_card('Closed version', 'Foo', present: false)
+ board_page.expect_card("A second version", "Foo", present: true)
+ board_page.expect_card("Open version", "Foo", present: false)
+ board_page.expect_card("Closed version", "Foo", present: false)
end
end
- context 'when user has edit_work_packages, but missing assign_versions permissions' do
+ context "when user has edit_work_packages, but missing assign_versions permissions" do
let(:no_version_edit_user) do
create(:user, member_with_roles: { project => no_version_edit_role })
end
@@ -312,7 +312,7 @@ def create_new_version_board
edit_work_packages view_work_packages manage_public_queries]
end
- it 'can not move cards or add cards' do
+ it "can not move cards or add cards" do
# Create version board first
login_as user
board_page = create_new_version_board
@@ -329,17 +329,17 @@ def create_new_version_board
end
end
- context 'with limited permissions' do
+ context "with limited permissions" do
before do
login_as(second_user)
end
- it 'does not allow to create new versions from within the board' do
+ it "does not allow to create new versions from within the board" do
board_page = create_new_version_board
- board_page.open_and_fill_add_list_modal 'Completely new version'
+ board_page.open_and_fill_add_list_modal "Completely new version"
- expect(page).to have_no_css('.ng-option', text: 'Completely new version')
+ expect(page).to have_no_css(".ng-option", text: "Completely new version")
end
end
end
diff --git a/modules/boards/spec/features/board_conflicts_spec.rb b/modules/boards/spec/features/board_conflicts_spec.rb
index a97d4e391762..2ffd0208f189 100644
--- a/modules/boards/spec/features/board_conflicts_spec.rb
+++ b/modules/boards/spec/features/board_conflicts_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'support/board_index_page'
-require_relative 'support/board_page'
+require "spec_helper"
+require_relative "support/board_index_page"
+require_relative "support/board_page"
-RSpec.describe 'Board remote changes resolution', :js, with_ee: %i[board_view] do
+RSpec.describe "Board remote changes resolution", :js, with_ee: %i[board_view] do
let(:user1) do
create(:user,
member_with_roles: { project => role })
@@ -47,28 +47,28 @@
end
let!(:priority) { create(:default_priority) }
- let!(:open_status) { create(:default_status, name: 'Open') }
- let!(:work_package1) { create(:work_package, project:, subject: 'Work package A', status: open_status) }
- let!(:work_package2) { create(:work_package, project:, subject: 'Work package B', status: open_status) }
+ let!(:open_status) { create(:default_status, name: "Open") }
+ let!(:work_package1) { create(:work_package, project:, subject: "Work package A", status: open_status) }
+ let!(:work_package2) { create(:work_package, project:, subject: "Work package B", status: open_status) }
before do
project
login_as(user1)
end
- it 'update boards in the background' do
+ it "update boards in the background" do
board_index.visit!
# Create new board
- board_page = board_index.create_board action: 'Status'
+ board_page = board_index.create_board action: "Status"
# expect lists of default status
- board_page.expect_list 'Open'
+ board_page.expect_list "Open"
- board_page.expect_card('Open', work_package1.subject)
- board_page.expect_card('Open', work_package2.subject)
+ board_page.expect_card("Open", work_package1.subject)
+ board_page.expect_card("Open", work_package2.subject)
- board_page.expect_cards_in_order('Open', work_package1, work_package2)
+ board_page.expect_cards_in_order("Open", work_package1, work_package2)
board_query = Query.last
board_query.ordered_work_packages.replace [
@@ -80,6 +80,6 @@
sleep(3)
- board_page.expect_cards_in_order('Open', work_package2, work_package1)
+ board_page.expect_cards_in_order("Open", work_package2, work_package1)
end
end
diff --git a/modules/boards/spec/features/board_enterprise_spec.rb b/modules/boards/spec/features/board_enterprise_spec.rb
index dd8d4b15a80f..38f07ed1975f 100644
--- a/modules/boards/spec/features/board_enterprise_spec.rb
+++ b/modules/boards/spec/features/board_enterprise_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'support/board_index_page'
-require_relative 'support/board_page'
+require "spec_helper"
+require_relative "support/board_index_page"
+require_relative "support/board_page"
-RSpec.describe 'Boards enterprise spec', :js, :with_cuprite do
+RSpec.describe "Boards enterprise spec", :js, :with_cuprite do
shared_let(:admin) { create(:admin) }
shared_let(:project) { create(:project, enabled_module_names: %i[work_package_tracking board_view]) }
@@ -39,68 +39,68 @@
let(:board_index) { Pages::BoardIndex.new(project) }
- shared_let(:manual_board) { create(:board_grid_with_query, name: 'My board', project:) }
+ shared_let(:manual_board) { create(:board_grid_with_query, name: "My board", project:) }
shared_let(:action_board) do
create(:subproject_board,
- name: 'Subproject board',
+ name: "Subproject board",
project:,
projects_columns: [])
end
- context 'when EE inactive' do
+ context "when EE inactive" do
before do
login_as(admin)
board_index.visit!
end
- it 'disabled all action boards' do
- page.find('.toolbar-item a', text: 'Board').click
+ it "disabled all action boards" do
+ page.find(".toolbar-item a", text: "Board").click
- expect(page).to have_css("#{test_selector('op-tile-block')}:not(.-disabled)", text: 'Basic')
+ expect(page).to have_css("#{test_selector('op-tile-block')}:not(.-disabled)", text: "Basic")
expect(page).to have_css("#{test_selector('op-tile-block')}.-disabled", count: 5)
end
- it 'shows a banner on the action board' do
+ it "shows a banner on the action board" do
# Expect both existing boards to show
- expect(page).to have_content 'My board'
- expect(page).to have_content 'Subproject board'
+ expect(page).to have_content "My board"
+ expect(page).to have_content "Subproject board"
board_page = board_index.open_board(manual_board)
- board_page.expect_query 'My board'
- expect(page).not_to have_test_selector 'op-enterprise-banner'
+ board_page.expect_query "My board"
+ expect(page).not_to have_test_selector "op-enterprise-banner"
board_index.visit!
board_page = board_index.open_board(action_board)
- board_page.expect_query 'Subproject board'
- expect(page).to have_test_selector 'op-enterprise-banner'
+ board_page.expect_query "Subproject board"
+ expect(page).to have_test_selector "op-enterprise-banner"
end
end
- context 'when EE active', with_ee: %i[board_view] do
+ context "when EE active", with_ee: %i[board_view] do
before do
login_as(admin)
board_index.visit!
end
- it 'enables all options' do
- page.find('.toolbar-item a', text: 'Board').click
+ it "enables all options" do
+ page.find(".toolbar-item a", text: "Board").click
expect(page).to have_css("#{test_selector('op-tile-block')}:not(.-disabled)", count: 6)
end
- it 'shows the action board' do
+ it "shows the action board" do
# Expect both existing boards to show
- expect(page).to have_content 'My board'
- expect(page).to have_content 'Subproject board'
+ expect(page).to have_content "My board"
+ expect(page).to have_content "Subproject board"
board_page = board_index.open_board(manual_board)
- board_page.expect_query 'My board'
- expect(page).not_to have_test_selector 'op-enterprise-banner'
+ board_page.expect_query "My board"
+ expect(page).not_to have_test_selector "op-enterprise-banner"
board_index.visit!
board_page = board_index.open_board(action_board)
- board_page.expect_query 'Subproject board'
- expect(page).not_to have_test_selector 'op-enterprise-banner'
+ board_page.expect_query "Subproject board"
+ expect(page).not_to have_test_selector "op-enterprise-banner"
end
end
end
diff --git a/modules/boards/spec/features/board_highlighting_spec.rb b/modules/boards/spec/features/board_highlighting_spec.rb
index 2c144beb40f8..24d6d2ba0976 100644
--- a/modules/boards/spec/features/board_highlighting_spec.rb
+++ b/modules/boards/spec/features/board_highlighting_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'support/board_index_page'
-require_relative 'support/board_page'
+require "spec_helper"
+require_relative "support/board_index_page"
+require_relative "support/board_page"
-RSpec.describe 'Work Package boards spec', :js, with_ee: %i[board_view] do
+RSpec.describe "Work Package boards spec", :js, with_ee: %i[board_view] do
let(:user) do
create(:user,
member_with_roles: { project => role })
@@ -58,7 +58,7 @@
let!(:priority2) { create(:priority, color: color2) }
let!(:type) { create(:type, color:) }
let!(:type2) { create(:type, color: color2) }
- let!(:open_status) { create(:default_status, name: 'Open') }
+ let!(:open_status) { create(:default_status, name: "Open") }
let(:board_index) { Pages::BoardIndex.new(project) }
@@ -70,32 +70,32 @@
login_as(user)
end
- it 'navigates from boards to the WP full view and back' do
+ it "navigates from boards to the WP full view and back" do
board_index.visit!
- board_page = board_index.create_board action: 'Status'
+ board_page = board_index.create_board action: "Status"
# See the work packages
- board_page.expect_query 'Open', editable: false
- board_page.expect_card 'Open', wp.subject
- board_page.expect_card 'Open', wp2.subject
+ board_page.expect_query "Open", editable: false
+ board_page.expect_card "Open", wp.subject
+ board_page.expect_card "Open", wp2.subject
# Highlight type inline is always active
expect(page).to have_css(".__hl_inline_type_#{type.id}")
expect(page).to have_css(".__hl_inline_type_#{type2.id}")
# Highlight whole card by priority
- board_page.change_board_highlighting 'inline', 'Priority'
+ board_page.change_board_highlighting "inline", "Priority"
expect(page).to have_css(".__hl_background_priority_#{priority.id}")
expect(page).to have_css(".__hl_background_priority_#{priority2.id}")
# Highlight whole card by type
- board_page.change_board_highlighting 'inline', 'Type'
+ board_page.change_board_highlighting "inline", "Type"
expect(page).to have_css(".__hl_background_type_#{type.id}")
expect(page).to have_css(".__hl_background_type_#{type2.id}")
# Disable highlighting
- board_page.change_board_highlighting 'none'
+ board_page.change_board_highlighting "none"
expect(page).to have_no_css(".__hl_background_type_#{type.id}")
expect(page).to have_no_css(".__hl_background_type_#{type2.id}")
diff --git a/modules/boards/spec/features/board_index_spec.rb b/modules/boards/spec/features/board_index_spec.rb
index 06edd75b75ac..ea7ad0850470 100644
--- a/modules/boards/spec/features/board_index_spec.rb
+++ b/modules/boards/spec/features/board_index_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'support/board_index_page'
+require "spec_helper"
+require_relative "support/board_index_page"
-RSpec.describe 'Work Package Project Boards Index Page',
+RSpec.describe "Work Package Project Boards Index Page",
:with_cuprite,
with_ee: %i[board_view] do
# The identifier is important to test https://community.openproject.com/wp/29754
- shared_let(:project) { create(:project, identifier: 'boards', enabled_module_names: %i[work_package_tracking board_view]) }
+ shared_let(:project) { create(:project, identifier: "boards", enabled_module_names: %i[work_package_tracking board_view]) }
shared_let(:management_role) do
create(:project_role,
@@ -75,92 +75,92 @@
board_index.visit!
end
- describe 'create button' do
- context 'as a user with board management permissions' do
+ describe "create button" do
+ context "as a user with board management permissions" do
let(:current_user) { user_with_full_permissions }
- it 'is shown' do
+ it "is shown" do
board_index.expect_create_button
end
end
- context 'as a user with view only permissions' do
+ context "as a user with view only permissions" do
let(:current_user) { user_with_limited_permissions }
- it 'is shown' do
+ it "is shown" do
board_index.expect_no_create_button
end
end
end
- context 'when no boards exist' do
- it 'displays the empty message' do
+ context "when no boards exist" do
+ it "displays the empty message" do
board_index.expect_no_boards_listed
end
end
- context 'when boards exist' do
+ context "when boards exist" do
shared_let(:board_view) do
- create(:board_grid_with_query, name: 'My board', project:)
+ create(:board_grid_with_query, name: "My board", project:)
end
shared_let(:other_board_view) do
- create(:board_grid_with_query, name: 'My other board', project:)
+ create(:board_grid_with_query, name: "My other board", project:)
end
- it 'lists the boards' do
+ it "lists the boards" do
board_index.expect_boards_listed(board_view,
other_board_view)
end
- describe 'delete links' do
- context 'as a project member with board management permissions' do
+ describe "delete links" do
+ context "as a project member with board management permissions" do
let(:current_user) { user_with_full_permissions }
- it 'renders delete links for each board' do
+ it "renders delete links for each board" do
board_index.expect_delete_buttons(board_view,
other_board_view)
end
end
- context 'as a project member with view only permissions' do
+ context "as a project member with view only permissions" do
let(:current_user) { user_with_limited_permissions }
- it 'does not render delete links' do
+ it "does not render delete links" do
board_index.expect_no_delete_buttons(board_view,
other_board_view)
end
end
end
- describe 'sorting' do
+ describe "sorting" do
it 'allows sorting by "Name" and "Created on"' do
# Initial sort is Name ASC
# We can assert this behavior by expected the order to be
# 1. board_view
# 2. other_board_view
# upon page load
- aggregate_failures 'Sorting by Name' do
+ aggregate_failures "Sorting by Name" do
board_index.expect_boards_listed_in_order(board_view,
other_board_view)
- board_index.click_to_sort_by('Name')
+ board_index.click_to_sort_by("Name")
board_index.expect_boards_listed_in_order(other_board_view,
board_view)
end
- aggregate_failures 'Sorting by Created on' do
- board_index.click_to_sort_by('Created on')
+ aggregate_failures "Sorting by Created on" do
+ board_index.click_to_sort_by("Created on")
board_index.expect_boards_listed_in_order(board_view,
other_board_view)
- board_index.click_to_sort_by('Created on')
+ board_index.click_to_sort_by("Created on")
board_index.expect_boards_listed_in_order(other_board_view,
board_view)
end
end
end
- it 'paginates results', with_settings: { per_page_options: '1' } do
+ it "paginates results", with_settings: { per_page_options: "1" } do
# First page displays the historically last meeting
board_index.expect_boards_listed(board_view)
board_index.expect_boards_not_listed(other_board_view)
diff --git a/modules/boards/spec/features/board_management_spec.rb b/modules/boards/spec/features/board_management_spec.rb
index 159f30b89551..8491dc7299c1 100644
--- a/modules/boards/spec/features/board_management_spec.rb
+++ b/modules/boards/spec/features/board_management_spec.rb
@@ -26,18 +26,18 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'support/board_index_page'
-require_relative 'support/board_page'
+require "spec_helper"
+require_relative "support/board_index_page"
+require_relative "support/board_page"
-RSpec.describe 'Board management spec', :js, with_ee: %i[board_view] do
+RSpec.describe "Board management spec", :js, with_ee: %i[board_view] do
let(:user) do
create(:user,
member_with_roles: { project => role })
end
let(:project) { create(:project, enabled_module_names: %i[work_package_tracking board_view]) }
let(:role) { create(:project_role, permissions:) }
- let!(:work_package) { create(:work_package, subject: 'Foo', project:) }
+ let!(:work_package) { create(:work_package, subject: "Foo", project:) }
let(:board_index) { Pages::BoardIndex.new(project) }
let(:filters) { Components::WorkPackages::Filters.new }
@@ -50,7 +50,7 @@
login_as(user)
end
- context 'with full boards permissions' do
+ context "with full boards permissions" do
let(:permissions) do
%i[
show_board_views
@@ -63,51 +63,51 @@
end
let(:board_view) { create(:board_grid_with_query, project:) }
- it 'allows parallel creation of cards (Regression #30842)' do
+ it "allows parallel creation of cards (Regression #30842)" do
board_view
board_index.visit!
board_page = board_index.open_board board_view
board_page.add_list
- board_page.rename_list 'Unnamed list', 'List 2'
+ board_page.rename_list "Unnamed list", "List 2"
# Open in list 1
- board_page.within_list('List 1') do
- page.find_test_selector('op-board-list--card-dropdown-add-button').click
+ board_page.within_list("List 1") do
+ page.find_test_selector("op-board-list--card-dropdown-add-button").click
end
- page.find('.menu-item', text: 'Add new card').click
+ page.find(".menu-item", text: "Add new card").click
# Open in list 2
- board_page.within_list('List 2') do
- page.find_test_selector('op-board-list--card-dropdown-add-button').click
+ board_page.within_list("List 2") do
+ page.find_test_selector("op-board-list--card-dropdown-add-button").click
end
- page.find('.menu-item', text: 'Add new card').click
+ page.find(".menu-item", text: "Add new card").click
- board_page.within_list('List 2') do
- subject = page.find_by_id('wp-new-inline-edit--field-subject')
- subject.set 'New card 1'
+ board_page.within_list("List 2") do
+ subject = page.find_by_id("wp-new-inline-edit--field-subject")
+ subject.set "New card 1"
subject.send_keys :enter
end
- board_page.within_list('List 1') do
- subject = page.find_by_id('wp-new-inline-edit--field-subject')
- subject.set 'New card 2'
+ board_page.within_list("List 1") do
+ subject = page.find_by_id("wp-new-inline-edit--field-subject")
+ subject.set "New card 2"
subject.send_keys :enter
end
- board_page.expect_card('List 1', 'New card 2')
- board_page.expect_card('List 2', 'New card 1')
+ board_page.expect_card("List 1", "New card 2")
+ board_page.expect_card("List 2", "New card 1")
end
- it 'allows management of boards' do
+ it "allows management of boards" do
board_view
board_index.visit!
board_page = board_index.open_board board_view
- board_page.expect_query 'List 1', editable: true
+ board_page.expect_query "List 1", editable: true
board_page.expect_editable_board true
board_page.expect_editable_list true
board_page.back_to_index
@@ -116,41 +116,41 @@
# Create new board
board_page = board_index.create_board
- board_page.rename_board 'Board test'
+ board_page.rename_board "Board test"
# Rename through toolbar
- board_page.rename_board 'Board foo', through_dropdown: true
+ board_page.rename_board "Board foo", through_dropdown: true
- board_page.rename_list 'Unnamed list', 'First'
+ board_page.rename_list "Unnamed list", "First"
board_page.board(reload: true) do |board|
- expect(board.name).to eq 'Board foo'
+ expect(board.name).to eq "Board foo"
queries = board.contained_queries
expect(queries.count).to eq(1)
- expect(queries.first.name).to eq 'First'
+ expect(queries.first.name).to eq "First"
end
# Create new list
board_page.add_list
- board_page.rename_list 'Unnamed list', 'Second'
+ board_page.rename_list "Unnamed list", "Second"
# Add item
- board_page.add_card 'First', 'Task 1'
+ board_page.add_card "First", "Task 1"
# Expect added to query
queries = board_page.board(reload: true).contained_queries
- first = queries.find_by(name: 'First')
- second = queries.find_by(name: 'Second')
+ first = queries.find_by(name: "First")
+ second = queries.find_by(name: "Second")
expect(first.ordered_work_packages.count).to eq(1)
expect(second.ordered_work_packages).to be_empty
# Expect work package to be saved in query first
subjects = WorkPackage.where(id: first.ordered_work_packages.pluck(:work_package_id)).pluck(:subject)
- expect(subjects).to contain_exactly('Task 1')
+ expect(subjects).to contain_exactly("Task 1")
# Move item to Second list
- board_page.move_card(0, from: 'First', to: 'Second')
- board_page.expect_card('First', 'Task 1', present: false)
- board_page.expect_card('Second', 'Task 1', present: true)
+ board_page.move_card(0, from: "First", to: "Second")
+ board_page.expect_card("First", "Task 1", present: false)
+ board_page.expect_card("Second", "Task 1", present: true)
# Expect work package to be saved in query second
sleep 2
@@ -160,90 +160,90 @@
end
subjects = WorkPackage.where(id: second.ordered_work_packages.pluck(:work_package_id)).pluck(:subject)
- expect(subjects).to contain_exactly('Task 1')
+ expect(subjects).to contain_exactly("Task 1")
# Reference an existing work package
- board_page.reference('Second', work_package)
+ board_page.reference("Second", work_package)
sleep 2
- board_page.expect_card('Second', work_package.subject)
+ board_page.expect_card("Second", work_package.subject)
subjects = WorkPackage.where(id: second.ordered_work_packages.pluck(:work_package_id)).pluck(:subject)
- expect(subjects).to contain_exactly(work_package.subject, 'Task 1')
+ expect(subjects).to contain_exactly(work_package.subject, "Task 1")
# Filter for Task
filters.expect_filter_count 0
filters.open
- filters.quick_filter 'Task'
+ filters.quick_filter "Task"
sleep 2
# Expect task to match, work_package invisible
- board_page.expect_card('First', 'Task 1', present: false)
- board_page.expect_card('Second', 'Task 1', present: true)
- board_page.expect_card('Second', work_package.subject, present: false)
+ board_page.expect_card("First", "Task 1", present: false)
+ board_page.expect_card("Second", "Task 1", present: true)
+ board_page.expect_card("Second", work_package.subject, present: false)
- filters.quick_filter ''
+ filters.quick_filter ""
sleep 2
# Remove card again
- board_page.remove_card 'Second', work_package.subject, 0
+ board_page.remove_card "Second", work_package.subject, 0
# Remove query
- board_page.remove_list 'Second'
+ board_page.remove_list "Second"
queries = board_page.board(reload: true).contained_queries
expect(queries.count).to eq(1)
- expect(queries.first.name).to eq 'First'
+ expect(queries.first.name).to eq "First"
expect(queries.first.ordered_work_packages.to_a).to be_empty
# Remove first list
- board_page.remove_list 'First'
+ board_page.remove_list "First"
board_page.expect_empty
# Remove entire board
board_page.delete_board
- board_index.expect_board 'Board foo', present: false
+ board_index.expect_board "Board foo", present: false
end
- it 'allows creating a new project board form via the sidebar' do
+ it "allows creating a new project board form via the sidebar" do
board_index.visit!
- board_page = board_index.create_board title: 'My Board created via the sidebar',
+ board_page = board_index.create_board title: "My Board created via the sidebar",
via_toolbar: false
board_page.board(reload: true) do |board|
- expect(board.name).to eq 'My Board created via the sidebar'
+ expect(board.name).to eq "My Board created via the sidebar"
queries = board.contained_queries
expect(queries.count).to eq(1)
- expect(queries.first.name).to eq 'Unnamed list'
+ expect(queries.first.name).to eq "Unnamed list"
end
end
- it 'allows renaming the board with an error in between (regression #51851)' do
+ it "allows renaming the board with an error in between (regression #51851)" do
board_view
board_index.visit!
board_page = board_index.open_board board_view
- board_page.expect_query 'List 1', editable: true
+ board_page.expect_query "List 1", editable: true
board_page.expect_editable_board true
board_page.expect_editable_list true
# Leave the toolbar name empty
- board_page.rename_via_toolbar ''
+ board_page.rename_via_toolbar ""
board_page.expect_toast message: "Name #{I18n.t('activerecord.errors.messages.blank')}", type: :error
# I can immediately enter the correct name
- board_page.rename_board 'My new name'
+ board_page.rename_board "My new name"
end
end
- context 'with view boards + work package permission' do
+ context "with view boards + work package permission" do
let(:permissions) { %i[show_board_views view_work_packages] }
let(:board_view) { create(:board_grid_with_query, project:) }
- it 'allows viewing boards index and boards' do
+ it "allows viewing boards index and boards" do
board_view
board_index.visit!
board_page = board_index.open_board board_view
- board_page.expect_query 'List 1', editable: false
+ board_page.expect_query "List 1", editable: false
board_page.expect_editable_board false
board_page.expect_editable_list false
@@ -253,40 +253,40 @@
end
end
- context 'with view boards + edit work package and change work package status permissions' do
+ context "with view boards + edit work package and change work package status permissions" do
let(:permissions) { %i[show_board_views view_work_packages add_work_packages edit_work_packages] }
let(:board_view) { create(:board_grid_with_queries, project:) }
- it 'allows viewing boards index and moving items around' do
+ it "allows viewing boards index and moving items around" do
board_view
board_index.visit!
board_page = board_index.open_board board_view
- board_page.expect_query 'List 1', editable: false
- board_page.expect_query 'List 2', editable: false
+ board_page.expect_query "List 1", editable: false
+ board_page.expect_query "List 2", editable: false
board_page.expect_editable_board false
board_page.expect_editable_list true
# Add item
- board_page.add_card 'List 1', 'Task 1'
+ board_page.add_card "List 1", "Task 1"
board_page.expect_and_dismiss_toaster(message: "Successful creation.")
# Move item to Second list
- board_page.move_card(0, from: 'List 1', to: 'List 2')
- board_page.expect_card('List 1', 'Task 1', present: false)
- board_page.expect_card('List 2', 'Task 1', present: true)
+ board_page.move_card(0, from: "List 1", to: "List 2")
+ board_page.expect_card("List 1", "Task 1", present: false)
+ board_page.expect_card("List 2", "Task 1", present: true)
# Expect added to query
queries = board_page.board(reload: true).contained_queries
- first = queries.find_by(name: 'List 1')
- second = queries.find_by(name: 'List 2')
+ first = queries.find_by(name: "List 1")
+ second = queries.find_by(name: "List 2")
wait_for(first.ordered_work_packages).to be_empty
expect(second.ordered_work_packages.count).to eq(1)
# Expect work package to be saved in query first
subjects = WorkPackage.where(id: second.ordered_work_packages.pluck(:work_package_id)).pluck(:subject)
- expect(subjects).to contain_exactly('Task 1')
+ expect(subjects).to contain_exactly("Task 1")
board_page.back_to_index
@@ -294,24 +294,24 @@
end
end
- context 'with view permission only' do
+ context "with view permission only" do
let(:permissions) { %i[show_board_views] }
let(:board_view) { create(:board_grid_with_queries, project:) }
- it 'does not allow viewing of boards' do
+ it "does not allow viewing of boards" do
visit project_work_package_board_path(project, board_view)
- expect(page).to have_css('#errorExplanation', text: I18n.t(:notice_not_authorized))
+ expect(page).to have_css("#errorExplanation", text: I18n.t(:notice_not_authorized))
board_index.expect_editable false
end
end
- context 'with no permission only' do
+ context "with no permission only" do
let(:permissions) { %i[] }
- it 'does not allow viewing of boards' do
+ it "does not allow viewing of boards" do
board_index.visit!
- expect(page).to have_css('#errorExplanation', text: I18n.t(:notice_not_authorized))
+ expect(page).to have_css("#errorExplanation", text: I18n.t(:notice_not_authorized))
end
end
end
diff --git a/modules/boards/spec/features/board_navigation_spec.rb b/modules/boards/spec/features/board_navigation_spec.rb
index b636dc75dc62..b251b0bab8b4 100644
--- a/modules/boards/spec/features/board_navigation_spec.rb
+++ b/modules/boards/spec/features/board_navigation_spec.rb
@@ -26,24 +26,24 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'support/board_index_page'
-require_relative 'support/board_page'
+require "spec_helper"
+require_relative "support/board_index_page"
+require_relative "support/board_page"
-RSpec.describe 'Work Package boards spec', :js, with_ee: %i[board_view] do
+RSpec.describe "Work Package boards spec", :js, with_ee: %i[board_view] do
let(:user) do
create(:user,
member_with_roles: { project => role })
end
# The identifier is important to test https://community.openproject.com/wp/29754
- let(:project) { create(:project, identifier: 'boards', enabled_module_names: %i[work_package_tracking board_view]) }
+ let(:project) { create(:project, identifier: "boards", enabled_module_names: %i[work_package_tracking board_view]) }
let(:permissions) { %i[show_board_views manage_board_views add_work_packages view_work_packages manage_public_queries] }
let(:role) { create(:project_role, permissions:) }
let(:admin) { create(:admin) }
let!(:priority) { create(:default_priority) }
let!(:status) { create(:default_status) }
let(:board_index) { Pages::BoardIndex.new(project) }
- let!(:board_view) { create(:board_grid_with_query, name: 'My board', project:) }
+ let!(:board_view) { create(:board_grid_with_query, name: "My board", project:) }
let(:project_html_title) { Components::HtmlTitle.new project }
let(:destroy_modal) { Components::WorkPackages::DestroyModal.new }
@@ -54,25 +54,25 @@
login_as(admin)
end
- it 'navigates from boards to the WP full view and back' do
+ it "navigates from boards to the WP full view and back" do
board_index.visit!
# Add a new WP on the board
board_page = board_index.open_board board_view
- board_page.expect_query 'List 1', editable: true
- board_page.add_card 'List 1', 'Task 1'
+ board_page.expect_query "List 1", editable: true
+ board_page.add_card "List 1", "Task 1"
board_page.expect_toast message: I18n.t(:notice_successful_create)
wp = WorkPackage.last
- expect(wp.subject).to eq 'Task 1'
+ expect(wp.subject).to eq "Task 1"
# Double click leads to the full view
- click_target = page.find_test_selector('op-wp-single-card--content-type')
+ click_target = page.find_test_selector("op-wp-single-card--content-type")
page.driver.browser.action.double_click(click_target.native).perform
- expect(page).to have_current_path project_work_package_path(project, wp.id, 'activity')
+ expect(page).to have_current_path project_work_package_path(project, wp.id, "activity")
# Click back goes back to the board
- find('.work-packages-back-button').click
+ find(".work-packages-back-button").click
expect(page).to have_current_path project_work_package_board_path(project, board_view)
# Open the details page with the info icon
@@ -84,11 +84,11 @@
card.expect_selected
# Add a second card, focus on that
- board_page.add_card 'List 1', 'Foobar'
+ board_page.add_card "List 1", "Foobar"
board_page.expect_toast message: I18n.t(:notice_successful_create)
wp = WorkPackage.last
- expect(wp.subject).to eq 'Foobar'
+ expect(wp.subject).to eq "Foobar"
card = board_page.card_for(wp)
# Click on the card
@@ -96,7 +96,7 @@
expect(page).to have_current_path /details\/#{wp.id}\/overview/
end
- it 'navigates correctly the path from overview page to the boards page',
+ it "navigates correctly the path from overview page to the boards page",
# The polling interval is only lowered as the sidemenu relies on Angular's change
# detection to be updated. This is a bug.
# In reality, it does not really matter as the user will always move the mouse or do
@@ -105,60 +105,60 @@
visit project_path(project)
item = page.find('#menu-sidebar li[data-name="boards"]', wait: 10)
- item.find('.toggler').click
+ item.find(".toggler").click
- subitem = page.find_test_selector('op-sidemenu--item-action--Myboard', wait: 10)
+ subitem = page.find_test_selector("op-sidemenu--item-action--Myboard", wait: 10)
# Ends with boards due to lazy route
expect(subitem[:href]).to end_with project_work_package_boards_path(project)
subitem.click
board_page = Pages::Board.new board_view
- board_page.expect_query 'List 1', editable: true
- board_page.add_card 'List 1', 'Task 1'
+ board_page.expect_query "List 1", editable: true
+ board_page.add_card "List 1", "Task 1"
end
- it 'navigates from boards to the WP details view then go to full view then go back (see #33747)' do
+ it "navigates from boards to the WP details view then go to full view then go back (see #33747)" do
board_index.visit!
# Add a new WP on the board
board_page = board_index.open_board board_view
- board_page.expect_query 'List 1', editable: true
- board_page.add_card 'List 1', 'Task 1'
+ board_page.expect_query "List 1", editable: true
+ board_page.add_card "List 1", "Task 1"
board_page.expect_toast message: I18n.t(:notice_successful_create)
wp = WorkPackage.last
- expect(wp.subject).to eq 'Task 1'
+ expect(wp.subject).to eq "Task 1"
# Open the details page with the info icon
card = board_page.card_for(wp)
split_view = card.open_details_view
split_view.ensure_page_loaded
split_view.expect_subject
- split_view.switch_to_tab tab: 'Relations'
+ split_view.switch_to_tab tab: "Relations"
# Go to full view of WP
full_view = split_view.switch_to_fullscreen
- full_view.expect_tab 'Relations'
+ full_view.expect_tab "Relations"
# Go back to details view with selected tab
full_view.go_back
split_view.expect_subject
expect(page).to have_current_path /details\/#{wp.id}\/relations/
- split_view.expect_tab 'Relations'
+ split_view.expect_tab "Relations"
end
- it 'navigates to the details view and reloads (see #49678)' do
+ it "navigates to the details view and reloads (see #49678)" do
board_index.visit!
# Add a new WP on the board
board_page = board_index.open_board board_view
- board_page.expect_query 'List 1', editable: true
- board_page.add_card 'List 1', 'Task 1'
+ board_page.expect_query "List 1", editable: true
+ board_page.add_card "List 1", "Task 1"
board_page.expect_toast message: I18n.t(:notice_successful_create)
wp = WorkPackage.last
- expect(wp.subject).to eq 'Task 1'
+ expect(wp.subject).to eq "Task 1"
# Open the details page with the info icon
card = board_page.card_for(wp)
split_view = card.open_details_view
@@ -171,16 +171,16 @@
split_view.expect_subject
end
- it 'navigates to boards after deleting WP(see #33756)' do
+ it "navigates to boards after deleting WP(see #33756)" do
board_index.visit!
# Add a new WP on the board
board_page = board_index.open_board board_view
- board_page.expect_query 'List 1', editable: true
- board_page.add_card 'List 1', 'Task 1'
+ board_page.expect_query "List 1", editable: true
+ board_page.add_card "List 1", "Task 1"
board_page.expect_toast message: I18n.t(:notice_successful_create)
wp = WorkPackage.last
- expect(wp.subject).to eq 'Task 1'
+ expect(wp.subject).to eq "Task 1"
# Open the details page with the info icon
card = board_page.card_for(wp)
@@ -189,8 +189,8 @@
# Go to full view of WP
split_view.switch_to_fullscreen
- find_by_id('action-show-more-dropdown-menu').click
- click_link(I18n.t('js.button_delete'))
+ find_by_id("action-show-more-dropdown-menu").click
+ click_link(I18n.t("js.button_delete"))
# Delete the WP
destroy_modal.expect_listed(wp)
diff --git a/modules/boards/spec/features/board_overview_spec.rb b/modules/boards/spec/features/board_overview_spec.rb
index 2fa458568bc8..1adbac98090e 100644
--- a/modules/boards/spec/features/board_overview_spec.rb
+++ b/modules/boards/spec/features/board_overview_spec.rb
@@ -26,22 +26,22 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'support/board_overview_page'
+require "spec_helper"
+require_relative "support/board_overview_page"
-RSpec.describe 'Work Package Boards Overview',
+RSpec.describe "Work Package Boards Overview",
:with_cuprite,
with_ee: %i[board_view] do
# The identifier is important to test https://community.openproject.com/wp/29754
shared_let(:project) do
create(:project,
- name: 'Project 2',
- identifier: 'boards',
+ name: "Project 2",
+ identifier: "boards",
enabled_module_names: %i[work_package_tracking board_view])
end
shared_let(:other_project) do
create(:project,
- name: 'Project 1',
+ name: "Project 1",
enabled_module_names: %i[work_package_tracking board_view])
end
@@ -91,77 +91,77 @@
board_overview.visit!
end
- it 'renders the global menu with its item selected' do
+ it "renders the global menu with its item selected" do
board_overview.expect_global_menu_item_selected
end
- describe 'create button' do
- context 'as a user with board management permissions' do
+ describe "create button" do
+ context "as a user with board management permissions" do
let(:current_user) { user_with_full_permissions }
- it 'is shown' do
+ it "is shown" do
board_overview.expect_create_button
end
end
- context 'as a user with view only permissions' do
+ context "as a user with view only permissions" do
let(:current_user) { user_with_limited_permissions }
- it 'is shown' do
+ it "is shown" do
board_overview.expect_no_create_button
end
end
end
- context 'when no boards exist' do
- it 'displays the empty message' do
+ context "when no boards exist" do
+ it "displays the empty message" do
board_overview.expect_no_boards_listed
end
end
- context 'when boards exist' do
+ context "when boards exist" do
shared_let(:board_view) do
create(:board_grid_with_query,
- name: 'My board',
+ name: "My board",
project:)
end
shared_let(:other_board_view) do
create(:board_grid_with_query,
- name: 'My other board',
+ name: "My other board",
project:)
end
shared_let(:other_project_board_view) do
create(:board_grid_with_query,
- name: 'Other Project Board',
+ name: "Other Project Board",
project: other_project)
end
- context 'as an admin' do
+ context "as an admin" do
let(:current_user) { admin }
- it 'lists all boards' do
+ it "lists all boards" do
board_overview.expect_boards_listed(board_view,
other_board_view,
other_project_board_view)
end
end
- context 'as a project member' do
+ context "as a project member" do
let(:current_user) { user_with_full_permissions }
- it 'lists the boards' do
+ it "lists the boards" do
board_overview.expect_boards_listed(board_view, other_board_view)
board_overview.expect_boards_not_listed(other_project_board_view)
end
end
- it 'does not render delete links' do
+ it "does not render delete links" do
board_overview.expect_no_delete_buttons(board_view,
other_board_view,
other_project_board_view)
end
- describe 'sorting' do
+ describe "sorting" do
it 'allows sorting by "Name", "Project" and "Created on"' do
# Initial sort is Name ASC
# We can assert this behavior by expected the order to be
@@ -169,19 +169,19 @@
# 2. other_board_view
# 3. other_project_board_view
# upon page load
- aggregate_failures 'Sorting by Name' do
+ aggregate_failures "Sorting by Name" do
board_overview.expect_boards_listed_in_order(board_view,
other_board_view,
other_project_board_view)
- board_overview.click_to_sort_by('Name')
+ board_overview.click_to_sort_by("Name")
board_overview.expect_boards_listed_in_order(other_project_board_view,
other_board_view,
board_view)
end
- aggregate_failures 'Sorting by Project' do
- board_overview.click_to_sort_by('Project')
+ aggregate_failures "Sorting by Project" do
+ board_overview.click_to_sort_by("Project")
# Sorting is performed on multiple columns at a time, taking into account
# previous sorting criteria and using the latest clicked column as
# the first column in the +ORDER BY+ clause and previously sorted by columns after.
@@ -195,19 +195,19 @@
board_overview.expect_boards_listed_in_order(other_project_board_view,
other_board_view,
board_view)
- board_overview.click_to_sort_by('Project')
+ board_overview.click_to_sort_by("Project")
board_overview.expect_boards_listed_in_order(other_board_view,
board_view,
other_project_board_view)
end
- aggregate_failures 'Sorting by Created on' do
- board_overview.click_to_sort_by('Created on')
+ aggregate_failures "Sorting by Created on" do
+ board_overview.click_to_sort_by("Created on")
board_overview.expect_boards_listed_in_order(board_view,
other_board_view,
other_project_board_view)
- board_overview.click_to_sort_by('Created on')
+ board_overview.click_to_sort_by("Created on")
board_overview.expect_boards_listed_in_order(other_project_board_view,
other_board_view,
board_view)
@@ -215,7 +215,7 @@
end
end
- it 'paginates results', with_settings: { per_page_options: '1' } do
+ it "paginates results", with_settings: { per_page_options: "1" } do
# First page displays the historically last meeting
board_overview.expect_boards_listed(board_view)
board_overview.expect_boards_not_listed(other_board_view,
diff --git a/modules/boards/spec/features/board_reference_work_package_spec.rb b/modules/boards/spec/features/board_reference_work_package_spec.rb
index de469248ac17..23a1e18d94e8 100644
--- a/modules/boards/spec/features/board_reference_work_package_spec.rb
+++ b/modules/boards/spec/features/board_reference_work_package_spec.rb
@@ -26,18 +26,18 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'support/board_index_page'
-require_relative 'support/board_page'
+require "spec_helper"
+require_relative "support/board_index_page"
+require_relative "support/board_page"
-RSpec.describe 'Board reference work package spec', :js, with_ee: %i[board_view] do
+RSpec.describe "Board reference work package spec", :js, with_ee: %i[board_view] do
let(:user) do
create(:user,
member_with_roles: { project => role })
end
let(:project) { create(:project, enabled_module_names: %i[work_package_tracking board_view]) }
let(:role) { create(:project_role, permissions:) }
- let!(:work_package) { create(:work_package, version:, subject: 'Foo', project:) }
+ let!(:work_package) { create(:work_package, version:, subject: "Foo", project:) }
let(:board_index) { Pages::BoardIndex.new(project) }
let(:filters) { Components::WorkPackages::Filters.new }
@@ -57,33 +57,33 @@
let!(:priority) { create(:default_priority) }
let!(:status) { create(:default_status) }
- let!(:version) { create(:version, name: 'Foo version', project:) }
+ let!(:version) { create(:version, name: "Foo version", project:) }
before do
project
login_as(user)
end
- it 'allows referencing with filters (Regression #29966)' do
+ it "allows referencing with filters (Regression #29966)" do
board_view
board_index.visit!
# Create new board
board_page = board_index.create_board
- board_page.rename_list 'Unnamed list', 'First'
+ board_page.rename_list "Unnamed list", "First"
# Filter for Version
filters.open
- filters.add_filter_by('Version', 'is (OR)', version.name)
+ filters.add_filter_by("Version", "is (OR)", version.name)
sleep 2
# Reference an existing work package
- board_page.reference('First', work_package)
+ board_page.reference("First", work_package)
sleep 2
- board_page.expect_card('First', work_package.subject)
+ board_page.expect_card("First", work_package.subject)
queries = board_page.board(reload: true).contained_queries
- first = queries.find_by(name: 'First')
+ first = queries.find_by(name: "First")
ids = first.ordered_work_packages.pluck(:work_package_id)
expect(ids).to contain_exactly(work_package.id)
@@ -92,39 +92,39 @@
expect(work_package.version_id).to eq version.id
end
- context 'with a subproject and work packages within it (Regression #31613)' do
+ context "with a subproject and work packages within it (Regression #31613)" do
let!(:child_project) { create(:project, parent: project) }
- let!(:work_package) { create(:work_package, subject: 'WP SUB', project: child_project) }
+ let!(:work_package) { create(:work_package, subject: "WP SUB", project: child_project) }
let(:user) do
create(:user, member_with_roles: { project => role, child_project => role })
end
- it 'returns the work package when subproject filters is added' do
+ it "returns the work package when subproject filters is added" do
board_view
board_index.visit!
# Create new board
board_page = board_index.create_board
- board_page.rename_list 'Unnamed list', 'First'
+ board_page.rename_list "Unnamed list", "First"
# Reference an existing work package
- board_page.expect_not_referencable('First', work_package)
+ board_page.expect_not_referencable("First", work_package)
sleep 2
- board_page.expect_card('First', work_package.subject, present: false)
+ board_page.expect_card("First", work_package.subject, present: false)
# Add subproject filter
filters.open
- filters.add_filter_by('subproject', 'is not empty', nil, 'subprojectId')
+ filters.add_filter_by("subproject", "is not empty", nil, "subprojectId")
sleep 2
# Reference an existing work package
- board_page.reference('First', work_package)
+ board_page.reference("First", work_package)
sleep 2
- board_page.expect_card('First', work_package.subject)
+ board_page.expect_card("First", work_package.subject)
queries = board_page.board(reload: true).contained_queries
- first = queries.find_by(name: 'First')
+ first = queries.find_by(name: "First")
ids = first.ordered_work_packages.pluck(:work_package_id)
expect(ids).to contain_exactly(work_package.id)
diff --git a/modules/boards/spec/features/board_update_spec.rb b/modules/boards/spec/features/board_update_spec.rb
index 78a6e8d7cf49..a1caaaa2e818 100644
--- a/modules/boards/spec/features/board_update_spec.rb
+++ b/modules/boards/spec/features/board_update_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'support/board_index_page'
-require_relative 'support/board_page'
+require "spec_helper"
+require_relative "support/board_index_page"
+require_relative "support/board_page"
-RSpec.describe 'Work Package boards updating spec', :js, with_ee: %i[board_view] do
+RSpec.describe "Work Package boards updating spec", :js, with_ee: %i[board_view] do
let(:admin) { create(:admin) }
let(:project) { create(:project, enabled_module_names: %i[work_package_tracking board_view]) }
@@ -38,7 +38,7 @@
let!(:status) { create(:default_status) }
let(:board_index) { Pages::BoardIndex.new(project) }
- let!(:board_view) { create(:board_grid_with_query, name: 'My board', project:) }
+ let!(:board_view) { create(:board_grid_with_query, name: "My board", project:) }
before do
project
@@ -46,22 +46,22 @@
board_index.visit!
end
- it 'Changing the title in the split screen, updates the card automatically' do
+ it "Changing the title in the split screen, updates the card automatically" do
board_page = board_index.open_board board_view
- board_page.expect_query 'List 1', editable: true
- board_page.add_card 'List 1', 'Foo Bar'
+ board_page.expect_query "List 1", editable: true
+ board_page.add_card "List 1", "Foo Bar"
board_page.expect_toast message: I18n.t(:notice_successful_create)
work_package = WorkPackage.last
- expect(work_package.subject).to eq 'Foo Bar'
+ expect(work_package.subject).to eq "Foo Bar"
# Open in split view
card = board_page.card_for(work_package)
split_view = card.open_details_view
split_view.expect_subject
- split_view.edit_field(:subject).update('My super cool new title')
+ split_view.edit_field(:subject).update("My super cool new title")
- split_view.expect_and_dismiss_toaster message: 'Successful update.'
- card.expect_subject 'My super cool new title'
+ split_view.expect_and_dismiss_toaster message: "Successful update."
+ card.expect_subject "My super cool new title"
end
end
diff --git a/modules/boards/spec/features/boards_global_create_spec.rb b/modules/boards/spec/features/boards_global_create_spec.rb
index f2d1cd747f07..53b4ec505576 100644
--- a/modules/boards/spec/features/boards_global_create_spec.rb
+++ b/modules/boards/spec/features/boards_global_create_spec.rb
@@ -1,10 +1,10 @@
# frozen_string_literal: true
-require 'spec_helper'
-require_relative 'support/board_new_page'
+require "spec_helper"
+require_relative "support/board_new_page"
-RSpec.describe 'Boards',
- 'Creating a view from a Global Context',
+RSpec.describe "Boards",
+ "Creating a view from a Global Context",
:js,
:with_cuprite,
with_ee: %i[board_view] do
@@ -16,8 +16,8 @@
shared_let(:versions) { create_list(:version, 3, project:) }
shared_let(:excluded_versions) do
[
- create(:version, project:, status: 'closed'),
- create(:version, project: other_project, sharing: 'system')
+ create(:version, project:, status: "closed"),
+ create(:version, project: other_project, sharing: "system")
]
end
@@ -27,32 +27,32 @@
login_as admin
end
- context 'within the global index page' do
+ context "within the global index page" do
before do
visit work_package_boards_path
end
- context 'when clicking on the create button' do
+ context "when clicking on the create button" do
before do
new_board_page.navigate_by_create_button
end
- it 'navigates to the global create form' do
+ it "navigates to the global create form" do
expect(page).to have_current_path new_work_package_board_path
- expect(page).to have_content I18n.t('boards.label_create_new_board')
+ expect(page).to have_content I18n.t("boards.label_create_new_board")
end
end
end
- context 'within the global create page' do
+ context "within the global create page" do
before do
new_board_page.visit!
end
- context 'with a Community Edition', with_ee: %i[] do
- it 'renders an enterprise banner and disables all restriced board types', :aggregate_failures do
- expect(page).to have_css('op-enterprise-banner')
- expect(page).to have_selector(:radio_button, 'Basic')
+ context "with a Community Edition", with_ee: %i[] do
+ it "renders an enterprise banner and disables all restriced board types", :aggregate_failures do
+ expect(page).to have_css("op-enterprise-banner")
+ expect(page).to have_selector(:radio_button, "Basic")
%w[Status Assignee Version Subproject Parent-child].each do |restricted_board_type|
expect(page).to have_selector(:radio_button, restricted_board_type, disabled: true)
@@ -60,8 +60,8 @@
end
end
- context 'with an Enterprise Edition' do
- context 'with all fields set' do
+ context "with an Enterprise Edition" do
+ context "with all fields set" do
before do
wait_for_reload # Halt until the project autocompleter is ready
@@ -71,13 +71,13 @@
context 'when creating a "Basic" board' do
before do
- new_board_page.set_board_type 'Basic'
+ new_board_page.set_board_type "Basic"
new_board_page.click_on_submit
wait_for_reload
end
- it 'creates the board and redirects me to it' do
+ it "creates the board and redirects me to it" do
expect(page).to have_text(I18n.t(:notice_successful_create))
expect(page).to have_current_path("/projects/#{project.identifier}/boards/#{Boards::Grid.last.id}")
expect(page).to have_text "Gotham Renewal Board"
@@ -86,13 +86,13 @@
context 'when creating a "Status" board' do
before do
- new_board_page.set_board_type 'Status'
+ new_board_page.set_board_type "Status"
new_board_page.click_on_submit
wait_for_reload
end
- it 'creates the board and redirects me to it' do
+ it "creates the board and redirects me to it" do
expect(page).to have_text(I18n.t(:notice_successful_create))
expect(page).to have_current_path("/projects/#{project.identifier}/boards/#{Boards::Grid.last.id}")
expect(page).to have_text "Gotham Renewal Board"
@@ -102,13 +102,13 @@
context 'when creating an "Assignee" board' do
before do
- new_board_page.set_board_type 'Assignee'
+ new_board_page.set_board_type "Assignee"
new_board_page.click_on_submit
wait_for_reload
end
- it 'creates the board and redirects me to it' do
+ it "creates the board and redirects me to it" do
expect(page).to have_text(I18n.t(:notice_successful_create))
expect(page).to have_current_path("/projects/#{project.identifier}/boards/#{Boards::Grid.last.id}")
expect(page).to have_text "Gotham Renewal Board"
@@ -117,13 +117,13 @@
context 'when creating a "Version" board' do
before do
- new_board_page.set_board_type 'Version'
+ new_board_page.set_board_type "Version"
new_board_page.click_on_submit
wait_for_reload
end
- it 'creates the board and redirects me to it', :aggregate_failures do
+ it "creates the board and redirects me to it", :aggregate_failures do
expect(page).to have_text(I18n.t(:notice_successful_create))
expect(page).to have_current_path("/projects/#{project.identifier}/boards/#{Boards::Grid.last.id}")
expect(page).to have_text "Gotham Renewal Board"
@@ -138,13 +138,13 @@
context 'when creating a "Subproject" board' do
before do
- new_board_page.set_board_type 'Subproject'
+ new_board_page.set_board_type "Subproject"
new_board_page.click_on_submit
wait_for_reload
end
- it 'creates the board and redirects me to it' do
+ it "creates the board and redirects me to it" do
expect(page).to have_text(I18n.t(:notice_successful_create))
expect(page).to have_current_path("/projects/#{project.identifier}/boards/#{Boards::Grid.last.id}")
expect(page).to have_text "Gotham Renewal Board"
@@ -153,13 +153,13 @@
context 'when creating a "Parent-child" board' do
before do
- new_board_page.set_board_type 'Parent-child'
+ new_board_page.set_board_type "Parent-child"
new_board_page.click_on_submit
wait_for_reload
end
- it 'creates the board and redirects me to it' do
+ it "creates the board and redirects me to it" do
expect(page).to have_text(I18n.t(:notice_successful_create))
expect(page).to have_current_path("/projects/#{project.identifier}/boards/#{Boards::Grid.last.id}")
expect(page).to have_text "Gotham Renewal Board"
@@ -167,8 +167,8 @@
end
end
- context 'when missing a required field' do
- describe 'title' do
+ context "when missing a required field" do
+ describe "title" do
before do
wait_for_reload # Halt until the project autocompleter is ready
@@ -176,7 +176,7 @@
new_board_page.click_on_submit
end
- it 'renders a required attribute validation error' do
+ it "renders a required attribute validation error" do
expect(Boards::Grid.all).to be_empty
# Required HTML attribute just warns
@@ -184,7 +184,7 @@
end
end
- describe 'project_id' do
+ describe "project_id" do
before do
new_board_page.set_title("Batman's Itinerary")
new_board_page.click_on_submit
@@ -192,7 +192,7 @@
wait_for_reload
end
- it 'renders a required attribute validation error' do
+ it "renders a required attribute validation error" do
expect(Boards::Grid.all).to be_empty
new_board_page.expect_toast message: "Project #{I18n.t('activerecord.errors.messages.blank')}",
@@ -203,13 +203,13 @@
end
end
- describe 'cancel button' do
+ describe "cancel button" do
context "when it's clicked" do
before do
new_board_page.click_on_cancel_button
end
- it 'navigates back to the global index page' do
+ it "navigates back to the global index page" do
expect(page).to have_current_path(work_package_boards_path)
end
end
diff --git a/modules/boards/spec/features/boards_sorting_spec.rb b/modules/boards/spec/features/boards_sorting_spec.rb
index 9ece629182e8..75fbf14b38b4 100644
--- a/modules/boards/spec/features/boards_sorting_spec.rb
+++ b/modules/boards/spec/features/boards_sorting_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'support/board_index_page'
-require_relative 'support/board_page'
+require "spec_helper"
+require_relative "support/board_index_page"
+require_relative "support/board_page"
-RSpec.describe 'Work Package boards sorting spec', :js, with_ee: %i[board_view] do
+RSpec.describe "Work Package boards sorting spec", :js, with_ee: %i[board_view] do
let(:admin) { create(:admin) }
let(:project) { create(:project, enabled_module_names: %i[work_package_tracking board_view]) }
let(:board_index) { Pages::BoardIndex.new(project) }
@@ -46,28 +46,28 @@
# By adding each board the sort of table will change
# The currently added board should be at the top
- it 'sorts the boards grid and menu based on their names' do
- board_page = board_index.create_board title: 'My Basic Board'
+ it "sorts the boards grid and menu based on their names" do
+ board_page = board_index.create_board title: "My Basic Board"
board_page.back_to_index
- board_index.expect_boards_listed 'My Basic Board'
- query_menu.expect_menu_entry 'My Basic Board'
+ board_index.expect_boards_listed "My Basic Board"
+ query_menu.expect_menu_entry "My Basic Board"
- board_page = board_index.create_board title: 'My Action Board',
- action: 'Version',
+ board_page = board_index.create_board title: "My Action Board",
+ action: "Version",
expect_empty: true
board_page.back_to_index
- board_index.expect_boards_listed 'My Action Board',
- 'My Basic Board'
- query_menu.expect_menu_entry 'My Action Board'
+ board_index.expect_boards_listed "My Action Board",
+ "My Basic Board"
+ query_menu.expect_menu_entry "My Action Board"
- board_page = board_index.create_board title: 'My Status Board',
- action: 'Status'
+ board_page = board_index.create_board title: "My Status Board",
+ action: "Status"
board_page.back_to_index
- board_index.expect_boards_listed 'My Status Board',
- 'My Action Board',
- 'My Basic Board'
- query_menu.expect_menu_entry 'My Status Board'
+ board_index.expect_boards_listed "My Status Board",
+ "My Action Board",
+ "My Basic Board"
+ query_menu.expect_menu_entry "My Status Board"
end
end
diff --git a/modules/boards/spec/features/menu_items/global_menu_item_spec.rb b/modules/boards/spec/features/menu_items/global_menu_item_spec.rb
index 422333c35bcc..03323da73ebd 100644
--- a/modules/boards/spec/features/menu_items/global_menu_item_spec.rb
+++ b/modules/boards/spec/features/menu_items/global_menu_item_spec.rb
@@ -29,21 +29,21 @@
# ++
#
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Global menu item for boards', :js, :with_cuprite do
- let(:boards_label) { I18n.t('boards.label_boards') }
+RSpec.describe "Global menu item for boards", :js, :with_cuprite do
+ let(:boards_label) { I18n.t("boards.label_boards") }
before do
login_as current_user
visit root_path
end
- context 'with permissions' do
+ context "with permissions" do
let(:current_user) { create(:admin) }
it "sends the user to the boards overview when clicked" do
- within '#main-menu' do
+ within "#main-menu" do
click_on boards_label
end
@@ -53,11 +53,11 @@
end
end
- context 'without permissions' do
+ context "without permissions" do
let(:current_user) { create(:user) }
- it 'is not rendered' do
- within '#main-menu' do
+ it "is not rendered" do
+ within "#main-menu" do
expect(page).to have_no_content(boards_label)
end
end
diff --git a/modules/boards/spec/features/menu_items/top_menu_item_spec.rb b/modules/boards/spec/features/menu_items/top_menu_item_spec.rb
index a85b0c38c478..45a15304f0e1 100644
--- a/modules/boards/spec/features/menu_items/top_menu_item_spec.rb
+++ b/modules/boards/spec/features/menu_items/top_menu_item_spec.rb
@@ -26,23 +26,23 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Top menu item for boards', :js, :with_cuprite do
+RSpec.describe "Top menu item for boards", :js, :with_cuprite do
let(:user) { create(:admin) }
let(:menu) { find(".op-app-menu a[title='#{I18n.t('label_modules')}']") }
- let(:boards) { I18n.t('boards.label_boards') }
+ let(:boards) { I18n.t("boards.label_boards") }
before do
allow(User).to receive(:current).and_return user
end
- shared_examples_for 'the boards menu item' do
+ shared_examples_for "the boards menu item" do
it "sends the user to the boards overview when clicked" do
menu.click
- within '#more-menu' do
+ within "#more-menu" do
click_on boards
end
@@ -51,28 +51,28 @@
end
end
- context 'when in the project settings' do
+ context "when in the project settings" do
let!(:project) { create(:project) }
before do
visit "/projects/#{project.identifier}/settings/general"
end
- it_behaves_like 'the boards menu item'
+ it_behaves_like "the boards menu item"
end
- context 'on the landing page' do
+ context "on the landing page" do
before do
visit root_path
end
- it_behaves_like 'the boards menu item'
+ it_behaves_like "the boards menu item"
- context 'with missing permissions' do
+ context "with missing permissions" do
let(:user) { create(:user) }
it "does not display the menu item" do
- within '#more-menu', visible: false do
+ within "#more-menu", visible: false do
expect(page).to have_no_link boards
end
end
diff --git a/modules/boards/spec/features/onboarding/boards_onboarding_tour_spec.rb b/modules/boards/spec/features/onboarding/boards_onboarding_tour_spec.rb
index 04c8bd051089..d7c152c9e8d5 100644
--- a/modules/boards/spec/features/onboarding/boards_onboarding_tour_spec.rb
+++ b/modules/boards/spec/features/onboarding/boards_onboarding_tour_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../support/onboarding_steps'
+require "spec_helper"
+require_relative "../support/onboarding_steps"
# We decrease the notification polling interval because some portions of the JS code rely on something triggering
# the Angular change detection. This is usually done by the notification polling, but we don't want to wait
-RSpec.describe 'boards onboarding tour',
+RSpec.describe "boards onboarding tour",
:js,
with_settings: { notifications_polling_interval: 1_000 } do
- let(:next_button) { find('.enjoyhint_next_btn') }
+ let(:next_button) { find(".enjoyhint_next_btn") }
let(:user) do
create(:admin,
member_with_roles: { demo_project => role })
@@ -53,15 +53,15 @@
let(:demo_project) do
create(:project,
- name: 'Demo project',
- identifier: 'demo-project',
+ name: "Demo project",
+ identifier: "demo-project",
public: true,
enabled_module_names: %w[work_package_tracking gantt wiki board_view])
end
let!(:wp_1) { create(:work_package, project: demo_project) }
- let!(:demo_board_view) { create(:board_grid_with_query, project: demo_project, name: 'Kanban', query:) }
- let!(:demo_basic_board_view) { create(:board_grid_with_query, project: demo_project, name: 'Basic board', query:) }
+ let!(:demo_board_view) { create(:board_grid_with_query, project: demo_project, name: "Kanban", query:) }
+ let!(:demo_basic_board_view) { create(:board_grid_with_query, project: demo_project, name: "Basic board", query:) }
let(:query) { create(:query, user:, project: demo_project) }
before do
@@ -75,13 +75,13 @@
page.execute_script("window.sessionStorage.clear();")
end
- context 'as a new user' do
- context 'with an EE token', with_ee: %i[board_view] do
+ context "as a new user" do
+ context "with an EE token", with_ee: %i[board_view] do
before do
login_as user
end
- it 'I see the board onboarding tour in the demo project' do
+ it "I see the board onboarding tour in the demo project" do
# Set the tour parameter so that we can start on the wp page
visit "/projects/#{demo_project.identifier}/work_packages?start_onboarding_tour=true"
@@ -93,12 +93,12 @@
end
end
- context 'without an EE token' do
+ context "without an EE token" do
before do
login_as user
end
- it 'I see the board onboarding tour in the demo project' do
+ it "I see the board onboarding tour in the demo project" do
# Set the tour parameter so that we can start on the wp page
visit "/projects/#{demo_project.identifier}/work_packages?start_onboarding_tour=true"
diff --git a/modules/boards/spec/features/support/board_index_page.rb b/modules/boards/spec/features/support/board_index_page.rb
index 3bc10cbd10f1..0b266b4f2472 100644
--- a/modules/boards/spec/features/support/board_index_page.rb
+++ b/modules/boards/spec/features/support/board_index_page.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'support/pages/page'
-require_relative 'board_list_page'
-require_relative 'board_new_page'
+require "support/pages/page"
+require_relative "board_list_page"
+require_relative "board_new_page"
module Pages
class BoardIndex < BoardListPage
@@ -48,19 +48,19 @@ def visit!
def expect_editable(editable)
# Editable / draggable check
- expect(page).to have_conditional_selector(editable, '.buttons a.icon-delete')
+ expect(page).to have_conditional_selector(editable, ".buttons a.icon-delete")
# Create button
- expect(page).to have_conditional_selector(editable, '.toolbar-item a', text: 'Board')
+ expect(page).to have_conditional_selector(editable, ".toolbar-item a", text: "Board")
end
def expect_board(name, present: true)
- expect(page).to have_conditional_selector(present, 'td.name', text: name)
+ expect(page).to have_conditional_selector(present, "td.name", text: name)
end
- def create_board(action: 'Basic', title: "#{action} Board", expect_empty: false, via_toolbar: true)
+ def create_board(action: "Basic", title: "#{action} Board", expect_empty: false, via_toolbar: true)
if via_toolbar
- within '.toolbar-items' do
- click_link 'Board'
+ within ".toolbar-items" do
+ click_link "Board"
end
else
find('[data-test-selector="sidebar--create-board-button"]').click
@@ -73,17 +73,17 @@ def create_board(action: 'Basic', title: "#{action} Board", expect_empty: false,
new_board_page.click_on_submit
if expect_empty
- expect(page).to have_css('.boards-list--add-item-text', wait: 10)
- expect(page).to have_no_css('.boards-list--item')
+ expect(page).to have_css(".boards-list--add-item-text", wait: 10)
+ expect(page).to have_no_css(".boards-list--item")
else
- expect(page).to have_css('.boards-list--item', wait: 10)
+ expect(page).to have_css(".boards-list--item", wait: 10)
end
::Pages::Board.new ::Boards::Grid.last
end
def open_board(board)
- page.find('td.name a', text: board.name).click
+ page.find("td.name a", text: board.name).click
wait_for_reload if using_cuprite?
::Pages::Board.new board
end
diff --git a/modules/boards/spec/features/support/board_list_page.rb b/modules/boards/spec/features/support/board_list_page.rb
index 3696969947d9..8697798408dd 100644
--- a/modules/boards/spec/features/support/board_list_page.rb
+++ b/modules/boards/spec/features/support/board_list_page.rb
@@ -26,28 +26,28 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'support/pages/page'
+require "support/pages/page"
module Pages
class BoardListPage < Page
def visit!
- raise 'Define how to visit me'
+ raise "Define how to visit me"
end
def expect_create_button
- within '.toolbar-items' do
- expect(page).to have_link 'Board'
+ within ".toolbar-items" do
+ expect(page).to have_link "Board"
end
end
def expect_no_create_button
- within '.toolbar-items' do
- expect(page).to have_no_link 'Board'
+ within ".toolbar-items" do
+ expect(page).to have_no_link "Board"
end
end
def expect_delete_buttons(*boards)
- within '#content-wrapper' do
+ within "#content-wrapper" do
boards.each do |board|
expect(page).to have_css "[data-test-selector='board-remove-#{board.id}']"
end
@@ -55,7 +55,7 @@ def expect_delete_buttons(*boards)
end
def expect_no_delete_buttons(*boards)
- within '#content-wrapper' do
+ within "#content-wrapper" do
boards.each do |board|
expect(page).to have_no_css "[data-test-selector='board-remove-#{board.id}']"
end
@@ -65,7 +65,7 @@ def expect_no_delete_buttons(*boards)
def expect_boards_listed(*boards)
expected_board_names = board_names_for(boards)
- within '#content-wrapper' do
+ within "#content-wrapper" do
expected_board_names.each do |board_name|
expect(page).to have_css("td.name", text: board_name)
end
@@ -73,7 +73,7 @@ def expect_boards_listed(*boards)
end
def expect_boards_listed_in_order(*boards)
- within '#content-wrapper' do
+ within "#content-wrapper" do
listed_board_names = all("td.name").map(&:text)
expect_board_names = board_names_for(boards)
@@ -84,7 +84,7 @@ def expect_boards_listed_in_order(*boards)
def expect_boards_not_listed(*boards)
unexpected_board_names = board_names_for(boards)
- within '#content-wrapper' do
+ within "#content-wrapper" do
unexpected_board_names.each do |board_name|
expect(page).to have_no_css("td.title", text: board_name)
end
@@ -96,17 +96,17 @@ def board_names_for(boards)
end
def expect_no_boards_listed
- within '#content-wrapper' do
+ within "#content-wrapper" do
expect(page).to have_content I18n.t(:no_results_title_text)
end
end
def expect_to_be_on_page(number)
- expect(page).to have_css('.op-pagination--item_current', text: number)
+ expect(page).to have_css(".op-pagination--item_current", text: number)
end
def to_page(number)
- within '.op-pagination--pages' do
+ within ".op-pagination--pages" do
click_link number.to_s
end
end
diff --git a/modules/boards/spec/features/support/board_new_page.rb b/modules/boards/spec/features/support/board_new_page.rb
index a581e484c1e7..e31ddd472ff3 100644
--- a/modules/boards/spec/features/support/board_new_page.rb
+++ b/modules/boards/spec/features/support/board_new_page.rb
@@ -1,6 +1,6 @@
# frozen_string_literal: true
-require 'support/pages/page'
+require "support/pages/page"
module Pages
class NewBoard < Page
@@ -13,8 +13,8 @@ def visit!
def navigate_by_create_button
visit work_package_boards_path unless page.current_path == work_package_boards_path
- within '.toolbar-items' do
- click_link 'Board'
+ within ".toolbar-items" do
+ click_link "Board"
end
end
@@ -29,7 +29,7 @@ def expect_project_dropdown
def set_project(project)
select_autocomplete(find('[data-test-selector="project_id"]'),
query: project,
- results_selector: 'body',
+ results_selector: "body",
wait_for_fetched_options: false)
end
@@ -42,7 +42,7 @@ def click_on_submit
end
def click_on_cancel_button
- click_on 'Cancel'
+ click_on "Cancel"
end
end
end
diff --git a/modules/boards/spec/features/support/board_overview_page.rb b/modules/boards/spec/features/support/board_overview_page.rb
index 7a71af131b98..e2523843f0c8 100644
--- a/modules/boards/spec/features/support/board_overview_page.rb
+++ b/modules/boards/spec/features/support/board_overview_page.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'support/pages/page'
-require_relative 'board_list_page'
+require "support/pages/page"
+require_relative "board_list_page"
module Pages
class BoardOverview < BoardListPage
@@ -36,8 +36,8 @@ def visit!
end
def expect_global_menu_item_selected
- within '#main-menu' do
- expect(page).to have_css('.selected', text: 'Boards')
+ within "#main-menu" do
+ expect(page).to have_css(".selected", text: "Boards")
end
end
end
diff --git a/modules/boards/spec/features/support/board_page.rb b/modules/boards/spec/features/support/board_page.rb
index 65a1bf746346..7df51b126912 100644
--- a/modules/boards/spec/features/support/board_page.rb
+++ b/modules/boards/spec/features/support/board_page.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'support/pages/page'
+require "support/pages/page"
module Pages
class Board < Page
@@ -51,7 +51,7 @@ def filters
end
def free?
- @board.options['type'] == 'free'
+ @board.options["type"] == "free"
end
def action?
@@ -63,7 +63,7 @@ def expect_path
end
def action_attribute
- @board.options['attribute']
+ @board.options["attribute"]
end
def list_count
@@ -84,9 +84,9 @@ def add_card(list_name, card_title)
end
# Add item in dropdown
- page.find('.menu-item', text: 'Add new card').click
+ page.find(".menu-item", text: "Add new card").click
- subject = page.find_by_id('wp-new-inline-edit--field-subject')
+ subject = page.find_by_id("wp-new-inline-edit--field-subject")
subject.set card_title
subject.send_keys :enter
@@ -108,11 +108,11 @@ def reference(list_name, work_package)
page.find('[data-test-selector="op-board-list--card-dropdown-add-button"]').click
end
- page.find('.menu-item', text: 'Add existing').click
+ page.find(".menu-item", text: "Add existing").click
- select_autocomplete(page.find('.wp-inline-create--reference-autocompleter'),
+ select_autocomplete(page.find(".wp-inline-create--reference-autocompleter"),
query: work_package.subject,
- results_selector: 'body',
+ results_selector: "body",
select_text: "##{work_package.id}")
expect_card(list_name, work_package.subject)
@@ -123,13 +123,13 @@ def expect_not_referencable(list_name, work_package)
page.find('[data-test-selector="op-board-list--card-dropdown-add-button"]').click
end
- page.find('.menu-item', text: 'Add existing').click
+ page.find(".menu-item", text: "Add existing").click
- target_dropdown = search_autocomplete(page.find('.wp-inline-create--reference-autocompleter'),
+ target_dropdown = search_autocomplete(page.find(".wp-inline-create--reference-autocompleter"),
query: work_package.subject,
- results_selector: '.work-packages-partitioned-query-space--container')
+ results_selector: ".work-packages-partitioned-query-space--container")
- expect(target_dropdown).to have_no_css('.ui-menu-item', text: work_package.subject)
+ expect(target_dropdown).to have_no_css(".ui-menu-item", text: work_package.subject)
end
##
@@ -187,8 +187,8 @@ def wait_for_lists_reload
# wait for reload of lists to start and finish
# Not sure if that's the most reliable way to do it, but there is nothing visible
# about the PATCH request being sent and executed successfully after moving a card.
- expect(page).to have_css('.op-loading-indicator', wait: 5)
- expect(page).to have_no_css('.op-loading-indicator')
+ expect(page).to have_css(".op-loading-indicator", wait: 5)
+ expect(page).to have_no_css(".op-loading-indicator")
end
def add_list(option: nil, query: option)
@@ -199,11 +199,11 @@ def add_list(option: nil, query: option)
count = list_count
if option.nil?
- page.find('.boards-list--add-item').click
+ page.find(".boards-list--add-item").click
expect(page).to have_css('[data-test-selector="op-board-list"]', count: count + 1)
else
open_and_fill_add_list_modal query
- page.find('.ng-option', text: option, wait: 10).click
+ page.find(".ng-option", text: option, wait: 10).click
page.find('[data-test-selector="confirmation-modal--confirmed"]').click
end
end
@@ -211,20 +211,20 @@ def add_list(option: nil, query: option)
def add_list_with_new_value(name)
open_and_fill_add_list_modal name
- page.find('.op-select-footer--label', text: "Create #{name}").click
+ page.find(".op-select-footer--label", text: "Create #{name}").click
end
def save
- page.find('.editable-toolbar-title--save').click
- expect_and_dismiss_toaster message: 'Successful update.'
+ page.find(".editable-toolbar-title--save").click
+ expect_and_dismiss_toaster message: "Successful update."
end
def expect_changed
- expect(page).to have_css('.editable-toolbar-title--save')
+ expect(page).to have_css(".editable-toolbar-title--save")
end
def expect_not_changed
- expect(page).to have_no_css('.editable-toolbar-title--save')
+ expect(page).to have_no_css(".editable-toolbar-title--save")
end
def expect_list(name)
@@ -236,14 +236,14 @@ def expect_no_list(name)
end
def expect_empty
- expect(page).to have_no_css('.boards-list--item', wait: 10)
+ expect(page).to have_no_css(".boards-list--item", wait: 10)
end
def remove_list(name)
- click_list_dropdown name, 'Delete list'
+ click_list_dropdown name, "Delete list"
accept_alert_dialog!
- expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
expect(page).to have_no_selector list_selector(name)
end
@@ -254,7 +254,7 @@ def click_list_dropdown(list_name, action)
page.find('[data-test-selector="op-board-list--menu"] a').click
end
- page.find('.dropdown-menu button', text: action).click
+ page.find(".dropdown-menu button", text: action).click
end
def card_for(work_package)
@@ -265,11 +265,11 @@ def expect_list_option(name, present: true)
open_and_fill_add_list_modal name
if present
- expect(page).to have_css('.ng-option', text: name)
+ expect(page).to have_css(".ng-option", text: name)
else
- expect(page).to have_no_css('.ng-option', text: name)
+ expect(page).to have_no_css(".ng-option", text: name)
end
- find('body').send_keys [:escape]
+ find("body").send_keys [:escape]
end
def visit!
@@ -281,24 +281,24 @@ def visit!
end
def delete_board
- click_dropdown_entry 'Delete'
+ click_dropdown_entry "Delete"
accept_alert_dialog!
- expect_and_dismiss_toaster message: I18n.t('js.notice_successful_delete')
+ expect_and_dismiss_toaster message: I18n.t("js.notice_successful_delete")
end
def back_to_index
- within '#main-menu' do
- click_link 'Boards'
+ within "#main-menu" do
+ click_link "Boards"
end
end
def expect_editable_board(editable)
# Settings dropdown
- expect(page).to have_conditional_selector(editable, '.board--settings-dropdown')
+ expect(page).to have_conditional_selector(editable, ".board--settings-dropdown")
# Add new list
- expect(page).to have_conditional_selector(editable, '.boards-list--add-item')
+ expect(page).to have_conditional_selector(editable, ".boards-list--add-item")
end
def expect_editable_list(editable)
@@ -307,79 +307,79 @@ def expect_editable_list(editable)
def rename_board(new_name, through_dropdown: false)
if through_dropdown
- click_dropdown_entry 'Rename view'
- expect(page).to have_focus_on('.toolbar-container .editable-toolbar-title--input')
- input = page.find('.toolbar-container .editable-toolbar-title--input')
+ click_dropdown_entry "Rename view"
+ expect(page).to have_focus_on(".toolbar-container .editable-toolbar-title--input")
+ input = page.find(".toolbar-container .editable-toolbar-title--input")
input.set new_name
input.send_keys :enter
else
rename_via_toolbar new_name
end
- expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
- page.within('.toolbar-container') do
- expect(page).to have_field('editable-toolbar-title', with: new_name)
+ page.within(".toolbar-container") do
+ expect(page).to have_field("editable-toolbar-title", with: new_name)
end
end
def rename_via_toolbar(new_name)
- page.within('.toolbar-container') do
- input = page.find('.editable-toolbar-title--input').click
+ page.within(".toolbar-container") do
+ input = page.find(".editable-toolbar-title--input").click
input.set new_name
input.send_keys :enter
end
end
def click_dropdown_entry(name)
- page.find('.board--settings-dropdown').click
- page.find('.menu-item', text: name).click
+ page.find(".board--settings-dropdown").click
+ page.find(".menu-item", text: name).click
end
def rename_list(from, to)
- input = page.find_field('editable-toolbar-title', with: from).click
+ input = page.find_field("editable-toolbar-title", with: from).click
input.set to
input.send_keys :enter
- expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
end
def expect_query(name, editable: true)
if editable
- expect(page).to have_field('editable-toolbar-title', with: name)
+ expect(page).to have_field("editable-toolbar-title", with: name)
else
- expect(page).to have_css('.editable-toolbar-title--fixed', text: name)
+ expect(page).to have_css(".editable-toolbar-title--fixed", text: name)
end
end
def change_board_highlighting(mode, attribute = nil)
- click_dropdown_entry 'Configure view'
+ click_dropdown_entry "Configure view"
if attribute.nil?
choose(option: mode)
else
- select attribute, from: 'selected_attribute'
+ select attribute, from: "selected_attribute"
end
- click_button 'Apply'
+ click_button "Apply"
end
def open_and_fill_add_list_modal(name)
open_add_list_modal
sleep(0.1)
- page.find('.spot-modal .new-list--action-select input').set(name)
- expect(page).to have_no_css('.ng-spinner-loader')
+ page.find(".spot-modal .new-list--action-select input").set(name)
+ expect(page).to have_no_css(".ng-spinner-loader")
end
def open_add_list_modal
- page.find('.boards-list--add-item').click
- expect(page).to have_css('.new-list--action-select input')
+ page.find(".boards-list--add-item").click
+ expect(page).to have_css(".new-list--action-select input")
end
def add_list_modal_shows_warning(value, with_link: false)
- within page.find('.spot-modal') do
- warning = '.op-toast.-warning'
- link = '.op-toast--content a'
+ within page.find(".spot-modal") do
+ warning = ".op-toast.-warning"
+ link = ".op-toast--content a"
expect(page).to (value ? have_selector(warning) : have_no_selector(warning))
expect(page).to (with_link ? have_selector(link) : have_no_selector(link))
diff --git a/modules/boards/spec/features/support/onboarding_steps.rb b/modules/boards/spec/features/support/onboarding_steps.rb
index 206b31b09f2c..966f81a43603 100644
--- a/modules/boards/spec/features/support/onboarding_steps.rb
+++ b/modules/boards/spec/features/support/onboarding_steps.rb
@@ -29,23 +29,23 @@
module OnboardingSteps
def step_through_onboarding_board_tour(with_ee_token: true)
next_button.click
- expect(page).to have_text sanitize_string(I18n.t('js.onboarding.steps.boards.overview')), normalize_ws: true
+ expect(page).to have_text sanitize_string(I18n.t("js.onboarding.steps.boards.overview")), normalize_ws: true
next_button.click
if with_ee_token
expect(page)
- .to have_text sanitize_string(I18n.t('js.onboarding.steps.boards.lists_kanban')), normalize_ws: true, wait: 20
+ .to have_text sanitize_string(I18n.t("js.onboarding.steps.boards.lists_kanban")), normalize_ws: true, wait: 20
else
expect(page)
- .to have_text sanitize_string(I18n.t('js.onboarding.steps.boards.lists_basic')), normalize_ws: true, wait: 20
+ .to have_text sanitize_string(I18n.t("js.onboarding.steps.boards.lists_basic")), normalize_ws: true, wait: 20
end
next_button.click
- expect(page).to have_text sanitize_string(I18n.t('js.onboarding.steps.boards.add')), normalize_ws: true
+ expect(page).to have_text sanitize_string(I18n.t("js.onboarding.steps.boards.add")), normalize_ws: true
next_button.click
expect(page)
- .to have_text sanitize_string(I18n.t('js.onboarding.steps.boards.drag')), normalize_ws: true
+ .to have_text sanitize_string(I18n.t("js.onboarding.steps.boards.drag")), normalize_ws: true
end
end
diff --git a/modules/boards/spec/lib/open_project/boards/grid_registration_spec.rb b/modules/boards/spec/lib/open_project/boards/grid_registration_spec.rb
index cc751396f291..6c22221da96f 100644
--- a/modules/boards/spec/lib/open_project/boards/grid_registration_spec.rb
+++ b/modules/boards/spec/lib/open_project/boards/grid_registration_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::Boards::GridRegistration do
let(:project) { create(:project) }
@@ -9,38 +9,38 @@
member_with_permissions: { project => permissions })
end
- describe 'from_scope' do
- subject { described_class.from_scope '/foobar/projects/bla/boards' }
+ describe "from_scope" do
+ subject { described_class.from_scope "/foobar/projects/bla/boards" }
- context 'with a relative URL root', with_config: { rails_relative_url_root: '/foobar' } do
- it 'maps that correctly' do
+ context "with a relative URL root", with_config: { rails_relative_url_root: "/foobar" } do
+ it "maps that correctly" do
expect(subject).to be_present
expect(subject[:class]).to eq(Boards::Grid)
end
end
end
- describe '.visible' do
- context 'when having the view_boards permission' do
- it 'returns the board' do
+ describe ".visible" do
+ context "when having the view_boards permission" do
+ it "returns the board" do
expect(described_class.visible(user))
.to match_array(board)
end
end
- context 'when having the manage_board_views permission' do
+ context "when having the manage_board_views permission" do
let(:permissions) { [:manage_board_views] }
- it 'returns the board' do
+ it "returns the board" do
expect(described_class.visible(user))
.to match_array(board)
end
end
- context 'when having neither of the permissions' do
+ context "when having neither of the permissions" do
let(:permissions) { [] }
- it 'returns the board' do
+ it "returns the board" do
expect(described_class.visible(user))
.to be_empty
end
diff --git a/modules/boards/spec/models/boards/grid_spec.rb b/modules/boards/spec/models/boards/grid_spec.rb
index 239edc14e09d..3402b355ff0d 100644
--- a/modules/boards/spec/models/boards/grid_spec.rb
+++ b/modules/boards/spec/models/boards/grid_spec.rb
@@ -26,60 +26,60 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Boards::Grid do
let(:instance) { described_class.new }
let(:project) { build_stubbed(:project) }
- describe 'attributes' do
- it '#project' do
+ describe "attributes" do
+ it "#project" do
instance.project = project
expect(instance.project)
.to eql project
end
- it '#name' do
+ it "#name" do
instance.name = nil
expect(instance).not_to be_valid
expect(instance.errors[:name]).to be_present
- instance.name = 'foo'
+ instance.name = "foo"
expect(instance).to be_valid
end
- describe '#board_type' do
- it 'extracts correct, symbolized type when it is stored as a symbol key' do
- instance.options[:type] = 'action'
+ describe "#board_type" do
+ it "extracts correct, symbolized type when it is stored as a symbol key" do
+ instance.options[:type] = "action"
expect(instance.board_type).to eq(:action)
end
- it 'extracts correct, symbolized type when it is stored as a string key' do
- instance.options['type'] = 'action'
+ it "extracts correct, symbolized type when it is stored as a string key" do
+ instance.options["type"] = "action"
expect(instance.board_type).to eq(:action)
end
- it 'defaults to :free type' do
+ it "defaults to :free type" do
instance.options = {}
expect(instance.board_type).to eq(:free)
end
end
- describe '#board_type_attribute' do
- it 'returns nil for a board that is not of type action' do
- instance.options = { type: 'free', attribute: 'status' }
+ describe "#board_type_attribute" do
+ it "returns nil for a board that is not of type action" do
+ instance.options = { type: "free", attribute: "status" }
expect(instance.board_type_attribute).to be_nil
end
- it 'returns attribute for a board that is of type action' do
- instance.options = { type: 'action', attribute: 'status' }
+ it "returns attribute for a board that is of type action" do
+ instance.options = { type: "action", attribute: "status" }
- expect(instance.board_type_attribute).to eq('status')
+ expect(instance.board_type_attribute).to eq("status")
end
end
end
diff --git a/modules/boards/spec/queries/grids/query_integration_spec.rb b/modules/boards/spec/queries/grids/query_integration_spec.rb
index 7c2463d6bb0b..133534761967 100644
--- a/modules/boards/spec/queries/grids/query_integration_spec.rb
+++ b/modules/boards/spec/queries/grids/query_integration_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Grids::Query, type: :model do
include OpenProject::StaticRouting::UrlHelpers
@@ -53,28 +53,28 @@
login_as(current_user)
end
- context 'without a filter' do
- describe '#results' do
- it 'is the same as getting all the boards visible to the user' do
+ context "without a filter" do
+ describe "#results" do
+ it "is the same as getting all the boards visible to the user" do
expect(instance.results).to contain_exactly(board_grid)
end
end
end
- context 'with a scope filter' do
- context 'filtering for a projects/:project_id/boards' do
+ context "with a scope filter" do
+ context "filtering for a projects/:project_id/boards" do
before do
- instance.where('scope', '=', [project_work_package_boards_path(project)])
+ instance.where("scope", "=", [project_work_package_boards_path(project)])
end
- describe '#results' do
- it 'yields boards assigned to the project' do
+ describe "#results" do
+ it "yields boards assigned to the project" do
expect(instance.results).to contain_exactly(board_grid)
end
end
- describe '#valid?' do
- it 'is true' do
+ describe "#valid?" do
+ it "is true" do
expect(instance).to be_valid
end
end
diff --git a/modules/boards/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb b/modules/boards/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb
index 1afb1a911ba9..2a57fa80c4d7 100644
--- a/modules/boards/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb
+++ b/modules/boards/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
RSpec.describe "POST /api/v3/grids/form for Board Grids", content_type: :json do
include Rack::Test::Methods
@@ -55,15 +55,15 @@
login_as(current_user)
end
- describe '#post' do
+ describe "#post" do
before do
- post path, params.to_json, 'CONTENT_TYPE' => 'application/json'
+ post path, params.to_json, "CONTENT_TYPE" => "application/json"
end
- context 'with a valid boards scope' do
+ context "with a valid boards scope" do
let(:params) do
{
- name: 'foo',
+ name: "foo",
_links: {
scope: {
href: project_work_package_boards_path(project)
@@ -72,12 +72,12 @@
}
end
- it 'contains default data in the payload' do
+ it "contains default data in the payload" do
expected = {
rowCount: 1,
columnCount: 4,
widgets: [],
- name: 'foo',
+ name: "foo",
options: {},
_links: {
attachments: [],
@@ -90,23 +90,23 @@
expect(subject.body)
.to be_json_eql(expected.to_json)
- .at_path('_embedded/payload')
+ .at_path("_embedded/payload")
end
- it 'has no validationErrors' do
+ it "has no validationErrors" do
expect(subject.body)
.to be_json_eql({}.to_json)
- .at_path('_embedded/validationErrors')
+ .at_path("_embedded/validationErrors")
end
- it 'has a commit link' do
+ it "has a commit link" do
expect(subject.body)
.to be_json_eql(api_v3_paths.grids.to_json)
- .at_path('_links/commit/href')
+ .at_path("_links/commit/href")
end
end
- context 'with boards scope for which the user does not have the necessary permissions' do
+ context "with boards scope for which the user does not have the necessary permissions" do
let(:current_user) { prohibited_user }
let(:params) do
{
@@ -118,14 +118,14 @@
}
end
- it 'has a validationError on scope' do
+ it "has a validationError on scope" do
expect(subject.body)
.to be_json_eql("Scope is not set to one of the allowed values.".to_json)
- .at_path('_embedded/validationErrors/scope/message')
+ .at_path("_embedded/validationErrors/scope/message")
end
end
- context 'with an invalid boards scope' do
+ context "with an invalid boards scope" do
let(:params) do
{
_links: {
@@ -136,17 +136,17 @@
}
end
- it 'has a validationError on scope' do
+ it "has a validationError on scope" do
expect(subject.body)
.to be_json_eql("Scope is not set to one of the allowed values.".to_json)
- .at_path('_embedded/validationErrors/scope/message')
+ .at_path("_embedded/validationErrors/scope/message")
end
end
- context 'with an unsupported widget identifier' do
+ context "with an unsupported widget identifier" do
let(:params) do
{
- name: 'foo',
+ name: "foo",
_links: {
attachments: [],
scope: {
@@ -167,10 +167,10 @@
}
end
- it 'has a validationError on widget' do
+ it "has a validationError on widget" do
expect(subject.body)
.to be_json_eql("Widgets is not set to one of the allowed values.".to_json)
- .at_path('_embedded/validationErrors/widgets/message')
+ .at_path("_embedded/validationErrors/widgets/message")
end
end
end
diff --git a/modules/boards/spec/requests/api/v3/grids/grids_resource_spec.rb b/modules/boards/spec/requests/api/v3/grids/grids_resource_spec.rb
index 55de32fde4c7..ffb44d632e81 100644
--- a/modules/boards/spec/requests/api/v3/grids/grids_resource_spec.rb
+++ b/modules/boards/spec/requests/api/v3/grids/grids_resource_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'API v3 Grids resource for Board Grids', content_type: :json do
+RSpec.describe "API v3 Grids resource for Board Grids", content_type: :json do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -63,7 +63,7 @@
subject(:response) { last_response }
- describe '#get INDEX' do
+ describe "#get INDEX" do
let(:path) { api_v3_paths.grids }
let(:stored_grids) do
@@ -77,63 +77,63 @@
get path
end
- it 'responds with 200 OK' do
+ it "responds with 200 OK" do
expect(subject.status).to eq(200)
end
- it 'sends a collection of grids but only those visible to the current user' do
+ it "sends a collection of grids but only those visible to the current user" do
expect(subject.body)
- .to be_json_eql('Collection'.to_json)
- .at_path('_type')
+ .to be_json_eql("Collection".to_json)
+ .at_path("_type")
expect(subject.body)
- .to be_json_eql('Grid'.to_json)
- .at_path('_embedded/elements/0/_type')
+ .to be_json_eql("Grid".to_json)
+ .at_path("_embedded/elements/0/_type")
expect(subject.body)
.to be_json_eql(1.to_json)
- .at_path('total')
+ .at_path("total")
end
- context 'with a filter on the scope attribute for all boards of a project' do
+ context "with a filter on the scope attribute for all boards of a project" do
# The user would be able to see both boards
shared_let(:other_role) { create(:project_role, permissions: [:show_board_views]) }
let(:path) do
- filter = [{ 'scope' =>
+ filter = [{ "scope" =>
{
- 'operator' => '=',
- 'values' => [project_work_package_boards_path(manage_board_views_project)]
+ "operator" => "=",
+ "values" => [project_work_package_boards_path(manage_board_views_project)]
} }]
"#{api_v3_paths.grids}?#{{ filters: filter.to_json }.to_query}"
end
- it 'responds with 200 OK' do
+ it "responds with 200 OK" do
expect(subject.status).to eq(200)
end
- it 'sends only the board of the project' do
+ it "sends only the board of the project" do
expect(subject.body)
- .to be_json_eql('Collection'.to_json)
- .at_path('_type')
+ .to be_json_eql("Collection".to_json)
+ .at_path("_type")
expect(subject.body)
- .to be_json_eql('Grid'.to_json)
- .at_path('_embedded/elements/0/_type')
+ .to be_json_eql("Grid".to_json)
+ .at_path("_embedded/elements/0/_type")
expect(subject.body)
.to be_json_eql(1.to_json)
- .at_path('total')
+ .at_path("total")
expect(subject.body)
.to be_json_eql(manage_board_views_grid.id.to_json)
- .at_path('_embedded/elements/0/id')
+ .at_path("_embedded/elements/0/id")
end
end
end
- describe '#get' do
+ describe "#get" do
let(:path) { api_v3_paths.grid(manage_board_views_grid.id) }
let(:stored_grids) do
@@ -146,53 +146,53 @@
get path
end
- it 'responds with 200 OK' do
+ it "responds with 200 OK" do
expect(subject.status).to eq(200)
end
- it 'sends a grid block' do
+ it "sends a grid block" do
expect(subject.body)
- .to be_json_eql('Grid'.to_json)
- .at_path('_type')
+ .to be_json_eql("Grid".to_json)
+ .at_path("_type")
end
- it 'has a name' do
+ it "has a name" do
expect(subject.body)
- .to be_json_eql('My board'.to_json)
- .at_path('name')
+ .to be_json_eql("My board".to_json)
+ .at_path("name")
end
- it 'identifies the url the grid is stored for' do
+ it "identifies the url the grid is stored for" do
expect(subject.body)
.to be_json_eql(project_work_package_boards_path(manage_board_views_project).to_json)
- .at_path('_links/scope/href')
+ .at_path("_links/scope/href")
end
- context 'with the scope not existing' do
+ context "with the scope not existing" do
let(:stored_grids) do
end
let(:path) { api_v3_paths.grid(5) }
- it 'responds with 404 NOT FOUND' do
+ it "responds with 404 NOT FOUND" do
expect(subject.status).to be 404
end
end
- context 'when lacking permission to see the grid' do
+ context "when lacking permission to see the grid" do
let(:stored_grids) do
other_board_grid
end
let(:path) { api_v3_paths.grid(other_board_grid.id) }
- it 'responds with 404 NOT FOUND' do
+ it "responds with 404 NOT FOUND" do
expect(subject.status).to be 404
end
end
end
- describe '#patch' do
+ describe "#patch" do
let(:path) { api_v3_paths.grid(manage_board_views_grid.id) }
let(:params) do
@@ -216,31 +216,31 @@
before do
stored_grids
- patch path, params.to_json, 'CONTENT_TYPE' => 'application/json'
+ patch path, params.to_json, "CONTENT_TYPE" => "application/json"
end
- it 'responds with 200 OK' do
+ it "responds with 200 OK" do
expect(subject.status).to eq(200)
end
- it 'returns the altered grid block' do
+ it "returns the altered grid block" do
expect(subject.body)
- .to be_json_eql('Grid'.to_json)
- .at_path('_type')
+ .to be_json_eql("Grid".to_json)
+ .at_path("_type")
expect(subject.body)
- .to be_json_eql(params['rowCount'].to_json)
- .at_path('rowCount')
+ .to be_json_eql(params["rowCount"].to_json)
+ .at_path("rowCount")
expect(subject.body)
- .to be_json_eql(params['widgets'][0]['identifier'].to_json)
- .at_path('widgets/0/identifier')
+ .to be_json_eql(params["widgets"][0]["identifier"].to_json)
+ .at_path("widgets/0/identifier")
end
- it 'perists the changes' do
+ it "perists the changes" do
expect(manage_board_views_grid.reload.row_count)
- .to eql params['rowCount']
+ .to eql params["rowCount"]
end
- context 'with invalid params' do
+ context "with invalid params" do
let(:params) do
{
rowCount: -5,
@@ -255,61 +255,61 @@
}.with_indifferent_access
end
- it 'responds with 422 and mentions the error' do
+ it "responds with 422 and mentions the error" do
expect(subject.status).to eq 422
- expect(JSON.parse(subject.body)['_embedded']['errors'].map { |e| e['message'] })
+ expect(JSON.parse(subject.body)["_embedded"]["errors"].map { |e| e["message"] })
.to contain_exactly("Widgets is outside of the grid.", "Number of rows must be greater than 0.")
end
- it 'does not persist the changes to widgets' do
+ it "does not persist the changes to widgets" do
expect(manage_board_views_grid.reload.widgets.count)
.to eql OpenProject::Boards::GridRegistration.defaults[:widgets].size
end
end
- context 'with a scope param' do
+ context "with a scope param" do
let(:params) do
{
_links: {
scope: {
- href: ''
+ href: ""
}
}
}.with_indifferent_access
end
- it_behaves_like 'read-only violation', 'scope', Boards::Grid
+ it_behaves_like "read-only violation", "scope", Boards::Grid
end
- context 'with the grid not existing' do
+ context "with the grid not existing" do
let(:path) { api_v3_paths.grid(1234) }
- it 'responds with 404 NOT FOUND' do
+ it "responds with 404 NOT FOUND" do
expect(subject.status).to be 404
end
end
- context 'without the manage_board_views permission' do
+ context "without the manage_board_views permission" do
let(:stored_grids) do
show_board_views_grid
end
let(:path) { api_v3_paths.grid(show_board_views_grid.id) }
- it 'responds with 404 NOT FOUND' do
+ it "responds with 404 NOT FOUND" do
expect(subject.status).to be 404
end
end
end
- describe '#post' do
+ describe "#post" do
let(:path) { api_v3_paths.grids }
let(:params) do
{
rowCount: 10,
- name: 'foo',
+ name: "foo",
columnCount: 15,
widgets: [{
identifier: "work_package_query",
@@ -327,37 +327,37 @@
end
before do
- post path, params.to_json, 'CONTENT_TYPE' => 'application/json'
+ post path, params.to_json, "CONTENT_TYPE" => "application/json"
end
- it 'responds with 201 CREATED' do
+ it "responds with 201 CREATED" do
expect(subject.status).to eq(201)
end
- it 'returns the created grid block' do
+ it "returns the created grid block" do
expect(subject.body)
- .to be_json_eql('Grid'.to_json)
- .at_path('_type')
+ .to be_json_eql("Grid".to_json)
+ .at_path("_type")
expect(subject.body)
- .to be_json_eql('foo'.to_json)
- .at_path('name')
+ .to be_json_eql("foo".to_json)
+ .at_path("name")
expect(subject.body)
- .to be_json_eql(params['rowCount'].to_json)
- .at_path('rowCount')
+ .to be_json_eql(params["rowCount"].to_json)
+ .at_path("rowCount")
expect(subject.body)
- .to be_json_eql(params['widgets'][0]['identifier'].to_json)
- .at_path('widgets/0/identifier')
+ .to be_json_eql(params["widgets"][0]["identifier"].to_json)
+ .at_path("widgets/0/identifier")
end
- it 'persists the grid' do
+ it "persists the grid" do
expect(Grids::Grid.count)
.to be(1)
end
- context 'with invalid params' do
+ context "with invalid params" do
let(:params) do
{
- name: 'foo',
+ name: "foo",
rowCount: -5,
columnCount: "sdjfksdfsdfdsf",
widgets: [{
@@ -375,31 +375,31 @@
}.with_indifferent_access
end
- it 'responds with 422' do
+ it "responds with 422" do
expect(subject.status).to eq(422)
end
- it 'does not create a grid' do
+ it "does not create a grid" do
expect(Grids::Grid.count)
.to be(0)
end
- it 'returns the errors' do
+ it "returns the errors" do
expect(subject.body)
- .to be_json_eql('Error'.to_json)
- .at_path('_type')
+ .to be_json_eql("Error".to_json)
+ .at_path("_type")
- expect(JSON.parse(subject.body)['_embedded']['errors'].map { |e| e['message'] })
+ expect(JSON.parse(subject.body)["_embedded"]["errors"].map { |e| e["message"] })
.to contain_exactly("Widgets is outside of the grid.", "Number of rows must be greater than 0.",
"Number of columns must be greater than 0.")
end
end
- context 'without a scope link' do
+ context "without a scope link" do
let(:params) do
{
rowCount: 5,
- name: 'foo',
+ name: "foo",
columnCount: 5,
widgets: [{
identifier: "work_package_query",
@@ -411,30 +411,30 @@
}.with_indifferent_access
end
- it 'responds with 422' do
+ it "responds with 422" do
expect(subject.status).to eq(422)
end
- it 'does not create a grid' do
+ it "does not create a grid" do
expect(Grids::Grid.count)
.to be(0)
end
- it 'returns the errors' do
+ it "returns the errors" do
expect(subject.body)
- .to be_json_eql('Error'.to_json)
- .at_path('_type')
+ .to be_json_eql("Error".to_json)
+ .at_path("_type")
expect(subject.body)
.to be_json_eql("Scope is not set to one of the allowed values.".to_json)
- .at_path('message')
+ .at_path("message")
end
end
- context 'without the permission to create boards in the project' do
+ context "without the permission to create boards in the project" do
let(:params) do
{
- name: 'foo',
+ name: "foo",
rowCount: 5,
columnCount: 5,
widgets: [{
@@ -452,23 +452,23 @@
}.with_indifferent_access
end
- it 'responds with 422' do
+ it "responds with 422" do
expect(subject.status).to eq(422)
end
- it 'does not create a grid' do
+ it "does not create a grid" do
expect(Grids::Grid.count)
.to be(0)
end
- it 'returns the errors' do
+ it "returns the errors" do
expect(subject.body)
- .to be_json_eql('Error'.to_json)
- .at_path('_type')
+ .to be_json_eql("Error".to_json)
+ .at_path("_type")
expect(subject.body)
.to be_json_eql("Scope is not set to one of the allowed values.".to_json)
- .at_path('message')
+ .at_path("message")
end
end
end
diff --git a/modules/boards/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb b/modules/boards/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb
index da7eb42cfe63..3b38a1afe82c 100644
--- a/modules/boards/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb
+++ b/modules/boards/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
RSpec.describe "PATCH /api/v3/grids/:id/form for Board Grids", content_type: :json do
include Rack::Test::Methods
@@ -56,35 +56,35 @@
login_as(current_user)
end
- describe '#post' do
+ describe "#post" do
before do
- post path, params.to_json, 'CONTENT_TYPE' => 'application/json'
+ post path, params.to_json, "CONTENT_TYPE" => "application/json"
end
- it 'returns 200 OK' do
+ it "returns 200 OK" do
expect(subject.status)
.to be 200
end
- it 'is of type form' do
+ it "is of type form" do
expect(subject.body)
.to be_json_eql("Form".to_json)
- .at_path('_type')
+ .at_path("_type")
end
- it 'contains a Schema disallowing setting scope' do
+ it "contains a Schema disallowing setting scope" do
expect(subject.body)
.to be_json_eql("Schema".to_json)
- .at_path('_embedded/schema/_type')
+ .at_path("_embedded/schema/_type")
expect(subject.body)
.to be_json_eql(false.to_json)
- .at_path('_embedded/schema/scope/writable')
+ .at_path("_embedded/schema/scope/writable")
end
- it 'contains the current data in the payload' do
+ it "contains the current data in the payload" do
expected = {
- name: 'My board',
+ name: "My board",
rowCount: 1,
columnCount: 4,
widgets: [],
@@ -100,34 +100,34 @@
expect(subject.body)
.to be_json_eql(expected.to_json)
- .at_path('_embedded/payload')
+ .at_path("_embedded/payload")
end
- it 'has a commit link' do
+ it "has a commit link" do
expect(subject.body)
.to be_json_eql(api_v3_paths.grid(grid.id).to_json)
- .at_path('_links/commit/href')
+ .at_path("_links/commit/href")
end
- context 'with some value for the scope value' do
+ context "with some value for the scope value" do
let(:params) do
{
_links: {
scope: {
- href: '/some/path'
+ href: "/some/path"
}
}
}
end
- it 'has a validation error on scope as the value is not writable' do
+ it "has a validation error on scope as the value is not writable" do
expect(subject.body)
.to be_json_eql("Scope was attempted to be written but is not writable.".to_json)
- .at_path('_embedded/validationErrors/scope/message')
+ .at_path("_embedded/validationErrors/scope/message")
end
end
- context 'with an unsupported widget identifier' do
+ context "with an unsupported widget identifier" do
let(:params) do
{
widgets: [
@@ -143,26 +143,26 @@
}
end
- it 'has a validationError on widget' do
+ it "has a validationError on widget" do
expect(subject.body)
.to be_json_eql("Widgets is not set to one of the allowed values.".to_json)
- .at_path('_embedded/validationErrors/widgets/message')
+ .at_path("_embedded/validationErrors/widgets/message")
end
end
- context 'for a non existing grid' do
+ context "for a non existing grid" do
let(:path) { api_v3_paths.grid_form(grid.id + 5) }
- it 'returns 404 NOT FOUND' do
+ it "returns 404 NOT FOUND" do
expect(subject.status)
.to be 404
end
end
- context 'for a grid for which the user does not have permission' do
+ context "for a grid for which the user does not have permission" do
let(:current_user) { prohibited_user }
- it 'returns 404 NOT FOUND' do
+ it "returns 404 NOT FOUND" do
expect(subject.status)
.to be 404
end
diff --git a/modules/boards/spec/routing/boards_routing_spec.rb b/modules/boards/spec/routing/boards_routing_spec.rb
index f38df997003e..de491e612e22 100644
--- a/modules/boards/spec/routing/boards_routing_spec.rb
+++ b/modules/boards/spec/routing/boards_routing_spec.rb
@@ -26,42 +26,42 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Boards routing' do
+RSpec.describe "Boards routing" do
it do
expect(subject)
- .to route(:get, '/boards')
- .to(controller: 'boards/boards', action: 'index')
+ .to route(:get, "/boards")
+ .to(controller: "boards/boards", action: "index")
end
it do
expect(subject)
- .to route(:get, '/projects/foobar/boards/1')
- .to(controller: 'boards/boards', action: 'show', project_id: 'foobar', id: 1)
+ .to route(:get, "/projects/foobar/boards/1")
+ .to(controller: "boards/boards", action: "show", project_id: "foobar", id: 1)
end
it do
expect(subject)
- .to route(:get, '/boards/new')
- .to(controller: 'boards/boards', action: 'new')
+ .to route(:get, "/boards/new")
+ .to(controller: "boards/boards", action: "new")
end
it do
expect(subject)
- .to route(:get, '/projects/foobar/boards/new')
- .to(controller: 'boards/boards', action: 'new', project_id: 'foobar')
+ .to route(:get, "/projects/foobar/boards/new")
+ .to(controller: "boards/boards", action: "new", project_id: "foobar")
end
it do
expect(subject)
- .to route(:post, '/projects/foobar/boards')
- .to(controller: 'boards/boards', action: 'create', project_id: 'foobar')
+ .to route(:post, "/projects/foobar/boards")
+ .to(controller: "boards/boards", action: "create", project_id: "foobar")
end
it do
expect(subject)
- .to route(:post, '/boards')
- .to(controller: 'boards/boards', action: 'create')
+ .to route(:post, "/boards")
+ .to(controller: "boards/boards", action: "create")
end
end
diff --git a/modules/boards/spec/services/assignee_board_create_service_spec.rb b/modules/boards/spec/services/assignee_board_create_service_spec.rb
index ab324afa75f7..e9008b1ff611 100644
--- a/modules/boards/spec/services/assignee_board_create_service_spec.rb
+++ b/modules/boards/spec/services/assignee_board_create_service_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Boards::AssigneeBoardCreateService do
shared_let(:project) { create(:project) }
@@ -37,16 +37,16 @@
subject { instance.call(params) }
- context 'with all valid params' do
+ context "with all valid params" do
let(:params) do
{
name: "Gotham Renewal Board",
project:,
- attribute: 'assignee'
+ attribute: "assignee"
}
end
- it 'is successful' do
+ it "is successful" do
expect(subject).to be_success
end
@@ -54,8 +54,8 @@
board = subject.result
expect(board.name).to eq("Gotham Renewal Board")
- expect(board.options[:attribute]).to eq('assignee')
- expect(board.options[:type]).to eq('action')
+ expect(board.options[:attribute]).to eq("assignee")
+ expect(board.options[:type]).to eq("action")
expect(board.widgets).to be_empty
end
diff --git a/modules/boards/spec/services/base_create_service_shared_examples.rb b/modules/boards/spec/services/base_create_service_shared_examples.rb
index 7146101c57b6..dbe290bf3be7 100644
--- a/modules/boards/spec/services/base_create_service_shared_examples.rb
+++ b/modules/boards/spec/services/base_create_service_shared_examples.rb
@@ -28,10 +28,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.shared_examples 'sets the appropriate sort_criteria on each query' do
- it '', :aggregate_failures do
+RSpec.shared_examples "sets the appropriate sort_criteria on each query" do
+ it "", :aggregate_failures do
subject
queries_sort_criteria = queries.map(&:sort_criteria)
diff --git a/modules/boards/spec/services/basic_board_create_service_spec.rb b/modules/boards/spec/services/basic_board_create_service_spec.rb
index 723caa11a4cf..ed55f61a4696 100644
--- a/modules/boards/spec/services/basic_board_create_service_spec.rb
+++ b/modules/boards/spec/services/basic_board_create_service_spec.rb
@@ -28,8 +28,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'base_create_service_shared_examples'
+require "spec_helper"
+require_relative "base_create_service_shared_examples"
RSpec.describe Boards::BasicBoardCreateService do
shared_let(:project) { create(:project) }
@@ -38,16 +38,16 @@
subject { instance.call(params) }
- context 'with all valid params' do
+ context "with all valid params" do
let(:params) do
{
name: "Gotham Renewal Board",
project:,
- attribute: 'basic'
+ attribute: "basic"
}
end
- it 'is successful' do
+ it "is successful" do
expect(subject).to be_success
end
@@ -56,32 +56,32 @@
expect(board.name).to eq("Gotham Renewal Board")
expect(board.options[:attribute]).to be_nil
- expect(board.options[:type]).to eq 'free'
+ expect(board.options[:type]).to eq "free"
end
- describe 'widgets and queries' do
+ describe "widgets and queries" do
let(:board) { subject.result }
let(:widgets) { board.widgets }
let(:queries) { Query.all }
- it 'creates one of each', :aggregate_failures do
+ it "creates one of each", :aggregate_failures do
subject
expect(widgets.count).to eq 1
expect(queries.count).to eq 1
end
- it 'sets the manual sorting filter on each' do
+ it "sets the manual sorting filter on each" do
subject
query_filter = queries.flat_map(&:filters).map(&:to_hash).first
- widget_filter = widgets.flat_map { _1.options['filters'] }.first
+ widget_filter = widgets.flat_map { _1.options["filters"] }.first
expect(query_filter).to have_key :manual_sort
expect(query_filter).to eq widget_filter
end
- it_behaves_like 'sets the appropriate sort_criteria on each query'
+ it_behaves_like "sets the appropriate sort_criteria on each query"
end
end
end
diff --git a/modules/boards/spec/services/copy_service_integration_spec.rb b/modules/boards/spec/services/copy_service_integration_spec.rb
index 1213dbe45f32..b10580cee8a0 100644
--- a/modules/boards/spec/services/copy_service_integration_spec.rb
+++ b/modules/boards/spec/services/copy_service_integration_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe Projects::CopyService, 'integration', type: :model do
+RSpec.describe Projects::CopyService, "integration", type: :model do
let(:current_user) do
create(:user,
member_with_roles: { source => role })
@@ -44,7 +44,7 @@
end
let(:only_args) { %w[work_packages boards] }
let(:target_project_params) do
- { name: 'Some name', identifier: 'some-identifier' }
+ { name: "Some name", identifier: "some-identifier" }
end
let(:params) do
{ target_project_params:, only: only_args }
@@ -52,7 +52,7 @@
subject { instance.call(params) }
- describe 'for a subproject board' do
+ describe "for a subproject board" do
let(:current_user) do
create(:user, member_with_roles: { source => role, child_project => role })
end
@@ -63,7 +63,7 @@
let!(:board_view) do
create(:board_grid_with_query,
project: source,
- name: 'Subproject board',
+ name: "Subproject board",
options: { "type" => "action", "attribute" => "subproject" })
end
@@ -72,45 +72,45 @@
# Modify the actual saved query to contain the subproject filter
query = board_view.contained_queries.first
- query.add_filter('only_subproject_id', '=', child_project.id)
+ query.add_filter("only_subproject_id", "=", child_project.id)
query.save!
end
- it 'succeeds to copy, but add an error for the missing subproject column (Regression #34550)' do
+ it "succeeds to copy, but add an error for the missing subproject column (Regression #34550)" do
# Expect to have created to board, but with error
expect(subject).to be_success
expect(subject.errors.full_messages).to eq([expected_error])
expect(board_copies.count).to eq 1
# Expect board name to match
- expect(board_copy.name).to eq 'Subproject board'
+ expect(board_copy.name).to eq "Subproject board"
# Expect the widget to be lost during save
expect(board_copy.widgets).to be_empty
end
end
- describe 'for ordered work packages' do
- let!(:board_view) { create(:board_grid_with_query, project: source, name: 'My Board') }
- let!(:wp_1) { create(:work_package, project: source, subject: 'Second') }
- let!(:wp_2) { create(:work_package, project: source, subject: 'First') }
+ describe "for ordered work packages" do
+ let!(:board_view) { create(:board_grid_with_query, project: source, name: "My Board") }
+ let!(:wp_1) { create(:work_package, project: source, subject: "Second") }
+ let!(:wp_2) { create(:work_package, project: source, subject: "First") }
before do
OrderedWorkPackage.create(query:, work_package: wp_1, position: 1234)
OrderedWorkPackage.create(query:, work_package: wp_2, position: -1000)
end
- describe 'call' do
- it 'copies the boards with the order correct' do
+ describe "call" do
+ it "copies the boards with the order correct" do
expect(subject).to be_success
expect(board_copies.count).to eq 1
# Expect board name to match
- expect(board_copy.name).to eq 'My Board'
+ expect(board_copy.name).to eq "My Board"
# Expect query to differ
- query_id = board_copy.widgets.first.options['queryId']
+ query_id = board_copy.widgets.first.options["queryId"]
expect(query_id.to_i).not_to eq(query.id)
# Expect query to be in correct project
@@ -132,11 +132,11 @@
wps = query.ordered_work_packages
expect(wps.count).to eq 2
- expect(wps[0].work_package.subject).to eq 'First'
+ expect(wps[0].work_package.subject).to eq "First"
expect(wps[0].position).to eq -1000
expect(wps[0].work_package.id).not_to eq wp_2.id
- expect(wps[1].work_package.subject).to eq 'Second'
+ expect(wps[1].work_package.subject).to eq "Second"
expect(wps[1].position).to eq 1234
expect(wps[1].work_package.id).not_to eq wp_1.id
end
diff --git a/modules/boards/spec/services/status_board_create_service_spec.rb b/modules/boards/spec/services/status_board_create_service_spec.rb
index 012a139f4e88..498763a9a1f6 100644
--- a/modules/boards/spec/services/status_board_create_service_spec.rb
+++ b/modules/boards/spec/services/status_board_create_service_spec.rb
@@ -28,8 +28,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'base_create_service_shared_examples'
+require "spec_helper"
+require_relative "base_create_service_shared_examples"
RSpec.describe Boards::StatusBoardCreateService do
shared_let(:project) { create(:project) }
@@ -39,16 +39,16 @@
subject { instance.call(params) }
- context 'with all valid params' do
+ context "with all valid params" do
let(:params) do
{
name: "Gotham Renewal Board",
project:,
- attribute: 'status'
+ attribute: "status"
}
end
- it 'is successful' do
+ it "is successful" do
expect(subject).to be_success
end
@@ -56,32 +56,32 @@
board = subject.result
expect(board.name).to eq("Gotham Renewal Board")
- expect(board.options[:attribute]).to eq('status')
- expect(board.options[:type]).to eq('action')
+ expect(board.options[:attribute]).to eq("status")
+ expect(board.options[:type]).to eq("action")
end
- describe 'widgets and queries' do
+ describe "widgets and queries" do
let(:board) { subject.result }
let(:widgets) { board.widgets }
let(:queries) { Query.all }
- it 'creates one of each for the current default status', :aggregate_failures do
+ it "creates one of each for the current default status", :aggregate_failures do
subject
expect(widgets.count).to eq 1
expect(queries.count).to eq 1
end
- it 'sets the filters on each' do
+ it "sets the filters on each" do
subject
query_filter = queries.flat_map(&:filters).map(&:to_hash).first
- widget_filter = widgets.flat_map { _1.options['filters'] }.first
+ widget_filter = widgets.flat_map { _1.options["filters"] }.first
expect(query_filter).to match_array(widget_filter)
end
- it_behaves_like 'sets the appropriate sort_criteria on each query'
+ it_behaves_like "sets the appropriate sort_criteria on each query"
end
end
end
diff --git a/modules/boards/spec/services/subproject_board_create_service_spec.rb b/modules/boards/spec/services/subproject_board_create_service_spec.rb
index ad5056c6700a..13607df6292c 100644
--- a/modules/boards/spec/services/subproject_board_create_service_spec.rb
+++ b/modules/boards/spec/services/subproject_board_create_service_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Boards::SubprojectBoardCreateService do
shared_let(:project) { create(:project) }
@@ -37,16 +37,16 @@
subject { instance.call(params) }
- context 'with all valid params' do
+ context "with all valid params" do
let(:params) do
{
name: "Gotham Renewal Board",
project:,
- attribute: 'subproject'
+ attribute: "subproject"
}
end
- it 'is successful' do
+ it "is successful" do
expect(subject).to be_success
end
@@ -54,8 +54,8 @@
board = subject.result
expect(board.name).to eq("Gotham Renewal Board")
- expect(board.options[:attribute]).to eq('subproject')
- expect(board.options[:type]).to eq('action')
+ expect(board.options[:attribute]).to eq("subproject")
+ expect(board.options[:type]).to eq("action")
expect(board.widgets).to be_empty
end
diff --git a/modules/boards/spec/services/subtasks_board_create_service_spec.rb b/modules/boards/spec/services/subtasks_board_create_service_spec.rb
index d78fcf557d3a..8083a6a4237c 100644
--- a/modules/boards/spec/services/subtasks_board_create_service_spec.rb
+++ b/modules/boards/spec/services/subtasks_board_create_service_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Boards::SubtasksBoardCreateService do
shared_let(:project) { create(:project) }
@@ -37,16 +37,16 @@
subject { instance.call(params) }
- context 'with all valid params' do
+ context "with all valid params" do
let(:params) do
{
name: "Gotham Renewal Board",
project:,
- attribute: 'subtasks'
+ attribute: "subtasks"
}
end
- it 'is successful' do
+ it "is successful" do
expect(subject).to be_success
end
@@ -54,8 +54,8 @@
board = subject.result
expect(board.name).to eq("Gotham Renewal Board")
- expect(board.options[:attribute]).to eq('subtasks')
- expect(board.options[:type]).to eq('action')
+ expect(board.options[:attribute]).to eq("subtasks")
+ expect(board.options[:type]).to eq("action")
expect(board.widgets).to be_empty
end
diff --git a/modules/boards/spec/services/version_board_create_service_spec.rb b/modules/boards/spec/services/version_board_create_service_spec.rb
index 5566ba36ab96..3d6e50bb4c21 100644
--- a/modules/boards/spec/services/version_board_create_service_spec.rb
+++ b/modules/boards/spec/services/version_board_create_service_spec.rb
@@ -28,8 +28,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'base_create_service_shared_examples'
+require "spec_helper"
+require_relative "base_create_service_shared_examples"
RSpec.describe Boards::VersionBoardCreateService do
shared_let(:project) { create(:project) }
@@ -40,8 +40,8 @@
shared_let(:versions) { create_list(:version, 5, project:) }
shared_let(:excluded_versions) do
[
- create(:version, project:, status: 'closed'),
- create(:version, project: other_project, sharing: 'system')
+ create(:version, project:, status: "closed"),
+ create(:version, project: other_project, sharing: "system")
]
end
@@ -50,16 +50,16 @@
subject { instance.call(params) }
- context 'with all valid params' do
+ context "with all valid params" do
let(:params) do
{
name: "Gotham Renewal Board",
project:,
- attribute: 'version'
+ attribute: "version"
}
end
- it 'is successful' do
+ it "is successful" do
expect(subject).to be_success
end
@@ -67,35 +67,35 @@
board = subject.result
expect(board.name).to eq("Gotham Renewal Board")
- expect(board.options[:attribute]).to eq('version')
- expect(board.options[:type]).to eq('action')
+ expect(board.options[:attribute]).to eq("version")
+ expect(board.options[:type]).to eq("action")
end
- describe 'column_count' do
- it 'matches the column_count to the version count' do
+ describe "column_count" do
+ it "matches the column_count to the version count" do
board = subject.result
expect(board.column_count).to eq(versions.count)
end
- context 'when there are no versions that apply for the project' do
+ context "when there are no versions that apply for the project" do
before do
- versions.each { _1.update!(status: 'closed') }
+ versions.each { _1.update!(status: "closed") }
end
- it 'sets the column_count to the default value' do
+ it "sets the column_count to the default value" do
board = subject.result
expect(board.column_count).to eq(4)
end
end
end
- describe 'widgets and queries' do
+ describe "widgets and queries" do
let(:board) { subject.result }
let(:widgets) { board.widgets }
let(:queries) { Query.all }
- it 'creates one of each per expected version', :aggregate_failures do
+ it "creates one of each per expected version", :aggregate_failures do
subject
expect(widgets.count).to eq(versions.count)
@@ -104,16 +104,16 @@
expect(queries.map(&:name)).to match_array(versions.map(&:name))
end
- it 'sets the filters on each' do
+ it "sets the filters on each" do
subject
queries_filters = queries.flat_map(&:filters).map(&:to_hash)
- widgets_filters = widgets.flat_map { _1.options['filters'] }
+ widgets_filters = widgets.flat_map { _1.options["filters"] }
expect(queries_filters).to match_array(widgets_filters)
end
- it_behaves_like 'sets the appropriate sort_criteria on each query'
+ it_behaves_like "sets the appropriate sort_criteria on each query"
end
end
end
diff --git a/modules/budgets/Gemfile b/modules/budgets/Gemfile
index fa75df156323..b4e2a20bb606 100644
--- a/modules/budgets/Gemfile
+++ b/modules/budgets/Gemfile
@@ -1,3 +1,3 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
gemspec
diff --git a/modules/budgets/app/controllers/budgets_controller.rb b/modules/budgets/app/controllers/budgets_controller.rb
index 83e1ed101479..852a1d5758ad 100644
--- a/modules/budgets/app/controllers/budgets_controller.rb
+++ b/modules/budgets/app/controllers/budgets_controller.rb
@@ -57,23 +57,23 @@ class BudgetsController < ApplicationController
include ::Costs::NumberHelper
def index
- sort_init 'id', 'desc'
+ sort_init "id", "desc"
sort_update default_budget_sort
@budgets = visible_sorted_budgets
respond_to do |format|
format.html do
- render action: 'index', layout: !request.xhr?
+ render action: "index", layout: !request.xhr?
end
- format.csv { send_data(budgets_to_csv(@budgets), type: 'text/csv; header=present', filename: 'export.csv') }
+ format.csv { send_data(budgets_to_csv(@budgets), type: "text/csv; header=present", filename: "export.csv") }
end
end
def show
@edit_allowed = User.current.allowed_in_project?(:edit_budgets, @project)
respond_to do |format|
- format.html { render action: 'show', layout: !request.xhr? }
+ format.html { render action: "show", layout: !request.xhr? }
end
end
@@ -107,9 +107,9 @@ def create
if call.success?
flash[:notice] = t(:notice_successful_create)
- redirect_to(params[:continue] ? { action: 'new' } : { action: 'show', id: @budget })
+ redirect_to(params[:continue] ? { action: "new" } : { action: "show", id: @budget })
else
- render action: 'new', layout: !request.xhr?
+ render action: "new", layout: !request.xhr?
end
end
@@ -127,7 +127,7 @@ def update
redirect_to(@budget)
else
@budget = call.result
- render action: 'edit'
+ render action: "edit"
end
rescue ActiveRecord::StaleObjectError
# Optimistic locking exception
@@ -137,7 +137,7 @@ def update
def destroy
@budgets.each(&:destroy)
flash[:notice] = t(:notice_successful_delete)
- redirect_to action: 'index', project_id: @project
+ redirect_to action: "index", project_id: @project
end
def destroy_info
@@ -159,7 +159,7 @@ def update_material_budget_item
@unit = volume == 1.0 ? cost_type.unit : cost_type.unit_plural
else
@costs = 0.0
- @unit = cost_type.try(:unit_plural) || ''
+ @unit = cost_type.try(:unit_plural) || ""
end
respond_to do |format|
@@ -212,7 +212,7 @@ def find_budgets
@project = projects.first
else
# TODO: let users bulk edit/move/destroy budgets from different projects
- render_error 'Can not bulk edit/move/destroy cost objects from different projects' and return false
+ render_error "Can not bulk edit/move/destroy cost objects from different projects" and return false
end
rescue ActiveRecord::RecordNotFound
render_404
@@ -233,7 +233,7 @@ def find_optional_project
def render_item_as_json(element_id, costs, unit, project, permission)
response = {
"#{element_id}_unit_name" => ActionController::Base.helpers.sanitize(unit),
- "#{element_id}_currency" => Setting.plugin_costs['costs_currency']
+ "#{element_id}_currency" => Setting.plugin_costs["costs_currency"]
}
if current_user.allowed_in_project?(permission, project)
@@ -246,9 +246,9 @@ def render_item_as_json(element_id, costs, unit, project, permission)
def default_budget_sort
{
- 'id' => "#{Budget.table_name}.id",
- 'subject' => "#{Budget.table_name}.subject",
- 'fixed_date' => "#{Budget.table_name}.fixed_date"
+ "id" => "#{Budget.table_name}.id",
+ "subject" => "#{Budget.table_name}.subject",
+ "fixed_date" => "#{Budget.table_name}.fixed_date"
}
end
@@ -277,7 +277,7 @@ def update_belonging_work_packages
reassign_to_id = params[:reassign_to_id]
budget_id = params[:id]
- budget_exists = Budget.visible(current_user).exists?(id: reassign_to_id) if params[:todo] == 'reassign'
+ budget_exists = Budget.visible(current_user).exists?(id: reassign_to_id) if params[:todo] == "reassign"
reassign_to = budget_exists ? reassign_to_id : nil
WorkPackage
diff --git a/modules/budgets/app/helpers/budgets_helper.rb b/modules/budgets/app/helpers/budgets_helper.rb
index 044d59185f88..b06b6aa3a82c 100644
--- a/modules/budgets/app/helpers/budgets_helper.rb
+++ b/modules/budgets/app/helpers/budgets_helper.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'csv'
+require "csv"
module BudgetsHelper
include ActionView::Helpers::NumberHelper
@@ -42,7 +42,7 @@ def budgets_to_csv(budgets)
CSV.generate(col_sep: t(:general_csv_separator)) do |csv|
# csv header fields
headers = [
- '#',
+ "#",
Project.model_name.human,
Budget.human_attribute_name(:subject),
Budget.human_attribute_name(:author),
@@ -54,7 +54,7 @@ def budgets_to_csv(budgets)
Budget.human_attribute_name(:updated_at),
Budget.human_attribute_name(:description)
]
- csv << headers.map { |c| begin; c.to_s.encode('UTF-8'); rescue StandardError; c.to_s; end }
+ csv << headers.map { |c| begin; c.to_s.encode("UTF-8"); rescue StandardError; c.to_s; end }
# csv lines
budgets.each do |budget|
fields = [
@@ -70,7 +70,7 @@ def budgets_to_csv(budgets)
format_time(budget.updated_at),
budget.description
]
- csv << fields.map { |c| begin; c.to_s.encode('UTF-8'); rescue StandardError; c.to_s; end }
+ csv << fields.map { |c| begin; c.to_s.encode("UTF-8"); rescue StandardError; c.to_s; end }
end
end
end
diff --git a/modules/budgets/app/models/budget.rb b/modules/budgets/app/models/budget.rb
index cc7f457941c0..2f5d0c01ea30 100644
--- a/modules/budgets/app/models/budget.rb
+++ b/modules/budgets/app/models/budget.rb
@@ -27,14 +27,14 @@
#++
class Budget < ApplicationRecord
- belongs_to :author, class_name: 'User'
+ belongs_to :author, class_name: "User"
belongs_to :project
has_many :work_packages, dependent: :nullify
has_many :material_budget_items, -> {
- includes(:cost_type).order(Arel.sql('material_budget_items.id ASC'))
+ includes(:cost_type).order(Arel.sql("material_budget_items.id ASC"))
}, dependent: :destroy
has_many :labor_budget_items, -> {
- includes(:user).order(Arel.sql('labor_budget_items.id ASC'))
+ includes(:user).order(Arel.sql("labor_budget_items.id ASC"))
}, dependent: :destroy
validates_associated :material_budget_items
@@ -51,9 +51,9 @@ class Budget < ApplicationRecord
acts_as_attachable
acts_as_journalized
- acts_as_event type: 'cost-objects',
+ acts_as_event type: "cost-objects",
title: Proc.new { |o| "#{I18n.t(:label_budget)} ##{o.id}: #{o.subject}" },
- url: Proc.new { |o| { controller: 'budgets', action: 'show', id: o.id } }
+ url: Proc.new { |o| { controller: "budgets", action: "show", id: o.id } }
validates_presence_of :subject, :project, :author, :fixed_date
validates_length_of :subject, maximum: 255
@@ -79,7 +79,7 @@ def new_copy(source)
protected
def copy_attributes(source)
- source.attributes.slice('project_id', 'subject', 'description', 'fixed_date').merge('author' => User.current)
+ source.attributes.slice("project_id", "subject", "description", "fixed_date").merge("author" => User.current)
end
def copy_budget_items(source, sink, items:)
@@ -92,7 +92,7 @@ def copy_budget_items(source, sink, items:)
%w(hours user_id comments amount)
end
- sink.send(items).build(bi.attributes.slice(*to_slice).merge('budget' => sink))
+ sink.send(items).build(bi.attributes.slice(*to_slice).merge("budget" => sink))
end
end
end
@@ -117,7 +117,7 @@ def budget_ratio
end
def css_classes
- 'budget'
+ "budget"
end
def to_s
@@ -129,11 +129,11 @@ def name
end
def material_budget
- @material_budget ||= material_budget_items.visible_costs.inject(BigDecimal('0.0000')) { |sum, i| sum += i.costs }
+ @material_budget ||= material_budget_items.visible_costs.inject(BigDecimal("0.0000")) { |sum, i| sum += i.costs }
end
def labor_budget
- @labor_budget ||= labor_budget_items.visible_costs.inject(BigDecimal('0.0000')) { |sum, i| sum += i.costs }
+ @labor_budget ||= labor_budget_items.visible_costs.inject(BigDecimal("0.0000")) { |sum, i| sum += i.costs }
end
def spent
@@ -142,7 +142,7 @@ def spent
def spent_material
@spent_material ||= if cost_entries.blank?
- BigDecimal('0.0000')
+ BigDecimal("0.0000")
else
cost_entries.visible_costs(User.current, project).sum("CASE
WHEN #{CostEntry.table_name}.overridden_costs IS NULL THEN
@@ -154,7 +154,7 @@ def spent_material
def spent_labor
@spent_labor ||= if time_entries.blank?
- BigDecimal('0.0000')
+ BigDecimal("0.0000")
else
time_entries.visible_costs(User.current, project).sum("CASE
WHEN #{TimeEntry.table_name}.overridden_costs IS NULL THEN
@@ -175,7 +175,7 @@ def new_material_budget_item_attributes=(material_budget_item_attributes)
end
def existing_material_budget_item_attributes=(material_budget_item_attributes)
- update_budget_item_attributes(material_budget_item_attributes, type: 'material')
+ update_budget_item_attributes(material_budget_item_attributes, type: "material")
end
def save_material_budget_items
@@ -196,7 +196,7 @@ def new_labor_budget_item_attributes=(labor_budget_item_attributes)
end
def existing_labor_budget_item_attributes=(labor_budget_item_attributes)
- update_budget_item_attributes(labor_budget_item_attributes, type: 'labor')
+ update_budget_item_attributes(labor_budget_item_attributes, type: "labor")
end
private
diff --git a/modules/budgets/app/models/journal/budget_journal.rb b/modules/budgets/app/models/journal/budget_journal.rb
index eef5a1015558..4486f4703599 100644
--- a/modules/budgets/app/models/journal/budget_journal.rb
+++ b/modules/budgets/app/models/journal/budget_journal.rb
@@ -27,5 +27,5 @@
#++
class Journal::BudgetJournal < Journal::BaseJournal
- self.table_name = 'budget_journals'
+ self.table_name = "budget_journals"
end
diff --git a/modules/budgets/app/models/labor_budget_item.rb b/modules/budgets/app/models/labor_budget_item.rb
index 7c53d8bf66cc..993330ab529c 100644
--- a/modules/budgets/app/models/labor_budget_item.rb
+++ b/modules/budgets/app/models/labor_budget_item.rb
@@ -29,7 +29,7 @@
class LaborBudgetItem < ApplicationRecord
belongs_to :budget
belongs_to :user
- belongs_to :principal, foreign_key: 'user_id'
+ belongs_to :principal, foreign_key: "user_id"
include ::Costs::DeletedUserFallback
diff --git a/modules/budgets/app/models/queries/work_packages/filter/budget_filter.rb b/modules/budgets/app/models/queries/work_packages/filter/budget_filter.rb
index 2d68c93a9d9e..81ceca67ffed 100644
--- a/modules/budgets/app/models/queries/work_packages/filter/budget_filter.rb
+++ b/modules/budgets/app/models/queries/work_packages/filter/budget_filter.rb
@@ -46,7 +46,7 @@ def type
end
def dependency_class
- '::API::V3::Queries::Schemas::BudgetFilterDependencyRepresenter'
+ "::API::V3::Queries::Schemas::BudgetFilterDependencyRepresenter"
end
def ar_object_filter?
@@ -69,7 +69,7 @@ def human_name
def budgets
Budget
.where(project_id: project)
- .order(Arel.sql('subject ASC'))
+ .order(Arel.sql("subject ASC"))
end
end
end
diff --git a/modules/budgets/budgets.gemspec b/modules/budgets/budgets.gemspec
index c7254e3757d3..87d37324e9bc 100644
--- a/modules/budgets/budgets.gemspec
+++ b/modules/budgets/budgets.gemspec
@@ -1,9 +1,9 @@
Gem::Specification.new do |s|
s.name = "budgets"
- s.version = '1.0.0'
+ s.version = "1.0.0"
s.authors = ["OpenProject GmbH"]
s.summary = "OpenProject Budgets."
s.files = Dir["{app,config,db,lib}/**/*"]
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/budgets/config/routes.rb b/modules/budgets/config/routes.rb
index 46a2e315d3b0..aa71075e1395 100644
--- a/modules/budgets/config/routes.rb
+++ b/modules/budgets/config/routes.rb
@@ -27,7 +27,7 @@
#++
Rails.application.routes.draw do
- scope 'projects/:project_id', as: 'projects' do
+ scope "projects/:project_id", as: "projects" do
resources :budgets, only: %i[new create index] do
match :update_labor_budget_item, on: :collection, via: %i[get post]
match :update_material_budget_item, on: :collection, via: %i[get post]
diff --git a/modules/budgets/db/migrate/20200807083950_keep_enabled_module.rb b/modules/budgets/db/migrate/20200807083950_keep_enabled_module.rb
index 4cc2e59210aa..4d45eeac8fcb 100644
--- a/modules/budgets/db/migrate/20200807083950_keep_enabled_module.rb
+++ b/modules/budgets/db/migrate/20200807083950_keep_enabled_module.rb
@@ -26,17 +26,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require Rails.root.to_s + '/db/migrate/migration_utils/module_renamer'
+require Rails.root.to_s + "/db/migrate/migration_utils/module_renamer"
class KeepEnabledModule < ActiveRecord::Migration[6.0]
def up
- module_renamer.add_to_enabled('budgets', %w[costs_module])
- module_renamer.add_to_default('budgets', %w[costs_module])
+ module_renamer.add_to_enabled("budgets", %w[costs_module])
+ module_renamer.add_to_default("budgets", %w[costs_module])
end
def down
- module_renamer.remove_from_enabled('budgets')
- module_renamer.remove_from_default('budgets')
+ module_renamer.remove_from_enabled("budgets")
+ module_renamer.remove_from_default("budgets")
end
private
diff --git a/modules/budgets/db/migrate/20200810152654_rename_cost_object_to_budget.rb b/modules/budgets/db/migrate/20200810152654_rename_cost_object_to_budget.rb
index 442510c962fe..ee472a90c370 100644
--- a/modules/budgets/db/migrate/20200810152654_rename_cost_object_to_budget.rb
+++ b/modules/budgets/db/migrate/20200810152654_rename_cost_object_to_budget.rb
@@ -28,10 +28,10 @@
class RenameCostObjectToBudget < ActiveRecord::Migration[6.0]
def up
- if primary_key_index_name(:cost_objects) != 'cost_objects_pkey'
+ if primary_key_index_name(:cost_objects) != "cost_objects_pkey"
warn "Found unexpected primary key name. Fixing primary key names..."
- require './db/migrate/20190502102512_ensure_postgres_index_names'
+ require "./db/migrate/20190502102512_ensure_postgres_index_names"
EnsurePostgresIndexNames.new.up
end
@@ -69,8 +69,8 @@ def up
WHERE container_type = 'CostObject'
SQL
- rename_in_queries('cost_object', 'budget')
- rename_in_cost_queries('CostObject', 'Budget')
+ rename_in_queries("cost_object", "budget")
+ rename_in_cost_queries("CostObject", "Budget")
rename_column :budgets, :created_on, :created_at
rename_column :budgets, :updated_on, :updated_at
@@ -100,8 +100,8 @@ def down
rename_column :budgets, :created_at, :created_on
rename_column :budgets, :updated_at, :updated_on
- rename_in_queries('budget', 'cost_object')
- rename_in_cost_queries('Budget', 'CostObject')
+ rename_in_queries("budget", "cost_object")
+ rename_in_cost_queries("Budget", "CostObject")
execute <<~SQL.squish
UPDATE attachments
@@ -189,6 +189,6 @@ def primary_key_index_name(table_name)
table = connection.quote table_name
sql = "SELECT indexname FROM pg_indexes WHERE tablename = #{table} AND indexdef LIKE '%(id)';"
- connection.execute(sql).pluck('indexname').compact.first
+ connection.execute(sql).pluck("indexname").compact.first
end
end
diff --git a/modules/budgets/lib/api/v3/budgets/budget_representer.rb b/modules/budgets/lib/api/v3/budgets/budget_representer.rb
index c9d096c4b430..fa856db2abf8 100644
--- a/modules/budgets/lib/api/v3/budgets/budget_representer.rb
+++ b/modules/budgets/lib/api/v3/budgets/budget_representer.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'roar/decorator'
-require 'roar/json/hal'
+require "roar/decorator"
+require "roar/json/hal"
module API
module V3
@@ -49,7 +49,7 @@ class BudgetRepresenter < ::API::Decorators::Single
property :subject, render_nil: true
def _type
- 'Budget'
+ "Budget"
end
end
end
diff --git a/modules/budgets/lib/api/v3/budgets/budgets_api.rb b/modules/budgets/lib/api/v3/budgets/budgets_api.rb
index cfb44b6a46ea..24ee6b395745 100644
--- a/modules/budgets/lib/api/v3/budgets/budgets_api.rb
+++ b/modules/budgets/lib/api/v3/budgets/budgets_api.rb
@@ -31,7 +31,7 @@ module V3
module Budgets
class BudgetsAPI < ::API::OpenProjectAPI
resources :budgets do
- route_param :id, type: Integer, desc: 'Budget ID' do
+ route_param :id, type: Integer, desc: "Budget ID" do
after_validation do
@budget = Budget.find(params[:id])
diff --git a/modules/budgets/lib/budgets/engine.rb b/modules/budgets/lib/budgets/engine.rb
index 317c8e179647..9efab0dbdb5e 100644
--- a/modules/budgets/lib/budgets/engine.rb
+++ b/modules/budgets/lib/budgets/engine.rb
@@ -2,8 +2,8 @@ module Budgets
class Engine < ::Rails::Engine
include OpenProject::Plugins::ActsAsOpEngine
- register 'budgets',
- author_url: 'https://www.openproject.org',
+ register "budgets",
+ author_url: "https://www.openproject.org",
bundled: true do
project_module :budgets do
permission :view_budgets,
@@ -16,11 +16,11 @@ class Engine < ::Rails::Engine
menu :project_menu,
:budgets,
- { controller: '/budgets', action: 'index' },
+ { controller: "/budgets", action: "index" },
if: ->(project) { project.module_enabled?(:budgets) },
after: :costs,
caption: :budgets_title,
- icon: 'budget'
+ icon: "budget"
end
add_api_path :budget do |id|
@@ -35,11 +35,11 @@ class Engine < ::Rails::Engine
"#{budget(id)}/attachments"
end
- add_api_endpoint 'API::V3::Root' do
+ add_api_endpoint "API::V3::Root" do
mount ::API::V3::Budgets::BudgetsAPI
end
- add_api_endpoint 'API::V3::Projects::ProjectsAPI', :id do
+ add_api_endpoint "API::V3::Projects::ProjectsAPI", :id do
mount ::API::V3::Budgets::BudgetsByProjectAPI
end
@@ -48,7 +48,7 @@ class Engine < ::Rails::Engine
end
config.to_prepare do
- OpenProject::ProjectLatestActivity.register on: 'Budget'
+ OpenProject::ProjectLatestActivity.register on: "Budget"
# Add to the budget to the costs group
::Type.add_default_mapping(:costs, :budget)
diff --git a/modules/budgets/lib/budgets/hooks/work_package_hook.rb b/modules/budgets/lib/budgets/hooks/work_package_hook.rb
index 3adf6b922c36..381d31e7e61a 100644
--- a/modules/budgets/lib/budgets/hooks/work_package_hook.rb
+++ b/modules/budgets/lib/budgets/hooks/work_package_hook.rb
@@ -41,11 +41,11 @@ def controller_work_packages_move_before_save(context = {})
budget_id = context[:params] && context[:params][:budget_id]
case budget_id
- when '' # a.k.a "(No change)"
+ when "" # a.k.a "(No change)"
# cost objects HAVE to be changed if move is performed across project boundaries
# as the are project specific
context[:work_package].budget_id = nil unless context[:work_package].project == context[:target_project]
- when 'none'
+ when "none"
context[:work_package].budget_id = nil
else
context[:work_package].budget_id = budget_id
@@ -63,14 +63,14 @@ def controller_work_packages_bulk_edit_before_save(context = {})
when context[:params][:budget_id].blank?
# Do nothing
- when context[:params][:budget_id] == 'none'
+ when context[:params][:budget_id] == "none"
# Unassign budget
context[:work_package].budget = nil
else
context[:work_package].budget = Budget.find(context[:params][:budget_id])
end
- ''
+ ""
end
end
end
diff --git a/modules/budgets/spec/features/budgets/add_budget_spec.rb b/modules/budgets/spec/features/budgets/add_budget_spec.rb
index 0e881808bcd1..abca50e11ecc 100644
--- a/modules/budgets/spec/features/budgets/add_budget_spec.rb
+++ b/modules/budgets/spec/features/budgets/add_budget_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper.rb")
-RSpec.describe 'adding a new budget', :js do
+RSpec.describe "adding a new budget", :js do
let(:project) { create(:project_with_types, members: project_members) }
let(:user) { create(:admin) }
let(:project_members) { {} }
@@ -37,7 +37,7 @@
login_as user
end
- it 'shows link to create a new budget' do
+ it "shows link to create a new budget" do
visit projects_budgets_path(project)
click_on("Add budget")
@@ -47,41 +47,41 @@
expect(page).to have_content "Subject"
end
- describe 'with multiple cost types' do
+ describe "with multiple cost types" do
let!(:cost_type_1) do
- create(:cost_type, name: 'Post-war', unit: 'cap', unit_plural: 'caps')
+ create(:cost_type, name: "Post-war", unit: "cap", unit_plural: "caps")
end
let!(:cost_type_2) do
- create(:cost_type, name: 'Foobar', unit: 'bar', unit_plural: 'bars')
+ create(:cost_type, name: "Foobar", unit: "bar", unit_plural: "bars")
end
- it 'can switch between them' do
+ it "can switch between them" do
visit projects_budgets_path(project)
click_on("Add budget")
expect(page).to have_content "New budget"
- fill_in 'Subject', with: 'My subject'
- fill_in 'budget_new_material_budget_item_attributes_0_units', with: 15
+ fill_in "Subject", with: "My subject"
+ fill_in "budget_new_material_budget_item_attributes_0_units", with: 15
# change cost type
- select 'Foobar', from: 'budget_new_material_budget_item_attributes_0_cost_type_id'
+ select "Foobar", from: "budget_new_material_budget_item_attributes_0_cost_type_id"
click_on "Create"
expect(page).to have_content "Successful creation"
expect(page).to have_content "My subject"
- expect(page).to have_css('.material_budget_items td.units', text: '15.00')
- expect(page).to have_css('.material_budget_items td', text: 'Foobar')
+ expect(page).to have_css(".material_budget_items td.units", text: "15.00")
+ expect(page).to have_css(".material_budget_items td", text: "Foobar")
end
end
- it 'create the budget' do
+ it "create the budget" do
visit new_projects_budget_path(project)
- fill_in("Subject", with: 'My subject')
+ fill_in("Subject", with: "My subject")
click_on "Create"
@@ -89,9 +89,9 @@
expect(page).to have_content "My subject"
end
- context 'with cost items' do
+ context "with cost items" do
let(:cost_type) do
- create(:cost_type, name: 'Post-war', unit: 'cap', unit_plural: 'caps')
+ create(:cost_type, name: "Post-war", unit: "cap", unit_plural: "caps")
end
let(:new_budget_page) { Pages::NewBudget.new project.identifier }
@@ -104,71 +104,71 @@
create(:default_hourly_rate, user:, rate: 25.0, valid_from: 1.year.ago)
end
- context 'with german locale' do
+ context "with german locale" do
let(:user) { create(:admin, language: :de) }
- it 'creates the budget including the given cost items with german locale' do
+ it "creates the budget including the given cost items with german locale" do
I18n.locale = :de
new_budget_page.visit!
- fill_in Budget.human_attribute_name(:subject, locale: :de), with: 'First Aid'
+ fill_in Budget.human_attribute_name(:subject, locale: :de), with: "First Aid"
- new_budget_page.add_unit_costs! '3,50', comment: 'RadAway', expected_costs: '175,00 EUR'
- new_budget_page.add_unit_costs! '1.000,50', comment: 'Rad-X', expected_costs: '50.025,00 EUR'
+ new_budget_page.add_unit_costs! "3,50", comment: "RadAway", expected_costs: "175,00 EUR"
+ new_budget_page.add_unit_costs! "1.000,50", comment: "Rad-X", expected_costs: "50.025,00 EUR"
- new_budget_page.add_labor_costs! '5000,10', user_name: user.name, comment: 'treatment', expected_costs: '125.002,50 EUR'
- new_budget_page.add_labor_costs! '0,5', user_name: user.name, comment: 'attendance', expected_costs: '12,50 EUR'
+ new_budget_page.add_labor_costs! "5000,10", user_name: user.name, comment: "treatment", expected_costs: "125.002,50 EUR"
+ new_budget_page.add_labor_costs! "0,5", user_name: user.name, comment: "attendance", expected_costs: "12,50 EUR"
page.find('[data-test-selector="budgets-create-button"]').click
expect(page).to have_content(I18n.t(:notice_successful_create, locale: :de))
- expect(new_budget_page.unit_costs_at(1)).to have_content '175,00 EUR'
- expect(new_budget_page.unit_costs_at(2)).to have_content '50.025,00 EUR'
- expect(new_budget_page.overall_unit_costs).to have_content '50.200,00 EUR'
+ expect(new_budget_page.unit_costs_at(1)).to have_content "175,00 EUR"
+ expect(new_budget_page.unit_costs_at(2)).to have_content "50.025,00 EUR"
+ expect(new_budget_page.overall_unit_costs).to have_content "50.200,00 EUR"
- expect(new_budget_page.labor_costs_at(1)).to have_content '125.002,50 EUR'
- expect(new_budget_page.labor_costs_at(2)).to have_content '12,50 EUR'
- expect(new_budget_page.overall_labor_costs).to have_content '125.015,00 EUR'
+ expect(new_budget_page.labor_costs_at(1)).to have_content "125.002,50 EUR"
+ expect(new_budget_page.labor_costs_at(2)).to have_content "12,50 EUR"
+ expect(new_budget_page.overall_labor_costs).to have_content "125.015,00 EUR"
click_on I18n.t(:button_update, locale: :de)
- budget_page.expect_planned_costs! type: :material, row: 1, expected: '175,00 EUR'
- budget_page.expect_planned_costs! type: :material, row: 2, expected: '50.025,00 EUR'
- budget_page.expect_planned_costs! type: :labor, row: 1, expected: '125.002,50 EUR'
- budget_page.expect_planned_costs! type: :labor, row: 2, expected: '12,50 EUR'
+ budget_page.expect_planned_costs! type: :material, row: 1, expected: "175,00 EUR"
+ budget_page.expect_planned_costs! type: :material, row: 2, expected: "50.025,00 EUR"
+ budget_page.expect_planned_costs! type: :labor, row: 1, expected: "125.002,50 EUR"
+ budget_page.expect_planned_costs! type: :labor, row: 2, expected: "12,50 EUR"
fields = page
- .all('input.budget-item-value')
+ .all("input.budget-item-value")
.select { |node| node.value.present? }
.map(&:value)
- expect(fields).to contain_exactly '3,50', '1.000,50', '5.000,10', '0,50'
+ expect(fields).to contain_exactly "3,50", "1.000,50", "5.000,10", "0,50"
end
end
- it 'creates the budget including the given cost items' do
+ it "creates the budget including the given cost items" do
new_budget_page.visit!
- fill_in 'Subject', with: 'First Aid'
+ fill_in "Subject", with: "First Aid"
- new_budget_page.add_unit_costs! 3, comment: 'RadAway'
- new_budget_page.add_unit_costs! 2, comment: 'Rad-X'
+ new_budget_page.add_unit_costs! 3, comment: "RadAway"
+ new_budget_page.add_unit_costs! 2, comment: "Rad-X"
- new_budget_page.add_labor_costs! 5, user_name: user.name, comment: 'treatment'
- new_budget_page.add_labor_costs! 2, user_name: user.name, comment: 'attendance'
+ new_budget_page.add_labor_costs! 5, user_name: user.name, comment: "treatment"
+ new_budget_page.add_labor_costs! 2, user_name: user.name, comment: "attendance"
- click_on 'Create'
- expect(page).to have_content('Successful creation')
+ click_on "Create"
+ expect(page).to have_content("Successful creation")
- expect(page).to have_css('td.currency', text: '150.00 EUR')
- expect(new_budget_page.unit_costs_at(1)).to have_content '150.00 EUR'
- expect(new_budget_page.unit_costs_at(2)).to have_content '100.00 EUR'
- expect(new_budget_page.overall_unit_costs).to have_content '250.00 EUR'
+ expect(page).to have_css("td.currency", text: "150.00 EUR")
+ expect(new_budget_page.unit_costs_at(1)).to have_content "150.00 EUR"
+ expect(new_budget_page.unit_costs_at(2)).to have_content "100.00 EUR"
+ expect(new_budget_page.overall_unit_costs).to have_content "250.00 EUR"
- expect(page).to have_css('td.currency', text: '125.00 EUR')
- expect(new_budget_page.labor_costs_at(1)).to have_content '125.00 EUR'
- expect(new_budget_page.labor_costs_at(2)).to have_content '50.00 EUR'
- expect(new_budget_page.overall_labor_costs).to have_content '175.00 EUR'
+ expect(page).to have_css("td.currency", text: "125.00 EUR")
+ expect(new_budget_page.labor_costs_at(1)).to have_content "125.00 EUR"
+ expect(new_budget_page.labor_costs_at(2)).to have_content "50.00 EUR"
+ expect(new_budget_page.overall_labor_costs).to have_content "175.00 EUR"
end
end
end
diff --git a/modules/budgets/spec/features/budgets/attachment_upload_spec.rb b/modules/budgets/spec/features/budgets/attachment_upload_spec.rb
index 1c53a46b48f8..ab10a6170cf0 100644
--- a/modules/budgets/spec/features/budgets/attachment_upload_spec.rb
+++ b/modules/budgets/spec/features/budgets/attachment_upload_spec.rb
@@ -26,16 +26,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/page_objects/notification'
+require "spec_helper"
+require "features/page_objects/notification"
-RSpec.describe 'Upload attachment to budget', :js do
+RSpec.describe "Upload attachment to budget", :js do
let(:user) do
create(:user, member_with_permissions: { project => %i[view_budgets edit_budgets] })
end
let(:project) { create(:project) }
let(:attachments) { Components::Attachments.new }
- let(:image_fixture) { UploadedFile.load_from('spec/fixtures/files/image.png') }
+ let(:image_fixture) { UploadedFile.load_from("spec/fixtures/files/image.png") }
let(:editor) { Components::WysiwygEditor.new }
let(:attachments_list) { Components::AttachmentsList.new }
@@ -43,62 +43,62 @@
login_as(user)
end
- it 'can upload an image to new and existing budgets via drag & drop' do
+ it "can upload an image to new and existing budgets via drag & drop" do
visit projects_budgets_path(project)
- within '.toolbar-items' do
+ within ".toolbar-items" do
click_on "Budget"
end
- fill_in "Subject", with: 'New budget'
+ fill_in "Subject", with: "New budget"
# adding an image
- editor.drag_attachment image_fixture.path, 'Image uploaded on creation'
+ editor.drag_attachment image_fixture.path, "Image uploaded on creation"
- editor.attachments_list.expect_attached('image.png')
+ editor.attachments_list.expect_attached("image.png")
- click_on 'Create'
+ click_on "Create"
- expect(page).to have_css('#content img', count: 1)
- expect(page).to have_content('Image uploaded on creation')
- attachments_list.expect_attached('image.png')
+ expect(page).to have_css("#content img", count: 1)
+ expect(page).to have_content("Image uploaded on creation")
+ attachments_list.expect_attached("image.png")
- within '.toolbar-items' do
+ within ".toolbar-items" do
click_on "Update"
end
- editor.drag_attachment image_fixture.path, 'Image uploaded the second time'
+ editor.drag_attachment image_fixture.path, "Image uploaded the second time"
- editor.attachments_list.expect_attached('image.png', count: 2)
+ editor.attachments_list.expect_attached("image.png", count: 2)
- click_on 'Submit'
+ click_on "Submit"
- expect(page).to have_css('#content img', count: 2)
- expect(page).to have_content('Image uploaded on creation')
- expect(page).to have_content('Image uploaded the second time')
- attachments_list.expect_attached('image.png', count: 2)
+ expect(page).to have_css("#content img", count: 2)
+ expect(page).to have_content("Image uploaded on creation")
+ expect(page).to have_content("Image uploaded the second time")
+ attachments_list.expect_attached("image.png", count: 2)
end
- it 'can upload an image to new and existing budgets via drag & drop on attachment list' do
+ it "can upload an image to new and existing budgets via drag & drop on attachment list" do
visit projects_budgets_path(project)
- within '.toolbar-items' do
+ within ".toolbar-items" do
click_on "Budget"
end
- fill_in "Subject", with: 'New budget'
+ fill_in "Subject", with: "New budget"
editor.set_markdown "Some content because it's required"
# adding an image
editor.attachments_list.drop(image_fixture)
- editor.attachments_list.expect_attached('image.png')
+ editor.attachments_list.expect_attached("image.png")
- click_on 'Create'
+ click_on "Create"
- attachments_list.expect_attached('image.png')
+ attachments_list.expect_attached("image.png")
- within '.toolbar-items' do
+ within ".toolbar-items" do
click_on "Update"
end
@@ -106,10 +106,10 @@
editor.attachments_list.drag_enter
editor.attachments_list.drop(image_fixture)
- editor.attachments_list.expect_attached('image.png', count: 2)
+ editor.attachments_list.expect_attached("image.png", count: 2)
- click_on 'Submit'
+ click_on "Submit"
- attachments_list.expect_attached('image.png', count: 2)
+ attachments_list.expect_attached("image.png", count: 2)
end
end
diff --git a/modules/budgets/spec/features/budgets/copy_budget_spec.rb b/modules/budgets/spec/features/budgets/copy_budget_spec.rb
index 98deeba1488d..f6b9918e0ed1 100644
--- a/modules/budgets/spec/features/budgets/copy_budget_spec.rb
+++ b/modules/budgets/spec/features/budgets/copy_budget_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper.rb")
-RSpec.describe 'Copying a budget', :js do
+RSpec.describe "Copying a budget", :js do
let(:project) { create(:project, enabled_module_names: %i[budgets costs]) }
let(:current_user) do
create(:user,
@@ -45,7 +45,7 @@
project:)
end
let!(:cost_type) do
- create(:cost_type, name: 'Post-war', unit: 'cap', unit_plural: 'caps')
+ create(:cost_type, name: "Post-war", unit: "cap", unit_plural: "caps")
end
let!(:cost_type_rate) { create(:cost_rate, cost_type:, rate: 50.0) }
let!(:default_hourly_rate) { create(:default_hourly_rate, user: original_author, rate: 25.0) }
@@ -75,22 +75,22 @@
login_as(current_user)
end
- it 'copies all the items of the budget under the name of the copying user' do
+ it "copies all the items of the budget under the name of the copying user" do
budget_page.visit!
budget_page.click_copy
budget_page.expect_subject(budget_subject)
- budget_page.expect_planned_costs!(type: :labor, row: 1, expected: '125.00 EUR')
- budget_page.expect_planned_costs!(type: :material, row: 1, expected: '150.00 EUR')
- budget_page.expect_planned_costs!(type: :material, row: 2, expected: '600,000.00 EUR')
+ budget_page.expect_planned_costs!(type: :labor, row: 1, expected: "125.00 EUR")
+ budget_page.expect_planned_costs!(type: :material, row: 1, expected: "150.00 EUR")
+ budget_page.expect_planned_costs!(type: :material, row: 2, expected: "600,000.00 EUR")
- click_button 'Create'
+ click_button "Create"
- budget_page.expect_toast message: 'Successful creation.'
+ budget_page.expect_toast message: "Successful creation."
expect(page)
- .to have_css('.author', text: current_user.name)
+ .to have_css(".author", text: current_user.name)
end
end
diff --git a/modules/budgets/spec/features/budgets/delete_budget_spec.rb b/modules/budgets/spec/features/budgets/delete_budget_spec.rb
index 283f43ee024d..f8beb62b9d8c 100644
--- a/modules/budgets/spec/features/budgets/delete_budget_spec.rb
+++ b/modules/budgets/spec/features/budgets/delete_budget_spec.rb
@@ -28,7 +28,7 @@
require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper.rb")
-RSpec.describe 'Deleting a budget', :js do
+RSpec.describe "Deleting a budget", :js do
let(:project) { create(:project, enabled_module_names: %i[budgets costs]) }
let(:user) { create(:admin) }
let(:budget_subject) { "A budget subject" }
@@ -49,8 +49,8 @@
budget_page.visit!
end
- context 'when no WP are assigned to this budget' do
- it 'simply deletes the budget without additional checks' do
+ context "when no WP are assigned to this budget" do
+ it "simply deletes the budget without additional checks" do
# Delete the budget
budget_page.click_delete
@@ -59,7 +59,7 @@
end
end
- context 'when WPs are assigned to this budget' do
+ context "when WPs are assigned to this budget" do
let(:wp1) { create(:work_package, project:, budget:) }
let(:wp2) { create(:work_package, project:, budget:) }
let(:budget_destroy_info_page) { Pages::DestroyInfo.new budget }
@@ -69,7 +69,7 @@
wp2
end
- context 'with no other budget to assign to' do
+ context "with no other budget to assign to" do
before do
# When deleting with WPs assigned we get to the destroy_info page
budget_page.click_delete
@@ -79,7 +79,7 @@
budget_destroy_info_page.expect_delete_option
end
- it 'deletes the budget from the WPs' do
+ it "deletes the budget from the WPs" do
# Select to delete the budget from the WPs
budget_destroy_info_page.expect_no_reassign_option
budget_destroy_info_page.select_delete_option
@@ -98,10 +98,10 @@
end
end
- context 'with another budget to assign to' do
+ context "with another budget to assign to" do
let(:budget2) do
create(:budget,
- subject: 'Another budget',
+ subject: "Another budget",
description: budget_description,
author: user,
project:)
@@ -118,7 +118,7 @@
budget_destroy_info_page.expect_delete_option
end
- it 'reassigns the WP to another budget' do
+ it "reassigns the WP to another budget" do
# Select reassign
budget_destroy_info_page.expect_reassign_option
budget_destroy_info_page.select_reassign_option budget2.subject
diff --git a/modules/budgets/spec/features/budgets/update_budget_spec.rb b/modules/budgets/spec/features/budgets/update_budget_spec.rb
index 1907db607702..ae5fbcf95480 100644
--- a/modules/budgets/spec/features/budgets/update_budget_spec.rb
+++ b/modules/budgets/spec/features/budgets/update_budget_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper.rb")
-RSpec.describe 'updating a budget', :js do
+RSpec.describe "updating a budget", :js do
let(:project) do
create(:project_with_types,
enabled_module_names: %i[budgets costs work_package_tracking],
@@ -39,9 +39,9 @@
current_user { user }
- describe 'with new cost items', :with_cuprite do
+ describe "with new cost items", :with_cuprite do
let(:cost_type) do
- create(:cost_type, name: 'Post-war', unit: 'cap', unit_plural: 'caps')
+ create(:cost_type, name: "Post-war", unit: "cap", unit_plural: "caps")
end
let(:budget_page) { Pages::EditBudget.new budget.id }
@@ -51,28 +51,28 @@
create(:default_hourly_rate, user:, rate: 25.0, valid_from: 1.day.ago)
end
- it 'creates the cost items' do
+ it "creates the cost items" do
budget_page.visit!
- click_on 'Update'
+ click_on "Update"
- budget_page.add_unit_costs! 3, comment: 'Stimpak', expected_costs: '150.00 EUR'
- budget_page.add_labor_costs! 5, user_name: user.name, comment: 'treatment', expected_costs: '125.00 EUR'
+ budget_page.add_unit_costs! 3, comment: "Stimpak", expected_costs: "150.00 EUR"
+ budget_page.add_labor_costs! 5, user_name: user.name, comment: "treatment", expected_costs: "125.00 EUR"
- click_on 'Submit'
- expect(budget_page).to have_content('Successful update')
+ click_on "Submit"
+ expect(budget_page).to have_content("Successful update")
- expect(page).to have_css('tbody td.currency', text: '150.00 EUR')
- expect(budget_page.overall_unit_costs).to have_content '150.00 EUR'
+ expect(page).to have_css("tbody td.currency", text: "150.00 EUR")
+ expect(budget_page.overall_unit_costs).to have_content "150.00 EUR"
- expect(page).to have_css('tbody td.currency', text: '125.00 EUR')
- expect(budget_page.labor_costs_at(1)).to have_content '125.00 EUR'
- expect(budget_page.overall_labor_costs).to have_content '125.00 EUR'
+ expect(page).to have_css("tbody td.currency", text: "125.00 EUR")
+ expect(budget_page.labor_costs_at(1)).to have_content "125.00 EUR"
+ expect(budget_page.overall_labor_costs).to have_content "125.00 EUR"
end
end
- describe 'with existing cost items' do
+ describe "with existing cost items" do
let(:cost_type) do
- create(:cost_type, name: 'Post-war', unit: 'cap', unit_plural: 'caps')
+ create(:cost_type, name: "Post-war", unit: "cap", unit_plural: "caps")
end
let(:material_budget_item) do
@@ -100,41 +100,41 @@
labor_budget_item
end
- it 'updates the cost items' do
+ it "updates the cost items" do
budget_page.visit!
- click_on 'Update'
+ click_on "Update"
- budget_page.expect_planned_costs! type: :material, row: 1, expected: '150.00 EUR'
- budget_page.expect_planned_costs! type: :labor, row: 1, expected: '125.00 EUR'
+ budget_page.expect_planned_costs! type: :material, row: 1, expected: "150.00 EUR"
+ budget_page.expect_planned_costs! type: :labor, row: 1, expected: "125.00 EUR"
budget_page.edit_unit_costs! material_budget_item.id,
units: 5,
- comment: 'updated num stimpaks'
+ comment: "updated num stimpaks"
budget_page.edit_labor_costs! labor_budget_item.id,
hours: 3,
user_name: user.name,
- comment: 'updated treatment duration'
+ comment: "updated treatment duration"
# Test for updated planned costs (Regression #31247)
- budget_page.expect_planned_costs! type: :material, row: 1, expected: '250.00 EUR'
- budget_page.expect_planned_costs! type: :labor, row: 1, expected: '75.00 EUR'
+ budget_page.expect_planned_costs! type: :material, row: 1, expected: "250.00 EUR"
+ budget_page.expect_planned_costs! type: :labor, row: 1, expected: "75.00 EUR"
- click_on 'Submit'
- expect(budget_page).to have_content('Successful update')
+ click_on "Submit"
+ expect(budget_page).to have_content("Successful update")
- expect(page).to have_css('tbody td.currency', text: '250.00 EUR')
- expect(budget_page.unit_costs_at(1)).to have_content '250.00 EUR'
- expect(budget_page.overall_unit_costs).to have_content '250.00 EUR'
+ expect(page).to have_css("tbody td.currency", text: "250.00 EUR")
+ expect(budget_page.unit_costs_at(1)).to have_content "250.00 EUR"
+ expect(budget_page.overall_unit_costs).to have_content "250.00 EUR"
- expect(page).to have_css('tbody td.currency', text: '75.00 EUR')
- expect(budget_page.labor_costs_at(1)).to have_content '75.00 EUR'
- expect(budget_page.overall_labor_costs).to have_content '75.00 EUR'
+ expect(page).to have_css("tbody td.currency", text: "75.00 EUR")
+ expect(budget_page.labor_costs_at(1)).to have_content "75.00 EUR"
+ expect(budget_page.overall_labor_costs).to have_content "75.00 EUR"
end
- context 'with german locale' do
+ context "with german locale" do
let(:user) { create(:admin, language: :de) }
let(:cost_type2) do
- create(:cost_type, name: 'ABC', unit: 'abc', unit_plural: 'abcs')
+ create(:cost_type, name: "ABC", unit: "abc", unit_plural: "abcs")
end
let(:material_budget_item2) do
@@ -145,29 +145,29 @@
amount: 1000.0)
end
- it 'retains the overridden budget when opening, but not editing (Regression #32822)' do
+ it "retains the overridden budget when opening, but not editing (Regression #32822)" do
material_budget_item2
budget_page.visit!
click_on I18n.t(:button_update, locale: :de)
- budget_page.expect_planned_costs! type: :material, row: 1, expected: '150,00 EUR'
- budget_page.expect_planned_costs! type: :material, row: 2, expected: '1.000,00 EUR'
- budget_page.expect_planned_costs! type: :labor, row: 1, expected: '125,00 EUR'
+ budget_page.expect_planned_costs! type: :material, row: 1, expected: "150,00 EUR"
+ budget_page.expect_planned_costs! type: :material, row: 2, expected: "1.000,00 EUR"
+ budget_page.expect_planned_costs! type: :labor, row: 1, expected: "125,00 EUR"
# Open first item
budget_page.open_edit_planned_costs! material_budget_item.id, type: :material
expect(page).to have_field("budget_existing_material_budget_item_attributes_#{material_budget_item.id}_amount")
- click_on 'OK'
+ click_on "OK"
expect(budget_page).to have_content(I18n.t(:notice_successful_update, locale: :de))
- expect(page).to have_css('tbody td.currency', text: '150,00 EUR')
- expect(page).to have_css('tbody td.currency', text: '1.000,00 EUR')
- expect(page).to have_css('tbody td.currency', text: '125,00 EUR')
+ expect(page).to have_css("tbody td.currency", text: "150,00 EUR")
+ expect(page).to have_css("tbody td.currency", text: "1.000,00 EUR")
+ expect(page).to have_css("tbody td.currency", text: "125,00 EUR")
end
end
- context 'with two material budget items' do
+ context "with two material budget items" do
let!(:material_budget_item_2) do
create(:material_budget_item,
units: 5,
@@ -175,22 +175,22 @@
budget:)
end
- it 'keeps previous planned material costs (Regression test #27692)' do
+ it "keeps previous planned material costs (Regression test #27692)" do
budget_page.visit!
- click_on 'Update'
+ click_on "Update"
# Update first element
budget_page.edit_planned_costs! material_budget_item.id, type: :material, costs: 123
- expect(budget_page).to have_content('Successful update')
- expect(page).to have_css('tbody td.currency', text: '123.00 EUR')
+ expect(budget_page).to have_content("Successful update")
+ expect(page).to have_css("tbody td.currency", text: "123.00 EUR")
- click_on 'Update'
+ click_on "Update"
# Update second element
budget_page.edit_planned_costs! material_budget_item_2.id, type: :material, costs: 543
- expect(budget_page).to have_content('Successful update')
- expect(page).to have_css('tbody td.currency', text: '123.00 EUR')
- expect(page).to have_css('tbody td.currency', text: '543.00 EUR')
+ expect(budget_page).to have_content("Successful update")
+ expect(page).to have_css("tbody td.currency", text: "123.00 EUR")
+ expect(page).to have_css("tbody td.currency", text: "543.00 EUR")
# Expect overridden costs on both
material_budget_item.reload
@@ -205,29 +205,29 @@
expect(material_budget_item_2.costs).to eq(543.0)
end
- context 'with a reversed currency format' do
+ context "with a reversed currency format" do
before do
allow(Setting)
.to receive(:plugin_costs)
- .and_return({ costs_currency_format: '%u %n', costs_currency: 'USD' }.with_indifferent_access)
+ .and_return({ costs_currency_format: "%u %n", costs_currency: "USD" }.with_indifferent_access)
end
- it 'can still update budgets (Regression test #32664)' do
+ it "can still update budgets (Regression test #32664)" do
budget_page.visit!
- click_on 'Update'
+ click_on "Update"
# Update first element
budget_page.edit_planned_costs! material_budget_item.id, type: :material, costs: 123
- expect(budget_page).to have_content('Successful update')
- expect(page).to have_css('tbody td.currency', text: 'USD 123.00')
+ expect(budget_page).to have_content("Successful update")
+ expect(page).to have_css("tbody td.currency", text: "USD 123.00")
- click_on 'Update'
+ click_on "Update"
# Update second element
budget_page.edit_planned_costs! material_budget_item_2.id, type: :material, costs: 543
- expect(budget_page).to have_content('Successful update')
- expect(page).to have_css('tbody td.currency', text: 'USD 123.00')
- expect(page).to have_css('tbody td.currency', text: 'USD 543.00')
+ expect(budget_page).to have_content("Successful update")
+ expect(page).to have_css("tbody td.currency", text: "USD 123.00")
+ expect(page).to have_css("tbody td.currency", text: "USD 543.00")
# Expect overridden costs on both
material_budget_item.reload
@@ -244,7 +244,7 @@
end
end
- context 'with two labor budget items' do
+ context "with two labor budget items" do
let!(:labor_budget_item_2) do
create(:labor_budget_item,
hours: 5,
@@ -252,22 +252,22 @@
budget:)
end
- it 'keeps previous planned labor costs (Regression test #27692)' do
+ it "keeps previous planned labor costs (Regression test #27692)" do
budget_page.visit!
- click_on 'Update'
+ click_on "Update"
# Update first element
budget_page.edit_planned_costs! labor_budget_item.id, type: :labor, costs: 456
- expect(budget_page).to have_content('Successful update')
- expect(page).to have_css('tbody td.currency', text: '456.00 EUR')
+ expect(budget_page).to have_content("Successful update")
+ expect(page).to have_css("tbody td.currency", text: "456.00 EUR")
- click_on 'Update'
+ click_on "Update"
# Update second element
budget_page.edit_planned_costs! labor_budget_item_2.id, type: :labor, costs: 987
- expect(budget_page).to have_content('Successful update')
- expect(page).to have_css('tbody td.currency', text: '456.00 EUR')
- expect(page).to have_css('tbody td.currency', text: '987.00 EUR')
+ expect(budget_page).to have_content("Successful update")
+ expect(page).to have_css("tbody td.currency", text: "456.00 EUR")
+ expect(page).to have_css("tbody td.currency", text: "987.00 EUR")
# Expect overridden costs on both
labor_budget_item.reload
@@ -282,29 +282,29 @@
expect(labor_budget_item_2.costs).to eq(987.0)
end
- context 'with a reversed currency format' do
+ context "with a reversed currency format" do
before do
allow(Setting)
.to receive(:plugin_costs)
- .and_return({ costs_currency_format: '%u %n', costs_currency: 'USD' }.with_indifferent_access)
+ .and_return({ costs_currency_format: "%u %n", costs_currency: "USD" }.with_indifferent_access)
end
- it 'can still update budgets (Regression test #32664)' do
+ it "can still update budgets (Regression test #32664)" do
budget_page.visit!
- click_on 'Update'
+ click_on "Update"
# Update first element
budget_page.edit_planned_costs! labor_budget_item.id, type: :labor, costs: 456
- expect(budget_page).to have_content('Successful update')
- expect(page).to have_css('tbody td.currency', text: 'USD 456.00')
+ expect(budget_page).to have_content("Successful update")
+ expect(page).to have_css("tbody td.currency", text: "USD 456.00")
- click_on 'Update'
+ click_on "Update"
# Update second element
budget_page.edit_planned_costs! labor_budget_item_2.id, type: :labor, costs: 987
- expect(budget_page).to have_content('Successful update')
- expect(page).to have_css('tbody td.currency', text: 'USD 456.00')
- expect(page).to have_css('tbody td.currency', text: 'USD 987.00')
+ expect(budget_page).to have_content("Successful update")
+ expect(page).to have_css("tbody td.currency", text: "USD 456.00")
+ expect(page).to have_css("tbody td.currency", text: "USD 987.00")
# Expect overridden costs on both
labor_budget_item.reload
@@ -321,15 +321,15 @@
end
end
- it 'removes existing cost items' do
+ it "removes existing cost items" do
budget_page.visit!
- click_on 'Update'
+ click_on "Update"
page.find("#budget_existing_labor_budget_item_attributes_#{labor_budget_item.id} a.delete-budget-item").click
- click_on 'Submit'
+ click_on "Submit"
- expect(budget_page.labor_costs_at(1)).to have_no_content '125.00 EUR'
+ expect(budget_page.labor_costs_at(1)).to have_no_content "125.00 EUR"
end
end
end
diff --git a/modules/budgets/spec/features/costs_edit_fields_spec.rb b/modules/budgets/spec/features/costs_edit_fields_spec.rb
index 0e90b5c23c6c..2da48e444dc4 100644
--- a/modules/budgets/spec/features/costs_edit_fields_spec.rb
+++ b/modules/budgets/spec/features/costs_edit_fields_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper.rb")
-RSpec.describe 'Work Package budget fields', :js do
+RSpec.describe "Work Package budget fields", :js do
let(:type_task) { create(:type_task) }
let!(:status) { create(:status, is_default: true) }
let!(:priority) { create(:priority, is_default: true) }
@@ -43,20 +43,20 @@
login_as(user)
end
- it 'does not show read-only fields and allows setting the budget' do
+ it "does not show read-only fields and allows setting the budget" do
create_page.visit!
- expect(page).to have_css('.inline-edit--container.budget')
- expect(page).to have_no_css('.inline-edit--container.laborCosts')
- expect(page).to have_no_css('.inline-edit--container.materialCosts')
- expect(page).to have_no_css('.inline-edit--container.overallCosts')
+ expect(page).to have_css(".inline-edit--container.budget")
+ expect(page).to have_no_css(".inline-edit--container.laborCosts")
+ expect(page).to have_no_css(".inline-edit--container.materialCosts")
+ expect(page).to have_no_css(".inline-edit--container.overallCosts")
field = create_page.edit_field(:budget)
field.set_value budget.name
- page.find('.ng-dropdown-panel .ng-option', text: budget.name).click
+ page.find(".ng-dropdown-panel .ng-option", text: budget.name).click
field = create_page.edit_field(:subject)
- field.set_value 'Some subject'
+ field.set_value "Some subject"
create_page.save!
diff --git a/modules/budgets/spec/features/work_package_filter_spec.rb b/modules/budgets/spec/features/work_package_filter_spec.rb
index b21a5d93a602..ace88d2f08a1 100644
--- a/modules/budgets/spec/features/work_package_filter_spec.rb
+++ b/modules/budgets/spec/features/work_package_filter_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Filter by budget', :js do
+RSpec.describe "Filter by budget", :js do
let(:user) { create(:admin) }
let(:project) { create(:project) }
@@ -70,21 +70,21 @@
wp_table.visit!
end
- it 'allows filtering for budgets' do
+ it "allows filtering for budgets" do
wp_table.expect_work_package_listed work_package_with_budget, work_package_without_budget
filters.expect_filter_count 1
filters.open
- filters.add_filter_by('Budget', 'is (OR)', budget.name)
+ filters.add_filter_by("Budget", "is (OR)", budget.name)
wp_table.expect_work_package_listed work_package_with_budget
wp_table.ensure_work_package_not_listed! work_package_without_budget
- wp_table.save_as('Some query name')
+ wp_table.save_as("Some query name")
- wp_table.expect_and_dismiss_toaster message: 'Successful creation.'
+ wp_table.expect_and_dismiss_toaster message: "Successful creation."
- filters.remove_filter 'budget'
+ filters.remove_filter "budget"
wp_table.expect_work_package_listed work_package_with_budget, work_package_without_budget
@@ -97,6 +97,6 @@
filters.open
- filters.expect_filter_by('Budget', 'is (OR)', budget.name)
+ filters.expect_filter_by("Budget", "is (OR)", budget.name)
end
end
diff --git a/modules/budgets/spec/helpers/budgets_helper_spec.rb b/modules/budgets/spec/helpers/budgets_helper_spec.rb
index 476f2ebbfad9..616625da1e04 100644
--- a/modules/budgets/spec/helpers/budgets_helper_spec.rb
+++ b/modules/budgets/spec/helpers/budgets_helper_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.dirname(__FILE__) + '/../spec_helper'
+require File.dirname(__FILE__) + "/../spec_helper"
RSpec.describe BudgetsHelper do
let(:project) { build(:project) }
let(:budget) { build(:budget, project:) }
- describe '#budgets_to_csv' do
- describe 'WITH a list of one cost object' do
- it 'outputs the cost objects attributes' do
+ describe "#budgets_to_csv" do
+ describe "WITH a list of one cost object" do
+ it "outputs the cost objects attributes" do
expected = [
budget.id,
budget.project.name,
@@ -52,9 +52,9 @@
expect(budgets_to_csv([budget]).include?(expected)).to be_truthy
end
- it 'starts with a header explaining the fields' do
+ it "starts with a header explaining the fields" do
expected = [
- '#',
+ "#",
Project.model_name.human,
Budget.human_attribute_name(:subject),
Budget.human_attribute_name(:author),
diff --git a/modules/budgets/spec/lib/api/v3/budgets/budget_representer_spec.rb b/modules/budgets/spec/lib/api/v3/budgets/budget_representer_spec.rb
index ede95378a5fe..01bdc2c12367 100644
--- a/modules/budgets/spec/lib/api/v3/budgets/budget_representer_spec.rb
+++ b/modules/budgets/spec/lib/api/v3/budgets/budget_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Budgets::BudgetRepresenter do
include API::V3::Utilities::PathHelper
@@ -48,39 +48,39 @@
let(:representer) { described_class.new(budget, current_user: user) }
- context 'generation' do
+ context "generation" do
subject(:generated) { representer.to_json }
- describe 'self link' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "self link" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.budget(budget.id) }
let(:title) { budget.subject }
end
end
- it_behaves_like 'has an untitled link' do
+ it_behaves_like "has an untitled link" do
let(:link) { :attachments }
let(:href) { api_v3_paths.attachments_by_budget budget.id }
end
- it_behaves_like 'has an untitled action link' do
+ it_behaves_like "has an untitled action link" do
let(:link) { :addAttachment }
let(:href) { api_v3_paths.attachments_by_budget budget.id }
let(:method) { :post }
let(:permission) { :edit_budgets }
end
- it 'indicates its type' do
- expect(subject).to be_json_eql('Budget'.to_json).at_path('_type')
+ it "indicates its type" do
+ expect(subject).to be_json_eql("Budget".to_json).at_path("_type")
end
- it 'indicates its id' do
- expect(subject).to be_json_eql(budget.id.to_json).at_path('id')
+ it "indicates its id" do
+ expect(subject).to be_json_eql(budget.id.to_json).at_path("id")
end
- it 'indicates its subject' do
- expect(subject).to be_json_eql(budget.subject.to_json).at_path('subject')
+ it "indicates its subject" do
+ expect(subject).to be_json_eql(budget.subject.to_json).at_path("subject")
end
end
end
diff --git a/modules/budgets/spec/lib/api/v3/path_helper_spec.rb b/modules/budgets/spec/lib/api/v3/path_helper_spec.rb
index 2278f2c55269..48b2e61161e3 100644
--- a/modules/budgets/spec/lib/api/v3/path_helper_spec.rb
+++ b/modules/budgets/spec/lib/api/v3/path_helper_spec.rb
@@ -26,32 +26,32 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Utilities::PathHelper do
let(:helper) { Class.new.tap { |c| c.extend(described_class) }.api_v3_paths }
- describe '#budget' do
+ describe "#budget" do
subject { helper.budget 42 }
- it { is_expected.to eql('/api/v3/budgets/42') }
+ it { is_expected.to eql("/api/v3/budgets/42") }
end
- describe '#budget' do
+ describe "#budget" do
subject { helper.budget 42 }
- it { is_expected.to eql('/api/v3/budgets/42') }
+ it { is_expected.to eql("/api/v3/budgets/42") }
end
- describe '#budgets_by_project' do
+ describe "#budgets_by_project" do
subject { helper.budgets_by_project 42 }
- it { is_expected.to eql('/api/v3/projects/42/budgets') }
+ it { is_expected.to eql("/api/v3/projects/42/budgets") }
end
- describe '#attachments_by_budget' do
+ describe "#attachments_by_budget" do
subject { helper.attachments_by_budget 42 }
- it { is_expected.to eql('/api/v3/budgets/42/attachments') }
+ it { is_expected.to eql("/api/v3/budgets/42/attachments") }
end
end
diff --git a/modules/budgets/spec/lib/api/v3/queries/schemas/cost_object_dependency_representer_spec.rb b/modules/budgets/spec/lib/api/v3/queries/schemas/cost_object_dependency_representer_spec.rb
index 97931b26a9a2..72c570daf203 100644
--- a/modules/budgets/spec/lib/api/v3/queries/schemas/cost_object_dependency_representer_spec.rb
+++ b/modules/budgets/spec/lib/api/v3/queries/schemas/cost_object_dependency_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::BudgetFilterDependencyRepresenter do
include API::V3::Utilities::PathHelper
@@ -43,40 +43,40 @@
subject(:generated) { instance.to_json }
- context 'generation' do
- context 'properties' do
- describe 'values' do
- let(:path) { 'values' }
- let(:type) { '[]Budget' }
+ context "generation" do
+ context "properties" do
+ describe "values" do
+ let(:path) { "values" }
+ let(:type) { "[]Budget" }
let(:href) { api_v3_paths.budgets_by_project project.id }
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::OpenWorkPackages'" do
let(:operator) { Queries::Operators::All }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
context "for operator 'Queries::Operators::ClosedWorkPackages'" do
let(:operator) { Queries::Operators::None }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
before do
@@ -84,14 +84,14 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::NotEquals)
expect(instance)
@@ -100,7 +100,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
diff --git a/modules/budgets/spec/models/budget_spec.rb b/modules/budgets/spec/models/budget_spec.rb
index 68707c6d2f49..27d0d78c88f5 100644
--- a/modules/budgets/spec/models/budget_spec.rb
+++ b/modules/budgets/spec/models/budget_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.dirname(__FILE__) + '/../spec_helper'
+require File.dirname(__FILE__) + "/../spec_helper"
RSpec.describe Budget do
let(:budget) { build(:budget, project:) }
@@ -34,7 +34,7 @@
let(:project) { create(:project_with_types) }
let(:user) { create(:user) }
- describe 'destroy' do
+ describe "destroy" do
let(:work_package) { create(:work_package, project:) }
before do
@@ -50,22 +50,22 @@
it { expect(work_package.reload.budget).to be_nil }
end
- describe '#existing_material_budget_item_attributes=' do
+ describe "#existing_material_budget_item_attributes=" do
let!(:existing_material_budget_item) do
create(:material_budget_item, budget:, units: 10.0)
budget.material_budget_items.reload.first
end
- context 'allowed to edit budgets' do
+ context "allowed to edit budgets" do
before do
mock_permissions_for(User.current) do |mock|
mock.allow_in_project :edit_budgets, project:
end
end
- context 'with a non integer value' do
- it 'updates the item' do
+ context "with a non integer value" do
+ it "updates the item" do
budget.existing_material_budget_item_attributes = { existing_material_budget_item.id.to_s.to_sym => { units: "0.5" } }
expect(existing_material_budget_item.units)
@@ -73,8 +73,8 @@
end
end
- context 'with no value' do
- it 'deletes the item' do
+ context "with no value" do
+ it "deletes the item" do
budget.existing_material_budget_item_attributes = { existing_material_budget_item.id.to_s.to_sym => {} }
expect(existing_material_budget_item)
diff --git a/modules/budgets/spec/models/labor_budget_item_spec.rb b/modules/budgets/spec/models/labor_budget_item_spec.rb
index ef7d40670f20..d86fec5a681c 100644
--- a/modules/budgets/spec/models/labor_budget_item_spec.rb
+++ b/modules/budgets/spec/models/labor_budget_item_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.dirname(__FILE__) + '/../spec_helper'
+require File.dirname(__FILE__) + "/../spec_helper"
RSpec.describe LaborBudgetItem do
let(:item) { build(:labor_budget_item, budget:, user:) }
@@ -49,10 +49,10 @@ def is_member(project, user, permissions)
roles: [create(:project_role, permissions:)])
end
- describe '#calculated_costs' do
- let(:default_costs) { '0.0'.to_f }
+ describe "#calculated_costs" do
+ let(:default_costs) { "0.0".to_f }
- describe 'WHEN no user is associated' do
+ describe "WHEN no user is associated" do
before do
item.user = nil
end
@@ -60,7 +60,7 @@ def is_member(project, user, permissions)
it { expect(item.calculated_costs).to eq(default_costs) }
end
- describe 'WHEN no hours are defined' do
+ describe "WHEN no hours are defined" do
before do
item.hours = nil
end
@@ -68,7 +68,7 @@ def is_member(project, user, permissions)
it { expect(item.calculated_costs).to eq(default_costs) }
end
- describe 'WHEN user, hours and rate are defined' do
+ describe "WHEN user, hours and rate are defined" do
before do
project.save!
item.hours = 5.0
@@ -96,8 +96,8 @@ def is_member(project, user, permissions)
end
end
- describe '#user' do
- describe 'WHEN an existing user is provided' do
+ describe "#user" do
+ describe "WHEN an existing user is provided" do
before do
item.save!
item.reload
@@ -108,7 +108,7 @@ def is_member(project, user, permissions)
it { expect(item.user).to eq(user) }
end
- describe 'WHEN a group is provided' do
+ describe "WHEN a group is provided" do
let(:group) { create(:group) }
before do
@@ -121,7 +121,7 @@ def is_member(project, user, permissions)
it { expect(item.principal).to eq(group) }
end
- describe 'WHEN a non existing user is provided (i.e. the user has been deleted)' do
+ describe "WHEN a non existing user is provided (i.e. the user has been deleted)" do
before do
item.save!
item.reload
@@ -135,61 +135,61 @@ def is_member(project, user, permissions)
end
end
- describe '#valid?' do
- describe 'WHEN hours, budget and user are provided' do
- it 'is valid' do
+ describe "#valid?" do
+ describe "WHEN hours, budget and user are provided" do
+ it "is valid" do
expect(item).to be_valid
end
end
- describe 'WHEN no hours are provided' do
+ describe "WHEN no hours are provided" do
before do
item.hours = nil
end
- it 'is not valid' do
+ it "is not valid" do
expect(item).not_to be_valid
- expect(item.errors[:hours]).to eq([I18n.t('activerecord.errors.messages.not_a_number')])
+ expect(item.errors[:hours]).to eq([I18n.t("activerecord.errors.messages.not_a_number")])
end
end
- describe 'WHEN hours are provided as nontransformable string' do
+ describe "WHEN hours are provided as nontransformable string" do
before do
- item.hours = 'test'
+ item.hours = "test"
end
- it 'is not valid' do
+ it "is not valid" do
expect(item).not_to be_valid
- expect(item.errors[:hours]).to eq([I18n.t('activerecord.errors.messages.not_a_number')])
+ expect(item.errors[:hours]).to eq([I18n.t("activerecord.errors.messages.not_a_number")])
end
end
- describe 'WHEN no budget is provided' do
+ describe "WHEN no budget is provided" do
before do
item.budget = nil
end
- it 'is not valid' do
+ it "is not valid" do
expect(item).not_to be_valid
- expect(item.errors[:budget]).to eq([I18n.t('activerecord.errors.messages.blank')])
+ expect(item.errors[:budget]).to eq([I18n.t("activerecord.errors.messages.blank")])
end
end
- describe 'WHEN no user is provided' do
+ describe "WHEN no user is provided" do
before do
item.user = nil
end
- it 'is not valid' do
+ it "is not valid" do
expect(item).not_to be_valid
- expect(item.errors[:user]).to eq([I18n.t('activerecord.errors.messages.blank')])
+ expect(item.errors[:user]).to eq([I18n.t("activerecord.errors.messages.blank")])
end
end
end
- describe '#costs_visible_by?' do
+ describe "#costs_visible_by?" do
before do
- project.enabled_module_names = project.enabled_module_names << 'costs'
+ project.enabled_module_names = project.enabled_module_names << "costs"
end
describe "WHEN the item is assigned to the user
diff --git a/modules/budgets/spec/models/permitted_params_spec.rb b/modules/budgets/spec/models/permitted_params_spec.rb
index ad1d8f8aaea5..46a1929fc350 100644
--- a/modules/budgets/spec/models/permitted_params_spec.rb
+++ b/modules/budgets/spec/models/permitted_params_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe PermittedParams do
let(:user) { build(:user) }
- shared_examples_for 'allows params' do
+ shared_examples_for "allows params" do
let(:params_key) { defined?(hash_key) ? hash_key : attribute }
let(:params) do
nested_params = if defined?(nested_key)
@@ -57,85 +57,85 @@
end
end
- describe '#budget' do
+ describe "#budget" do
let(:attribute) { :budget }
- context 'subject' do
- let(:hash) { { 'subject' => 'subject_test' } }
+ context "subject" do
+ let(:hash) { { "subject" => "subject_test" } }
- it_behaves_like 'allows params'
+ it_behaves_like "allows params"
end
- context 'description' do
- let(:hash) { { 'description' => 'description_test' } }
+ context "description" do
+ let(:hash) { { "description" => "description_test" } }
- it_behaves_like 'allows params'
+ it_behaves_like "allows params"
end
- context 'fixed_date' do
- let(:hash) { { 'fixed_date' => '2017-03-01' } }
+ context "fixed_date" do
+ let(:hash) { { "fixed_date" => "2017-03-01" } }
- it_behaves_like 'allows params'
+ it_behaves_like "allows params"
end
- context 'project_id' do
- let(:hash) { { 'project_id' => 42 } }
+ context "project_id" do
+ let(:hash) { { "project_id" => 42 } }
- it_behaves_like 'allows params' do
+ it_behaves_like "allows params" do
let(:allowed_params) { {} }
end
end
- context 'existing material budget item' do
+ context "existing material budget item" do
let(:hash) do
- { 'existing_material_budget_item_attributes' => { '1' => {
- 'units' => '100.0',
- 'cost_type_id' => '1',
- 'comments' => 'First package',
- 'amount' => '5,000.00'
+ { "existing_material_budget_item_attributes" => { "1" => {
+ "units" => "100.0",
+ "cost_type_id" => "1",
+ "comments" => "First package",
+ "amount" => "5,000.00"
} } }
end
- it_behaves_like 'allows params'
+ it_behaves_like "allows params"
end
- context 'new material budget item' do
+ context "new material budget item" do
let(:hash) do
- { 'new_material_budget_item_attributes' => { '1' => {
- 'units' => '20',
- 'cost_type_id' => '2',
- 'comments' => 'Macbooks',
- 'amount' => '52,000.00'
+ { "new_material_budget_item_attributes" => { "1" => {
+ "units" => "20",
+ "cost_type_id" => "2",
+ "comments" => "Macbooks",
+ "amount" => "52,000.00"
} } }
end
- it_behaves_like 'allows params'
+ it_behaves_like "allows params"
end
- context 'existing labor budget item' do
+ context "existing labor budget item" do
let(:hash) do
- { 'existing_labor_budget_item_attributes' => { '1' => {
- 'hours' => '20.0',
- 'user_id' => '1',
- 'comments' => 'App Setup',
- 'amount' => '2000.00'
+ { "existing_labor_budget_item_attributes" => { "1" => {
+ "hours" => "20.0",
+ "user_id" => "1",
+ "comments" => "App Setup",
+ "amount" => "2000.00"
} } }
end
- it_behaves_like 'allows params'
+ it_behaves_like "allows params"
end
- context 'new labor budget item' do
+ context "new labor budget item" do
let(:hash) do
- { 'new_labor_budget_item_attributes' => { '1' => {
- 'hours' => '5.0',
- 'user_id' => '2',
- 'comments' => 'Overhead',
- 'amount' => '400'
+ { "new_labor_budget_item_attributes" => { "1" => {
+ "hours" => "5.0",
+ "user_id" => "2",
+ "comments" => "Overhead",
+ "amount" => "400"
} } }
end
- it_behaves_like 'allows params'
+ it_behaves_like "allows params"
end
end
end
diff --git a/modules/budgets/spec/requests/api/v3/budgets/budget_resource_spec.rb b/modules/budgets/spec/requests/api/v3/budgets/budget_resource_spec.rb
index a10ea2ac47f2..84c1815c1693 100644
--- a/modules/budgets/spec/requests/api/v3/budgets/budget_resource_spec.rb
+++ b/modules/budgets/spec/requests/api/v3/budgets/budget_resource_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'API v3 Budget resource' do
+RSpec.describe "API v3 Budget resource" do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -42,61 +42,61 @@
subject(:response) { last_response }
- describe 'budgets/:id' do
+ describe "budgets/:id" do
let(:get_path) { api_v3_paths.budget budget.id }
- context 'logged in user' do
+ context "logged in user" do
before do
allow(User).to receive(:current).and_return current_user
get get_path
end
- context 'valid id' do
- it 'returns HTTP 200' do
+ context "valid id" do
+ it "returns HTTP 200" do
expect(response.status).to be(200)
end
end
- context 'invalid id' do
- let(:get_path) { api_v3_paths.budget 'bogus' }
+ context "invalid id" do
+ let(:get_path) { api_v3_paths.budget "bogus" }
- it_behaves_like 'param validation error' do
- let(:id) { 'bogus' }
+ it_behaves_like "param validation error" do
+ let(:id) { "bogus" }
end
end
end
- context 'not logged in user' do
+ context "not logged in user" do
before do
get get_path
end
- it_behaves_like 'forbidden response based on login_required'
+ it_behaves_like "forbidden response based on login_required"
end
end
- describe 'projects/:id/budgets' do
+ describe "projects/:id/budgets" do
let(:get_path) { api_v3_paths.budgets_by_project project.id }
- context 'logged in user' do
+ context "logged in user" do
before do
allow(User).to receive(:current).and_return current_user
get get_path
end
- it 'returns HTTP 200' do
+ it "returns HTTP 200" do
expect(response.status).to be(200)
end
end
- context 'not logged in user' do
+ context "not logged in user" do
before do
get get_path
end
- it_behaves_like 'not found response based on login_required'
+ it_behaves_like "not found response based on login_required"
end
end
end
diff --git a/modules/budgets/spec/services/budgets/create_service_spec.rb b/modules/budgets/spec/services/budgets/create_service_spec.rb
index 8777672870c3..491898663fd6 100644
--- a/modules/budgets/spec/services/budgets/create_service_spec.rb
+++ b/modules/budgets/spec/services/budgets/create_service_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'services/base_services/behaves_like_create_service'
+require "spec_helper"
+require "services/base_services/behaves_like_create_service"
RSpec.describe Budgets::CreateService, type: :model do
- it_behaves_like 'BaseServices create service'
+ it_behaves_like "BaseServices create service"
end
diff --git a/modules/budgets/spec/services/budgets/update_service_spec.rb b/modules/budgets/spec/services/budgets/update_service_spec.rb
index fb36afeab170..1c62fef6c73b 100644
--- a/modules/budgets/spec/services/budgets/update_service_spec.rb
+++ b/modules/budgets/spec/services/budgets/update_service_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'services/base_services/behaves_like_update_service'
+require "spec_helper"
+require "services/base_services/behaves_like_update_service"
RSpec.describe Budgets::UpdateService, type: :model do
- it_behaves_like 'BaseServices update service'
+ it_behaves_like "BaseServices update service"
end
diff --git a/modules/budgets/spec/spec_helper.rb b/modules/budgets/spec/spec_helper.rb
index cb06fc211592..9ad4380943c1 100644
--- a/modules/budgets/spec/spec_helper.rb
+++ b/modules/budgets/spec/spec_helper.rb
@@ -27,6 +27,6 @@
#++
# -- load spec_helper from OpenProject core
-require 'spec_helper'
+require "spec_helper"
-Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].sort.each { |f| require f }
+Dir[File.join(File.dirname(__FILE__), "support/**/*.rb")].sort.each { |f| require f }
diff --git a/modules/budgets/spec/support/pages/budget_form.rb b/modules/budgets/spec/support/pages/budget_form.rb
index e91d55c43f7a..e0c8b9a17564 100644
--- a/modules/budgets/spec/support/pages/budget_form.rb
+++ b/modules/budgets/spec/support/pages/budget_form.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'support/pages/page'
+require "support/pages/page"
module Pages
##
@@ -35,7 +35,7 @@ module BudgetForm
##
# Adds planned unit costs with the default cost type.
def add_unit_costs!(num_units, comment: nil, expected_costs: nil)
- edit_unit_costs! unit_rows, units: num_units, comment:, expected_costs:, type: 'new'
+ edit_unit_costs! unit_rows, units: num_units, comment:, expected_costs:, type: "new"
add_unit_costs_row!
end
@@ -47,7 +47,7 @@ def add_labor_costs!(num_hours, user_name:, comment: nil, expected_costs: nil)
user_name:,
comment:,
expected_costs:,
- type: 'new')
+ type: "new")
add_labor_costs_row!
end
@@ -68,7 +68,7 @@ def open_edit_planned_costs!(id, type:)
row_id = "#budget_existing_#{type}_budget_item_attributes_#{id}"
page.within row_id do
- find('.costs--edit-planned-costs-btn').click
+ find(".costs--edit-planned-costs-btn").click
end
end
@@ -87,14 +87,14 @@ def edit_planned_costs!(id, costs:, type:)
# Submit the costs form
def submit_form!
- find_by_id('budget-table--submit-button').click
+ find_by_id("budget-table--submit-button").click
end
##
# Adds planned labor costs with the default cost type.
#
# @param type [String] Either 'existing' (default) or 'new'
- def edit_labor_costs!(id, hours: nil, user_name: nil, comment: nil, expected_costs: nil, type: 'existing')
+ def edit_labor_costs!(id, hours: nil, user_name: nil, comment: nil, expected_costs: nil, type: "existing")
prefix = "#{labor_cost_attr_id(type)}_#{id}"
options = { fill_options: { clear: :backspace } }
@@ -106,13 +106,13 @@ def edit_labor_costs!(id, hours: nil, user_name: nil, comment: nil, expected_cos
end
def add_unit_costs_row!
- find('#material_budget_items_fieldset .wp-inline-create--add-link').click
+ find("#material_budget_items_fieldset .wp-inline-create--add-link").click
@unit_rows = unit_rows + 1
end
def add_labor_costs_row!
- find('#labor_budget_items_fieldset .wp-inline-create--add-link').click
+ find("#labor_budget_items_fieldset .wp-inline-create--add-link").click
@labor_rows = labor_rows + 1
end
@@ -133,19 +133,19 @@ def expect_subject(subject)
end
def unit_costs_at(num_row)
- unit_costs_container.all('tbody td.currency')[num_row - 1]
+ unit_costs_container.all("tbody td.currency")[num_row - 1]
end
def overall_unit_costs
- unit_costs_container.first('tfoot td.currency')
+ unit_costs_container.first("tfoot td.currency")
end
def labor_costs_at(num_row)
- labor_costs_container.all('tbody td.currency')[num_row - 1]
+ labor_costs_container.all("tbody td.currency")[num_row - 1]
end
def overall_labor_costs
- labor_costs_container.first('tfoot td.currency')
+ labor_costs_container.first("tfoot td.currency")
end
def unit_costs_container
@@ -157,7 +157,7 @@ def labor_costs_container
end
def find_container(title)
- find('h4', text: title).find(:xpath, '..')
+ find("h4", text: title).find(:xpath, "..")
end
##
diff --git a/modules/budgets/spec/support/pages/destroy_info.rb b/modules/budgets/spec/support/pages/destroy_info.rb
index 7bfab77bdc06..5a6d9f644def 100644
--- a/modules/budgets/spec/support/pages/destroy_info.rb
+++ b/modules/budgets/spec/support/pages/destroy_info.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'support/pages/page'
+require "support/pages/page"
module Pages
class DestroyInfo < Page
@@ -43,29 +43,29 @@ def expect_loaded
def expect_reassign_option
expect(page)
- .to have_field('todo_reassign')
+ .to have_field("todo_reassign")
end
def expect_no_reassign_option
expect(page)
- .to have_no_field('todo_reassign')
+ .to have_no_field("todo_reassign")
end
def select_reassign_option(budget_name)
- select(budget_name, from: 'reassign_to_id')
+ select(budget_name, from: "reassign_to_id")
end
def expect_delete_option
expect(page)
- .to have_field('todo_delete')
+ .to have_field("todo_delete")
end
def select_delete_option
- choose('todo_delete')
+ choose("todo_delete")
end
def delete
- click_button 'Apply'
+ click_button "Apply"
end
def path
diff --git a/modules/budgets/spec/support/pages/edit_budget.rb b/modules/budgets/spec/support/pages/edit_budget.rb
index 831dd3fd8fe4..d6907fea2fad 100644
--- a/modules/budgets/spec/support/pages/edit_budget.rb
+++ b/modules/budgets/spec/support/pages/edit_budget.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'support/pages/page'
-require_relative 'budget_form'
+require "support/pages/page"
+require_relative "budget_form"
module Pages
class EditBudget < Page
@@ -40,14 +40,14 @@ def initialize(budget_id)
end
def click_copy
- within '.toolbar-items' do
- click_link 'Copy'
+ within ".toolbar-items" do
+ click_link "Copy"
end
end
def click_delete
- within '.toolbar-items' do
- click_link 'Delete'
+ within ".toolbar-items" do
+ click_link "Delete"
end
end
diff --git a/modules/budgets/spec/support/pages/index_budget.rb b/modules/budgets/spec/support/pages/index_budget.rb
index 228e18a37fdc..521e1850dd0f 100644
--- a/modules/budgets/spec/support/pages/index_budget.rb
+++ b/modules/budgets/spec/support/pages/index_budget.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'support/pages/page'
+require "support/pages/page"
module Pages
class IndexBudget < Page
diff --git a/modules/budgets/spec/support/pages/new_budget.rb b/modules/budgets/spec/support/pages/new_budget.rb
index c256366b3846..51971a31bc48 100644
--- a/modules/budgets/spec/support/pages/new_budget.rb
+++ b/modules/budgets/spec/support/pages/new_budget.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'support/pages/page'
-require_relative 'budget_form'
+require "support/pages/page"
+require_relative "budget_form"
module Pages
class NewBudget < Page
diff --git a/modules/calendar/app/components/calendar/add_button_component.rb b/modules/calendar/app/components/calendar/add_button_component.rb
index 5873c19f2406..4eced87bc875 100644
--- a/modules/calendar/app/components/calendar/add_button_component.rb
+++ b/modules/calendar/app/components/calendar/add_button_component.rb
@@ -48,11 +48,11 @@ def dynamic_path
end
def id
- 'add-calendar-button'
+ "add-calendar-button"
end
def accessibility_label_text
- I18n.t('js.calendar.create_new')
+ I18n.t("js.calendar.create_new")
end
def label_text
diff --git a/modules/calendar/app/components/calendar/row_component.rb b/modules/calendar/app/components/calendar/row_component.rb
index 15bb64d2de6c..25593b745548 100644
--- a/modules/calendar/app/components/calendar/row_component.rb
+++ b/modules/calendar/app/components/calendar/row_component.rb
@@ -53,13 +53,13 @@ def button_links
def delete_link
if render_delete_link?
link_to(
- '',
+ "",
project_calendar_path(project, query.id),
method: :delete,
- class: 'icon icon-delete',
+ class: "icon icon-delete",
data: {
confirm: I18n.t(:text_are_you_sure),
- 'test-selector': "calendar-remove-#{query.id}"
+ "test-selector": "calendar-remove-#{query.id}"
},
title: t(:button_delete)
)
diff --git a/modules/calendar/app/components/calendar/table_component.rb b/modules/calendar/app/components/calendar/table_component.rb
index 558ae563a723..df247c02d893 100644
--- a/modules/calendar/app/components/calendar/table_component.rb
+++ b/modules/calendar/app/components/calendar/table_component.rb
@@ -33,7 +33,7 @@ class TableComponent < ::TableComponent
sortable_columns :name, :project_name, :created_at
def sortable_columns_correlation
- super.merge(project_name: 'projects.name')
+ super.merge(project_name: "projects.name")
end
def initial_sort
@@ -47,8 +47,8 @@ def paginated?
def headers
@headers ||= [
[:name, { caption: I18n.t(:label_name) }],
- current_project.blank? ? [:project_name, { caption: I18n.t('attributes.project') }] : nil,
- [:created_at, { caption: I18n.t('attributes.created_at') }]
+ current_project.blank? ? [:project_name, { caption: I18n.t("attributes.project") }] : nil,
+ [:created_at, { caption: I18n.t("attributes.created_at") }]
].compact
end
diff --git a/modules/calendar/app/controllers/calendar/calendars_controller.rb b/modules/calendar/app/controllers/calendar/calendars_controller.rb
index a0d6957a0279..c85bd8311c68 100644
--- a/modules/calendar/app/controllers/calendar/calendars_controller.rb
+++ b/modules/calendar/app/controllers/calendar/calendars_controller.rb
@@ -42,11 +42,11 @@ class CalendarsController < ApplicationController
def index
@views = visible_views
- render 'index', locals: { menu_name: project_or_global_menu }
+ render "index", locals: { menu_name: project_or_global_menu }
end
def show
- render layout: 'angular/angular'
+ render layout: "angular/angular"
end
def new; end
@@ -93,13 +93,13 @@ def visible_views
base_query = Query
.visible(current_user)
.joins(:views, :project)
- .where('views.type' => 'work_packages_calendar')
+ .where("views.type" => "work_packages_calendar")
if @project
- base_query = base_query.where('queries.project_id' => @project.id)
+ base_query = base_query.where("queries.project_id" => @project.id)
end
- base_query.order('queries.name ASC')
+ base_query.order("queries.name ASC")
end
def find_calendar
diff --git a/modules/calendar/app/models/ical_token_query_assignment.rb b/modules/calendar/app/models/ical_token_query_assignment.rb
index 6dbbb977037f..7b72c140253e 100644
--- a/modules/calendar/app/models/ical_token_query_assignment.rb
+++ b/modules/calendar/app/models/ical_token_query_assignment.rb
@@ -27,9 +27,9 @@
#++
class ICalTokenQueryAssignment < ApplicationRecord
- self.table_name = 'ical_token_query_assignments'
+ self.table_name = "ical_token_query_assignments"
- belongs_to :ical_token, class_name: 'Token::ICal', optional: true
+ belongs_to :ical_token, class_name: "Token::ICal", optional: true
belongs_to :query, optional: true
validates :name, presence: true
validate :unique_name_per_user_and_query
diff --git a/modules/calendar/app/services/calendar/create_ical_service.rb b/modules/calendar/app/services/calendar/create_ical_service.rb
index d8cbffc0c2ba..14e407f1d555 100644
--- a/modules/calendar/app/services/calendar/create_ical_service.rb
+++ b/modules/calendar/app/services/calendar/create_ical_service.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'icalendar'
+require "icalendar"
module Calendar
class CreateICalService < ::BaseServices::BaseCallable
@@ -45,7 +45,7 @@ def create_ical_string(work_packages, calendar_name)
calendar = Icalendar::Calendar.new
calendar.prodid = "-//OpenProject GmbH//OpenProject Core Project//EN"
- calendar.refresh_interval = 'PT1H'
+ calendar.refresh_interval = "PT1H"
calendar.x_wr_calname = calendar_name
work_packages.each do |work_package|
@@ -84,7 +84,7 @@ def summary_value(work_package)
def dtstamp_value(work_package)
# https://datatracker.ietf.org/doc/html/rfc5545#section-3.8.7.2
- Icalendar::Values::DateTime.new(work_package.updated_at, 'tzid' => 'UTC')
+ Icalendar::Values::DateTime.new(work_package.updated_at, "tzid" => "UTC")
end
def dtstart_value(work_package)
diff --git a/modules/calendar/app/services/calendar/views/global_create_service.rb b/modules/calendar/app/services/calendar/views/global_create_service.rb
index 05d2752d8de1..9c44357fb4a4 100644
--- a/modules/calendar/app/services/calendar/views/global_create_service.rb
+++ b/modules/calendar/app/services/calendar/views/global_create_service.rb
@@ -34,7 +34,7 @@ class GlobalCreateService < ::Views::GlobalCreateService
private
def view_type
- 'work_packages_calendar'
+ "work_packages_calendar"
end
end
end
diff --git a/modules/calendar/config/routes.rb b/modules/calendar/config/routes.rb
index 404d3d17a0a6..42322035b027 100644
--- a/modules/calendar/config/routes.rb
+++ b/modules/calendar/config/routes.rb
@@ -1,14 +1,14 @@
Rails.application.routes.draw do
- scope 'projects/:project_id', as: 'project' do
+ scope "projects/:project_id", as: "project" do
resources :calendars,
- controller: 'calendar/calendars',
+ controller: "calendar/calendars",
only: %i[index destroy],
as: :calendars do
- get '/new' => 'calendar/calendars#show', on: :collection, as: 'new'
- get '/ical' => 'calendar/ical#show', on: :member, as: 'ical'
- get '(/*state)' => 'calendar/calendars#show', on: :member, as: ''
+ get "/new" => "calendar/calendars#show", on: :collection, as: "new"
+ get "/ical" => "calendar/ical#show", on: :member, as: "ical"
+ get "(/*state)" => "calendar/calendars#show", on: :member, as: ""
end
end
- resources :calendars, only: %i[index new create], controller: 'calendar/calendars'
+ resources :calendars, only: %i[index new create], controller: "calendar/calendars"
end
diff --git a/modules/calendar/db/migrate/20230502094813_add_name_to_ical_tokens.rb b/modules/calendar/db/migrate/20230502094813_add_name_to_ical_tokens.rb
index 6f7778034ec3..132191cac713 100644
--- a/modules/calendar/db/migrate/20230502094813_add_name_to_ical_tokens.rb
+++ b/modules/calendar/db/migrate/20230502094813_add_name_to_ical_tokens.rb
@@ -1,7 +1,7 @@
class AddNameToICalTokens < ActiveRecord::Migration[7.0]
def up
# Add column with default value to avoid null values for existing records in preview environment
- add_column :ical_token_query_assignments, :name, :string, null: false, default: 'Not provided in earlier version'
+ add_column :ical_token_query_assignments, :name, :string, null: false, default: "Not provided in earlier version"
# Remove default value after migration and applying it to existing records
change_column_default :ical_token_query_assignments, :name, nil
end
diff --git a/modules/calendar/lib/open_project/calendar.rb b/modules/calendar/lib/open_project/calendar.rb
index ac7da727a473..4a457e390b78 100644
--- a/modules/calendar/lib/open_project/calendar.rb
+++ b/modules/calendar/lib/open_project/calendar.rb
@@ -28,6 +28,6 @@
module OpenProject
module Calendar
- require 'open_project/calendar/engine'
+ require "open_project/calendar/engine"
end
end
diff --git a/modules/calendar/lib/open_project/calendar/engine.rb b/modules/calendar/lib/open_project/calendar/engine.rb
index fe452aa12902..36d907c9bbab 100644
--- a/modules/calendar/lib/open_project/calendar/engine.rb
+++ b/modules/calendar/lib/open_project/calendar/engine.rb
@@ -22,18 +22,18 @@ class Engine < ::Rails::Engine
include OpenProject::Plugins::ActsAsOpEngine
- register 'openproject-calendar',
- author_url: 'https://www.openproject.org',
+ register "openproject-calendar",
+ author_url: "https://www.openproject.org",
bundled: true,
settings: {} do
project_module :calendar_view, dependencies: :work_package_tracking do
permission :view_calendar,
- { 'calendar/calendars': %i[index show] },
+ { "calendar/calendars": %i[index show] },
permissible_on: :project,
dependencies: %i[view_work_packages],
contract_actions: { calendar: %i[read] }
permission :manage_calendars,
- { 'calendar/calendars': %i[index show new create destroy] },
+ { "calendar/calendars": %i[index show new create destroy] },
permissible_on: :project,
dependencies: %i[view_calendar add_work_packages edit_work_packages save_queries manage_public_queries],
contract_actions: { calendar: %i[create update destroy] }
@@ -50,48 +50,48 @@ class Engine < ::Rails::Engine
end
menu :top_menu,
- :calendar_view, { controller: '/calendar/calendars', action: 'index', project_id: nil },
+ :calendar_view, { controller: "/calendar/calendars", action: "index", project_id: nil },
context: :modules,
caption: :label_calendar_plural,
- icon: 'calendar',
+ icon: "calendar",
after: :gantt,
if: should_render
menu :global_menu,
:calendar_view,
- { controller: '/calendar/calendars', action: 'index', project_id: nil },
+ { controller: "/calendar/calendars", action: "index", project_id: nil },
caption: :label_calendar_plural,
- icon: 'calendar',
+ icon: "calendar",
after: :gantt,
if: should_render
menu :project_menu,
:calendar_view,
- { controller: '/calendar/calendars', action: 'index' },
+ { controller: "/calendar/calendars", action: "index" },
caption: :label_calendar_plural,
- icon: 'calendar',
+ icon: "calendar",
after: :gantt
menu :project_menu,
:calendar_menu,
- { controller: '/calendar/calendars', action: 'index' },
+ { controller: "/calendar/calendars", action: "index" },
parent: :calendar_view,
- partial: 'calendar/calendars/menu',
+ partial: "calendar/calendars/menu",
last: true,
caption: :label_calendar_plural
end
add_view :WorkPackagesCalendar,
- contract_strategy: 'Calendar::Views::ContractStrategy'
+ contract_strategy: "Calendar::Views::ContractStrategy"
- initializer 'calendar.register_mimetypes' do
+ initializer "calendar.register_mimetypes" do
# next if defined? Mime::XLS
- Mime::Type.register('text/calendar', :ics)
+ Mime::Type.register("text/calendar", :ics)
end
- initializer 'calendar.configuration' do
- ::Settings::Definition.add 'ical_enabled',
+ initializer "calendar.configuration" do
+ ::Settings::Definition.add "ical_enabled",
default: true,
format: :boolean
end
diff --git a/modules/calendar/lib/openproject-calendar.rb b/modules/calendar/lib/openproject-calendar.rb
index 39ee5b24567c..dac0561b19b4 100644
--- a/modules/calendar/lib/openproject-calendar.rb
+++ b/modules/calendar/lib/openproject-calendar.rb
@@ -1 +1 @@
-require 'open_project/calendar'
+require "open_project/calendar"
diff --git a/modules/calendar/openproject-calendar.gemspec b/modules/calendar/openproject-calendar.gemspec
index c0eee27a53b7..ae28c6b76623 100644
--- a/modules/calendar/openproject-calendar.gemspec
+++ b/modules/calendar/openproject-calendar.gemspec
@@ -1,13 +1,13 @@
Gem::Specification.new do |s|
- s.name = 'openproject-calendar'
- s.version = '1.0.0'
- s.authors = 'OpenProject GmbH'
- s.email = 'info@openproject.com'
- s.summary = 'OpenProject Calendar'
- s.description = 'Provides calendar views'
- s.license = 'GPLv3'
+ s.name = "openproject-calendar"
+ s.version = "1.0.0"
+ s.authors = "OpenProject GmbH"
+ s.email = "info@openproject.com"
+ s.summary = "OpenProject Calendar"
+ s.description = "Provides calendar views"
+ s.license = "GPLv3"
- s.files = Dir['{app,config,db,lib}/**/*']
- s.add_dependency 'icalendar', '~> 2.10.0'
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.files = Dir["{app,config,db,lib}/**/*"]
+ s.add_dependency "icalendar", "~> 2.10.0"
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/calendar/spec/controllers/calendar_controller_spec.rb b/modules/calendar/spec/controllers/calendar_controller_spec.rb
index 10bb9754413d..78e916712c63 100644
--- a/modules/calendar/spec/controllers/calendar_controller_spec.rb
+++ b/modules/calendar/spec/controllers/calendar_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Calendar::CalendarsController do
let(:project) do
@@ -48,29 +48,29 @@
login_as user
end
- describe '#index' do
- shared_examples_for 'calendar#index' do
+ describe "#index" do
+ shared_examples_for "calendar#index" do
subject { response }
it { is_expected.to be_successful }
- it { is_expected.to render_template('calendar/calendars/index') }
+ it { is_expected.to render_template("calendar/calendars/index") }
end
- context 'within a project context' do
+ context "within a project context" do
before do
get :index, params: { project_id: project.id }
end
- it_behaves_like 'calendar#index'
+ it_behaves_like "calendar#index"
end
- context 'within a global context' do
+ context "within a global context" do
before do
get :index
end
- it_behaves_like 'calendar#index'
+ it_behaves_like "calendar#index"
end
end
end
diff --git a/modules/calendar/spec/controllers/ical_controller_spec.rb b/modules/calendar/spec/controllers/ical_controller_spec.rb
index b351ec176955..f4d6cb1f15f1 100644
--- a/modules/calendar/spec/controllers/ical_controller_spec.rb
+++ b/modules/calendar/spec/controllers/ical_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Calendar::ICalController do
shared_let(:project) { create(:project) }
@@ -82,18 +82,18 @@
# the ical urls are intended to be used without a logged in user from a calendar client app
# before { login_as(user) }
- describe '#show' do
- shared_examples_for 'success' do
+ describe "#show" do
+ shared_examples_for "success" do
subject { response }
it { is_expected.to be_successful }
- it 'returns a valid ical file' do
+ it "returns a valid ical file" do
expected_file_name = "openproject_calendar_#{DateTime.now.to_i}.ics"
expected_utf8_file_name = "UTF-8''#{expected_file_name}"
- expect(response.headers['Content-Type']).to eq('text/calendar')
- expect(response.headers['Content-Disposition']).to eq(
+ expect(response.headers["Content-Type"]).to eq("text/calendar")
+ expect(response.headers["Content-Disposition"]).to eq(
"attachment; filename=\"#{expected_file_name}\"; filename*=#{expected_utf8_file_name}"
)
expect(subject.body).to match(/BEGIN:VCALENDAR/)
@@ -105,12 +105,12 @@
end
end
- shared_examples_for 'failure' do
+ shared_examples_for "failure" do
subject { response }
it { is_expected.not_to be_successful }
- it 'does not return a valid ical file' do
+ it "does not return a valid ical file" do
expect(subject.body).not_to match(/BEGIN:VCALENDAR/)
expect(subject.body).not_to match(/END:VCALENDAR/)
@@ -120,7 +120,7 @@
end
end
- context 'with valid params and permissions when targeting own query' do
+ context "with valid params and permissions when targeting own query" do
before do
get :show, params: {
project_id: project.id,
@@ -129,10 +129,10 @@
}
end
- it_behaves_like 'success'
+ it_behaves_like "success"
end
- context 'with valid params and permissions with a query having a parent filter (bug #49726)' do
+ context "with valid params and permissions with a query having a parent filter (bug #49726)" do
before do
User.execute_as(user) do
parent_work_package = create(:work_package, project:, children: work_packages)
@@ -147,10 +147,10 @@
}
end
- it_behaves_like 'success'
+ it_behaves_like "success"
end
- context 'with valid params and permissions when targeting own query when globally disabled',
+ context "with valid params and permissions when targeting own query when globally disabled",
with_settings: { ical_enabled: false } do
before do
get :show, params: {
@@ -160,10 +160,10 @@
}
end
- it_behaves_like 'failure'
+ it_behaves_like "failure"
end
- context 'with valid params and permissions when targeting own query with login required set to `true`',
+ context "with valid params and permissions when targeting own query with login required set to `true`",
with_settings: { login_required: true } do
before do
get :show, params: {
@@ -173,10 +173,10 @@
}
end
- it_behaves_like 'success'
+ it_behaves_like "success"
end
- context 'with valid params and permissions when targeting a public query of somebody else' do
+ context "with valid params and permissions when targeting a public query of somebody else" do
let(:user2) do
create(:user,
member_with_permissions: { project => sufficient_permissions })
@@ -199,10 +199,10 @@
}
end
- it_behaves_like 'success'
+ it_behaves_like "success"
end
- context 'with valid params and permissions when targeting a public query of somebody else',
+ context "with valid params and permissions when targeting a public query of somebody else",
with_settings: { ical_enabled: false } do
let(:user2) do
create(:user,
@@ -226,10 +226,10 @@
}
end
- it_behaves_like 'failure'
+ it_behaves_like "failure"
end
- context 'with valid params and permissions when targeting a public query of somebody else with login required set to `true`',
+ context "with valid params and permissions when targeting a public query of somebody else with login required set to `true`",
with_settings: { login_required: true } do
let(:user2) do
create(:user,
@@ -253,10 +253,10 @@
}
end
- it_behaves_like 'success'
+ it_behaves_like "success"
end
- context 'with valid params and permissions when targeting a private query of somebody else' do
+ context "with valid params and permissions when targeting a private query of somebody else" do
let(:user2) do
create(:user,
member_with_permissions: { project => sufficient_permissions })
@@ -279,10 +279,10 @@
}
end
- it_behaves_like 'failure'
+ it_behaves_like "failure"
end
- context 'with valid params and permissions when not part of the project (anymore)' do
+ context "with valid params and permissions when not part of the project (anymore)" do
let(:project2) { create(:project) }
let(:user) do
create(:user,
@@ -297,10 +297,10 @@
}
end
- it_behaves_like 'failure'
+ it_behaves_like "failure"
end
- context 'with valid params and missing permissions' do
+ context "with valid params and missing permissions" do
let(:user) do
create(:user,
member_with_permissions: { project => insufficient_permissions })
@@ -314,10 +314,10 @@
}
end
- it_behaves_like 'failure'
+ it_behaves_like "failure"
end
- context 'with invalid token' do
+ context "with invalid token" do
before do
get :show, params: {
project_id: project.id,
@@ -326,10 +326,10 @@
}
end
- it_behaves_like 'failure'
+ it_behaves_like "failure"
end
- context 'with invalid query' do
+ context "with invalid query" do
before do
get :show, params: {
project_id: project.id,
@@ -338,10 +338,10 @@
}
end
- it_behaves_like 'failure'
+ it_behaves_like "failure"
end
- context 'with invalid project' do
+ context "with invalid project" do
before do
get :show, params: {
project_id: SecureRandom.hex,
@@ -352,10 +352,10 @@
# TODO: the project id is actually irrelevant - the query id is enough
# should the project id still be used in the ical url anyways?
- it_behaves_like 'success'
+ it_behaves_like "success"
end
- context 'with invalid project', with_settings: { ical_enabled: false } do
+ context "with invalid project", with_settings: { ical_enabled: false } do
before do
get :show, params: {
project_id: SecureRandom.hex,
@@ -366,7 +366,7 @@
# TODO: the project id is actually irrelevant - the query id is enough
# should the project id still be used in the ical url anyways?
- it_behaves_like 'failure'
+ it_behaves_like "failure"
end
end
end
diff --git a/modules/calendar/spec/features/calendar_create_work_package_spec.rb b/modules/calendar/spec/features/calendar_create_work_package_spec.rb
index 2b86b6e033f8..02d3addef8d3 100644
--- a/modules/calendar/spec/features/calendar_create_work_package_spec.rb
+++ b/modules/calendar/spec/features/calendar_create_work_package_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_context'
+require "spec_helper"
+require_relative "shared_context"
-RSpec.describe 'Calendar create new work package', :js do
- include_context 'with calendar full access'
+RSpec.describe "Calendar create new work package", :js do
+ include_context "with calendar full access"
let(:type_task) { create(:type_task) }
let!(:status) { create(:default_status) }
@@ -41,7 +41,7 @@
project.types << type_task
end
- it 'can create a new work package' do
+ it "can create a new work package" do
calendar.visit!
start_of_week = Time.zone.today.beginning_of_week(:sunday)
@@ -49,18 +49,18 @@
(start_of_week + 1.day).iso8601
subject = split_create.edit_field(:subject)
- subject.set_value 'Newly planned task'
+ subject.set_value "Newly planned task"
split_create.save!
- split_create.expect_and_dismiss_toaster(message: I18n.t('js.notice_successful_create'))
+ split_create.expect_and_dismiss_toaster(message: I18n.t("js.notice_successful_create"))
split_create.expect_attributes(
combinedDate: "#{start_of_week.strftime('%m/%d/%Y')} - #{(start_of_week + 1.day).strftime('%m/%d/%Y')}"
)
wp = WorkPackage.last
- expect(wp.subject).to eq 'Newly planned task'
+ expect(wp.subject).to eq "Newly planned task"
expect(wp.start_date).to eq start_of_week
expect(wp.due_date).to eq (start_of_week + 1.day)
diff --git a/modules/calendar/spec/features/calendar_dates_spec.rb b/modules/calendar/spec/features/calendar_dates_spec.rb
index 662cd88006c2..703a2366d819 100644
--- a/modules/calendar/spec/features/calendar_dates_spec.rb
+++ b/modules/calendar/spec/features/calendar_dates_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_context'
+require "spec_helper"
+require_relative "shared_context"
-RSpec.describe 'Calendar non working days', :js, :with_cuprite do
- include_context 'with calendar full access'
+RSpec.describe "Calendar non working days", :js, :with_cuprite do
+ include_context "with calendar full access"
let!(:other_user) do
- create(:user, firstname: 'Bernd', member_with_permissions: { project => %w[view_work_packages view_calendar] })
+ create(:user, firstname: "Bernd", member_with_permissions: { project => %w[view_work_packages view_calendar] })
end
before do
@@ -44,53 +44,53 @@
calendar.visit!
end
- context 'with week days defined' do
+ context "with week days defined" do
let(:week_days) { week_with_saturday_and_sunday_as_weekend }
- it 'renders sat and sun as non working' do
- expect(page).to have_css('.fc-day-sat.fc-non-working-day', minimum: 1, wait: 10)
- expect(page).to have_css('.fc-day-sun.fc-non-working-day', minimum: 1)
+ it "renders sat and sun as non working" do
+ expect(page).to have_css(".fc-day-sat.fc-non-working-day", minimum: 1, wait: 10)
+ expect(page).to have_css(".fc-day-sun.fc-non-working-day", minimum: 1)
- expect(page).to have_no_css('.fc-day-mon.fc-non-working-day')
- expect(page).to have_no_css('.fc-day-tue.fc-non-working-day')
- expect(page).to have_no_css('.fc-day-wed.fc-non-working-day')
- expect(page).to have_no_css('.fc-day-thu.fc-non-working-day')
- expect(page).to have_no_css('.fc-day-fri.fc-non-working-day')
+ expect(page).to have_no_css(".fc-day-mon.fc-non-working-day")
+ expect(page).to have_no_css(".fc-day-tue.fc-non-working-day")
+ expect(page).to have_no_css(".fc-day-wed.fc-non-working-day")
+ expect(page).to have_no_css(".fc-day-thu.fc-non-working-day")
+ expect(page).to have_no_css(".fc-day-fri.fc-non-working-day")
- find('.fc-next-button').click
+ find(".fc-next-button").click
- expect(page).to have_css('.fc-day-sat.fc-non-working-day', minimum: 1, wait: 10)
- expect(page).to have_css('.fc-day-sun.fc-non-working-day', minimum: 1)
+ expect(page).to have_css(".fc-day-sat.fc-non-working-day", minimum: 1, wait: 10)
+ expect(page).to have_css(".fc-day-sun.fc-non-working-day", minimum: 1)
- expect(page).to have_no_css('.fc-day-mon.fc-non-working-day')
- expect(page).to have_no_css('.fc-day-tue.fc-non-working-day')
- expect(page).to have_no_css('.fc-day-wed.fc-non-working-day')
- expect(page).to have_no_css('.fc-day-thu.fc-non-working-day')
- expect(page).to have_no_css('.fc-day-fri.fc-non-working-day')
+ expect(page).to have_no_css(".fc-day-mon.fc-non-working-day")
+ expect(page).to have_no_css(".fc-day-tue.fc-non-working-day")
+ expect(page).to have_no_css(".fc-day-wed.fc-non-working-day")
+ expect(page).to have_no_css(".fc-day-thu.fc-non-working-day")
+ expect(page).to have_no_css(".fc-day-fri.fc-non-working-day")
end
end
- context 'with all days marked as weekend' do
+ context "with all days marked as weekend" do
let(:week_days) { week_with_no_working_days }
- it 'renders all as non working' do
- expect(page).to have_css('.fc-day-sat.fc-non-working-day', minimum: 1, wait: 10)
- expect(page).to have_css('.fc-day-sun.fc-non-working-day', minimum: 1)
- expect(page).to have_css('.fc-day-mon.fc-non-working-day', minimum: 1)
- expect(page).to have_css('.fc-day-tue.fc-non-working-day', minimum: 1)
- expect(page).to have_css('.fc-day-wed.fc-non-working-day', minimum: 1)
- expect(page).to have_css('.fc-day-thu.fc-non-working-day', minimum: 1)
- expect(page).to have_css('.fc-day-fri.fc-non-working-day', minimum: 1)
-
- find('.fc-next-button').click
-
- expect(page).to have_css('.fc-day-sat.fc-non-working-day', minimum: 1, wait: 10)
- expect(page).to have_css('.fc-day-sun.fc-non-working-day', minimum: 1)
- expect(page).to have_css('.fc-day-mon.fc-non-working-day', minimum: 1)
- expect(page).to have_css('.fc-day-tue.fc-non-working-day', minimum: 1)
- expect(page).to have_css('.fc-day-wed.fc-non-working-day', minimum: 1)
- expect(page).to have_css('.fc-day-thu.fc-non-working-day', minimum: 1)
- expect(page).to have_css('.fc-day-fri.fc-non-working-day', minimum: 1)
+ it "renders all as non working" do
+ expect(page).to have_css(".fc-day-sat.fc-non-working-day", minimum: 1, wait: 10)
+ expect(page).to have_css(".fc-day-sun.fc-non-working-day", minimum: 1)
+ expect(page).to have_css(".fc-day-mon.fc-non-working-day", minimum: 1)
+ expect(page).to have_css(".fc-day-tue.fc-non-working-day", minimum: 1)
+ expect(page).to have_css(".fc-day-wed.fc-non-working-day", minimum: 1)
+ expect(page).to have_css(".fc-day-thu.fc-non-working-day", minimum: 1)
+ expect(page).to have_css(".fc-day-fri.fc-non-working-day", minimum: 1)
+
+ find(".fc-next-button").click
+
+ expect(page).to have_css(".fc-day-sat.fc-non-working-day", minimum: 1, wait: 10)
+ expect(page).to have_css(".fc-day-sun.fc-non-working-day", minimum: 1)
+ expect(page).to have_css(".fc-day-mon.fc-non-working-day", minimum: 1)
+ expect(page).to have_css(".fc-day-tue.fc-non-working-day", minimum: 1)
+ expect(page).to have_css(".fc-day-wed.fc-non-working-day", minimum: 1)
+ expect(page).to have_css(".fc-day-thu.fc-non-working-day", minimum: 1)
+ expect(page).to have_css(".fc-day-fri.fc-non-working-day", minimum: 1)
end
end
end
diff --git a/modules/calendar/spec/features/calendar_project_include_spec.rb b/modules/calendar/spec/features/calendar_project_include_spec.rb
index b7bfe14b2ce2..ec97c8b5d3a9 100644
--- a/modules/calendar/spec/features/calendar_project_include_spec.rb
+++ b/modules/calendar/spec/features/calendar_project_include_spec.rb
@@ -26,27 +26,27 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/work_packages/project_include/project_include_shared_examples'
-require_relative '../support/pages/calendar'
+require "spec_helper"
+require "features/work_packages/project_include/project_include_shared_examples"
+require_relative "../support/pages/calendar"
-RSpec.describe 'Calendar project include', :js do
+RSpec.describe "Calendar project include", :js do
shared_let(:enabled_modules) { %w[work_package_tracking calendar_view] }
shared_let(:permissions) do
%i[view_work_packages view_calendar edit_work_packages add_work_packages save_queries manage_public_queries]
end
- it_behaves_like 'has a project include dropdown' do
+ it_behaves_like "has a project include dropdown" do
let(:work_package_view) { Pages::Calendar.new project }
let(:dropdown) { Components::ProjectIncludeComponent.new }
- it 'correctly filters work packages by project' do
+ it "correctly filters work packages by project" do
dropdown.expect_count 1, wait: 10
# Make sure the filter gets set once
dropdown.toggle!
dropdown.expect_open
- dropdown.click_button 'Apply'
+ dropdown.click_button "Apply"
dropdown.expect_closed
work_package_view.expect_event task
@@ -57,7 +57,7 @@
dropdown.toggle!
dropdown.toggle_checkbox(sub_sub_sub_project.id)
- dropdown.click_button 'Apply'
+ dropdown.click_button "Apply"
dropdown.expect_count 1
work_package_view.expect_event sub_bug, present: true
@@ -65,7 +65,7 @@
dropdown.toggle!
dropdown.toggle_checkbox(other_project.id)
- dropdown.click_button 'Apply'
+ dropdown.click_button "Apply"
dropdown.expect_count 2
work_package_view.expect_event other_task
diff --git a/modules/calendar/spec/features/calendar_sharing_spec.rb b/modules/calendar/spec/features/calendar_sharing_spec.rb
index d8b93697ad56..31692b2248a4 100644
--- a/modules/calendar/spec/features/calendar_sharing_spec.rb
+++ b/modules/calendar/spec/features/calendar_sharing_spec.rb
@@ -26,17 +26,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_context'
+require "spec_helper"
+require_relative "shared_context"
-RSpec.describe 'Calendar sharing via ical', :js do
- include_context 'with calendar full access'
+RSpec.describe "Calendar sharing via ical", :js do
+ include_context "with calendar full access"
shared_let(:status) { create(:default_status) }
let(:user_with_sharing_permission) do
create(:user,
- firstname: 'Bernd',
+ firstname: "Bernd",
member_with_permissions: { project => %w[
view_work_packages
save_queries
@@ -56,7 +56,7 @@
# the manage_calendars permission should not be sufficient
# sharing via ical needs to be explicitly allowed
create(:user,
- firstname: 'Bernd',
+ firstname: "Bernd",
member_with_permissions: { project => %w[
view_work_packages
save_queries
@@ -69,7 +69,7 @@
create(:admin, member_with_permissions: { project => %i[view_work_packages edit_work_packages] })
end
- context 'without sufficient permissions and the ical_enabled setting enabled', with_settings: { ical_enabled: true } do
+ context "without sufficient permissions and the ical_enabled setting enabled", with_settings: { ical_enabled: true } do
let(:saved_query) do
create(:query_with_view_work_packages_calendar,
user: user_without_sharing_permission,
@@ -82,25 +82,25 @@
calendar.visit!
end
- context 'on persisted calendar query' do
+ context "on persisted calendar query" do
before do
saved_query
visit project_calendars_path(project)
- within '#content' do
+ within "#content" do
click_link saved_query.name
end
loading_indicator_saveguard
end
- it 'shows disabled sharing menu item' do
+ it "shows disabled sharing menu item" do
# wait for settings button to become visible
expect(page).to have_css("#work-packages-settings-button")
# click on settings button
- page.find_by_id('work-packages-settings-button').click
+ page.find_by_id("work-packages-settings-button").click
# expect disabled sharing menu item
within "#settingsDropdown" do
@@ -109,25 +109,25 @@
page.click_button("Subscribe to calendar")
# modal should not be shown
- expect(page).to have_no_css('.spot-modal--header', text: "Subscribe to calendar")
+ expect(page).to have_no_css(".spot-modal--header", text: "Subscribe to calendar")
end
end
end
end
- context 'with sufficient permissions', with_settings: { ical_enabled: true } do
+ context "with sufficient permissions", with_settings: { ical_enabled: true } do
before do
login_as user_with_sharing_permission
calendar.visit!
end
- context 'on not persisted calendar query' do
+ context "on not persisted calendar query" do
# add "manage_calendars" permission to user for this context
# in order to enable creating a new calendar on the UI.
# this permission is not mandatory for the actual feature
let(:user_with_sharing_permission) do
create(:user,
- firstname: 'Bernd',
+ firstname: "Bernd",
member_with_permissions: { project => %w[
view_work_packages
save_queries
@@ -137,7 +137,7 @@
] })
end
- it 'shows disabled sharing menu item' do
+ it "shows disabled sharing menu item" do
visit project_calendars_path(project)
click_link "Create new calendar"
@@ -146,7 +146,7 @@
expect(page).to have_css("#work-packages-settings-button")
# click on settings button
- page.find_by_id('work-packages-settings-button').click
+ page.find_by_id("work-packages-settings-button").click
# expect disabled sharing menu item
within "#settingsDropdown" do
@@ -155,30 +155,30 @@
page.click_button("Subscribe to calendar")
# modal should not be shown
- expect(page).to have_no_css('.spot-modal--header', text: "Subscribe to calendar")
+ expect(page).to have_no_css(".spot-modal--header", text: "Subscribe to calendar")
end
end
end
- context 'on persisted calendar query' do
+ context "on persisted calendar query" do
before do
saved_query
visit project_calendars_path(project)
- within '#content' do
+ within "#content" do
click_link saved_query.name
end
loading_indicator_saveguard
end
- it 'shows an active menu item' do
+ it "shows an active menu item" do
# wait for settings button to become visible
expect(page).to have_css("#work-packages-settings-button")
# click on settings button
- page.find_by_id('work-packages-settings-button').click
+ page.find_by_id("work-packages-settings-button").click
# expect active sharing menu item
within "#settingsDropdown" do
@@ -186,23 +186,23 @@
end
end
- it 'shows a sharing modal' do
+ it "shows a sharing modal" do
open_sharing_modal
- expect(page).to have_css('.spot-modal--header', text: "Subscribe to calendar")
+ expect(page).to have_css(".spot-modal--header", text: "Subscribe to calendar")
end
- it 'closes the sharing modal when closed by user by clicking the close button' do
+ it "closes the sharing modal when closed by user by clicking the close button" do
open_sharing_modal
- expect(page).to have_css('.spot-modal--header', text: "Subscribe to calendar")
+ expect(page).to have_css(".spot-modal--header", text: "Subscribe to calendar")
click_button "Cancel"
- expect(page).to have_no_css('.spot-modal--header', text: "Subscribe to calendar")
+ expect(page).to have_no_css(".spot-modal--header", text: "Subscribe to calendar")
end
- it 'successfully requests a new tokenized iCalendar URL when a unique name is provided' do
+ it "successfully requests a new tokenized iCalendar URL when a unique name is provided" do
open_sharing_modal
fill_in "Where will you be using this?", with: "A token name"
@@ -210,7 +210,7 @@
click_button "Copy URL"
# implicitly testing for success -> modal is closed and fallback message is shown
- expect(page).to have_no_css('.spot-modal--header', text: "Subscribe to calendar")
+ expect(page).to have_no_css(".spot-modal--header", text: "Subscribe to calendar")
expect(page).to have_content("/projects/#{saved_query.project.id}/calendars/#{saved_query.id}/ical?ical_token=")
# explictly testing for success message is not working in test env, probably
@@ -223,7 +223,7 @@
# https://copyprogramming.com/howto/emulating-a-clipboard-copy-paste-with-selinum-capybara
end
- it 'validates the presence of a name' do
+ it "validates the presence of a name" do
open_sharing_modal
# fill_in "Token name", with: "A token name"
@@ -231,18 +231,18 @@
click_button "Copy URL"
# modal is still shown and error message is shown
- expect(page).to have_css('.spot-modal--header', text: "Subscribe to calendar")
+ expect(page).to have_css(".spot-modal--header", text: "Subscribe to calendar")
expect(page).to have_content("Name is mandatory")
end
- it 'validates the uniqueness of a name' do
+ it "validates the uniqueness of a name" do
open_sharing_modal
fill_in "Where will you be using this?", with: "A token name"
click_button "Copy URL"
- expect(page).to have_no_css('.spot-modal--header', text: "Subscribe to calendar")
+ expect(page).to have_no_css(".spot-modal--header", text: "Subscribe to calendar")
expect(page).to have_content("/projects/#{saved_query.project.id}/calendars/#{saved_query.id}/ical?ical_token=")
# do the same thing again, now expect validation error
@@ -254,43 +254,43 @@
click_button "Copy URL"
# modal is still shown and error message is shown
- expect(page).to have_css('.spot-modal--header', text: "Subscribe to calendar")
+ expect(page).to have_css(".spot-modal--header", text: "Subscribe to calendar")
expect(page).to have_content("Name is already in use")
end
end
end
- context 'with sufficient permissions on persisted calendary query' do
- it 'navigates to iCal settings and disables the setting as an admin, disallowing sharing for a user' do
+ context "with sufficient permissions on persisted calendary query" do
+ it "navigates to iCal settings and disables the setting as an admin, disallowing sharing for a user" do
login_as admin
visit admin_index_path
- within '.menu-blocks--container' do
- click_link 'Calendars and dates'
+ within ".menu-blocks--container" do
+ click_link "Calendars and dates"
end
expect(page).to have_css(".title-container", text: "Working days")
click_link I18n.t(:label_calendar_subscriptions)
expect(page)
- .to have_field('Enable iCalendar subscriptions', checked: true)
+ .to have_field("Enable iCalendar subscriptions", checked: true)
- uncheck 'settings[ical_enabled]'
+ uncheck "settings[ical_enabled]"
- click_button 'Save'
+ click_button "Save"
expect(page)
.to have_content "Successful update."
expect(page)
- .to have_field('Enable iCalendar subscriptions', checked: false)
+ .to have_field("Enable iCalendar subscriptions", checked: false)
login_as user_with_sharing_permission
saved_query
visit project_calendars_path(project)
- within '#content' do
+ within "#content" do
click_link saved_query.name
end
@@ -300,7 +300,7 @@
expect(page).to have_css("#work-packages-settings-button")
# click on settings button
- page.find_by_id('work-packages-settings-button').click
+ page.find_by_id("work-packages-settings-button").click
# expect disabled sharing menu item
within "#settingsDropdown" do
@@ -309,7 +309,7 @@
page.click_button("Subscribe to calendar")
# modal should not be shown
- expect(page).to have_no_css('.spot-modal--header', text: "Subscribe to calendar")
+ expect(page).to have_no_css(".spot-modal--header", text: "Subscribe to calendar")
end
end
end
@@ -321,7 +321,7 @@ def open_sharing_modal
expect(page).to have_css("#work-packages-settings-button")
# click on settings button
- page.find_by_id('work-packages-settings-button').click
+ page.find_by_id("work-packages-settings-button").click
# expect disabled sharing menu item
within "#settingsDropdown" do
diff --git a/modules/calendar/spec/features/calendar_user_interaction_spec.rb b/modules/calendar/spec/features/calendar_user_interaction_spec.rb
index 8f11d30f06f6..0b7812a01058 100644
--- a/modules/calendar/spec/features/calendar_user_interaction_spec.rb
+++ b/modules/calendar/spec/features/calendar_user_interaction_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_context'
+require "spec_helper"
+require_relative "shared_context"
-RSpec.describe 'Calendar drag&dop and resizing', :js do
- include_context 'with calendar full access'
+RSpec.describe "Calendar drag&dop and resizing", :js do
+ include_context "with calendar full access"
let!(:other_user) do
create(:user,
- firstname: 'Bernd',
+ firstname: "Bernd",
member_with_permissions: { project => %w[view_work_packages view_calendar] })
end
@@ -51,22 +51,22 @@
calendar.expect_event work_package
end
- context 'with full permissions' do
- it 'allows to resize to change the dates of a wp' do
+ context "with full permissions" do
+ it "allows to resize to change the dates of a wp" do
target = work_package.due_date + 1.day
current_start = work_package.start_date
retry_block do
calendar.resize_date(work_package, target)
end
- calendar.expect_and_dismiss_toaster(message: I18n.t('js.notice_successful_update'))
+ calendar.expect_and_dismiss_toaster(message: I18n.t("js.notice_successful_update"))
work_package.reload
expect(work_package.due_date).to eq target
expect(work_package.start_date).to eq current_start
end
- it 'allows to resize from the start' do
+ it "allows to resize from the start" do
target = work_package.start_date - 1.day
current_end = work_package.due_date
@@ -74,21 +74,21 @@
calendar.resize_date(work_package, target, end_date: false)
end
- calendar.expect_and_dismiss_toaster(message: I18n.t('js.notice_successful_update'))
+ calendar.expect_and_dismiss_toaster(message: I18n.t("js.notice_successful_update"))
work_package.reload
expect(work_package.start_date).to eq target
expect(work_package.due_date).to eq current_end
end
- it 'allows to drag the work package to another date' do
+ it "allows to drag the work package to another date" do
target = Time.zone.today.beginning_of_week
retry_block do
calendar.drag_event(work_package, target)
end
- calendar.expect_and_dismiss_toaster(message: I18n.t('js.notice_successful_update'))
+ calendar.expect_and_dismiss_toaster(message: I18n.t("js.notice_successful_update"))
work_package.reload
@@ -98,10 +98,10 @@
end
end
- context 'without permission to edit' do
+ context "without permission to edit" do
let(:current_user) { other_user }
- it 'allows neither dragging nor resizing any wp' do
+ it "allows neither dragging nor resizing any wp" do
calendar.expect_event work_package
calendar.expect_wp_not_resizable(work_package)
calendar.expect_wp_not_draggable(work_package)
diff --git a/modules/calendar/spec/features/calendar_widget_spec.rb b/modules/calendar/spec/features/calendar_widget_spec.rb
index 89e08d07faf0..d60ab5f86ef3 100644
--- a/modules/calendar/spec/features/calendar_widget_spec.rb
+++ b/modules/calendar/spec/features/calendar_widget_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../../../overviews/spec/support/pages/overview'
-require_relative '../support/pages/calendar'
+require "spec_helper"
+require_relative "../../../overviews/spec/support/pages/overview"
+require_relative "../support/pages/calendar"
-RSpec.describe 'Calendar Widget', :js, :with_cuprite, with_settings: { start_of_week: 1 } do
+RSpec.describe "Calendar Widget", :js, :with_cuprite, with_settings: { start_of_week: 1 } do
let(:project) do
create(:project, enabled_module_names: %w[work_package_tracking calendar_view])
end
@@ -58,36 +58,36 @@
overview_page.visit!
end
- it 'opens the work package full view when clicking a calendar entry' do
+ it "opens the work package full view when clicking a calendar entry" do
# within top-left area, add an additional widget
- overview_page.add_widget(1, 1, :row, 'Calendar')
+ overview_page.add_widget(1, 1, :row, "Calendar")
- overview_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ overview_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
# Clicking the calendar entry goes to work package full screen
- page.find('.fc-event-title', text: work_package.subject).click
+ page.find(".fc-event-title", text: work_package.subject).click
wp_full_view.ensure_page_loaded
wp_full_view.go_back
- expect(page).to have_text('Overview')
+ expect(page).to have_text("Overview")
end
- it 'can resize the same work package twice (Regression #48333)', with_cuprite: false do
+ it "can resize the same work package twice (Regression #48333)", with_cuprite: false do
# within top-left area, add an additional widget
- overview_page.add_widget(1, 1, :row, 'Calendar')
+ overview_page.add_widget(1, 1, :row, "Calendar")
- overview_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ overview_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
- expect(page).to have_css('.fc-event-title', text: work_package.subject)
+ expect(page).to have_css(".fc-event-title", text: work_package.subject)
calendar.resize_date(work_package, work_package.due_date - 1.day)
- overview_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ overview_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
work_package.reload
expect(work_package.due_date).to eq Time.zone.today.beginning_of_week.next_occurring(:wednesday)
calendar.resize_date(work_package, work_package.due_date - 1.day)
- overview_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ overview_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
work_package.reload
expect(work_package.due_date).to eq Time.zone.today.beginning_of_week.next_occurring(:tuesday)
diff --git a/modules/calendar/spec/features/calendars_global_create_spec.rb b/modules/calendar/spec/features/calendars_global_create_spec.rb
index 000c849625a2..8f6eddadaf81 100644
--- a/modules/calendar/spec/features/calendars_global_create_spec.rb
+++ b/modules/calendar/spec/features/calendars_global_create_spec.rb
@@ -28,15 +28,15 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
-require_relative '../support/pages/calendar'
-require_relative 'shared_context'
+require "spec_helper"
+require_relative "../support/pages/calendar"
+require_relative "shared_context"
-RSpec.describe 'Calendar',
- 'Creating a view from a Global Context',
+RSpec.describe "Calendar",
+ "Creating a view from a Global Context",
:js,
:with_cuprite do
- include_context 'with calendar full access'
+ include_context "with calendar full access"
let(:calendars_page) { Pages::Calendar.new nil }
@@ -44,29 +44,29 @@
login_as user
end
- context 'within the global index page' do
+ context "within the global index page" do
before do
visit calendars_path
end
- context 'when clicking on the create button' do
+ context "when clicking on the create button" do
before do
calendars_page.click_on_create_button
end
- it 'navigates to the global create form' do
+ it "navigates to the global create form" do
expect(page).to have_current_path new_calendar_path
expect(page).to have_content I18n.t(:label_new_calendar)
end
end
end
- context 'within the global create page' do
+ context "within the global create page" do
before do
visit new_calendar_path
end
- context 'with all fields set' do
+ context "with all fields set" do
before do
wait_for_reload # Halt until the project autocompleter is ready
@@ -79,15 +79,15 @@
wait_for_reload
end
- it 'creates a view and redirects me to it' do
+ it "creates a view and redirects me to it" do
expect(page).to have_text(I18n.t(:notice_successful_create))
expect(page).to have_current_path(project_calendar_path(project, Query.last), ignore_query: true)
expect(page).to have_text("Batman's Itinerary")
end
end
- context 'when missing a required field' do
- describe 'title' do
+ context "when missing a required field" do
+ describe "title" do
before do
wait_for_reload # Halt until the project autocompleter is ready
@@ -95,7 +95,7 @@
calendars_page.click_on_submit
end
- it 'renders a required attribute validation error' do
+ it "renders a required attribute validation error" do
expect(Query.all).to be_empty
# Required HTML attribute just warns
@@ -103,7 +103,7 @@
end
end
- describe 'project_id' do
+ describe "project_id" do
before do
calendars_page.set_title("Batman's Itinerary")
calendars_page.click_on_submit
@@ -111,7 +111,7 @@
wait_for_reload
end
- it 'renders a required attribute validation error' do
+ it "renders a required attribute validation error" do
expect(Query.all).to be_empty
expect(page).to have_text("Project can't be blank.")
@@ -119,13 +119,13 @@
end
end
- describe 'cancel button' do
+ describe "cancel button" do
context "when it's clicked" do
before do
calendars_page.click_on_cancel_button
end
- it 'navigates back to the global index page' do
+ it "navigates back to the global index page" do
expect(page).to have_current_path(calendars_path)
end
end
diff --git a/modules/calendar/spec/features/calendars_index_spec.rb b/modules/calendar/spec/features/calendars_index_spec.rb
index 16629d7e9e2e..4124f0c898ec 100644
--- a/modules/calendar/spec/features/calendars_index_spec.rb
+++ b/modules/calendar/spec/features/calendars_index_spec.rb
@@ -26,19 +26,19 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../support/pages/calendar'
+require "spec_helper"
+require_relative "../support/pages/calendar"
-RSpec.describe 'Calendars', 'index', :with_cuprite do
+RSpec.describe "Calendars", "index", :with_cuprite do
# The order the Projects are created in is important. By naming `project` alphanumerically
# after `other_project`, we can ensure that subsequent specs that assert sorting is
# correct for the right reasons (sorting by Project name and not id)
shared_let(:project) do
- create(:project, name: 'Project 2', enabled_module_names: %w[work_package_tracking calendar_view])
+ create(:project, name: "Project 2", enabled_module_names: %w[work_package_tracking calendar_view])
end
shared_let(:other_project) do
- create(:project, name: 'Project 1', enabled_module_names: %w[work_package_tracking calendar_view])
+ create(:project, name: "Project 1", enabled_module_names: %w[work_package_tracking calendar_view])
end
shared_let(:permissions) do
@@ -69,12 +69,12 @@
create(:user, member_with_permissions: { project => permissions, other_project => permissions })
end
- context 'when navigating to the global index page', :js do
- shared_examples 'global index page is reachable' do
- it 'is reachable' do
+ context "when navigating to the global index page", :js do
+ shared_examples "global index page is reachable" do
+ it "is reachable" do
expect(page).to have_current_path(calendars_path)
- expect(page).to have_text 'There is currently nothing to display.'
- expect(page).to have_css '#main-menu'
+ expect(page).to have_text "There is currently nothing to display."
+ expect(page).to have_css "#main-menu"
end
end
@@ -84,30 +84,30 @@
wait_for_reload
end
- context 'with the modules menu' do
+ context "with the modules menu" do
before do
find("a[title='Modules']").click
- within '#more-menu' do
- click_on 'Calendars'
+ within "#more-menu" do
+ click_on "Calendars"
end
end
- it_behaves_like 'global index page is reachable'
+ it_behaves_like "global index page is reachable"
end
- context 'with the global menu' do
+ context "with the global menu" do
before do
- within '#main-menu' do
- click_on 'Calendars'
+ within "#main-menu" do
+ click_on "Calendars"
end
end
- it_behaves_like 'global index page is reachable'
+ it_behaves_like "global index page is reachable"
end
end
- context 'when visiting from a global context' do
+ context "when visiting from a global context" do
let(:calendars_page) { Pages::Calendar.new(nil) }
let(:queries) { [query, other_query] }
@@ -117,29 +117,29 @@
visit calendars_path
end
- context 'with permissions to globally manage calendars' do
- it 'shows the create new button' do
+ context "with permissions to globally manage calendars" do
+ it "shows the create new button" do
calendars_page.expect_create_button
end
end
- context 'with no views' do
+ context "with no views" do
let(:queries) { [] }
- it 'shows an empty index page' do
+ it "shows an empty index page" do
calendars_page.expect_no_views_visible
end
end
- context 'with existing views' do
- it 'shows those views', :aggregate_failures do
+ context "with existing views" do
+ it "shows those views", :aggregate_failures do
queries.each do |q|
calendars_page.expect_view_visible(q)
calendars_page.expect_no_delete_button(q)
end
end
- describe 'sorting' do
+ describe "sorting" do
before do
# Name ASC is the default sort order for Calendars
# We can assert the initial sort by expecting the order is
@@ -150,26 +150,26 @@
end
it 'allows sorting by "Name", "Project" and "Created On"' do
- aggregate_failures 'Sorting by Name' do
- calendars_page.click_to_sort_by('Name')
+ aggregate_failures "Sorting by Name" do
+ calendars_page.click_to_sort_by("Name")
calendars_page.expect_views_listed_in_order(other_query,
query)
end
- aggregate_failures 'Sorting by Project' do
- calendars_page.click_to_sort_by('Project')
+ aggregate_failures "Sorting by Project" do
+ calendars_page.click_to_sort_by("Project")
calendars_page.expect_views_listed_in_order(other_query,
query)
- calendars_page.click_to_sort_by('Project')
+ calendars_page.click_to_sort_by("Project")
calendars_page.expect_views_listed_in_order(query,
other_query)
end
- aggregate_failures 'Sorting by Created On' do
- calendars_page.click_to_sort_by('Created on')
+ aggregate_failures "Sorting by Created On" do
+ calendars_page.click_to_sort_by("Created on")
calendars_page.expect_views_listed_in_order(query,
other_query)
- calendars_page.click_to_sort_by('Created on')
+ calendars_page.click_to_sort_by("Created on")
calendars_page.expect_views_listed_in_order(other_query,
query)
end
@@ -177,17 +177,17 @@
end
end
- context 'with another user with limited access' do
+ context "with another user with limited access" do
let(:current_user) do
create(:user,
- firstname: 'Bernd',
+ firstname: "Bernd",
member_with_permissions: { project => %w[view_work_packages view_calendar] })
end
- context 'and the view is non-public' do
+ context "and the view is non-public" do
let(:query) { create(:query, user:, project:, public: false) }
- it 'does not show a non-public view' do
+ it "does not show a non-public view" do
calendars_page.expect_no_views_visible
calendars_page.expect_view_not_visible query
@@ -197,7 +197,7 @@
end
end
- context 'when visiting from a project-specific context' do
+ context "when visiting from a project-specific context" do
let(:calendars_page) { Pages::Calendar.new(project) }
before do
@@ -206,39 +206,39 @@
visit project_calendars_path(project)
end
- context 'with no views' do
+ context "with no views" do
let(:query) { nil }
- it 'shows an empty index page' do
+ it "shows an empty index page" do
calendars_page.expect_no_views_visible
calendars_page.expect_create_button
end
end
- context 'with an existing view' do
- it 'shows that view' do
+ context "with an existing view" do
+ it "shows that view" do
calendars_page.expect_view_visible query
calendars_page.expect_delete_button query
end
- context 'with another user with limited access' do
+ context "with another user with limited access" do
let(:current_user) do
create(:user,
- firstname: 'Bernd',
+ firstname: "Bernd",
member_with_permissions: { project => %w[view_work_packages view_calendar] })
end
- it 'does not show the management buttons' do
+ it "does not show the management buttons" do
calendars_page.expect_view_visible query
calendars_page.expect_no_delete_button query
calendars_page.expect_no_create_button
end
- context 'when the view is non-public' do
+ context "when the view is non-public" do
let(:query) { create(:query, user:, project:, public: false) }
- it 'does not show a non-public view' do
+ it "does not show a non-public view" do
calendars_page.expect_no_views_visible
calendars_page.expect_view_not_visible query
diff --git a/modules/calendar/spec/features/calendars_spec.rb b/modules/calendar/spec/features/calendars_spec.rb
index 7edd7505e2e2..9b855f1571c8 100644
--- a/modules/calendar/spec/features/calendars_spec.rb
+++ b/modules/calendar/spec/features/calendars_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package calendars', :js do
+RSpec.describe "Work package calendars", :js do
let(:project) { create(:project) }
let(:user) do
create(:user,
@@ -36,28 +36,28 @@
end
let!(:current_work_package) do
create(:work_package,
- subject: 'Current work package',
+ subject: "Current work package",
project:,
start_date: Time.zone.today.at_beginning_of_month + 15.days,
due_date: Time.zone.today.at_beginning_of_month + 15.days)
end
let!(:another_current_work_package) do
create(:work_package,
- subject: 'Another current work package',
+ subject: "Another current work package",
project:,
start_date: Time.zone.today.at_beginning_of_month + 12.days,
due_date: Time.zone.today.at_beginning_of_month + 18.days)
end
let!(:future_work_package) do
create(:work_package,
- subject: 'Future work package',
+ subject: "Future work package",
project:,
start_date: Time.zone.today.at_beginning_of_month.next_month + 15.days,
due_date: Time.zone.today.at_beginning_of_month.next_month + 15.days)
end
let!(:another_future_work_package) do
create(:work_package,
- subject: 'Another future work package',
+ subject: "Another future work package",
project:,
start_date: Time.zone.today.at_beginning_of_month.next_month + 12.days,
due_date: Time.zone.today.at_beginning_of_month.next_month + 18.days)
@@ -69,131 +69,131 @@
login_as(user)
end
- it 'navigates to today, allows filtering, switching the view and retrains the state' do
+ it "navigates to today, allows filtering, switching the view and retrains the state" do
visit project_path(project)
- within '#main-menu' do
- click_link 'Calendars'
+ within "#main-menu" do
+ click_link "Calendars"
end
# Expect empty index
- expect(page).to have_text 'There is currently nothing to display.'
+ expect(page).to have_text "There is currently nothing to display."
# Open a new calendar from there
- find('.toolbar-item a', text: 'Calendar').click
+ find(".toolbar-item a", text: "Calendar").click
loading_indicator_saveguard
# should open the calendar with the current month displayed
expect(page)
- .to have_css '.fc-event-title', text: current_work_package.subject
+ .to have_css ".fc-event-title", text: current_work_package.subject
expect(page)
- .to have_css '.fc-event-title', text: another_current_work_package.subject
+ .to have_css ".fc-event-title", text: another_current_work_package.subject
expect(page)
- .to have_no_css '.fc-event-title', text: future_work_package.subject
+ .to have_no_css ".fc-event-title", text: future_work_package.subject
expect(page)
- .to have_no_css '.fc-event-title', text: another_future_work_package.subject
+ .to have_no_css ".fc-event-title", text: another_future_work_package.subject
filters.expect_filter_count 1
filters.open
# The filter for the time frame added implicitly should not be visible
- filters.expect_no_filter_by('Dates interval', 'datesInterval')
+ filters.expect_no_filter_by("Dates interval", "datesInterval")
# The user can filter by e.g. the subject filter
- filters.add_filter_by 'Subject', 'contains', ['Another']
+ filters.add_filter_by "Subject", "contains", ["Another"]
# non matching work packages are no longer displayed
expect(page)
- .to have_no_css '.fc-event-title', text: current_work_package.subject
+ .to have_no_css ".fc-event-title", text: current_work_package.subject
expect(page)
- .to have_css '.fc-event-title', text: another_current_work_package.subject
+ .to have_css ".fc-event-title", text: another_current_work_package.subject
# The filter for the time frame added implicitly should not be visible
filters.expect_filter_count 2
# navigate to the next month
- find('.fc-next-button').click
+ find(".fc-next-button").click
expect(page)
- .to have_no_css '.fc-event-title', text: current_work_package.subject
+ .to have_no_css ".fc-event-title", text: current_work_package.subject
expect(page)
- .to have_no_css '.fc-event-title', text: another_current_work_package.subject
+ .to have_no_css ".fc-event-title", text: another_current_work_package.subject
expect(page)
- .to have_no_css '.fc-event-title', text: future_work_package.subject
+ .to have_no_css ".fc-event-title", text: future_work_package.subject
expect(page)
- .to have_css '.fc-event-title', text: another_future_work_package.subject
+ .to have_css ".fc-event-title", text: another_future_work_package.subject
# removing the filter will show the event again
- filters.remove_filter 'subject'
+ filters.remove_filter "subject"
expect(page)
- .to have_no_css '.fc-event-title', text: current_work_package.subject
+ .to have_no_css ".fc-event-title", text: current_work_package.subject
expect(page)
- .to have_no_css '.fc-event-title', text: another_current_work_package.subject
+ .to have_no_css ".fc-event-title", text: another_current_work_package.subject
expect(page)
- .to have_css '.fc-event-title', text: future_work_package.subject
+ .to have_css ".fc-event-title", text: future_work_package.subject
expect(page)
- .to have_css '.fc-event-title', text: another_future_work_package.subject
+ .to have_css ".fc-event-title", text: another_future_work_package.subject
future_url = current_url
# navigate back a month
- find('.fc-prev-button').click
+ find(".fc-prev-button").click
expect(page)
- .to have_css '.fc-event-title', text: current_work_package.subject
+ .to have_css ".fc-event-title", text: current_work_package.subject
expect(page)
- .to have_css '.fc-event-title', text: another_current_work_package.subject
+ .to have_css ".fc-event-title", text: another_current_work_package.subject
expect(page)
- .to have_no_css '.fc-event-title', text: future_work_package.subject
+ .to have_no_css ".fc-event-title", text: future_work_package.subject
expect(page)
- .to have_no_css '.fc-event-title', text: another_future_work_package.subject
+ .to have_no_css ".fc-event-title", text: another_future_work_package.subject
# open the page via the url should show the next month again
visit future_url
expect(page)
- .to have_no_css '.fc-event-title', text: current_work_package.subject
+ .to have_no_css ".fc-event-title", text: current_work_package.subject
expect(page)
- .to have_no_css '.fc-event-title', text: another_current_work_package.subject
+ .to have_no_css ".fc-event-title", text: another_current_work_package.subject
expect(page)
- .to have_css '.fc-event-title', text: future_work_package.subject
+ .to have_css ".fc-event-title", text: future_work_package.subject
expect(page)
- .to have_css '.fc-event-title', text: another_future_work_package.subject
+ .to have_css ".fc-event-title", text: another_future_work_package.subject
# go back a month by using the browser back functionality
- page.execute_script('window.history.back()')
+ page.execute_script("window.history.back()")
expect(page)
- .to have_css '.fc-event-title', text: current_work_package.subject
+ .to have_css ".fc-event-title", text: current_work_package.subject
expect(page)
- .to have_css '.fc-event-title', text: another_current_work_package.subject
+ .to have_css ".fc-event-title", text: another_current_work_package.subject
expect(page)
- .to have_no_css '.fc-event-title', text: future_work_package.subject
+ .to have_no_css ".fc-event-title", text: future_work_package.subject
expect(page)
- .to have_no_css '.fc-event-title', text: another_future_work_package.subject
+ .to have_no_css ".fc-event-title", text: another_future_work_package.subject
# click goes to work package split screen
- page.find('.fc-event-title', text: current_work_package.subject).click
+ page.find(".fc-event-title", text: current_work_package.subject).click
current_wp_split_screen.expect_open
# Going back in browser history will lead us back to the calendar
# Regression #29664
page.go_back
expect(page)
- .to have_css('.fc-event-title', text: current_work_package.subject, wait: 20)
+ .to have_css(".fc-event-title", text: current_work_package.subject, wait: 20)
current_wp_split_screen.expect_closed
# click goes to work package split screen page again
- page.find('.fc-event-title', text: current_work_package.subject).click
+ page.find(".fc-event-title", text: current_work_package.subject).click
current_wp_split_screen.expect_open
# click back goes back to calendar
current_wp_split_screen.close
expect(page)
- .to have_css '.fc-event-title', text: current_work_package.subject, wait: 20
+ .to have_css ".fc-event-title", text: current_work_package.subject, wait: 20
current_wp_split_screen.expect_closed
end
end
diff --git a/modules/calendar/spec/features/query_handling_spec.rb b/modules/calendar/spec/features/query_handling_spec.rb
index 77297e3028c0..64a17a140c04 100644
--- a/modules/calendar/spec/features/query_handling_spec.rb
+++ b/modules/calendar/spec/features/query_handling_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../support/pages/calendar'
-require_relative '../../../../spec/features/views/shared_examples'
+require "spec_helper"
+require_relative "../support/pages/calendar"
+require_relative "../../../../spec/features/views/shared_examples"
-RSpec.describe 'Calendar query handling', :js do
+RSpec.describe "Calendar query handling", :js do
shared_let(:type_task) { create(:type_task) }
shared_let(:type_bug) { create(:type_bug) }
shared_let(:project) do
@@ -57,7 +57,7 @@
assigned_to: user,
start_date: Time.zone.today - 1.day,
due_date: Time.zone.today + 1.day,
- subject: 'A task for the user')
+ subject: "A task for the user")
end
shared_let(:bug) do
create(:work_package,
@@ -66,7 +66,7 @@
assigned_to: user,
start_date: Time.zone.today - 1.day,
due_date: Time.zone.today + 1.day,
- subject: 'A bug for the user')
+ subject: "A bug for the user")
end
shared_let(:saved_query) do
@@ -83,12 +83,12 @@
current_user { user }
- it 'shows that query on the index page' do
+ it "shows that query on the index page" do
visit project_calendars_path(project)
expect(page).to have_text saved_query.name
- within '#content' do
+ within "#content" do
click_link saved_query.name
end
@@ -98,7 +98,7 @@
calendar_page.expect_event bug
end
- context 'when on the show page of the calendar' do
+ context "when on the show page of the calendar" do
before do
login_as user
calendar_page.visit!
@@ -109,11 +109,11 @@
calendar_page.expect_event bug
end
- it 'allows saving the calendar' do
+ it "allows saving the calendar" do
filters.expect_filter_count("1")
filters.open
- filters.add_filter_by('Type', 'is (OR)', [type_bug.name])
+ filters.add_filter_by("Type", "is (OR)", [type_bug.name])
filters.expect_filter_count("2")
@@ -123,35 +123,35 @@
query_title.expect_changed
query_title.press_save_button
- calendar_page.expect_and_dismiss_toaster(message: I18n.t('js.notice_successful_create'))
+ calendar_page.expect_and_dismiss_toaster(message: I18n.t("js.notice_successful_create"))
end
- it 'shows only calendar queries' do
+ it "shows only calendar queries" do
# Go to calendar where a query is already shown
query_menu.expect_menu_entry saved_query.name
# Change filter
filters.open
- filters.add_filter_by('Type', 'is (OR)', [type_bug.name])
+ filters.add_filter_by("Type", "is (OR)", [type_bug.name])
filters.expect_filter_count("2")
# Save current filters
query_title.expect_changed
- query_title.rename 'I am your Query'
- calendar_page.expect_and_dismiss_toaster(message: I18n.t('js.notice_successful_create'))
+ query_title.rename "I am your Query"
+ calendar_page.expect_and_dismiss_toaster(message: I18n.t("js.notice_successful_create"))
# The saved query appears in the side menu...
- query_menu.expect_menu_entry 'I am your Query'
+ query_menu.expect_menu_entry "I am your Query"
query_menu.expect_menu_entry saved_query.name
# .. but not in the work packages module
work_package_page.visit!
- query_menu.expect_menu_entry_not_visible 'I am your Query'
+ query_menu.expect_menu_entry_not_visible "I am your Query"
end
- it_behaves_like 'module specific query view management' do
+ it_behaves_like "module specific query view management" do
let(:module_page) { calendar_page }
- let(:default_name) { 'Unnamed calendar' }
+ let(:default_name) { "Unnamed calendar" }
let(:initial_filter_count) { 1 }
end
end
diff --git a/modules/calendar/spec/features/shared_context.rb b/modules/calendar/spec/features/shared_context.rb
index c2ec5c8687ab..0f16fc8da28d 100644
--- a/modules/calendar/spec/features/shared_context.rb
+++ b/modules/calendar/spec/features/shared_context.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../support/pages/calendar'
+require "spec_helper"
+require_relative "../support/pages/calendar"
-RSpec.shared_context 'with calendar full access' do
+RSpec.shared_context "with calendar full access" do
shared_let(:project) do
create(:project, enabled_module_names: %w[work_package_tracking calendar_view])
end
diff --git a/modules/calendar/spec/routing/calendar_routing_spec.rb b/modules/calendar/spec/routing/calendar_routing_spec.rb
index 602329cb9401..df154e6e2277 100644
--- a/modules/calendar/spec/routing/calendar_routing_spec.rb
+++ b/modules/calendar/spec/routing/calendar_routing_spec.rb
@@ -26,41 +26,41 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Calendar::CalendarsController do
it do
- expect(get('calendars')).to route_to(controller: 'calendar/calendars',
- action: 'index')
+ expect(get("calendars")).to route_to(controller: "calendar/calendars",
+ action: "index")
end
it do
- expect(get('/projects/1/calendars')).to route_to(controller: 'calendar/calendars',
- action: 'index',
- project_id: '1')
+ expect(get("/projects/1/calendars")).to route_to(controller: "calendar/calendars",
+ action: "index",
+ project_id: "1")
end
it do
- expect(get('/projects/1/calendars/2')).to route_to(controller: 'calendar/calendars',
- action: 'show',
- id: '2',
- project_id: '1')
+ expect(get("/projects/1/calendars/2")).to route_to(controller: "calendar/calendars",
+ action: "show",
+ id: "2",
+ project_id: "1")
end
it do
- expect(get('/calendars/new')).to route_to(controller: 'calendar/calendars',
- action: 'new')
+ expect(get("/calendars/new")).to route_to(controller: "calendar/calendars",
+ action: "new")
end
it do
- expect(post('/calendars')).to route_to(controller: 'calendar/calendars',
- action: 'create')
+ expect(post("/calendars")).to route_to(controller: "calendar/calendars",
+ action: "create")
end
it do
- expect(delete('/projects/1/calendars/2')).to route_to(controller: 'calendar/calendars',
- action: 'destroy',
- id: '2',
- project_id: '1')
+ expect(delete("/projects/1/calendars/2")).to route_to(controller: "calendar/calendars",
+ action: "destroy",
+ id: "2",
+ project_id: "1")
end
end
diff --git a/modules/calendar/spec/routing/ical_routing_spec.rb b/modules/calendar/spec/routing/ical_routing_spec.rb
index 5f77112b4e3d..77e4d2fda98d 100644
--- a/modules/calendar/spec/routing/ical_routing_spec.rb
+++ b/modules/calendar/spec/routing/ical_routing_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Calendar::ICalController do
it do
- expect(get('/projects/1/calendars/2/ical')).to route_to(controller: 'calendar/ical',
- action: 'show',
- id: '2',
- project_id: '1')
+ expect(get("/projects/1/calendars/2/ical")).to route_to(controller: "calendar/ical",
+ action: "show",
+ id: "2",
+ project_id: "1")
end
end
diff --git a/modules/calendar/spec/services/create_ical_service_spec.rb b/modules/calendar/spec/services/create_ical_service_spec.rb
index 1189b29618ac..6030305d818d 100644
--- a/modules/calendar/spec/services/create_ical_service_spec.rb
+++ b/modules/calendar/spec/services/create_ical_service_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Calendar::CreateICalService, type: :model do
let(:project) { create(:project) }
@@ -83,7 +83,7 @@
end
# rubocop:disable RSpec/ExampleLength
- it 'converts work_packages to an ical string which contains all required ical fields in the correct format and order' do
+ it "converts work_packages to an ical string which contains all required ical fields in the correct format and order" do
expected_ical_string = <<~EOICAL.gsub("\r ", "").delete("\r")
BEGIN:VCALENDAR
VERSION:2.0
@@ -134,12 +134,12 @@
end
# rubocop:enable RSpec/ExampleLength
- it 'is a success' do
+ it "is a success" do
expect(subject)
.to be_success
end
- describe 'stripped and truncated workpackage description' do
+ describe "stripped and truncated workpackage description" do
let(:work_package_with_rich_text_description) do
create(:work_package, project:,
due_date: Time.zone.today + 7.days, assigned_to: user,
@@ -168,21 +168,21 @@
]
end
- it 'strips html tags from the description' do
+ it "strips html tags from the description" do
expect(formatted_result).to include("test description") # no tags
expect(formatted_result).to include("\nfoo\nbar\nbaz") # no tags or tags
end
- it 'strips images from the description' do
+ it "strips images from the description" do
expect(formatted_result).to include("test image") # no tags
end
- it 'truncates the description at 250 chars' do
+ it "truncates the description at 250 chars" do
expect(formatted_result).to include("sanctus est ...")
end
end
- describe 'sanitized attributes' do
+ describe "sanitized attributes" do
# the iCalendar gem takes care of escaping malicious values
# following specs double check on this behaviour
let(:work_package_with_malicious_subject) do
@@ -201,12 +201,12 @@
]
end
- it 'escapes malicious workpackage subject values' do
+ it "escapes malicious workpackage subject values" do
expect(formatted_result).not_to include("")
expect(formatted_result).to include("<\\;script>\\;alert('Subject')\\;<\\;/script>\\;")
end
- it 'escapes malicious workpackage description values' do
+ it "escapes malicious workpackage description values" do
expect(formatted_result).not_to include("")
expect(formatted_result).to include("<\\;script>\\;alert('Description')\\;<\\;/script>\\;")
end
diff --git a/modules/calendar/spec/services/global_create_service_spec.rb b/modules/calendar/spec/services/global_create_service_spec.rb
index a24031a9f32d..b7424e615fc7 100644
--- a/modules/calendar/spec/services/global_create_service_spec.rb
+++ b/modules/calendar/spec/services/global_create_service_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Calendar::Views::GlobalCreateService do
shared_let(:project) { create(:project) }
@@ -37,7 +37,7 @@
subject { instance.call(params) }
- context 'with all valid params' do
+ context "with all valid params" do
let(:params) do
{
name: "Batman's Itinerary",
@@ -47,15 +47,15 @@
}
end
- it 'is successful' do
+ it "is successful" do
expect(subject).to be_success
end
- it 'creates a calendar view and its query' do
+ it "creates a calendar view and its query" do
view = subject.result
query = view.query
- expect(view.type).to eq 'work_packages_calendar'
+ expect(view.type).to eq "work_packages_calendar"
expect(query.name).to eq "Batman's Itinerary"
expect(query.project).to eql(project)
diff --git a/modules/calendar/spec/services/resolve_ical_token_service_spec.rb b/modules/calendar/spec/services/resolve_ical_token_service_spec.rb
index 7b48bfb0f607..452d7cfc2866 100644
--- a/modules/calendar/spec/services/resolve_ical_token_service_spec.rb
+++ b/modules/calendar/spec/services/resolve_ical_token_service_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Calendar::ResolveICalTokenService, type: :model do
let(:user) { create(:user) }
@@ -40,10 +40,10 @@
described_class.new
end
- context 'for a given valid ical token value' do
+ context "for a given valid ical token value" do
subject { instance.call(ical_token_string: valid_ical_token_value) }
- it 'resolves the ical_token instance as result' do
+ it "resolves the ical_token instance as result" do
ical_token_instance = subject.result
expect(ical_token_instance)
@@ -56,24 +56,24 @@
.to eql query
end
- it 'is a success' do
+ it "is a success" do
expect(subject)
.to be_success
end
end
- context 'when given ical token value is invalid' do
+ context "when given ical token value is invalid" do
subject { instance.call(ical_token_string: invalid_ical_token_value) }
- it 'raises ActiveRecord::RecordNotFound' do
+ it "raises ActiveRecord::RecordNotFound" do
expect { subject }.to raise_error(ActiveRecord::RecordNotFound)
end
end
- context 'when no ical token value is given' do
+ context "when no ical token value is given" do
subject { instance.call(ical_token_string: nil) }
- it 'raises ActiveRecord::RecordNotFound' do
+ it "raises ActiveRecord::RecordNotFound" do
expect { subject }.to raise_error(ActiveRecord::RecordNotFound)
end
end
diff --git a/modules/calendar/spec/services/resolve_work_packages_service_spec.rb b/modules/calendar/spec/services/resolve_work_packages_service_spec.rb
index 0fafae8173c6..644e6b7ed86f 100644
--- a/modules/calendar/spec/services/resolve_work_packages_service_spec.rb
+++ b/modules/calendar/spec/services/resolve_work_packages_service_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Calendar::ResolveWorkPackagesService, type: :model do
let(:user1) do
@@ -83,7 +83,7 @@
described_class.new
end
- context 'for a valid query' do
+ context "for a valid query" do
before do
# login for this isolated test:
# in context of the whole iCalendar API flow, the user is not logged in but resolved from the token
@@ -93,7 +93,7 @@
subject { instance.call(query:) }
- it 'returns work_packages of query with start and due date as result' do
+ it "returns work_packages of query with start and due date as result" do
result = subject.result
expect(result)
@@ -108,20 +108,20 @@
.not_to include(work_package_without_dates)
end
- it 'is a success' do
+ it "is a success" do
expect(subject)
.to be_success
end
end
- context 'if query is nil' do
+ context "if query is nil" do
before do
login_as(user1)
end
subject { instance.call(query: nil) }
- it 'does not resolve work_packages and raises ActiveRecord::RecordNotFound' do
+ it "does not resolve work_packages and raises ActiveRecord::RecordNotFound" do
expect { subject }.to raise_error(ActiveRecord::RecordNotFound)
end
end
diff --git a/modules/calendar/spec/support/pages/calendar.rb b/modules/calendar/spec/support/pages/calendar.rb
index 7eb67e018524..84b4760bf9c6 100644
--- a/modules/calendar/spec/support/pages/calendar.rb
+++ b/modules/calendar/spec/support/pages/calendar.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'support/pages/page'
+require "support/pages/page"
module Pages
class Calendar < ::Pages::Page
@@ -45,7 +45,7 @@ def initialize(project, query = nil)
end
def path
- project_calendar_path(project, id: query&.id || 'new')
+ project_calendar_path(project, id: query&.id || "new")
end
def add_item(start_date, end_date)
@@ -68,7 +68,7 @@ def resize_date(work_package, date, end_date: true)
.move_to(wp_strip.native)
.perform
- selector = end_date ? '.fc-event-resizer-end' : '.fc-event-resizer-start'
+ selector = end_date ? ".fc-event-resizer-end" : ".fc-event-resizer-start"
resizer = wp_strip.find(selector)
end_container = date_container date
@@ -88,73 +88,73 @@ def date_container(date)
page.find(".fc-day[data-date='#{str}'] .fc-daygrid-day-frame")
end
- def expect_title(title = 'Unnamed calendar')
- expect(page).to have_css '.editable-toolbar-title--fixed', text: title
+ def expect_title(title = "Unnamed calendar")
+ expect(page).to have_css ".editable-toolbar-title--fixed", text: title
end
def expect_event(work_package, present: true)
- expect(page).to have_conditional_selector(present, '.fc-event', text: work_package.subject, wait: 10)
+ expect(page).to have_conditional_selector(present, ".fc-event", text: work_package.subject, wait: 10)
end
def open_split_view(work_package)
page
- .find('.fc-event', text: work_package.subject)
+ .find(".fc-event", text: work_package.subject)
.click
::Pages::SplitWorkPackage.new(work_package, project)
end
def event(work_package)
- page.find('.fc-event', text: work_package.subject)
+ page.find(".fc-event", text: work_package.subject)
end
def expect_wp_not_resizable(work_package)
- expect(page).to have_css('.fc-event:not(.fc-event-resizable)', text: work_package.subject)
+ expect(page).to have_css(".fc-event:not(.fc-event-resizable)", text: work_package.subject)
end
def expect_wp_not_draggable(work_package)
- expect(page).to have_css('.fc-event:not(.fc-event-draggable)', text: work_package.subject)
+ expect(page).to have_css(".fc-event:not(.fc-event-draggable)", text: work_package.subject)
end
def set_title(title)
- fill_in 'Title', with: title
+ fill_in "Title", with: title
end
def set_project(project)
select_autocomplete(find('[data-test-selector="project_id"]'),
query: project,
- results_selector: 'body',
+ results_selector: "body",
wait_for_fetched_options: false)
end
def set_public
- check 'Public'
+ check "Public"
end
def set_favoured
- check 'Favoured'
+ check "Favoured"
end
def click_on_submit
- click_on 'Create'
+ click_on "Create"
end
def click_on_create_button
- within '.toolbar-items' do
- click_link 'Calendar'
+ within ".toolbar-items" do
+ click_link "Calendar"
end
end
def click_on_cancel_button
- click_on 'Cancel'
+ click_on "Cancel"
end
def expect_create_button
- expect(page).to have_css '.button', text: 'Calendar'
+ expect(page).to have_css ".button", text: "Calendar"
end
def expect_no_create_button
- expect(page).to have_no_css '.button', text: 'Calendar'
+ expect(page).to have_no_css ".button", text: "Calendar"
end
def expect_delete_button(query)
@@ -166,20 +166,20 @@ def expect_no_delete_button(query)
end
def expect_no_views_visible
- expect(page).to have_text 'There is currently nothing to display.'
+ expect(page).to have_text "There is currently nothing to display."
end
def expect_view_visible(query)
- expect(page).to have_css 'td', text: query.name
+ expect(page).to have_css "td", text: query.name
end
def expect_view_not_visible(query)
- expect(page).to have_no_css 'td', text: query.name
+ expect(page).to have_no_css "td", text: query.name
end
def expect_views_listed_in_order(*queries)
- within '.generic-table tbody' do
- listed_view_names = all('tr td.name').map(&:text)
+ within ".generic-table tbody" do
+ listed_view_names = all("tr td.name").map(&:text)
expect(listed_view_names).to eq(queries.map(&:name))
end
diff --git a/modules/costs/app/controllers/cost_types_controller.rb b/modules/costs/app/controllers/cost_types_controller.rb
index ffc670710647..2cbf4b4229fc 100644
--- a/modules/costs/app/controllers/cost_types_controller.rb
+++ b/modules/costs/app/controllers/cost_types_controller.rb
@@ -30,7 +30,7 @@ class CostTypesController < ApplicationController
# Allow only admins here
before_action :require_admin
before_action :find_cost_type, only: %i[edit update set_rate destroy restore]
- layout 'admin'
+ layout "admin"
helper :sort
include SortHelper
@@ -38,10 +38,10 @@ class CostTypesController < ApplicationController
include CostTypesHelper
def index
- sort_init 'name', 'asc'
- sort_columns = { 'name' => "#{CostType.table_name}.name",
- 'unit' => "#{CostType.table_name}.unit",
- 'unit_plural' => "#{CostType.table_name}.unit_plural" }
+ sort_init "name", "asc"
+ sort_columns = { "name" => "#{CostType.table_name}.name",
+ "unit" => "#{CostType.table_name}.unit",
+ "unit_plural" => "#{CostType.table_name}.unit_plural" }
sort_update sort_columns
@cost_types = CostType.order(sort_clause)
@@ -58,11 +58,11 @@ def index
@include_deleted = params[:include_deleted]
end
- render action: 'index', layout: !request.xhr?
+ render action: "index", layout: !request.xhr?
end
def edit
- render action: 'edit', layout: !request.xhr?
+ render action: "edit", layout: !request.xhr?
end
def update
@@ -70,9 +70,9 @@ def update
if @cost_type.save
flash[:notice] = t(:notice_successful_update)
- redirect_back_or_default(action: 'index')
+ redirect_back_or_default(action: "index")
else
- render action: 'edit', layout: !request.xhr?
+ render action: "edit", layout: !request.xhr?
end
rescue ActiveRecord::StaleObjectError
# Optimistic locking exception
@@ -84,7 +84,7 @@ def new
@cost_type.rates.build(valid_from: Date.today) if @cost_type.rates.empty?
- render action: 'edit', layout: !request.xhr?
+ render action: "edit", layout: !request.xhr?
end
def create
@@ -92,10 +92,10 @@ def create
if @cost_type.save
flash[:notice] = t(:notice_successful_update)
- redirect_back_or_default(action: 'index')
+ redirect_back_or_default(action: "index")
else
@cost_type.rates.build(valid_from: Date.today) if @cost_type.rates.empty?
- render action: 'edit', layout: !request.xhr?
+ render action: "edit", layout: !request.xhr?
end
rescue ActiveRecord::StaleObjectError
# Optimistic locking exception
@@ -109,7 +109,7 @@ def destroy
if @cost_type.save
flash[:notice] = t(:notice_successful_lock)
- redirect_back_or_default(action: 'index')
+ redirect_back_or_default(action: "index")
end
end
@@ -120,7 +120,7 @@ def restore
if @cost_type.save
flash[:notice] = t(:notice_successful_restore)
- redirect_back_or_default(action: 'index')
+ redirect_back_or_default(action: "index")
end
end
@@ -136,11 +136,11 @@ def set_rate
rate.rate = CostRate.parse_number_string_to_number(params[:rate])
if rate.save
flash[:notice] = t(:notice_successful_update)
- redirect_to action: 'index'
+ redirect_to action: "index"
else
# FIXME: Do some real error handling here
flash[:error] = t(:notice_something_wrong)
- redirect_to action: 'index'
+ redirect_to action: "index"
end
end
@@ -153,7 +153,7 @@ def find_cost_type
end
def default_breadcrumb
- if action_name == 'index'
+ if action_name == "index"
CostType.model_name.human(count: 2)
else
ActionController::Base.helpers.link_to(CostType.model_name.human(count: 2), cost_types_path)
diff --git a/modules/costs/app/controllers/costlog_controller.rb b/modules/costs/app/controllers/costlog_controller.rb
index ff169e95efec..a1d5e792271d 100644
--- a/modules/costs/app/controllers/costlog_controller.rb
+++ b/modules/costs/app/controllers/costlog_controller.rb
@@ -37,7 +37,7 @@ class CostlogController < ApplicationController
def new
new_default_cost_entry
- render action: 'edit'
+ render action: "edit"
end
def edit
@@ -57,7 +57,7 @@ def create
flash[:notice] = t(:notice_cost_logged_successfully)
redirect_back_or_default work_package_path(@cost_entry.work_package)
else
- render action: 'edit'
+ render action: "edit"
end
end
@@ -74,7 +74,7 @@ def update
redirect_back fallback_location: work_package_path(@cost_entry.work_package)
else
- render action: 'edit'
+ render action: "edit"
end
end
@@ -85,8 +85,8 @@ def destroy
@cost_entry.destroy
flash[:notice] = t(:notice_successful_delete)
- if request.referer.include?('cost_reports')
- redirect_to controller: '/cost_reports', action: :index
+ if request.referer.include?("cost_reports")
+ redirect_to controller: "/cost_reports", action: :index
else
redirect_back fallback_location: work_package_path(@cost_entry.work_package)
end
diff --git a/modules/costs/app/controllers/hourly_rates_controller.rb b/modules/costs/app/controllers/hourly_rates_controller.rb
index ee6679faa1f1..f97c18a8f02f 100644
--- a/modules/costs/app/controllers/hourly_rates_controller.rb
+++ b/modules/costs/app/controllers/hourly_rates_controller.rb
@@ -75,7 +75,7 @@ def edit
@rates << @user.rates.build(valid_from: Date.today, project: @project) if @rates.empty?
end
- render action: 'edit', layout: !request.xhr?
+ render action: "edit", layout: !request.xhr?
end
current_menu_item :edit do
@@ -93,7 +93,7 @@ def update
return deny_access unless User.current.admin?
end
- if params.include? 'user'
+ if params.include? "user"
update_rates @user,
@project,
permitted_params.user_rates[:new_rate_attributes],
@@ -105,9 +105,9 @@ def update
if @user.save
flash[:notice] = t(:notice_successful_update)
if @project.nil?
- redirect_back_or_default(controller: 'users', action: 'edit', id: @user)
+ redirect_back_or_default(controller: "users", action: "edit", id: @user)
else
- redirect_back_or_default(action: 'show', id: @user, project_id: @project)
+ redirect_back_or_default(action: "show", id: @user, project_id: @project)
end
else
if @project.nil?
@@ -120,7 +120,7 @@ def update
.sort { |a, b| b.valid_from || Date.today <=> a.valid_from || Date.today }
@rates << @user.rates.build(valid_from: Date.today, project: @project) if @rates.empty?
end
- render action: 'edit', layout: !request.xhr?
+ render action: "edit", layout: !request.xhr?
end
end
@@ -141,11 +141,11 @@ def set_rate
if request.xhr?
render :update do |page|
page.replace_html "rate_for_#{@user.id}",
- link_to(number_to_currency(rate.rate), action: 'edit', id: @user, project_id: @project)
+ link_to(number_to_currency(rate.rate), action: "edit", id: @user, project_id: @project)
end
else
flash[:notice] = t(:notice_successful_update)
- redirect_to action: 'index'
+ redirect_to action: "index"
end
end
end
diff --git a/modules/costs/app/controllers/my/timer_controller.rb b/modules/costs/app/controllers/my/timer_controller.rb
index 74c1d6c7ebe3..fa71ef8a553a 100644
--- a/modules/costs/app/controllers/my/timer_controller.rb
+++ b/modules/costs/app/controllers/my/timer_controller.rb
@@ -39,8 +39,8 @@ def show
def find_active_timer
query = Queries::TimeEntries::TimeEntryQuery.new(user: current_user)
- query.where 'ongoing', '=', ['t']
- query.where 'user_id', '=', [current_user.id]
+ query.where "ongoing", "=", ["t"]
+ query.where "user_id", "=", [current_user.id]
@timer = query.results.first
end
diff --git a/modules/costs/app/helpers/costlog_helper.rb b/modules/costs/app/helpers/costlog_helper.rb
index 00916731f327..3c1ca1fc566b 100644
--- a/modules/costs/app/helpers/costlog_helper.rb
+++ b/modules/costs/app/helpers/costlog_helper.rb
@@ -40,7 +40,7 @@ def cost_types_collection_for_select_options(selected_type = nil)
def user_collection_for_select_options(_options = {})
Principal
.possible_assignee(@project)
- .where(type: 'User')
+ .where(type: "User")
.map { |t| [t.name, t.id] }
end
diff --git a/modules/costs/app/helpers/costs/number_helper.rb b/modules/costs/app/helpers/costs/number_helper.rb
index c7c1053a0aa4..6e10d449cd3c 100644
--- a/modules/costs/app/helpers/costs/number_helper.rb
+++ b/modules/costs/app/helpers/costs/number_helper.rb
@@ -37,18 +37,18 @@ def parse_number_string(value)
# All locales seem to have their delimiters set to "".
# We thus remove all typical delimiters that are not the separator.
separator =
- if I18n.exists?(:'number.currency.format.separator')
- I18n.t(:'number.currency.format.separator')
+ if I18n.exists?(:"number.currency.format.separator")
+ I18n.t(:"number.currency.format.separator")
else
- I18n.t(:'number.format.separator', default: '.')
+ I18n.t(:"number.format.separator", default: ".")
end
if separator
- delimiters = Regexp.new('[ .,’˙]'.gsub(separator, ''))
+ delimiters = Regexp.new("[ .,’˙]".gsub(separator, ""))
- value.gsub!(delimiters, '')
+ value.gsub!(delimiters, "")
- value.gsub!(separator, '.')
+ value.gsub!(separator, ".")
end
value
@@ -66,10 +66,10 @@ def parse_number_string_to_number(value)
# Output currency value without unit
def unitless_currency_number(value)
- number_to_currency(value, format: '%n')
+ number_to_currency(value, format: "%n")
end
def to_currency_with_empty(rate)
- rate.nil? ? '0.0' : number_to_currency(rate.rate)
+ rate.nil? ? "0.0" : number_to_currency(rate.rate)
end
end
diff --git a/modules/costs/app/models/activities/time_entry_activity_provider.rb b/modules/costs/app/models/activities/time_entry_activity_provider.rb
index 8a0eb999c288..b2d4dac9442a 100644
--- a/modules/costs/app/models/activities/time_entry_activity_provider.rb
+++ b/modules/costs/app/models/activities/time_entry_activity_provider.rb
@@ -27,7 +27,7 @@
#++
class Activities::TimeEntryActivityProvider < Activities::BaseActivityProvider
- activity_provider_for type: 'time_entries',
+ activity_provider_for type: "time_entries",
permission: :view_time_entries
def extend_event_query(query)
@@ -37,34 +37,34 @@ def extend_event_query(query)
def event_query_projection
[
- activity_journal_projection_statement(:hours, 'time_entry_hours'),
- activity_journal_projection_statement(:comments, 'time_entry_comments'),
- activity_journal_projection_statement(:project_id, 'project_id'),
- activity_journal_projection_statement(:work_package_id, 'work_package_id'),
- projection_statement(projects_table, :name, 'project_name'),
- projection_statement(work_packages_table, :subject, 'work_package_subject'),
- projection_statement(types_table, :name, 'type_name')
+ activity_journal_projection_statement(:hours, "time_entry_hours"),
+ activity_journal_projection_statement(:comments, "time_entry_comments"),
+ activity_journal_projection_statement(:project_id, "project_id"),
+ activity_journal_projection_statement(:work_package_id, "work_package_id"),
+ projection_statement(projects_table, :name, "project_name"),
+ projection_statement(work_packages_table, :subject, "work_package_subject"),
+ projection_statement(types_table, :name, "type_name")
]
end
protected
def event_title(event)
- time_entry_object_name = event['work_package_id'].blank? ? event['project_name'] : work_package_title(event)
+ time_entry_object_name = event["work_package_id"].blank? ? event["project_name"] : work_package_title(event)
end
def event_type(_event)
- 'time-entry'
+ "time-entry"
end
def work_package_title(event)
- Activities::WorkPackageActivityProvider.work_package_title(event['work_package_id'],
- event['work_package_subject'],
- event['type_name'])
+ Activities::WorkPackageActivityProvider.work_package_title(event["work_package_id"],
+ event["work_package_subject"],
+ event["type_name"])
end
def event_description(event)
- event['time_entry_description']
+ event["time_entry_description"]
end
def event_path(event)
@@ -84,20 +84,20 @@ def work_packages_table
end
def event_location(event, only_path: true)
- filter_params = if event['work_package_id'].present?
- work_package_id_filter(event['work_package_id'])
+ filter_params = if event["work_package_id"].present?
+ work_package_id_filter(event["work_package_id"])
else
- project_id_filter(event['project_id'])
+ project_id_filter(event["project_id"])
end
- url_helpers.cost_reports_url(event['project_id'], only_path:, **filter_params)
+ url_helpers.cost_reports_url(event["project_id"], only_path:, **filter_params)
end
def project_id_filter(project_id)
- { 'fields[]': 'ProjectId', 'operators[ProjectId]': '=', 'values[ProjectId]': project_id, set_filter: 1 }
+ { "fields[]": "ProjectId", "operators[ProjectId]": "=", "values[ProjectId]": project_id, set_filter: 1 }
end
def work_package_id_filter(work_package_id)
- { 'fields[]': 'WorkPackageId', 'operators[WorkPackageId]': '=', 'values[WorkPackageId]': work_package_id, set_filter: 1 }
+ { "fields[]": "WorkPackageId", "operators[WorkPackageId]": "=", "values[WorkPackageId]": work_package_id, set_filter: 1 }
end
end
diff --git a/modules/costs/app/models/cost_entry.rb b/modules/costs/app/models/cost_entry.rb
index 6ac25f3467c6..971a01c78715 100644
--- a/modules/costs/app/models/cost_entry.rb
+++ b/modules/costs/app/models/cost_entry.rb
@@ -30,11 +30,11 @@ class CostEntry < ApplicationRecord
belongs_to :project
belongs_to :work_package
belongs_to :user
- belongs_to :logged_by, class_name: 'User'
+ belongs_to :logged_by, class_name: "User"
include ::Costs::DeletedUserFallback
belongs_to :cost_type
belongs_to :budget
- belongs_to :rate, class_name: 'CostRate'
+ belongs_to :rate, class_name: "CostRate"
include ActiveModel::ForbiddenAttributesProtection
diff --git a/modules/costs/app/models/cost_rate.rb b/modules/costs/app/models/cost_rate.rb
index 82eb60fdf40d..ba0e7ddab049 100644
--- a/modules/costs/app/models/cost_rate.rb
+++ b/modules/costs/app/models/cost_rate.rb
@@ -39,8 +39,8 @@ def previous(reference_date = valid_from)
def next(reference_date = valid_from)
CostRate
- .where(['cost_type_id = ? and valid_from > ?', cost_type_id, reference_date])
- .order(Arel.sql('valid_from ASC'))
+ .where(["cost_type_id = ? and valid_from > ?", cost_type_id, reference_date])
+ .order(Arel.sql("valid_from ASC"))
.first
end
diff --git a/modules/costs/app/models/cost_type.rb b/modules/costs/app/models/cost_type.rb
index a7081bd6ca72..16d9de970523 100644
--- a/modules/costs/app/models/cost_type.rb
+++ b/modules/costs/app/models/cost_type.rb
@@ -29,7 +29,7 @@
class CostType < ApplicationRecord
has_many :material_budget_items
has_many :cost_entries, dependent: :destroy
- has_many :rates, class_name: 'CostRate', dependent: :destroy
+ has_many :rates, class_name: "CostRate", dependent: :destroy
validates_presence_of :name, :unit, :unit_plural
validates_uniqueness_of :name
@@ -58,8 +58,8 @@ def current_rate
end
def rate_at(date)
- CostRate.where(['cost_type_id = ? and valid_from <= ?', id, date])
- .order(Arel.sql('valid_from DESC'))
+ CostRate.where(["cost_type_id = ? and valid_from <= ?", id, date])
+ .order(Arel.sql("valid_from DESC"))
.first
end
diff --git a/modules/costs/app/models/default_hourly_rate.rb b/modules/costs/app/models/default_hourly_rate.rb
index aa854df9b22a..478acdd64ba5 100644
--- a/modules/costs/app/models/default_hourly_rate.rb
+++ b/modules/costs/app/models/default_hourly_rate.rb
@@ -34,8 +34,8 @@ class DefaultHourlyRate < Rate
def next(reference_date = valid_from)
DefaultHourlyRate
- .where(['user_id = ? and valid_from > ?', user_id, reference_date])
- .order(Arel.sql('valid_from ASC'))
+ .where(["user_id = ? and valid_from > ?", user_id, reference_date])
+ .order(Arel.sql("valid_from ASC"))
.first
end
@@ -46,7 +46,7 @@ def previous(reference_date = valid_from)
def self.at_for_user(date, user_id)
user_id = user_id.id if user_id.is_a?(User)
- where(['user_id = ? and valid_from <= ?', user_id, date]).order(Arel.sql('valid_from DESC')).first
+ where(["user_id = ? and valid_from <= ?", user_id, date]).order(Arel.sql("valid_from DESC")).first
end
private
@@ -126,13 +126,13 @@ def orphaned_child_entries(date1, date2 = nil)
conditions = if date1.nil? || date2.nil?
# we have only one date, query >=
[
- 'user_id = ? AND (rate_id IN (?) OR rate_id IS NULL) AND spent_on >= ?',
+ "user_id = ? AND (rate_id IN (?) OR rate_id IS NULL) AND spent_on >= ?",
@rate.user_id, default_rates, date1 || date2
]
else
# we have two dates, query between
[
- 'user_id = ? AND (rate_id IN (?) OR rate_id IS NULL) AND spent_on BETWEEN ? AND ?',
+ "user_id = ? AND (rate_id IN (?) OR rate_id IS NULL) AND spent_on BETWEEN ? AND ?",
@rate.user_id, default_rates, date1, date2 - 1
]
end
diff --git a/modules/costs/app/models/hourly_rate.rb b/modules/costs/app/models/hourly_rate.rb
index 974dc05895d5..6cf3fc9e58de 100644
--- a/modules/costs/app/models/hourly_rate.rb
+++ b/modules/costs/app/models/hourly_rate.rb
@@ -38,9 +38,9 @@ def previous(reference_date = valid_from)
def next(reference_date = valid_from)
HourlyRate
- .where(['user_id = ? and project_id = ? and valid_from > ?',
+ .where(["user_id = ? and project_id = ? and valid_from > ?",
user_id, project_id, reference_date])
- .order(Arel.sql('valid_from ASC'))
+ .order(Arel.sql("valid_from ASC"))
.first
end
@@ -77,17 +77,17 @@ def self.at_date_for_user_in_project(date, user_id, project = nil, include_defau
user_id = user_id.id if user_id.is_a?(User)
unless project.nil?
- rate = where(['user_id = ? and project_id = ? and valid_from <= ?', user_id, project, date])
- .order(Arel.sql('valid_from DESC'))
+ rate = where(["user_id = ? and project_id = ? and valid_from <= ?", user_id, project, date])
+ .order(Arel.sql("valid_from DESC"))
.first
if rate.nil?
project = Project.find(project) unless project.is_a?(Project)
- rate = where(['user_id = ? and project_id in (?) and valid_from <= ?',
+ rate = where(["user_id = ? and project_id in (?) and valid_from <= ?",
user_id,
project.ancestors.to_a,
date])
.includes(:project)
- .order(Arel.sql('projects.lft DESC, valid_from DESC'))
+ .order(Arel.sql("projects.lft DESC, valid_from DESC"))
.first
end
end
diff --git a/modules/costs/app/models/journal/time_entry_journal.rb b/modules/costs/app/models/journal/time_entry_journal.rb
index 5f4b97ca0195..4f8e8e39516f 100644
--- a/modules/costs/app/models/journal/time_entry_journal.rb
+++ b/modules/costs/app/models/journal/time_entry_journal.rb
@@ -27,5 +27,5 @@
#++
class Journal::TimeEntryJournal < Journal::BaseJournal
- self.table_name = 'time_entry_journals'
+ self.table_name = "time_entry_journals"
end
diff --git a/modules/costs/app/models/rate.rb b/modules/costs/app/models/rate.rb
index 63bff76b475c..c5e72f05b041 100644
--- a/modules/costs/app/models/rate.rb
+++ b/modules/costs/app/models/rate.rb
@@ -189,13 +189,13 @@ def orphaned_child_entries(date1, date2 = nil)
conditions = if date1.nil? || date2.nil?
# we have only one date, query >=
[
- 'user_id = ? AND project_id IN (?) AND (rate_id IN (?) OR rate_id IS NULL) AND spent_on >= ?',
+ "user_id = ? AND project_id IN (?) AND (rate_id IN (?) OR rate_id IS NULL) AND spent_on >= ?",
@rate.user_id, @rate.project.descendants.to_a, default_rates, date1 || date2
]
else
# we have two dates, query between
[
- 'user_id = ? AND project_id IN (?) AND (rate_id IN (?) OR rate_id IS NULL) AND spent_on BETWEEN ? AND ?',
+ "user_id = ? AND project_id IN (?) AND (rate_id IN (?) OR rate_id IS NULL) AND spent_on BETWEEN ? AND ?",
@rate.user_id, @rate.project.descendants.to_a, default_rates, date1, date2
]
end
@@ -214,13 +214,13 @@ def child_entries(date1, date2 = nil)
conditions = if date1.nil? || date2.nil?
# we have only one date, query >=
[
- 'user_id = ? AND project_id IN (?) AND rate_id = ? AND spent_on >= ?',
+ "user_id = ? AND project_id IN (?) AND rate_id = ? AND spent_on >= ?",
@rate.user_id, @rate.project.descendants.to_a, @rate.id, date1 || date2
]
else
# we have two dates, query between
[
- 'user_id = ? AND project_id IN (?) AND rate_id = ? AND spent_on BETWEEN ? AND ?',
+ "user_id = ? AND project_id IN (?) AND rate_id = ? AND spent_on BETWEEN ? AND ?",
@rate.user_id, @rate.project.descendants.to_a, @rate.id, date1, date2
]
end
diff --git a/modules/costs/app/models/time_entry.rb b/modules/costs/app/models/time_entry.rb
index 5502092e6fee..fb1d3ba4e609 100644
--- a/modules/costs/app/models/time_entry.rb
+++ b/modules/costs/app/models/time_entry.rb
@@ -32,9 +32,9 @@ class TimeEntry < ApplicationRecord
belongs_to :project
belongs_to :work_package
belongs_to :user
- belongs_to :activity, class_name: 'TimeEntryActivity'
- belongs_to :rate, -> { where(type: %w[HourlyRate DefaultHourlyRate]) }, class_name: 'Rate'
- belongs_to :logged_by, class_name: 'User'
+ belongs_to :activity, class_name: "TimeEntryActivity"
+ belongs_to :rate, -> { where(type: %w[HourlyRate DefaultHourlyRate]) }, class_name: "Rate"
+ belongs_to :logged_by, class_name: "User"
acts_as_customizable
@@ -57,12 +57,12 @@ class TimeEntry < ApplicationRecord
# TODO: move into service
before_save :update_costs
- register_journal_formatted_fields(:time_entry_hours, 'hours')
- register_journal_formatted_fields(:time_entry_named_association, 'user_id')
- register_journal_formatted_fields(:named_association, 'work_package_id')
- register_journal_formatted_fields(:named_association, 'activity_id')
- register_journal_formatted_fields(:plaintext, 'comments')
- register_journal_formatted_fields(:plaintext, 'spent_on')
+ register_journal_formatted_fields(:time_entry_hours, "hours")
+ register_journal_formatted_fields(:time_entry_named_association, "user_id")
+ register_journal_formatted_fields(:named_association, "work_package_id")
+ register_journal_formatted_fields(:named_association, "activity_id")
+ register_journal_formatted_fields(:plaintext, "comments")
+ register_journal_formatted_fields(:plaintext, "spent_on")
def self.update_all(updates, conditions = nil, options = {})
# instead of a update_all, perform an individual update during work_package#move
diff --git a/modules/costs/app/models/time_entry_activities_project.rb b/modules/costs/app/models/time_entry_activities_project.rb
index 5fe1060cfa44..14b3a6df5f33 100644
--- a/modules/costs/app/models/time_entry_activities_project.rb
+++ b/modules/costs/app/models/time_entry_activities_project.rb
@@ -28,5 +28,5 @@
class TimeEntryActivitiesProject < ApplicationRecord
belongs_to :project
- belongs_to :activity, class_name: 'TimeEntryActivity'
+ belongs_to :activity, class_name: "TimeEntryActivity"
end
diff --git a/modules/costs/app/models/time_entry_activity.rb b/modules/costs/app/models/time_entry_activity.rb
index 76851b5d564b..77d999394d92 100644
--- a/modules/costs/app/models/time_entry_activity.rb
+++ b/modules/costs/app/models/time_entry_activity.rb
@@ -29,8 +29,8 @@
class TimeEntryActivity < Enumeration
include ::Scopes::Scoped
- has_many :time_entries, foreign_key: 'activity_id'
- has_many :time_entry_activities_projects, foreign_key: 'activity_id', dependent: :delete_all
+ has_many :time_entries, foreign_key: "activity_id"
+ has_many :time_entry_activities_projects, foreign_key: "activity_id", dependent: :delete_all
validates :parent, absence: true
diff --git a/modules/costs/app/models/work_package/abstract_costs.rb b/modules/costs/app/models/work_package/abstract_costs.rb
index 2aeec7cc7d89..7fb6fecf7919 100644
--- a/modules/costs/app/models/work_package/abstract_costs.rb
+++ b/modules/costs/app/models/work_package/abstract_costs.rb
@@ -124,7 +124,7 @@ def wp_table
def wp_table_descendants
# Relies on a table called descendants to exist in the scope
# which is provided by left_join_self_and_descendants
- wp_table.alias 'descendants'
+ wp_table.alias "descendants"
end
def ce_table
diff --git a/modules/costs/app/models/work_package/labor_costs.rb b/modules/costs/app/models/work_package/labor_costs.rb
index 0eeac91bdd87..fb639de5e161 100644
--- a/modules/costs/app/models/work_package/labor_costs.rb
+++ b/modules/costs/app/models/work_package/labor_costs.rb
@@ -9,11 +9,11 @@ def filter_authorized(scope)
end
def costs_sum_alias
- 'time_entries_sum'
+ "time_entries_sum"
end
def subselect_alias
- 'time_entries'
+ "time_entries"
end
def sum_subselect(base_scope)
diff --git a/modules/costs/app/models/work_package/material_costs.rb b/modules/costs/app/models/work_package/material_costs.rb
index fb1042dfe228..be4768981548 100644
--- a/modules/costs/app/models/work_package/material_costs.rb
+++ b/modules/costs/app/models/work_package/material_costs.rb
@@ -9,11 +9,11 @@ def filter_authorized(scope)
end
def costs_sum_alias
- 'cost_entries_sum'
+ "cost_entries_sum"
end
def subselect_alias
- 'cost_entries'
+ "cost_entries"
end
end
end
diff --git a/modules/costs/config/routes.rb b/modules/costs/config/routes.rb
index 56ccfe3e607e..9d08fbd15055 100644
--- a/modules/costs/config/routes.rb
+++ b/modules/costs/config/routes.rb
@@ -27,29 +27,29 @@
#++
Rails.application.routes.draw do
- scope 'projects/:project_id', as: 'projects' do
- resources :cost_entries, controller: 'costlog', only: %i[new create]
+ scope "projects/:project_id", as: "projects" do
+ resources :cost_entries, controller: "costlog", only: %i[new create]
resources :hourly_rates, only: %i[show edit update] do
post :set_rate, on: :member
end
end
- scope 'my' do
- get '/timer' => 'my/timer#show', as: 'my_timers'
+ scope "my" do
+ get "/timer" => "my/timer#show", as: "my_timers"
end
- scope 'projects/:project_id', as: 'project', module: 'projects' do
- namespace 'settings' do
+ scope "projects/:project_id", as: "project", module: "projects" do
+ namespace "settings" do
resource :time_entry_activities, only: %i[show update]
end
end
- scope 'work_packages/:work_package_id', as: 'work_packages' do
- resources :cost_entries, controller: 'costlog', only: %i[new]
+ scope "work_packages/:work_package_id", as: "work_packages" do
+ resources :cost_entries, controller: "costlog", only: %i[new]
end
- resources :cost_entries, controller: 'costlog', only: %i[edit update destroy]
+ resources :cost_entries, controller: "costlog", only: %i[edit update destroy]
resources :cost_types, only: %i[index new edit update create destroy] do
member do
diff --git a/modules/costs/costs.gemspec b/modules/costs/costs.gemspec
index 4b7ca373eb00..575f70c8b374 100644
--- a/modules/costs/costs.gemspec
+++ b/modules/costs/costs.gemspec
@@ -1,13 +1,13 @@
# Describe your gem and declare its dependencies:
Gem::Specification.new do |s|
- s.name = 'costs'
- s.version = '1.0.0'
- s.authors = 'OpenProject GmbH'
- s.email = 'info@openproject.com'
- s.summary = 'OpenProject Costs'
- s.description = 'This module adds features for planning and tracking costs of projects.'
- s.license = 'GPLv3'
+ s.name = "costs"
+ s.version = "1.0.0"
+ s.authors = "OpenProject GmbH"
+ s.email = "info@openproject.com"
+ s.summary = "OpenProject Costs"
+ s.description = "This module adds features for planning and tracking costs of projects."
+ s.license = "GPLv3"
- s.files = Dir['{app,config,db,lib,doc}/**/*', 'README.md']
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.files = Dir["{app,config,db,lib,doc}/**/*", "README.md"]
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/costs/db/migrate/20180323133404_to_v710_aggregated_costs_migrations.rb b/modules/costs/db/migrate/20180323133404_to_v710_aggregated_costs_migrations.rb
index 8202b775909d..cef387e17900 100644
--- a/modules/costs/db/migrate/20180323133404_to_v710_aggregated_costs_migrations.rb
+++ b/modules/costs/db/migrate/20180323133404_to_v710_aggregated_costs_migrations.rb
@@ -43,75 +43,75 @@ class ToV710AggregatedCostsMigrations < ActiveRecord::Migration[5.1]
def up
Migration::MigrationSquasher.squash(migrations) do
- create_table 'cost_entries', id: :integer do |t|
- t.integer 'user_id', null: false
- t.integer 'project_id', null: false
- t.integer 'work_package_id', null: false
- t.integer 'cost_type_id', null: false
- t.float 'units', null: false
- t.date 'spent_on', null: false
- t.datetime 'created_on', null: false
- t.datetime 'updated_on', null: false
- t.string 'comments', null: false
- t.boolean 'blocked', default: false, null: false
- t.decimal 'overridden_costs', precision: 15, scale: 4
- t.decimal 'costs', precision: 15, scale: 4
- t.integer 'rate_id'
- t.integer 'tyear', null: false
- t.integer 'tmonth', null: false
- t.integer 'tweek', null: false
+ create_table "cost_entries", id: :integer do |t|
+ t.integer "user_id", null: false
+ t.integer "project_id", null: false
+ t.integer "work_package_id", null: false
+ t.integer "cost_type_id", null: false
+ t.float "units", null: false
+ t.date "spent_on", null: false
+ t.datetime "created_on", null: false
+ t.datetime "updated_on", null: false
+ t.string "comments", null: false
+ t.boolean "blocked", default: false, null: false
+ t.decimal "overridden_costs", precision: 15, scale: 4
+ t.decimal "costs", precision: 15, scale: 4
+ t.integer "rate_id"
+ t.integer "tyear", null: false
+ t.integer "tmonth", null: false
+ t.integer "tweek", null: false
end
- create_table 'cost_objects', id: :integer do |t|
- t.integer 'project_id', null: false
- t.integer 'author_id', null: false
- t.string 'subject', null: false
- t.text 'description', null: false
- t.string 'type', null: false
- t.date 'fixed_date', null: false
- t.datetime 'created_on'
- t.datetime 'updated_on'
+ create_table "cost_objects", id: :integer do |t|
+ t.integer "project_id", null: false
+ t.integer "author_id", null: false
+ t.string "subject", null: false
+ t.text "description", null: false
+ t.string "type", null: false
+ t.date "fixed_date", null: false
+ t.datetime "created_on"
+ t.datetime "updated_on"
end
add_index :cost_objects, %i[project_id updated_on]
- create_table 'cost_types', id: :integer do |t|
- t.string 'name', null: false
- t.string 'unit', null: false
- t.string 'unit_plural', null: false
- t.boolean 'default', default: false, null: false
- t.datetime 'deleted_at'
+ create_table "cost_types", id: :integer do |t|
+ t.string "name", null: false
+ t.string "unit", null: false
+ t.string "unit_plural", null: false
+ t.boolean "default", default: false, null: false
+ t.datetime "deleted_at"
end
- create_table 'labor_budget_items', id: :integer do |t|
- t.integer 'cost_object_id', null: false
- t.float 'hours', null: false
- t.integer 'user_id'
- t.string 'comments', default: '', null: false
- t.decimal 'budget', precision: 15, scale: 4
+ create_table "labor_budget_items", id: :integer do |t|
+ t.integer "cost_object_id", null: false
+ t.float "hours", null: false
+ t.integer "user_id"
+ t.string "comments", default: "", null: false
+ t.decimal "budget", precision: 15, scale: 4
end
- create_table 'material_budget_items', id: :integer do |t|
- t.integer 'cost_object_id', null: false
- t.float 'units', null: false
- t.integer 'cost_type_id'
- t.string 'comments', default: '', null: false
- t.decimal 'budget', precision: 15, scale: 4
+ create_table "material_budget_items", id: :integer do |t|
+ t.integer "cost_object_id", null: false
+ t.float "units", null: false
+ t.integer "cost_type_id"
+ t.string "comments", default: "", null: false
+ t.decimal "budget", precision: 15, scale: 4
end
- create_table 'rates', id: :integer do |t|
- t.date 'valid_from', null: false
- t.decimal 'rate', precision: 15, scale: 4, null: false
- t.string 'type', null: false
- t.integer 'project_id'
- t.integer 'user_id'
- t.integer 'cost_type_id'
+ create_table "rates", id: :integer do |t|
+ t.date "valid_from", null: false
+ t.decimal "rate", precision: 15, scale: 4, null: false
+ t.string "type", null: false
+ t.integer "project_id"
+ t.integer "user_id"
+ t.integer "cost_type_id"
end
- change_table 'time_entries', id: :integer do |t|
- t.decimal 'overridden_costs', precision: 15, scale: 4
- t.decimal 'costs', precision: 15, scale: 4
- t.integer 'rate_id'
+ change_table "time_entries", id: :integer do |t|
+ t.decimal "overridden_costs", precision: 15, scale: 4
+ t.decimal "costs", precision: 15, scale: 4
+ t.integer "rate_id"
end
create_table :cost_object_journals, id: :integer do |t|
@@ -136,18 +136,18 @@ def up
end
def down
- drop_table 'cost_entries'
- drop_table 'cost_objects'
- drop_table 'cost_types'
- drop_table 'labor_budget_items'
- drop_table 'material_budget_items'
- drop_table 'rates'
- drop_table 'cost_object_journals'
-
- change_table 'time_entries' do |t|
- t.remove_column 'overridden_costs'
- t.remove_column 'costs'
- t.remove_column 'rate_id'
+ drop_table "cost_entries"
+ drop_table "cost_objects"
+ drop_table "cost_types"
+ drop_table "labor_budget_items"
+ drop_table "material_budget_items"
+ drop_table "rates"
+ drop_table "cost_object_journals"
+
+ change_table "time_entries" do |t|
+ t.remove_column "overridden_costs"
+ t.remove_column "costs"
+ t.remove_column "rate_id"
end
remove_column :work_packages, :cost_object_id
@@ -162,7 +162,7 @@ def down
def migrations
MIGRATION_FILES.split.map do |m|
- m.gsub(/_.*\z/, '')
+ m.gsub(/_.*\z/, "")
end
end
end
diff --git a/modules/costs/db/migrate/20200327074416_rename_fixed_version_in_cost_query.rb b/modules/costs/db/migrate/20200327074416_rename_fixed_version_in_cost_query.rb
index 7951ed074c0f..ac85b07e689c 100644
--- a/modules/costs/db/migrate/20200327074416_rename_fixed_version_in_cost_query.rb
+++ b/modules/costs/db/migrate/20200327074416_rename_fixed_version_in_cost_query.rb
@@ -28,11 +28,11 @@
class RenameFixedVersionInCostQuery < ActiveRecord::Migration[6.0]
def up
- rename_query_attributes('FixedVersion', 'Version')
+ rename_query_attributes("FixedVersion", "Version")
end
def down
- rename_query_attributes('Version', 'FixedVersion')
+ rename_query_attributes("Version", "FixedVersion")
end
def rename_query_attributes(from, to)
diff --git a/modules/costs/db/migrate/20200807083952_rename_time_and_cost_module.rb b/modules/costs/db/migrate/20200807083952_rename_time_and_cost_module.rb
index d5dbfea4dbec..e4f9a6e9a555 100644
--- a/modules/costs/db/migrate/20200807083952_rename_time_and_cost_module.rb
+++ b/modules/costs/db/migrate/20200807083952_rename_time_and_cost_module.rb
@@ -26,26 +26,26 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require Rails.root.to_s + '/db/migrate/migration_utils/module_renamer'
-require Rails.root.to_s + '/db/migrate/migration_utils/setting_renamer'
+require Rails.root.to_s + "/db/migrate/migration_utils/module_renamer"
+require Rails.root.to_s + "/db/migrate/migration_utils/setting_renamer"
class RenameTimeAndCostModule < ActiveRecord::Migration[6.0]
def up
- module_renamer.add_to_enabled('costs', %w[time_tracking costs_module reporting_module])
+ module_renamer.add_to_enabled("costs", %w[time_tracking costs_module reporting_module])
module_renamer.remove_from_enabled(%w[time_tracking costs_module reporting_module])
- module_renamer.add_to_default('costs', %w[time_tracking costs_module reporting_module])
- setting_renamer.rename('plugin_costs', 'plugin_costs')
+ module_renamer.add_to_default("costs", %w[time_tracking costs_module reporting_module])
+ setting_renamer.rename("plugin_costs", "plugin_costs")
end
def down
# We do not know if all three where actually enabled but having them enabled will keep the functionality
- module_renamer.add_to_enabled('time_tracking', 'costs')
- module_renamer.add_to_enabled('costs_module', 'costs')
- module_renamer.add_to_enabled('reporting_module', 'costs')
+ module_renamer.add_to_enabled("time_tracking", "costs")
+ module_renamer.add_to_enabled("costs_module", "costs")
+ module_renamer.add_to_enabled("reporting_module", "costs")
- module_renamer.remove_from_enabled('costs')
- module_renamer.add_to_default(%w[costs_module time_tracking reporting_module], 'costs')
- setting_renamer.rename('plugin_costs', 'plugin_costs')
+ module_renamer.remove_from_enabled("costs")
+ module_renamer.add_to_default(%w[costs_module time_tracking reporting_module], "costs")
+ setting_renamer.rename("plugin_costs", "plugin_costs")
end
def module_renamer
diff --git a/modules/costs/db/migrate/20210726065912_rename_cost_object_type.rb b/modules/costs/db/migrate/20210726065912_rename_cost_object_type.rb
index 9942367ff0a8..e2b050aac8d7 100644
--- a/modules/costs/db/migrate/20210726065912_rename_cost_object_type.rb
+++ b/modules/costs/db/migrate/20210726065912_rename_cost_object_type.rb
@@ -54,8 +54,8 @@ def up
add_index :journals, %i[journable_type journable_id version], unique: true
Journal
- .where(journable_type: 'CostObject')
- .update_all(journable_type: 'Budget')
+ .where(journable_type: "CostObject")
+ .update_all(journable_type: "Budget")
end
def down
diff --git a/modules/costs/db/migrate/20230622074222_add_ongoing_to_time_entry.rb b/modules/costs/db/migrate/20230622074222_add_ongoing_to_time_entry.rb
index e10bb63438a9..58f0515fe525 100644
--- a/modules/costs/db/migrate/20230622074222_add_ongoing_to_time_entry.rb
+++ b/modules/costs/db/migrate/20230622074222_add_ongoing_to_time_entry.rb
@@ -4,7 +4,7 @@ def change
t.boolean :ongoing, null: false, default: false, index: true
end
- add_index :time_entries, %i[user_id ongoing], unique: true, where: 'ongoing = true'
+ add_index :time_entries, %i[user_id ongoing], unique: true, where: "ongoing = true"
change_column_null :time_entries, :activity_id, true
change_column_null :time_entries, :hours, true
diff --git a/modules/costs/lib/api/v3/cost_entries/aggregated_cost_entry_representer.rb b/modules/costs/lib/api/v3/cost_entries/aggregated_cost_entry_representer.rb
index ccba7dcb4ad3..17aab34ab110 100644
--- a/modules/costs/lib/api/v3/cost_entries/aggregated_cost_entry_representer.rb
+++ b/modules/costs/lib/api/v3/cost_entries/aggregated_cost_entry_representer.rb
@@ -70,7 +70,7 @@ def initialize(cost_type, units)
end
def _type
- 'AggregatedCostEntry'
+ "AggregatedCostEntry"
end
def model_required?
diff --git a/modules/costs/lib/api/v3/cost_entries/cost_entries_api.rb b/modules/costs/lib/api/v3/cost_entries/cost_entries_api.rb
index 60a1b7947032..45a270518de2 100644
--- a/modules/costs/lib/api/v3/cost_entries/cost_entries_api.rb
+++ b/modules/costs/lib/api/v3/cost_entries/cost_entries_api.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'api/v3/cost_types/cost_type_representer'
+require "api/v3/cost_types/cost_type_representer"
module API
module V3
module CostEntries
class CostEntriesAPI < ::API::OpenProjectAPI
resources :cost_entries do
- route_param :id, type: Integer, desc: 'Cost entry ID' do
+ route_param :id, type: Integer, desc: "Cost entry ID" do
after_validation do
@cost_entry = CostEntry.find(params[:id])
diff --git a/modules/costs/lib/api/v3/cost_entries/cost_entries_by_work_package_api.rb b/modules/costs/lib/api/v3/cost_entries/cost_entries_by_work_package_api.rb
index bebfd695734a..2bec6bbe4721 100644
--- a/modules/costs/lib/api/v3/cost_entries/cost_entries_by_work_package_api.rb
+++ b/modules/costs/lib/api/v3/cost_entries/cost_entries_by_work_package_api.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'api/v3/cost_types/cost_type_representer'
+require "api/v3/cost_types/cost_type_representer"
module API
module V3
diff --git a/modules/costs/lib/api/v3/cost_entries/cost_entry_representer.rb b/modules/costs/lib/api/v3/cost_entries/cost_entry_representer.rb
index 0780180f09b1..31c496884894 100644
--- a/modules/costs/lib/api/v3/cost_entries/cost_entry_representer.rb
+++ b/modules/costs/lib/api/v3/cost_entries/cost_entry_representer.rb
@@ -52,7 +52,7 @@ class CostEntryRepresenter < ::API::Decorators::Single
date_time_property :updated_at
def _type
- 'CostEntry'
+ "CostEntry"
end
end
end
diff --git a/modules/costs/lib/api/v3/cost_entries/work_package_costs_by_type_representer.rb b/modules/costs/lib/api/v3/cost_entries/work_package_costs_by_type_representer.rb
index 0acdbaba79e7..a2a33877faca 100644
--- a/modules/costs/lib/api/v3/cost_entries/work_package_costs_by_type_representer.rb
+++ b/modules/costs/lib/api/v3/cost_entries/work_package_costs_by_type_representer.rb
@@ -60,7 +60,7 @@ def cost_helper
end
def _type
- 'Collection'
+ "Collection"
end
end
end
diff --git a/modules/costs/lib/api/v3/cost_types/cost_type_representer.rb b/modules/costs/lib/api/v3/cost_types/cost_type_representer.rb
index 7e55321621a2..872fb1fcb400 100644
--- a/modules/costs/lib/api/v3/cost_types/cost_type_representer.rb
+++ b/modules/costs/lib/api/v3/cost_types/cost_type_representer.rb
@@ -41,7 +41,7 @@ class CostTypeRepresenter < ::API::Decorators::Single
getter: ->(*) { default }
def _type
- 'CostType'
+ "CostType"
end
end
end
diff --git a/modules/costs/lib/api/v3/cost_types/cost_types_api.rb b/modules/costs/lib/api/v3/cost_types/cost_types_api.rb
index 52f66ea1193a..ba35ef93294f 100644
--- a/modules/costs/lib/api/v3/cost_types/cost_types_api.rb
+++ b/modules/costs/lib/api/v3/cost_types/cost_types_api.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'api/v3/cost_types/cost_type_representer'
+require "api/v3/cost_types/cost_type_representer"
module API
module V3
@@ -37,7 +37,7 @@ class CostTypesAPI < ::API::OpenProjectAPI
authorize_in_any_project(%i[view_cost_entries view_own_cost_entries])
end
- route_param :id, type: Integer, desc: 'Cost type ID' do
+ route_param :id, type: Integer, desc: "Cost type ID" do
after_validation do
@cost_type = CostType.active.find(params[:id])
end
diff --git a/modules/costs/lib/api/v3/time_entries/schemas/time_entry_schema_representer.rb b/modules/costs/lib/api/v3/time_entries/schemas/time_entry_schema_representer.rb
index c81a30aefc92..b07119fb7ca8 100644
--- a/modules/costs/lib/api/v3/time_entries/schemas/time_entry_schema_representer.rb
+++ b/modules/costs/lib/api/v3/time_entries/schemas/time_entry_schema_representer.rb
@@ -39,26 +39,26 @@ def self.represented_class
end
schema :id,
- type: 'Integer'
+ type: "Integer"
schema :created_at,
- type: 'DateTime'
+ type: "DateTime"
schema :updated_at,
- type: 'DateTime'
+ type: "DateTime"
schema :spent_on,
- type: 'Date'
+ type: "Date"
schema :hours,
- type: 'Duration'
+ type: "Duration"
schema :comment,
- type: 'Formattable',
+ type: "Formattable",
required: false
schema :ongoing,
- type: 'Boolean',
+ type: "Boolean",
required: false
schema_with_allowed_link :user,
@@ -83,7 +83,7 @@ def self.represented_class
}
schema_with_allowed_collection :activity,
- type: 'TimeEntriesActivity',
+ type: "TimeEntriesActivity",
value_representer: TimeEntriesActivityRepresenter,
has_default: true,
required: false,
@@ -109,9 +109,9 @@ def allowed_projects_href
def allowed_user_href
api_v3_paths.path_for :principals,
filters: [
- { status: { operator: '!', values: [Principal.statuses[:locked].to_s] } },
- { type: { operator: '=', values: ['User'] } },
- { member: { operator: '=', values: [represented.project_id] } }
+ { status: { operator: "!", values: [Principal.statuses[:locked].to_s] } },
+ { type: { operator: "=", values: ["User"] } },
+ { member: { operator: "=", values: [represented.project_id] } }
]
end
end
diff --git a/modules/costs/lib/api/v3/time_entries/time_entries_activity_api.rb b/modules/costs/lib/api/v3/time_entries/time_entries_activity_api.rb
index bd50eab1b458..93874fcca13b 100644
--- a/modules/costs/lib/api/v3/time_entries/time_entries_activity_api.rb
+++ b/modules/costs/lib/api/v3/time_entries/time_entries_activity_api.rb
@@ -31,7 +31,7 @@ module V3
module TimeEntries
class TimeEntriesActivityAPI < ::API::OpenProjectAPI
resources :activities do
- route_param :id, type: Integer, desc: 'Time entry activity ID' do
+ route_param :id, type: Integer, desc: "Time entry activity ID" do
after_validation do
authorize_in_any_work_package(:edit_own_time_entries) do
authorize_in_any_project(%i(log_time
diff --git a/modules/costs/lib/api/v3/time_entries/time_entries_activity_representer.rb b/modules/costs/lib/api/v3/time_entries/time_entries_activity_representer.rb
index 39ec03c97d2a..9a90c9aaf474 100644
--- a/modules/costs/lib/api/v3/time_entries/time_entries_activity_representer.rb
+++ b/modules/costs/lib/api/v3/time_entries/time_entries_activity_representer.rb
@@ -59,7 +59,7 @@ class TimeEntriesActivityRepresenter < ::API::Decorators::Single
}
def _type
- 'TimeEntriesActivity'
+ "TimeEntriesActivity"
end
def active_projects
diff --git a/modules/costs/lib/api/v3/time_entries/time_entries_api.rb b/modules/costs/lib/api/v3/time_entries/time_entries_api.rb
index 78ac7ade8588..052dd537aefa 100644
--- a/modules/costs/lib/api/v3/time_entries/time_entries_api.rb
+++ b/modules/costs/lib/api/v3/time_entries/time_entries_api.rb
@@ -43,7 +43,7 @@ class TimeEntriesAPI < ::API::OpenProjectAPI
mount ::API::V3::TimeEntries::AvailableProjectsAPI
mount ::API::V3::TimeEntries::AvailableWorkPackagesOnCreateAPI
- route_param :id, type: Integer, desc: 'Time entry ID' do
+ route_param :id, type: Integer, desc: "Time entry ID" do
after_validation do
@time_entry = TimeEntry
.visible
diff --git a/modules/costs/lib/api/v3/time_entries/time_entry_representer.rb b/modules/costs/lib/api/v3/time_entries/time_entry_representer.rb
index 6dbf73a083fb..d9905964ead6 100644
--- a/modules/costs/lib/api/v3/time_entries/time_entry_representer.rb
+++ b/modules/costs/lib/api/v3/time_entries/time_entry_representer.rb
@@ -106,14 +106,14 @@ class TimeEntryRepresenter < ::API::Decorators::Single
.new(represented,
path: :time_entries_activity,
property_name: :time_entries_activity,
- namespace: 'time_entries/activities',
+ namespace: "time_entries/activities",
getter: :activity_id,
- setter: :'activity_id=')
+ setter: :"activity_id=")
.from_hash(fragment)
}
def _type
- 'TimeEntry'
+ "TimeEntry"
end
def update_allowed?
@@ -125,7 +125,7 @@ def update_allowed?
def hours=(value)
represented.hours = datetime_formatter.parse_duration_to_hours(value,
- 'hours',
+ "hours",
allow_nil: true)
end
diff --git a/modules/costs/lib/costs.rb b/modules/costs/lib/costs.rb
index f9d947f3ee4c..cc281d9a4122 100644
--- a/modules/costs/lib/costs.rb
+++ b/modules/costs/lib/costs.rb
@@ -26,4 +26,4 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'costs/engine'
+require "costs/engine"
diff --git a/modules/costs/lib/costs/engine.rb b/modules/costs/lib/costs/engine.rb
index a2aa49a45b7f..ef47fec7638d 100644
--- a/modules/costs/lib/costs/engine.rb
+++ b/modules/costs/lib/costs/engine.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'open_project/plugins'
+require "open_project/plugins"
module Costs
class Engine < ::Rails::Engine
@@ -34,12 +34,12 @@ class Engine < ::Rails::Engine
include OpenProject::Plugins::ActsAsOpEngine
- register 'costs',
- author_url: 'https://www.openproject.org',
+ register "costs",
+ author_url: "https://www.openproject.org",
bundled: true,
settings: {
- default: { 'costs_currency' => 'EUR', 'costs_currency_format' => '%n %u' },
- partial: 'settings/costs',
+ default: { "costs_currency" => "EUR", "costs_currency_format" => "%n %u" },
+ partial: "settings/costs",
menu_item: :costs_setting
} do
project_module :costs do
@@ -73,7 +73,7 @@ class Engine < ::Rails::Engine
require: :member
permission :manage_project_activities,
- { 'projects/settings/time_entry_activities': %i[show update] },
+ { "projects/settings/time_entry_activities": %i[show update] },
permissible_on: :project,
require: :member
@@ -122,21 +122,21 @@ class Engine < ::Rails::Engine
# Menu extensions
menu :admin_menu,
:cost_types,
- { controller: '/cost_types', action: 'index' },
+ { controller: "/cost_types", action: "index" },
if: ->(*) { User.current.admin? },
parent: :admin_costs,
caption: :label_cost_type_plural
end
- activity_provider :time_entries, class_name: 'Activities::TimeEntryActivityProvider', default: false
+ activity_provider :time_entries, class_name: "Activities::TimeEntryActivityProvider", default: false
patches %i[Project User PermittedParams]
patch_with_namespace :BasicData, :SettingSeeder
patch_with_namespace :ActiveSupport, :NumberHelper, :NumberToCurrencyConverter
add_tab_entry :user,
- name: 'rates',
- partial: 'users/rates',
+ name: "rates",
+ partial: "users/rates",
path: ->(params) { edit_user_path(params[:user], tab: :rates) },
only_if: ->(*) { User.current.admin? },
label: :caption_rate_history
@@ -157,13 +157,13 @@ class Engine < ::Rails::Engine
"#{root}/cost_types/#{id}"
end
- add_api_endpoint 'API::V3::Root' do
+ add_api_endpoint "API::V3::Root" do
mount ::API::V3::CostEntries::CostEntriesAPI
mount ::API::V3::CostTypes::CostTypesAPI
mount ::API::V3::TimeEntries::TimeEntriesAPI
end
- add_api_endpoint 'API::V3::WorkPackages::WorkPackagesAPI', :id do
+ add_api_endpoint "API::V3::WorkPackages::WorkPackagesAPI", :id do
mount ::API::V3::CostEntries::CostEntriesByWorkPackageAPI
end
@@ -181,7 +181,7 @@ class Engine < ::Rails::Engine
{
href: new_work_packages_cost_entry_path(represented),
- type: 'text/html',
+ type: "text/html",
title: "Log costs on #{represented.subject}"
}
end
@@ -195,11 +195,11 @@ class Engine < ::Rails::Engine
{
href: cost_reports_path(represented.project_id,
- 'fields[]': 'WorkPackageId',
- 'operators[WorkPackageId]': '=',
- 'values[WorkPackageId]': represented.id,
+ "fields[]": "WorkPackageId",
+ "operators[WorkPackageId]": "=",
+ "values[WorkPackageId]": represented.id,
set_filter: 1),
- type: 'text/html',
+ type: "text/html",
title: "Show cost entries"
}
end
@@ -256,25 +256,25 @@ class Engine < ::Rails::Engine
# N.B. in the long term we should have a type like "Currency", but that requires a proper
# format and not a string like "10 EUR"
schema :overall_costs,
- type: 'String',
+ type: "String",
required: false,
writable: false,
show_if: ->(*) { represented.project && represented.project.costs_enabled? }
schema :labor_costs,
- type: 'String',
+ type: "String",
required: false,
writable: false,
show_if: ->(*) { represented.project && represented.project.costs_enabled? }
schema :material_costs,
- type: 'String',
+ type: "String",
required: false,
writable: false,
show_if: ->(*) { represented.project && represented.project.costs_enabled? }
schema :costs_by_type,
- type: 'Collection',
+ type: "Collection",
name_source: :spent_units,
required: false,
show_if: ->(*) { represented.project && represented.project.costs_enabled? },
@@ -282,7 +282,7 @@ class Engine < ::Rails::Engine
end
config.to_prepare do
- OpenProject::ProjectLatestActivity.register on: 'TimeEntry'
+ OpenProject::ProjectLatestActivity.register on: "TimeEntry"
Costs::Patches::MembersPatch.mixin!
diff --git a/modules/costs/lib/costs/patches/members_patch.rb b/modules/costs/lib/costs/patches/members_patch.rb
index 9bc1aca8a33e..4eaef561ed03 100644
--- a/modules/costs/lib/costs/patches/members_patch.rb
+++ b/modules/costs/lib/costs/patches/members_patch.rb
@@ -45,7 +45,7 @@ def members_table_options(_roles)
module TableComponent
def sort_collection(query, sort_clause, sort_columns)
- q = super(query, sort_clause.gsub("current_rate", 'COALESCE(rate, 0.0)'), sort_columns)
+ q = super(query, sort_clause.gsub("current_rate", "COALESCE(rate, 0.0)"), sort_columns)
if sort_columns.include? :current_rate
join_rate q
diff --git a/modules/costs/lib/costs/patches/number_to_currency_converter_patch.rb b/modules/costs/lib/costs/patches/number_to_currency_converter_patch.rb
index 320d253298b9..152e28c9072b 100644
--- a/modules/costs/lib/costs/patches/number_to_currency_converter_patch.rb
+++ b/modules/costs/lib/costs/patches/number_to_currency_converter_patch.rb
@@ -33,8 +33,8 @@ def self.included(base) # :nodoc:
module InstanceMethods
def i18n_opts
- super.merge(unit: ERB::Util.h(Setting.plugin_costs['costs_currency']),
- format: ERB::Util.h(Setting.plugin_costs['costs_currency_format']))
+ super.merge(unit: ERB::Util.h(Setting.plugin_costs["costs_currency"]),
+ format: ERB::Util.h(Setting.plugin_costs["costs_currency_format"]))
end
end
end
diff --git a/modules/costs/lib/costs/patches/project_patch.rb b/modules/costs/lib/costs/patches/project_patch.rb
index 971d7472b5f6..ae29606f9b6f 100644
--- a/modules/costs/lib/costs/patches/project_patch.rb
+++ b/modules/costs/lib/costs/patches/project_patch.rb
@@ -32,12 +32,12 @@ def self.included(base) # :nodoc:
base.include(InstanceMethods)
base.class_eval do
- has_many :rates, class_name: 'HourlyRate'
+ has_many :rates, class_name: "HourlyRate"
has_many :member_groups, -> {
includes(:principal)
.where("#{Principal.table_name}.type='Group'")
- }, class_name: 'Member'
+ }, class_name: "Member"
has_many :groups, through: :member_groups, source: :principal
end
end
diff --git a/modules/costs/lib/costs/patches/setting_seeder_patch.rb b/modules/costs/lib/costs/patches/setting_seeder_patch.rb
index bd0f29a5f59d..fe6935d4b470 100644
--- a/modules/costs/lib/costs/patches/setting_seeder_patch.rb
+++ b/modules/costs/lib/costs/patches/setting_seeder_patch.rb
@@ -35,8 +35,8 @@ module InstanceMethods
def data
original_data = super
- unless original_data['default_projects_modules'].include? 'costs'
- original_data['default_projects_modules'] << 'costs'
+ unless original_data["default_projects_modules"].include? "costs"
+ original_data["default_projects_modules"] << "costs"
end
original_data
diff --git a/modules/costs/lib/costs/patches/user_patch.rb b/modules/costs/lib/costs/patches/user_patch.rb
index 490ff6e270f0..75f53eff7778 100644
--- a/modules/costs/lib/costs/patches/user_patch.rb
+++ b/modules/costs/lib/costs/patches/user_patch.rb
@@ -31,8 +31,8 @@ def self.included(base) # :nodoc:
base.send(:include, InstanceMethods)
base.class_eval do
- has_many :rates, class_name: 'HourlyRate'
- has_many :default_rates, class_name: 'DefaultHourlyRate'
+ has_many :rates, class_name: "HourlyRate"
+ has_many :default_rates, class_name: "DefaultHourlyRate"
before_save :save_rates
end
@@ -45,7 +45,7 @@ def allowed_to_condition_with_project_id(permission, projects = nil)
ids = scope.pluck(:id)
- ids.empty? ? '1=0' : "(#{Project.table_name}.id in (#{ids.join(', ')}))"
+ ids.empty? ? "1=0" : "(#{Project.table_name}.id in (#{ids.join(', ')}))"
end
def current_rate(project = nil, include_default = true)
diff --git a/modules/costs/spec/contracts/time_entries/create_contract_spec.rb b/modules/costs/spec/contracts/time_entries/create_contract_spec.rb
index 3e9bf25bb55b..9048a5ab621d 100644
--- a/modules/costs/spec/contracts/time_entries/create_contract_spec.rb
+++ b/modules/costs/spec/contracts/time_entries/create_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe TimeEntries::CreateContract do
- it_behaves_like 'time entry contract' do
+ it_behaves_like "time entry contract" do
subject(:contract) do
described_class.new(time_entry, current_user)
end
@@ -59,41 +59,41 @@
end
end
- context 'if user is not allowed to log time' do
+ context "if user is not allowed to log time" do
let(:permissions) { [] }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, base: %i(error_unauthorized))
end
end
- context 'when ongoing and different user' do
+ context "when ongoing and different user" do
let(:time_entry_user) { other_user }
let(:time_entry_ongoing) { true }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, ongoing: %i(not_current_user))
end
end
- context 'if user has only permission to log own time' do
+ context "if user has only permission to log own time" do
let(:permissions) { %i[log_own_time] }
- it 'is valid' do
+ it "is valid" do
expect_valid(true)
end
- context 'when trying to log for other user' do
+ context "when trying to log for other user" do
let(:time_entry_user) { build_stubbed(:user) }
let(:changed_by_system) { {} }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, base: %i(error_unauthorized))
end
end
end
- context 'if time_entry user is not contract user' do
+ context "if time_entry user is not contract user" do
let(:other_user) { build_stubbed(:user) }
let(:permissions) { [] }
let(:time_entry_user) { other_user }
@@ -104,12 +104,12 @@
end
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, base: %i(error_unauthorized))
end
end
- context 'if time_entry user was not set by system' do
+ context "if time_entry user was not set by system" do
let(:other_user) { build_stubbed(:user) }
let(:time_entry_user) { other_user }
let(:permissions) { [] }
@@ -121,15 +121,15 @@
end
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, base: %i(error_unauthorized))
end
end
- context 'if the user is nil' do
+ context "if the user is nil" do
let(:time_entry_user) { nil }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, user_id: %i(blank))
end
end
diff --git a/modules/costs/spec/contracts/time_entries/delete_contract_spec.rb b/modules/costs/spec/contracts/time_entries/delete_contract_spec.rb
index a4d979ba1167..16db88b65545 100644
--- a/modules/costs/spec/contracts/time_entries/delete_contract_spec.rb
+++ b/modules/costs/spec/contracts/time_entries/delete_contract_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe TimeEntries::DeleteContract do
let(:current_user) { build_stubbed(:user) }
@@ -74,53 +74,53 @@ def expect_valid(valid, symbols = {})
end
end
- shared_examples 'is valid' do
- it 'is valid' do
+ shared_examples "is valid" do
+ it "is valid" do
expect_valid(true)
end
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
- context 'when user is not allowed to delete time entries' do
+ context "when user is not allowed to delete time entries" do
let(:permissions) { [] }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, base: %i(error_unauthorized))
end
end
- context 'when time entry ongoing and user as log_time permission' do
+ context "when time entry ongoing and user as log_time permission" do
let(:time_entry_ongoing) { true }
let(:permissions) { %i[log_own_time] }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'when time entry not ongoing and user as log_time permission' do
+ context "when time entry not ongoing and user as log_time permission" do
let(:time_entry_ongoing) { false }
let(:permissions) { %i[log_own_time] }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, base: %i(error_unauthorized))
end
end
- context 'when time_entry user is not contract user' do
+ context "when time_entry user is not contract user" do
let(:time_entry_user) { other_user }
- context 'when has permission' do
+ context "when has permission" do
let(:permissions) { %i[edit_time_entries] }
- it 'is valid' do
+ it "is valid" do
expect_valid(true)
end
end
- context 'when has no permission' do
+ context "when has no permission" do
let(:permissions) { %i[edit_own_time_entries] }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, base: %i(error_unauthorized))
end
end
diff --git a/modules/costs/spec/contracts/time_entries/shared_contract_examples.rb b/modules/costs/spec/contracts/time_entries/shared_contract_examples.rb
index b1ea2d681cc0..8e62c50072ce 100644
--- a/modules/costs/spec/contracts/time_entries/shared_contract_examples.rb
+++ b/modules/costs/spec/contracts/time_entries/shared_contract_examples.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.shared_examples_for 'time entry contract' do
+RSpec.shared_examples_for "time entry contract" do
let(:current_user) { build_stubbed(:user) }
before do
mock_permissions_for(current_user) do |mock|
@@ -107,139 +107,139 @@ def expect_valid(valid, symbols = {})
end
end
- shared_examples 'is valid' do
- it 'is valid' do
+ shared_examples "is valid" do
+ it "is valid" do
expect_valid(true)
end
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
- context 'when the work_package is within a different project than the provided project' do
+ context "when the work_package is within a different project than the provided project" do
let(:time_entry_work_package) { build_stubbed(:work_package) }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, work_package_id: %i(invalid))
end
end
- context 'when the work_package is nil' do
+ context "when the work_package is nil" do
let(:time_entry_work_package) { nil }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'when the project is nil' do
+ context "when the project is nil" do
let(:time_entry_project) { nil }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, project_id: %i(invalid blank))
end
end
- context 'when activity is nil' do
+ context "when activity is nil" do
let(:time_entry_activity) { nil }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if the activity is disabled in the project' do
+ context "if the activity is disabled in the project" do
let(:time_entry_activity_active) { false }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, activity_id: %i(inclusion))
end
end
- context 'when spent_on is nil' do
+ context "when spent_on is nil" do
let(:time_entry_spent_on) { nil }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, spent_on: %i(blank))
end
end
- context 'when spent_on is outside the year limits to prevent overflow in postgres' do
+ context "when spent_on is outside the year limits to prevent overflow in postgres" do
let(:time_entry_spent_on) { Date.new(10000) }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, spent_on: %i(date_before_or_equal_to))
end
end
- context 'when spent_on is in the future' do
+ context "when spent_on is in the future" do
let(:time_entry_spent_on) { Date.new(9999) }
- it 'is valid' do
+ it "is valid" do
expect_valid(true)
end
end
- context 'when spent_on is today' do
+ context "when spent_on is today" do
let(:time_entry_spent_on) { Time.zone.today }
- it 'is valid' do
+ it "is valid" do
expect_valid(true)
end
end
- context 'when spent_on is in the past' do
+ context "when spent_on is in the past" do
let(:time_entry_spent_on) { Time.zone.yesterday }
- it 'is valid' do
+ it "is valid" do
expect_valid(true)
end
end
- context 'when hours is nil' do
+ context "when hours is nil" do
let(:time_entry_hours) { nil }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, hours: %i(blank))
end
end
- context 'when hours is negative' do
+ context "when hours is negative" do
let(:time_entry_hours) { -1 }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, hours: %i(invalid))
end
end
- context 'when comment is nil' do
+ context "when comment is nil" do
let(:time_entry_comments) { nil }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if more than 24 hours are booked for a day' do
+ context "if more than 24 hours are booked for a day" do
let(:time_entry_day_sum) { 24 - time_entry_hours + 1 }
- it 'is valid' do
+ it "is valid" do
expect_valid(true)
end
end
- describe 'assignable_activities' do
- context 'if no project is set' do
+ describe "assignable_activities" do
+ context "if no project is set" do
let(:time_entry_project) { nil }
- it 'is empty' do
+ it "is empty" do
expect(contract.assignable_activities)
.to be_empty
end
end
- context 'if a project is set' do
- it 'returns all activities active in the project' do
+ context "if a project is set" do
+ it "returns all activities active in the project" do
expect(contract.assignable_activities)
.to eql activities_scope
end
end
end
- describe 'assignable_versions' do
+ describe "assignable_versions" do
let(:project_versions) { [instance_double(Version)] }
let(:wp_versions) { [instance_double(Version)] }
@@ -257,36 +257,36 @@ def expect_valid(valid, symbols = {})
end
end
- context 'if no project and no work package is set' do
+ context "if no project and no work package is set" do
let(:time_entry_project) { nil }
let(:time_entry_work_package) { nil }
- it 'is empty' do
+ it "is empty" do
expect(contract.assignable_versions)
.to be_empty
end
end
- context 'if a project is set but no work package' do
+ context "if a project is set but no work package" do
let(:time_entry_work_package) { nil }
- it 'returns assignable_versions of the project' do
+ it "returns assignable_versions of the project" do
expect(contract.assignable_versions)
.to eql project_versions
end
end
- context 'if a work_package is set but no project' do
+ context "if a work_package is set but no project" do
let(:time_entry_project) { nil }
- it 'returns assignable_versions of the project' do
+ it "returns assignable_versions of the project" do
expect(contract.assignable_versions)
.to eql wp_versions
end
end
- context 'if both project and work_package are set' do
- it 'returns assignable_versions of the project' do
+ context "if both project and work_package are set" do
+ it "returns assignable_versions of the project" do
expect(contract.assignable_versions)
.to eql wp_versions
end
diff --git a/modules/costs/spec/contracts/time_entries/update_contract_spec.rb b/modules/costs/spec/contracts/time_entries/update_contract_spec.rb
index bd25b934b069..8996b418c987 100644
--- a/modules/costs/spec/contracts/time_entries/update_contract_spec.rb
+++ b/modules/costs/spec/contracts/time_entries/update_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe TimeEntries::UpdateContract do
- it_behaves_like 'time entry contract' do
+ it_behaves_like "time entry contract" do
let(:time_entry) do
build_stubbed(:time_entry,
project: time_entry_project,
@@ -45,15 +45,15 @@
let(:permissions) { %i(edit_time_entries) }
- context 'if user is not allowed to edit time entries' do
+ context "if user is not allowed to edit time entries" do
let(:permissions) { [] }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, base: %i(error_unauthorized))
end
end
- context 'if project changed' do
+ context "if project changed" do
let(:new_project) do
build_stubbed(:project) do |new_project|
allow(TimeEntryActivity)
@@ -84,64 +84,64 @@
time_entry.project = new_project
end
- context 'if user is not allowed to edit time entries in old project but in new' do
+ context "if user is not allowed to edit time entries in old project but in new" do
let(:permissions) { [] }
let(:new_project_permissions) { %i(edit_time_entries) }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, base: %i(error_unauthorized))
end
end
- context 'if user is allowed to edit time entries in old project but not in new' do
+ context "if user is allowed to edit time entries in old project but not in new" do
let(:new_project_permissions) { [] }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, base: %i(error_unauthorized))
end
end
- context 'if user is allowed to edit time entries in both projects' do
+ context "if user is allowed to edit time entries in both projects" do
let(:new_project_permissions) { %i(edit_time_entries) }
- it 'is valid' do
+ it "is valid" do
expect_valid(true)
end
end
end
- context 'if the user is nil' do
+ context "if the user is nil" do
let(:time_entry_user) { nil }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, user_id: %i(blank))
end
end
- context 'if the user is changed' do
+ context "if the user is changed" do
let(:permissions) { %i(edit_own_time_entries) }
- it 'is invalid' do
+ it "is invalid" do
time_entry.user = other_user
expect_valid(false, base: %i(error_unauthorized))
end
end
- context 'if time_entry user is not contract user' do
+ context "if time_entry user is not contract user" do
let(:time_entry_user) { other_user }
- context 'if has permission' do
+ context "if has permission" do
let(:permissions) { %i[edit_time_entries] }
- it 'is valid' do
+ it "is valid" do
expect_valid(true)
end
end
- context 'if has no permission' do
+ context "if has no permission" do
let(:permissions) { %i[edit_own_time_entries] }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, base: %i(error_unauthorized))
end
end
diff --git a/modules/costs/spec/controllers/cost_types_controller_spec.rb b/modules/costs/spec/controllers/cost_types_controller_spec.rb
index 70e613e0883d..10e1de3f769d 100644
--- a/modules/costs/spec/controllers/cost_types_controller_spec.rb
+++ b/modules/costs/spec/controllers/cost_types_controller_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper.rb")
RSpec.describe CostTypesController do
let(:admin) { create(:admin) }
let(:cost_type) { create(:cost_type) }
- describe 'DELETE destroy' do
- it 'allows an admin to delete' do
+ describe "DELETE destroy" do
+ it "allows an admin to delete" do
as_logged_in_user admin do
delete :destroy, params: { id: cost_type.id }
end
@@ -44,12 +44,12 @@
end
end
- describe 'PATCH restore' do
+ describe "PATCH restore" do
before do
cost_type.deleted_at = DateTime.now
end
- it 'allows an admin to restore' do
+ it "allows an admin to restore" do
as_logged_in_user admin do
patch :restore, params: { id: cost_type.id }
end
diff --git a/modules/costs/spec/controllers/costlog_controller_spec.rb b/modules/costs/spec/controllers/costlog_controller_spec.rb
index c108e8a6d913..7f0782dae5d7 100644
--- a/modules/costs/spec/controllers/costlog_controller_spec.rb
+++ b/modules/costs/spec/controllers/costlog_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper.rb")
RSpec.describe CostlogController do
include Cost::PluginSpecHelper
@@ -47,7 +47,7 @@
overridden_costs: 400,
units: 100,
user:,
- comments: '')
+ comments: "")
end
let(:work_package_status) { create(:work_package_status, is_default: true) }
@@ -65,7 +65,7 @@ def disable_flash_sweep
allow(@controller.flash).to receive(:sweep)
end
- shared_examples_for 'assigns' do
+ shared_examples_for "assigns" do
it do
expect(assigns(:cost_entry).project).to eq(expected_project)
expect(assigns(:cost_entry).work_package).to eq(expected_work_package)
@@ -86,8 +86,8 @@ def disable_flash_sweep
User.current = nil
end
- describe 'GET new' do
- let(:params) { { 'work_package_id' => work_package.id.to_s } }
+ describe "GET new" do
+ let(:params) { { "work_package_id" => work_package.id.to_s } }
let(:expected_project) { project }
let(:expected_work_package) { work_package }
@@ -97,18 +97,18 @@ def disable_flash_sweep
let(:expected_overridden_costs) { nil }
let(:expected_units) { nil }
- shared_examples_for 'successful new' do
+ shared_examples_for "successful new" do
before do
get :new, params:
end
it { expect(response).to be_successful }
- it_behaves_like 'assigns'
- it { expect(response).to render_template('edit') }
+ it_behaves_like "assigns"
+ it { expect(response).to render_template("edit") }
end
- shared_examples_for 'forbidden new' do
+ shared_examples_for "forbidden new" do
before do
get :new, params:
end
@@ -116,12 +116,12 @@ def disable_flash_sweep
it { expect(response.response_code).to eq(403) }
end
- describe 'WHEN user allowed to create new cost_entry' do
+ describe "WHEN user allowed to create new cost_entry" do
before do
grant_current_user_permissions user, [:log_costs]
end
- it_behaves_like 'successful new'
+ it_behaves_like "successful new"
end
describe "WHEN user allowed to create new cost_entry
@@ -135,34 +135,34 @@ def disable_flash_sweep
grant_current_user_permissions user, [:log_costs]
end
- it_behaves_like 'successful new'
+ it_behaves_like "successful new"
end
- describe 'WHEN user is allowed to create new own cost_entry' do
+ describe "WHEN user is allowed to create new own cost_entry" do
before do
grant_current_user_permissions user, [:log_own_costs]
end
- it_behaves_like 'successful new'
+ it_behaves_like "successful new"
end
- describe 'WHEN user is not allowed to create new cost_entries' do
+ describe "WHEN user is not allowed to create new cost_entries" do
before do
grant_current_user_permissions user, []
end
- it_behaves_like 'forbidden new'
+ it_behaves_like "forbidden new"
end
end
- describe 'GET edit' do
- let(:params) { { 'id' => cost_entry.id.to_s } }
+ describe "GET edit" do
+ let(:params) { { "id" => cost_entry.id.to_s } }
before do
cost_entry.save(validate: false)
end
- shared_examples_for 'successful edit' do
+ shared_examples_for "successful edit" do
before do
get :edit, params:
end
@@ -170,10 +170,10 @@ def disable_flash_sweep
it { expect(response).to be_successful }
it { expect(assigns(:cost_entry)).to eq(cost_entry) }
it { expect(assigns(:cost_entry)).not_to be_changed }
- it { expect(response).to render_template('edit') }
+ it { expect(response).to render_template("edit") }
end
- shared_examples_for 'forbidden edit' do
+ shared_examples_for "forbidden edit" do
before do
get :edit, params:
end
@@ -181,12 +181,12 @@ def disable_flash_sweep
it { expect(response.response_code).to eq(403) }
end
- describe 'WHEN the user is allowed to edit cost_entries' do
+ describe "WHEN the user is allowed to edit cost_entries" do
before do
grant_current_user_permissions user, [:edit_cost_entries]
end
- it_behaves_like 'successful edit'
+ it_behaves_like "successful edit"
end
describe "WHEN the user is allowed to edit cost_entries
@@ -198,15 +198,15 @@ def disable_flash_sweep
cost_entry.save(validate: false)
end
- it_behaves_like 'successful edit'
+ it_behaves_like "successful edit"
end
- describe 'WHEN the user is allowed to edit own cost_entries' do
+ describe "WHEN the user is allowed to edit own cost_entries" do
before do
grant_current_user_permissions user, [:edit_own_cost_entries]
end
- it_behaves_like 'successful edit'
+ it_behaves_like "successful edit"
end
describe "WHEN the user is allowed to edit own cost_entries
@@ -218,15 +218,15 @@ def disable_flash_sweep
cost_entry.save(validate: false)
end
- it_behaves_like 'forbidden edit'
+ it_behaves_like "forbidden edit"
end
- describe 'WHEN the user is not allowed to edit cost_entries' do
+ describe "WHEN the user is not allowed to edit cost_entries" do
before do
grant_current_user_permissions user, []
end
- it_behaves_like 'forbidden edit'
+ it_behaves_like "forbidden edit"
end
describe "WHEN the user is allowed to edit cost_entries
@@ -241,7 +241,7 @@ def disable_flash_sweep
cost_entry.save!
end
- it_behaves_like 'forbidden edit'
+ it_behaves_like "forbidden edit"
end
describe "WHEN the user is allowed to edit cost_entries
@@ -249,7 +249,7 @@ def disable_flash_sweep
before do
grant_current_user_permissions user, [:edit_cost_entries]
- params['id'] = (cost_entry.id + 1).to_s
+ params["id"] = (cost_entry.id + 1).to_s
get :edit, params:
end
@@ -258,16 +258,16 @@ def disable_flash_sweep
end
end
- describe 'POST create' do
+ describe "POST create" do
let (:params) do
- { 'project_id' => project.id.to_s,
- 'cost_entry' => { 'user_id' => user.id.to_s,
- 'work_package_id' => (work_package.present? ? work_package.id.to_s : ''),
- 'units' => units.to_s,
- 'cost_type_id' => (cost_type.present? ? cost_type.id.to_s : ''),
- 'comments' => 'lorem',
- 'spent_on' => date.to_s,
- 'overridden_costs' => overridden_costs.to_s } }
+ { "project_id" => project.id.to_s,
+ "cost_entry" => { "user_id" => user.id.to_s,
+ "work_package_id" => (work_package.present? ? work_package.id.to_s : ""),
+ "units" => units.to_s,
+ "cost_type_id" => (cost_type.present? ? cost_type.id.to_s : ""),
+ "comments" => "lorem",
+ "spent_on" => date.to_s,
+ "overridden_costs" => overridden_costs.to_s } }
end
let(:expected_project) { project }
let(:expected_work_package) { work_package }
@@ -278,7 +278,7 @@ def disable_flash_sweep
let(:expected_units) { units }
let(:user2) { create(:user) }
- let(:date) { '2012-04-03'.to_date }
+ let(:date) { "2012-04-03".to_date }
let(:overridden_costs) { 500.00 }
let(:units) { 5.0 }
@@ -286,7 +286,7 @@ def disable_flash_sweep
cost_type.save! if cost_type.present?
end
- shared_examples_for 'successful create' do
+ shared_examples_for "successful create" do
before do
post :create, params:
end
@@ -294,22 +294,22 @@ def disable_flash_sweep
it { expect(response).to be_redirect }
it { expect(assigns(:cost_entry)).not_to be_new_record }
- it_behaves_like 'assigns'
- it { expect(flash[:notice]).to eql('Unit cost logged successfully.') }
+ it_behaves_like "assigns"
+ it { expect(flash[:notice]).to eql("Unit cost logged successfully.") }
end
- shared_examples_for 'invalid create' do
+ shared_examples_for "invalid create" do
before do
post :create, params:
end
it { expect(response).to be_successful }
- it_behaves_like 'assigns'
+ it_behaves_like "assigns"
it { expect(flash[:notice]).to be_nil }
end
- shared_examples_for 'forbidden create' do
+ shared_examples_for "forbidden create" do
before do
post :create, params:
end
@@ -317,20 +317,20 @@ def disable_flash_sweep
it { expect(response.response_code).to eq(403) }
end
- describe 'WHEN the user is allowed to create cost_entries' do
+ describe "WHEN the user is allowed to create cost_entries" do
before do
grant_current_user_permissions user, [:log_costs]
end
- it_behaves_like 'successful create'
+ it_behaves_like "successful create"
end
- describe 'WHEN the user is allowed to create own cost_entries' do
+ describe "WHEN the user is allowed to create own cost_entries" do
before do
grant_current_user_permissions user, [:log_own_costs]
end
- it_behaves_like 'successful create'
+ it_behaves_like "successful create"
end
describe "WHEN the user is allowed to create cost_entries
@@ -340,10 +340,10 @@ def disable_flash_sweep
before do
grant_current_user_permissions user, [:log_costs]
- params['cost_entry'].delete('spent_on')
+ params["cost_entry"].delete("spent_on")
end
- it_behaves_like 'successful create'
+ it_behaves_like "successful create"
end
describe "WHEN the user is allowed to create cost_entries
@@ -353,10 +353,10 @@ def disable_flash_sweep
before do
grant_current_user_permissions user, [:log_costs]
- params['cost_entry']['cost_type_id'] = (cost_type.id + 1).to_s
+ params["cost_entry"]["cost_type_id"] = (cost_type.id + 1).to_s
end
- it_behaves_like 'invalid create'
+ it_behaves_like "invalid create"
end
describe "WHEN the user is allowed to create cost_entries
@@ -368,10 +368,10 @@ def disable_flash_sweep
create(:cost_type, default: true)
grant_current_user_permissions user, [:log_costs]
- params['cost_entry']['cost_type_id'] = 1
+ params["cost_entry"]["cost_type_id"] = 1
end
- it_behaves_like 'invalid create'
+ it_behaves_like "invalid create"
end
describe "WHEN the user is allowed to create cost_entries
@@ -383,10 +383,10 @@ def disable_flash_sweep
create(:cost_type, default: true)
grant_current_user_permissions user, [:log_costs]
- params['cost_entry'].delete('cost_type_id')
+ params["cost_entry"].delete("cost_type_id")
end
- it_behaves_like 'invalid create'
+ it_behaves_like "invalid create"
end
describe "WHEN the user is allowed to create cost_entries
@@ -396,10 +396,10 @@ def disable_flash_sweep
before do
grant_current_user_permissions user, [:log_costs]
- params['cost_entry'].delete('cost_type_id')
+ params["cost_entry"].delete("cost_type_id")
end
- it_behaves_like 'invalid create'
+ it_behaves_like "invalid create"
end
describe "WHEN the user is allowed to create cost_entries
@@ -410,7 +410,7 @@ def disable_flash_sweep
cost_type.save!
end
- it_behaves_like 'invalid create'
+ it_behaves_like "invalid create"
end
describe "WHEN the user is allowed to create cost_entries
@@ -420,10 +420,10 @@ def disable_flash_sweep
grant_current_user_permissions user, []
grant_current_user_permissions user2, [:log_costs]
- params['cost_entry']['user_id'] = user.id.to_s
+ params["cost_entry"]["user_id"] = user.id.to_s
end
- it_behaves_like 'successful create'
+ it_behaves_like "successful create"
end
describe "WHEN the user is allowed to create cost_entries
@@ -432,10 +432,10 @@ def disable_flash_sweep
before do
grant_current_user_permissions user2, [:log_costs]
- params['cost_entry']['user_id'] = user.id.to_s
+ params["cost_entry"]["user_id"] = user.id.to_s
end
- it_behaves_like 'invalid create'
+ it_behaves_like "invalid create"
end
describe "WHEN the user is allowed to create cost_entries
@@ -451,10 +451,10 @@ def disable_flash_sweep
before do
grant_current_user_permissions user, [:log_costs]
- params['cost_entry']['work_package_id'] = work_package2.id
+ params["cost_entry"]["work_package_id"] = work_package2.id
end
- it_behaves_like 'invalid create'
+ it_behaves_like "invalid create"
end
describe "WHEN the user is allowed to create cost_entries
@@ -464,10 +464,10 @@ def disable_flash_sweep
before do
grant_current_user_permissions user, [:log_costs]
- params['cost_entry'].delete('work_package_id')
+ params["cost_entry"].delete("work_package_id")
end
- it_behaves_like 'invalid create'
+ it_behaves_like "invalid create"
end
describe "WHEN the user is allowed to create own cost_entries
@@ -475,30 +475,30 @@ def disable_flash_sweep
before do
grant_current_user_permissions user2, [:log_own_costs]
- params['cost_entry']['user_id'] = user.id
+ params["cost_entry"]["user_id"] = user.id
end
- it_behaves_like 'forbidden create'
+ it_behaves_like "forbidden create"
end
- describe 'WHEN the user is not allowed to create cost_entries' do
+ describe "WHEN the user is not allowed to create cost_entries" do
before do
grant_current_user_permissions user, []
end
- it_behaves_like 'forbidden create'
+ it_behaves_like "forbidden create"
end
end
- describe 'PUT update' do
+ describe "PUT update" do
let(:params) do
- { 'id' => cost_entry.id.to_s,
- 'cost_entry' => { 'comments' => 'lorem',
- 'work_package_id' => cost_entry.work_package.id.to_s,
- 'units' => cost_entry.units.to_s,
- 'spent_on' => cost_entry.spent_on.to_s,
- 'user_id' => cost_entry.user.id.to_s,
- 'cost_type_id' => cost_entry.cost_type.id.to_s } }
+ { "id" => cost_entry.id.to_s,
+ "cost_entry" => { "comments" => "lorem",
+ "work_package_id" => cost_entry.work_package.id.to_s,
+ "units" => cost_entry.units.to_s,
+ "spent_on" => cost_entry.spent_on.to_s,
+ "user_id" => cost_entry.user.id.to_s,
+ "cost_type_id" => cost_entry.cost_type.id.to_s } }
end
let(:expected_work_package) { cost_entry.work_package }
let(:expected_user) { cost_entry.user }
@@ -512,7 +512,7 @@ def disable_flash_sweep
cost_entry.save(validate: false)
end
- shared_examples_for 'successful update' do
+ shared_examples_for "successful update" do
before do
put :update, params:
end
@@ -520,22 +520,22 @@ def disable_flash_sweep
it { expect(response).to be_redirect }
it { expect(assigns(:cost_entry)).to eq(cost_entry) }
- it_behaves_like 'assigns'
+ it_behaves_like "assigns"
it { expect(assigns(:cost_entry)).not_to be_changed }
it { expect(flash[:notice]).to eql I18n.t(:notice_successful_update) }
end
- shared_examples_for 'invalid update' do
+ shared_examples_for "invalid update" do
before do
put :update, params:
end
- it_behaves_like 'assigns'
+ it_behaves_like "assigns"
it { expect(response).to be_successful }
it { expect(flash[:notice]).to be_nil }
end
- shared_examples_for 'forbidden update' do
+ shared_examples_for "forbidden update" do
before do
put :update, params:
end
@@ -566,15 +566,15 @@ def disable_flash_sweep
grant_current_user_permissions expected_user, []
grant_current_user_permissions user, [:edit_cost_entries]
- params['cost_entry']['work_package_id'] = expected_work_package.id.to_s
- params['cost_entry']['user_id'] = expected_user.id.to_s
- params['cost_entry']['spent_on'] = expected_spent_on.to_s
- params['cost_entry']['units'] = expected_units.to_s
- params['cost_entry']['cost_type_id'] = expected_cost_type.id.to_s
- params['cost_entry']['overridden_costs'] = expected_overridden_costs.to_s
+ params["cost_entry"]["work_package_id"] = expected_work_package.id.to_s
+ params["cost_entry"]["user_id"] = expected_user.id.to_s
+ params["cost_entry"]["spent_on"] = expected_spent_on.to_s
+ params["cost_entry"]["units"] = expected_units.to_s
+ params["cost_entry"]["cost_type_id"] = expected_cost_type.id.to_s
+ params["cost_entry"]["overridden_costs"] = expected_overridden_costs.to_s
end
- it_behaves_like 'successful update'
+ it_behaves_like "successful update"
end
describe "WHEN the user is allowed to update cost_entries
@@ -583,7 +583,7 @@ def disable_flash_sweep
grant_current_user_permissions user, [:edit_cost_entries]
end
- it_behaves_like 'successful update'
+ it_behaves_like "successful update"
end
describe "WHEN the user is allowed to update own cost_entries
@@ -593,10 +593,10 @@ def disable_flash_sweep
before do
grant_current_user_permissions user, [:edit_own_cost_entries]
- params['cost_entry']['units'] = expected_units.to_s
+ params["cost_entry"]["units"] = expected_units.to_s
end
- it_behaves_like 'successful update'
+ it_behaves_like "successful update"
end
describe "WHEN the user is allowed to update cost_entries
@@ -608,10 +608,10 @@ def disable_flash_sweep
before do
grant_current_user_permissions user, [:edit_cost_entries]
- params['cost_entry']['user_id'] = user2.id.to_s
+ params["cost_entry"]["user_id"] = user2.id.to_s
end
- it_behaves_like 'invalid update'
+ it_behaves_like "invalid update"
end
describe "WHEN the user is allowed to update cost_entries
@@ -627,10 +627,10 @@ def disable_flash_sweep
before do
grant_current_user_permissions user, [:edit_cost_entries]
- params['cost_entry']['work_package_id'] = work_package2.id.to_s
+ params["cost_entry"]["work_package_id"] = work_package2.id.to_s
end
- it_behaves_like 'invalid update'
+ it_behaves_like "invalid update"
end
describe "WHEN the user is allowed to update cost_entries
@@ -641,10 +641,10 @@ def disable_flash_sweep
before do
grant_current_user_permissions user, [:edit_cost_entries]
- params['cost_entry']['work_package_id'] = (work_package.id + 1).to_s
+ params["cost_entry"]["work_package_id"] = (work_package.id + 1).to_s
end
- it_behaves_like 'invalid update'
+ it_behaves_like "invalid update"
end
describe "WHEN the user is allowed to update cost_entries
@@ -655,10 +655,10 @@ def disable_flash_sweep
before do
grant_current_user_permissions user, [:edit_cost_entries]
- params['cost_entry']['cost_type_id'] = expected_cost_type.id.to_s
+ params["cost_entry"]["cost_type_id"] = expected_cost_type.id.to_s
end
- it_behaves_like 'invalid update'
+ it_behaves_like "invalid update"
end
describe "WHEN the user is allowed to update cost_entries
@@ -669,10 +669,10 @@ def disable_flash_sweep
before do
grant_current_user_permissions user, [:edit_cost_entries]
- params['cost_entry']['cost_type_id'] = '1234123512'
+ params["cost_entry"]["cost_type_id"] = "1234123512"
end
- it_behaves_like 'invalid update'
+ it_behaves_like "invalid update"
end
describe "WHEN the user is allowed to update own cost_entries and not all
@@ -683,10 +683,10 @@ def disable_flash_sweep
before do
grant_current_user_permissions user, [:edit_own_cost_entries]
- params['cost_entry']['user_id'] = user3.id
+ params["cost_entry"]["user_id"] = user3.id
end
- it_behaves_like 'forbidden update'
+ it_behaves_like "forbidden update"
end
describe "WHEN the user is allowed to update own cost_entries and not all
@@ -697,10 +697,10 @@ def disable_flash_sweep
before do
grant_current_user_permissions user3, [:edit_own_cost_entries]
- params['cost_entry']['units'] = (cost_entry.units + 20).to_s
+ params["cost_entry"]["units"] = (cost_entry.units + 20).to_s
end
- it_behaves_like 'forbidden update'
+ it_behaves_like "forbidden update"
end
end
end
diff --git a/modules/costs/spec/controllers/hourly_rates_controller_spec.rb b/modules/costs/spec/controllers/hourly_rates_controller_spec.rb
index 3f7df92323a8..1ba6a81a9845 100644
--- a/modules/costs/spec/controllers/hourly_rates_controller_spec.rb
+++ b/modules/costs/spec/controllers/hourly_rates_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper.rb")
RSpec.describe HourlyRatesController do
shared_let(:admin) { create(:admin) }
@@ -34,13 +34,13 @@
let(:user) { create(:user) }
let(:default_rate) { create(:default_hourly_rate, user:) }
- describe 'PUT update' do
- describe 'WHEN trying to update with an invalid rate value' do
+ describe "PUT update" do
+ describe "WHEN trying to update with an invalid rate value" do
let(:params) do
{
id: user.id,
- user: { 'existing_rate_attributes' => { default_rate.id.to_s => { 'valid_from' => default_rate.valid_from.to_s,
- 'rate' => '2d5' } } }
+ user: { "existing_rate_attributes" => { default_rate.id.to_s => { "valid_from" => default_rate.valid_from.to_s,
+ "rate" => "2d5" } } }
}
end
@@ -50,13 +50,13 @@
end
end
- it 'renders the edit template' do
- expect(response).to render_template('edit')
+ it "renders the edit template" do
+ expect(response).to render_template("edit")
end
- it 'displays an error message' do
+ it "displays an error message" do
actual_message = assigns(:user).default_rates.first.errors.messages[:rate].first
- expect(actual_message).to eq(I18n.t('activerecord.errors.messages.not_a_number'))
+ expect(actual_message).to eq(I18n.t("activerecord.errors.messages.not_a_number"))
end
end
end
diff --git a/modules/costs/spec/controllers/work_packages_bulk_controller_spec.rb b/modules/costs/spec/controllers/work_packages_bulk_controller_spec.rb
index 5491e29772d5..689dc25c2041 100644
--- a/modules/costs/spec/controllers/work_packages_bulk_controller_spec.rb
+++ b/modules/costs/spec/controllers/work_packages_bulk_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WorkPackages::BulkController do
let(:project) { create(:project_with_types) }
@@ -39,8 +39,8 @@
allow(User).to receive(:current).and_return user
end
- describe '#update' do
- context 'when a cost report is assigned' do
+ describe "#update" do
+ context "when a cost report is assigned" do
before do
put :update, params: { ids: [work_package.id],
work_package: { budget_id: budget.id } }
diff --git a/modules/costs/spec/factories/cost_entry_factory.rb b/modules/costs/spec/factories/cost_entry_factory.rb
index 6764a000c000..3b4b00e02946 100644
--- a/modules/costs/spec/factories/cost_entry_factory.rb
+++ b/modules/costs/spec/factories/cost_entry_factory.rb
@@ -34,7 +34,7 @@
cost_type
spent_on { Date.today }
units { 1 }
- comments { '' }
+ comments { "" }
before(:create) do |ce|
ce.work_package.project = ce.project
diff --git a/modules/costs/spec/factories/cost_type_factory.rb b/modules/costs/spec/factories/cost_type_factory.rb
index 7763c414d283..7e19c64609fe 100644
--- a/modules/costs/spec/factories/cost_type_factory.rb
+++ b/modules/costs/spec/factories/cost_type_factory.rb
@@ -29,8 +29,8 @@
FactoryBot.define do
factory :cost_type do
sequence(:name) { |n| "ct no. #{n}" }
- unit { 'singular_unit' }
- unit_plural { 'plural_unit' }
+ unit { "singular_unit" }
+ unit_plural { "plural_unit" }
trait :deleted do
deleted_at { Time.now }
diff --git a/modules/costs/spec/factories/journal/budget_journal_factory.rb b/modules/costs/spec/factories/journal/budget_journal_factory.rb
index ea79035fac04..a366514f80e4 100644
--- a/modules/costs/spec/factories/journal/budget_journal_factory.rb
+++ b/modules/costs/spec/factories/journal/budget_journal_factory.rb
@@ -27,6 +27,6 @@
#++
FactoryBot.define do
- factory :journal_budget_journal, class: 'Journal::BudgetJournal' do
+ factory :journal_budget_journal, class: "Journal::BudgetJournal" do
end
end
diff --git a/modules/costs/spec/factories/journal/time_entry_journal_factory.rb b/modules/costs/spec/factories/journal/time_entry_journal_factory.rb
index d2adfe07b886..07cb2a25a81a 100644
--- a/modules/costs/spec/factories/journal/time_entry_journal_factory.rb
+++ b/modules/costs/spec/factories/journal/time_entry_journal_factory.rb
@@ -27,6 +27,6 @@
#++
FactoryBot.define do
- factory :journal_time_entry_journal, class: 'Journal::TimeEntryJournal' do
+ factory :journal_time_entry_journal, class: "Journal::TimeEntryJournal" do
end
end
diff --git a/modules/costs/spec/features/cost_entries/add_cost_entry_spec.rb b/modules/costs/spec/features/cost_entries/add_cost_entry_spec.rb
index a11bcf363249..2ade93e62604 100644
--- a/modules/costs/spec/features/cost_entries/add_cost_entry_spec.rb
+++ b/modules/costs/spec/features/cost_entries/add_cost_entry_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative '../../spec_helper'
+require_relative "../../spec_helper"
-RSpec.describe 'Work Package cost fields', :js do
+RSpec.describe "Work Package cost fields", :js do
shared_let(:type_task) { create(:type_task) }
shared_let(:status) { create(:status, is_default: true) }
shared_let(:priority) { create(:priority, is_default: true) }
@@ -50,13 +50,13 @@
member_with_roles: { project => role })
end
shared_let(:cost_type1) do
- type = create(:cost_type, name: 'A', unit: 'A single', unit_plural: 'A plural')
+ type = create(:cost_type, name: "A", unit: "A single", unit_plural: "A plural")
create(:cost_rate, cost_type: type, rate: 1.00)
type
end
shared_let(:cost_type2) do
- type = create(:cost_type, name: 'B', unit: 'B single', unit_plural: 'B plural')
+ type = create(:cost_type, name: "B", unit: "B single", unit_plural: "B plural")
create(:cost_rate, cost_type: type, rate: 2.00)
type
end
@@ -68,38 +68,38 @@
login_as user
end
- it 'does not show read-only fields' do
+ it "does not show read-only fields" do
full_view.visit!
# Go to add cost entry page
SeleniumHubWaiter.wait
- find('#action-show-more-dropdown-menu .button').click
- find('.menu-item', text: 'Log unit costs').click
+ find("#action-show-more-dropdown-menu .button").click
+ find(".menu-item", text: "Log unit costs").click
SeleniumHubWaiter.wait
# Set single value, should update suffix
- select 'A', from: 'cost_entry_cost_type_id'
- fill_in 'cost_entry_units', with: '1'
- expect(page).to have_css('#cost_entry_unit_name', text: 'A single')
- expect(page).to have_css('#cost_entry_costs', text: '1.00 EUR')
+ select "A", from: "cost_entry_cost_type_id"
+ fill_in "cost_entry_units", with: "1"
+ expect(page).to have_css("#cost_entry_unit_name", text: "A single")
+ expect(page).to have_css("#cost_entry_costs", text: "1.00 EUR")
- fill_in 'cost_entry_units', with: '2'
- expect(page).to have_css('#cost_entry_unit_name', text: 'A plural')
- expect(page).to have_css('#cost_entry_costs', text: '2.00 EUR')
+ fill_in "cost_entry_units", with: "2"
+ expect(page).to have_css("#cost_entry_unit_name", text: "A plural")
+ expect(page).to have_css("#cost_entry_costs", text: "2.00 EUR")
# Switch cost type
- select 'B', from: 'cost_entry_cost_type_id'
- expect(page).to have_css('#cost_entry_unit_name', text: 'B plural')
- expect(page).to have_css('#cost_entry_costs', text: '4.00 EUR')
+ select "B", from: "cost_entry_cost_type_id"
+ expect(page).to have_css("#cost_entry_unit_name", text: "B plural")
+ expect(page).to have_css("#cost_entry_costs", text: "4.00 EUR")
# Override costs
- find_by_id('cost_entry_costs').click
+ find_by_id("cost_entry_costs").click
SeleniumHubWaiter.wait
- fill_in 'cost_entry_overridden_costs', with: '15.52'
+ fill_in "cost_entry_overridden_costs", with: "15.52"
- click_on 'Save'
+ click_on "Save"
# Expect correct costs
- expect(page).to have_css('.op-toast.-success', text: I18n.t(:notice_cost_logged_successfully))
+ expect(page).to have_css(".op-toast.-success", text: I18n.t(:notice_cost_logged_successfully))
entry = CostEntry.last
expect(entry.cost_type_id).to eq(cost_type2.id)
expect(entry.units).to eq(2.0)
@@ -107,11 +107,11 @@
expect(entry.real_costs).to eq(15.52)
visit edit_cost_entry_path(entry)
- expect(page).to have_css('#cost_entry_costs', text: '15.52 EUR')
+ expect(page).to have_css("#cost_entry_costs", text: "15.52 EUR")
end
- context 'with german locale' do
- it 'creates the budget including the given cost items with german locale' do
+ context "with german locale" do
+ it "creates the budget including the given cost items with german locale" do
user.update!(language: :de)
I18n.locale = :de
@@ -119,24 +119,24 @@
# Go to add cost entry page
SeleniumHubWaiter.wait
- find('#action-show-more-dropdown-menu .button').click
- find('.menu-item', text: I18n.t(:button_log_costs)).click
+ find("#action-show-more-dropdown-menu .button").click
+ find(".menu-item", text: I18n.t(:button_log_costs)).click
SeleniumHubWaiter.wait
- fill_in 'cost_entry_units', with: '1,42'
- select 'B', from: 'cost_entry_cost_type_id'
- expect(page).to have_css('#cost_entry_unit_name', text: 'B plural')
- expect(page).to have_css('#cost_entry_costs', text: '2,84 EUR')
+ fill_in "cost_entry_units", with: "1,42"
+ select "B", from: "cost_entry_cost_type_id"
+ expect(page).to have_css("#cost_entry_unit_name", text: "B plural")
+ expect(page).to have_css("#cost_entry_costs", text: "2,84 EUR")
# Override costs
- find_by_id('cost_entry_costs').click
+ find_by_id("cost_entry_costs").click
SeleniumHubWaiter.wait
- fill_in 'cost_entry_overridden_costs', with: '1.350,25'
+ fill_in "cost_entry_overridden_costs", with: "1.350,25"
click_on I18n.t(:button_save)
# Expect correct costs
- expect(page).to have_css('.op-toast.-success', text: I18n.t(:notice_cost_logged_successfully))
+ expect(page).to have_css(".op-toast.-success", text: I18n.t(:notice_cost_logged_successfully))
entry = CostEntry.last
expect(entry.cost_type_id).to eq(cost_type2.id)
expect(entry.units).to eq(1.42)
@@ -145,18 +145,18 @@
# Can edit the costs again
visit edit_cost_entry_path(entry)
- expect(page).to have_css('#cost_entry_costs', text: '1.350,25 EUR')
+ expect(page).to have_css("#cost_entry_costs", text: "1.350,25 EUR")
# Toggle the cost button
SeleniumHubWaiter.wait
- find_by_id('cost_entry_costs').click
+ find_by_id("cost_entry_costs").click
# Update the costs in german locale
SeleniumHubWaiter.wait
- fill_in 'cost_entry_overridden_costs', with: '55.000,55'
+ fill_in "cost_entry_overridden_costs", with: "55.000,55"
click_on I18n.t(:button_save)
- expect(page).to have_css('#cost_entry_costs', text: '55.000,55 EUR')
+ expect(page).to have_css("#cost_entry_costs", text: "55.000,55 EUR")
entry.reload
expect(entry.units).to eq(1.42)
expect(entry.costs).to eq(2.84)
@@ -164,25 +164,25 @@
end
end
- context 'with an additional placeholder user in the project' do
+ context "with an additional placeholder user in the project" do
let!(:placeholder_user) do
create(:placeholder_user,
member_with_roles: { project => role })
end
- it 'does not allow to select them (Regression #36353)' do
+ it "does not allow to select them (Regression #36353)" do
expect(placeholder_user).to be_present
expect(Principal.possible_assignee(project).to_a).to include placeholder_user
full_view.visit!
# Go to add cost entry page
SeleniumHubWaiter.wait
- find('#action-show-more-dropdown-menu .button').click
- find('.menu-item', text: I18n.t(:button_log_costs)).click
+ find("#action-show-more-dropdown-menu .button").click
+ find(".menu-item", text: I18n.t(:button_log_costs)).click
SeleniumHubWaiter.wait
- expect(page).to have_no_css('#cost_entry_user_id option', text: placeholder_user.name, visible: :all)
- expect(page).to have_css('#cost_entry_user_id option', text: user.name, visible: :all)
+ expect(page).to have_no_css("#cost_entry_user_id option", text: placeholder_user.name, visible: :all)
+ expect(page).to have_css("#cost_entry_user_id option", text: user.name, visible: :all)
end
end
end
diff --git a/modules/costs/spec/features/cost_entries/add_entry_without_rate_permission_spec.rb b/modules/costs/spec/features/cost_entries/add_entry_without_rate_permission_spec.rb
index 111a666a5ee4..7008b2ca0e69 100644
--- a/modules/costs/spec/features/cost_entries/add_entry_without_rate_permission_spec.rb
+++ b/modules/costs/spec/features/cost_entries/add_entry_without_rate_permission_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative '../../spec_helper'
+require_relative "../../spec_helper"
-RSpec.describe 'Create cost entry without rate permissions', :js do
+RSpec.describe "Create cost entry without rate permissions", :js do
shared_let(:type_task) { create(:type_task) }
shared_let(:status) { create(:status, is_default: true) }
shared_let(:priority) { create(:priority, is_default: true) }
@@ -48,7 +48,7 @@
end
shared_let(:cost_type) do
- type = create(:cost_type, name: 'A', unit: 'A single', unit_plural: 'A plural')
+ type = create(:cost_type, name: "A", unit: "A single", unit_plural: "A plural")
create(:cost_rate, cost_type: type, rate: 1.00)
type
end
@@ -60,24 +60,24 @@
login_as user
end
- it 'can create the item without seeing the costs' do
+ it "can create the item without seeing the costs" do
full_view.visit!
# Go to add cost entry page
SeleniumHubWaiter.wait
- find('#action-show-more-dropdown-menu .button').click
- find('.menu-item', text: 'Log unit costs').click
+ find("#action-show-more-dropdown-menu .button").click
+ find(".menu-item", text: "Log unit costs").click
SeleniumHubWaiter.wait
# Set single value, should update suffix
- select 'A', from: 'cost_entry_cost_type_id'
- fill_in 'cost_entry_units', with: '1'
- expect(page).to have_css('#cost_entry_unit_name', text: 'A single')
- expect(page).to have_no_css('#cost_entry_costs')
+ select "A", from: "cost_entry_cost_type_id"
+ fill_in "cost_entry_units", with: "1"
+ expect(page).to have_css("#cost_entry_unit_name", text: "A single")
+ expect(page).to have_no_css("#cost_entry_costs")
- click_on 'Save'
+ click_on "Save"
# Expect correct costs
- expect(page).to have_css('.op-toast.-success', text: I18n.t(:notice_cost_logged_successfully))
+ expect(page).to have_css(".op-toast.-success", text: I18n.t(:notice_cost_logged_successfully))
entry = CostEntry.last
expect(entry.cost_type_id).to eq(cost_type.id)
expect(entry.units).to eq(1.0)
diff --git a/modules/costs/spec/features/cost_types/create_cost_type_spec.rb b/modules/costs/spec/features/cost_types/create_cost_type_spec.rb
index 6f4cd437db83..b3039a017d1f 100644
--- a/modules/costs/spec/features/cost_types/create_cost_type_spec.rb
+++ b/modules/costs/spec/features/cost_types/create_cost_type_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'creating a cost type', :js do
+RSpec.describe "creating a cost type", :js do
let!(:user) { create(:admin) }
let!(:cost_type) do
- type = create(:cost_type, name: 'Translations')
+ type = create(:cost_type, name: "Translations")
create(:cost_rate, cost_type: type, rate: 1.00)
type
end
@@ -40,61 +40,61 @@
login_as user
end
- it 'can create a cost type' do
+ it "can create a cost type" do
visit "/cost_types/new"
- fill_in 'cost_type_name', with: 'Test day rate'
- fill_in 'cost_type_unit', with: 'dayUnit'
- fill_in 'cost_type_unit_plural', with: 'dayUnitPlural'
- fill_in 'cost_type_new_rate_attributes_0_rate', with: '1,000.25'
+ fill_in "cost_type_name", with: "Test day rate"
+ fill_in "cost_type_unit", with: "dayUnit"
+ fill_in "cost_type_unit_plural", with: "dayUnitPlural"
+ fill_in "cost_type_new_rate_attributes_0_rate", with: "1,000.25"
sleep 1
- scroll_to_and_click(find('button.-with-icon.icon-checkmark'))
+ scroll_to_and_click(find("button.-with-icon.icon-checkmark"))
expect_angular_frontend_initialized
- expect(page).to have_css '.generic-table', wait: 10
+ expect(page).to have_css ".generic-table", wait: 10
- cost_type_row = find('tr', text: 'Test day rate')
+ cost_type_row = find("tr", text: "Test day rate")
- expect(cost_type_row).to have_css('td a', text: 'Test day rate')
- expect(cost_type_row).to have_css('td', text: 'dayUnit')
- expect(cost_type_row).to have_css('td', text: 'dayUnitPlural')
- expect(cost_type_row).to have_css('td.currency', text: '1,000.25')
+ expect(cost_type_row).to have_css("td a", text: "Test day rate")
+ expect(cost_type_row).to have_css("td", text: "dayUnit")
+ expect(cost_type_row).to have_css("td", text: "dayUnitPlural")
+ expect(cost_type_row).to have_css("td.currency", text: "1,000.25")
cost_type = CostType.last
- expect(cost_type.name).to eq 'Test day rate'
+ expect(cost_type.name).to eq "Test day rate"
cost_rate = cost_type.rates.last
expect(cost_rate.rate).to eq 1000.25
end
- context 'with german locale' do
+ context "with german locale" do
let(:user) { create(:admin, language: :de) }
- it 'creates the entry with german number separators' do
+ it "creates the entry with german number separators" do
visit "/cost_types/new"
- fill_in 'cost_type_name', with: 'Test day rate'
- fill_in 'cost_type_unit', with: 'dayUnit'
- fill_in 'cost_type_unit_plural', with: 'dayUnitPlural'
- fill_in 'cost_type_new_rate_attributes_0_rate', with: '1.000,25'
+ fill_in "cost_type_name", with: "Test day rate"
+ fill_in "cost_type_unit", with: "dayUnit"
+ fill_in "cost_type_unit_plural", with: "dayUnitPlural"
+ fill_in "cost_type_new_rate_attributes_0_rate", with: "1.000,25"
sleep 1
- scroll_to_and_click(find('button.-with-icon.icon-checkmark'))
+ scroll_to_and_click(find("button.-with-icon.icon-checkmark"))
expect_angular_frontend_initialized
- expect(page).to have_css '.generic-table', wait: 10
+ expect(page).to have_css ".generic-table", wait: 10
- cost_type_row = find('tr', text: 'Test day rate')
+ cost_type_row = find("tr", text: "Test day rate")
- expect(cost_type_row).to have_css('td a', text: 'Test day rate')
- expect(cost_type_row).to have_css('td', text: 'dayUnit')
- expect(cost_type_row).to have_css('td', text: 'dayUnitPlural')
- expect(cost_type_row).to have_css('td.currency', text: '1.000,25')
+ expect(cost_type_row).to have_css("td a", text: "Test day rate")
+ expect(cost_type_row).to have_css("td", text: "dayUnit")
+ expect(cost_type_row).to have_css("td", text: "dayUnitPlural")
+ expect(cost_type_row).to have_css("td.currency", text: "1.000,25")
cost_type = CostType.last
- expect(cost_type.name).to eq 'Test day rate'
+ expect(cost_type.name).to eq "Test day rate"
cost_rate = cost_type.rates.last
expect(cost_rate.rate).to eq 1000.25
end
diff --git a/modules/costs/spec/features/cost_types/delete_cost_type_spec.rb b/modules/costs/spec/features/cost_types/delete_cost_type_spec.rb
index 48f61847e2ab..3a98bed667f8 100644
--- a/modules/costs/spec/features/cost_types/delete_cost_type_spec.rb
+++ b/modules/costs/spec/features/cost_types/delete_cost_type_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'deleting a cost type', :js do
+RSpec.describe "deleting a cost type", :js do
let!(:user) { create(:admin) }
let!(:cost_type) do
- type = create(:cost_type, name: 'Translations')
+ type = create(:cost_type, name: "Translations")
create(:cost_rate, cost_type: type, rate: 1.00)
type
end
@@ -40,26 +40,26 @@
login_as user
end
- it 'can delete the cost type' do
+ it "can delete the cost type" do
visit cost_types_path
within("#delete_cost_type_#{cost_type.id}") do
- scroll_to_and_click(find('button.submit_cost_type'))
+ scroll_to_and_click(find("button.submit_cost_type"))
end
# Expect no results if not locked
expect_angular_frontend_initialized
- expect(page).to have_css '.generic-table--no-results-container', wait: 10
+ expect(page).to have_css ".generic-table--no-results-container", wait: 10
SeleniumHubWaiter.wait
# Show locked
- find_by_id('include_deleted').set true
- click_on 'Apply'
+ find_by_id("include_deleted").set true
+ click_on "Apply"
# Expect no results if not locked
expect(page).to have_text I18n.t(:label_locked_cost_types)
- expect(page).to have_css('.restore_cost_type')
- expect(page).to have_css('.cost-types--list-deleted td', text: 'Translations')
+ expect(page).to have_css(".restore_cost_type")
+ expect(page).to have_css(".cost-types--list-deleted td", text: "Translations")
end
end
diff --git a/modules/costs/spec/features/costs_context_menu_spec.rb b/modules/costs/spec/features/costs_context_menu_spec.rb
index 48ed7859e986..f075b3d1484e 100644
--- a/modules/costs/spec/features/costs_context_menu_spec.rb
+++ b/modules/costs/spec/features/costs_context_menu_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package table log unit costs', :js do
+RSpec.describe "Work package table log unit costs", :js do
let(:user) { create(:admin) }
let(:work_package) { create(:work_package) }
@@ -24,8 +24,8 @@ def goto_context_menu
goto_context_menu
end
- it 'renders the log unit costs menu item' do
+ it "renders the log unit costs menu item" do
menu.choose(I18n.t(:label_log_costs))
- expect(page).to have_css('h2', text: I18n.t(:label_log_costs))
+ expect(page).to have_css("h2", text: I18n.t(:label_log_costs))
end
end
diff --git a/modules/costs/spec/features/destroy_work_package_with_cost_entries_spec.rb b/modules/costs/spec/features/destroy_work_package_with_cost_entries_spec.rb
index 66874c5d1cb0..54b1dcc0a582 100644
--- a/modules/costs/spec/features/destroy_work_package_with_cost_entries_spec.rb
+++ b/modules/costs/spec/features/destroy_work_package_with_cost_entries_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper.rb")
-RSpec.describe 'Deleting time entries', :js do
+RSpec.describe "Deleting time entries", :js do
let(:project) { work_package.project }
let(:user) do
create(:user,
@@ -44,7 +44,7 @@
let(:work_package) { create(:work_package) }
let(:destroy_modal) { Components::WorkPackages::DestroyModal.new }
let(:cost_type) do
- type = create(:cost_type, name: 'Translations')
+ type = create(:cost_type, name: "Translations")
create(:cost_rate,
cost_type: type,
rate: 7.00)
@@ -63,7 +63,7 @@
user:)
end
- it 'allows to move the time entry to a different work package' do
+ it "allows to move the time entry to a different work package" do
login_as(user)
work_package
@@ -74,18 +74,18 @@
wp_page.visit!
SeleniumHubWaiter.wait
- find_by_id('action-show-more-dropdown-menu').click
+ find_by_id("action-show-more-dropdown-menu").click
- click_link(I18n.t('js.button_delete'))
+ click_link(I18n.t("js.button_delete"))
destroy_modal.expect_listed(work_package)
destroy_modal.confirm_deletion
SeleniumHubWaiter.wait
- choose 'to_do_action_reassign'
- fill_in 'to_do_reassign_to_id', with: other_work_package.id
+ choose "to_do_action_reassign"
+ fill_in "to_do_reassign_to_id", with: other_work_package.id
- click_button(I18n.t('button_delete'))
+ click_button(I18n.t("button_delete"))
table = Pages::WorkPackagesTable.new(project)
table.expect_current_path
@@ -93,6 +93,6 @@
other_wp_page = Pages::FullWorkPackage.new(other_work_package)
other_wp_page.visit!
- wp_page.expect_attributes costs_by_type: '2 Translations'
+ wp_page.expect_attributes costs_by_type: "2 Translations"
end
end
diff --git a/modules/costs/spec/features/members_hourly_rates_spec.rb b/modules/costs/spec/features/members_hourly_rates_spec.rb
index 9b37479230ea..f989f2e1c6c8 100644
--- a/modules/costs/spec/features/members_hourly_rates_spec.rb
+++ b/modules/costs/spec/features/members_hourly_rates_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper.rb")
-RSpec.describe 'hourly rates on a member', :js do
+RSpec.describe "hourly rates on a member", :js do
let(:project) { build(:project) }
let(:user) do
create(:admin, member_with_permissions: { project => %i[view_work_packages edit_work_packages] })
@@ -36,7 +36,7 @@
let(:member) { Member.find_by(project:, principal: user) }
def view_rates
- visit edit_user_path(user, tab: 'rates')
+ visit edit_user_path(user, tab: "rates")
end
def view_project_members
@@ -54,13 +54,13 @@ def add_rate(rate:, date:)
sleep(0.1)
all("tr[id^='user_new_rate_attributes_'] .delete-row-button").each(&:click)
sleep(0.1)
- click_link_or_button 'Add rate'
+ click_link_or_button "Add rate"
datepicker = Components::BasicDatepicker.new
- datepicker.set_date(date.strftime('%Y-%m-%d'))
+ datepicker.set_date(date.strftime("%Y-%m-%d"))
within "tr[id^='user_new_rate_attributes_']" do
- fill_in 'Rate', with: rate
+ fill_in "Rate", with: rate
end
end
@@ -68,7 +68,7 @@ def change_rate_date(from:, to:)
input = find("table.rates .date input[data-value='#{from.strftime('%Y-%m-%d')}']")
input.click
datepicker = Components::BasicDatepicker.new
- datepicker.set_date(to.strftime('%Y-%m-%d'))
+ datepicker.set_date(to.strftime("%Y-%m-%d"))
end
before do
@@ -77,34 +77,34 @@ def change_rate_date(from:, to:)
login_as(user)
end
- it 'displays always the currently active rate' do
- expect_current_rate_in_members_table('0.00 EUR')
+ it "displays always the currently active rate" do
+ expect_current_rate_in_members_table("0.00 EUR")
- click_link('0.00 EUR')
+ click_link("0.00 EUR")
SeleniumHubWaiter.wait
add_rate(date: Date.current, rate: 10)
- click_button 'Save'
+ click_button "Save"
- expect_current_rate_in_members_table('10.00 EUR')
+ expect_current_rate_in_members_table("10.00 EUR")
SeleniumHubWaiter.wait
- click_link('10.00 EUR')
+ click_link("10.00 EUR")
add_rate(date: 3.days.ago, rate: 20)
- click_button 'Save'
+ click_button "Save"
- expect_current_rate_in_members_table('10.00 EUR')
+ expect_current_rate_in_members_table("10.00 EUR")
SeleniumHubWaiter.wait
- click_link('10.00 EUR')
+ click_link("10.00 EUR")
change_rate_date(from: Date.current, to: 5.days.ago)
- click_button 'Save'
+ click_button "Save"
- expect_current_rate_in_members_table('20.00 EUR')
+ expect_current_rate_in_members_table("20.00 EUR")
end
end
diff --git a/modules/costs/spec/features/time_entries_spec.rb b/modules/costs/spec/features/time_entries_spec.rb
index 661e3184ebc8..3d6002cc3689 100644
--- a/modules/costs/spec/features/time_entries_spec.rb
+++ b/modules/costs/spec/features/time_entries_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative '../spec_helper'
+require_relative "../spec_helper"
-RSpec.describe 'Work Package table cost entries', :js do
+RSpec.describe "Work Package table cost entries", :js do
shared_let(:project) { create(:project_with_types) }
shared_let(:user) { create(:admin) }
@@ -65,7 +65,7 @@
login_as(user)
end
- it 'shows the correct sum of the time entries' do
+ it "shows the correct sum of the time entries" do
wp_table.visit_query(query)
wp_table.expect_work_package_listed(parent)
wp_table.expect_work_package_listed(work_package)
@@ -73,20 +73,20 @@
parent_row = wp_table.row(parent)
wp_row = wp_table.row(work_package)
- expect(parent_row).to have_css('.inline-edit--container.spentTime', text: '12.5 h')
- expect(wp_row).to have_css('.inline-edit--container.spentTime', text: '2.5 h')
+ expect(parent_row).to have_css(".inline-edit--container.spentTime", text: "12.5 h")
+ expect(wp_row).to have_css(".inline-edit--container.spentTime", text: "2.5 h")
end
- it 'creates an activity' do
+ it "creates an activity" do
visit project_activities_path project
# Activate the spent time filter
- check('Spent time')
- click_on 'Apply'
+ check("Spent time")
+ click_on "Apply"
wp1 = time_entry1.work_package
wp2 = time_entry2.work_package
- expect(page).to have_css('.op-activity-list--item-title', text: "#{wp1.type.name} ##{wp1.id}: #{wp1.subject}")
- expect(page).to have_css('.op-activity-list--item-title', text: "#{wp2.type.name} ##{wp2.id}: #{wp2.subject}")
+ expect(page).to have_css(".op-activity-list--item-title", text: "#{wp1.type.name} ##{wp1.id}: #{wp1.subject}")
+ expect(page).to have_css(".op-activity-list--item-title", text: "#{wp2.type.name} ##{wp2.id}: #{wp2.subject}")
end
end
diff --git a/modules/costs/spec/features/time_entry/activity_spec.rb b/modules/costs/spec/features/time_entry/activity_spec.rb
index cf05f0aae663..c1fc24fa4132 100644
--- a/modules/costs/spec/features/time_entry/activity_spec.rb
+++ b/modules/costs/spec/features/time_entry/activity_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Time entry activity' do
+RSpec.describe "Time entry activity" do
shared_let(:admin) { create(:admin) }
let(:project) { create(:project) }
@@ -36,35 +36,35 @@
login_as(admin)
end
- it 'supports CRUD' do
+ it "supports CRUD" do
visit enumerations_path
- page.find_test_selector('create-enumeration-time-entry-activity').click
+ page.find_test_selector("create-enumeration-time-entry-activity").click
- fill_in 'Name', with: 'A new activity'
- click_on('Create')
+ fill_in "Name", with: "A new activity"
+ click_on("Create")
expect(page.current_path)
.to eql enumerations_path
expect(page)
- .to have_content('A new activity')
+ .to have_content("A new activity")
visit project_settings_general_path(project)
click_on "Time tracking activities"
expect(page)
- .to have_field('A new activity', checked: true)
+ .to have_field("A new activity", checked: true)
- uncheck 'A new activity'
+ uncheck "A new activity"
- click_on 'Save'
+ click_on "Save"
expect(page)
.to have_content "Successful update."
expect(page)
- .to have_field('A new activity', checked: false)
+ .to have_field("A new activity", checked: false)
end
end
diff --git a/modules/costs/spec/features/timer_spec.rb b/modules/costs/spec/features/timer_spec.rb
index cdbdb22cc11d..03f4ee246f80 100644
--- a/modules/costs/spec/features/timer_spec.rb
+++ b/modules/costs/spec/features/timer_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative '../spec_helper'
+require_relative "../spec_helper"
-RSpec.describe 'Work Package timer', :js do
+RSpec.describe "Work Package timer", :js do
shared_let(:project) { create(:project_with_types) }
- shared_let(:work_package_a) { create(:work_package, subject: 'WP A', project:) }
- shared_let(:work_package_b) { create(:work_package, subject: 'WP B', project:) }
+ shared_let(:work_package_a) { create(:work_package, subject: "WP A", project:) }
+ shared_let(:work_package_b) { create(:work_package, subject: "WP B", project:) }
let(:wp_view_a) { Pages::FullWorkPackage.new(work_package_a) }
let(:wp_view_b) { Pages::FullWorkPackage.new(work_package_b) }
@@ -45,8 +45,8 @@
login_as user
end
- shared_examples 'allows time tracking' do
- it 'shows the timer and allows tracking time' do
+ shared_examples "allows time tracking" do
+ it "shows the timer and allows tracking time" do
wp_view_a.visit!
timer_button.expect_visible
timer_button.start
@@ -58,20 +58,20 @@
expect(timer_entry.work_package).to eq work_package_a
expect(timer_entry.hours).to be_nil
- page.find('.op-top-menu-user').click
- expect(page).to have_css('.op-timer-account-menu', wait: 10)
- expect(page).to have_css('.op-timer-account-menu--wp-details', text: "##{work_package_a.id}: WP A")
- page.find_test_selector('op-timer-account-menu-stop').click
+ page.find(".op-top-menu-user").click
+ expect(page).to have_css(".op-timer-account-menu", wait: 10)
+ expect(page).to have_css(".op-timer-account-menu--wp-details", text: "##{work_package_a.id}: WP A")
+ page.find_test_selector("op-timer-account-menu-stop").click
time_logging_modal.is_visible true
- time_logging_modal.has_field_with_value 'spentOn', Date.current.strftime
- time_logging_modal.has_field_with_value 'hours', /(\d\.)?\d+/
+ time_logging_modal.has_field_with_value "spentOn", Date.current.strftime
+ time_logging_modal.has_field_with_value "hours", /(\d\.)?\d+/
time_logging_modal.work_package_is_missing false
# wait for available_work_packages query to finish before saving
time_logging_modal.expect_work_package(work_package_a.subject)
- time_logging_modal.perform_action 'Save'
+ time_logging_modal.perform_action "Save"
time_logging_modal.is_visible false
wp_view_a.expect_and_dismiss_toaster message: I18n.t(:notice_successful_update)
@@ -92,8 +92,8 @@
timer_button.start
- expect(page).to have_css('.op-timer-stop-modal')
- expect(page).to have_text('Tracking time:')
+ expect(page).to have_css(".op-timer-stop-modal")
+ expect(page).to have_text("Tracking time:")
active_time_entries = TimeEntry.where(ongoing: true, user:)
expect(active_time_entries.count).to eq 1
@@ -101,15 +101,15 @@
expect(timer_entry.work_package).to eq work_package_a
expect(timer_entry.hours).to be_nil
- page.within('.spot-modal') { click_button 'Stop current timer' }
+ page.within(".spot-modal") { click_button "Stop current timer" }
time_logging_modal.is_visible true
- time_logging_modal.has_field_with_value 'spentOn', Date.current.strftime
- time_logging_modal.has_field_with_value 'hours', /(\d\.)?\d+/
+ time_logging_modal.has_field_with_value "spentOn", Date.current.strftime
+ time_logging_modal.has_field_with_value "hours", /(\d\.)?\d+/
time_logging_modal.work_package_is_missing false
# wait for available_work_packages query to finish before saving
time_logging_modal.expect_work_package(work_package_a.subject)
- time_logging_modal.perform_action 'Save'
+ time_logging_modal.perform_action "Save"
# Closing the modal starts the next timer
wp_view_b.expect_and_dismiss_toaster message: I18n.t(:notice_successful_update)
@@ -129,26 +129,26 @@
end
end
- context 'when user has permission to log time' do
+ context "when user has permission to log time" do
let(:permissions) { %i[log_own_time edit_own_time_entries view_own_time_entries view_work_packages] }
- it_behaves_like 'allows time tracking'
+ it_behaves_like "allows time tracking"
- context 'when an old timer exists' do
+ context "when an old timer exists" do
let!(:active_timer) do
Timecop.travel(2.days.ago) do
create(:time_entry, project:, work_package: work_package_a, user:, ongoing: true)
end
end
- it 'correctly shows active timers > 24 hours' do
+ it "correctly shows active timers > 24 hours" do
wp_view_a.visit!
timer_button.expect_visible
timer_button.expect_time /48:0\d:\d+/
end
end
- it 'correctly handles timers in multiple tabs' do
+ it "correctly handles timers in multiple tabs" do
wp_view_a.visit!
timer_button.expect_visible
@@ -163,31 +163,31 @@
timer_button.expect_inactive
timer_button.start
- expect(page).to have_css('.op-timer-stop-modal')
- expect(page).to have_text('Tracking time:')
+ expect(page).to have_css(".op-timer-stop-modal")
+ expect(page).to have_text("Tracking time:")
- page.within('.spot-modal') { click_button 'Stop current timer' }
+ page.within(".spot-modal") { click_button "Stop current timer" }
time_logging_modal.is_visible true
- time_logging_modal.has_field_with_value 'spentOn', Date.current.strftime
- time_logging_modal.has_field_with_value 'hours', /(\d\.)?\d+/
+ time_logging_modal.has_field_with_value "spentOn", Date.current.strftime
+ time_logging_modal.has_field_with_value "hours", /(\d\.)?\d+/
time_logging_modal.work_package_is_missing false
# wait for available_work_packages query to finish before saving
time_logging_modal.expect_work_package(work_package_a.subject)
- time_logging_modal.perform_action 'Save'
+ time_logging_modal.perform_action "Save"
wp_view_b.expect_and_dismiss_toaster message: I18n.t(:notice_successful_update)
time_logging_modal.is_visible false
timer_button.expect_active
timer_button.stop
time_logging_modal.is_visible true
- time_logging_modal.has_field_with_value 'spentOn', Date.current.strftime
- time_logging_modal.has_field_with_value 'hours', /(\d\.)?\d+/
+ time_logging_modal.has_field_with_value "spentOn", Date.current.strftime
+ time_logging_modal.has_field_with_value "hours", /(\d\.)?\d+/
time_logging_modal.work_package_is_missing false
# wait for available_work_packages query to finish before saving
time_logging_modal.expect_work_package(work_package_a.subject)
- time_logging_modal.perform_action 'Save'
+ time_logging_modal.perform_action "Save"
wp_view_b.expect_and_dismiss_toaster message: I18n.t(:notice_successful_update)
time_logging_modal.is_visible false
timer_button.expect_inactive
@@ -195,32 +195,32 @@
within_window(second_window) do
timer_button.expect_active
timer_button.stop
- wp_view_b.expect_and_dismiss_toaster message: I18n.t('js.timer.timer_already_stopped'), type: :warning
+ wp_view_b.expect_and_dismiss_toaster message: I18n.t("js.timer.timer_already_stopped"), type: :warning
end
end
end
- context 'when user has no permission to log time' do
+ context "when user has no permission to log time" do
let(:permissions) { %i[view_work_packages] }
- it 'does not show the timer' do
+ it "does not show the timer" do
wp_view_a.visit!
# Wait for another button to be present
- expect(page).to have_css('#watch-button', wait: 10)
+ expect(page).to have_css("#watch-button", wait: 10)
timer_button.expect_visible visible: false
end
end
- context 'when user has permission to add, but not edit or view' do
+ context "when user has permission to add, but not edit or view" do
let(:permissions) { %i[view_work_packages log_own_time] }
- it_behaves_like 'allows time tracking'
+ it_behaves_like "allows time tracking"
end
- context 'when user has permission to add and view but not edit' do
+ context "when user has permission to add and view but not edit" do
let(:permissions) { %i[view_work_packages log_own_time view_own_logged_time] }
- it_behaves_like 'allows time tracking'
+ it_behaves_like "allows time tracking"
end
end
diff --git a/modules/costs/spec/features/users_hourly_rates_spec.rb b/modules/costs/spec/features/users_hourly_rates_spec.rb
index 7d0ab9012675..963c3ce5fcd3 100644
--- a/modules/costs/spec/features/users_hourly_rates_spec.rb
+++ b/modules/costs/spec/features/users_hourly_rates_spec.rb
@@ -26,80 +26,80 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative '../spec_helper'
+require_relative "../spec_helper"
-RSpec.describe 'hourly rates on user edit', :js do
+RSpec.describe "hourly rates on user edit", :js do
let(:user) { create(:admin) }
def view_rates
- visit edit_user_path(user, tab: 'rates')
+ visit edit_user_path(user, tab: "rates")
end
before do
login_as user
end
- context 'with no rates' do
+ context "with no rates" do
before do
view_rates
end
- it 'shows no data message' do
- expect(page).to have_text I18n.t('no_results_title_text')
+ it "shows no data message" do
+ expect(page).to have_text I18n.t("no_results_title_text")
end
end
- context 'with rates' do
+ context "with rates" do
let!(:rate) { create(:default_hourly_rate, user:) }
before do
view_rates
end
- it 'shows the rates' do
- expect(page).to have_text 'Current rate'.upcase
+ it "shows the rates" do
+ expect(page).to have_text "Current rate".upcase
end
- describe 'deleting all rates' do
+ describe "deleting all rates" do
before do
- click_link 'Update' # go to update view for rates
+ click_link "Update" # go to update view for rates
SeleniumHubWaiter.wait
- find('.icon-delete').click # delete last existing rate
- click_on 'Save' # save change
+ find(".icon-delete").click # delete last existing rate
+ click_on "Save" # save change
end
# regression test: clicking save used to result in a error
- it 'leads back to the now empty rate overview' do
+ it "leads back to the now empty rate overview" do
expect(page).to have_text /rate history/i
- expect(page).to have_text I18n.t('no_results_title_text')
+ expect(page).to have_text I18n.t("no_results_title_text")
- expect(page).to have_no_text 'Current rate'
+ expect(page).to have_no_text "Current rate"
end
end
end
- describe 'updating rates as German user', driver: :firefox_de do
- let(:user) { create(:admin, language: 'de') }
+ describe "updating rates as German user", driver: :firefox_de do
+ let(:user) { create(:admin, language: "de") }
let!(:rate) { create(:default_hourly_rate, user:, rate: 1.0) }
- it 'allows editing without reinterpreting the number (Regression #42219)' do
+ it "allows editing without reinterpreting the number (Regression #42219)" do
visit edit_hourly_rate_path(user)
# Expect the german locale output
- expect(page).to have_field("user[existing_rate_attributes][#{rate.id}][rate]", with: '1,00')
+ expect(page).to have_field("user[existing_rate_attributes][#{rate.id}][rate]", with: "1,00")
- click_link 'Satz hinzufügen'
+ click_link "Satz hinzufügen"
fill_in "user_new_rate_attributes_1_valid_from", with: (Time.zone.today + 1.day).iso8601
find("input#user_new_rate_attributes_1_valid_from").send_keys :escape
- fill_in "user_new_rate_attributes_1_rate", with: '5,12'
+ fill_in "user_new_rate_attributes_1_rate", with: "5,12"
- click_button 'Speichern'
+ click_button "Speichern"
view_rates
- expect(page).to have_css('.currency', text: '1,00')
- expect(page).to have_css('.currency', text: '5,12')
+ expect(page).to have_css(".currency", text: "1,00")
+ expect(page).to have_css(".currency", text: "5,12")
end
end
end
diff --git a/modules/costs/spec/features/view_own_rates_spec.rb b/modules/costs/spec/features/view_own_rates_spec.rb
index 89cc003c5ed6..ae9d5b4b798f 100644
--- a/modules/costs/spec/features/view_own_rates_spec.rb
+++ b/modules/costs/spec/features/view_own_rates_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper.rb")
-RSpec.describe 'Only see your own rates', :js do
+RSpec.describe "Only see your own rates", :js do
let(:project) { work_package.project }
let(:user) do
create(:user,
@@ -56,7 +56,7 @@
hours: 1.00)
end
let(:cost_type) do
- type = create(:cost_type, name: 'Translations')
+ type = create(:cost_type, name: "Translations")
create(:cost_rate, cost_type: type,
rate: 7.00)
type
@@ -107,12 +107,12 @@
wp_page.ensure_page_loaded
end
- it 'only displays own entries and rates' do
+ it "only displays own entries and rates" do
# All the values do not include the entries made by the other user
- wp_page.expect_attributes spent_time: '1 h',
- costs_by_type: '2 Translations',
- overall_costs: '24.00 EUR',
- labor_costs: '10.00 EUR',
- material_costs: '14.00 EUR'
+ wp_page.expect_attributes spent_time: "1 h",
+ costs_by_type: "2 Translations",
+ overall_costs: "24.00 EUR",
+ labor_costs: "10.00 EUR",
+ material_costs: "14.00 EUR"
end
end
diff --git a/modules/costs/spec/helpers/costs/number_helper_spec.rb b/modules/costs/spec/helpers/costs/number_helper_spec.rb
index b730277cc94b..757029578f54 100644
--- a/modules/costs/spec/helpers/costs/number_helper_spec.rb
+++ b/modules/costs/spec/helpers/costs/number_helper_spec.rb
@@ -26,54 +26,54 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.dirname(__FILE__) + '/../../spec_helper'
+require File.dirname(__FILE__) + "/../../spec_helper"
RSpec.describe Costs::NumberHelper do
- describe '#parse_number_string' do
- context 'with a german local' do
- it 'parses a string with delimiter and separator correctly' do
+ describe "#parse_number_string" do
+ context "with a german local" do
+ it "parses a string with delimiter and separator correctly" do
I18n.with_locale(:de) do
expect(helper.parse_number_string("123.456,78"))
.to eql "123456.78"
end
end
- it 'parses a string with space delimiter and separator correctly' do
+ it "parses a string with space delimiter and separator correctly" do
I18n.with_locale(:de) do
expect(helper.parse_number_string("123 456,78"))
.to eql "123456.78"
end
end
- it 'parses a string without delimiter and separator correctly' do
+ it "parses a string without delimiter and separator correctly" do
I18n.with_locale(:de) do
expect(helper.parse_number_string("12345678"))
.to eql "12345678"
end
end
- it 'parses a string without delimiter and with separator correctly' do
+ it "parses a string without delimiter and with separator correctly" do
I18n.with_locale(:de) do
expect(helper.parse_number_string("123456,78"))
.to eql "123456.78"
end
end
- it 'parses a string with delimiter and without separator correctly' do
+ it "parses a string with delimiter and without separator correctly" do
I18n.with_locale(:de) do
expect(helper.parse_number_string("12.345.678"))
.to eql "12345678"
end
end
- it 'parses a string with space delimiter and without separator correctly' do
+ it "parses a string with space delimiter and without separator correctly" do
I18n.with_locale(:de) do
expect(helper.parse_number_string("12 345 678"))
.to eql "12345678"
end
end
- it 'returns alphabetical values instead of a delimiter unchanged' do
+ it "returns alphabetical values instead of a delimiter unchanged" do
I18n.with_locale(:de) do
expect(helper.parse_number_string("123456a78"))
.to eql "123456a78"
@@ -81,50 +81,50 @@
end
end
- context 'with an english local' do
- it 'parses a string with delimiter and separator correctly' do
+ context "with an english local" do
+ it "parses a string with delimiter and separator correctly" do
I18n.with_locale(:en) do
expect(helper.parse_number_string("123,456.78"))
.to eql "123456.78"
end
end
- it 'parses a string with space delimiter and separator correctly' do
+ it "parses a string with space delimiter and separator correctly" do
I18n.with_locale(:en) do
expect(helper.parse_number_string("123 456.78"))
.to eql "123456.78"
end
end
- it 'parses a string without delimiter and separator correctly' do
+ it "parses a string without delimiter and separator correctly" do
I18n.with_locale(:en) do
expect(helper.parse_number_string("12345678"))
.to eql "12345678"
end
end
- it 'parses a string without delimiter and with separator correctly' do
+ it "parses a string without delimiter and with separator correctly" do
I18n.with_locale(:en) do
expect(helper.parse_number_string("123456.78"))
.to eql "123456.78"
end
end
- it 'parses a string with delimiter and without separator correctly' do
+ it "parses a string with delimiter and without separator correctly" do
I18n.with_locale(:en) do
expect(helper.parse_number_string("12,345,678"))
.to eql "12345678"
end
end
- it 'parses a string with space delimiter and without separator correctly' do
+ it "parses a string with space delimiter and without separator correctly" do
I18n.with_locale(:en) do
expect(helper.parse_number_string("12 345 678"))
.to eql "12345678"
end
end
- it 'returns alphabetical values instead of a delimiter unchanged' do
+ it "returns alphabetical values instead of a delimiter unchanged" do
I18n.with_locale(:en) do
expect(helper.parse_number_string("123456a78"))
.to eql "123456a78"
@@ -132,57 +132,57 @@
end
end
- context 'for nil' do
- it 'is nil' do
+ context "for nil" do
+ it "is nil" do
expect(helper.parse_number_string(nil))
.to be_nil
end
end
- context 'with a russian locale (Regression #37859)' do
- it 'parses a string with delimiter and separator correctly' do
+ context "with a russian locale (Regression #37859)" do
+ it "parses a string with delimiter and separator correctly" do
I18n.with_locale(:ru) do
expect(helper.parse_number_string("123.456,78"))
.to eql "123456.78"
end
end
- it 'parses a string with space delimiter and separator correctly' do
+ it "parses a string with space delimiter and separator correctly" do
I18n.with_locale(:de) do
expect(helper.parse_number_string("123 456,78"))
.to eql "123456.78"
end
end
- it 'parses a string without delimiter and separator correctly' do
+ it "parses a string without delimiter and separator correctly" do
I18n.with_locale(:de) do
expect(helper.parse_number_string("12345678"))
.to eql "12345678"
end
end
- it 'parses a string without delimiter and with separator correctly' do
+ it "parses a string without delimiter and with separator correctly" do
I18n.with_locale(:de) do
expect(helper.parse_number_string("123456,78"))
.to eql "123456.78"
end
end
- it 'parses a string with delimiter and without separator correctly' do
+ it "parses a string with delimiter and without separator correctly" do
I18n.with_locale(:de) do
expect(helper.parse_number_string("12.345.678"))
.to eql "12345678"
end
end
- it 'parses a string with space delimiter and without separator correctly' do
+ it "parses a string with space delimiter and without separator correctly" do
I18n.with_locale(:de) do
expect(helper.parse_number_string("12 345 678"))
.to eql "12345678"
end
end
- it 'returns alphabetical values instead of a delimiter unchanged' do
+ it "returns alphabetical values instead of a delimiter unchanged" do
I18n.with_locale(:de) do
expect(helper.parse_number_string("123456a78"))
.to eql "123456a78"
diff --git a/modules/costs/spec/lib/api/v3/cost_entries/aggregated_cost_entry_representer_spec.rb b/modules/costs/spec/lib/api/v3/cost_entries/aggregated_cost_entry_representer_spec.rb
index e8c9084cf3bf..90b8a41f6429 100644
--- a/modules/costs/spec/lib/api/v3/cost_entries/aggregated_cost_entry_representer_spec.rb
+++ b/modules/costs/spec/lib/api/v3/cost_entries/aggregated_cost_entry_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::CostEntries::AggregatedCostEntryRepresenter do
include API::V3::Utilities::PathHelper
@@ -36,17 +36,17 @@
subject { representer.to_json }
- it 'has a type' do
- expect(subject).to be_json_eql('AggregatedCostEntry'.to_json).at_path('_type')
+ it "has a type" do
+ expect(subject).to be_json_eql("AggregatedCostEntry".to_json).at_path("_type")
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'costType' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "costType" }
let(:href) { api_v3_paths.cost_type cost_entry.cost_type.id }
let(:title) { cost_entry.cost_type.name }
end
- it 'has spent units' do
- expect(subject).to be_json_eql(cost_entry.units.to_json).at_path('spentUnits')
+ it "has spent units" do
+ expect(subject).to be_json_eql(cost_entry.units.to_json).at_path("spentUnits")
end
end
diff --git a/modules/costs/spec/lib/api/v3/cost_entries/cost_entry_representer_spec.rb b/modules/costs/spec/lib/api/v3/cost_entries/cost_entry_representer_spec.rb
index 0ca7ee6cd398..4a2c101bf9ca 100644
--- a/modules/costs/spec/lib/api/v3/cost_entries/cost_entry_representer_spec.rb
+++ b/modules/costs/spec/lib/api/v3/cost_entries/cost_entry_representer_spec.rb
@@ -26,69 +26,69 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::CostEntries::CostEntryRepresenter do
include API::V3::Utilities::PathHelper
let(:cost_entry) { build_stubbed(:cost_entry) }
- let(:representer) { described_class.new(cost_entry, current_user: double('current_user')) }
+ let(:representer) { described_class.new(cost_entry, current_user: double("current_user")) }
subject { representer.to_json }
- it 'has a type' do
- expect(subject).to be_json_eql('CostEntry'.to_json).at_path('_type')
+ it "has a type" do
+ expect(subject).to be_json_eql("CostEntry".to_json).at_path("_type")
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.cost_entry cost_entry.id }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'project' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "project" }
let(:href) { api_v3_paths.project cost_entry.project.id }
let(:title) { cost_entry.project.name }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'user' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "user" }
let(:href) { api_v3_paths.user cost_entry.user_id }
let(:title) { cost_entry.user.name }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'costType' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "costType" }
let(:href) { api_v3_paths.cost_type cost_entry.cost_type.id }
let(:title) { cost_entry.cost_type.name }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'workPackage' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "workPackage" }
let(:href) { api_v3_paths.work_package cost_entry.work_package.id }
let(:title) { cost_entry.work_package.subject }
end
- it 'has an id' do
- expect(subject).to be_json_eql(cost_entry.id.to_json).at_path('id')
+ it "has an id" do
+ expect(subject).to be_json_eql(cost_entry.id.to_json).at_path("id")
end
- it 'has spent units' do
- expect(subject).to be_json_eql(cost_entry.units.to_json).at_path('spentUnits')
+ it "has spent units" do
+ expect(subject).to be_json_eql(cost_entry.units.to_json).at_path("spentUnits")
end
- it_behaves_like 'has ISO 8601 date only' do
+ it_behaves_like "has ISO 8601 date only" do
let(:date) { cost_entry.spent_on }
- let(:json_path) { 'spentOn' }
+ let(:json_path) { "spentOn" }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { cost_entry.created_at }
- let(:json_path) { 'createdAt' }
+ let(:json_path) { "createdAt" }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { cost_entry.updated_at }
- let(:json_path) { 'updatedAt' }
+ let(:json_path) { "updatedAt" }
end
end
diff --git a/modules/costs/spec/lib/api/v3/cost_entries/work_package_costs_by_type_representer_spec.rb b/modules/costs/spec/lib/api/v3/cost_entries/work_package_costs_by_type_representer_spec.rb
index a12c4df90c56..728e7cc2704b 100644
--- a/modules/costs/spec/lib/api/v3/cost_entries/work_package_costs_by_type_representer_spec.rb
+++ b/modules/costs/spec/lib/api/v3/cost_entries/work_package_costs_by_type_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::CostEntries::WorkPackageCostsByTypeRepresenter do
include API::V3::Utilities::PathHelper
@@ -66,25 +66,25 @@
cost_entries_B
end
- it 'has a type' do
- expect(subject).to be_json_eql('Collection'.to_json).at_path('_type')
+ it "has a type" do
+ expect(subject).to be_json_eql("Collection".to_json).at_path("_type")
end
- it 'has one element per type' do
- expect(subject).to have_json_size(2).at_path('_embedded/elements')
+ it "has one element per type" do
+ expect(subject).to have_json_size(2).at_path("_embedded/elements")
end
- it 'indicates the cost types' do
- elements = JSON.parse(subject)['_embedded']['elements']
- types = elements.map { |entry| entry['_links']['costType']['href'] }
+ it "indicates the cost types" do
+ elements = JSON.parse(subject)["_embedded"]["elements"]
+ types = elements.map { |entry| entry["_links"]["costType"]["href"] }
expect(types).to include(api_v3_paths.cost_type(cost_type_A.id))
expect(types).to include(api_v3_paths.cost_type(cost_type_B.id))
end
- it 'aggregates the units' do
- elements = JSON.parse(subject)['_embedded']['elements']
+ it "aggregates the units" do
+ elements = JSON.parse(subject)["_embedded"]["elements"]
units_by_type = elements.inject({}) do |hash, entry|
- hash[entry['_links']['costType']['href']] = entry['spentUnits']
+ hash[entry["_links"]["costType"]["href"]] = entry["spentUnits"]
hash
end
diff --git a/modules/costs/spec/lib/api/v3/cost_types/cost_type_representer_spec.rb b/modules/costs/spec/lib/api/v3/cost_types/cost_type_representer_spec.rb
index 4ff5b4b3aa06..26366d1ff24c 100644
--- a/modules/costs/spec/lib/api/v3/cost_types/cost_type_representer_spec.rb
+++ b/modules/costs/spec/lib/api/v3/cost_types/cost_type_representer_spec.rb
@@ -26,43 +26,43 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::CostTypes::CostTypeRepresenter do
include API::V3::Utilities::PathHelper
let(:cost_type) { build_stubbed(:cost_type) }
- let(:representer) { described_class.new(cost_type, current_user: double('current_user')) }
+ let(:representer) { described_class.new(cost_type, current_user: double("current_user")) }
subject { representer.to_json }
- it 'has a type' do
- expect(subject).to be_json_eql('CostType'.to_json).at_path('_type')
+ it "has a type" do
+ expect(subject).to be_json_eql("CostType".to_json).at_path("_type")
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.cost_type cost_type.id }
let(:title) { cost_type.name }
end
- it 'has an id' do
- expect(subject).to be_json_eql(cost_type.id.to_json).at_path('id')
+ it "has an id" do
+ expect(subject).to be_json_eql(cost_type.id.to_json).at_path("id")
end
- it 'has a name' do
- expect(subject).to be_json_eql(cost_type.name.to_json).at_path('name')
+ it "has a name" do
+ expect(subject).to be_json_eql(cost_type.name.to_json).at_path("name")
end
- it 'has a unit' do
- expect(subject).to be_json_eql(cost_type.unit.to_json).at_path('unit')
+ it "has a unit" do
+ expect(subject).to be_json_eql(cost_type.unit.to_json).at_path("unit")
end
- it 'has a pluralized unit' do
- expect(subject).to be_json_eql(cost_type.unit_plural.to_json).at_path('unitPlural')
+ it "has a pluralized unit" do
+ expect(subject).to be_json_eql(cost_type.unit_plural.to_json).at_path("unitPlural")
end
- it 'indicates if it is the default' do
- expect(subject).to be_json_eql(cost_type.default.to_json).at_path('isDefault')
+ it "indicates if it is the default" do
+ expect(subject).to be_json_eql(cost_type.default.to_json).at_path("isDefault")
end
end
diff --git a/modules/costs/spec/lib/api/v3/costs_api_user_permission_check_spec.rb b/modules/costs/spec/lib/api/v3/costs_api_user_permission_check_spec.rb
index fd9ae5bf6b41..97bbd1ff7878 100644
--- a/modules/costs/spec/lib/api/v3/costs_api_user_permission_check_spec.rb
+++ b/modules/costs/spec/lib/api/v3/costs_api_user_permission_check_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::CostsApiUserPermissionCheck do
class CostsApiUserPermissionCheckTestClass
@@ -69,188 +69,188 @@ def view_time_entries_allowed?
subject { CostsApiUserPermissionCheckTestClass.new }
- describe '#overall_costs_visible?' do
+ describe "#overall_costs_visible?" do
describe :overall_costs_visible? do
- shared_examples_for 'not visible' do
- it 'is not visible' do
+ shared_examples_for "not visible" do
+ it "is not visible" do
expect(subject).not_to be_overall_costs_visible
end
end
- shared_examples_for 'is visible' do
- it 'is not visible' do
+ shared_examples_for "is visible" do
+ it "is not visible" do
expect(subject).to be_overall_costs_visible
end
end
- context 'lacks permissions' do
- it_behaves_like 'not visible'
+ context "lacks permissions" do
+ it_behaves_like "not visible"
end
- context 'has view_time_entries and view_hourly_rates' do
+ context "has view_time_entries and view_hourly_rates" do
let(:view_time_entries) { true }
let(:view_hourly_rates) { true }
- it_behaves_like 'is visible'
+ it_behaves_like "is visible"
end
- context 'has view_time_entries and view_own_hourly_rate' do
+ context "has view_time_entries and view_own_hourly_rate" do
let(:view_time_entries) { true }
let(:view_own_hourly_rate) { true }
- it_behaves_like 'is visible'
+ it_behaves_like "is visible"
end
- context 'has view_own_time_entries and view_own_hourly_rate' do
+ context "has view_own_time_entries and view_own_hourly_rate" do
let(:view_own_time_entries) { true }
let(:view_own_hourly_rate) { true }
- it_behaves_like 'is visible'
+ it_behaves_like "is visible"
end
- context 'has view_own_time_entries and view_hourly_rates' do
+ context "has view_own_time_entries and view_hourly_rates" do
let(:view_own_time_entries) { true }
let(:view_hourly_rates) { true }
- it_behaves_like 'is visible'
+ it_behaves_like "is visible"
end
- context 'has view_cost_entries and view_cost_rates' do
+ context "has view_cost_entries and view_cost_rates" do
let(:view_cost_entries) { true }
let(:view_cost_rates) { true }
- it_behaves_like 'is visible'
+ it_behaves_like "is visible"
end
- context 'has view_own_cost_entries and view_cost_rates' do
+ context "has view_own_cost_entries and view_cost_rates" do
let(:view_cost_entries) { true }
let(:view_cost_rates) { true }
- it_behaves_like 'is visible'
+ it_behaves_like "is visible"
end
end
describe :labor_costs_visible? do
- shared_examples_for 'not visible' do
- it 'is not visible' do
+ shared_examples_for "not visible" do
+ it "is not visible" do
expect(subject).not_to be_labor_costs_visible
end
end
- shared_examples_for 'is visible' do
- it 'is not visible' do
+ shared_examples_for "is visible" do
+ it "is not visible" do
expect(subject).to be_labor_costs_visible
end
end
- context 'lacks permissions' do
- it_behaves_like 'not visible'
+ context "lacks permissions" do
+ it_behaves_like "not visible"
end
- context 'has view_time_entries and view_hourly_rates' do
+ context "has view_time_entries and view_hourly_rates" do
let(:view_time_entries) { true }
let(:view_hourly_rates) { true }
- it_behaves_like 'is visible'
+ it_behaves_like "is visible"
end
- context 'has view_own_time_entries and view_hourly_rates' do
+ context "has view_own_time_entries and view_hourly_rates" do
let(:view_own_time_entries) { true }
let(:view_hourly_rates) { true }
- it_behaves_like 'is visible'
+ it_behaves_like "is visible"
end
end
describe :material_costs_visible? do
- shared_examples_for 'not visible' do
- it 'is not visible' do
+ shared_examples_for "not visible" do
+ it "is not visible" do
expect(subject).not_to be_material_costs_visible
end
end
- shared_examples_for 'is visible' do
- it 'is not visible' do
+ shared_examples_for "is visible" do
+ it "is not visible" do
expect(subject).to be_material_costs_visible
end
end
- context 'lacks permissions' do
- it_behaves_like 'not visible'
+ context "lacks permissions" do
+ it_behaves_like "not visible"
end
- context 'has view_cost_entries and view_cost_rates' do
+ context "has view_cost_entries and view_cost_rates" do
let(:view_cost_entries) { true }
let(:view_cost_rates) { true }
- it_behaves_like 'is visible'
+ it_behaves_like "is visible"
end
- context 'has view_own_cost_entries and view_own_cost_rates' do
+ context "has view_own_cost_entries and view_own_cost_rates" do
let(:view_own_cost_entries) { true }
let(:view_cost_rates) { true }
- it_behaves_like 'is visible'
+ it_behaves_like "is visible"
end
end
describe :costs_by_type_visible? do
- shared_examples_for 'not visible' do
- it 'is not visible' do
+ shared_examples_for "not visible" do
+ it "is not visible" do
expect(subject).not_to be_costs_by_type_visible
end
end
- shared_examples_for 'is visible' do
- it 'is not visible' do
+ shared_examples_for "is visible" do
+ it "is not visible" do
expect(subject).to be_costs_by_type_visible
end
end
- context 'lacks permissions' do
- it_behaves_like 'not visible'
+ context "lacks permissions" do
+ it_behaves_like "not visible"
end
- context 'has view_costs_entries' do
+ context "has view_costs_entries" do
let(:view_cost_entries) { true }
- it_behaves_like 'is visible'
+ it_behaves_like "is visible"
end
- context 'has view_own_time_entries' do
+ context "has view_own_time_entries" do
let(:view_own_cost_entries) { true }
- it_behaves_like 'is visible'
+ it_behaves_like "is visible"
end
end
context :spent_time_visible do
- shared_examples_for 'not visible' do
- it 'is not visible' do
+ shared_examples_for "not visible" do
+ it "is not visible" do
expect(subject).not_to be_spent_time_visible
end
end
- shared_examples_for 'is visible' do
- it 'is not visible' do
+ shared_examples_for "is visible" do
+ it "is not visible" do
expect(subject).to be_spent_time_visible
end
end
- context 'lacks permissions' do
- it_behaves_like 'not visible'
+ context "lacks permissions" do
+ it_behaves_like "not visible"
end
- context 'has view_costs_entries' do
+ context "has view_costs_entries" do
let(:view_time_entries) { true }
- it_behaves_like 'is visible'
+ it_behaves_like "is visible"
end
- context 'has view_own_time_entries' do
+ context "has view_own_time_entries" do
let(:view_own_time_entries) { true }
- it_behaves_like 'is visible'
+ it_behaves_like "is visible"
end
end
end
diff --git a/modules/costs/spec/lib/api/v3/path_helper_spec.rb b/modules/costs/spec/lib/api/v3/path_helper_spec.rb
index 9b82261da053..b2273ad712bf 100644
--- a/modules/costs/spec/lib/api/v3/path_helper_spec.rb
+++ b/modules/costs/spec/lib/api/v3/path_helper_spec.rb
@@ -26,32 +26,32 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Utilities::PathHelper do
let(:helper) { Class.new.tap { |c| c.extend(described_class) }.api_v3_paths }
- describe '#cost_entry' do
+ describe "#cost_entry" do
subject { helper.cost_entry 42 }
- it { is_expected.to eql('/api/v3/cost_entries/42') }
+ it { is_expected.to eql("/api/v3/cost_entries/42") }
end
- describe '#cost_entries_by_work_package' do
+ describe "#cost_entries_by_work_package" do
subject { helper.cost_entries_by_work_package 42 }
- it { is_expected.to eql('/api/v3/work_packages/42/cost_entries') }
+ it { is_expected.to eql("/api/v3/work_packages/42/cost_entries") }
end
- describe '#summarized_work_package_costs_by_type' do
+ describe "#summarized_work_package_costs_by_type" do
subject { helper.summarized_work_package_costs_by_type 42 }
- it { is_expected.to eql('/api/v3/work_packages/42/summarized_costs_by_type') }
+ it { is_expected.to eql("/api/v3/work_packages/42/summarized_costs_by_type") }
end
- describe '#cost_type' do
+ describe "#cost_type" do
subject { helper.cost_type 42 }
- it { is_expected.to eql('/api/v3/cost_types/42') }
+ it { is_expected.to eql("/api/v3/cost_types/42") }
end
end
diff --git a/modules/costs/spec/lib/api/v3/time_entries/schemas/time_entry_schema_representer_spec.rb b/modules/costs/spec/lib/api/v3/time_entries/schemas/time_entry_schema_representer_spec.rb
index 2d07ba07d455..5cfe128a9ce8 100644
--- a/modules/costs/spec/lib/api/v3/time_entries/schemas/time_entry_schema_representer_spec.rb
+++ b/modules/costs/spec/lib/api/v3/time_entries/schemas/time_entry_schema_representer_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::TimeEntries::Schemas::TimeEntrySchemaRepresenter do
include API::V3::Utilities::PathHelper
let(:current_user) { build_stubbed(:user) }
- let(:self_link) { '/a/self/link' }
+ let(:self_link) { "/a/self/link" }
let(:embedded) { true }
let(:new_record) { true }
let(:project) { build_stubbed(:project) }
@@ -77,121 +77,121 @@
current_user:)
end
- context 'generation' do
+ context "generation" do
subject(:generated) { representer.to_json }
- describe '_type' do
- it 'is indicated as Schema' do
- expect(subject).to be_json_eql('Schema'.to_json).at_path('_type')
+ describe "_type" do
+ it "is indicated as Schema" do
+ expect(subject).to be_json_eql("Schema".to_json).at_path("_type")
end
end
- describe 'id' do
- let(:path) { 'id' }
+ describe "id" do
+ let(:path) { "id" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Integer' }
- let(:name) { I18n.t('attributes.id') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Integer" }
+ let(:name) { I18n.t("attributes.id") }
let(:required) { true }
let(:writable) { false }
end
end
- describe 'spentOn' do
- let(:path) { 'spentOn' }
+ describe "spentOn" do
+ let(:path) { "spentOn" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Date' }
- let(:name) { TimeEntry.human_attribute_name('spent_on') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Date" }
+ let(:name) { TimeEntry.human_attribute_name("spent_on") }
let(:required) { true }
let(:writable) { true }
end
end
- describe 'hours' do
- let(:path) { 'hours' }
+ describe "hours" do
+ let(:path) { "hours" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Duration' }
- let(:name) { TimeEntry.human_attribute_name('hours') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Duration" }
+ let(:name) { TimeEntry.human_attribute_name("hours") }
let(:required) { true }
let(:writable) { true }
end
end
- describe 'comment' do
- let(:path) { 'comment' }
+ describe "comment" do
+ let(:path) { "comment" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Formattable' }
- let(:name) { TimeEntry.human_attribute_name('comment') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Formattable" }
+ let(:name) { TimeEntry.human_attribute_name("comment") }
let(:required) { false }
let(:writable) { true }
end
end
- describe 'createdAt' do
- let(:path) { 'createdAt' }
+ describe "createdAt" do
+ let(:path) { "createdAt" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'DateTime' }
- let(:name) { TimeEntry.human_attribute_name('created_at') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "DateTime" }
+ let(:name) { TimeEntry.human_attribute_name("created_at") }
let(:required) { true }
let(:writable) { false }
end
end
- describe 'updatedAt' do
- let(:path) { 'updatedAt' }
+ describe "updatedAt" do
+ let(:path) { "updatedAt" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'DateTime' }
- let(:name) { TimeEntry.human_attribute_name('updated_at') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "DateTime" }
+ let(:name) { TimeEntry.human_attribute_name("updated_at") }
let(:required) { true }
let(:writable) { false }
end
end
- describe 'user' do
- let(:path) { 'user' }
+ describe "user" do
+ let(:path) { "user" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'User' }
- let(:name) { TimeEntry.human_attribute_name('user') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "User" }
+ let(:name) { TimeEntry.human_attribute_name("user") }
let(:required) { true }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
end
- describe 'work_package' do
- let(:path) { 'workPackage' }
+ describe "work_package" do
+ let(:path) { "workPackage" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'WorkPackage' }
- let(:name) { TimeEntry.human_attribute_name('work_package') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "WorkPackage" }
+ let(:name) { TimeEntry.human_attribute_name("work_package") }
let(:required) { false }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- context 'if embedding' do
+ context "if embedding" do
let(:embedded) { true }
- context 'if being a new record' do
+ context "if being a new record" do
let(:new_record) { true }
- it_behaves_like 'links to allowed values via collection link' do
+ it_behaves_like "links to allowed values via collection link" do
let(:href) do
api_v3_paths.time_entries_available_work_packages_on_create
end
end
end
- context 'if being an existing record' do
+ context "if being an existing record" do
let(:new_record) { false }
- it_behaves_like 'links to allowed values via collection link' do
+ it_behaves_like "links to allowed values via collection link" do
let(:href) do
api_v3_paths.time_entries_available_work_packages_on_edit(contract.id)
end
@@ -200,41 +200,41 @@
end
end
- describe 'activity' do
- let(:path) { 'activity' }
+ describe "activity" do
+ let(:path) { "activity" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'TimeEntriesActivity' }
- let(:name) { TimeEntry.human_attribute_name('activity') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "TimeEntriesActivity" }
+ let(:name) { TimeEntry.human_attribute_name("activity") }
let(:has_default) { true }
let(:required) { false }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- context 'if embedding' do
+ context "if embedding" do
let(:embedded) { true }
- it_behaves_like 'links to and embeds allowed values directly' do
+ it_behaves_like "links to and embeds allowed values directly" do
let(:hrefs) { [activity].map { |value| "/api/v3/time_entries/activities/#{value.id}" } }
end
end
- describe 'project' do
- let(:path) { 'project' }
+ describe "project" do
+ let(:path) { "project" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Project' }
- let(:name) { TimeEntry.human_attribute_name('project') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Project" }
+ let(:name) { TimeEntry.human_attribute_name("project") }
let(:required) { false }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- context 'if embedding' do
+ context "if embedding" do
let(:embedded) { true }
- it_behaves_like 'links to allowed values via collection link' do
+ it_behaves_like "links to allowed values via collection link" do
let(:href) do
api_v3_paths.time_entries_available_projects
end
@@ -242,27 +242,27 @@
end
end
- describe 'user' do
- let(:path) { 'user' }
+ describe "user" do
+ let(:path) { "user" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'User' }
- let(:name) { TimeEntry.human_attribute_name('user') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "User" }
+ let(:name) { TimeEntry.human_attribute_name("user") }
let(:required) { true }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- context 'if embedding' do
+ context "if embedding" do
let(:embedded) { true }
- it_behaves_like 'links to allowed values via collection link' do
+ it_behaves_like "links to allowed values via collection link" do
let(:href) do
api_v3_paths.path_for :principals,
filters: [
- { status: { operator: '!', values: [Principal.statuses[:locked].to_s] } },
- { type: { operator: '=', values: ['User'] } },
- { member: { operator: '=', values: [project.id] } }
+ { status: { operator: "!", values: [Principal.statuses[:locked].to_s] } },
+ { type: { operator: "=", values: ["User"] } },
+ { member: { operator: "=", values: [project.id] } }
]
end
end
@@ -270,7 +270,7 @@
end
end
- context 'for a custom value' do
+ context "for a custom value" do
let(:custom_field) { build_stubbed(:time_entry_custom_field) }
let(:path) { "customField#{custom_field.id}" }
let(:writable_attributes) { [custom_field.attribute_name] }
@@ -281,18 +281,18 @@
.and_return([custom_field])
end
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Formattable' }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Formattable" }
let(:name) { custom_field.name }
let(:required) { false }
let(:writable) { true }
end
- context 'with schema not writable' do
+ context "with schema not writable" do
let(:writable_attributes) { [] }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Formattable' }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Formattable" }
let(:name) { custom_field.name }
let(:required) { false }
let(:writable) { false }
diff --git a/modules/costs/spec/lib/api/v3/time_entries/time_entries_activity_representer_rendering_spec.rb b/modules/costs/spec/lib/api/v3/time_entries/time_entries_activity_representer_rendering_spec.rb
index 35a6dc56128b..70059edac66a 100644
--- a/modules/costs/spec/lib/api/v3/time_entries/time_entries_activity_representer_rendering_spec.rb
+++ b/modules/costs/spec/lib/api/v3/time_entries/time_entries_activity_representer_rendering_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::TimeEntries::TimeEntriesActivityRepresenter, 'rendering' do
+RSpec.describe API::V3::TimeEntries::TimeEntriesActivityRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
let(:activity) do
@@ -41,15 +41,15 @@
subject { representer.to_json }
- describe '_links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.time_entries_activity activity.id }
let(:title) { activity.name }
end
# returns the projects where it (and it's children) is active
- it_behaves_like 'has a link collection' do
+ it_behaves_like "has a link collection" do
let(:project1) { build_stubbed(:project) }
let(:project2) { build_stubbed(:project) }
@@ -61,7 +61,7 @@
project2])
end
- let(:link) { 'projects' }
+ let(:link) { "projects" }
let(:hrefs) do
[
{
@@ -77,24 +77,24 @@
end
end
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'TimeEntriesActivity' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "TimeEntriesActivity" }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { activity.id }
end
- it_behaves_like 'property', :name do
+ it_behaves_like "property", :name do
let(:value) { activity.name }
end
- it_behaves_like 'property', :position do
+ it_behaves_like "property", :position do
let(:value) { activity.position }
end
- it_behaves_like 'property', :default do
+ it_behaves_like "property", :default do
let(:value) { activity.is_default }
end
end
diff --git a/modules/costs/spec/lib/api/v3/time_entries/time_entry_representer_parsing_spec.rb b/modules/costs/spec/lib/api/v3/time_entries/time_entry_representer_parsing_spec.rb
index a3c236f5b7bc..e58f737819b2 100644
--- a/modules/costs/spec/lib/api/v3/time_entries/time_entry_representer_parsing_spec.rb
+++ b/modules/costs/spec/lib/api/v3/time_entries/time_entry_representer_parsing_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::TimeEntries::TimeEntryRepresenter, 'parsing' do
+RSpec.describe API::V3::TimeEntries::TimeEntryRepresenter, "parsing" do
include API::V3::Utilities::PathHelper
let(:time_entry) do
build_stubbed(:time_entry,
- comments: 'blubs',
+ comments: "blubs",
spent_on: Date.today - 3.days,
created_at: DateTime.now - 6.hours,
updated_at: DateTime.now - 3.hours,
@@ -76,7 +76,7 @@
"href" => api_v3_paths.user(user2.id)
}
},
- "hours" => 'PT5H',
+ "hours" => "PT5H",
"comment" => {
"raw" => "some comment"
},
@@ -93,33 +93,33 @@
.and_return([text_custom_field, user_custom_field])
end
- describe '_links' do
- context 'activity' do
- it 'updates the activity' do
+ describe "_links" do
+ context "activity" do
+ it "updates the activity" do
time_entry = representer.from_hash(hash)
expect(time_entry.activity_id)
.to eql(activity2.id)
end
end
- context 'project' do
- it 'updates the project' do
+ context "project" do
+ it "updates the project" do
time_entry = representer.from_hash(hash)
expect(time_entry.project_id)
.to eql(project2.id)
end
end
- context 'workPackage' do
- it 'updates the work_package' do
+ context "workPackage" do
+ it "updates the work_package" do
time_entry = representer.from_hash(hash)
expect(time_entry.work_package_id)
.to eql(work_package2.id)
end
end
- context 'linked custom field' do
- it 'updates the custom value' do
+ context "linked custom field" do
+ it "updates the custom value" do
time_entry = representer.from_hash(hash)
expect(time_entry.custom_field_values.detect { |cv| cv.custom_field_id == user_custom_field.id }.value)
@@ -128,30 +128,30 @@
end
end
- describe 'properties' do
- context 'spentOn' do
- it 'updates spent_on' do
+ describe "properties" do
+ context "spentOn" do
+ it "updates spent_on" do
time_entry = representer.from_hash(hash)
expect(time_entry.spent_on)
.to eql(Date.parse("2017-07-28"))
end
end
- context 'hours' do
- it 'updates hours' do
+ context "hours" do
+ it "updates hours" do
time_entry = representer.from_hash(hash)
expect(time_entry.hours)
.to be(5.0)
end
- context 'with null value' do
+ context "with null value" do
let(:hash) do
{
"hours" => nil
}
end
- it 'updates hours' do
+ it "updates hours" do
time_entry = representer.from_hash(hash)
expect(time_entry.hours)
.to be_nil
@@ -159,16 +159,16 @@
end
end
- context 'comment' do
- it 'updates comment' do
+ context "comment" do
+ it "updates comment" do
time_entry = representer.from_hash(hash)
expect(time_entry.comments)
- .to eql('some comment')
+ .to eql("some comment")
end
end
- context 'property custom field' do
- it 'updates the custom value' do
+ context "property custom field" do
+ it "updates the custom value" do
time_entry = representer.from_hash(hash)
expect(time_entry.custom_field_values.detect { |cv| cv.custom_field_id == text_custom_field.id }.value)
diff --git a/modules/costs/spec/lib/api/v3/time_entries/time_entry_representer_rendering_spec.rb b/modules/costs/spec/lib/api/v3/time_entries/time_entry_representer_rendering_spec.rb
index 156c53449aa3..14a31c07a416 100644
--- a/modules/costs/spec/lib/api/v3/time_entries/time_entry_representer_rendering_spec.rb
+++ b/modules/costs/spec/lib/api/v3/time_entries/time_entry_representer_rendering_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::TimeEntries::TimeEntryRepresenter, 'rendering' do
+RSpec.describe API::V3::TimeEntries::TimeEntryRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
let(:time_entry) do
build_stubbed(:time_entry,
- comments: 'blubs',
+ comments: "blubs",
spent_on: Date.today,
created_at: DateTime.now - 6.hours,
updated_at: DateTime.now - 3.hours,
@@ -68,52 +68,52 @@
.and_return([])
end
- include_context 'eager loaded work package representer'
+ include_context "eager loaded work package representer"
- describe '_links' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.time_entry time_entry.id }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'project' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "project" }
let(:href) { api_v3_paths.project project.id }
let(:title) { project.name }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'workPackage' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "workPackage" }
let(:href) { api_v3_paths.work_package work_package.id }
let(:title) { work_package.subject }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'user' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "user" }
let(:href) { api_v3_paths.user user.id }
let(:title) { user.name }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'activity' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "activity" }
let(:href) { api_v3_paths.time_entries_activity activity.id }
let(:title) { activity.name }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'schema' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "schema" }
let(:href) { api_v3_paths.time_entry_schema }
end
- context 'custom value' do
+ context "custom value" do
let(:custom_field) do
build_stubbed(:time_entry_custom_field, :user)
end
let(:custom_value) do
- double('CustomValue',
+ double("CustomValue",
custom_field:,
customized: time_entry,
- value: '1',
+ value: "1",
typed_value: user)
end
let(:user) do
@@ -135,131 +135,131 @@
.and_return(custom_value)
end
- it 'has the user linked' do
+ it "has the user linked" do
expect(subject)
.to be_json_eql(api_v3_paths.user(custom_value.value).to_json)
.at_path("_links/customField#{custom_field.id}/href")
end
end
- context 'when allowed to update' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'updateImmediately' }
+ context "when allowed to update" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "updateImmediately" }
let(:href) { api_v3_paths.time_entry(time_entry.id) }
let(:method) { :patch }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'update' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "update" }
let(:href) { api_v3_paths.time_entry_form(time_entry.id) }
let(:method) { :post }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'delete' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "delete" }
let(:href) { api_v3_paths.time_entry(time_entry.id) }
let(:method) { :delete }
end
end
- context 'when not allowed to update' do
+ context "when not allowed to update" do
let(:permissions) { [] }
- it_behaves_like 'has no link' do
- let(:link) { 'updateImmediately' }
+ it_behaves_like "has no link" do
+ let(:link) { "updateImmediately" }
end
- it_behaves_like 'has no link' do
- let(:link) { 'update' }
+ it_behaves_like "has no link" do
+ let(:link) { "update" }
end
- it_behaves_like 'has no link' do
- let(:link) { 'delete' }
+ it_behaves_like "has no link" do
+ let(:link) { "delete" }
end
end
- context 'when allowed to edit own and it is own' do
+ context "when allowed to edit own and it is own" do
let(:permissions) { [:edit_own_time_entries] }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'updateImmediately' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "updateImmediately" }
let(:href) { api_v3_paths.time_entry(time_entry.id) }
let(:method) { :patch }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'delete' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "delete" }
let(:href) { api_v3_paths.time_entry(time_entry.id) }
let(:method) { :delete }
end
end
- context 'when allowed to edit own and it is not own' do
+ context "when allowed to edit own and it is not own" do
let(:permissions) { [:edit_own_time_entries] }
let(:current_user) { build_stubbed(:user) }
- it_behaves_like 'has no link' do
- let(:link) { 'updateImmediately' }
+ it_behaves_like "has no link" do
+ let(:link) { "updateImmediately" }
end
- it_behaves_like 'has no link' do
- let(:link) { 'delete' }
+ it_behaves_like "has no link" do
+ let(:link) { "delete" }
end
end
end
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'TimeEntry' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "TimeEntry" }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { time_entry.id }
end
- it_behaves_like 'formattable property', :comment do
+ it_behaves_like "formattable property", :comment do
let(:value) { time_entry.comments }
end
- context 'with an empty comment' do
+ context "with an empty comment" do
let(:time_entry) { build_stubbed(:time_entry) }
- it_behaves_like 'formattable property', :comment do
+ it_behaves_like "formattable property", :comment do
let(:value) { time_entry.comments }
end
end
- it_behaves_like 'date property', :spentOn do
+ it_behaves_like "date property", :spentOn do
let(:value) { time_entry.spent_on }
end
- context 'hours' do
- it_behaves_like 'property', :hours do
- let(:value) { 'PT5H' }
+ context "hours" do
+ it_behaves_like "property", :hours do
+ let(:value) { "PT5H" }
end
- context 'if hours are nil' do
+ context "if hours are nil" do
let(:hours) { nil }
- it_behaves_like 'property', :hours do
+ it_behaves_like "property", :hours do
let(:value) { nil }
end
end
end
- it_behaves_like 'datetime property', :createdAt do
+ it_behaves_like "datetime property", :createdAt do
let(:value) { time_entry.created_at }
end
- it_behaves_like 'datetime property', :updatedAt do
+ it_behaves_like "datetime property", :updatedAt do
let(:value) { time_entry.updated_at }
end
- context 'custom value' do
+ context "custom value" do
let(:custom_field) { build_stubbed(:time_entry_custom_field) }
let(:custom_value) do
CustomValue.new(custom_field:,
- value: '1234',
+ value: "1234",
customized: time_entry)
end
diff --git a/modules/costs/spec/lib/api/v3/work_packages/work_package_representer_spec.rb b/modules/costs/spec/lib/api/v3/work_packages/work_package_representer_spec.rb
index 2ac6a0fee9d6..0023e618db17 100644
--- a/modules/costs/spec/lib/api/v3/work_packages/work_package_representer_spec.rb
+++ b/modules/costs/spec/lib/api/v3/work_packages/work_package_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::WorkPackages::WorkPackageRepresenter do
include API::V3::Utilities::PathHelper
@@ -51,7 +51,7 @@
units: 3,
spent_on: Time.zone.today,
user:,
- comments: 'Entry 1')
+ comments: "Entry 1")
end
let(:cost_entry_2) do
create(:cost_entry,
@@ -60,7 +60,7 @@
units: 3,
spent_on: Time.zone.today,
user:,
- comments: 'Entry 2')
+ comments: "Entry 2")
end
let(:work_package) do
@@ -79,31 +79,31 @@
subject(:generated) { representer.to_json }
- describe 'generation' do
+ describe "generation" do
before do
cost_entry_1
cost_entry_2
end
- describe 'work_package' do
+ describe "work_package" do
# specifying as it used to be different
- it { is_expected.to have_json_path('spentTime') }
+ it { is_expected.to have_json_path("spentTime") }
- it { is_expected.not_to have_json_path('spentHours') }
+ it { is_expected.not_to have_json_path("spentHours") }
- it { is_expected.to have_json_path('overallCosts') }
+ it { is_expected.to have_json_path("overallCosts") }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'costsByType' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "costsByType" }
let(:href) { api_v3_paths.summarized_work_package_costs_by_type work_package.id }
end
- it 'embeds the costsByType' do
- expect(subject).to have_json_path('_embedded/costsByType')
+ it "embeds the costsByType" do
+ expect(subject).to have_json_path("_embedded/costsByType")
end
- describe 'spentTime' do
- context 'time entry with single hour' do
+ describe "spentTime" do
+ context "time entry with single hour" do
let(:time_entry) do
create(:time_entry,
project: work_package.project,
@@ -113,10 +113,10 @@
before { time_entry }
- it { is_expected.to be_json_eql('PT1H'.to_json).at_path('spentTime') }
+ it { is_expected.to be_json_eql("PT1H".to_json).at_path("spentTime") }
end
- context 'time entry with multiple hours' do
+ context "time entry with multiple hours" do
let(:time_entry) do
create(:time_entry,
project: work_package.project,
@@ -126,16 +126,16 @@
before { time_entry }
- it { is_expected.to be_json_eql('P1DT18H30M'.to_json).at_path('spentTime') }
+ it { is_expected.to be_json_eql("P1DT18H30M".to_json).at_path("spentTime") }
end
- context 'no view_time_entries permission' do
+ context "no view_time_entries permission" do
let(:additional_permissions) { [] }
- it { is_expected.not_to have_json_path('spentTime') }
+ it { is_expected.not_to have_json_path("spentTime") }
end
- context 'only view_own_time_entries permission' do
+ context "only view_own_time_entries permission" do
let(:user2) do
create(:user, member_with_permissions: { project => %i[view_own_time_entries view_work_packages] })
end
@@ -160,166 +160,166 @@
allow(User).to receive(:current).and_return(user2)
end
- it { is_expected.to be_json_eql('PT2H'.to_json).at_path('spentTime') }
+ it { is_expected.to be_json_eql("PT2H".to_json).at_path("spentTime") }
end
- context 'no time entry' do
- it { is_expected.to be_json_eql('PT0S'.to_json).at_path('spentTime') }
+ context "no time entry" do
+ it { is_expected.to be_json_eql("PT0S".to_json).at_path("spentTime") }
end
end
- describe 'laborCosts' do
+ describe "laborCosts" do
before do
allow(work_package).to receive(:labor_costs).and_return(6000.0)
end
- context 'with the :view_hourly_rates and :view_time_entries permission' do
+ context "with the :view_hourly_rates and :view_time_entries permission" do
let(:additional_permissions) { %i[view_hourly_rates view_time_entries] }
- it 'is expected to have a laborCosts attribute' do
- expect(subject).to be_json_eql('6,000.00 EUR'.to_json).at_path('laborCosts')
+ it "is expected to have a laborCosts attribute" do
+ expect(subject).to be_json_eql("6,000.00 EUR".to_json).at_path("laborCosts")
end
end
- context 'with the :view_own_hourly_rate and :view_own_time_entries permission' do
+ context "with the :view_own_hourly_rate and :view_own_time_entries permission" do
let(:additional_permissions) { %i[view_own_hourly_rate view_own_time_entries] }
- it 'is expected to have a laborCosts attribute' do
- expect(subject).to be_json_eql('6,000.00 EUR'.to_json).at_path('laborCosts')
+ it "is expected to have a laborCosts attribute" do
+ expect(subject).to be_json_eql("6,000.00 EUR".to_json).at_path("laborCosts")
end
end
- context 'without the user having permission' do
- it 'has no attribute' do
- expect(subject).not_to have_json_path('laborCosts')
+ context "without the user having permission" do
+ it "has no attribute" do
+ expect(subject).not_to have_json_path("laborCosts")
end
end
end
- describe 'materialCosts' do
+ describe "materialCosts" do
before do
allow(work_package).to receive(:material_costs).and_return(6000.0)
end
- context 'with the :view_own_cost_entries and :view_cost_rates permission' do
+ context "with the :view_own_cost_entries and :view_cost_rates permission" do
let(:additional_permissions) { %i[view_own_cost_entries view_cost_rates] }
- it 'is expected to have a materialCosts attribute' do
- expect(subject).to be_json_eql('6,000.00 EUR'.to_json).at_path('materialCosts')
+ it "is expected to have a materialCosts attribute" do
+ expect(subject).to be_json_eql("6,000.00 EUR".to_json).at_path("materialCosts")
end
end
- context 'with the :view_cost_entries and :view_cost_rates permission' do
+ context "with the :view_cost_entries and :view_cost_rates permission" do
let(:additional_permissions) { %i[view_cost_entries view_cost_rates] }
- it 'is expected to have a materialCosts attribute' do
- expect(subject).to be_json_eql('6,000.00 EUR'.to_json).at_path('materialCosts')
+ it "is expected to have a materialCosts attribute" do
+ expect(subject).to be_json_eql("6,000.00 EUR".to_json).at_path("materialCosts")
end
end
- context 'without the user having permission' do
+ context "without the user having permission" do
let(:additional_permissions) { [] }
- it 'has no attribute' do
- expect(subject).not_to have_json_path('materialCosts')
+ it "has no attribute" do
+ expect(subject).not_to have_json_path("materialCosts")
end
end
end
- describe 'overallCosts' do
+ describe "overallCosts" do
before do
allow(work_package).to receive(:overall_costs).and_return(6000.0)
end
- context 'with the :view_hourly_rates and :view_time_entries permission' do
+ context "with the :view_hourly_rates and :view_time_entries permission" do
let(:additional_permissions) { %i[view_hourly_rates view_time_entries] }
- it 'is expected to have a overallCosts attribute' do
- expect(subject).to be_json_eql('6,000.00 EUR'.to_json).at_path('overallCosts')
+ it "is expected to have a overallCosts attribute" do
+ expect(subject).to be_json_eql("6,000.00 EUR".to_json).at_path("overallCosts")
end
end
- context 'with the :view_own_hourly_rate and :view_own_time_entries permission' do
+ context "with the :view_own_hourly_rate and :view_own_time_entries permission" do
let(:additional_permissions) { %i[view_own_time_entries view_own_hourly_rate] }
- it 'is expected to have a overallCosts attribute' do
- expect(subject).to be_json_eql('6,000.00 EUR'.to_json).at_path('overallCosts')
+ it "is expected to have a overallCosts attribute" do
+ expect(subject).to be_json_eql("6,000.00 EUR".to_json).at_path("overallCosts")
end
end
- context 'with the :view_own_cost_entries and :view_cost_rates permission' do
+ context "with the :view_own_cost_entries and :view_cost_rates permission" do
let(:additional_permissions) { %i[view_own_cost_entries view_cost_rates] }
- it 'is expected to have a overallCosts attribute' do
- expect(subject).to be_json_eql('6,000.00 EUR'.to_json).at_path('overallCosts')
+ it "is expected to have a overallCosts attribute" do
+ expect(subject).to be_json_eql("6,000.00 EUR".to_json).at_path("overallCosts")
end
end
- context 'with the :view_cost_entries and :view_cost_rates permission' do
+ context "with the :view_cost_entries and :view_cost_rates permission" do
let(:additional_permissions) { %i[view_cost_entries view_cost_rates] }
- it 'is expected to have a overallCosts attribute' do
- expect(subject).to be_json_eql('6,000.00 EUR'.to_json).at_path('overallCosts')
+ it "is expected to have a overallCosts attribute" do
+ expect(subject).to be_json_eql("6,000.00 EUR".to_json).at_path("overallCosts")
end
end
- context 'without the user having permission' do
+ context "without the user having permission" do
let(:additional_permissions) { [] }
- it 'has no attribute' do
- expect(subject).not_to have_json_path('overallCosts')
+ it "has no attribute" do
+ expect(subject).not_to have_json_path("overallCosts")
end
end
end
end
end
- describe '_links' do
- describe 'move' do
- it_behaves_like 'has a titled action link' do
- let(:link) { 'logCosts' }
+ describe "_links" do
+ describe "move" do
+ it_behaves_like "has a titled action link" do
+ let(:link) { "logCosts" }
let(:href) { new_work_packages_cost_entry_path(work_package) }
let(:permission) { %i(log_costs log_own_costs) }
let(:title) { "Log costs on #{work_package.subject}" }
end
end
- describe 'timeEntries' do
- context 'with the :view_time_entries permission' do
+ describe "timeEntries" do
+ context "with the :view_time_entries permission" do
let(:additional_permissions) { %i[view_time_entries] }
- it 'has timeEntries link' do
- expect(subject).to have_json_path('_links/timeEntries/href')
+ it "has timeEntries link" do
+ expect(subject).to have_json_path("_links/timeEntries/href")
end
end
- context 'with the :view_own_time_entries permission' do
+ context "with the :view_own_time_entries permission" do
let(:additional_permissions) { %i[view_own_time_entries] }
- it 'has timeEnries link' do
- expect(subject).to have_json_path('_links/timeEntries/href')
+ it "has timeEnries link" do
+ expect(subject).to have_json_path("_links/timeEntries/href")
end
end
end
end
- describe 'costs module disabled' do
+ describe "costs module disabled" do
before do
allow(work_package).to receive(:costs_enabled?).and_return false
end
- describe 'work_package' do
- it { is_expected.to have_json_path('spentTime') }
+ describe "work_package" do
+ it { is_expected.to have_json_path("spentTime") }
- it { is_expected.not_to have_json_path('spentHours') }
+ it { is_expected.not_to have_json_path("spentHours") }
- describe 'embedded' do
- it { is_expected.not_to have_json_path('_embedded/summarizedCostEntries') }
+ describe "embedded" do
+ it { is_expected.not_to have_json_path("_embedded/summarizedCostEntries") }
end
end
- describe '_links' do
- it { is_expected.not_to have_json_path('_links/log_costs') }
+ describe "_links" do
+ it { is_expected.not_to have_json_path("_links/log_costs") }
end
end
end
diff --git a/modules/costs/spec/lib/api/v3/work_packages/work_package_schema_representer_spec.rb b/modules/costs/spec/lib/api/v3/work_packages/work_package_schema_representer_spec.rb
index a13c2887d09b..6604f7bf71e1 100644
--- a/modules/costs/spec/lib/api/v3/work_packages/work_package_schema_representer_spec.rb
+++ b/modules/costs/spec/lib/api/v3/work_packages/work_package_schema_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::WorkPackages::Schema::WorkPackageSchemaRepresenter do
let(:custom_field) { build(:custom_field) }
@@ -54,115 +54,115 @@
subject { representer.to_json }
- describe 'overallCosts' do
- context 'has the permissions' do
+ describe "overallCosts" do
+ context "has the permissions" do
before do
allow(project)
.to receive(:costs_enabled?)
.and_return(true)
end
- it_behaves_like 'has basic schema properties' do
- let(:path) { 'overallCosts' }
- let(:type) { 'String' }
- let(:name) { I18n.t('activerecord.attributes.work_package.overall_costs') }
+ it_behaves_like "has basic schema properties" do
+ let(:path) { "overallCosts" }
+ let(:type) { "String" }
+ let(:name) { I18n.t("activerecord.attributes.work_package.overall_costs") }
let(:required) { false }
let(:writable) { false }
end
end
- context 'lacks the permissions' do
+ context "lacks the permissions" do
before do
allow(project)
.to receive(:costs_enabled?)
.and_return(false)
end
- it { is_expected.not_to have_json_path('overallCosts') }
+ it { is_expected.not_to have_json_path("overallCosts") }
end
end
- describe 'laborCosts' do
- context 'has the permissions' do
+ describe "laborCosts" do
+ context "has the permissions" do
before do
allow(project)
.to receive(:costs_enabled?)
.and_return(true)
end
- it_behaves_like 'has basic schema properties' do
- let(:path) { 'laborCosts' }
- let(:type) { 'String' }
- let(:name) { I18n.t('activerecord.attributes.work_package.labor_costs') }
+ it_behaves_like "has basic schema properties" do
+ let(:path) { "laborCosts" }
+ let(:type) { "String" }
+ let(:name) { I18n.t("activerecord.attributes.work_package.labor_costs") }
let(:required) { false }
let(:writable) { false }
end
end
- context 'lacks the permissions' do
+ context "lacks the permissions" do
before do
allow(project)
.to receive(:costs_enabled?)
.and_return(false)
end
- it { is_expected.not_to have_json_path('laborCosts') }
+ it { is_expected.not_to have_json_path("laborCosts") }
end
end
- describe 'materialCosts' do
- context 'has the permissions' do
+ describe "materialCosts" do
+ context "has the permissions" do
before do
allow(project)
.to receive(:costs_enabled?)
.and_return(true)
end
- it_behaves_like 'has basic schema properties' do
- let(:path) { 'materialCosts' }
- let(:type) { 'String' }
- let(:name) { I18n.t('activerecord.attributes.work_package.material_costs') }
+ it_behaves_like "has basic schema properties" do
+ let(:path) { "materialCosts" }
+ let(:type) { "String" }
+ let(:name) { I18n.t("activerecord.attributes.work_package.material_costs") }
let(:required) { false }
let(:writable) { false }
end
end
- context 'lacks the permissions' do
+ context "lacks the permissions" do
before do
allow(project)
.to receive(:costs_enabled?)
.and_return(false)
end
- it { is_expected.not_to have_json_path('materialCosts') }
+ it { is_expected.not_to have_json_path("materialCosts") }
end
end
- describe 'costsByType' do
- context 'has the permissions' do
+ describe "costsByType" do
+ context "has the permissions" do
before do
allow(project)
.to receive(:costs_enabled?)
.and_return(true)
end
- it_behaves_like 'has basic schema properties' do
- let(:path) { 'costsByType' }
- let(:type) { 'Collection' }
- let(:name) { I18n.t('activerecord.attributes.work_package.spent_units') }
+ it_behaves_like "has basic schema properties" do
+ let(:path) { "costsByType" }
+ let(:type) { "Collection" }
+ let(:name) { I18n.t("activerecord.attributes.work_package.spent_units") }
let(:required) { false }
let(:writable) { false }
end
end
- context 'lacks the permissions' do
+ context "lacks the permissions" do
before do
allow(project)
.to receive(:costs_enabled?)
.and_return(false)
end
- it { is_expected.not_to have_json_path('costsByType') }
+ it { is_expected.not_to have_json_path("costsByType") }
end
end
end
diff --git a/modules/costs/spec/lib/costs/query_currency_select_spec.rb b/modules/costs/spec/lib/costs/query_currency_select_spec.rb
index dd706c91a10b..7973c40df8ed 100644
--- a/modules/costs/spec/lib/costs/query_currency_select_spec.rb
+++ b/modules/costs/spec/lib/costs/query_currency_select_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Costs::QueryCurrencySelect, type: :model do
let(:project) do
@@ -40,51 +40,51 @@
let(:costs_enabled) { true }
let(:column_name) { :material_costs }
- describe '.instances' do
+ describe ".instances" do
subject { described_class.instances(project).map(&:name) }
- context 'with costs enabled' do
- it 'returns the four costs columns' do
+ context "with costs enabled" do
+ it "returns the four costs columns" do
expect(subject)
.to match_array %i[budget material_costs labor_costs overall_costs]
end
end
- context 'with costs disabled' do
+ context "with costs disabled" do
let(:costs_enabled) { false }
- it 'returns no columns' do
+ it "returns no columns" do
expect(subject)
.to be_empty
end
end
- context 'with no context' do
- it 'returns the four costs columns' do
+ context "with no context" do
+ it "returns the four costs columns" do
expect(subject)
.to match_array %i[budget material_costs labor_costs overall_costs]
end
end
end
- context 'material_costs' do
- describe '#summable?' do
- it 'is true' do
+ context "material_costs" do
+ describe "#summable?" do
+ it "is true" do
expect(instance)
.to be_summable
end
end
- describe '#summable' do
- it 'is callable' do
+ describe "#summable" do
+ it "is callable" do
expect(instance.summable)
.to respond_to(:call)
end
# Not testing the results here, this is done by an integration test
- it 'returns an AR scope that has an id and a material_costs column' do
- query = double('query')
- result = double('result')
+ it "returns an AR scope that has an id and a material_costs column" do
+ query = double("query")
+ result = double("result")
allow(query)
.to receive(:results)
@@ -96,7 +96,7 @@
allow(query)
.to receive(:group_by_statement)
- .and_return('author_id')
+ .and_return("author_id")
expect(ActiveRecord::Base.connection.select_all(instance.summable.(query, true).to_sql).columns)
.to match_array %w(id material_costs)
@@ -104,26 +104,26 @@
end
end
- context 'labor_costs' do
+ context "labor_costs" do
let(:column_name) { :labor_costs }
- describe '#summable?' do
- it 'is true' do
+ describe "#summable?" do
+ it "is true" do
expect(instance)
.to be_summable
end
end
- describe '#summable' do
- it 'is callable' do
+ describe "#summable" do
+ it "is callable" do
expect(instance.summable)
.to respond_to(:call)
end
# Not testing the results here, this is done by an integration test
- it 'returns an AR scope that has an id and a labor_costs column' do
- query = double('query')
- result = double('result')
+ it "returns an AR scope that has an id and a labor_costs column" do
+ query = double("query")
+ result = double("result")
allow(query)
.to receive(:results)
@@ -135,7 +135,7 @@
allow(query)
.to receive(:group_by_statement)
- .and_return('author_id')
+ .and_return("author_id")
expect(ActiveRecord::Base.connection.select_all(instance.summable.(query, true).to_sql).columns)
.to match_array %w(id labor_costs)
diff --git a/modules/costs/spec/models/cost_entry_spec.rb b/modules/costs/spec/models/cost_entry_spec.rb
index 9bcccb733a3a..b1b593679186 100644
--- a/modules/costs/spec/models/cost_entry_spec.rb
+++ b/modules/costs/spec/models/cost_entry_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
RSpec.describe CostEntry do
include Cost::PluginSpecHelper
@@ -54,7 +54,7 @@
spent_on: date,
units:,
user:,
- comments: 'lorem')
+ comments: "lorem")
end
let(:cost_entry2) do
@@ -64,7 +64,7 @@
spent_on: date,
units:,
user:,
- comments: 'lorem')
+ comments: "lorem")
end
let(:cost_type) do
@@ -97,8 +97,8 @@
let(:units) { 5.0 }
let(:date) { Date.today }
- describe 'class' do
- describe '#visible' do
+ describe "class" do
+ describe "#visible" do
describe "WHEN having the view_cost_entries permission
WHEN querying for a project
WHEN a cost entry from another user is defined" do
@@ -149,20 +149,20 @@
end
end
- describe 'instance' do
- describe '#costs' do
+ describe "instance" do
+ describe "#costs" do
let(:fourth_rate) do
build(:cost_rate, valid_from: date - 1.day,
rate: 10000.0,
cost_type:)
end
- describe 'WHEN updating the number of units' do
+ describe "WHEN updating the number of units" do
before do
cost_entry.spent_on = first_rate.valid_from + 1.day
end
- it 'updates costs' do
+ it "updates costs" do
6.times do |units|
cost_entry.units = units
cost_entry.save!
@@ -171,7 +171,7 @@
end
end
- describe 'WHEN a new rate is added at the end' do
+ describe "WHEN a new rate is added at the end" do
before do
cost_entry.save!
fourth_rate.save!
@@ -181,7 +181,7 @@
it { expect(cost_entry.costs).to eq(fourth_rate.rate * cost_entry.units) }
end
- describe 'WHEN a new rate is added for the future' do
+ describe "WHEN a new rate is added for the future" do
before do
cost_entry.save!
fourth_rate.valid_from = date + 1.day
@@ -192,7 +192,7 @@
it { expect(cost_entry.costs).to eq(third_rate.rate * cost_entry.units) }
end
- describe 'WHEN a new rate is added in between' do
+ describe "WHEN a new rate is added in between" do
before do
cost_entry.save!
fourth_rate.valid_from = date - 3.days
@@ -203,7 +203,7 @@
it { expect(cost_entry.costs).to eq(third_rate.rate * cost_entry.units) }
end
- describe 'WHEN a rate is destroyed' do
+ describe "WHEN a rate is destroyed" do
before do
cost_entry.save!
third_rate.destroy
@@ -223,29 +223,29 @@
it { expect(cost_entry.costs).to eq(cost_entry.units * first_rate.rate) }
end
- describe 'WHEN spent on is changed' do
+ describe "WHEN spent on is changed" do
before do
cost_type.save!
cost_entry.save!
end
- it 'takes the then active rate to calculate' do
+ it "takes the then active rate to calculate" do
(5.days.ago.to_date..Date.today).each do |time|
cost_entry.spent_on = time
cost_entry.save!
rate = CostRate
- .where(['cost_type_id = ? AND valid_from <= ?',
+ .where(["cost_type_id = ? AND valid_from <= ?",
cost_entry.cost_type.id, cost_entry.spent_on])
- .order(Arel.sql('valid_from DESC')).first.rate
+ .order(Arel.sql("valid_from DESC")).first.rate
expect(cost_entry.costs).to eq(cost_entry.units * rate)
end
end
end
end
- describe '#overridden_costs' do
- describe 'WHEN overridden costs are seet' do
+ describe "#overridden_costs" do
+ describe "WHEN overridden costs are seet" do
let(:value) { rand(500) }
before do
@@ -256,8 +256,8 @@
end
end
- describe '#real_costs' do
- describe 'WHEN overridden cost are set' do
+ describe "#real_costs" do
+ describe "WHEN overridden cost are set" do
let(:value) { rand(500) }
before do
@@ -268,20 +268,20 @@
end
end
- describe '#valid' do
+ describe "#valid" do
before do
cost_entry.save!
end
it { expect(cost_entry).to be_valid }
- describe 'WHEN no cost_type is provided' do
+ describe "WHEN no cost_type is provided" do
before { cost_entry.cost_type = nil }
it { expect(cost_entry).not_to be_valid }
end
- describe 'WHEN no project is provided' do
+ describe "WHEN no project is provided" do
before do
cost_entry.project = nil
# unfortunately the project get's set to the work_package's project if no project is provided
@@ -292,31 +292,31 @@
it { expect(cost_entry).not_to be_valid }
end
- describe 'WHEN no work_package is provided' do
+ describe "WHEN no work_package is provided" do
before { cost_entry.work_package = nil }
it { expect(cost_entry).not_to be_valid }
end
- describe 'WHEN the work_package is not in the project' do
+ describe "WHEN the work_package is not in the project" do
before { cost_entry.work_package = work_package2 }
it { expect(cost_entry).not_to be_valid }
end
- describe 'WHEN no units are provided' do
+ describe "WHEN no units are provided" do
before { cost_entry.units = nil }
it { expect(cost_entry).not_to be_valid }
end
- describe 'WHEN no spent_on is provided' do
+ describe "WHEN no spent_on is provided" do
before { cost_entry.spent_on = nil }
it { expect(cost_entry).not_to be_valid }
end
- describe 'WHEN no user is provided' do
+ describe "WHEN no user is provided" do
before { cost_entry.user = nil }
it { expect(cost_entry).not_to be_valid }
@@ -339,15 +339,15 @@
it { expect(cost_entry).not_to be_valid }
end
- describe 'WHEN the cost_type is deleted' do
+ describe "WHEN the cost_type is deleted" do
before { cost_type.deleted_at = Date.new }
it { expect(cost_entry).not_to be_valid }
end
end
- describe '#user' do
- describe 'WHEN a non existing user is provided (i.e. the user has been deleted)' do
+ describe "#user" do
+ describe "WHEN a non existing user is provided (i.e. the user has been deleted)" do
before do
cost_entry.save!
user.destroy
@@ -356,25 +356,25 @@
it { expect(cost_entry.reload.user).to eq(DeletedUser.first) }
end
- describe 'WHEN an existing user is provided' do
+ describe "WHEN an existing user is provided" do
it { expect(cost_entry.user).to eq(user) }
end
end
- describe '#logged_by' do
- it 'validates' do
+ describe "#logged_by" do
+ it "validates" do
cost_entry.logged_by = nil
expect(cost_entry).not_to be_valid
expect(cost_entry.errors[:logged_by_id]).to be_present
end
- it 'sets logged_by from current user' do
+ it "sets logged_by from current user" do
entry = User.execute_as(user2) { described_class.new logged_by: user }
expect(entry.logged_by).to eq(user2)
end
end
- describe '#editable_by?' do
+ describe "#editable_by?" do
describe "WHEN the user has the edit_cost_entries permission
WHEN the cost entry is not created by the user" do
before do
@@ -429,7 +429,7 @@
end
end
- describe '#creatable_by?' do
+ describe "#creatable_by?" do
describe "WHEN the user has the log costs permission
WHEN the cost entry is not associated to the user" do
before do
@@ -476,7 +476,7 @@
end
end
- describe '#costs_visible_by?' do
+ describe "#costs_visible_by?" do
describe "WHEN the user has the view_cost_rates permission
WHEN the cost entry is not associated to the user" do
before do
diff --git a/modules/costs/spec/models/cost_type_spec.rb b/modules/costs/spec/models/cost_type_spec.rb
index 3a75cace79a7..2197cfc536fd 100644
--- a/modules/costs/spec/models/cost_type_spec.rb
+++ b/modules/costs/spec/models/cost_type_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb')
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper.rb")
RSpec.describe CostType do
let(:klass) { CostType }
let(:cost_type) do
- klass.new name: 'ct1',
- unit: 'singular',
- unit_plural: 'plural'
+ klass.new name: "ct1",
+ unit: "singular",
+ unit_plural: "plural"
end
before do
@@ -44,9 +44,9 @@
CostType.destroy_all
end
- describe 'class' do
- describe 'active' do
- describe 'WHEN a CostType instance is deleted' do
+ describe "class" do
+ describe "active" do
+ describe "WHEN a CostType instance is deleted" do
before do
cost_type.deleted_at = Time.now
cost_type.save!
@@ -55,7 +55,7 @@
it { expect(klass.active.size).to eq(0) }
end
- describe 'WHEN a CostType instance is not deleted' do
+ describe "WHEN a CostType instance is not deleted" do
before do
cost_type.save!
end
diff --git a/modules/costs/spec/models/default_hourly_rate_spec.rb b/modules/costs/spec/models/default_hourly_rate_spec.rb
index f562c0150b80..cded19f96852 100644
--- a/modules/costs/spec/models/default_hourly_rate_spec.rb
+++ b/modules/costs/spec/models/default_hourly_rate_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.dirname(__FILE__) + '/../spec_helper'
+require File.dirname(__FILE__) + "/../spec_helper"
RSpec.describe DefaultHourlyRate do
let(:project) { create(:project) }
@@ -36,8 +36,8 @@
user:)
end
- describe '#user' do
- describe 'WHEN an existing user is provided' do
+ describe "#user" do
+ describe "WHEN an existing user is provided" do
before do
rate.user = user
rate.save!
@@ -46,7 +46,7 @@
it { expect(rate.user).to eq(user) }
end
- describe 'WHEN a non existing user is provided (i.e. the user is deleted)' do
+ describe "WHEN a non existing user is provided (i.e. the user is deleted)" do
before do
rate.user = user
rate.save!
diff --git a/modules/costs/spec/models/hourly_rate_spec.rb b/modules/costs/spec/models/hourly_rate_spec.rb
index f877145e702b..24d1c776c455 100644
--- a/modules/costs/spec/models/hourly_rate_spec.rb
+++ b/modules/costs/spec/models/hourly_rate_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.dirname(__FILE__) + '/../spec_helper'
+require File.dirname(__FILE__) + "/../spec_helper"
RSpec.describe HourlyRate do
let(:project) { create(:project) }
@@ -36,8 +36,8 @@
user:)
end
- describe '#user' do
- describe 'WHEN an existing user is provided' do
+ describe "#user" do
+ describe "WHEN an existing user is provided" do
before do
rate.user = user
rate.save!
@@ -46,7 +46,7 @@
it { expect(rate.user).to eq(user) }
end
- describe 'WHEN a non existing user is provided (i.e. the user is deleted)' do
+ describe "WHEN a non existing user is provided (i.e. the user is deleted)" do
before do
rate.user = user
rate.save!
diff --git a/modules/costs/spec/models/permitted_params_spec.rb b/modules/costs/spec/models/permitted_params_spec.rb
index ab68171bcb49..8f9e6bf185f7 100644
--- a/modules/costs/spec/models/permitted_params_spec.rb
+++ b/modules/costs/spec/models/permitted_params_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path('../spec_helper', __dir__)
+require File.expand_path("../spec_helper", __dir__)
RSpec.describe PermittedParams do
let(:user) { build(:user) }
- shared_examples_for 'allows params' do
+ shared_examples_for "allows params" do
let(:params_key) { defined?(hash_key) ? hash_key : attribute }
let(:params) do
nested_params = if defined?(nested_key)
@@ -57,115 +57,115 @@
end
end
- describe '#cost_entry' do
+ describe "#cost_entry" do
let(:attribute) { :cost_entry }
- context 'comments' do
- let(:hash) { { 'comments' => 'blubs' } }
+ context "comments" do
+ let(:hash) { { "comments" => "blubs" } }
- it_behaves_like 'allows params'
+ it_behaves_like "allows params"
end
- context 'units' do
- let(:hash) { { 'units' => '5.0' } }
+ context "units" do
+ let(:hash) { { "units" => "5.0" } }
- it_behaves_like 'allows params'
+ it_behaves_like "allows params"
end
- context 'overridden_costs' do
- let(:hash) { { 'overridden_costs' => '5.0' } }
+ context "overridden_costs" do
+ let(:hash) { { "overridden_costs" => "5.0" } }
- it_behaves_like 'allows params'
+ it_behaves_like "allows params"
end
- context 'spent_on' do
- let(:hash) { { 'spent_on' => Date.today.to_s } }
+ context "spent_on" do
+ let(:hash) { { "spent_on" => Date.today.to_s } }
- it_behaves_like 'allows params'
+ it_behaves_like "allows params"
end
- context 'project_id' do
- let(:hash) { { 'project_id' => 42 } }
+ context "project_id" do
+ let(:hash) { { "project_id" => 42 } }
- it_behaves_like 'allows params' do
+ it_behaves_like "allows params" do
let(:allowed_params) { {} }
end
end
end
- describe '#cost_type' do
+ describe "#cost_type" do
let(:attribute) { :cost_type }
- context 'name' do
- let(:hash) { { 'name' => 'name_test' } }
+ context "name" do
+ let(:hash) { { "name" => "name_test" } }
- it_behaves_like 'allows params'
+ it_behaves_like "allows params"
end
- context 'unit' do
- let(:hash) { { 'unit' => 'unit_test' } }
+ context "unit" do
+ let(:hash) { { "unit" => "unit_test" } }
- it_behaves_like 'allows params'
+ it_behaves_like "allows params"
end
- context 'unit_plural' do
- let(:hash) { { 'unit_plural' => 'unit_plural_test' } }
+ context "unit_plural" do
+ let(:hash) { { "unit_plural" => "unit_plural_test" } }
- it_behaves_like 'allows params'
+ it_behaves_like "allows params"
end
- context 'default' do
- let(:hash) { { 'default' => 7 } }
+ context "default" do
+ let(:hash) { { "default" => 7 } }
- it_behaves_like 'allows params'
+ it_behaves_like "allows params"
end
- context 'new_rate_attributes' do
+ context "new_rate_attributes" do
let(:hash) do
- { 'new_rate_attributes' => { '0' => { 'valid_from' => '2013-05-08', 'rate' => '5002' },
- '1' => { 'valid_from' => '2013-05-10', 'rate' => '5004' } } }
+ { "new_rate_attributes" => { "0" => { "valid_from" => "2013-05-08", "rate" => "5002" },
+ "1" => { "valid_from" => "2013-05-10", "rate" => "5004" } } }
end
- it_behaves_like 'allows params'
+ it_behaves_like "allows params"
end
- context 'existing_rate_attributes' do
+ context "existing_rate_attributes" do
let(:hash) do
- { 'existing_rate_attributes' => { '9' => { 'valid_from' => '2013-05-05', 'rate' => '50.0' } } }
+ { "existing_rate_attributes" => { "9" => { "valid_from" => "2013-05-05", "rate" => "50.0" } } }
end
- it_behaves_like 'allows params'
+ it_behaves_like "allows params"
end
- context 'project_id' do
- let(:hash) { { 'project_id' => 42 } }
+ context "project_id" do
+ let(:hash) { { "project_id" => 42 } }
- it_behaves_like 'allows params' do
+ it_behaves_like "allows params" do
let(:allowed_params) { {} }
end
end
end
- describe '#user_rates' do
+ describe "#user_rates" do
let(:attribute) { :user_rates }
let(:hash_key) { :user }
- context 'new_rate_attributes' do
+ context "new_rate_attributes" do
let(:hash) do
- { 'new_rate_attributes' => { '0' => { 'valid_from' => '2013-05-08', 'rate' => '5002' },
- '1' => { 'valid_from' => '2013-05-10', 'rate' => '5004' } } }
+ { "new_rate_attributes" => { "0" => { "valid_from" => "2013-05-08", "rate" => "5002" },
+ "1" => { "valid_from" => "2013-05-10", "rate" => "5004" } } }
end
- it_behaves_like 'allows params'
+ it_behaves_like "allows params"
end
- context 'existing_rate_attributes' do
+ context "existing_rate_attributes" do
let(:hash) do
- { 'existing_rate_attributes' => { '0' => { 'valid_from' => '2013-05-08', 'rate' => '5002' },
- '1' => { 'valid_from' => '2013-05-10', 'rate' => '5004' } } }
+ { "existing_rate_attributes" => { "0" => { "valid_from" => "2013-05-08", "rate" => "5002" },
+ "1" => { "valid_from" => "2013-05-10", "rate" => "5004" } } }
end
- it_behaves_like 'allows params'
+ it_behaves_like "allows params"
end
end
end
diff --git a/modules/costs/spec/models/project/activity_spec.rb b/modules/costs/spec/models/project/activity_spec.rb
index 85b2fefc0d4c..2a3f92ac209d 100644
--- a/modules/costs/spec/models/project/activity_spec.rb
+++ b/modules/costs/spec/models/project/activity_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe Projects::Activity, 'costs' do
+RSpec.describe Projects::Activity, "costs" do
shared_let(:project) do
create(:project, :updated_a_long_time_ago)
end
@@ -54,8 +54,8 @@ def latest_activity
Project.with_latest_activity.find(project.id).latest_activity_at
end
- describe '.with_latest_activity' do
- it 'set project.latest_activity_at to the latest updated budget time' do
+ describe ".with_latest_activity" do
+ it "set project.latest_activity_at to the latest updated budget time" do
budget.update(updated_at: initial_time - 10.seconds)
budget2.update(updated_at: initial_time - 20.seconds)
@@ -63,7 +63,7 @@ def latest_activity
expect(latest_activity).to be_within(0.00001).of(budget.updated_at)
end
- it 'takes the time stamp of the latest activity across models' do
+ it "takes the time stamp of the latest activity across models" do
work_package.update(updated_at: initial_time - 10.seconds)
budget.update(updated_at: initial_time - 20.seconds)
diff --git a/modules/costs/spec/models/projects/scopes/activated_time_activity_spec.rb b/modules/costs/spec/models/projects/scopes/activated_time_activity_spec.rb
index 15c170ec234e..766d1e34ee69 100644
--- a/modules/costs/spec/models/projects/scopes/activated_time_activity_spec.rb
+++ b/modules/costs/spec/models/projects/scopes/activated_time_activity_spec.rb
@@ -26,55 +26,55 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Projects::Scopes::ActivatedTimeActivity do
let!(:activity) { create(:time_entry_activity) }
let!(:project) { create(:project) }
let!(:other_project) { create(:project) }
- describe '.activated_time_activity' do
+ describe ".activated_time_activity" do
subject { Project.activated_time_activity(activity) }
- context 'without project specific overrides' do
- context 'and being active' do
- it 'returns all projects' do
+ context "without project specific overrides" do
+ context "and being active" do
+ it "returns all projects" do
expect(subject)
.to contain_exactly(project, other_project)
end
end
- context 'and not being active' do
+ context "and not being active" do
before do
activity.update_attribute(:active, false)
end
- it 'returns no projects' do
+ it "returns no projects" do
expect(subject)
.to be_empty
end
end
end
- context 'with project specific overrides' do
+ context "with project specific overrides" do
before do
TimeEntryActivitiesProject.insert({ activity_id: activity.id, project_id: project.id, active: true })
TimeEntryActivitiesProject.insert({ activity_id: activity.id, project_id: other_project.id, active: false })
end
- context 'and being active' do
- it 'returns the project the activity is activated in' do
+ context "and being active" do
+ it "returns the project the activity is activated in" do
expect(subject)
.to contain_exactly(project)
end
end
- context 'and not being active' do
+ context "and not being active" do
before do
activity.update_attribute(:active, false)
end
- it 'returns only the projects the activity is activated in' do
+ it "returns only the projects the activity is activated in" do
expect(subject)
.to contain_exactly(project)
end
diff --git a/modules/costs/spec/models/projects/scopes/visible_with_activated_time_activity_spec.rb b/modules/costs/spec/models/projects/scopes/visible_with_activated_time_activity_spec.rb
index e8e900addbed..a40590eb3ec0 100644
--- a/modules/costs/spec/models/projects/scopes/visible_with_activated_time_activity_spec.rb
+++ b/modules/costs/spec/models/projects/scopes/visible_with_activated_time_activity_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Projects::Scopes::VisibleWithActivatedTimeActivity do
let!(:activity) { create(:time_entry_activity) }
@@ -54,68 +54,68 @@
login_as(current_user)
end
- describe '.fetch' do
+ describe ".fetch" do
subject { Project.visible_with_activated_time_activity(activity) }
- context 'without project specific overrides' do
- context 'and being active' do
- it 'returns all projects' do
+ context "without project specific overrides" do
+ context "and being active" do
+ it "returns all projects" do
expect(subject)
.to contain_exactly(project, other_project)
end
end
- context 'and not being active' do
+ context "and not being active" do
before do
activity.update_attribute(:active, false)
end
- it 'returns no projects' do
+ it "returns no projects" do
expect(subject)
.to be_empty
end
end
- context 'and having only view_own_time_entries_permission' do
+ context "and having only view_own_time_entries_permission" do
let(:project_permissions) { [:view_own_time_entries] }
let(:other_project_permissions) { [:view_own_time_entries] }
- it 'returns all projects' do
+ it "returns all projects" do
expect(subject)
.to contain_exactly(project, other_project)
end
end
- context 'and having no view permission' do
+ context "and having no view permission" do
let(:project_permissions) { [] }
let(:other_project_permissions) { [] }
- it 'returns all projects' do
+ it "returns all projects" do
expect(subject)
.to be_empty
end
end
end
- context 'with project specific overrides' do
+ context "with project specific overrides" do
before do
TimeEntryActivitiesProject.insert({ activity_id: activity.id, project_id: project.id, active: true })
TimeEntryActivitiesProject.insert({ activity_id: activity.id, project_id: other_project.id, active: false })
end
- context 'and being active' do
- it 'returns the project the activity is activated in' do
+ context "and being active" do
+ it "returns the project the activity is activated in" do
expect(subject)
.to contain_exactly(project)
end
end
- context 'and not being active' do
+ context "and not being active" do
before do
activity.update_attribute(:active, false)
end
- it 'returns only the projects the activity is activated in' do
+ it "returns only the projects the activity is activated in" do
expect(subject)
.to contain_exactly(project)
end
diff --git a/modules/costs/spec/models/queries/time_entries/filters/activity_filter_spec.rb b/modules/costs/spec/models/queries/time_entries/filters/activity_filter_spec.rb
index ac46eced1358..666387bd0723 100644
--- a/modules/costs/spec/models/queries/time_entries/filters/activity_filter_spec.rb
+++ b/modules/costs/spec/models/queries/time_entries/filters/activity_filter_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Queries::TimeEntries::Filters::ActivityFilter do
let(:time_entry_activity1) { build_stubbed(:time_entry_activity) }
@@ -60,18 +60,18 @@
.and_return(activities.map { |x| [x.name, x.id] })
end
- it_behaves_like 'basic query filter' do
+ it_behaves_like "basic query filter" do
let(:class_key) { :activity_id }
let(:type) { :list_optional }
let(:name) { TimeEntry.human_attribute_name(:activity) }
- describe '#allowed_values' do
- it 'is a list of the possible values' do
+ describe "#allowed_values" do
+ it "is a list of the possible values" do
expect(instance.allowed_values).to match_array(activities.map { |x| [x.name, x.id] })
end
end
- it_behaves_like 'list_optional query filter' do
+ it_behaves_like "list_optional query filter" do
let(:attribute) { :activity_id }
let(:model) { TimeEntry }
let(:valid_values) { activities.map { |a| a.id.to_s } }
diff --git a/modules/costs/spec/models/queries/time_entries/filters/created_at_filter_spec.rb b/modules/costs/spec/models/queries/time_entries/filters/created_at_filter_spec.rb
index ba476e6dc20f..ec36d25d9d1b 100644
--- a/modules/costs/spec/models/queries/time_entries/filters/created_at_filter_spec.rb
+++ b/modules/costs/spec/models/queries/time_entries/filters/created_at_filter_spec.rb
@@ -26,25 +26,25 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Queries::TimeEntries::Filters::CreatedAtFilter do
- it_behaves_like 'basic query filter' do
+ it_behaves_like "basic query filter" do
let(:type) { :datetime_past }
let(:class_key) { :created_at }
- describe '#available?' do
- it 'is true' do
+ describe "#available?" do
+ it "is true" do
expect(instance).to be_available
end
end
- describe '#allowed_values' do
- it 'is nil' do
+ describe "#allowed_values" do
+ it "is nil" do
expect(instance.allowed_values).to be_nil
end
end
- it_behaves_like 'non ar filter'
+ it_behaves_like "non ar filter"
end
end
diff --git a/modules/costs/spec/models/queries/time_entries/filters/ongoing_filter_spec.rb b/modules/costs/spec/models/queries/time_entries/filters/ongoing_filter_spec.rb
index 4c53179f433f..59c5e8b6d58b 100644
--- a/modules/costs/spec/models/queries/time_entries/filters/ongoing_filter_spec.rb
+++ b/modules/costs/spec/models/queries/time_entries/filters/ongoing_filter_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Queries::TimeEntries::Filters::OngoingFilter do
- it_behaves_like 'boolean query filter' do
+ it_behaves_like "boolean query filter" do
let(:model) { TimeEntry }
let(:attribute) { :ongoing }
end
diff --git a/modules/costs/spec/models/queries/time_entries/filters/project_filter_spec.rb b/modules/costs/spec/models/queries/time_entries/filters/project_filter_spec.rb
index e788e562df3f..383f3651ab32 100644
--- a/modules/costs/spec/models/queries/time_entries/filters/project_filter_spec.rb
+++ b/modules/costs/spec/models/queries/time_entries/filters/project_filter_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Queries::TimeEntries::Filters::ProjectFilter do
let(:project1) { build_stubbed(:project) }
@@ -39,13 +39,13 @@
.and_return([project1.id, project2.id])
end
- it_behaves_like 'basic query filter' do
+ it_behaves_like "basic query filter" do
let(:class_key) { :project_id }
let(:type) { :list_optional }
let(:name) { TimeEntry.human_attribute_name(:project) }
- describe '#allowed_values' do
- it 'is a list of the possible values' do
+ describe "#allowed_values" do
+ it "is a list of the possible values" do
expected = [[project1.id, project1.id.to_s], [project2.id, project2.id.to_s]]
expect(instance.allowed_values).to match_array(expected)
@@ -53,7 +53,7 @@
end
end
- it_behaves_like 'list_optional query filter' do
+ it_behaves_like "list_optional query filter" do
let(:attribute) { :project_id }
let(:model) { TimeEntry }
let(:valid_values) { [project1.id.to_s] }
diff --git a/modules/costs/spec/models/queries/time_entries/filters/spent_on_filter_spec.rb b/modules/costs/spec/models/queries/time_entries/filters/spent_on_filter_spec.rb
index 2893d2ff1bd7..22fc82ba1b8d 100644
--- a/modules/costs/spec/models/queries/time_entries/filters/spent_on_filter_spec.rb
+++ b/modules/costs/spec/models/queries/time_entries/filters/spent_on_filter_spec.rb
@@ -26,26 +26,26 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Queries::TimeEntries::Filters::SpentOnFilter do
- it_behaves_like 'basic query filter' do
+ it_behaves_like "basic query filter" do
let(:type) { :date }
let(:class_key) { :spent_on }
let(:human_name) { TimeEntry.human_attribute_name :spent_on }
- describe '#available?' do
- it 'is true' do
+ describe "#available?" do
+ it "is true" do
expect(instance).to be_available
end
end
- describe '#allowed_values' do
- it 'is nil' do
+ describe "#allowed_values" do
+ it "is nil" do
expect(instance.allowed_values).to be_nil
end
end
- it_behaves_like 'non ar filter'
+ it_behaves_like "non ar filter"
end
end
diff --git a/modules/costs/spec/models/queries/time_entries/filters/updated_at_filter_spec.rb b/modules/costs/spec/models/queries/time_entries/filters/updated_at_filter_spec.rb
index e473154b70fa..596a965b5bc0 100644
--- a/modules/costs/spec/models/queries/time_entries/filters/updated_at_filter_spec.rb
+++ b/modules/costs/spec/models/queries/time_entries/filters/updated_at_filter_spec.rb
@@ -26,25 +26,25 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Queries::TimeEntries::Filters::UpdatedAtFilter do
- it_behaves_like 'basic query filter' do
+ it_behaves_like "basic query filter" do
let(:type) { :datetime_past }
let(:class_key) { :updated_at }
- describe '#available?' do
- it 'is true' do
+ describe "#available?" do
+ it "is true" do
expect(instance).to be_available
end
end
- describe '#allowed_values' do
- it 'is nil' do
+ describe "#allowed_values" do
+ it "is nil" do
expect(instance.allowed_values).to be_nil
end
end
- it_behaves_like 'non ar filter'
+ it_behaves_like "non ar filter"
end
end
diff --git a/modules/costs/spec/models/queries/time_entries/filters/user_filter_spec.rb b/modules/costs/spec/models/queries/time_entries/filters/user_filter_spec.rb
index aeea4cedeb29..113fbeeb8c67 100644
--- a/modules/costs/spec/models/queries/time_entries/filters/user_filter_spec.rb
+++ b/modules/costs/spec/models/queries/time_entries/filters/user_filter_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Queries::TimeEntries::Filters::UserFilter do
let(:user1) { build_stubbed(:user) }
@@ -39,13 +39,13 @@
.and_return([user1.id, user2.id])
end
- it_behaves_like 'basic query filter' do
+ it_behaves_like "basic query filter" do
let(:class_key) { :user_id }
let(:type) { :list_optional }
let(:name) { TimeEntry.human_attribute_name(:user) }
- describe '#allowed_values' do
- it 'is a list of the possible values' do
+ describe "#allowed_values" do
+ it "is a list of the possible values" do
expected = [[user1.id, user1.id.to_s], [user2.id, user2.id.to_s]]
expect(instance.allowed_values).to match_array(expected)
@@ -53,7 +53,7 @@
end
end
- it_behaves_like 'list_optional query filter' do
+ it_behaves_like "list_optional query filter" do
let(:attribute) { :user_id }
let(:model) { TimeEntry }
let(:instance_key) { :user_id }
diff --git a/modules/costs/spec/models/queries/time_entries/filters/work_package_filter_spec.rb b/modules/costs/spec/models/queries/time_entries/filters/work_package_filter_spec.rb
index 1fe0c4162d4d..339bb7ae7a9a 100644
--- a/modules/costs/spec/models/queries/time_entries/filters/work_package_filter_spec.rb
+++ b/modules/costs/spec/models/queries/time_entries/filters/work_package_filter_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Queries::TimeEntries::Filters::WorkPackageFilter do
let(:work_package1) { build_stubbed(:work_package) }
@@ -39,13 +39,13 @@
.and_return([work_package1.id, work_package2.id])
end
- it_behaves_like 'basic query filter' do
+ it_behaves_like "basic query filter" do
let(:class_key) { :work_package_id }
let(:type) { :list_optional }
let(:name) { TimeEntry.human_attribute_name(:work_package) }
- describe '#allowed_values' do
- it 'is a list of the possible values' do
+ describe "#allowed_values" do
+ it "is a list of the possible values" do
expected = [[work_package1.id, work_package1.id.to_s], [work_package2.id, work_package2.id.to_s]]
expect(instance.allowed_values).to match_array(expected)
@@ -53,7 +53,7 @@
end
end
- it_behaves_like 'list_optional query filter' do
+ it_behaves_like "list_optional query filter" do
let(:attribute) { :work_package_id }
let(:model) { TimeEntry }
let(:valid_values) { [work_package1.id.to_s] }
diff --git a/modules/costs/spec/models/queries/time_entries/time_entry_query_integration_spec.rb b/modules/costs/spec/models/queries/time_entries/time_entry_query_integration_spec.rb
index f98ddcfda3c0..4878dfc0611f 100644
--- a/modules/costs/spec/models/queries/time_entries/time_entry_query_integration_spec.rb
+++ b/modules/costs/spec/models/queries/time_entries/time_entry_query_integration_spec.rb
@@ -26,16 +26,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe Queries::TimeEntries::TimeEntryQuery, 'integration' do
+RSpec.describe Queries::TimeEntries::TimeEntryQuery, "integration" do
let(:instance) { described_class.new(user:) }
before do
login_as(user)
end
- context 'when using ongoing filter' do
+ context "when using ongoing filter" do
let(:project) { create(:project, enabled_module_names: %w[costs]) }
let(:user) { create(:user, member_with_permissions: { project => %i[log_own_time] }) }
let(:work_package) { create(:work_package, project:) }
@@ -45,21 +45,21 @@
let!(:user_timer) { create(:time_entry, user:, work_package:, ongoing: true) }
let!(:other_user_timer) { create(:time_entry, user: other_user, work_package: other_work_package, ongoing: true) }
- describe '#results' do
+ describe "#results" do
subject { instance.results }
before do
- instance.where('ongoing', '=', ['t'])
+ instance.where("ongoing", "=", ["t"])
end
- it 'only returns the users own time entries' do
+ it "only returns the users own time entries" do
expect(subject).to contain_exactly(user_timer)
end
- context 'when user has log_time permission' do
+ context "when user has log_time permission" do
let(:user) { create(:user, member_with_permissions: { project => %i[log_time] }) }
- it 'still returns the users own time entries' do
+ it "still returns the users own time entries" do
expect(subject).to contain_exactly(user_timer)
end
end
diff --git a/modules/costs/spec/models/queries/time_entries/time_entry_query_spec.rb b/modules/costs/spec/models/queries/time_entries/time_entry_query_spec.rb
index 5ab24076ad51..6bdf58284a91 100644
--- a/modules/costs/spec/models/queries/time_entries/time_entry_query_spec.rb
+++ b/modules/costs/spec/models/queries/time_entries/time_entry_query_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Queries::TimeEntries::TimeEntryQuery do
let(:user) { build_stubbed(:user) }
@@ -37,16 +37,16 @@
login_as(user)
end
- context 'without a filter' do
- describe '#results' do
- it 'is the same as getting all the time entries' do
+ context "without a filter" do
+ describe "#results" do
+ it "is the same as getting all the time entries" do
expect(instance.results.to_sql).to eql base_scope.to_sql
end
end
end
- context 'with a user filter' do
- let(:values) { ['1'] }
+ context "with a user filter" do
+ let(:values) { ["1"] }
before do
allow(Principal)
@@ -56,22 +56,22 @@
end
subject do
- instance.where('user_id', '=', values)
+ instance.where("user_id", "=", values)
instance
end
- describe '#results' do
- it 'is the same as handwriting the query' do
+ describe "#results" do
+ it "is the same as handwriting the query" do
expected = base_scope
.where(["time_entries.user_id IN (?)", values])
expect(subject.results.to_sql).to eql expected.to_sql
end
- context 'with a me value' do
- let(:values) { ['me'] }
+ context "with a me value" do
+ let(:values) { ["me"] }
- it 'replaces the value to produce the query' do
+ it "replaces the value to produce the query" do
expected = base_scope
.where(["time_entries.user_id IN (?)", [user.id.to_s]])
@@ -80,92 +80,92 @@
end
end
- describe '#valid?' do
- it 'is true' do
+ describe "#valid?" do
+ it "is true" do
expect(subject).to be_valid
end
- context 'with a me value and being logged in' do
- let(:values) { ['me'] }
+ context "with a me value and being logged in" do
+ let(:values) { ["me"] }
- it 'is valid' do
+ it "is valid" do
expect(subject).to be_valid
end
end
- context 'with not existing values' do
- let(:values) { [''] }
+ context "with not existing values" do
+ let(:values) { [""] }
- it 'is invalid' do
+ it "is invalid" do
expect(subject).to be_invalid
end
end
end
end
- context 'with a project filter' do
+ context "with a project filter" do
before do
allow(Project)
.to receive_message_chain(:visible, :pluck)
.with(:id)
.and_return([1])
- instance.where('project_id', '=', ['1'])
+ instance.where("project_id", "=", ["1"])
end
- describe '#results' do
- it 'is the same as handwriting the query' do
+ describe "#results" do
+ it "is the same as handwriting the query" do
expected = base_scope
- .where(["time_entries.project_id IN (?)", ['1']])
+ .where(["time_entries.project_id IN (?)", ["1"]])
expect(instance.results.to_sql).to eql expected.to_sql
end
end
- describe '#valid?' do
- it 'is true' do
+ describe "#valid?" do
+ it "is true" do
expect(instance).to be_valid
end
- it 'is invalid if the filter is invalid' do
- instance.where('project_id', '=', [''])
+ it "is invalid if the filter is invalid" do
+ instance.where("project_id", "=", [""])
expect(instance).to be_invalid
end
end
end
- context 'with a work_package filter' do
+ context "with a work_package filter" do
before do
allow(WorkPackage)
.to receive_message_chain(:visible, :pluck)
.with(:id)
.and_return([1])
- instance.where('work_package_id', '=', ['1'])
+ instance.where("work_package_id", "=", ["1"])
end
- describe '#results' do
- it 'is the same as handwriting the query' do
+ describe "#results" do
+ it "is the same as handwriting the query" do
expected = base_scope
- .where(["time_entries.work_package_id IN (?)", ['1']])
+ .where(["time_entries.work_package_id IN (?)", ["1"]])
expect(instance.results.to_sql).to eql expected.to_sql
end
end
- describe '#valid?' do
- it 'is true' do
+ describe "#valid?" do
+ it "is true" do
expect(instance).to be_valid
end
- it 'is invalid if the filter is invalid' do
- instance.where('work_package_id', '=', [''])
+ it "is invalid if the filter is invalid" do
+ instance.where("work_package_id", "=", [""])
expect(instance).to be_invalid
end
end
end
- context 'with an order by id asc' do
- describe '#results' do
- it 'returns all visible time entries ordered by id asc' do
+ context "with an order by id asc" do
+ describe "#results" do
+ it "returns all visible time entries ordered by id asc" do
expect(instance.order(id: :asc).results.to_sql)
.to eql base_scope.except(:order).order(id: :asc).to_sql
end
diff --git a/modules/costs/spec/models/rate_spec.rb b/modules/costs/spec/models/rate_spec.rb
index 42941ea18e9f..08c81878c32e 100644
--- a/modules/costs/spec/models/rate_spec.rb
+++ b/modules/costs/spec/models/rate_spec.rb
@@ -26,35 +26,35 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.dirname(__FILE__) + '/../spec_helper'
+require File.dirname(__FILE__) + "/../spec_helper"
RSpec.describe Rate do
let(:rate) { build(:rate) }
- describe '#valid?' do
- describe 'WHEN no rate is supplied' do
+ describe "#valid?" do
+ describe "WHEN no rate is supplied" do
before do
rate.rate = nil
end
- it 'is not valid' do
+ it "is not valid" do
expect(rate).not_to be_valid
- expect(rate.errors[:rate]).to eq([I18n.t('activerecord.errors.messages.not_a_number')])
+ expect(rate.errors[:rate]).to eq([I18n.t("activerecord.errors.messages.not_a_number")])
end
end
- describe 'WHEN no number is supplied' do
+ describe "WHEN no number is supplied" do
before do
- rate.rate = 'test'
+ rate.rate = "test"
end
- it 'is not valid' do
+ it "is not valid" do
expect(rate).not_to be_valid
- expect(rate.errors[:rate]).to eq([I18n.t('activerecord.errors.messages.not_a_number')])
+ expect(rate.errors[:rate]).to eq([I18n.t("activerecord.errors.messages.not_a_number")])
end
end
- describe 'WHEN a rate is supplied' do
+ describe "WHEN a rate is supplied" do
before do
rate.rate = 5.0
end
@@ -62,7 +62,7 @@
it { expect(rate).to be_valid }
end
- describe 'WHEN a date is supplied' do
+ describe "WHEN a date is supplied" do
before do
rate.valid_from = Date.today
end
@@ -70,33 +70,33 @@
it { expect(rate).to be_valid }
end
- describe 'WHEN a transformable string is supplied for date' do
+ describe "WHEN a transformable string is supplied for date" do
before do
- rate.valid_from = '2012-03-04'
+ rate.valid_from = "2012-03-04"
end
it { expect(rate).to be_valid }
end
- describe 'WHEN a nontransformable string is supplied for date' do
+ describe "WHEN a nontransformable string is supplied for date" do
before do
- rate.valid_from = '2012-02-30'
+ rate.valid_from = "2012-02-30"
end
- it 'is not valid' do
+ it "is not valid" do
expect(rate).not_to be_valid
- expect(rate.errors[:valid_from]).to eq([I18n.t('activerecord.errors.messages.not_a_date')])
+ expect(rate.errors[:valid_from]).to eq([I18n.t("activerecord.errors.messages.not_a_date")])
end
end
- describe 'WHEN no value is supplied for date' do
+ describe "WHEN no value is supplied for date" do
before do
rate.valid_from = nil
end
- it 'is not valid' do
+ it "is not valid" do
expect(rate).not_to be_valid
- expect(rate.errors[:valid_from]).to eq([I18n.t('activerecord.errors.messages.not_a_date')])
+ expect(rate.errors[:valid_from]).to eq([I18n.t("activerecord.errors.messages.not_a_date")])
end
end
end
diff --git a/modules/costs/spec/models/time_entries/scopes/of_user_and_day_spec.rb b/modules/costs/spec/models/time_entries/scopes/of_user_and_day_spec.rb
index 3629d96f1db5..971c84543c3d 100644
--- a/modules/costs/spec/models/time_entries/scopes/of_user_and_day_spec.rb
+++ b/modules/costs/spec/models/time_entries/scopes/of_user_and_day_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe TimeEntries::Scopes::OfUserAndDay do
let(:user) { create(:user) }
@@ -52,18 +52,18 @@
spent_on: spent_on - 3.days)
end
- describe '.of_user_and_day' do
+ describe ".of_user_and_day" do
subject { TimeEntry.of_user_and_day(user, spent_on) }
- it 'are all the time entries of the user on the date' do
+ it "are all the time entries of the user on the date" do
expect(subject)
.to contain_exactly(time_entry, other_time_entry)
end
- context 'if excluding a time entry' do
+ context "if excluding a time entry" do
subject { TimeEntry.of_user_and_day(user, spent_on, excluding: other_time_entry) }
- it 'does not include the time entry' do
+ it "does not include the time entry" do
expect(subject)
.to contain_exactly(time_entry)
end
diff --git a/modules/costs/spec/models/time_entries/scopes/visible_spec.rb b/modules/costs/spec/models/time_entries/scopes/visible_spec.rb
index cb142c4ea694..4074492b062d 100644
--- a/modules/costs/spec/models/time_entries/scopes/visible_spec.rb
+++ b/modules/costs/spec/models/time_entries/scopes/visible_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe TimeEntry, "visible scope" do
let(:project) { create(:project) }
@@ -59,22 +59,22 @@
user:)
end
- describe '.visible' do
+ describe ".visible" do
subject { TimeEntry.visible(user) }
- context 'for a user having the view_time_entries permission' do
+ context "for a user having the view_time_entries permission" do
let(:user) { create(:user, member_with_permissions: { project => [:view_time_entries] }) }
- it 'retrieves all the time entries of projects the user has the permissions in' do
+ it "retrieves all the time entries of projects the user has the permissions in" do
expect(subject)
.to contain_exactly(own_project_time_entry, project_time_entry)
end
end
- context 'for a user having the view_own_time_entries permission on a work package' do
+ context "for a user having the view_own_time_entries permission on a work package" do
let(:user) { create(:user, member_with_permissions: { work_package => [:view_own_time_entries] }) }
- it 'retrieves all the time entries of the user in projects the user has the permissions in' do
+ it "retrieves all the time entries of the user in projects the user has the permissions in" do
expect(subject)
.to contain_exactly(own_project_time_entry)
end
diff --git a/modules/costs/spec/models/time_entry_activities/scopes/active_in_project_spec.rb b/modules/costs/spec/models/time_entry_activities/scopes/active_in_project_spec.rb
index 0bdd14257c83..7178530473d2 100644
--- a/modules/costs/spec/models/time_entry_activities/scopes/active_in_project_spec.rb
+++ b/modules/costs/spec/models/time_entry_activities/scopes/active_in_project_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe TimeEntryActivities::Scopes::ActiveInProject do
let!(:activity) { create(:time_entry_activity) }
@@ -34,78 +34,78 @@
let(:project) { create(:project) }
let(:other_project) { create(:project) }
- describe '.active_in_project' do
+ describe ".active_in_project" do
subject { TimeEntryActivity.active_in_project(project) }
- context 'without a project configuration' do
- context 'with the activity being active' do
- it 'includes the activity' do
+ context "without a project configuration" do
+ context "with the activity being active" do
+ it "includes the activity" do
expect(subject)
.to contain_exactly(activity, other_activity)
end
end
- context 'with the activity being inactive' do
+ context "with the activity being inactive" do
before do
activity.update_attribute(:active, false)
end
- it 'excludes the activity' do
+ it "excludes the activity" do
expect(subject)
.to contain_exactly(other_activity)
end
end
end
- context 'with a project configuration configured to true' do
+ context "with a project configuration configured to true" do
before do
activity.time_entry_activities_projects.create(project:, active: true)
end
- it 'includes the activity' do
+ it "includes the activity" do
expect(subject)
.to contain_exactly(activity, other_activity)
end
- context 'with the activity being inactive' do
+ context "with the activity being inactive" do
before do
activity.update_attribute(:active, false)
end
- it 'includes the activity' do
+ it "includes the activity" do
expect(subject)
.to contain_exactly(activity, other_activity)
end
end
end
- context 'with a project configuration configured to false but for a different project' do
+ context "with a project configuration configured to false but for a different project" do
before do
activity.time_entry_activities_projects.create(project: other_project, active: false)
end
- it 'includes the activity' do
+ it "includes the activity" do
expect(subject)
.to contain_exactly(activity, other_activity)
end
end
- context 'with a project configuration configured to false' do
+ context "with a project configuration configured to false" do
before do
activity.time_entry_activities_projects.create(project:, active: false)
end
- it 'excludes the activity' do
+ it "excludes the activity" do
expect(subject)
.to contain_exactly(other_activity)
end
- context 'with a project configuration configured to true but for a different project' do
+ context "with a project configuration configured to true but for a different project" do
before do
activity.time_entry_activities_projects.create(project: other_project, active: true)
end
- it 'excludes the activity' do
+ it "excludes the activity" do
expect(subject)
.to contain_exactly(other_activity)
end
diff --git a/modules/costs/spec/models/time_entry_activity_spec.rb b/modules/costs/spec/models/time_entry_activity_spec.rb
index 3ab3cb3c1534..aab0ab419c92 100644
--- a/modules/costs/spec/models/time_entry_activity_spec.rb
+++ b/modules/costs/spec/models/time_entry_activity_spec.rb
@@ -26,19 +26,19 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe TimeEntryActivity do
let(:new_activity) { described_class.new }
- let(:saved_activity) { described_class.create name: 'Design' }
+ let(:saved_activity) { described_class.create name: "Design" }
- it 'is an enumeration' do
+ it "is an enumeration" do
expect(new_activity)
.to be_a(Enumeration)
end
- describe '#objects_count' do
- it 'represents the count of time entries of that activity' do
+ describe "#objects_count" do
+ it "represents the count of time entries of that activity" do
expect { create(:time_entry, activity: saved_activity) }
.to change(saved_activity, :objects_count)
.from(0)
@@ -46,8 +46,8 @@
end
end
- describe '#option_name' do
- it 'is enumeration_activities' do
+ describe "#option_name" do
+ it "is enumeration_activities" do
expect(new_activity.option_name)
.to eq :enumeration_activities
end
diff --git a/modules/costs/spec/models/time_entry_spec.rb b/modules/costs/spec/models/time_entry_spec.rb
index 71233c2f72e7..075d6f9956b0 100644
--- a/modules/costs/spec/models/time_entry_spec.rb
+++ b/modules/costs/spec/models/time_entry_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe TimeEntry do
let(:project) { create(:project_with_types, public: false) }
@@ -60,7 +60,7 @@
hours:,
user:,
rate: hourly_one,
- comments: 'lorem')
+ comments: "lorem")
end
let(:time_entry2) do
@@ -71,7 +71,7 @@
hours:,
user:,
rate: hourly_one,
- comments: 'lorem')
+ comments: "lorem")
end
def is_member(project, user, permissions)
@@ -81,23 +81,23 @@ def is_member(project, user, permissions)
roles: [create(:project_role, permissions:)])
end
- describe '#hours' do
- formats = { '2' => 2.0,
- '21.1' => 21.1,
- '2,1' => 2.1,
- '1,5h' => 1.5,
- '7:12' => 7.2,
- '10h' => 10.0,
- '10 h' => 10.0,
- '45m' => 0.75,
- '45 m' => 0.75,
- '3h15' => 3.25,
- '3h 15' => 3.25,
- '3 h 15' => 3.25,
- '3 h 15m' => 3.25,
- '3 h 15 m' => 3.25,
- '3 hours' => 3.0,
- '12min' => 0.2 }
+ describe "#hours" do
+ formats = { "2" => 2.0,
+ "21.1" => 21.1,
+ "2,1" => 2.1,
+ "1,5h" => 1.5,
+ "7:12" => 7.2,
+ "10h" => 10.0,
+ "10 h" => 10.0,
+ "45m" => 0.75,
+ "45 m" => 0.75,
+ "3h15" => 3.25,
+ "3h 15" => 3.25,
+ "3 h 15" => 3.25,
+ "3 h 15m" => 3.25,
+ "3 h 15 m" => 3.25,
+ "3 hours" => 3.0,
+ "12min" => 0.2 }
formats.each do |from, to|
it "formats '#{from}'" do
@@ -108,7 +108,7 @@ def is_member(project, user, permissions)
end
end
- it 'always prefers overridden_costs' do
+ it "always prefers overridden_costs" do
allow(User).to receive(:current).and_return(user)
value = rand(500)
@@ -118,13 +118,13 @@ def is_member(project, user, permissions)
time_entry.save!
end
- describe 'given rate' do
+ describe "given rate" do
before do
allow(User).to receive(:current).and_return(user)
@default_example = time_entry2
end
- it 'returns the current costs depending on the number of hours' do
+ it "returns the current costs depending on the number of hours" do
101.times do |hours|
time_entry.hours = hours
time_entry.save!
@@ -132,7 +132,7 @@ def is_member(project, user, permissions)
end
end
- it 'updates cost if a new rate is added at the end' do
+ it "updates cost if a new rate is added at the end" do
time_entry.user = User.current
time_entry.spent_on = Time.now
time_entry.hours = 1
@@ -149,7 +149,7 @@ def is_member(project, user, permissions)
expect(time_entry.costs).to eq(hourly.rate)
end
- it 'updates cost if a new rate is added in between' do
+ it "updates cost if a new rate is added in between" do
time_entry.user = User.current
time_entry.spent_on = 3.days.ago.to_date
time_entry.hours = 1
@@ -166,7 +166,7 @@ def is_member(project, user, permissions)
expect(time_entry.costs).to eq(hourly.rate)
end
- it 'updates cost if a spent_on changes' do
+ it "updates cost if a spent_on changes" do
time_entry.hours = 1
(5.days.ago.to_date..Date.today).each do |time|
time_entry.spent_on = time.to_date
@@ -175,7 +175,7 @@ def is_member(project, user, permissions)
end
end
- it 'updates cost if a rate is removed' do
+ it "updates cost if a rate is removed" do
time_entry.spent_on = hourly_one.valid_from
time_entry.hours = 1
time_entry.save!
@@ -188,7 +188,7 @@ def is_member(project, user, permissions)
expect(time_entry.costs).to eq(hourly_five.rate)
end
- it 'is able to change order of rates (sorted by valid_from)' do
+ it "is able to change order of rates (sorted by valid_from)" do
time_entry.spent_on = hourly_one.valid_from
time_entry.save!
expect(time_entry.rate).to eq(hourly_one)
@@ -199,13 +199,13 @@ def is_member(project, user, permissions)
end
end
- describe 'default rate' do
+ describe "default rate" do
before do
allow(User).to receive(:current).and_return(user)
@default_example = time_entry2
end
- it 'returns the current costs depending on the number of hours' do
+ it "returns the current costs depending on the number of hours" do
101.times do |hours|
@default_example.hours = hours
@default_example.save!
@@ -213,7 +213,7 @@ def is_member(project, user, permissions)
end
end
- it 'updates cost if a new rate is added at the end' do
+ it "updates cost if a new rate is added at the end" do
@default_example.user = user2
@default_example.spent_on = Time.now.to_date
@default_example.hours = 1
@@ -229,7 +229,7 @@ def is_member(project, user, permissions)
expect(@default_example.costs).to eq(hourly.rate)
end
- it 'updates cost if a new rate is added in between' do
+ it "updates cost if a new rate is added in between" do
@default_example.user = user2
@default_example.spent_on = 3.days.ago.to_date
@default_example.hours = 1
@@ -245,7 +245,7 @@ def is_member(project, user, permissions)
expect(@default_example.costs).to eq(hourly.rate)
end
- it 'updates cost if a spent_on changes' do
+ it "updates cost if a spent_on changes" do
@default_example.hours = 1
(5.days.ago.to_date..Date.today).each do |time|
@default_example.spent_on = time.to_date
@@ -254,7 +254,7 @@ def is_member(project, user, permissions)
end
end
- it 'updates cost if a rate is removed' do
+ it "updates cost if a rate is removed" do
@default_example.spent_on = default_hourly_one.valid_from
@default_example.hours = 1
@default_example.save!
@@ -267,7 +267,7 @@ def is_member(project, user, permissions)
expect(@default_example.costs).to eq(default_hourly_five.rate)
end
- it 'is able to switch between default hourly rate and hourly rate' do
+ it "is able to switch between default hourly rate and hourly rate" do
@default_example.user = user2
@default_example.rate = default_hourly_one
@default_example.save!
@@ -288,9 +288,9 @@ def is_member(project, user, permissions)
expect(@default_example.rate).to eq(default_hourly_one)
end
- describe '#costs_visible_by?' do
+ describe "#costs_visible_by?" do
before do
- project.enabled_module_names = project.enabled_module_names << 'costs'
+ project.enabled_module_names = project.enabled_module_names << "costs"
end
describe "WHEN the time_entry is assigned to the user
@@ -339,49 +339,49 @@ def is_member(project, user, permissions)
end
end
- describe 'visible_by?' do
- context 'when not having the necessary permissions' do
+ describe "visible_by?" do
+ context "when not having the necessary permissions" do
before do
is_member(project, user, [])
end
- it 'is visible' do
+ it "is visible" do
expect(time_entry.visible_by?(user)).to be_falsey
end
end
- context 'when having the view_time_entries permission' do
+ context "when having the view_time_entries permission" do
before do
is_member(project, user, [:view_time_entries])
end
- it 'is visible' do
+ it "is visible" do
expect(time_entry.visible_by?(user)).to be_truthy
end
end
- context 'when having the view_own_time_entries permission ' +
- 'and being the owner of the time entry' do
+ context "when having the view_own_time_entries permission " +
+ "and being the owner of the time entry" do
before do
is_member(project, user, [:view_own_time_entries])
time_entry.user = user
end
- it 'is visible' do
+ it "is visible" do
expect(time_entry.visible_by?(user)).to be_truthy
end
end
- context 'when having the view_own_time_entries permission ' +
- 'and not being the owner of the time entry' do
+ context "when having the view_own_time_entries permission " +
+ "and not being the owner of the time entry" do
before do
is_member(project, user, [:view_own_time_entries])
time_entry.user = build :user
end
- it 'is visible' do
+ it "is visible" do
expect(time_entry.visible_by?(user)).to be_falsey
end
end
diff --git a/modules/costs/spec/models/user_spec.rb b/modules/costs/spec/models/user_spec.rb
index 841f5df2d148..a46458f25834 100644
--- a/modules/costs/spec/models/user_spec.rb
+++ b/modules/costs/spec/models/user_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.dirname(__FILE__) + '/../spec_helper'
+require File.dirname(__FILE__) + "/../spec_helper"
RSpec.describe User do
include Cost::PluginSpecHelper
@@ -40,7 +40,7 @@
end
let(:default_hourly_rate) { build(:default_hourly_rate, user:) }
- describe '#allowed_to_condition_with_project_id' do
+ describe "#allowed_to_condition_with_project_id" do
let(:permission) { :view_own_time_entries }
before do
@@ -54,7 +54,7 @@
is_member(project, user, [permission])
end
- it 'returns a sql condition where the project id the user has the permission in is enforced' do
+ it "returns a sql condition where the project id the user has the permission in is enforced" do
expect(user.allowed_to_condition_with_project_id(permission)).to eq("(projects.id in (#{project.id}))")
end
end
@@ -66,7 +66,7 @@
is_member(project2, user, [permission])
end
- it 'returns a sql condition where all the project ids the user has the permission in is enforced' do
+ it "returns a sql condition where all the project ids the user has the permission in is enforced" do
# as order is not guaranteed and in fact does not matter
# we have to check for both valid options
valid_conditions = ["(projects.id in (#{project.id}, #{project2.id}))",
@@ -82,8 +82,8 @@
user.save!
end
- it 'returns a neutral (for an or operation) sql condition' do
- expect(user.allowed_to_condition_with_project_id(permission)).to eq('1=0')
+ it "returns a neutral (for an or operation) sql condition" do
+ expect(user.allowed_to_condition_with_project_id(permission)).to eq("1=0")
end
end
@@ -94,13 +94,13 @@
is_member(project2, user, [permission])
end
- it 'returns a sql condition where all the project ids the user has the permission in is enforced' do
+ it "returns a sql condition where all the project ids the user has the permission in is enforced" do
expect(user.allowed_to_condition_with_project_id(permission, project)).to eq("(projects.id in (#{project.id}))")
end
end
end
- describe '#set_existing_rates' do
+ describe "#set_existing_rates" do
before do
user.save
project.save
@@ -120,19 +120,19 @@
user.set_existing_rates(project, new_attributes)
end
- it 'updates the rate' do
+ it "updates the rate" do
expect(user.rates.detect do |r|
r.id == project_hourly_rate.id
end.rate).to eq(new_attributes[project_hourly_rate.id.to_s][:rate].to_i)
end
- it 'updates valid_from' do
+ it "updates valid_from" do
expect(user.rates.detect do |r|
r.id == project_hourly_rate.id
end.valid_from).to eq(new_attributes[project_hourly_rate.id.to_s][:valid_from].to_date)
end
- it 'does not create a rate' do
+ it "does not create a rate" do
expect(user.rates.size).to eq(1)
end
end
@@ -153,15 +153,15 @@
user.set_existing_rates(project2, new_attributes)
end
- it 'does not update the rate' do
+ it "does not update the rate" do
expect(user.rates.detect { |r| r.id == project_hourly_rate.id }.rate).to eq(@original_rate)
end
- it 'does not update valid_from' do
+ it "does not update valid_from" do
expect(user.rates.detect { |r| r.id == project_hourly_rate.id }.valid_from).to eq(@original_valid_from)
end
- it 'does not create a rate' do
+ it "does not create a rate" do
expect(user.rates.size).to eq(1)
end
end
@@ -175,7 +175,7 @@
user.set_existing_rates(project, {})
end
- it 'deletes the hourly rate' do
+ it "deletes the hourly rate" do
expect(user.rates.reload).to be_empty
end
end
@@ -189,7 +189,7 @@
user.set_existing_rates(nil, {})
end
- it 'deletes the default hourly rate' do
+ it "deletes the default hourly rate" do
expect(user.default_rates.reload).to be_empty
end
end
diff --git a/modules/costs/spec/models/work_package/ask_before_destruction_spec.rb b/modules/costs/spec/models/work_package/ask_before_destruction_spec.rb
index 2d933e057959..1d9f64935906 100644
--- a/modules/costs/spec/models/work_package/ask_before_destruction_spec.rb
+++ b/modules/costs/spec/models/work_package/ask_before_destruction_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WorkPackage do
let(:work_package) do
@@ -67,43 +67,43 @@
cost_type:)
end
- describe '#cleanup_action_required_before_destructing?' do
- describe 'w/ the work package having a cost entry' do
+ describe "#cleanup_action_required_before_destructing?" do
+ describe "w/ the work package having a cost entry" do
before do
work_package
cost_entry
end
- it 'is true' do
+ it "is true" do
expect(WorkPackage.cleanup_action_required_before_destructing?(work_package)).to be_truthy
end
end
- describe 'w/ two work packages having a cost entry' do
+ describe "w/ two work packages having a cost entry" do
before do
work_package
cost_entry
cost_entry2
end
- it 'is true' do
+ it "is true" do
expect(WorkPackage.cleanup_action_required_before_destructing?([work_package, work_package2])).to be_truthy
end
end
- describe 'w/o the work package having a cost entry' do
+ describe "w/o the work package having a cost entry" do
before do
work_package
end
- it 'is false' do
+ it "is false" do
expect(WorkPackage.cleanup_action_required_before_destructing?(work_package)).to be_falsey
end
end
end
- describe '#associated_classes_to_address_before_destructing?' do
- describe 'w/ the work package having a cost entry' do
+ describe "#associated_classes_to_address_before_destructing?" do
+ describe "w/ the work package having a cost entry" do
before do
work_package
cost_entry
@@ -114,44 +114,44 @@
end
end
- describe 'w/o the work package having a cost entry' do
+ describe "w/o the work package having a cost entry" do
before do
work_package
end
- it 'is empty' do
+ it "is empty" do
expect(WorkPackage.associated_classes_to_address_before_destruction_of(work_package)).to be_empty
end
end
end
- describe '#cleanup_associated_before_destructing_if_required' do
+ describe "#cleanup_associated_before_destructing_if_required" do
before do
work_package.save!
cost_entry
end
- describe 'w/o a cleanup being necessary' do
- let(:action) { WorkPackage.cleanup_associated_before_destructing_if_required(work_package, user, action: 'reassign') }
+ describe "w/o a cleanup being necessary" do
+ let(:action) { WorkPackage.cleanup_associated_before_destructing_if_required(work_package, user, action: "reassign") }
before do
cost_entry.destroy
end
- it 'returns true' do
+ it "returns true" do
expect(action).to be_truthy
end
end
describe 'w/ "destroy" as action' do
- let(:action) { WorkPackage.cleanup_associated_before_destructing_if_required(work_package, user, action: 'destroy') }
+ let(:action) { WorkPackage.cleanup_associated_before_destructing_if_required(work_package, user, action: "destroy") }
- it 'returns true' do
+ it "returns true" do
expect(action).to be_truthy
end
- it 'does not touch the cost_entry' do
+ it "does not touch the cost_entry" do
action
cost_entry.reload
@@ -159,14 +159,14 @@
end
end
- describe 'w/o an action' do
+ describe "w/o an action" do
let(:action) { WorkPackage.cleanup_associated_before_destructing_if_required(work_package, user) }
- it 'returns true' do
+ it "returns true" do
expect(action).to be_truthy
end
- it 'does not touch the cost_entry' do
+ it "does not touch the cost_entry" do
action
cost_entry.reload
@@ -175,30 +175,30 @@
end
describe 'w/ "nullify" as action' do
- let(:action) { WorkPackage.cleanup_associated_before_destructing_if_required(work_package, user, action: 'nullify') }
+ let(:action) { WorkPackage.cleanup_associated_before_destructing_if_required(work_package, user, action: "nullify") }
- it 'returns false' do
+ it "returns false" do
expect(action).to be_falsey
end
- it 'does not alter the work_package_id of all cost entries' do
+ it "does not alter the work_package_id of all cost entries" do
action
cost_entry.reload
expect(cost_entry.work_package_id).to eq(work_package.id)
end
- it 'sets an error on work packages' do
+ it "sets an error on work packages" do
action
- expect(work_package.errors[:base]).to eq([I18n.t(:'activerecord.errors.models.work_package.nullify_is_not_valid_for_cost_entries')])
+ expect(work_package.errors[:base]).to eq([I18n.t(:"activerecord.errors.models.work_package.nullify_is_not_valid_for_cost_entries")])
end
end
describe 'w/ "reassign" as action
w/ reassigning to a valid work_package' do
let(:action) do
- WorkPackage.cleanup_associated_before_destructing_if_required(work_package, user, action: 'reassign',
+ WorkPackage.cleanup_associated_before_destructing_if_required(work_package, user, action: "reassign",
reassign_to_id: work_package2.id)
end
@@ -209,11 +209,11 @@
member2.save!
end
- it 'returns true' do
+ it "returns true" do
expect(action).to be_truthy
end
- it 'sets the work_package_id of all cost entries to the new work package' do
+ it "sets the work_package_id of all cost entries to the new work package" do
action
cost_entry.reload
@@ -231,7 +231,7 @@
describe 'w/ "reassign" as action
w/ reassigning to a work_package the user is not allowed to see' do
let(:action) do
- WorkPackage.cleanup_associated_before_destructing_if_required(work_package, user, action: 'reassign',
+ WorkPackage.cleanup_associated_before_destructing_if_required(work_package, user, action: "reassign",
reassign_to_id: work_package2.id)
end
@@ -239,11 +239,11 @@
work_package2.save!
end
- it 'returns true' do
+ it "returns true" do
expect(action).to be_falsey
end
- it 'does not alter the work_package_id of all cost entries' do
+ it "does not alter the work_package_id of all cost entries" do
action
cost_entry.reload
@@ -254,14 +254,14 @@
describe 'w/ "reassign" as action
w/ reassigning to a non existing work package' do
let(:action) do
- WorkPackage.cleanup_associated_before_destructing_if_required(work_package, user, action: 'reassign', reassign_to_id: 0)
+ WorkPackage.cleanup_associated_before_destructing_if_required(work_package, user, action: "reassign", reassign_to_id: 0)
end
- it 'returns true' do
+ it "returns true" do
expect(action).to be_falsey
end
- it 'does not alter the work_package_id of all cost entries' do
+ it "does not alter the work_package_id of all cost entries" do
action
cost_entry.reload
@@ -271,13 +271,13 @@
describe 'w/ "reassign" as action
w/o providing a reassignment id' do
- let(:action) { WorkPackage.cleanup_associated_before_destructing_if_required(work_package, user, action: 'reassign') }
+ let(:action) { WorkPackage.cleanup_associated_before_destructing_if_required(work_package, user, action: "reassign") }
- it 'returns true' do
+ it "returns true" do
expect(action).to be_falsey
end
- it 'does not alter the work_package_id of all cost entries' do
+ it "does not alter the work_package_id of all cost entries" do
action
cost_entry.reload
@@ -285,18 +285,18 @@
end
end
- describe 'w/ an invalid option' do
- let(:action) { WorkPackage.cleanup_associated_before_destructing_if_required(work_package, user, action: 'bogus') }
+ describe "w/ an invalid option" do
+ let(:action) { WorkPackage.cleanup_associated_before_destructing_if_required(work_package, user, action: "bogus") }
- it 'returns false' do
+ it "returns false" do
expect(action).to be_falsey
end
end
- describe 'w/ nil as invalid option' do
+ describe "w/ nil as invalid option" do
let(:action) { WorkPackage.cleanup_associated_before_destructing_if_required(work_package, user, nil) }
- it 'returns false' do
+ it "returns false" do
expect(action).to be_falsey
end
end
diff --git a/modules/costs/spec/models/work_package_spec.rb b/modules/costs/spec/models/work_package_spec.rb
index dc4cf0f0e4aa..b86036bfd538 100644
--- a/modules/costs/spec/models/work_package_spec.rb
+++ b/modules/costs/spec/models/work_package_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
RSpec.describe WorkPackage do
let(:user) { create(:admin) }
@@ -43,7 +43,7 @@
end
let!(:cost_entry) do
create(:cost_entry, work_package:, project:, units: 3, spent_on: Date.today, user:,
- comments: 'test entry')
+ comments: "test entry")
end
let!(:budget) { create(:budget, project:) }
@@ -53,13 +53,13 @@ def move_to_project(work_package, project)
.call(project:)
end
- it 'updates cost entries on move' do
+ it "updates cost entries on move" do
expect(work_package.project_id).to eql project.id
expect(move_to_project(work_package, project2)).not_to be_falsey
expect(cost_entry.reload.project_id).to eql project2.id
end
- it 'allows to set budget to nil' do
+ it "allows to set budget to nil" do
work_package.budget = budget
work_package.save!
expect(work_package.budget).to eql budget
diff --git a/modules/costs/spec/requests/api/attachments/attachments_by_budget_resource_spec.rb b/modules/costs/spec/requests/api/attachments/attachments_by_budget_resource_spec.rb
index 96aa91cfd585..8c98d9a5b70e 100644
--- a/modules/costs/spec/requests/api/attachments/attachments_by_budget_resource_spec.rb
+++ b/modules/costs/spec/requests/api/attachments/attachments_by_budget_resource_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'requests/api/v3/attachments/attachment_resource_shared_examples'
+require "spec_helper"
+require "requests/api/v3/attachments/attachment_resource_shared_examples"
RSpec.describe "budget attachments" do
it_behaves_like "an APIv3 attachment resource" do
diff --git a/modules/costs/spec/requests/api/cost_entries/cost_entries_by_work_package_resource_spec.rb b/modules/costs/spec/requests/api/cost_entries/cost_entries_by_work_package_resource_spec.rb
index f3b28c961fc4..ea7587e9c5e5 100644
--- a/modules/costs/spec/requests/api/cost_entries/cost_entries_by_work_package_resource_spec.rb
+++ b/modules/costs/spec/requests/api/cost_entries/cost_entries_by_work_package_resource_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'API v3 Cost Entry resource' do
+RSpec.describe "API v3 Cost Entry resource" do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -57,57 +57,57 @@
get get_path
end
- describe 'work_packages/:id/cost_entries' do
+ describe "work_packages/:id/cost_entries" do
let(:get_path) { api_v3_paths.cost_entries_by_work_package work_package.id }
- context 'user can see any cost entries' do
- it 'returns HTTP 200' do
+ context "user can see any cost entries" do
+ it "returns HTTP 200" do
expect(response.status).to be(200)
end
end
- context 'user can see own cost entries' do
+ context "user can see own cost entries" do
let(:cost_entry_permissions) { [:view_own_cost_entries] }
- it 'returns HTTP 200' do
+ it "returns HTTP 200" do
expect(response.status).to be(200)
end
end
- context 'user has no cost entry permissions' do
+ context "user has no cost entry permissions" do
let(:cost_entry_permissions) { [] }
- it_behaves_like 'error response',
+ it_behaves_like "error response",
403,
- 'MissingPermission',
- I18n.t('api_v3.errors.code_403')
+ "MissingPermission",
+ I18n.t("api_v3.errors.code_403")
end
end
- describe 'work_packages/:id/summarized_costs_by_type' do
+ describe "work_packages/:id/summarized_costs_by_type" do
let(:get_path) { api_v3_paths.summarized_work_package_costs_by_type work_package.id }
- context 'user can see any cost entries' do
- it 'returns HTTP 200' do
+ context "user can see any cost entries" do
+ it "returns HTTP 200" do
expect(response.status).to be(200)
end
end
- context 'user can see own cost entries' do
+ context "user can see own cost entries" do
let(:cost_entry_permissions) { [:view_own_cost_entries] }
- it 'returns HTTP 200' do
+ it "returns HTTP 200" do
expect(response.status).to be(200)
end
end
- context 'user has no cost entry permissions' do
+ context "user has no cost entry permissions" do
let(:cost_entry_permissions) { [] }
- it_behaves_like 'error response',
+ it_behaves_like "error response",
403,
- 'MissingPermission',
- I18n.t('api_v3.errors.code_403')
+ "MissingPermission",
+ I18n.t("api_v3.errors.code_403")
end
end
end
diff --git a/modules/costs/spec/requests/api/cost_entries/cost_entry_resource_spec.rb b/modules/costs/spec/requests/api/cost_entries/cost_entry_resource_spec.rb
index 0a0c970cf9bf..5d7c81755513 100644
--- a/modules/costs/spec/requests/api/cost_entries/cost_entry_resource_spec.rb
+++ b/modules/costs/spec/requests/api/cost_entries/cost_entry_resource_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'API v3 Cost Entry resource' do
+RSpec.describe "API v3 Cost Entry resource" do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -49,54 +49,54 @@
get get_path
end
- describe 'cost_entries/:id' do
+ describe "cost_entries/:id" do
let(:get_path) { api_v3_paths.cost_entry cost_entry.id }
- context 'user can see cost entries' do
- context 'valid id' do
- it 'returns HTTP 200' do
+ context "user can see cost entries" do
+ context "valid id" do
+ it "returns HTTP 200" do
expect(response.status).to be(200)
end
end
- context 'invalid id' do
- let(:get_path) { api_v3_paths.cost_type 'bogus' }
+ context "invalid id" do
+ let(:get_path) { api_v3_paths.cost_type "bogus" }
- it_behaves_like 'param validation error' do
- let(:id) { 'bogus' }
+ it_behaves_like "param validation error" do
+ let(:id) { "bogus" }
end
end
end
- context 'user can only see own cost entries' do
+ context "user can only see own cost entries" do
let(:permissions) { [:view_own_cost_entries] }
- context 'cost entry is not his own' do
- it_behaves_like 'error response',
+ context "cost entry is not his own" do
+ it_behaves_like "error response",
403,
- 'MissingPermission',
- I18n.t('api_v3.errors.code_403')
+ "MissingPermission",
+ I18n.t("api_v3.errors.code_403")
end
- context 'cost entry is his own' do
+ context "cost entry is his own" do
let(:cost_entry) { create(:cost_entry, project:, user: current_user) }
- it 'returns HTTP 200' do
+ it "returns HTTP 200" do
expect(response.status).to be(200)
end
end
end
- context 'user has no cost entry permissions' do
+ context "user has no cost entry permissions" do
let(:permissions) { [] }
- describe 'he can\'t even see own cost entries' do
+ describe "he can't even see own cost entries" do
let(:cost_entry) { create(:cost_entry, project:, user: current_user) }
- it_behaves_like 'error response',
+ it_behaves_like "error response",
403,
- 'MissingPermission',
- I18n.t('api_v3.errors.code_403')
+ "MissingPermission",
+ I18n.t("api_v3.errors.code_403")
end
end
end
diff --git a/modules/costs/spec/requests/api/cost_types/cost_type_resource_spec.rb b/modules/costs/spec/requests/api/cost_types/cost_type_resource_spec.rb
index b57fd00b17fc..763b914271eb 100644
--- a/modules/costs/spec/requests/api/cost_types/cost_type_resource_spec.rb
+++ b/modules/costs/spec/requests/api/cost_types/cost_type_resource_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'API v3 Cost Type resource' do
+RSpec.describe "API v3 Cost Type resource" do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -48,38 +48,38 @@
get get_path
end
- describe 'cost_types/:id' do
+ describe "cost_types/:id" do
let(:get_path) { api_v3_paths.cost_type cost_type.id }
- context 'user can see cost entries' do
- context 'valid id' do
- it 'returns HTTP 200' do
+ context "user can see cost entries" do
+ context "valid id" do
+ it "returns HTTP 200" do
expect(response.status).to be(200)
end
end
- context 'cost type deleted' do
+ context "cost type deleted" do
let!(:cost_type) { create(:cost_type, :deleted) }
- it_behaves_like 'not found'
+ it_behaves_like "not found"
end
- context 'invalid id' do
- let(:get_path) { api_v3_paths.cost_type 'bogus' }
+ context "invalid id" do
+ let(:get_path) { api_v3_paths.cost_type "bogus" }
- it_behaves_like 'param validation error' do
- let(:id) { 'bogus' }
+ it_behaves_like "param validation error" do
+ let(:id) { "bogus" }
end
end
end
- context 'user can\'t see cost entries' do
+ context "user can't see cost entries" do
let(:current_user) { create(:user) }
- it_behaves_like 'error response',
+ it_behaves_like "error response",
403,
- 'MissingPermission',
- I18n.t('api_v3.errors.code_403')
+ "MissingPermission",
+ I18n.t("api_v3.errors.code_403")
end
end
end
diff --git a/modules/costs/spec/requests/api/time_entries/available_projects_resource_spec.rb b/modules/costs/spec/requests/api/time_entries/available_projects_resource_spec.rb
index 6a5e452e1afc..a78a0f94f092 100644
--- a/modules/costs/spec/requests/api/time_entries/available_projects_resource_spec.rb
+++ b/modules/costs/spec/requests/api/time_entries/available_projects_resource_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'API v3 time entries available projects resource' do
+RSpec.describe "API v3 time entries available projects resource" do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -87,7 +87,7 @@
subject(:response) { last_response }
- describe 'GET api/v3/time_entries/available_projects' do
+ describe "GET api/v3/time_entries/available_projects" do
let(:projects) do
[project_with_log_permission,
project_with_edit_permission,
@@ -106,40 +106,40 @@
get path
end
- it 'responds 200 OK' do
+ it "responds 200 OK" do
expect(subject.status).to eq(200)
end
- it 'returns a collection of projects containing only the ones for which the user has the necessary permissions' do
+ it "returns a collection of projects containing only the ones for which the user has the necessary permissions" do
expect(subject.body)
- .to be_json_eql('Collection'.to_json)
- .at_path('_type')
+ .to be_json_eql("Collection".to_json)
+ .at_path("_type")
expect(subject.body)
- .to be_json_eql('3')
- .at_path('total')
+ .to be_json_eql("3")
+ .at_path("total")
expect(subject.body)
.to be_json_eql(project_with_log_permission.id.to_json)
- .at_path('_embedded/elements/0/id')
+ .at_path("_embedded/elements/0/id")
expect(subject.body)
.to be_json_eql(project_with_edit_permission.id.to_json)
- .at_path('_embedded/elements/1/id')
+ .at_path("_embedded/elements/1/id")
expect(subject.body)
.to be_json_eql(project_with_edit_own_permission.id.to_json)
- .at_path('_embedded/elements/2/id')
+ .at_path("_embedded/elements/2/id")
end
- context 'without permissions' do
+ context "without permissions" do
let(:projects) do
[project_with_view_permission,
project_without_permission,
project_without_membership]
end
- it 'returns a 403' do
+ it "returns a 403" do
expect(subject.status)
.to eq(403)
end
diff --git a/modules/costs/spec/requests/api/time_entries/create_form_resource_spec.rb b/modules/costs/spec/requests/api/time_entries/create_form_resource_spec.rb
index 039f11e48472..fc326820b9ff 100644
--- a/modules/costs/spec/requests/api/time_entries/create_form_resource_spec.rb
+++ b/modules/costs/spec/requests/api/time_entries/create_form_resource_spec.rb
@@ -25,8 +25,8 @@
#
# See COPYRIGHT and LICENSE files for more details.
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
RSpec.describe API::V3::TimeEntries::CreateFormAPI, content_type: :json do
include Rack::Test::Methods
@@ -61,46 +61,46 @@
subject(:response) { last_response }
- describe '#POST /api/v3/time_entries/form' do
- it 'returns 200 OK' do
+ describe "#POST /api/v3/time_entries/form" do
+ it "returns 200 OK" do
expect(response.status).to eq(200)
end
- it 'returns a form' do
+ it "returns a form" do
expect(response.body)
- .to be_json_eql('Form'.to_json)
- .at_path('_type')
+ .to be_json_eql("Form".to_json)
+ .at_path("_type")
end
- it 'does not create a time_entry' do
+ it "does not create a time_entry" do
expect(TimeEntry.count)
.to be 0
end
- context 'with empty parameters' do
- it 'has 4 validation errors' do
- expect(subject.body).to have_json_size(3).at_path('_embedded/validationErrors')
+ context "with empty parameters" do
+ it "has 4 validation errors" do
+ expect(subject.body).to have_json_size(3).at_path("_embedded/validationErrors")
end
- it 'has a validation error on project' do
- expect(subject.body).to have_json_path('_embedded/validationErrors/project')
+ it "has a validation error on project" do
+ expect(subject.body).to have_json_path("_embedded/validationErrors/project")
end
- it 'has a validation error on spentOn' do
- expect(subject.body).to have_json_path('_embedded/validationErrors/spentOn')
+ it "has a validation error on spentOn" do
+ expect(subject.body).to have_json_path("_embedded/validationErrors/spentOn")
end
- it 'has a validation error on hours' do
- expect(subject.body).to have_json_path('_embedded/validationErrors/hours')
+ it "has a validation error on hours" do
+ expect(subject.body).to have_json_path("_embedded/validationErrors/hours")
end
- it 'has no commit link' do
+ it "has no commit link" do
expect(subject.body)
- .not_to have_json_path('_links/commit')
+ .not_to have_json_path("_links/commit")
end
end
- context 'with all parameters' do
+ context "with all parameters" do
let(:parameters) do
{
_links: {
@@ -115,38 +115,38 @@
}
},
spentOn: Date.today.to_s,
- hours: 'PT5H',
+ hours: "PT5H",
comment: {
raw: "some comment"
},
custom_field.attribute_name(:camel_case) => {
- raw: 'some cf text'
+ raw: "some cf text"
}
}
end
- it 'has 0 validation errors' do
- expect(subject.body).to have_json_size(0).at_path('_embedded/validationErrors')
+ it "has 0 validation errors" do
+ expect(subject.body).to have_json_size(0).at_path("_embedded/validationErrors")
end
- it 'has the values prefilled in the payload' do
+ it "has the values prefilled in the payload" do
body = subject.body
expect(body)
.to be_json_eql(api_v3_paths.project(project.id).to_json)
- .at_path('_embedded/payload/_links/project/href')
+ .at_path("_embedded/payload/_links/project/href")
expect(body)
.to be_json_eql(api_v3_paths.work_package(work_package.id).to_json)
- .at_path('_embedded/payload/_links/workPackage/href')
+ .at_path("_embedded/payload/_links/workPackage/href")
expect(body)
.to be_json_eql(api_v3_paths.time_entries_activity(active_activity.id).to_json)
- .at_path('_embedded/payload/_links/activity/href')
+ .at_path("_embedded/payload/_links/activity/href")
expect(body)
.to be_json_eql(api_v3_paths.user(user.id).to_json)
- .at_path('_embedded/payload/_links/user/href')
+ .at_path("_embedded/payload/_links/user/href")
expect(body)
.to be_json_eql("some comment".to_json)
@@ -154,52 +154,52 @@
expect(body)
.to be_json_eql(Date.today.to_s.to_json)
- .at_path('_embedded/payload/spentOn')
+ .at_path("_embedded/payload/spentOn")
expect(body)
.to be_json_eql("PT5H".to_json)
- .at_path('_embedded/payload/hours')
+ .at_path("_embedded/payload/hours")
expect(body)
.to be_json_eql("some cf text".to_json)
.at_path("_embedded/payload/customField#{custom_field.id}/raw")
end
- it 'has the available values listed in the schema' do
+ it "has the available values listed in the schema" do
body = subject.body
wp_path = api_v3_paths.time_entries_available_work_packages_on_create
expect(body)
.to be_json_eql(wp_path.to_json)
- .at_path('_embedded/schema/workPackage/_links/allowedValues/href')
+ .at_path("_embedded/schema/workPackage/_links/allowedValues/href")
expect(body)
.to be_json_eql(api_v3_paths.time_entries_available_projects.to_json)
- .at_path('_embedded/schema/project/_links/allowedValues/href')
+ .at_path("_embedded/schema/project/_links/allowedValues/href")
end
- it 'has a commit link' do
+ it "has a commit link" do
expect(subject.body)
.to be_json_eql(api_v3_paths.time_entries.to_json)
- .at_path('_links/commit/href')
+ .at_path("_links/commit/href")
end
end
- context 'without the necessary permission' do
+ context "without the necessary permission" do
let(:permissions) { [] }
- it 'returns 403 Not Authorized' do
+ it "returns 403 Not Authorized" do
expect(response.status).to eq(403)
end
end
- context 'without the log_time permisson' do
+ context "without the log_time permisson" do
let(:permissions) { %i[log_own_time view_work_packages] }
- it 'does not render the user href' do
+ it "does not render the user href" do
expect(body)
- .not_to have_json_path('_embedded/payload/_links/user/href')
+ .not_to have_json_path("_embedded/payload/_links/user/href")
end
end
end
diff --git a/modules/costs/spec/requests/api/time_entries/schemas/time_entry_schema_resource_spec.rb b/modules/costs/spec/requests/api/time_entries/schemas/time_entry_schema_resource_spec.rb
index 868538ebeb03..eb3bac336d47 100644
--- a/modules/costs/spec/requests/api/time_entries/schemas/time_entry_schema_resource_spec.rb
+++ b/modules/costs/spec/requests/api/time_entries/schemas/time_entry_schema_resource_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'API v3 Time entry schema resource', content_type: :json do
+RSpec.describe "API v3 Time entry schema resource", content_type: :json do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -49,30 +49,30 @@
subject(:response) { last_response }
- describe '#GET /time_entries/schema' do
+ describe "#GET /time_entries/schema" do
before do
get path
end
- it 'responds with 200 OK' do
+ it "responds with 200 OK" do
expect(subject.status).to eq(200)
end
- it 'returns a schema' do
+ it "returns a schema" do
expect(subject.body)
- .to be_json_eql('Schema'.to_json)
- .at_path '_type'
+ .to be_json_eql("Schema".to_json)
+ .at_path "_type"
end
- it 'does not embed' do
+ it "does not embed" do
expect(subject.body)
- .not_to have_json_path('project/_links/allowedValues')
+ .not_to have_json_path("project/_links/allowedValues")
end
- context 'if lacking permissions' do
+ context "if lacking permissions" do
let(:permissions) { [] }
- it 'responds with 403' do
+ it "responds with 403" do
expect(subject.status).to eq(403)
end
end
diff --git a/modules/costs/spec/requests/api/time_entries/update_form_resource_spec.rb b/modules/costs/spec/requests/api/time_entries/update_form_resource_spec.rb
index d226973ba544..2b5166332a31 100644
--- a/modules/costs/spec/requests/api/time_entries/update_form_resource_spec.rb
+++ b/modules/costs/spec/requests/api/time_entries/update_form_resource_spec.rb
@@ -25,8 +25,8 @@
#
# See COPYRIGHT and LICENSE files for more details.
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
RSpec.describe API::V3::TimeEntries::UpdateFormAPI, content_type: :json do
include Rack::Test::Methods
@@ -62,18 +62,18 @@
subject(:response) { last_response }
- describe '#POST /api/v3/time_entries/:id/form' do
- it 'returns 200 OK' do
+ describe "#POST /api/v3/time_entries/:id/form" do
+ it "returns 200 OK" do
expect(response.status).to eq(200)
end
- it 'returns a form' do
+ it "returns a form" do
expect(response.body)
- .to be_json_eql('Form'.to_json)
- .at_path('_type')
+ .to be_json_eql("Form".to_json)
+ .at_path("_type")
end
- context 'with all parameters' do
+ context "with all parameters" do
let(:parameters) do
{
_links: {
@@ -88,39 +88,39 @@
}
},
spentOn: Date.today.to_s,
- hours: 'PT5H',
+ hours: "PT5H",
comment: {
raw: "some comment"
},
custom_field.attribute_name(:camel_case) => {
- raw: 'some cf text'
+ raw: "some cf text"
}
}
end
- it 'has 0 validation errors' do
- expect(subject.body).to have_json_size(0).at_path('_embedded/validationErrors')
+ it "has 0 validation errors" do
+ expect(subject.body).to have_json_size(0).at_path("_embedded/validationErrors")
end
- it 'does not alter the entry' do
+ it "does not alter the entry" do
expect(time_entry.work_package)
.not_to eql work_package
end
- it 'has the values prefilled in the payload' do
+ it "has the values prefilled in the payload" do
body = subject.body
expect(body)
.to be_json_eql(api_v3_paths.project(project.id).to_json)
- .at_path('_embedded/payload/_links/project/href')
+ .at_path("_embedded/payload/_links/project/href")
expect(body)
.to be_json_eql(api_v3_paths.work_package(work_package.id).to_json)
- .at_path('_embedded/payload/_links/workPackage/href')
+ .at_path("_embedded/payload/_links/workPackage/href")
expect(body)
.to be_json_eql(api_v3_paths.time_entries_activity(active_activity.id).to_json)
- .at_path('_embedded/payload/_links/activity/href')
+ .at_path("_embedded/payload/_links/activity/href")
expect(body)
.to be_json_eql("some comment".to_json)
@@ -128,11 +128,11 @@
expect(body)
.to be_json_eql(Date.today.to_s.to_json)
- .at_path('_embedded/payload/spentOn')
+ .at_path("_embedded/payload/spentOn")
expect(body)
.to be_json_eql("PT5H".to_json)
- .at_path('_embedded/payload/hours')
+ .at_path("_embedded/payload/hours")
expect(body)
.to be_json_eql("some cf text".to_json)
@@ -143,28 +143,28 @@
.at_path("_embedded/payload/_links/user/href")
end
- it 'has the available values listed in the schema' do
+ it "has the available values listed in the schema" do
body = subject.body
wp_path = api_v3_paths.time_entries_available_work_packages_on_edit(time_entry.id)
expect(body)
.to be_json_eql(wp_path.to_json)
- .at_path('_embedded/schema/workPackage/_links/allowedValues/href')
+ .at_path("_embedded/schema/workPackage/_links/allowedValues/href")
expect(body)
.to be_json_eql(api_v3_paths.time_entries_available_projects.to_json)
- .at_path('_embedded/schema/project/_links/allowedValues/href')
+ .at_path("_embedded/schema/project/_links/allowedValues/href")
end
- it 'has a commit link' do
+ it "has a commit link" do
expect(subject.body)
.to be_json_eql(api_v3_paths.time_entry(time_entry.id).to_json)
- .at_path('_links/commit/href')
+ .at_path("_links/commit/href")
end
end
- context 'with an invalid parameter' do
+ context "with an invalid parameter" do
let(:parameters) do
{
_links: {
@@ -175,24 +175,24 @@
}
end
- it 'has 1 validation errors' do
- expect(subject.body).to have_json_size(1).at_path('_embedded/validationErrors')
+ it "has 1 validation errors" do
+ expect(subject.body).to have_json_size(1).at_path("_embedded/validationErrors")
end
- it 'has a validation error on workPackage' do
- expect(subject.body).to have_json_path('_embedded/validationErrors/workPackage')
+ it "has a validation error on workPackage" do
+ expect(subject.body).to have_json_path("_embedded/validationErrors/workPackage")
end
- it 'has no commit link' do
+ it "has no commit link" do
expect(subject.body)
- .not_to have_json_path('_links/commit/href')
+ .not_to have_json_path("_links/commit/href")
end
end
- context 'with permissions to edit own time entries' do
+ context "with permissions to edit own time entries" do
let(:permissions) { %i[view_time_entries edit_own_time_entries] }
- context 'with the time_entry being of the user' do
+ context "with the time_entry being of the user" do
let(:user) do
user = time_entry.user
@@ -204,22 +204,22 @@
user
end
- it 'returns 200 OK' do
+ it "returns 200 OK" do
expect(response.status).to eq(200)
end
end
- context 'with the time_entry being of a different user' do
- it 'returns 403 Not Authorized' do
+ context "with the time_entry being of a different user" do
+ it "returns 403 Not Authorized" do
expect(response.status).to eq(403)
end
end
end
- context 'without the necessary permission' do
+ context "without the necessary permission" do
let(:permissions) { %i[view_time_entries] }
- it 'returns 403 Not Authorized' do
+ it "returns 403 Not Authorized" do
expect(response.status).to eq(403)
end
end
diff --git a/modules/costs/spec/requests/api/time_entry_activity_resource_spec.rb b/modules/costs/spec/requests/api/time_entry_activity_resource_spec.rb
index 95760f2ef7d9..04ce1d7d4fe1 100644
--- a/modules/costs/spec/requests/api/time_entry_activity_resource_spec.rb
+++ b/modules/costs/spec/requests/api/time_entry_activity_resource_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'API v3 time_entry_activity resource' do
+RSpec.describe "API v3 time_entry_activity resource" do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -47,33 +47,33 @@
login_as(current_user)
end
- describe 'GET /api/v3/time_entries/activities/:id' do
+ describe "GET /api/v3/time_entries/activities/:id" do
let(:path) { api_v3_paths.time_entries_activity(activity.id) }
- context 'for a visible root activity' do
+ context "for a visible root activity" do
before do
activity
get path
end
- it 'returns 200 OK' do
+ it "returns 200 OK" do
expect(subject.status)
.to be(200)
end
- it 'returns the time entry' do
+ it "returns the time entry" do
expect(subject.body)
- .to be_json_eql('TimeEntriesActivity'.to_json)
- .at_path('_type')
+ .to be_json_eql("TimeEntriesActivity".to_json)
+ .at_path("_type")
expect(subject.body)
.to be_json_eql(activity.id.to_json)
- .at_path('id')
+ .at_path("id")
end
end
- context 'for non shared activities' do
+ context "for non shared activities" do
before do
activity.project_id = 234
activity.save(validate: false)
@@ -81,13 +81,13 @@
get path
end
- it 'returns 404 NOT FOUND' do
+ it "returns 404 NOT FOUND" do
expect(subject.status)
.to be(404)
end
end
- context 'when lacking permissions' do
+ context "when lacking permissions" do
let(:permissions) { [] }
before do
@@ -96,7 +96,7 @@
get path
end
- it 'returns 404 NOT FOUND' do
+ it "returns 404 NOT FOUND" do
expect(subject.status)
.to be(404)
end
diff --git a/modules/costs/spec/requests/api/time_entry_resource_spec.rb b/modules/costs/spec/requests/api/time_entry_resource_spec.rb
index 979045ec4725..077ad55f5074 100644
--- a/modules/costs/spec/requests/api/time_entry_resource_spec.rb
+++ b/modules/costs/spec/requests/api/time_entry_resource_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'API v3 time_entry resource' do
+RSpec.describe "API v3 time_entry resource" do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -57,7 +57,7 @@
let(:custom_field) { create(:time_entry_custom_field) }
let(:custom_value) do
CustomValue.create(custom_field:,
- value: '1234',
+ value: "1234",
customized: time_entry)
end
let(:activity) do
@@ -72,10 +72,10 @@
OpenProject::Cache.clear
end
- describe 'GET api/v3/time_entries' do
+ describe "GET api/v3/time_entries" do
let(:path) { api_v3_paths.time_entries }
- context 'without params' do
+ context "without params" do
before do
time_entry
invisible_time_entry
@@ -84,22 +84,22 @@
get path
end
- it 'responds 200 OK' do
+ it "responds 200 OK" do
expect(subject.status).to eq(200)
end
- it 'returns a collection of time entries containing only the visible time entries' do
+ it "returns a collection of time entries containing only the visible time entries" do
expect(subject.body)
- .to be_json_eql('Collection'.to_json)
- .at_path('_type')
+ .to be_json_eql("Collection".to_json)
+ .at_path("_type")
expect(subject.body)
- .to be_json_eql('1')
- .at_path('total')
+ .to be_json_eql("1")
+ .at_path("total")
expect(subject.body)
.to be_json_eql(time_entry.id.to_json)
- .at_path('_embedded/elements/0/id')
+ .at_path("_embedded/elements/0/id")
expect(subject.body)
.to be_json_eql(custom_value.value.to_json)
@@ -107,7 +107,7 @@
end
end
- context 'with pageSize, offset and sortBy' do
+ context "with pageSize, offset and sortBy" do
let(:path) { "#{api_v3_paths.time_entries}?pageSize=1&offset=2&sortBy=#{[%i(id asc)].to_json}" }
before do
@@ -118,33 +118,33 @@
get path
end
- it 'returns a slice of the visible time entries' do
+ it "returns a slice of the visible time entries" do
expect(subject.body)
- .to be_json_eql('Collection'.to_json)
- .at_path('_type')
+ .to be_json_eql("Collection".to_json)
+ .at_path("_type")
expect(subject.body)
- .to be_json_eql('2')
- .at_path('total')
+ .to be_json_eql("2")
+ .at_path("total")
expect(subject.body)
- .to be_json_eql('1')
- .at_path('count')
+ .to be_json_eql("1")
+ .at_path("count")
expect(subject.body)
.to be_json_eql(other_time_entry.id.to_json)
- .at_path('_embedded/elements/0/id')
+ .at_path("_embedded/elements/0/id")
end
end
- context 'filtering by user' do
+ context "filtering by user" do
let(:invisible_time_entry) do
create(:time_entry, project: other_project, work_package: other_work_package, user: other_user)
end
let(:path) do
- filter = [{ 'user' => {
- 'operator' => '=',
- 'values' => [other_user.id]
+ filter = [{ "user" => {
+ "operator" => "=",
+ "values" => [other_user.id]
} }]
"#{api_v3_paths.time_entries}?#{{ filters: filter.to_json }.to_query}"
@@ -158,18 +158,18 @@
get path
end
- it 'contains only the filtered time entries in the response' do
+ it "contains only the filtered time entries in the response" do
expect(subject.body)
- .to be_json_eql('1')
- .at_path('total')
+ .to be_json_eql("1")
+ .at_path("total")
expect(subject.body)
.to be_json_eql(other_time_entry.id.to_json)
- .at_path('_embedded/elements/0/id')
+ .at_path("_embedded/elements/0/id")
end
end
- context 'filtering by work package' do
+ context "filtering by work package" do
let(:unwanted_work_package) do
create(:work_package, project:, type: project.types.first)
end
@@ -179,9 +179,9 @@
end
let(:path) do
- filter = [{ 'work_package' => {
- 'operator' => '=',
- 'values' => [work_package.id]
+ filter = [{ "work_package" => {
+ "operator" => "=",
+ "values" => [work_package.id]
} }]
"#{api_v3_paths.time_entries}?#{{ filters: filter.to_json }.to_query}"
@@ -195,25 +195,25 @@
get path
end
- it 'contains only the filtered time entries in the response' do
+ it "contains only the filtered time entries in the response" do
expect(subject.body)
- .to be_json_eql('1')
- .at_path('total')
+ .to be_json_eql("1")
+ .at_path("total")
expect(subject.body)
.to be_json_eql(time_entry.id.to_json)
- .at_path('_embedded/elements/0/id')
+ .at_path("_embedded/elements/0/id")
end
end
- context 'filtering by project' do
+ context "filtering by project" do
let(:other_time_entry) do
create(:time_entry, project: other_project, work_package: other_work_package, user: current_user)
end
let(:path) do
- filter = [{ 'project' => {
- 'operator' => '=',
- 'values' => [other_project.id]
+ filter = [{ "project" => {
+ "operator" => "=",
+ "values" => [other_project.id]
} }]
"#{api_v3_paths.time_entries}?#{{ filters: filter.to_json }.to_query}"
@@ -231,27 +231,27 @@
get path
end
- it 'contains only the filtered time entries in the response' do
+ it "contains only the filtered time entries in the response" do
expect(subject.body)
- .to be_json_eql('1')
- .at_path('total')
+ .to be_json_eql("1")
+ .at_path("total")
expect(subject.body)
.to be_json_eql(other_time_entry.id.to_json)
- .at_path('_embedded/elements/0/id')
+ .at_path("_embedded/elements/0/id")
end
end
- context 'filtering by global activity' do
+ context "filtering by global activity" do
let(:activity) do
create(:time_entry_activity)
end
let(:path) do
filter = [
{
- 'activity_id' => {
- 'operator' => '=',
- 'values' => [activity.id]
+ "activity_id" => {
+ "operator" => "=",
+ "values" => [activity.id]
}
}
]
@@ -291,26 +291,26 @@
get path
end
- it 'contains only the filtered time entries in the response' do
+ it "contains only the filtered time entries in the response" do
expect(subject.body)
- .to be_json_eql('2')
- .at_path('total')
+ .to be_json_eql("2")
+ .at_path("total")
expect(subject.body)
.to be_json_eql(time_entry.id.to_json)
- .at_path('_embedded/elements/0/id')
+ .at_path("_embedded/elements/0/id")
expect(subject.body)
.to be_json_eql(other_time_entry.id.to_json)
- .at_path('_embedded/elements/1/id')
+ .at_path("_embedded/elements/1/id")
end
end
- context 'invalid filter' do
+ context "invalid filter" do
let(:path) do
- filter = [{ 'bogus' => {
- 'operator' => '=',
- 'values' => ['1']
+ filter = [{ "bogus" => {
+ "operator" => "=",
+ "values" => ["1"]
} }]
"#{api_v3_paths.time_entries}?#{{ filters: filter.to_json }.to_query}"
@@ -322,17 +322,17 @@
get path
end
- it 'returns an error' do
+ it "returns an error" do
expect(subject.status).to eq(400)
expect(subject.body)
- .to be_json_eql('urn:openproject-org:api:v3:errors:InvalidQuery'.to_json)
- .at_path('errorIdentifier')
+ .to be_json_eql("urn:openproject-org:api:v3:errors:InvalidQuery".to_json)
+ .at_path("errorIdentifier")
end
end
end
- describe 'GET /api/v3/time_entries/:id' do
+ describe "GET /api/v3/time_entries/:id" do
let(:path) { api_v3_paths.time_entry(time_entry.id) }
before do
@@ -342,36 +342,36 @@
get path
end
- it 'returns 200 OK' do
+ it "returns 200 OK" do
expect(subject.status)
.to be(200)
end
- it 'returns the time entry' do
+ it "returns the time entry" do
expect(subject.body)
- .to be_json_eql('TimeEntry'.to_json)
- .at_path('_type')
+ .to be_json_eql("TimeEntry".to_json)
+ .at_path("_type")
expect(subject.body)
.to be_json_eql(time_entry.id.to_json)
- .at_path('id')
+ .at_path("id")
expect(subject.body)
.to be_json_eql(custom_value.value.to_json)
.at_path("customField#{custom_field.id}/raw")
end
- context 'when lacking permissions' do
+ context "when lacking permissions" do
let(:permissions) { [] }
- it 'returns 404 NOT FOUND' do
+ it "returns 404 NOT FOUND" do
expect(subject.status)
.to be(404)
end
end
end
- describe 'POST api/v3/time_entries' do
+ describe "POST api/v3/time_entries" do
let(:permissions) { %i(view_time_entries log_time view_work_packages) }
let(:path) { api_v3_paths.time_entries }
let(:params) do
@@ -387,13 +387,13 @@
href: api_v3_paths.work_package(work_package.id)
}
},
- hours: 'PT5H',
+ hours: "PT5H",
comment: {
raw: "some comment"
},
spentOn: "2017-07-28",
custom_field.attribute_name(:camel_case) => {
- raw: 'some cf text'
+ raw: "some cf text"
}
}
end
@@ -404,14 +404,14 @@
additional_setup.call
- post path, params.to_json, 'CONTENT_TYPE' => 'application/json'
+ post path, params.to_json, "CONTENT_TYPE" => "application/json"
end
- it 'responds 201 CREATED' do
+ it "responds 201 CREATED" do
expect(subject.status).to eq(201)
end
- it 'creates another time entry with the provided values' do
+ it "creates another time entry with the provided values" do
expect(TimeEntry.count)
.to be 1
@@ -439,26 +439,26 @@
.to eql Date.parse("2017-07-28")
expect(new_entry.send(custom_field.attribute_getter))
- .to eql 'some cf text'
+ .to eql "some cf text"
end
- context 'when lacking permissions' do
+ context "when lacking permissions" do
let(:permissions) { %i(view_time_entries view_work_packages) }
- it 'returns 403' do
+ it "returns 403" do
expect(subject.status)
.to be(403)
end
end
- context 'if sending an activity the project disables' do
+ context "if sending an activity the project disables" do
let(:disable_activity) do
TimeEntryActivitiesProject.insert({ activity_id: activity.id, project_id: project.id, active: false })
end
let(:additional_setup) { -> { disable_activity } }
- it 'returns 422 and complains about the activity' do
+ it "returns 422 and complains about the activity" do
expect(subject.status)
.to be(422)
@@ -468,7 +468,7 @@
end
end
- context 'when sending invalid params' do
+ context "when sending invalid params" do
let(:params) do
{
_links: {
@@ -482,16 +482,16 @@
href: api_v3_paths.work_package(work_package.id + 1)
}
},
- hours: 'PT5H',
+ hours: "PT5H",
comment: "some comment",
spentOn: "2017-07-28",
custom_field.attribute_name(:camel_case) => {
- raw: 'some cf text'
+ raw: "some cf text"
}
}
end
- it 'returns 422 and complains about work packages' do
+ it "returns 422 and complains about work packages" do
expect(subject.status)
.to be(422)
@@ -502,13 +502,13 @@
end
end
- describe 'PATCH api/v3/time_entries/:id' do
+ describe "PATCH api/v3/time_entries/:id" do
let(:path) { api_v3_paths.time_entry(time_entry.id) }
let(:permissions) { %i(edit_time_entries view_time_entries view_work_packages) }
let(:params) do
{
- hours: 'PT10H',
+ hours: "PT10H",
activity: {
href: api_v3_paths.time_entries_activity(activity.id)
}
@@ -523,10 +523,10 @@
additional_setup.call
- patch path, params.to_json, 'CONTENT_TYPE' => 'application/json'
+ patch path, params.to_json, "CONTENT_TYPE" => "application/json"
end
- it 'updates the time entry' do
+ it "updates the time entry" do
expect(subject.status).to eq(200)
time_entry.reload
@@ -535,23 +535,23 @@
expect(time_entry.activity).to eq activity
end
- context 'when lacking permissions' do
+ context "when lacking permissions" do
let(:permissions) { %i(view_time_entries) }
- it 'returns 403' do
+ it "returns 403" do
expect(subject.status)
.to be(403)
end
end
- context 'if sending an activity the project disables' do
+ context "if sending an activity the project disables" do
let(:disable_activity) do
TimeEntryActivitiesProject.insert({ activity_id: activity.id, project_id: project.id, active: false })
end
let(:additional_setup) { -> { disable_activity } }
- it 'returns 422 and complains about the activity' do
+ it "returns 422 and complains about the activity" do
expect(subject.status)
.to be(422)
@@ -561,7 +561,7 @@
end
end
- context 'when sending invalid params' do
+ context "when sending invalid params" do
let(:params) do
{
_links: {
@@ -572,7 +572,7 @@
}
end
- it 'returns 422 and complains about work packages' do
+ it "returns 422 and complains about work packages" do
expect(subject.status)
.to be(422)
@@ -583,7 +583,7 @@
end
end
- describe 'DELETE api/v3/time_entries/:id' do
+ describe "DELETE api/v3/time_entries/:id" do
let(:path) { api_v3_paths.time_entry(time_entry.id) }
let(:permissions) { %i(edit_own_time_entries view_time_entries view_work_packages) }
let(:params) {}
@@ -593,17 +593,17 @@
other_time_entry
custom_value
- delete path, params.to_json, 'CONTENT_TYPE' => 'application/json'
+ delete path, params.to_json, "CONTENT_TYPE" => "application/json"
end
- it 'deleted the time entry' do
+ it "deleted the time entry" do
expect(subject.status).to eq(204)
end
- context 'when lacking permissions' do
+ context "when lacking permissions" do
let(:permissions) { %i(view_time_entries) }
- it 'returns 403' do
+ it "returns 403" do
expect(subject.status)
.to be(403)
end
@@ -611,41 +611,41 @@
subject(:response) { last_response }
- shared_examples_for 'deletes the time_entry' do
- it 'responds with HTTP No Content' do
+ shared_examples_for "deletes the time_entry" do
+ it "responds with HTTP No Content" do
expect(subject.status).to eq 204
end
- it 'removes the time_entry from the DB' do
+ it "removes the time_entry from the DB" do
expect(TimeEntry.exists?(time_entry.id)).to be_falsey
end
end
- shared_examples_for 'does not delete the time_entry' do |status = 403|
+ shared_examples_for "does not delete the time_entry" do |status = 403|
it "responds with #{status}" do
expect(subject.status).to eq status
end
- it 'does not delete the time_entry' do
+ it "does not delete the time_entry" do
expect(TimeEntry.exists?(time_entry.id)).to be_truthy
end
end
- context 'with the user being the author' do
- it_behaves_like 'deletes the time_entry'
+ context "with the user being the author" do
+ it_behaves_like "deletes the time_entry"
end
- context 'with the user not being the author' do
+ context "with the user not being the author" do
let(:time_entry) { other_time_entry }
- context 'but permission to edit all time entries' do
+ context "but permission to edit all time entries" do
let(:permissions) { %i(edit_time_entries view_time_entries view_work_packages) }
- it_behaves_like 'deletes the time_entry'
+ it_behaves_like "deletes the time_entry"
end
- context 'with permission to delete own time entries' do
- it_behaves_like 'does not delete the time_entry', 403
+ context "with permission to delete own time entries" do
+ it_behaves_like "does not delete the time_entry", 403
end
end
end
diff --git a/modules/costs/spec/routing/cost_objects_routing_spec.rb b/modules/costs/spec/routing/cost_objects_routing_spec.rb
index 57a28c568335..23c495914f19 100644
--- a/modules/costs/spec/routing/cost_objects_routing_spec.rb
+++ b/modules/costs/spec/routing/cost_objects_routing_spec.rb
@@ -26,62 +26,62 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe BudgetsController do
- describe 'routing' do
+ describe "routing" do
it {
- expect(get('/projects/blubs/budgets/new')).to route_to(controller: 'budgets',
- action: 'new',
- project_id: 'blubs')
+ expect(get("/projects/blubs/budgets/new")).to route_to(controller: "budgets",
+ action: "new",
+ project_id: "blubs")
}
it {
- expect(post('/projects/blubs/budgets')).to route_to(controller: 'budgets',
- action: 'create',
- project_id: 'blubs')
+ expect(post("/projects/blubs/budgets")).to route_to(controller: "budgets",
+ action: "create",
+ project_id: "blubs")
}
it {
- expect(get('/projects/blubs/budgets')).to route_to(controller: 'budgets',
- action: 'index',
- project_id: 'blubs')
+ expect(get("/projects/blubs/budgets")).to route_to(controller: "budgets",
+ action: "index",
+ project_id: "blubs")
}
it {
- expect(get('/budgets/5')).to route_to(controller: 'budgets',
- action: 'show',
- id: '5')
+ expect(get("/budgets/5")).to route_to(controller: "budgets",
+ action: "show",
+ id: "5")
}
it {
- expect(put('/budgets/5')).to route_to(controller: 'budgets',
- action: 'update',
- id: '5')
+ expect(put("/budgets/5")).to route_to(controller: "budgets",
+ action: "update",
+ id: "5")
}
it {
- expect(delete('/budgets/5')).to route_to(controller: 'budgets',
- action: 'destroy',
- id: '5')
+ expect(delete("/budgets/5")).to route_to(controller: "budgets",
+ action: "destroy",
+ id: "5")
}
it {
- expect(post('/projects/42/budgets/update_material_budget_item')).to route_to(controller: 'budgets',
- action: 'update_material_budget_item',
- project_id: '42')
+ expect(post("/projects/42/budgets/update_material_budget_item")).to route_to(controller: "budgets",
+ action: "update_material_budget_item",
+ project_id: "42")
}
it {
- expect(post('/projects/42/budgets/update_labor_budget_item')).to route_to(controller: 'budgets',
- action: 'update_labor_budget_item',
- project_id: '42')
+ expect(post("/projects/42/budgets/update_labor_budget_item")).to route_to(controller: "budgets",
+ action: "update_labor_budget_item",
+ project_id: "42")
}
it {
- expect(get('/budgets/5/copy')).to route_to(controller: 'budgets',
- action: 'copy',
- id: '5')
+ expect(get("/budgets/5/copy")).to route_to(controller: "budgets",
+ action: "copy",
+ id: "5")
}
end
end
diff --git a/modules/costs/spec/routing/cost_types_routing_spec.rb b/modules/costs/spec/routing/cost_types_routing_spec.rb
index 816f12344f36..3a000910ad94 100644
--- a/modules/costs/spec/routing/cost_types_routing_spec.rb
+++ b/modules/costs/spec/routing/cost_types_routing_spec.rb
@@ -26,53 +26,53 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe CostTypesController do
- describe 'routing' do
+ describe "routing" do
it {
- expect(get('/cost_types')).to route_to(controller: 'cost_types',
- action: 'index')
+ expect(get("/cost_types")).to route_to(controller: "cost_types",
+ action: "index")
}
it {
- expect(post('/cost_types')).to route_to(controller: 'cost_types',
- action: 'create')
+ expect(post("/cost_types")).to route_to(controller: "cost_types",
+ action: "create")
}
it {
- expect(get('/cost_types/new')).to route_to(controller: 'cost_types',
- action: 'new')
+ expect(get("/cost_types/new")).to route_to(controller: "cost_types",
+ action: "new")
}
it {
- expect(get('/cost_types/5/edit')).to route_to(controller: 'cost_types',
- action: 'edit',
- id: '5')
+ expect(get("/cost_types/5/edit")).to route_to(controller: "cost_types",
+ action: "edit",
+ id: "5")
}
it {
- expect(put('/cost_types/5')).to route_to(controller: 'cost_types',
- action: 'update',
- id: '5')
+ expect(put("/cost_types/5")).to route_to(controller: "cost_types",
+ action: "update",
+ id: "5")
}
it {
- expect(put('/cost_types/5/set_rate')).to route_to(controller: 'cost_types',
- action: 'set_rate',
- id: '5')
+ expect(put("/cost_types/5/set_rate")).to route_to(controller: "cost_types",
+ action: "set_rate",
+ id: "5")
}
it {
- expect(delete('/cost_types/5')).to route_to(controller: 'cost_types',
- action: 'destroy',
- id: '5')
+ expect(delete("/cost_types/5")).to route_to(controller: "cost_types",
+ action: "destroy",
+ id: "5")
}
it {
- expect(patch('/cost_types/5/restore')).to route_to(controller: 'cost_types',
- action: 'restore',
- id: '5')
+ expect(patch("/cost_types/5/restore")).to route_to(controller: "cost_types",
+ action: "restore",
+ id: "5")
}
end
end
diff --git a/modules/costs/spec/routing/costlog_routing_spec.rb b/modules/costs/spec/routing/costlog_routing_spec.rb
index 1c0dfbe7345a..d41d6b005571 100644
--- a/modules/costs/spec/routing/costlog_routing_spec.rb
+++ b/modules/costs/spec/routing/costlog_routing_spec.rb
@@ -26,44 +26,44 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe CostlogController do
- describe 'routing' do
+ describe "routing" do
it {
- expect(get('/projects/blubs/cost_entries/new')).to route_to(controller: 'costlog',
- action: 'new',
- project_id: 'blubs')
+ expect(get("/projects/blubs/cost_entries/new")).to route_to(controller: "costlog",
+ action: "new",
+ project_id: "blubs")
}
it {
- expect(post('/projects/blubs/cost_entries')).to route_to(controller: 'costlog',
- action: 'create',
- project_id: 'blubs')
+ expect(post("/projects/blubs/cost_entries")).to route_to(controller: "costlog",
+ action: "create",
+ project_id: "blubs")
}
it {
- expect(get('/work_packages/5/cost_entries/new')).to route_to(controller: 'costlog',
- action: 'new',
- work_package_id: '5')
+ expect(get("/work_packages/5/cost_entries/new")).to route_to(controller: "costlog",
+ action: "new",
+ work_package_id: "5")
}
it {
- expect(get('/cost_entries/5/edit')).to route_to(controller: 'costlog',
- action: 'edit',
- id: '5')
+ expect(get("/cost_entries/5/edit")).to route_to(controller: "costlog",
+ action: "edit",
+ id: "5")
}
it {
- expect(put('/cost_entries/5')).to route_to(controller: 'costlog',
- action: 'update',
- id: '5')
+ expect(put("/cost_entries/5")).to route_to(controller: "costlog",
+ action: "update",
+ id: "5")
}
it {
- expect(delete('/cost_entries/5')).to route_to(controller: 'costlog',
- action: 'destroy',
- id: '5')
+ expect(delete("/cost_entries/5")).to route_to(controller: "costlog",
+ action: "destroy",
+ id: "5")
}
end
end
diff --git a/modules/costs/spec/routing/hourly_rates_routing_spec.rb b/modules/costs/spec/routing/hourly_rates_routing_spec.rb
index a9d89cf8d879..1d1296561167 100644
--- a/modules/costs/spec/routing/hourly_rates_routing_spec.rb
+++ b/modules/costs/spec/routing/hourly_rates_routing_spec.rb
@@ -26,42 +26,42 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe HourlyRatesController do
- describe 'routing' do
+ describe "routing" do
it {
- expect(get('/projects/blubs/hourly_rates/5')).to route_to(controller: 'hourly_rates',
- action: 'show',
- project_id: 'blubs',
- id: '5')
+ expect(get("/projects/blubs/hourly_rates/5")).to route_to(controller: "hourly_rates",
+ action: "show",
+ project_id: "blubs",
+ id: "5")
}
it {
- expect(get('/projects/blubs/hourly_rates/5/edit')).to route_to(controller: 'hourly_rates',
- action: 'edit',
- project_id: 'blubs',
- id: '5')
+ expect(get("/projects/blubs/hourly_rates/5/edit")).to route_to(controller: "hourly_rates",
+ action: "edit",
+ project_id: "blubs",
+ id: "5")
}
it {
- expect(get('/hourly_rates/5/edit')).to route_to(controller: 'hourly_rates',
- action: 'edit',
- id: '5')
+ expect(get("/hourly_rates/5/edit")).to route_to(controller: "hourly_rates",
+ action: "edit",
+ id: "5")
}
it {
- expect(put('/projects/blubs/hourly_rates/5')).to route_to(controller: 'hourly_rates',
- action: 'update',
- project_id: 'blubs',
- id: '5')
+ expect(put("/projects/blubs/hourly_rates/5")).to route_to(controller: "hourly_rates",
+ action: "update",
+ project_id: "blubs",
+ id: "5")
}
it {
- expect(post('/projects/blubs/hourly_rates/5/set_rate')).to route_to(controller: 'hourly_rates',
- action: 'set_rate',
- project_id: 'blubs',
- id: '5')
+ expect(post("/projects/blubs/hourly_rates/5/set_rate")).to route_to(controller: "hourly_rates",
+ action: "set_rate",
+ project_id: "blubs",
+ id: "5")
}
end
end
diff --git a/modules/costs/spec/services/time_entries/set_attributes_service_integration_spec.rb b/modules/costs/spec/services/time_entries/set_attributes_service_integration_spec.rb
index bdb3155be31f..968992569fab 100644
--- a/modules/costs/spec/services/time_entries/set_attributes_service_integration_spec.rb
+++ b/modules/costs/spec/services/time_entries/set_attributes_service_integration_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe TimeEntries::SetAttributesService, 'integration', type: :model do
+RSpec.describe TimeEntries::SetAttributesService, "integration", type: :model do
let(:project) { create(:project) }
let(:user) do
create(:user,
@@ -52,14 +52,14 @@
subject { instance.call(params) }
- context 'default activity not active in project' do
+ context "default activity not active in project" do
let!(:default_activity) { create(:time_entry_activity, is_default: true) }
before do
project.time_entry_activities_projects.create(activity_id: default_activity.id, active: false)
end
- it 'does not assign the default activity' do
+ it "does not assign the default activity" do
expect(subject).to be_success
expect(subject.result.activity).to be_nil
end
diff --git a/modules/costs/spec/services/time_entries/set_attributes_service_spec.rb b/modules/costs/spec/services/time_entries/set_attributes_service_spec.rb
index 34b82bfd6c4d..6339b66221c1 100644
--- a/modules/costs/spec/services/time_entries/set_attributes_service_spec.rb
+++ b/modules/costs/spec/services/time_entries/set_attributes_service_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe TimeEntries::SetAttributesService, type: :model do
let(:user) { build_stubbed(:user) }
@@ -36,9 +36,9 @@
let(:project) { build_stubbed(:project) }
let(:spent_on) { Time.zone.today.to_s }
let(:hours) { 5.0 }
- let(:comments) { 'some comment' }
+ let(:comments) { "some comment" }
let(:contract_instance) do
- contract = double('contract_instance') # rubocop:disable RSpec/VerifiedDoubles
+ contract = double("contract_instance") # rubocop:disable RSpec/VerifiedDoubles
allow(contract)
.to receive(:validate)
.and_return(contract_valid)
@@ -48,7 +48,7 @@
contract
end
- let(:contract_errors) { double('contract_errors') } # rubocop:disable RSpec/VerifiedDoubles
+ let(:contract_errors) { double("contract_errors") } # rubocop:disable RSpec/VerifiedDoubles
let(:contract_valid) { true }
let(:time_entry_valid) { true }
@@ -77,12 +77,12 @@
subject { instance.call(params) }
- it 'creates a new time entry' do
+ it "creates a new time entry" do
expect(subject.result)
.to eql time_entry_instance
end
- it 'is a success' do
+ it "is a success" do
expect(subject)
.to be_success
end
@@ -94,14 +94,14 @@
.to eql user
end
- it 'notes the user to be system changed' do
+ it "notes the user to be system changed" do
subject
- expect(time_entry_instance.changed_by_system['user_id'])
+ expect(time_entry_instance.changed_by_system["user_id"])
.to eql [nil, user.id]
end
- it 'assigns the default TimeEntryActivity' do
+ it "assigns the default TimeEntryActivity" do
allow(TimeEntryActivity)
.to receive(:default)
.and_return(default_activity)
@@ -112,7 +112,7 @@
.to eql default_activity
end
- context 'with params' do
+ context "with params" do
let(:params) do
{
work_package:,
@@ -136,7 +136,7 @@
}.with_indifferent_access
end
- it 'assigns the params' do
+ it "assigns the params" do
subject
attributes_of_interest = time_entry_instance
@@ -148,14 +148,14 @@
end
end
- context 'with hours == 0' do
+ context "with hours == 0" do
let(:params) do
{
hours: 0
}
end
- it 'sets hours to nil' do
+ it "sets hours to nil" do
subject
expect(time_entry_instance.hours)
@@ -163,14 +163,14 @@
end
end
- context 'with project not specified' do
+ context "with project not specified" do
let(:params) do
{
work_package:
}
end
- it 'sets the project to the work_package\'s project' do
+ it "sets the project to the work_package's project" do
subject
expect(time_entry_instance.project)
@@ -178,7 +178,7 @@
end
end
- context 'with another user setting logged by' do
+ context "with another user setting logged by" do
let(:other_user) { create(:user) }
let(:time_entry_instance) { create(:time_entry, user: other_user, logged_by: other_user, hours: 1) }
@@ -188,7 +188,7 @@
}
end
- it 'updates the entry, and updates the logged by' do
+ it "updates the entry, and updates the logged by" do
expect { subject }
.to change(time_entry_instance, :hours).from(1).to(1234)
.and change(time_entry_instance, :logged_by).from(other_user).to(user)
@@ -197,13 +197,13 @@
end
end
- context 'with an invalid contract' do
+ context "with an invalid contract" do
let(:contract_valid) { false }
let(:expect_time_instance_save) do
expect(time_entry_instance).not_to receive(:save) # rubocop:disable RSpec/MessageSpies
end
- it 'returns failure' do
+ it "returns failure" do
expect(subject)
.not_to be_success
end
diff --git a/modules/costs/spec/spec_helper.rb b/modules/costs/spec/spec_helper.rb
index 073c6827c8e1..1b8d73a3e5a1 100644
--- a/modules/costs/spec/spec_helper.rb
+++ b/modules/costs/spec/spec_helper.rb
@@ -27,8 +27,8 @@
#++
# -- load spec_helper from OpenProject core
-require 'spec_helper'
+require "spec_helper"
-require File.join(File.dirname(__FILE__), 'plugin_spec_helper')
+require File.join(File.dirname(__FILE__), "plugin_spec_helper")
-Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].sort.each { |f| require f }
+Dir[File.join(File.dirname(__FILE__), "support/**/*.rb")].sort.each { |f| require f }
diff --git a/modules/dashboards/config/routes.rb b/modules/dashboards/config/routes.rb
index 1f17b0e4336e..2abbb2a31737 100644
--- a/modules/dashboards/config/routes.rb
+++ b/modules/dashboards/config/routes.rb
@@ -1,3 +1,3 @@
Rails.application.routes.draw do
- get '/projects/:project_id/dashboards', to: 'dashboards/dashboards#show', as: :project_dashboards
+ get "/projects/:project_id/dashboards", to: "dashboards/dashboards#show", as: :project_dashboards
end
diff --git a/modules/dashboards/dashboards.gemspec b/modules/dashboards/dashboards.gemspec
index 84657708333e..0bbc19a888f5 100644
--- a/modules/dashboards/dashboards.gemspec
+++ b/modules/dashboards/dashboards.gemspec
@@ -1,11 +1,11 @@
Gem::Specification.new do |s|
s.name = "dashboards"
- s.version = '1.0.0'
+ s.version = "1.0.0"
s.authors = ["OpenProject"]
s.summary = "OpenProject Dashboards"
s.files = Dir["{app,config,db,lib}/**/*"]
- s.add_dependency 'grids'
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.add_dependency "grids"
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/dashboards/lib/dashboards/engine.rb b/modules/dashboards/lib/dashboards/engine.rb
index 86c70fabc9c4..c516b2039dcf 100644
--- a/modules/dashboards/lib/dashboards/engine.rb
+++ b/modules/dashboards/lib/dashboards/engine.rb
@@ -1,6 +1,6 @@
# Prevent load-order problems in case openproject-plugins is listed after a plugin in the Gemfile
# or not at all
-require 'open_project/plugins'
+require "open_project/plugins"
module Dashboards
class Engine < ::Rails::Engine
@@ -8,36 +8,36 @@ class Engine < ::Rails::Engine
include OpenProject::Plugins::ActsAsOpEngine
- initializer 'dashboards.menu' do
+ initializer "dashboards.menu" do
::Redmine::MenuManager.map(:project_menu) do |menu|
menu.push(:dashboards,
- { controller: '/dashboards/dashboards', action: 'show' },
- caption: :'dashboards.label',
+ { controller: "/dashboards/dashboards", action: "show" },
+ caption: :"dashboards.label",
after: :work_packages,
- icon: 'status',
- badge: 'label_menu_badge.alpha')
+ icon: "status",
+ badge: "label_menu_badge.alpha")
end
end
- initializer 'dashboards.permissions' do
+ initializer "dashboards.permissions" do
Rails.application.reloader.to_prepare do
OpenProject::AccessControl.map do |ac_map|
ac_map.project_module(:dashboards) do |pm_map|
pm_map.permission(:view_dashboards,
- { 'dashboards/dashboards': %i[show] },
+ { "dashboards/dashboards": %i[show] },
permissible_on: :project)
pm_map.permission(:manage_dashboards,
- { 'dashboards/dashboards': %i[show] },
+ { "dashboards/dashboards": %i[show] },
permissible_on: :project)
end
end
end
end
- initializer 'dashboards.conversion' do
- require Rails.root.join('config/constants/ar_to_api_conversions')
+ initializer "dashboards.conversion" do
+ require Rails.root.join("config/constants/ar_to_api_conversions")
- Constants::ARToAPIConversions.add('grids/dashboard': 'grid')
+ Constants::ARToAPIConversions.add("grids/dashboard": "grid")
end
config.to_prepare do
diff --git a/modules/dashboards/lib/dashboards/grid_registration.rb b/modules/dashboards/lib/dashboards/grid_registration.rb
index aa65572d09fe..d6ec9da8d864 100644
--- a/modules/dashboards/lib/dashboards/grid_registration.rb
+++ b/modules/dashboards/lib/dashboards/grid_registration.rb
@@ -1,6 +1,6 @@
module Dashboards
class GridRegistration < ::Grids::Configuration::InProjectBaseRegistration
- grid_class 'Grids::Dashboard'
+ grid_class "Grids::Dashboard"
to_scope :project_dashboards_path
defaults -> {
@@ -9,15 +9,15 @@ class GridRegistration < ::Grids::Configuration::InProjectBaseRegistration
column_count: 2,
widgets: [
{
- identifier: 'work_packages_table',
+ identifier: "work_packages_table",
start_row: 1,
end_row: 2,
start_column: 1,
end_column: 2,
options: {
- name: I18n.t('js.grid.widgets.work_packages_table.title'),
+ name: I18n.t("js.grid.widgets.work_packages_table.title"),
queryProps: {
- 'columns[]': %w(id project type subject),
+ "columns[]": %w(id project type subject),
filters: JSON.dump([{ status: { operator: "o", values: [] } }])
}
}
@@ -28,6 +28,6 @@ class GridRegistration < ::Grids::Configuration::InProjectBaseRegistration
view_permission :view_dashboards
edit_permission :manage_dashboards
- in_project_scope_path ['dashboards']
+ in_project_scope_path ["dashboards"]
end
end
diff --git a/modules/dashboards/spec/contracts/grids/create_contract_spec.rb b/modules/dashboards/spec/contracts/grids/create_contract_spec.rb
index 0da26fb03238..68e768f6db08 100644
--- a/modules/dashboards/spec/contracts/grids/create_contract_spec.rb
+++ b/modules/dashboards/spec/contracts/grids/create_contract_spec.rb
@@ -26,31 +26,31 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_examples'
+require "spec_helper"
+require_relative "shared_examples"
RSpec.describe Grids::CreateContract do
- include_context 'grid contract'
- include_context 'model contract'
+ include_context "grid contract"
+ include_context "model contract"
- it_behaves_like 'shared grid contract attributes'
+ it_behaves_like "shared grid contract attributes"
- describe 'user_id' do
- context 'for a Grids::Dashboard' do
+ describe "user_id" do
+ context "for a Grids::Dashboard" do
let(:grid) { build_stubbed(:dashboard, default_values) }
- it_behaves_like 'is not writable' do
+ it_behaves_like "is not writable" do
let(:attribute) { :user_id }
let(:value) { 5 }
end
end
end
- describe 'project_id' do
- context 'for a Grids::Dashboard' do
+ describe "project_id" do
+ context "for a Grids::Dashboard" do
let(:grid) { build_stubbed(:dashboard, default_values) }
- it_behaves_like 'is writable' do
+ it_behaves_like "is writable" do
let(:attribute) { :project_id }
let(:value) { 5 }
end
diff --git a/modules/dashboards/spec/contracts/grids/shared_examples.rb b/modules/dashboards/spec/contracts/grids/shared_examples.rb
index ad853a8e648a..21b73f51533e 100644
--- a/modules/dashboards/spec/contracts/grids/shared_examples.rb
+++ b/modules/dashboards/spec/contracts/grids/shared_examples.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-RSpec.shared_context 'grid contract' do
+RSpec.shared_context "grid contract" do
let(:user) { build_stubbed(:user) }
let(:instance) { described_class.new(grid, user) }
let(:project) { build_stubbed(:project) }
@@ -51,32 +51,32 @@
end
end
-RSpec.shared_examples_for 'shared grid contract attributes' do
- include_context 'model contract'
+RSpec.shared_examples_for "shared grid contract attributes" do
+ include_context "model contract"
let(:model) { grid }
- it 'is valid' do
+ it "is valid" do
expect(instance.validate)
.to be_truthy
end
- context 'if not having the manage_dashbaords permission' do
+ context "if not having the manage_dashbaords permission" do
let(:permissions) { %i[save_queries] }
- it 'is invalid' do
+ it "is invalid" do
expect(instance.validate)
.to be_falsey
end
- it 'notes the error' do
+ it "notes the error" do
instance.validate
expect(instance.errors.details[:scope])
.to contain_exactly({ error: :inclusion })
end
end
- describe 'widgets' do
- it_behaves_like 'is writable' do
+ describe "widgets" do
+ it_behaves_like "is writable" do
let(:attribute) { :widgets }
let(:value) do
[
@@ -84,233 +84,233 @@
end_row: 4,
start_column: 2,
end_column: 5,
- identifier: 'work_packages_table')
+ identifier: "work_packages_table")
]
end
end
- context 'invalid identifier' do
+ context "invalid identifier" do
before do
grid.widgets.build(start_row: 1,
end_row: 4,
start_column: 2,
end_column: 5,
- identifier: 'bogus_identifier')
+ identifier: "bogus_identifier")
end
- it 'is invalid' do
+ it "is invalid" do
expect(instance.validate)
.to be_falsey
end
- it 'notes the error' do
+ it "notes the error" do
instance.validate
expect(instance.errors.details[:widgets])
.to contain_exactly({ error: :inclusion })
end
end
- context 'collisions between widgets' do
+ context "collisions between widgets" do
before do
grid.widgets.build(start_row: 1,
end_row: 3,
start_column: 1,
end_column: 3,
- identifier: 'work_packages_table')
+ identifier: "work_packages_table")
grid.widgets.build(start_row: 2,
end_row: 4,
start_column: 2,
end_column: 4,
- identifier: 'work_packages_table')
+ identifier: "work_packages_table")
end
- it 'is invalid' do
+ it "is invalid" do
expect(instance.validate)
.to be_falsey
end
- it 'notes the error' do
+ it "notes the error" do
instance.validate
expect(instance.errors.details[:widgets])
.to contain_exactly({ error: :overlaps }, { error: :overlaps })
end
end
- context 'widgets having the same start column as another\'s end column' do
+ context "widgets having the same start column as another's end column" do
before do
grid.widgets.build(start_row: 1,
end_row: 3,
start_column: 1,
end_column: 3,
- identifier: 'work_packages_table')
+ identifier: "work_packages_table")
grid.widgets.build(start_row: 1,
end_row: 3,
start_column: 3,
end_column: 4,
- identifier: 'work_packages_table')
+ identifier: "work_packages_table")
end
- it 'is valid' do
+ it "is valid" do
expect(instance.validate)
.to be_truthy
end
end
- context 'widgets having the same start row as another\'s end row' do
+ context "widgets having the same start row as another's end row" do
before do
grid.widgets.build(start_row: 1,
end_row: 3,
start_column: 1,
end_column: 3,
- identifier: 'work_packages_table')
+ identifier: "work_packages_table")
grid.widgets.build(start_row: 3,
end_row: 4,
start_column: 1,
end_column: 3,
- identifier: 'work_packages_table')
+ identifier: "work_packages_table")
end
- it 'is valid' do
+ it "is valid" do
expect(instance.validate)
.to be_truthy
end
end
- context 'widgets being outside (max) of the grid' do
+ context "widgets being outside (max) of the grid" do
before do
grid.widgets.build(start_row: 1,
end_row: grid.row_count + 2,
start_column: 1,
end_column: 3,
- identifier: 'work_packages_table')
+ identifier: "work_packages_table")
end
- it 'is invalid' do
+ it "is invalid" do
expect(instance.validate)
.to be_falsey
end
- it 'notes the error' do
+ it "notes the error" do
instance.validate
expect(instance.errors.details[:widgets])
.to contain_exactly({ error: :outside })
end
end
- context 'widgets being outside (min) of the grid' do
+ context "widgets being outside (min) of the grid" do
before do
grid.widgets.build(start_row: 1,
end_row: 2,
start_column: -1,
end_column: 3,
- identifier: 'work_packages_table')
+ identifier: "work_packages_table")
end
- it 'is invalid' do
+ it "is invalid" do
expect(instance.validate)
.to be_falsey
end
- it 'notes the error' do
+ it "notes the error" do
instance.validate
expect(instance.errors.details[:widgets])
.to contain_exactly({ error: :outside })
end
end
- context 'widgets spanning the whole grid' do
+ context "widgets spanning the whole grid" do
before do
grid.widgets.build(start_row: 1,
end_row: grid.row_count + 1,
start_column: 1,
end_column: grid.column_count + 1,
- identifier: 'work_packages_table')
+ identifier: "work_packages_table")
end
- it 'is valid' do
+ it "is valid" do
expect(instance.validate)
.to be_truthy
end
end
- context 'widgets having start after end column' do
+ context "widgets having start after end column" do
before do
grid.widgets.build(start_row: 1,
end_row: 2,
start_column: 4,
end_column: 3,
- identifier: 'work_packages_table')
+ identifier: "work_packages_table")
end
- it 'is invalid' do
+ it "is invalid" do
expect(instance.validate)
.to be_falsey
end
- it 'notes the error' do
+ it "notes the error" do
instance.validate
expect(instance.errors.details[:widgets])
.to contain_exactly({ error: :end_before_start })
end
end
- context 'widgets having start after end row' do
+ context "widgets having start after end row" do
before do
grid.widgets.build(start_row: 4,
end_row: 2,
start_column: 1,
end_column: 3,
- identifier: 'work_packages_table')
+ identifier: "work_packages_table")
end
- it 'is invalid' do
+ it "is invalid" do
expect(instance.validate)
.to be_falsey
end
- it 'notes the error' do
+ it "notes the error" do
instance.validate
expect(instance.errors.details[:widgets])
.to contain_exactly({ error: :end_before_start })
end
end
- context 'widgets having start equals end column' do
+ context "widgets having start equals end column" do
before do
grid.widgets.build(start_row: 1,
end_row: 2,
start_column: 4,
end_column: 3,
- identifier: 'work_packages_table')
+ identifier: "work_packages_table")
end
- it 'is invalid' do
+ it "is invalid" do
expect(instance.validate)
.to be_falsey
end
- it 'notes the error' do
+ it "notes the error" do
instance.validate
expect(instance.errors.details[:widgets])
.to contain_exactly({ error: :end_before_start })
end
end
- context 'widgets having start equals end row' do
+ context "widgets having start equals end row" do
before do
grid.widgets.build(start_row: 2,
end_row: 2,
start_column: 1,
end_column: 3,
- identifier: 'work_packages_table')
+ identifier: "work_packages_table")
end
- it 'is invalid' do
+ it "is invalid" do
expect(instance.validate)
.to be_falsey
end
- it 'notes the error' do
+ it "notes the error" do
instance.validate
expect(instance.errors.details[:widgets])
.to contain_exactly({ error: :end_before_start })
diff --git a/modules/dashboards/spec/factories/grid_factory.rb b/modules/dashboards/spec/factories/grid_factory.rb
index 3db88797b30c..691119b01e68 100644
--- a/modules/dashboards/spec/factories/grid_factory.rb
+++ b/modules/dashboards/spec/factories/grid_factory.rb
@@ -1,12 +1,12 @@
FactoryBot.define do
- factory :dashboard, class: 'Grids::Dashboard' do
+ factory :dashboard, class: "Grids::Dashboard" do
project
row_count { 7 }
column_count { 4 }
widgets do
[
Grids::Widget.new(
- identifier: 'work_packages_table',
+ identifier: "work_packages_table",
start_row: 1,
end_row: 7,
start_column: 1,
@@ -16,7 +16,7 @@
end
end
- factory :dashboard_with_table, class: 'Grids::Dashboard' do
+ factory :dashboard_with_table, class: "Grids::Dashboard" do
project
row_count { 7 }
column_count { 4 }
@@ -25,13 +25,13 @@
query = create(:query, project: dashboard.project, public: true)
widget = build(:grid_widget,
- identifier: 'work_packages_table',
+ identifier: "work_packages_table",
start_row: 1,
end_row: 7,
start_column: 1,
end_column: 3,
options: {
- name: 'Work package table',
+ name: "Work package table",
queryId: query.id
})
@@ -39,21 +39,21 @@
end
end
- factory :dashboard_with_custom_text, class: 'Grids::Dashboard' do
+ factory :dashboard_with_custom_text, class: "Grids::Dashboard" do
project
row_count { 7 }
column_count { 4 }
callback(:after_build) do |dashboard|
widget = build(:grid_widget,
- identifier: 'custom_text',
+ identifier: "custom_text",
start_row: 1,
end_row: 7,
start_column: 1,
end_column: 3,
options: {
- name: 'Custom text',
- text: 'Lorem ipsum'
+ name: "Custom text",
+ text: "Lorem ipsum"
})
dashboard.widgets = [widget]
diff --git a/modules/dashboards/spec/features/custom_text_spec.rb b/modules/dashboards/spec/features/custom_text_spec.rb
index 764a90d5df3f..92de98472e98 100644
--- a/modules/dashboards/spec/features/custom_text_spec.rb
+++ b/modules/dashboards/spec/features/custom_text_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/dashboard'
+require_relative "../support/pages/dashboard"
-RSpec.describe 'Project description widget on dashboard', :js do
- let!(:type) { create(:type_task, name: 'Task') }
+RSpec.describe "Project description widget on dashboard", :js do
+ let!(:type) { create(:type_task, name: "Task") }
let!(:project) do
create(:project, types: [type])
end
@@ -52,109 +52,109 @@
let(:dashboard_page) do
Pages::Dashboard.new(project)
end
- let(:image_fixture) { UploadedFile.load_from('spec/fixtures/files/image.png') }
- let(:editor) { Components::WysiwygEditor.new 'body' }
- let(:field) { TextEditorField.new(page, 'description', selector: '.inline-edit--active-field') }
+ let(:image_fixture) { UploadedFile.load_from("spec/fixtures/files/image.png") }
+ let(:editor) { Components::WysiwygEditor.new "body" }
+ let(:field) { TextEditorField.new(page, "description", selector: ".inline-edit--active-field") }
before do
login_as user
end
- context 'for a user having edit permissions' do
+ context "for a user having edit permissions" do
before do
dashboard_page.visit!
end
- it 'can use the wp create button macro within it' do
+ it "can use the wp create button macro within it" do
dashboard_page.add_widget(1, 1, :within, "Custom text")
sleep(0.1)
# As the user lacks the manage_public_queries and save_queries permission, no other widget is present
- custom_text_widget = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ custom_text_widget = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
within custom_text_widget.area do
- find('.inplace-editing--container').click
+ find(".inplace-editing--container").click
end
- editor.insert_macro 'Insert create work package button'
+ editor.insert_macro "Insert create work package button"
- expect(page).to have_css('.spot-modal')
- select 'Task', from: 'selected-type'
- find('.spot-modal--submit-button').click
+ expect(page).to have_css(".spot-modal")
+ select "Task", from: "selected-type"
+ find(".spot-modal--submit-button").click
field.save!
- dashboard_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ dashboard_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
- within('#content') do
+ within("#content") do
expect(page).to have_css("a[href=\"/projects/#{project.identifier}/work_packages/new?type=#{type.id}\"]")
end
end
- it 'can add the widget set custom text and upload attachments' do
+ it "can add the widget set custom text and upload attachments" do
dashboard_page.add_widget(1, 1, :within, "Custom text")
sleep(0.1)
# As the user lacks the manage_public_queries and save_queries permission, no other widget is present
- custom_text_widget = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ custom_text_widget = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
within custom_text_widget.area do
- find('.inplace-editing--container').click
+ find(".inplace-editing--container").click
- field.set_value('My own little text')
+ field.set_value("My own little text")
field.save!
end
- dashboard_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ dashboard_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
within custom_text_widget.area do
expect(page)
- .to have_css('.inline-edit--display-field', text: 'My own little text')
+ .to have_css(".inline-edit--display-field", text: "My own little text")
- find('.inplace-editing--container').click
+ find(".inplace-editing--container").click
- field.set_value('My new text')
+ field.set_value("My new text")
field.cancel_by_click
expect(page)
- .to have_css('.inline-edit--display-field', text: 'My own little text')
+ .to have_css(".inline-edit--display-field", text: "My own little text")
end
- dashboard_page.expect_no_toaster message: I18n.t('js.notice_successful_update')
+ dashboard_page.expect_no_toaster message: I18n.t("js.notice_successful_update")
within custom_text_widget.area do
# adding an image
- find('.inplace-editing--container').click
+ find(".inplace-editing--container").click
sleep(0.1)
end
# The drag_attachment is written in a way that it requires to be executed with page on body
# so we cannot have it wrapped in the within block.
- editor.drag_attachment image_fixture.path, 'Image uploaded'
+ editor.drag_attachment image_fixture.path, "Image uploaded"
within custom_text_widget.area do
- expect(page).to have_test_selector('op-attachment-list-item', text: 'image.png')
- expect(page).to have_no_css('notifications-upload-progress')
+ expect(page).to have_test_selector("op-attachment-list-item", text: "image.png")
+ expect(page).to have_no_css("notifications-upload-progress")
field.save!
end
- dashboard_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ dashboard_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
within custom_text_widget.area do
expect(page)
- .to have_css('#content img', count: 1)
+ .to have_css("#content img", count: 1)
expect(page)
- .not_to have_test_selector('op-attachment-list-item', text: 'image.png')
+ .not_to have_test_selector("op-attachment-list-item", text: "image.png")
end
end
end
- context 'for a user lacking edit permissions' do
+ context "for a user lacking edit permissions" do
let!(:dashboard) do
create(:dashboard_with_custom_text, project:)
end
@@ -167,15 +167,15 @@
dashboard_page.visit!
end
- it 'allows reading but not editing the custom text' do
- custom_text_widget = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ it "allows reading but not editing the custom text" do
+ custom_text_widget = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
within custom_text_widget.area do
expect(page)
.to have_content(dashboard.widgets.first.options[:text])
expect(page)
- .to have_no_css('.inplace-editing--container')
+ .to have_no_css(".inplace-editing--container")
end
end
end
diff --git a/modules/dashboards/spec/features/docments_spec.rb b/modules/dashboards/spec/features/docments_spec.rb
index adc46559269f..55d63695cbff 100644
--- a/modules/dashboards/spec/features/docments_spec.rb
+++ b/modules/dashboards/spec/features/docments_spec.rb
@@ -26,17 +26,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/dashboard'
+require_relative "../support/pages/dashboard"
-RSpec.describe 'Documents widget on dashboard', :js do
+RSpec.describe "Documents widget on dashboard", :js do
let!(:project) { create(:project) }
let!(:other_project) { create(:project) }
let!(:visible_document) do
create(:document,
project:,
- description: 'blubs')
+ description: "blubs")
end
let!(:invisible_document) do
create(:document,
@@ -64,11 +64,11 @@
dashboard.visit!
end
- it 'can add the widget and see the visible documents' do
+ it "can add the widget and see the visible documents" do
# within top-right area, add an additional widget
- dashboard.add_widget(1, 1, :within, 'Documents')
+ dashboard.add_widget(1, 1, :within, "Documents")
- document_widget = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ document_widget = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
within document_widget.area do
expect(page)
@@ -76,7 +76,7 @@
expect(page)
.to have_content visible_document.description
expect(page)
- .to have_content visible_document.created_at.strftime('%m/%d/%Y')
+ .to have_content visible_document.created_at.strftime("%m/%d/%Y")
expect(page)
.to have_no_content invisible_document.title
diff --git a/modules/dashboards/spec/features/members_principals_spec.rb b/modules/dashboards/spec/features/members_principals_spec.rb
index bed0d1f449bc..b40184e3431b 100644
--- a/modules/dashboards/spec/features/members_principals_spec.rb
+++ b/modules/dashboards/spec/features/members_principals_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/dashboard'
+require_relative "../support/pages/dashboard"
-RSpec.describe 'Dashboard page members', :js do
+RSpec.describe "Dashboard page members", :js do
shared_let(:type) { create(:type) }
- shared_let(:project) { create(:project, types: [type], description: 'My **custom** description') }
+ shared_let(:project) { create(:project, types: [type], description: "My **custom** description") }
shared_let(:permissions) do
%i[manage_dashboards
@@ -42,20 +42,20 @@
shared_let(:user) do
create(:user,
- firstname: 'Foo',
- lastname: 'Bar',
+ firstname: "Foo",
+ lastname: "Bar",
member_with_permissions: { project => permissions })
end
shared_let(:group) do
create(:group,
- name: 'DEV Team',
+ name: "DEV Team",
member_with_permissions: { project => permissions })
end
shared_let(:placeholder) do
create(:placeholder_user,
- name: 'DEVELOPER PLACEHOLDER',
+ name: "DEVELOPER PLACEHOLDER",
member_with_permissions: { project => permissions })
end
@@ -69,21 +69,21 @@
dashboard_page.visit!
end
- it 'renders the default view, allows altering and saving' do
+ it "renders the default view, allows altering and saving" do
# within top-right area, add an additional widget
- dashboard_page.add_widget(1, 1, :within, 'Members')
+ dashboard_page.add_widget(1, 1, :within, "Members")
- members_block = page.find('.widget-box', text: 'MEMBERS')
+ members_block = page.find(".widget-box", text: "MEMBERS")
within(members_block) do
- user_link = find('op-principal a', text: user.name)
- expect(user_link['href']).to end_with user_path(user.id)
+ user_link = find("op-principal a", text: user.name)
+ expect(user_link["href"]).to end_with user_path(user.id)
- group_link = find('op-principal a', text: group.name)
- expect(group_link['href']).to end_with show_group_path(group.id)
+ group_link = find("op-principal a", text: group.name)
+ expect(group_link["href"]).to end_with show_group_path(group.id)
- placeholder_link = find('op-principal a', text: placeholder.name)
- expect(placeholder_link['href']).to end_with placeholder_user_path(placeholder.id)
+ placeholder_link = find("op-principal a", text: placeholder.name)
+ expect(placeholder_link["href"]).to end_with placeholder_user_path(placeholder.id)
end
end
end
diff --git a/modules/dashboards/spec/features/members_spec.rb b/modules/dashboards/spec/features/members_spec.rb
index 4271a970c33b..816a126c347e 100644
--- a/modules/dashboards/spec/features/members_spec.rb
+++ b/modules/dashboards/spec/features/members_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/dashboard'
+require_relative "../support/pages/dashboard"
-RSpec.describe 'Members widget on dashboard', :js do
+RSpec.describe "Members widget on dashboard", :js do
let!(:project) { create(:project) }
let!(:other_project) { create(:project) }
@@ -99,11 +99,11 @@ def expect_all_members_visible(area)
end
end
- it 'can add the widget and see the members if the permissions suffice' do
+ it "can add the widget and see the members if the permissions suffice" do
# within top-right area, add an additional widget
- dashboard.add_widget(1, 1, :within, 'Members')
+ dashboard.add_widget(1, 1, :within, "Members")
- members_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ members_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
expect_all_members_visible(members_area.area)
@@ -112,7 +112,7 @@ def expect_all_members_visible(area)
within members_area.area do
expect(page)
- .to have_link('Member')
+ .to have_link("Member")
end
# A user without edit permission will see the members but cannot add one
@@ -125,7 +125,7 @@ def expect_all_members_visible(area)
within members_area.area do
expect(page)
- .to have_no_link('Member')
+ .to have_no_link("Member")
end
# A user without view permission will not see any members
@@ -140,13 +140,13 @@ def expect_all_members_visible(area)
.to have_no_content manager_user.name
expect(page)
- .to have_content('No visible members')
+ .to have_content("No visible members")
expect(page)
- .to have_no_link('Member')
+ .to have_no_link("Member")
expect(page)
- .to have_no_link('View all members')
+ .to have_no_link("View all members")
end
end
end
diff --git a/modules/dashboards/spec/features/modifying_with_unallowed_spec.rb b/modules/dashboards/spec/features/modifying_with_unallowed_spec.rb
index fa7a1d0a8aee..92f730188cc9 100644
--- a/modules/dashboards/spec/features/modifying_with_unallowed_spec.rb
+++ b/modules/dashboards/spec/features/modifying_with_unallowed_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/dashboard'
+require_relative "../support/pages/dashboard"
-RSpec.describe 'Modifying a dashboard which already has widgets for which permissions are lacking', :js do
+RSpec.describe "Modifying a dashboard which already has widgets for which permissions are lacking", :js do
let!(:project) do
create(:project)
end
@@ -60,12 +60,12 @@
dashboard_page.visit!
end
- it 'can add and modify widgets' do
+ it "can add and modify widgets" do
dashboard_page.add_widget(dashboard.row_count, dashboard.column_count, :row, "News")
sleep(0.1)
- news_widget = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(2)')
+ news_widget = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(2)")
within news_widget.area do
expect(page)
@@ -76,7 +76,7 @@
dashboard_page.visit!
- news_widget = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(2)')
+ news_widget = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(2)")
within news_widget.area do
expect(page)
@@ -90,6 +90,6 @@
dashboard_page.visit!
expect(page)
- .to have_no_css('.grid--area.-widgeted:nth-of-type(2)')
+ .to have_no_css(".grid--area.-widgeted:nth-of-type(2)")
end
end
diff --git a/modules/dashboards/spec/features/navigation_spec.rb b/modules/dashboards/spec/features/navigation_spec.rb
index eabaca0e1bce..67a771cb5606 100644
--- a/modules/dashboards/spec/features/navigation_spec.rb
+++ b/modules/dashboards/spec/features/navigation_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Navigate to dashboard', :js do
+RSpec.describe "Navigate to dashboard", :js do
let(:project) { create(:project) }
let(:permissions) { [:view_dashboards] }
let(:user) do
@@ -40,16 +40,16 @@
login_as user
end
- it 'can visit the dashboard' do
+ it "can visit the dashboard" do
visit project_path(project)
- within '#menu-sidebar' do
+ within "#menu-sidebar" do
click_link "Dashboard"
end
- within '#content' do
+ within "#content" do
expect(page)
- .to have_content('Dashboard')
+ .to have_content("Dashboard")
end
end
end
diff --git a/modules/dashboards/spec/features/news_spec.rb b/modules/dashboards/spec/features/news_spec.rb
index 1c395aa6b68a..ffb7cdc4451d 100644
--- a/modules/dashboards/spec/features/news_spec.rb
+++ b/modules/dashboards/spec/features/news_spec.rb
@@ -26,17 +26,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/dashboard'
+require_relative "../support/pages/dashboard"
-RSpec.describe 'News widget on dashboard', :js do
+RSpec.describe "News widget on dashboard", :js do
let!(:project) { create(:project) }
let!(:other_project) { create(:project) }
let!(:visible_news) do
create(:news,
project:,
- description: 'blubs')
+ description: "blubs")
end
let!(:invisible_news) do
create(:news,
@@ -65,11 +65,11 @@
dashboard.visit!
end
- it 'can add the widget and see the visible news' do
+ it "can add the widget and see the visible news" do
# within top-right area, add an additional widget
- dashboard.add_widget(1, 1, :within, 'News')
+ dashboard.add_widget(1, 1, :within, "News")
- news_widget = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ news_widget = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
within news_widget.area do
expect(page)
@@ -79,7 +79,7 @@
expect(page)
.to have_content visible_news.project.name
expect(page)
- .to have_content visible_news.created_at.strftime('%m/%d/%Y')
+ .to have_content visible_news.created_at.strftime("%m/%d/%Y")
expect(page)
.to have_no_content invisible_news.title
diff --git a/modules/dashboards/spec/features/project_description_spec.rb b/modules/dashboards/spec/features/project_description_spec.rb
index f52f5f925273..0ecb4cd62105 100644
--- a/modules/dashboards/spec/features/project_description_spec.rb
+++ b/modules/dashboards/spec/features/project_description_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/dashboard'
+require_relative "../support/pages/dashboard"
-RSpec.describe 'Project description widget on dashboard', :js do
+RSpec.describe "Project description widget on dashboard", :js do
let(:project_description) { "Some text I like to write" }
let!(:project) do
create(:project, description: project_description)
@@ -63,7 +63,7 @@ def add_project_description_widget
dashboard_page.visit!
dashboard_page.add_widget(1, 1, :within, "Project description")
- dashboard_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ dashboard_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
end
before do
@@ -71,12 +71,12 @@ def add_project_description_widget
add_project_description_widget
end
- context 'without editing permissions' do
+ context "without editing permissions" do
let(:current_user) { read_only_user }
- it 'can add the widget, but not edit the description' do
+ it "can add the widget, but not edit the description" do
# As the user lacks the manage_public_queries and save_queries permission, no other widget is present
- description_widget = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ description_widget = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
within(description_widget.area) do
# The description is visible
@@ -84,41 +84,41 @@ def add_project_description_widget
.to have_content(project_description)
# The description is not editable
- field = TextEditorField.new dashboard_page, 'description'
+ field = TextEditorField.new dashboard_page, "description"
field.expect_read_only
field.activate! expect_open: false
end
end
end
- context 'with editing permissions' do
+ context "with editing permissions" do
let(:current_user) { editing_user }
- it 'can edit the description' do
+ it "can edit the description" do
# As the user lacks the manage_public_queries and save_queries permission, no other widget is present
- description_widget = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ description_widget = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
within(description_widget.area) do
# Open description field
- field = TextEditorField.new dashboard_page, 'description'
+ field = TextEditorField.new dashboard_page, "description"
field.activate!
sleep(0.1)
# Change the value
field.expect_value(project_description)
- field.set_value 'A completely new description which is super cool.'
+ field.set_value "A completely new description which is super cool."
field.save!
# The edit field is toggled and the value saved.
- expect(page).to have_content('A completely new description which is super cool.')
+ expect(page).to have_content("A completely new description which is super cool.")
expect(page).to have_selector(field.selector)
expect(page).to have_no_selector(field.input_selector)
end
end
end
- context 'with editing and wp add permissions' do
- let!(:type) { create(:type_task, name: 'Task') }
+ context "with editing and wp add permissions" do
+ let!(:type) { create(:type_task, name: "Task") }
let!(:project) do
create(:project, types: [type])
end
@@ -126,26 +126,26 @@ def add_project_description_widget
let(:current_user) do
create(:user, member_with_permissions: { project => editing_permissions + %i[add_work_packages] })
end
- let(:editor) { Components::WysiwygEditor.new 'body' }
+ let(:editor) { Components::WysiwygEditor.new "body" }
- it 'can create a button macro for work packages' do
+ it "can create a button macro for work packages" do
# As the user lacks the manage_public_queries and save_queries permission, no other widget is present
- description_widget = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ description_widget = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
- field = TextEditorField.new dashboard_page, 'description'
+ field = TextEditorField.new dashboard_page, "description"
field.activate!
- editor.insert_macro 'Insert create work package button'
+ editor.insert_macro "Insert create work package button"
- expect(page).to have_css('.spot-modal')
- select 'Task', from: 'selected-type'
- find('.spot-modal--submit-button').click
+ expect(page).to have_css(".spot-modal")
+ select "Task", from: "selected-type"
+ find(".spot-modal--submit-button").click
field.save!
- dashboard_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ dashboard_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
- within('#content') do
+ within("#content") do
expect(page).to have_css("a[href=\"/projects/#{project.identifier}/work_packages/new?type=#{type.id}\"]")
end
end
diff --git a/modules/dashboards/spec/features/project_status_spec.rb b/modules/dashboards/spec/features/project_status_spec.rb
index c21de976426a..e98f642bcf13 100644
--- a/modules/dashboards/spec/features/project_status_spec.rb
+++ b/modules/dashboards/spec/features/project_status_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/dashboard'
+require_relative "../support/pages/dashboard"
-RSpec.describe 'Project status widget on dashboard', :js do
+RSpec.describe "Project status widget on dashboard", :js do
let!(:project) do
create(:project,
- status_code: 'on_track',
- status_explanation: 'some explanation')
+ status_code: "on_track",
+ status_explanation: "some explanation")
end
let(:read_only_permissions) do
@@ -65,7 +65,7 @@ def add_project_status_widget
dashboard_page.visit!
dashboard_page.add_widget(1, 1, :within, "Project status")
- dashboard_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ dashboard_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
end
before do
@@ -73,77 +73,77 @@ def add_project_status_widget
add_project_status_widget
end
- context 'without editing permissions' do
+ context "without editing permissions" do
let(:current_user) { read_only_user }
- it 'can add the widget, but not edit the status' do
+ it "can add the widget, but not edit the status" do
# As the user lacks the manage_public_queries and save_queries permission, no other widget is present
- status_widget = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ status_widget = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
within(status_widget.area) do
# The description is visible
expect(page)
- .to have_content('ON TRACK')
+ .to have_content("ON TRACK")
expect(page)
.to have_content(project.status_explanation)
# The status selector does not open
- field = EditField.new(dashboard_page, 'status')
+ field = EditField.new(dashboard_page, "status")
field.expect_read_only
field.activate! expect_open: false
# The explanation is not editable
- field = TextEditorField.new(dashboard_page, 'statusExplanation')
+ field = TextEditorField.new(dashboard_page, "statusExplanation")
field.expect_read_only
field.activate! expect_open: false
end
end
end
- context 'with editing permissions' do
+ context "with editing permissions" do
let(:current_user) { editing_user }
- it 'can edit the status and its explanation' do
+ it "can edit the status and its explanation" do
# As the user lacks the manage_public_queries and save_queries permission, no other widget is present
- status_widget = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ status_widget = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
within(status_widget.area) do
# Open status selector
- field = ProjectStatusField.new(dashboard_page, 'status')
+ field = ProjectStatusField.new(dashboard_page, "status")
field.activate!
sleep(0.1)
# Change the value
- field.set_to('AT RISK')
+ field.set_to("AT RISK")
# The edit field is toggled and the value saved.
- expect(page).to have_content('AT RISK', wait: 5)
+ expect(page).to have_content("AT RISK", wait: 5)
expect(page).to have_selector(field.selector)
expect(page).to have_no_selector(field.input_selector)
# Unset the project status
field.activate!
sleep(0.1)
- field.set_to('NOT SET')
+ field.set_to("NOT SET")
# The edit field is toggled and the value saved.
- expect(page).to have_content('NOT SET', wait: 5)
+ expect(page).to have_content("NOT SET", wait: 5)
expect(page).to have_selector(field.selector)
expect(page).to have_no_selector(field.input_selector)
# Open explanation field
- field = TextEditorField.new dashboard_page, 'statusExplanation'
+ field = TextEditorField.new dashboard_page, "statusExplanation"
field.activate!
sleep(0.1)
# Change the value
field.expect_value(project.status_explanation)
- field.set_value 'A completely new explanation which is super cool.'
+ field.set_value "A completely new explanation which is super cool."
field.save!
# The edit field is toggled and the value saved.
- expect(page).to have_content('A completely new explanation which is super cool.')
+ expect(page).to have_content("A completely new explanation which is super cool.")
expect(page).to have_selector(field.selector)
expect(page).to have_no_selector(field.input_selector)
end
diff --git a/modules/dashboards/spec/features/read_only_allowed_spec.rb b/modules/dashboards/spec/features/read_only_allowed_spec.rb
index 200fce2baa35..1e40c8eb5376 100644
--- a/modules/dashboards/spec/features/read_only_allowed_spec.rb
+++ b/modules/dashboards/spec/features/read_only_allowed_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/dashboard'
+require_relative "../support/pages/dashboard"
-RSpec.describe 'Read only mode when user lacks edit permission on dashboard', :js do
+RSpec.describe "Read only mode when user lacks edit permission on dashboard", :js do
let!(:type) { create(:type) }
let!(:project) { create(:project, types: [type]) }
let!(:work_package) do
@@ -71,11 +71,11 @@
dashboard_page.visit!
end
- it 'can not modify the dashboard but can still use it' do
+ it "can not modify the dashboard but can still use it" do
dashboard_page.expect_unable_to_add_widget(dashboard.row_count, dashboard.column_count, :row)
dashboard_page.expect_no_help_mode
- table_widget = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ table_widget = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
table_widget.expect_not_resizable
diff --git a/modules/dashboards/spec/features/subprojects_spec.rb b/modules/dashboards/spec/features/subprojects_spec.rb
index 998df3e57fe9..a1ed89d18890 100644
--- a/modules/dashboards/spec/features/subprojects_spec.rb
+++ b/modules/dashboards/spec/features/subprojects_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/dashboard'
+require_relative "../support/pages/dashboard"
-RSpec.describe 'Subprojects widget on dashboard', :js do
+RSpec.describe "Subprojects widget on dashboard", :js do
let!(:project) do
create(:project, parent: parent_project)
end
@@ -73,14 +73,14 @@
Pages::Dashboard.new(project)
end
- context 'as a user' do
+ context "as a user" do
current_user { user }
- it 'can add the widget listing active subprojects the user is member of', :aggregate_failures do
+ it "can add the widget listing active subprojects the user is member of", :aggregate_failures do
dashboard_page.visit!
dashboard_page.add_widget(1, 1, :within, "Subprojects")
- subprojects_widget = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ subprojects_widget = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
expect(page)
.to have_link(child_project.name)
@@ -102,14 +102,14 @@
end
end
- context 'as an admin' do
+ context "as an admin" do
current_user { create(:admin) }
- it 'can add the widget listing all active subprojects', :aggregate_failures do
+ it "can add the widget listing all active subprojects", :aggregate_failures do
dashboard_page.visit!
dashboard_page.add_widget(1, 2, :within, "Subprojects")
- subprojects_widget = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(2)')
+ subprojects_widget = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(2)")
within(subprojects_widget.area) do
expect(page)
diff --git a/modules/dashboards/spec/features/time_entries_spec.rb b/modules/dashboards/spec/features/time_entries_spec.rb
index 8a0216cbe64c..07a09423d623 100644
--- a/modules/dashboards/spec/features/time_entries_spec.rb
+++ b/modules/dashboards/spec/features/time_entries_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/dashboard'
+require_relative "../support/pages/dashboard"
-RSpec.describe 'Time entries widget on dashboard', :js do
+RSpec.describe "Time entries widget on dashboard", :js do
let!(:type) { create(:type) }
let!(:project) { create(:project, types: [type]) }
let!(:other_project) { create(:project, types: [type]) }
@@ -47,7 +47,7 @@
user:,
spent_on: Date.today,
hours: 6,
- comments: 'My comment')
+ comments: "My comment")
end
let!(:other_visible_time_entry) do
create(:time_entry,
@@ -56,7 +56,7 @@
user: other_user,
spent_on: Date.today - 1.day,
hours: 5,
- comments: 'Another`s comment')
+ comments: "Another`s comment")
end
let!(:invisible_time_entry) do
create(:time_entry,
@@ -95,37 +95,37 @@
dashboard.visit!
end
- it 'adds the widget and checks the displayed entries' do
+ it "adds the widget and checks the displayed entries" do
# within top-right area, add an additional widget
dashboard.add_widget(1, 1, :within, 'Spent time \(last 7 days\)')
- spent_time_widget = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ spent_time_widget = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
within spent_time_widget.area do
expect(page)
.to have_content "Total: 11 h"
expect(page)
- .to have_content Date.today.strftime('%m/%d/%Y')
+ .to have_content Date.today.strftime("%m/%d/%Y")
expect(page)
- .to have_css('.activity', text: visible_time_entry.activity.name)
+ .to have_css(".activity", text: visible_time_entry.activity.name)
expect(page)
- .to have_css('.subject', text: "#{project.name} - ##{work_package.id}: #{work_package.subject}")
+ .to have_css(".subject", text: "#{project.name} - ##{work_package.id}: #{work_package.subject}")
expect(page)
- .to have_css('.comments', text: visible_time_entry.comments)
+ .to have_css(".comments", text: visible_time_entry.comments)
expect(page)
- .to have_css('.hours', text: visible_time_entry.hours)
+ .to have_css(".hours", text: visible_time_entry.hours)
expect(page)
- .to have_content((Date.today - 1.day).strftime('%m/%d/%Y'))
+ .to have_content((Date.today - 1.day).strftime("%m/%d/%Y"))
expect(page)
- .to have_css('.activity', text: other_visible_time_entry.activity.name)
+ .to have_css(".activity", text: other_visible_time_entry.activity.name)
expect(page)
- .to have_css('.subject', text: "#{project.name} - ##{work_package.id}: #{work_package.subject}")
+ .to have_css(".subject", text: "#{project.name} - ##{work_package.id}: #{work_package.subject}")
expect(page)
- .to have_css('.comments', text: other_visible_time_entry.comments)
+ .to have_css(".comments", text: other_visible_time_entry.comments)
expect(page)
- .to have_css('.hours', text: other_visible_time_entry.hours)
+ .to have_css(".hours", text: other_visible_time_entry.hours)
# Allows to edit
page.find_test_selector("edit-time-entry-#{visible_time_entry.id}").click
@@ -135,15 +135,15 @@
time_logging_modal.expect_work_package work_package.subject
- time_logging_modal.update_field 'hours', 4
+ time_logging_modal.update_field "hours", 4
sleep(0.1)
- time_logging_modal.perform_action 'Save'
+ time_logging_modal.perform_action "Save"
time_logging_modal.is_visible false
within spent_time_widget.area do
- expect(page).to have_css('.hours', text: 4)
+ expect(page).to have_css(".hours", text: 4)
end
visible_time_entry.reload
diff --git a/modules/dashboards/spec/features/work_package_calendar_spec.rb b/modules/dashboards/spec/features/work_package_calendar_spec.rb
index f217ef8b7f06..7732d798f142 100644
--- a/modules/dashboards/spec/features/work_package_calendar_spec.rb
+++ b/modules/dashboards/spec/features/work_package_calendar_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/dashboard'
+require_relative "../support/pages/dashboard"
-RSpec.describe 'Work package calendar widget on dashboard', :js do
+RSpec.describe "Work package calendar widget on dashboard", :js do
let!(:type) { create(:type) }
let!(:priority) { create(:default_priority) }
let!(:project) { create(:project, types: [type]) }
@@ -38,7 +38,7 @@
let!(:open_status) { create(:default_status) }
let!(:spanning_work_package) do
create(:work_package,
- subject: 'Spanning work package',
+ subject: "Spanning work package",
project:,
start_date: Date.today - 8.days,
due_date: Date.today + 8.days,
@@ -48,7 +48,7 @@
end
let!(:starting_work_package) do
create(:work_package,
- subject: 'Starting work package',
+ subject: "Starting work package",
project:,
start_date: Date.today,
due_date: Date.today + 8.days,
@@ -58,7 +58,7 @@
end
let!(:ending_work_package) do
create(:work_package,
- subject: 'Ending work package',
+ subject: "Ending work package",
project:,
start_date: Date.today - 8.days,
due_date: Date.today,
@@ -68,7 +68,7 @@
end
let!(:outdated_work_package) do
create(:work_package,
- subject: 'Outdated work package',
+ subject: "Outdated work package",
project:,
start_date: Date.today - 9.days,
due_date: Date.today - 7.days,
@@ -78,7 +78,7 @@
end
let!(:other_project_work_package) do
create(:work_package,
- subject: 'Other project work package',
+ subject: "Other project work package",
project: other_project,
start_date: Date.today - 9.days,
due_date: Date.today + 7.days,
@@ -114,29 +114,29 @@
dashboard.visit!
end
- it 'can add the widget and see the work packages of the project' do
+ it "can add the widget and see the work packages of the project" do
dashboard.add_widget(1, 1, :within, "Calendar")
sleep(0.1)
# As the user lacks the necessary permissions, no widget is preconfigured
- calendar_widget = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ calendar_widget = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
within(calendar_widget.area) do
expect(page)
- .to have_css('.fc-event-title', text: spanning_work_package.subject)
+ .to have_css(".fc-event-title", text: spanning_work_package.subject)
expect(page)
- .to have_css('.fc-event-title', text: starting_work_package.subject)
+ .to have_css(".fc-event-title", text: starting_work_package.subject)
expect(page)
- .to have_css('.fc-event-title', text: ending_work_package.subject)
+ .to have_css(".fc-event-title", text: ending_work_package.subject)
expect(page)
- .to have_no_css('.fc-event-title', text: outdated_work_package.subject)
+ .to have_no_css(".fc-event-title", text: outdated_work_package.subject)
expect(page)
- .to have_no_css('.fc-event-title', text: other_project_work_package.subject)
+ .to have_no_css(".fc-event-title", text: other_project_work_package.subject)
end
end
end
diff --git a/modules/dashboards/spec/features/work_package_graph_overview_spec.rb b/modules/dashboards/spec/features/work_package_graph_overview_spec.rb
index d4ce90faaf70..10346966bbe8 100644
--- a/modules/dashboards/spec/features/work_package_graph_overview_spec.rb
+++ b/modules/dashboards/spec/features/work_package_graph_overview_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/dashboard'
+require_relative "../support/pages/dashboard"
-RSpec.describe 'Work package overview graph widget on dashboard', :js do
+RSpec.describe "Work package overview graph widget on dashboard", :js do
let!(:type) { create(:type) }
let!(:priority) { create(:default_priority) }
let!(:project) { create(:project, types: [type]) }
@@ -38,7 +38,7 @@
let!(:closed_status) { create(:closed_status) }
let!(:open_work_package) do
create(:work_package,
- subject: 'Spanning work package',
+ subject: "Spanning work package",
project:,
status: open_status,
type:,
@@ -47,7 +47,7 @@
end
let!(:closed) do
create(:work_package,
- subject: 'Starting work package',
+ subject: "Starting work package",
project:,
status: closed_status,
type:,
@@ -82,13 +82,13 @@
end
# As a graph is rendered as a canvas, we have limited abilities to test the widget
- it 'can add the widget' do
+ it "can add the widget" do
sleep(0.1)
dashboard.add_widget(1, 1, :within, "Work packages overview")
# As the user lacks the necessary permissions, no widget is preconfigured
- overview_widget = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ overview_widget = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
overview_widget.expect_to_span(1, 1, 2, 2)
end
diff --git a/modules/dashboards/spec/features/work_package_graph_spec.rb b/modules/dashboards/spec/features/work_package_graph_spec.rb
index e92115db6a30..179378f9abcf 100644
--- a/modules/dashboards/spec/features/work_package_graph_spec.rb
+++ b/modules/dashboards/spec/features/work_package_graph_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/dashboard'
+require_relative "../support/pages/dashboard"
-RSpec.describe 'Arbitrary WorkPackage query graph widget dashboard', :js, with_ee: %i[grid_widget_wp_graph] do
+RSpec.describe "Arbitrary WorkPackage query graph widget dashboard", :js, with_ee: %i[grid_widget_wp_graph] do
let!(:type) { create(:type) }
let!(:other_type) { create(:type) }
let!(:priority) { create(:default_priority) }
@@ -96,8 +96,8 @@
dashboard_page.visit!
end
- context 'with the permission to save queries' do
- it 'can add the widget and see the work packages of the filtered for types' do
+ context "with the permission to save queries" do
+ it "can add the widget and see the work packages of the filtered for types" do
expect(page)
.to have_content(type_work_package.subject)
@@ -105,7 +105,7 @@
sleep(1)
- filter_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(2)')
+ filter_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(2)")
filter_area.expect_to_span(1, 1, 2, 2)
@@ -114,15 +114,15 @@
# User has the ability to modify the query
filter_area.configure_wp_table
- modal.switch_to('Filters')
+ modal.switch_to("Filters")
filters.expect_filter_count(2)
- filters.add_filter_by('Type', 'is (OR)', type.name)
+ filters.add_filter_by("Type", "is (OR)", type.name)
modal.save
filter_area.configure_wp_table
- modal.switch_to('General')
- general.set_axis 'Type'
- general.set_type 'Bar'
+ modal.switch_to("General")
+ general.set_axis "Type"
+ general.set_type "Bar"
modal.save
sleep(0.5)
@@ -137,36 +137,36 @@
.to have_content(type_work_package.subject)
filter_area.configure_wp_table
- modal.switch_to('Filters')
+ modal.switch_to("Filters")
filters.expect_filter_count(3)
- modal.switch_to('General')
- general.expect_axis 'Type'
- general.expect_type 'Bar'
+ modal.switch_to("General")
+ general.expect_axis "Type"
+ general.expect_type "Bar"
# A notification is displayed if no work package is returned for the graph
- modal.switch_to('Filters')
- filters.add_filter_by('Subject', 'contains', '!!!!!!!!!!!!!!!!!')
+ modal.switch_to("Filters")
+ filters.add_filter_by("Subject", "contains", "!!!!!!!!!!!!!!!!!")
modal.save
within filter_area.area do
expect(page)
- .to have_content(I18n.t('js.work_packages.no_results.title'))
+ .to have_content(I18n.t("js.work_packages.no_results.title"))
end
end
end
- context 'without the permission to save queries' do
+ context "without the permission to save queries" do
let(:permissions) { %i[view_work_packages add_work_packages view_dashboards manage_dashboards] }
- it 'cannot add the widget' do
+ it "cannot add the widget" do
dashboard_page.expect_unable_to_add_widget(1, 1, :within, "Work packages graph")
end
end
- context 'without an enterprise edition', with_ee: false do
- it 'cannot add the widget and receives an enterprise edition notice' do
+ context "without an enterprise edition", with_ee: false do
+ it "cannot add the widget and receives an enterprise edition notice" do
dashboard_page.expect_add_widget_enterprise_edition_notice(1, 2, :within)
# At this point the add widget modal is open
diff --git a/modules/dashboards/spec/features/work_package_table_spec.rb b/modules/dashboards/spec/features/work_package_table_spec.rb
index 26165c9f61cd..1c56ca645313 100644
--- a/modules/dashboards/spec/features/work_package_table_spec.rb
+++ b/modules/dashboards/spec/features/work_package_table_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/dashboard'
+require_relative "../support/pages/dashboard"
-RSpec.describe 'Arbitrary WorkPackage query table widget dashboard', :js do
+RSpec.describe "Arbitrary WorkPackage query table widget dashboard", :js do
let!(:type) { create(:type) }
let!(:other_type) { create(:type) }
let!(:priority) { create(:default_priority) }
@@ -92,63 +92,63 @@
dashboard_page.visit!
end
- context 'with the permission to save queries' do
- it 'can add the widget and see the work packages of the filtered for types' do
+ context "with the permission to save queries" do
+ it "can add the widget and see the work packages of the filtered for types" do
# This one always exists by default.
# Using it here as a safeguard to govern speed.
- wp_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ wp_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
expect(wp_area)
- .to have_css('.subject', text: type_work_package.subject)
+ .to have_css(".subject", text: type_work_package.subject)
dashboard_page.add_widget(1, 1, :row, "Work packages table")
- filter_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(2)')
+ filter_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(2)")
filter_area.expect_to_span(1, 1, 2, 3)
# At the beginning, the default query is displayed
expect(filter_area.area)
- .to have_css('.subject', text: type_work_package.subject, wait: 30)
+ .to have_css(".subject", text: type_work_package.subject, wait: 30)
expect(filter_area.area)
- .to have_css('.subject', text: other_type_work_package.subject)
+ .to have_css(".subject", text: other_type_work_package.subject)
# Work packages from other projects are not displayed as the query is project scoped
expect(filter_area.area)
- .to have_no_css('.subject', text: other_project_work_package.subject)
+ .to have_no_css(".subject", text: other_project_work_package.subject)
# User has the ability to modify the query
filter_area.configure_wp_table
- modal.switch_to('Filters')
+ modal.switch_to("Filters")
filters.expect_filter_count(2)
- filters.add_filter_by('Type', 'is (OR)', type.name)
+ filters.add_filter_by("Type", "is (OR)", type.name)
modal.save
filter_area.configure_wp_table
- modal.switch_to('Columns')
+ modal.switch_to("Columns")
columns.assume_opened
- columns.remove 'Subject'
+ columns.remove "Subject"
expect(filter_area.area)
- .to have_css('.id', text: type_work_package.id)
+ .to have_css(".id", text: type_work_package.id)
# as the Subject column is disabled
expect(filter_area.area)
- .to have_no_css('.subject', text: type_work_package.subject)
+ .to have_no_css(".subject", text: type_work_package.subject)
# As other_type is filtered out
expect(filter_area.area)
- .to have_no_css('.id', text: other_type_work_package.id)
+ .to have_no_css(".id", text: other_type_work_package.id)
# Work packages from other projects are not displayed as the query is project scoped
expect(filter_area.area)
- .to have_no_css('.subject', text: other_project_work_package.subject)
+ .to have_no_css(".subject", text: other_project_work_package.subject)
scroll_to_element(filter_area.area)
within filter_area.area do
- input = find('.editable-toolbar-title--input')
- input.set('My WP Filter')
+ input = find(".editable-toolbar-title--input")
+ input.set("My WP Filter")
input.native.send_keys(:return)
end
@@ -160,32 +160,32 @@
visit root_path
dashboard_page.visit!
- filter_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(2)')
+ filter_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(2)")
expect(filter_area.area)
- .to have_css('.id', text: type_work_package.id)
+ .to have_css(".id", text: type_work_package.id)
# as the Subject column is disabled
expect(filter_area.area)
- .to have_no_css('.subject', text: type_work_package.subject)
+ .to have_no_css(".subject", text: type_work_package.subject)
# As other_type is filtered out
expect(filter_area.area)
- .to have_no_css('.id', text: other_type_work_package.id)
+ .to have_no_css(".id", text: other_type_work_package.id)
# Work packages from other projects are not displayed as the query is project scoped
expect(filter_area.area)
- .to have_no_css('.subject', text: other_project_work_package.subject)
+ .to have_no_css(".subject", text: other_project_work_package.subject)
within filter_area.area do
- expect(page).to have_field('editable-toolbar-title', with: 'My WP Filter', wait: 10)
+ expect(page).to have_field("editable-toolbar-title", with: "My WP Filter", wait: 10)
end
end
end
- context 'without the permission to save queries' do
+ context "without the permission to save queries" do
let(:permissions) { %i[view_work_packages add_work_packages view_dashboards manage_dashboards] }
- it 'cannot add the widget' do
+ it "cannot add the widget" do
dashboard_page.expect_unable_to_add_widget(1, 1, :within, "Work packages table")
end
end
diff --git a/modules/dashboards/spec/lib/dashboards/grid_registration_spec.rb b/modules/dashboards/spec/lib/dashboards/grid_registration_spec.rb
index 2ea18b0b7386..7977315b04d0 100644
--- a/modules/dashboards/spec/lib/dashboards/grid_registration_spec.rb
+++ b/modules/dashboards/spec/lib/dashboards/grid_registration_spec.rb
@@ -1,60 +1,60 @@
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Dashboards::GridRegistration do
let(:user) { build_stubbed(:user) }
let(:project) { build_stubbed(:project) }
let(:grid) { build_stubbed(:dashboard, project:) }
- describe 'from_scope' do
- context 'with a relative URL root', with_config: { rails_relative_url_root: '/foobar' } do
- subject { described_class.from_scope '/foobar/projects/an_id/dashboards' }
+ describe "from_scope" do
+ context "with a relative URL root", with_config: { rails_relative_url_root: "/foobar" } do
+ subject { described_class.from_scope "/foobar/projects/an_id/dashboards" }
- it 'returns the class' do
+ it "returns the class" do
expect(subject[:class]).to eq(Grids::Dashboard)
end
- it 'returns the project_id' do
- expect(subject[:project_id]).to eq('an_id')
+ it "returns the project_id" do
+ expect(subject[:project_id]).to eq("an_id")
end
- context 'with a different route' do
- subject { described_class.from_scope '/barfoo/projects/an_id/dashboards' }
+ context "with a different route" do
+ subject { described_class.from_scope "/barfoo/projects/an_id/dashboards" }
- it 'returns nil' do
+ it "returns nil" do
expect(subject).to be_nil
end
end
end
- context 'without a relative URL root' do
- subject { described_class.from_scope '/projects/an_id/dashboards' }
+ context "without a relative URL root" do
+ subject { described_class.from_scope "/projects/an_id/dashboards" }
- it 'returns the class' do
+ it "returns the class" do
expect(subject[:class]).to eq(Grids::Dashboard)
end
- it 'returns the project_id' do
- expect(subject[:project_id]).to eq('an_id')
+ it "returns the project_id" do
+ expect(subject[:project_id]).to eq("an_id")
end
- context 'with a different route' do
- subject { described_class.from_scope '/projects/an_id/boards' }
+ context "with a different route" do
+ subject { described_class.from_scope "/projects/an_id/boards" }
- it 'returns nil' do
+ it "returns nil" do
expect(subject).to be_nil
end
end
end
end
- describe 'defaults' do
- it 'returns the initialized widget' do
+ describe "defaults" do
+ it "returns the initialized widget" do
expect(described_class.defaults[:widgets].map(&:identifier))
.to contain_exactly("work_packages_table")
end
end
- describe 'writable?' do
+ describe "writable?" do
let(:permissions) { [:manage_dashboards] }
let(:allowed) { true }
@@ -64,17 +64,17 @@
end
end
- context 'if the user has the :manage_dashboards permission' do
- it 'is truthy' do
+ context "if the user has the :manage_dashboards permission" do
+ it "is truthy" do
expect(described_class)
.to be_writable(grid, user)
end
end
- context 'if the user lacks the :manage_dashboards permission' do
+ context "if the user lacks the :manage_dashboards permission" do
let(:permissions) { [] }
- it 'is falsey' do
+ it "is falsey" do
expect(described_class)
.not_to be_writable(grid, user)
end
diff --git a/modules/dashboards/spec/requests/api/v3/attachments/grid_spec.rb b/modules/dashboards/spec/requests/api/v3/attachments/grid_spec.rb
index 3a22d712079b..4db064491bfa 100644
--- a/modules/dashboards/spec/requests/api/v3/attachments/grid_spec.rb
+++ b/modules/dashboards/spec/requests/api/v3/attachments/grid_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require Rails.root.join("spec/requests/api/v3/attachments/attachment_resource_shared_examples").to_s
RSpec.describe "grid attachments" do
diff --git a/modules/dashboards/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb b/modules/dashboards/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb
index 995b414361d5..060d3fc02db4 100644
--- a/modules/dashboards/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb
+++ b/modules/dashboards/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
RSpec.describe "POST /api/v3/grids/form for Dashboard Grids", content_type: :json do
include Rack::Test::Methods
@@ -62,15 +62,15 @@
login_as(current_user)
end
- describe '#post' do
+ describe "#post" do
before do
post path, params.to_json
end
- context 'with a valid boards scope' do
+ context "with a valid boards scope" do
let(:params) do
{
- name: 'foo',
+ name: "foo",
_links: {
scope: {
href: project_dashboards_path(project)
@@ -79,7 +79,7 @@
}
end
- it 'contains default data in the payload' do
+ it "contains default data in the payload" do
expected = {
rowCount: 1,
columnCount: 2,
@@ -91,14 +91,14 @@
options: {
name: "Work packages table",
queryProps: {
- 'columns[]': %w(id project type subject),
+ "columns[]": %w(id project type subject),
filters: "[{\"status\":{\"operator\":\"o\",\"values\":[]}}]"
}
},
startColumn: 1,
startRow: 1
}],
- name: 'foo',
+ name: "foo",
options: {},
_links: {
attachments: [],
@@ -111,23 +111,23 @@
expect(subject.body)
.to be_json_eql(expected.to_json)
- .at_path('_embedded/payload')
+ .at_path("_embedded/payload")
end
- it 'has no validationErrors' do
+ it "has no validationErrors" do
expect(subject.body)
.to be_json_eql({}.to_json)
- .at_path('_embedded/validationErrors')
+ .at_path("_embedded/validationErrors")
end
- it 'has a commit link' do
+ it "has a commit link" do
expect(subject.body)
.to be_json_eql(api_v3_paths.grids.to_json)
- .at_path('_links/commit/href')
+ .at_path("_links/commit/href")
end
end
- context 'with boards scope for which the user does not have the necessary permissions' do
+ context "with boards scope for which the user does not have the necessary permissions" do
let(:current_user) { prohibited_user }
let(:params) do
{
@@ -139,14 +139,14 @@
}
end
- it 'has a validationError on scope' do
+ it "has a validationError on scope" do
expect(subject.body)
.to be_json_eql("Scope is not set to one of the allowed values.".to_json)
- .at_path('_embedded/validationErrors/scope/message')
+ .at_path("_embedded/validationErrors/scope/message")
end
end
- context 'with an invalid scope' do
+ context "with an invalid scope" do
let(:params) do
{
_links: {
@@ -157,17 +157,17 @@
}
end
- it 'has a validationError on scope' do
+ it "has a validationError on scope" do
expect(subject.body)
.to be_json_eql("Scope is not set to one of the allowed values.".to_json)
- .at_path('_embedded/validationErrors/scope/message')
+ .at_path("_embedded/validationErrors/scope/message")
end
end
- context 'with an unsupported widget identifier' do
+ context "with an unsupported widget identifier" do
let(:params) do
{
- name: 'foo',
+ name: "foo",
_links: {
attachments: [],
scope: {
@@ -187,18 +187,18 @@
}
end
- it 'has a validationError on widget' do
+ it "has a validationError on widget" do
expect(subject.body)
.to be_json_eql("Widgets is not set to one of the allowed values.".to_json)
- .at_path('_embedded/validationErrors/widgets/message')
+ .at_path("_embedded/validationErrors/widgets/message")
end
end
- context 'for a user not allowed to save queries' do
+ context "for a user not allowed to save queries" do
let(:current_user) { no_save_query_user }
let(:params) do
{
- name: 'foo',
+ name: "foo",
_links: {
scope: {
href: project_dashboards_path(project)
@@ -207,12 +207,12 @@
}
end
- it 'contains default data in the payload that lacks the work_packages_table widget' do
+ it "contains default data in the payload that lacks the work_packages_table widget" do
expected = {
rowCount: 1,
columnCount: 2,
widgets: [],
- name: 'foo',
+ name: "foo",
options: {},
_links: {
attachments: [],
@@ -225,19 +225,19 @@
expect(subject.body)
.to be_json_eql(expected.to_json)
- .at_path('_embedded/payload')
+ .at_path("_embedded/payload")
end
- it 'has no validationErrors' do
+ it "has no validationErrors" do
expect(subject.body)
.to be_json_eql({}.to_json)
- .at_path('_embedded/validationErrors')
+ .at_path("_embedded/validationErrors")
end
- it 'has a commit link' do
+ it "has a commit link" do
expect(subject.body)
.to be_json_eql(api_v3_paths.grids.to_json)
- .at_path('_links/commit/href')
+ .at_path("_links/commit/href")
end
end
end
diff --git a/modules/dashboards/spec/requests/api/v3/grids/grids_resource_spec.rb b/modules/dashboards/spec/requests/api/v3/grids/grids_resource_spec.rb
index 75f72d85e9ce..8c72a2cf752d 100644
--- a/modules/dashboards/spec/requests/api/v3/grids/grids_resource_spec.rb
+++ b/modules/dashboards/spec/requests/api/v3/grids/grids_resource_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'API v3 Grids resource', content_type: :json do
+RSpec.describe "API v3 Grids resource", content_type: :json do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -46,7 +46,7 @@
end
let(:widgets) do
[create(:grid_widget,
- identifier: 'custom_text',
+ identifier: "custom_text",
start_column: 1,
end_column: 3,
start_row: 1,
@@ -63,7 +63,7 @@
subject(:response) { last_response }
- describe '#get' do
+ describe "#get" do
let(:path) { api_v3_paths.grid(grid.id) }
let(:stored_grids) do
@@ -76,42 +76,42 @@
get path
end
- it 'responds with 200 OK' do
+ it "responds with 200 OK" do
expect(subject.status).to eq(200)
end
- it 'sends a grid block' do
+ it "sends a grid block" do
expect(subject.body)
- .to be_json_eql('Grid'.to_json)
- .at_path('_type')
+ .to be_json_eql("Grid".to_json)
+ .at_path("_type")
end
- it 'identifies the url the grid is stored for' do
+ it "identifies the url the grid is stored for" do
expect(subject.body)
.to be_json_eql(project_dashboards_path(project).to_json)
- .at_path('_links/scope/href')
+ .at_path("_links/scope/href")
end
- it 'has a widget that renders custom text' do
+ it "has a widget that renders custom text" do
expect(subject.body)
- .to be_json_eql('custom_text'.to_json)
- .at_path('widgets/0/identifier')
+ .to be_json_eql("custom_text".to_json)
+ .at_path("widgets/0/identifier")
expect(subject.body)
.to be_json_eql(custom_text.to_json)
- .at_path('widgets/0/options/text/raw')
+ .at_path("widgets/0/options/text/raw")
end
- context 'with the grid not existing' do
+ context "with the grid not existing" do
let(:path) { api_v3_paths.grid(grid.id + 1) }
- it 'responds with 404 NOT FOUND' do
+ it "responds with 404 NOT FOUND" do
expect(subject.status).to be 404
end
end
end
- describe '#patch' do
+ describe "#patch" do
let(:path) { api_v3_paths.grid(grid.id) }
let(:stored_grids) do
@@ -123,7 +123,7 @@
let(:params) do
{
rowCount: 10,
- name: 'foo',
+ name: "foo",
columnCount: 15,
widgets: widget_params
}.with_indifferent_access
@@ -135,7 +135,7 @@
patch path, params.to_json
end
- context 'with an added custom_text widget' do
+ context "with an added custom_text widget" do
let(:widget_params) do
[
{
@@ -157,38 +157,38 @@
end
let(:widgets) { [] }
- it 'responds with 200 OK' do
+ it "responds with 200 OK" do
expect(subject.status).to eq(200)
end
- it 'returns the altered grid block with the added widget' do
+ it "returns the altered grid block with the added widget" do
expect(subject.body)
- .to be_json_eql('Grid'.to_json)
- .at_path('_type')
+ .to be_json_eql("Grid".to_json)
+ .at_path("_type")
expect(subject.body)
- .to be_json_eql('foo'.to_json)
- .at_path('name')
+ .to be_json_eql("foo".to_json)
+ .at_path("name")
expect(subject.body)
- .to be_json_eql(params['rowCount'].to_json)
- .at_path('rowCount')
+ .to be_json_eql(params["rowCount"].to_json)
+ .at_path("rowCount")
expect(subject.body)
- .to be_json_eql(params['widgets'][0]['identifier'].to_json)
- .at_path('widgets/0/identifier')
+ .to be_json_eql(params["widgets"][0]["identifier"].to_json)
+ .at_path("widgets/0/identifier")
expect(subject.body)
- .to be_json_eql(params['widgets'][0]['options']['text']['raw'].to_json)
- .at_path('widgets/0/options/text/raw')
+ .to be_json_eql(params["widgets"][0]["options"]["text"]["raw"].to_json)
+ .at_path("widgets/0/options/text/raw")
expect(subject.body)
- .to be_json_eql(params['widgets'][0]['options']['name'].to_json)
- .at_path('widgets/0/options/name')
+ .to be_json_eql(params["widgets"][0]["options"]["name"].to_json)
+ .at_path("widgets/0/options/name")
end
- it 'perists the changes' do
+ it "perists the changes" do
expect(grid.reload.row_count)
- .to eql params['rowCount']
- expect(grid.reload.widgets[0].options['text'])
- .to eql params['widgets'][0]['options']['text']['raw']
- expect(grid.reload.widgets[0].options['name'])
- .to eql params['widgets'][0]['options']['name']
+ .to eql params["rowCount"]
+ expect(grid.reload.widgets[0].options["text"])
+ .to eql params["widgets"][0]["options"]["text"]["raw"]
+ expect(grid.reload.widgets[0].options["name"])
+ .to eql params["widgets"][0]["options"]["name"]
end
end
end
diff --git a/modules/dashboards/spec/support/pages/dashboard.rb b/modules/dashboards/spec/support/pages/dashboard.rb
index e3e5039aea9d..e9d52806b797 100644
--- a/modules/dashboards/spec/support/pages/dashboard.rb
+++ b/modules/dashboards/spec/support/pages/dashboard.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'support/pages/page'
+require "support/pages/page"
-require_relative '../../../../grids/spec/support/pages/grid'
+require_relative "../../../../grids/spec/support/pages/grid"
module Pages
class Dashboard < ::Pages::Grid
diff --git a/modules/documents/app/controllers/documents_controller.rb b/modules/documents/app/controllers/documents_controller.rb
index a0ed79f2645a..e61fb96387a4 100644
--- a/modules/documents/app/controllers/documents_controller.rb
+++ b/modules/documents/app/controllers/documents_controller.rb
@@ -36,15 +36,15 @@ class DocumentsController < ApplicationController
before_action :authorize
def index
- @group_by = %w(category date title author).include?(params[:group_by]) ? params[:group_by] : 'category'
+ @group_by = %w(category date title author).include?(params[:group_by]) ? params[:group_by] : "category"
documents = @project.documents
@grouped =
case @group_by
- when 'date'
+ when "date"
documents.group_by { |d| d.updated_at.to_date }
- when 'title'
+ when "title"
documents.group_by { |d| d.title.first.upcase }
- when 'author'
+ when "author"
documents.with_attachments.group_by { |d| d.attachments.last.author }
else
documents.includes(:category).group_by(&:category)
@@ -54,7 +54,7 @@ def index
end
def show
- @attachments = @document.attachments.order(Arel.sql('created_at DESC'))
+ @attachments = @document.attachments.order(Arel.sql("created_at DESC"))
end
def new
@@ -71,7 +71,7 @@ def create
redirect_to project_documents_path(@project)
else
@document = call.result
- render action: 'new'
+ render action: "new"
end
end
@@ -86,21 +86,21 @@ def update
if call.success?
flash[:notice] = I18n.t(:notice_successful_update)
- redirect_to action: 'show', id: @document
+ redirect_to action: "show", id: @document
else
@document = call.result
- render action: 'edit'
+ render action: "edit"
end
end
def destroy
@document.destroy
- redirect_to controller: '/documents', action: 'index', project_id: @project
+ redirect_to controller: "/documents", action: "index", project_id: @project
end
private
def document_params
- params.fetch(:document, {}).permit('category_id', 'title', 'description')
+ params.fetch(:document, {}).permit("category_id", "title", "description")
end
end
diff --git a/modules/documents/app/mailers/documents_mailer.rb b/modules/documents/app/mailers/documents_mailer.rb
index ba5526449800..f1a98d95ef77 100644
--- a/modules/documents/app/mailers/documents_mailer.rb
+++ b/modules/documents/app/mailers/documents_mailer.rb
@@ -30,8 +30,8 @@ class DocumentsMailer < UserMailer
def document_added(user, document)
@document = document
- open_project_headers 'Project' => @document.project.identifier,
- 'Type' => 'Document'
+ open_project_headers "Project" => @document.project.identifier,
+ "Type" => "Document"
send_localized_mail(user) do
"[#{@document.project.name}] #{t(:label_document_new)}: #{@document.title}"
@@ -42,7 +42,7 @@ def attachments_added(user, attachments)
container = attachments.first.container
@added_to = "#{Document.model_name.human}: #{container.title}"
- @added_to_url = url_for(controller: '/documents', action: 'show', id: container.id)
+ @added_to_url = url_for(controller: "/documents", action: "show", id: container.id)
super
end
diff --git a/modules/documents/app/models/activities/document_activity_provider.rb b/modules/documents/app/models/activities/document_activity_provider.rb
index 529beb841482..00e073aac164 100644
--- a/modules/documents/app/models/activities/document_activity_provider.rb
+++ b/modules/documents/app/models/activities/document_activity_provider.rb
@@ -27,13 +27,13 @@
#++
class Activities::DocumentActivityProvider < Activities::BaseActivityProvider
- activity_provider_for type: 'documents',
+ activity_provider_for type: "documents",
permission: :view_documents
def event_query_projection
[
- activity_journal_projection_statement(:title, 'document_title'),
- activity_journal_projection_statement(:project_id, 'project_id')
+ activity_journal_projection_statement(:title, "document_title"),
+ activity_journal_projection_statement(:project_id, "project_id")
]
end
@@ -42,7 +42,7 @@ def event_title(event)
end
def event_type(_event)
- 'document'
+ "document"
end
def event_path(event)
@@ -56,6 +56,6 @@ def event_url(event)
private
def url_helper_parameter(event)
- event['journable_id']
+ event["journable_id"]
end
end
diff --git a/modules/documents/app/models/document.rb b/modules/documents/app/models/document.rb
index c0e89f874bd9..7acb4e0c3d0a 100644
--- a/modules/documents/app/models/document.rb
+++ b/modules/documents/app/models/document.rb
@@ -34,12 +34,12 @@ class Document < ApplicationRecord
acts_as_journalized
acts_as_event title: Proc.new { |o| "#{Document.model_name.human}: #{o.title}" },
- url: Proc.new { |o| { controller: '/documents', action: 'show', id: o.id } },
+ url: Proc.new { |o| { controller: "/documents", action: "show", id: o.id } },
author: Proc.new { |o|
o.attachments.find(:first, order: "#{Attachment.table_name}.created_at ASC").try(:author)
}
- acts_as_searchable columns: ['title', "#{table_name}.description"],
+ acts_as_searchable columns: ["title", "#{table_name}.description"],
include: :project,
references: :projects,
date_column: "#{table_name}.created_at"
diff --git a/modules/documents/app/models/document_category.rb b/modules/documents/app/models/document_category.rb
index c5c41f7d92ea..30892b81cf8d 100644
--- a/modules/documents/app/models/document_category.rb
+++ b/modules/documents/app/models/document_category.rb
@@ -27,7 +27,7 @@
#++
class DocumentCategory < Enumeration
- has_many :documents, foreign_key: 'category_id'
+ has_many :documents, foreign_key: "category_id"
OptionName = :enumeration_doc_categories
diff --git a/modules/documents/app/seeders/basic_data/documents/enumeration_seeder.rb b/modules/documents/app/seeders/basic_data/documents/enumeration_seeder.rb
index f3953d577be3..6a5669ebf134 100644
--- a/modules/documents/app/seeders/basic_data/documents/enumeration_seeder.rb
+++ b/modules/documents/app/seeders/basic_data/documents/enumeration_seeder.rb
@@ -30,11 +30,11 @@ module BasicData
module Documents
class EnumerationSeeder < ModelSeeder
self.model_class = DocumentCategory
- self.seed_data_model_key = 'document_categories'
+ self.seed_data_model_key = "document_categories"
def model_attributes(category_data)
{
- name: category_data['name']
+ name: category_data["name"]
}
end
end
diff --git a/modules/documents/db/migrate/20180323140208_to_v710_aggregated_documents_migrations.rb b/modules/documents/db/migrate/20180323140208_to_v710_aggregated_documents_migrations.rb
index 0fb548865ca1..60682f012a09 100644
--- a/modules/documents/db/migrate/20180323140208_to_v710_aggregated_documents_migrations.rb
+++ b/modules/documents/db/migrate/20180323140208_to_v710_aggregated_documents_migrations.rb
@@ -68,7 +68,7 @@ def down
def migrations
MIGRATION_FILES.split.map do |m|
- m.gsub(/_.*\z/, '')
+ m.gsub(/_.*\z/, "")
end
end
end
diff --git a/modules/documents/lib/api/v3/documents/document_representer.rb b/modules/documents/lib/api/v3/documents/document_representer.rb
index 99a78bb0ed74..155b76ec6ae0 100644
--- a/modules/documents/lib/api/v3/documents/document_representer.rb
+++ b/modules/documents/lib/api/v3/documents/document_representer.rb
@@ -59,7 +59,7 @@ class DocumentRepresenter < ::API::Decorators::Single
end
def _type
- 'Document'
+ "Document"
end
end
end
diff --git a/modules/documents/lib/api/v3/documents/documents_api.rb b/modules/documents/lib/api/v3/documents/documents_api.rb
index 5314ba6c9c6c..85b87473a32b 100644
--- a/modules/documents/lib/api/v3/documents/documents_api.rb
+++ b/modules/documents/lib/api/v3/documents/documents_api.rb
@@ -49,7 +49,7 @@ class DocumentsAPI < ::API::OpenProjectAPI
end
end
- route_param :id, type: Integer, desc: 'Document ID' do
+ route_param :id, type: Integer, desc: "Document ID" do
helpers do
def document
Document.visible.find(params[:id])
diff --git a/modules/documents/lib/open_project/documents/engine.rb b/modules/documents/lib/open_project/documents/engine.rb
index 4d30387356e2..c6a248ca2bb4 100644
--- a/modules/documents/lib/open_project/documents/engine.rb
+++ b/modules/documents/lib/open_project/documents/engine.rb
@@ -32,15 +32,15 @@ class Engine < ::Rails::Engine
include OpenProject::Plugins::ActsAsOpEngine
- register 'openproject-documents',
+ register "openproject-documents",
author_url: "http://www.openproject.org",
bundled: true do
menu :project_menu,
:documents,
- { controller: '/documents', action: 'index' },
+ { controller: "/documents", action: "index" },
caption: :label_document_plural,
before: :members,
- icon: 'notes'
+ icon: "notes"
project_module :documents do |_map|
permission :view_documents,
@@ -55,7 +55,7 @@ class Engine < ::Rails::Engine
Redmine::Search.register :documents
end
- activity_provider :documents, class_name: 'Activities::DocumentActivityProvider', default: false
+ activity_provider :documents, class_name: "Activities::DocumentActivityProvider", default: false
patches %i[Project]
@@ -71,7 +71,7 @@ class Engine < ::Rails::Engine
"#{document(id)}/attachments"
end
- add_api_endpoint 'API::V3::Root' do
+ add_api_endpoint "API::V3::Root" do
mount ::API::V3::Documents::DocumentsAPI
end
diff --git a/modules/documents/lib/openproject-documents.rb b/modules/documents/lib/openproject-documents.rb
index 9288d1d36f86..6eacc169126d 100644
--- a/modules/documents/lib/openproject-documents.rb
+++ b/modules/documents/lib/openproject-documents.rb
@@ -26,4 +26,4 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'open_project/documents'
+require "open_project/documents"
diff --git a/modules/documents/openproject-documents.gemspec b/modules/documents/openproject-documents.gemspec
index df9722eddf22..c00b215e8315 100644
--- a/modules/documents/openproject-documents.gemspec
+++ b/modules/documents/openproject-documents.gemspec
@@ -1,6 +1,6 @@
Gem::Specification.new do |s|
s.name = "openproject-documents"
- s.version = '1.0.0'
+ s.version = "1.0.0"
s.authors = "OpenProject GmbH"
s.email = "info@openproject.com"
s.summary = "OpenProject Documents"
@@ -8,5 +8,5 @@ Gem::Specification.new do |s|
s.license = "GPLv3"
s.files = Dir["{app,config,db,lib,doc}/**/*", "README.md"]
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/documents/spec/api/v3/documents/document_representer_rendering_spec.rb b/modules/documents/spec/api/v3/documents/document_representer_rendering_spec.rb
index 68d8524ba021..7d5057ea54e3 100644
--- a/modules/documents/spec/api/v3/documents/document_representer_rendering_spec.rb
+++ b/modules/documents/spec/api/v3/documents/document_representer_rendering_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Documents::DocumentRepresenter, 'rendering' do
+RSpec.describe API::V3::Documents::DocumentRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
let(:document) do
build_stubbed(:document,
- description: 'Some description') do |document|
+ description: "Some description") do |document|
allow(document)
.to receive(:project)
.and_return(project)
@@ -49,25 +49,25 @@
subject { representer.to_json }
- describe '_links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.document document.id }
let(:title) { document.title }
end
- it_behaves_like 'has an untitled link' do
+ it_behaves_like "has an untitled link" do
let(:link) { :attachments }
let(:href) { api_v3_paths.attachments_by_document document.id }
end
- it_behaves_like 'has a titled link' do
+ it_behaves_like "has a titled link" do
let(:link) { :project }
let(:title) { project.name }
let(:href) { api_v3_paths.project project.id }
end
- it_behaves_like 'has an untitled action link' do
+ it_behaves_like "has an untitled action link" do
let(:link) { :addAttachment }
let(:href) { api_v3_paths.attachments_by_document document.id }
let(:method) { :post }
@@ -75,41 +75,41 @@
end
end
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'Document' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "Document" }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { document.id }
end
- it_behaves_like 'property', :title do
+ it_behaves_like "property", :title do
let(:value) { document.title }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { document.created_at }
- let(:json_path) { 'createdAt' }
+ let(:json_path) { "createdAt" }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { document.updated_at }
- let(:json_path) { 'updatedAt' }
+ let(:json_path) { "updatedAt" }
end
- it_behaves_like 'API V3 formattable', 'description' do
- let(:format) { 'markdown' }
+ it_behaves_like "API V3 formattable", "description" do
+ let(:format) { "markdown" }
let(:raw) { document.description }
- let(:html) { '
' + document.description + '
' }
+ let(:html) { '
' + document.description + "
" }
end
end
- describe '_embedded' do
- it 'has project embedded' do
+ describe "_embedded" do
+ it "has project embedded" do
expect(subject)
.to be_json_eql(project.name.to_json)
- .at_path('_embedded/project/name')
+ .at_path("_embedded/project/name")
end
end
end
diff --git a/modules/documents/spec/application_helper_spec.rb b/modules/documents/spec/application_helper_spec.rb
index 2e18111bd57a..573fb119be1b 100644
--- a/modules/documents/spec/application_helper_spec.rb
+++ b/modules/documents/spec/application_helper_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe ApplicationHelper do
include ApplicationHelper
@@ -47,7 +47,7 @@
end
let(:document) do
create(:document,
- title: 'Test document',
+ title: "Test document",
project:)
end
@@ -62,10 +62,10 @@
context "Simple Document links" do
let(:document_link) do
- link_to('Test document',
- { controller: 'documents', action: 'show', id: document.id },
- class: 'document op-uc-link',
- target: '_top')
+ link_to("Test document",
+ { controller: "documents", action: "show", id: document.id },
+ class: "document op-uc-link",
+ target: "_top")
end
context "Plain link" do
@@ -93,7 +93,7 @@
end
end
- context 'Cross-Project Document Links' do
+ context "Cross-Project Document Links" do
let(:the_other_project) { create(:valid_project) }
context "By name without project" do
diff --git a/modules/documents/spec/controllers/documents_controller_spec.rb b/modules/documents/spec/controllers/documents_controller_spec.rb
index 85f4f470465a..bb7c3914e6d2 100644
--- a/modules/documents/spec/controllers/documents_controller_spec.rb
+++ b/modules/documents/spec/controllers/documents_controller_spec.rb
@@ -62,13 +62,13 @@
end
end
- describe 'new' do
+ describe "new" do
before do
get :new, params: { project_id: project.id }
end
- it 'show the new document form' do
- expect(response).to render_template(partial: 'documents/_form')
+ it "show the new document form" do
+ expect(response).to render_template(partial: "documents/_form")
end
end
@@ -99,7 +99,7 @@
end.to change(Document, :count).by 1
end
- it 'does trigger a workflow job for the document' do
+ it "does trigger a workflow job for the document" do
expect(Notifications::WorkflowJob)
.to have_been_enqueued
.with(:create_notifications, document.journals.last, true)
@@ -119,7 +119,7 @@
title: "New Document",
project_id: notify_project.id,
category_id: default_category.id),
- attachments: { '1' => { id: uncontainered.id } }
+ attachments: { "1" => { id: uncontainered.id } }
}
end
@@ -137,7 +137,7 @@
end
end
- describe 'show' do
+ describe "show" do
before do
document
get :show, params: { id: document.id }
@@ -145,7 +145,7 @@
it "shows the attachment" do
expect(response).to be_successful
- expect(response).to render_template('show')
+ expect(response).to render_template("show")
end
end
diff --git a/modules/documents/spec/factories/journal/document_journal_factory.rb b/modules/documents/spec/factories/journal/document_journal_factory.rb
index 0f01b316bc83..b735949d0992 100644
--- a/modules/documents/spec/factories/journal/document_journal_factory.rb
+++ b/modules/documents/spec/factories/journal/document_journal_factory.rb
@@ -27,6 +27,6 @@
#++
FactoryBot.define do
- factory :journal_document_journal, class: 'Journal::DocumentJournal' do
+ factory :journal_document_journal, class: "Journal::DocumentJournal" do
end
end
diff --git a/modules/documents/spec/features/attachment_upload_spec.rb b/modules/documents/spec/features/attachment_upload_spec.rb
index 9c72ba18152d..3b1a08c508e6 100644
--- a/modules/documents/spec/features/attachment_upload_spec.rb
+++ b/modules/documents/spec/features/attachment_upload_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/page_objects/notification'
+require "spec_helper"
+require "features/page_objects/notification"
-RSpec.describe 'Upload attachment to documents', :js,
+RSpec.describe "Upload attachment to documents", :js,
with_settings: {
journal_aggregation_time_minutes: 0
} do
@@ -47,7 +47,7 @@
end
let(:project) { create(:project) }
let(:attachments) { Components::Attachments.new }
- let(:image_fixture) { UploadedFile.load_from('spec/fixtures/files/image.png') }
+ let(:image_fixture) { UploadedFile.load_from("spec/fixtures/files/image.png") }
let(:editor) { Components::WysiwygEditor.new }
let(:attachments_list) { Components::AttachmentsList.new }
@@ -55,43 +55,43 @@
login_as(user)
end
- shared_examples 'can upload an image' do
- it 'can upload an image' do
+ shared_examples "can upload an image" do
+ it "can upload an image" do
visit new_project_document_path(project)
- expect(page).to have_css('#new_document', wait: 10)
+ expect(page).to have_css("#new_document", wait: 10)
SeleniumHubWaiter.wait
- select(category.name, from: 'Category')
- fill_in "Title", with: 'New documentation'
+ select(category.name, from: "Category")
+ fill_in "Title", with: "New documentation"
# adding an image via the attachments-list
find_test_selector("op-attachments--drop-box").drop(image_fixture.path)
- editor.attachments_list.expect_attached('image.png')
+ editor.attachments_list.expect_attached("image.png")
# adding an image
- editor.drag_attachment image_fixture.path, 'Image uploaded on creation'
- editor.attachments_list.expect_attached('image.png', count: 2)
+ editor.drag_attachment image_fixture.path, "Image uploaded on creation"
+ editor.attachments_list.expect_attached("image.png", count: 2)
editor.wait_until_upload_progress_toaster_cleared
perform_enqueued_jobs do
- click_on 'Create'
+ click_on "Create"
# Expect it to be present on the index page
- expect(page).to have_css('.document-category-elements--header', text: 'New documentation')
- expect(page).to have_css('#content img', count: 1)
- expect(page).to have_content('Image uploaded on creation')
+ expect(page).to have_css(".document-category-elements--header", text: "New documentation")
+ expect(page).to have_css("#content img", count: 1)
+ expect(page).to have_content("Image uploaded on creation")
end
document = Document.last
- expect(document.title).to eq 'New documentation'
+ expect(document.title).to eq "New documentation"
# Expect it to be present on the show page
SeleniumHubWaiter.wait
- find('.document-category-elements--header a', text: 'New documentation').click
+ find(".document-category-elements--header a", text: "New documentation").click
expect(page).to have_current_path "/documents/#{document.id}", wait: 10
- expect(page).to have_css('#content img', count: 1)
- expect(page).to have_content('Image uploaded on creation')
+ expect(page).to have_css("#content img", count: 1)
+ expect(page).to have_content("Image uploaded on creation")
# Adding a second image
# We should be using the 'Edit' button at the top but that leads to flickering specs
@@ -101,27 +101,27 @@
# editor.click_and_type_slowly 'abc'
SeleniumHubWaiter.wait
- editor.attachments_list.expect_attached('image.png', count: 2)
+ editor.attachments_list.expect_attached("image.png", count: 2)
- editor.drag_attachment image_fixture.path, 'Image uploaded the second time'
+ editor.drag_attachment image_fixture.path, "Image uploaded the second time"
- editor.attachments_list.expect_attached('image.png', count: 3)
+ editor.attachments_list.expect_attached("image.png", count: 3)
editor.attachments_list.drag_enter
editor.attachments_list.drop(image_fixture)
- editor.attachments_list.expect_attached('image.png', count: 4)
+ editor.attachments_list.expect_attached("image.png", count: 4)
editor.wait_until_upload_progress_toaster_cleared
perform_enqueued_jobs do
- click_on 'Save'
+ click_on "Save"
# Expect both images to be present on the show page
- expect(page).to have_css('#content img', count: 2)
- expect(page).to have_content('Image uploaded on creation')
- expect(page).to have_content('Image uploaded the second time')
- attachments_list.expect_attached('image.png', count: 4)
+ expect(page).to have_css("#content img", count: 2)
+ expect(page).to have_content("Image uploaded on creation")
+ expect(page).to have_content("Image uploaded the second time")
+ attachments_list.expect_attached("image.png", count: 4)
end
# Expect a mail to be sent to the user having subscribed to all notifications
@@ -132,19 +132,19 @@
.to contain_exactly(other_user.mail)
expect(ActionMailer::Base.deliveries.last.subject)
- .to include 'New documentation'
+ .to include "New documentation"
end
end
- context 'with direct uploads (Regression #34285)', :with_direct_uploads do
+ context "with direct uploads (Regression #34285)", :with_direct_uploads do
before do
allow_any_instance_of(Attachment).to receive(:diskfile).and_return image_fixture # rubocop:disable RSpec/AnyInstance
end
- it_behaves_like 'can upload an image'
+ it_behaves_like "can upload an image"
end
- context 'for internal uploads', with_direct_uploads: false do
- it_behaves_like 'can upload an image'
+ context "for internal uploads", with_direct_uploads: false do
+ it_behaves_like "can upload an image"
end
end
diff --git a/modules/documents/spec/lib/open_project/markdown_formatting_spec.rb b/modules/documents/spec/lib/open_project/markdown_formatting_spec.rb
index 7e5e61e7aa5c..bdc7b175c29d 100644
--- a/modules/documents/spec/lib/open_project/markdown_formatting_spec.rb
+++ b/modules/documents/spec/lib/open_project/markdown_formatting_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::TextFormatting,
- 'Document links' do
+ "Document links" do
include ActionView::Helpers::UrlHelper # soft-dependency
include ActionView::Context
include OpenProject::StaticRouting::UrlHelpers
@@ -43,7 +43,7 @@ def controller
end
shared_let(:document) do
- create(:document, project:, title: 'My document')
+ create(:document, project:, title: "My document")
end
subject do
@@ -62,7 +62,7 @@ def controller
TEXT
end
- context 'when visible' do
+ context "when visible" do
let(:role) { create(:project_role, permissions: %i[view_documents view_project]) }
let(:user) { create(:user, member_with_roles: { project => role }) }
@@ -76,19 +76,19 @@ def controller
let(:document_link) do
link_to(
- 'My document',
- { controller: '/documents', action: 'show', id: document.id, only_path: true },
- class: 'document op-uc-link',
- target: '_top'
+ "My document",
+ { controller: "/documents", action: "show", id: document.id, only_path: true },
+ class: "document op-uc-link",
+ target: "_top"
)
end
- it 'renders the links' do
+ it "renders the links" do
expect(subject).to be_html_eql(expected)
end
end
- context 'when not visible' do
+ context "when not visible" do
let(:user) { create(:user) }
let(:expected) do
@@ -99,7 +99,7 @@ def controller
HTML
end
- it 'renders the raw text' do
+ it "renders the raw text" do
expect(subject).to be_html_eql(expected)
end
end
diff --git a/modules/documents/spec/lib/redmine/access_control_spec.rb b/modules/documents/spec/lib/redmine/access_control_spec.rb
index bc484b4b3e3f..130ee4439e73 100644
--- a/modules/documents/spec/lib/redmine/access_control_spec.rb
+++ b/modules/documents/spec/lib/redmine/access_control_spec.rb
@@ -25,19 +25,19 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.dirname(__FILE__) + '/../../spec_helper'
+require File.dirname(__FILE__) + "/../../spec_helper"
RSpec.describe OpenProject::AccessControl do
- describe 'manage documents permission' do
- it 'is part of the documents project module' do
+ describe "manage documents permission" do
+ it "is part of the documents project module" do
permission = OpenProject::AccessControl.permission(:manage_documents)
expect(permission.project_module).to be(:documents)
end
end
- describe 'view documents permission' do
- it 'is part of the documents project module' do
+ describe "view documents permission" do
+ it "is part of the documents project module" do
permission = OpenProject::AccessControl.permission(:view_documents)
expect(permission.project_module).to be(:documents)
diff --git a/modules/documents/spec/mailers/documents_mailer_spec.rb b/modules/documents/spec/mailers/documents_mailer_spec.rb
index d5509447c0f1..d7add0f09d12 100644
--- a/modules/documents/spec/mailers/documents_mailer_spec.rb
+++ b/modules/documents/spec/mailers/documents_mailer_spec.rb
@@ -25,11 +25,11 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.dirname(__FILE__) + '/../spec_helper'
+require File.dirname(__FILE__) + "/../spec_helper"
RSpec.describe DocumentsMailer do
let(:user) do
- create(:user, firstname: 'Test', lastname: "User", mail: 'test@test.com')
+ create(:user, firstname: "Test", lastname: "User", mail: "test@test.com")
end
let(:project) { create(:project, name: "TestProject") }
let(:document) do
@@ -37,9 +37,9 @@
end
let(:mail) { DocumentsMailer.document_added(user, document) }
- describe "document added-mail", with_settings: { host_name: 'my.openproject.com' } do
+ describe "document added-mail", with_settings: { host_name: "my.openproject.com" } do
it "renders the subject" do
- expect(mail.subject).to eql '[TestProject] New document: Test Title'
+ expect(mail.subject).to eql "[TestProject] New document: Test Title"
end
it "renders the receivers mail" do
diff --git a/modules/documents/spec/models/document_category_spec.rb b/modules/documents/spec/models/document_category_spec.rb
index ff645858504e..0fd70473b658 100644
--- a/modules/documents/spec/models/document_category_spec.rb
+++ b/modules/documents/spec/models/document_category_spec.rb
@@ -25,7 +25,7 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.dirname(__FILE__) + '/../spec_helper'
+require File.dirname(__FILE__) + "/../spec_helper"
RSpec.describe DocumentCategory do
let(:project) { create(:project) }
diff --git a/modules/documents/spec/models/document_spec.rb b/modules/documents/spec/models/document_spec.rb
index 1889677ccd89..5a37f1b432f6 100644
--- a/modules/documents/spec/models/document_spec.rb
+++ b/modules/documents/spec/models/document_spec.rb
@@ -25,10 +25,10 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.dirname(__FILE__) + '/../spec_helper'
+require File.dirname(__FILE__) + "/../spec_helper"
RSpec.describe Document do
- let(:documentation_category) { create(:document_category, name: 'User documentation') }
+ let(:documentation_category) { create(:document_category, name: "User documentation") }
let(:project) { create(:project) }
let(:user) { create(:user) }
let(:admin) { create(:admin) }
@@ -55,7 +55,7 @@
end
it "sets a default-category, if none is given" do
- default_category = create(:document_category, name: 'Technical documentation', is_default: true)
+ default_category = create(:document_category, name: "Technical documentation", is_default: true)
document = Document.new(project:, title: "New Document")
expect(document.category).to eql default_category
expect do
@@ -69,7 +69,7 @@
expect do
Attachments::CreateService
.new(user: admin)
- .call(container: valid_document, file: attributes_for(:attachment)[:file], filename: 'foo')
+ .call(container: valid_document, file: attributes_for(:attachment)[:file], filename: "foo")
expect(valid_document.attachments.size).to be 1
end.to(change do
diff --git a/modules/documents/spec/models/queries/documents/document_query_spec.rb b/modules/documents/spec/models/queries/documents/document_query_spec.rb
index 1ac9dfb330b4..a2bf0a80c56a 100644
--- a/modules/documents/spec/models/queries/documents/document_query_spec.rb
+++ b/modules/documents/spec/models/queries/documents/document_query_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Queries::Documents::DocumentQuery do
let(:user) { build_stubbed(:user) }
@@ -37,39 +37,39 @@
login_as(user)
end
- context 'without a filter' do
- describe '#results' do
- it 'is the same as getting all the visible documents' do
+ context "without a filter" do
+ describe "#results" do
+ it "is the same as getting all the visible documents" do
expect(instance.results.to_sql).to eql base_scope.to_sql
end
end
end
- context 'with a project filter' do
+ context "with a project filter" do
before do
allow(Project)
.to receive_message_chain(:visible, :pluck)
.with(:id)
.and_return([1])
- instance.where('project_id', '=', ['1'])
+ instance.where("project_id", "=", ["1"])
end
- describe '#results' do
- it 'is the same as handwriting the query' do
+ describe "#results" do
+ it "is the same as handwriting the query" do
expected = base_scope
- .where(["documents.project_id IN (?)", ['1']])
+ .where(["documents.project_id IN (?)", ["1"]])
expect(instance.results.to_sql).to eql expected.to_sql
end
end
- describe '#valid?' do
- it 'is true' do
+ describe "#valid?" do
+ it "is true" do
expect(instance).to be_valid
end
- it 'is invalid if the filter is invalid' do
- instance.where('project_id', '=', [''])
+ it "is invalid if the filter is invalid" do
+ instance.where("project_id", "=", [""])
expect(instance).to be_invalid
end
end
diff --git a/modules/documents/spec/models/queries/documents/filters/project_filter_spec.rb b/modules/documents/spec/models/queries/documents/filters/project_filter_spec.rb
index 26cfdd7d9920..b138ac307895 100644
--- a/modules/documents/spec/models/queries/documents/filters/project_filter_spec.rb
+++ b/modules/documents/spec/models/queries/documents/filters/project_filter_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Queries::Documents::Filters::ProjectFilter do
let(:project1) { build_stubbed(:project) }
@@ -39,13 +39,13 @@
.and_return([project1.id, project2.id])
end
- it_behaves_like 'basic query filter' do
+ it_behaves_like "basic query filter" do
let(:class_key) { :project_id }
let(:type) { :list_optional }
let(:name) { Document.human_attribute_name(:project) }
- describe '#allowed_values' do
- it 'is a list of the possible values' do
+ describe "#allowed_values" do
+ it "is a list of the possible values" do
expected = [[project1.id, project1.id.to_s], [project2.id, project2.id.to_s]]
expect(instance.allowed_values).to match_array(expected)
@@ -53,7 +53,7 @@
end
end
- it_behaves_like 'list_optional query filter' do
+ it_behaves_like "list_optional query filter" do
let(:attribute) { :project_id }
let(:model) { Document }
let(:valid_values) { [project1.id.to_s] }
diff --git a/modules/documents/spec/requests/api/v3/attachments/attachments_by_documents_resource_spec.rb b/modules/documents/spec/requests/api/v3/attachments/attachments_by_documents_resource_spec.rb
index ea08c72fb03f..cfa95920e895 100644
--- a/modules/documents/spec/requests/api/v3/attachments/attachments_by_documents_resource_spec.rb
+++ b/modules/documents/spec/requests/api/v3/attachments/attachments_by_documents_resource_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'requests/api/v3/attachments/attachment_resource_shared_examples'
+require "spec_helper"
+require "requests/api/v3/attachments/attachment_resource_shared_examples"
RSpec.describe "document attachments" do
it_behaves_like "an APIv3 attachment resource" do
diff --git a/modules/documents/spec/requests/api/v3/documents/documents_resource_spec.rb b/modules/documents/spec/requests/api/v3/documents/documents_resource_spec.rb
index 59a3372702ef..5af45b06d6ef 100644
--- a/modules/documents/spec/requests/api/v3/documents/documents_resource_spec.rb
+++ b/modules/documents/spec/requests/api/v3/documents/documents_resource_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'API v3 documents resource' do
+RSpec.describe "API v3 documents resource" do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -49,7 +49,7 @@
login_as(current_user)
end
- describe 'GET /api/v3/documents' do
+ describe "GET /api/v3/documents" do
let(:path) { api_v3_paths.documents }
before do
@@ -59,56 +59,56 @@
get path
end
- it 'returns 200 OK' do
+ it "returns 200 OK" do
expect(subject.status)
.to be(200)
end
- it 'returns a Collection of visible documents' do
+ it "returns a Collection of visible documents" do
expect(subject.body)
- .to be_json_eql('Collection'.to_json)
- .at_path('_type')
+ .to be_json_eql("Collection".to_json)
+ .at_path("_type")
expect(subject.body)
.to be_json_eql(1.to_json)
- .at_path('total')
+ .at_path("total")
expect(subject.body)
- .to be_json_eql('Document'.to_json)
- .at_path('_embedded/elements/0/_type')
+ .to be_json_eql("Document".to_json)
+ .at_path("_embedded/elements/0/_type")
expect(subject.body)
.to be_json_eql(document.title.to_json)
- .at_path('_embedded/elements/0/title')
+ .at_path("_embedded/elements/0/title")
end
end
- describe 'GET /api/v3/documents/:id' do
+ describe "GET /api/v3/documents/:id" do
let(:path) { api_v3_paths.document(document.id) }
before do
get path
end
- it 'returns 200 OK' do
+ it "returns 200 OK" do
expect(subject.status)
.to be(200)
end
- it 'returns the document' do
+ it "returns the document" do
expect(subject.body)
- .to be_json_eql('Document'.to_json)
- .at_path('_type')
+ .to be_json_eql("Document".to_json)
+ .at_path("_type")
expect(subject.body)
.to be_json_eql(document.id.to_json)
- .at_path('id')
+ .at_path("id")
end
- context 'when lacking permissions' do
+ context "when lacking permissions" do
let(:permissions) { [] }
- it 'returns 404 NOT FOUND' do
+ it "returns 404 NOT FOUND" do
expect(subject.status)
.to be(404)
end
diff --git a/modules/documents/spec/routing/documents_routing_spec.rb b/modules/documents/spec/routing/documents_routing_spec.rb
index 34cc47cde187..6edd5f059f69 100644
--- a/modules/documents/spec/routing/documents_routing_spec.rb
+++ b/modules/documents/spec/routing/documents_routing_spec.rb
@@ -26,50 +26,50 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe DocumentsController do
describe "routing" do
it {
- expect(get('/projects/567/documents')).to route_to(controller: 'documents',
- action: 'index',
- project_id: '567')
+ expect(get("/projects/567/documents")).to route_to(controller: "documents",
+ action: "index",
+ project_id: "567")
}
it {
- expect(get('/projects/567/documents/new')).to route_to(controller: 'documents',
- action: 'new',
- project_id: '567')
+ expect(get("/projects/567/documents/new")).to route_to(controller: "documents",
+ action: "new",
+ project_id: "567")
}
it {
- expect(get('/documents/22')).to route_to(controller: 'documents',
- action: 'show',
- id: '22')
+ expect(get("/documents/22")).to route_to(controller: "documents",
+ action: "show",
+ id: "22")
}
it {
- expect(get('/documents/22/edit')).to route_to(controller: 'documents',
- action: 'edit',
- id: '22')
+ expect(get("/documents/22/edit")).to route_to(controller: "documents",
+ action: "edit",
+ id: "22")
}
it {
- expect(post('/projects/567/documents')).to route_to(controller: 'documents',
- action: 'create',
- project_id: '567')
+ expect(post("/projects/567/documents")).to route_to(controller: "documents",
+ action: "create",
+ project_id: "567")
}
it {
- expect(put('/documents/567')).to route_to(controller: 'documents',
- action: 'update',
- id: '567')
+ expect(put("/documents/567")).to route_to(controller: "documents",
+ action: "update",
+ id: "567")
}
it {
- expect(delete('/documents/567')).to route_to(controller: 'documents',
- action: 'destroy',
- id: '567')
+ expect(delete("/documents/567")).to route_to(controller: "documents",
+ action: "destroy",
+ id: "567")
}
end
end
diff --git a/modules/documents/spec/services/notifications/create_from_model_service_document_spec.rb b/modules/documents/spec/services/notifications/create_from_model_service_document_spec.rb
index 93abebff329b..e26002b48909 100644
--- a/modules/documents/spec/services/notifications/create_from_model_service_document_spec.rb
+++ b/modules/documents/spec/services/notifications/create_from_model_service_document_spec.rb
@@ -25,15 +25,15 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require Rails.root.join('spec/services/notifications/create_from_journal_job_shared')
+require "spec_helper"
+require Rails.root.join("spec/services/notifications/create_from_journal_job_shared")
-RSpec.describe Notifications::CreateFromModelService, 'document', with_settings: { journal_aggregation_time_minutes: 0 } do
+RSpec.describe Notifications::CreateFromModelService, "document", with_settings: { journal_aggregation_time_minutes: 0 } do
subject(:call) do
described_class.new(journal).call(send_notifications)
end
- include_context 'with CreateFromJournalJob context'
+ include_context "with CreateFromJournalJob context"
shared_let(:project) { create(:project) }
@@ -53,10 +53,10 @@
recipient
end
- describe '#perform' do
- context 'with a newly created document' do
- context 'with the user having registered for all notifications' do
- it_behaves_like 'creates notification' do
+ describe "#perform" do
+ context "with a newly created document" do
+ context "with the user having registered for all notifications" do
+ it_behaves_like "creates notification" do
let(:notification_channel_reasons) do
{
read_ian: nil,
@@ -68,53 +68,53 @@
end
end
- context 'with the user having registered for assignee notifications' do
+ context "with the user having registered for assignee notifications" do
let(:recipient_notification_settings) do
[
build(:notification_setting, **notification_settings_all_false.merge(assignee: true))
]
end
- it_behaves_like 'creates no notification'
+ it_behaves_like "creates no notification"
end
- context 'with the user having registered for responsible notifications' do
+ context "with the user having registered for responsible notifications" do
let(:recipient_notification_settings) do
[
build(:notification_setting, **notification_settings_all_false.merge(responsible: true))
]
end
- it_behaves_like 'creates no notification'
+ it_behaves_like "creates no notification"
end
- context 'with the user having registered for no notifications' do
+ context "with the user having registered for no notifications" do
let(:recipient_notification_settings) do
[
build(:notification_setting, **notification_settings_all_false)
]
end
- it_behaves_like 'creates no notification'
+ it_behaves_like "creates no notification"
end
- context 'with the user having registered for all notifications but lacking permissions' do
+ context "with the user having registered for all notifications but lacking permissions" do
before do
recipient.members.destroy_all
end
- it_behaves_like 'creates no notification'
+ it_behaves_like "creates no notification"
end
end
- context 'with an updated document' do
+ context "with an updated document" do
before do
- resource.title = 'A new subject'
+ resource.title = "A new subject"
resource.save!
end
- context 'with the user having registered for all notifications' do
- it_behaves_like 'creates notification' do
+ context "with the user having registered for all notifications" do
+ it_behaves_like "creates notification" do
let(:notification_channel_reasons) do
{
read_ian: nil,
@@ -126,42 +126,42 @@
end
end
- context 'with the user having registered for assignee notifications' do
+ context "with the user having registered for assignee notifications" do
let(:recipient_notification_settings) do
[
build(:notification_setting, **notification_settings_all_false.merge(assignee: true))
]
end
- it_behaves_like 'creates no notification'
+ it_behaves_like "creates no notification"
end
- context 'with the user having registered for responsible notifications' do
+ context "with the user having registered for responsible notifications" do
let(:recipient_notification_settings) do
[
build(:notification_setting, **notification_settings_all_false.merge(responsible: true))
]
end
- it_behaves_like 'creates no notification'
+ it_behaves_like "creates no notification"
end
- context 'with the user having registered for no notifications' do
+ context "with the user having registered for no notifications" do
let(:recipient_notification_settings) do
[
build(:notification_setting, **notification_settings_all_false)
]
end
- it_behaves_like 'creates no notification'
+ it_behaves_like "creates no notification"
end
- context 'with the user having registered for all notifications but lacking permissions' do
+ context "with the user having registered for all notifications but lacking permissions" do
before do
recipient.members.destroy_all
end
- it_behaves_like 'creates no notification'
+ it_behaves_like "creates no notification"
end
end
end
diff --git a/modules/documents/spec/services/notifications/mail_service_spec.rb b/modules/documents/spec/services/notifications/mail_service_spec.rb
index 5f6ad1063cb0..14b9ac829915 100644
--- a/modules/documents/spec/services/notifications/mail_service_spec.rb
+++ b/modules/documents/spec/services/notifications/mail_service_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Notifications::MailService, type: :model do
subject(:call) { instance.call }
@@ -39,7 +39,7 @@
end
let(:instance) { described_class.new(notification) }
- context 'with a document journal notification' do
+ context "with a document journal notification" do
let(:journal) do
build_stubbed(:journal,
journable: build_stubbed(:document)).tap do |j|
@@ -76,7 +76,7 @@
mail
end
- it 'sends a mail' do
+ it "sends a mail" do
call
expect(DocumentsMailer)
@@ -88,10 +88,10 @@
.to have_received(:deliver_later)
end
- context 'with the notification read in app already' do
+ context "with the notification read in app already" do
let(:read_ian) { true }
- it 'sends no mail' do
+ it "sends no mail" do
call
expect(DocumentsMailer)
@@ -99,10 +99,10 @@
end
end
- context 'with the journal not being the initial one' do
+ context "with the journal not being the initial one" do
let(:initial_journal) { false }
- it 'sends no mail' do
+ it "sends no mail" do
call
expect(DocumentsMailer)
diff --git a/modules/gantt/app/controllers/gantt/gantt_controller.rb b/modules/gantt/app/controllers/gantt/gantt_controller.rb
index 198a5033c6d0..62424595cb77 100644
--- a/modules/gantt/app/controllers/gantt/gantt_controller.rb
+++ b/modules/gantt/app/controllers/gantt/gantt_controller.rb
@@ -32,7 +32,7 @@ def index
format.html do
render :index,
locals: { query: @query, project: @project, menu_name: project_or_global_menu },
- layout: 'angular/angular'
+ layout: "angular/angular"
end
format.any(*supported_list_formats) do
diff --git a/modules/gantt/app/controllers/gantt/menus_controller.rb b/modules/gantt/app/controllers/gantt/menus_controller.rb
index 01c119e5b485..8b99b082b8fc 100644
--- a/modules/gantt/app/controllers/gantt/menus_controller.rb
+++ b/modules/gantt/app/controllers/gantt/menus_controller.rb
@@ -38,16 +38,16 @@ def show
def menu_items
[
- OpenProject::Menu::MenuGroup.new(header: I18n.t('js.label_starred_queries'), children: starred_queries),
- OpenProject::Menu::MenuGroup.new(header: I18n.t('js.label_default_queries'), children: default_queries),
- OpenProject::Menu::MenuGroup.new(header: I18n.t('js.label_global_queries'), children: global_queries),
- OpenProject::Menu::MenuGroup.new(header: I18n.t('js.label_custom_queries'), children: custom_queries)
+ OpenProject::Menu::MenuGroup.new(header: I18n.t("js.label_starred_queries"), children: starred_queries),
+ OpenProject::Menu::MenuGroup.new(header: I18n.t("js.label_default_queries"), children: default_queries),
+ OpenProject::Menu::MenuGroup.new(header: I18n.t("js.label_global_queries"), children: global_queries),
+ OpenProject::Menu::MenuGroup.new(header: I18n.t("js.label_custom_queries"), children: custom_queries)
]
end
def starred_queries
base_query
- .where('starred' => 't')
+ .where("starred" => "t")
.pluck(:id, :name)
.map { |id, name| menu_item({ query_id: id }, name) }
end
@@ -67,16 +67,16 @@ def default_queries
def global_queries
base_query
- .where('starred' => 'f')
- .where('public' => 't')
+ .where("starred" => "f")
+ .where("public" => "t")
.pluck(:id, :name)
.map { |id, name| menu_item({ query_id: id }, name) }
end
def custom_queries
base_query
- .where('starred' => 'f')
- .where('public' => 'f')
+ .where("starred" => "f")
+ .where("public" => "f")
.pluck(:id, :name)
.map { |id, name| menu_item({ query_id: id }, name) }
end
@@ -86,12 +86,12 @@ def base_query
.visible(current_user)
.includes(:project)
.joins(:views)
- .where('views.type' => 'gantt')
+ .where("views.type" => "gantt")
if @project.present?
- base_query.where('queries.project_id' => @project.id)
+ base_query.where("queries.project_id" => @project.id)
else
- base_query.where('queries.project_id' => nil)
+ base_query.where("queries.project_id" => nil)
end
end
diff --git a/modules/gantt/app/services/gantt/default_query_generator_service.rb b/modules/gantt/app/services/gantt/default_query_generator_service.rb
index 9e2f67194e4e..c4a548f07d57 100644
--- a/modules/gantt/app/services/gantt/default_query_generator_service.rb
+++ b/modules/gantt/app/services/gantt/default_query_generator_service.rb
@@ -43,7 +43,7 @@ class DefaultQueryGeneratorService
tzl: "auto",
tv: true,
hi: true,
- t: 'start_date:asc'
+ t: "start_date:asc"
}.to_json.freeze
attr_reader :project
@@ -70,7 +70,7 @@ class << self
def all_open_query(project)
default_with_filter = add_columns(project)
- default_with_filter['f'] = [{ 'n' => 'status', 'o' => 'o', 'v' => [] }]
+ default_with_filter["f"] = [{ "n" => "status", "o" => "o", "v" => [] }]
default_with_filter
end
@@ -81,7 +81,7 @@ def milestones_query(project)
milestones = milestone_ids(project)
return if milestones.empty?
- default_with_filter['f'] = [{ 'n' => 'type', 'o' => '=', 'v' => milestones }]
+ default_with_filter["f"] = [{ "n" => "type", "o" => "=", "v" => milestones }]
default_with_filter
end
@@ -89,7 +89,7 @@ def add_columns(project)
default_with_filter = JSON
.parse(Gantt::DefaultQueryGeneratorService::DEFAULT_PARAMS)
- default_with_filter['c'] = if project.present?
+ default_with_filter["c"] = if project.present?
Gantt::DefaultQueryGeneratorService::PROJECT_DEFAULT_COLUMNS
else
Gantt::DefaultQueryGeneratorService::GLOBAL_DEFAULT_COLUMNS
@@ -110,11 +110,11 @@ def phase_ids(project)
if project.present?
::Type
.enabled_in(project.id)
- .where(name: I18n.t('seeds.standard.types.item_2.name', default: 'Phase'))
+ .where(name: I18n.t("seeds.standard.types.item_2.name", default: "Phase"))
.pluck(:id)
.map(&:to_s)
else
- ::Type.where(name: 'Phase').pluck(:id).map(&:to_s)
+ ::Type.where(name: "Phase").pluck(:id).map(&:to_s)
end
end
end
diff --git a/modules/gantt/config/routes.rb b/modules/gantt/config/routes.rb
index ec21074b0afd..261a2b35b7ec 100644
--- a/modules/gantt/config/routes.rb
+++ b/modules/gantt/config/routes.rb
@@ -1,24 +1,24 @@
Rails.application.routes.draw do
- scope 'projects/:project_id', as: 'project' do
- resources :gantt, controller: 'gantt/gantt', only: [:index] do
+ scope "projects/:project_id", as: "project" do
+ resources :gantt, controller: "gantt/gantt", only: [:index] do
collection do
# The menu route has to be above the state routes! Otherwise, the menu will be interpreted as another state
- get 'menu' => 'gantt/menus#show'
+ get "menu" => "gantt/menus#show"
# states managed by client-side routing on work_package#index
- get '(/*state)' => 'gantt/gantt#index', as: ''
- get '/create_new' => 'gantt/gantt#index', as: 'new_split'
+ get "(/*state)" => "gantt/gantt#index", as: ""
+ get "/create_new" => "gantt/gantt#index", as: "new_split"
end
end
end
- resources :gantt, controller: 'gantt/gantt', only: [:index] do
+ resources :gantt, controller: "gantt/gantt", only: [:index] do
collection do
# states managed by client-side routing on work_package#index
- get 'details/*state' => 'gantt/gantt#index', as: :details
+ get "details/*state" => "gantt/gantt#index", as: :details
# states managed by client-side (angular) routing on work_package#show
- get '/' => 'gantt/gantt#index', as: 'index'
+ get "/" => "gantt/gantt#index", as: "index"
end
end
diff --git a/modules/gantt/lib/open_project/gantt.rb b/modules/gantt/lib/open_project/gantt.rb
index d6eba8e7d10d..71ecc00e6f7d 100644
--- a/modules/gantt/lib/open_project/gantt.rb
+++ b/modules/gantt/lib/open_project/gantt.rb
@@ -28,6 +28,6 @@
module OpenProject
module Gantt
- require 'open_project/gantt/engine'
+ require "open_project/gantt/engine"
end
end
diff --git a/modules/gantt/lib/open_project/gantt/engine.rb b/modules/gantt/lib/open_project/gantt/engine.rb
index 384b5379b0bd..e3b223cdae26 100644
--- a/modules/gantt/lib/open_project/gantt/engine.rb
+++ b/modules/gantt/lib/open_project/gantt/engine.rb
@@ -32,8 +32,8 @@ class Engine < ::Rails::Engine
include OpenProject::Plugins::ActsAsOpEngine
- register 'openproject-gantt',
- author_url: 'https://www.openproject.org',
+ register "openproject-gantt",
+ author_url: "https://www.openproject.org",
bundled: true,
settings: {} do
Rails.application.reloader.to_prepare do
@@ -42,9 +42,9 @@ class Engine < ::Rails::Engine
end
OpenProject::AccessControl.permission(:view_work_packages).tap do |add|
- add.controller_actions << 'gantt/gantt/index'
- add.controller_actions << 'gantt/gantt/menu'
- add.controller_actions << 'gantt/menus/show'
+ add.controller_actions << "gantt/gantt/index"
+ add.controller_actions << "gantt/gantt/menu"
+ add.controller_actions << "gantt/menus/show"
end
end
@@ -59,51 +59,51 @@ class Engine < ::Rails::Engine
menu :global_menu,
:gantt,
- { controller: '/gantt/gantt', action: 'index', project_id: nil },
+ { controller: "/gantt/gantt", action: "index", project_id: nil },
caption: :label_gantt_chart_plural,
after: :work_packages,
- icon: 'view-timeline',
+ icon: "view-timeline",
if: should_render_global_menu_item
menu :global_menu,
:global_gantt_query_select,
- { controller: '/gantt/gantt', action: 'index' },
+ { controller: "/gantt/gantt", action: "index" },
parent: :gantt,
- partial: 'gantt/menus/menu',
+ partial: "gantt/menus/menu",
last: true,
caption: :label_gantt_chart_plural,
if: should_render_global_menu_item
menu :project_menu,
:gantt,
- { controller: '/gantt/gantt', action: 'index' },
+ { controller: "/gantt/gantt", action: "index" },
caption: :label_gantt_chart_plural,
after: :work_packages,
if: ->(project) { should_render_project_menu.call(project) },
- icon: 'view-timeline',
+ icon: "view-timeline",
html: {
- id: 'main-menu-gantt'
+ id: "main-menu-gantt"
}
menu :project_menu,
:gantt_query_select,
- { controller: '/gantt/gantt', action: 'index' },
+ { controller: "/gantt/gantt", action: "index" },
parent: :gantt,
- partial: 'gantt/menus/menu',
+ partial: "gantt/menus/menu",
last: true,
caption: :label_gantt_chart_plural,
if: ->(project) { should_render_project_menu.call(project) }
menu :top_menu,
:gantt,
- { controller: '/gantt/gantt', action: 'index', project_id: nil },
+ { controller: "/gantt/gantt", action: "index", project_id: nil },
caption: :label_gantt_chart_plural,
after: :work_packages,
- icon: 'view-timeline',
+ icon: "view-timeline",
if: should_render_global_menu_item
end
add_view :Gantt,
- contract_strategy: 'Gantt::Views::ContractStrategy'
+ contract_strategy: "Gantt::Views::ContractStrategy"
end
end
diff --git a/modules/gantt/lib/openproject-gantt.rb b/modules/gantt/lib/openproject-gantt.rb
index 95933c137e09..79d73374978b 100644
--- a/modules/gantt/lib/openproject-gantt.rb
+++ b/modules/gantt/lib/openproject-gantt.rb
@@ -1 +1 @@
-require 'open_project/gantt'
+require "open_project/gantt"
diff --git a/modules/gantt/openproject-gantt.gemspec b/modules/gantt/openproject-gantt.gemspec
index bf96d10b96c4..8c95def17015 100644
--- a/modules/gantt/openproject-gantt.gemspec
+++ b/modules/gantt/openproject-gantt.gemspec
@@ -1,12 +1,12 @@
Gem::Specification.new do |s|
- s.name = 'openproject-gantt'
- s.version = '1.0.0'
- s.authors = 'OpenProject GmbH'
- s.email = 'info@openproject.com'
- s.summary = 'OpenProject Gantt'
- s.description = 'Provides gantt views'
- s.license = 'GPLv3'
+ s.name = "openproject-gantt"
+ s.version = "1.0.0"
+ s.authors = "OpenProject GmbH"
+ s.email = "info@openproject.com"
+ s.summary = "OpenProject Gantt"
+ s.description = "Provides gantt views"
+ s.license = "GPLv3"
- s.files = Dir['{app,config,db,lib}/**/*']
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.files = Dir["{app,config,db,lib}/**/*"]
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/gantt/spec/controllers/gantt/gantt_controller_spec.rb b/modules/gantt/spec/controllers/gantt/gantt_controller_spec.rb
index 836f13594637..ba6c3753e2f3 100644
--- a/modules/gantt/spec/controllers/gantt/gantt_controller_spec.rb
+++ b/modules/gantt/spec/controllers/gantt/gantt_controller_spec.rb
@@ -28,27 +28,27 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Gantt::GanttController do
- shared_let(:project) { create(:project, identifier: 'test_project', public: false) }
+ shared_let(:project) { create(:project, identifier: "test_project", public: false) }
current_user do
create(:user,
member_with_permissions: { project => %i[view_work_packages export_work_packages] })
end
- describe 'index' do
+ describe "index" do
let(:default_gantt_params) { Gantt::DefaultQueryGeneratorService.new(with_project: project).call }
- context 'for atom format' do
- let(:params) { default_gantt_params.merge(project_id: project.id, format: 'atom') }
+ context "for atom format" do
+ let(:params) { default_gantt_params.merge(project_id: project.id, format: "atom") }
- it 'returns the atom feed' do
- get('index', params:)
+ it "returns the atom feed" do
+ get("index", params:)
expect(response).to have_http_status(:success)
- expect(response.content_type).to include('application/atom+xml')
+ expect(response.content_type).to include("application/atom+xml")
end
end
end
diff --git a/modules/gantt/spec/features/menu/global_gantt_menu_spec.rb b/modules/gantt/spec/features/menu/global_gantt_menu_spec.rb
index bad2b9959e39..8d0631b0620d 100644
--- a/modules/gantt/spec/features/menu/global_gantt_menu_spec.rb
+++ b/modules/gantt/spec/features/menu/global_gantt_menu_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Gantt charts menu',
+RSpec.describe "Gantt charts menu",
:js,
:selenium do
let(:user) { create(:admin) }
@@ -84,29 +84,29 @@
login_as(user)
end
- describe 'on the global Gantt charts page' do
- it 'shows all queries without a project' do
+ describe "on the global Gantt charts page" do
+ it "shows all queries without a project" do
wp_global_timeline.visit!
loading_indicator_saveguard
# Show global queries only
- expect(page).to have_css('.op-sidemenu--item-action', text: global_starred_query)
- expect(page).to have_css('.op-sidemenu--item-action', text: global_public_query)
- expect(page).to have_css('.op-sidemenu--item-action', text: global_private_query)
- expect(page).to have_no_css('.op-sidemenu--item-action', text: private_project_query)
+ expect(page).to have_css(".op-sidemenu--item-action", text: global_starred_query)
+ expect(page).to have_css(".op-sidemenu--item-action", text: global_public_query)
+ expect(page).to have_css(".op-sidemenu--item-action", text: global_private_query)
+ expect(page).to have_no_css(".op-sidemenu--item-action", text: private_project_query)
end
end
- describe 'on the project Gantt charts page' do
- it 'shows all queries that belong to the project' do
+ describe "on the project Gantt charts page" do
+ it "shows all queries that belong to the project" do
wp_project_timeline.visit!
loading_indicator_saveguard
# Show project queries only
- expect(page).to have_no_css('.op-sidemenu--item-action', text: global_starred_query)
- expect(page).to have_no_css('.op-sidemenu--item-action', text: global_public_query)
- expect(page).to have_no_css('.op-sidemenu--item-action', text: global_private_query)
- expect(page).to have_css('.op-sidemenu--item-action', text: private_project_query)
+ expect(page).to have_no_css(".op-sidemenu--item-action", text: global_starred_query)
+ expect(page).to have_no_css(".op-sidemenu--item-action", text: global_public_query)
+ expect(page).to have_no_css(".op-sidemenu--item-action", text: global_private_query)
+ expect(page).to have_css(".op-sidemenu--item-action", text: private_project_query)
end
end
end
diff --git a/modules/gantt/spec/features/timeline/timeline_dates_spec.rb b/modules/gantt/spec/features/timeline/timeline_dates_spec.rb
index 50f87f8d9554..4334c328c507 100644
--- a/modules/gantt/spec/features/timeline/timeline_dates_spec.rb
+++ b/modules/gantt/spec/features/timeline/timeline_dates_spec.rb
@@ -26,16 +26,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package timeline date formatting',
+RSpec.describe "Work package timeline date formatting",
:js,
:selenium,
- with_settings: { date_format: '%Y-%m-%d' } do
+ with_settings: { date_format: "%Y-%m-%d" } do
shared_let(:type) { create(:type_bug, color: create(:color_green)) }
shared_let(:project) { create(:project, types: [type], enabled_module_names: %i[work_package_tracking gantt]) }
- shared_let(:start_date) { Date.parse('2020-12-31') }
- shared_let(:due_date) { Date.parse('2021-01-01') }
+ shared_let(:start_date) { Date.parse("2020-12-31") }
+ shared_let(:due_date) { Date.parse("2021-01-01") }
shared_let(:duration) { due_date - start_date + 1 }
shared_let(:work_package) do
@@ -45,7 +45,7 @@
start_date:,
due_date:,
duration:,
- subject: 'My subject')
+ subject: "My subject")
end
shared_let(:work_package_with_non_working_days) do
@@ -53,7 +53,7 @@
project:,
type:,
duration: 5,
- subject: 'My Subject 2')
+ subject: "My Subject 2")
end
shared_let(:work_package_without_non_working_days) do
@@ -62,17 +62,17 @@
type:,
duration: 5,
ignore_non_working_days: true,
- subject: 'Work Package ignoring non working days')
+ subject: "Work Package ignoring non working days")
end
let(:wp_timeline) { Pages::WorkPackagesTimeline.new(project) }
let!(:query_tl) do
query = build(:query_with_view_gantt, user: current_user, project:)
- query.column_names = ['id', 'type', 'subject']
+ query.column_names = ["id", "type", "subject"]
query.filters.clear
query.timeline_visible = true
- query.timeline_zoom_level = 'days'
- query.name = 'Query with Timeline'
+ query.timeline_zoom_level = "days"
+ query.name = "Query with Timeline"
query.save!
query
@@ -92,69 +92,69 @@ def expect_date_week(date, expected_week)
wp_timeline.visit_query query_tl
end
- describe 'with default settings',
- with_settings: { start_of_week: '', first_week_of_year: '' } do
+ describe "with default settings",
+ with_settings: { start_of_week: "", first_week_of_year: "" } do
before do
wp_timeline.expect_timeline!
end
- context 'with german locale user' do
- let(:current_user) { create(:admin, language: 'de') }
+ context "with german locale user" do
+ let(:current_user) { create(:admin, language: "de") }
- it 'shows german ISO dates' do
+ it "shows german ISO dates" do
# expect moment to return week 53 for start date
- expect_date_week work_package.start_date.iso8601, '53'
- expect_date_week work_package.due_date.iso8601, '53'
+ expect_date_week work_package.start_date.iso8601, "53"
+ expect_date_week work_package.due_date.iso8601, "53"
# Monday, 4th of january is the first week
- expect_date_week '2021-01-04', '01'
+ expect_date_week "2021-01-04", "01"
end
end
- context 'with english locale user' do
- let(:current_user) { create(:admin, language: 'en') }
+ context "with english locale user" do
+ let(:current_user) { create(:admin, language: "en") }
- it 'shows english ISO dates' do
+ it "shows english ISO dates" do
# expect moment to return week 01 for start date
- expect_date_week work_package.start_date.iso8601, '01'
- expect_date_week work_package.due_date.iso8601, '01'
+ expect_date_week work_package.start_date.iso8601, "01"
+ expect_date_week work_package.due_date.iso8601, "01"
# Monday, 4th of january is the second week
- expect_date_week '2021-01-04', '02'
+ expect_date_week "2021-01-04", "02"
end
end
- context 'with weekdays defined' do
- let(:current_user) { create(:admin, language: 'en') }
+ context "with weekdays defined" do
+ let(:current_user) { create(:admin, language: "en") }
shared_let(:week_days) { week_with_saturday_and_sunday_as_weekend }
shared_let(:non_working_day) do
create(:non_working_day,
- date: '28-12-2020')
+ date: "28-12-2020")
end
- it 'shows them as disabled' do
- expect_date_week work_package.start_date.iso8601, '01'
+ it "shows them as disabled" do
+ expect_date_week work_package.start_date.iso8601, "01"
- expect(page).to have_test_selector('wp-timeline--non-working-day_27-12-2020')
- expect(page).to have_test_selector('wp-timeline--non-working-day_2-1-2021')
- expect(page).to have_test_selector('wp-timeline--non-working-day_28-12-2020')
+ expect(page).to have_test_selector("wp-timeline--non-working-day_27-12-2020")
+ expect(page).to have_test_selector("wp-timeline--non-working-day_2-1-2021")
+ expect(page).to have_test_selector("wp-timeline--non-working-day_28-12-2020")
- expect(page).not_to have_test_selector('wp-timeline--non-working-day_29-12-2020')
- expect(page).not_to have_test_selector('wp-timeline--non-working-day_30-12-2020')
- expect(page).not_to have_test_selector('wp-timeline--non-working-day_31-12-2020')
- expect(page).not_to have_test_selector('wp-timeline--non-working-day_1-1-2021')
+ expect(page).not_to have_test_selector("wp-timeline--non-working-day_29-12-2020")
+ expect(page).not_to have_test_selector("wp-timeline--non-working-day_30-12-2020")
+ expect(page).not_to have_test_selector("wp-timeline--non-working-day_31-12-2020")
+ expect(page).not_to have_test_selector("wp-timeline--non-working-day_1-1-2021")
end
end
end
- describe 'with US/CA settings',
+ describe "with US/CA settings",
# According to our documentation:
# https://www.openproject.org/docs/system-admin-guide/calendars-and-dates/#date-format
- with_settings: { start_of_week: '7', first_week_of_year: '6' } do
+ with_settings: { start_of_week: "7", first_week_of_year: "6" } do
let(:current_user) { create(:admin) }
- it 'shows english ISO dates' do
- expect(page).to have_css('.wp-timeline--header-element', text: '01')
- expect(page).to have_css('.wp-timeline--header-element', text: '02')
+ it "shows english ISO dates" do
+ expect(page).to have_css(".wp-timeline--header-element", text: "01")
+ expect(page).to have_css(".wp-timeline--header-element", text: "02")
# The last weekday determines whether there are 52 or 53 weeks
# Only if the last day in the year is exactly the day before the day configured to be
@@ -166,23 +166,23 @@ def expect_date_week(date, expected_week)
53
end
- expect(page).to have_css('.wp-timeline--header-element', text: number_of_weeks)
- expect(page).to have_no_css('.wp-timeline--header-element', text: number_of_weeks + 1)
+ expect(page).to have_css(".wp-timeline--header-element", text: number_of_weeks)
+ expect(page).to have_no_css(".wp-timeline--header-element", text: number_of_weeks + 1)
# expect moment to return week 01 for start date and due date
- expect_date_week work_package.start_date.iso8601, '01'
- expect_date_week work_package.due_date.iso8601, '01'
+ expect_date_week work_package.start_date.iso8601, "01"
+ expect_date_week work_package.due_date.iso8601, "01"
# First sunday in january is in second week
- expect_date_week '2021-01-03', '02'
+ expect_date_week "2021-01-03", "02"
end
end
- describe 'setting dates' do
+ describe "setting dates" do
shared_let(:week_days) { week_with_saturday_and_sunday_as_weekend }
let(:current_user) { create(:admin) }
let(:row) { wp_timeline.timeline_row work_package_with_non_working_days.id }
- it 'today_line is in view' do
+ it "today_line is in view" do
row.wait_until_hoverable
today_line_offsetLeft = page.evaluate_script <<~JS
document.getElementById('wp-timeline-static-element-today-line').offsetLeft
@@ -198,11 +198,11 @@ def expect_date_week(date, expected_week)
shared_let(:non_working_day) do
create(:non_working_day,
- date: '06-01-2021')
+ date: "06-01-2021")
end
shared_examples "sets dates, duration and displays bar" do
- it 'sets dates, duration and duration bar' do
+ it "sets dates, duration and duration bar" do
subject
row.expect_bar(duration: expected_bar_duration)
@@ -221,13 +221,13 @@ def expect_date_week(date, expected_week)
end
end
- context 'with an existing duration only' do
+ context "with an existing duration only" do
before do
# Reset dates on each run
work_package_with_non_working_days.update({ start_date: nil, due_date: nil, duration: 5 })
end
- it 'displays the hover bar correctly' do
+ it "displays the hover bar correctly" do
# Expect no hover bar when hovering over a non working day
row.hover_bar(offset_days: -1)
row.expect_no_hovered_bar
@@ -246,72 +246,72 @@ def expect_date_week(date, expected_week)
row.expect_hovered_bar(duration: work_package_with_non_working_days.duration + 2)
end
- describe 'set the start, due date while preserving duration' do
+ describe "set the start, due date while preserving duration" do
subject { row.click_bar }
- it_behaves_like 'sets dates, duration and displays bar' do
+ it_behaves_like "sets dates, duration and displays bar" do
let(:target_wp) { work_package_with_non_working_days }
let(:expected_bar_duration) { work_package_with_non_working_days.duration }
- let(:expected_start_date) { Date.parse('2021-01-04') }
- let(:expected_due_date) { Date.parse('2021-01-08') }
+ let(:expected_start_date) { Date.parse("2021-01-04") }
+ let(:expected_due_date) { Date.parse("2021-01-08") }
let(:expected_duration) { 4 }
let(:expected_label) { work_package_with_non_working_days.subject }
end
end
- describe 'set the start, due date while preserving duration over the weekend' do
+ describe "set the start, due date while preserving duration over the weekend" do
subject { row.click_bar(offset_days: 1) }
- it_behaves_like 'sets dates, duration and displays bar' do
+ it_behaves_like "sets dates, duration and displays bar" do
let(:target_wp) { work_package_with_non_working_days }
let(:expected_bar_duration) { work_package_with_non_working_days.duration + 2 }
- let(:expected_start_date) { Date.parse('2021-01-05') }
- let(:expected_due_date) { Date.parse('2021-01-11') }
+ let(:expected_start_date) { Date.parse("2021-01-05") }
+ let(:expected_due_date) { Date.parse("2021-01-11") }
let(:expected_duration) { 4 }
let(:expected_label) { work_package_with_non_working_days.subject }
end
end
- describe 'sets the start, due dates while preserving duration on a drag and drop create' do
+ describe "sets the start, due dates while preserving duration on a drag and drop create" do
subject { row.drag_and_drop(days: 5) }
- it_behaves_like 'sets dates, duration and displays bar' do
+ it_behaves_like "sets dates, duration and displays bar" do
let(:target_wp) { work_package_with_non_working_days }
let(:expected_bar_duration) { work_package_with_non_working_days.duration }
- let(:expected_start_date) { Date.parse('2021-01-04') }
- let(:expected_due_date) { Date.parse('2021-01-08') }
+ let(:expected_start_date) { Date.parse("2021-01-04") }
+ let(:expected_due_date) { Date.parse("2021-01-08") }
let(:expected_duration) { 4 }
let(:expected_label) { work_package_with_non_working_days.subject }
end
end
- describe 'sets the start, due dates while preserving duration on a drag and drop create over the weekend' do
+ describe "sets the start, due dates while preserving duration on a drag and drop create over the weekend" do
subject { row.drag_and_drop(offset_days: 1, days: 7) }
- it_behaves_like 'sets dates, duration and displays bar' do
+ it_behaves_like "sets dates, duration and displays bar" do
let(:target_wp) { work_package_with_non_working_days }
let(:expected_bar_duration) { work_package_with_non_working_days.duration + 2 }
- let(:expected_start_date) { Date.parse('2021-01-05') }
- let(:expected_due_date) { Date.parse('2021-01-11') }
+ let(:expected_start_date) { Date.parse("2021-01-05") }
+ let(:expected_due_date) { Date.parse("2021-01-11") }
let(:expected_duration) { 4 }
let(:expected_label) { work_package_with_non_working_days.subject }
end
end
- describe 'sets the start, due dates and duration on a drag and drop create over the weekend' do
+ describe "sets the start, due dates and duration on a drag and drop create over the weekend" do
subject { row.drag_and_drop(offset_days: 1, days: 8) }
- it_behaves_like 'sets dates, duration and displays bar' do
+ it_behaves_like "sets dates, duration and displays bar" do
let(:target_wp) { work_package_with_non_working_days }
let(:expected_bar_duration) { work_package_with_non_working_days.duration + 3 }
- let(:expected_start_date) { Date.parse('2021-01-05') }
- let(:expected_due_date) { Date.parse('2021-01-12') }
+ let(:expected_start_date) { Date.parse("2021-01-05") }
+ let(:expected_due_date) { Date.parse("2021-01-12") }
let(:expected_duration) { 5 }
let(:expected_label) { work_package_with_non_working_days.subject }
end
end
- it 'cancels when the drag starts or finishes on a weekend' do
+ it "cancels when the drag starts or finishes on a weekend" do
# Finish on the weekend
row.drag_and_drop(offset_days: 1, days: 5)
@@ -325,17 +325,17 @@ def expect_date_week(date, expected_week)
expect { work_package_with_non_working_days.reload }.not_to change { work_package_with_non_working_days }
end
- context 'when ignore_non_working_days is true' do
+ context "when ignore_non_working_days is true" do
let(:row) { wp_timeline.timeline_row work_package_without_non_working_days.id }
- describe 'sets the start, due dates and duration on a drag and drop create over the weekend' do
+ describe "sets the start, due dates and duration on a drag and drop create over the weekend" do
subject { row.drag_and_drop(offset_days: 1, days: 8) }
- it_behaves_like 'sets dates, duration and displays bar' do
+ it_behaves_like "sets dates, duration and displays bar" do
let(:target_wp) { work_package_without_non_working_days }
let(:expected_bar_duration) { work_package_without_non_working_days.duration + 3 }
- let(:expected_start_date) { Date.parse('2021-01-05') }
- let(:expected_due_date) { Date.parse('2021-01-12') }
+ let(:expected_start_date) { Date.parse("2021-01-05") }
+ let(:expected_due_date) { Date.parse("2021-01-12") }
let(:expected_duration) { 8 }
let(:expected_label) { work_package_without_non_working_days.subject }
end
diff --git a/modules/gantt/spec/features/timeline/timeline_hierarchy_spec.rb b/modules/gantt/spec/features/timeline/timeline_hierarchy_spec.rb
index 6d07707c9549..702362f2722b 100644
--- a/modules/gantt/spec/features/timeline/timeline_hierarchy_spec.rb
+++ b/modules/gantt/spec/features/timeline/timeline_hierarchy_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package timeline hierarchies',
+RSpec.describe "Work package timeline hierarchies",
:js,
:selenium do
let(:user) { create(:admin) }
@@ -45,7 +45,7 @@
end
let!(:query) do
query = build(:query_with_view_gantt, user:, project:)
- query.column_names = ['subject']
+ query.column_names = ["subject"]
query.filters.clear
query.show_hierarchies = true
query.timeline_visible = true
@@ -64,7 +64,7 @@
login_as(user)
end
- it 'hides the row in both hierarchy and timeline' do
+ it "hides the row in both hierarchy and timeline" do
wp_timeline.visit_query query
# Expect root and leaf visible in table and timeline
@@ -84,10 +84,10 @@
wp_timeline.expect_hidden_row(wp_leaf)
# Should now have exactly two rows (one in each split view)
- expect(page).to have_css('.wp--row', count: 2)
+ expect(page).to have_css(".wp--row", count: 2)
end
- context 'with a relation being rendered to a hidden row' do
+ context "with a relation being rendered to a hidden row" do
let!(:wp_other) do
create(:work_package,
project:,
@@ -101,7 +101,7 @@
relation_type: Relation::TYPE_FOLLOWS)
end
- it 'does not render the relation when hierarchy is collapsed' do
+ it "does not render the relation when hierarchy is collapsed" do
wp_timeline.visit_query query
# Expect root and leaf visible in table and timeline
diff --git a/modules/gantt/spec/features/timeline/timeline_labels_spec.rb b/modules/gantt/spec/features/timeline/timeline_labels_spec.rb
index 4b27ed354572..0ba9d1be6ad1 100644
--- a/modules/gantt/spec/features/timeline/timeline_labels_spec.rb
+++ b/modules/gantt/spec/features/timeline/timeline_labels_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package timeline labels',
+RSpec.describe "Work package timeline labels",
:js,
:selenium,
- with_settings: { date_format: '%Y-%m-%d' } do
+ with_settings: { date_format: "%Y-%m-%d" } do
let(:user) { create(:admin) }
let(:today) { Time.zone.today }
let(:tomorrow) { Time.zone.tomorrow }
@@ -43,8 +43,8 @@
assigned_to: user,
start_date: today,
due_date: tomorrow,
- subject: 'My subject',
- custom_field_values: { custom_field.id => custom_value_for('onions') })
+ subject: "My subject",
+ custom_field_values: { custom_field.id => custom_value_for("onions") })
end
let(:milestone_work_package) do
create(:work_package,
@@ -52,7 +52,7 @@
type: milestone_type,
start_date: future,
due_date: future,
- subject: 'My milestone')
+ subject: "My milestone")
end
let(:type) { create(:type_bug) }
let(:milestone_type) { create(:type, is_milestone: true) }
@@ -77,7 +77,7 @@
query = build(:query_with_view_gantt, user:, project:)
query.filters.clear
query.timeline_visible = true
- query.name = 'Query with Timeline'
+ query.name = "Query with Timeline"
query.save!
@@ -98,12 +98,12 @@ def custom_value_for(str)
wp_timeline.expect_timeline!
end
- it 'shows and allows to configure labels' do
+ it "shows and allows to configure labels" do
# Check default labels (bar type)
row = wp_timeline.timeline_row work_package.id
row.expect_labels left: nil,
right: nil,
- farRight: 'My subject'
+ farRight: "My subject"
row.expect_hovered_labels left: today.iso8601, right: tomorrow.iso8601
@@ -111,18 +111,18 @@ def custom_value_for(str)
row = wp_timeline.timeline_row milestone_work_package.id
row.expect_labels left: nil,
right: nil,
- farRight: 'My milestone'
+ farRight: "My milestone"
row.expect_hovered_labels left: nil, right: future.iso8601
# Modify label configuration
config_modal.open!
- config_modal.expect_labels! left: '(none)',
- right: '(none)',
- farRight: 'Subject'
+ config_modal.expect_labels! left: "(none)",
+ right: "(none)",
+ farRight: "Subject"
- config_modal.update_labels left: 'Assignee',
- right: 'Type',
- farRight: 'Status'
+ config_modal.update_labels left: "Assignee",
+ right: "Type",
+ farRight: "Status"
# Check overridden labels
row = wp_timeline.timeline_row work_package.id
@@ -132,19 +132,19 @@ def custom_value_for(str)
# Check default labels (milestone)
row = wp_timeline.timeline_row milestone_work_package.id
- row.expect_labels left: '-',
+ row.expect_labels left: "-",
right: milestone_type.name.upcase,
farRight: milestone_work_package.status.name
# Save the query
- settings_menu.open_and_save_query_as 'changed labels'
- wp_timeline.expect_title 'changed labels'
+ settings_menu.open_and_save_query_as "changed labels"
+ wp_timeline.expect_title "changed labels"
# Check the query
query = Query.last
- expect(query.timeline_labels).to eq left: 'assignee',
- right: 'type',
- farRight: 'status'
+ expect(query.timeline_labels).to eq left: "assignee",
+ right: "type",
+ farRight: "status"
# Revisit page
wp_timeline.visit_query query
@@ -159,19 +159,19 @@ def custom_value_for(str)
# Check overridden labels (milestone)
row = wp_timeline.timeline_row milestone_work_package.id
- row.expect_labels left: '-',
+ row.expect_labels left: "-",
right: milestone_type.name.upcase,
farRight: milestone_work_package.status.name
# Set labels to start|due|subject
config_modal.open!
- config_modal.expect_labels! left: 'Assignee',
- right: 'Type',
- farRight: 'Status'
+ config_modal.expect_labels! left: "Assignee",
+ right: "Type",
+ farRight: "Status"
- config_modal.update_labels left: 'Start date',
- right: 'Finish date',
- farRight: 'Subject'
+ config_modal.update_labels left: "Start date",
+ right: "Finish date",
+ farRight: "Subject"
# Check overridden labels
row = wp_timeline.timeline_row work_package.id
diff --git a/modules/gantt/spec/features/timeline/timeline_navigation_spec.rb b/modules/gantt/spec/features/timeline/timeline_navigation_spec.rb
index abf15eec2f29..6664d1f43dcb 100644
--- a/modules/gantt/spec/features/timeline/timeline_navigation_spec.rb
+++ b/modules/gantt/spec/features/timeline/timeline_navigation_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package timeline navigation',
+RSpec.describe "Work package timeline navigation",
:js,
:selenium do
let(:user) { create(:admin) }
@@ -61,7 +61,7 @@
login_as(user)
end
- describe 'with multiple queries' do
+ describe "with multiple queries" do
let(:type) { create(:type) }
let(:type2) { create(:type) }
let(:project) { create(:project, enabled_module_names:, types: [type, type2]) }
@@ -80,11 +80,11 @@
let!(:query) do
query = build(:query_with_view_work_packages_table, user:, project:)
- query.column_names = ['id', 'type', 'subject']
+ query.column_names = ["id", "type", "subject"]
query.filters.clear
query.timeline_visible = false
- query.add_filter('type_id', '=', [type.id])
- query.name = 'Query without Timeline'
+ query.add_filter("type_id", "=", [type.id])
+ query.name = "Query without Timeline"
query.save!
create(:view_work_packages_table,
@@ -95,11 +95,11 @@
let!(:query_tl) do
query = build(:query_with_view_gantt, user:, project:)
- query.column_names = ['id', 'type', 'subject']
+ query.column_names = ["id", "type", "subject"]
query.filters.clear
- query.add_filter('type_id', '=', [type2.id])
+ query.add_filter("type_id", "=", [type2.id])
query.timeline_visible = true
- query.name = 'Query with Timeline'
+ query.name = "Query with Timeline"
query.save!
create(:view_gantt,
@@ -108,7 +108,7 @@
query
end
- it 'can move from and to the timeline query (Regression test #26086)' do
+ it "can move from and to the timeline query (Regression test #26086)" do
# Visit timeline query
wp_timeline.visit_query query_tl
@@ -117,8 +117,8 @@
wp_timeline.ensure_work_package_not_listed! work_package
# Navigate to the WP module
- find('.main-menu--arrow-left-to-project').click
- find('#main-menu-work-packages-wrapper .main-menu-toggler').click
+ find(".main-menu--arrow-left-to-project").click
+ find("#main-menu-work-packages-wrapper .main-menu-toggler").click
# Select other query
query_menu.select query
@@ -127,8 +127,8 @@
wp_table.ensure_work_package_not_listed! work_package2
# Navigate to the Gantt module agin
- find('.main-menu--arrow-left-to-project').click
- find('#main-menu-gantt-wrapper .main-menu-toggler').click
+ find(".main-menu--arrow-left-to-project").click
+ find("#main-menu-gantt-wrapper .main-menu-toggler").click
# Select first query again
query_menu.click_item query_tl.name
@@ -138,7 +138,7 @@
wp_timeline.ensure_work_package_not_listed! work_package
end
- it 'can open a context menu in the timeline (Regression #30761)' do
+ it "can open a context menu in the timeline (Regression #30761)" do
# Visit timeline query
wp_timeline.visit_query query_tl
@@ -148,14 +148,14 @@
retry_block do
find(".wp-row-#{work_package2.id}-timeline").right_click
- find('.menu-item', text: 'Add predecessor')
- find('.menu-item', text: 'Add follower')
+ find(".menu-item", text: "Add predecessor")
+ find(".menu-item", text: "Add follower")
end
end
end
- describe 'with the default query' do
- let(:closed_status) { create(:closed_status, name: 'Closed') }
+ describe "with the default query" do
+ let(:closed_status) { create(:closed_status, name: "Closed") }
let(:project) { create(:project, types: [milestone_type], enabled_module_names:) }
let!(:wp_milestone) do
@@ -169,7 +169,7 @@
status: closed_status)
end
- it 'shows the timeline open initially' do
+ it "shows the timeline open initially" do
wp_timeline.visit!
loading_indicator_saveguard
@@ -183,7 +183,7 @@
end
end
- it 'can save the open state and zoom of timeline' do
+ it "can save the open state and zoom of timeline" do
wp_timeline.visit_query query
wp_timeline.expect_work_package_listed(work_package)
@@ -202,13 +202,13 @@
wp_timeline.expect_zoom_at :weeks
# Save the query
- settings_menu.open_and_save_query_as 'foobar'
- wp_timeline.expect_title 'foobar'
+ settings_menu.open_and_save_query_as "foobar"
+ wp_timeline.expect_title "foobar"
# Check the query
query = Query.last
expect(query.timeline_visible).to be_truthy
- expect(query.timeline_zoom_level).to eq 'weeks'
+ expect(query.timeline_zoom_level).to eq "weeks"
# Revisit page
wp_timeline.visit_query query
@@ -225,13 +225,13 @@
# Save
wp_timeline.save
- wp_timeline.expect_and_dismiss_toaster message: 'Successful update'
+ wp_timeline.expect_and_dismiss_toaster message: "Successful update"
query.reload
- expect(query.timeline_zoom_level).to eq 'auto'
+ expect(query.timeline_zoom_level).to eq "auto"
end
- describe 'with a hierarchy being shown' do
+ describe "with a hierarchy being shown" do
let!(:child_work_package) do
create(:work_package,
project:,
@@ -250,7 +250,7 @@
query
end
- it 'toggles the hierarchy in both views' do
+ it "toggles the hierarchy in both views" do
wp_timeline.visit_query query
loading_indicator_saveguard
wp_timeline.expect_work_package_listed(work_package)
@@ -273,10 +273,10 @@
end
end
- describe 'when table is grouped' do
+ describe "when table is grouped" do
let(:project) { create(:project) }
- let(:category) { create(:category, project:, name: 'Foo') }
- let(:category2) { create(:category, project:, name: 'Bar') }
+ let(:category) { create(:category, project:, name: "Foo") }
+ let(:category2) { create(:category, project:, name: "Bar") }
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
let(:relations) { Components::WorkPackages::Relations.new(wp_cat1) }
@@ -301,7 +301,7 @@
type: milestone_type,
start_date: Date.current - 10.days,
due_date: Date.current - 10.days,
- subject: 'My milestone')
+ subject: "My milestone")
end
let!(:wp_none) do
@@ -318,7 +318,7 @@
let!(:query) do
query = build(:query_with_view_gantt, user:, project:)
- query.column_names = ['id', 'subject', 'category']
+ query.column_names = ["id", "subject", "category"]
query.show_hierarchies = false
query.timeline_visible = true
@@ -326,33 +326,33 @@
query
end
- it 'mirrors group handling when grouping by category' do
+ it "mirrors group handling when grouping by category" do
wp_table.visit_query(query)
wp_table.expect_work_package_listed(wp_cat1, wp_cat2, wp_none)
- group_by.enable_via_menu 'Category'
+ group_by.enable_via_menu "Category"
# Expect table to be grouped as WP created above
- expect(page).to have_css('.group--value .count', count: 3)
+ expect(page).to have_css(".group--value .count", count: 3)
# Expect timeline to have relation between first and second group
wp_timeline.expect_timeline_relation(wp_cat1, wp_cat2)
# Collapse Foo section
- header = find('.wp-table--group-header', text: 'Foo (1)')
- header.find('.expander').click
+ header = find(".wp-table--group-header", text: "Foo (1)")
+ header.find(".expander").click
wp_timeline.ensure_work_package_not_listed!(wp_cat1)
# Relation should be hidden
wp_timeline.expect_no_timeline_relation(wp_cat1, wp_cat2)
end
- it 'removes the relation element when removed in split screen' do
+ it "removes the relation element when removed in split screen" do
wp_table.visit_query(query)
wp_table.expect_work_package_listed(wp_cat1, wp_cat2, wp_none)
# Expect timeline to have relation between first and second group
- within('.work-packages-split-view--tabletimeline-side') do
+ within(".work-packages-split-view--tabletimeline-side") do
wp_timeline.expect_timeline_relation(wp_cat1, wp_cat2)
wp_timeline.expect_timeline_element(wp_cat1)
wp_timeline.expect_timeline_element(wp_cat2)
@@ -364,32 +364,32 @@
relations.remove_relation(wp_cat2)
# Relation should be removed in TL
- within('.work-packages-split-view--tabletimeline-side') do
+ within(".work-packages-split-view--tabletimeline-side") do
wp_timeline.expect_timeline_element(wp_cat1)
wp_timeline.expect_timeline_element(wp_cat2)
wp_timeline.expect_no_timeline_relation(wp_cat1, wp_cat2)
end
end
- it 'shows milestone icons on collapsed project group rows but not on expanded ones' do
+ it "shows milestone icons on collapsed project group rows but not on expanded ones" do
wp_table.visit_query(query)
# The button to fold/expand all groups is only present when grouping
expect(page)
- .to have_no_button('wp-fold-toggle-button')
+ .to have_no_button("wp-fold-toggle-button")
- group_by.enable_via_menu 'Project'
+ group_by.enable_via_menu "Project"
# Collapse Foo section
- find('.wp-table--group-header', text: 'My Project No.')
- .find('.expander')
+ find(".wp-table--group-header", text: "My Project No.")
+ .find(".expander")
.click
# Folding will lead to having milestones presented within the group row
- expect(page).to have_css('.-group-row .timeline-element.milestone')
+ expect(page).to have_css(".-group-row .timeline-element.milestone")
# Check hover labels (milestone)
- milestone = find('.timeline-element.milestone')
+ milestone = find(".timeline-element.milestone")
milestone.hover
expect(milestone).to have_css(".labelHoverLeft.not-empty")
@@ -399,17 +399,17 @@
expect(milestone).to have_css(".labelFarRight", visible: :hidden)
# Unfold Group rows
- find('.wp-table--group-header', text: 'My Project No.')
- .find('.expander')
+ find(".wp-table--group-header", text: "My Project No.")
+ .find(".expander")
.click
- expect(page).to have_no_css('.-group-row .timeline-element')
+ expect(page).to have_no_css(".-group-row .timeline-element")
- click_button('wp-fold-toggle-button')
- click_button(I18n.t('js.button_collapse_all'))
+ click_button("wp-fold-toggle-button")
+ click_button(I18n.t("js.button_collapse_all"))
# Will again fold all rows so the milestone elements should again be present
- expect(page).to have_css('.-group-row .timeline-element.milestone')
+ expect(page).to have_css(".-group-row .timeline-element.milestone")
end
end
end
diff --git a/modules/gantt/spec/migrations/change_view_of_queries_with_timeline_to_gantt_spec.rb b/modules/gantt/spec/migrations/change_view_of_queries_with_timeline_to_gantt_spec.rb
index 4f8cd7c1f843..4b5965f7a2ec 100644
--- a/modules/gantt/spec/migrations/change_view_of_queries_with_timeline_to_gantt_spec.rb
+++ b/modules/gantt/spec/migrations/change_view_of_queries_with_timeline_to_gantt_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require Rails.root.join("db/migrate/20231201085450_change_view_of_queries_with_timeline_to_gantt.rb")
RSpec.describe ChangeViewOfQueriesWithTimelineToGantt, type: :model do
@@ -55,13 +55,13 @@
query
end
- context 'when migrating up' do
+ context "when migrating up" do
# Silencing migration logs, since we are not interested in that during testing
subject { ActiveRecord::Migration.suppress_messages { described_class.new.up } }
it "changes the view type for (work package table) queries with enabled timeline" do
expect { subject }
- .to change { View.where(query_id: wp_query_with_timeline.id).first.type }.from('work_packages_table').to('gantt')
+ .to change { View.where(query_id: wp_query_with_timeline.id).first.type }.from("work_packages_table").to("gantt")
expect { subject }
.not_to change { View.where(query_id: wp_query_without_timeline.id).first.type }
expect { subject }
@@ -69,7 +69,7 @@
end
end
- context 'when migrating down' do
+ context "when migrating down" do
let!(:gantt_query) do
query = create(:query_with_view_gantt)
query.timeline_visible = true
@@ -83,7 +83,7 @@
it "changes the view type for (gantt table) queries" do
expect { subject }
- .to change { View.where(query_id: gantt_query.id).first.type }.from('gantt').to('work_packages_table')
+ .to change { View.where(query_id: gantt_query.id).first.type }.from("gantt").to("work_packages_table")
expect { subject }
.not_to change { View.where(query_id: wp_query_with_timeline.id).first.type }
expect { subject }
diff --git a/modules/gantt/spec/routing/gantt_routing_spec.rb b/modules/gantt/spec/routing/gantt_routing_spec.rb
index d64644bf8c6f..e592c27df9b4 100644
--- a/modules/gantt/spec/routing/gantt_routing_spec.rb
+++ b/modules/gantt/spec/routing/gantt_routing_spec.rb
@@ -26,46 +26,46 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Gantt routing' do
- context 'with :project_id' do
- it 'routes to gantt#index' do
+RSpec.describe "Gantt routing" do
+ context "with :project_id" do
+ it "routes to gantt#index" do
expect(subject)
- .to route(:get, '/projects/foobar/gantt')
- .to(controller: 'gantt/gantt', action: :index, project_id: 'foobar')
+ .to route(:get, "/projects/foobar/gantt")
+ .to(controller: "gantt/gantt", action: :index, project_id: "foobar")
end
- it 'connects GET /projects/:project_id/gantt/create_new to gantt#index' do
- expect(get('/projects/1/gantt/create_new'))
- .to route_to(controller: 'gantt/gantt',
- action: 'index',
- project_id: '1',
- state: 'create_new')
+ it "connects GET /projects/:project_id/gantt/create_new to gantt#index" do
+ expect(get("/projects/1/gantt/create_new"))
+ .to route_to(controller: "gantt/gantt",
+ action: "index",
+ project_id: "1",
+ state: "create_new")
end
- it 'connects GET /projects/:project_id/gantt/details/:id/:state' +
- ' to gantt#index' do
- expect(get('/projects/1/gantt/details/2/overview'))
- .to route_to(controller: 'gantt/gantt',
- action: 'index',
- project_id: '1',
- state: 'details/2/overview')
+ it "connects GET /projects/:project_id/gantt/details/:id/:state" +
+ " to gantt#index" do
+ expect(get("/projects/1/gantt/details/2/overview"))
+ .to route_to(controller: "gantt/gantt",
+ action: "index",
+ project_id: "1",
+ state: "details/2/overview")
end
end
- context 'without :project_id' do
- it 'routes to gantt#index' do
+ context "without :project_id" do
+ it "routes to gantt#index" do
expect(subject)
- .to route(:get, '/gantt')
- .to(controller: 'gantt/gantt', action: :index)
+ .to route(:get, "/gantt")
+ .to(controller: "gantt/gantt", action: :index)
end
- it 'connects GET /gantt/details/:state to gantt#index' do
- expect(get('/gantt/details/5/overview'))
- .to route_to(controller: 'gantt/gantt',
- action: 'index',
- state: '5/overview')
+ it "connects GET /gantt/details/:state to gantt#index" do
+ expect(get("/gantt/details/5/overview"))
+ .to route_to(controller: "gantt/gantt",
+ action: "index",
+ state: "5/overview")
end
end
end
diff --git a/modules/github_integration/app/models/github_check_run.rb b/modules/github_integration/app/models/github_check_run.rb
index 38c10ead37d0..c214004f8917 100644
--- a/modules/github_integration/app/models/github_check_run.rb
+++ b/modules/github_integration/app/models/github_check_run.rb
@@ -30,20 +30,20 @@ class GithubCheckRun < ApplicationRecord
belongs_to :github_pull_request, touch: true
enum status: {
- completed: 'completed',
- in_progress: 'in_progress',
- queued: 'queued'
+ completed: "completed",
+ in_progress: "in_progress",
+ queued: "queued"
}
enum conclusion: {
- action_required: 'action_required',
- cancelled: 'cancelled',
- failure: 'failure',
- neutral: 'neutral',
- skipped: 'skipped',
- stale: 'stale',
- success: 'success',
- timed_out: 'timed_out'
+ action_required: "action_required",
+ cancelled: "cancelled",
+ failure: "failure",
+ neutral: "neutral",
+ skipped: "skipped",
+ stale: "stale",
+ success: "success",
+ timed_out: "timed_out"
}
validates_presence_of :github_app_owner_avatar_url,
diff --git a/modules/github_integration/app/models/github_pull_request.rb b/modules/github_integration/app/models/github_pull_request.rb
index 32c16ae749a4..4b53509d7ba1 100644
--- a/modules/github_integration/app/models/github_pull_request.rb
+++ b/modules/github_integration/app/models/github_pull_request.rb
@@ -32,11 +32,11 @@ class GithubPullRequest < ApplicationRecord
has_and_belongs_to_many :work_packages
has_many :github_check_runs, dependent: :destroy
belongs_to :github_user, optional: true
- belongs_to :merged_by, optional: true, class_name: 'GithubUser'
+ belongs_to :merged_by, optional: true, class_name: "GithubUser"
enum state: {
- open: 'open',
- closed: 'closed'
+ open: "open",
+ closed: "closed"
}
validates_presence_of :github_html_url,
@@ -92,6 +92,6 @@ def validate_labels_schema
return if labels.nil?
return if labels.all? { |label| label.keys.sort == LABEL_KEYS }
- errors.add(:labels, 'invalid schema')
+ errors.add(:labels, "invalid schema")
end
end
diff --git a/modules/github_integration/db/migrate/20210407110000_github_integration_models.rb b/modules/github_integration/db/migrate/20210407110000_github_integration_models.rb
index cc7367112505..4e23b65f2a62 100644
--- a/modules/github_integration/db/migrate/20210407110000_github_integration_models.rb
+++ b/modules/github_integration/db/migrate/20210407110000_github_integration_models.rb
@@ -55,7 +55,7 @@ def change
end
create_join_table :github_pull_requests, :work_packages do |t|
- t.index :github_pull_request_id, name: 'github_pr_wp_pr_id'
+ t.index :github_pull_request_id, name: "github_pr_wp_pr_id"
t.index %i[github_pull_request_id work_package_id],
unique: true,
name: "unique_index_gh_prs_wps_on_gh_pr_id_and_wp_id"
diff --git a/modules/github_integration/lib/api/v3/github_pull_requests/github_check_run_representer.rb b/modules/github_integration/lib/api/v3/github_pull_requests/github_check_run_representer.rb
index 3b37b8856f6f..ae9f039d140d 100644
--- a/modules/github_integration/lib/api/v3/github_pull_requests/github_check_run_representer.rb
+++ b/modules/github_integration/lib/api/v3/github_pull_requests/github_check_run_representer.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'roar/decorator'
-require 'roar/json/hal'
+require "roar/decorator"
+require "roar/json/hal"
module API
module V3
@@ -52,7 +52,7 @@ class GithubCheckRunRepresenter < ::API::Decorators::Single
date_time_property :completed_at
def _type
- 'GithubCheckRun'
+ "GithubCheckRun"
end
end
end
diff --git a/modules/github_integration/lib/api/v3/github_pull_requests/github_pull_request_representer.rb b/modules/github_integration/lib/api/v3/github_pull_requests/github_pull_request_representer.rb
index dd1443aa749a..afd486e7c455 100644
--- a/modules/github_integration/lib/api/v3/github_pull_requests/github_pull_request_representer.rb
+++ b/modules/github_integration/lib/api/v3/github_pull_requests/github_pull_request_representer.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'roar/decorator'
-require 'roar/json/hal'
+require "roar/decorator"
+require "roar/json/hal"
module API
module V3
@@ -115,7 +115,7 @@ def initialize(model, current_user:, **_opts)
date_time_property :updated_at
def _type
- 'GithubPullRequest'
+ "GithubPullRequest"
end
self.to_eager_load = %i[github_user merged_by]
diff --git a/modules/github_integration/lib/api/v3/github_pull_requests/github_pull_requests_api.rb b/modules/github_integration/lib/api/v3/github_pull_requests/github_pull_requests_api.rb
index ced6c95cca5e..35bf8f7bdcfb 100644
--- a/modules/github_integration/lib/api/v3/github_pull_requests/github_pull_requests_api.rb
+++ b/modules/github_integration/lib/api/v3/github_pull_requests/github_pull_requests_api.rb
@@ -31,7 +31,7 @@ module V3
module GithubPullRequests
class GithubPullRequestsAPI < ::API::OpenProjectAPI
resources :github_pull_requests do
- route_param :id, type: Integer, desc: 'Pull Request ID' do
+ route_param :id, type: Integer, desc: "Pull Request ID" do
after_validation do
@pull_request = GithubPullRequest.find(declared_params[:id])
diff --git a/modules/github_integration/lib/api/v3/github_pull_requests/github_user_representer.rb b/modules/github_integration/lib/api/v3/github_pull_requests/github_user_representer.rb
index 8adf219b7be3..153eb7e15cc7 100644
--- a/modules/github_integration/lib/api/v3/github_pull_requests/github_user_representer.rb
+++ b/modules/github_integration/lib/api/v3/github_pull_requests/github_user_representer.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'roar/decorator'
-require 'roar/json/hal'
+require "roar/decorator"
+require "roar/json/hal"
module API
module V3
@@ -43,7 +43,7 @@ class GithubUserRepresenter < ::API::Decorators::Single
property :github_avatar_url, as: :avatarUrl
def _type
- 'GithubUser'
+ "GithubUser"
end
end
end
diff --git a/modules/github_integration/lib/open_project/github_integration/engine.rb b/modules/github_integration/lib/open_project/github_integration/engine.rb
index 20ff1a0eaa56..75950c7d335a 100644
--- a/modules/github_integration/lib/open_project/github_integration/engine.rb
+++ b/modules/github_integration/lib/open_project/github_integration/engine.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'open_project/plugins'
-require_relative 'patches/api/work_package_representer'
+require "open_project/plugins"
+require_relative "patches/api/work_package_representer"
module OpenProject::GithubIntegration
class Engine < ::Rails::Engine
@@ -35,8 +35,8 @@ class Engine < ::Rails::Engine
include OpenProject::Plugins::ActsAsOpEngine
- register 'openproject-github_integration',
- author_url: 'https://www.openproject.org/',
+ register "openproject-github_integration",
+ author_url: "https://www.openproject.org/",
bundled: true do
project_module(:github, dependencies: :work_package_tracking) do
permission(:show_github_content,
@@ -45,19 +45,19 @@ class Engine < ::Rails::Engine
end
end
- initializer 'github.register_hook' do
- ::OpenProject::Webhooks.register_hook 'github' do |hook, environment, params, user|
+ initializer "github.register_hook" do
+ ::OpenProject::Webhooks.register_hook "github" do |hook, environment, params, user|
HookHandler.new.process(hook, environment, params, user)
end
end
- initializer 'github.subscribe_to_notifications' do |app|
+ initializer "github.subscribe_to_notifications" do |app|
app.config.after_initialize do
- ::OpenProject::Notifications.subscribe('github.check_run',
+ ::OpenProject::Notifications.subscribe("github.check_run",
&NotificationHandler.method(:check_run))
- ::OpenProject::Notifications.subscribe('github.issue_comment',
+ ::OpenProject::Notifications.subscribe("github.issue_comment",
&NotificationHandler.method(:issue_comment))
- ::OpenProject::Notifications.subscribe('github.pull_request',
+ ::OpenProject::Notifications.subscribe("github.pull_request",
&NotificationHandler.method(:pull_request))
end
end
@@ -77,18 +77,18 @@ class Engine < ::Rails::Engine
"github_check_run/#{id}"
end
- add_api_endpoint 'API::V3::WorkPackages::WorkPackagesAPI', :id do
+ add_api_endpoint "API::V3::WorkPackages::WorkPackagesAPI", :id do
mount ::API::V3::GithubPullRequests::GithubPullRequestsByWorkPackageAPI
end
- add_api_endpoint 'API::V3::Root' do
+ add_api_endpoint "API::V3::Root" do
mount ::API::V3::GithubPullRequests::GithubPullRequestsAPI
end
add_cron_jobs do
{
- 'Cron::ClearOldPullRequestsJob': {
- cron: '25 1 * * *', # runs at 1:25 nightly
+ "Cron::ClearOldPullRequestsJob": {
+ cron: "25 1 * * *", # runs at 1:25 nightly
class: ::Cron::ClearOldPullRequestsJob.name
}
}
diff --git a/modules/github_integration/lib/open_project/github_integration/hook_handler.rb b/modules/github_integration/lib/open_project/github_integration/hook_handler.rb
index 4a70fbfd7315..15e90a3efa52 100644
--- a/modules/github_integration/lib/open_project/github_integration/hook_handler.rb
+++ b/modules/github_integration/lib/open_project/github_integration/hook_handler.rb
@@ -40,8 +40,8 @@ class HookHandler
# We need to check validity of the data and send a Notification
# to be processed in our `NotificationHandler`.
def process(_hook, request, params, user)
- event_type = request.env['HTTP_X_GITHUB_EVENT']
- event_delivery = request.env['HTTP_X_GITHUB_DELIVERY']
+ event_type = request.env["HTTP_X_GITHUB_EVENT"]
+ event_delivery = request.env["HTTP_X_GITHUB_DELIVERY"]
Rails.logger.debug { "Received github webhook #{event_type} (#{event_delivery})" }
@@ -51,9 +51,9 @@ def process(_hook, request, params, user)
payload = params[:payload]
.permit!
.to_h
- .merge('open_project_user_id' => user.id,
- 'github_event' => event_type,
- 'github_delivery' => event_delivery)
+ .merge("open_project_user_id" => user.id,
+ "github_event" => event_type,
+ "github_delivery" => event_delivery)
event_name = "github.#{event_type}"
OpenProject::Notifications.send(event_name, payload)
diff --git a/modules/github_integration/lib/open_project/github_integration/notification_handler.rb b/modules/github_integration/lib/open_project/github_integration/notification_handler.rb
index 8efd1e5a51a3..6ad0941c0ca9 100644
--- a/modules/github_integration/lib/open_project/github_integration/notification_handler.rb
+++ b/modules/github_integration/lib/open_project/github_integration/notification_handler.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative 'notification_handler/helper'
-require_relative 'notification_handler/issue_comment'
-require_relative 'notification_handler/pull_request'
+require_relative "notification_handler/helper"
+require_relative "notification_handler/issue_comment"
+require_relative "notification_handler/pull_request"
module OpenProject::GithubIntegration
##
diff --git a/modules/github_integration/lib/open_project/github_integration/notification_handler/check_run.rb b/modules/github_integration/lib/open_project/github_integration/notification_handler/check_run.rb
index f1be1b910a81..84c7fa546203 100644
--- a/modules/github_integration/lib/open_project/github_integration/notification_handler/check_run.rb
+++ b/modules/github_integration/lib/open_project/github_integration/notification_handler/check_run.rb
@@ -58,7 +58,7 @@ def find_pull_request
github_id = payload.check_run
.pull_requests
.first
- .fetch('id')
+ .fetch("id")
GithubPullRequest.find_by(github_id:)
end
end
diff --git a/modules/github_integration/lib/open_project/github_integration/notification_handler/helper.rb b/modules/github_integration/lib/open_project/github_integration/notification_handler/helper.rb
index e0b75382136a..8f7a602e10a9 100644
--- a/modules/github_integration/lib/open_project/github_integration/notification_handler/helper.rb
+++ b/modules/github_integration/lib/open_project/github_integration/notification_handler/helper.rb
@@ -107,7 +107,7 @@ def to_h
def method_missing(name, *args, &block)
super unless args.empty? && block.nil?
- value = if name.end_with?('?')
+ value = if name.end_with?("?")
@payload.fetch(name.to_s[..-2], nil)
else
@payload.fetch(name.to_s)
diff --git a/modules/github_integration/lib/open_project/github_integration/notification_handler/issue_comment.rb b/modules/github_integration/lib/open_project/github_integration/notification_handler/issue_comment.rb
index 19d4f0e8c4cf..3fa198d16e17 100644
--- a/modules/github_integration/lib/open_project/github_integration/notification_handler/issue_comment.rb
+++ b/modules/github_integration/lib/open_project/github_integration/notification_handler/issue_comment.rb
@@ -83,11 +83,11 @@ def upsert_partial_pull_request(work_packages)
def journal_entry(pull_request, payload)
return unless COMMENT_ACTIONS.include?(payload.action)
- angular_component_tag 'macro',
- class: 'github_pull_request',
+ angular_component_tag "macro",
+ class: "github_pull_request",
inputs: {
pullRequestId: pull_request.id,
- pullRequestState: 'referenced'
+ pullRequestState: "referenced"
}
end
end
diff --git a/modules/github_integration/lib/open_project/github_integration/notification_handler/pull_request.rb b/modules/github_integration/lib/open_project/github_integration/notification_handler/pull_request.rb
index efc162d3733e..2dcb25dc8f4b 100644
--- a/modules/github_integration/lib/open_project/github_integration/notification_handler/pull_request.rb
+++ b/modules/github_integration/lib/open_project/github_integration/notification_handler/pull_request.rb
@@ -63,7 +63,7 @@ def process(params)
private
def work_packages_to_comment_on(action, work_packages, already_referenced)
- if action == 'edited'
+ if action == "edited"
without_already_referenced(work_packages, already_referenced)
else
COMMENT_ACTIONS.include?(action) ? work_packages : []
@@ -85,8 +85,8 @@ def upsert_pull_request(payload, work_packages)
end
def journal_entry(pull_request, payload)
- angular_component_tag 'macro',
- class: 'github_pull_request',
+ angular_component_tag "macro",
+ class: "github_pull_request",
inputs: {
pullRequestId: pull_request.id,
pullRequestState: pull_request_state(payload)
@@ -95,16 +95,16 @@ def journal_entry(pull_request, payload)
def pull_request_state(payload)
key = {
- 'opened' => 'opened',
- 'reopened' => 'opened',
- 'closed' => 'closed',
- 'edited' => 'referenced',
- 'referenced' => 'referenced',
- 'ready_for_review' => 'ready_for_review'
+ "opened" => "opened",
+ "reopened" => "opened",
+ "closed" => "closed",
+ "edited" => "referenced",
+ "referenced" => "referenced",
+ "ready_for_review" => "ready_for_review"
}[payload.action]
- return 'merged' if key == 'closed' && payload.pull_request.merged
- return 'draft' if key == 'open' && payload.pull_request.draft
+ return "merged" if key == "closed" && payload.pull_request.merged
+ return "draft" if key == "open" && payload.pull_request.draft
key
end
diff --git a/modules/github_integration/lib/open_project/github_integration/services.rb b/modules/github_integration/lib/open_project/github_integration/services.rb
index edecc0f94e13..a0c6e6f31bc6 100644
--- a/modules/github_integration/lib/open_project/github_integration/services.rb
+++ b/modules/github_integration/lib/open_project/github_integration/services.rb
@@ -26,6 +26,6 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative 'services/upsert_check_run'
-require_relative 'services/upsert_github_user'
-require_relative 'services/upsert_pull_request'
+require_relative "services/upsert_check_run"
+require_relative "services/upsert_github_user"
+require_relative "services/upsert_pull_request"
diff --git a/modules/github_integration/lib/open_project/github_integration/services/upsert_check_run.rb b/modules/github_integration/lib/open_project/github_integration/services/upsert_check_run.rb
index ed9365b6876e..3f4fa904a1ce 100644
--- a/modules/github_integration/lib/open_project/github_integration/services/upsert_check_run.rb
+++ b/modules/github_integration/lib/open_project/github_integration/services/upsert_check_run.rb
@@ -36,7 +36,7 @@ module OpenProject::GithubIntegration::Services
# See: https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#check_run
class UpsertCheckRun
def call(payload, pull_request:)
- GithubCheckRun.find_or_initialize_by(github_id: payload.fetch('id'))
+ GithubCheckRun.find_or_initialize_by(github_id: payload.fetch("id"))
.tap do |check_run|
check_run.update!(github_pull_request: pull_request, **extract_params(payload))
end
@@ -48,23 +48,23 @@ def call(payload, pull_request:)
# to our internal representation.
# See: https://docs.github.com/en/rest/reference/checks
def extract_params(payload)
- output = payload.fetch('output')
- app = payload.fetch('app')
+ output = payload.fetch("output")
+ app = payload.fetch("app")
{
- github_id: payload.fetch('id'),
- github_html_url: payload.fetch('html_url'),
- app_id: app.fetch('id'),
- github_app_owner_avatar_url: app.fetch('owner')
- .fetch('avatar_url'),
- name: payload.fetch('name'),
- status: payload.fetch('status'),
- conclusion: payload['conclusion'],
- output_title: output.fetch('title'),
- output_summary: output.fetch('summary'),
- details_url: payload['details_url'],
- started_at: payload['started_at'],
- completed_at: payload['completed_at']
+ github_id: payload.fetch("id"),
+ github_html_url: payload.fetch("html_url"),
+ app_id: app.fetch("id"),
+ github_app_owner_avatar_url: app.fetch("owner")
+ .fetch("avatar_url"),
+ name: payload.fetch("name"),
+ status: payload.fetch("status"),
+ conclusion: payload["conclusion"],
+ output_title: output.fetch("title"),
+ output_summary: output.fetch("summary"),
+ details_url: payload["details_url"],
+ started_at: payload["started_at"],
+ completed_at: payload["completed_at"]
}
end
end
diff --git a/modules/github_integration/lib/open_project/github_integration/services/upsert_github_user.rb b/modules/github_integration/lib/open_project/github_integration/services/upsert_github_user.rb
index e473dc205091..e863a5936260 100644
--- a/modules/github_integration/lib/open_project/github_integration/services/upsert_github_user.rb
+++ b/modules/github_integration/lib/open_project/github_integration/services/upsert_github_user.rb
@@ -36,7 +36,7 @@ module OpenProject::GithubIntegration::Services
# See: https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#pull_request
class UpsertGithubUser
def call(payload)
- GithubUser.find_or_initialize_by(github_id: payload.fetch('id'))
+ GithubUser.find_or_initialize_by(github_id: payload.fetch("id"))
.tap do |github_user|
github_user.update!(extract_params(payload))
end
@@ -50,10 +50,10 @@ def call(payload)
# See: https://docs.github.com/en/rest/reference/users
def extract_params(payload)
{
- github_id: payload.fetch('id'),
- github_login: payload.fetch('login'),
- github_html_url: payload.fetch('html_url'),
- github_avatar_url: payload.fetch('avatar_url')
+ github_id: payload.fetch("id"),
+ github_login: payload.fetch("login"),
+ github_html_url: payload.fetch("html_url"),
+ github_avatar_url: payload.fetch("avatar_url")
}
end
end
diff --git a/modules/github_integration/lib/open_project/github_integration/services/upsert_pull_request.rb b/modules/github_integration/lib/open_project/github_integration/services/upsert_pull_request.rb
index cca0d4d20277..2ed0ea027f78 100644
--- a/modules/github_integration/lib/open_project/github_integration/services/upsert_pull_request.rb
+++ b/modules/github_integration/lib/open_project/github_integration/services/upsert_pull_request.rb
@@ -44,8 +44,8 @@ def call(payload, work_packages: [])
private
def find_or_initialize(payload)
- GithubPullRequest.find_by_github_identifiers(id: payload.fetch('id'),
- url: payload.fetch('html_url'),
+ GithubPullRequest.find_by_github_identifiers(id: payload.fetch("id"),
+ url: payload.fetch("html_url"),
initialize: true)
end
@@ -55,38 +55,38 @@ def find_or_initialize(payload)
# rubocop:disable Metrics/AbcSize
def extract_params(payload)
{
- github_id: payload.fetch('id'),
- github_user: github_user_id(payload.fetch('user')),
- number: payload.fetch('number'),
- github_html_url: payload.fetch('html_url'),
- github_updated_at: payload.fetch('updated_at'),
- state: payload.fetch('state'),
- title: payload.fetch('title'),
- body: payload.fetch('body'),
- repository: payload.fetch('base')
- .fetch('repo')
- .fetch('full_name'),
- repository_html_url: payload.fetch('base')
- .fetch('repo')
- .fetch('html_url'),
- draft: payload.fetch('draft'),
- merged: payload.fetch('merged'),
- merged_by: github_user_id(payload['merged_by']),
- merged_at: payload['merged_at'],
- comments_count: payload.fetch('comments'),
- review_comments_count: payload.fetch('review_comments'),
- additions_count: payload.fetch('additions'),
- deletions_count: payload.fetch('deletions'),
- changed_files_count: payload.fetch('changed_files'),
- labels: payload.fetch('labels').map { |values| extract_label_values(values) }
+ github_id: payload.fetch("id"),
+ github_user: github_user_id(payload.fetch("user")),
+ number: payload.fetch("number"),
+ github_html_url: payload.fetch("html_url"),
+ github_updated_at: payload.fetch("updated_at"),
+ state: payload.fetch("state"),
+ title: payload.fetch("title"),
+ body: payload.fetch("body"),
+ repository: payload.fetch("base")
+ .fetch("repo")
+ .fetch("full_name"),
+ repository_html_url: payload.fetch("base")
+ .fetch("repo")
+ .fetch("html_url"),
+ draft: payload.fetch("draft"),
+ merged: payload.fetch("merged"),
+ merged_by: github_user_id(payload["merged_by"]),
+ merged_at: payload["merged_at"],
+ comments_count: payload.fetch("comments"),
+ review_comments_count: payload.fetch("review_comments"),
+ additions_count: payload.fetch("additions"),
+ deletions_count: payload.fetch("deletions"),
+ changed_files_count: payload.fetch("changed_files"),
+ labels: payload.fetch("labels").map { |values| extract_label_values(values) }
}
end
# rubocop:enable Metrics/AbcSize
def extract_label_values(payload)
{
- name: payload.fetch('name'),
- color: payload.fetch('color')
+ name: payload.fetch("name"),
+ color: payload.fetch("color")
}
end
diff --git a/modules/github_integration/lib/openproject-github_integration.rb b/modules/github_integration/lib/openproject-github_integration.rb
index 21f70ed8aa7a..b04577a0bf17 100644
--- a/modules/github_integration/lib/openproject-github_integration.rb
+++ b/modules/github_integration/lib/openproject-github_integration.rb
@@ -26,4 +26,4 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'open_project/github_integration'
+require "open_project/github_integration"
diff --git a/modules/github_integration/openproject-github_integration.gemspec b/modules/github_integration/openproject-github_integration.gemspec
index 73f82bb1834a..d1b9590ddcdc 100644
--- a/modules/github_integration/openproject-github_integration.gemspec
+++ b/modules/github_integration/openproject-github_integration.gemspec
@@ -1,15 +1,15 @@
Gem::Specification.new do |s|
s.name = "openproject-github_integration"
- s.version = '1.0.0'
+ s.version = "1.0.0"
s.authors = "OpenProject GmbH"
s.email = "info@openproject.com"
s.homepage = "https://www.openproject.org/docs/system-admin-guide/integrations/github-integration/"
- s.summary = 'OpenProject Github Integration'
- s.description = 'Integrates OpenProject and Github for a better workflow'
- s.license = 'GPLv3'
+ s.summary = "OpenProject Github Integration"
+ s.description = "Integrates OpenProject and Github for a better workflow"
+ s.license = "GPLv3"
s.files = Dir["{app,config,db,frontend,lib}/**/*"] + %w(README.md)
s.add_dependency "openproject-webhooks"
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/github_integration/spec/factories/github_check_run_factory.rb b/modules/github_integration/spec/factories/github_check_run_factory.rb
index aa32b6d84494..144fa4696ab7 100644
--- a/modules/github_integration/spec/factories/github_check_run_factory.rb
+++ b/modules/github_integration/spec/factories/github_check_run_factory.rb
@@ -33,12 +33,12 @@
sequence(:github_id)
github_html_url { "https://github.com/check_runs/#{github_id}" }
github_app_owner_avatar_url { "https://github.com/apps/#{github_id}/owner.jpg" }
- name { 'test' }
+ name { "test" }
app_id { 12345 }
- status { 'completed' }
- conclusion { 'success' }
- output_title { 'an output title' }
- output_summary { 'an output summary' }
+ status { "completed" }
+ conclusion { "success" }
+ output_title { "an output title" }
+ output_summary { "an output summary" }
details_url { "https://github.com/check_runs/#{github_id}/details" }
started_at { 1.hour.ago }
completed_at { 1.minute.ago }
diff --git a/modules/github_integration/spec/factories/github_pull_request_factory.rb b/modules/github_integration/spec/factories/github_pull_request_factory.rb
index 624f2a722137..8210467bc870 100644
--- a/modules/github_integration/spec/factories/github_pull_request_factory.rb
+++ b/modules/github_integration/spec/factories/github_pull_request_factory.rb
@@ -32,7 +32,7 @@
sequence(:number)
sequence(:github_id)
- state { 'open' }
+ state { "open" }
github_html_url { "https://github.com/test_user/test_repo/pull/#{number}" }
labels { [] }
@@ -77,11 +77,11 @@
trait :open
trait :closed_unmerged do
- state { 'closed' }
+ state { "closed" }
end
trait :closed_merged do
- state { 'closed' }
+ state { "closed" }
merged { true }
merged_by { association :github_user }
merged_at { Time.current }
diff --git a/modules/github_integration/spec/features/work_package_activity_spec.rb b/modules/github_integration/spec/features/work_package_activity_spec.rb
index 108889c1cdd0..4110d1a79282 100644
--- a/modules/github_integration/spec/features/work_package_activity_spec.rb
+++ b/modules/github_integration/spec/features/work_package_activity_spec.rb
@@ -1,19 +1,19 @@
# frozen_string_literal: true
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work Package Activity Tab',
- 'Comments by Github',
+RSpec.describe "Work Package Activity Tab",
+ "Comments by Github",
:js,
:with_cuprite do
- shared_let(:github_system_user) { create(:admin, firstname: 'Github', lastname: 'System User') }
+ shared_let(:github_system_user) { create(:admin, firstname: "Github", lastname: "System User") }
shared_let(:admin) { create(:admin) }
shared_let(:project) { create(:project, enabled_module_names: Setting.default_projects_modules + %w[activity]) }
shared_let(:work_package) { create(:work_package, project:) }
- shared_let(:pull_request_author) { create(:github_user, github_login: 'i_am_the_author') }
- shared_let(:pull_request_merging_user) { create(:github_user, github_login: 'i_merged') }
+ shared_let(:pull_request_author) { create(:github_user, github_login: "i_am_the_author") }
+ shared_let(:pull_request_merging_user) { create(:github_user, github_login: "i_merged") }
shared_let(:pull_request) do
create(:github_pull_request,
github_user: pull_request_author)
@@ -28,42 +28,42 @@ def trigger_pull_request_action
let(:payload) do
{
- 'action' => action,
- 'open_project_user_id' => github_system_user.id,
- 'pull_request' => pull_request_hash,
- 'sender' => sender_section_hash
+ "action" => action,
+ "open_project_user_id" => github_system_user.id,
+ "pull_request" => pull_request_hash,
+ "sender" => sender_section_hash
}
end
let(:pull_request_hash) do
{
- 'id' => pull_request.id,
- 'number' => pull_request.number,
- 'body' => "Mentioning OP##{work_package.id}",
- 'title' => pull_request.title,
- 'html_url' => pull_request.github_html_url,
- 'updated_at' => Time.current.iso8601,
- 'state' => state,
- 'draft' => false,
- 'merged' => merged,
- 'merged_by' => merged_by_section_hash,
- 'merged_at' => merged_at,
- 'comments' => pull_request.comments_count + 1,
- 'review_comments' => pull_request.review_comments_count,
- 'additions' => pull_request.additions_count,
- 'deletions' => pull_request.deletions_count,
- 'changed_files' => pull_request.changed_files_count,
- 'labels' => pull_request.labels,
- 'user' => {
- 'id' => pull_request_author.github_id,
- 'login' => pull_request_author.github_login,
- 'html_url' => pull_request_author.github_html_url,
- 'avatar_url' => pull_request_author.github_avatar_url
+ "id" => pull_request.id,
+ "number" => pull_request.number,
+ "body" => "Mentioning OP##{work_package.id}",
+ "title" => pull_request.title,
+ "html_url" => pull_request.github_html_url,
+ "updated_at" => Time.current.iso8601,
+ "state" => state,
+ "draft" => false,
+ "merged" => merged,
+ "merged_by" => merged_by_section_hash,
+ "merged_at" => merged_at,
+ "comments" => pull_request.comments_count + 1,
+ "review_comments" => pull_request.review_comments_count,
+ "additions" => pull_request.additions_count,
+ "deletions" => pull_request.deletions_count,
+ "changed_files" => pull_request.changed_files_count,
+ "labels" => pull_request.labels,
+ "user" => {
+ "id" => pull_request_author.github_id,
+ "login" => pull_request_author.github_login,
+ "html_url" => pull_request_author.github_html_url,
+ "avatar_url" => pull_request_author.github_avatar_url
},
- 'base' => {
- 'repo' => {
- 'full_name' => 'author_user/repo',
- 'html_url' => 'github.com/author_user/repo'
+ "base" => {
+ "repo" => {
+ "full_name" => "author_user/repo",
+ "html_url" => "github.com/author_user/repo"
}
}
}
@@ -71,15 +71,15 @@ def trigger_pull_request_action
let(:sender_section_hash) do
{
- 'login' => 'test_user',
- 'html_url' => 'github.com/test_user'
+ "login" => "test_user",
+ "html_url" => "github.com/test_user"
}
end
let(:work_package_page) { Pages::SplitWorkPackage.new(work_package, project) }
- context 'when the pull request is merged' do
- let(:action) { 'closed' }
+ context "when the pull request is merged" do
+ let(:action) { "closed" }
before do
trigger_pull_request_action
@@ -90,21 +90,21 @@ def trigger_pull_request_action
let(:merged) { true }
let(:merged_by_section_hash) do
{
- 'id' => pull_request_merging_user.github_id,
- 'login' => pull_request_merging_user.github_login,
- 'html_url' => pull_request_merging_user.github_html_url,
- 'avatar_url' => pull_request_merging_user.github_avatar_url
+ "id" => pull_request_merging_user.github_id,
+ "login" => pull_request_merging_user.github_login,
+ "html_url" => pull_request_merging_user.github_html_url,
+ "avatar_url" => pull_request_merging_user.github_avatar_url
}
end
let(:merged_at) { Time.current.iso8601 }
- let(:state) { 'closed' }
+ let(:state) { "closed" }
before do
- work_package_page.visit_tab! 'activity'
+ work_package_page.visit_tab! "activity"
work_package_page.ensure_page_loaded
end
- it 'renders a comment stating the Pull Request was merged by the merge actor' do
+ it "renders a comment stating the Pull Request was merged by the merge actor" do
expected_merge_comment = <<~GITHUB_MERGE_COMMENT.squish
Merged#{I18n.t('js.github_integration.pull_requests.merged_message',
pr_number: pull_request.number,
@@ -114,18 +114,18 @@ def trigger_pull_request_action
github_user_link: pull_request_merging_user.github_login)}
GITHUB_MERGE_COMMENT
- expect(page).to have_css('.user-comment > .message', text: expected_merge_comment)
+ expect(page).to have_css(".user-comment > .message", text: expected_merge_comment)
end
end
end
- context 'when the Work Package is referenced in a Pull Request' do
- let(:action) { 'referenced' }
+ context "when the Work Package is referenced in a Pull Request" do
+ let(:action) { "referenced" }
let(:merged) { false }
let(:merged_by_section_hash) { {} }
let(:merged_at) { nil }
- let(:state) { 'open' }
+ let(:state) { "open" }
before do
trigger_pull_request_action
@@ -134,11 +134,11 @@ def trigger_pull_request_action
context "and I visit the work package's activity tab" do
before do
- work_package_page.visit_tab! 'activity'
+ work_package_page.visit_tab! "activity"
work_package_page.ensure_page_loaded
end
- it 'renders a comment stating the Work Package was referenced in the Pull Request' do
+ it "renders a comment stating the Work Package was referenced in the Pull Request" do
expected_referenced_comment = <<~GITHUB_REFERENCED_COMMENT.squish
Referenced#{I18n.t('js.github_integration.pull_requests.referenced_message',
pr_number: pull_request.number,
@@ -148,18 +148,18 @@ def trigger_pull_request_action
github_user_link: pull_request_author.github_login)}
GITHUB_REFERENCED_COMMENT
- expect(page).to have_css('.user-comment > .message', text: expected_referenced_comment)
+ expect(page).to have_css(".user-comment > .message", text: expected_referenced_comment)
end
end
end
- context 'when any non-edge-case action is performed on a pull request' do
- let(:action) { 'ready_for_review' }
+ context "when any non-edge-case action is performed on a pull request" do
+ let(:action) { "ready_for_review" }
let(:merged) { false }
let(:merged_by_section_hash) { {} }
let(:merged_at) { nil }
- let(:state) { 'open' }
+ let(:state) { "open" }
before do
trigger_pull_request_action
@@ -168,11 +168,11 @@ def trigger_pull_request_action
context "and I visit the work package's activity tab" do
before do
- work_package_page.visit_tab! 'activity'
+ work_package_page.visit_tab! "activity"
work_package_page.ensure_page_loaded
end
- it 'renders a comment stating that said action was performed on the Pull Request' do
+ it "renders a comment stating that said action was performed on the Pull Request" do
expected_action_comment = <<~GITHUB_READY_FOR_REVIEW_COMMENT.squish
Marked Ready For Review#{I18n.t('js.github_integration.pull_requests.message',
pr_number: pull_request.number,
@@ -182,7 +182,7 @@ def trigger_pull_request_action
github_user_link: pull_request_author.github_login)}
GITHUB_READY_FOR_REVIEW_COMMENT
- expect(page).to have_css('.user-comment > .message', text: expected_action_comment)
+ expect(page).to have_css(".user-comment > .message", text: expected_action_comment)
end
end
end
diff --git a/modules/github_integration/spec/features/work_package_github_tab_spec.rb b/modules/github_integration/spec/features/work_package_github_tab_spec.rb
index d035f53baaab..82b53eb47f58 100644
--- a/modules/github_integration/spec/features/work_package_github_tab_spec.rb
+++ b/modules/github_integration/spec/features/work_package_github_tab_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../support/pages/work_package_github_tab'
+require "spec_helper"
+require_relative "../support/pages/work_package_github_tab"
-RSpec.describe 'Open the GitHub tab', :js do
+RSpec.describe "Open the GitHub tab", :js do
let(:user) do
create(:user,
member_with_roles: { project => role })
@@ -41,13 +41,13 @@
show_github_content))
end
let(:project) { create(:project) }
- let(:work_package) { create(:work_package, project:, subject: 'A test work_package') }
+ let(:work_package) { create(:work_package, project:, subject: "A test work_package") }
let(:github_tab) { Pages::GitHubTab.new(work_package.id) }
- let(:pull_request) { create(:github_pull_request, :open, work_packages: [work_package], title: 'A Test PR title') }
- let(:check_run) { create(:github_check_run, github_pull_request: pull_request, name: 'a check run name') }
+ let(:pull_request) { create(:github_pull_request, :open, work_packages: [work_package], title: "A Test PR title") }
+ let(:check_run) { create(:github_check_run, github_pull_request: pull_request, name: "a check run name") }
let(:tabs) { Components::WorkPackages::Tabs.new(work_package) }
- let(:github_tab_element) { find('.op-tab-row--link_selected', text: 'GITHUB') }
+ let(:github_tab_element) { find(".op-tab-row--link_selected", text: "GITHUB") }
shared_examples_for "a github tab" do
before do
@@ -58,62 +58,62 @@
# compares the clipboard content by drafting a new comment, pressing ctrl+v and
# comparing the pasted content against the provided text
def expect_clipboard_content(text)
- work_package_page.switch_to_tab(tab: 'activity')
+ work_package_page.switch_to_tab(tab: "activity")
work_package_page.trigger_edit_comment
- work_package_page.update_comment(' ') # ensure the comment editor is fully loaded
+ work_package_page.update_comment(" ") # ensure the comment editor is fully loaded
github_tab.paste_clipboard_content
expect(work_package_page.add_comment_container).to have_content(text)
- work_package_page.switch_to_tab(tab: 'github')
+ work_package_page.switch_to_tab(tab: "github")
end
- it 'shows the github tab when the user is allowed to see it' do
+ it "shows the github tab when the user is allowed to see it" do
work_package_page.visit!
- work_package_page.switch_to_tab(tab: 'github')
+ work_package_page.switch_to_tab(tab: "github")
tabs.expect_counter(github_tab_element, 1)
github_tab.git_actions_menu_button.click
github_tab.git_actions_copy_branch_name_button.click
- expect(page).to have_text('Copied!')
+ expect(page).to have_text("Copied!")
expect_clipboard_content("#{work_package.type.name.downcase}/#{work_package.id}-a-test-work_package")
- expect(page).to have_text('A Test PR title')
- expect(page).to have_text('a check run name')
+ expect(page).to have_text("A Test PR title")
+ expect(page).to have_text("a check run name")
end
- context 'when there are no pull requests' do
+ context "when there are no pull requests" do
let(:check_run) {}
let(:pull_request) {}
- it 'shows the github tab with an empty-pull-requests message' do
+ it "shows the github tab with an empty-pull-requests message" do
work_package_page.visit!
- work_package_page.switch_to_tab(tab: 'github')
+ work_package_page.switch_to_tab(tab: "github")
tabs.expect_no_counter(github_tab_element)
- expect(page).to have_content('There are no pull requests')
+ expect(page).to have_content("There are no pull requests")
expect(page).to have_content("Link an existing PR by using the code OP##{work_package.id}")
end
end
- context 'when the user does not have the permissions to see the github tab' do
+ context "when the user does not have the permissions to see the github tab" do
let(:role) do
create(:project_role,
permissions: %i(view_work_packages
add_work_package_notes))
end
- it 'does not show the github tab' do
+ it "does not show the github tab" do
work_package_page.visit!
github_tab.expect_tab_not_present
end
end
- context 'when the github integration is not enabled for the project' do
- let(:project) { create(:project, disable_modules: 'github') }
+ context "when the github integration is not enabled for the project" do
+ let(:project) { create(:project, disable_modules: "github") }
- it 'does not show the github tab' do
+ it "does not show the github tab" do
work_package_page.visit!
github_tab.expect_tab_not_present
@@ -121,15 +121,15 @@ def expect_clipboard_content(text)
end
end
- describe 'work package full view' do
+ describe "work package full view" do
let(:work_package_page) { Pages::FullWorkPackage.new(work_package) }
- it_behaves_like 'a github tab'
+ it_behaves_like "a github tab"
end
- describe 'work package split view' do
+ describe "work package split view" do
let(:work_package_page) { Pages::SplitWorkPackage.new(work_package) }
- it_behaves_like 'a github tab'
+ it_behaves_like "a github tab"
end
end
diff --git a/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_check_run_representer_spec.rb b/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_check_run_representer_spec.rb
index a72c8c67a1cd..4ba21ecc94d3 100644
--- a/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_check_run_representer_spec.rb
+++ b/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_check_run_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::GithubPullRequests::GithubCheckRunRepresenter do
include API::V3::Utilities::PathHelper
@@ -37,62 +37,62 @@
let(:representer) { described_class.create(check_run, current_user: user) }
let(:user) { build_stubbed(:admin) }
- it { is_expected.to include_json('GithubCheckRun'.to_json).at_path('_type') }
+ it { is_expected.to include_json("GithubCheckRun".to_json).at_path("_type") }
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'GithubCheckRun' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "GithubCheckRun" }
end
- it_behaves_like 'property', :htmlUrl do
+ it_behaves_like "property", :htmlUrl do
let(:value) { check_run.github_html_url }
end
- it_behaves_like 'property', :appOwnerAvatarUrl do
+ it_behaves_like "property", :appOwnerAvatarUrl do
let(:value) { check_run.github_app_owner_avatar_url }
end
- it_behaves_like 'property', :name do
+ it_behaves_like "property", :name do
let(:value) { check_run.name }
end
- it_behaves_like 'property', :status do
+ it_behaves_like "property", :status do
let(:value) { check_run.status }
end
- it_behaves_like 'property', :conclusion do
+ it_behaves_like "property", :conclusion do
let(:value) { check_run.conclusion }
end
- it_behaves_like 'property', :outputTitle do
+ it_behaves_like "property", :outputTitle do
let(:value) { check_run.output_title }
end
- it_behaves_like 'property', :outputSummary do
+ it_behaves_like "property", :outputSummary do
let(:value) { check_run.output_summary }
end
- it_behaves_like 'property', :detailsUrl do
+ it_behaves_like "property", :detailsUrl do
let(:value) { check_run.details_url }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { check_run.started_at }
- let(:json_path) { 'startedAt' }
+ let(:json_path) { "startedAt" }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { check_run.completed_at }
- let(:json_path) { 'completedAt' }
+ let(:json_path) { "completedAt" }
end
end
- describe '_links' do
- it { is_expected.to have_json_type(Object).at_path('_links') }
- it { is_expected.to have_json_path('_links/self/href') }
+ describe "_links" do
+ it { is_expected.to have_json_type(Object).at_path("_links") }
+ it { is_expected.to have_json_path("_links/self/href") }
end
- describe 'caching' do
+ describe "caching" do
before do
allow(OpenProject::Cache).to receive(:fetch).and_call_original
end
@@ -105,22 +105,22 @@
.with(representer.json_cache_key)
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let!(:former_cache_key) { representer.json_cache_key }
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'GithubPullRequests', 'GithubCheckRunRepresenter')
+ .to include("API", "V3", "GithubPullRequests", "GithubCheckRunRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
I18n.with_locale(:fr) do
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
end
- it 'changes when the check run is updated' do
+ it "changes when the check run is updated" do
check_run.updated_at = 20.seconds.from_now
expect(representer.json_cache_key)
diff --git a/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_pull_request_representer_spec.rb b/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_pull_request_representer_spec.rb
index 0d2840056b78..c704977f8480 100644
--- a/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_pull_request_representer_spec.rb
+++ b/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_pull_request_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::GithubPullRequests::GithubPullRequestRepresenter do
include API::V3::Utilities::PathHelper
@@ -35,7 +35,7 @@
let(:github_pull_request) do
build_stubbed(:github_pull_request,
- state: 'open',
+ state: "open",
labels:,
github_user:,
merged_by:).tap do |pr|
@@ -47,8 +47,8 @@
let(:labels) do
[
{
- 'name' => 'grey',
- 'color' => '#666'
+ "name" => "grey",
+ "color" => "#666"
}
]
end
@@ -60,118 +60,118 @@
let(:user) { build_stubbed(:admin) }
- it { is_expected.to include_json('GithubPullRequest'.to_json).at_path('_type') }
+ it { is_expected.to include_json("GithubPullRequest".to_json).at_path("_type") }
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'GithubPullRequest' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "GithubPullRequest" }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { github_pull_request.id }
end
- it_behaves_like 'property', :number do
+ it_behaves_like "property", :number do
let(:value) { github_pull_request.number }
end
- it_behaves_like 'property', :htmlUrl do
+ it_behaves_like "property", :htmlUrl do
let(:value) { github_pull_request.github_html_url }
end
- it_behaves_like 'property', :state do
+ it_behaves_like "property", :state do
let(:value) { github_pull_request.state }
end
- it_behaves_like 'property', :repository do
+ it_behaves_like "property", :repository do
let(:value) { github_pull_request.repository }
end
- it_behaves_like 'property', :title do
+ it_behaves_like "property", :title do
let(:value) { github_pull_request.title }
end
- it_behaves_like 'formattable property', :body do
+ it_behaves_like "formattable property", :body do
let(:value) { github_pull_request.body }
end
- it_behaves_like 'property', :draft do
+ it_behaves_like "property", :draft do
let(:value) { github_pull_request.draft }
end
- it_behaves_like 'property', :merged do
+ it_behaves_like "property", :merged do
let(:value) { github_pull_request.merged }
end
- it_behaves_like 'property', :commentsCount do
+ it_behaves_like "property", :commentsCount do
let(:value) { github_pull_request.comments_count }
end
- it_behaves_like 'property', :reviewCommentsCount do
+ it_behaves_like "property", :reviewCommentsCount do
let(:value) { github_pull_request.review_comments_count }
end
- it_behaves_like 'property', :additionsCount do
+ it_behaves_like "property", :additionsCount do
let(:value) { github_pull_request.additions_count }
end
- it_behaves_like 'property', :deletionsCount do
+ it_behaves_like "property", :deletionsCount do
let(:value) { github_pull_request.deletions_count }
end
- it_behaves_like 'property', :changedFilesCount do
+ it_behaves_like "property", :changedFilesCount do
let(:value) { github_pull_request.changed_files_count }
end
- it_behaves_like 'property', :labels do
+ it_behaves_like "property", :labels do
let(:value) { github_pull_request.labels }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { github_pull_request.github_updated_at }
- let(:json_path) { 'githubUpdatedAt' }
+ let(:json_path) { "githubUpdatedAt" }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { github_pull_request.created_at }
- let(:json_path) { 'createdAt' }
+ let(:json_path) { "createdAt" }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { github_pull_request.updated_at }
- let(:json_path) { 'updatedAt' }
+ let(:json_path) { "updatedAt" }
end
end
- describe '_links' do
- it { is_expected.to have_json_type(Object).at_path('_links') }
+ describe "_links" do
+ it { is_expected.to have_json_type(Object).at_path("_links") }
- it_behaves_like 'has a titled link' do
- let(:link) { 'githubUser' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "githubUser" }
let(:href) { api_v3_paths.github_user(github_user.id) }
let(:title) { github_user.github_login }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'mergedBy' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "mergedBy" }
let(:href) { api_v3_paths.github_user(merged_by.id) }
let(:title) { merged_by.github_login }
end
- it_behaves_like 'has a link collection' do
- let(:link) { 'checkRuns' }
+ it_behaves_like "has a link collection" do
+ let(:link) { "checkRuns" }
let(:hrefs) do
[
{
- 'href' => api_v3_paths.github_check_run(check_run.id),
- 'title' => check_run.name
+ "href" => api_v3_paths.github_check_run(check_run.id),
+ "title" => check_run.name
}
]
end
end
end
- describe 'caching' do
+ describe "caching" do
before do
allow(OpenProject::Cache).to receive(:fetch).and_call_original
end
@@ -184,36 +184,36 @@
.with(representer.json_cache_key)
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let!(:former_cache_key) { representer.json_cache_key }
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'GithubPullRequests', 'GithubPullRequestRepresenter')
+ .to include("API", "V3", "GithubPullRequests", "GithubPullRequestRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
I18n.with_locale(:fr) do
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
end
- it 'changes when the github_pull_request is updated' do
+ it "changes when the github_pull_request is updated" do
github_pull_request.updated_at = 20.seconds.from_now
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
- it 'changes when the github_user is updated' do
+ it "changes when the github_user is updated" do
github_pull_request.github_user.updated_at = 20.seconds.from_now
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
- it 'changes when the merged_by user is updated' do
+ it "changes when the merged_by user is updated" do
github_pull_request.merged_by.updated_at = 20.seconds.from_now
expect(representer.json_cache_key)
diff --git a/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_user_representer_spec.rb b/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_user_representer_spec.rb
index 639d66b0dd7e..40d5e23b328c 100644
--- a/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_user_representer_spec.rb
+++ b/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_user_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::GithubPullRequests::GithubUserRepresenter do
include API::V3::Utilities::PathHelper
@@ -38,32 +38,32 @@
let(:user) { build_stubbed(:admin) }
- it { is_expected.to include_json('GithubUser'.to_json).at_path('_type') }
+ it { is_expected.to include_json("GithubUser".to_json).at_path("_type") }
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'GithubUser' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "GithubUser" }
end
- it_behaves_like 'property', :login do
+ it_behaves_like "property", :login do
let(:value) { github_user.github_login }
end
- it_behaves_like 'property', :htmlUrl do
+ it_behaves_like "property", :htmlUrl do
let(:value) { github_user.github_html_url }
end
- it_behaves_like 'property', :avatarUrl do
+ it_behaves_like "property", :avatarUrl do
let(:value) { github_user.github_avatar_url }
end
end
- describe '_links' do
- it { is_expected.to have_json_type(Object).at_path('_links') }
- it { is_expected.to have_json_path('_links/self/href') }
+ describe "_links" do
+ it { is_expected.to have_json_type(Object).at_path("_links") }
+ it { is_expected.to have_json_path("_links/self/href") }
end
- describe 'caching' do
+ describe "caching" do
before do
allow(OpenProject::Cache).to receive(:fetch).and_call_original
end
@@ -76,22 +76,22 @@
.with(representer.json_cache_key)
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let!(:former_cache_key) { representer.json_cache_key }
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'GithubPullRequests', 'GithubUserRepresenter')
+ .to include("API", "V3", "GithubPullRequests", "GithubUserRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
I18n.with_locale(:fr) do
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
end
- it 'changes when the github_user is updated' do
+ it "changes when the github_user is updated" do
github_user.updated_at = 20.seconds.from_now
expect(representer.json_cache_key)
diff --git a/modules/github_integration/spec/lib/open_project/github_integration/hook_handler_integration_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/hook_handler_integration_spec.rb
index 109e0c5f0ee1..3373f1583085 100644
--- a/modules/github_integration/spec/lib/open_project/github_integration/hook_handler_integration_spec.rb
+++ b/modules/github_integration/spec/lib/open_project/github_integration/hook_handler_integration_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path('../../../spec_helper', __dir__)
+require File.expand_path("../../../spec_helper", __dir__)
RSpec.describe OpenProject::GithubIntegration::HookHandler do
subject(:process_webhook) do
described_class.new
.tap { journal_counts_before }
- .process('github', OpenStruct.new(env: environment), ActionController::Parameters.new(payload), user)
+ .process("github", OpenStruct.new(env: environment), ActionController::Parameters.new(payload), user)
.tap { [work_packages[0], work_packages[1], work_packages[2], work_packages[3]].map(&:reload) }
end
@@ -42,11 +42,11 @@
let(:environment) do
{
- 'HTTP_X_GITHUB_EVENT' => event,
- 'HTTP_X_GITHUB_DELIVERY' => 'test delivery'
+ "HTTP_X_GITHUB_EVENT" => event,
+ "HTTP_X_GITHUB_DELIVERY" => "test delivery"
}
end
- let(:host_name) { 'example.net' }
+ let(:host_name) { "example.net" }
let(:user) { create(:user) }
let(:role) do
create(:project_role,
@@ -62,21 +62,21 @@
let(:pr_merged) { false }
let(:pr_draft) { false }
- let(:pr_state) { 'open' }
+ let(:pr_state) { "open" }
let(:pr_labels) { [] }
- shared_examples_for 'it does not comment on any work package' do
+ shared_examples_for "it does not comment on any work package" do
let(:created_journals) { journal_counts_after.sum - journal_counts_before.sum }
- it 'consumes the webhook without commenting on any work package' do
+ it "consumes the webhook without commenting on any work package" do
process_webhook
expect(created_journals).to be 0
end
end
- shared_examples_for 'it comments on the first work_package' do
- it 'comments only on the first work package' do
+ shared_examples_for "it comments on the first work_package" do
+ it "comments only on the first work package" do
process_webhook
expect(work_packages[0].journals.count).to be(journal_counts_before[0] + 1)
@@ -88,8 +88,8 @@
end
end
- shared_examples_for 'it does not create a pull request' do
- it 'creates no GithubPullRequest or GithubUser' do
+ shared_examples_for "it does not create a pull request" do
+ it "creates no GithubPullRequest or GithubUser" do
expect { process_webhook }.to(
change(GithubPullRequest, :count).by(0).and(
change(GithubUser, :count).by(0)
@@ -98,14 +98,14 @@
end
end
- shared_examples_for 'it creates a pull request and github user' do
- it 'creates a GithubPullRequest and a GithubUser' do
+ shared_examples_for "it creates a pull request and github user" do
+ it "creates a GithubPullRequest and a GithubUser" do
expect { process_webhook }.to(change(GithubPullRequest, :count).by(1).and(change(GithubUser, :count).by(1)))
pull_request = GithubPullRequest.last
github_user = GithubUser.last
expect(pull_request).to have_attributes(
- title: 'A PR title',
+ title: "A PR title",
body: "A PR body mentioning OP##{work_packages[0].id}",
merged: pr_merged,
draft: pr_draft,
@@ -117,21 +117,21 @@
comments_count: 22,
review_comments_count: 33,
changed_files_count: 12,
- repository: 'test_user/webhooks_playground',
+ repository: "test_user/webhooks_playground",
github_user_id: github_user.id
)
expect(pull_request.work_packages).to eq [work_packages[0]]
expect(github_user).to have_attributes(
- github_login: 'test_user',
- github_html_url: 'https://github.com/test_user',
- github_avatar_url: 'https://avatars.githubusercontent.com/u/206108?v=4'
+ github_login: "test_user",
+ github_html_url: "https://github.com/test_user",
+ github_avatar_url: "https://avatars.githubusercontent.com/u/206108?v=4"
)
end
end
- shared_examples_for 'it creates a partial pull request' do
- it 'creates a partial GithubPullRequest' do
+ shared_examples_for "it creates a partial pull request" do
+ it "creates a partial GithubPullRequest" do
expect { process_webhook }.to(
change(GithubPullRequest, :count).by(1).and(
change(GithubUser, :count).by(1)
@@ -159,66 +159,66 @@
expect(pull_request.work_packages).to eq [work_packages[0]]
expect(github_user).to have_attributes(
- github_login: 'test_user',
- github_html_url: 'https://github.com/test_user',
- github_avatar_url: 'https://avatars.githubusercontent.com/u/206108?v=4'
+ github_login: "test_user",
+ github_html_url: "https://github.com/test_user",
+ github_avatar_url: "https://avatars.githubusercontent.com/u/206108?v=4"
)
end
end
- context 'when receiving a webhook for a pull_request event' do
- let(:event) { 'pull_request' }
+ context "when receiving a webhook for a pull_request event" do
+ let(:event) { "pull_request" }
- context 'when opened without mentioning any work package' do
+ context "when opened without mentioning any work package" do
let(:payload) do
webhook_payload(
- 'pull_request',
- 'opened',
- title: 'A PR title',
- body: 'A PR body'
+ "pull_request",
+ "opened",
+ title: "A PR title",
+ body: "A PR body"
)
end
- it_behaves_like 'it does not comment on any work package'
- it_behaves_like 'it does not create a pull request'
+ it_behaves_like "it does not comment on any work package"
+ it_behaves_like "it does not create a pull request"
end
- context 'when opened and mentioning a work package in the PR title' do
+ context "when opened and mentioning a work package in the PR title" do
let(:payload) do
webhook_payload(
- 'pull_request',
- 'opened',
+ "pull_request",
+ "opened",
title: "A PR title mentioning OP##{work_packages[0].id}",
- body: 'A PR body'
+ body: "A PR body"
)
end
let(:created_journals) { journal_counts_after.sum - journal_counts_before.sum }
- it_behaves_like 'it does not comment on any work package'
- it_behaves_like 'it does not create a pull request'
+ it_behaves_like "it does not comment on any work package"
+ it_behaves_like "it does not create a pull request"
end
- context 'when opened and mentioning a work package using its code in the PR body' do
+ context "when opened and mentioning a work package using its code in the PR body" do
let(:payload) do
webhook_payload(
- 'pull_request',
- 'opened',
- title: 'A PR title',
+ "pull_request",
+ "opened",
+ title: "A PR title",
body: "A PR body mentioning OP##{work_packages[0].id}"
)
end
let(:journal_entry) { / 'value' } }) }
+ let(:hook) { "fake hook" }
+ let(:params) { ActionController::Parameters.new({ payload: { "fake" => "value" } }) }
let(:environment) do
- { 'HTTP_X_GITHUB_EVENT' => 'pull_request',
- 'HTTP_X_GITHUB_DELIVERY' => 'veryuniqueid' }
+ { "HTTP_X_GITHUB_EVENT" => "pull_request",
+ "HTTP_X_GITHUB_DELIVERY" => "veryuniqueid" }
end
let(:request) { OpenStruct.new(env: environment) }
let(:user) do
@@ -44,34 +44,34 @@
user
end
- context 'with an unsupported event' do
+ context "with an unsupported event" do
let(:environment) do
- { 'HTTP_X_GITHUB_EVENT' => 'X-unspupported',
- 'HTTP_X_GITHUB_DELIVERY' => 'veryuniqueid2' }
+ { "HTTP_X_GITHUB_EVENT" => "X-unspupported",
+ "HTTP_X_GITHUB_DELIVERY" => "veryuniqueid2" }
end
- it 'returns 404' do
+ it "returns 404" do
result = handler.process(hook, request, params, user)
expect(result).to eq(404)
end
end
- context 'with a supported event and without user' do
+ context "with a supported event and without user" do
let(:user) { nil }
- it 'returns 403' do
+ it "returns 403" do
result = handler.process(hook, request, params, user)
expect(result).to eq(403)
end
end
- context 'with a supported event and a user' do
+ context "with a supported event and a user" do
let(:expected_params) do
{
- 'fake' => 'value',
- 'open_project_user_id' => 12,
- 'github_event' => 'pull_request',
- 'github_delivery' => 'veryuniqueid'
+ "fake" => "value",
+ "open_project_user_id" => 12,
+ "github_event" => "pull_request",
+ "github_delivery" => "veryuniqueid"
}
end
@@ -79,12 +79,12 @@
allow(OpenProject::Notifications).to receive(:send)
end
- it 'sends a notification with the correct contents' do
+ it "sends a notification with the correct contents" do
handler.process(hook, request, params, user)
expect(OpenProject::Notifications).to have_received(:send).with("github.pull_request", expected_params)
end
- it 'returns 200' do
+ it "returns 200" do
result = handler.process(hook, request, params, user)
expect(result).to eq(200)
end
diff --git a/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/check_run_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/check_run_spec.rb
index 2dcbf8f43503..91bbbdf84f66 100644
--- a/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/check_run_spec.rb
+++ b/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/check_run_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path('../../../../spec_helper', __dir__)
+require File.expand_path("../../../../spec_helper", __dir__)
RSpec.describe OpenProject::GithubIntegration::NotificationHandler::CheckRun do
subject(:process) { described_class.new.process(payload) }
@@ -36,8 +36,8 @@
end
let(:payload) do
{
- 'check_run' => {
- 'pull_requests' => pull_requests_payload
+ "check_run" => {
+ "pull_requests" => pull_requests_payload
}
}
end
@@ -49,31 +49,31 @@
allow(upsert_check_run_service).to receive(:call).and_return(nil)
end
- it 'does not call the UpsertCheckRun service when the check_run is not associated to a PR' do
+ it "does not call the UpsertCheckRun service when the check_run is not associated to a PR" do
process
expect(upsert_check_run_service).not_to have_received(:call)
end
- context 'when the check_run is not associated to a known GithubPullRequest' do
+ context "when the check_run is not associated to a known GithubPullRequest" do
let(:pull_requests_payload) do
[
{
- 'id' => 123
+ "id" => 123
}
]
end
- it 'does not call the UpsertCheckRun service' do
+ it "does not call the UpsertCheckRun service" do
process
expect(upsert_check_run_service).not_to have_received(:call)
end
end
- context 'when the check_run is associated to a known GithubPullRequest' do
+ context "when the check_run is associated to a known GithubPullRequest" do
let(:pull_requests_payload) do
[
{
- 'id' => 123
+ "id" => 123
}
]
end
@@ -81,10 +81,10 @@
before { github_pull_request }
- it 'does not call the UpsertCheckRun service' do
+ it "does not call the UpsertCheckRun service" do
process
expect(upsert_check_run_service).to have_received(:call).with(
- payload['check_run'],
+ payload["check_run"],
pull_request: github_pull_request
)
end
diff --git a/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/helper_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/helper_spec.rb
index f15d26e1db91..6cff504c4418 100644
--- a/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/helper_spec.rb
+++ b/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/helper_spec.rb
@@ -26,56 +26,56 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path('../../../../spec_helper', __dir__)
+require File.expand_path("../../../../spec_helper", __dir__)
RSpec.describe OpenProject::GithubIntegration::NotificationHandler::Helper do
subject(:handler) { Class.new.include(described_class).new }
before do
- allow(Setting).to receive(:host_name).and_return('example.net')
+ allow(Setting).to receive(:host_name).and_return("example.net")
end
- describe '#extract_work_package_ids' do
- it 'returns an empty array for an empty source' do
- expect(handler.extract_work_package_ids('')).to eq([])
+ describe "#extract_work_package_ids" do
+ it "returns an empty array for an empty source" do
+ expect(handler.extract_work_package_ids("")).to eq([])
end
- it 'returns an empty array for a null source' do
+ it "returns an empty array for a null source" do
expect(handler.extract_work_package_ids(nil)).to eq([])
end
- it 'finds a work package by code' do
+ it "finds a work package by code" do
source = "Blabla\nOP#1234\n"
expect(handler.extract_work_package_ids(source)).to eq([1234])
end
- it 'finds a plain work package url' do
+ it "finds a plain work package url" do
source = 'Blabla\nhttps://example.net/work_packages/234\n'
expect(handler.extract_work_package_ids(source)).to eq([234])
end
- it 'finds a work package url in markdown link syntax' do
+ it "finds a work package url in markdown link syntax" do
source = 'Blabla\n[WP 234](https://example.net/work_packages/234)\n'
expect(handler.extract_work_package_ids(source)).to eq([234])
end
- it 'finds multiple work package urls' do
+ it "finds multiple work package urls" do
source = "I reference https://example.net/work_packages/434\n and Blabla\n[WP 234](https://example.net/wp/234)\n"
expect(handler.extract_work_package_ids(source)).to eq([434, 234])
end
- it 'finds multiple occurrences of a work package only once' do
+ it "finds multiple occurrences of a work package only once" do
source = "I reference https://example.net/work_packages/434\n and Blabla\n[WP 234](https://example.net/work_packages/434)\n"
expect(handler.extract_work_package_ids(source)).to eq([434])
end
end
- describe '#find_visible_work_packages' do
+ describe "#find_visible_work_packages" do
let(:user) { build_stubbed(:user) }
let(:visible_wp) { instance_double(WorkPackage, project: :project_with_permissions) }
let(:invisible_wp) { instance_double(WorkPackage, project: :project_without_permissions) }
- shared_examples_for 'it finds visible work packages' do
+ shared_examples_for "it finds visible work packages" do
subject(:find_visible_work_packages) { handler.find_visible_work_packages(ids, user) }
before do
@@ -87,41 +87,41 @@
end
end
- it 'finds work packages visible to the user' do
+ it "finds work packages visible to the user" do
expect(find_visible_work_packages).to eql(expected)
end
end
- describe 'should find an existing work package' do
+ describe "should find an existing work package" do
let(:work_packages) { [visible_wp] }
let(:ids) { [0] }
let(:expected) { work_packages }
- it_behaves_like 'it finds visible work packages'
+ it_behaves_like "it finds visible work packages"
end
- describe 'should not find a non-existing work package' do
+ describe "should not find a non-existing work package" do
let(:work_packages) { [invisible_wp] }
let(:ids) { [0] }
let(:expected) { [] }
- it_behaves_like 'it finds visible work packages'
+ it_behaves_like "it finds visible work packages"
end
- describe 'should find multiple existing work packages' do
+ describe "should find multiple existing work packages" do
let(:work_packages) { [visible_wp, visible_wp] }
let(:ids) { [0, 1] }
let(:expected) { work_packages }
- it_behaves_like 'it finds visible work packages'
+ it_behaves_like "it finds visible work packages"
end
- describe 'should not find work package which the user shall not see' do
+ describe "should not find work package which the user shall not see" do
let(:work_packages) { [visible_wp, invisible_wp, visible_wp, invisible_wp] }
let(:ids) { [0, 1, 2, 3] }
let(:expected) { [visible_wp, visible_wp] }
- it_behaves_like 'it finds visible work packages'
+ it_behaves_like "it finds visible work packages"
end
end
end
diff --git a/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/issue_comment_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/issue_comment_spec.rb
index c37347687531..5c778c424e75 100644
--- a/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/issue_comment_spec.rb
+++ b/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/issue_comment_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path('../../../../spec_helper', __dir__)
+require File.expand_path("../../../../spec_helper", __dir__)
RSpec.describe OpenProject::GithubIntegration::NotificationHandler::IssueComment do
subject(:process) { handler_instance.process(payload) }
@@ -37,40 +37,40 @@
end
let(:payload) do
{
- 'action' => action,
- 'comment' => {
- 'body' => comment_body,
- 'html_url' => 'https://comment.url',
- 'user' => {
- 'login' => 'test_user',
- 'html_url' => 'https://github.com/test_user'
+ "action" => action,
+ "comment" => {
+ "body" => comment_body,
+ "html_url" => "https://comment.url",
+ "user" => {
+ "login" => "test_user",
+ "html_url" => "https://github.com/test_user"
}
},
- 'issue' => {
- 'state' => 'open',
- 'number' => pr_number,
- 'title' => 'PR or issue title',
- 'updated_at' => Time.current.iso8601,
- 'pull_request' => pr_payload,
- 'user' => {
- 'id' => 345,
- 'login' => 'test_user',
- 'html_url' => 'https://github.com/test_user',
- 'avatar_url' => 'https://github.com/test_user.jpg'
+ "issue" => {
+ "state" => "open",
+ "number" => pr_number,
+ "title" => "PR or issue title",
+ "updated_at" => Time.current.iso8601,
+ "pull_request" => pr_payload,
+ "user" => {
+ "id" => 345,
+ "login" => "test_user",
+ "html_url" => "https://github.com/test_user",
+ "avatar_url" => "https://github.com/test_user.jpg"
}
},
- 'repository' => {
- 'full_name' => repo_full_name,
- 'html_url' => 'https://github.com/test_user/repo'
+ "repository" => {
+ "full_name" => repo_full_name,
+ "html_url" => "https://github.com/test_user/repo"
},
- 'open_project_user_id' => github_system_user.id
+ "open_project_user_id" => github_system_user.id
}
end
let(:comment_body) { "a comment about OP##{work_package.id}" }
- let(:pr_payload) { { 'html_url' => pr_html_url } }
- let(:pr_html_url) { 'https://github.com/test_user/repo/pull/123' }
+ let(:pr_payload) { { "html_url" => pr_html_url } }
+ let(:pr_html_url) { "https://github.com/test_user/repo/pull/123" }
let(:pr_number) { 123 }
- let(:repo_full_name) { 'test_user/repo' }
+ let(:repo_full_name) { "test_user/repo" }
let(:github_system_user) { create(:admin) }
let(:work_package) { create(:work_package) }
let(:github_pull_request) { GithubPullRequest.find_by(github_html_url: pr_html_url) }
@@ -87,8 +87,8 @@
.and_call_original
end
- shared_examples_for 'upserting a GithubPullRequest' do
- it 'calls the UpsertPartialPullRequest service' do
+ shared_examples_for "upserting a GithubPullRequest" do
+ it "calls the UpsertPartialPullRequest service" do
process
expect(upsert_partial_pull_request_service)
.to have_received(:call) do |received_payload, work_packages:|
@@ -100,15 +100,15 @@
end
end
- shared_examples_for 'not upserting a GithubPullRequest' do
- it 'does not call the UpsertPartialPullRequest service' do
+ shared_examples_for "not upserting a GithubPullRequest" do
+ it "does not call the UpsertPartialPullRequest service" do
process
expect(upsert_partial_pull_request_service).not_to have_received(:call)
end
end
- shared_examples_for 'creating a comment on the work package' do
- it 'adds a comment to work packages' do
+ shared_examples_for "creating a comment on the work package" do
+ it "adds a comment to work packages" do
process
expect(handler_instance)
.to have_received(:comment_on_referenced_work_packages)
@@ -116,97 +116,97 @@
end
end
- shared_examples_for 'not creating comments on work packages' do
- it 'does not add comments to work packages' do
+ shared_examples_for "not creating comments on work packages" do
+ it "does not add comments to work packages" do
process
expect(handler_instance).not_to have_received(:comment_on_referenced_work_packages)
end
end
- context 'when a comment was created' do
- let(:action) { 'created' }
+ context "when a comment was created" do
+ let(:action) { "created" }
- context 'when commented on an issue' do
+ context "when commented on an issue" do
let(:pr_payload) { nil }
- it_behaves_like 'not creating comments on work packages'
- it_behaves_like 'not upserting a GithubPullRequest'
+ it_behaves_like "not creating comments on work packages"
+ it_behaves_like "not upserting a GithubPullRequest"
end
- context 'when commented on a PR' do
+ context "when commented on a PR" do
let(:comment) do
%().squish
end
- it_behaves_like 'creating a comment on the work package'
- it_behaves_like 'upserting a GithubPullRequest'
+ it_behaves_like "creating a comment on the work package"
+ it_behaves_like "upserting a GithubPullRequest"
end
- context 'when we already have a GithubPullRequest for the commented PR' do
+ context "when we already have a GithubPullRequest for the commented PR" do
let!(:github_pull_request) { create(:github_pull_request, github_html_url: pr_html_url) }
let(:comment) do
%().squish
end
- it_behaves_like 'creating a comment on the work package'
- it_behaves_like 'upserting a GithubPullRequest'
+ it_behaves_like "creating a comment on the work package"
+ it_behaves_like "upserting a GithubPullRequest"
end
- context 'when we already have a GithubPullRequest with that work_package' do
+ context "when we already have a GithubPullRequest with that work_package" do
let!(:github_pull_request) do
create(:github_pull_request, github_html_url: pr_html_url, work_packages: [work_package])
end
- it_behaves_like 'not creating comments on work packages'
+ it_behaves_like "not creating comments on work packages"
- it 'calls the UpsertPartialPullRequest service without adding already known work_packages' do
+ it "calls the UpsertPartialPullRequest service without adding already known work_packages" do
process
expect(upsert_partial_pull_request_service).not_to have_received(:call)
end
end
end
- context 'when a comment was edited' do
- let(:action) { 'edited' }
+ context "when a comment was edited" do
+ let(:action) { "edited" }
- context 'when editing an issue comment' do
+ context "when editing an issue comment" do
let(:pr_payload) { nil }
- it_behaves_like 'not creating comments on work packages'
- it_behaves_like 'not upserting a GithubPullRequest'
+ it_behaves_like "not creating comments on work packages"
+ it_behaves_like "not upserting a GithubPullRequest"
end
- context 'when editing a PR comment with a new work package reference' do
+ context "when editing a PR comment with a new work package reference" do
let(:comment) do
%().squish
end
- it_behaves_like 'creating a comment on the work package'
- it_behaves_like 'upserting a GithubPullRequest'
+ it_behaves_like "creating a comment on the work package"
+ it_behaves_like "upserting a GithubPullRequest"
end
- context 'when we already have a GithubPullRequest for the commented PR' do
+ context "when we already have a GithubPullRequest for the commented PR" do
let!(:github_pull_request) { create(:github_pull_request, github_html_url: pr_html_url) }
let(:comment) do
%().squish
end
- it_behaves_like 'creating a comment on the work package'
- it_behaves_like 'upserting a GithubPullRequest'
+ it_behaves_like "creating a comment on the work package"
+ it_behaves_like "upserting a GithubPullRequest"
end
- context 'when we already have a GithubPullRequest with that work_package' do
+ context "when we already have a GithubPullRequest with that work_package" do
let!(:github_pull_request) do
create(:github_pull_request, github_html_url: pr_html_url, work_packages: [work_package])
end
- it_behaves_like 'not creating comments on work packages'
+ it_behaves_like "not creating comments on work packages"
- it 'calls the UpsertPartialPullRequest service without adding already known work_packages' do
+ it "calls the UpsertPartialPullRequest service without adding already known work_packages" do
process
expect(upsert_partial_pull_request_service)
.not_to have_received(:call)
diff --git a/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/pull_request_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/pull_request_spec.rb
index ec04497a1715..289fad06664b 100644
--- a/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/pull_request_spec.rb
+++ b/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/pull_request_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path('../../../../spec_helper', __dir__)
+require File.expand_path("../../../../spec_helper", __dir__)
RSpec.describe OpenProject::GithubIntegration::NotificationHandler::PullRequest do
subject(:process) { handler_instance.process(payload) }
@@ -37,42 +37,42 @@
let(:payload) do
{
- 'action' => action,
- 'open_project_user_id' => github_system_user.id,
- 'pull_request' => {
- 'id' => 123,
- 'number' => 1,
- 'body' => pr_body,
- 'title' => 'A PR title',
- 'html_url' => 'http://pr.url',
- 'updated_at' => Time.current.iso8601,
- 'state' => 'open',
- 'draft' => pr_draft,
- 'merged' => pr_merged,
- 'merged_by' => nil,
- 'merged_at' => nil,
- 'comments' => 1,
- 'review_comments' => 2,
- 'additions' => 3,
- 'deletions' => 4,
- 'changed_files' => 5,
- 'labels' => [],
- 'user' => {
- 'id' => 345,
- 'login' => 'test_user',
- 'html_url' => 'https://github.com/test_user',
- 'avatar_url' => 'https://github.com/test_user.jpg'
+ "action" => action,
+ "open_project_user_id" => github_system_user.id,
+ "pull_request" => {
+ "id" => 123,
+ "number" => 1,
+ "body" => pr_body,
+ "title" => "A PR title",
+ "html_url" => "http://pr.url",
+ "updated_at" => Time.current.iso8601,
+ "state" => "open",
+ "draft" => pr_draft,
+ "merged" => pr_merged,
+ "merged_by" => nil,
+ "merged_at" => nil,
+ "comments" => 1,
+ "review_comments" => 2,
+ "additions" => 3,
+ "deletions" => 4,
+ "changed_files" => 5,
+ "labels" => [],
+ "user" => {
+ "id" => 345,
+ "login" => "test_user",
+ "html_url" => "https://github.com/test_user",
+ "avatar_url" => "https://github.com/test_user.jpg"
},
- 'base' => {
- 'repo' => {
- 'full_name' => 'test_user/repo',
- 'html_url' => 'github.com/test_user/repo'
+ "base" => {
+ "repo" => {
+ "full_name" => "test_user/repo",
+ "html_url" => "github.com/test_user/repo"
}
}
},
- 'sender' => {
- 'login' => 'test_user',
- 'html_url' => 'github.com/test_user'
+ "sender" => {
+ "login" => "test_user",
+ "html_url" => "github.com/test_user"
}
}
end
@@ -88,8 +88,8 @@
allow(upsert_service).to receive(:call).and_call_original
end
- shared_examples_for 'not adding a comment' do
- it 'does not add comments to work packages' do
+ shared_examples_for "not adding a comment" do
+ it "does not add comments to work packages" do
process
expect(handler_instance).to have_received(:comment_on_referenced_work_packages).with(
[],
@@ -99,8 +99,8 @@
end
end
- shared_examples_for 'adding a comment' do
- it 'adds a comment to the work packages' do
+ shared_examples_for "adding a comment" do
+ it "adds a comment to the work packages" do
process
expect(handler_instance).to have_received(:comment_on_referenced_work_packages).with(
[work_package],
@@ -110,101 +110,101 @@
end
end
- shared_examples_for 'calls the pull request upsert service' do
- it 'calls the pull request upsert service' do
+ shared_examples_for "calls the pull request upsert service" do
+ it "calls the pull request upsert service" do
process
- expect(upsert_service).to have_received(:call).with(payload['pull_request'], work_packages: [work_package])
+ expect(upsert_service).to have_received(:call).with(payload["pull_request"], work_packages: [work_package])
end
- context 'when no work_package was mentioned' do
- let(:pr_body) { 'some text that does not mention any work package' }
+ context "when no work_package was mentioned" do
+ let(:pr_body) { "some text that does not mention any work package" }
- it 'does not call the pull request upsert service' do
+ it "does not call the pull request upsert service" do
process
expect(upsert_service).not_to have_received(:call)
end
end
end
- context 'with a closed action' do
- let(:action) { 'closed' }
+ context "with a closed action" do
+ let(:action) { "closed" }
let(:comment) do
%().squish
end
- it_behaves_like 'adding a comment'
- it_behaves_like 'calls the pull request upsert service'
+ it_behaves_like "adding a comment"
+ it_behaves_like "calls the pull request upsert service"
end
- context 'with a closed action when the PR was merged' do
- let(:action) { 'closed' }
+ context "with a closed action when the PR was merged" do
+ let(:action) { "closed" }
let(:pr_merged) { true }
let(:comment) do
%().squish
end
- it_behaves_like 'adding a comment'
- it_behaves_like 'calls the pull request upsert service'
+ it_behaves_like "adding a comment"
+ it_behaves_like "calls the pull request upsert service"
- context 'when the work package is already known to the GithubPullRequest' do
+ context "when the work package is already known to the GithubPullRequest" do
let!(:github_pull_request) { create(:github_pull_request, github_id: 123, work_packages: [work_package]) }
- it_behaves_like 'adding a comment'
+ it_behaves_like "adding a comment"
- it 'calls the pull request upsert service' do
+ it "calls the pull request upsert service" do
process
- expect(upsert_service).to have_received(:call).with(payload['pull_request'], work_packages: [work_package])
+ expect(upsert_service).to have_received(:call).with(payload["pull_request"], work_packages: [work_package])
end
end
end
- context 'with a converted_to_draft action' do
- let(:action) { 'converted_to_draft' }
+ context "with a converted_to_draft action" do
+ let(:action) { "converted_to_draft" }
- it_behaves_like 'not adding a comment'
- it_behaves_like 'calls the pull request upsert service'
+ it_behaves_like "not adding a comment"
+ it_behaves_like "calls the pull request upsert service"
end
- context 'with an edited action' do
- let(:action) { 'edited' }
+ context "with an edited action" do
+ let(:action) { "edited" }
let(:comment) do
%().squish
end
- it_behaves_like 'adding a comment'
- it_behaves_like 'calls the pull request upsert service'
+ it_behaves_like "adding a comment"
+ it_behaves_like "calls the pull request upsert service"
- context 'when a GithubPullRequest exists that is not linked to the mentioned work package yet' do
+ context "when a GithubPullRequest exists that is not linked to the mentioned work package yet" do
let!(:github_pull_request) { create(:github_pull_request, github_id: 123) }
- it_behaves_like 'adding a comment'
+ it_behaves_like "adding a comment"
- it 'calls the pull request upsert service' do
+ it "calls the pull request upsert service" do
process
- expect(upsert_service).to have_received(:call).with(payload['pull_request'], work_packages: [work_package])
+ expect(upsert_service).to have_received(:call).with(payload["pull_request"], work_packages: [work_package])
end
end
- context 'when the work package is already known to the GithubPullRequest' do
+ context "when the work package is already known to the GithubPullRequest" do
let!(:github_pull_request) { create(:github_pull_request, github_id: 123, work_packages: [work_package]) }
- it_behaves_like 'not adding a comment'
+ it_behaves_like "not adding a comment"
- it 'calls the pull request upsert service' do
+ it "calls the pull request upsert service" do
process
- expect(upsert_service).to have_received(:call).with(payload['pull_request'], work_packages: [work_package])
+ expect(upsert_service).to have_received(:call).with(payload["pull_request"], work_packages: [work_package])
end
end
- context 'when the a work package is already known to the GithubPullRequest but another work package is new' do
+ context "when the a work package is already known to the GithubPullRequest but another work package is new" do
let!(:github_pull_request) { create(:github_pull_request, github_id: 123, work_packages: [work_package]) }
let!(:other_work_package) { create(:work_package) }
let(:pr_body) { "Mentioning OP##{work_package.id} and OP##{other_work_package.id}" }
- it 'adds a comment only for the other_work_package' do
+ it "adds a comment only for the other_work_package" do
process
expect(handler_instance).to have_received(:comment_on_referenced_work_packages).with(
[other_work_package],
@@ -213,70 +213,70 @@
)
end
- it 'calls the pull request upsert service with all work_packages' do
+ it "calls the pull request upsert service with all work_packages" do
process
- expect(upsert_service).to have_received(:call).with(payload['pull_request'],
+ expect(upsert_service).to have_received(:call).with(payload["pull_request"],
work_packages: [work_package, other_work_package])
end
end
end
- context 'with a labeled action' do
- let(:action) { 'labeled' }
+ context "with a labeled action" do
+ let(:action) { "labeled" }
- it_behaves_like 'not adding a comment'
- it_behaves_like 'calls the pull request upsert service'
+ it_behaves_like "not adding a comment"
+ it_behaves_like "calls the pull request upsert service"
end
- context 'with an opened action' do
- let(:action) { 'opened' }
+ context "with an opened action" do
+ let(:action) { "opened" }
let(:comment) do
%().squish
end
- it_behaves_like 'adding a comment'
- it_behaves_like 'calls the pull request upsert service'
+ it_behaves_like "adding a comment"
+ it_behaves_like "calls the pull request upsert service"
end
- context 'with an opened action when the PR is a draft' do
- let(:action) { 'opened' }
+ context "with an opened action when the PR is a draft" do
+ let(:action) { "opened" }
let(:pr_draft) { true }
let(:comment) do
%().squish
end
- it_behaves_like 'adding a comment'
- it_behaves_like 'calls the pull request upsert service'
+ it_behaves_like "adding a comment"
+ it_behaves_like "calls the pull request upsert service"
end
- context 'with a ready_for_review action' do
- let(:action) { 'ready_for_review' }
+ context "with a ready_for_review action" do
+ let(:action) { "ready_for_review" }
let(:comment) do
%().squish
end
- it_behaves_like 'adding a comment'
- it_behaves_like 'calls the pull request upsert service'
+ it_behaves_like "adding a comment"
+ it_behaves_like "calls the pull request upsert service"
end
- context 'with a reopened action' do
- let(:action) { 'reopened' }
+ context "with a reopened action" do
+ let(:action) { "reopened" }
let(:comment) do
%().squish
end
- it_behaves_like 'adding a comment'
- it_behaves_like 'calls the pull request upsert service'
+ it_behaves_like "adding a comment"
+ it_behaves_like "calls the pull request upsert service"
end
- context 'with a synchronize action' do
- let(:action) { 'synchronize' }
+ context "with a synchronize action" do
+ let(:action) { "synchronize" }
- it_behaves_like 'not adding a comment'
- it_behaves_like 'calls the pull request upsert service'
+ it_behaves_like "not adding a comment"
+ it_behaves_like "calls the pull request upsert service"
end
end
diff --git a/modules/github_integration/spec/lib/open_project/github_integration/notification_handler_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/notification_handler_spec.rb
index d84ddb1104ff..6a50893a4c1c 100644
--- a/modules/github_integration/spec/lib/open_project/github_integration/notification_handler_spec.rb
+++ b/modules/github_integration/spec/lib/open_project/github_integration/notification_handler_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path('../../../spec_helper', __dir__)
+require File.expand_path("../../../spec_helper", __dir__)
RSpec.describe OpenProject::GithubIntegration::NotificationHandler do
let(:payload) { {} }
- shared_examples_for 'a notification handler' do
+ shared_examples_for "a notification handler" do
let(:handler) { instance_double(handler_class) }
before do
@@ -39,45 +39,45 @@
allow(handler).to receive(:process).and_return(nil)
end
- it 'forwards the payload to a new handler instance' do
+ it "forwards the payload to a new handler instance" do
process
expect(handler).to have_received(:process).with(payload)
end
- context 'when the handler throws an error' do
+ context "when the handler throws an error" do
before do
allow(handler).to receive(:process).and_raise("oops")
allow(Rails.logger).to receive(:error)
end
- it 'logs the error message' do
+ it "logs the error message" do
expect { process }.to raise_error("oops")
expect(Rails.logger).to have_received(:error)
end
end
end
- describe '.check_run' do
+ describe ".check_run" do
subject(:process) { described_class.check_run(payload) }
let(:handler_class) { described_class::CheckRun }
- it_behaves_like 'a notification handler'
+ it_behaves_like "a notification handler"
end
- describe '.issue_comment' do
+ describe ".issue_comment" do
subject(:process) { described_class.issue_comment(payload) }
let(:handler_class) { described_class::IssueComment }
- it_behaves_like 'a notification handler'
+ it_behaves_like "a notification handler"
end
- describe '.pull_request' do
+ describe ".pull_request" do
subject(:process) { described_class.pull_request(payload) }
let(:handler_class) { described_class::PullRequest }
- it_behaves_like 'a notification handler'
+ it_behaves_like "a notification handler"
end
end
diff --git a/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_check_run_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_check_run_spec.rb
index c3d48dafaa03..5ddab3219948 100644
--- a/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_check_run_spec.rb
+++ b/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_check_run_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path('../../../../spec_helper', __dir__)
+require File.expand_path("../../../../spec_helper", __dir__)
RSpec.describe OpenProject::GithubIntegration::Services::UpsertCheckRun do
subject(:upsert) { described_class.new.call(params, pull_request: github_pull_request) }
@@ -34,50 +34,50 @@
let(:github_pull_request) { create(:github_pull_request) }
let(:params) do
{
- 'id' => 123,
- 'html_url' => 'https://github.com/check_runs/123',
- 'name' => 'test',
- 'status' => 'completed',
- 'conclusion' => 'success',
- 'details_url' => 'https://github.com/details',
- 'started_at' => 1.hour.ago.iso8601,
- 'completed_at' => 1.minute.ago.iso8601,
- 'output' => {
- 'title' => 'a title',
- 'summary' => 'a summary'
+ "id" => 123,
+ "html_url" => "https://github.com/check_runs/123",
+ "name" => "test",
+ "status" => "completed",
+ "conclusion" => "success",
+ "details_url" => "https://github.com/details",
+ "started_at" => 1.hour.ago.iso8601,
+ "completed_at" => 1.minute.ago.iso8601,
+ "output" => {
+ "title" => "a title",
+ "summary" => "a summary"
},
- 'app' => {
- 'id' => 456,
- 'owner' => {
- 'avatar_url' => 'https:://github.com/apps/456/avatar.png'
+ "app" => {
+ "id" => 456,
+ "owner" => {
+ "avatar_url" => "https:://github.com/apps/456/avatar.png"
}
}
}
end
- it 'creates a new check run for the given pull request' do
+ it "creates a new check run for the given pull request" do
expect { upsert }.to change(GithubCheckRun, :count).by(1)
expect(GithubCheckRun.last).to have_attributes(
github_id: 123,
- github_html_url: 'https://github.com/check_runs/123',
+ github_html_url: "https://github.com/check_runs/123",
app_id: 456,
- github_app_owner_avatar_url: 'https:://github.com/apps/456/avatar.png',
- name: 'test',
- status: 'completed',
- conclusion: 'success',
- output_title: 'a title',
- output_summary: 'a summary',
- details_url: 'https://github.com/details',
+ github_app_owner_avatar_url: "https:://github.com/apps/456/avatar.png",
+ name: "test",
+ status: "completed",
+ conclusion: "success",
+ output_title: "a title",
+ output_summary: "a summary",
+ details_url: "https://github.com/details",
github_pull_request:
)
end
- context 'when a check run with that id already exists' do
- let(:check_run) { create(:github_check_run, github_id: 123, status: 'queued') }
+ context "when a check run with that id already exists" do
+ let(:check_run) { create(:github_check_run, github_id: 123, status: "queued") }
- it 'updates the check run' do
- expect { upsert }.to change { check_run.reload.status }.from('queued').to('completed')
+ it "updates the check run" do
+ expect { upsert }.to change { check_run.reload.status }.from("queued").to("completed")
end
end
end
diff --git a/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_github_user_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_github_user_spec.rb
index d7111f9fcf53..e6c1d2afd987 100644
--- a/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_github_user_spec.rb
+++ b/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_github_user_spec.rb
@@ -26,38 +26,38 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path('../../../../spec_helper', __dir__)
+require File.expand_path("../../../../spec_helper", __dir__)
RSpec.describe OpenProject::GithubIntegration::Services::UpsertGithubUser do
subject(:upsert) { described_class.new.call(params) }
let(:params) do
{
- 'id' => 123,
- 'login' => 'test_user',
- 'html_url' => 'https://github.com/test_user',
- 'avatar_url' => 'https://github.com/test_user/avatar.jpg'
+ "id" => 123,
+ "login" => "test_user",
+ "html_url" => "https://github.com/test_user",
+ "avatar_url" => "https://github.com/test_user/avatar.jpg"
}
end
- it 'creates a new github user' do
+ it "creates a new github user" do
expect { upsert }.to change(GithubUser, :count).by(1)
expect(GithubUser.last).to have_attributes(
github_id: 123,
- github_login: 'test_user',
- github_html_url: 'https://github.com/test_user',
- github_avatar_url: 'https://github.com/test_user/avatar.jpg'
+ github_login: "test_user",
+ github_html_url: "https://github.com/test_user",
+ github_avatar_url: "https://github.com/test_user/avatar.jpg"
)
end
- context 'when a github user with that id already exists' do
+ context "when a github user with that id already exists" do
let(:github_user) do
- create(:github_user, github_id: 123, github_avatar_url: 'https://github.com/test_user/old_avatar.jpg')
+ create(:github_user, github_id: 123, github_avatar_url: "https://github.com/test_user/old_avatar.jpg")
end
- it 'updates the github user' do
- expect { upsert }.to change { github_user.reload.github_avatar_url }.from('https://github.com/test_user/old_avatar.jpg').to('https://github.com/test_user/avatar.jpg')
+ it "updates the github user" do
+ expect { upsert }.to change { github_user.reload.github_avatar_url }.from("https://github.com/test_user/old_avatar.jpg").to("https://github.com/test_user/avatar.jpg")
end
end
end
diff --git a/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_partial_pull_request_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_partial_pull_request_spec.rb
index 4fcfb9ddfbd6..bdf495e5867e 100644
--- a/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_partial_pull_request_spec.rb
+++ b/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_partial_pull_request_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path('../../../../spec_helper', __dir__)
+require File.expand_path("../../../../spec_helper", __dir__)
RSpec.describe OpenProject::GithubIntegration::Services::UpsertPartialPullRequest do
subject(:upsert) do
@@ -49,11 +49,11 @@
{
"issue" => {
"number" => 23,
- "title" => 'Some title',
+ "title" => "Some title",
"updated_at" => "2021-04-06T15:16:03Z",
- "state" => 'closed',
+ "state" => "closed",
"pull_request" => {
- "html_url" => 'https://github.com/pulls/1'
+ "html_url" => "https://github.com/pulls/1"
},
"user" => {
"login" => "test_user",
@@ -62,61 +62,61 @@
}
},
"repository" => {
- "full_name" => 'test_user/repo'
+ "full_name" => "test_user/repo"
}
}
end
let(:work_packages) { create_list(:work_package, 1) }
- it 'creates a new github pull request' do
+ it "creates a new github pull request" do
expect { upsert }.to change(GithubPullRequest, :count).by(1)
expect(GithubPullRequest.last).to have_attributes(
github_id: nil,
- state: 'closed',
+ state: "closed",
number: 23,
- title: 'Some title',
- github_html_url: 'https://github.com/pulls/1',
+ title: "Some title",
+ github_html_url: "https://github.com/pulls/1",
github_updated_at: DateTime.parse("2021-04-06T15:16:03Z"),
github_user_id: 12345,
- repository: 'test_user/repo',
+ repository: "test_user/repo",
work_packages:
)
end
- context 'when a github pull request with that html_url already exists' do
+ context "when a github pull request with that html_url already exists" do
let(:github_pull_request) do
create(:github_pull_request,
- github_html_url: 'https://github.com/pulls/1')
+ github_html_url: "https://github.com/pulls/1")
end
- it 'updates the github pull request' do
+ it "updates the github pull request" do
expect { upsert }.to change { github_pull_request.reload.work_packages }.from([]).to(work_packages)
end
end
- context 'when a github pull request with that html_url and work_package exists' do
+ context "when a github pull request with that html_url and work_package exists" do
let(:github_pull_request) do
create(:github_pull_request,
- github_html_url: 'https://github.com/pulls/1',
+ github_html_url: "https://github.com/pulls/1",
work_packages:)
end
- it 'does not change the associated work packages' do
+ it "does not change the associated work packages" do
expect { upsert }.not_to(change { github_pull_request.reload.work_packages.to_a })
end
end
- context 'when a github pull request with that html_url and work_package exists and a new work_package is referenced' do
+ context "when a github pull request with that html_url and work_package exists and a new work_package is referenced" do
let(:github_pull_request) do
create(:github_pull_request,
- github_html_url: 'https://github.com/pulls/1',
+ github_html_url: "https://github.com/pulls/1",
work_packages: already_known_work_packages)
end
let(:work_packages) { create_list(:work_package, 2) }
let(:already_known_work_packages) { [work_packages[0]] }
- it 'adds the new work package' do
+ it "adds the new work package" do
expect { upsert }
.to change { github_pull_request.reload.work_packages }
.from(already_known_work_packages)
@@ -124,19 +124,19 @@
end
end
- context 'when an open github pull request with that html_url and work_package exists and a new work_package is referenced' do
+ context "when an open github pull request with that html_url and work_package exists and a new work_package is referenced" do
let(:github_pull_request) do
create(:github_pull_request,
- github_html_url: 'https://github.com/pulls/1',
- repository: 'some_user/a_repository',
- state: 'open',
+ github_html_url: "https://github.com/pulls/1",
+ repository: "some_user/a_repository",
+ state: "open",
github_id: 1,
work_packages: already_known_work_packages)
end
let(:work_packages) { create_list(:work_package, 2) }
let(:already_known_work_packages) { [work_packages[0]] }
- it 'adds the new work package and updates attributes' do
+ it "adds the new work package and updates attributes" do
expect { upsert }
.to change { github_pull_request.reload.work_packages }
.from(already_known_work_packages)
@@ -144,13 +144,13 @@
expect(github_pull_request).to have_attributes(
github_id: 1,
- state: 'closed',
+ state: "closed",
number: 23,
- title: 'Some title',
+ title: "Some title",
github_user_id: 12345,
- github_html_url: 'https://github.com/pulls/1',
+ github_html_url: "https://github.com/pulls/1",
github_updated_at: DateTime.parse("2021-04-06T15:16:03Z"),
- repository: 'test_user/repo'
+ repository: "test_user/repo"
)
end
end
diff --git a/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_pull_request_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_pull_request_spec.rb
index 2c6afed38fa3..afc97f1b655c 100644
--- a/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_pull_request_spec.rb
+++ b/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_pull_request_spec.rb
@@ -26,52 +26,52 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path('../../../../spec_helper', __dir__)
+require File.expand_path("../../../../spec_helper", __dir__)
RSpec.describe OpenProject::GithubIntegration::Services::UpsertPullRequest do
subject(:upsert) { described_class.new.call(params, work_packages:) }
let(:params) do
{
- 'id' => 123,
- 'number' => 5,
- 'html_url' => 'https://github.com/test_user/repo',
- 'updated_at' => '20210409T12:13:14Z',
- 'state' => pr_state,
- 'title' => 'The PR title',
- 'body' => 'The PR body',
- 'draft' => false,
- 'comments' => 12,
- 'review_comments' => 13,
- 'additions' => 14,
- 'deletions' => 15,
- 'changed_files' => 16,
- 'labels' => labels_payload,
- 'base' => {
- 'repo' => {
- 'full_name' => 'test_user/repo',
- 'html_url' => 'https://github.com/test_user/repo'
+ "id" => 123,
+ "number" => 5,
+ "html_url" => "https://github.com/test_user/repo",
+ "updated_at" => "20210409T12:13:14Z",
+ "state" => pr_state,
+ "title" => "The PR title",
+ "body" => "The PR body",
+ "draft" => false,
+ "comments" => 12,
+ "review_comments" => 13,
+ "additions" => 14,
+ "deletions" => 15,
+ "changed_files" => 16,
+ "labels" => labels_payload,
+ "base" => {
+ "repo" => {
+ "full_name" => "test_user/repo",
+ "html_url" => "https://github.com/test_user/repo"
}
},
- 'user' => user_payload,
+ "user" => user_payload,
**merged_payload
}
end
let(:labels_payload) { [] }
- let(:pr_state) { 'open' }
+ let(:pr_state) { "open" }
let(:merged_payload) do
{
- 'merged' => false,
- 'merged_by' => nil,
- 'merged_at' => nil
+ "merged" => false,
+ "merged_by" => nil,
+ "merged_at" => nil
}
end
let(:user_payload) do
{
- 'id' => 456,
- 'login' => 'test_user',
- 'html_url' => 'https://github.com/test_user',
- 'avatar_url' => 'https://github.com/test_user/avatar.jpg'
+ "id" => 456,
+ "login" => "test_user",
+ "html_url" => "https://github.com/test_user",
+ "avatar_url" => "https://github.com/test_user/avatar.jpg"
}
end
let(:work_packages) { create_list(:work_package, 1) }
@@ -83,7 +83,7 @@
allow(upsert_github_user_service).to receive(:call).and_return(github_user)
end
- it 'creates a new github pull request and calls the upsert github user service' do
+ it "creates a new github pull request and calls the upsert github user service" do
expect { upsert }.to change(GithubPullRequest, :count).by(1)
expect(upsert_github_user_service).to have_received(:call).with(user_payload)
@@ -91,11 +91,11 @@
expect(GithubPullRequest.last).to have_attributes(
github_id: 123,
number: 5,
- github_html_url: 'https://github.com/test_user/repo',
- github_updated_at: Time.zone.parse('20210409T12:13:14Z'),
- state: 'open',
- title: 'The PR title',
- body: 'The PR body',
+ github_html_url: "https://github.com/test_user/repo",
+ github_updated_at: Time.zone.parse("20210409T12:13:14Z"),
+ state: "open",
+ title: "The PR title",
+ body: "The PR body",
draft: false,
merged: false,
merged_by: nil,
@@ -106,23 +106,23 @@
deletions_count: 15,
changed_files_count: 16,
labels: [],
- repository: 'test_user/repo',
+ repository: "test_user/repo",
github_user:,
work_packages:
)
end
- context 'when a github pull request with that id already exists' do
+ context "when a github pull request with that id already exists" do
let(:github_pull_request) do
- create(:github_pull_request, github_id: 123, title: 'old title')
+ create(:github_pull_request, github_id: 123, title: "old title")
end
- it 'updates the github pull request' do
- expect { upsert }.to change { github_pull_request.reload.title }.from('old title').to('The PR title')
+ it "updates the github pull request" do
+ expect { upsert }.to change { github_pull_request.reload.title }.from("old title").to("The PR title")
end
end
- context 'when a partial github pull request with that html_url already exists' do
+ context "when a partial github pull request with that html_url already exists" do
let(:github_pull_request) do
create(:github_pull_request,
github_id: nil,
@@ -132,37 +132,37 @@
review_comments_count: nil,
additions_count: nil,
deletions_count: nil,
- github_html_url: 'https://github.com/test_user/repo',
- state: 'closed')
+ github_html_url: "https://github.com/test_user/repo",
+ state: "closed")
end
- it 'updates the github pull request' do
- expect { upsert }.to change { github_pull_request.reload.state }.from('closed').to('open')
+ it "updates the github pull request" do
+ expect { upsert }.to change { github_pull_request.reload.state }.from("closed").to("open")
expect(github_pull_request).to have_attributes(
github_id: 123,
- state: 'open',
+ state: "open",
number: 5,
- title: 'The PR title',
- body: 'The PR body',
- github_html_url: 'https://github.com/test_user/repo',
- github_updated_at: DateTime.parse('20210409T12:13:14Z'),
- repository: 'test_user/repo'
+ title: "The PR title",
+ body: "The PR body",
+ github_html_url: "https://github.com/test_user/repo",
+ github_updated_at: DateTime.parse("20210409T12:13:14Z"),
+ repository: "test_user/repo"
)
end
end
- context 'when a github pull request with that id and work_package exists' do
+ context "when a github pull request with that id and work_package exists" do
let(:github_pull_request) do
create(:github_pull_request, github_id: 123, work_packages:)
end
- it 'does not change the associated work packages' do
+ it "does not change the associated work packages" do
expect { upsert }.not_to(change { github_pull_request.reload.work_packages.to_a })
end
end
- context 'when a github pull request with that id and work_package exists and a new work_package is referenced' do
+ context "when a github pull request with that id and work_package exists and a new work_package is referenced" do
let(:github_pull_request) do
create(:github_pull_request, github_id: 123,
work_packages: already_known_work_packages)
@@ -170,22 +170,22 @@
let(:work_packages) { create_list(:work_package, 2) }
let(:already_known_work_packages) { [work_packages[0]] }
- it 'adds the new work package' do
+ it "adds the new work package" do
expect { upsert }.to change { github_pull_request.reload.work_packages }.from(already_known_work_packages).to(work_packages)
end
end
- context 'when the pr is merged' do
- let(:pr_state) { 'open' }
+ context "when the pr is merged" do
+ let(:pr_state) { "open" }
let(:merged_payload) do
{
- 'merged' => true,
- 'merged_by' => user_payload,
- 'merged_at' => '20210410T09:45:03Z'
+ "merged" => true,
+ "merged_by" => user_payload,
+ "merged_at" => "20210410T09:45:03Z"
}
end
- it 'sets the merge attributes' do
+ it "sets the merge attributes" do
expect { upsert }.to change(GithubPullRequest, :count).by(1)
expect(upsert_github_user_service).to have_received(:call).with(user_payload).twice
@@ -195,42 +195,42 @@
github_user:,
merged: true,
merged_by: github_user,
- merged_at: Time.zone.parse('20210410T09:45:03Z')
+ merged_at: Time.zone.parse("20210410T09:45:03Z")
)
end
end
- context 'when the pull request payload contains label data' do
+ context "when the pull request payload contains label data" do
let(:labels_payload) do
[
{
- 'id' => 123456789,
- 'name' => 'grey',
- 'color' => '#666',
- 'description' => "An evil'ish gray tone"
+ "id" => 123456789,
+ "name" => "grey",
+ "color" => "#666",
+ "description" => "An evil'ish gray tone"
},
{
- 'id' => 987654321,
- 'name' => 'white',
- 'color' => '#fff',
- 'description' => "A haven'ish white tone"
+ "id" => 987654321,
+ "name" => "white",
+ "color" => "#fff",
+ "description" => "A haven'ish white tone"
}
]
end
- it 'stores the label attributes' do
+ it "stores the label attributes" do
expect { upsert }.to change(GithubPullRequest, :count).by(1)
expect(GithubPullRequest.last).to have_attributes(
github_id: 123,
labels: [
{
- 'name' => 'grey',
- 'color' => '#666'
+ "name" => "grey",
+ "color" => "#666"
},
{
- 'name' => 'white',
- 'color' => '#fff'
+ "name" => "white",
+ "color" => "#fff"
}
]
)
diff --git a/modules/github_integration/spec/models/github_pull_request_spec.rb b/modules/github_integration/spec/models/github_pull_request_spec.rb
index f8da27d15658..f0185d5eb68b 100644
--- a/modules/github_integration/spec/models/github_pull_request_spec.rb
+++ b/modules/github_integration/spec/models/github_pull_request_spec.rb
@@ -36,10 +36,10 @@
it { is_expected.to validate_presence_of :title }
it { is_expected.to validate_presence_of :github_updated_at }
- context 'when it is not a partial pull request' do
+ context "when it is not a partial pull request" do
subject do
described_class.new(changed_files_count: 5,
- body: 'something',
+ body: "something",
comments_count: 4,
review_comments_count: 3,
additions_count: 2,
@@ -54,16 +54,16 @@
it { is_expected.to validate_presence_of :changed_files_count }
end
- describe 'labels' do
+ describe "labels" do
it { is_expected.to allow_value(nil).for(:labels) }
it { is_expected.to allow_value([]).for(:labels) }
- it { is_expected.to allow_value([{ 'color' => '#666', 'name' => 'grey' }]).for(:labels) }
- it { is_expected.not_to allow_value([{ 'name' => 'grey' }]).for(:labels) }
+ it { is_expected.to allow_value([{ "color" => "#666", "name" => "grey" }]).for(:labels) }
+ it { is_expected.not_to allow_value([{ "name" => "grey" }]).for(:labels) }
it { is_expected.not_to allow_value([{}]).for(:labels) }
end
end
- describe '.without_work_package' do
+ describe ".without_work_package" do
subject { described_class.without_work_package }
let(:pull_request) { create(:github_pull_request, work_packages:) }
@@ -73,92 +73,92 @@
it { is_expected.to contain_exactly(pull_request) }
- context 'when the pr is linked to a work_package' do
+ context "when the pr is linked to a work_package" do
let(:work_packages) { create_list(:work_package, 1) }
it { is_expected.to be_empty }
end
end
- describe '.find_by_github_identifiers' do
+ describe ".find_by_github_identifiers" do
let(:github_id) { 5 }
- let(:github_url) { 'https://github.com/opf/openproject/pull/123' }
+ let(:github_url) { "https://github.com/opf/openproject/pull/123" }
let(:pull_request) do
create(:github_pull_request,
github_id:,
github_html_url: github_url)
end
- context 'when the github_id attribute matches' do
- it 'finds by github_id' do
+ context "when the github_id attribute matches" do
+ it "finds by github_id" do
expect(described_class.find_by_github_identifiers(id: pull_request.github_id))
.to eql pull_request
end
end
- context 'when the github_html_url attribute matches' do
- it 'finds by github_html_url' do
+ context "when the github_html_url attribute matches" do
+ it "finds by github_html_url" do
expect(described_class.find_by_github_identifiers(url: pull_request.github_html_url))
.to eql pull_request
end
end
- context 'when the provided github_id does not match' do
- it 'is nil' do
+ context "when the provided github_id does not match" do
+ it "is nil" do
expect(described_class.find_by_github_identifiers(id: pull_request.github_id + 1))
.to be_nil
end
end
- context 'when the provided github_html_url does not match' do
- it 'is nil' do
+ context "when the provided github_html_url does not match" do
+ it "is nil" do
expect(described_class.find_by_github_identifiers(url: "#{pull_request.github_html_url}zzzz"))
.to be_nil
end
end
- context 'when neither match' do
- it 'is nil' do
+ context "when neither match" do
+ it "is nil" do
expect(described_class.find_by_github_identifiers(id: pull_request.github_id + 1,
url: "#{pull_request.github_html_url}zzzz"))
.to be_nil
end
end
- context 'when the provided github_html_url does not match but the github_id does' do
- it 'is nil' do
+ context "when the provided github_html_url does not match but the github_id does" do
+ it "is nil" do
expect(described_class.find_by_github_identifiers(id: pull_request.github_id,
url: "#{pull_request.github_html_url}zzzz"))
.to eql pull_request
end
end
- context 'when the provided github_html_url does match but the github_id does not' do
- it 'is nil' do
+ context "when the provided github_html_url does match but the github_id does not" do
+ it "is nil" do
expect(described_class.find_by_github_identifiers(id: pull_request.github_id + 1,
url: pull_request.github_html_url))
.to eql pull_request
end
end
- context 'when neither match but initialize is true' do
+ context "when neither match but initialize is true" do
subject(:finder) do
described_class.find_by_github_identifiers(id: pull_request.github_id + 1,
url: "#{pull_request.github_html_url}zzzz",
initialize: true)
end
- it 'returns a pull reqeust' do
+ it "returns a pull reqeust" do
expect(finder)
.to be_a(described_class)
end
- it 'returns a new record' do
+ it "returns a new record" do
expect(finder)
.to be_new_record
end
- it 'has the provided attributes initialized' do
+ it "has the provided attributes initialized" do
expect(finder.attributes.compact)
.to eql("github_id" => pull_request.github_id + 1,
"github_html_url" => "#{pull_request.github_html_url}zzzz")
@@ -166,41 +166,41 @@
end
end
- describe '#latest_check_runs' do
+ describe "#latest_check_runs" do
subject { pull_request.reload.latest_check_runs }
let(:pull_request) { create(:github_pull_request) }
it { is_expected.to be_empty }
- context 'when multiple check_runs from different apps with different names exist' do
+ context "when multiple check_runs from different apps with different names exist" do
let(:latest_check_runs) do
[
create(
:github_check_run,
app_id: 123,
- name: 'test',
+ name: "test",
started_at: 1.minute.ago,
github_pull_request: pull_request
),
create(
:github_check_run,
app_id: 123,
- name: 'lint',
+ name: "lint",
started_at: 1.minute.ago,
github_pull_request: pull_request
),
create(
:github_check_run,
app_id: 456,
- name: 'test',
+ name: "test",
started_at: 1.minute.ago,
github_pull_request: pull_request
),
create(
:github_check_run,
app_id: 789,
- name: 'test',
+ name: "test",
started_at: 1.minute.ago,
github_pull_request: pull_request
)
@@ -211,21 +211,21 @@
create(
:github_check_run,
app_id: 123,
- name: 'test',
+ name: "test",
started_at: 2.minutes.ago,
github_pull_request: pull_request
),
create(
:github_check_run,
app_id: 123,
- name: 'test',
+ name: "test",
started_at: 3.minutes.ago,
github_pull_request: pull_request
),
create(
:github_check_run,
app_id: 123,
- name: 'lint',
+ name: "lint",
started_at: 5.minutes.ago,
github_pull_request: pull_request
)
diff --git a/modules/github_integration/spec/spec_helper.rb b/modules/github_integration/spec/spec_helper.rb
index 11d3b4668f94..d5f21fe45533 100644
--- a/modules/github_integration/spec/spec_helper.rb
+++ b/modules/github_integration/spec/spec_helper.rb
@@ -26,6 +26,6 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].sort.each { |f| require f }
+Dir[File.join(File.dirname(__FILE__), "support/**/*.rb")].sort.each { |f| require f }
diff --git a/modules/github_integration/spec/support/pages/work_package_github_tab.rb b/modules/github_integration/spec/support/pages/work_package_github_tab.rb
index d4657329b7bd..e2d97d0affe0 100644
--- a/modules/github_integration/spec/support/pages/work_package_github_tab.rb
+++ b/modules/github_integration/spec/support/pages/work_package_github_tab.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'rbconfig'
-require 'support/pages/page'
+require "rbconfig"
+require "support/pages/page"
module Pages
class GitHubTab < Page
@@ -43,26 +43,26 @@ def path
end
def git_actions_menu_button
- find('.github-git-copy:not([disabled])', text: 'Git')
+ find(".github-git-copy:not([disabled])", text: "Git")
end
def git_actions_copy_branch_name_button
- find('.git-actions-menu .copy-button:not([disabled])', match: :first)
+ find(".git-actions-menu .copy-button:not([disabled])", match: :first)
end
def paste_clipboard_content
meta_key = osx? ? :command : :control
- page.send_keys(meta_key, 'v')
+ page.send_keys(meta_key, "v")
end
def expect_tab_not_present
- expect(page).to have_no_css('.op-tab-row--link', text: 'GITHUB')
+ expect(page).to have_no_css(".op-tab-row--link", text: "GITHUB")
end
private
def osx?
- RbConfig::CONFIG['host_os'].include?('darwin')
+ RbConfig::CONFIG["host_os"].include?("darwin")
end
end
end
diff --git a/modules/github_integration/spec/support/webhook_fixture_helpers.rb b/modules/github_integration/spec/support/webhook_fixture_helpers.rb
index bea8c36b3eb2..4fe554143d35 100644
--- a/modules/github_integration/spec/support/webhook_fixture_helpers.rb
+++ b/modules/github_integration/spec/support/webhook_fixture_helpers.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'json'
+require "json"
module WebhookFixtureHelpers
- FIXTURES_PATH = File.join(File.dirname(__FILE__), '../fixtures/github_webhooks')
+ FIXTURES_PATH = File.join(File.dirname(__FILE__), "../fixtures/github_webhooks")
# Params:
# * replacements: A `Hash` containing replacement values for placeholders in the fixture files,
diff --git a/modules/github_integration/spec/workers/cron/clear_old_pull_requests_job_spec.rb b/modules/github_integration/spec/workers/cron/clear_old_pull_requests_job_spec.rb
index beb5cc6fbbd2..62cf2d600d7a 100644
--- a/modules/github_integration/spec/workers/cron/clear_old_pull_requests_job_spec.rb
+++ b/modules/github_integration/spec/workers/cron/clear_old_pull_requests_job_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Cron::ClearOldPullRequestsJob, type: :job do
let(:pull_request_without_work_package) do
@@ -44,7 +44,7 @@
pull_request_with_work_package
end
- it 'removes pull request without work packages attached' do
+ it "removes pull request without work packages attached" do
expect { job.perform }.to change(GithubPullRequest, :count).by(-1).and(change(GithubCheckRun, :count).by(-1))
expect(GithubPullRequest.all)
diff --git a/modules/gitlab_integration/app/models/gitlab_issue.rb b/modules/gitlab_integration/app/models/gitlab_issue.rb
index 61ad3c59f112..31f5927fd21b 100644
--- a/modules/gitlab_integration/app/models/gitlab_issue.rb
+++ b/modules/gitlab_integration/app/models/gitlab_issue.rb
@@ -36,8 +36,8 @@ class GitlabIssue < ApplicationRecord
belongs_to :gitlab_user, optional: true
enum state: {
- opened: 'opened',
- closed: 'closed'
+ opened: "opened",
+ closed: "closed"
}
validates_presence_of :gitlab_html_url,
diff --git a/modules/gitlab_integration/app/models/gitlab_merge_request.rb b/modules/gitlab_integration/app/models/gitlab_merge_request.rb
index ae02a147a74a..77724d3b534b 100644
--- a/modules/gitlab_integration/app/models/gitlab_merge_request.rb
+++ b/modules/gitlab_integration/app/models/gitlab_merge_request.rb
@@ -35,12 +35,12 @@ class GitlabMergeRequest < ApplicationRecord
has_and_belongs_to_many :work_packages
has_many :gitlab_pipelines, dependent: :destroy
belongs_to :gitlab_user, optional: true
- belongs_to :merged_by, optional: true, class_name: 'GitlabUser'
+ belongs_to :merged_by, optional: true, class_name: "GitlabUser"
enum state: {
- opened: 'opened',
- merged: 'merged',
- closed: 'closed'
+ opened: "opened",
+ merged: "merged",
+ closed: "closed"
}
validates_presence_of :gitlab_html_url,
diff --git a/modules/gitlab_integration/app/models/gitlab_pipeline.rb b/modules/gitlab_integration/app/models/gitlab_pipeline.rb
index 24b4c1633122..e663c3bf8c34 100644
--- a/modules/gitlab_integration/app/models/gitlab_pipeline.rb
+++ b/modules/gitlab_integration/app/models/gitlab_pipeline.rb
@@ -34,17 +34,17 @@ class GitlabPipeline < ApplicationRecord
# TODO: confirm with the gitlab documentation what are the different statuses.
enum status: {
- created: 'created',
- running: 'running',
- success: 'success',
- waiting: 'waiting',
- preparing: 'preparing',
- failed: 'failed',
- pending: 'pending',
- canceled: 'canceled',
- skipped: 'skipped',
- manual: 'manual',
- scheduled: 'scheduled'
+ created: "created",
+ running: "running",
+ success: "success",
+ waiting: "waiting",
+ preparing: "preparing",
+ failed: "failed",
+ pending: "pending",
+ canceled: "canceled",
+ skipped: "skipped",
+ manual: "manual",
+ scheduled: "scheduled"
}
validates_presence_of :gitlab_user_avatar_url,
diff --git a/modules/gitlab_integration/db/migrate/20211015110000_gitlab_integration_models.rb b/modules/gitlab_integration/db/migrate/20211015110000_gitlab_integration_models.rb
index 847183710ae5..ef2af3f83da7 100644
--- a/modules/gitlab_integration/db/migrate/20211015110000_gitlab_integration_models.rb
+++ b/modules/gitlab_integration/db/migrate/20211015110000_gitlab_integration_models.rb
@@ -50,7 +50,7 @@ def change
end
create_join_table :gitlab_merge_requests, :work_packages do |t|
- t.index :gitlab_merge_request_id, name: 'gitlab_mr_wp_mr_id'
+ t.index :gitlab_merge_request_id, name: "gitlab_mr_wp_mr_id"
t.index %i[gitlab_merge_request_id work_package_id],
unique: true,
name: "unique_index_gl_mrs_wps_on_gl_mr_id_and_wp_id"
diff --git a/modules/gitlab_integration/db/migrate/20211015110002_add_gitlab_issues.rb b/modules/gitlab_integration/db/migrate/20211015110002_add_gitlab_issues.rb
index 6256a34212fe..e5a893195518 100644
--- a/modules/gitlab_integration/db/migrate/20211015110002_add_gitlab_issues.rb
+++ b/modules/gitlab_integration/db/migrate/20211015110002_add_gitlab_issues.rb
@@ -45,7 +45,7 @@ def change
end
create_join_table :gitlab_issues, :work_packages do |t|
- t.index :gitlab_issue_id, name: 'gitlab_issues_wp_issue_id'
+ t.index :gitlab_issue_id, name: "gitlab_issues_wp_issue_id"
t.index %i[gitlab_issue_id work_package_id],
unique: true,
name: "unique_index_gl_issues_wps_on_gl_issue_id_and_wp_id"
diff --git a/modules/gitlab_integration/lib/api/v3/gitlab_issues/gitlab_issue_representer.rb b/modules/gitlab_integration/lib/api/v3/gitlab_issues/gitlab_issue_representer.rb
index 5ed0b8dd4cca..a27aa56ed3b8 100644
--- a/modules/gitlab_integration/lib/api/v3/gitlab_issues/gitlab_issue_representer.rb
+++ b/modules/gitlab_integration/lib/api/v3/gitlab_issues/gitlab_issue_representer.rb
@@ -27,8 +27,8 @@
# See docs/COPYRIGHT.rdoc for more details.
#++
-require 'roar/decorator'
-require 'roar/json/hal'
+require "roar/decorator"
+require "roar/json/hal"
module API
module V3
@@ -80,7 +80,7 @@ def initialize(model, current_user:, **_opts)
date_time_property :updated_at
def _type
- 'GitlabIssue'
+ "GitlabIssue"
end
self.to_eager_load = %i[gitlab_user]
diff --git a/modules/gitlab_integration/lib/api/v3/gitlab_issues/gitlab_user_representer.rb b/modules/gitlab_integration/lib/api/v3/gitlab_issues/gitlab_user_representer.rb
index 535b9ddb49aa..4f2e48db0c19 100644
--- a/modules/gitlab_integration/lib/api/v3/gitlab_issues/gitlab_user_representer.rb
+++ b/modules/gitlab_integration/lib/api/v3/gitlab_issues/gitlab_user_representer.rb
@@ -27,8 +27,8 @@
# See docs/COPYRIGHT.rdoc for more details.
#++
-require 'roar/decorator'
-require 'roar/json/hal'
+require "roar/decorator"
+require "roar/json/hal"
module API
module V3
@@ -44,7 +44,7 @@ class GitlabUserRepresenter < ::API::Decorators::Single
property :gitlab_avatar_url, as: :avatarUrl
def _type
- 'GitlabUser'
+ "GitlabUser"
end
end
end
diff --git a/modules/gitlab_integration/lib/api/v3/gitlab_merge_requests/gitlab_merge_request_representer.rb b/modules/gitlab_integration/lib/api/v3/gitlab_merge_requests/gitlab_merge_request_representer.rb
index 7286b080bcfd..f9650185840c 100644
--- a/modules/gitlab_integration/lib/api/v3/gitlab_merge_requests/gitlab_merge_request_representer.rb
+++ b/modules/gitlab_integration/lib/api/v3/gitlab_merge_requests/gitlab_merge_request_representer.rb
@@ -27,8 +27,8 @@
# See docs/COPYRIGHT.rdoc for more details.
#++
-require 'roar/decorator'
-require 'roar/json/hal'
+require "roar/decorator"
+require "roar/json/hal"
module API
module V3
@@ -98,7 +98,7 @@ def initialize(model, current_user:, **_opts)
date_time_property :updated_at
def _type
- 'GitlabMergeRequest'
+ "GitlabMergeRequest"
end
self.to_eager_load = %i[gitlab_user merged_by]
diff --git a/modules/gitlab_integration/lib/api/v3/gitlab_merge_requests/gitlab_pipeline_representer.rb b/modules/gitlab_integration/lib/api/v3/gitlab_merge_requests/gitlab_pipeline_representer.rb
index a52c5700d9ca..858f816abaca 100644
--- a/modules/gitlab_integration/lib/api/v3/gitlab_merge_requests/gitlab_pipeline_representer.rb
+++ b/modules/gitlab_integration/lib/api/v3/gitlab_merge_requests/gitlab_pipeline_representer.rb
@@ -27,8 +27,8 @@
# See docs/COPYRIGHT.rdoc for more details.
#++
-require 'roar/decorator'
-require 'roar/json/hal'
+require "roar/decorator"
+require "roar/json/hal"
module API
module V3
@@ -53,7 +53,7 @@ class GitlabPipelineRepresenter < ::API::Decorators::Single
date_time_property :completed_at
def _type
- 'GitlabPipeline'
+ "GitlabPipeline"
end
end
end
diff --git a/modules/gitlab_integration/lib/api/v3/gitlab_merge_requests/gitlab_user_representer.rb b/modules/gitlab_integration/lib/api/v3/gitlab_merge_requests/gitlab_user_representer.rb
index 63ef95738b6a..361f8651f18a 100644
--- a/modules/gitlab_integration/lib/api/v3/gitlab_merge_requests/gitlab_user_representer.rb
+++ b/modules/gitlab_integration/lib/api/v3/gitlab_merge_requests/gitlab_user_representer.rb
@@ -27,8 +27,8 @@
# See docs/COPYRIGHT.rdoc for more details.
#++
-require 'roar/decorator'
-require 'roar/json/hal'
+require "roar/decorator"
+require "roar/json/hal"
module API
module V3
@@ -44,7 +44,7 @@ class GitlabUserRepresenter < ::API::Decorators::Single
property :gitlab_avatar_url, as: :avatarUrl
def _type
- 'GitlabUser'
+ "GitlabUser"
end
end
end
diff --git a/modules/gitlab_integration/lib/open_project/gitlab_integration/engine.rb b/modules/gitlab_integration/lib/open_project/gitlab_integration/engine.rb
index 71cdbf7e2fb1..48b2c0b84582 100644
--- a/modules/gitlab_integration/lib/open_project/gitlab_integration/engine.rb
+++ b/modules/gitlab_integration/lib/open_project/gitlab_integration/engine.rb
@@ -27,12 +27,12 @@
# See docs/COPYRIGHT.rdoc for more details.
#++
-require 'open_project/plugins'
+require "open_project/plugins"
-require_relative 'patches/api/work_package_representer'
-require_relative 'notification_handlers'
-require_relative 'hook_handler'
-require_relative 'services'
+require_relative "patches/api/work_package_representer"
+require_relative "notification_handlers"
+require_relative "hook_handler"
+require_relative "services"
module OpenProject::GitlabIntegration
class Engine < ::Rails::Engine
@@ -40,8 +40,8 @@ class Engine < ::Rails::Engine
include OpenProject::Plugins::ActsAsOpEngine
- register 'openproject-gitlab_integration',
- author_url: 'https://github.com/btey/openproject',
+ register "openproject-gitlab_integration",
+ author_url: "https://github.com/btey/openproject",
bundled: true do
project_module(:gitlab, dependencies: :work_package_tracking) do
permission(:show_gitlab_content,
@@ -52,24 +52,24 @@ class Engine < ::Rails::Engine
patches %w[WorkPackage]
- initializer 'gitlab.register_hook' do
- ::OpenProject::Webhooks.register_hook 'gitlab' do |hook, environment, params, user|
+ initializer "gitlab.register_hook" do
+ ::OpenProject::Webhooks.register_hook "gitlab" do |hook, environment, params, user|
HookHandler.new.process(hook, environment, params, user)
end
end
- initializer 'gitlab.subscribe_to_notifications' do
- ::OpenProject::Notifications.subscribe('gitlab.merge_request_hook',
+ initializer "gitlab.subscribe_to_notifications" do
+ ::OpenProject::Notifications.subscribe("gitlab.merge_request_hook",
&NotificationHandlers.method(:merge_request_hook))
- ::OpenProject::Notifications.subscribe('gitlab.note_hook',
+ ::OpenProject::Notifications.subscribe("gitlab.note_hook",
&NotificationHandlers.method(:note_hook))
- ::OpenProject::Notifications.subscribe('gitlab.issue_hook',
+ ::OpenProject::Notifications.subscribe("gitlab.issue_hook",
&NotificationHandlers.method(:issue_hook))
- ::OpenProject::Notifications.subscribe('gitlab.push_hook',
+ ::OpenProject::Notifications.subscribe("gitlab.push_hook",
&NotificationHandlers.method(:push_hook))
- ::OpenProject::Notifications.subscribe('gitlab.pipeline_hook',
+ ::OpenProject::Notifications.subscribe("gitlab.pipeline_hook",
&NotificationHandlers.method(:pipeline_hook))
- ::OpenProject::Notifications.subscribe('gitlab.system_hook',
+ ::OpenProject::Notifications.subscribe("gitlab.system_hook",
&NotificationHandlers.method(:system_hook))
end
@@ -92,18 +92,18 @@ class Engine < ::Rails::Engine
"gitlab_pipeline/#{id}"
end
- add_api_endpoint 'API::V3::WorkPackages::WorkPackagesAPI', :id do
+ add_api_endpoint "API::V3::WorkPackages::WorkPackagesAPI", :id do
mount ::API::V3::GitlabMergeRequests::GitlabMergeRequestsByWorkPackageAPI
end
- add_api_endpoint 'API::V3::WorkPackages::WorkPackagesAPI', :id do
+ add_api_endpoint "API::V3::WorkPackages::WorkPackagesAPI", :id do
mount ::API::V3::GitlabIssues::GitlabIssuesByWorkPackageAPI
end
add_cron_jobs do
{
- 'Cron::ClearOldMergeRequestsJob': {
- cron: '25 1 * * *', # runs at 1:25 nightly
+ "Cron::ClearOldMergeRequestsJob": {
+ cron: "25 1 * * *", # runs at 1:25 nightly
class: ::Cron::ClearOldMergeRequestsJob.name
}
}
diff --git a/modules/gitlab_integration/lib/open_project/gitlab_integration/hook_handler.rb b/modules/gitlab_integration/lib/open_project/gitlab_integration/hook_handler.rb
index 5c8900bbcbb5..8c0de711fc61 100644
--- a/modules/gitlab_integration/lib/open_project/gitlab_integration/hook_handler.rb
+++ b/modules/gitlab_integration/lib/open_project/gitlab_integration/hook_handler.rb
@@ -43,8 +43,8 @@ class HookHandler
# We need to check validity of the data and send a Notification
# which we process in our NotificationHandler.
def process(_hook, request, params, user)
- event_type = request.env['HTTP_X_GITLAB_EVENT']
- event_type.tr!(' ', '_')
+ event_type = request.env["HTTP_X_GITLAB_EVENT"]
+ event_type.tr!(" ", "_")
event_type = event_type.to_s.downcase
Rails.logger.debug { "Received gitlab webhook #{event_type}" }
@@ -55,8 +55,8 @@ def process(_hook, request, params, user)
payload = params[:payload]
.permit!
.to_h
- .merge('open_project_user_id' => user.id,
- 'gitlab_event' => event_type)
+ .merge("open_project_user_id" => user.id,
+ "gitlab_event" => event_type)
event_name = :"gitlab.#{event_type}"
OpenProject::Notifications.send(event_name, payload)
diff --git a/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/helper.rb b/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/helper.rb
index cf715d0bb69c..50b55c372330 100644
--- a/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/helper.rb
+++ b/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/helper.rb
@@ -48,9 +48,9 @@ def extract_work_package_ids(text, kind = "")
# e.g.,: This is a reference to OP#1234
# For private comments you can use the prefix: PP#
host_name = Regexp.escape(Setting.host_name)
- wp_regex = if kind == 'private'
+ wp_regex = if kind == "private"
/PP#(\d+)/
- elsif kind != 'note'
+ elsif kind != "note"
/OP#(\d+)|PP#(\d+)|http(?:s?):\/\/#{host_name}\/(?:\S+?\/)*(?:work_packages|wp)\/([0-9]+)/
else
/OP#(\d+)|http(?:s?):\/\/#{host_name}\/(?:\S+?\/)*(?:work_packages|wp)\/([0-9]+)/
@@ -84,7 +84,7 @@ def find_mentioned_work_packages(text, user, kind = "")
# Returns a list of `WorkPackage`s that were excluded in the `text`.
def find_excluded_work_packages(text, user)
- find_visible_work_packages(extract_work_package_ids(text, 'private'), user)
+ find_visible_work_packages(extract_work_package_ids(text, "private"), user)
end
##
@@ -126,7 +126,7 @@ def to_h
def method_missing(name, *args, &block)
super unless args.empty? && block.nil?
- value = if name.end_with?('?')
+ value = if name.end_with?("?")
@payload.fetch(name.to_s[..-2], nil)
else
@payload.fetch(name.to_s)
diff --git a/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/issue_hook.rb b/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/issue_hook.rb
index 53b4148f6ea2..97c77136d748 100644
--- a/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/issue_hook.rb
+++ b/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/issue_hook.rb
@@ -37,7 +37,7 @@ class IssueHook
def process(payload_params)
@payload = wrap_payload(payload_params)
user = User.find_by_id(payload.open_project_user_id)
- text = payload.object_attributes.title + ' - ' + payload.object_attributes.description
+ text = payload.object_attributes.title + " - " + payload.object_attributes.description
work_packages = find_mentioned_work_packages(text, user)
notes = generate_notes(payload)
comment_on_referenced_work_packages(work_packages, user, notes)
@@ -52,9 +52,9 @@ def generate_notes(payload)
accepted_actions = %w[open reopen close]
key_action = {
- 'open' => 'opened',
- 'reopen' => 'reopened',
- 'close' => 'closed'
+ "open" => "opened",
+ "reopen" => "reopened",
+ "close" => "closed"
}[payload.object_attributes.action]
return nil unless accepted_actions.include? payload.object_attributes.action
diff --git a/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/merge_request_hook.rb b/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/merge_request_hook.rb
index cc409d2f4c72..943a289d77fe 100644
--- a/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/merge_request_hook.rb
+++ b/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/merge_request_hook.rb
@@ -48,15 +48,15 @@ def process(payload_params)
return unless (accepted_actions.include? payload.object_attributes.action) || (accepted_states.include? payload.object_attributes.state)
user = User.find_by_id(payload.open_project_user_id)
- text = payload.object_attributes.title + ' - ' + payload.object_attributes.description
+ text = payload.object_attributes.title + " - " + payload.object_attributes.description
work_packages = find_mentioned_work_packages(text, user)
notes = generate_notes(payload)
if (accepted_actions_for_comments.include? payload.object_attributes.action) || (accepted_states.include? payload.object_attributes.state)
comment_on_referenced_work_packages(work_packages, user, notes)
- if payload.object_attributes.state == 'opened' && update_status_on_new_mr
+ if payload.object_attributes.state == "opened" && update_status_on_new_mr
status_on_referenced_work_packages(work_packages, user, wp_status_id_on_new_mr)
- elsif payload.object_attributes.state == 'merged' && update_status_on_merged
+ elsif payload.object_attributes.state == "merged" && update_status_on_merged
status_on_referenced_work_packages(work_packages, user, wp_status_id_on_merged)
end
end
@@ -69,16 +69,16 @@ def process(payload_params)
def generate_notes(payload)
key = {
- 'opened' => 'opened',
- 'reopened' => 'reopened',
- 'closed' => 'closed',
- 'merged' => 'merged',
- 'edited' => 'referenced',
- 'referenced' => 'referenced'
+ "opened" => "opened",
+ "reopened" => "reopened",
+ "closed" => "closed",
+ "merged" => "merged",
+ "edited" => "referenced",
+ "referenced" => "referenced"
}[payload.object_attributes.state]
key_action = {
- 'reopen' => 'reopened'
+ "reopen" => "reopened"
}[payload.object_attributes.action]
return nil unless key
diff --git a/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/note_hook.rb b/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/note_hook.rb
index 3bffd2683413..8a6aab36b35a 100644
--- a/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/note_hook.rb
+++ b/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/note_hook.rb
@@ -40,35 +40,35 @@ def process(payload_params)
user = User.find_by(id: payload.open_project_user_id)
text = payload.object_attributes.note
work_packages = find_mentioned_work_packages(text, user, payload.object_kind)
- if work_packages.empty? && payload.object_attributes.noteable_type == 'Issue'
+ if work_packages.empty? && payload.object_attributes.noteable_type == "Issue"
text = "#{payload.issue.title} - #{payload.object_attributes.note}"
work_packages = find_mentioned_work_packages(text, user, payload.object_kind)
work_packages_excluded = find_excluded_work_packages(text, user)
work_packages = work_packages - work_packages_excluded unless work_packages_excluded.empty?
return if work_packages.empty?
- notes = generate_notes(payload, 'comment')
- elsif work_packages.empty? && payload.object_attributes.noteable_type == 'Snippet'
+ notes = generate_notes(payload, "comment")
+ elsif work_packages.empty? && payload.object_attributes.noteable_type == "Snippet"
text = "#{payload.snippet.title} - #{payload.object_attributes.note}"
work_packages = find_mentioned_work_packages(text, user, payload.object_kind)
work_packages_excluded = find_excluded_work_packages(text, user)
work_packages = work_packages - work_packages_excluded unless work_packages_excluded.empty?
return if work_packages.empty?
- notes = generate_notes(payload, 'reference')
- elsif work_packages.empty? && payload.object_attributes.noteable_type == 'MergeRequest'
+ notes = generate_notes(payload, "reference")
+ elsif work_packages.empty? && payload.object_attributes.noteable_type == "MergeRequest"
text = "#{payload.merge_request.title} - #{payload.object_attributes.note}"
work_packages = find_mentioned_work_packages(text, user, payload.object_kind)
work_packages_excluded = find_excluded_work_packages(text, user)
work_packages = work_packages - work_packages_excluded unless work_packages_excluded.empty?
return if work_packages.empty?
- notes = generate_notes(payload, 'comment')
+ notes = generate_notes(payload, "comment")
else
- notes = generate_notes(payload, 'reference')
+ notes = generate_notes(payload, "reference")
end
comment_on_referenced_work_packages(work_packages, user, notes)
- if payload.object_attributes.noteable_type == 'Issue'
+ if payload.object_attributes.noteable_type == "Issue"
upsert_issue(work_packages)
end
end
@@ -80,7 +80,7 @@ def process(payload_params)
# TODO: add key list to simplify the code...
def generate_notes(payload, note_type)
case payload.object_attributes.noteable_type
- when 'Commit'
+ when "Commit"
commit_id = payload.commit.id
I18n.t("gitlab_integration.note_commit_referenced_comment",
commit_id: commit_id[0, 8],
@@ -90,8 +90,8 @@ def generate_notes(payload, note_type)
repository_url: payload.repository.homepage,
gitlab_user: payload.user.name,
gitlab_user_url: payload.user.avatar_url)
- when 'MergeRequest'
- if note_type == 'comment'
+ when "MergeRequest"
+ if note_type == "comment"
I18n.t("gitlab_integration.note_mr_commented_comment",
mr_number: payload.merge_request.iid,
mr_title: payload.merge_request.title,
@@ -101,7 +101,7 @@ def generate_notes(payload, note_type)
repository_url: payload.repository.homepage,
gitlab_user: payload.user.name,
gitlab_user_url: payload.user.avatar_url)
- elsif note_type == 'reference'
+ elsif note_type == "reference"
I18n.t("gitlab_integration.note_mr_referenced_comment",
mr_number: payload.merge_request.iid,
mr_title: payload.merge_request.title,
@@ -112,8 +112,8 @@ def generate_notes(payload, note_type)
gitlab_user: payload.user.name,
gitlab_user_url: payload.user.avatar_url)
end
- when 'Issue'
- if note_type == 'comment'
+ when "Issue"
+ if note_type == "comment"
I18n.t("gitlab_integration.note_issue_commented_comment",
issue_number: payload.issue.iid,
issue_title: payload.issue.title,
@@ -123,7 +123,7 @@ def generate_notes(payload, note_type)
repository_url: payload.repository.homepage,
gitlab_user: payload.user.name,
gitlab_user_url: payload.user.avatar_url)
- elsif note_type == 'reference'
+ elsif note_type == "reference"
I18n.t("gitlab_integration.note_issue_referenced_comment",
issue_number: payload.issue.iid,
issue_title: payload.issue.title,
@@ -134,7 +134,7 @@ def generate_notes(payload, note_type)
gitlab_user: payload.user.name,
gitlab_user_url: payload.user.avatar_url)
end
- when 'Snippet'
+ when "Snippet"
I18n.t("gitlab_integration.note_snippet_referenced_comment",
snippet_number: payload.snippet.id,
snippet_title: payload.snippet.title,
diff --git a/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/push_hook.rb b/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/push_hook.rb
index 772b8e625625..5a8ea57ea41f 100644
--- a/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/push_hook.rb
+++ b/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/push_hook.rb
@@ -36,11 +36,11 @@ class PushHook
def process(payload_params)
@payload = wrap_payload(payload_params)
- return nil unless payload.object_kind == 'push'
+ return nil unless payload.object_kind == "push"
payload.commits.each do |commit|
user = User.find_by_id(payload.open_project_user_id)
- text = commit['title'] + " - " + commit['message']
+ text = commit["title"] + " - " + commit["message"]
work_packages = find_mentioned_work_packages(text, user)
notes = generate_notes(commit, payload)
comment_on_referenced_work_packages(work_packages, user, notes)
@@ -52,12 +52,12 @@ def process(payload_params)
attr_reader :payload
def generate_notes(commit, payload)
- commit_id = commit['id']
+ commit_id = commit["id"]
I18n.t("gitlab_integration.push_single_commit_comment",
commit_number: commit_id[0, 8],
- commit_note: commit['message'],
- commit_url: commit['url'],
- commit_timestamp: commit['timestamp'],
+ commit_note: commit["message"],
+ commit_url: commit["url"],
+ commit_timestamp: commit["timestamp"],
repository: payload.repository.name,
repository_url: payload.repository.homepage,
gitlab_user: payload.user_name,
diff --git a/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/system_hook.rb b/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/system_hook.rb
index 72a56f1fb63d..5e91993c0f4d 100644
--- a/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/system_hook.rb
+++ b/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handler/system_hook.rb
@@ -36,11 +36,11 @@ class SystemHook
def process(payload_params)
@payload = wrap_payload(payload_params)
- return nil unless payload.object_kind == 'push'
+ return nil unless payload.object_kind == "push"
payload.commits.each do |commit|
user = User.find_by_id(payload.open_project_user_id)
- text = commit['title'] + " - " + commit['message']
+ text = commit["title"] + " - " + commit["message"]
work_packages = find_mentioned_work_packages(text, user)
notes = generate_notes(commit, payload)
comment_on_referenced_work_packages(work_packages, user, notes)
@@ -52,12 +52,12 @@ def process(payload_params)
attr_reader :payload
def generate_notes(commit, payload)
- commit_id = commit['id']
+ commit_id = commit["id"]
I18n.t("gitlab_integration.push_single_commit_comment",
commit_number: commit_id[0, 8],
- commit_note: commit['message'],
- commit_url: commit['url'],
- commit_timestamp: commit['timestamp'],
+ commit_note: commit["message"],
+ commit_url: commit["url"],
+ commit_timestamp: commit["timestamp"],
repository: payload.repository.name,
repository_url: payload.repository.homepage,
gitlab_user: payload.user_name,
diff --git a/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handlers.rb b/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handlers.rb
index e157bbddf651..5492be055cb9 100644
--- a/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handlers.rb
+++ b/modules/gitlab_integration/lib/open_project/gitlab_integration/notification_handlers.rb
@@ -27,12 +27,12 @@
# See docs/COPYRIGHT.rdoc for more details.
#++
-require_relative 'notification_handler/helper'
-require_relative 'notification_handler/issue_hook'
-require_relative 'notification_handler/merge_request_hook'
-require_relative 'notification_handler/note_hook'
-require_relative 'notification_handler/push_hook'
-require_relative 'notification_handler/system_hook'
+require_relative "notification_handler/helper"
+require_relative "notification_handler/issue_hook"
+require_relative "notification_handler/merge_request_hook"
+require_relative "notification_handler/note_hook"
+require_relative "notification_handler/push_hook"
+require_relative "notification_handler/system_hook"
module OpenProject::GitlabIntegration
##
@@ -40,37 +40,37 @@ module OpenProject::GitlabIntegration
module NotificationHandlers
class << self
def merge_request_hook(payload)
- with_logging('merge_request_hook') do
+ with_logging("merge_request_hook") do
OpenProject::GitlabIntegration::NotificationHandler::MergeRequestHook.new.process(payload)
end
end
def note_hook(payload)
- with_logging('note_hook') do
+ with_logging("note_hook") do
OpenProject::GitlabIntegration::NotificationHandler::NoteHook.new.process(payload)
end
end
def push_hook(payload)
- with_logging('push_hook') do
+ with_logging("push_hook") do
OpenProject::GitlabIntegration::NotificationHandler::PushHook.new.process(payload)
end
end
def issue_hook(payload)
- with_logging('issue_hook') do
+ with_logging("issue_hook") do
OpenProject::GitlabIntegration::NotificationHandler::IssueHook.new.process(payload)
end
end
def pipeline_hook(payload)
- with_logging('pipeline_hook') do
+ with_logging("pipeline_hook") do
OpenProject::GitlabIntegration::NotificationHandler::PipelineHook.new.process(payload)
end
end
def system_hook(payload)
- with_logging('system_hook') do
+ with_logging("system_hook") do
OpenProject::GitlabIntegration::NotificationHandler::SystemHook.new.process(payload)
end
end
diff --git a/modules/gitlab_integration/lib/open_project/gitlab_integration/services.rb b/modules/gitlab_integration/lib/open_project/gitlab_integration/services.rb
index ea44e1735213..f8e9d5526fc2 100644
--- a/modules/gitlab_integration/lib/open_project/gitlab_integration/services.rb
+++ b/modules/gitlab_integration/lib/open_project/gitlab_integration/services.rb
@@ -27,7 +27,7 @@
# See docs/COPYRIGHT.rdoc for more details.
#++
-require_relative 'services/params_helper'
-require_relative 'services/upsert_pipeline'
-require_relative 'services/upsert_gitlab_user'
-require_relative 'services/upsert_merge_request'
+require_relative "services/params_helper"
+require_relative "services/upsert_pipeline"
+require_relative "services/upsert_gitlab_user"
+require_relative "services/upsert_merge_request"
diff --git a/modules/gitlab_integration/lib/open_project/gitlab_integration/services/params_helper.rb b/modules/gitlab_integration/lib/open_project/gitlab_integration/services/params_helper.rb
index ef7a9355c03e..0769492f72b1 100644
--- a/modules/gitlab_integration/lib/open_project/gitlab_integration/services/params_helper.rb
+++ b/modules/gitlab_integration/lib/open_project/gitlab_integration/services/params_helper.rb
@@ -34,8 +34,8 @@ module Services
module ParamsHelper
private
- EMPTY_AVATAR_URL = 'https://www.gravatar.com/avatar/?d=mp'
- EMPTY_DESCRIPTION = 'No description provided'
+ EMPTY_AVATAR_URL = "https://www.gravatar.com/avatar/?d=mp"
+ EMPTY_DESCRIPTION = "No description provided"
def avatar_url(raw_url)
raw_url.presence || EMPTY_AVATAR_URL
diff --git a/modules/gitlab_integration/lib/open_project/gitlab_integration/services/upsert_issue.rb b/modules/gitlab_integration/lib/open_project/gitlab_integration/services/upsert_issue.rb
index 6eb2298d5f9c..5d70838cb1ff 100644
--- a/modules/gitlab_integration/lib/open_project/gitlab_integration/services/upsert_issue.rb
+++ b/modules/gitlab_integration/lib/open_project/gitlab_integration/services/upsert_issue.rb
@@ -69,8 +69,8 @@ def extract_params(payload)
def extract_label_values(payload)
{
- title: payload['title'],
- color: payload['color']
+ title: payload["title"],
+ color: payload["color"]
}
end
diff --git a/modules/gitlab_integration/lib/open_project/gitlab_integration/services/upsert_issue_note.rb b/modules/gitlab_integration/lib/open_project/gitlab_integration/services/upsert_issue_note.rb
index eb58b8e83e33..8516896740b2 100644
--- a/modules/gitlab_integration/lib/open_project/gitlab_integration/services/upsert_issue_note.rb
+++ b/modules/gitlab_integration/lib/open_project/gitlab_integration/services/upsert_issue_note.rb
@@ -69,8 +69,8 @@ def extract_params(payload)
def extract_label_values(payload)
{
- title: payload['title'],
- color: payload['color']
+ title: payload["title"],
+ color: payload["color"]
}
end
diff --git a/modules/gitlab_integration/lib/open_project/gitlab_integration/services/upsert_merge_request.rb b/modules/gitlab_integration/lib/open_project/gitlab_integration/services/upsert_merge_request.rb
index 78c8c0ccfa00..d81edc88e7dd 100644
--- a/modules/gitlab_integration/lib/open_project/gitlab_integration/services/upsert_merge_request.rb
+++ b/modules/gitlab_integration/lib/open_project/gitlab_integration/services/upsert_merge_request.rb
@@ -63,9 +63,9 @@ def extract_params(payload)
body: description(payload.object_attributes.description),
repository: payload.repository.name,
draft: payload.object_attributes.work_in_progress,
- merged: payload.object_attributes.state == 'merged',
+ merged: payload.object_attributes.state == "merged",
merged_by: gitlab_user_id(payload.user),
- merged_at: payload.object_attributes.state == 'merged' ? payload.object_attributes.updated_at : nil,
+ merged_at: payload.object_attributes.state == "merged" ? payload.object_attributes.updated_at : nil,
labels: payload.labels.map { |values| extract_label_values(values) }
}
end
@@ -73,8 +73,8 @@ def extract_params(payload)
def extract_label_values(payload)
{
- title: payload['title'],
- color: payload['color']
+ title: payload["title"],
+ color: payload["color"]
}
end
diff --git a/modules/gitlab_integration/lib/openproject-gitlab_integration.rb b/modules/gitlab_integration/lib/openproject-gitlab_integration.rb
index 146bd94ac4ef..e7499bfa3211 100644
--- a/modules/gitlab_integration/lib/openproject-gitlab_integration.rb
+++ b/modules/gitlab_integration/lib/openproject-gitlab_integration.rb
@@ -27,4 +27,4 @@
# See docs/COPYRIGHT.rdoc for more details.
#++
-require 'open_project/gitlab_integration'
+require "open_project/gitlab_integration"
diff --git a/modules/gitlab_integration/openproject-gitlab_integration.gemspec b/modules/gitlab_integration/openproject-gitlab_integration.gemspec
index 11f7f31bebe8..2bc97fd50061 100644
--- a/modules/gitlab_integration/openproject-gitlab_integration.gemspec
+++ b/modules/gitlab_integration/openproject-gitlab_integration.gemspec
@@ -31,17 +31,17 @@
#++
Gem::Specification.new do |s|
- s.name = 'openproject-gitlab_integration'
- s.version = '3.0.0'
- s.authors = 'OpenProject GmbH, Ben Tey'
+ s.name = "openproject-gitlab_integration"
+ s.version = "3.0.0"
+ s.authors = "OpenProject GmbH, Ben Tey"
s.email = "info@openproject.com"
s.homepage = "https://www.openproject.org/docs/system-admin-guide/integrations/gitlab-integration/"
- s.summary = 'OpenProject GitLab Integration'
- s.description = 'Integrates OpenProject and GitLab for a better workflow'
- s.license = 'GPLv3'
+ s.summary = "OpenProject GitLab Integration"
+ s.description = "Integrates OpenProject and GitLab for a better workflow"
+ s.license = "GPLv3"
- s.files = Dir['{app,config,db,frontend,lib}/**/*'] + %w[README.md]
+ s.files = Dir["{app,config,db,frontend,lib}/**/*"] + %w[README.md]
- s.add_dependency 'openproject-webhooks'
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.add_dependency "openproject-webhooks"
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/gitlab_integration/spec/factories/gitlab_issues.rb b/modules/gitlab_integration/spec/factories/gitlab_issues.rb
index 46516f3481f1..663d77eee093 100644
--- a/modules/gitlab_integration/spec/factories/gitlab_issues.rb
+++ b/modules/gitlab_integration/spec/factories/gitlab_issues.rb
@@ -32,7 +32,7 @@
sequence(:number)
sequence(:gitlab_id)
- state { 'opened' }
+ state { "opened" }
gitlab_html_url { "https://gitlab.com/test_user/test_repo/issues/#{number}" }
labels { [] }
@@ -46,11 +46,11 @@
end
trait :open do
- state { 'opened' }
+ state { "opened" }
end
trait :closed do
- state { 'closed' }
+ state { "closed" }
end
end
end
diff --git a/modules/gitlab_integration/spec/factories/gitlab_merge_requests.rb b/modules/gitlab_integration/spec/factories/gitlab_merge_requests.rb
index d8a137fde4cb..0a35a33ba3fc 100644
--- a/modules/gitlab_integration/spec/factories/gitlab_merge_requests.rb
+++ b/modules/gitlab_integration/spec/factories/gitlab_merge_requests.rb
@@ -32,7 +32,7 @@
sequence(:number)
sequence(:gitlab_id)
- state { 'opened' }
+ state { "opened" }
gitlab_html_url { "https://gitlab.com/test_user/test_repo/merge/#{number}" }
labels { [] }
@@ -57,11 +57,11 @@
trait :open
trait :closed_unmerged do
- state { 'closed' }
+ state { "closed" }
end
trait :closed_merged do
- state { 'merged' }
+ state { "merged" }
merged { true }
merged_by { association :gitlab_user }
merged_at { Time.current }
diff --git a/modules/gitlab_integration/spec/factories/gitlab_pipelines.rb b/modules/gitlab_integration/spec/factories/gitlab_pipelines.rb
index 523c03721f57..ea626aa24796 100644
--- a/modules/gitlab_integration/spec/factories/gitlab_pipelines.rb
+++ b/modules/gitlab_integration/spec/factories/gitlab_pipelines.rb
@@ -38,7 +38,7 @@
details_url { "https://gitlab.com/test_user/test_repo/commit/#{commit_id}" }
gitlab_html_url { "https://gitlab.com/test_user/test_repo/pipelines/#{gitlab_id}" }
gitlab_user_avatar_url { "https://www.gravatar.com/avatar/#{gitlab_id}/owner.jpg" }
- status { 'pending' }
+ status { "pending" }
started_at { 1.hour.ago }
completed_at { nil }
project_id { 1 }
@@ -48,7 +48,7 @@
end
trait :complete do
- status { 'success' }
+ status { "success" }
completed_at { 1.minute.ago }
end
@@ -61,14 +61,14 @@
end
end
- factory :gitlab_pipeline_ci_detail, class: 'Hash' do
+ factory :gitlab_pipeline_ci_detail, class: "Hash" do
skip_create
initialize_with { attributes }
stage { %w[test build deploy].sample }
sequence(:name) { |n| "job_#{n}" }
- status { 'success' }
+ status { "success" }
started_at { 1.hour.ago }
created_at { started_at }
finished_at { nil }
diff --git a/modules/gitlab_integration/spec/features/work_package_gitlab_issue_activity_spec.rb b/modules/gitlab_integration/spec/features/work_package_gitlab_issue_activity_spec.rb
index 536e5ecfc622..858596c24570 100644
--- a/modules/gitlab_integration/spec/features/work_package_gitlab_issue_activity_spec.rb
+++ b/modules/gitlab_integration/spec/features/work_package_gitlab_issue_activity_spec.rb
@@ -1,19 +1,19 @@
# frozen_string_literal: true
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work Package Activity Tab',
- 'Comments by Gitlab',
+RSpec.describe "Work Package Activity Tab",
+ "Comments by Gitlab",
:js,
:with_cuprite do
- shared_let(:gitlab_system_user) { create(:admin, firstname: 'Gitlab', lastname: 'System User') }
+ shared_let(:gitlab_system_user) { create(:admin, firstname: "Gitlab", lastname: "System User") }
shared_let(:admin) { create(:admin) }
shared_let(:project) { create(:project, enabled_module_names: Setting.default_projects_modules + %w[activity]) }
shared_let(:work_package) { create(:work_package, project:) }
- shared_let(:issue_author) { create(:gitlab_user, gitlab_username: 'i_am_the_author') }
- shared_let(:issue_closing_user) { create(:gitlab_user, gitlab_username: 'i_closed') }
+ shared_let(:issue_author) { create(:gitlab_user, gitlab_username: "i_am_the_author") }
+ shared_let(:issue_closing_user) { create(:gitlab_user, gitlab_username: "i_closed") }
shared_let(:issue) do
create(:gitlab_issue,
@@ -28,51 +28,51 @@ def trigger_issue_action
end
let(:mr_description) { "Mentioning OP##{work_package.id}" }
- let(:gitlab_action) { 'close' }
- let(:issue_state) { 'closed' }
+ let(:gitlab_action) { "close" }
+ let(:issue_state) { "closed" }
let(:labels) { [] }
let(:payload) do
{
- 'open_project_user_id' => gitlab_system_user.id,
- 'object_kind' => "issue",
- 'event_type' => "issue",
- 'user' => {
- 'id' => issue_closing_user.gitlab_id,
- 'name' => issue_closing_user.gitlab_name,
- 'username' => issue_closing_user.gitlab_username,
- 'avatar_url' => issue_closing_user.gitlab_avatar_url,
- 'email' => issue_closing_user.gitlab_email
+ "open_project_user_id" => gitlab_system_user.id,
+ "object_kind" => "issue",
+ "event_type" => "issue",
+ "user" => {
+ "id" => issue_closing_user.gitlab_id,
+ "name" => issue_closing_user.gitlab_name,
+ "username" => issue_closing_user.gitlab_username,
+ "avatar_url" => issue_closing_user.gitlab_avatar_url,
+ "email" => issue_closing_user.gitlab_email
},
- 'object_attributes' => {
- 'action' => gitlab_action,
- 'assignee_id' => nil,
- 'author_id' => 1,
- 'created_at' => '2024-03-04 16:09:08 UTC',
- 'title' => 'An Issue title',
- 'description' => mr_description,
- 'draft' => false,
- 'work_in_progress' => false,
- 'state' => issue_state,
- 'id' => issue.gitlab_id,
- 'iid' => issue.gitlab_id,
- 'head_pipeline_id' => nil,
- 'url' => 'http://79dfcd98b723/root/hot_do/-/issues/4',
- 'updated_at' => Time.current.iso8601
+ "object_attributes" => {
+ "action" => gitlab_action,
+ "assignee_id" => nil,
+ "author_id" => 1,
+ "created_at" => "2024-03-04 16:09:08 UTC",
+ "title" => "An Issue title",
+ "description" => mr_description,
+ "draft" => false,
+ "work_in_progress" => false,
+ "state" => issue_state,
+ "id" => issue.gitlab_id,
+ "iid" => issue.gitlab_id,
+ "head_pipeline_id" => nil,
+ "url" => "http://79dfcd98b723/root/hot_do/-/issues/4",
+ "updated_at" => Time.current.iso8601
},
- 'labels' => labels,
- 'repository' => {
- 'name' => "Hot Do",
- 'url' => "git@79dfcd98b723:root/hot_do.git",
- 'description' => nil,
- 'homepage' => 'http://79dfcd98b723/root/hot_do/-/issues/4'
+ "labels" => labels,
+ "repository" => {
+ "name" => "Hot Do",
+ "url" => "git@79dfcd98b723:root/hot_do.git",
+ "description" => nil,
+ "homepage" => "http://79dfcd98b723/root/hot_do/-/issues/4"
}
}
end
let(:work_package_page) { Pages::SplitWorkPackage.new(work_package, project) }
- context 'when there is an issue event' do
+ context "when there is an issue event" do
before do
trigger_issue_action
login_as admin
@@ -80,7 +80,7 @@ def trigger_issue_action
context "and I visit the work package's activity tab" do
before do
- work_package_page.visit_tab! 'activity'
+ work_package_page.visit_tab! "activity"
work_package_page.ensure_page_loaded
end
@@ -89,8 +89,8 @@ def trigger_issue_action
"has been closed by #{issue_closing_user.gitlab_name}."
end
- it 'renders a comment referencing the issue' do
- expect(page).to have_css('.user-comment > .message', text: expected_comment)
+ it "renders a comment referencing the issue" do
+ expect(page).to have_css(".user-comment > .message", text: expected_comment)
end
end
end
diff --git a/modules/gitlab_integration/spec/features/work_package_gitlab_merge_request_activity_spec.rb b/modules/gitlab_integration/spec/features/work_package_gitlab_merge_request_activity_spec.rb
index c018ba365879..76ec3815e85a 100644
--- a/modules/gitlab_integration/spec/features/work_package_gitlab_merge_request_activity_spec.rb
+++ b/modules/gitlab_integration/spec/features/work_package_gitlab_merge_request_activity_spec.rb
@@ -1,19 +1,19 @@
# frozen_string_literal: true
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work Package Activity Tab',
- 'Comments by Gitlab',
+RSpec.describe "Work Package Activity Tab",
+ "Comments by Gitlab",
:js,
:with_cuprite do
- shared_let(:gitlab_system_user) { create(:admin, firstname: 'Gitlab', lastname: 'System User') }
+ shared_let(:gitlab_system_user) { create(:admin, firstname: "Gitlab", lastname: "System User") }
shared_let(:admin) { create(:admin) }
shared_let(:project) { create(:project, enabled_module_names: Setting.default_projects_modules + %w[activity]) }
shared_let(:work_package) { create(:work_package, project:) }
- shared_let(:merge_request_author) { create(:gitlab_user, gitlab_username: 'i_am_the_author') }
- shared_let(:merge_request_merging_user) { create(:gitlab_user, gitlab_username: 'i_merged') }
+ shared_let(:merge_request_author) { create(:gitlab_user, gitlab_username: "i_am_the_author") }
+ shared_let(:merge_request_merging_user) { create(:gitlab_user, gitlab_username: "i_merged") }
shared_let(:merge_request) do
create(:gitlab_merge_request,
gitlab_user: merge_request_author)
@@ -27,51 +27,51 @@ def trigger_merge_request_action
end
let(:mr_description) { "Mentioning OP##{work_package.id}" }
- let(:gitlab_action) { 'merge' }
- let(:mr_state) { 'merged' }
+ let(:gitlab_action) { "merge" }
+ let(:mr_state) { "merged" }
let(:mr_draft) { false }
let(:payload) do
{
- 'open_project_user_id' => gitlab_system_user.id,
- 'object_kind' => "merge_request",
- 'event_type' => "merge_request",
- 'user' => {
- 'id' => merge_request_merging_user.gitlab_id,
- 'name' => merge_request_merging_user.gitlab_name,
- 'username' => merge_request_merging_user.gitlab_username,
- 'avatar_url' => merge_request_merging_user.gitlab_avatar_url,
- 'email' => merge_request_merging_user.gitlab_email
+ "open_project_user_id" => gitlab_system_user.id,
+ "object_kind" => "merge_request",
+ "event_type" => "merge_request",
+ "user" => {
+ "id" => merge_request_merging_user.gitlab_id,
+ "name" => merge_request_merging_user.gitlab_name,
+ "username" => merge_request_merging_user.gitlab_username,
+ "avatar_url" => merge_request_merging_user.gitlab_avatar_url,
+ "email" => merge_request_merging_user.gitlab_email
},
- 'object_attributes' => {
- 'action' => gitlab_action,
- 'assignee_id' => nil,
- 'author_id' => 1,
- 'created_at' => '2024-03-04 16:09:08 UTC',
- 'title' => 'A MR title',
- 'description' => mr_description,
- 'draft' => mr_draft,
- 'work_in_progress' => mr_draft,
- 'state' => mr_state,
- 'head_pipeline_id' => nil,
- 'id' => merge_request.gitlab_id,
- 'iid' => merge_request.gitlab_id,
- 'url' => 'http://79dfcd98b723/root/hot_do/-/merge_requests/4',
- 'updated_at' => Time.current.iso8601
+ "object_attributes" => {
+ "action" => gitlab_action,
+ "assignee_id" => nil,
+ "author_id" => 1,
+ "created_at" => "2024-03-04 16:09:08 UTC",
+ "title" => "A MR title",
+ "description" => mr_description,
+ "draft" => mr_draft,
+ "work_in_progress" => mr_draft,
+ "state" => mr_state,
+ "head_pipeline_id" => nil,
+ "id" => merge_request.gitlab_id,
+ "iid" => merge_request.gitlab_id,
+ "url" => "http://79dfcd98b723/root/hot_do/-/merge_requests/4",
+ "updated_at" => Time.current.iso8601
},
- 'labels' => [],
- 'repository' => {
- 'name' => "Hot Do",
- 'url' => "git@79dfcd98b723:root/hot_do.git",
- 'description' => nil,
- 'homepage' => 'http://79dfcd98b723/root/hot_do/-/merge_requests/4'
+ "labels" => [],
+ "repository" => {
+ "name" => "Hot Do",
+ "url" => "git@79dfcd98b723:root/hot_do.git",
+ "description" => nil,
+ "homepage" => "http://79dfcd98b723/root/hot_do/-/merge_requests/4"
}
}
end
let(:work_package_page) { Pages::SplitWorkPackage.new(work_package, project) }
- context 'when there is a merge request event' do
+ context "when there is a merge request event" do
before do
trigger_merge_request_action
login_as admin
@@ -79,7 +79,7 @@ def trigger_merge_request_action
context "and I visit the work package's activity tab" do
before do
- work_package_page.visit_tab! 'activity'
+ work_package_page.visit_tab! "activity"
work_package_page.ensure_page_loaded
end
@@ -89,8 +89,8 @@ def trigger_merge_request_action
"#{merge_request_merging_user.gitlab_name}."
end
- it 'renders a comment referencing the Merge Request' do
- expect(page).to have_css('.user-comment > .message', text: expected_comment)
+ it "renders a comment referencing the Merge Request" do
+ expect(page).to have_css(".user-comment > .message", text: expected_comment)
end
end
end
diff --git a/modules/gitlab_integration/spec/features/work_package_gitlab_tab_spec.rb b/modules/gitlab_integration/spec/features/work_package_gitlab_tab_spec.rb
index dc9d8f35015c..60ad20ef554b 100644
--- a/modules/gitlab_integration/spec/features/work_package_gitlab_tab_spec.rb
+++ b/modules/gitlab_integration/spec/features/work_package_gitlab_tab_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require_relative '../support/pages/work_package_gitlab_tab'
+require_relative "../support/pages/work_package_gitlab_tab"
-RSpec.describe 'Open the Gitlab tab', :js do
+RSpec.describe "Open the Gitlab tab", :js do
let(:user) { create(:user, member_with_roles: { project => role }) }
let(:role) do
@@ -45,17 +45,17 @@
enabled_module_names: %i[work_package_tracking gitlab])
end
- let(:work_package) { create(:work_package, project:, subject: 'A test work_package') }
+ let(:work_package) { create(:work_package, project:, subject: "A test work_package") }
let(:tabs) { Components::WorkPackages::Tabs.new(work_package) }
- let(:gitlab_tab_element) { find('.op-tab-row--link_selected', text: 'GITLAB') }
+ let(:gitlab_tab_element) { find(".op-tab-row--link_selected", text: "GITLAB") }
let(:gitlab_tab) { Pages::GitlabTab.new(work_package.id) }
- let(:issue) { create(:gitlab_issue, :open, work_packages: [work_package], title: 'A Test Issue title') }
- let(:merge_request) { create(:gitlab_merge_request, :open, work_packages: [work_package], title: 'A Test MR title') }
+ let(:issue) { create(:gitlab_issue, :open, work_packages: [work_package], title: "A Test Issue title") }
+ let(:merge_request) { create(:gitlab_merge_request, :open, work_packages: [work_package], title: "A Test MR title") }
let(:pipeline) do
- create(:gitlab_pipeline, gitlab_merge_request: merge_request, name: 'a pipeline name')
+ create(:gitlab_pipeline, gitlab_merge_request: merge_request, name: "a pipeline name")
end
shared_examples_for "a gitlab tab" do
@@ -68,72 +68,72 @@
# compares the clipboard content by drafting a new comment, pressing ctrl+v and
# comparing the pasted content against the provided text
def expect_clipboard_content(text)
- work_package_page.switch_to_tab(tab: 'activity')
+ work_package_page.switch_to_tab(tab: "activity")
work_package_page.trigger_edit_comment
- work_package_page.update_comment(' ') # ensure the comment editor is fully loaded
+ work_package_page.update_comment(" ") # ensure the comment editor is fully loaded
gitlab_tab.paste_clipboard_content
expect(work_package_page.add_comment_container).to have_content(text)
- work_package_page.switch_to_tab(tab: 'gitlab')
+ work_package_page.switch_to_tab(tab: "gitlab")
end
- it 'shows the gitlab tab when the user is allowed to see it' do
+ it "shows the gitlab tab when the user is allowed to see it" do
work_package_page.visit!
- work_package_page.switch_to_tab(tab: 'gitlab')
+ work_package_page.switch_to_tab(tab: "gitlab")
tabs.expect_counter(gitlab_tab_element, 2)
gitlab_tab.git_actions_menu_button.click
gitlab_tab.git_actions_copy_branch_name_button.click
- expect(page).to have_text('Copied!')
+ expect(page).to have_text("Copied!")
expect_clipboard_content("#{work_package.type.name.downcase}/#{work_package.id}-a-test-work_package")
- expect(page).to have_text('A Test Issue title')
- expect(page).to have_text('Open')
+ expect(page).to have_text("A Test Issue title")
+ expect(page).to have_text("Open")
- expect(page).to have_text('A Test MR title')
- expect(page).to have_text('Pending')
+ expect(page).to have_text("A Test MR title")
+ expect(page).to have_text("Pending")
end
- context 'when there are no merge requests or issues' do
+ context "when there are no merge requests or issues" do
let(:pipeline) { nil }
let(:merge_request) { nil }
let(:issue) { nil }
- it 'shows the gitlab tab with an empty message' do
+ it "shows the gitlab tab with an empty message" do
work_package_page.visit!
- work_package_page.switch_to_tab(tab: 'gitlab')
+ work_package_page.switch_to_tab(tab: "gitlab")
tabs.expect_no_counter(gitlab_tab_element)
- expect(page).to have_content('There are no issues linked yet.')
+ expect(page).to have_content("There are no issues linked yet.")
expect(page).to have_content("Link an existing issue by using the code OP##{work_package.id} " \
"(or PP##{work_package.id} for private links) in the issue title/description " \
"or create a new issue")
- expect(page).to have_content('There are no merge requests')
+ expect(page).to have_content("There are no merge requests")
expect(page).to have_content("Link an existing MR by using the code OP##{work_package.id}")
end
end
- context 'when the user does not have the permissions to see the gitlab tab' do
+ context "when the user does not have the permissions to see the gitlab tab" do
let(:role) do
create(:project_role,
permissions: %i(view_work_packages
add_work_package_notes))
end
- it 'does not show the gitlab tab' do
+ it "does not show the gitlab tab" do
work_package_page.visit!
gitlab_tab.expect_tab_not_present
end
end
- context 'when the gitlab integration is not enabled for the project' do
- let(:project) { create(:project, disable_modules: 'gitlab') }
+ context "when the gitlab integration is not enabled for the project" do
+ let(:project) { create(:project, disable_modules: "gitlab") }
- it 'does not show the gitlab tab' do
+ it "does not show the gitlab tab" do
work_package_page.visit!
gitlab_tab.expect_tab_not_present
@@ -141,15 +141,15 @@ def expect_clipboard_content(text)
end
end
- describe 'work package full view' do
+ describe "work package full view" do
let(:work_package_page) { Pages::FullWorkPackage.new(work_package) }
- it_behaves_like 'a gitlab tab'
+ it_behaves_like "a gitlab tab"
end
- describe 'work package split view' do
+ describe "work package split view" do
let(:work_package_page) { Pages::SplitWorkPackage.new(work_package) }
- it_behaves_like 'a gitlab tab'
+ it_behaves_like "a gitlab tab"
end
end
diff --git a/modules/gitlab_integration/spec/lib/api/v3/gitlab_issues/gitlab_issue_representer_spec.rb b/modules/gitlab_integration/spec/lib/api/v3/gitlab_issues/gitlab_issue_representer_spec.rb
index 2abdb7603681..07a0bfdf9471 100644
--- a/modules/gitlab_integration/spec/lib/api/v3/gitlab_issues/gitlab_issue_representer_spec.rb
+++ b/modules/gitlab_integration/spec/lib/api/v3/gitlab_issues/gitlab_issue_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe API::V3::GitlabIssues::GitlabIssueRepresenter do
@@ -36,15 +36,15 @@
let(:gitlab_issue) do
build_stubbed(:gitlab_issue,
- state: 'opened',
+ state: "opened",
labels:,
gitlab_user:)
end
let(:labels) do
[
{
- 'name' => 'grey',
- 'color' => '#666'
+ "name" => "grey",
+ "color" => "#666"
}
]
end
@@ -53,67 +53,67 @@
let(:user) { build_stubbed(:admin) }
- it { is_expected.to include_json('GitlabIssue'.to_json).at_path('_type') }
+ it { is_expected.to include_json("GitlabIssue".to_json).at_path("_type") }
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'GitlabIssue' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "GitlabIssue" }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { gitlab_issue.id }
end
- it_behaves_like 'property', :number do
+ it_behaves_like "property", :number do
let(:value) { gitlab_issue.number }
end
- it_behaves_like 'property', :htmlUrl do
+ it_behaves_like "property", :htmlUrl do
let(:value) { gitlab_issue.gitlab_html_url }
end
- it_behaves_like 'property', :state do
+ it_behaves_like "property", :state do
let(:value) { gitlab_issue.state }
end
- it_behaves_like 'property', :repository do
+ it_behaves_like "property", :repository do
let(:value) { gitlab_issue.repository }
end
- it_behaves_like 'property', :title do
+ it_behaves_like "property", :title do
let(:value) { gitlab_issue.title }
end
- it_behaves_like 'formattable property', :body do
+ it_behaves_like "formattable property", :body do
let(:value) { gitlab_issue.body }
end
- it_behaves_like 'property', :labels do
+ it_behaves_like "property", :labels do
let(:value) { gitlab_issue.labels }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { gitlab_issue.created_at }
- let(:json_path) { 'createdAt' }
+ let(:json_path) { "createdAt" }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { gitlab_issue.updated_at }
- let(:json_path) { 'updatedAt' }
+ let(:json_path) { "updatedAt" }
end
end
- describe '_links' do
- it { is_expected.to have_json_type(Object).at_path('_links') }
+ describe "_links" do
+ it { is_expected.to have_json_type(Object).at_path("_links") }
- it_behaves_like 'has a titled link' do
- let(:link) { 'gitlabUser' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "gitlabUser" }
let(:href) { api_v3_paths.gitlab_user(gitlab_user.id) }
let(:title) { gitlab_user.gitlab_name }
end
end
- describe 'caching' do
+ describe "caching" do
before do
allow(OpenProject::Cache).to receive(:fetch).and_call_original
end
@@ -126,29 +126,29 @@
.with(representer.json_cache_key)
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let!(:former_cache_key) { representer.json_cache_key }
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'GitlabIssues', 'GitlabIssueRepresenter')
+ .to include("API", "V3", "GitlabIssues", "GitlabIssueRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
I18n.with_locale(:fr) do
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
end
- it 'changes when the gitlab_issue is updated' do
+ it "changes when the gitlab_issue is updated" do
gitlab_issue.updated_at = 20.seconds.from_now
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
- it 'changes when the gitlab_user is updated' do
+ it "changes when the gitlab_user is updated" do
gitlab_issue.gitlab_user.updated_at = 20.seconds.from_now
expect(representer.json_cache_key)
diff --git a/modules/gitlab_integration/spec/lib/api/v3/gitlab_issues/gitlab_user_representer_spec.rb b/modules/gitlab_integration/spec/lib/api/v3/gitlab_issues/gitlab_user_representer_spec.rb
index 488f4d2ed586..904fcdc86642 100644
--- a/modules/gitlab_integration/spec/lib/api/v3/gitlab_issues/gitlab_user_representer_spec.rb
+++ b/modules/gitlab_integration/spec/lib/api/v3/gitlab_issues/gitlab_user_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe API::V3::GitlabIssues::GitlabUserRepresenter do
@@ -39,32 +39,32 @@
let(:user) { build_stubbed(:admin) }
- it { is_expected.to include_json('GitlabUser'.to_json).at_path('_type') }
+ it { is_expected.to include_json("GitlabUser".to_json).at_path("_type") }
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'GitlabUser' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "GitlabUser" }
end
- it_behaves_like 'property', :login do
+ it_behaves_like "property", :login do
let(:value) { gitlab_user.gitlab_name }
end
- it_behaves_like 'property', :email do
+ it_behaves_like "property", :email do
let(:value) { gitlab_user.gitlab_email }
end
- it_behaves_like 'property', :avatarUrl do
+ it_behaves_like "property", :avatarUrl do
let(:value) { gitlab_user.gitlab_avatar_url }
end
end
- describe '_links' do
- it { is_expected.to have_json_type(Object).at_path('_links') }
- it { is_expected.to have_json_path('_links/self/href') }
+ describe "_links" do
+ it { is_expected.to have_json_type(Object).at_path("_links") }
+ it { is_expected.to have_json_path("_links/self/href") }
end
- describe 'caching' do
+ describe "caching" do
before do
allow(OpenProject::Cache).to receive(:fetch).and_call_original
end
@@ -77,22 +77,22 @@
.with(representer.json_cache_key)
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let!(:former_cache_key) { representer.json_cache_key }
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'GitlabIssues', 'GitlabUserRepresenter')
+ .to include("API", "V3", "GitlabIssues", "GitlabUserRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
I18n.with_locale(:fr) do
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
end
- it 'changes when the gitlab_user is updated' do
+ it "changes when the gitlab_user is updated" do
gitlab_user.updated_at = 20.seconds.from_now
expect(representer.json_cache_key)
diff --git a/modules/gitlab_integration/spec/lib/api/v3/gitlab_merge_requests/gitlab_merge_request_representer_spec.rb b/modules/gitlab_integration/spec/lib/api/v3/gitlab_merge_requests/gitlab_merge_request_representer_spec.rb
index 02c7261412ea..2f2546e0c830 100644
--- a/modules/gitlab_integration/spec/lib/api/v3/gitlab_merge_requests/gitlab_merge_request_representer_spec.rb
+++ b/modules/gitlab_integration/spec/lib/api/v3/gitlab_merge_requests/gitlab_merge_request_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe API::V3::GitlabMergeRequests::GitlabMergeRequestRepresenter do
@@ -36,7 +36,7 @@
let(:gitlab_merge_request) do
build_stubbed(:gitlab_merge_request,
- state: 'opened',
+ state: "opened",
labels:,
gitlab_user:,
merged_by:).tap do |pr|
@@ -48,8 +48,8 @@
let(:labels) do
[
{
- 'name' => 'grey',
- 'color' => '#666'
+ "name" => "grey",
+ "color" => "#666"
}
]
end
@@ -61,98 +61,98 @@
let(:user) { build_stubbed(:admin) }
- it { is_expected.to include_json('GitlabMergeRequest'.to_json).at_path('_type') }
+ it { is_expected.to include_json("GitlabMergeRequest".to_json).at_path("_type") }
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'GitlabMergeRequest' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "GitlabMergeRequest" }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { gitlab_merge_request.id }
end
- it_behaves_like 'property', :number do
+ it_behaves_like "property", :number do
let(:value) { gitlab_merge_request.number }
end
- it_behaves_like 'property', :htmlUrl do
+ it_behaves_like "property", :htmlUrl do
let(:value) { gitlab_merge_request.gitlab_html_url }
end
- it_behaves_like 'property', :state do
+ it_behaves_like "property", :state do
let(:value) { gitlab_merge_request.state }
end
- it_behaves_like 'property', :repository do
+ it_behaves_like "property", :repository do
let(:value) { gitlab_merge_request.repository }
end
- it_behaves_like 'property', :title do
+ it_behaves_like "property", :title do
let(:value) { gitlab_merge_request.title }
end
- it_behaves_like 'formattable property', :body do
+ it_behaves_like "formattable property", :body do
let(:value) { gitlab_merge_request.body }
end
- it_behaves_like 'property', :draft do
+ it_behaves_like "property", :draft do
let(:value) { gitlab_merge_request.draft }
end
- it_behaves_like 'property', :merged do
+ it_behaves_like "property", :merged do
let(:value) { gitlab_merge_request.merged }
end
- it_behaves_like 'property', :labels do
+ it_behaves_like "property", :labels do
let(:value) { gitlab_merge_request.labels }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { gitlab_merge_request.gitlab_updated_at }
- let(:json_path) { 'gitlabUpdatedAt' }
+ let(:json_path) { "gitlabUpdatedAt" }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { gitlab_merge_request.created_at }
- let(:json_path) { 'createdAt' }
+ let(:json_path) { "createdAt" }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { gitlab_merge_request.updated_at }
- let(:json_path) { 'updatedAt' }
+ let(:json_path) { "updatedAt" }
end
end
- describe '_links' do
- it { is_expected.to have_json_type(Object).at_path('_links') }
+ describe "_links" do
+ it { is_expected.to have_json_type(Object).at_path("_links") }
- it_behaves_like 'has a titled link' do
- let(:link) { 'gitlabUser' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "gitlabUser" }
let(:href) { api_v3_paths.gitlab_user(gitlab_user.id) }
let(:title) { gitlab_user.gitlab_name }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'mergedBy' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "mergedBy" }
let(:href) { api_v3_paths.gitlab_user(merged_by.id) }
let(:title) { merged_by.gitlab_name }
end
- it_behaves_like 'has a link collection' do
- let(:link) { 'pipelines' }
+ it_behaves_like "has a link collection" do
+ let(:link) { "pipelines" }
let(:hrefs) do
[
{
- 'href' => api_v3_paths.gitlab_pipeline(pipeline.id),
- 'title' => pipeline.name
+ "href" => api_v3_paths.gitlab_pipeline(pipeline.id),
+ "title" => pipeline.name
}
]
end
end
end
- describe 'caching' do
+ describe "caching" do
before do
allow(OpenProject::Cache).to receive(:fetch).and_call_original
end
@@ -165,36 +165,36 @@
.with(representer.json_cache_key)
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let!(:former_cache_key) { representer.json_cache_key }
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'GitlabMergeRequests', 'GitlabMergeRequestRepresenter')
+ .to include("API", "V3", "GitlabMergeRequests", "GitlabMergeRequestRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
I18n.with_locale(:fr) do
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
end
- it 'changes when the gitlab_merge_request is updated' do
+ it "changes when the gitlab_merge_request is updated" do
gitlab_merge_request.updated_at = 20.seconds.from_now
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
- it 'changes when the gitlab_user is updated' do
+ it "changes when the gitlab_user is updated" do
gitlab_merge_request.gitlab_user.updated_at = 20.seconds.from_now
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
- it 'changes when the merged_by user is updated' do
+ it "changes when the merged_by user is updated" do
gitlab_merge_request.merged_by.updated_at = 20.seconds.from_now
expect(representer.json_cache_key)
diff --git a/modules/gitlab_integration/spec/lib/api/v3/gitlab_merge_requests/gitlab_pipeline_representer_spec.rb b/modules/gitlab_integration/spec/lib/api/v3/gitlab_merge_requests/gitlab_pipeline_representer_spec.rb
index 683566c2677c..7fd0aa7ff7b4 100644
--- a/modules/gitlab_integration/spec/lib/api/v3/gitlab_merge_requests/gitlab_pipeline_representer_spec.rb
+++ b/modules/gitlab_integration/spec/lib/api/v3/gitlab_merge_requests/gitlab_pipeline_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe API::V3::GitlabMergeRequests::GitlabPipelineRepresenter do
@@ -38,62 +38,62 @@
let(:representer) { described_class.create(pipeline, current_user: user) }
let(:user) { build_stubbed(:admin) }
- it { is_expected.to include_json('GitlabPipeline'.to_json).at_path('_type') }
+ it { is_expected.to include_json("GitlabPipeline".to_json).at_path("_type") }
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'GitlabPipeline' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "GitlabPipeline" }
end
- it_behaves_like 'property', :htmlUrl do
+ it_behaves_like "property", :htmlUrl do
let(:value) { pipeline.gitlab_html_url }
end
- it_behaves_like 'property', :userAvatarUrl do
+ it_behaves_like "property", :userAvatarUrl do
let(:value) { pipeline.gitlab_user_avatar_url }
end
- it_behaves_like 'property', :name do
+ it_behaves_like "property", :name do
let(:value) { pipeline.name }
end
- it_behaves_like 'property', :status do
+ it_behaves_like "property", :status do
let(:value) { pipeline.status }
end
- it_behaves_like 'property', :detailsUrl do
+ it_behaves_like "property", :detailsUrl do
let(:value) { pipeline.details_url }
end
- it_behaves_like 'property', :ciDetails do
+ it_behaves_like "property", :ciDetails do
let(:value) { pipeline.ci_details }
end
- it_behaves_like 'property', :username do
+ it_behaves_like "property", :username do
let(:value) { pipeline.username }
end
- it_behaves_like 'property', :commitId do
+ it_behaves_like "property", :commitId do
let(:value) { pipeline.commit_id }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { pipeline.started_at }
- let(:json_path) { 'startedAt' }
+ let(:json_path) { "startedAt" }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { pipeline.completed_at }
- let(:json_path) { 'completedAt' }
+ let(:json_path) { "completedAt" }
end
end
- describe '_links' do
- it { is_expected.to have_json_type(Object).at_path('_links') }
- it { is_expected.to have_json_path('_links/self/href') }
+ describe "_links" do
+ it { is_expected.to have_json_type(Object).at_path("_links") }
+ it { is_expected.to have_json_path("_links/self/href") }
end
- describe 'caching' do
+ describe "caching" do
before do
allow(OpenProject::Cache).to receive(:fetch).and_call_original
end
@@ -106,22 +106,22 @@
.with(representer.json_cache_key)
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let!(:former_cache_key) { representer.json_cache_key }
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'GitlabMergeRequests', 'GitlabPipelineRepresenter')
+ .to include("API", "V3", "GitlabMergeRequests", "GitlabPipelineRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
I18n.with_locale(:fr) do
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
end
- it 'changes when the check run is updated' do
+ it "changes when the check run is updated" do
pipeline.updated_at = 20.seconds.from_now
expect(representer.json_cache_key)
diff --git a/modules/gitlab_integration/spec/lib/api/v3/gitlab_merge_requests/gitlab_user_representer_spec.rb b/modules/gitlab_integration/spec/lib/api/v3/gitlab_merge_requests/gitlab_user_representer_spec.rb
index e50adcdfc0c2..a3babd06c351 100644
--- a/modules/gitlab_integration/spec/lib/api/v3/gitlab_merge_requests/gitlab_user_representer_spec.rb
+++ b/modules/gitlab_integration/spec/lib/api/v3/gitlab_merge_requests/gitlab_user_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe API::V3::GitlabMergeRequests::GitlabUserRepresenter do
@@ -39,32 +39,32 @@
let(:user) { build_stubbed(:admin) }
- it { is_expected.to include_json('GitlabUser'.to_json).at_path('_type') }
+ it { is_expected.to include_json("GitlabUser".to_json).at_path("_type") }
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'GitlabUser' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "GitlabUser" }
end
- it_behaves_like 'property', :login do
+ it_behaves_like "property", :login do
let(:value) { gitlab_user.gitlab_name }
end
- it_behaves_like 'property', :email do
+ it_behaves_like "property", :email do
let(:value) { gitlab_user.gitlab_email }
end
- it_behaves_like 'property', :avatarUrl do
+ it_behaves_like "property", :avatarUrl do
let(:value) { gitlab_user.gitlab_avatar_url }
end
end
- describe '_links' do
- it { is_expected.to have_json_type(Object).at_path('_links') }
- it { is_expected.to have_json_path('_links/self/href') }
+ describe "_links" do
+ it { is_expected.to have_json_type(Object).at_path("_links") }
+ it { is_expected.to have_json_path("_links/self/href") }
end
- describe 'caching' do
+ describe "caching" do
before do
allow(OpenProject::Cache).to receive(:fetch).and_call_original
end
@@ -77,22 +77,22 @@
.with(representer.json_cache_key)
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let!(:former_cache_key) { representer.json_cache_key }
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'GitlabMergeRequests', 'GitlabUserRepresenter')
+ .to include("API", "V3", "GitlabMergeRequests", "GitlabUserRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
I18n.with_locale(:fr) do
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
end
- it 'changes when the gitlab_user is updated' do
+ it "changes when the gitlab_user is updated" do
gitlab_user.updated_at = 20.seconds.from_now
expect(representer.json_cache_key)
diff --git a/modules/gitlab_integration/spec/lib/open_project/gitlab_integration/notification_handler/issue_hook_spec.rb b/modules/gitlab_integration/spec/lib/open_project/gitlab_integration/notification_handler/issue_hook_spec.rb
index cea60477e6fa..812ae950622d 100644
--- a/modules/gitlab_integration/spec/lib/open_project/gitlab_integration/notification_handler/issue_hook_spec.rb
+++ b/modules/gitlab_integration/spec/lib/open_project/gitlab_integration/notification_handler/issue_hook_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe OpenProject::GitlabIntegration::NotificationHandler::IssueHook do
@@ -40,45 +40,45 @@
let(:gitlab_issue) { GitlabIssue.find_by_gitlab_identifiers(id: 5) }
let(:mr_description) { "Mentioning OP##{work_package.id}" }
- let(:gitlab_action) { 'open' }
- let(:issue_state) { 'opened' }
+ let(:gitlab_action) { "open" }
+ let(:issue_state) { "opened" }
let(:issue_draft) { false }
let(:labels) { [] }
let(:payload) do
{
- 'open_project_user_id' => gitlab_system_user.id,
- 'object_kind' => "issue",
- 'event_type' => "issue",
- 'user' => {
- 'id' => 1,
- 'name' => "Administrator",
- 'username' => "root",
- 'avatar_url' => "https://www.gravatar.com/avatar/258d8dc916db8cea2cafb6c3cd0cb0246efe061421dbd83ec3a350428cabda4f?s=80&d=identicon",
- 'email' => "[REDACTED]"
+ "open_project_user_id" => gitlab_system_user.id,
+ "object_kind" => "issue",
+ "event_type" => "issue",
+ "user" => {
+ "id" => 1,
+ "name" => "Administrator",
+ "username" => "root",
+ "avatar_url" => "https://www.gravatar.com/avatar/258d8dc916db8cea2cafb6c3cd0cb0246efe061421dbd83ec3a350428cabda4f?s=80&d=identicon",
+ "email" => "[REDACTED]"
},
- 'object_attributes' => {
- 'action' => gitlab_action,
- 'assignee_id' => nil,
- 'author_id' => 1,
- 'created_at' => '2024-03-04 16:09:08 UTC',
- 'title' => 'An Issue title',
- 'description' => mr_description,
- 'draft' => issue_draft,
- 'work_in_progress' => issue_draft,
- 'state' => issue_state,
- 'id' => 5,
- 'iid' => 5,
- 'head_pipeline_id' => nil,
- 'url' => 'http://79dfcd98b723/root/hot_do/-/issues/4',
- 'updated_at' => Time.current.iso8601
+ "object_attributes" => {
+ "action" => gitlab_action,
+ "assignee_id" => nil,
+ "author_id" => 1,
+ "created_at" => "2024-03-04 16:09:08 UTC",
+ "title" => "An Issue title",
+ "description" => mr_description,
+ "draft" => issue_draft,
+ "work_in_progress" => issue_draft,
+ "state" => issue_state,
+ "id" => 5,
+ "iid" => 5,
+ "head_pipeline_id" => nil,
+ "url" => "http://79dfcd98b723/root/hot_do/-/issues/4",
+ "updated_at" => Time.current.iso8601
},
- 'labels' => labels,
- 'repository' => {
- 'name' => "Hot Do",
- 'url' => "git@79dfcd98b723:root/hot_do.git",
- 'description' => nil,
- 'homepage' => 'http://79dfcd98b723/root/hot_do/-/issues/4'
+ "labels" => labels,
+ "repository" => {
+ "name" => "Hot Do",
+ "url" => "git@79dfcd98b723:root/hot_do.git",
+ "description" => nil,
+ "homepage" => "http://79dfcd98b723/root/hot_do/-/issues/4"
}
}
end
@@ -89,15 +89,15 @@
allow(upsert_service).to receive(:call).and_call_original
end
- shared_examples_for 'not adding a comment' do
- it 'does not add comments to work packages' do
+ shared_examples_for "not adding a comment" do
+ it "does not add comments to work packages" do
process
expect(handler_instance).not_to have_received(:comment_on_referenced_work_packages)
end
end
- shared_examples_for 'adding a comment' do
- it 'adds a comment to the work packages' do
+ shared_examples_for "adding a comment" do
+ it "adds a comment to the work packages" do
process
expect(handler_instance).to have_received(:comment_on_referenced_work_packages).with(
[work_package],
@@ -107,37 +107,37 @@
end
end
- shared_examples_for 'calls the issue upsert service' do
- it 'calls the issue upsert service' do
+ shared_examples_for "calls the issue upsert service" do
+ it "calls the issue upsert service" do
process
expect(upsert_service).to have_received(:call)
.with(a_kind_of(OpenProject::GitlabIntegration::NotificationHandler::Helper::Payload), work_packages: [work_package])
end
- context 'when no work_package was mentioned' do
- let(:mr_description) { 'some text that does not mention any work package' }
+ context "when no work_package was mentioned" do
+ let(:mr_description) { "some text that does not mention any work package" }
- it 'does not call the issue upsert service' do
+ it "does not call the issue upsert service" do
process
expect(upsert_service).not_to have_received(:call)
end
end
end
- context 'with an opened action' do
+ context "with an opened action" do
let(:comment) do
"**Issue Opened:** Issue 5 [An Issue title](http://79dfcd98b723/root/hot_do/-/issues/4) for " \
"[Hot Do](http://79dfcd98b723/root/hot_do/-/issues/4) has been opened by " \
"[Administrator](https://www.gravatar.com/avatar/258d8dc916db8cea2cafb6c3cd0cb0246efe061421dbd83ec3a350428cabda4f?s=80&d=identicon).\n"
end
- it_behaves_like 'adding a comment'
- it_behaves_like 'calls the issue upsert service'
+ it_behaves_like "adding a comment"
+ it_behaves_like "calls the issue upsert service"
end
- context 'with a closed action' do
- let(:gitlab_action) { 'close' }
- let(:issue_state) { 'closed' }
+ context "with a closed action" do
+ let(:gitlab_action) { "close" }
+ let(:issue_state) { "closed" }
let(:comment) do
"**Issue Closed:** Issue 5 [An Issue title](http://79dfcd98b723/root/hot_do/-/issues/4) for " \
@@ -145,16 +145,16 @@
"[Administrator](https://www.gravatar.com/avatar/258d8dc916db8cea2cafb6c3cd0cb0246efe061421dbd83ec3a350428cabda4f?s=80&d=identicon).\n"
end
- it_behaves_like 'adding a comment'
- it_behaves_like 'calls the issue upsert service'
+ it_behaves_like "adding a comment"
+ it_behaves_like "calls the issue upsert service"
- context 'when the work package is already known to the GitlabIssue' do
+ context "when the work package is already known to the GitlabIssue" do
let!(:gitlab_issue) { create(:gitlab_issue, gitlab_id: 5, work_packages: [work_package]) }
- it_behaves_like 'adding a comment'
+ it_behaves_like "adding a comment"
- it 'calls the issue upsert service' do
- expect { process }.to change { gitlab_issue.reload.state }.from('opened').to('closed')
+ it "calls the issue upsert service" do
+ expect { process }.to change { gitlab_issue.reload.state }.from("opened").to("closed")
expect(upsert_service).to have_received(:call).with(
a_kind_of(OpenProject::GitlabIntegration::NotificationHandler::Helper::Payload), work_packages: [work_package]
)
@@ -162,10 +162,10 @@
end
end
- context 'with a labeled action' do
+ context "with a labeled action" do
let!(:gitlab_issue) { create(:gitlab_issue, gitlab_id: 5, work_packages: [work_package]) }
- let(:gitlab_action) { 'update' }
- let(:issue_state) { 'opened' }
+ let(:gitlab_action) { "update" }
+ let(:issue_state) { "opened" }
let(:labels) do
[
@@ -201,9 +201,9 @@
# No comment is added when the labels are updated as there is no UI yet for labels supported by the plugin
let(:comment) { nil }
- it_behaves_like 'adding a comment'
+ it_behaves_like "adding a comment"
- it 'calls the issue upsert service with all work_packages' do
+ it "calls the issue upsert service with all work_packages" do
gitlab_issue = process.reload
expect(gitlab_issue.labels).to eq([{ "title" => "feature", "color" => "#009966" },
{ "title" => "needs review", "color" => "#9400d3" }])
@@ -213,9 +213,9 @@
end
end
- context 'with a reopened action' do
- let(:gitlab_action) { 'reopen' }
- let(:issue_state) { 'opened' }
+ context "with a reopened action" do
+ let(:gitlab_action) { "reopen" }
+ let(:issue_state) { "opened" }
let(:comment) do
"**Issue Reopened:** Issue 5 [An Issue title](http://79dfcd98b723/root/hot_do/-/issues/4) for " \
@@ -223,7 +223,7 @@
"[Administrator](https://www.gravatar.com/avatar/258d8dc916db8cea2cafb6c3cd0cb0246efe061421dbd83ec3a350428cabda4f?s=80&d=identicon).\n"
end
- it_behaves_like 'adding a comment'
- it_behaves_like 'calls the issue upsert service'
+ it_behaves_like "adding a comment"
+ it_behaves_like "calls the issue upsert service"
end
end
diff --git a/modules/gitlab_integration/spec/lib/open_project/gitlab_integration/notification_handler/merge_request_hook_spec.rb b/modules/gitlab_integration/spec/lib/open_project/gitlab_integration/notification_handler/merge_request_hook_spec.rb
index 8ae0e8ca2a2b..93ee37967e3b 100644
--- a/modules/gitlab_integration/spec/lib/open_project/gitlab_integration/notification_handler/merge_request_hook_spec.rb
+++ b/modules/gitlab_integration/spec/lib/open_project/gitlab_integration/notification_handler/merge_request_hook_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe OpenProject::GitlabIntegration::NotificationHandler::MergeRequestHook do
@@ -40,45 +40,45 @@
let(:gitlab_merge_request) { GitlabMergeRequest.find_by_gitlab_identifiers(id: 4) }
let(:mr_description) { "Mentioning OP##{work_package.id}" }
- let(:gitlab_action) { 'open' }
- let(:mr_state) { 'opened' }
+ let(:gitlab_action) { "open" }
+ let(:mr_state) { "opened" }
let(:mr_draft) { false }
let(:labels) { [] }
let(:payload) do
{
- 'open_project_user_id' => gitlab_system_user.id,
- 'object_kind' => "merge_request",
- 'event_type' => "merge_request",
- 'user' => {
- 'id' => 1,
- 'name' => "Administrator",
- 'username' => "root",
- 'avatar_url' => "https://www.gravatar.com/avatar/258d8dc916db8cea2cafb6c3cd0cb0246efe061421dbd83ec3a350428cabda4f?s=80&d=identicon",
- 'email' => "[REDACTED]"
+ "open_project_user_id" => gitlab_system_user.id,
+ "object_kind" => "merge_request",
+ "event_type" => "merge_request",
+ "user" => {
+ "id" => 1,
+ "name" => "Administrator",
+ "username" => "root",
+ "avatar_url" => "https://www.gravatar.com/avatar/258d8dc916db8cea2cafb6c3cd0cb0246efe061421dbd83ec3a350428cabda4f?s=80&d=identicon",
+ "email" => "[REDACTED]"
},
- 'object_attributes' => {
- 'action' => gitlab_action,
- 'assignee_id' => nil,
- 'author_id' => 1,
- 'created_at' => '2024-03-04 16:09:08 UTC',
- 'title' => 'A MR title',
- 'description' => mr_description,
- 'draft' => mr_draft,
- 'work_in_progress' => mr_draft,
- 'state' => mr_state,
- 'head_pipeline_id' => nil,
- 'id' => 4,
- 'iid' => 4,
- 'url' => 'http://79dfcd98b723/root/hot_do/-/merge_requests/4',
- 'updated_at' => Time.current.iso8601
+ "object_attributes" => {
+ "action" => gitlab_action,
+ "assignee_id" => nil,
+ "author_id" => 1,
+ "created_at" => "2024-03-04 16:09:08 UTC",
+ "title" => "A MR title",
+ "description" => mr_description,
+ "draft" => mr_draft,
+ "work_in_progress" => mr_draft,
+ "state" => mr_state,
+ "head_pipeline_id" => nil,
+ "id" => 4,
+ "iid" => 4,
+ "url" => "http://79dfcd98b723/root/hot_do/-/merge_requests/4",
+ "updated_at" => Time.current.iso8601
},
- 'labels' => labels,
- 'repository' => {
- 'name' => "Hot Do",
- 'url' => "git@79dfcd98b723:root/hot_do.git",
- 'description' => nil,
- 'homepage' => 'http://79dfcd98b723/root/hot_do/-/merge_requests/4'
+ "labels" => labels,
+ "repository" => {
+ "name" => "Hot Do",
+ "url" => "git@79dfcd98b723:root/hot_do.git",
+ "description" => nil,
+ "homepage" => "http://79dfcd98b723/root/hot_do/-/merge_requests/4"
}
}
end
@@ -89,15 +89,15 @@
allow(upsert_service).to receive(:call).and_call_original
end
- shared_examples_for 'not adding a comment' do
- it 'does not add comments to work packages' do
+ shared_examples_for "not adding a comment" do
+ it "does not add comments to work packages" do
process
expect(handler_instance).not_to have_received(:comment_on_referenced_work_packages)
end
end
- shared_examples_for 'adding a comment' do
- it 'adds a comment to the work packages' do
+ shared_examples_for "adding a comment" do
+ it "adds a comment to the work packages" do
process
expect(handler_instance).to have_received(:comment_on_referenced_work_packages).with(
[work_package],
@@ -107,37 +107,37 @@
end
end
- shared_examples_for 'calls the merge request upsert service' do
- it 'calls the merge request upsert service' do
+ shared_examples_for "calls the merge request upsert service" do
+ it "calls the merge request upsert service" do
process
expect(upsert_service).to have_received(:call)
.with(a_kind_of(OpenProject::GitlabIntegration::NotificationHandler::Helper::Payload), work_packages: [work_package])
end
- context 'when no work_package was mentioned' do
- let(:mr_description) { 'some text that does not mention any work package' }
+ context "when no work_package was mentioned" do
+ let(:mr_description) { "some text that does not mention any work package" }
- it 'does not call the merge request upsert service' do
+ it "does not call the merge request upsert service" do
process
expect(upsert_service).not_to have_received(:call)
end
end
end
- context 'with an opened action' do
+ context "with an opened action" do
let(:comment) do
"**MR Opened:** Merge request 4 [A MR title](http://79dfcd98b723/root/hot_do/-/merge_requests/4) for " \
"[Hot Do](git@79dfcd98b723:root/hot_do.git) has been opened by " \
"[Administrator](https://www.gravatar.com/avatar/258d8dc916db8cea2cafb6c3cd0cb0246efe061421dbd83ec3a350428cabda4f?s=80&d=identicon).\n"
end
- it_behaves_like 'adding a comment'
- it_behaves_like 'calls the merge request upsert service'
+ it_behaves_like "adding a comment"
+ it_behaves_like "calls the merge request upsert service"
end
- context 'with a closed action' do
- let(:gitlab_action) { 'close' }
- let(:mr_state) { 'closed' }
+ context "with a closed action" do
+ let(:gitlab_action) { "close" }
+ let(:mr_state) { "closed" }
let(:comment) do
"**MR Closed:** Merge request 4 [A MR title](http://79dfcd98b723/root/hot_do/-/merge_requests/4) for " \
@@ -145,13 +145,13 @@
"[Administrator](https://www.gravatar.com/avatar/258d8dc916db8cea2cafb6c3cd0cb0246efe061421dbd83ec3a350428cabda4f?s=80&d=identicon).\n"
end
- it_behaves_like 'adding a comment'
- it_behaves_like 'calls the merge request upsert service'
+ it_behaves_like "adding a comment"
+ it_behaves_like "calls the merge request upsert service"
end
- context 'when the MR was merged' do
- let(:gitlab_action) { 'merge' }
- let(:mr_state) { 'merged' }
+ context "when the MR was merged" do
+ let(:gitlab_action) { "merge" }
+ let(:mr_state) { "merged" }
let(:comment) do
"**MR Merged:** Merge request 4 [A MR title](http://79dfcd98b723/root/hot_do/-/merge_requests/4) for " \
@@ -159,16 +159,16 @@
"[Administrator](https://www.gravatar.com/avatar/258d8dc916db8cea2cafb6c3cd0cb0246efe061421dbd83ec3a350428cabda4f?s=80&d=identicon).\n"
end
- it_behaves_like 'adding a comment'
- it_behaves_like 'calls the merge request upsert service'
+ it_behaves_like "adding a comment"
+ it_behaves_like "calls the merge request upsert service"
- context 'when the work package is already known to the GitlabMergeRequest' do
+ context "when the work package is already known to the GitlabMergeRequest" do
let!(:gitlab_merge_request) { create(:gitlab_merge_request, gitlab_id: 4, work_packages: [work_package]) }
- it_behaves_like 'adding a comment'
+ it_behaves_like "adding a comment"
- it 'calls the merge request upsert service' do
- expect { process }.to change { gitlab_merge_request.reload.state }.from('opened').to('merged')
+ it "calls the merge request upsert service" do
+ expect { process }.to change { gitlab_merge_request.reload.state }.from("opened").to("merged")
expect(upsert_service).to have_received(:call).with(
a_kind_of(OpenProject::GitlabIntegration::NotificationHandler::Helper::Payload), work_packages: [work_package]
)
@@ -176,18 +176,18 @@
end
end
- context 'when the MR is converted to draft' do
- let(:gitlab_action) { 'update' }
- let(:mr_state) { 'opened' }
+ context "when the MR is converted to draft" do
+ let(:gitlab_action) { "update" }
+ let(:mr_state) { "opened" }
let(:mr_draft) { true }
- it_behaves_like 'not adding a comment'
- it_behaves_like 'calls the merge request upsert service'
+ it_behaves_like "not adding a comment"
+ it_behaves_like "calls the merge request upsert service"
end
- context 'with a labeled action' do
- let(:gitlab_action) { 'update' }
- let(:mr_state) { 'opened' }
+ context "with a labeled action" do
+ let(:gitlab_action) { "update" }
+ let(:mr_state) { "opened" }
let(:labels) do
[
@@ -220,9 +220,9 @@
]
end
- it_behaves_like 'not adding a comment'
+ it_behaves_like "not adding a comment"
- it 'calls the merge request upsert service with all work_packages' do
+ it "calls the merge request upsert service with all work_packages" do
gitlab_merge_request = process.reload
expect(gitlab_merge_request.labels).to eq([{ "title" => "feature", "color" => "#009966" },
{ "title" => "needs review", "color" => "#9400d3" }])
@@ -232,9 +232,9 @@
end
end
- context 'when the MR is ready for review' do
- let(:gitlab_action) { 'update' }
- let(:mr_state) { 'opened' }
+ context "when the MR is ready for review" do
+ let(:gitlab_action) { "update" }
+ let(:mr_state) { "opened" }
let(:mr_draft) { false }
let(:comment) do
@@ -245,18 +245,18 @@
before { create(:gitlab_merge_request, gitlab_id: 4, work_packages: [work_package]) }
- it_behaves_like 'not adding a comment'
+ it_behaves_like "not adding a comment"
- it 'calls the merge request upsert service' do
+ it "calls the merge request upsert service" do
process
expect(upsert_service).to have_received(:call)
.with(a_kind_of(OpenProject::GitlabIntegration::NotificationHandler::Helper::Payload), work_packages: [work_package])
end
end
- context 'with a reopened action' do
- let(:gitlab_action) { 'reopen' }
- let(:mr_state) { 'opened' }
+ context "with a reopened action" do
+ let(:gitlab_action) { "reopen" }
+ let(:mr_state) { "opened" }
let(:comment) do
"**MR Reopened:** Merge request 4 [A MR title](http://79dfcd98b723/root/hot_do/-/merge_requests/4) for " \
@@ -264,7 +264,7 @@
"[Administrator](https://www.gravatar.com/avatar/258d8dc916db8cea2cafb6c3cd0cb0246efe061421dbd83ec3a350428cabda4f?s=80&d=identicon).\n"
end
- it_behaves_like 'adding a comment'
- it_behaves_like 'calls the merge request upsert service'
+ it_behaves_like "adding a comment"
+ it_behaves_like "calls the merge request upsert service"
end
end
diff --git a/modules/gitlab_integration/spec/lib/open_project/gitlab_integration/notification_handler/pipeline_hook_spec.rb b/modules/gitlab_integration/spec/lib/open_project/gitlab_integration/notification_handler/pipeline_hook_spec.rb
index 2dc806a3c43d..10632b42eef9 100644
--- a/modules/gitlab_integration/spec/lib/open_project/gitlab_integration/notification_handler/pipeline_hook_spec.rb
+++ b/modules/gitlab_integration/spec/lib/open_project/gitlab_integration/notification_handler/pipeline_hook_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe OpenProject::GitlabIntegration::NotificationHandler::PipelineHook do
@@ -40,17 +40,17 @@
let(:payload) do
{
- 'open_project_user_id' => gitlab_system_user.id,
- 'object_kind' => "pipeline",
- 'event_type' => "pipeline",
- 'user' => {
- 'id' => 1,
- 'name' => "Administrator",
- 'username' => "root",
- 'avatar_url' => "https://www.gravatar.com/avatar/258d8dc916db8cea2cafb6c3cd0cb0246efe061421dbd83ec3a350428cabda4f?s=80&d=identicon",
- 'email' => "[REDACTED]"
+ "open_project_user_id" => gitlab_system_user.id,
+ "object_kind" => "pipeline",
+ "event_type" => "pipeline",
+ "user" => {
+ "id" => 1,
+ "name" => "Administrator",
+ "username" => "root",
+ "avatar_url" => "https://www.gravatar.com/avatar/258d8dc916db8cea2cafb6c3cd0cb0246efe061421dbd83ec3a350428cabda4f?s=80&d=identicon",
+ "email" => "[REDACTED]"
},
- 'object_attributes' => {
+ "object_attributes" => {
"id" => 5,
"iid" => 5,
"name" => nil,
@@ -134,8 +134,8 @@
allow(upsert_service).to receive(:call).and_call_original
end
- context 'with a new pipeline' do
- it 'calls the pipeline upsert service' do
+ context "with a new pipeline" do
+ it "calls the pipeline upsert service" do
expect { process }.to change(GitlabPipeline, :count).by(1)
expect(upsert_service).to have_received(:call)
.with(a_kind_of(OpenProject::GitlabIntegration::NotificationHandler::Helper::Payload),
diff --git a/modules/gitlab_integration/spec/models/gitlab_issue_spec.rb b/modules/gitlab_integration/spec/models/gitlab_issue_spec.rb
index 5ca66a5e98fc..5d29c218140e 100644
--- a/modules/gitlab_integration/spec/models/gitlab_issue_spec.rb
+++ b/modules/gitlab_integration/spec/models/gitlab_issue_spec.rb
@@ -26,16 +26,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe GitlabIssue do
- describe 'Associations' do
+ describe "Associations" do
it { is_expected.to have_and_belong_to_many(:work_packages) }
it { is_expected.to belong_to(:gitlab_user).optional }
end
- describe 'Validations' do
+ describe "Validations" do
it { is_expected.to validate_presence_of :gitlab_html_url }
it { is_expected.to validate_presence_of :number }
it { is_expected.to validate_presence_of :repository }
@@ -43,48 +43,48 @@
it { is_expected.to validate_presence_of :title }
it { is_expected.to validate_presence_of :gitlab_updated_at }
- context 'when it is a partial issue' do
+ context "when it is a partial issue" do
let(:issue) { build(:gitlab_issue, :partial) }
it { expect(issue).not_to validate_presence_of :body }
end
- context 'when it is not a partial issue' do
+ context "when it is not a partial issue" do
let(:issue) { build(:gitlab_issue) }
it { expect(issue).to be_valid }
end
- describe 'labels' do
+ describe "labels" do
it { is_expected.to allow_value(nil).for(:labels) }
it { is_expected.to allow_value([]).for(:labels) }
- it { is_expected.to allow_value([{ 'color' => '#666', 'title' => 'grey' }]).for(:labels) }
+ it { is_expected.to allow_value([{ "color" => "#666", "title" => "grey" }]).for(:labels) }
- it 'requires both color and title' do
- expect(subject).not_to allow_value([{ 'title' => 'grey' }]).for(:labels)
+ it "requires both color and title" do
+ expect(subject).not_to allow_value([{ "title" => "grey" }]).for(:labels)
end
it { is_expected.not_to allow_value([{}]).for(:labels) }
- it 'returns an error message when invalid' do
- issue = build(:gitlab_issue, labels: [{ 'title' => 'grey' }])
+ it "returns an error message when invalid" do
+ issue = build(:gitlab_issue, labels: [{ "title" => "grey" }])
issue.valid?
- expect(issue.errors[:labels]).to include('must be an array of hashes with keys: color, title')
+ expect(issue.errors[:labels]).to include("must be an array of hashes with keys: color, title")
end
end
end
- describe 'Enums' do
+ describe "Enums" do
let(:gitlab_issue) { build(:gitlab_issue) }
it do
expect(gitlab_issue).to define_enum_for(:state)
- .with_values(opened: 'opened', closed: 'closed')
+ .with_values(opened: "opened", closed: "closed")
.backed_by_column_of_type(:string)
end
end
- describe '.without_work_package' do
+ describe ".without_work_package" do
subject(:gitlab_issues_without_workpackages) { described_class.without_work_package }
let(:gitlab_issue_no_work_packages) { create(:gitlab_issue, work_packages: []) }
@@ -98,78 +98,78 @@
it { expect(gitlab_issues_without_workpackages).to contain_exactly(gitlab_issue_no_work_packages) }
end
- describe '.find_by_gitlab_identifiers' do
+ describe ".find_by_gitlab_identifiers" do
shared_let(:issue) { create(:gitlab_issue) }
- it 'raises an ArgumentError when no id or url is provided' do
- expect { described_class.find_by_gitlab_identifiers }.to raise_error(ArgumentError, 'needs an id or an url')
+ it "raises an ArgumentError when no id or url is provided" do
+ expect { described_class.find_by_gitlab_identifiers }.to raise_error(ArgumentError, "needs an id or an url")
end
- context 'when the gitlab_id attribute matches' do
- it 'finds by gitlab_id' do
+ context "when the gitlab_id attribute matches" do
+ it "finds by gitlab_id" do
expect(described_class.find_by_gitlab_identifiers(id: issue.gitlab_id)).to eql(issue)
end
end
- context 'when the gitlab_html_url attribute matches' do
- it 'finds by gitlab_html_url' do
+ context "when the gitlab_html_url attribute matches" do
+ it "finds by gitlab_html_url" do
expect(described_class.find_by_gitlab_identifiers(url: issue.gitlab_html_url)).to eql(issue)
end
end
- context 'when the provided gitlab_id does not match' do
- it 'is nil' do
+ context "when the provided gitlab_id does not match" do
+ it "is nil" do
expect(described_class.find_by_gitlab_identifiers(id: issue.gitlab_id + 1)).to be_nil
end
end
- context 'when the provided gitlab_html_url does not match' do
- it 'is nil' do
+ context "when the provided gitlab_html_url does not match" do
+ it "is nil" do
expect(described_class.find_by_gitlab_identifiers(url: "#{issue.gitlab_html_url}zzzz"))
.to be_nil
end
end
- context 'when neither match' do
- it 'is nil' do
+ context "when neither match" do
+ it "is nil" do
expect(described_class.find_by_gitlab_identifiers(id: issue.gitlab_id + 1,
url: "#{issue.gitlab_html_url}zzzz"))
.to be_nil
end
end
- context 'when the provided gitlab_html_url does not match but the gitlab_id does' do
- it 'is nil' do
+ context "when the provided gitlab_html_url does not match but the gitlab_id does" do
+ it "is nil" do
expect(described_class.find_by_gitlab_identifiers(id: issue.gitlab_id,
url: "#{issue.gitlab_html_url}zzzz"))
.to eql issue
end
end
- context 'when the provided gitlab_html_url does match but the gitlab_id does not' do
- it 'is nil' do
+ context "when the provided gitlab_html_url does match but the gitlab_id does not" do
+ it "is nil" do
expect(described_class.find_by_gitlab_identifiers(id: issue.gitlab_id + 1,
url: issue.gitlab_html_url))
.to eql issue
end
end
- context 'when neither match but initialize is true' do
+ context "when neither match but initialize is true" do
subject(:finder) do
described_class.find_by_gitlab_identifiers(id: issue.gitlab_id + 1,
url: "#{issue.gitlab_html_url}zzzz",
initialize: true)
end
- it 'returns an issue' do
+ it "returns an issue" do
expect(finder).to be_a(described_class)
end
- it 'returns a new record' do
+ it "returns a new record" do
expect(finder).to be_new_record
end
- it 'has the provided attributes initialized' do
+ it "has the provided attributes initialized" do
expect(finder.attributes.compact)
.to eql("gitlab_id" => issue.gitlab_id + 1,
"gitlab_html_url" => "#{issue.gitlab_html_url}zzzz")
diff --git a/modules/gitlab_integration/spec/models/gitlab_merge_request_spec.rb b/modules/gitlab_integration/spec/models/gitlab_merge_request_spec.rb
index 76b4533956ad..30050f244417 100644
--- a/modules/gitlab_integration/spec/models/gitlab_merge_request_spec.rb
+++ b/modules/gitlab_integration/spec/models/gitlab_merge_request_spec.rb
@@ -26,18 +26,18 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe GitlabMergeRequest do
- describe 'Associations' do
+ describe "Associations" do
it { is_expected.to have_and_belong_to_many(:work_packages) }
it { is_expected.to have_many(:gitlab_pipelines).dependent(:destroy) }
it { is_expected.to belong_to(:gitlab_user).optional }
- it { is_expected.to belong_to(:merged_by).class_name('GitlabUser').optional }
+ it { is_expected.to belong_to(:merged_by).class_name("GitlabUser").optional }
end
- describe 'Validations' do
+ describe "Validations" do
it { is_expected.to validate_presence_of :gitlab_html_url }
it { is_expected.to validate_presence_of :number }
it { is_expected.to validate_presence_of :repository }
@@ -45,48 +45,48 @@
it { is_expected.to validate_presence_of :title }
it { is_expected.to validate_presence_of :gitlab_updated_at }
- context 'when it is a partial merge request' do
+ context "when it is a partial merge request" do
let(:merge_request) { build(:gitlab_merge_request, :partial) }
it { expect(merge_request).not_to validate_presence_of :body }
end
- context 'when it is not a partial merge_request' do
+ context "when it is not a partial merge_request" do
let(:merge_request) { build(:gitlab_merge_request) }
it { expect(merge_request).to be_valid }
end
- describe 'labels' do
+ describe "labels" do
it { is_expected.to allow_value(nil).for(:labels) }
it { is_expected.to allow_value([]).for(:labels) }
- it { is_expected.to allow_value([{ 'color' => '#666', 'title' => 'grey' }]).for(:labels) }
+ it { is_expected.to allow_value([{ "color" => "#666", "title" => "grey" }]).for(:labels) }
- it 'requires both color and title' do
- expect(subject).not_to allow_value([{ 'title' => 'grey' }]).for(:labels)
+ it "requires both color and title" do
+ expect(subject).not_to allow_value([{ "title" => "grey" }]).for(:labels)
end
it { is_expected.not_to allow_value([{}]).for(:labels) }
- it 'returns an error message when invalid' do
- merge_request = build(:gitlab_merge_request, labels: [{ 'title' => 'grey' }])
+ it "returns an error message when invalid" do
+ merge_request = build(:gitlab_merge_request, labels: [{ "title" => "grey" }])
merge_request.valid?
- expect(merge_request.errors[:labels]).to include('must be an array of hashes with keys: color, title')
+ expect(merge_request.errors[:labels]).to include("must be an array of hashes with keys: color, title")
end
end
end
- describe 'Enums' do
+ describe "Enums" do
let(:gitlab_merge_request) { build(:gitlab_merge_request) }
it do
expect(gitlab_merge_request).to define_enum_for(:state)
- .with_values(opened: 'opened', merged: 'merged', closed: 'closed')
+ .with_values(opened: "opened", merged: "merged", closed: "closed")
.backed_by_column_of_type(:string)
end
end
- describe '.without_work_package' do
+ describe ".without_work_package" do
subject { described_class.without_work_package }
let(:merge_request) { create(:gitlab_merge_request, work_packages:) }
@@ -96,85 +96,85 @@
it { is_expected.to contain_exactly(merge_request) }
- context 'when the pr is linked to a work_package' do
+ context "when the pr is linked to a work_package" do
let(:work_packages) { create_list(:work_package, 1) }
it { is_expected.to be_empty }
end
end
- describe '.find_by_gitlab_identifiers' do
+ describe ".find_by_gitlab_identifiers" do
shared_let(:merge_request) { create(:gitlab_merge_request) }
- it 'raises an ArgumentError when no id or url is provided' do
- expect { described_class.find_by_gitlab_identifiers }.to raise_error(ArgumentError, 'needs an id or an url')
+ it "raises an ArgumentError when no id or url is provided" do
+ expect { described_class.find_by_gitlab_identifiers }.to raise_error(ArgumentError, "needs an id or an url")
end
- context 'when the gitlab_id attribute matches' do
- it 'finds by gitlab_id' do
+ context "when the gitlab_id attribute matches" do
+ it "finds by gitlab_id" do
expect(described_class.find_by_gitlab_identifiers(id: merge_request.gitlab_id)).to eql(merge_request)
end
end
- context 'when the gitlab_html_url attribute matches' do
- it 'finds by gitlab_html_url' do
+ context "when the gitlab_html_url attribute matches" do
+ it "finds by gitlab_html_url" do
expect(described_class.find_by_gitlab_identifiers(url: merge_request.gitlab_html_url)).to eql(merge_request)
end
end
- context 'when the provided gitlab_id does not match' do
- it 'is nil' do
+ context "when the provided gitlab_id does not match" do
+ it "is nil" do
expect(described_class.find_by_gitlab_identifiers(id: merge_request.gitlab_id + 1)).to be_nil
end
end
- context 'when the provided gitlab_html_url does not match' do
- it 'is nil' do
+ context "when the provided gitlab_html_url does not match" do
+ it "is nil" do
expect(described_class.find_by_gitlab_identifiers(url: "#{merge_request.gitlab_html_url}zzzz"))
.to be_nil
end
end
- context 'when neither match' do
- it 'is nil' do
+ context "when neither match" do
+ it "is nil" do
expect(described_class.find_by_gitlab_identifiers(id: merge_request.gitlab_id + 1,
url: "#{merge_request.gitlab_html_url}zzzz"))
.to be_nil
end
end
- context 'when the provided gitlab_html_url does not match but the gitlab_id does' do
- it 'is nil' do
+ context "when the provided gitlab_html_url does not match but the gitlab_id does" do
+ it "is nil" do
expect(described_class.find_by_gitlab_identifiers(id: merge_request.gitlab_id,
url: "#{merge_request.gitlab_html_url}zzzz"))
.to eql merge_request
end
end
- context 'when the provided gitlab_html_url does match but the gitlab_id does not' do
- it 'is nil' do
+ context "when the provided gitlab_html_url does match but the gitlab_id does not" do
+ it "is nil" do
expect(described_class.find_by_gitlab_identifiers(id: merge_request.gitlab_id + 1,
url: merge_request.gitlab_html_url))
.to eql merge_request
end
end
- context 'when neither match but initialize is true' do
+ context "when neither match but initialize is true" do
subject(:finder) do
described_class.find_by_gitlab_identifiers(id: merge_request.gitlab_id + 1,
url: "#{merge_request.gitlab_html_url}zzzz",
initialize: true)
end
- it 'returns an merge_request' do
+ it "returns an merge_request" do
expect(finder).to be_a(described_class)
end
- it 'returns a new record' do
+ it "returns a new record" do
expect(finder).to be_new_record
end
- it 'has the provided attributes initialized' do
+ it "has the provided attributes initialized" do
expect(finder.attributes.compact)
.to eql("gitlab_id" => merge_request.gitlab_id + 1,
"gitlab_html_url" => "#{merge_request.gitlab_html_url}zzzz")
@@ -182,14 +182,14 @@
end
end
- describe '#latest_pipelines' do
- context 'when multiple pipelines for the same merge request exist' do
+ describe "#latest_pipelines" do
+ context "when multiple pipelines for the same merge request exist" do
shared_association_default(:gitlab_merge_request) { create(:gitlab_merge_request) }
shared_let(:latest_pipelines) { create_list(:gitlab_pipeline, 2, :recent, project_id: 123) }
shared_let(:outdated_pipelines) { create_list(:gitlab_pipeline, 2, :outdated, project_id: 123) }
- it 'returns the latest pipeline ordered from most recent' do
+ it "returns the latest pipeline ordered from most recent" do
expect(gitlab_merge_request.reload.latest_pipelines).to match_array(latest_pipelines + outdated_pipelines)
end
end
diff --git a/modules/gitlab_integration/spec/models/gitlab_pipeline_spec.rb b/modules/gitlab_integration/spec/models/gitlab_pipeline_spec.rb
index 4c4f9d333c78..c58b6ae7fe70 100644
--- a/modules/gitlab_integration/spec/models/gitlab_pipeline_spec.rb
+++ b/modules/gitlab_integration/spec/models/gitlab_pipeline_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe GitlabPipeline do
- describe 'Associations' do
+ describe "Associations" do
it { is_expected.to belong_to(:gitlab_merge_request).touch(true) }
end
- describe 'Validations' do
+ describe "Validations" do
it { is_expected.to validate_presence_of :gitlab_user_avatar_url }
it { is_expected.to validate_presence_of :gitlab_html_url }
it { is_expected.to validate_presence_of :gitlab_id }
@@ -45,22 +45,22 @@
it { is_expected.to validate_presence_of :username }
end
- describe 'Enums' do
+ describe "Enums" do
let(:gitlab_pipeline) { build(:gitlab_pipeline) }
it do
expect(gitlab_pipeline).to define_enum_for(:status)
- .with_values(created: 'created',
- running: 'running',
- success: 'success',
- waiting: 'waiting',
- preparing: 'preparing',
- failed: 'failed',
- pending: 'pending',
- canceled: 'canceled',
- skipped: 'skipped',
- manual: 'manual',
- scheduled: 'scheduled')
+ .with_values(created: "created",
+ running: "running",
+ success: "success",
+ waiting: "waiting",
+ preparing: "preparing",
+ failed: "failed",
+ pending: "pending",
+ canceled: "canceled",
+ skipped: "skipped",
+ manual: "manual",
+ scheduled: "scheduled")
.backed_by_column_of_type(:string)
end
end
diff --git a/modules/gitlab_integration/spec/models/gitlab_user_spec.rb b/modules/gitlab_integration/spec/models/gitlab_user_spec.rb
index 0c47d4d64961..c184b0da932b 100644
--- a/modules/gitlab_integration/spec/models/gitlab_user_spec.rb
+++ b/modules/gitlab_integration/spec/models/gitlab_user_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe GitlabUser do
- describe 'Associations' do
+ describe "Associations" do
it { is_expected.to have_many(:gitlab_merge_requests) }
end
- describe 'Validations' do
+ describe "Validations" do
it { is_expected.to validate_presence_of :gitlab_id }
it { is_expected.to validate_presence_of :gitlab_name }
it { is_expected.to validate_presence_of :gitlab_username }
diff --git a/modules/gitlab_integration/spec/spec_helper.rb b/modules/gitlab_integration/spec/spec_helper.rb
index 5974eaa856cf..e9b86f472dd9 100644
--- a/modules/gitlab_integration/spec/spec_helper.rb
+++ b/modules/gitlab_integration/spec/spec_helper.rb
@@ -26,4 +26,4 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
diff --git a/modules/gitlab_integration/spec/support/pages/work_package_gitlab_tab.rb b/modules/gitlab_integration/spec/support/pages/work_package_gitlab_tab.rb
index 4792431eeef3..cf8bf666b8a3 100644
--- a/modules/gitlab_integration/spec/support/pages/work_package_gitlab_tab.rb
+++ b/modules/gitlab_integration/spec/support/pages/work_package_gitlab_tab.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'rbconfig'
-require 'support/pages/page'
+require "rbconfig"
+require "support/pages/page"
module Pages
class GitlabTab < Page
@@ -43,26 +43,26 @@ def path
end
def git_actions_menu_button
- find('.gitlab-git-copy:not([disabled])', text: 'Git')
+ find(".gitlab-git-copy:not([disabled])", text: "Git")
end
def git_actions_copy_branch_name_button
- find('.git-actions-menu .copy-button:not([disabled])', match: :first)
+ find(".git-actions-menu .copy-button:not([disabled])", match: :first)
end
def paste_clipboard_content
meta_key = osx? ? :command : :control
- page.send_keys(meta_key, 'v')
+ page.send_keys(meta_key, "v")
end
def expect_tab_not_present
- expect(page).to have_no_css('.op-tab-row--link', text: 'GITLAB')
+ expect(page).to have_no_css(".op-tab-row--link", text: "GITLAB")
end
private
def osx?
- RbConfig::CONFIG['host_os'].include?('darwin')
+ RbConfig::CONFIG["host_os"].include?("darwin")
end
end
end
diff --git a/modules/grids/Gemfile b/modules/grids/Gemfile
index fa75df156323..b4e2a20bb606 100644
--- a/modules/grids/Gemfile
+++ b/modules/grids/Gemfile
@@ -1,3 +1,3 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
gemspec
diff --git a/modules/grids/app/contracts/grids/base_contract.rb b/modules/grids/app/contracts/grids/base_contract.rb
index 428daaf4a342..62d88b5389ea 100644
--- a/modules/grids/app/contracts/grids/base_contract.rb
+++ b/modules/grids/app/contracts/grids/base_contract.rb
@@ -129,7 +129,7 @@ def validate_widgets_start_before_end
end
def run_registration_validations
- validations = config.validations(model, self.class.name.demodulize.gsub('Contract', '').underscore.to_sym)
+ validations = config.validations(model, self.class.name.demodulize.gsub("Contract", "").underscore.to_sym)
validations.each do |validation|
instance_eval(&validation)
diff --git a/modules/grids/app/contracts/grids/create_contract.rb b/modules/grids/app/contracts/grids/create_contract.rb
index 86da86d4d3a6..0ced6dbb535e 100644
--- a/modules/grids/app/contracts/grids/create_contract.rb
+++ b/modules/grids/app/contracts/grids/create_contract.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'grids/base_contract'
+require "grids/base_contract"
module Grids
class CreateContract < BaseContract
diff --git a/modules/grids/app/contracts/grids/delete_contract.rb b/modules/grids/app/contracts/grids/delete_contract.rb
index 285f86f969e2..1ea7623a9b1d 100644
--- a/modules/grids/app/contracts/grids/delete_contract.rb
+++ b/modules/grids/app/contracts/grids/delete_contract.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'grids/base_contract'
+require "grids/base_contract"
module Grids
class DeleteContract < ::DeleteContract
diff --git a/modules/grids/app/contracts/grids/update_contract.rb b/modules/grids/app/contracts/grids/update_contract.rb
index 74593827e59a..8a178e508637 100644
--- a/modules/grids/app/contracts/grids/update_contract.rb
+++ b/modules/grids/app/contracts/grids/update_contract.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'grids/base_contract'
+require "grids/base_contract"
module Grids
class UpdateContract < BaseContract
diff --git a/modules/grids/app/controllers/api/v3/grids/grids_api.rb b/modules/grids/app/controllers/api/v3/grids/grids_api.rb
index 75f9512a153d..60e1011ccb24 100644
--- a/modules/grids/app/controllers/api/v3/grids/grids_api.rb
+++ b/modules/grids/app/controllers/api/v3/grids/grids_api.rb
@@ -57,12 +57,12 @@ class GridsAPI < ::API::OpenProjectAPI
mount ::API::V3::Grids::CreateFormAPI
mount ::API::V3::Grids::Schemas::GridSchemaAPI
- route_param :id, type: Integer, desc: 'Grid ID' do
+ route_param :id, type: Integer, desc: "Grid ID" do
after_validation do
@grid = ::Grids::Query
.new(user: current_user)
.results
- .find(params['id'])
+ .find(params["id"])
end
get do
diff --git a/modules/grids/app/controllers/grids/base_in_project_controller.rb b/modules/grids/app/controllers/grids/base_in_project_controller.rb
index 1458a8b8b550..eac86aa79ab5 100644
--- a/modules/grids/app/controllers/grids/base_in_project_controller.rb
+++ b/modules/grids/app/controllers/grids/base_in_project_controller.rb
@@ -4,7 +4,7 @@ class BaseInProjectController < ::ApplicationController
before_action :authorize
def show
- render layout: 'angular/angular'
+ render layout: "angular/angular"
end
end
end
diff --git a/modules/grids/app/models/grids/grid.rb b/modules/grids/app/models/grids/grid.rb
index 7e395db5feec..c2c3f518d865 100644
--- a/modules/grids/app/models/grids/grid.rb
+++ b/modules/grids/app/models/grids/grid.rb
@@ -33,7 +33,7 @@ class Grid < ApplicationRecord
serialize :options, type: Hash
has_many :widgets,
- class_name: 'Widget',
+ class_name: "Widget",
dependent: :destroy,
autosave: true
diff --git a/modules/grids/app/queries/grids/filters/page_filter.rb b/modules/grids/app/queries/grids/filters/page_filter.rb
index d53b03f739c3..78922f27de17 100644
--- a/modules/grids/app/queries/grids/filters/page_filter.rb
+++ b/modules/grids/app/queries/grids/filters/page_filter.rb
@@ -30,7 +30,7 @@ module Grids
module Filters
class PageFilter < Filters::GridFilter
def allowed_values
- raise NotImplementedError, 'There would be too many candidates'
+ raise NotImplementedError, "There would be too many candidates"
end
def allowed_values_subset
@@ -62,7 +62,7 @@ def where
project_id_condition(actual_value[:project_id])]
"(#{conditions.compact.join(' AND ')})"
- end.join(' OR ')
+ end.join(" OR ")
end
private
@@ -72,7 +72,7 @@ def class_condition(klass)
operator_strategy.sql_for_field([klass.name],
self.class.model.table_name,
- 'type')
+ "type")
end
def project_id_condition(project_id)
@@ -84,7 +84,7 @@ def project_id_condition(project_id)
operator_strategy.sql_for_field([project_id],
self.class.model.table_name,
- 'project_id')
+ "project_id")
end
def available_operators
diff --git a/modules/grids/app/queries/grids/filters/scope_filter.rb b/modules/grids/app/queries/grids/filters/scope_filter.rb
index 384cf0888f0a..b5b26639b210 100644
--- a/modules/grids/app/queries/grids/filters/scope_filter.rb
+++ b/modules/grids/app/queries/grids/filters/scope_filter.rb
@@ -30,7 +30,7 @@ module Grids
module Filters
class ScopeFilter < Filters::GridFilter
def allowed_values
- raise NotImplementedError, 'There would be too many candidates'
+ raise NotImplementedError, "There would be too many candidates"
end
def allowed_values_subset
@@ -55,7 +55,7 @@ def where
project_id_condition(config[:project_id])]
"(#{conditions.compact.join(' AND ')})"
- end.join(' OR ')
+ end.join(" OR ")
end
private
@@ -70,7 +70,7 @@ def class_condition(klass)
operator_strategy.sql_for_field([klass.name],
self.class.model.table_name,
- 'type')
+ "type")
end
def project_id_condition(project_id)
@@ -82,7 +82,7 @@ def project_id_condition(project_id)
operator_strategy.sql_for_field([project_id],
self.class.model.table_name,
- 'project_id')
+ "project_id")
end
def type_strategy
diff --git a/modules/grids/app/representers/api/v3/grids/grid_representer.rb b/modules/grids/app/representers/api/v3/grids/grid_representer.rb
index 176d07b0f5fd..2073ce9089bb 100644
--- a/modules/grids/app/representers/api/v3/grids/grid_representer.rb
+++ b/modules/grids/app/representers/api/v3/grids/grid_representer.rb
@@ -45,11 +45,11 @@ class GridRepresenter < ::API::Decorators::Single
{
href: path,
- type: 'text/html'
+ type: "text/html"
}
},
setter: ->(fragment:, **) {
- represented.scope = fragment['href']
+ represented.scope = fragment["href"]
}
self_link title_getter: ->(*) {}
@@ -112,7 +112,7 @@ class GridRepresenter < ::API::Decorators::Single
render_nil: false
def _type
- 'Grid'
+ "Grid"
end
private
@@ -133,7 +133,7 @@ def scope_path
# Remove all query params
# Those are added when the path does not actually require
# project or user
- path&.gsub(/(\?.+)|(\.\d+)\z/, '')
+ path&.gsub(/(\?.+)|(\.\d+)\z/, "")
end
def scope_path_attributes
diff --git a/modules/grids/app/representers/api/v3/grids/schemas/grid_schema_representer.rb b/modules/grids/app/representers/api/v3/grids/schemas/grid_schema_representer.rb
index a5e73b5513da..702940dd8a91 100644
--- a/modules/grids/app/representers/api/v3/grids/schemas/grid_schema_representer.rb
+++ b/modules/grids/app/representers/api/v3/grids/schemas/grid_schema_representer.rb
@@ -39,28 +39,28 @@ def initialize(represented, self_link: nil, current_user: nil, form_embedded: fa
end
schema :id,
- type: 'Integer'
+ type: "Integer"
schema :created_at,
- type: 'DateTime'
+ type: "DateTime"
schema :updated_at,
- type: 'DateTime'
+ type: "DateTime"
schema :row_count,
- type: 'Integer'
+ type: "Integer"
schema :column_count,
- type: 'Integer'
+ type: "Integer"
schema :name,
- type: 'String'
+ type: "String"
schema :options,
- type: 'JSON'
+ type: "JSON"
schema_with_allowed_collection :scope,
- type: 'Href',
+ type: "Href",
required: true,
has_default: false,
value_representer: false,
@@ -71,7 +71,7 @@ def initialize(represented, self_link: nil, current_user: nil, form_embedded: fa
}
schema_with_allowed_collection :widgets,
- type: '[]GridWidget',
+ type: "[]GridWidget",
required: true,
has_default: false,
values_callback: -> do
diff --git a/modules/grids/app/representers/api/v3/grids/widgets/chart_options_representer.rb b/modules/grids/app/representers/api/v3/grids/widgets/chart_options_representer.rb
index b0e47734be84..62f3f81bb0d2 100644
--- a/modules/grids/app/representers/api/v3/grids/widgets/chart_options_representer.rb
+++ b/modules/grids/app/representers/api/v3/grids/widgets/chart_options_representer.rb
@@ -33,7 +33,7 @@ module Widgets
class ChartOptionsRepresenter < QueryOptionsRepresenter
property :chartType,
getter: ->(represented:, **) {
- represented['chartType']
+ represented["chartType"]
}
end
end
diff --git a/modules/grids/app/representers/api/v3/grids/widgets/default_options_representer.rb b/modules/grids/app/representers/api/v3/grids/widgets/default_options_representer.rb
index 533e0832d2ea..80bff573c508 100644
--- a/modules/grids/app/representers/api/v3/grids/widgets/default_options_representer.rb
+++ b/modules/grids/app/representers/api/v3/grids/widgets/default_options_representer.rb
@@ -33,7 +33,7 @@ module Widgets
class DefaultOptionsRepresenter < ::API::Decorators::Single
property :name,
getter: ->(represented:, **) {
- represented['name']
+ represented["name"]
}
end
end
diff --git a/modules/grids/app/representers/api/v3/grids/widgets/query_options_representer.rb b/modules/grids/app/representers/api/v3/grids/widgets/query_options_representer.rb
index b54b8d8569af..105cd13b63af 100644
--- a/modules/grids/app/representers/api/v3/grids/widgets/query_options_representer.rb
+++ b/modules/grids/app/representers/api/v3/grids/widgets/query_options_representer.rb
@@ -33,14 +33,14 @@ module Widgets
class QueryOptionsRepresenter < DefaultOptionsRepresenter
property :queryId,
getter: ->(represented:, **) {
- represented['queryId']
+ represented["queryId"]
}
# This is required for initialization where the values
# are stored like this so the front end can then initialize it.
property :queryProps,
getter: ->(represented:, **) {
- represented['queryProps']
+ represented["queryProps"]
}
end
end
diff --git a/modules/grids/app/representers/api/v3/grids/widgets/time_entry_calendar_options_representer.rb b/modules/grids/app/representers/api/v3/grids/widgets/time_entry_calendar_options_representer.rb
index 58b232c79f40..3378d3684653 100644
--- a/modules/grids/app/representers/api/v3/grids/widgets/time_entry_calendar_options_representer.rb
+++ b/modules/grids/app/representers/api/v3/grids/widgets/time_entry_calendar_options_representer.rb
@@ -33,7 +33,7 @@ module Widgets
class TimeEntryCalendarOptionsRepresenter < DefaultOptionsRepresenter
property :days,
getter: ->(represented:, **) {
- represented['days'] || {}
+ represented["days"] || {}
}
end
end
diff --git a/modules/grids/app/representers/api/v3/grids/widgets/widget_representer.rb b/modules/grids/app/representers/api/v3/grids/widgets/widget_representer.rb
index bb7b159fc138..5a89c2d0bffa 100644
--- a/modules/grids/app/representers/api/v3/grids/widgets/widget_representer.rb
+++ b/modules/grids/app/representers/api/v3/grids/widgets/widget_representer.rb
@@ -49,7 +49,7 @@ class WidgetRepresenter < ::API::Decorators::Single
}
def _type
- 'GridWidget'
+ "GridWidget"
end
end
end
diff --git a/modules/grids/app/services/grids/set_attributes_service.rb b/modules/grids/app/services/grids/set_attributes_service.rb
index 4dcc4f726185..c2317ad4cb05 100644
--- a/modules/grids/app/services/grids/set_attributes_service.rb
+++ b/modules/grids/app/services/grids/set_attributes_service.rb
@@ -63,11 +63,11 @@ def update_widgets(widgets)
to_destroy.each(&:mark_for_destruction)
to_create.each do |widget|
- model.widgets.build widget.attributes.except('id')
+ model.widgets.build widget.attributes.except("id")
end
update_map.each do |existing, provided|
- existing.attributes = provided.attributes.except('id', 'grid_id')
+ existing.attributes = provided.attributes.except("id", "grid_id")
end
end
diff --git a/modules/grids/grids.gemspec b/modules/grids/grids.gemspec
index 835911e21062..f7558f57b4a9 100644
--- a/modules/grids/grids.gemspec
+++ b/modules/grids/grids.gemspec
@@ -1,9 +1,9 @@
Gem::Specification.new do |s|
s.name = "grids"
- s.version = '1.0.0'
+ s.version = "1.0.0"
s.authors = ["OpenProject"]
s.summary = "OpenProject Grids."
s.files = Dir["{app,config,db,lib}/**/*"]
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/grids/lib/grids.rb b/modules/grids/lib/grids.rb
index 6022892573d3..b4eaac18ede9 100644
--- a/modules/grids/lib/grids.rb
+++ b/modules/grids/lib/grids.rb
@@ -1,5 +1,5 @@
require "grids/engine"
-require 'grids/configuration'
+require "grids/configuration"
module Grids
end
diff --git a/modules/grids/lib/grids/configuration/in_project_base_registration.rb b/modules/grids/lib/grids/configuration/in_project_base_registration.rb
index 440b16e45820..ad268e575937 100644
--- a/modules/grids/lib/grids/configuration/in_project_base_registration.rb
+++ b/modules/grids/lib/grids/configuration/in_project_base_registration.rb
@@ -1,18 +1,18 @@
module Grids::Configuration
class InProjectBaseRegistration < ::Grids::Configuration::Registration
- widgets 'work_packages_table',
- 'work_packages_graph',
- 'project_description',
- 'project_status',
- 'project_details',
- 'subprojects',
- 'work_packages_calendar',
- 'work_packages_overview',
- 'time_entries_list',
- 'members',
- 'news',
- 'documents',
- 'custom_text'
+ widgets "work_packages_table",
+ "work_packages_graph",
+ "project_description",
+ "project_status",
+ "project_details",
+ "subprojects",
+ "work_packages_calendar",
+ "work_packages_overview",
+ "time_entries_list",
+ "members",
+ "news",
+ "documents",
+ "custom_text"
remove_query_lambda = -> {
::Query.find_by(id: options[:queryId])&.destroy
@@ -32,43 +32,43 @@ class InProjectBaseRegistration < ::Grids::Configuration::Registration
user.allowed_in_any_work_package?(:view_work_packages, in_project: project)
}
- widget_strategy 'work_packages_table' do
+ widget_strategy "work_packages_table" do
after_destroy remove_query_lambda
allowed save_or_manage_queries_lambda
- options_representer '::API::V3::Grids::Widgets::QueryOptionsRepresenter'
+ options_representer "::API::V3::Grids::Widgets::QueryOptionsRepresenter"
end
- widget_strategy 'work_packages_graph' do
+ widget_strategy "work_packages_graph" do
after_destroy remove_query_lambda
allowed queries_permission_and_ee_lambda
- options_representer '::API::V3::Grids::Widgets::ChartOptionsRepresenter'
+ options_representer "::API::V3::Grids::Widgets::ChartOptionsRepresenter"
end
- widget_strategy 'custom_text' do
- options_representer '::API::V3::Grids::Widgets::CustomTextOptionsRepresenter'
+ widget_strategy "custom_text" do
+ options_representer "::API::V3::Grids::Widgets::CustomTextOptionsRepresenter"
end
- widget_strategy 'work_packages_overview' do
+ widget_strategy "work_packages_overview" do
allowed view_work_packages_lambda
end
- widget_strategy 'work_packages_calendar' do
+ widget_strategy "work_packages_calendar" do
allowed view_work_packages_lambda
end
- widget_strategy 'members' do
+ widget_strategy "members" do
allowed ->(user, project) { user.allowed_in_project?(:view_members, project) }
end
- widget_strategy 'news' do
+ widget_strategy "news" do
allowed ->(user, project) { user.allowed_in_project?(:view_news, project) }
end
- widget_strategy 'documents' do
+ widget_strategy "documents" do
allowed ->(user, project) { user.allowed_in_project?(:view_documents, project) }
end
@@ -92,10 +92,10 @@ def all_scopes
def from_scope(scope)
# recognize_routes does not work with engine paths
path = [OpenProject::Configuration.rails_relative_url_root,
- 'projects',
- '([^/]+)',
+ "projects",
+ "([^/]+)",
in_project_scope_path,
- '?'].flatten.compact.join('/')
+ "?"].flatten.compact.join("/")
match = Regexp.new(path).match(scope)
return if match.nil?
diff --git a/modules/grids/lib/grids/configuration/registration.rb b/modules/grids/lib/grids/configuration/registration.rb
index 3136deb10c6b..3c075c17e431 100644
--- a/modules/grids/lib/grids/configuration/registration.rb
+++ b/modules/grids/lib/grids/configuration/registration.rb
@@ -127,13 +127,13 @@ def validations(mode = nil, proc = nil)
def register!
unless grid_class
- raise 'Need to define the grid class first. Use grid_class to do so.'
+ raise "Need to define the grid class first. Use grid_class to do so."
end
unless widgets
- raise 'Need to define at least one widget first. Use widgets to do so.'
+ raise "Need to define at least one widget first. Use widgets to do so."
end
unless to_scope
- raise 'Need to define a scope. Use to_scope to do so'
+ raise "Need to define a scope. Use to_scope to do so"
end
Grids::Configuration.register_grid(grid_class, self)
diff --git a/modules/grids/lib/grids/configuration/widget_strategy.rb b/modules/grids/lib/grids/configuration/widget_strategy.rb
index 9738665f9cc3..d160cef833b6 100644
--- a/modules/grids/lib/grids/configuration/widget_strategy.rb
+++ b/modules/grids/lib/grids/configuration/widget_strategy.rb
@@ -54,7 +54,7 @@ def options_representer(klass = nil)
@options_representer = klass
end
- @options_representer || '::API::V3::Grids::Widgets::DefaultOptionsRepresenter'
+ @options_representer || "::API::V3::Grids::Widgets::DefaultOptionsRepresenter"
end
end
end
diff --git a/modules/grids/spec/contracts/grids/create_contract_spec.rb b/modules/grids/spec/contracts/grids/create_contract_spec.rb
index c5a04e7623b8..d2c970205fca 100644
--- a/modules/grids/spec/contracts/grids/create_contract_spec.rb
+++ b/modules/grids/spec/contracts/grids/create_contract_spec.rb
@@ -26,46 +26,46 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_examples'
+require "spec_helper"
+require_relative "shared_examples"
RSpec.describe Grids::CreateContract do
- include_context 'grid contract'
- include_context 'model contract'
+ include_context "grid contract"
+ include_context "model contract"
- it_behaves_like 'shared grid contract attributes'
+ it_behaves_like "shared grid contract attributes"
- describe 'type' do
+ describe "type" do
let(:grid) { build_stubbed(:grid, default_values) }
- it_behaves_like 'is writable' do
+ it_behaves_like "is writable" do
let(:attribute) { :type }
- let(:value) { 'Grids::Grid' }
+ let(:value) { "Grids::Grid" }
end
end
- describe 'user_id' do
+ describe "user_id" do
let(:grid) { build_stubbed(:grid, default_values) }
- it_behaves_like 'is not writable' do
+ it_behaves_like "is not writable" do
let(:attribute) { :user_id }
let(:value) { 5 }
end
end
- describe 'project_id' do
+ describe "project_id" do
let(:grid) { build_stubbed(:grid, default_values) }
- it_behaves_like 'is not writable' do
+ it_behaves_like "is not writable" do
let(:attribute) { :project_id }
let(:value) { 5 }
end
end
- describe '#assignable_values' do
- context 'for scope' do
- it 'calls the grid configuration for the available values' do
- scopes = double('scopes')
+ describe "#assignable_values" do
+ context "for scope" do
+ it "calls the grid configuration for the available values" do
+ scopes = double("scopes")
allow(Grids::Configuration)
.to receive(:all_scopes)
@@ -76,8 +76,8 @@
end
end
- context 'for widgets' do
- it 'calls the grid configuration for the available values but allows only those eligible' do
+ context "for widgets" do
+ it "calls the grid configuration for the available values but allows only those eligible" do
widgets = %i[widget1 widget2]
allow(Grids::Configuration)
@@ -99,8 +99,8 @@
end
end
- context 'for something else' do
- it 'returns nil' do
+ context "for something else" do
+ it "returns nil" do
expect(instance.assignable_values(:something, user))
.to be_nil
end
diff --git a/modules/grids/spec/contracts/grids/delete_contract_spec.rb b/modules/grids/spec/contracts/grids/delete_contract_spec.rb
index 56b3648fbf13..f855a9068f10 100644
--- a/modules/grids/spec/contracts/grids/delete_contract_spec.rb
+++ b/modules/grids/spec/contracts/grids/delete_contract_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Grids::DeleteContract do
let(:user) { build_stubbed(:user) }
@@ -44,29 +44,29 @@
allow(grid).to receive(:user_deletable?).and_return(user_deletable)
end
- context 'when writable' do
+ context "when writable" do
let(:writable) { true }
let(:user_deletable) { true }
- it 'deletes the grid even if no valid widgets' do
+ it "deletes the grid even if no valid widgets" do
expect(instance.validate).to be_truthy
end
end
- context 'when not writable' do
+ context "when not writable" do
let(:writable) { false }
let(:user_deletable) { true }
- it 'deletes the grid even if not valid' do
+ it "deletes the grid even if not valid" do
expect(instance.validate).to be_falsey
end
end
- context 'when not deletable' do
+ context "when not deletable" do
let(:writable) { true }
let(:user_deletable) { false }
- it 'deletes the grid even if not valid' do
+ it "deletes the grid even if not valid" do
expect(instance.validate).to be_falsey
end
end
diff --git a/modules/grids/spec/contracts/grids/shared_examples.rb b/modules/grids/spec/contracts/grids/shared_examples.rb
index 9c05ad4841f6..89a431a0e561 100644
--- a/modules/grids/spec/contracts/grids/shared_examples.rb
+++ b/modules/grids/spec/contracts/grids/shared_examples.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-RSpec.shared_context 'grid contract' do
+RSpec.shared_context "grid contract" do
let(:user) { build_stubbed(:user) }
let(:instance) { described_class.new(grid, user) }
let(:widgets) { [] }
@@ -41,11 +41,11 @@
build_stubbed(:grid, default_values)
end
- shared_examples_for 'validates positive integer' do
- context 'when the value is negative' do
+ shared_examples_for "validates positive integer" do
+ context "when the value is negative" do
let(:value) { -1 }
- it 'is invalid' do
+ it "is invalid" do
instance.validate
expect(instance.errors.details[attribute])
@@ -53,10 +53,10 @@
end
end
- context 'when the value is nil' do
+ context "when the value is nil" do
let(:value) { nil }
- it 'is invalid' do
+ it "is invalid" do
instance.validate
expect(instance.errors.details[attribute])
@@ -66,24 +66,24 @@
end
end
-RSpec.shared_examples_for 'shared grid contract attributes' do
- include_context 'model contract'
+RSpec.shared_examples_for "shared grid contract attributes" do
+ include_context "model contract"
let(:model) { grid }
- describe 'row_count' do
- it_behaves_like 'is writable' do
+ describe "row_count" do
+ it_behaves_like "is writable" do
let(:attribute) { :row_count }
let(:value) { 5 }
- it_behaves_like 'validates positive integer'
+ it_behaves_like "validates positive integer"
end
- context 'row_count less than 1' do
+ context "row_count less than 1" do
before do
grid.row_count = 0
end
- it 'notes the error' do
+ it "notes the error" do
instance.validate
expect(instance.errors.details[:row_count])
.to contain_exactly({ error: :greater_than, count: 0 })
@@ -91,20 +91,20 @@
end
end
- describe 'column_count' do
- it_behaves_like 'is writable' do
+ describe "column_count" do
+ it_behaves_like "is writable" do
let(:attribute) { :column_count }
let(:value) { 5 }
- it_behaves_like 'validates positive integer'
+ it_behaves_like "validates positive integer"
end
- context 'row_count less than 1' do
+ context "row_count less than 1" do
before do
grid.column_count = 0
end
- it 'notes the error' do
+ it "notes the error" do
instance.validate
expect(instance.errors.details[:column_count])
.to contain_exactly({ error: :greater_than, count: 0 })
@@ -112,8 +112,8 @@
end
end
- describe 'valid grid subclasses' do
- context 'for the Grid superclass itself' do
+ describe "valid grid subclasses" do
+ context "for the Grid superclass itself" do
let(:grid) do
build_stubbed(:grid, default_values)
end
@@ -122,14 +122,14 @@
instance.validate
end
- it 'is invalid for the grid superclass itself' do
+ it "is invalid for the grid superclass itself" do
expect(instance.errors.details[:scope])
.to contain_exactly({ error: :inclusion })
end
end
end
- describe 'widgets' do
+ describe "widgets" do
before do
allow(Grids::Configuration)
.to receive(:writable?)
@@ -142,21 +142,21 @@
allow(Grids::Configuration)
.to receive(:allowed_widget?)
- .with(Grids::Grid, 'widget1', user, nil)
+ .with(Grids::Grid, "widget1", user, nil)
.and_return(true)
allow(Grids::Configuration)
.to receive(:allowed_widget?)
- .with(Grids::Grid, 'widget2', user, nil)
+ .with(Grids::Grid, "widget2", user, nil)
.and_return(false)
end
- context 'if there are new widgets that are not allowed' do
+ context "if there are new widgets that are not allowed" do
let(:widgets) do
- [Grids::Widget.new(identifier: 'widget2', start_row: 1, end_row: 3, start_column: 1, end_column: 3)]
+ [Grids::Widget.new(identifier: "widget2", start_row: 1, end_row: 3, start_column: 1, end_column: 3)]
end
- it 'notes the error' do
+ it "notes the error" do
instance.validate
expect(instance.errors.details[:widgets])
@@ -164,20 +164,20 @@
end
end
- context 'if there are new widgets that are allowed' do
+ context "if there are new widgets that are allowed" do
let(:widgets) do
- [Grids::Widget.new(identifier: 'widget1', start_row: 1, end_row: 3, start_column: 1, end_column: 3)]
+ [Grids::Widget.new(identifier: "widget1", start_row: 1, end_row: 3, start_column: 1, end_column: 3)]
end
- it 'is valid' do
+ it "is valid" do
expect(instance.validate)
.to be_truthy
end
end
- context 'if there are new widgets that are not allowed but marked for destruction' do
+ context "if there are new widgets that are not allowed but marked for destruction" do
let(:widgets) do
- widget = Grids::Widget.new(identifier: 'widget2', start_row: 1, end_row: 3, start_column: 1, end_column: 3)
+ widget = Grids::Widget.new(identifier: "widget2", start_row: 1, end_row: 3, start_column: 1, end_column: 3)
allow(widget)
.to receive(:marked_for_destruction?)
@@ -186,18 +186,18 @@
[widget]
end
- it 'is valid' do
+ it "is valid" do
expect(instance.validate)
.to be_truthy
end
end
- context 'if there are existing widgets that are not allowed' do
+ context "if there are existing widgets that are not allowed" do
let(:widgets) do
- [build_stubbed(:grid_widget, identifier: 'widget2', start_row: 1, end_row: 3, start_column: 1, end_column: 3)]
+ [build_stubbed(:grid_widget, identifier: "widget2", start_row: 1, end_row: 3, start_column: 1, end_column: 3)]
end
- it 'is valid' do
+ it "is valid" do
expect(instance.validate)
.to be_truthy
end
diff --git a/modules/grids/spec/contracts/grids/update_contract_spec.rb b/modules/grids/spec/contracts/grids/update_contract_spec.rb
index 6bb5114b3d95..f37f26c68d01 100644
--- a/modules/grids/spec/contracts/grids/update_contract_spec.rb
+++ b/modules/grids/spec/contracts/grids/update_contract_spec.rb
@@ -26,26 +26,26 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_examples'
+require "spec_helper"
+require_relative "shared_examples"
RSpec.describe Grids::UpdateContract do
- include_context 'model contract'
- include_context 'grid contract'
+ include_context "model contract"
+ include_context "grid contract"
- it_behaves_like 'shared grid contract attributes'
+ it_behaves_like "shared grid contract attributes"
- describe 'type' do
+ describe "type" do
before do
- grid.type = 'Grid'
+ grid.type = "Grid"
end
- it 'is not writable' do
+ it "is not writable" do
expect(instance.validate)
.to be_falsey
end
- it 'explains the not writable error' do
+ it "explains the not writable error" do
instance.validate
# scope because that is what type is called on the outside for grids
expect(instance.errors.details[:scope])
@@ -53,16 +53,16 @@
end
end
- describe 'user_id' do
- it_behaves_like 'is not writable' do
+ describe "user_id" do
+ it_behaves_like "is not writable" do
let(:model) { grid }
let(:attribute) { :user_id }
let(:value) { 5 }
end
end
- describe 'project_id' do
- it_behaves_like 'is not writable' do
+ describe "project_id" do
+ it_behaves_like "is not writable" do
let(:model) { grid }
let(:attribute) { :project_id }
let(:value) { 5 }
diff --git a/modules/grids/spec/factories/grid_factory.rb b/modules/grids/spec/factories/grid_factory.rb
index 477191983ab9..de0f77668bc4 100644
--- a/modules/grids/spec/factories/grid_factory.rb
+++ b/modules/grids/spec/factories/grid_factory.rb
@@ -1,5 +1,5 @@
FactoryBot.define do
- factory :grid, class: 'Grids::Grid' do
+ factory :grid, class: "Grids::Grid" do
row_count { 5 }
column_count { 5 }
end
diff --git a/modules/grids/spec/factories/grid_widget_factory.rb b/modules/grids/spec/factories/grid_widget_factory.rb
index 0e5dcedea21d..dae2774f785c 100644
--- a/modules/grids/spec/factories/grid_widget_factory.rb
+++ b/modules/grids/spec/factories/grid_widget_factory.rb
@@ -1,4 +1,4 @@
FactoryBot.define do
- factory :grid_widget, class: 'Grids::Widget' do
+ factory :grid_widget, class: "Grids::Widget" do
end
end
diff --git a/modules/grids/spec/lib/api/v3/grids/grid_payload_representer_parsing_spec.rb b/modules/grids/spec/lib/api/v3/grids/grid_payload_representer_parsing_spec.rb
index 0b21f150a834..b949add58815 100644
--- a/modules/grids/spec/lib/api/v3/grids/grid_payload_representer_parsing_spec.rb
+++ b/modules/grids/spec/lib/api/v3/grids/grid_payload_representer_parsing_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Grids::GridPayloadRepresenter, 'parsing' do
+RSpec.describe API::V3::Grids::GridPayloadRepresenter, "parsing" do
include API::V3::Utilities::PathHelper
let(:object) do
@@ -46,7 +46,7 @@
"widgets" => [
{
_type: "Widget",
- identifier: 'work_packages_assigned',
+ identifier: "work_packages_assigned",
startRow: 4,
endRow: 5,
startColumn: 1,
@@ -54,7 +54,7 @@
},
{
_type: "Widget",
- identifier: 'work_packages_created',
+ identifier: "work_packages_created",
startRow: 1,
endRow: 2,
startColumn: 1,
@@ -62,7 +62,7 @@
},
{
_type: "Widget",
- identifier: 'work_packages_watched',
+ identifier: "work_packages_watched",
startRow: 2,
endRow: 4,
startColumn: 4,
@@ -71,45 +71,45 @@
],
"_links" => {
"scope" => {
- "href" => 'some_path'
+ "href" => "some_path"
}
}
}
end
- describe '_links' do
- context 'scope' do
- it 'updates page' do
+ describe "_links" do
+ context "scope" do
+ it "updates page" do
grid = representer.from_hash(hash)
expect(grid.scope)
- .to eql('some_path')
+ .to eql("some_path")
end
end
end
- describe 'properties' do
- context 'rowCount' do
- it 'updates row_count' do
+ describe "properties" do
+ context "rowCount" do
+ it "updates row_count" do
grid = representer.from_hash(hash)
expect(grid.row_count)
.to be(10)
end
end
- context 'columnCount' do
- it 'updates column_count' do
+ context "columnCount" do
+ it "updates column_count" do
grid = representer.from_hash(hash)
expect(grid.column_count)
.to be(20)
end
end
- context 'widgets' do
- it 'updates widgets' do
+ context "widgets" do
+ it "updates widgets" do
grid = representer.from_hash(hash)
expect(grid.widgets[0].identifier)
- .to eql('work_packages_assigned')
+ .to eql("work_packages_assigned")
expect(grid.widgets[0].start_row)
.to be(4)
expect(grid.widgets[0].end_row)
@@ -120,7 +120,7 @@
.to be(2)
expect(grid.widgets[1].identifier)
- .to eql('work_packages_created')
+ .to eql("work_packages_created")
expect(grid.widgets[1].start_row)
.to be(1)
expect(grid.widgets[1].end_row)
@@ -131,7 +131,7 @@
.to be(2)
expect(grid.widgets[2].identifier)
- .to eql('work_packages_watched')
+ .to eql("work_packages_watched")
expect(grid.widgets[2].start_row)
.to be(2)
expect(grid.widgets[2].end_row)
diff --git a/modules/grids/spec/lib/api/v3/grids/grid_representer_rendering_spec.rb b/modules/grids/spec/lib/api/v3/grids/grid_representer_rendering_spec.rb
index 8eb18241764a..b388247b772c 100644
--- a/modules/grids/spec/lib/api/v3/grids/grid_representer_rendering_spec.rb
+++ b/modules/grids/spec/lib/api/v3/grids/grid_representer_rendering_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Grids::GridRepresenter, 'rendering' do
+RSpec.describe API::V3::Grids::GridRepresenter, "rendering" do
include OpenProject::StaticRouting::UrlHelpers
include API::V3::Utilities::PathHelper
@@ -40,7 +40,7 @@
widgets: [
build_stubbed(
:grid_widget,
- identifier: 'work_packages_assigned',
+ identifier: "work_packages_assigned",
start_row: 4,
end_row: 5,
start_column: 1,
@@ -48,7 +48,7 @@
),
build_stubbed(
:grid_widget,
- identifier: 'work_packages_created',
+ identifier: "work_packages_created",
start_row: 1,
end_row: 2,
start_column: 1,
@@ -56,7 +56,7 @@
),
build_stubbed(
:grid_widget,
- identifier: 'work_packages_watched',
+ identifier: "work_packages_watched",
start_row: 2,
end_row: 4,
start_column: 4,
@@ -71,7 +71,7 @@
let(:representer) { described_class.new(grid, current_user:, embed_links:) }
let(:writable) { true }
- let(:scope_path) { 'bogus_scope' }
+ let(:scope_path) { "bogus_scope" }
let(:attachment_addable) { true }
before do
@@ -93,54 +93,54 @@
.and_return(attachment_addable)
end
- context 'generation' do
+ context "generation" do
subject(:generated) { representer.to_json }
- context 'properties' do
- it 'denotes its type' do
+ context "properties" do
+ it "denotes its type" do
expect(subject)
- .to be_json_eql('Grid'.to_json)
- .at_path('_type')
+ .to be_json_eql("Grid".to_json)
+ .at_path("_type")
end
- it 'has an id' do
+ it "has an id" do
expect(subject)
.to be_json_eql(grid.id)
- .at_path('id')
+ .at_path("id")
end
- it 'has a rowCount' do
+ it "has a rowCount" do
expect(subject)
.to be_json_eql(4)
- .at_path('rowCount')
+ .at_path("rowCount")
end
- it 'has a columnCount' do
+ it "has a columnCount" do
expect(subject)
.to be_json_eql(5)
- .at_path('columnCount')
+ .at_path("columnCount")
end
- describe 'createdAt' do
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ describe "createdAt" do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { grid.created_at }
- let(:json_path) { 'createdAt' }
+ let(:json_path) { "createdAt" }
end
end
- describe 'updatedAt' do
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ describe "updatedAt" do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { grid.updated_at }
- let(:json_path) { 'updatedAt' }
+ let(:json_path) { "updatedAt" }
end
end
- it 'has a list of widgets' do
+ it "has a list of widgets" do
widgets = [
{
_type: "GridWidget",
id: grid.widgets[0].id,
- identifier: 'work_packages_assigned',
+ identifier: "work_packages_assigned",
options: {},
startRow: 4,
endRow: 5,
@@ -150,7 +150,7 @@
{
_type: "GridWidget",
id: grid.widgets[1].id,
- identifier: 'work_packages_created',
+ identifier: "work_packages_created",
options: {},
startRow: 1,
endRow: 2,
@@ -160,7 +160,7 @@
{
_type: "GridWidget",
id: grid.widgets[2].id,
- identifier: 'work_packages_watched',
+ identifier: "work_packages_watched",
options: {},
startRow: 2,
endRow: 4,
@@ -171,41 +171,41 @@
expect(subject)
.to be_json_eql(widgets.to_json)
- .at_path('widgets')
+ .at_path("widgets")
end
end
- context '_links' do
- context 'self link' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ context "_links" do
+ context "self link" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { "/api/v3/grids/#{grid.id}" }
end
end
- context 'update link' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'update' }
+ context "update link" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "update" }
let(:href) { "/api/v3/grids/#{grid.id}/form" }
let(:method) { :post }
end
end
- context 'updateImmediately link' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'updateImmediately' }
+ context "updateImmediately link" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "updateImmediately" }
let(:href) { "/api/v3/grids/#{grid.id}" }
let(:method) { :patch }
end
end
- context 'scope link' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'scope' }
+ context "scope link" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "scope" }
let(:href) { scope_path }
let(:type) { "text/html" }
- it 'has a content type of html' do
+ it "has a content type of html" do
expect(subject)
.to be_json_eql(type.to_json)
.at_path("_links/#{link}/type")
@@ -213,32 +213,32 @@
end
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'attachments' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "attachments" }
let(:href) { api_v3_paths.attachments_by_grid(grid.id) }
end
- context 'addAttachments link' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'addAttachment' }
+ context "addAttachments link" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "addAttachment" }
let(:href) { api_v3_paths.attachments_by_grid(grid.id) }
end
- context 'user is not allowed to edit work packages' do
+ context "user is not allowed to edit work packages" do
let(:attachment_addable) { false }
- it_behaves_like 'has no link' do
- let(:link) { 'addAttachment' }
+ it_behaves_like "has no link" do
+ let(:link) { "addAttachment" }
end
end
end
end
- context 'embedded' do
- it 'embeds the attachments as collection' do
+ context "embedded" do
+ it "embeds the attachments as collection" do
expect(subject)
- .to be_json_eql('Collection'.to_json)
- .at_path('_embedded/attachments/_type')
+ .to be_json_eql("Collection".to_json)
+ .at_path("_embedded/attachments/_type")
end
end
end
diff --git a/modules/grids/spec/lib/api/v3/grids/schemas/grid_schema_representer_spec.rb b/modules/grids/spec/lib/api/v3/grids/schemas/grid_schema_representer_spec.rb
index 718a0d9d462f..0e56bd51a6a3 100644
--- a/modules/grids/spec/lib/api/v3/grids/schemas/grid_schema_representer_spec.rb
+++ b/modules/grids/spec/lib/api/v3/grids/schemas/grid_schema_representer_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Grids::Schemas::GridSchemaRepresenter do
include API::V3::Utilities::PathHelper
let(:current_user) { build_stubbed(:user) }
- let(:self_link) { '/a/self/link' }
+ let(:self_link) { "/a/self/link" }
let(:embedded) { true }
let(:new_record) { true }
let(:allowed_scopes) { %w(/some/path /some/other/path) }
@@ -41,14 +41,14 @@
%w(first_widget second_widget)
end
let(:contract) do
- contract = double('contract')
+ contract = double("contract")
allow(contract)
.to receive(:writable?) do |attribute|
writable = %w(row_count column_count widgets)
if new_record
- writable << 'scope'
+ writable << "scope"
end
writable.include?(attribute.to_s)
@@ -65,7 +65,7 @@
allow(contract)
.to receive(:model)
- .and_return(double('model'))
+ .and_return(double("model"))
contract
end
@@ -76,89 +76,89 @@
current_user:)
end
- context 'generation' do
+ context "generation" do
subject(:generated) { representer.to_json }
- describe '_type' do
- it 'is indicated as Schema' do
- expect(subject).to be_json_eql('Schema'.to_json).at_path('_type')
+ describe "_type" do
+ it "is indicated as Schema" do
+ expect(subject).to be_json_eql("Schema".to_json).at_path("_type")
end
end
- describe 'id' do
- let(:path) { 'id' }
+ describe "id" do
+ let(:path) { "id" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Integer' }
- let(:name) { I18n.t('attributes.id') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Integer" }
+ let(:name) { I18n.t("attributes.id") }
let(:required) { true }
let(:writable) { false }
end
end
- describe 'rowCount' do
- let(:path) { 'rowCount' }
+ describe "rowCount" do
+ let(:path) { "rowCount" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Integer' }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Integer" }
let(:name) { Grids::Grid.human_attribute_name(:row_count) }
let(:required) { true }
let(:writable) { true }
end
end
- describe 'columnCount' do
- let(:path) { 'columnCount' }
+ describe "columnCount" do
+ let(:path) { "columnCount" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Integer' }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Integer" }
let(:name) { Grids::Grid.human_attribute_name(:column_count) }
let(:required) { true }
let(:writable) { true }
end
end
- describe 'createdAt' do
- let(:path) { 'createdAt' }
+ describe "createdAt" do
+ let(:path) { "createdAt" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'DateTime' }
- let(:name) { Grids::Grid.human_attribute_name('created_at') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "DateTime" }
+ let(:name) { Grids::Grid.human_attribute_name("created_at") }
let(:required) { true }
let(:writable) { false }
end
end
- describe 'updatedAt' do
- let(:path) { 'updatedAt' }
+ describe "updatedAt" do
+ let(:path) { "updatedAt" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'DateTime' }
- let(:name) { Grids::Grid.human_attribute_name('updated_at') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "DateTime" }
+ let(:name) { Grids::Grid.human_attribute_name("updated_at") }
let(:required) { true }
let(:writable) { false }
end
end
- describe 'widgets' do
- let(:path) { 'widgets' }
+ describe "widgets" do
+ let(:path) { "widgets" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { '[]GridWidget' }
- let(:name) { Grids::Grid.human_attribute_name('widgets') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "[]GridWidget" }
+ let(:name) { Grids::Grid.human_attribute_name("widgets") }
let(:required) { true }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- context 'when embedding' do
+ context "when embedding" do
let(:embedded) { true }
- it 'contains no link to the allowed values' do
+ it "contains no link to the allowed values" do
expect(subject).not_to have_json_path("#{path}/_links/allowedValues")
end
- it 'embeds the allowed values' do
+ it "embeds the allowed values" do
allowed_widgets.each_with_index do |identifier, index|
href_path = "#{path}/_embedded/allowedValues/#{index}/identifier"
expect(subject).to be_json_eql(identifier.to_json).at_path(href_path)
@@ -166,98 +166,98 @@
end
end
- context 'when not embedding' do
+ context "when not embedding" do
let(:embedded) { false }
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
end
end
- describe 'scope' do
- let(:path) { 'scope' }
+ describe "scope" do
+ let(:path) { "scope" }
- context 'when having a new record' do
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Href' }
- let(:name) { Grids::Grid.human_attribute_name('scope') }
+ context "when having a new record" do
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Href" }
+ let(:name) { Grids::Grid.human_attribute_name("scope") }
let(:required) { true }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- context 'when embedding' do
+ context "when embedding" do
let(:embedded) { true }
- it_behaves_like 'links to allowed values directly' do
+ it_behaves_like "links to allowed values directly" do
let(:hrefs) { allowed_scopes }
end
- it 'does not embed' do
+ it "does not embed" do
expect(generated)
- .not_to have_json_path('scope/embedded')
+ .not_to have_json_path("scope/embedded")
end
end
- context 'when not embedding' do
+ context "when not embedding" do
let(:embedded) { false }
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
- it 'does not embed' do
+ it "does not embed" do
expect(generated)
- .not_to have_json_path('scope/embedded')
+ .not_to have_json_path("scope/embedded")
end
end
end
- context 'when not having a new record' do
+ context "when not having a new record" do
let(:new_record) { false }
let(:allowed_scopes) { nil }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Href' }
- let(:name) { Grids::Grid.human_attribute_name('scope') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Href" }
+ let(:name) { Grids::Grid.human_attribute_name("scope") }
let(:required) { true }
let(:writable) { false }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- context 'when embedding' do
+ context "when embedding" do
let(:embedded) { true }
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
- it 'does not embed' do
+ it "does not embed" do
expect(generated)
- .not_to have_json_path('scope/embedded')
+ .not_to have_json_path("scope/embedded")
end
end
- context 'when not embedding' do
+ context "when not embedding" do
let(:embedded) { false }
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
- it 'does not embed' do
+ it "does not embed" do
expect(generated)
- .not_to have_json_path('scope/embedded')
+ .not_to have_json_path("scope/embedded")
end
end
end
end
- context '_links' do
- describe 'self link' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ context "_links" do
+ describe "self link" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { self_link }
end
- context 'embedded in a form' do
+ context "embedded in a form" do
let(:self_link) { nil }
- it_behaves_like 'has no link' do
- let(:link) { 'self' }
+ it_behaves_like "has no link" do
+ let(:link) { "self" }
end
end
end
diff --git a/modules/grids/spec/lib/api/v3/utilities/file_helper_spec.rb b/modules/grids/spec/lib/api/v3/utilities/file_helper_spec.rb
index d37e8f98dc6b..1439b34b661a 100644
--- a/modules/grids/spec/lib/api/v3/utilities/file_helper_spec.rb
+++ b/modules/grids/spec/lib/api/v3/utilities/file_helper_spec.rb
@@ -26,17 +26,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Utilities::PathHelper do
let(:helper) { Class.new.tap { |c| c.extend(API::V3::Utilities::PathHelper) }.api_v3_paths }
- context 'attachments paths' do
- describe '#attachments_by_grid' do
+ context "attachments paths" do
+ describe "#attachments_by_grid" do
subject { helper.attachments_by_grid 1 }
- it 'provides the path' do
- expect(subject).to match('/grids/1/attachments')
+ it "provides the path" do
+ expect(subject).to match("/grids/1/attachments")
end
end
end
diff --git a/modules/grids/spec/models/grids/grid_spec.rb b/modules/grids/spec/models/grids/grid_spec.rb
index a1edc503f0ae..6298a25f763e 100644
--- a/modules/grids/spec/models/grids/grid_spec.rb
+++ b/modules/grids/spec/models/grids/grid_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_model'
+require "spec_helper"
+require_relative "shared_model"
RSpec.describe Grids::Grid do
let(:instance) { Grids::Grid.new column_count: 5, row_count: 5 }
- it_behaves_like 'grid attributes'
+ it_behaves_like "grid attributes"
end
diff --git a/modules/grids/spec/models/grids/shared_model.rb b/modules/grids/spec/models/grids/shared_model.rb
index d21bd87805fd..c1910eaaa2a9 100644
--- a/modules/grids/spec/models/grids/shared_model.rb
+++ b/modules/grids/spec/models/grids/shared_model.rb
@@ -26,33 +26,33 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-RSpec.shared_examples_for 'grid attributes' do
- describe 'attributes' do
- it '#row_count' do
+RSpec.shared_examples_for "grid attributes" do
+ describe "attributes" do
+ it "#row_count" do
instance.row_count = 5
expect(instance.row_count)
.to be 5
end
- it '#column_count' do
+ it "#column_count" do
instance.column_count = 5
expect(instance.column_count)
.to be 5
end
- it '#name' do
- instance.name = 'custom 123'
+ it "#name" do
+ instance.name = "custom 123"
expect(instance.name)
- .to eql 'custom 123'
+ .to eql "custom 123"
# can be empty
instance.name = nil
expect(instance).to be_valid
end
- it '#options' do
+ it "#options" do
value = {
- some: 'value',
+ some: "value",
and: {
also: 1
}
@@ -63,7 +63,7 @@
.to eql value
end
- it '#widgets' do
+ it "#widgets" do
widgets = [
Grids::Widget.new(start_row: 2),
Grids::Widget.new(start_row: 5)
@@ -75,7 +75,7 @@
end
end
- it_behaves_like 'acts_as_attachable included' do
+ it_behaves_like "acts_as_attachable included" do
let(:model_instance) { instance }
let(:project) { create(:project) }
end
diff --git a/modules/grids/spec/models/grids/widget_spec.rb b/modules/grids/spec/models/grids/widget_spec.rb
index 20a43ea07dfb..d92562c3f319 100644
--- a/modules/grids/spec/models/grids/widget_spec.rb
+++ b/modules/grids/spec/models/grids/widget_spec.rb
@@ -26,45 +26,45 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Grids::Widget do
let(:instance) { Grids::Widget.new }
- describe 'attributes' do
- it '#start_row' do
+ describe "attributes" do
+ it "#start_row" do
instance.start_row = 5
expect(instance.start_row)
.to be 5
end
- it '#end_row' do
+ it "#end_row" do
instance.end_row = 5
expect(instance.end_row)
.to be 5
end
- it '#start_column' do
+ it "#start_column" do
instance.start_column = 5
expect(instance.start_column)
.to be 5
end
- it '#end_column' do
+ it "#end_column" do
instance.end_column = 5
expect(instance.end_column)
.to be 5
end
- it '#identifier' do
- instance.identifier = 'some_identifier'
+ it "#identifier" do
+ instance.identifier = "some_identifier"
expect(instance.identifier)
- .to eql 'some_identifier'
+ .to eql "some_identifier"
end
- it '#options' do
+ it "#options" do
value = {
- some: 'value',
+ some: "value",
and: {
also: 1
}
@@ -75,7 +75,7 @@
.to eql value
end
- it '#grid' do
+ it "#grid" do
grid = Grids::Grid.new
instance.grid = grid
expect(instance.grid)
diff --git a/modules/grids/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb b/modules/grids/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb
index 5524c6a470d2..e708d1f597ed 100644
--- a/modules/grids/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb
+++ b/modules/grids/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
RSpec.describe "POST /api/v3/grids/form", content_type: :json do
include Rack::Test::Methods
@@ -46,23 +46,23 @@
login_as(current_user)
end
- describe '#post' do
+ describe "#post" do
before do
- post path, params.to_json, 'CONTENT_TYPE' => 'application/json'
+ post path, params.to_json, "CONTENT_TYPE" => "application/json"
end
- it 'returns 200 OK' do
+ it "returns 200 OK" do
expect(subject.status)
.to be 200
end
- it 'is of type form' do
+ it "is of type form" do
expect(subject.body)
.to be_json_eql("Form".to_json)
- .at_path('_type')
+ .at_path("_type")
end
- it 'contains default data in the payload' do
+ it "contains default data in the payload" do
expected = {
rowCount: 4,
columnCount: 5,
@@ -75,18 +75,18 @@
expect(subject.body)
.to be_json_eql(expected.to_json)
- .at_path('_embedded/payload')
+ .at_path("_embedded/payload")
end
- it 'has a validation error on scope' do
+ it "has a validation error on scope" do
expect(subject.body)
.to be_json_eql("Scope is not set to one of the allowed values.".to_json)
- .at_path('_embedded/validationErrors/scope/message')
+ .at_path("_embedded/validationErrors/scope/message")
end
- it 'does not have a commit link' do
+ it "does not have a commit link" do
expect(subject.body)
- .not_to have_json_path('_links/commit')
+ .not_to have_json_path("_links/commit")
end
end
end
diff --git a/modules/grids/spec/requests/api/v3/grids/grids_resource_spec.rb b/modules/grids/spec/requests/api/v3/grids/grids_resource_spec.rb
index 434c6c287a4e..b58606aabca9 100644
--- a/modules/grids/spec/requests/api/v3/grids/grids_resource_spec.rb
+++ b/modules/grids/spec/requests/api/v3/grids/grids_resource_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'API v3 Grids resource', content_type: :json do
+RSpec.describe "API v3 Grids resource", content_type: :json do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -43,26 +43,26 @@
subject(:response) { last_response }
- describe '#get INDEX' do
+ describe "#get INDEX" do
let(:path) { api_v3_paths.grids }
before do
get path
end
- it 'responds with 200 OK' do
+ it "responds with 200 OK" do
expect(subject.status).to eq(200)
end
end
- describe '#post' do
+ describe "#post" do
let(:path) { api_v3_paths.grids }
before do
- post path, params.to_json, 'CONTENT_TYPE' => 'application/json'
+ post path, params.to_json, "CONTENT_TYPE" => "application/json"
end
- context 'without a page link' do
+ context "without a page link" do
let(:params) do
{
rowCount: 5,
@@ -77,23 +77,23 @@
}.with_indifferent_access
end
- it 'responds with 422' do
+ it "responds with 422" do
expect(subject.status).to eq(422)
end
- it 'does not create a grid' do
+ it "does not create a grid" do
expect(Grids::Grid.count)
.to be(0)
end
- it 'returns the errors' do
+ it "returns the errors" do
expect(subject.body)
- .to be_json_eql('Error'.to_json)
- .at_path('_type')
+ .to be_json_eql("Error".to_json)
+ .at_path("_type")
expect(subject.body)
.to be_json_eql("Scope is not set to one of the allowed values.".to_json)
- .at_path('message')
+ .at_path("message")
end
end
end
diff --git a/modules/grids/spec/requests/api/v3/grids/grids_schema_resource_spec.rb b/modules/grids/spec/requests/api/v3/grids/grids_schema_resource_spec.rb
index 3429e72990d9..68afe1542497 100644
--- a/modules/grids/spec/requests/api/v3/grids/grids_schema_resource_spec.rb
+++ b/modules/grids/spec/requests/api/v3/grids/grids_schema_resource_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'API v3 Grids schema resource', content_type: :json do
+RSpec.describe "API v3 Grids schema resource", content_type: :json do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -45,24 +45,24 @@
subject(:response) { last_response }
- describe '#GET /grids/schema' do
+ describe "#GET /grids/schema" do
before do
get path
end
- it 'responds with 200 OK' do
+ it "responds with 200 OK" do
expect(subject.status).to eq(200)
end
- it 'returns a schema' do
+ it "returns a schema" do
expect(subject.body)
- .to be_json_eql('Schema'.to_json)
- .at_path '_type'
+ .to be_json_eql("Schema".to_json)
+ .at_path "_type"
end
- it 'does not embed' do
+ it "does not embed" do
expect(subject.body)
- .not_to have_json_path('page/_links/allowedValues')
+ .not_to have_json_path("page/_links/allowedValues")
end
end
end
diff --git a/modules/grids/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb b/modules/grids/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb
index bebfc2126e6f..f63d0b0d0cd9 100644
--- a/modules/grids/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb
+++ b/modules/grids/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
RSpec.describe "PATCH /api/v3/grids/:id/form", content_type: :json do
include Rack::Test::Methods
@@ -45,15 +45,15 @@
login_as(current_user)
end
- describe '#post' do
+ describe "#post" do
before do
- post path, params.to_json, 'CONTENT_TYPE' => 'application/json'
+ post path, params.to_json, "CONTENT_TYPE" => "application/json"
end
- context 'for a non existing grid' do
+ context "for a non existing grid" do
let(:path) { api_v3_paths.grid_form(5) }
- it 'returns 404 NOT FOUND' do
+ it "returns 404 NOT FOUND" do
expect(subject.status)
.to be 404
end
diff --git a/modules/grids/spec/services/grids/create_service_spec.rb b/modules/grids/spec/services/grids/create_service_spec.rb
index 8e87e4ee9b45..13929ad99e90 100644
--- a/modules/grids/spec/services/grids/create_service_spec.rb
+++ b/modules/grids/spec/services/grids/create_service_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'services/base_services/behaves_like_create_service'
+require "spec_helper"
+require "services/base_services/behaves_like_create_service"
RSpec.describe Grids::CreateService, type: :model do
- it_behaves_like 'BaseServices create service' do
+ it_behaves_like "BaseServices create service" do
let(:model_class) { Grids::Grid }
end
end
diff --git a/modules/grids/spec/services/grids/set_attributes_service_spec.rb b/modules/grids/spec/services/grids/set_attributes_service_spec.rb
index e95d438355b8..c1d324c867d4 100644
--- a/modules/grids/spec/services/grids/set_attributes_service_spec.rb
+++ b/modules/grids/spec/services/grids/set_attributes_service_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Grids::SetAttributesService, type: :model do
let(:user) { build_stubbed(:user) }
let(:contract_class) do
- contract = double('contract_class')
+ contract = double("contract_class")
allow(contract)
.to receive(:new)
@@ -41,11 +41,11 @@
contract
end
let(:contract_instance) do
- double('contract_instance', validate: contract_valid, errors: contract_errors)
+ double("contract_instance", validate: contract_valid, errors: contract_errors)
end
let(:contract_valid) { true }
let(:contract_errors) do
- double('contract_errors')
+ double("contract_errors")
end
let(:grid_valid) { true }
let(:instance) do
@@ -59,7 +59,7 @@
build_stubbed(grid_class.name.demodulize.underscore.to_sym, widgets: [])
end
- describe 'call' do
+ describe "call" do
let(:call_attributes) do
{
column_count: 6
@@ -74,29 +74,29 @@
subject { instance.call(call_attributes) }
- it 'is successful' do
+ it "is successful" do
expect(subject.success?).to be_truthy
end
- it 'sets the attributes' do
+ it "sets the attributes" do
subject
expect(grid.attributes.slice(*grid.changed).symbolize_keys)
.to eql call_attributes
end
- it 'does not persist the grid' do
+ it "does not persist the grid" do
expect(grid)
.not_to receive(:save)
subject
end
- context 'with additional widgets' do
+ context "with additional widgets" do
let(:widgets) do
[
build_stubbed(:grid_widget,
- identifier: 'work_packages_assigned',
+ identifier: "work_packages_assigned",
start_row: 3,
end_row: 5,
start_column: 1,
@@ -114,34 +114,34 @@
subject
end
- it 'adds the new widgets' do
+ it "adds the new widgets" do
expect(grid.widgets.length)
.to be 1
end
- it 'does not persist the new widget' do
+ it "does not persist the new widget" do
expect(grid.widgets[0])
.to be_new_record
end
- it 'applies the provided values' do
- expect(grid.widgets[0].attributes.except('id'))
- .to eql widgets[0].attributes.except('id').merge('grid_id' => grid.id)
+ it "applies the provided values" do
+ expect(grid.widgets[0].attributes.except("id"))
+ .to eql widgets[0].attributes.except("id").merge("grid_id" => grid.id)
end
- context 'with the widget not being allowed' do
+ context "with the widget not being allowed" do
before do
allow(Grids::Configuration)
.to receive(:allowed_widget?)
- .with(grid, 'work_packages_assigned', user, nil)
+ .with(grid, "work_packages_assigned", user, nil)
.and_return(false)
end
- context 'with the grid being a new record' do
+ context "with the grid being a new record" do
let(:existing_widgets) do
[
build(:grid_widget,
- identifier: 'work_packages_assigned',
+ identifier: "work_packages_assigned",
start_row: 3,
end_row: 5,
start_column: 1,
@@ -156,14 +156,14 @@
)
end
- it 'leaves the prohibited widget' do
+ it "leaves the prohibited widget" do
expect(grid.widgets.length)
.to be 1
end
end
- context 'with the grid not being a new record' do
- it 'leaves the prohibited widget' do
+ context "with the grid not being a new record" do
+ it "leaves the prohibited widget" do
expect(grid.widgets.length)
.to be 1
end
@@ -171,11 +171,11 @@
end
end
- context 'with empty widget params' do
+ context "with empty widget params" do
let(:existing_widgets) do
[
build_stubbed(:grid_widget,
- identifier: 'work_packages_assigned',
+ identifier: "work_packages_assigned",
start_row: 3,
end_row: 5,
start_column: 1,
@@ -199,29 +199,29 @@
subject
end
- it 'does not remove the widget right away' do
+ it "does not remove the widget right away" do
expect(grid.widgets.length)
.to be 1
end
- it 'marks the widget for destruction' do
+ it "marks the widget for destruction" do
expect(grid.widgets[0])
.to be_marked_for_destruction
end
- context 'with the widget not being allowed' do
+ context "with the widget not being allowed" do
before do
allow(Grids::Configuration)
.to receive(:allowed_widget?)
- .with(grid, 'work_packages_assigned', user, nil)
+ .with(grid, "work_packages_assigned", user, nil)
.and_return(false)
end
- context 'with the grid being a new record' do
+ context "with the grid being a new record" do
let(:existing_widgets) do
[
build(:grid_widget,
- identifier: 'work_packages_assigned',
+ identifier: "work_packages_assigned",
start_row: 3,
end_row: 5,
start_column: 1,
@@ -236,14 +236,14 @@
)
end
- it 'removes the prohibited widget' do
+ it "removes the prohibited widget" do
expect(grid.widgets)
.to be_empty
end
end
- context 'with the grid not being a new record' do
- it 'leaves the prohibited widget' do
+ context "with the grid not being a new record" do
+ it "leaves the prohibited widget" do
expect(grid.widgets.length)
.to be 1
end
@@ -251,11 +251,11 @@
end
end
- context 'without widget params' do
+ context "without widget params" do
let(:existing_widgets) do
[
build_stubbed(:grid_widget,
- identifier: 'work_packages_assigned',
+ identifier: "work_packages_assigned",
start_row: 3,
end_row: 5,
start_column: 1,
@@ -275,29 +275,29 @@
subject
end
- it 'does not remove the widget' do
+ it "does not remove the widget" do
expect(grid.widgets.length)
.to be 1
end
- it 'does not mark the widget for destruction' do
+ it "does not mark the widget for destruction" do
expect(grid.widgets[0])
.not_to be_marked_for_destruction
end
- context 'with the widget not being allowed' do
+ context "with the widget not being allowed" do
before do
allow(Grids::Configuration)
.to receive(:allowed_widget?)
- .with(grid, 'work_packages_assigned', user, nil)
+ .with(grid, "work_packages_assigned", user, nil)
.and_return(false)
end
- context 'with the grid being a new record' do
+ context "with the grid being a new record" do
let(:existing_widgets) do
[
build(:grid_widget,
- identifier: 'work_packages_assigned',
+ identifier: "work_packages_assigned",
start_row: 3,
end_row: 5,
start_column: 1,
@@ -312,14 +312,14 @@
)
end
- it 'removes the prohibited widget' do
+ it "removes the prohibited widget" do
expect(grid.widgets)
.to be_empty
end
end
- context 'with the grid not being a new record' do
- it 'leaves the prohibited widget' do
+ context "with the grid not being a new record" do
+ it "leaves the prohibited widget" do
expect(grid.widgets.length)
.to be 1
end
@@ -327,12 +327,12 @@
end
end
- context 'with updates to an existing widget' do
+ context "with updates to an existing widget" do
let(:widgets) do
[
build_stubbed(:grid_widget,
id: existing_widgets[0].id,
- identifier: 'work_packages_assigned',
+ identifier: "work_packages_assigned",
start_row: 3,
end_row: 5,
start_column: 1,
@@ -342,7 +342,7 @@
let(:existing_widgets) do
[
build_stubbed(:grid_widget,
- identifier: 'work_packages_assigned',
+ identifier: "work_packages_assigned",
start_row: 2,
end_row: 5,
start_column: 1,
@@ -362,40 +362,40 @@
subject
end
- it 'updates the widget' do
+ it "updates the widget" do
expect(grid.widgets[0].start_row)
.to eql widgets[0].start_row
end
- it 'does not persist the changes' do
+ it "does not persist the changes" do
expect(grid.widgets[0])
.to be_changed
end
end
- context 'with additions and updates to existing widgets' do
+ context "with additions and updates to existing widgets" do
let(:widgets) do
[
build_stubbed(:grid_widget,
- identifier: 'work_packages_assigned',
+ identifier: "work_packages_assigned",
start_row: 3,
end_row: 5,
start_column: 1,
end_column: 3),
build_stubbed(:grid_widget,
- identifier: 'work_packages_watched',
+ identifier: "work_packages_watched",
start_row: 1,
end_row: 2,
start_column: 1,
end_column: 2),
build_stubbed(:grid_widget,
- identifier: 'work_packages_calendar',
+ identifier: "work_packages_calendar",
start_row: 2,
end_row: 4,
start_column: 1,
end_column: 2),
build_stubbed(:grid_widget,
- identifier: 'work_packages_calendar',
+ identifier: "work_packages_calendar",
start_row: 1,
end_row: 2,
start_column: 4,
@@ -405,19 +405,19 @@
let(:existing_widgets) do
[
build_stubbed(:grid_widget,
- identifier: 'work_packages_assigned',
+ identifier: "work_packages_assigned",
start_row: 2,
end_row: 5,
start_column: 1,
end_column: 3),
build_stubbed(:grid_widget,
- identifier: 'work_packages_assigned',
+ identifier: "work_packages_assigned",
start_row: 1,
end_row: 2,
start_column: 3,
end_column: 4),
build_stubbed(:grid_widget,
- identifier: 'work_packages_calendar',
+ identifier: "work_packages_calendar",
start_row: 1,
end_row: 2,
start_column: 1,
@@ -437,27 +437,27 @@
subject
end
- it 'updates the widgets but does not persist them' do
- expect(grid.widgets.detect { |w| w.identifier == 'work_packages_assigned' && w.changed? }
- .attributes.slice('start_row', 'end_row', 'start_colum', 'end_column'))
- .to eql('start_row' => 3, 'end_row' => 5, 'end_column' => 3)
+ it "updates the widgets but does not persist them" do
+ expect(grid.widgets.detect { |w| w.identifier == "work_packages_assigned" && w.changed? }
+ .attributes.slice("start_row", "end_row", "start_colum", "end_column"))
+ .to eql("start_row" => 3, "end_row" => 5, "end_column" => 3)
- expect(grid.widgets.detect { |w| w.identifier == 'work_packages_calendar' && w.changed? }
- .attributes.slice('start_row', 'end_row', 'start_colum', 'end_column'))
- .to eql('start_row' => 2, 'end_row' => 4, 'end_column' => 2)
+ expect(grid.widgets.detect { |w| w.identifier == "work_packages_calendar" && w.changed? }
+ .attributes.slice("start_row", "end_row", "start_colum", "end_column"))
+ .to eql("start_row" => 2, "end_row" => 4, "end_column" => 2)
end
- it 'does not persist the new widgets' do
- expect(grid.widgets.any? { |w| w.identifier == 'work_packages_watched' && w.new_record? })
+ it "does not persist the new widgets" do
+ expect(grid.widgets.any? { |w| w.identifier == "work_packages_watched" && w.new_record? })
.to be_truthy
- expect(grid.widgets.any? { |w| w.identifier == 'work_packages_calendar' && w.new_record? })
+ expect(grid.widgets.any? { |w| w.identifier == "work_packages_calendar" && w.new_record? })
.to be_truthy
end
- it 'does mark a widget for destruction' do
+ it "does mark a widget for destruction" do
expect(grid.widgets.detect(&:marked_for_destruction?).identifier)
- .to eql 'work_packages_assigned'
+ .to eql "work_packages_assigned"
end
end
end
diff --git a/modules/grids/spec/services/grids/update_service_spec.rb b/modules/grids/spec/services/grids/update_service_spec.rb
index 3ece44b07c19..4f25a7749cb8 100644
--- a/modules/grids/spec/services/grids/update_service_spec.rb
+++ b/modules/grids/spec/services/grids/update_service_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Grids::UpdateService, type: :model do
let(:user) { build_stubbed(:user) }
let(:contract_class) do
- double('contract_class', '<=': true)
+ double("contract_class", "<=": true)
end
let(:grid_valid) { true }
let(:instance) do
@@ -45,7 +45,7 @@
true
end
let(:set_attributes_errors) do
- double('set_attributes_errors')
+ double("set_attributes_errors")
end
let(:set_attributes_result) do
ServiceResult.new result: grid,
@@ -62,7 +62,7 @@
grid
end
let!(:set_attributes_service) do
- service = double('set_attributes_service_instance')
+ service = double("set_attributes_service_instance")
allow(Grids::SetAttributesService)
.to receive(:new)
@@ -79,20 +79,20 @@
service
end
- describe 'call' do
- shared_examples_for 'service call' do
+ describe "call" do
+ shared_examples_for "service call" do
subject { instance.call(call_attributes) }
- it 'is successful' do
+ it "is successful" do
expect(subject.success?).to be_truthy
end
- it 'returns the result of the SetAttributesService' do
+ it "returns the result of the SetAttributesService" do
expect(subject)
.to eql set_attributes_result
end
- it 'persists the grid' do
+ it "persists the grid" do
expect(grid)
.to receive(:save)
.and_return(grid_valid)
@@ -100,19 +100,19 @@
subject
end
- context 'when the SetAttributeService is unsuccessful' do
+ context "when the SetAttributeService is unsuccessful" do
let(:set_attributes_success) { false }
- it 'is unsuccessful' do
+ it "is unsuccessful" do
expect(subject.success?).to be_falsey
end
- it 'returns the result of the SetAttributesService' do
+ it "returns the result of the SetAttributesService" do
expect(subject)
.to eql set_attributes_result
end
- it 'does not persist the changes' do
+ it "does not persist the changes" do
expect(grid)
.not_to receive(:save)
@@ -126,10 +126,10 @@
end
end
- context 'when the grid is invalid' do
+ context "when the grid is invalid" do
let(:grid_valid) { false }
- it 'is unsuccessful' do
+ it "is unsuccessful" do
expect(subject.success?).to be_falsey
end
@@ -141,13 +141,13 @@
end
end
- context 'with parameters' do
+ context "with parameters" do
let(:call_attributes) { { row_count: 5 } }
- it_behaves_like 'service call'
+ it_behaves_like "service call"
end
- context 'with parameters only for widgets' do
+ context "with parameters only for widgets" do
let(:call_attributes) { { widgets: [build_stubbed(:grid_widget)] } }
before do
@@ -168,7 +168,7 @@
end
end
- it_behaves_like 'service call'
+ it_behaves_like "service call"
end
end
end
diff --git a/modules/grids/spec/support/pages/grid.rb b/modules/grids/spec/support/pages/grid.rb
index b0772d006012..96446872a0ca 100644
--- a/modules/grids/spec/support/pages/grid.rb
+++ b/modules/grids/spec/support/pages/grid.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'support/pages/page'
+require "support/pages/page"
module Pages
class Grid < ::Pages::Page
def add_widget(row_number, column_number, location, name)
within_add_widget_modal(row_number, column_number, location) do
expect(page)
- .to have_content(I18n.t('js.grid.add_widget'))
+ .to have_content(I18n.t("js.grid.add_widget"))
SeleniumHubWaiter.wait unless using_cuprite?
@@ -43,7 +43,7 @@ def add_widget(row_number, column_number, location, name)
def expect_no_help_mode
expect(page)
- .to have_no_css('.toolbar-item .icon-add')
+ .to have_no_css(".toolbar-item .icon-add")
end
def expect_unable_to_add_widget(row_number, column_number, location, name = nil)
@@ -57,10 +57,10 @@ def expect_unable_to_add_widget(row_number, column_number, location, name = nil)
def expect_add_widget_enterprise_edition_notice(row_number, column_number, location)
within_add_widget_modal(row_number, column_number, location) do
expect(page)
- .to have_content(I18n.t('js.grid.add_widget'))
+ .to have_content(I18n.t("js.grid.add_widget"))
expect(page)
- .to have_css('.op-toast.-ee-upsale', text: I18n.t('js.upsale.ee_only'))
+ .to have_css(".op-toast.-ee-upsale", text: I18n.t("js.upsale.ee_only"))
end
end
@@ -84,14 +84,14 @@ def within_add_widget_modal(row_number, column_number, location, &)
area.hover
add_widget_button = if using_cuprite?
- area.find('.grid--widget-add')
+ area.find(".grid--widget-add")
else
- area.find('.grid--widget-add', visible: :all)
+ area.find(".grid--widget-add", visible: :all)
end
add_widget_button.click
- within('.spot-modal', &)
+ within(".spot-modal", &)
end
def expect_widget_adding_prohibited_generally(row_number = 1, column_number = 1)
@@ -99,13 +99,13 @@ def expect_widget_adding_prohibited_generally(row_number = 1, column_number = 1)
area.hover
expect(area)
- .to have_no_css('.grid--widget-add')
+ .to have_no_css(".grid--widget-add")
end
def expect_specific_widget_unaddable(row_number, column_number, location, name)
within_add_widget_modal(row_number, column_number, location) do
expect(page)
- .to have_content(I18n.t('js.grid.add_widget'))
+ .to have_content(I18n.t("js.grid.add_widget"))
expect(page)
.to have_no_css('[data-test-selector="op-grid--addable-widget"]', text: Regexp.new("^#{name}$"))
diff --git a/modules/job_status/app/models/job_status/status.rb b/modules/job_status/app/models/job_status/status.rb
index 928b40d91fa3..1372b5b2aa5a 100644
--- a/modules/job_status/app/models/job_status/status.rb
+++ b/modules/job_status/app/models/job_status/status.rb
@@ -28,18 +28,18 @@
module JobStatus
class Status < ApplicationRecord
- self.table_name = 'job_statuses'
+ self.table_name = "job_statuses"
belongs_to :user
belongs_to :reference, polymorphic: true
enum status: {
- in_queue: 'in_queue',
- error: 'error',
- in_process: 'in_process',
- success: 'success',
- failure: 'failure',
- cancelled: 'cancelled'
+ in_queue: "in_queue",
+ error: "error",
+ in_process: "in_process",
+ success: "success",
+ failure: "failure",
+ cancelled: "cancelled"
}
def self.of_reference(reference)
diff --git a/modules/job_status/config/routes.rb b/modules/job_status/config/routes.rb
index c2d6d1a97c0e..a28cc2a14210 100644
--- a/modules/job_status/config/routes.rb
+++ b/modules/job_status/config/routes.rb
@@ -1,5 +1,5 @@
Rails.application.routes.draw do
- get '/job_statuses/:job_uuid',
- to: 'angular#empty_layout',
- as: 'job_status'
+ get "/job_statuses/:job_uuid",
+ to: "angular#empty_layout",
+ as: "job_status"
end
diff --git a/modules/job_status/db/migrate/20200422105623_add_job_status.rb b/modules/job_status/db/migrate/20200422105623_add_job_status.rb
index 8e662859891f..3dd8b817e0b9 100644
--- a/modules/job_status/db/migrate/20200422105623_add_job_status.rb
+++ b/modules/job_status/db/migrate/20200422105623_add_job_status.rb
@@ -40,7 +40,7 @@ def up
t.timestamps
end
- add_column :delayed_job_statuses, :status, :delayed_job_status, default: 'in_queue'
+ add_column :delayed_job_statuses, :status, :delayed_job_status, default: "in_queue"
end
def down
diff --git a/modules/job_status/db/migrate/20200610124259_extend_job_status.rb b/modules/job_status/db/migrate/20200610124259_extend_job_status.rb
index 240c0c65b71d..bf26ecff80b1 100644
--- a/modules/job_status/db/migrate/20200610124259_extend_job_status.rb
+++ b/modules/job_status/db/migrate/20200610124259_extend_job_status.rb
@@ -50,8 +50,8 @@ def change
reversible do |dir|
dir.up do
- change_column_default :delayed_job_statuses, :created_at, -> { 'CURRENT_TIMESTAMP' }
- change_column_default :delayed_job_statuses, :updated_at, -> { 'CURRENT_TIMESTAMP' }
+ change_column_default :delayed_job_statuses, :created_at, -> { "CURRENT_TIMESTAMP" }
+ change_column_default :delayed_job_statuses, :updated_at, -> { "CURRENT_TIMESTAMP" }
end
end
diff --git a/modules/job_status/lib/api/v3/job_status/job_status_api.rb b/modules/job_status/lib/api/v3/job_status/job_status_api.rb
index 27a5fc7537c3..f8d04b7f73b9 100644
--- a/modules/job_status/lib/api/v3/job_status/job_status_api.rb
+++ b/modules/job_status/lib/api/v3/job_status/job_status_api.rb
@@ -31,7 +31,7 @@ module V3
module JobStatus
class JobStatusAPI < ::API::OpenProjectAPI
resources :job_statuses do
- route_param :job_id, type: String, desc: 'Job UUID' do
+ route_param :job_id, type: String, desc: "Job UUID" do
after_validation do
@job = ::JobStatus::Status
.find_by(job_id: params[:job_id], user_id: current_user.id)
diff --git a/modules/job_status/lib/api/v3/job_status/job_status_representer.rb b/modules/job_status/lib/api/v3/job_status/job_status_representer.rb
index ec0c02fd3fc2..179043b822cf 100644
--- a/modules/job_status/lib/api/v3/job_status/job_status_representer.rb
+++ b/modules/job_status/lib/api/v3/job_status/job_status_representer.rb
@@ -44,7 +44,7 @@ class JobStatusRepresenter < ::API::Decorators::Single
render_nil: true
def _type
- 'JobStatus'
+ "JobStatus"
end
end
end
diff --git a/modules/job_status/lib/open_project/job_status.rb b/modules/job_status/lib/open_project/job_status.rb
index bc608cdec3d6..9eb10d776e6b 100644
--- a/modules/job_status/lib/open_project/job_status.rb
+++ b/modules/job_status/lib/open_project/job_status.rb
@@ -28,6 +28,6 @@
module OpenProject
module JobStatus
- require 'open_project/job_status/engine'
+ require "open_project/job_status/engine"
end
end
diff --git a/modules/job_status/lib/open_project/job_status/engine.rb b/modules/job_status/lib/open_project/job_status/engine.rb
index 543067144e75..85bd828a6456 100644
--- a/modules/job_status/lib/open_project/job_status/engine.rb
+++ b/modules/job_status/lib/open_project/job_status/engine.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'open_project/plugins'
+require "open_project/plugins"
module OpenProject::JobStatus
class Engine < ::Rails::Engine
@@ -34,11 +34,11 @@ class Engine < ::Rails::Engine
include OpenProject::Plugins::ActsAsOpEngine
- register 'openproject-job_status',
- author_url: 'https://www.openproject.org',
+ register "openproject-job_status",
+ author_url: "https://www.openproject.org",
bundled: true
- add_api_endpoint 'API::V3::Root' do
+ add_api_endpoint "API::V3::Root" do
mount ::API::V3::JobStatus::JobStatusAPI
end
@@ -48,8 +48,8 @@ class Engine < ::Rails::Engine
add_cron_jobs do
{
- 'JobStatus::Cron::ClearOldJobStatusJob': {
- cron: '15 4 * * *', # runs at 4:15 nightly
+ "JobStatus::Cron::ClearOldJobStatusJob": {
+ cron: "15 4 * * *", # runs at 4:15 nightly
class: ::JobStatus::Cron::ClearOldJobStatusJob.name
}
}
diff --git a/modules/job_status/lib/open_project/job_status/event_listener.rb b/modules/job_status/lib/open_project/job_status/event_listener.rb
index cd24529d8471..9dfc4a81dc95 100644
--- a/modules/job_status/lib/open_project/job_status/event_listener.rb
+++ b/modules/job_status/lib/open_project/job_status/event_listener.rb
@@ -41,7 +41,7 @@ def register!
end
# Start of process
- ActiveSupport::Notifications.subscribe('perform_start.active_job') do |_name, _started, _call, _id, payload|
+ ActiveSupport::Notifications.subscribe("perform_start.active_job") do |_name, _started, _call, _id, payload|
job = payload[:job]
next unless job
@@ -50,7 +50,7 @@ def register!
end
# Complete, or failure
- ActiveSupport::Notifications.subscribe('perform.active_job') do |_name, _started, _call, _id, payload|
+ ActiveSupport::Notifications.subscribe("perform.active_job") do |_name, _started, _call, _id, payload|
job = payload[:job]
exception_object = payload[:exception_object]
@@ -63,7 +63,7 @@ def register!
end
# Retry stopped -> failure
- ActiveSupport::Notifications.subscribe('retry_stopped.active_job') do |_name, _started, _call, _id, payload|
+ ActiveSupport::Notifications.subscribe("retry_stopped.active_job") do |_name, _started, _call, _id, payload|
job = payload[:job]
error = payload[:error]
@@ -72,7 +72,7 @@ def register!
end
# Retry enqueued
- ActiveSupport::Notifications.subscribe('enqueue_retry.active_job') do |_name, _started, _call, _id, payload|
+ ActiveSupport::Notifications.subscribe("enqueue_retry.active_job") do |_name, _started, _call, _id, payload|
job = payload[:job]
error = payload[:error]
@@ -81,7 +81,7 @@ def register!
end
# Discarded job
- ActiveSupport::Notifications.subscribe('discard.active_job') do |_name, _started, _call, _id, payload|
+ ActiveSupport::Notifications.subscribe("discard.active_job") do |_name, _started, _call, _id, payload|
job = payload[:job]
error = payload[:error]
@@ -116,7 +116,7 @@ def on_start(job)
# On requeuing a job after error
def on_requeue(job, error)
job.upsert_status status: :in_queue,
- message: I18n.t('background_jobs.status.error_requeue', message: error)
+ message: I18n.t("background_jobs.status.error_requeue", message: error)
end
##
@@ -124,7 +124,7 @@ def on_requeue(job, error)
def on_cancelled(job, error)
upsert_status job,
status: :cancelled,
- message: I18n.t('background_jobs.status.cancelled_due_to', message: error)
+ message: I18n.t("background_jobs.status.cancelled_due_to", message: error)
end
##
diff --git a/modules/job_status/lib/openproject-job_status.rb b/modules/job_status/lib/openproject-job_status.rb
index c0cb29dfe248..6229f53c8d67 100644
--- a/modules/job_status/lib/openproject-job_status.rb
+++ b/modules/job_status/lib/openproject-job_status.rb
@@ -26,4 +26,4 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'open_project/job_status'
+require "open_project/job_status"
diff --git a/modules/job_status/openproject-job_status.gemspec b/modules/job_status/openproject-job_status.gemspec
index 7db686f70dc8..e78cb9943845 100644
--- a/modules/job_status/openproject-job_status.gemspec
+++ b/modules/job_status/openproject-job_status.gemspec
@@ -1,10 +1,10 @@
Gem::Specification.new do |s|
- s.name = 'openproject-job_status'
- s.version = '1.0.0'
- s.authors = 'OpenProject GmbH'
- s.email = 'info@openproject.com'
- s.summary = 'OpenProject Job status'
- s.description = 'Listing and status of background jobs'
- s.license = 'GPLv3'
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.name = "openproject-job_status"
+ s.version = "1.0.0"
+ s.authors = "OpenProject GmbH"
+ s.email = "info@openproject.com"
+ s.summary = "OpenProject Job status"
+ s.description = "Listing and status of background jobs"
+ s.license = "GPLv3"
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/job_status/spec/factories/delayed_job_status_factory.rb b/modules/job_status/spec/factories/delayed_job_status_factory.rb
index 73ad122492a4..3945178832e9 100644
--- a/modules/job_status/spec/factories/delayed_job_status_factory.rb
+++ b/modules/job_status/spec/factories/delayed_job_status_factory.rb
@@ -27,7 +27,7 @@
#++
FactoryBot.define do
- factory :delayed_job_status, class: '::JobStatus::Status' do
+ factory :delayed_job_status, class: "::JobStatus::Status" do
job_id { SecureRandom.uuid }
user { User.current }
end
diff --git a/modules/job_status/spec/features/job_status_spec.rb b/modules/job_status/spec/features/job_status_spec.rb
index 4e6002ae374b..990e417f6c0f 100644
--- a/modules/job_status/spec/features/job_status_spec.rb
+++ b/modules/job_status/spec/features/job_status_spec.rb
@@ -26,51 +26,51 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Job status', :js do
+RSpec.describe "Job status", :js do
shared_let(:admin) { create(:admin) }
before do
login_as admin
end
- it 'renders a descriptive error in case of 404' do
- visit '/job_statuses/something-that-does-not-exist'
+ it "renders a descriptive error in case of 404" do
+ visit "/job_statuses/something-that-does-not-exist"
- expect(page).to have_css('.icon-big.icon-help', wait: 10)
- expect(page).to have_content I18n.t('js.job_status.generic_messages.not_found')
+ expect(page).to have_css(".icon-big.icon-help", wait: 10)
+ expect(page).to have_content I18n.t("js.job_status.generic_messages.not_found")
end
- describe 'with a status that has an additional errors payload' do
+ describe "with a status that has an additional errors payload" do
let!(:status) { create(:delayed_job_status, user: admin) }
before do
- status.update! payload: { errors: ['Some error', 'Another error'] }
+ status.update! payload: { errors: ["Some error", "Another error"] }
end
- it 'shows a list of these errors' do
+ it "shows a list of these errors" do
visit "/job_statuses/#{status.job_id}"
- expect(page).to have_css('.job-status--modal-additional-errors', text: 'Some errors have occurred', wait: 10)
- expect(page).to have_css('ul li', text: 'Some error')
- expect(page).to have_css('ul li', text: 'Another error')
+ expect(page).to have_css(".job-status--modal-additional-errors", text: "Some errors have occurred", wait: 10)
+ expect(page).to have_css("ul li", text: "Some error")
+ expect(page).to have_css("ul li", text: "Another error")
end
end
- describe 'with a status with error and redirect' do
+ describe "with a status with error and redirect" do
let!(:status) { create(:delayed_job_status, user: admin) }
before do
- status.update! payload: { redirect: home_url, errors: ['Some error'] }
+ status.update! payload: { redirect: home_url, errors: ["Some error"] }
end
- it 'does not automatically redirect' do
+ it "does not automatically redirect" do
visit "/job_statuses/#{status.job_id}"
- expect(page).to have_css('.job-status--modal-additional-errors', text: 'Some errors have occurred', wait: 10)
- expect(page).to have_css('ul li', text: 'Some error')
- expect(page).to have_css("a[href='#{home_url}']", text: 'Please click here to continue')
+ expect(page).to have_css(".job-status--modal-additional-errors", text: "Some errors have occurred", wait: 10)
+ expect(page).to have_css("ul li", text: "Some error")
+ expect(page).to have_css("a[href='#{home_url}']", text: "Please click here to continue")
end
end
end
diff --git a/modules/job_status/spec/services/documents/create_service_spec.rb b/modules/job_status/spec/services/documents/create_service_spec.rb
index f2c553849239..7db35ce1dce2 100644
--- a/modules/job_status/spec/services/documents/create_service_spec.rb
+++ b/modules/job_status/spec/services/documents/create_service_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
-require 'services/base_services/behaves_like_create_service'
+require "spec_helper"
+require "services/base_services/behaves_like_create_service"
RSpec.describe Documents::CreateService, type: :model do
- it_behaves_like 'BaseServices create service'
+ it_behaves_like "BaseServices create service"
end
diff --git a/modules/job_status/spec/services/documents/update_service_spec.rb b/modules/job_status/spec/services/documents/update_service_spec.rb
index cbce9123182d..85326054ae28 100644
--- a/modules/job_status/spec/services/documents/update_service_spec.rb
+++ b/modules/job_status/spec/services/documents/update_service_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'services/base_services/behaves_like_update_service'
+require "spec_helper"
+require "services/base_services/behaves_like_update_service"
RSpec.describe Documents::UpdateService, type: :model do
- it_behaves_like 'BaseServices update service'
+ it_behaves_like "BaseServices update service"
end
diff --git a/modules/ldap_groups/app/components/ldap_groups/memberships/table_component.rb b/modules/ldap_groups/app/components/ldap_groups/memberships/table_component.rb
index f7cc0ef4580b..efd7aa5e0a92 100644
--- a/modules/ldap_groups/app/components/ldap_groups/memberships/table_component.rb
+++ b/modules/ldap_groups/app/components/ldap_groups/memberships/table_component.rb
@@ -42,13 +42,13 @@ def sortable?
end
def empty_row_message
- I18n.t 'ldap_groups.synchronized_groups.no_members'
+ I18n.t "ldap_groups.synchronized_groups.no_members"
end
def headers
[
- ['user', { caption: ::LdapGroups::Membership.human_attribute_name('user') }],
- ['added', { caption: ::LdapGroups::Membership.human_attribute_name('created_at') }]
+ ["user", { caption: ::LdapGroups::Membership.human_attribute_name("user") }],
+ ["added", { caption: ::LdapGroups::Membership.human_attribute_name("created_at") }]
]
end
end
diff --git a/modules/ldap_groups/app/components/ldap_groups/synchronized_filters/row_component.rb b/modules/ldap_groups/app/components/ldap_groups/synchronized_filters/row_component.rb
index 896574aa9b73..3d9a2bee67c5 100644
--- a/modules/ldap_groups/app/components/ldap_groups/synchronized_filters/row_component.rb
+++ b/modules/ldap_groups/app/components/ldap_groups/synchronized_filters/row_component.rb
@@ -65,7 +65,7 @@ def edit_link
link_to I18n.t(:button_edit),
{ controller: table.target_controller, ldap_filter_id: model.id, action: :edit },
- class: 'icon icon-edit',
+ class: "icon icon-edit",
title: t(:button_edit)
end
@@ -74,7 +74,7 @@ def delete_link
link_to I18n.t(:button_delete),
{ controller: table.target_controller, ldap_filter_id: model.id, action: :destroy_info },
- class: 'icon icon-delete',
+ class: "icon icon-delete",
title: t(:button_delete)
end
end
diff --git a/modules/ldap_groups/app/components/ldap_groups/synchronized_filters/table_component.rb b/modules/ldap_groups/app/components/ldap_groups/synchronized_filters/table_component.rb
index b1aed9b41ba0..150c8944882e 100644
--- a/modules/ldap_groups/app/components/ldap_groups/synchronized_filters/table_component.rb
+++ b/modules/ldap_groups/app/components/ldap_groups/synchronized_filters/table_component.rb
@@ -38,7 +38,7 @@ def initial_sort
end
def target_controller
- 'ldap_groups/synchronized_filters'
+ "ldap_groups/synchronized_filters"
end
def sortable?
@@ -47,18 +47,18 @@ def sortable?
def inline_create_link
link_to({ controller: target_controller, action: :new },
- class: 'budget-add-row wp-inline-create--add-link',
- title: I18n.t('ldap_groups.synchronized_filters.add_new')) do
- helpers.op_icon('icon icon-add')
+ class: "budget-add-row wp-inline-create--add-link",
+ title: I18n.t("ldap_groups.synchronized_filters.add_new")) do
+ helpers.op_icon("icon icon-add")
end
end
def headers
[
- ['name', { caption: ::LdapGroups::SynchronizedFilter.human_attribute_name('name') }],
- ['auth_source', { caption: ::LdapGroups::SynchronizedFilter.human_attribute_name('auth_source') }],
- ['groups', { caption: I18n.t('ldap_groups.synchronized_groups.plural') }],
- ['sync_users', { caption: ::LdapGroups::SynchronizedFilter.human_attribute_name('sync_users') }]
+ ["name", { caption: ::LdapGroups::SynchronizedFilter.human_attribute_name("name") }],
+ ["auth_source", { caption: ::LdapGroups::SynchronizedFilter.human_attribute_name("auth_source") }],
+ ["groups", { caption: I18n.t("ldap_groups.synchronized_groups.plural") }],
+ ["sync_users", { caption: ::LdapGroups::SynchronizedFilter.human_attribute_name("sync_users") }]
]
end
end
diff --git a/modules/ldap_groups/app/components/ldap_groups/synchronized_groups/row_component.rb b/modules/ldap_groups/app/components/ldap_groups/synchronized_groups/row_component.rb
index 6f752c6da103..e8c9a2a29fec 100644
--- a/modules/ldap_groups/app/components/ldap_groups/synchronized_groups/row_component.rb
+++ b/modules/ldap_groups/app/components/ldap_groups/synchronized_groups/row_component.rb
@@ -64,7 +64,7 @@ def delete_link
link_to I18n.t(:button_delete),
{ controller: table.target_controller, ldap_group_id: model.id, action: :destroy_info },
- class: 'icon icon-delete',
+ class: "icon icon-delete",
title: t(:button_delete)
end
end
diff --git a/modules/ldap_groups/app/components/ldap_groups/synchronized_groups/table_component.rb b/modules/ldap_groups/app/components/ldap_groups/synchronized_groups/table_component.rb
index 24878b914a7d..d89594cbb804 100644
--- a/modules/ldap_groups/app/components/ldap_groups/synchronized_groups/table_component.rb
+++ b/modules/ldap_groups/app/components/ldap_groups/synchronized_groups/table_component.rb
@@ -38,7 +38,7 @@ def initial_sort
end
def target_controller
- 'ldap_groups/synchronized_groups'
+ "ldap_groups/synchronized_groups"
end
def sortable?
@@ -51,23 +51,23 @@ def sortable_column?(_column)
def inline_create_link
link_to({ controller: target_controller, action: :new },
- class: 'budget-add-row wp-inline-create--add-link',
- title: I18n.t('ldap_groups.synchronized_groups.add_new')) do
- helpers.op_icon('icon icon-add')
+ class: "budget-add-row wp-inline-create--add-link",
+ title: I18n.t("ldap_groups.synchronized_groups.add_new")) do
+ helpers.op_icon("icon icon-add")
end
end
def empty_row_message
- I18n.t 'ldap_groups.synchronized_groups.no_results'
+ I18n.t "ldap_groups.synchronized_groups.no_results"
end
def headers
[
- ['dn', { caption: ::LdapGroups::SynchronizedGroup.human_attribute_name('dn') }],
- ['ldap_auth_source', { caption: ::LdapGroups::SynchronizedGroup.human_attribute_name('ldap_auth_source') }],
- ['group', { caption: I18n.t(:label_group) }],
- ['users', { caption: I18n.t(:label_user_plural) }],
- ['sync_users', { caption: ::LdapGroups::SynchronizedFilter.human_attribute_name('sync_users') }]
+ ["dn", { caption: ::LdapGroups::SynchronizedGroup.human_attribute_name("dn") }],
+ ["ldap_auth_source", { caption: ::LdapGroups::SynchronizedGroup.human_attribute_name("ldap_auth_source") }],
+ ["group", { caption: I18n.t(:label_group) }],
+ ["users", { caption: I18n.t(:label_user_plural) }],
+ ["sync_users", { caption: ::LdapGroups::SynchronizedFilter.human_attribute_name("sync_users") }]
]
end
end
diff --git a/modules/ldap_groups/app/controllers/ldap_groups/synchronized_filters_controller.rb b/modules/ldap_groups/app/controllers/ldap_groups/synchronized_filters_controller.rb
index fc1008019a91..3cb6f03a9bd6 100644
--- a/modules/ldap_groups/app/controllers/ldap_groups/synchronized_filters_controller.rb
+++ b/modules/ldap_groups/app/controllers/ldap_groups/synchronized_filters_controller.rb
@@ -4,7 +4,7 @@ class SynchronizedFiltersController < ::ApplicationController
before_action :check_ee
before_action :find_filter, except: %i[new create]
- layout 'admin'
+ layout "admin"
menu_item :plugin_ldap_groups
def new
@@ -59,7 +59,7 @@ def synchronize
call.on_success do
count = call.result
symbol = count > 0 ? :notice : :info
- flash[symbol] = I18n.t('ldap_groups.synchronized_filters.label_n_groups_found', count:)
+ flash[symbol] = I18n.t("ldap_groups.synchronized_filters.label_n_groups_found", count:)
end
call.on_failure do
@@ -79,7 +79,7 @@ def find_filter
def check_ee
unless EnterpriseToken.allows_to?(:ldap_groups)
- render template: 'ldap_groups/synchronized_groups/upsale'
+ render template: "ldap_groups/synchronized_groups/upsale"
false
end
end
@@ -91,7 +91,7 @@ def permitted_params
end
def default_breadcrumb
- ActionController::Base.helpers.link_to(t('ldap_groups.synchronized_groups.plural'), ldap_groups_synchronized_groups_path)
+ ActionController::Base.helpers.link_to(t("ldap_groups.synchronized_groups.plural"), ldap_groups_synchronized_groups_path)
end
def show_local_breadcrumb
diff --git a/modules/ldap_groups/app/controllers/ldap_groups/synchronized_groups_controller.rb b/modules/ldap_groups/app/controllers/ldap_groups/synchronized_groups_controller.rb
index eb577d4040c5..dd7a9ec36609 100644
--- a/modules/ldap_groups/app/controllers/ldap_groups/synchronized_groups_controller.rb
+++ b/modules/ldap_groups/app/controllers/ldap_groups/synchronized_groups_controller.rb
@@ -4,7 +4,7 @@ class SynchronizedGroupsController < ::ApplicationController
before_action :check_ee
before_action :find_group, only: %i(show destroy_info destroy)
- layout 'admin'
+ layout "admin"
menu_item :plugin_ldap_groups
include PaginationHelper
@@ -58,7 +58,7 @@ def find_group
def check_ee
unless EnterpriseToken.allows_to?(:ldap_groups)
- render template: 'ldap_groups/synchronized_groups/upsale'
+ render template: "ldap_groups/synchronized_groups/upsale"
false
end
end
@@ -70,10 +70,10 @@ def permitted_params
end
def default_breadcrumb
- if action_name == 'index'
- t('ldap_groups.synchronized_groups.plural')
+ if action_name == "index"
+ t("ldap_groups.synchronized_groups.plural")
else
- ActionController::Base.helpers.link_to(t('ldap_groups.synchronized_groups.plural'), ldap_groups_synchronized_groups_path)
+ ActionController::Base.helpers.link_to(t("ldap_groups.synchronized_groups.plural"), ldap_groups_synchronized_groups_path)
end
end
diff --git a/modules/ldap_groups/app/models/ldap_groups.rb b/modules/ldap_groups/app/models/ldap_groups.rb
index 5a024ac7392e..3d3053d2cff9 100644
--- a/modules/ldap_groups/app/models/ldap_groups.rb
+++ b/modules/ldap_groups/app/models/ldap_groups.rb
@@ -1,5 +1,5 @@
module LdapGroups
def self.table_name_prefix
- 'ldap_groups_'
+ "ldap_groups_"
end
end
diff --git a/modules/ldap_groups/app/models/ldap_groups/membership.rb b/modules/ldap_groups/app/models/ldap_groups/membership.rb
index 4396f78c866b..e0a70119a1d6 100644
--- a/modules/ldap_groups/app/models/ldap_groups/membership.rb
+++ b/modules/ldap_groups/app/models/ldap_groups/membership.rb
@@ -2,7 +2,7 @@ module LdapGroups
class Membership < ApplicationRecord
belongs_to :user
belongs_to :group,
- class_name: '::LdapGroups::SynchronizedGroup',
+ class_name: "::LdapGroups::SynchronizedGroup",
counter_cache: :users_count
validates_uniqueness_of :user_id, scope: :group_id
diff --git a/modules/ldap_groups/app/models/ldap_groups/synchronized_filter.rb b/modules/ldap_groups/app/models/ldap_groups/synchronized_filter.rb
index 43baa15f7cec..10a4e563ff93 100644
--- a/modules/ldap_groups/app/models/ldap_groups/synchronized_filter.rb
+++ b/modules/ldap_groups/app/models/ldap_groups/synchronized_filter.rb
@@ -1,13 +1,13 @@
-require 'net/ldap'
-require 'net/ldap/dn'
+require "net/ldap"
+require "net/ldap/dn"
module LdapGroups
class SynchronizedFilter < ApplicationRecord
belongs_to :ldap_auth_source
has_many :groups,
- class_name: '::LdapGroups::SynchronizedGroup',
- foreign_key: 'filter_id',
+ class_name: "::LdapGroups::SynchronizedGroup",
+ foreign_key: "filter_id",
dependent: :destroy
validates_presence_of :name
@@ -28,7 +28,7 @@ def seeded_from_env?
return false if ldap_auth_source.nil?
ldap_auth_source&.seeded_from_env? &&
- Setting.seed_ldap.dig(ldap_auth_source.name, 'groupfilter', name)
+ Setting.seed_ldap.dig(ldap_auth_source.name, "groupfilter", name)
end
private
diff --git a/modules/ldap_groups/app/models/ldap_groups/synchronized_group.rb b/modules/ldap_groups/app/models/ldap_groups/synchronized_group.rb
index dbcd0be5a89c..b5778ef039b8 100644
--- a/modules/ldap_groups/app/models/ldap_groups/synchronized_group.rb
+++ b/modules/ldap_groups/app/models/ldap_groups/synchronized_group.rb
@@ -1,5 +1,5 @@
-require 'net/ldap'
-require 'net/ldap/dn'
+require "net/ldap"
+require "net/ldap/dn"
module LdapGroups
class SynchronizedGroup < ApplicationRecord
@@ -8,12 +8,12 @@ class SynchronizedGroup < ApplicationRecord
belongs_to :ldap_auth_source
belongs_to :filter,
- class_name: '::LdapGroups::SynchronizedFilter'
+ class_name: "::LdapGroups::SynchronizedFilter"
has_many :users,
- class_name: '::LdapGroups::Membership',
+ class_name: "::LdapGroups::Membership",
dependent: :delete_all,
- foreign_key: 'group_id'
+ foreign_key: "group_id"
validates_presence_of :dn
validates_presence_of :group
diff --git a/modules/ldap_groups/app/services/ldap_groups/synchronize_filter_service.rb b/modules/ldap_groups/app/services/ldap_groups/synchronize_filter_service.rb
index 2010d084764f..26525d6b99f5 100644
--- a/modules/ldap_groups/app/services/ldap_groups/synchronize_filter_service.rb
+++ b/modules/ldap_groups/app/services/ldap_groups/synchronize_filter_service.rb
@@ -61,7 +61,7 @@ def search(filter, ldap_con, &)
ldap_con.search(
base: filter.used_base_dn,
filter: filter.parsed_filter_string,
- attributes: ['dn', filter.group_name_attribute],
+ attributes: ["dn", filter.group_name_attribute],
&
)
end
diff --git a/modules/ldap_groups/config/routes.rb b/modules/ldap_groups/config/routes.rb
index e4aec6a09d64..f66e6f61535a 100644
--- a/modules/ldap_groups/config/routes.rb
+++ b/modules/ldap_groups/config/routes.rb
@@ -1,14 +1,14 @@
Rails.application.routes.draw do
- namespace 'ldap_groups' do
+ namespace "ldap_groups" do
resources :synchronized_filters,
param: :ldap_filter_id,
except: %i(index) do
member do
# Extract groups from filter
- get 'synchronize'
+ get "synchronize"
# Destroy warning
- get 'destroy_info'
+ get "destroy_info"
end
end
@@ -17,7 +17,7 @@
only: %i(new index create show destroy) do
member do
# Destroy warning
- get 'destroy_info'
+ get "destroy_info"
end
end
end
diff --git a/modules/ldap_groups/db/migrate/20200427082928_ldap_groups_timestamps.rb b/modules/ldap_groups/db/migrate/20200427082928_ldap_groups_timestamps.rb
index 3067955900fb..fe961cfdc9ea 100644
--- a/modules/ldap_groups/db/migrate/20200427082928_ldap_groups_timestamps.rb
+++ b/modules/ldap_groups/db/migrate/20200427082928_ldap_groups_timestamps.rb
@@ -28,14 +28,14 @@
class LdapGroupsTimestamps < ActiveRecord::Migration[6.0]
def up
- change_column_default :ldap_groups_synchronized_groups, :created_at, -> { 'CURRENT_TIMESTAMP' }
- change_column_default :ldap_groups_synchronized_groups, :updated_at, -> { 'CURRENT_TIMESTAMP' }
+ change_column_default :ldap_groups_synchronized_groups, :created_at, -> { "CURRENT_TIMESTAMP" }
+ change_column_default :ldap_groups_synchronized_groups, :updated_at, -> { "CURRENT_TIMESTAMP" }
- change_column_default :ldap_groups_synchronized_filters, :created_at, -> { 'CURRENT_TIMESTAMP' }
- change_column_default :ldap_groups_synchronized_filters, :updated_at, -> { 'CURRENT_TIMESTAMP' }
+ change_column_default :ldap_groups_synchronized_filters, :created_at, -> { "CURRENT_TIMESTAMP" }
+ change_column_default :ldap_groups_synchronized_filters, :updated_at, -> { "CURRENT_TIMESTAMP" }
- change_column_default :ldap_groups_memberships, :created_at, -> { 'CURRENT_TIMESTAMP' }
- change_column_default :ldap_groups_memberships, :updated_at, -> { 'CURRENT_TIMESTAMP' }
+ change_column_default :ldap_groups_memberships, :created_at, -> { "CURRENT_TIMESTAMP" }
+ change_column_default :ldap_groups_memberships, :updated_at, -> { "CURRENT_TIMESTAMP" }
end
def down
diff --git a/modules/ldap_groups/db/migrate/20210219092709_move_base_dn_into_filters.rb b/modules/ldap_groups/db/migrate/20210219092709_move_base_dn_into_filters.rb
index 630b89f12484..ed3c54a80873 100644
--- a/modules/ldap_groups/db/migrate/20210219092709_move_base_dn_into_filters.rb
+++ b/modules/ldap_groups/db/migrate/20210219092709_move_base_dn_into_filters.rb
@@ -28,7 +28,7 @@
class MoveBaseDnIntoFilters < ActiveRecord::Migration[6.1]
class MigratingAuthSource < ApplicationRecord
- self.table_name = 'auth_sources'
+ self.table_name = "auth_sources"
end
def change
diff --git a/modules/ldap_groups/lib/open_project/ldap_groups/engine.rb b/modules/ldap_groups/lib/open_project/ldap_groups/engine.rb
index 3b6c387b81cb..50e9b44d4fdb 100644
--- a/modules/ldap_groups/lib/open_project/ldap_groups/engine.rb
+++ b/modules/ldap_groups/lib/open_project/ldap_groups/engine.rb
@@ -4,25 +4,25 @@ class Engine < ::Rails::Engine
include OpenProject::Plugins::ActsAsOpEngine
- register 'openproject-ldap_groups',
- author_url: 'https://github.com/opf/openproject-ldap_groups',
+ register "openproject-ldap_groups",
+ author_url: "https://github.com/opf/openproject-ldap_groups",
bundled: true,
settings: {
default: {}
} do
menu :admin_menu,
:plugin_ldap_groups,
- { controller: '/ldap_groups/synchronized_groups', action: :index },
+ { controller: "/ldap_groups/synchronized_groups", action: :index },
parent: :authentication,
last: true,
- caption: ->(*) { I18n.t('ldap_groups.label_menu_item') },
- enterprise_feature: 'ldap_groups'
+ caption: ->(*) { I18n.t("ldap_groups.label_menu_item") },
+ enterprise_feature: "ldap_groups"
end
add_cron_jobs do
{
- 'Ldap::SynchronizationJob': {
- cron: '30 23 * * *', # Run once per night at 11:30pm
+ "Ldap::SynchronizationJob": {
+ cron: "30 23 * * *", # Run once per night at 11:30pm
class: Ldap::SynchronizationJob.name
}
}
diff --git a/modules/ldap_groups/lib/open_project/ldap_groups/patches/group_patch.rb b/modules/ldap_groups/lib/open_project/ldap_groups/patches/group_patch.rb
index a28cdeef1846..9b2b475b241c 100644
--- a/modules/ldap_groups/lib/open_project/ldap_groups/patches/group_patch.rb
+++ b/modules/ldap_groups/lib/open_project/ldap_groups/patches/group_patch.rb
@@ -4,7 +4,7 @@ module GroupPatch
def self.included(base) # :nodoc:
base.class_eval do
has_many :ldap_groups_synchronized_groups,
- class_name: '::LdapGroups::SynchronizedGroup',
+ class_name: "::LdapGroups::SynchronizedGroup",
dependent: :destroy
end
end
diff --git a/modules/ldap_groups/lib/open_project/ldap_groups/patches/ldap_auth_source_patch.rb b/modules/ldap_groups/lib/open_project/ldap_groups/patches/ldap_auth_source_patch.rb
index b5137b1e17a0..c738d0569558 100644
--- a/modules/ldap_groups/lib/open_project/ldap_groups/patches/ldap_auth_source_patch.rb
+++ b/modules/ldap_groups/lib/open_project/ldap_groups/patches/ldap_auth_source_patch.rb
@@ -4,11 +4,11 @@ module LdapAuthSourcePatch
def self.included(base) # :nodoc:
base.class_eval do
has_many :ldap_groups_synchronized_groups,
- class_name: '::LdapGroups::SynchronizedGroup',
+ class_name: "::LdapGroups::SynchronizedGroup",
dependent: :destroy
has_many :ldap_groups_synchronized_filters,
- class_name: '::LdapGroups::SynchronizedFilter',
+ class_name: "::LdapGroups::SynchronizedFilter",
dependent: :destroy
end
end
diff --git a/modules/ldap_groups/lib/open_project/ldap_groups/patches/user_patch.rb b/modules/ldap_groups/lib/open_project/ldap_groups/patches/user_patch.rb
index 2860baa3e5f0..f458ddf8714e 100644
--- a/modules/ldap_groups/lib/open_project/ldap_groups/patches/user_patch.rb
+++ b/modules/ldap_groups/lib/open_project/ldap_groups/patches/user_patch.rb
@@ -4,7 +4,7 @@ module UserPatch
def self.included(base) # :nodoc:
base.class_eval do
has_many :ldap_groups_memberships,
- class_name: '::LdapGroups::Membership',
+ class_name: "::LdapGroups::Membership",
dependent: :destroy
end
end
diff --git a/modules/ldap_groups/lib/openproject-ldap_groups.rb b/modules/ldap_groups/lib/openproject-ldap_groups.rb
index 5b2bdd18f8b5..c87a86e554d1 100644
--- a/modules/ldap_groups/lib/openproject-ldap_groups.rb
+++ b/modules/ldap_groups/lib/openproject-ldap_groups.rb
@@ -1 +1 @@
-require 'open_project/ldap_groups'
+require "open_project/ldap_groups"
diff --git a/modules/ldap_groups/lib/tasks/ldap_groups.rake b/modules/ldap_groups/lib/tasks/ldap_groups.rake
index f67f3627ff07..ff24331508a8 100644
--- a/modules/ldap_groups/lib/tasks/ldap_groups.rake
+++ b/modules/ldap_groups/lib/tasks/ldap_groups.rake
@@ -27,13 +27,13 @@
#++
namespace :ldap_groups do
- desc 'Synchronize groups and their users from the LDAP auth source.' \
- 'Will only synchronize for those users already present in the application.'
+ desc "Synchronize groups and their users from the LDAP auth source." \
+ "Will only synchronize for those users already present in the application."
task synchronize: :environment do
LdapGroups::SynchronizationService.synchronize!
end
- desc 'Print all members of groups tied to a synchronized group that are not derived from LDAP'
+ desc "Print all members of groups tied to a synchronized group that are not derived from LDAP"
task print_unsynced_members: :environment do
LdapGroups::SynchronizedGroup
.includes(:group)
@@ -52,37 +52,37 @@ namespace :ldap_groups do
end
namespace :development do
- desc 'Create a development LDAP server from the fixtures LDIF'
+ desc "Create a development LDAP server from the fixtures LDIF"
task ldap_server: :environment do
- require 'ladle'
- ldif = ENV.fetch('LDIF_FILE') { Rails.root.join('spec/fixtures/ldap/users.ldif') }
- ldap_server = Ladle::Server.new(quiet: false, port: '12389', domain: 'dc=example,dc=com', ldif:).start
+ require "ladle"
+ ldif = ENV.fetch("LDIF_FILE") { Rails.root.join("spec/fixtures/ldap/users.ldif") }
+ ldap_server = Ladle::Server.new(quiet: false, port: "12389", domain: "dc=example,dc=com", ldif:).start
puts "Creating a connection called ladle"
- source = LdapAuthSource.find_or_initialize_by(name: 'ladle local development')
+ source = LdapAuthSource.find_or_initialize_by(name: "ladle local development")
source.attributes = {
- host: 'localhost',
- port: '12389',
- tls_mode: 'plain_ldap',
- account: 'uid=admin,ou=system',
- account_password: 'secret',
- base_dn: 'dc=example,dc=com',
+ host: "localhost",
+ port: "12389",
+ tls_mode: "plain_ldap",
+ account: "uid=admin,ou=system",
+ account_password: "secret",
+ base_dn: "dc=example,dc=com",
onthefly_register: true,
- attr_login: 'uid',
- attr_firstname: 'givenName',
- attr_lastname: 'sn',
- attr_mail: 'mail',
- attr_admin: 'isAdmin'
+ attr_login: "uid",
+ attr_firstname: "givenName",
+ attr_lastname: "sn",
+ attr_mail: "mail",
+ attr_admin: "isAdmin"
}
source.save!
- filter = LdapGroups::SynchronizedFilter.find_or_initialize_by(ldap_auth_source: source, name: 'All groups')
- filter.group_name_attribute = 'dn'
+ filter = LdapGroups::SynchronizedFilter.find_or_initialize_by(ldap_auth_source: source, name: "All groups")
+ filter.group_name_attribute = "dn"
filter.sync_users = true
- filter.filter_string = '(cn=*)'
- filter.base_dn = 'ou=groups,dc=example,dc=com'
+ filter.filter_string = "(cn=*)"
+ filter.base_dn = "ou=groups,dc=example,dc=com"
filter.save!
@@ -139,7 +139,7 @@ namespace :ldap_groups do
INFO
puts "Send CTRL+D to stop the server"
- require 'irb'
+ require "irb"
binding.irb
ldap_server.stop
diff --git a/modules/ldap_groups/openproject-ldap_groups.gemspec b/modules/ldap_groups/openproject-ldap_groups.gemspec
index 30b69af57d73..9749a9cca516 100644
--- a/modules/ldap_groups/openproject-ldap_groups.gemspec
+++ b/modules/ldap_groups/openproject-ldap_groups.gemspec
@@ -1,14 +1,14 @@
Gem::Specification.new do |s|
s.name = "openproject-ldap_groups"
- s.version = '1.0.0'
+ s.version = "1.0.0"
s.authors = "OpenProject GmbH, Oliver Günther"
s.email = "info@openproject.com"
s.homepage = "https://github.com/opf/openproject-ldap_groups"
- s.summary = 'OpenProject LDAP groups'
- s.description = 'Synchronization of LDAP group memberships'
- s.license = 'GPL-3'
+ s.summary = "OpenProject LDAP groups"
+ s.description = "Synchronization of LDAP group memberships"
+ s.license = "GPL-3"
s.files = Dir["{app,config,db,lib}/**/*"] + %w(README.md)
- s.add_development_dependency 'ladle'
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.add_development_dependency "ladle"
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb b/modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb
index 51d0eb64750b..e6699c875cb3 100644
--- a/modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb
+++ b/modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb
@@ -1,4 +1,4 @@
-require_relative '../spec_helper'
+require_relative "../spec_helper"
RSpec.describe LdapGroups::SynchronizedGroupsController, with_ee: %i[ldap_groups] do
let(:user) { create(:user) }
@@ -8,92 +8,92 @@
allow(User).to receive(:current).and_return(logged_in_user)
end
- describe '#index' do
+ describe "#index" do
before do
get :index
end
- context 'when not admin' do
+ context "when not admin" do
let(:logged_in_user) { user }
- it 'does not give access' do
+ it "does not give access" do
expect(response.status).to eq 403
end
end
- context 'when admin' do
+ context "when admin" do
let(:logged_in_user) { admin }
- it 'renders the page' do
+ it "renders the page" do
expect(response).to be_successful
- expect(response).to render_template 'index'
+ expect(response).to render_template "index"
end
end
end
- describe '#show' do
- context 'when not admin' do
+ describe "#show" do
+ context "when not admin" do
let(:logged_in_user) { user }
- let(:id) { 'whatever' }
+ let(:id) { "whatever" }
- it 'does not give access' do
+ it "does not give access" do
get :show, params: { ldap_group_id: id }
expect(response.status).to eq 403
end
end
- context 'when admin' do
+ context "when admin" do
let(:logged_in_user) { admin }
- context 'when no entry exists' do
- let(:id) { 'foo' }
+ context "when no entry exists" do
+ let(:id) { "foo" }
- it 'renders 404' do
+ it "renders 404" do
get :show, params: { ldap_group_id: id }
expect(response.status).to eq(404)
end
end
- context 'when entry exists' do
+ context "when entry exists" do
let!(:group) { build_stubbed(:ldap_synchronized_group) }
- let(:id) { 'foo' }
+ let(:id) { "foo" }
- it 'renders the page' do
+ it "renders the page" do
expect(LdapGroups::SynchronizedGroup)
.to receive(:find)
- .with('foo')
+ .with("foo")
.and_return(group)
get :show, params: { ldap_group_id: id }
expect(response).to be_successful
- expect(response).to render_template 'show'
+ expect(response).to render_template "show"
end
end
end
end
- describe '#new' do
- context 'when not admin' do
+ describe "#new" do
+ context "when not admin" do
let(:logged_in_user) { user }
- it 'does not give access' do
+ it "does not give access" do
get :new
expect(response.status).to eq 403
end
end
- context 'when admin' do
+ context "when admin" do
let(:logged_in_user) { admin }
- it 'renders the page' do
+ it "renders the page" do
get :new
expect(response).to be_successful
- expect(response).to render_template 'new'
+ expect(response).to render_template "new"
end
end
end
- describe '#create' do
+ describe "#create" do
let(:save_result) { false }
before do
@@ -101,40 +101,40 @@
post :create, params: { synchronized_group: params }
end
- context 'when not admin' do
+ context "when not admin" do
let(:logged_in_user) { user }
let(:params) { {} }
- it 'does not give access' do
+ it "does not give access" do
expect(response.status).to eq 403
end
end
- context 'when admin' do
+ context "when admin" do
let(:logged_in_user) { admin }
- context 'with invalid params' do
+ context "with invalid params" do
let(:params) { {} }
- it 'renders 400' do
+ it "renders 400" do
expect(response.status).to eq(400)
end
end
- context 'with valid params' do
- let(:params) { { ldap_auth_source_id: 1, group_id: 1, dn: 'cn=foo,ou=groups,dc=example,dc=com' } }
+ context "with valid params" do
+ let(:params) { { ldap_auth_source_id: 1, group_id: 1, dn: "cn=foo,ou=groups,dc=example,dc=com" } }
- context 'and saving succeeds' do
+ context "and saving succeeds" do
let(:save_result) { true }
- it 'renders 200' do
+ it "renders 200" do
expect(flash[:notice]).to be_present
expect(response).to redirect_to action: :index
end
end
- context 'and saving fails' do
- it 'renders new page' do
+ context "and saving fails" do
+ it "renders new page" do
expect(response.status).to eq(200)
expect(response).to render_template :new
end
@@ -143,78 +143,78 @@
end
end
- describe '#destroy_info' do
- context 'when not admin' do
+ describe "#destroy_info" do
+ context "when not admin" do
let(:logged_in_user) { user }
- let(:id) { 'whatever' }
+ let(:id) { "whatever" }
- it 'does not give access' do
+ it "does not give access" do
get :destroy_info, params: { ldap_group_id: id }
expect(response.status).to eq 403
end
end
- context 'when admin' do
+ context "when admin" do
let(:logged_in_user) { admin }
- context 'when no entry exists' do
- let(:id) { 'foo' }
+ context "when no entry exists" do
+ let(:id) { "foo" }
- it 'renders 404' do
+ it "renders 404" do
get :destroy_info, params: { ldap_group_id: id }
expect(response.status).to eq(404)
end
end
- context 'when entry exists' do
+ context "when entry exists" do
let!(:group) { build_stubbed(:ldap_synchronized_group) }
- let(:id) { 'foo' }
+ let(:id) { "foo" }
- it 'renders the page' do
+ it "renders the page" do
expect(LdapGroups::SynchronizedGroup)
.to receive(:find)
- .with('foo')
+ .with("foo")
.and_return(group)
get :destroy_info, params: { ldap_group_id: id }
expect(response).to be_successful
- expect(response).to render_template 'destroy_info'
+ expect(response).to render_template "destroy_info"
end
end
end
end
- describe '#destroy' do
- context 'when not admin' do
+ describe "#destroy" do
+ context "when not admin" do
let(:logged_in_user) { user }
- let(:id) { 'whatever' }
+ let(:id) { "whatever" }
- it 'does not give access' do
+ it "does not give access" do
delete :destroy, params: { ldap_group_id: id }
expect(response.status).to eq 403
end
end
- context 'when admin' do
+ context "when admin" do
let(:logged_in_user) { admin }
- context 'when no entry exists' do
- let(:id) { 'foo' }
+ context "when no entry exists" do
+ let(:id) { "foo" }
- it 'renders 404' do
+ it "renders 404" do
delete :destroy, params: { ldap_group_id: id }
expect(response.status).to eq(404)
end
end
- context 'when entry exists' do
+ context "when entry exists" do
let!(:group) { build_stubbed(:ldap_synchronized_group) }
- let(:id) { 'foo' }
+ let(:id) { "foo" }
before do
expect(LdapGroups::SynchronizedGroup)
.to receive(:find)
- .with('foo')
+ .with("foo")
.and_return(group)
expect(group)
@@ -222,20 +222,20 @@
.and_return(destroy_result)
end
- context 'when deletion succeeds' do
+ context "when deletion succeeds" do
let(:destroy_result) { true }
- it 'redirects to index' do
+ it "redirects to index" do
delete :destroy, params: { ldap_group_id: id }
expect(flash[:notice]).to be_present
expect(response).to redirect_to action: :index
end
end
- context 'when deletion fails' do
+ context "when deletion fails" do
let(:destroy_result) { false }
- it 'redirects to index' do
+ it "redirects to index" do
delete :destroy, params: { ldap_group_id: id }
expect(flash[:error]).to be_present
expect(response).to redirect_to action: :index
diff --git a/modules/ldap_groups/spec/factories/synchronized_filter_factory.rb b/modules/ldap_groups/spec/factories/synchronized_filter_factory.rb
index 9c17156c117b..c9840888269a 100644
--- a/modules/ldap_groups/spec/factories/synchronized_filter_factory.rb
+++ b/modules/ldap_groups/spec/factories/synchronized_filter_factory.rb
@@ -1,9 +1,9 @@
FactoryBot.define do
- factory :ldap_synchronized_filter, class: '::LdapGroups::SynchronizedFilter' do
- name { 'foo and bar' }
- filter_string { '(|(cn=foo)(cn=bar))' }
- group_name_attribute { 'cn' }
- base_dn { 'dc=example,dc=com' }
+ factory :ldap_synchronized_filter, class: "::LdapGroups::SynchronizedFilter" do
+ name { "foo and bar" }
+ filter_string { "(|(cn=foo)(cn=bar))" }
+ group_name_attribute { "cn" }
+ base_dn { "dc=example,dc=com" }
ldap_auth_source
sync_users { true }
end
diff --git a/modules/ldap_groups/spec/factories/synchronized_group_factory.rb b/modules/ldap_groups/spec/factories/synchronized_group_factory.rb
index 9cf539f327f8..7476f3d92b90 100644
--- a/modules/ldap_groups/spec/factories/synchronized_group_factory.rb
+++ b/modules/ldap_groups/spec/factories/synchronized_group_factory.rb
@@ -1,6 +1,6 @@
FactoryBot.define do
- factory :ldap_synchronized_group, class: '::LdapGroups::SynchronizedGroup' do
- dn { 'cn=foo,ou=groups,dc=example,dc=com' }
+ factory :ldap_synchronized_group, class: "::LdapGroups::SynchronizedGroup" do
+ dn { "cn=foo,ou=groups,dc=example,dc=com" }
group factory: :group
ldap_auth_source
sync_users { true }
diff --git a/modules/ldap_groups/spec/features/administration_spec.rb b/modules/ldap_groups/spec/features/administration_spec.rb
index 37b94cfafc2d..2caeecc8b2eb 100644
--- a/modules/ldap_groups/spec/features/administration_spec.rb
+++ b/modules/ldap_groups/spec/features/administration_spec.rb
@@ -1,6 +1,6 @@
-require_relative '../spec_helper'
+require_relative "../spec_helper"
-RSpec.describe 'LDAP group sync administration spec', :js do
+RSpec.describe "LDAP group sync administration spec", :js do
let(:admin) { create(:admin) }
before do
@@ -8,65 +8,65 @@
visit ldap_groups_synchronized_groups_path
end
- context 'without EE' do
- it 'shows upsale' do
- expect(page).to have_css('.upsale-notification')
+ context "without EE" do
+ it "shows upsale" do
+ expect(page).to have_css(".upsale-notification")
end
end
- context 'with EE', with_ee: %i[ldap_groups] do
- let!(:group) { create(:group, lastname: 'foo') }
- let!(:auth_source) { create(:ldap_auth_source, name: 'ldap') }
+ context "with EE", with_ee: %i[ldap_groups] do
+ let!(:group) { create(:group, lastname: "foo") }
+ let!(:auth_source) { create(:ldap_auth_source, name: "ldap") }
- it 'allows synced group administration flow' do
- expect(page).to have_no_css('.upsale-notification')
+ it "allows synced group administration flow" do
+ expect(page).to have_no_css(".upsale-notification")
# Create group
- find('.button', text: I18n.t('ldap_groups.synchronized_groups.singular')).click
+ find(".button", text: I18n.t("ldap_groups.synchronized_groups.singular")).click
SeleniumHubWaiter.wait
- select 'ldap', from: 'synchronized_group_ldap_auth_source_id'
- select 'foo', from: 'synchronized_group_group_id'
- fill_in 'synchronized_group_dn', with: 'cn=foo,ou=groups,dc=example,dc=com'
- check 'synchronized_group_sync_users'
+ select "ldap", from: "synchronized_group_ldap_auth_source_id"
+ select "foo", from: "synchronized_group_group_id"
+ fill_in "synchronized_group_dn", with: "cn=foo,ou=groups,dc=example,dc=com"
+ check "synchronized_group_sync_users"
- click_on 'Create'
- expect(page).to have_css('.op-toast.-success', text: I18n.t(:notice_successful_create))
- expect(page).to have_css('td.dn', text: 'cn=foo,ou=groups,dc=example,dc=com')
- expect(page).to have_css('td.ldap_auth_source', text: 'ldap')
- expect(page).to have_css('td.group', text: 'foo')
- expect(page).to have_css('td.users', text: '0')
+ click_on "Create"
+ expect(page).to have_css(".op-toast.-success", text: I18n.t(:notice_successful_create))
+ expect(page).to have_css("td.dn", text: "cn=foo,ou=groups,dc=example,dc=com")
+ expect(page).to have_css("td.ldap_auth_source", text: "ldap")
+ expect(page).to have_css("td.group", text: "foo")
+ expect(page).to have_css("td.users", text: "0")
# Show entry
SeleniumHubWaiter.wait
- find('td.dn a').click
- expect(page).to have_css '.generic-table--empty-row'
+ find("td.dn a").click
+ expect(page).to have_css ".generic-table--empty-row"
# Check created group
sync = LdapGroups::SynchronizedGroup.last
expect(sync.group_id).to eq(group.id)
expect(sync.ldap_auth_source_id).to eq(auth_source.id)
- expect(sync.dn).to eq 'cn=foo,ou=groups,dc=example,dc=com'
+ expect(sync.dn).to eq "cn=foo,ou=groups,dc=example,dc=com"
# Assume we have a membership
sync.users.create user_id: admin.id
visit ldap_groups_synchronized_group_path(sync)
- expect(page).to have_css 'td.user', text: admin.name
+ expect(page).to have_css "td.user", text: admin.name
memberships = sync.users.pluck(:id)
visit ldap_groups_synchronized_groups_path
expect_angular_frontend_initialized
- find('.buttons a', text: 'Delete').click
+ find(".buttons a", text: "Delete").click
SeleniumHubWaiter.wait
- find('.danger-zone--verification input').set 'cn=foo,ou=groups,dc=example,dc=com'
+ find(".danger-zone--verification input").set "cn=foo,ou=groups,dc=example,dc=com"
SeleniumHubWaiter.wait
- click_on 'Delete'
+ click_on "Delete"
- expect(page).to have_css('.op-toast.-success', text: I18n.t(:notice_successful_delete))
- expect(page).to have_css '.generic-table--empty-row'
+ expect(page).to have_css(".op-toast.-success", text: I18n.t(:notice_successful_delete))
+ expect(page).to have_css ".generic-table--empty-row"
expect(LdapGroups::Membership.where(id: memberships)).to be_empty
end
diff --git a/modules/ldap_groups/spec/features/filter_administration_spec.rb b/modules/ldap_groups/spec/features/filter_administration_spec.rb
index c8a73e803e2b..1ff1401c9d93 100644
--- a/modules/ldap_groups/spec/features/filter_administration_spec.rb
+++ b/modules/ldap_groups/spec/features/filter_administration_spec.rb
@@ -1,14 +1,14 @@
-require_relative '../spec_helper'
+require_relative "../spec_helper"
-RSpec.describe 'LDAP group filter administration spec', :js do
+RSpec.describe "LDAP group filter administration spec", :js do
let(:admin) { create(:admin) }
before do
login_as admin
end
- context 'with EE', with_ee: %i[ldap_groups] do
- context 'when providing seed variables',
+ context "with EE", with_ee: %i[ldap_groups] do
+ context "when providing seed variables",
:settings_reset,
with_env: {
OPENPROJECT_SEED_LDAP_FOO_HOST: "localhost",
@@ -30,18 +30,18 @@
OPENPROJECT_SEED_LDAP_FOO_GROUPFILTER_BAR_SYNC__USERS: "true",
OPENPROJECT_SEED_LDAP_FOO_GROUPFILTER_BAR_GROUP__ATTRIBUTE: "dn"
} do
- it 'blocks editing of the filter' do
+ it "blocks editing of the filter" do
reset(:seed_ldap)
allow(LdapGroups::SynchronizationJob).to receive(:perform_now)
EnvData::LdapSeeder.new({}).seed_data!
visit ldap_groups_synchronized_groups_path
- expect(page).to have_text 'bar'
- page.find('td.name a', text: 'bar').click
+ expect(page).to have_text "bar"
+ page.find("td.name a", text: "bar").click
expect(page).to have_text I18n.t(:label_seeded_from_env_warning)
- expect(page).to have_no_link 'Edit'
- expect(page).to have_no_link 'Delete'
+ expect(page).to have_no_link "Edit"
+ expect(page).to have_no_link "Delete"
end
end
end
diff --git a/modules/ldap_groups/spec/models/membership_spec.rb b/modules/ldap_groups/spec/models/membership_spec.rb
index 5a75336299d7..d57b2fc64c30 100644
--- a/modules/ldap_groups/spec/models/membership_spec.rb
+++ b/modules/ldap_groups/spec/models/membership_spec.rb
@@ -1,7 +1,7 @@
-require 'spec_helper'
+require "spec_helper"
RSpec.describe LdapGroups::Membership do
- describe 'destroy' do
+ describe "destroy" do
let(:synchronized_group) { create(:ldap_synchronized_group, group:) }
let(:group) { create(:group) }
let(:user) { create(:user) }
@@ -12,7 +12,7 @@
end
end
- it 'is removed when the user is destroyed' do
+ it "is removed when the user is destroyed" do
expect(user.ldap_groups_memberships.count).to eq 1
membership = user.ldap_groups_memberships.first
expect(membership.group).to eq(synchronized_group)
diff --git a/modules/ldap_groups/spec/models/synchronized_filter_spec.rb b/modules/ldap_groups/spec/models/synchronized_filter_spec.rb
index 0ddbd2b0abd8..80753aaabfb1 100644
--- a/modules/ldap_groups/spec/models/synchronized_filter_spec.rb
+++ b/modules/ldap_groups/spec/models/synchronized_filter_spec.rb
@@ -1,26 +1,26 @@
-require 'spec_helper'
+require "spec_helper"
RSpec.describe LdapGroups::SynchronizedFilter do
- describe '#used_base_dn' do
- let(:ldap_auth_source) { build(:ldap_auth_source, base_dn: 'dc=example,dc=com') }
+ describe "#used_base_dn" do
+ let(:ldap_auth_source) { build(:ldap_auth_source, base_dn: "dc=example,dc=com") }
let(:filter) { build(:ldap_synchronized_filter, ldap_auth_source:) }
- it 'validates the end of the base dn matches the ldap_auth_source' do
+ it "validates the end of the base dn matches the ldap_auth_source" do
filter.base_dn = nil
expect(filter.base_dn).to be_nil
expect(filter.used_base_dn).to eq(ldap_auth_source.base_dn)
end
end
- describe '#base_dn' do
- let(:ldap_auth_source) { build(:ldap_auth_source, base_dn: 'dc=example,dc=com') }
+ describe "#base_dn" do
+ let(:ldap_auth_source) { build(:ldap_auth_source, base_dn: "dc=example,dc=com") }
let(:filter) { build(:ldap_synchronized_filter, ldap_auth_source:) }
- it 'validates the end of the base dn matches the ldap_auth_source' do
+ it "validates the end of the base dn matches the ldap_auth_source" do
filter.base_dn = nil
expect(filter).to be_valid
- filter.base_dn = 'dc=something,dc=else'
+ filter.base_dn = "dc=something,dc=else"
expect(filter).not_to be_valid
expect(filter.errors.details[:base_dn]).to contain_exactly(error: :must_contain_base_dn)
end
diff --git a/modules/ldap_groups/spec/models/synchronized_group_spec.rb b/modules/ldap_groups/spec/models/synchronized_group_spec.rb
index 4605b8909f44..f8a8f8c7aad5 100644
--- a/modules/ldap_groups/spec/models/synchronized_group_spec.rb
+++ b/modules/ldap_groups/spec/models/synchronized_group_spec.rb
@@ -1,19 +1,19 @@
-require 'spec_helper'
+require "spec_helper"
RSpec.describe LdapGroups::SynchronizedGroup do
- describe 'validations' do
+ describe "validations" do
subject { build(:ldap_synchronized_group) }
- context 'correct attributes' do
- it 'saves the record' do
+ context "correct attributes" do
+ it "saves the record" do
expect(subject.save).to be true
end
end
- context 'missing attributes' do
+ context "missing attributes" do
subject { described_class.new }
- it 'validates missing attributes' do
+ it "validates missing attributes" do
expect(subject.save).to be false
expect(subject.errors[:dn]).to include "can't be blank."
expect(subject.errors[:ldap_auth_source]).to include "can't be blank."
@@ -22,16 +22,16 @@
end
end
- describe 'manipulating members' do
+ describe "manipulating members" do
let(:users) { [user1, user2] }
let(:user1) { create(:user) }
let(:user2) { create(:user) }
- describe '.add_members!' do
+ describe ".add_members!" do
let(:synchronized_group) { create(:ldap_synchronized_group, group:) }
let(:group) { create(:group) }
- shared_examples 'it adds users to the synchronized group and the internal one' do
+ shared_examples "it adds users to the synchronized group and the internal one" do
let(:members) { raise "define me!" }
before do
@@ -43,29 +43,29 @@
end
end
- it 'adds the user(s) to the internal group' do
+ it "adds the user(s) to the internal group" do
expect(group.reload.users).to match_array users
end
- it 'adds the user(s) to the synchronized group' do
+ it "adds the user(s) to the synchronized group" do
expect(synchronized_group.reload.users.map(&:user)).to match_array users
end
end
- context 'called with user records' do
- it_behaves_like 'it adds users to the synchronized group and the internal one' do
+ context "called with user records" do
+ it_behaves_like "it adds users to the synchronized group and the internal one" do
let(:members) { users }
end
end
- context 'called just with user IDs' do
- it_behaves_like 'it adds users to the synchronized group and the internal one' do
+ context "called just with user IDs" do
+ it_behaves_like "it adds users to the synchronized group and the internal one" do
let(:members) { users.pluck(:id) }
end
end
end
- describe '.remove_members!' do
+ describe ".remove_members!" do
let(:synchronized_group) do
create(:ldap_synchronized_group, group:).tap do |sg|
group.users.each do |user|
@@ -75,43 +75,43 @@
end
let(:group) { create(:group, members: users) }
- shared_examples 'it removes the users from the synchronized group and the internal one' do
+ shared_examples "it removes the users from the synchronized group and the internal one" do
let(:members) { raise "define me!" }
before do
synchronized_group.remove_members! members
end
- it 'removes the user(s) from the internal group' do
+ it "removes the user(s) from the internal group" do
expect(group.reload.users).to be_empty
end
- it 'removes the users(s) from the synchronized group' do
+ it "removes the users(s) from the synchronized group" do
expect(synchronized_group.users).to be_empty
end
- it 'does not, however, delete the actual users!' do
+ it "does not, however, delete the actual users!" do
expect(User.find(users.map(&:id))).to match_array users
end
end
- context 'called with user records' do
- it_behaves_like 'it removes the users from the synchronized group and the internal one' do
+ context "called with user records" do
+ it_behaves_like "it removes the users from the synchronized group and the internal one" do
let(:members) { group.users }
end
end
- context 'called just with user IDs' do
- it_behaves_like 'it removes the users from the synchronized group and the internal one' do
+ context "called just with user IDs" do
+ it_behaves_like "it removes the users from the synchronized group and the internal one" do
let(:members) { group.users.pluck(:id) }
end
end
- context 'when the service call fails for any reason' do
+ context "when the service call fails for any reason" do
let(:service) { instance_double(Groups::UpdateService) }
- let(:failure_result) { ServiceResult.failure(message: 'oh noes') }
+ let(:failure_result) { ServiceResult.failure(message: "oh noes") }
- it 'does not commit the changes' do
+ it "does not commit the changes" do
allow(Groups::UpdateService).to receive(:new).and_return(service)
allow(service).to receive(:call).and_return(failure_result)
diff --git a/modules/ldap_groups/spec/services/synchronization_spec.rb b/modules/ldap_groups/spec/services/synchronization_spec.rb
index 2b4bfb5da2de..fcbca7507ba3 100644
--- a/modules/ldap_groups/spec/services/synchronization_spec.rb
+++ b/modules/ldap_groups/spec/services/synchronization_spec.rb
@@ -1,11 +1,11 @@
-require File.dirname(__FILE__) + '/../spec_helper'
-require 'ladle'
+require File.dirname(__FILE__) + "/../spec_helper"
+require "ladle"
RSpec.describe LdapGroups::SynchronizeGroupsService, with_ee: %i[ldap_groups] do
- include_context 'with temporary LDAP'
+ include_context "with temporary LDAP"
let(:plugin_settings) do
- { group_base: 'ou=groups,dc=example,dc=com', group_key: 'cn' }
+ { group_base: "ou=groups,dc=example,dc=com", group_key: "cn" }
end
# Ldap has:
@@ -14,38 +14,38 @@
let(:ldap_auth_source) do
create(:ldap_auth_source,
port: ParallelHelper.port_for_ldap.to_s,
- account: 'uid=admin,ou=system',
- account_password: 'secret',
- base_dn: 'ou=people,dc=example,dc=com',
+ account: "uid=admin,ou=system",
+ account_password: "secret",
+ base_dn: "ou=people,dc=example,dc=com",
onthefly_register:,
filter_string: ldap_filter,
- attr_login: 'uid',
- attr_firstname: 'givenName',
- attr_lastname: 'sn',
- attr_mail: 'mail')
+ attr_login: "uid",
+ attr_firstname: "givenName",
+ attr_lastname: "sn",
+ attr_mail: "mail")
end
let(:onthefly_register) { false }
let(:sync_users) { false }
let(:ldap_filter) { nil }
- let(:user_aa729) { create(:user, login: 'aa729', ldap_auth_source:) }
- let(:user_bb459) { create(:user, login: 'bb459', ldap_auth_source:) }
- let(:user_cc414) { create(:user, login: 'cc414', ldap_auth_source:) }
+ let(:user_aa729) { create(:user, login: "aa729", ldap_auth_source:) }
+ let(:user_bb459) { create(:user, login: "bb459", ldap_auth_source:) }
+ let(:user_cc414) { create(:user, login: "cc414", ldap_auth_source:) }
- let(:group_foo) { create(:group, lastname: 'foo_internal') }
- let(:group_bar) { create(:group, lastname: 'bar') }
+ let(:group_foo) { create(:group, lastname: "foo_internal") }
+ let(:group_bar) { create(:group, lastname: "bar") }
let(:synced_foo) do
create(:ldap_synchronized_group,
- dn: 'cn=foo,ou=groups,dc=example,dc=com',
+ dn: "cn=foo,ou=groups,dc=example,dc=com",
group: group_foo,
sync_users:,
ldap_auth_source:)
end
let(:synced_bar) do
create(:ldap_synchronized_group,
- dn: 'cn=bar,ou=groups,dc=example,dc=com',
+ dn: "cn=bar,ou=groups,dc=example,dc=com",
group: group_bar,
sync_users:,
ldap_auth_source:)
@@ -58,8 +58,8 @@
end
end
- shared_examples 'does not change membership count' do
- it 'does not change membership count' do
+ shared_examples "does not change membership count" do
+ it "does not change membership count" do
subject
expect(group_foo.users).to be_empty
@@ -70,33 +70,33 @@
end
end
- describe 'adding memberships' do
- context 'when no synced group exists' do
+ describe "adding memberships" do
+ context "when no synced group exists" do
before do
user_aa729
user_bb459
user_cc414
end
- it_behaves_like 'does not change membership count'
+ it_behaves_like "does not change membership count"
end
- context 'when one synced group exists' do
+ context "when one synced group exists" do
before do
group_foo
synced_foo
end
- context 'when no users exist' do
- it_behaves_like 'does not change membership count'
+ context "when no users exist" do
+ it_behaves_like "does not change membership count"
end
- context 'when one mapped user exists' do
+ context "when one mapped user exists" do
before do
user_aa729
end
- it 'synchronized the membership of aa729 to foo' do
+ it "synchronized the membership of aa729 to foo" do
subject
expect(synced_foo.users.count).to eq(1)
expect(group_foo.users).to eq([user_aa729])
@@ -104,7 +104,7 @@
end
end
- context 'when all groups exist' do
+ context "when all groups exist" do
before do
group_foo
synced_foo
@@ -112,14 +112,14 @@
synced_bar
end
- context 'and all users exist' do
+ context "and all users exist" do
before do
user_aa729
user_bb459
user_cc414
end
- describe 'synchronizes all memberships' do
+ describe "synchronizes all memberships" do
before do
subject
@@ -130,7 +130,7 @@
expect(group_bar.users).to eq([user_aa729, user_bb459, user_cc414])
end
- it 'removes all memberships after removing synced group' do
+ it "removes all memberships after removing synced group" do
synced_foo_id = synced_foo.id
expect(LdapGroups::Membership.where(group_id: synced_foo_id).count).to eq(1)
synced_foo.destroy
@@ -140,7 +140,7 @@
expect(LdapGroups::Membership.where(group_id: synced_foo_id)).to be_empty
end
- it 'removes all memberships and groups after removing auth source' do
+ it "removes all memberships and groups after removing auth source" do
expect { ldap_auth_source.destroy! }
.to change { LdapGroups::Membership.count }.from(4).to(0)
@@ -148,7 +148,7 @@
expect { synced_bar.reload }.to raise_error ActiveRecord::RecordNotFound
end
- it 'removes all memberships and groups after removing actual group' do
+ it "removes all memberships and groups after removing actual group" do
synced_foo_id = synced_foo.id
expect(LdapGroups::Membership.where(group_id: synced_foo_id).count).to eq(1)
group_foo.destroy
@@ -162,12 +162,12 @@
end
end
- context 'and only one user of bar exists' do
+ context "and only one user of bar exists" do
before do
user_cc414
end
- it 'synchronized that membership' do
+ it "synchronized that membership" do
subject
expect(synced_foo.users.count).to eq(0)
expect(synced_bar.users.count).to eq(1)
@@ -176,15 +176,15 @@
expect(group_bar.users).to eq([user_cc414])
end
- context 'with LDAP on-the-fly disabled' do
+ context "with LDAP on-the-fly disabled" do
let(:onthefly_register) { false }
- let(:user_aa729) { User.find_by login: 'aa729' }
- let(:user_bb459) { User.find_by login: 'bb459' }
+ let(:user_aa729) { User.find_by login: "aa729" }
+ let(:user_bb459) { User.find_by login: "bb459" }
- context 'and users sync in the groups enabled' do
+ context "and users sync in the groups enabled" do
let(:sync_users) { true }
- it 'creates the remaining users' do
+ it "creates the remaining users" do
subject
expect(synced_foo.users.count).to eq(1)
expect(synced_bar.users.count).to eq(3)
@@ -194,10 +194,10 @@
end
end
- context 'and users sync not enabled' do
+ context "and users sync not enabled" do
let(:sync_users) { false }
- it 'does not create the users' do
+ it "does not create the users" do
subject
expect(synced_foo.users.count).to eq(0)
expect(synced_bar.users.count).to eq(1)
@@ -208,15 +208,15 @@
end
end
- context 'with LDAP on-the-fly enabled' do
+ context "with LDAP on-the-fly enabled" do
let(:onthefly_register) { true }
- let(:user_aa729) { User.find_by login: 'aa729' }
- let(:user_bb459) { User.find_by login: 'bb459' }
+ let(:user_aa729) { User.find_by login: "aa729" }
+ let(:user_bb459) { User.find_by login: "bb459" }
- context 'and users sync in the groups enabled' do
+ context "and users sync in the groups enabled" do
let(:sync_users) { true }
- it 'creates the remaining users' do
+ it "creates the remaining users" do
subject
expect(synced_foo.users.count).to eq(1)
expect(synced_bar.users.count).to eq(3)
@@ -226,10 +226,10 @@
end
end
- context 'and users sync not enabled' do
+ context "and users sync not enabled" do
let(:sync_users) { false }
- it 'does not create the users' do
+ it "does not create the users" do
subject
expect(synced_foo.users.count).to eq(0)
expect(synced_bar.users.count).to eq(1)
@@ -240,16 +240,16 @@
end
end
- context 'with an LDAP filter for users starting with b and on-the-fly enabled' do
+ context "with an LDAP filter for users starting with b and on-the-fly enabled" do
let(:onthefly_register) { true }
- let(:ldap_filter) { '(uid=b*)' }
- let(:user_aa729) { User.find_by login: 'aa729' }
- let(:user_bb459) { User.find_by login: 'bb459' }
+ let(:ldap_filter) { "(uid=b*)" }
+ let(:user_aa729) { User.find_by login: "aa729" }
+ let(:user_bb459) { User.find_by login: "bb459" }
- context 'and users sync in the groups enabled' do
+ context "and users sync in the groups enabled" do
let(:sync_users) { true }
- it 'creates the remaining users' do
+ it "creates the remaining users" do
subject
expect(synced_foo.users.count).to eq(0)
expect(synced_bar.users.count).to eq(1)
@@ -260,10 +260,10 @@
end
end
- context 'and users sync not enabled' do
+ context "and users sync not enabled" do
let(:sync_users) { false }
- it 'does not create the users' do
+ it "does not create the users" do
subject
expect(synced_foo.users.count).to eq(0)
expect(synced_bar.users.count).to eq(0)
@@ -276,15 +276,15 @@
end
end
- context 'foo group exists' do
- let(:group_foo) { create(:group, lastname: 'foo_internal', members: user_aa729) }
+ context "foo group exists" do
+ let(:group_foo) { create(:group, lastname: "foo_internal", members: user_aa729) }
before do
group_foo
synced_foo
end
- it 'takes over users that are in LDAP' do
+ it "takes over users that are in LDAP" do
membership = LdapGroups::Membership.find_by user: user_aa729, group: group_foo
expect(membership).not_to be_present
@@ -300,11 +300,11 @@
end
end
- describe 'removing memberships' do
- context 'with a user in a group thats not in ldap' do
- let(:group_foo) { create(:group, lastname: 'foo_internal', members: [user_cc414, user_aa729]) }
- let(:manager) { create(:project_role, name: 'Manager') }
- let(:project) { create(:project, name: 'Project 1', identifier: 'project1', members: { group_foo => [manager] }) }
+ describe "removing memberships" do
+ context "with a user in a group thats not in ldap" do
+ let(:group_foo) { create(:group, lastname: "foo_internal", members: [user_cc414, user_aa729]) }
+ let(:manager) { create(:project_role, name: "Manager") }
+ let(:project) { create(:project, name: "Project 1", identifier: "project1", members: { group_foo => [manager] }) }
before do
project
@@ -312,7 +312,7 @@
synced_foo.users.create(user: user_cc414)
end
- it 'removes the membership' do
+ it "removes the membership" do
expect(project.members.count).to eq 2
expect(project.users).to contain_exactly user_aa729, user_cc414
@@ -331,14 +331,14 @@
end
end
- context 'with invalid connection' do
+ context "with invalid connection" do
let(:ldap_auth_source) { create(:ldap_auth_source) }
before do
synced_foo
end
- it 'does not raise, but print to stderr' do
+ it "does not raise, but print to stderr" do
allow(Rails.logger).to receive(:error)
subject
@@ -348,24 +348,24 @@
end
end
- context 'with invalid base' do
+ context "with invalid base" do
let(:synced_foo) do
- create(:ldap_synchronized_group, dn: 'cn=foo,ou=invalid,dc=example,dc=com', group: group_foo,
+ create(:ldap_synchronized_group, dn: "cn=foo,ou=invalid,dc=example,dc=com", group: group_foo,
ldap_auth_source:)
end
let(:synced_bar) do
- create(:ldap_synchronized_group, dn: 'cn=bar,ou=invalid,dc=example,dc=com', group: group_bar,
+ create(:ldap_synchronized_group, dn: "cn=bar,ou=invalid,dc=example,dc=com", group: group_bar,
ldap_auth_source:)
end
- context 'when one synced group exists' do
+ context "when one synced group exists" do
before do
group_foo
synced_foo
user_aa729
end
- it 'does not find the group and syncs no user' do
+ it "does not find the group and syncs no user" do
subject
expect(synced_foo.users).to be_empty
expect(group_foo.users).to eq([])
@@ -373,14 +373,14 @@
end
end
- context 'when one user does not match case' do
+ context "when one user does not match case" do
before do
group_foo
synced_foo
- user_aa729.update_attribute(:login, 'Aa729')
+ user_aa729.update_attribute(:login, "Aa729")
end
- it 'synchronized the membership of aa729 to foo' do
+ it "synchronized the membership of aa729 to foo" do
subject
expect(synced_foo.users.count).to eq(1)
expect(group_foo.users).to eq([user_aa729])
diff --git a/modules/ldap_groups/spec/services/synchronize_filter_spec.rb b/modules/ldap_groups/spec/services/synchronize_filter_spec.rb
index 77cc5457eed7..c6c0c9ae2ad3 100644
--- a/modules/ldap_groups/spec/services/synchronize_filter_spec.rb
+++ b/modules/ldap_groups/spec/services/synchronize_filter_spec.rb
@@ -1,10 +1,10 @@
-require File.dirname(__FILE__) + '/../spec_helper'
-require 'ladle'
+require File.dirname(__FILE__) + "/../spec_helper"
+require "ladle"
RSpec.describe LdapGroups::SynchronizeFilterService, with_ee: %i[ldap_groups] do
before(:all) do
- ldif = Rails.root.join('spec/fixtures/ldap/users.ldif')
- @ldap_server = Ladle::Server.new(quiet: false, port: ParallelHelper.port_for_ldap.to_s, domain: 'dc=example,dc=com',
+ ldif = Rails.root.join("spec/fixtures/ldap/users.ldif")
+ @ldap_server = Ladle::Server.new(quiet: false, port: ParallelHelper.port_for_ldap.to_s, domain: "dc=example,dc=com",
ldif:).start
end
@@ -18,19 +18,19 @@
let(:ldap_auth_source) do
create(:ldap_auth_source,
port: ParallelHelper.port_for_ldap.to_s,
- account: 'uid=admin,ou=system',
- account_password: 'secret',
- base_dn: 'dc=example,dc=com',
- attr_login: 'uid')
+ account: "uid=admin,ou=system",
+ account_password: "secret",
+ base_dn: "dc=example,dc=com",
+ attr_login: "uid")
end
- let(:group_foo) { create(:group, lastname: 'foo') }
- let(:group_bar) { create(:group, lastname: 'bar') }
+ let(:group_foo) { create(:group, lastname: "foo") }
+ let(:group_bar) { create(:group, lastname: "bar") }
let(:synced_foo) do
create(
:ldap_synchronized_group,
- dn: 'cn=foo,ou=groups,dc=example,dc=com',
+ dn: "cn=foo,ou=groups,dc=example,dc=com",
group: group_foo,
ldap_auth_source:
)
@@ -38,7 +38,7 @@
let(:synced_bar) do
create(
:ldap_synchronized_group,
- dn: 'cn=bar,ou=groups,dc=example,dc=com',
+ dn: "cn=bar,ou=groups,dc=example,dc=com",
group: group_bar,
ldap_auth_source:
)
@@ -48,42 +48,42 @@
subject { described_class.new(filter_foo_bar).call }
- shared_examples 'has foo and bar synced groups' do
- it 'creates the two groups' do
+ shared_examples "has foo and bar synced groups" do
+ it "creates the two groups" do
expect { subject }.not_to raise_error
filter_foo_bar.reload
# Expect two synchronized groups added
expect(filter_foo_bar.groups.count).to eq 2
- expect(filter_foo_bar.groups.map(&:dn)).to contain_exactly('cn=foo,ou=groups,dc=example,dc=com',
- 'cn=bar,ou=groups,dc=example,dc=com')
+ expect(filter_foo_bar.groups.map(&:dn)).to contain_exactly("cn=foo,ou=groups,dc=example,dc=com",
+ "cn=bar,ou=groups,dc=example,dc=com")
# Expect two actual groups added
- op_foo_group = Group.find_by(lastname: 'foo')
- op_bar_group = Group.find_by(lastname: 'bar')
+ op_foo_group = Group.find_by(lastname: "foo")
+ op_bar_group = Group.find_by(lastname: "bar")
expect(op_foo_group).to be_present
expect(op_bar_group).to be_present
- sync_foo_group = LdapGroups::SynchronizedGroup.find_by(dn: 'cn=foo,ou=groups,dc=example,dc=com')
- sync_bar_group = LdapGroups::SynchronizedGroup.find_by(dn: 'cn=bar,ou=groups,dc=example,dc=com')
+ sync_foo_group = LdapGroups::SynchronizedGroup.find_by(dn: "cn=foo,ou=groups,dc=example,dc=com")
+ sync_bar_group = LdapGroups::SynchronizedGroup.find_by(dn: "cn=bar,ou=groups,dc=example,dc=com")
expect(sync_foo_group.group).to eq op_foo_group
expect(sync_bar_group.group).to eq op_bar_group
end
end
- describe 'when filter is new and nothing exists' do
- it_behaves_like 'has foo and bar synced groups'
+ describe "when filter is new and nothing exists" do
+ it_behaves_like "has foo and bar synced groups"
end
- describe 'when one group already exists' do
+ describe "when one group already exists" do
before do
synced_foo
end
- it_behaves_like 'has foo and bar synced groups'
+ it_behaves_like "has foo and bar synced groups"
- it 'the group is taken over by the filter' do
+ it "the group is taken over by the filter" do
expect { subject }.not_to raise_error
synced_foo.reload
@@ -91,10 +91,10 @@
end
end
- describe 'when one group already exists with different settings' do
+ describe "when one group already exists with different settings" do
let(:synced_foo) do
create(:ldap_synchronized_group,
- dn: 'cn=foo,ou=groups,dc=example,dc=com',
+ dn: "cn=foo,ou=groups,dc=example,dc=com",
group: group_foo,
sync_users: false,
ldap_auth_source:)
@@ -109,7 +109,7 @@
synced_foo
end
- it 'the group receives the value of the filter' do
+ it "the group receives the value of the filter" do
expect(synced_foo.sync_users).to be false
expect { subject }.not_to raise_error
@@ -118,47 +118,47 @@
end
end
- describe 'when it has a group that no longer exists in ldap' do
- let!(:group_doesnotexist) { create(:group, lastname: 'doesnotexist') }
+ describe "when it has a group that no longer exists in ldap" do
+ let!(:group_doesnotexist) { create(:group, lastname: "doesnotexist") }
let!(:synced_doesnotexist) do
create(:ldap_synchronized_group,
- dn: 'cn=doesnotexist,ou=groups,dc=example,dc=com',
+ dn: "cn=doesnotexist,ou=groups,dc=example,dc=com",
group: group_doesnotexist,
filter: filter_foo_bar,
ldap_auth_source:)
end
- it 'removes that group' do
+ it "removes that group" do
expect { subject }.not_to raise_error
expect { synced_doesnotexist.reload }.to raise_error(ActiveRecord::RecordNotFound)
end
end
- describe 'when filter has sync_users selected' do
+ describe "when filter has sync_users selected" do
let(:filter_foo_bar) { create(:ldap_synchronized_filter, ldap_auth_source:, sync_users: true) }
- it 'creates the groups with sync_users flag set' do
+ it "creates the groups with sync_users flag set" do
expect { subject }.not_to raise_error
filter_foo_bar.reload
# Expect two synchronized groups added
expect(filter_foo_bar.groups.count).to eq 2
- sync_foo_group = LdapGroups::SynchronizedGroup.find_by(dn: 'cn=foo,ou=groups,dc=example,dc=com')
- sync_bar_group = LdapGroups::SynchronizedGroup.find_by(dn: 'cn=bar,ou=groups,dc=example,dc=com')
+ sync_foo_group = LdapGroups::SynchronizedGroup.find_by(dn: "cn=foo,ou=groups,dc=example,dc=com")
+ sync_bar_group = LdapGroups::SynchronizedGroup.find_by(dn: "cn=bar,ou=groups,dc=example,dc=com")
expect(sync_foo_group.sync_users).to be_truthy
expect(sync_bar_group.sync_users).to be_truthy
end
end
- describe 'when filter has its own base dn' do
+ describe "when filter has its own base dn" do
let(:filter_foo_bar) do
create(:ldap_synchronized_filter,
ldap_auth_source:,
- base_dn: 'ou=users,dc=example,dc=com')
+ base_dn: "ou=users,dc=example,dc=com")
end
- it 'uses that base for searching and doesnt find any groups' do
+ it "uses that base for searching and doesnt find any groups" do
expect { subject }.not_to raise_error
filter_foo_bar.reload
diff --git a/modules/meeting/app/components/banner_message_component.rb b/modules/meeting/app/components/banner_message_component.rb
index 70f33ff8c5cb..e72512e4882b 100644
--- a/modules/meeting/app/components/banner_message_component.rb
+++ b/modules/meeting/app/components/banner_message_component.rb
@@ -31,7 +31,7 @@ def initialize(message: nil,
full: true,
full_when_narrow: false,
dismiss_scheme: :hide,
- dismiss_label: I18n.t('button_close'),
+ dismiss_label: I18n.t("button_close"),
icon: false,
scheme: :default,
test_selector: "primer-banner-message-component")
diff --git a/modules/meeting/app/components/meeting_agenda_items/form_component.rb b/modules/meeting/app/components/meeting_agenda_items/form_component.rb
index 599b74882395..39d90ce694a6 100644
--- a/modules/meeting/app/components/meeting_agenda_items/form_component.rb
+++ b/modules/meeting/app/components/meeting_agenda_items/form_component.rb
@@ -56,9 +56,9 @@ def render?
def wrapper_data_attributes
{
- controller: 'meeting-agenda-item-form',
- 'application-target': 'dynamic',
- 'meeting-agenda-item-form-cancel-url-value': @cancel_path
+ controller: "meeting-agenda-item-form",
+ "application-target": "dynamic",
+ "meeting-agenda-item-form-cancel-url-value": @cancel_path
}
end
diff --git a/modules/meeting/app/components/meeting_agenda_items/item_component.rb b/modules/meeting/app/components/meeting_agenda_items/item_component.rb
index 0e961c52ad42..e52d1cb514b4 100644
--- a/modules/meeting/app/components/meeting_agenda_items/item_component.rb
+++ b/modules/meeting/app/components/meeting_agenda_items/item_component.rb
@@ -86,7 +86,7 @@ def wrapper_arguments
scheme: :default,
data: {
id: @meeting_agenda_item.id,
- 'drop-url': drop_meeting_agenda_item_path(@meeting_agenda_item.meeting, @meeting_agenda_item)
+ "drop-url": drop_meeting_agenda_item_path(@meeting_agenda_item.meeting, @meeting_agenda_item)
}
}
end
diff --git a/modules/meeting/app/components/meeting_agenda_items/item_component/show_component.rb b/modules/meeting/app/components/meeting_agenda_items/item_component/show_component.rb
index 88a711c49b01..cb3f6d9e45b6 100644
--- a/modules/meeting/app/components/meeting_agenda_items/item_component/show_component.rb
+++ b/modules/meeting/app/components/meeting_agenda_items/item_component/show_component.rb
@@ -81,7 +81,7 @@ def edit_action_item(menu)
menu.with_item(label: t("label_edit"),
href: edit_meeting_agenda_item_path(@meeting_agenda_item.meeting, @meeting_agenda_item),
content_arguments: {
- data: { 'turbo-stream': true }
+ data: { "turbo-stream": true }
}) do |item|
item.with_leading_visual_icon(icon: :pencil)
end
@@ -92,7 +92,7 @@ def add_note_action_item(menu)
href: edit_meeting_agenda_item_path(@meeting_agenda_item.meeting, @meeting_agenda_item,
display_notes_input: true),
content_arguments: {
- data: { 'turbo-stream': true }
+ data: { "turbo-stream": true }
}) do |item|
item.with_leading_visual_icon(icon: :note)
end
@@ -110,7 +110,7 @@ def delete_action_item(menu)
scheme: :danger,
href: meeting_agenda_item_path(@meeting_agenda_item.meeting, @meeting_agenda_item),
form_arguments: {
- method: :delete, data: { confirm: t("text_are_you_sure"), 'turbo-stream': true }
+ method: :delete, data: { confirm: t("text_are_you_sure"), "turbo-stream": true }
}) do |item|
item.with_leading_visual_icon(icon: :trash)
end
@@ -121,7 +121,7 @@ def move_action_item(menu, move_to, label_text, icon)
href: move_meeting_agenda_item_path(@meeting_agenda_item.meeting, @meeting_agenda_item,
move_to:),
form_arguments: {
- method: :put, data: { 'turbo-stream': true }
+ method: :put, data: { "turbo-stream": true }
}) do |item|
item.with_leading_visual_icon(icon:)
end
diff --git a/modules/meeting/app/components/meeting_agenda_items/list_component.rb b/modules/meeting/app/components/meeting_agenda_items/list_component.rb
index d44b477a41c0..79bb962b064e 100644
--- a/modules/meeting/app/components/meeting_agenda_items/list_component.rb
+++ b/modules/meeting/app/components/meeting_agenda_items/list_component.rb
@@ -44,9 +44,9 @@ def initialize(meeting:, form_hidden: true, form_type: :simple)
def wrapper_data_attributes
{
- controller: 'meeting-agenda-item-drag-and-drop',
- 'application-target': 'dynamic',
- 'target-tag': 'ul'
+ controller: "meeting-agenda-item-drag-and-drop",
+ "application-target": "dynamic",
+ "target-tag": "ul"
}
end
@@ -55,7 +55,7 @@ def insert_target_modified?
end
def insert_target_modifier_id
- 'meeting-agenda-items-new-item'
+ "meeting-agenda-items-new-item"
end
end
end
diff --git a/modules/meeting/app/components/meetings/add_button_component.rb b/modules/meeting/app/components/meetings/add_button_component.rb
index 84c8856fcc3a..7b5a3afbfe2a 100644
--- a/modules/meeting/app/components/meetings/add_button_component.rb
+++ b/modules/meeting/app/components/meetings/add_button_component.rb
@@ -44,7 +44,7 @@ def dynamic_path
end
def id
- 'add-meeting-button'
+ "add-meeting-button"
end
def accessibility_label_text
diff --git a/modules/meeting/app/components/meetings/row_component.rb b/modules/meeting/app/components/meetings/row_component.rb
index 1db1a654ac7d..800a65cc5516 100644
--- a/modules/meeting/app/components/meetings/row_component.rb
+++ b/modules/meeting/app/components/meetings/row_component.rb
@@ -40,9 +40,9 @@ def title
def type
if model.is_a?(StructuredMeeting)
- I18n.t('meeting.types.structured')
+ I18n.t("meeting.types.structured")
else
- I18n.t('meeting.types.classic')
+ I18n.t("meeting.types.classic")
end
end
@@ -57,7 +57,7 @@ def duration
def location
helpers.auto_link(model.location,
link: :all,
- html: { target: '_blank' })
+ html: { target: "_blank" })
end
end
end
diff --git a/modules/meeting/app/components/meetings/sidebar/participants_component.rb b/modules/meeting/app/components/meetings/sidebar/participants_component.rb
index bc67bca91183..0d2c2b7dabe5 100644
--- a/modules/meeting/app/components/meetings/sidebar/participants_component.rb
+++ b/modules/meeting/app/components/meetings/sidebar/participants_component.rb
@@ -36,8 +36,8 @@ class Sidebar::ParticipantsComponent < ApplicationComponent
def wrapper_data_attributes
{
- controller: 'meetings-sidebar-participants',
- 'application-target': 'dynamic'
+ controller: "meetings-sidebar-participants",
+ "application-target": "dynamic"
}
end
@@ -55,10 +55,10 @@ def count
def render_participant(participant)
flex_layout(align_items: :center) do |flex|
- flex.with_column(classes: 'ellipsis') do
+ flex.with_column(classes: "ellipsis") do
render(Users::AvatarComponent.new(user: participant.user,
size: :medium,
- classes: 'op-principal_flex'))
+ classes: "op-principal_flex"))
end
render_participant_state(participant, flex)
end
diff --git a/modules/meeting/app/components/meetings/table_component.rb b/modules/meeting/app/components/meetings/table_component.rb
index 1bad5a4b2ad7..f9b03a821799 100644
--- a/modules/meeting/app/components/meetings/table_component.rb
+++ b/modules/meeting/app/components/meetings/table_component.rb
@@ -39,7 +39,7 @@ def initial_sort
end
def sortable_columns_correlation
- super.merge(project_name: 'projects.name')
+ super.merge(project_name: "projects.name")
end
def initialize_sorted_model
diff --git a/modules/meeting/app/controllers/meeting_agendas_controller.rb b/modules/meeting/app/controllers/meeting_agendas_controller.rb
index f8decd73a402..b67480d1f420 100644
--- a/modules/meeting/app/controllers/meeting_agendas_controller.rb
+++ b/modules/meeting/app/controllers/meeting_agendas_controller.rb
@@ -32,18 +32,18 @@ class MeetingAgendasController < MeetingContentsController
def close
@meeting.close_agenda_and_copy_to_minutes!
- redirect_back_or_default controller: '/meetings', action: 'show', id: @meeting
+ redirect_back_or_default controller: "/meetings", action: "show", id: @meeting
end
def open
@content.unlock!
- redirect_back_or_default controller: '/meetings', action: 'show', id: @meeting
+ redirect_back_or_default controller: "/meetings", action: "show", id: @meeting
end
private
def find_content
@content = @meeting.agenda || @meeting.build_agenda
- @content_type = 'meeting_agenda'
+ @content_type = "meeting_agenda"
end
end
diff --git a/modules/meeting/app/controllers/meeting_contents_controller.rb b/modules/meeting/app/controllers/meeting_contents_controller.rb
index cf68b4d26982..f4a7b3fb8bc6 100644
--- a/modules/meeting/app/controllers/meeting_contents_controller.rb
+++ b/modules/meeting/app/controllers/meeting_contents_controller.rb
@@ -45,17 +45,17 @@ class MeetingContentsController < ApplicationController
def show
if params[:id].present? && @content.last_journal.version == params[:id].to_i
# Redirect links to the last version
- redirect_to controller: '/meetings',
+ redirect_to controller: "/meetings",
action: :show,
id: @meeting,
- tab: @content_type.sub(/^meeting_/, '')
+ tab: @content_type.sub(/^meeting_/, "")
return
end
# go to an old version if a version id is given
@journaled_version = true
@content = @content.at_version params[:id] if params[:id].present?
- render 'meeting_contents/show'
+ render "meeting_contents/show"
end
def update
@@ -65,27 +65,27 @@ def update
if call.success?
flash[:notice] = I18n.t(:notice_successful_update)
- redirect_back_or_default controller: '/meetings', action: 'show', id: @meeting
+ redirect_back_or_default controller: "/meetings", action: "show", id: @meeting
else
flash.now[:error] = call.message
- params[:tab] ||= 'minutes' if @meeting.agenda.present? && @meeting.agenda.locked?
- render 'meetings/show'
+ params[:tab] ||= "minutes" if @meeting.agenda.present? && @meeting.agenda.locked?
+ render "meetings/show"
end
end
def history
# don't load text
- @content_versions = @content.journals.select('id, user_id, notes, created_at, version')
- .order(Arel.sql('version DESC'))
+ @content_versions = @content.journals.select("id, user_id, notes, created_at, version")
+ .order(Arel.sql("version DESC"))
.page(page_param)
.per_page(per_page_param)
- render 'meeting_contents/history', layout: !request.xhr?
+ render "meeting_contents/history", layout: !request.xhr?
end
def diff
@diff = @content.diff(params[:version_to], params[:version_from])
- render 'meeting_contents/diff'
+ render "meeting_contents/diff"
rescue ActiveRecord::RecordNotFound
render_404
end
diff --git a/modules/meeting/app/controllers/meeting_minutes_controller.rb b/modules/meeting/app/controllers/meeting_minutes_controller.rb
index da28ba43d743..270ac29912ed 100644
--- a/modules/meeting/app/controllers/meeting_minutes_controller.rb
+++ b/modules/meeting/app/controllers/meeting_minutes_controller.rb
@@ -33,6 +33,6 @@ class MeetingMinutesController < MeetingContentsController
def find_content
@content = @meeting.minutes || @meeting.build_minutes
- @content_type = 'meeting_minutes'
+ @content_type = "meeting_minutes"
end
end
diff --git a/modules/meeting/app/controllers/work_package_meetings_tab_controller.rb b/modules/meeting/app/controllers/work_package_meetings_tab_controller.rb
index a12c06bc88b9..add8df560536 100644
--- a/modules/meeting/app/controllers/work_package_meetings_tab_controller.rb
+++ b/modules/meeting/app/controllers/work_package_meetings_tab_controller.rb
@@ -125,9 +125,9 @@ def get_agenda_items_of_work_package(direction)
.includes(:meeting)
.where(meeting_id: Meeting.visible(current_user))
.where(work_package_id: @work_package.id)
- .order('meetings.start_time': :asc)
+ .order("meetings.start_time": :asc)
- comparison = direction == :past ? '<' : '>='
+ comparison = direction == :past ? "<" : ">="
agenda_items.where("meetings.start_time + (interval '1 hour' * meetings.duration) #{comparison} ?", Time.zone.now)
end
end
diff --git a/modules/meeting/app/forms/meeting_agenda_item/duration.rb b/modules/meeting/app/forms/meeting_agenda_item/duration.rb
index 4be1c75d6d66..5c4f91caa0b0 100644
--- a/modules/meeting/app/forms/meeting_agenda_item/duration.rb
+++ b/modules/meeting/app/forms/meeting_agenda_item/duration.rb
@@ -30,7 +30,7 @@ class MeetingAgendaItem::Duration < ApplicationForm
form do |agenda_item_form|
agenda_item_form.text_field(
name: :duration_in_minutes,
- placeholder: I18n.t('activerecord.attributes.meeting_agenda_items.duration_in_minutes'),
+ placeholder: I18n.t("activerecord.attributes.meeting_agenda_items.duration_in_minutes"),
label: MeetingAgendaItem.human_attribute_name(:duration_in_minutes),
leading_visual: { icon: :stopwatch },
visually_hide_label: true,
diff --git a/modules/meeting/app/forms/meeting_agenda_item/meeting_form.rb b/modules/meeting/app/forms/meeting_agenda_item/meeting_form.rb
index 3617285ef9e5..0effb6db1bb9 100644
--- a/modules/meeting/app/forms/meeting_agenda_item/meeting_form.rb
+++ b/modules/meeting/app/forms/meeting_agenda_item/meeting_form.rb
@@ -61,6 +61,6 @@ def initialize(disabled: false, wrapper_id: nil)
end
def append_to_container
- @wrapper_id.nil? ? 'body' : "##{@wrapper_id}"
+ @wrapper_id.nil? ? "body" : "##{@wrapper_id}"
end
end
diff --git a/modules/meeting/app/forms/meeting_agenda_item/title.rb b/modules/meeting/app/forms/meeting_agenda_item/title.rb
index 9b8a8bff88d8..20744648912f 100644
--- a/modules/meeting/app/forms/meeting_agenda_item/title.rb
+++ b/modules/meeting/app/forms/meeting_agenda_item/title.rb
@@ -35,10 +35,10 @@ class MeetingAgendaItem::Title < ApplicationForm
visually_hide_label: true,
required: true,
autofocus: true,
- autocomplete: 'off',
+ autocomplete: "off",
disabled: @disabled,
data: {
- action: 'keydown.esc->meeting-agenda-item-form#cancel'
+ action: "keydown.esc->meeting-agenda-item-form#cancel"
}
)
end
diff --git a/modules/meeting/app/forms/meeting_agenda_item/work_package.rb b/modules/meeting/app/forms/meeting_agenda_item/work_package.rb
index 52be6a872117..7b2f169b7d68 100644
--- a/modules/meeting/app/forms/meeting_agenda_item/work_package.rb
+++ b/modules/meeting/app/forms/meeting_agenda_item/work_package.rb
@@ -35,10 +35,10 @@ class MeetingAgendaItem::WorkPackage < ApplicationForm
autocomplete_options: {
id: "op-agenda-items-wp-autocomplete",
data: {
- 'test-selector': 'op-agenda-items-wp-autocomplete'
+ "test-selector": "op-agenda-items-wp-autocomplete"
},
- resource: 'work_packages',
- searchKey: 'subjectOrId',
+ resource: "work_packages",
+ searchKey: "subjectOrId",
focusDirectly: true,
disabled: @disabled
}
diff --git a/modules/meeting/app/helpers/meeting_contents_helper.rb b/modules/meeting/app/helpers/meeting_contents_helper.rb
index e3ab854a4595..d88780e2b3ac 100644
--- a/modules/meeting/app/helpers/meeting_contents_helper.rb
+++ b/modules/meeting/app/helpers/meeting_contents_helper.rb
@@ -28,7 +28,7 @@
module MeetingContentsHelper
def can_edit_meeting_content?(content, content_type)
- authorize_for(content_type.pluralize, 'update') && content.editable?
+ authorize_for(content_type.pluralize, "update") && content.editable?
end
def saved_meeting_content_text_present?(content)
@@ -45,7 +45,7 @@ def meeting_content_context_menu(content, content_type)
menu << meeting_content_edit_link(content_type) if can_edit_meeting_content?(content, content_type)
menu << meeting_content_history_link(content_type, content.meeting)
- menu.join(' ')
+ menu.join(" ")
end
def meeting_agenda_toggle_status_link(content, content_type)
@@ -58,75 +58,75 @@ def meeting_agenda_toggle_status_link(content, content_type)
def close_meeting_agenda_link(content_type, meeting)
case content_type
- when 'meeting_agenda'
- content_tag :li, '', class: 'toolbar-item' do
- link_to_if_authorized({ controller: '/meeting_agendas',
- action: 'close',
+ when "meeting_agenda"
+ content_tag :li, "", class: "toolbar-item" do
+ link_to_if_authorized({ controller: "/meeting_agendas",
+ action: "close",
meeting_id: meeting },
method: :put,
data: { confirm: I18n.t(:text_meeting_closing_are_you_sure) },
- class: 'meetings--close-meeting-button button') do
- text_with_icon(I18n.t(:label_meeting_close), 'icon-locked')
+ class: "meetings--close-meeting-button button") do
+ text_with_icon(I18n.t(:label_meeting_close), "icon-locked")
end
end
- when 'meeting_minutes'
- content_tag :li, '', class: 'toolbar-item' do
- link_to_if_authorized({ controller: '/meeting_agendas',
- action: 'close',
+ when "meeting_minutes"
+ content_tag :li, "", class: "toolbar-item" do
+ link_to_if_authorized({ controller: "/meeting_agendas",
+ action: "close",
meeting_id: meeting },
method: :put,
- class: 'button') do
- text_with_icon(I18n.t(:label_meeting_agenda_close), 'icon-locked')
+ class: "button") do
+ text_with_icon(I18n.t(:label_meeting_agenda_close), "icon-locked")
end
end
end
end
def open_meeting_agenda_link(content_type, meeting)
- return unless content_type == 'meeting_agenda'
+ return unless content_type == "meeting_agenda"
- content_tag :li, '', class: 'toolbar-item' do
- link_to_if_authorized({ controller: '/meeting_agendas',
- action: 'open',
+ content_tag :li, "", class: "toolbar-item" do
+ link_to_if_authorized({ controller: "/meeting_agendas",
+ action: "open",
meeting_id: meeting },
method: :put,
- class: 'button',
+ class: "button",
data: { confirm: I18n.t(:text_meeting_agenda_open_are_you_sure) }) do
- text_with_icon(I18n.t(:label_meeting_open), 'icon-unlocked')
+ text_with_icon(I18n.t(:label_meeting_open), "icon-unlocked")
end
end
end
def meeting_content_edit_link(_content_type)
- content_tag :li, '', class: 'toolbar-item' do
- link_to '',
- class: 'button button--edit-agenda',
+ content_tag :li, "", class: "toolbar-item" do
+ link_to "",
+ class: "button button--edit-agenda",
data: {
- action: 'meeting-content#enableEditState',
- 'meeting-content-target': 'editButton'
+ action: "meeting-content#enableEditState",
+ "meeting-content-target": "editButton"
},
accesskey: accesskey(:edit) do
- text_with_icon(I18n.t(:label_edit), 'icon-edit')
+ text_with_icon(I18n.t(:label_edit), "icon-edit")
end
end
end
def meeting_content_history_link(content_type, meeting)
- content_tag :li, '', class: 'toolbar-item' do
- link_to_if_authorized({ controller: '/' + content_type.pluralize,
- action: 'history',
+ content_tag :li, "", class: "toolbar-item" do
+ link_to_if_authorized({ controller: "/" + content_type.pluralize,
+ action: "history",
meeting_id: meeting },
aria: { label: t(:label_history) },
title: t(:label_history),
- class: 'button') do
- text_with_icon(I18n.t(:label_history), 'icon-activity-history')
+ class: "button") do
+ text_with_icon(I18n.t(:label_history), "icon-activity-history")
end
end
end
def text_with_icon(text, icon)
op_icon("button--icon #{icon}") +
- ' ' +
- content_tag('span', text, class: 'button--text')
+ " " +
+ content_tag("span", text, class: "button--text")
end
end
diff --git a/modules/meeting/app/helpers/meetings_helper.rb b/modules/meeting/app/helpers/meetings_helper.rb
index a7f7fc1f73fe..0ba105163506 100644
--- a/modules/meeting/app/helpers/meetings_helper.rb
+++ b/modules/meeting/app/helpers/meetings_helper.rb
@@ -51,8 +51,8 @@ def menu_upcoming_meetings_item
def menu_past_meetings_item
path = project_or_global_meetings_path(
- filters: [{ time: { operator: '=', values: ['past'] } }],
- sort: 'start_time:desc'
+ filters: [{ time: { operator: "=", values: ["past"] } }],
+ sort: "start_time:desc"
)
menu_link_element path, t(:label_past_meetings)
@@ -61,10 +61,10 @@ def menu_past_meetings_item
def menu_upcoming_invitations_item
path = project_or_global_meetings_path(
filters: [
- { time: { operator: '=', values: ['future'] } },
- { invited_user_id: { operator: '=', values: [User.current.id.to_s] } }
+ { time: { operator: "=", values: ["future"] } },
+ { invited_user_id: { operator: "=", values: [User.current.id.to_s] } }
],
- sort: 'start_time'
+ sort: "start_time"
)
menu_link_element path, t(:label_upcoming_invitations)
@@ -73,10 +73,10 @@ def menu_upcoming_invitations_item
def menu_past_invitations_item
path = project_or_global_meetings_path(
filters: [
- { time: { operator: '=', values: ['past'] } },
- { invited_user_id: { operator: '=', values: [User.current.id.to_s] } }
+ { time: { operator: "=", values: ["past"] } },
+ { invited_user_id: { operator: "=", values: [User.current.id.to_s] } }
],
- sort: 'start_time:desc'
+ sort: "start_time:desc"
)
menu_link_element path, t(:label_past_invitations)
@@ -84,7 +84,7 @@ def menu_past_invitations_item
def menu_attendee_item
path = project_or_global_meetings_path(
- filters: [{ attended_user_id: { operator: '=', values: [User.current.id.to_s] } }]
+ filters: [{ attended_user_id: { operator: "=", values: [User.current.id.to_s] } }]
)
menu_link_element path, t(:label_attendee)
@@ -92,7 +92,7 @@ def menu_attendee_item
def menu_creator_item
path = project_or_global_meetings_path(
- filters: [{ author_id: { operator: '=', values: [User.current.id.to_s] } }]
+ filters: [{ author_id: { operator: "=", values: [User.current.id.to_s] } }]
)
menu_link_element path, t(:label_author)
@@ -111,7 +111,7 @@ def project_or_global_meetings_path(filters: nil, sort: nil)
def menu_link_element(path, label)
link_to path, class: menu_item_css_class(path), title: label do
- content_tag(:span, class: 'op-sidemenu--item-title') do
+ content_tag(:span, class: "op-sidemenu--item-title") do
label
end
end
@@ -132,17 +132,17 @@ def format_participant_list(participants)
.reject { |p| p.user.nil? }
.map { |p| link_to_user p.user }
- safe_join(user_links, '; ')
+ safe_join(user_links, "; ")
else
- t('placeholders.default')
+ t("placeholders.default")
end
end
def render_meeting_journal(model, journal, options = {})
- return '' if journal.initial?
+ return "" if journal.initial?
journal_content = render_journal_details(journal, :label_updated_time_by, model, options)
- content_tag 'div', journal_content, id: "change-#{journal.id}", class: 'journal'
+ content_tag "div", journal_content, id: "change-#{journal.id}", class: "journal"
end
# This renders a journal entry with a header and details
@@ -159,16 +159,16 @@ def render_journal_details(journal, header_label = :label_updated_time_by, _mode
HTML
if journal.details.any?
- details = content_tag 'ul', class: 'details journal-attributes' do
+ details = content_tag "ul", class: "details journal-attributes" do
journal.details.filter_map do |detail|
if d = journal.render_detail(detail, cache: options[:cache])
- content_tag('li', d.html_safe)
+ content_tag("li", d.html_safe)
end
- end.join(' ').html_safe
+ end.join(" ").html_safe
end
end
- content_tag('div', "#{header}#{details}".html_safe, id: "change-#{journal.id}", class: 'journal')
+ content_tag("div", "#{header}#{details}".html_safe, id: "change-#{journal.id}", class: "journal")
end
def global_meeting_create_context?
diff --git a/modules/meeting/app/mailers/meeting_mailer.rb b/modules/meeting/app/mailers/meeting_mailer.rb
index 7def8247802d..e001f0c405c6 100644
--- a/modules/meeting/app/mailers/meeting_mailer.rb
+++ b/modules/meeting/app/mailers/meeting_mailer.rb
@@ -32,8 +32,8 @@ def invited(meeting, user, actor)
@meeting = meeting
@user = user
- open_project_headers 'Project' => @meeting.project.identifier,
- 'Meeting-Id' => @meeting.id
+ open_project_headers "Project" => @meeting.project.identifier,
+ "Meeting-Id" => @meeting.id
with_attached_ics(meeting, user) do
subject = "[#{@meeting.project.name}] #{@meeting.title}"
@@ -47,12 +47,12 @@ def rescheduled(meeting, user, actor, changes:)
@meeting = meeting
@changes = changes
- open_project_headers 'Project' => @meeting.project.identifier,
- 'Meeting-Id' => @meeting.id
+ open_project_headers "Project" => @meeting.project.identifier,
+ "Meeting-Id" => @meeting.id
with_attached_ics(meeting, user) do
subject = "[#{@meeting.project.name}] "
- subject << I18n.t('meeting.email.rescheduled.header', title: @meeting.title)
+ subject << I18n.t("meeting.email.rescheduled.header", title: @meeting.title)
mail(to: user.mail, subject:)
end
end
@@ -79,7 +79,7 @@ def with_attached_ics(meeting, user)
.call
call.on_success do
- attachments['meeting.ics'] = call.result
+ attachments["meeting.ics"] = call.result
yield
end
@@ -91,9 +91,9 @@ def with_attached_ics(meeting, user)
end
def set_headers(meeting)
- open_project_headers 'Project' => meeting.project.identifier, 'Meeting-Id' => meeting.id
- headers['Content-Type'] = 'text/calendar; charset=utf-8; method="PUBLISH"; name="meeting.ics"'
- headers['Content-Transfer-Encoding'] = '8bit'
+ open_project_headers "Project" => meeting.project.identifier, "Meeting-Id" => meeting.id
+ headers["Content-Type"] = 'text/calendar; charset=utf-8; method="PUBLISH"; name="meeting.ics"'
+ headers["Content-Transfer-Encoding"] = "8bit"
end
def format_timezone_offset(timezone, time)
diff --git a/modules/meeting/app/models/journal/meeting_agenda_item_journal.rb b/modules/meeting/app/models/journal/meeting_agenda_item_journal.rb
index f2cef2b0cb22..e24fdc591a67 100644
--- a/modules/meeting/app/models/journal/meeting_agenda_item_journal.rb
+++ b/modules/meeting/app/models/journal/meeting_agenda_item_journal.rb
@@ -27,13 +27,13 @@
#++
class Journal::MeetingAgendaItemJournal < Journal::BaseJournal
- self.table_name = 'meeting_agenda_item_journals'
+ self.table_name = "meeting_agenda_item_journals"
enum item_type: MeetingAgendaItem::ITEM_TYPES
belongs_to :meeting
- belongs_to :author, class_name: 'User'
- belongs_to :agenda_item, class_name: 'MeetingAgendaItem'
+ belongs_to :author, class_name: "User"
+ belongs_to :agenda_item, class_name: "MeetingAgendaItem"
def editable?
false
diff --git a/modules/meeting/app/models/journal/meeting_content_journal.rb b/modules/meeting/app/models/journal/meeting_content_journal.rb
index 98ad96ef48b6..e761a7913bb0 100644
--- a/modules/meeting/app/models/journal/meeting_content_journal.rb
+++ b/modules/meeting/app/models/journal/meeting_content_journal.rb
@@ -27,10 +27,10 @@
#++
class Journal::MeetingContentJournal < Journal::BaseJournal
- self.table_name = 'meeting_content_journals'
+ self.table_name = "meeting_content_journals"
belongs_to :meeting
- belongs_to :author, class_name: 'User'
+ belongs_to :author, class_name: "User"
def editable?
false
diff --git a/modules/meeting/app/models/journal/meeting_journal.rb b/modules/meeting/app/models/journal/meeting_journal.rb
index d5ef503b304a..491208c50b95 100644
--- a/modules/meeting/app/models/journal/meeting_journal.rb
+++ b/modules/meeting/app/models/journal/meeting_journal.rb
@@ -27,7 +27,7 @@
#++
class Journal::MeetingJournal < Journal::BaseJournal
- self.table_name = 'meeting_journals'
+ self.table_name = "meeting_journals"
- belongs_to :author, class_name: 'User'
+ belongs_to :author, class_name: "User"
end
diff --git a/modules/meeting/app/models/meeting_agenda.rb b/modules/meeting/app/models/meeting_agenda.rb
index 5e97bec0d058..5508007cd13c 100644
--- a/modules/meeting/app/models/meeting_agenda.rb
+++ b/modules/meeting/app/models/meeting_agenda.rb
@@ -28,14 +28,14 @@
class MeetingAgenda < MeetingContent
def lock!(user = User.current)
- self.journal_notes = I18n.t('events.meeting_agenda_closed')
+ self.journal_notes = I18n.t("events.meeting_agenda_closed")
self.author = user
self.locked = true
save
end
def unlock!(user = User.current)
- self.journal_notes = I18n.t('events.meeting_agenda_opened')
+ self.journal_notes = I18n.t("events.meeting_agenda_opened")
self.author = user
self.locked = false
save
diff --git a/modules/meeting/app/models/meeting_agenda_item.rb b/modules/meeting/app/models/meeting_agenda_item.rb
index 1c0b4c519bdb..c643fd9dd6f2 100644
--- a/modules/meeting/app/models/meeting_agenda_item.rb
+++ b/modules/meeting/app/models/meeting_agenda_item.rb
@@ -35,10 +35,10 @@ class MeetingAgendaItem < ApplicationRecord
enum item_type: ITEM_TYPES
- belongs_to :meeting, class_name: 'StructuredMeeting'
- belongs_to :work_package, class_name: '::WorkPackage'
+ belongs_to :meeting, class_name: "StructuredMeeting"
+ belongs_to :work_package, class_name: "::WorkPackage"
has_one :project, through: :meeting
- belongs_to :author, class_name: 'User', optional: false
+ belongs_to :author, class_name: "User", optional: false
acts_as_list scope: :meeting
default_scope { order(:position) }
@@ -91,6 +91,6 @@ def modifiable?
end
def copy_attributes
- attributes.except('id', 'meeting_id')
+ attributes.except("id", "meeting_id")
end
end
diff --git a/modules/meeting/app/models/meeting_content.rb b/modules/meeting/app/models/meeting_content.rb
index 17438e44cc5d..e433df1ca4d2 100644
--- a/modules/meeting/app/models/meeting_content.rb
+++ b/modules/meeting/app/models/meeting_content.rb
@@ -33,7 +33,7 @@ class MeetingContent < ApplicationRecord
belongs_to :meeting
# Show the project on activity and search views
has_one :project, through: :meeting
- belongs_to :author, class_name: 'User'
+ belongs_to :author, class_name: "User"
acts_as_attachable(
after_remove: :attachments_changed,
@@ -48,7 +48,7 @@ class MeetingContent < ApplicationRecord
acts_as_journalized
acts_as_event type: Proc.new { |o| o.class.to_s.underscore.dasherize.to_s },
title: Proc.new { |o| "#{o.class.model_name.human}: #{o.meeting.title}" },
- url: Proc.new { |o| { controller: '/meetings', action: 'show', id: o.meeting } }
+ url: Proc.new { |o| { controller: "/meetings", action: "show", id: o.meeting } }
scope :visible, ->(*args) {
includes(meeting: :project)
diff --git a/modules/meeting/app/models/meeting_participant.rb b/modules/meeting/app/models/meeting_participant.rb
index d22436fb675e..f13cf5701d20 100644
--- a/modules/meeting/app/models/meeting_participant.rb
+++ b/modules/meeting/app/models/meeting_participant.rb
@@ -34,11 +34,11 @@ class MeetingParticipant < ApplicationRecord
scope :attended, -> { where(attended: true) }
def name
- user.present? ? user.name : I18n.t('user.deleted')
+ user.present? ? user.name : I18n.t("user.deleted")
end
def mail
- user.present? ? user.mail : I18n.t('user.deleted')
+ user.present? ? user.mail : I18n.t("user.deleted")
end
def <=>(other)
@@ -49,6 +49,6 @@ def <=>(other)
def copy_attributes
# create a clean attribute set allowing to attach participants to different meetings
- attributes.reject { |k, _v| ['id', 'meeting_id', 'attended', 'created_at', 'updated_at'].include?(k) }
+ attributes.reject { |k, _v| ["id", "meeting_id", "attended", "created_at", "updated_at"].include?(k) }
end
end
diff --git a/modules/meeting/app/models/queries/meetings/filters/time_filter.rb b/modules/meeting/app/models/queries/meetings/filters/time_filter.rb
index 6031a0a43dbb..0f2691d911f1 100644
--- a/modules/meeting/app/models/queries/meetings/filters/time_filter.rb
+++ b/modules/meeting/app/models/queries/meetings/filters/time_filter.rb
@@ -27,8 +27,8 @@
#++
class Queries::Meetings::Filters::TimeFilter < Queries::Meetings::Filters::MeetingFilter
- PAST_VALUE = 'past'.freeze
- FUTURE_VALUE = 'future'.freeze
+ PAST_VALUE = "past".freeze
+ FUTURE_VALUE = "future".freeze
validate :validate_only_single_value
diff --git a/modules/meeting/app/models/structured_meeting.rb b/modules/meeting/app/models/structured_meeting.rb
index 1d7dc58c49d7..c4d42d469791 100644
--- a/modules/meeting/app/models/structured_meeting.rb
+++ b/modules/meeting/app/models/structured_meeting.rb
@@ -29,8 +29,8 @@
class StructuredMeeting < Meeting
has_many :agenda_items,
dependent: :destroy,
- foreign_key: 'meeting_id',
- class_name: 'MeetingAgendaItem',
+ foreign_key: "meeting_id",
+ class_name: "MeetingAgendaItem",
inverse_of: :meeting
accepts_nested_attributes_for :agenda_items
diff --git a/modules/meeting/app/seeders/meetings/demo_data/meeting_agenda_items_seeder.rb b/modules/meeting/app/seeders/meetings/demo_data/meeting_agenda_items_seeder.rb
index 83fff13ce60f..36227d6c825b 100644
--- a/modules/meeting/app/seeders/meetings/demo_data/meeting_agenda_items_seeder.rb
+++ b/modules/meeting/app/seeders/meetings/demo_data/meeting_agenda_items_seeder.rb
@@ -30,7 +30,7 @@ module Meetings
module DemoData
class MeetingAgendaItemsSeeder < ::BasicData::ModelSeeder
self.model_class = MeetingAgendaItem
- self.seed_data_model_key = 'meeting_agenda_items'
+ self.seed_data_model_key = "meeting_agenda_items"
##
#
@@ -40,12 +40,12 @@ def initialize(_project, seed_data)
def model_attributes(meeting_data)
{
- title: meeting_data['title'],
- notes: meeting_data['notes'],
- duration_in_minutes: meeting_data['duration'],
- author: seed_data.find_reference(meeting_data['author']),
- meeting: seed_data.find_reference(meeting_data['meeting']),
- work_package: seed_data.find_reference(meeting_data['work_package'])
+ title: meeting_data["title"],
+ notes: meeting_data["notes"],
+ duration_in_minutes: meeting_data["duration"],
+ author: seed_data.find_reference(meeting_data["author"]),
+ meeting: seed_data.find_reference(meeting_data["meeting"]),
+ work_package: seed_data.find_reference(meeting_data["work_package"])
}
end
end
diff --git a/modules/meeting/app/seeders/meetings/demo_data/meeting_seeder.rb b/modules/meeting/app/seeders/meetings/demo_data/meeting_seeder.rb
index 233c98d7890f..bffdf8392e43 100644
--- a/modules/meeting/app/seeders/meetings/demo_data/meeting_seeder.rb
+++ b/modules/meeting/app/seeders/meetings/demo_data/meeting_seeder.rb
@@ -30,7 +30,7 @@ module Meetings
module DemoData
class MeetingSeeder < ::BasicData::ModelSeeder
self.model_class = StructuredMeeting
- self.seed_data_model_key = 'meetings'
+ self.seed_data_model_key = "meetings"
attr_reader :project
@@ -41,9 +41,9 @@ def initialize(project, seed_data)
def model_attributes(meeting_data)
{
- title: meeting_data['title'],
- author: seed_data.find_reference(meeting_data['author']),
- duration: minutes_to_hours(meeting_data['duration']),
+ title: meeting_data["title"],
+ author: seed_data.find_reference(meeting_data["author"]),
+ duration: minutes_to_hours(meeting_data["duration"]),
project:
}
end
diff --git a/modules/meeting/app/services/meetings/copy_service.rb b/modules/meeting/app/services/meetings/copy_service.rb
index e0c5a5f50577..686421add8c4 100644
--- a/modules/meeting/app/services/meetings/copy_service.rb
+++ b/modules/meeting/app/services/meetings/copy_service.rb
@@ -74,9 +74,9 @@ def copied_attributes(meeting, override)
meeting
.attributes
.slice(*writable_meeting_attributes(meeting))
- .merge('start_time' => meeting.start_time + 1.week)
- .merge('author' => user)
- .merge('participants_attributes' => meeting.allowed_participants.collect(&:copy_attributes))
+ .merge("start_time" => meeting.start_time + 1.week)
+ .merge("author" => user)
+ .merge("participants_attributes" => meeting.allowed_participants.collect(&:copy_attributes))
.merge(overwritten_attributes)
end
@@ -86,7 +86,7 @@ def writable_meeting_attributes(meeting)
def copy_meeting_attachment(copy)
copy_attachments(
- 'Meeting',
+ "Meeting",
from: meeting,
to: copy
)
@@ -110,7 +110,7 @@ def copy_meeting_agenda(copy)
meeting: copy,
author: user,
text: meeting.agenda&.text,
- journal_notes: I18n.t('meeting.copied', id: meeting.id)
+ journal_notes: I18n.t("meeting.copied", id: meeting.id)
)
end
end
diff --git a/modules/meeting/app/services/meetings/create_service.rb b/modules/meeting/app/services/meetings/create_service.rb
index 78c634947837..cc5e874eed9a 100644
--- a/modules/meeting/app/services/meetings/create_service.rb
+++ b/modules/meeting/app/services/meetings/create_service.rb
@@ -35,7 +35,7 @@ def instance(params)
# Setting the #type as attributes will not work
# as the STI instance is not changed without using e.g., +becomes!+
case params.delete(:type)
- when 'StructuredMeeting'
+ when "StructuredMeeting"
StructuredMeeting.new
else
Meeting.new
diff --git a/modules/meeting/app/services/meetings/ical_service.rb b/modules/meeting/app/services/meetings/ical_service.rb
index 5eec3f22a35b..9ef87dc81b77 100644
--- a/modules/meeting/app/services/meetings/ical_service.rb
+++ b/modules/meeting/app/services/meetings/ical_service.rb
@@ -25,8 +25,8 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'icalendar'
-require 'icalendar/tzinfo'
+require "icalendar"
+require "icalendar/tzinfo"
module Meetings
class ICalService
@@ -104,7 +104,7 @@ def ical_subject
end
def ical_datetime(time, timezone_id)
- Icalendar::Values::DateTime.new time.in_time_zone(timezone_id), 'tzid' => timezone_id
+ Icalendar::Values::DateTime.new time.in_time_zone(timezone_id), "tzid" => timezone_id
end
def ical_organizer
diff --git a/modules/meeting/db/migrate/20180323135408_to_v710_aggregated_meeting_migrations.rb b/modules/meeting/db/migrate/20180323135408_to_v710_aggregated_meeting_migrations.rb
index 9aa249ad92cf..b5057153214a 100644
--- a/modules/meeting/db/migrate/20180323135408_to_v710_aggregated_meeting_migrations.rb
+++ b/modules/meeting/db/migrate/20180323135408_to_v710_aggregated_meeting_migrations.rb
@@ -42,37 +42,37 @@ class ToV710AggregatedMeetingMigrations < ActiveRecord::Migration[5.1]
def up
Migration::MigrationSquasher.squash(migrations) do
- create_table 'meeting_contents', id: :integer do |t|
- t.string 'type'
- t.integer 'meeting_id'
- t.integer 'author_id'
- t.text 'text'
- t.integer 'lock_version'
- t.datetime 'created_at', null: false
- t.datetime 'updated_at', null: false
- t.boolean 'locked', default: false
+ create_table "meeting_contents", id: :integer do |t|
+ t.string "type"
+ t.integer "meeting_id"
+ t.integer "author_id"
+ t.text "text"
+ t.integer "lock_version"
+ t.datetime "created_at", null: false
+ t.datetime "updated_at", null: false
+ t.boolean "locked", default: false
end
- create_table 'meeting_participants', id: :integer do |t|
- t.integer 'user_id'
- t.integer 'meeting_id'
- t.string 'email'
- t.string 'name'
- t.boolean 'invited'
- t.boolean 'attended'
- t.datetime 'created_at', null: false
- t.datetime 'updated_at', null: false
+ create_table "meeting_participants", id: :integer do |t|
+ t.integer "user_id"
+ t.integer "meeting_id"
+ t.string "email"
+ t.string "name"
+ t.boolean "invited"
+ t.boolean "attended"
+ t.datetime "created_at", null: false
+ t.datetime "updated_at", null: false
end
- create_table 'meetings', id: :integer do |t|
- t.string 'title'
- t.integer 'author_id'
- t.integer 'project_id'
- t.string 'location'
- t.datetime 'start_time'
- t.float 'duration'
- t.datetime 'created_at', null: false
- t.datetime 'updated_at', null: false
+ create_table "meetings", id: :integer do |t|
+ t.string "title"
+ t.integer "author_id"
+ t.integer "project_id"
+ t.string "location"
+ t.datetime "start_time"
+ t.float "duration"
+ t.datetime "created_at", null: false
+ t.datetime "updated_at", null: false
t.index %i[project_id updated_at]
end
@@ -98,9 +98,9 @@ def up
end
def down
- drop_table 'meeting_contents'
- drop_table 'meeting_participants'
- drop_table 'meetings'
+ drop_table "meeting_contents"
+ drop_table "meeting_participants"
+ drop_table "meetings"
drop_table :meeting_journals
drop_table :meeting_content_journals
end
@@ -109,7 +109,7 @@ def down
def migrations
MIGRATION_FILES.split.map do |m|
- m.gsub(/_.*\z/, '')
+ m.gsub(/_.*\z/, "")
end
end
end
diff --git a/modules/meeting/db/migrate/20230911102918_add_type_to_meeting.rb b/modules/meeting/db/migrate/20230911102918_add_type_to_meeting.rb
index b09b4a1d7764..9dec164b3b34 100644
--- a/modules/meeting/db/migrate/20230911102918_add_type_to_meeting.rb
+++ b/modules/meeting/db/migrate/20230911102918_add_type_to_meeting.rb
@@ -1,5 +1,5 @@
class AddTypeToMeeting < ActiveRecord::Migration[7.0]
def change
- add_column :meetings, :type, :string, default: 'Meeting', null: false
+ add_column :meetings, :type, :string, default: "Meeting", null: false
end
end
diff --git a/modules/meeting/lib/api/v3/meeting_contents/meeting_content_representer.rb b/modules/meeting/lib/api/v3/meeting_contents/meeting_content_representer.rb
index ce4592cbe2e1..8ca90f379ab2 100644
--- a/modules/meeting/lib/api/v3/meeting_contents/meeting_content_representer.rb
+++ b/modules/meeting/lib/api/v3/meeting_contents/meeting_content_representer.rb
@@ -49,7 +49,7 @@ class MeetingContentRepresenter < ::API::Decorators::Single
end
def _type
- 'MeetingContent'
+ "MeetingContent"
end
end
end
diff --git a/modules/meeting/lib/api/v3/meetings/meeting_representer.rb b/modules/meeting/lib/api/v3/meetings/meeting_representer.rb
index af49d7dc4f68..8a536d8eaa5b 100644
--- a/modules/meeting/lib/api/v3/meetings/meeting_representer.rb
+++ b/modules/meeting/lib/api/v3/meetings/meeting_representer.rb
@@ -75,7 +75,7 @@ class MeetingRepresenter < ::API::Decorators::Single
date_time_property :updated_at
def _type
- 'Meeting'
+ "Meeting"
end
end
end
diff --git a/modules/meeting/lib/api/v3/meetings/meetings_api.rb b/modules/meeting/lib/api/v3/meetings/meetings_api.rb
index 7f9cd0005188..6a8e4a791a5a 100644
--- a/modules/meeting/lib/api/v3/meetings/meetings_api.rb
+++ b/modules/meeting/lib/api/v3/meetings/meetings_api.rb
@@ -37,7 +37,7 @@ def meeting
end
end
- route_param :id, type: Integer, desc: 'Activity ID' do
+ route_param :id, type: Integer, desc: "Activity ID" do
after_validation do
@meeting = Meeting.visible.find(declared_params[:id])
end
diff --git a/modules/meeting/lib/open_project/meeting.rb b/modules/meeting/lib/open_project/meeting.rb
index 87b48d92c60f..300a95884998 100644
--- a/modules/meeting/lib/open_project/meeting.rb
+++ b/modules/meeting/lib/open_project/meeting.rb
@@ -28,6 +28,6 @@
module OpenProject
module Meeting
- require 'open_project/meeting/engine'
+ require "open_project/meeting/engine"
end
end
diff --git a/modules/meeting/lib/open_project/meeting/patches/setting_seeder_patch.rb b/modules/meeting/lib/open_project/meeting/patches/setting_seeder_patch.rb
index 5c4c641eee2a..4e49dc806c9b 100644
--- a/modules/meeting/lib/open_project/meeting/patches/setting_seeder_patch.rb
+++ b/modules/meeting/lib/open_project/meeting/patches/setting_seeder_patch.rb
@@ -35,8 +35,8 @@ module InstanceMethods
def data
original_data = super
- unless original_data['default_projects_modules'].include? 'meetings'
- original_data['default_projects_modules'] << 'meetings'
+ unless original_data["default_projects_modules"].include? "meetings"
+ original_data["default_projects_modules"] << "meetings"
end
original_data
diff --git a/modules/meeting/lib/openproject-meeting.rb b/modules/meeting/lib/openproject-meeting.rb
index bedae3a08cd4..27257af1d0bd 100644
--- a/modules/meeting/lib/openproject-meeting.rb
+++ b/modules/meeting/lib/openproject-meeting.rb
@@ -26,4 +26,4 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'open_project/meeting'
+require "open_project/meeting"
diff --git a/modules/meeting/openproject-meeting.gemspec b/modules/meeting/openproject-meeting.gemspec
index 1c53c3b40ac4..e66b89f0c686 100644
--- a/modules/meeting/openproject-meeting.gemspec
+++ b/modules/meeting/openproject-meeting.gemspec
@@ -1,19 +1,19 @@
# Describe your gem and declare its dependencies:
Gem::Specification.new do |s|
- s.name = 'openproject-meeting'
- s.version = '1.0.0'
- s.authors = 'OpenProject GmbH'
- s.email = 'info@openproject.com'
- s.summary = 'OpenProject Meeting'
+ s.name = "openproject-meeting"
+ s.version = "1.0.0"
+ s.authors = "OpenProject GmbH"
+ s.email = "info@openproject.com"
+ s.summary = "OpenProject Meeting"
s.description = "This module adds functions to support project meetings to OpenProject. Meetings
can be scheduled selecting invitees from the same project to take part in the meeting. An agenda
can be created and sent to the invitees. After the meeting, attendees can be selected and
minutes can be created based on the agenda. Finally, the minutes can be sent to all attendees
and invitees."
- s.license = 'GPLv3'
+ s.license = "GPLv3"
- s.files = Dir['{app,config,db,lib,doc}/**/*', 'README.md']
+ s.files = Dir["{app,config,db,lib,doc}/**/*", "README.md"]
- s.add_dependency 'icalendar', '~> 2.10.0'
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.add_dependency "icalendar", "~> 2.10.0"
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/meeting/spec/contracts/meeting_agenda_items/create_contract_spec.rb b/modules/meeting/spec/contracts/meeting_agenda_items/create_contract_spec.rb
index c21a76337139..95bad151e84a 100644
--- a/modules/meeting/spec/contracts/meeting_agenda_items/create_contract_spec.rb
+++ b/modules/meeting/spec/contracts/meeting_agenda_items/create_contract_spec.rb
@@ -28,56 +28,56 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe MeetingAgendaItems::CreateContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
shared_let(:project) { create(:project) }
let(:meeting) { create(:structured_meeting, project:) }
let(:item) { build(:meeting_agenda_item, meeting:) }
let(:contract) { described_class.new(item, user) }
- context 'with permission' do
+ context "with permission" do
let(:user) do
create(:user, member_with_permissions: { project => %i[view_meetings manage_agendas] })
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
- context 'when :meeting is not editable' do
+ context "when :meeting is not editable" do
before do
meeting.update_column(:state, :closed)
end
- it_behaves_like 'contract is invalid', base: I18n.t(:text_agenda_item_not_editable_anymore)
+ it_behaves_like "contract is invalid", base: I18n.t(:text_agenda_item_not_editable_anymore)
end
- context 'when :meeting is not present anymore' do
+ context "when :meeting is not present anymore" do
before do
meeting.destroy
end
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
- context 'when an item_type is provided' do
+ context "when an item_type is provided" do
before do
- allow(item).to receive(:changed).and_return(['item_type'])
+ allow(item).to receive(:changed).and_return(["item_type"])
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
end
- context 'without permission' do
+ context "without permission" do
let(:user) { build_stubbed(:user) }
- it_behaves_like 'contract is invalid', base: :does_not_exist
+ it_behaves_like "contract is invalid", base: :does_not_exist
end
- include_examples 'contract reuses the model errors' do
+ include_examples "contract reuses the model errors" do
let(:user) { build_stubbed(:user) }
end
end
diff --git a/modules/meeting/spec/contracts/meeting_agenda_items/delete_contract_spec.rb b/modules/meeting/spec/contracts/meeting_agenda_items/delete_contract_spec.rb
index 3af14d395c9a..2f236c169970 100644
--- a/modules/meeting/spec/contracts/meeting_agenda_items/delete_contract_spec.rb
+++ b/modules/meeting/spec/contracts/meeting_agenda_items/delete_contract_spec.rb
@@ -28,40 +28,40 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe MeetingAgendaItems::DeleteContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
shared_let(:project) { create(:project) }
shared_let(:meeting) { create(:structured_meeting, project:) }
shared_let(:item) { create(:meeting_agenda_item, meeting:) }
let(:contract) { described_class.new(item, user) }
- context 'with permission' do
+ context "with permission" do
let(:user) do
create(:user, member_with_permissions: { project => [:manage_agendas] })
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
- context 'when :meeting is not editable' do
+ context "when :meeting is not editable" do
before do
meeting.update_column(:state, :closed)
end
- it_behaves_like 'contract is invalid', base: I18n.t(:text_agenda_item_not_editable_anymore)
+ it_behaves_like "contract is invalid", base: I18n.t(:text_agenda_item_not_editable_anymore)
end
end
- context 'without permission' do
+ context "without permission" do
let(:user) { build_stubbed(:user) }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
- include_examples 'contract reuses the model errors' do
+ include_examples "contract reuses the model errors" do
let(:user) { build_stubbed(:user) }
end
end
diff --git a/modules/meeting/spec/contracts/meeting_agenda_items/update_contract_spec.rb b/modules/meeting/spec/contracts/meeting_agenda_items/update_contract_spec.rb
index dd84d5460d56..10fbdfb51ad7 100644
--- a/modules/meeting/spec/contracts/meeting_agenda_items/update_contract_spec.rb
+++ b/modules/meeting/spec/contracts/meeting_agenda_items/update_contract_spec.rb
@@ -28,48 +28,48 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe MeetingAgendaItems::UpdateContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
shared_let(:project) { create(:project) }
shared_let(:meeting) { create(:structured_meeting, project:) }
shared_let(:item) { create(:meeting_agenda_item, meeting:) }
let(:contract) { described_class.new(item, user) }
- context 'with permission' do
+ context "with permission" do
let(:user) do
create(:user, member_with_permissions: { project => [:manage_agendas] })
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
- context 'when :meeting is not editable' do
+ context "when :meeting is not editable" do
before do
meeting.update_column(:state, :closed)
end
- it_behaves_like 'contract is invalid', base: I18n.t(:text_agenda_item_not_editable_anymore)
+ it_behaves_like "contract is invalid", base: I18n.t(:text_agenda_item_not_editable_anymore)
end
- context 'when an item_type is provided' do
+ context "when an item_type is provided" do
before do
- allow(item).to receive(:changed).and_return(['item_type'])
+ allow(item).to receive(:changed).and_return(["item_type"])
end
- it_behaves_like 'contract is invalid', item_type: :error_readonly
+ it_behaves_like "contract is invalid", item_type: :error_readonly
end
end
- context 'without permission' do
+ context "without permission" do
let(:user) { build_stubbed(:user) }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
- include_examples 'contract reuses the model errors' do
+ include_examples "contract reuses the model errors" do
let(:user) { build_stubbed(:user) }
end
end
diff --git a/modules/meeting/spec/contracts/meeting_contents/update_contract_spec.rb b/modules/meeting/spec/contracts/meeting_contents/update_contract_spec.rb
index 28eebc8172f9..c15f80179765 100644
--- a/modules/meeting/spec/contracts/meeting_contents/update_contract_spec.rb
+++ b/modules/meeting/spec/contracts/meeting_contents/update_contract_spec.rb
@@ -26,30 +26,30 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe MeetingContents::UpdateContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:agenda) { build_stubbed(:meeting_agenda) }
let(:current_user) { build_stubbed(:user) }
let(:contract) { described_class.new(agenda, current_user) }
- context 'when not editable' do
+ context "when not editable" do
before do
allow(agenda).to receive(:editable?).and_return false
end
- it_behaves_like 'contract is invalid', base: :error_readonly
+ it_behaves_like "contract is invalid", base: :error_readonly
end
- context 'when editable' do
+ context "when editable" do
before do
allow(agenda).to receive(:editable?).and_return true
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
diff --git a/modules/meeting/spec/contracts/meetings/create_contract_spec.rb b/modules/meeting/spec/contracts/meetings/create_contract_spec.rb
index 824be59068a2..4191e25dbc37 100644
--- a/modules/meeting/spec/contracts/meetings/create_contract_spec.rb
+++ b/modules/meeting/spec/contracts/meetings/create_contract_spec.rb
@@ -28,31 +28,31 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe Meetings::CreateContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
shared_let(:project) { create(:project) }
let(:meeting) { build(:structured_meeting, project:) }
let(:contract) { described_class.new(meeting, user) }
- context 'with permission' do
+ context "with permission" do
let(:user) do
create(:user, member_with_permissions: { project => %i[view_meetings create_meetings] })
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'without permission' do
+ context "without permission" do
let(:user) { build_stubbed(:user) }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
- include_examples 'contract reuses the model errors' do
+ include_examples "contract reuses the model errors" do
let(:user) { build_stubbed(:user) }
end
end
diff --git a/modules/meeting/spec/contracts/meetings/update_contract_spec.rb b/modules/meeting/spec/contracts/meetings/update_contract_spec.rb
index 1904a52d6fef..c752017e9f32 100644
--- a/modules/meeting/spec/contracts/meetings/update_contract_spec.rb
+++ b/modules/meeting/spec/contracts/meetings/update_contract_spec.rb
@@ -28,39 +28,39 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe Meetings::UpdateContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
shared_let(:project) { create(:project) }
shared_let(:meeting) { create(:structured_meeting, project:) }
let(:contract) { described_class.new(meeting, user) }
- context 'with permission' do
+ context "with permission" do
let(:user) do
create(:user, member_with_permissions: { project => [:edit_meetings] })
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
- context 'when lock_version is changed' do
+ context "when lock_version is changed" do
before do
allow(meeting).to receive(:lock_version_changed?).and_return(true)
end
- it_behaves_like 'contract is invalid', base: :error_conflict
+ it_behaves_like "contract is invalid", base: :error_conflict
end
end
- context 'without permission' do
+ context "without permission" do
let(:user) { build_stubbed(:user) }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
- include_examples 'contract reuses the model errors' do
+ include_examples "contract reuses the model errors" do
let(:user) { build_stubbed(:user) }
end
end
diff --git a/modules/meeting/spec/controllers/meetings_controller_spec.rb b/modules/meeting/spec/controllers/meetings_controller_spec.rb
index 4771ef8cb503..7976f548f2fb 100644
--- a/modules/meeting/spec/controllers/meetings_controller_spec.rb
+++ b/modules/meeting/spec/controllers/meetings_controller_spec.rb
@@ -43,8 +43,8 @@
allow(controller).to receive(:check_if_login_required)
end
- describe 'GET' do
- describe 'index' do
+ describe "GET" do
+ describe "index" do
let(:meetings) do
[
create(:meeting, project:),
@@ -53,19 +53,19 @@
]
end
- describe 'html' do
- context 'when requesting meetings globally' do
+ describe "html" do
+ context "when requesting meetings globally" do
before do
- get 'index'
+ get "index"
end
it { expect(response).to be_successful }
it { expect(assigns(:meetings)).to match_array meetings }
end
- context 'when requesting meetings scoped to a project ID' do
+ context "when requesting meetings scoped to a project ID" do
before do
- get 'index', params: { project_id: project.id }
+ get "index", params: { project_id: project.id }
end
it { expect(response).to be_successful }
@@ -74,12 +74,12 @@
end
end
- describe 'show' do
+ describe "show" do
let(:meeting) { create(:meeting, project:, agenda: nil) }
- describe 'html' do
+ describe "html" do
before do
- get 'show', params: { id: meeting.id }
+ get "show", params: { id: meeting.id }
end
it { expect(response).to be_successful }
@@ -87,7 +87,7 @@
end
end
- describe 'new' do
+ describe "new" do
let(:meeting) { Meeting.new(project:) }
before do
@@ -95,11 +95,11 @@
allow(Meeting).to receive(:new).and_return(meeting)
end
- shared_examples_for 'new action' do |response_type:|
+ shared_examples_for "new action" do |response_type:|
describe response_type do
- context 'when requesting the page without a project id' do
+ context "when requesting the page without a project id" do
before do
- get 'new'
+ get "new"
end
it { expect(response).to be_successful }
@@ -107,9 +107,9 @@
it { expect(assigns(:project)).to be_nil }
end
- context 'when requesting the page with a project id' do
+ context "when requesting the page with a project id" do
before do
- get 'new', params: { project_id: project.id }
+ get "new", params: { project_id: project.id }
end
it { expect(response).to be_successful }
@@ -119,16 +119,16 @@
end
end
- it_behaves_like 'new action', response_type: 'html'
- it_behaves_like 'new action', response_type: 'turbo_stream'
+ it_behaves_like "new action", response_type: "html"
+ it_behaves_like "new action", response_type: "turbo_stream"
end
- describe 'edit' do
+ describe "edit" do
let(:meeting) { create(:meeting, project:) }
- describe 'html' do
+ describe "html" do
before do
- get 'edit', params: { id: meeting.id }
+ get "edit", params: { id: meeting.id }
end
it { expect(response).to be_successful }
@@ -137,8 +137,8 @@
end
end
- describe 'POST' do
- describe 'create' do
+ describe "POST" do
+ describe "create" do
render_views
let(:base_params) do
@@ -150,10 +150,10 @@
let(:base_meeting_params) do
{
- title: 'Foobar',
- duration: '1.0',
- start_date: '2015-06-01',
- start_time_hour: '10:00'
+ title: "Foobar",
+ duration: "1.0",
+ start_date: "2015-06-01",
+ start_time_hour: "10:00"
}
end
@@ -167,80 +167,80 @@
params:
end
- context 'with a project_id' do
- context 'and an invalid start_date with start_time_hour' do
+ context "with a project_id" do
+ context "and an invalid start_date with start_time_hour" do
let(:meeting_params) do
- base_meeting_params.merge(start_date: '-')
+ base_meeting_params.merge(start_date: "-")
end
- it 'renders an error' do
+ it "renders an error" do
expect(response).to have_http_status :ok
expect(response).to render_template :new
expect(response.body)
- .to have_css '#errorExplanation li',
+ .to have_css "#errorExplanation li",
text: "Date #{I18n.t('activerecord.errors.messages.not_an_iso_date')}"
end
end
- context 'and an invalid start_time_hour with start_date' do
+ context "and an invalid start_time_hour with start_date" do
let(:meeting_params) do
- base_meeting_params.merge(start_time_hour: '-')
+ base_meeting_params.merge(start_time_hour: "-")
end
- it 'renders an error' do
+ it "renders an error" do
expect(response).to have_http_status :ok
expect(response).to render_template :new
expect(response.body)
- .to have_css '#errorExplanation li',
+ .to have_css "#errorExplanation li",
text: "Starting time #{I18n.t('activerecord.errors.messages.invalid_time_format')}"
end
end
end
- context 'with a nil project_id' do
+ context "with a nil project_id" do
let(:project) { nil }
- it 'renders an error' do
+ it "renders an error" do
expect(response).to have_http_status :ok
expect(response).to render_template :new
expect(response.body)
- .to have_css '#errorExplanation li',
+ .to have_css "#errorExplanation li",
text: "Project #{I18n.t('activerecord.errors.messages.blank')}"
end
end
- context 'without a project_id' do
+ context "without a project_id" do
let(:params) { base_params.except(:project_id) }
let(:project) { nil }
- it 'renders an error' do
+ it "renders an error" do
expect(response).to have_http_status :ok
expect(response).to render_template :new
expect(response.body)
- .to have_css '#errorExplanation li',
+ .to have_css "#errorExplanation li",
text: "Project #{I18n.t('activerecord.errors.messages.blank')}"
end
end
end
end
- describe 'notify' do
+ describe "notify" do
let!(:meeting) { create(:meeting) }
let!(:participant) { create(:meeting_participant, meeting:, attended: true) }
- it 'produces a background job for notification' do
+ it "produces a background job for notification" do
post :notify, params: { id: meeting.id }
perform_enqueued_jobs
expect(ActionMailer::Base.deliveries.count).to eq(1)
end
- context 'with an error during deliver' do
+ context "with an error during deliver" do
before do
allow(MeetingMailer).to receive(:invited).and_raise(Net::SMTPError)
end
- it 'produces a flash message containing the mail addresses raising the error' do
+ it "produces a flash message containing the mail addresses raising the error" do
expect { post :notify, params: { id: meeting.id } }.not_to raise_error
meeting.participants.each do |participant|
expect(flash[:error]).to include(participant.name)
diff --git a/modules/meeting/spec/factories/meeting_agenda_item_factory.rb b/modules/meeting/spec/factories/meeting_agenda_item_factory.rb
index 5a4bfe7939f1..4cebfcd5eac0 100644
--- a/modules/meeting/spec/factories/meeting_agenda_item_factory.rb
+++ b/modules/meeting/spec/factories/meeting_agenda_item_factory.rb
@@ -34,7 +34,7 @@
duration_in_minutes { 10 }
item_type { :simple }
m.sequence(:title) { |n| "Agenda item #{n}" }
- notes { 'Agenda Item Notes' }
+ notes { "Agenda Item Notes" }
factory(:wp_meeting_agenda_item) do
item_type { :work_package }
diff --git a/modules/meeting/spec/factories/meeting_content_journal_factory.rb b/modules/meeting/spec/factories/meeting_content_journal_factory.rb
index b5cd62f9b8dd..245798e6014d 100644
--- a/modules/meeting/spec/factories/meeting_content_journal_factory.rb
+++ b/modules/meeting/spec/factories/meeting_content_journal_factory.rb
@@ -27,6 +27,6 @@
#++
FactoryBot.define do
- factory :journal_meeting_content_journal, class: 'Journal::MeetingContentJournal' do
+ factory :journal_meeting_content_journal, class: "Journal::MeetingContentJournal" do
end
end
diff --git a/modules/meeting/spec/factories/meeting_factory.rb b/modules/meeting/spec/factories/meeting_factory.rb
index e23442368d48..e7c31bbdb528 100644
--- a/modules/meeting/spec/factories/meeting_factory.rb
+++ b/modules/meeting/spec/factories/meeting_factory.rb
@@ -27,19 +27,19 @@
#++
FactoryBot.define do
- factory :meeting, class: 'Meeting' do |m|
+ factory :meeting, class: "Meeting" do |m|
author factory: :user
project
start_time { Date.tomorrow + 10.hours }
duration { 1.0 }
- location { 'https://some-url.com' }
+ location { "https://some-url.com" }
m.sequence(:title) { |n| "Meeting #{n}" }
after(:create) do |meeting, evaluator|
meeting.project = evaluator.project if evaluator.project
end
- factory :structured_meeting, class: 'StructuredMeeting' do |m|
+ factory :structured_meeting, class: "StructuredMeeting" do |m|
m.sequence(:title) { |n| "Structured meeting #{n}" }
end
end
diff --git a/modules/meeting/spec/factories/meeting_journal_factory.rb b/modules/meeting/spec/factories/meeting_journal_factory.rb
index baa02ebfa3f9..b26df1ead8de 100644
--- a/modules/meeting/spec/factories/meeting_journal_factory.rb
+++ b/modules/meeting/spec/factories/meeting_journal_factory.rb
@@ -31,8 +31,8 @@
created_at { Time.now }
sequence(:version)
- factory :meeting_content_journal, class: 'Journal' do
- journable_type { 'MeetingContent' }
+ factory :meeting_content_journal, class: "Journal" do
+ journable_type { "MeetingContent" }
end
end
end
diff --git a/modules/meeting/spec/features/meetings_activity_spec.rb b/modules/meeting/spec/features/meetings_activity_spec.rb
index 7c623f909057..414092441924 100644
--- a/modules/meeting/spec/features/meetings_activity_spec.rb
+++ b/modules/meeting/spec/features/meetings_activity_spec.rb
@@ -26,30 +26,30 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Meetings', :js do
+RSpec.describe "Meetings", :js do
let(:project) { create(:project, enabled_module_names: %w[meetings activity]) }
let(:user) { create(:admin) }
- let!(:meeting) { create(:meeting, project:, title: 'Awesome meeting!') }
- let!(:agenda) { create(:meeting_agenda, meeting:, text: 'foo') }
- let!(:minutes) { create(:meeting_minutes, meeting:, text: 'minutes') }
+ let!(:meeting) { create(:meeting, project:, title: "Awesome meeting!") }
+ let!(:agenda) { create(:meeting_agenda, meeting:, text: "foo") }
+ let!(:minutes) { create(:meeting_minutes, meeting:, text: "minutes") }
before do
login_as(user)
end
- describe 'project activity' do
- it 'can show the meeting in the project activity' do
+ describe "project activity" do
+ it "can show the meeting in the project activity" do
visit project_activity_index_path(project)
- check 'Meetings'
- click_on 'Apply'
+ check "Meetings"
+ click_on "Apply"
- expect(page).to have_css('.op-activity-list--item-title', text: 'Minutes: Awesome meeting!')
- expect(page).to have_css('.op-activity-list--item-title', text: 'Agenda: Awesome meeting!')
- expect(page).to have_css('.op-activity-list--item-title', text: 'Meeting: Awesome meeting!')
+ expect(page).to have_css(".op-activity-list--item-title", text: "Minutes: Awesome meeting!")
+ expect(page).to have_css(".op-activity-list--item-title", text: "Agenda: Awesome meeting!")
+ expect(page).to have_css(".op-activity-list--item-title", text: "Meeting: Awesome meeting!")
end
end
end
diff --git a/modules/meeting/spec/features/meetings_close_spec.rb b/modules/meeting/spec/features/meetings_close_spec.rb
index b0fb0a47d1df..7dd952537c03 100644
--- a/modules/meeting/spec/features/meetings_close_spec.rb
+++ b/modules/meeting/spec/features/meetings_close_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Meetings close' do
+RSpec.describe "Meetings close" do
let(:project) { create(:project, enabled_module_names: %w[meetings]) }
let(:user) do
create(:user,
@@ -39,55 +39,55 @@
member_with_permissions: { project => permissions })
end
- let!(:meeting) { create(:meeting, project:, title: 'Own awesome meeting!', author: user) }
+ let!(:meeting) { create(:meeting, project:, title: "Own awesome meeting!", author: user) }
let!(:meeting_agenda) { create(:meeting_agenda, meeting:, text: "asdf") }
before do
login_as(user)
end
- context 'with permission to close meetings', :js do
+ context "with permission to close meetings", :js do
let(:permissions) { %i[view_meetings close_meeting_agendas] }
- it 'can delete own and other`s meetings' do
+ it "can delete own and other`s meetings" do
visit meetings_path(project)
click_link meeting.title
# Go to minutes, expect uneditable
- find('.op-tab-row--link', text: 'MINUTES').click
+ find(".op-tab-row--link", text: "MINUTES").click
- expect(page).to have_css('.button', text: 'Close the agenda to begin the Minutes')
+ expect(page).to have_css(".button", text: "Close the agenda to begin the Minutes")
# Close the meeting
- find('.op-tab-row--link', text: 'AGENDA').click
+ find(".op-tab-row--link", text: "AGENDA").click
accept_confirm do
- find('.button', text: 'Close').click
+ find(".button", text: "Close").click
end
# Expect to be on minutes
- expect(page).to have_css('.op-tab-row--link_selected', text: 'MINUTES')
+ expect(page).to have_css(".op-tab-row--link_selected", text: "MINUTES")
# Copies the text
- expect(page).to have_css('#tab-content-minutes', text: 'asdf')
+ expect(page).to have_css("#tab-content-minutes", text: "asdf")
# Go back to agenda, expect we can open it again
- find('.op-tab-row--link', text: 'AGENDA').click
+ find(".op-tab-row--link", text: "AGENDA").click
accept_confirm do
- find('.button', text: 'Open').click
+ find(".button", text: "Open").click
end
- expect(page).to have_css('.button', text: 'Close')
+ expect(page).to have_css(".button", text: "Close")
end
end
- context 'without permission to close meetings' do
+ context "without permission to close meetings" do
let(:permissions) { %i[view_meetings] }
- it 'cannot delete own and other`s meetings' do
+ it "cannot delete own and other`s meetings" do
visit meetings_path(project)
expect(page)
- .to have_no_link 'Close'
+ .to have_no_link "Close"
end
end
end
diff --git a/modules/meeting/spec/features/meetings_copy_spec.rb b/modules/meeting/spec/features/meetings_copy_spec.rb
index 0aac54cf3949..2c6e503c7e5a 100644
--- a/modules/meeting/spec/features/meetings_copy_spec.rb
+++ b/modules/meeting/spec/features/meetings_copy_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Meetings copy', :js, :with_cuprite do
+RSpec.describe "Meetings copy", :js, :with_cuprite do
shared_let(:project) { create(:project, enabled_module_names: %w[meetings]) }
shared_let(:permissions) { %i[view_meetings create_meetings] }
shared_let(:user) do
create(:user,
member_with_permissions: { project => permissions }).tap do |u|
- u.pref[:time_zone] = 'UTC'
+ u.pref[:time_zone] = "UTC"
u.save!
end
@@ -51,8 +51,8 @@
create(:meeting,
author: user,
project:,
- title: 'Awesome meeting!',
- location: 'Meeting room',
+ title: "Awesome meeting!",
+ location: "Meeting room",
duration:,
start_time:).tap do |m|
create(:meeting_agenda, meeting: m, text: agenda_text)
@@ -73,26 +73,26 @@
login_as user
end
- it 'copying a meeting' do
+ it "copying a meeting" do
visit project_meetings_path(project)
click_link meeting.title
- find_test_selector('meetings-more-dropdown-menu').click
- page.within('.menu-drop-down-container') do
- click_link 'Copy'
+ find_test_selector("meetings-more-dropdown-menu").click
+ page.within(".menu-drop-down-container") do
+ click_link "Copy"
end
expect(page)
- .to have_field 'Title', with: meeting.title
+ .to have_field "Title", with: meeting.title
expect(page)
- .to have_field 'Location', with: meeting.location
+ .to have_field "Location", with: meeting.location
expect(page)
- .to have_field 'Duration', with: meeting.duration
+ .to have_field "Duration", with: meeting.duration
expect(page)
- .to have_field 'Start date', with: (start_time + 1.week).strftime("%Y-%m-%d")
+ .to have_field "Start date", with: (start_time + 1.week).strftime("%Y-%m-%d")
expect(page)
- .to have_field 'Time', with: start_time.strftime("%H:%M")
+ .to have_field "Time", with: start_time.strftime("%H:%M")
click_button "Create"
diff --git a/modules/meeting/spec/features/meetings_delete_spec.rb b/modules/meeting/spec/features/meetings_delete_spec.rb
index bfc9ec1d0679..76fa351234d3 100644
--- a/modules/meeting/spec/features/meetings_delete_spec.rb
+++ b/modules/meeting/spec/features/meetings_delete_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Meetings deletion' do
+RSpec.describe "Meetings deletion" do
let(:project) { create(:project, enabled_module_names: %w[meetings]) }
let(:user) do
create(:user,
@@ -39,8 +39,8 @@
member_with_permissions: { project => permissions })
end
- let!(:meeting) { create(:meeting, project:, title: 'Own awesome meeting!', author: user) }
- let!(:other_meeting) { create(:meeting, project:, title: 'Other awesome meeting!', author: other_user) }
+ let!(:meeting) { create(:meeting, project:, title: "Own awesome meeting!", author: user) }
+ let!(:other_meeting) { create(:meeting, project:, title: "Other awesome meeting!", author: other_user) }
let(:index_path) { project_meetings_path(project) }
@@ -48,7 +48,7 @@
login_as(user)
end
- context 'with permission to delete meetings', :js do
+ context "with permission to delete meetings", :js do
let(:permissions) { %i[view_meetings delete_meetings] }
it "can delete own and other's meetings" do
@@ -56,7 +56,7 @@
click_link meeting.title
accept_confirm do
- find_test_selector('meetings-more-dropdown-menu').click
+ find_test_selector("meetings-more-dropdown-menu").click
click_link "Delete"
end
@@ -65,19 +65,19 @@
click_link other_meeting.title
accept_confirm do
- find_test_selector('meetings-more-dropdown-menu').click
+ find_test_selector("meetings-more-dropdown-menu").click
click_link "Delete"
end
expect(page)
- .to have_content(I18n.t('.no_results_title_text', cascade: true))
+ .to have_content(I18n.t(".no_results_title_text", cascade: true))
expect(page)
.to have_current_path index_path
end
end
- context 'without permission to delete meetings' do
+ context "without permission to delete meetings" do
let(:permissions) { %i[view_meetings] }
it "cannot delete own and other's meetings" do
@@ -85,13 +85,13 @@
click_link meeting.title
expect(page)
- .to have_no_link 'Delete'
+ .to have_no_link "Delete"
visit index_path
click_link other_meeting.title
expect(page)
- .to have_no_link 'Delete'
+ .to have_no_link "Delete"
end
end
end
diff --git a/modules/meeting/spec/features/meetings_global_menu_item_spec.rb b/modules/meeting/spec/features/meetings_global_menu_item_spec.rb
index 047878b24825..d849d29f2e82 100644
--- a/modules/meeting/spec/features/meetings_global_menu_item_spec.rb
+++ b/modules/meeting/spec/features/meetings_global_menu_item_spec.rb
@@ -29,10 +29,10 @@
# ++
#
-require 'spec_helper'
-require_relative '../support/pages/meetings/index'
+require "spec_helper"
+require_relative "../support/pages/meetings/index"
-RSpec.describe 'Meetings global menu item',
+RSpec.describe "Meetings global menu item",
:with_cuprite do
shared_let(:user_without_permissions) { create(:user) }
shared_let(:admin) { create(:admin) }
@@ -44,33 +44,33 @@
login_as current_user
end
- context 'as a user with permissions' do
+ context "as a user with permissions" do
let(:current_user) { admin }
before do
meetings_page.navigate_by_global_menu
end
- it 'navigates to the global meetings index page' do
- expect(page).to have_current_path('/meetings')
+ it "navigates to the global meetings index page" do
+ expect(page).to have_current_path("/meetings")
end
specify '"Upcoming meetings" is the default filter set' do
- within '#main-menu' do
- expect(page).to have_css('.selected', text: I18n.t(:label_upcoming_meetings))
+ within "#main-menu" do
+ expect(page).to have_css(".selected", text: I18n.t(:label_upcoming_meetings))
end
end
end
- context 'as a user without permissions' do
+ context "as a user without permissions" do
let(:current_user) { user_without_permissions }
before do
visit root_path
end
- it 'does not render' do
- within '#main-menu' do
+ it "does not render" do
+ within "#main-menu" do
expect(page).to have_no_link(meetings_label)
end
end
diff --git a/modules/meeting/spec/features/meetings_index_spec.rb b/modules/meeting/spec/features/meetings_index_spec.rb
index 5f99d71a894b..941ac61d057e 100644
--- a/modules/meeting/spec/features/meetings_index_spec.rb
+++ b/modules/meeting/spec/features/meetings_index_spec.rb
@@ -26,16 +26,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/meetings/index'
+require_relative "../support/pages/meetings/index"
-RSpec.describe 'Meetings', 'Index', :with_cuprite do
+RSpec.describe "Meetings", "Index", :with_cuprite do
# The order the Projects are created in is important. By naming `project` alphanumerically
# after `other_project`, we can ensure that subsequent specs that assert sorting is
# correct for the right reasons (sorting by Project name and not id)
- shared_let(:project) { create(:project, name: 'Project 2', enabled_module_names: %w[meetings]) }
- shared_let(:other_project) { create(:project, name: 'Project 1', enabled_module_names: %w[meetings]) }
+ shared_let(:project) { create(:project, name: "Project 2", enabled_module_names: %w[meetings]) }
+ shared_let(:other_project) { create(:project, name: "Project 1", enabled_module_names: %w[meetings]) }
let(:role) { create(:project_role, permissions:) }
let(:permissions) { %i(view_meetings) }
let(:user) do
@@ -52,42 +52,42 @@
let(:meeting) do
create(:meeting,
project:,
- title: 'Awesome meeting today!',
+ title: "Awesome meeting today!",
start_time: Time.current)
end
let(:tomorrows_meeting) do
create(:meeting,
project:,
- title: 'Awesome meeting tomorrow!',
+ title: "Awesome meeting tomorrow!",
start_time: 1.day.from_now,
duration: 2.0,
- location: 'no-protocol.com')
+ location: "no-protocol.com")
end
let(:meeting_with_no_location) do
create(:meeting,
project:,
- title: 'Boring meeting without a location!',
+ title: "Boring meeting without a location!",
start_time: 1.day.from_now,
- location: '')
+ location: "")
end
let(:meeting_with_malicious_location) do
create(:meeting,
project:,
- title: 'Sneaky meeting!',
+ title: "Sneaky meeting!",
start_time: 1.day.from_now,
location: "")
end
let(:yesterdays_meeting) do
- create(:meeting, project:, title: 'Awesome meeting yesterday!', start_time: 1.day.ago)
+ create(:meeting, project:, title: "Awesome meeting yesterday!", start_time: 1.day.ago)
end
shared_let(:other_project_meeting) do
create(:meeting,
project: other_project,
- title: 'Awesome other project meeting!',
+ title: "Awesome other project meeting!",
start_time: 2.days.from_now,
duration: 2.0,
- location: 'not-a-url')
+ location: "not-a-url")
end
def setup_meeting_involvement
@@ -101,10 +101,10 @@ def setup_meeting_involvement
login_as user
end
- shared_examples 'sidebar filtering' do |context:|
- context 'when filtering with the sidebar' do
+ shared_examples "sidebar filtering" do |context:|
+ context "when filtering with the sidebar" do
shared_let(:ongoing_meeting) do
- create(:meeting, project:, title: 'Awesome ongoing meeting!', start_time: 30.minutes.ago)
+ create(:meeting, project:, title: "Awesome ongoing meeting!", start_time: 30.minutes.ago)
end
before do
@@ -114,10 +114,10 @@ def setup_meeting_involvement
context 'with the "Upcoming meetings" filter' do
before do
- meetings_page.set_sidebar_filter 'Upcoming meetings'
+ meetings_page.set_sidebar_filter "Upcoming meetings"
end
- it 'shows all upcoming and ongoing meetings', :aggregate_failures do
+ it "shows all upcoming and ongoing meetings", :aggregate_failures do
expected_upcoming_meetings = if context == :global
[ongoing_meeting, meeting, tomorrows_meeting, other_project_meeting]
else
@@ -131,10 +131,10 @@ def setup_meeting_involvement
context 'with the "Past meetings" filter' do
before do
- meetings_page.set_sidebar_filter 'Past meetings'
+ meetings_page.set_sidebar_filter "Past meetings"
end
- it 'show all past and ongoing meetings' do
+ it "show all past and ongoing meetings" do
meetings_page.expect_meetings_listed_in_order(ongoing_meeting,
yesterdays_meeting)
meetings_page.expect_meetings_not_listed(meeting,
@@ -144,7 +144,7 @@ def setup_meeting_involvement
context 'with the "Upcoming invitations" filter' do
before do
- meetings_page.set_sidebar_filter 'Upcoming invitations'
+ meetings_page.set_sidebar_filter "Upcoming invitations"
end
it "shows all upcoming meetings I've been marked as invited to" do
@@ -157,7 +157,7 @@ def setup_meeting_involvement
context 'with the "Past invitations" filter' do
before do
- meetings_page.set_sidebar_filter 'Past invitations'
+ meetings_page.set_sidebar_filter "Past invitations"
end
it "shows all past meetings I've been marked as invited to" do
@@ -170,7 +170,7 @@ def setup_meeting_involvement
context 'with the "Attendee" filter' do
before do
- meetings_page.set_sidebar_filter 'Attendee'
+ meetings_page.set_sidebar_filter "Attendee"
end
it "shows all meetings I've been marked as attending to" do
@@ -183,7 +183,7 @@ def setup_meeting_involvement
context 'with the "Creator" filter' do
before do
- meetings_page.set_sidebar_filter 'Creator'
+ meetings_page.set_sidebar_filter "Creator"
end
it "shows all meetings I'm the author of" do
@@ -196,10 +196,10 @@ def setup_meeting_involvement
end
end
- context 'when visiting from a global context' do
+ context "when visiting from a global context" do
let(:meetings_page) { Pages::Meetings::Index.new(project: nil) }
- it 'lists all upcoming meetings for all projects the user has access to' do
+ it "lists all upcoming meetings for all projects the user has access to" do
meeting
yesterdays_meeting
@@ -223,17 +223,17 @@ def setup_meeting_involvement
meetings_page.expect_no_meeting_location(meeting_with_no_location)
end
- context 'and the user is allowed to create meetings' do
+ context "and the user is allowed to create meetings" do
let(:permissions) { %i(view_meetings create_meetings) }
- it 'shows the create new buttons' do
+ it "shows the create new buttons" do
meetings_page.navigate_by_modules_menu
meetings_page.expect_create_new_buttons
end
end
- context 'and the user is not allowed to create meetings' do
+ context "and the user is not allowed to create meetings" do
let(:permissions) { %i[view_meetings] }
it "doesn't show a create new button" do
@@ -243,7 +243,7 @@ def setup_meeting_involvement
end
end
- describe 'sorting' do
+ describe "sorting" do
before do
meeting
visit meetings_path
@@ -255,78 +255,78 @@ def setup_meeting_involvement
meetings_page.expect_meetings_listed_in_order(meeting, other_project_meeting)
end
- it 'allows sorting by every column' do
- aggregate_failures 'Sorting by Title' do
- meetings_page.click_to_sort_by('Title')
+ it "allows sorting by every column" do
+ aggregate_failures "Sorting by Title" do
+ meetings_page.click_to_sort_by("Title")
meetings_page.expect_meetings_listed_in_order(meeting,
other_project_meeting)
- meetings_page.click_to_sort_by('Title')
+ meetings_page.click_to_sort_by("Title")
meetings_page.expect_meetings_listed_in_order(other_project_meeting,
meeting)
end
- aggregate_failures 'Sorting by Project' do
- meetings_page.click_to_sort_by('Project')
+ aggregate_failures "Sorting by Project" do
+ meetings_page.click_to_sort_by("Project")
meetings_page.expect_meetings_listed_in_order(other_project_meeting,
meeting)
- meetings_page.click_to_sort_by('Project')
+ meetings_page.click_to_sort_by("Project")
meetings_page.expect_meetings_listed_in_order(meeting,
other_project_meeting)
end
- aggregate_failures 'Sorting by Time' do
- meetings_page.click_to_sort_by('Time')
+ aggregate_failures "Sorting by Time" do
+ meetings_page.click_to_sort_by("Time")
meetings_page.expect_meetings_listed_in_order(meeting,
other_project_meeting)
- meetings_page.click_to_sort_by('Time')
+ meetings_page.click_to_sort_by("Time")
meetings_page.expect_meetings_listed_in_order(other_project_meeting,
meeting)
end
- aggregate_failures 'Sorting by Duration' do
- meetings_page.click_to_sort_by('Duration')
+ aggregate_failures "Sorting by Duration" do
+ meetings_page.click_to_sort_by("Duration")
meetings_page.expect_meetings_listed_in_order(meeting,
other_project_meeting)
- meetings_page.click_to_sort_by('Duration')
+ meetings_page.click_to_sort_by("Duration")
meetings_page.expect_meetings_listed_in_order(other_project_meeting,
meeting)
end
- aggregate_failures 'Sorting by Location' do
- meetings_page.click_to_sort_by('Location')
+ aggregate_failures "Sorting by Location" do
+ meetings_page.click_to_sort_by("Location")
meetings_page.expect_meetings_listed_in_order(meeting,
other_project_meeting)
- meetings_page.click_to_sort_by('Location')
+ meetings_page.click_to_sort_by("Location")
meetings_page.expect_meetings_listed_in_order(other_project_meeting,
meeting)
end
end
end
- include_examples 'sidebar filtering', context: :global
+ include_examples "sidebar filtering", context: :global
end
- context 'when visiting from a project specific context' do
+ context "when visiting from a project specific context" do
let(:meetings_page) { Pages::Meetings::Index.new(project:) }
- context 'via the menu' do
- specify 'with no meetings' do
+ context "via the menu" do
+ specify "with no meetings" do
meetings_page.navigate_by_project_menu
meetings_page.expect_no_meetings_listed
end
end
- context 'when the user is allowed to create meetings' do
+ context "when the user is allowed to create meetings" do
let(:permissions) { %i(view_meetings create_meetings) }
- it 'shows the create new buttons' do
+ it "shows the create new buttons" do
meetings_page.visit!
meetings_page.expect_create_new_buttons
end
end
- context 'when the user is not allowed to create meetings' do
+ context "when the user is not allowed to create meetings" do
let(:permissions) { %i[view_meetings] }
it "doesn't show the create new buttons" do
@@ -335,16 +335,16 @@ def setup_meeting_involvement
end
end
- include_examples 'sidebar filtering', context: :project
+ include_examples "sidebar filtering", context: :project
- specify 'with 1 meeting listed' do
+ specify "with 1 meeting listed" do
meeting
meetings_page.visit!
meetings_page.expect_meetings_listed(meeting)
end
- it 'with pagination', with_settings: { per_page_options: '1' } do
+ it "with pagination", with_settings: { per_page_options: "1" } do
meeting
tomorrows_meeting
yesterdays_meeting
@@ -377,7 +377,7 @@ def setup_meeting_involvement
meetings_page.expect_no_meeting_location(meeting_with_no_location)
end
- describe 'sorting' do
+ describe "sorting" do
before do
meeting
tomorrows_meeting
@@ -390,57 +390,57 @@ def setup_meeting_involvement
meetings_page.expect_meetings_listed_in_order(meeting, tomorrows_meeting)
end
- it 'allows sorting by every column' do
- aggregate_failures 'Sorting by Title' do
- meetings_page.click_to_sort_by('Title')
+ it "allows sorting by every column" do
+ aggregate_failures "Sorting by Title" do
+ meetings_page.click_to_sort_by("Title")
meetings_page.expect_meetings_listed_in_order(meeting,
tomorrows_meeting)
- meetings_page.click_to_sort_by('Title')
+ meetings_page.click_to_sort_by("Title")
meetings_page.expect_meetings_listed_in_order(tomorrows_meeting,
meeting)
end
- aggregate_failures 'Sorting by Time' do
- meetings_page.click_to_sort_by('Time')
+ aggregate_failures "Sorting by Time" do
+ meetings_page.click_to_sort_by("Time")
meetings_page.expect_meetings_listed_in_order(meeting,
tomorrows_meeting)
- meetings_page.click_to_sort_by('Time')
+ meetings_page.click_to_sort_by("Time")
meetings_page.expect_meetings_listed_in_order(tomorrows_meeting,
meeting)
end
- aggregate_failures 'Sorting by Time' do
- meetings_page.click_to_sort_by('Time')
+ aggregate_failures "Sorting by Time" do
+ meetings_page.click_to_sort_by("Time")
meetings_page.expect_meetings_listed_in_order(meeting,
tomorrows_meeting)
- meetings_page.click_to_sort_by('Time')
+ meetings_page.click_to_sort_by("Time")
meetings_page.expect_meetings_listed_in_order(tomorrows_meeting,
meeting)
end
- aggregate_failures 'Sorting by Duration' do
- meetings_page.click_to_sort_by('Duration')
+ aggregate_failures "Sorting by Duration" do
+ meetings_page.click_to_sort_by("Duration")
meetings_page.expect_meetings_listed_in_order(meeting,
tomorrows_meeting)
- meetings_page.click_to_sort_by('Duration')
+ meetings_page.click_to_sort_by("Duration")
meetings_page.expect_meetings_listed_in_order(tomorrows_meeting,
meeting)
end
- aggregate_failures 'Sorting by Duration' do
- meetings_page.click_to_sort_by('Duration')
+ aggregate_failures "Sorting by Duration" do
+ meetings_page.click_to_sort_by("Duration")
meetings_page.expect_meetings_listed_in_order(meeting,
tomorrows_meeting)
- meetings_page.click_to_sort_by('Duration')
+ meetings_page.click_to_sort_by("Duration")
meetings_page.expect_meetings_listed_in_order(tomorrows_meeting,
meeting)
end
- aggregate_failures 'Sorting by Location' do
- meetings_page.click_to_sort_by('Location')
+ aggregate_failures "Sorting by Location" do
+ meetings_page.click_to_sort_by("Location")
meetings_page.expect_meetings_listed_in_order(meeting,
tomorrows_meeting)
- meetings_page.click_to_sort_by('Location')
+ meetings_page.click_to_sort_by("Location")
meetings_page.expect_meetings_listed_in_order(tomorrows_meeting,
meeting)
end
diff --git a/modules/meeting/spec/features/meetings_locking_spec.rb b/modules/meeting/spec/features/meetings_locking_spec.rb
index cf4dbac72dcd..d40186178d0e 100644
--- a/modules/meeting/spec/features/meetings_locking_spec.rb
+++ b/modules/meeting/spec/features/meetings_locking_spec.rb
@@ -26,40 +26,40 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Meetings locking', :js do
+RSpec.describe "Meetings locking", :js do
let(:project) { create(:project, enabled_module_names: %w[meetings]) }
let(:user) { create(:admin) }
let!(:meeting) { create(:meeting) }
let!(:agenda) { create(:meeting_agenda, meeting:) }
let(:agenda_field) do
TextEditorField.new(page,
- '',
- selector: test_selector('op-meeting--meeting_agenda'))
+ "",
+ selector: test_selector("op-meeting--meeting_agenda"))
end
before do
login_as(user)
end
- it 'shows an error when trying to update a meeting update while editing' do
+ it "shows an error when trying to update a meeting update while editing" do
visit meeting_path(meeting)
# Edit agenda
- within '#tab-content-agenda' do
- find('.button--edit-agenda').click
+ within "#tab-content-agenda" do
+ find(".button--edit-agenda").click
- agenda_field.set_value('Some new text')
+ agenda_field.set_value("Some new text")
- agenda.text = 'blabla'
+ agenda.text = "blabla"
agenda.save!
- click_on 'Save'
+ click_on "Save"
end
- expect(page).to have_text 'Information has been updated by at least one other user in the meantime.'
+ expect(page).to have_text "Information has been updated by at least one other user in the meantime."
- agenda_field.expect_value('Some new text')
+ agenda_field.expect_value("Some new text")
end
end
diff --git a/modules/meeting/spec/features/meetings_new_spec.rb b/modules/meeting/spec/features/meetings_new_spec.rb
index cf042da7c1da..5f710ba71edb 100644
--- a/modules/meeting/spec/features/meetings_new_spec.rb
+++ b/modules/meeting/spec/features/meetings_new_spec.rb
@@ -26,17 +26,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/meetings/index'
+require_relative "../support/pages/meetings/index"
-RSpec.describe 'Meetings new', :js, with_cuprite: false do
+RSpec.describe "Meetings new", :js, with_cuprite: false do
shared_let(:project) { create(:project, enabled_module_names: %w[meetings]) }
shared_let(:admin) { create(:admin) }
- let(:time_zone) { 'utc' }
+ let(:time_zone) { "utc" }
let(:user) do
create(:user,
- lastname: 'First',
+ lastname: "First",
member_with_permissions: { project => permissions }).tap do |u|
u.pref[:time_zone] = time_zone
@@ -45,7 +45,7 @@
end
let(:other_user) do
create(:user,
- lastname: 'Second',
+ lastname: "Second",
member_with_permissions: { project => permissions })
end
let(:permissions) { %i[view_meetings create_meetings] }
@@ -55,7 +55,7 @@
login_as current_user
end
- context 'when creating a meeting from the global page' do
+ context "when creating a meeting from the global page" do
before do
other_user
project
@@ -64,21 +64,21 @@
let(:index_page) { Pages::Meetings::Index.new(project: nil) }
let(:new_page) { Pages::Meetings::New.new(nil) }
- context 'with permission to create meetings' do
- it 'does not render menus', :with_cuprite do
+ context "with permission to create meetings" do
+ it "does not render menus", :with_cuprite do
new_page.visit!
new_page.expect_no_main_menu
end
- describe 'clicking on the create new meeting button', :with_cuprite do
- it 'navigates to the global create form' do
+ describe "clicking on the create new meeting button", :with_cuprite do
+ it "navigates to the global create form" do
index_page.visit!
index_page.click_create_new
expect(page).to have_current_path(new_page.path)
end
end
- ['CET', 'UTC', '', 'Pacific Time (US & Canada)'].each do |zone|
+ ["CET", "UTC", "", "Pacific Time (US & Canada)"].each do |zone|
let(:time_zone) { zone }
it "allows creating a project and handles errors in time zone #{zone}" do
@@ -86,18 +86,18 @@
expect_angular_frontend_initialized # Wait for project dropdown to be ready
- new_page.set_title 'Some title'
- new_page.set_type 'Classic'
+ new_page.set_title "Some title"
+ new_page.set_type "Classic"
new_page.set_project project
- new_page.set_start_date '2013-03-28'
- new_page.set_start_time '13:30'
- new_page.set_duration '1.5'
+ new_page.set_start_date "2013-03-28"
+ new_page.set_start_time "13:30"
+ new_page.set_duration "1.5"
new_page.invite(other_user)
show_page = new_page.click_create
- show_page.expect_toast(message: 'Successful creation')
+ show_page.expect_toast(message: "Successful creation")
show_page.expect_invited(user, other_user)
@@ -105,7 +105,7 @@
end
end
- context 'without a title set' do
+ context "without a title set" do
before do
new_page.visit!
@@ -114,13 +114,13 @@
new_page.set_project project
- new_page.set_start_date '2013-03-28'
- new_page.set_start_time '13:30'
- new_page.set_duration '1.5'
+ new_page.set_start_date "2013-03-28"
+ new_page.set_start_time "13:30"
+ new_page.set_duration "1.5"
new_page.invite(other_user)
end
- it 'renders a validation error' do
+ it "renders a validation error" do
expect do
new_page.click_create
end.not_to change(Query, :count)
@@ -130,17 +130,17 @@
end
end
- context 'without a project set' do
+ context "without a project set" do
before do
new_page.visit!
- new_page.set_title 'Some title'
- new_page.set_type 'Classic'
- new_page.set_start_date '2013-03-28'
- new_page.set_start_time '13:30'
- new_page.set_duration '1.5'
+ new_page.set_title "Some title"
+ new_page.set_type "Classic"
+ new_page.set_start_date "2013-03-28"
+ new_page.set_start_time "13:30"
+ new_page.set_duration "1.5"
end
- it 'renders a validation error' do
+ it "renders a validation error" do
new_page.click_create
new_page.expect_toast(message: "#{Project.model_name.human} #{I18n.t('activerecord.errors.messages.blank')}",
@@ -151,26 +151,26 @@
end
end
- context 'without permission to create meetings', :with_cuprite do
+ context "without permission to create meetings", :with_cuprite do
let(:permissions) { %i[view_meetings] }
- it 'shows no edit link' do
+ it "shows no edit link" do
index_page.visit!
index_page.expect_no_create_new_button
end
end
- context 'as an admin', :with_cuprite do
+ context "as an admin", :with_cuprite do
let(:current_user) { admin }
- it 'allows creating meeting in a project without members' do
+ it "allows creating meeting in a project without members" do
new_page.visit!
expect_angular_frontend_initialized # Wait for project dropdown to be ready
- new_page.set_title 'Some title'
- new_page.set_type 'Classic'
+ new_page.set_title "Some title"
+ new_page.set_type "Classic"
new_page.set_project project
@@ -178,20 +178,20 @@
show_page = new_page.click_create
- show_page.expect_toast(message: 'Successful creation')
+ show_page.expect_toast(message: "Successful creation")
# Not sure if that is then intended behaviour but that is what is currently programmed
show_page.expect_invited(admin)
end
- context 'without a project set' do
+ context "without a project set" do
before do
new_page.visit!
- new_page.set_title 'Some title'
- new_page.set_type 'Classic'
+ new_page.set_title "Some title"
+ new_page.set_type "Classic"
end
- it 'renders a validation error' do
+ it "renders a validation error" do
new_page.click_create
new_page.expect_toast(message: "#{Project.model_name.human} #{I18n.t('activerecord.errors.messages.blank')}",
@@ -200,7 +200,7 @@
end
end
- context 'without a title set' do
+ context "without a title set" do
before do
new_page.visit!
@@ -210,7 +210,7 @@
new_page.set_project project
end
- it 'renders a validation error' do
+ it "renders a validation error" do
expect do
new_page.click_create
end.not_to change(Query, :count)
@@ -222,39 +222,39 @@
end
end
- context 'when creating a meeting from the project-specific page' do
+ context "when creating a meeting from the project-specific page" do
let(:index_page) { Pages::Meetings::Index.new(project:) }
let(:new_page) { Pages::Meetings::New.new(project) }
- context 'with permission to create meetings' do
+ context "with permission to create meetings" do
before do
other_user
end
- describe 'clicking on the create new meeting button', :with_cuprite do
- it 'navigates to the project-specific create form' do
+ describe "clicking on the create new meeting button", :with_cuprite do
+ it "navigates to the project-specific create form" do
index_page.visit!
index_page.click_create_new
expect(page).to have_current_path(new_page.path)
end
end
- ['CET', 'UTC', '', 'Pacific Time (US & Canada)'].each do |zone|
+ ["CET", "UTC", "", "Pacific Time (US & Canada)"].each do |zone|
let(:time_zone) { zone }
it "allows creating a project and handles errors in time zone #{zone}" do
new_page.visit!
- new_page.set_title 'Some title'
- new_page.set_type 'Classic'
- new_page.set_start_date '2013-03-28'
- new_page.set_start_time '13:30'
- new_page.set_duration '1.5'
+ new_page.set_title "Some title"
+ new_page.set_type "Classic"
+ new_page.set_start_date "2013-03-28"
+ new_page.set_start_time "13:30"
+ new_page.set_duration "1.5"
new_page.invite(other_user)
show_page = new_page.click_create
- show_page.expect_toast(message: 'Successful creation')
+ show_page.expect_toast(message: "Successful creation")
show_page.expect_invited(user, other_user)
@@ -262,16 +262,16 @@
end
end
- context 'without a title set' do
+ context "without a title set" do
before do
new_page.visit!
- new_page.set_start_date '2013-03-28'
- new_page.set_start_time '13:30'
- new_page.set_duration '1.5'
+ new_page.set_start_date "2013-03-28"
+ new_page.set_start_time "13:30"
+ new_page.set_duration "1.5"
new_page.invite(other_user)
end
- it 'renders a validation error' do
+ it "renders a validation error" do
expect do
new_page.click_create
end.not_to change(Query, :count)
@@ -282,44 +282,44 @@
end
end
- context 'without permission to create meetings', :with_cuprite do
+ context "without permission to create meetings", :with_cuprite do
let(:permissions) { %i[view_meetings] }
- it 'shows no edit link' do
+ it "shows no edit link" do
index_page.visit!
index_page.expect_no_create_new_button
end
end
- context 'as an admin', :with_cuprite do
+ context "as an admin", :with_cuprite do
let(:current_user) { admin }
let(:field) do
TextEditorField.new(page,
- '',
- selector: test_selector('op-meeting--meeting_agenda'))
+ "",
+ selector: test_selector("op-meeting--meeting_agenda"))
end
- it 'allows creating meeting in a project without members' do
+ it "allows creating meeting in a project without members" do
new_page.visit!
- new_page.set_type 'Classic'
- new_page.set_title 'Some title'
+ new_page.set_type "Classic"
+ new_page.set_title "Some title"
show_page = new_page.click_create
- show_page.expect_toast(message: 'Successful creation')
+ show_page.expect_toast(message: "Successful creation")
# Not sure if that is then intended behaviour but that is what is currently programmed
show_page.expect_invited(admin)
end
- context 'without a title set' do
+ context "without a title set" do
before do
new_page.visit!
end
- it 'renders a validation error' do
+ it "renders a validation error" do
expect do
new_page.click_create
end.not_to change(Query, :count)
@@ -329,27 +329,27 @@
end
end
- it 'can save the meeting agenda via cmd+Enter' do
+ it "can save the meeting agenda via cmd+Enter" do
new_page.visit!
- new_page.set_title 'Some title'
- new_page.set_type 'Classic'
+ new_page.set_title "Some title"
+ new_page.set_type "Classic"
show_page = new_page.click_create
- show_page.expect_toast(message: 'Successful creation')
+ show_page.expect_toast(message: "Successful creation")
meeting = Meeting.last
- field.set_value('My new meeting text')
+ field.set_value("My new meeting text")
field.submit_by_enter
- show_page.expect_and_dismiss_toaster message: 'Successful update'
+ show_page.expect_and_dismiss_toaster message: "Successful update"
meeting.reload
- expect(meeting.agenda.text).to eq 'My new meeting text'
+ expect(meeting.agenda.text).to eq "My new meeting text"
end
end
end
diff --git a/modules/meeting/spec/features/meetings_participants_spec.rb b/modules/meeting/spec/features/meetings_participants_spec.rb
index fd05156c1087..3159e2df5cf5 100644
--- a/modules/meeting/spec/features/meetings_participants_spec.rb
+++ b/modules/meeting/spec/features/meetings_participants_spec.rb
@@ -26,35 +26,35 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/meetings/edit'
+require_relative "../support/pages/meetings/edit"
-RSpec.describe 'Meetings participants' do
+RSpec.describe "Meetings participants" do
let(:project) { create(:project, enabled_module_names: %w[meetings]) }
let!(:user) do
create(:user,
- firstname: 'Current',
+ firstname: "Current",
member_with_permissions: { project => %i[view_meetings edit_meetings] })
end
let!(:viewer_user) do
create(:user,
- firstname: 'Viewer',
+ firstname: "Viewer",
member_with_permissions: { project => %i[view_meetings] })
end
let!(:non_viewer_user) do
create(:user,
- firstname: 'Nonviewer',
+ firstname: "Nonviewer",
member_with_permissions: { project => %i[] })
end
let(:edit_page) { Pages::Meetings::Edit.new(meeting) }
- let!(:meeting) { create(:meeting, project:, title: 'Awesome meeting!') }
+ let!(:meeting) { create(:meeting, project:, title: "Awesome meeting!") }
before do
login_as(user)
end
- it 'allows setting members to participants which are allowed to view the meeting' do
+ it "allows setting members to participants which are allowed to view the meeting" do
edit_page.visit!
edit_page.expect_available_participant(user)
@@ -64,7 +64,7 @@
edit_page.invite(viewer_user)
show_page = edit_page.click_save
- show_page.expect_toast(message: 'Successful update')
+ show_page.expect_toast(message: "Successful update")
show_page.expect_invited(viewer_user)
@@ -72,12 +72,12 @@
edit_page.uninvite(viewer_user)
show_page = edit_page.click_save
- show_page.expect_toast(message: 'Successful update')
+ show_page.expect_toast(message: "Successful update")
show_page.expect_uninvited(viewer_user)
end
- context 'with an invalid user reference' do
+ context "with an invalid user reference" do
let(:show_page) { Pages::Meetings::Show.new(meeting) }
let(:meeting_participant) { create(:meeting_participant, user: viewer_user, meeting:) }
@@ -85,7 +85,7 @@
meeting_participant.update_column(:user_id, 12341234)
end
- it 'still allows to view the meeting' do
+ it "still allows to view the meeting" do
show_page.visit!
show_page.expect_invited meeting.author
diff --git a/modules/meeting/spec/features/meetings_search_spec.rb b/modules/meeting/spec/features/meetings_search_spec.rb
index dfd6e4165c1b..c9ab648b204c 100644
--- a/modules/meeting/spec/features/meetings_search_spec.rb
+++ b/modules/meeting/spec/features/meetings_search_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Meeting search', :js do
+RSpec.describe "Meeting search", :js do
include Components::Autocompleter::NgSelectAutocompleteHelpers
let(:project) { create(:project) }
let(:role) { create(:project_role, permissions: %i(view_meetings view_work_packages)) }
@@ -43,35 +43,35 @@
visit project_path(project)
end
- context 'global search' do
- it 'works with a title' do
- select_autocomplete(page.find('.top-menu-search--input'),
+ context "global search" do
+ it "works with a title" do
+ select_autocomplete(page.find(".top-menu-search--input"),
query: "Meeting",
select_text: "In this project ↵",
wait_dropdown_open: false)
page.find('[data-qa-tab-id="meetings"]').click
- expect(page.find_by_id('search-results')).to have_text(meeting.title)
+ expect(page.find_by_id("search-results")).to have_text(meeting.title)
end
- it 'works with an agenda item title' do
- select_autocomplete(page.find('.top-menu-search--input'),
+ it "works with an agenda item title" do
+ select_autocomplete(page.find(".top-menu-search--input"),
query: agenda_item.title,
select_text: "In this project ↵",
wait_dropdown_open: false)
page.find('[data-qa-tab-id="meetings"]').click
- expect(page.find_by_id('search-results')).to have_text(meeting.title)
+ expect(page.find_by_id("search-results")).to have_text(meeting.title)
end
- it 'works with an agenda item notes' do
- select_autocomplete(page.find('.top-menu-search--input'),
+ it "works with an agenda item notes" do
+ select_autocomplete(page.find(".top-menu-search--input"),
query: agenda_item.notes,
select_text: "In this project ↵",
wait_dropdown_open: false)
page.find('[data-qa-tab-id="meetings"]').click
- expect(page.find_by_id('search-results')).to have_text(meeting.title)
+ expect(page.find_by_id("search-results")).to have_text(meeting.title)
end
end
end
diff --git a/modules/meeting/spec/features/meetings_show_spec.rb b/modules/meeting/spec/features/meetings_show_spec.rb
index 7715a4c020fa..498d830b1ad1 100644
--- a/modules/meeting/spec/features/meetings_show_spec.rb
+++ b/modules/meeting/spec/features/meetings_show_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../support/pages/meetings/show'
+require "spec_helper"
+require_relative "../support/pages/meetings/show"
-RSpec.describe 'Meetings', :js do
+RSpec.describe "Meetings", :js do
let(:project) { create(:project, enabled_module_names: %w[meetings]) }
let(:role) { create(:project_role, permissions:) }
let(:user) do
@@ -37,39 +37,39 @@
member_with_roles: { project => role })
end
- let!(:meeting) { create(:meeting, project:, title: 'Awesome meeting!') }
+ let!(:meeting) { create(:meeting, project:, title: "Awesome meeting!") }
let(:show_page) { Pages::Meetings::Show.new(meeting) }
current_user { user }
- describe 'navigate to meeting page' do
+ describe "navigate to meeting page" do
let(:permissions) { %i[view_meetings] }
- it 'can visit the meeting' do
+ it "can visit the meeting" do
visit meetings_path(project)
- find('td.title a', text: 'Awesome meeting!', wait: 10).click
- expect(page).to have_css('h2', text: 'Meeting: Awesome meeting!')
+ find("td.title a", text: "Awesome meeting!", wait: 10).click
+ expect(page).to have_css("h2", text: "Meeting: Awesome meeting!")
- expect(page).to have_test_selector('op-meeting--meeting_agenda',
- text: 'There is currently nothing to display')
+ expect(page).to have_test_selector("op-meeting--meeting_agenda",
+ text: "There is currently nothing to display")
end
- context 'with a location' do
- context 'as a valid url' do
- it 'renders a link to the meeting location' do
+ context "with a location" do
+ context "as a valid url" do
+ it "renders a link to the meeting location" do
show_page.visit!
show_page.expect_link_to_location(meeting.location)
end
end
- context 'as an invalid url' do
+ context "as an invalid url" do
before do
- meeting.update!(location: 'badurl')
+ meeting.update!(location: "badurl")
end
- it 'renders the meeting location as plaintext' do
+ it "renders the meeting location as plaintext" do
show_page.visit!
show_page.expect_plaintext_location(meeting.location)
@@ -77,100 +77,100 @@
end
end
- context 'with an open agenda' do
- let!(:agenda) { create(:meeting_agenda, meeting:, text: 'foo') }
- let(:agenda_update) { create(:meeting_agenda, meeting:, text: 'bla') }
+ context "with an open agenda" do
+ let!(:agenda) { create(:meeting_agenda, meeting:, text: "foo") }
+ let(:agenda_update) { create(:meeting_agenda, meeting:, text: "bla") }
- it 'shows the agenda' do
+ it "shows the agenda" do
visit meeting_path(meeting)
- expect(page).to have_test_selector('op-meeting--meeting_agenda',
- text: 'foo')
+ expect(page).to have_test_selector("op-meeting--meeting_agenda",
+ text: "foo")
# May not edit
- expect(page).to have_no_css('.button--edit-agenda')
- expect(page).not_to have_test_selector('op-meeting--meeting_agenda',
- text: 'Edit')
+ expect(page).to have_no_css(".button--edit-agenda")
+ expect(page).not_to have_test_selector("op-meeting--meeting_agenda",
+ text: "Edit")
end
- it 'can view history' do
+ it "can view history" do
agenda_update
visit meeting_path(meeting)
- click_on 'History'
+ click_on "History"
- find_by_id('version-1').click
- expect(page).to have_test_selector('op-meeting--meeting_agenda', text: 'foo')
+ find_by_id("version-1").click
+ expect(page).to have_test_selector("op-meeting--meeting_agenda", text: "foo")
end
- context 'and edit permissions' do
+ context "and edit permissions" do
let(:permissions) { %i[view_meetings create_meeting_agendas] }
let(:field) do
TextEditorField.new(page,
- '',
- selector: test_selector('op-meeting--meeting_agenda'))
+ "",
+ selector: test_selector("op-meeting--meeting_agenda"))
end
- it 'can edit the agenda' do
+ it "can edit the agenda" do
visit meeting_path(meeting)
- find('.toolbar-item', text: 'Edit').click
+ find(".toolbar-item", text: "Edit").click
- field.expect_value('foo')
+ field.expect_value("foo")
- field.set_value('My new meeting text')
+ field.set_value("My new meeting text")
field.submit_by_enter
- show_page.expect_and_dismiss_toaster message: 'Successful update'
+ show_page.expect_and_dismiss_toaster message: "Successful update"
meeting.reload
- expect(meeting.agenda.text).to eq 'My new meeting text'
+ expect(meeting.agenda.text).to eq "My new meeting text"
end
end
- context 'and edit minutes permissions' do
+ context "and edit minutes permissions" do
let(:permissions) { %i[view_meetings create_meeting_minutes] }
- it 'can not edit the minutes' do
+ it "can not edit the minutes" do
visit meeting_path(meeting)
- click_link 'Minutes'
- expect(page).not_to have_test_selector('op-meeting--meeting_minutes', text: 'Edit')
- expect(page).to have_test_selector('op-meeting--meeting_minutes',
- text: 'There is currently nothing to display')
+ click_link "Minutes"
+ expect(page).not_to have_test_selector("op-meeting--meeting_minutes", text: "Edit")
+ expect(page).to have_test_selector("op-meeting--meeting_minutes",
+ text: "There is currently nothing to display")
end
end
end
- context 'with a locked agenda' do
- let!(:agenda) { create(:meeting_agenda, meeting:, text: 'foo', locked: true) }
+ context "with a locked agenda" do
+ let!(:agenda) { create(:meeting_agenda, meeting:, text: "foo", locked: true) }
- it 'shows the minutes when visiting' do
+ it "shows the minutes when visiting" do
visit meeting_path(meeting)
- expect(page).to have_no_css('h2', text: 'Agenda')
- expect(page).to have_no_css('#meeting_minutes_text')
- expect(page).to have_css('h2', text: 'Minutes')
+ expect(page).to have_no_css("h2", text: "Agenda")
+ expect(page).to have_no_css("#meeting_minutes_text")
+ expect(page).to have_css("h2", text: "Minutes")
end
- context 'and edit permissions' do
+ context "and edit permissions" do
let(:permissions) { %i[view_meetings create_meeting_minutes] }
let(:field) do
TextEditorField.new(page,
- '',
- selector: test_selector('op-meeting--meeting_minutes'))
+ "",
+ selector: test_selector("op-meeting--meeting_minutes"))
end
- it 'can edit the minutes' do
+ it "can edit the minutes" do
visit meeting_path(meeting)
- field.set_value('This is what we talked about')
+ field.set_value("This is what we talked about")
- click_button 'Save'
+ click_button "Save"
expect(page)
- .to have_css('.op-uc-container',
- text: 'This is what we talked about')
+ .to have_css(".op-uc-container",
+ text: "This is what we talked about")
end
end
end
diff --git a/modules/meeting/spec/features/structured_meetings/attachment_upload_spec.rb b/modules/meeting/spec/features/structured_meetings/attachment_upload_spec.rb
index a1cad1c3e48b..6861e51649d9 100644
--- a/modules/meeting/spec/features/structured_meetings/attachment_upload_spec.rb
+++ b/modules/meeting/spec/features/structured_meetings/attachment_upload_spec.rb
@@ -26,19 +26,19 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/page_objects/notification'
-require_relative '../../support/pages/structured_meeting/show'
+require "spec_helper"
+require "features/page_objects/notification"
+require_relative "../../support/pages/structured_meeting/show"
-RSpec.describe 'Upload attachment to meetings', :js do
+RSpec.describe "Upload attachment to meetings", :js do
let(:user) do
create(:user,
member_with_permissions: { project => %i[view_meetings edit_meetings manage_agendas] })
end
let(:project) { create(:project) }
let(:attachments) { Components::Attachments.new }
- let(:image_fixture) { UploadedFile.load_from('spec/fixtures/files/image.png') }
- let(:editor) { Components::WysiwygEditor.new '#content', 'opce-ckeditor-augmented-textarea' }
+ let(:image_fixture) { UploadedFile.load_from("spec/fixtures/files/image.png") }
+ let(:editor) { Components::WysiwygEditor.new "#content", "opce-ckeditor-augmented-textarea" }
let(:wiki_page_content) { project.wiki.pages.first.text }
let(:meeting) { create(:structured_meeting, project: project)}
@@ -48,22 +48,22 @@
login_as(user)
end
- it 'can upload an image to new and existing meeting agenda item via drag & drop in editor' do
+ it "can upload an image to new and existing meeting agenda item via drag & drop in editor" do
show_page.visit!
show_page.add_agenda_item(save: false) do
- click_link_or_button 'Notes'
+ click_link_or_button "Notes"
end
# adding an image
- editor.drag_attachment image_fixture.path, 'Image uploaded the first time'
+ editor.drag_attachment image_fixture.path, "Image uploaded the first time"
- editor.attachments_list.expect_attached('image.png')
+ editor.attachments_list.expect_attached("image.png")
editor.wait_until_upload_progress_toaster_cleared
- click_link_or_button 'Save'
- expect(page).to have_css('#meeting-agenda-items-list-component img', count: 1)
- expect(page).to have_content('Image uploaded the first time')
- editor.attachments_list.expect_attached('image.png')
+ click_link_or_button "Save"
+ expect(page).to have_css("#meeting-agenda-items-list-component img", count: 1)
+ expect(page).to have_content("Image uploaded the first time")
+ editor.attachments_list.expect_attached("image.png")
end
end
diff --git a/modules/meeting/spec/features/structured_meetings/mobile_structure_meeting_spec.rb b/modules/meeting/spec/features/structured_meetings/mobile_structure_meeting_spec.rb
index f951b91ba4c8..780c4d883fd8 100644
--- a/modules/meeting/spec/features/structured_meetings/mobile_structure_meeting_spec.rb
+++ b/modules/meeting/spec/features/structured_meetings/mobile_structure_meeting_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../../support/pages/structured_meeting//mobile/show'
+require_relative "../../support/pages/structured_meeting//mobile/show"
-RSpec.describe 'Structured meetings CRUD',
+RSpec.describe "Structured meetings CRUD",
:js,
:with_cuprite do
include Components::Autocompleter::NgSelectAutocompleteHelpers
@@ -38,22 +38,22 @@
shared_let(:project) { create(:project, enabled_module_names: %w[meetings work_package_tracking]) }
shared_let(:user) do
create(:user,
- lastname: 'First',
+ lastname: "First",
member_with_permissions: { project => %i[view_meetings create_meetings edit_meetings delete_meetings manage_agendas
close_meeting_agendas view_work_packages] }).tap do |u|
- u.pref[:time_zone] = 'utc'
+ u.pref[:time_zone] = "utc"
u.save!
end
end
shared_let(:other_user) do
create(:user,
- lastname: 'Second',
+ lastname: "Second",
member_with_permissions: { project => %i[view_meetings view_work_packages] })
end
shared_let(:no_member_user) do
create(:user,
- lastname: 'Third')
+ lastname: "Third")
end
shared_let(:meeting) do
@@ -63,14 +63,14 @@
let(:current_user) { user }
let(:show_page) { Pages::StructuredMeeting::Mobile::Show.new(StructuredMeeting.order(id: :asc).last) }
- include_context 'with mobile screen size'
+ include_context "with mobile screen size"
before do
login_as current_user
show_page.visit!
end
- it 'can edit participants of a structured meeting' do
+ it "can edit participants of a structured meeting" do
expect(page).to have_current_path(show_page.path)
show_page.expect_participants(count: 1)
@@ -79,10 +79,10 @@
show_page.expect_participant(user, invited: true, attended: false)
show_page.expect_participant(other_user, invited: false, attended: false)
show_page.expect_available_participants(count: 2)
- expect(page).to have_button('Save')
+ expect(page).to have_button("Save")
check(id: "checkbox_invited_#{other_user.id}")
- click_button('Save')
+ click_button("Save")
end
show_page.expect_participants(count: 2)
@@ -95,7 +95,7 @@
show_page.expect_participant(user, invited: true, attended: false, editable: false)
show_page.expect_participant(other_user, invited: true, attended: false, editable: false)
show_page.expect_available_participants(count: 2)
- expect(page).to have_no_button('Save')
+ expect(page).to have_no_button("Save")
end
show_page.close_dialog
@@ -110,7 +110,7 @@
show_page.expect_participant(user, invited: true, attended: false, editable: false)
show_page.expect_participant(other_user, invited: true, attended: false, editable: false)
show_page.expect_available_participants(count: 2)
- expect(page).to have_no_button('Save')
+ expect(page).to have_no_button("Save")
end
end
end
diff --git a/modules/meeting/spec/features/structured_meetings/structured_meeting_crud_spec.rb b/modules/meeting/spec/features/structured_meetings/structured_meeting_crud_spec.rb
index fb33994db521..a7c9f9d8f86f 100644
--- a/modules/meeting/spec/features/structured_meetings/structured_meeting_crud_spec.rb
+++ b/modules/meeting/spec/features/structured_meetings/structured_meeting_crud_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../../support/pages/meetings/new'
-require_relative '../../support/pages/structured_meeting/show'
+require_relative "../../support/pages/meetings/new"
+require_relative "../../support/pages/structured_meeting/show"
-RSpec.describe 'Structured meetings CRUD',
+RSpec.describe "Structured meetings CRUD",
:js,
:with_cuprite do
include Components::Autocompleter::NgSelectAutocompleteHelpers
@@ -39,25 +39,25 @@
shared_let(:project) { create(:project, enabled_module_names: %w[meetings work_package_tracking]) }
shared_let(:user) do
create(:user,
- lastname: 'First',
+ lastname: "First",
member_with_permissions: { project => %i[view_meetings create_meetings edit_meetings delete_meetings manage_agendas
view_work_packages] }).tap do |u|
- u.pref[:time_zone] = 'utc'
+ u.pref[:time_zone] = "utc"
u.save!
end
end
shared_let(:other_user) do
create(:user,
- lastname: 'Second',
+ lastname: "Second",
member_with_permissions: { project => %i[view_meetings view_work_packages] })
end
shared_let(:no_member_user) do
create(:user,
- lastname: 'Third')
+ lastname: "Third")
end
shared_let(:work_package) do
- create(:work_package, project:, subject: 'Important task')
+ create(:work_package, project:, subject: "Important task")
end
let(:current_user) { user }
@@ -69,80 +69,80 @@
login_as current_user
new_page.visit!
expect(page).to have_current_path(new_page.path)
- new_page.set_title 'Some title'
- new_page.set_type 'Dynamic'
+ new_page.set_title "Some title"
+ new_page.set_type "Dynamic"
- new_page.set_start_date '2013-03-28'
- new_page.set_start_time '13:30'
- new_page.set_duration '1.5'
+ new_page.set_start_date "2013-03-28"
+ new_page.set_start_time "13:30"
+ new_page.set_duration "1.5"
new_page.invite(other_user)
new_page.click_create
end
- it 'can create a structured meeting and add agenda items' do
- show_page.expect_toast(message: 'Successful creation')
+ it "can create a structured meeting and add agenda items" do
+ show_page.expect_toast(message: "Successful creation")
# Can add and edit a single item
show_page.add_agenda_item do
- fill_in 'Title', with: 'My agenda item'
- fill_in 'Duration (min)', with: '25'
+ fill_in "Title", with: "My agenda item"
+ fill_in "Duration (min)", with: "25"
end
- show_page.expect_agenda_item title: 'My agenda item'
+ show_page.expect_agenda_item title: "My agenda item"
show_page.cancel_add_form
- item = MeetingAgendaItem.find_by(title: 'My agenda item')
+ item = MeetingAgendaItem.find_by(title: "My agenda item")
show_page.edit_agenda_item(item) do
- fill_in 'Title', with: 'Updated title'
- click_button 'Save'
+ fill_in "Title", with: "Updated title"
+ click_button "Save"
end
- show_page.expect_no_agenda_item title: 'My agenda item'
+ show_page.expect_no_agenda_item title: "My agenda item"
# Can add multiple items
show_page.add_agenda_item do
- fill_in 'Title', with: 'First'
+ fill_in "Title", with: "First"
end
- show_page.expect_agenda_item title: 'Updated title'
- show_page.expect_agenda_item title: 'First'
+ show_page.expect_agenda_item title: "Updated title"
+ show_page.expect_agenda_item title: "First"
show_page.in_agenda_form do
- fill_in 'Title', with: 'Second'
- click_button 'Save'
+ fill_in "Title", with: "Second"
+ click_button "Save"
end
- show_page.expect_agenda_item title: 'Updated title'
- show_page.expect_agenda_item title: 'First'
- show_page.expect_agenda_item title: 'Second'
+ show_page.expect_agenda_item title: "Updated title"
+ show_page.expect_agenda_item title: "First"
+ show_page.expect_agenda_item title: "Second"
# Can reorder
- show_page.assert_agenda_order! 'Updated title', 'First', 'Second'
+ show_page.assert_agenda_order! "Updated title", "First", "Second"
- second = MeetingAgendaItem.find_by!(title: 'Second')
+ second = MeetingAgendaItem.find_by!(title: "Second")
show_page.select_action(second, I18n.t(:label_sort_higher))
- show_page.assert_agenda_order! 'Updated title', 'Second', 'First'
+ show_page.assert_agenda_order! "Updated title", "Second", "First"
- first = MeetingAgendaItem.find_by!(title: 'First')
+ first = MeetingAgendaItem.find_by!(title: "First")
show_page.select_action(first, I18n.t(:label_sort_highest))
- show_page.assert_agenda_order! 'First', 'Updated title', 'Second'
+ show_page.assert_agenda_order! "First", "Updated title", "Second"
# Can edit and cancel with escape
show_page.edit_agenda_item(first) do
- find_field('Title').send_keys :escape
+ find_field("Title").send_keys :escape
end
show_page.expect_item_edit_form(first, visible: false)
# Can remove
show_page.remove_agenda_item first
- show_page.assert_agenda_order! 'Updated title', 'Second'
+ show_page.assert_agenda_order! "Updated title", "Second"
show_page.cancel_add_form
# Can link work packages
show_page.add_agenda_item(type: WorkPackage) do
- select_autocomplete(find_test_selector('op-agenda-items-wp-autocomplete'),
- query: 'task',
- results_selector: 'body')
+ select_autocomplete(find_test_selector("op-agenda-items-wp-autocomplete"),
+ query: "task",
+ results_selector: "body")
end
show_page.expect_agenda_link work_package
@@ -152,7 +152,7 @@
# Can edit and validate a work package item
show_page.edit_agenda_item(wp_item) do
show_page.clear_item_edit_work_package_title
- click_button 'Save'
+ click_button "Save"
end
show_page.expect_item_edit_field_error(wp_item, "Work package can't be blank.")
@@ -160,54 +160,54 @@
# Keeping the editing state of an agenda item while modifying other items
show_page.edit_agenda_item(second) do
- fill_in 'Title', with: 'Second edited'
+ fill_in "Title", with: "Second edited"
end
show_page.select_action(item, I18n.t(:label_sort_lowest))
show_page.cancel_add_form
show_page.add_agenda_item do
- fill_in 'Title', with: 'My agenda item'
- fill_in 'Duration in minutes', with: '25'
+ fill_in "Title", with: "My agenda item"
+ fill_in "Duration in minutes", with: "25"
end
- show_page.expect_agenda_item title: 'My agenda item'
- my_item = MeetingAgendaItem.find_by!(title: 'My agenda item')
+ show_page.expect_agenda_item title: "My agenda item"
+ my_item = MeetingAgendaItem.find_by!(title: "My agenda item")
show_page.edit_agenda_item(my_item) do
- fill_in 'Title', with: 'My agenda item edited'
- click_button 'Save'
+ fill_in "Title", with: "My agenda item edited"
+ click_button "Save"
end
show_page.remove_agenda_item my_item
show_page.expect_item_edit_form(second)
- show_page.expect_item_edit_title(second, 'Second edited')
+ show_page.expect_item_edit_title(second, "Second edited")
show_page.cancel_edit_form(second)
# user can see actions
- expect(page).to have_css('#meeting-agenda-items-new-button-component')
- expect(page).to have_test_selector('op-meeting-agenda-actions', count: 3)
+ expect(page).to have_css("#meeting-agenda-items-new-button-component")
+ expect(page).to have_test_selector("op-meeting-agenda-actions", count: 3)
# other_use can view, but not edit
login_as other_user
show_page.visit!
- expect(page).to have_no_css('#meeting-agenda-items-new-button-component')
- expect(page).not_to have_test_selector('op-meeting-agenda-actions')
+ expect(page).to have_no_css("#meeting-agenda-items-new-button-component")
+ expect(page).not_to have_test_selector("op-meeting-agenda-actions")
end
- it 'can delete a meeting and get back to the index page' do
- click_button('op-meetings-header-action-trigger')
+ it "can delete a meeting and get back to the index page" do
+ click_button("op-meetings-header-action-trigger")
- accept_confirm(I18n.t('text_are_you_sure')) do
- click_button 'Delete meeting'
+ accept_confirm(I18n.t("text_are_you_sure")) do
+ click_button "Delete meeting"
end
expect(page).to have_current_path project_meetings_path(project)
end
- context 'when exporting as ICS' do
+ context "when exporting as ICS" do
before do
@download_list = DownloadList.new
end
@@ -218,8 +218,8 @@
subject { @download_list.refresh_from(page).latest_download.to_s }
- it 'can export the meeting as ICS' do
- click_button('op-meetings-header-action-trigger')
+ it "can export the meeting as ICS" do
+ click_button("op-meetings-header-action-trigger")
click_link I18n.t(:label_icalendar_download)
@@ -227,73 +227,73 @@
end
end
- it 'shows an error toast trying to update an outdated item' do
- show_page.expect_toast(message: 'Successful creation')
+ it "shows an error toast trying to update an outdated item" do
+ show_page.expect_toast(message: "Successful creation")
# Can add and edit a single item
show_page.add_agenda_item do
- fill_in 'Title', with: 'My agenda item'
- fill_in 'Duration (min)', with: '25'
+ fill_in "Title", with: "My agenda item"
+ fill_in "Duration (min)", with: "25"
end
- show_page.expect_agenda_item title: 'My agenda item'
+ show_page.expect_agenda_item title: "My agenda item"
show_page.cancel_add_form
- item = MeetingAgendaItem.find_by!(title: 'My agenda item')
+ item = MeetingAgendaItem.find_by!(title: "My agenda item")
show_page.edit_agenda_item(item) do
# Side effect: update the item
- item.update!(title: 'Updated title')
+ item.update!(title: "Updated title")
- fill_in 'Title', with: 'My agenda item edited'
- click_button 'Save'
+ fill_in "Title", with: "My agenda item edited"
+ click_button "Save"
end
- expect(page).to have_css('.flash', text: I18n.t('activerecord.errors.messages.error_conflict'))
+ expect(page).to have_css(".flash", text: I18n.t("activerecord.errors.messages.error_conflict"))
end
- it 'can copy the meeting' do
- show_page.expect_toast(message: 'Successful creation')
+ it "can copy the meeting" do
+ show_page.expect_toast(message: "Successful creation")
# Can add and edit a single item
show_page.add_agenda_item do
- fill_in 'Title', with: 'My agenda item'
- fill_in 'Duration (min)', with: '25'
+ fill_in "Title", with: "My agenda item"
+ fill_in "Duration (min)", with: "25"
end
- show_page.expect_agenda_item title: 'My agenda item'
+ show_page.expect_agenda_item title: "My agenda item"
show_page.cancel_add_form
- click_button('op-meetings-header-action-trigger')
- click_link 'Copy'
+ click_button("op-meetings-header-action-trigger")
+ click_link "Copy"
expect(page).to have_current_path "/meetings/#{meeting.id}/copy"
- click_button 'Create'
+ click_button "Create"
- show_page.expect_agenda_item title: 'My agenda item'
+ show_page.expect_agenda_item title: "My agenda item"
new_meeting = StructuredMeeting.reorder(id: :asc).last
expect(page).to have_current_path "/meetings/#{new_meeting.id}"
end
- context 'with a work package reference to another' do
+ context "with a work package reference to another" do
let!(:meeting) { create(:structured_meeting, project:, author: current_user) }
let!(:other_project) { create(:project) }
- let!(:other_wp) { create(:work_package, project: other_project, author: current_user, subject: 'Private task') }
+ let!(:other_wp) { create(:work_package, project: other_project, author: current_user, subject: "Private task") }
let!(:role) { create(:project_role, permissions: %w[view_work_packages]) }
let!(:membership) { create(:member, principal: user, project: other_project, roles: [role]) }
let!(:agenda_item) { create(:wp_meeting_agenda_item, meeting:, author: current_user, work_package: other_wp) }
let(:show_page) { Pages::StructuredMeeting::Show.new(meeting) }
- it 'shows correctly for author, but returns an unresolved reference for the second user' do
+ it "shows correctly for author, but returns an unresolved reference for the second user" do
show_page.visit!
show_page.expect_agenda_link agenda_item
- expect(page).to have_text 'Private task'
+ expect(page).to have_text "Private task"
login_as other_user
show_page.visit!
show_page.expect_undisclosed_agenda_link agenda_item
- expect(page).to have_no_text 'Private task'
+ expect(page).to have_no_text "Private task"
end
end
end
diff --git a/modules/meeting/spec/features/structured_meetings/work_package_meetings_tab_spec.rb b/modules/meeting/spec/features/structured_meetings/work_package_meetings_tab_spec.rb
index f817188f8ccf..0f1fb07fb763 100644
--- a/modules/meeting/spec/features/structured_meetings/work_package_meetings_tab_spec.rb
+++ b/modules/meeting/spec/features/structured_meetings/work_package_meetings_tab_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../../support/pages/work_package_meetings_tab'
+require "spec_helper"
+require_relative "../../support/pages/work_package_meetings_tab"
-RSpec.describe 'Open the Meetings tab', :js do
+RSpec.describe "Open the Meetings tab", :js do
shared_let(:project) { create(:project) }
- shared_let(:work_package) { create(:work_package, project:, subject: 'A test work_package') }
+ shared_let(:work_package) { create(:work_package, project:, subject: "A test work_package") }
let(:user) do
create(:user,
@@ -47,33 +47,33 @@
let(:meetings_tab) { Pages::MeetingsTab.new(work_package.id) }
let(:tabs) { Components::WorkPackages::Tabs.new(work_package) }
- let(:meetings_tab_element) { find('.op-tab-row--link_selected', text: 'MEETINGS') }
+ let(:meetings_tab_element) { find(".op-tab-row--link_selected", text: "MEETINGS") }
shared_context "a meetings tab" do
before do
login_as(user)
end
- it 'shows the meetings tab when the user is allowed to see it' do
+ it "shows the meetings tab when the user is allowed to see it" do
work_package_page.visit!
- work_package_page.switch_to_tab(tab: 'meetings')
+ work_package_page.switch_to_tab(tab: "meetings")
meetings_tab.expect_tab_content_rendered
end
- context 'when the user does not have the permissions to see the meetings tab' do
+ context "when the user does not have the permissions to see the meetings tab" do
let(:role) do
create(:project_role,
permissions: %i(view_work_packages))
end
- it 'does not show the meetings tab' do
+ it "does not show the meetings tab" do
work_package_page.visit!
meetings_tab.expect_tab_not_present
end
- context 'when the user has permission in another project' do
+ context "when the user has permission in another project" do
let(:other_project) { create(:project, enabled_module_names: %w[meetings]) }
let(:user) do
@@ -84,7 +84,7 @@
})
end
- it 'does show the tab' do
+ it "does show the tab" do
work_package_page.visit!
meetings_tab.expect_tab_present
@@ -92,7 +92,7 @@
end
end
- context 'when the user has the permission to see the tab, but the work package is linked in two projects' do
+ context "when the user has the permission to see the tab, but the work package is linked in two projects" do
let(:other_project) { create(:project, enabled_module_names: %w[meetings]) }
let!(:visible_meeting) { create(:structured_meeting, project:) }
let!(:invisible_meeting) { create(:structured_meeting, project: other_project) }
@@ -110,7 +110,7 @@
permissions: %i(view_work_packages view_meetings))
end
- it 'shows the one visible meeting' do
+ it "shows the one visible meeting" do
work_package_page.visit!
switch_to_meetings_tab
@@ -128,19 +128,19 @@
end
end
- context 'when the meetings module is not enabled for the project' do
+ context "when the meetings module is not enabled for the project" do
before do
- project.enabled_module_names = ['work_package_tracking']
+ project.enabled_module_names = ["work_package_tracking"]
project.save!
end
- it 'does not show the meetings tab' do
+ it "does not show the meetings tab" do
work_package_page.visit!
meetings_tab.expect_tab_not_present
end
- context 'when the user has permission to view in another project' do
+ context "when the user has permission to view in another project" do
let(:other_project) { create(:project, enabled_module_names: %w[meetings]) }
let(:user) do
@@ -151,7 +151,7 @@
})
end
- it 'does show the tab, but does not show the button' do
+ it "does show the tab, but does not show the button" do
work_package_page.visit!
meetings_tab.expect_tab_present
@@ -160,7 +160,7 @@
end
end
- context 'when the user has permission to manage in another project' do
+ context "when the user has permission to manage in another project" do
let(:other_project) { create(:project, enabled_module_names: %w[meetings]) }
let(:user) do
@@ -171,7 +171,7 @@
})
end
- it 'does show the tab and shows the add button' do
+ it "does show the tab and shows the add button" do
work_package_page.visit!
meetings_tab.expect_tab_present
@@ -181,30 +181,30 @@
end
end
- context 'when the work_package is not referenced in an upcoming meeting' do
- it 'shows an empty message within the upcoming meetings section' do
+ context "when the work_package is not referenced in an upcoming meeting" do
+ it "shows an empty message within the upcoming meetings section" do
work_package_page.visit!
switch_to_meetings_tab
meetings_tab.expect_upcoming_counter_to_be(0)
- expect(page).to have_content('This work package is not scheduled in an upcoming meeting agenda yet.')
+ expect(page).to have_content("This work package is not scheduled in an upcoming meeting agenda yet.")
end
end
- context 'when the work_package is not referenced in a past meeting' do
- it 'shows an empty message within the past meetings section' do
+ context "when the work_package is not referenced in a past meeting" do
+ it "shows an empty message within the past meetings section" do
work_package_page.visit!
switch_to_meetings_tab
meetings_tab.expect_past_counter_to_be(0)
meetings_tab.switch_to_past_meetings_section
- expect(page).to have_content('This work package was not mentioned in a past meeting.')
+ expect(page).to have_content("This work package was not mentioned in a past meeting.")
end
end
- context 'when the work_package is already referenced in upcoming meetings' do
+ context "when the work_package is already referenced in upcoming meetings" do
let!(:first_meeting) { create(:structured_meeting, project:) }
let!(:second_meeting) { create(:structured_meeting, project:) }
@@ -220,7 +220,7 @@
notes: "A very important note in the second meeting!")
end
- it 'shows the meeting agenda items in the upcoming meetings section grouped by meeting' do
+ it "shows the meeting agenda items in the upcoming meetings section grouped by meeting" do
work_package_page.visit!
switch_to_meetings_tab
@@ -240,7 +240,7 @@
end
end
- context 'when the work_package was already referenced in past meetings' do
+ context "when the work_package was already referenced in past meetings" do
let!(:first_past_meeting) { create(:structured_meeting, project:, start_time: Date.yesterday - 10.hours) }
let!(:second_past_meeting) { create(:structured_meeting, project:, start_time: Date.yesterday - 10.hours) }
@@ -256,7 +256,7 @@
notes: "A very important note in the second meeting!")
end
- it 'shows the meeting agenda items in the past meetings section grouped by meeting' do
+ it "shows the meeting agenda items in the past meetings section grouped by meeting" do
work_package_page.visit!
switch_to_meetings_tab
@@ -278,15 +278,15 @@
end
end
- context 'when user is allowed to edit meetings' do
- it 'shows the add to meeting button' do
+ context "when user is allowed to edit meetings" do
+ it "shows the add to meeting button" do
work_package_page.visit!
switch_to_meetings_tab
meetings_tab.expect_add_to_meeting_button_present
end
- it 'opens the add to meeting dialog when clicking the add to meeting button' do
+ it "opens the add to meeting dialog when clicking the add to meeting button" do
work_package_page.visit!
switch_to_meetings_tab
@@ -295,16 +295,16 @@
meetings_tab.expect_add_to_meeting_dialog_shown
end
- context 'when open, upcoming meetings are visible for the user' do
+ context "when open, upcoming meetings are visible for the user" do
shared_let(:past_meeting) { create(:structured_meeting, project:, start_time: Date.yesterday - 10.hours) }
shared_let(:first_upcoming_meeting) { create(:structured_meeting, project:) }
shared_let(:second_upcoming_meeting) { create(:structured_meeting, project:) }
shared_let(:closed_upcoming_meeting) { create(:structured_meeting, project:, state: :closed) }
shared_let(:ongoing_meeting) do
- create(:structured_meeting, title: 'Ongoing', project:, start_time: 1.hour.ago, duration: 4.0)
+ create(:structured_meeting, title: "Ongoing", project:, start_time: 1.hour.ago, duration: 4.0)
end
- it 'enables the user to add the work package to multiple open, upcoming meetings' do
+ it "enables the user to add the work package to multiple open, upcoming meetings" do
work_package_page.visit!
switch_to_meetings_tab
@@ -314,30 +314,30 @@
meetings_tab.fill_and_submit_meeting_dialog(
first_upcoming_meeting,
- 'A very important note added from the meetings tab to the first meeting!'
+ "A very important note added from the meetings tab to the first meeting!"
)
meetings_tab.expect_upcoming_counter_to_be(1)
page.within_test_selector("op-meeting-container-#{first_upcoming_meeting.id}") do
- expect(page).to have_content('A very important note added from the meetings tab to the first meeting!')
+ expect(page).to have_content("A very important note added from the meetings tab to the first meeting!")
end
meetings_tab.open_add_to_meeting_dialog
meetings_tab.fill_and_submit_meeting_dialog(
second_upcoming_meeting,
- 'A very important note added from the meetings tab to the second meeting!'
+ "A very important note added from the meetings tab to the second meeting!"
)
meetings_tab.expect_upcoming_counter_to_be(2)
page.within_test_selector("op-meeting-container-#{second_upcoming_meeting.id}") do
- expect(page).to have_content('A very important note added from the meetings tab to the second meeting!')
+ expect(page).to have_content("A very important note added from the meetings tab to the second meeting!")
end
end
- it 'allows the user to select ongoing meetings' do
+ it "allows the user to select ongoing meetings" do
work_package_page.visit!
switch_to_meetings_tab
@@ -345,50 +345,50 @@
meetings_tab.fill_and_submit_meeting_dialog(
ongoing_meeting,
- 'Some notes to be added'
+ "Some notes to be added"
)
meetings_tab.expect_upcoming_counter_to_be(1)
page.within_test_selector("op-meeting-container-#{ongoing_meeting.id}") do
- expect(page).to have_content('Some notes to be added')
+ expect(page).to have_content("Some notes to be added")
end
end
- it 'does not enable the user to select a past meeting' do
+ it "does not enable the user to select a past meeting" do
work_package_page.visit!
switch_to_meetings_tab
meetings_tab.open_add_to_meeting_dialog
- fill_in('meeting_agenda_item_meeting_id', with: past_meeting.title)
- expect(page).to have_no_css('.ng-option-marked', text: past_meeting.title)
+ fill_in("meeting_agenda_item_meeting_id", with: past_meeting.title)
+ expect(page).to have_no_css(".ng-option-marked", text: past_meeting.title)
end
- it 'does not enable the user to select a closed, upcoming meeting' do
+ it "does not enable the user to select a closed, upcoming meeting" do
work_package_page.visit!
switch_to_meetings_tab
meetings_tab.open_add_to_meeting_dialog
- fill_in('meeting_agenda_item_meeting_id', with: closed_upcoming_meeting.title)
- expect(page).to have_no_css('.ng-option-marked', text: closed_upcoming_meeting.title)
+ fill_in("meeting_agenda_item_meeting_id", with: closed_upcoming_meeting.title)
+ expect(page).to have_no_css(".ng-option-marked", text: closed_upcoming_meeting.title)
end
- it 'requires a meeting to be selected' do
+ it "requires a meeting to be selected" do
work_package_page.visit!
switch_to_meetings_tab
meetings_tab.open_add_to_meeting_dialog
- click_button('Save')
+ click_button("Save")
- expect(page).to have_content('Meeting can\'t be blank')
+ expect(page).to have_content("Meeting can't be blank")
end
end
end
- context 'when user is not allowed to edit meetings' do
+ context "when user is not allowed to edit meetings" do
let(:restricted_role) do
create(:project_role,
permissions: %i(view_work_packages
@@ -399,7 +399,7 @@
member_with_roles: { project => restricted_role })
end
- it 'does not show the add to meeting button' do
+ it "does not show the add to meeting button" do
work_package_page.visit!
switch_to_meetings_tab
@@ -408,20 +408,20 @@
end
end
- describe 'work package full view' do
+ describe "work package full view" do
let(:work_package_page) { Pages::FullWorkPackage.new(work_package) }
- it_behaves_like 'a meetings tab'
+ it_behaves_like "a meetings tab"
end
- describe 'work package split view' do
+ describe "work package split view" do
let(:work_package_page) { Pages::SplitWorkPackage.new(work_package) }
- it_behaves_like 'a meetings tab'
+ it_behaves_like "a meetings tab"
end
def switch_to_meetings_tab
- work_package_page.switch_to_tab(tab: 'meetings')
+ work_package_page.switch_to_tab(tab: "meetings")
meetings_tab.expect_tab_content_rendered # wait for the tab to be rendered
end
end
diff --git a/modules/meeting/spec/lib/api/v3/meetings/meeting_representer_spec.rb b/modules/meeting/spec/lib/api/v3/meetings/meeting_representer_spec.rb
index bf376f6b1932..1a3a7ed3858f 100644
--- a/modules/meeting/spec/lib/api/v3/meetings/meeting_representer_spec.rb
+++ b/modules/meeting/spec/lib/api/v3/meetings/meeting_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Meetings::MeetingRepresenter do
include API::V3::Utilities::PathHelper
@@ -42,59 +42,59 @@
let(:meeting) do
create(:meeting,
author: user,
- location: 'https://foo.example.com',
+ location: "https://foo.example.com",
project:)
end
let(:representer) { described_class.new(meeting, current_user: user) }
- describe 'generation' do
+ describe "generation" do
subject(:generated) { representer.to_json }
- describe 'self link' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "self link" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.meeting(meeting.id) }
let(:title) { meeting.title }
end
end
- it_behaves_like 'has an untitled link' do
+ it_behaves_like "has an untitled link" do
let(:link) { :attachments }
let(:href) { api_v3_paths.attachments_by_meeting meeting.id }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'author' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "author" }
let(:href) { api_v3_paths.user(user.id) }
let(:title) { user.name }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'project' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "project" }
let(:href) { api_v3_paths.project(project.id) }
let(:title) { project.name }
end
- it_behaves_like 'has an untitled action link' do
+ it_behaves_like "has an untitled action link" do
let(:link) { :addAttachment }
let(:href) { api_v3_paths.attachments_by_meeting meeting.id }
let(:method) { :post }
let(:permission) { :edit_meetings }
end
- it 'describes the object', :aggregate_failures do
- expect(subject).to be_json_eql('Meeting'.to_json).at_path('_type')
- expect(subject).to be_json_eql(meeting.id.to_json).at_path('id')
- expect(subject).to be_json_eql(meeting.title.to_json).at_path('title')
- expect(subject).to be_json_eql(meeting.lock_version.to_json).at_path('lockVersion')
- expect(subject).to be_json_eql(meeting.start_time.utc.iso8601(3).to_json).at_path('startTime')
- expect(subject).to be_json_eql(meeting.end_time.utc.iso8601(3).to_json).at_path('endTime')
- expect(subject).to be_json_eql(meeting.duration.to_json).at_path('duration')
- expect(subject).to be_json_eql(meeting.location.to_json).at_path('location')
+ it "describes the object", :aggregate_failures do
+ expect(subject).to be_json_eql("Meeting".to_json).at_path("_type")
+ expect(subject).to be_json_eql(meeting.id.to_json).at_path("id")
+ expect(subject).to be_json_eql(meeting.title.to_json).at_path("title")
+ expect(subject).to be_json_eql(meeting.lock_version.to_json).at_path("lockVersion")
+ expect(subject).to be_json_eql(meeting.start_time.utc.iso8601(3).to_json).at_path("startTime")
+ expect(subject).to be_json_eql(meeting.end_time.utc.iso8601(3).to_json).at_path("endTime")
+ expect(subject).to be_json_eql(meeting.duration.to_json).at_path("duration")
+ expect(subject).to be_json_eql(meeting.location.to_json).at_path("location")
- expect(subject).to be_json_eql(meeting.created_at.utc.iso8601(3).to_json).at_path('createdAt')
- expect(subject).to be_json_eql(meeting.updated_at.utc.iso8601(3).to_json).at_path('updatedAt')
+ expect(subject).to be_json_eql(meeting.created_at.utc.iso8601(3).to_json).at_path("createdAt")
+ expect(subject).to be_json_eql(meeting.updated_at.utc.iso8601(3).to_json).at_path("updatedAt")
end
end
end
diff --git a/modules/meeting/spec/lib/api/v3/utilities/path_helper_spec.rb b/modules/meeting/spec/lib/api/v3/utilities/path_helper_spec.rb
index 7f555949b947..920b94ef28ae 100644
--- a/modules/meeting/spec/lib/api/v3/utilities/path_helper_spec.rb
+++ b/modules/meeting/spec/lib/api/v3/utilities/path_helper_spec.rb
@@ -26,20 +26,20 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Utilities::PathHelper do
let(:helper) { Class.new.tap { |c| c.extend(described_class) }.api_v3_paths }
- describe '#meeting' do
+ describe "#meeting" do
subject { helper.meeting 42 }
- it { is_expected.to eql('/api/v3/meetings/42') }
+ it { is_expected.to eql("/api/v3/meetings/42") }
end
- describe '#attachments_by_meeting' do
+ describe "#attachments_by_meeting" do
subject { helper.attachments_by_meeting 42 }
- it { is_expected.to eql('/api/v3/meetings/42/attachments') }
+ it { is_expected.to eql("/api/v3/meetings/42/attachments") }
end
end
diff --git a/modules/meeting/spec/lib/open_project/markdown_formatting_spec.rb b/modules/meeting/spec/lib/open_project/markdown_formatting_spec.rb
index 65240c46440a..b885c0d6383c 100644
--- a/modules/meeting/spec/lib/open_project/markdown_formatting_spec.rb
+++ b/modules/meeting/spec/lib/open_project/markdown_formatting_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::TextFormatting,
- 'Meeting links' do
+ "Meeting links" do
include ActionView::Helpers::UrlHelper # soft-dependency
include ActionView::Context
include OpenProject::StaticRouting::UrlHelpers
@@ -43,7 +43,7 @@ def controller
end
shared_let(:meeting) do
- create(:meeting, project:, title: 'Monthly coordination')
+ create(:meeting, project:, title: "Monthly coordination")
end
subject do
@@ -64,7 +64,7 @@ def controller
TEXT
end
- context 'when visible' do
+ context "when visible" do
let(:role) { create(:project_role, permissions: %i[view_meetings view_project]) }
let(:user) { create(:user, member_with_roles: { project => role }) }
@@ -80,19 +80,19 @@ def controller
let(:meeting_link) do
link_to(
- 'Monthly coordination',
- { controller: '/meetings', action: 'show', id: meeting.id, only_path: true },
- class: 'meeting op-uc-link',
- target: '_top'
+ "Monthly coordination",
+ { controller: "/meetings", action: "show", id: meeting.id, only_path: true },
+ class: "meeting op-uc-link",
+ target: "_top"
)
end
- it 'renders the links' do
+ it "renders the links" do
expect(subject).to be_html_eql(expected)
end
end
- context 'when not visible' do
+ context "when not visible" do
let(:user) { create(:user) }
let(:expected) do
@@ -105,7 +105,7 @@ def controller
HTML
end
- it 'renders the raw text' do
+ it "renders the raw text" do
expect(subject).to be_html_eql(expected)
end
end
diff --git a/modules/meeting/spec/mailers/meeting_mailer_spec.rb b/modules/meeting/spec/mailers/meeting_mailer_spec.rb
index e50c7ee9607a..c7119eb91565 100644
--- a/modules/meeting/spec/mailers/meeting_mailer_spec.rb
+++ b/modules/meeting/spec/mailers/meeting_mailer_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative '../spec_helper'
+require_relative "../spec_helper"
RSpec.describe MeetingMailer do
shared_let(:role) { create(:project_role, permissions: [:view_meetings]) }
- shared_let(:project) { create(:project, name: 'My project') }
+ shared_let(:project) { create(:project, name: "My project") }
shared_let(:author) do
create(:user,
member_with_roles: { project => role },
- preferences: { time_zone: 'Europe/Berlin' })
+ preferences: { time_zone: "Europe/Berlin" })
end
shared_let(:watcher1) { create(:user, member_with_roles: { project => role }) }
shared_let(:watcher2) { create(:user, member_with_roles: { project => role }) }
@@ -56,7 +56,7 @@
meeting.save!
end
- describe 'invited' do
+ describe "invited" do
let(:mail) { described_class.invited(meeting, watcher1, author) }
# this is needed to call module functions from Redmine::I18n
let(:i18n) do
@@ -66,67 +66,67 @@
end
end
- it 'renders the headers' do
+ it "renders the headers" do
expect(mail.subject).to include(meeting.project.name)
expect(mail.subject).to include(meeting.title)
expect(mail.to).to contain_exactly(watcher1.mail)
expect(mail.from).to eq([Setting.mail_from])
end
- it 'renders the text body' do
+ it "renders the text body" do
User.execute_as(watcher1) do
check_meeting_mail_content mail.text_part.body
end
end
- it 'renders the html body' do
+ it "renders the html body" do
User.execute_as(watcher1) do
check_meeting_mail_content mail.html_part.body
end
end
- context 'with a recipient with another time zone' do
- let!(:preference) { create(:user_preference, user: watcher1, time_zone: 'Asia/Tokyo') }
+ context "with a recipient with another time zone" do
+ let!(:preference) { create(:user_preference, user: watcher1, time_zone: "Asia/Tokyo") }
- it 'renders the mail with the correcet locale' do
- expect(mail.text_part.body).to include('Tokyo')
- expect(mail.text_part.body).to include('GMT+09:00')
- expect(mail.html_part.body).to include('Tokyo')
- expect(mail.html_part.body).to include('GMT+09:00')
+ it "renders the mail with the correcet locale" do
+ expect(mail.text_part.body).to include("Tokyo")
+ expect(mail.text_part.body).to include("GMT+09:00")
+ expect(mail.html_part.body).to include("Tokyo")
+ expect(mail.html_part.body).to include("GMT+09:00")
expect(mail.to).to contain_exactly(watcher1.mail)
end
end
- context 'when the meeting time results in another date' do
+ context "when the meeting time results in another date" do
let(:meeting) do
create(:meeting,
author:,
project:,
- start_time: '2021-11-09T23:00:00 +0100'.to_datetime.utc)
+ start_time: "2021-11-09T23:00:00 +0100".to_datetime.utc)
end
- describe 'it renders november 9th for Berlin zone' do
+ describe "it renders november 9th for Berlin zone" do
let(:mail) { described_class.invited(meeting, author, author) }
- it 'renders the mail with the correct locale' do
- expect(mail.html_part.body).to include('11/09/2021 11:00 PM')
- expect(mail.html_part.body).to include('12:00 AM (GMT+01:00) Europe/Berlin')
- expect(mail.text_part.body).to include('11/09/2021 11:00 PM-12:00 AM (GMT+01:00) Europe/Berlin')
+ it "renders the mail with the correct locale" do
+ expect(mail.html_part.body).to include("11/09/2021 11:00 PM")
+ expect(mail.html_part.body).to include("12:00 AM (GMT+01:00) Europe/Berlin")
+ expect(mail.text_part.body).to include("11/09/2021 11:00 PM-12:00 AM (GMT+01:00) Europe/Berlin")
expect(mail.to).to contain_exactly(author.mail)
end
end
- describe 'it renders november 10th for Tokyo zone' do
- let!(:preference) { create(:user_preference, user: watcher1, time_zone: 'Asia/Tokyo') }
+ describe "it renders november 10th for Tokyo zone" do
+ let!(:preference) { create(:user_preference, user: watcher1, time_zone: "Asia/Tokyo") }
let(:mail) { described_class.invited(meeting, watcher1, author) }
- it 'renders the mail with the correct locale' do
- expect(mail.html_part.body).to include('11/10/2021 07:00 AM')
- expect(mail.html_part.body).to include('08:00 AM (GMT+09:00) Asia/Tokyo')
+ it "renders the mail with the correct locale" do
+ expect(mail.html_part.body).to include("11/10/2021 07:00 AM")
+ expect(mail.html_part.body).to include("08:00 AM (GMT+09:00) Asia/Tokyo")
- expect(mail.text_part.body).to include('11/10/2021 07:00 AM-08:00 AM (GMT+09:00) Asia/Tokyo')
+ expect(mail.text_part.body).to include("11/10/2021 07:00 AM-08:00 AM (GMT+09:00) Asia/Tokyo")
expect(mail.to).to contain_exactly(watcher1.mail)
end
@@ -134,114 +134,114 @@
end
end
- describe 'icalendar' do
+ describe "icalendar" do
let(:meeting) do
create(:meeting,
author:,
project:,
- title: 'Important meeting',
- location: 'https://example.com/meet/important-meeting',
+ title: "Important meeting",
+ location: "https://example.com/meet/important-meeting",
start_time: "2021-01-19T10:00:00Z".to_time(:utc),
duration: 1.0)
end
let(:mail) { described_class.icalendar_notification(meeting, author, author) }
- it 'renders the headers' do
+ it "renders the headers" do
expect(mail.subject).to include(meeting.project.name)
expect(mail.subject).to include(meeting.title)
expect(mail.to).to contain_exactly(author.mail)
expect(mail.from).to eq([Setting.mail_from])
end
- describe 'text body' do
+ describe "text body" do
subject(:body) { mail.text_part.body }
- it 'renders the text body' do
+ it "renders the text body" do
expect(body).to include(meeting.project.name)
expect(body).to include(meeting.title)
expect(body).to include(meeting.location)
- expect(body).to include('01/19/2021 11:00 AM-12:00 PM (GMT+01:00) Europe/Berlin')
+ expect(body).to include("01/19/2021 11:00 AM-12:00 PM (GMT+01:00) Europe/Berlin")
expect(body).to include(meeting.participants[0].name)
expect(body).to include(meeting.participants[1].name)
end
end
- describe 'renders the html body' do
+ describe "renders the html body" do
subject(:body) { mail.html_part.body }
- it 'renders the text body' do
+ it "renders the text body" do
expect(body).to include(meeting.project.name)
expect(body).to include(meeting.title)
expect(body).to include(meeting.location)
- expect(body).to include('01/19/2021 11:00 AM')
- expect(body).to include('12:00 PM (GMT+01:00) Europe/Berlin')
+ expect(body).to include("01/19/2021 11:00 AM")
+ expect(body).to include("12:00 PM (GMT+01:00) Europe/Berlin")
expect(body).to include(meeting.participants[0].name)
expect(body).to include(meeting.participants[1].name)
end
end
- describe 'renders the calendar entry' do
+ describe "renders the calendar entry" do
let(:ical) { mail.parts.detect { |x| !x.multipart? } }
let(:parsed) { Icalendar::Event.parse(ical.body.raw_source) }
let(:entry) { parsed.first }
- it 'renders the calendar entry' do
+ it "renders the calendar entry" do
expect(parsed).to be_a Array
expect(parsed.length).to eq 1
expect(entry.dtstart.utc).to eq meeting.start_time
expect(entry.dtend.utc).to eq meeting.start_time + 1.hour
- expect(entry.summary).to eq '[My project] Important meeting'
+ expect(entry.summary).to eq "[My project] Important meeting"
expect(entry.description).to eq "[My project] Meeting: Important meeting"
expect(entry.location).to eq(meeting.location.presence)
end
- it 'has the correct time matching the timezone' do
+ it "has the correct time matching the timezone" do
expect(entry.dtstart).to eq "2021-01-19T10:00:00Z".to_time(:utc).in_time_zone("Europe/Berlin")
expect(entry.dtend).to eq ("2021-01-19T10:00:00Z".to_time(:utc) + 1.hour).in_time_zone("Europe/Berlin")
end
end
- context 'with a recipient with another time zone' do
- let!(:preference) { create(:user_preference, user: watcher1, time_zone: 'Asia/Tokyo') }
+ context "with a recipient with another time zone" do
+ let!(:preference) { create(:user_preference, user: watcher1, time_zone: "Asia/Tokyo") }
let(:mail) { described_class.icalendar_notification(meeting, watcher1, author) }
- it 'renders the mail with the correct locale' do
- expect(mail.text_part.body).to include('01/19/2021 07:00 PM-08:00 PM (GMT+09:00) Asia/Tokyo')
- expect(mail.html_part.body).to include('01/19/2021 07:00 PM')
- expect(mail.html_part.body).to include('08:00 PM (GMT+09:00) Asia/Tokyo')
+ it "renders the mail with the correct locale" do
+ expect(mail.text_part.body).to include("01/19/2021 07:00 PM-08:00 PM (GMT+09:00) Asia/Tokyo")
+ expect(mail.html_part.body).to include("01/19/2021 07:00 PM")
+ expect(mail.html_part.body).to include("08:00 PM (GMT+09:00) Asia/Tokyo")
expect(mail.to).to contain_exactly(watcher1.mail)
end
end
- context 'when the meeting time results in another date' do
+ context "when the meeting time results in another date" do
let(:meeting) do
create(:meeting,
author:,
project:,
- start_time: '2021-11-09T23:00:00 +0100'.to_datetime.utc)
+ start_time: "2021-11-09T23:00:00 +0100".to_datetime.utc)
end
- describe 'it renders november 9th for Berlin zone' do
+ describe "it renders november 9th for Berlin zone" do
let(:mail) { described_class.icalendar_notification(meeting, author, author) }
- it 'renders the mail with the correct locale' do
- expect(mail.text_part.body).to include('11/09/2021 11:00 PM-12:00 AM (GMT+01:00) Europe/Berlin')
- expect(mail.html_part.body).to include('11/09/2021 11:00 PM')
- expect(mail.html_part.body).to include('12:00 AM (GMT+01:00) Europe/Berlin')
+ it "renders the mail with the correct locale" do
+ expect(mail.text_part.body).to include("11/09/2021 11:00 PM-12:00 AM (GMT+01:00) Europe/Berlin")
+ expect(mail.html_part.body).to include("11/09/2021 11:00 PM")
+ expect(mail.html_part.body).to include("12:00 AM (GMT+01:00) Europe/Berlin")
expect(mail.to).to contain_exactly(author.mail)
end
end
- describe 'it renders november 10th for Tokyo zone' do
+ describe "it renders november 10th for Tokyo zone" do
let(:mail) { described_class.icalendar_notification(meeting, watcher1, author) }
- let!(:preference) { create(:user_preference, user: watcher1, time_zone: 'Asia/Tokyo') }
+ let!(:preference) { create(:user_preference, user: watcher1, time_zone: "Asia/Tokyo") }
- it 'renders the mail with the correct locale' do
- expect(mail.text_part.body).to include('11/10/2021 07:00 AM-08:00 AM (GMT+09:00) Asia/Tokyo')
- expect(mail.html_part.body).to include('11/10/2021 07:00 AM-08:00 AM (GMT+09:00) Asia/Tokyo')
+ it "renders the mail with the correct locale" do
+ expect(mail.text_part.body).to include("11/10/2021 07:00 AM-08:00 AM (GMT+09:00) Asia/Tokyo")
+ expect(mail.html_part.body).to include("11/10/2021 07:00 AM-08:00 AM (GMT+09:00) Asia/Tokyo")
expect(mail.to).to contain_exactly(watcher1.mail)
end
diff --git a/modules/meeting/spec/models/meeting_acts_as_journalized_spec.rb b/modules/meeting/spec/models/meeting_acts_as_journalized_spec.rb
index 3b3dc5f34c00..493c2b158ae7 100644
--- a/modules/meeting/spec/models/meeting_acts_as_journalized_spec.rb
+++ b/modules/meeting/spec/models/meeting_acts_as_journalized_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Meeting do
shared_let (:user) { create(:user) }
@@ -38,59 +38,59 @@
end
end
- describe '#journal' do
- context 'for meeting creation' do
+ describe "#journal" do
+ context "for meeting creation" do
it { expect(Journal.for_meeting.count).to eq(1) }
- it 'has a journal entry' do
+ it "has a journal entry" do
expect(Journal.for_meeting.first.journable).to eq(meeting)
end
- it 'notes the changes to title' do
+ it "notes the changes to title" do
expect(meeting.last_journal.details[:title])
.to contain_exactly(nil, meeting.title)
end
- it 'notes the changes to project' do
+ it "notes the changes to project" do
expect(meeting.last_journal.details[:project_id])
.to contain_exactly(nil, meeting.project_id)
end
- it 'notes the location' do
+ it "notes the location" do
expect(meeting.last_journal.details[:location])
.to contain_exactly(nil, meeting.location)
end
- it 'notes the start time' do
+ it "notes the start time" do
expect(meeting.last_journal.details[:start_time])
.to contain_exactly(nil, meeting.start_time)
end
- it 'notes the duration' do
+ it "notes the duration" do
expect(meeting.last_journal.details[:duration])
.to contain_exactly(nil, meeting.duration)
end
- it 'has the timestamp of the meeting update time for created_at' do
+ it "has the timestamp of the meeting update time for created_at" do
expect(meeting.last_journal.created_at)
.to eql(meeting.reload.updated_at)
end
- it 'has the updated_at of the meeting as the lower bound for validity_period and no upper bound' do
+ it "has the updated_at of the meeting as the lower bound for validity_period and no upper bound" do
expect(meeting.last_journal.validity_period)
.to eql(meeting.reload.updated_at...)
end
end
- context 'when nothing is changed' do
+ context "when nothing is changed" do
it { expect { meeting.save! }.not_to change(Journal, :count) }
- it 'does not update the updated_at time of the work package' do
+ it "does not update the updated_at time of the work package" do
expect { meeting.save! }.not_to change(meeting, :updated_at)
end
end
- describe 'agenda_items' do
+ describe "agenda_items" do
let(:work_package) { nil }
let(:agenda_item_attributes) { {} }
let(:agenda_item) { meeting.agenda_items.first }
@@ -101,32 +101,32 @@
meeting.save
end
- context 'for a new agenda item within aggregation time' do
+ context "for a new agenda item within aggregation time" do
it { expect(meeting.journals.count).to eq(1) }
it { expect(agenda_item_journals.count).to eq(1) }
it {
expect(agenda_item_journals.last).to have_attributes agenda_item.attributes.slice(
- 'author_id', 'title', 'notes', 'position', 'duration_in_minutes',
- 'start_time', 'end_time', 'work_package_id', 'item_type'
+ "author_id", "title", "notes", "position", "duration_in_minutes",
+ "start_time", "end_time", "work_package_id", "item_type"
)
}
end
- context 'for a new agenda item outside aggregation time', with_settings: { journal_aggregation_time_minutes: 0 } do
+ context "for a new agenda item outside aggregation time", with_settings: { journal_aggregation_time_minutes: 0 } do
it { expect(meeting.journals.count).to eq(2) }
it { expect(meeting.journals.first.agenda_item_journals).to be_empty }
it { expect(agenda_item_journals.count).to eq(1) }
it {
expect(agenda_item_journals.last).to have_attributes agenda_item.attributes.slice(
- 'author_id', 'title', 'notes', 'position', 'duration_in_minutes',
- 'start_time', 'end_time', 'work_package_id', 'item_type'
+ "author_id", "title", "notes", "position", "duration_in_minutes",
+ "start_time", "end_time", "work_package_id", "item_type"
)
}
end
- context 'when agenda item saved w/o change' do
+ context "when agenda item saved w/o change" do
it {
expect do
agenda_item.save
@@ -136,21 +136,21 @@
end
Journal::MeetingAgendaItemJournal.columns_hash.slice(
- 'notes', 'position', 'duration_in_minutes', 'work_package_id', 'item_type'
+ "notes", "position", "duration_in_minutes", "work_package_id", "item_type"
).each do |column_name, column_info|
column_value =
- if column_name == 'item_type' then 'work_package'
+ if column_name == "item_type" then "work_package"
elsif column_info.type == :integer then 11
- else 'A string'
+ else "A string"
end
- if column_name == 'item_type'
+ if column_name == "item_type"
# When testing the work_package item_type, a work_package is required.
let(:work_package) { create(:work_package) }
end
- context 'when updating an agenda_item within the aggregation time' do
- shared_examples 'it updates the existing journals' do
+ context "when updating an agenda_item within the aggregation time" do
+ shared_examples "it updates the existing journals" do
subject(:update_agenda_item) do
agenda_item.update(column_name => updated_value)
meeting.save_journals
@@ -158,7 +158,7 @@
it { expect { update_agenda_item }.not_to change(Journal, :count) }
- it 'updates the agenda item journal' do
+ it "updates the agenda item journal" do
expect { update_agenda_item }
.to change { agenda_item_journals.last.send(column_name) }
.to(updated_value)
@@ -166,7 +166,7 @@
end
describe "setting a value for the #{column_name} column" do
- it_behaves_like 'it updates the existing journals' do
+ it_behaves_like "it updates the existing journals" do
let(:updated_value) { column_value }
end
end
@@ -174,15 +174,15 @@
describe "unsetting a value for the #{column_name} column" do
let(:agenda_item_attributes) { { column_name => column_value } }
- it_behaves_like 'it updates the existing journals' do
+ it_behaves_like "it updates the existing journals" do
let(:updated_value) { nil }
end
end
end
- context 'when updating an agenda_item outside the aggregation time',
+ context "when updating an agenda_item outside the aggregation time",
with_settings: { journal_aggregation_time_minutes: 0 } do
- shared_examples 'creates a new journal and keeps old journal intact' do
+ shared_examples "creates a new journal and keeps old journal intact" do
subject(:update_agenda_item) do
agenda_item.update(column_name => updated_value)
meeting.save_journals
@@ -192,13 +192,13 @@
it { expect { update_agenda_item }.to change(Journal::MeetingJournal, :count).by(1) }
it { expect { update_agenda_item }.to change(Journal::MeetingAgendaItemJournal, :count).by(1) }
- it 'does not update the previous agenda item journal' do
+ it "does not update the previous agenda item journal" do
previous_journal_agenda_items = agenda_item_journals
expect { update_agenda_item }
.not_to change { previous_journal_agenda_items.reload }
end
- it 'updates the new agenda item journal' do
+ it "updates the new agenda item journal" do
expect { update_agenda_item }
.to change { Journal::MeetingAgendaItemJournal.last.send(column_name) }
.to(updated_value)
@@ -206,7 +206,7 @@
end
describe "setting a value for the #{column_name} column" do
- it_behaves_like 'creates a new journal and keeps old journal intact' do
+ it_behaves_like "creates a new journal and keeps old journal intact" do
let(:updated_value) { column_value }
end
end
@@ -214,14 +214,14 @@
describe "unsetting a value for the #{column_name} column" do
let(:agenda_item_attributes) { { column_name => column_value } }
- it_behaves_like 'creates a new journal and keeps old journal intact' do
+ it_behaves_like "creates a new journal and keeps old journal intact" do
let(:updated_value) { nil }
end
end
end
end
- context 'for a removed agenda_item within aggregation time' do
+ context "for a removed agenda_item within aggregation time" do
subject(:remove_agenda_item) do
agenda_item.destroy
meeting.save_journals
@@ -237,7 +237,7 @@
}
end
- context 'for a removed agenda_item outside aggregation time', with_settings: { journal_aggregation_time_minutes: 0 } do
+ context "for a removed agenda_item outside aggregation time", with_settings: { journal_aggregation_time_minutes: 0 } do
let(:agenda_item_journals) { meeting.journals.second.agenda_item_journals }
subject(:remove_agenda_item) do
@@ -265,12 +265,12 @@
it {
remove_agenda_item
expect(agenda_item_journals.last).to have_attributes agenda_item.attributes.slice(
- 'author_id', 'title', 'notes', 'position', 'duration_in_minutes',
- 'start_time', 'end_time', 'work_package_id'
+ "author_id", "title", "notes", "position", "duration_in_minutes",
+ "start_time", "end_time", "work_package_id"
)
}
- it 'removes the agenda_item_journals from the new journal' do
+ it "removes the agenda_item_journals from the new journal" do
remove_agenda_item
expect(meeting.journals.last.agenda_item_journals).to be_empty
end
@@ -278,7 +278,7 @@
end
end
- describe '#destroy' do
+ describe "#destroy" do
before do
meeting.agenda_items << create(:meeting_agenda_item)
meeting.save
@@ -289,21 +289,21 @@
subject { meeting.destroy }
- it 'removes the journal' do
+ it "removes the journal" do
expect { subject }
.to change { Journal.exists?(journal.id) }
.from(true)
.to(false)
end
- it 'removes the journal data' do
+ it "removes the journal data" do
expect { subject }
.to change { Journal::MeetingJournal.exists?(id: journal.data_id) }
.from(true)
.to(false)
end
- it 'removes the meeting agenda items journals' do
+ it "removes the meeting agenda items journals" do
expect { subject }
.to change {
Journal::MeetingAgendaItemJournal.where(id: agenda_item_journals.map(&:id)).count
diff --git a/modules/meeting/spec/models/meeting_agenda_item_spec.rb b/modules/meeting/spec/models/meeting_agenda_item_spec.rb
index 694b64d6c4ae..220e244f14c8 100644
--- a/modules/meeting/spec/models/meeting_agenda_item_spec.rb
+++ b/modules/meeting/spec/models/meeting_agenda_item_spec.rb
@@ -36,94 +36,94 @@
subject { meeting_agenda_item }
- describe '#author' do
- let(:attributes) { { title: 'foo', author: } }
+ describe "#author" do
+ let(:attributes) { { title: "foo", author: } }
- context 'when author is missing' do
+ context "when author is missing" do
let(:author) { nil }
- it 'validates' do
+ it "validates" do
expect(subject).not_to be_valid
expect(subject.errors[:author]).to include "must exist"
end
end
- context 'when author is present' do
+ context "when author is present" do
let(:author) { build_stubbed(:user) }
- it 'validates' do
+ it "validates" do
expect(subject).to be_valid
end
end
end
- describe '#duration' do
- let(:attributes) { { title: 'foo', author: build_stubbed(:user), duration_in_minutes: } }
+ describe "#duration" do
+ let(:attributes) { { title: "foo", author: build_stubbed(:user), duration_in_minutes: } }
- context 'with a valid duration' do
+ context "with a valid duration" do
let(:duration_in_minutes) { 60 }
- it 'is valid' do
+ it "is valid" do
expect(subject).to be_valid
end
end
- context 'with a negative duration' do
+ context "with a negative duration" do
let(:duration_in_minutes) { -1 }
- it 'is invalid' do
+ it "is invalid" do
expect(subject).not_to be_valid
expect(subject.errors[:duration_in_minutes]).to include "must be greater than or equal to 0."
end
end
- context 'with a duration that is too large' do
+ context "with a duration that is too large" do
let(:duration_in_minutes) { 10000000000 }
- it 'is valid' do
+ it "is valid" do
expect(subject).not_to be_valid
expect(subject.errors[:duration_in_minutes]).to include "must be less than or equal to 1440."
end
end
- context 'with max duration' do
+ context "with max duration" do
let(:duration_in_minutes) { 1440 }
- it 'is valid' do
+ it "is valid" do
expect(subject).to be_valid
end
end
- context 'with overmax duration' do
+ context "with overmax duration" do
let(:duration_in_minutes) { 1441 }
- it 'is valid' do
+ it "is valid" do
expect(subject).not_to be_valid
expect(subject.errors[:duration_in_minutes]).to include "must be less than or equal to 1440."
end
end
end
- describe '#title' do
+ describe "#title" do
let(:attributes) { { title:, item_type:, author: build_stubbed(:user), work_package_id: 1 } }
- context 'when item_type is simple' do
+ context "when item_type is simple" do
let(:item_type) { :simple }
- context 'and title is missing' do
+ context "and title is missing" do
let(:title) { nil }
it { is_expected.not_to be_valid }
end
- context 'and title is present' do
- let(:title) { 'title' }
+ context "and title is present" do
+ let(:title) { "title" }
it { is_expected.to be_valid }
end
end
- context 'when item_type is work_package and title is missing' do
+ context "when item_type is work_package and title is missing" do
let(:item_type) { :work_package }
let(:title) { nil }
@@ -131,36 +131,36 @@
end
end
- describe '#work_package_id' do
- let(:attributes) { { work_package_id:, item_type:, author: build_stubbed(:user), title: 'title' } }
+ describe "#work_package_id" do
+ let(:attributes) { { work_package_id:, item_type:, author: build_stubbed(:user), title: "title" } }
- context 'on create' do
- context 'when item_type is simple' do
+ context "on create" do
+ context "when item_type is simple" do
let(:item_type) { :simple }
- context 'and work_package_id is missing' do
+ context "and work_package_id is missing" do
let(:work_package_id) { nil }
it { is_expected.to be_valid }
end
- context 'and work_package_id is present' do
+ context "and work_package_id is present" do
let(:work_package_id) { 1 }
it { is_expected.to be_valid }
end
end
- context 'when item_type is work_package' do
+ context "when item_type is work_package" do
let(:item_type) { :work_package }
- context 'and work_package_id is missing' do
+ context "and work_package_id is missing" do
let(:work_package_id) { nil }
it { is_expected.not_to be_valid }
end
- context 'and work_package_id is present' do
+ context "and work_package_id is present" do
let(:work_package_id) { 1 }
it { is_expected.to be_valid }
@@ -168,7 +168,7 @@
end
end
- context 'on update' do
+ context "on update" do
let(:meeting_agenda_item) { create(:meeting_agenda_item) }
subject do
@@ -176,32 +176,32 @@
meeting_agenda_item
end
- context 'when item_type is simple' do
+ context "when item_type is simple" do
let(:item_type) { :simple }
- context 'and work_package_id is missing' do
+ context "and work_package_id is missing" do
let(:work_package_id) { nil }
it { is_expected.to be_valid }
end
- context 'and work_package_id is present' do
+ context "and work_package_id is present" do
let(:work_package_id) { 1 }
it { is_expected.to be_valid }
end
end
- context 'when item_type is work_package' do
+ context "when item_type is work_package" do
let(:item_type) { :work_package }
- context 'and work_package_id is missing' do
+ context "and work_package_id is missing" do
let(:work_package_id) { nil }
it { is_expected.to be_valid }
end
- context 'and work_package_id is present' do
+ context "and work_package_id is present" do
let(:work_package_id) { 1 }
it { is_expected.to be_valid }
@@ -210,7 +210,7 @@
end
end
- describe '#deleted_work_package?' do
+ describe "#deleted_work_package?" do
subject { meeting_agenda_item.deleted_work_package? }
let(:attributes) { { work_package_id:, item_type: } }
@@ -219,11 +219,11 @@
let(:item_type) { :simple }
let(:work_package_id) { nil }
- context 'and the agenda_item is not persisted' do
+ context "and the agenda_item is not persisted" do
it { is_expected.to be false }
end
- context 'and the agenda_item is persisted' do
+ context "and the agenda_item is persisted" do
let(:meeting_agenda_item) { build_stubbed(:meeting_agenda_item, meeting:, **attributes) }
it { is_expected.to be false }
@@ -233,27 +233,27 @@
context 'when item_type is "work_package"' do
let(:item_type) { :work_package }
- context 'and the agenda_item is not persisted' do
- context 'and work_package_id is missing' do
+ context "and the agenda_item is not persisted" do
+ context "and work_package_id is missing" do
let(:work_package_id) { nil }
it { is_expected.to be false }
end
- context 'and work_package_id is present' do
+ context "and work_package_id is present" do
let(:work_package_id) { 1 }
it { is_expected.to be false }
end
end
- context 'and the agenda_item is persisted' do
+ context "and the agenda_item is persisted" do
let(:meeting_agenda_item) { build_stubbed(:meeting_agenda_item, meeting:, **attributes) }
- context 'and work_package_id was originally missing' do
+ context "and work_package_id was originally missing" do
let(:work_package_id) { nil }
- context 'and now is present' do
+ context "and now is present" do
before do
meeting_agenda_item.work_package_id = 1
end
@@ -261,19 +261,19 @@
it { is_expected.to be true }
end
- context 'and now is also missing' do
+ context "and now is also missing" do
it { is_expected.to be true }
end
end
- context 'and work_package_id was originally present' do
+ context "and work_package_id was originally present" do
let(:work_package_id) { 1 }
- context 'and now is also present' do
+ context "and now is also present" do
it { is_expected.to be false }
end
- context 'and now is missing' do
+ context "and now is missing" do
before do
meeting_agenda_item.work_package_id = nil
end
@@ -285,18 +285,18 @@
end
end
- describe '#modifiable?' do
+ describe "#modifiable?" do
subject { meeting_agenda_item.modifiable? }
let(:attributes) { { work_package_id: nil, item_type: :work_package } }
- context 'when meeting is closed' do
+ context "when meeting is closed" do
let(:meeting_attributes) { { state: :closed } }
it { is_expected.to be false }
end
- context 'when the work package is not deleted' do
+ context "when the work package is not deleted" do
before do
allow(meeting_agenda_item).to receive(:deleted_work_package?).and_return(false)
end
@@ -304,16 +304,16 @@
it { is_expected.to be true }
end
- context 'when work package is deleted' do
+ context "when work package is deleted" do
before do
allow(meeting_agenda_item).to receive(:deleted_work_package?).and_return(true)
end
- context 'and the current value is not modified' do
+ context "and the current value is not modified" do
it { is_expected.to be true }
end
- context 'and the current value is modified' do
+ context "and the current value is modified" do
before do
meeting_agenda_item.work_package_id = 1
end
diff --git a/modules/meeting/spec/models/meeting_agenda_spec.rb b/modules/meeting/spec/models/meeting_agenda_spec.rb
index 72ccbb53844e..2bf070ca61e6 100644
--- a/modules/meeting/spec/models/meeting_agenda_spec.rb
+++ b/modules/meeting/spec/models/meeting_agenda_spec.rb
@@ -26,16 +26,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.dirname(__FILE__) + '/../spec_helper'
+require File.dirname(__FILE__) + "/../spec_helper"
-RSpec.describe 'MeetingAgenda' do
+RSpec.describe "MeetingAgenda" do
before do
@a = build(:meeting_agenda, text: "Some content...\n\nMore content!\n\nExtraordinary content!!")
end
# TODO: Test the right user and messages are set in the history
- describe '#lock!' do
- it 'locks the agenda' do
+ describe "#lock!" do
+ it "locks the agenda" do
@a.save
@a.reload
@a.lock!
@@ -44,8 +44,8 @@
end
end
- describe '#unlock!' do
- it 'unlocks the agenda' do
+ describe "#unlock!" do
+ it "unlocks the agenda" do
@a.locked = true
@a.save
@a.reload
@@ -56,13 +56,13 @@
end
# a meeting agenda is editable when it is not locked
- describe '#editable?' do
- it 'is editable when not locked' do
+ describe "#editable?" do
+ it "is editable when not locked" do
@a.locked = false
expect(@a.editable?).to be_truthy
end
- it 'is not editable when locked' do
+ it "is not editable when locked" do
@a.locked = true
expect(@a.editable?).to be_falsey
end
diff --git a/modules/meeting/spec/models/meeting_minutes_spec.rb b/modules/meeting/spec/models/meeting_minutes_spec.rb
index 22310c31951b..e56f8990163e 100644
--- a/modules/meeting/spec/models/meeting_minutes_spec.rb
+++ b/modules/meeting/spec/models/meeting_minutes_spec.rb
@@ -26,37 +26,37 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.dirname(__FILE__) + '/../spec_helper'
+require File.dirname(__FILE__) + "/../spec_helper"
-RSpec.describe 'MeetingMinutes' do
+RSpec.describe "MeetingMinutes" do
before do
@min = build(:meeting_minutes)
end
# meeting minutes are editable when the meeting agenda is locked
- describe '#editable?' do
+ describe "#editable?" do
before do
@mee = build(:meeting)
@min.meeting = @mee
end
- describe 'with no agenda present' do
- it 'is not editable' do
+ describe "with no agenda present" do
+ it "is not editable" do
expect(@min.editable?).to be_falsey
end
end
- describe 'with an agenda present' do
+ describe "with an agenda present" do
before do
@a = build(:meeting_agenda)
@mee.agenda = @a
end
- it 'is not editable when the agenda is open' do
+ it "is not editable when the agenda is open" do
expect(@min.editable?).to be_falsey
end
- it 'is editable when the agenda is closed' do
+ it "is editable when the agenda is closed" do
@a.lock!
expect(@min.editable?).to be_truthy
end
diff --git a/modules/meeting/spec/models/meeting_spec.rb b/modules/meeting/spec/models/meeting_spec.rb
index 443dda9dfae4..7774235d9e54 100644
--- a/modules/meeting/spec/models/meeting_spec.rb
+++ b/modules/meeting/spec/models/meeting_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.dirname(__FILE__) + '/../spec_helper'
+require File.dirname(__FILE__) + "/../spec_helper"
RSpec.describe Meeting do
shared_let (:user1) { create(:user) }
@@ -34,7 +34,7 @@
let(:project) { create(:project, members: project_members) }
let(:meeting) { create(:meeting, project:, author: user1) }
let(:agenda) do
- meeting.create_agenda text: 'Meeting Agenda text'
+ meeting.create_agenda text: "Meeting Agenda text"
meeting.reload_agenda # avoiding stale object errors
end
let(:project_members) { {} }
@@ -45,60 +45,60 @@
it { is_expected.to belong_to :author }
it { is_expected.to validate_presence_of :title }
- describe 'new instance' do
- let(:meeting) { build(:meeting, project:, title: 'dingens') }
+ describe "new instance" do
+ let(:meeting) { build(:meeting, project:, title: "dingens") }
- describe 'to_s' do
- it { expect(meeting.to_s).to eq('dingens') }
+ describe "to_s" do
+ it { expect(meeting.to_s).to eq("dingens") }
end
- describe 'start_date' do
+ describe "start_date" do
it { expect(meeting.start_date).to eq(Date.tomorrow.iso8601) }
end
- describe 'start_month' do
+ describe "start_month" do
it { expect(meeting.start_month).to eq(Date.tomorrow.month) }
end
- describe 'start_year' do
+ describe "start_year" do
it { expect(meeting.start_year).to eq(Date.tomorrow.year) }
end
- describe 'end_time' do
+ describe "end_time" do
it { expect(meeting.end_time).to eq(Date.tomorrow + 11.hours) }
end
- describe 'date validations' do
- it 'marks invalid start dates' do
- meeting.start_date = '-'
- expect(meeting.start_date).to eq('-')
+ describe "date validations" do
+ it "marks invalid start dates" do
+ meeting.start_date = "-"
+ expect(meeting.start_date).to eq("-")
expect(meeting.start_time).to be_nil
expect(meeting).not_to be_valid
expect(meeting.errors.count).to eq(1)
end
- it 'marks invalid start hours' do
- meeting.start_time_hour = '-'
- expect(meeting.start_time_hour).to eq('-')
+ it "marks invalid start hours" do
+ meeting.start_time_hour = "-"
+ expect(meeting.start_time_hour).to eq("-")
expect(meeting.start_time).to be_nil
expect(meeting).not_to be_valid
expect(meeting.errors.count).to eq(1)
end
- it 'is not invalid when setting date_time explicitly' do
+ it "is not invalid when setting date_time explicitly" do
meeting.start_time = DateTime.now
expect(meeting).to be_valid
end
- it 'raises an error trying to set invalid time' do
- expect { meeting.start_time = '-' }.to raise_error(Date::Error)
+ it "raises an error trying to set invalid time" do
+ expect { meeting.start_time = "-" }.to raise_error(Date::Error)
end
- it 'accepts changes after invalid dates' do
- meeting.start_date = '-'
+ it "accepts changes after invalid dates" do
+ meeting.start_date = "-"
expect(meeting.start_time).to be_nil
expect(meeting).not_to be_valid
- expect(meeting.errors[:start_date]).to contain_exactly 'is not a valid date. Required format: YYYY-MM-DD.'
+ expect(meeting.errors[:start_date]).to contain_exactly "is not a valid date. Required format: YYYY-MM-DD."
meeting.start_date = Time.zone.today.iso8601
expect(meeting).to be_valid
@@ -109,38 +109,38 @@
end
end
- describe 'all_changeable_participants' do
- describe 'WITH a user having the view_meetings permission' do
+ describe "all_changeable_participants" do
+ describe "WITH a user having the view_meetings permission" do
let(:project_members) { { user1 => role } }
- it 'contains the user' do
+ it "contains the user" do
expect(meeting.all_changeable_participants).to eq([user1])
end
end
- describe 'WITH a user not having the view_meetings permission' do
+ describe "WITH a user not having the view_meetings permission" do
let(:role2) { create(:project_role, permissions: []) }
let(:project_members) { { user1 => role, user2 => role2 } }
- it 'does not contain the user' do
+ it "does not contain the user" do
expect(meeting.all_changeable_participants).not_to include(user2)
end
end
- describe 'WITH a user being locked but invited' do
+ describe "WITH a user being locked but invited" do
let(:locked_user) { create(:locked_user) }
before do
meeting.participants_attributes = [{ user_id: locked_user.id, invited: 1 }]
end
- it 'contains the user' do
+ it "contains the user" do
expect(meeting.all_changeable_participants).to include(locked_user)
end
end
end
- describe 'participants and author as watchers' do
+ describe "participants and author as watchers" do
let(:project_members) { { user1 => role, user2 => role } }
before do
@@ -151,7 +151,7 @@
it { expect(meeting.watchers.collect(&:user)).to contain_exactly(user1, user2) }
end
- describe '#close_agenda_and_copy_to_minutes' do
+ describe "#close_agenda_and_copy_to_minutes" do
before do
agenda # creating it
@@ -162,48 +162,48 @@
expect(meeting.minutes.text).to eq(meeting.agenda.text)
end
- it 'closes the agenda' do
+ it "closes the agenda" do
expect(meeting.agenda).to be_locked
end
end
- describe 'Timezones' do
- shared_examples 'uses that zone' do |zone|
+ describe "Timezones" do
+ shared_examples "uses that zone" do |zone|
it do
- meeting.start_date = '2016-07-01'
+ meeting.start_date = "2016-07-01"
expect(meeting.start_time.zone).to eq(zone)
end
end
- context 'default zone' do
- it_behaves_like 'uses that zone', 'UTC'
+ context "default zone" do
+ it_behaves_like "uses that zone", "UTC"
end
- context 'other timezone set' do
+ context "other timezone set" do
let!(:old_time_zone) { Time.zone }
before do
- Time.zone = 'EST'
+ Time.zone = "EST"
end
after do
Time.zone = old_time_zone.name
end
- it_behaves_like 'uses that zone', 'EST'
+ it_behaves_like "uses that zone", "EST"
end
end
- describe 'acts_as_watchable' do
- it 'is watchable' do
+ describe "acts_as_watchable" do
+ it "is watchable" do
expect(described_class).to include(Redmine::Acts::Watchable::InstanceMethods)
end
- it 'uses the :view_meetings permission' do
+ it "uses the :view_meetings permission" do
expect(described_class.acts_as_watchable_permission).to eq(:view_meetings)
end
- it 'uses the :view_meetings permission in STI classes' do
+ it "uses the :view_meetings permission in STI classes" do
expect(StructuredMeeting.acts_as_watchable_permission).to eq(:view_meetings)
end
end
diff --git a/modules/meeting/spec/models/permitted_params_spec.rb b/modules/meeting/spec/models/permitted_params_spec.rb
index 9c67383dee3c..043ecbc1ce22 100644
--- a/modules/meeting/spec/models/permitted_params_spec.rb
+++ b/modules/meeting/spec/models/permitted_params_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.dirname(__FILE__) + '/../spec_helper'
+require File.dirname(__FILE__) + "/../spec_helper"
RSpec.describe PermittedParams do
let(:user) { build_stubbed(:user) }
- describe '#search' do
- it 'permits its whitelisted params' do
+ describe "#search" do
+ it "permits its whitelisted params" do
acceptable_params = { messages: 1 }
permitted = ActionController::Parameters.new(acceptable_params).permit!
diff --git a/modules/meeting/spec/models/project/activity_spec.rb b/modules/meeting/spec/models/project/activity_spec.rb
index c19c756ef44b..ab0824e782d5 100644
--- a/modules/meeting/spec/models/project/activity_spec.rb
+++ b/modules/meeting/spec/models/project/activity_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe Projects::Activity, 'meeting' do
+RSpec.describe Projects::Activity, "meeting" do
shared_let(:project) do
create(:project, :updated_a_long_time_ago)
end
@@ -54,8 +54,8 @@ def latest_activity
Project.with_latest_activity.find(project.id).latest_activity_at
end
- describe '.with_latest_activity' do
- it 'set project.latest_activity_at to the latest updated meeting time' do
+ describe ".with_latest_activity" do
+ it "set project.latest_activity_at to the latest updated meeting time" do
meeting.update(updated_at: initial_time - 10.seconds)
meeting2.update(updated_at: initial_time - 20.seconds)
@@ -63,7 +63,7 @@ def latest_activity
expect(latest_activity).to be_within(0.00001).of(meeting.updated_at)
end
- it 'takes the time stamp of the latest activity across models' do
+ it "takes the time stamp of the latest activity across models" do
work_package.update(updated_at: initial_time - 10.seconds)
meeting.update(updated_at: initial_time - 20.seconds)
diff --git a/modules/meeting/spec/models/queries/meeting_query_spec.rb b/modules/meeting/spec/models/queries/meeting_query_spec.rb
index 76279af44fef..4947e56d7f58 100644
--- a/modules/meeting/spec/models/queries/meeting_query_spec.rb
+++ b/modules/meeting/spec/models/queries/meeting_query_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Queries::Meetings::MeetingQuery do
subject { described_class.new(user:) }
@@ -46,78 +46,78 @@
let(:invisible_project) { create(:project) }
let!(:invisible_meeting) { create(:meeting, project: invisible_project, start_time: 1.day.ago) }
- context 'without a filter' do
- it 'returns all visible meetings' do
+ context "without a filter" do
+ it "returns all visible meetings" do
expect(subject.results).to contain_exactly(visible_meeting_past, visible_meeting_ongoing, visible_meeting_future)
end
end
- context 'when filtering by project' do
+ context "when filtering by project" do
let(:other_visible_project) { create(:project, members: { user => create(:project_role, permissions: %i[view_meetings]) }) }
let!(:other_visible_meeting) { create(:meeting, project: other_visible_project, author: user, start_time: 1.day.ago) }
before do
- subject.where('project_id', '=', [other_visible_project.id])
+ subject.where("project_id", "=", [other_visible_project.id])
end
- it 'returns only visible meetings for that project' do
+ it "returns only visible meetings for that project" do
expect(subject.results).to contain_exactly(other_visible_meeting)
end
end
- context 'when filtering by time' do
- context 'for future meetings' do
+ context "when filtering by time" do
+ context "for future meetings" do
before do
- subject.where('time', '=', ['future'])
+ subject.where("time", "=", ["future"])
end
- it 'returns meetings starting in the future and meetings currently ongoing' do
+ it "returns meetings starting in the future and meetings currently ongoing" do
expect(subject.results).to contain_exactly(visible_meeting_future, visible_meeting_ongoing)
end
end
- context 'for past meetings' do
+ context "for past meetings" do
before do
- subject.where('time', '=', ['past'])
+ subject.where("time", "=", ["past"])
end
- it 'returns meetings starting in the past and meetings currently ongoing' do
+ it "returns meetings starting in the past and meetings currently ongoing" do
expect(subject.results).to contain_exactly(visible_meeting_past, visible_meeting_ongoing)
end
end
end
- context 'when filtering by attending users' do
+ context "when filtering by attending users" do
before do
create(:meeting_participant, user: other_user, meeting: visible_meeting_ongoing, attended: true)
create(:meeting_participant, user: other_user, meeting: visible_meeting_future, attended: false)
- subject.where('attended_user_id', '=', [other_user.id])
+ subject.where("attended_user_id", "=", [other_user.id])
end
- it 'returns meetings where the given user is attending' do
+ it "returns meetings where the given user is attending" do
expect(subject.results).to contain_exactly(visible_meeting_ongoing)
end
end
- context 'when filtering by invited users' do
+ context "when filtering by invited users" do
before do
create(:meeting_participant, user: other_user, meeting: visible_meeting_ongoing, invited: true)
create(:meeting_participant, user: other_user, meeting: visible_meeting_future, invited: false)
- subject.where('invited_user_id', '=', [other_user.id])
+ subject.where("invited_user_id", "=", [other_user.id])
end
- it 'returns meetings where the given user is invited' do
+ it "returns meetings where the given user is invited" do
expect(subject.results).to contain_exactly(visible_meeting_ongoing)
end
end
- context 'when filtering by author' do
+ context "when filtering by author" do
before do
visible_meeting_future.update(author: other_user)
- subject.where('author_id', '=', [other_user.id])
+ subject.where("author_id", "=", [other_user.id])
end
- it 'returns meetings where the given user is invited' do
+ it "returns meetings where the given user is invited" do
expect(subject.results).to contain_exactly(visible_meeting_future)
end
end
diff --git a/modules/meeting/spec/requests/api/v3/attachments/meeting_agenda_spec.rb b/modules/meeting/spec/requests/api/v3/attachments/meeting_agenda_spec.rb
index 46a60c9220ef..d902c51eba78 100644
--- a/modules/meeting/spec/requests/api/v3/attachments/meeting_agenda_spec.rb
+++ b/modules/meeting/spec/requests/api/v3/attachments/meeting_agenda_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'requests/api/v3/attachments/attachment_resource_shared_examples'
+require "spec_helper"
+require "requests/api/v3/attachments/attachment_resource_shared_examples"
RSpec.describe "meeting agenda attachments" do
it_behaves_like "an APIv3 attachment resource" do
diff --git a/modules/meeting/spec/requests/api/v3/attachments/meeting_minutes_spec.rb b/modules/meeting/spec/requests/api/v3/attachments/meeting_minutes_spec.rb
index 7ddc1dac3ad7..7bdc16fa6bb8 100644
--- a/modules/meeting/spec/requests/api/v3/attachments/meeting_minutes_spec.rb
+++ b/modules/meeting/spec/requests/api/v3/attachments/meeting_minutes_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'requests/api/v3/attachments/attachment_resource_shared_examples'
+require "spec_helper"
+require "requests/api/v3/attachments/attachment_resource_shared_examples"
RSpec.describe "meeting minutes attachments" do
it_behaves_like "an APIv3 attachment resource" do
diff --git a/modules/meeting/spec/requests/api/v3/attachments/meetings_spec.rb b/modules/meeting/spec/requests/api/v3/attachments/meetings_spec.rb
index bb76e3f8eb18..b1dc4377b414 100644
--- a/modules/meeting/spec/requests/api/v3/attachments/meetings_spec.rb
+++ b/modules/meeting/spec/requests/api/v3/attachments/meetings_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'requests/api/v3/attachments/attachment_resource_shared_examples'
+require "spec_helper"
+require "requests/api/v3/attachments/attachment_resource_shared_examples"
RSpec.describe "meetings attachments" do
it_behaves_like "an APIv3 attachment resource" do
diff --git a/modules/meeting/spec/requests/api/v3/meetings/meetings_resource_spec.rb b/modules/meeting/spec/requests/api/v3/meetings/meetings_resource_spec.rb
index c7918ebd3611..ce5637d5989f 100644
--- a/modules/meeting/spec/requests/api/v3/meetings/meetings_resource_spec.rb
+++ b/modules/meeting/spec/requests/api/v3/meetings/meetings_resource_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'API v3 Meeting resource' do
+RSpec.describe "API v3 Meeting resource" do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -42,45 +42,45 @@
member_with_permissions: { project => permissions })
end
- describe 'meetings/:id' do
+ describe "meetings/:id" do
let(:get_path) { api_v3_paths.meeting meeting.id }
- context 'with logged in user' do
+ context "with logged in user" do
before do
allow(User).to receive(:current).and_return current_user
get get_path
end
- context 'when valid id' do
- it 'returns HTTP 200' do
+ context "when valid id" do
+ it "returns HTTP 200" do
expect(last_response.status).to eq 200
end
end
- context 'when valid id, but not visible' do
+ context "when valid id, but not visible" do
let(:permissions) { [:view_work_packages] }
- it 'returns HTTP 404' do
+ it "returns HTTP 404" do
expect(last_response.status).to eq 404
end
end
- context 'when invalid id' do
- let(:get_path) { api_v3_paths.budget 'bogus' }
+ context "when invalid id" do
+ let(:get_path) { api_v3_paths.budget "bogus" }
- it_behaves_like 'param validation error' do
- let(:id) { 'bogus' }
+ it_behaves_like "param validation error" do
+ let(:id) { "bogus" }
end
end
end
- context 'with not logged in user' do
+ context "with not logged in user" do
before do
get get_path
end
- it_behaves_like 'not found response based on login_required'
+ it_behaves_like "not found response based on login_required"
end
end
end
diff --git a/modules/meeting/spec/requests/meetings_spec.rb b/modules/meeting/spec/requests/meetings_spec.rb
index 09e70761db3a..075e7bc5ebf6 100644
--- a/modules/meeting/spec/requests/meetings_spec.rb
+++ b/modules/meeting/spec/requests/meetings_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Meeting requests',
+RSpec.describe "Meeting requests",
:skip_csrf,
type: :rails_request do
shared_let(:project) { create(:project, enabled_module_names: %i[meetings]) }
@@ -38,15 +38,15 @@
login_as user
end
- describe 'copy' do
+ describe "copy" do
let(:meeting) { create(:structured_meeting, project:) }
let(:base_params) do
{
copied_from_meeting_id: meeting.id,
project_id: project.id,
meeting: {
- title: 'Copied meeting',
- type: 'StructuredMeeting'
+ title: "Copied meeting",
+ type: "StructuredMeeting"
}
}
end
@@ -56,26 +56,26 @@
post meetings_path(project),
params: base_params.merge(params)
- Meeting.find_by(title: 'Copied meeting')
+ Meeting.find_by(title: "Copied meeting")
end
- context 'when copying agenda items' do
- let!(:agenda_item) { create(:meeting_agenda_item, meeting:, notes: '**foo**') }
- let(:params) { { copy_agenda: '1' } }
+ context "when copying agenda items" do
+ let!(:agenda_item) { create(:meeting_agenda_item, meeting:, notes: "**foo**") }
+ let(:params) { { copy_agenda: "1" } }
- it 'copies the agenda items' do
+ it "copies the agenda items" do
subject
expect(response).to be_redirect
expect(subject).to be_present
expect(subject.agenda_items.count).to eq(1)
- expect(subject.agenda_items.first.notes).to eq('**foo**')
+ expect(subject.agenda_items.first.notes).to eq("**foo**")
end
end
- context 'when copying without additional params' do
- it 'copies the meeting, but not the agenda' do
+ context "when copying without additional params" do
+ it "copies the meeting, but not the agenda" do
subject
expect(response).to be_redirect
@@ -85,11 +85,11 @@
end
end
- context 'when meeting is not visible' do
+ context "when meeting is not visible" do
let(:other_project) { create(:project) }
let(:meeting) { create(:meeting, project: other_project) }
- it 'renders a 404' do
+ it "renders a 404" do
subject
expect(response).to have_http_status(:not_found)
end
diff --git a/modules/meeting/spec/routing/previews_routing_spec.rb b/modules/meeting/spec/routing/previews_routing_spec.rb
index 4a379d9c88d9..0f4763d36dd2 100644
--- a/modules/meeting/spec/routing/previews_routing_spec.rb
+++ b/modules/meeting/spec/routing/previews_routing_spec.rb
@@ -26,18 +26,18 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'preview' do
- it 'connects POST /meetings/:meeting_id/agenda/preview to meeting_agendas#preview' do
- expect(post('/meetings/1/agenda/preview')).to route_to(controller: 'meeting_agendas',
- meeting_id: '1',
- action: 'preview')
+RSpec.describe "preview" do
+ it "connects POST /meetings/:meeting_id/agenda/preview to meeting_agendas#preview" do
+ expect(post("/meetings/1/agenda/preview")).to route_to(controller: "meeting_agendas",
+ meeting_id: "1",
+ action: "preview")
end
- it 'connects POST /meetings/:meeting_id/agenda/preview to meeting_minutes#preview' do
- expect(post('/meetings/1/minutes/preview')).to route_to(controller: 'meeting_minutes',
- meeting_id: '1',
- action: 'preview')
+ it "connects POST /meetings/:meeting_id/agenda/preview to meeting_minutes#preview" do
+ expect(post("/meetings/1/minutes/preview")).to route_to(controller: "meeting_minutes",
+ meeting_id: "1",
+ action: "preview")
end
end
diff --git a/modules/meeting/spec/seeders/demo_data/project_seeder_spec.rb b/modules/meeting/spec/seeders/demo_data/project_seeder_spec.rb
index 40b1212971ac..839e59efb4ac 100644
--- a/modules/meeting/spec/seeders/demo_data/project_seeder_spec.rb
+++ b/modules/meeting/spec/seeders/demo_data/project_seeder_spec.rb
@@ -28,20 +28,20 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe DemoData::ProjectSeeder do
- include_context 'with basic seed data'
+ include_context "with basic seed data"
- subject(:project_seeder) { described_class.new(seed_data.lookup('projects.my-project')) }
+ subject(:project_seeder) { described_class.new(seed_data.lookup("projects.my-project")) }
let(:work_package) { create(:work_package) }
let(:user) { create(:user) }
let(:seed_data) do
data = basic_seed_data.merge(
Source::SeedData.new(
- 'projects' => {
- 'my-project' => project_data
+ "projects" => {
+ "my-project" => project_data
}
)
)
@@ -81,27 +81,27 @@
project_seeder.seed!
end
- it 'creates an associated meeting' do
- meeting = Meeting.find_by(title: 'Weekly')
+ it "creates an associated meeting" do
+ meeting = Meeting.find_by(title: "Weekly")
expect(meeting.author).to eq user
expect(meeting.duration).to eq 0.5
expect(meeting.agenda_items.count).to eq 2
- first = meeting.agenda_items.find_by(title: 'First topic')
+ first = meeting.agenda_items.find_by(title: "First topic")
expect(first.duration_in_minutes).to eq 10
expect(first.author).to eq user
- expect(first.notes).to eq 'Some **markdown**'
+ expect(first.notes).to eq "Some **markdown**"
- second = meeting.agenda_items.find_by(title: 'Reference')
+ second = meeting.agenda_items.find_by(title: "Reference")
expect(second.duration_in_minutes).to eq 5
expect(second.author).to eq user
- expect(second.notes).to eq 'Some **markdown**'
+ expect(second.notes).to eq "Some **markdown**"
expect(second.work_package).to eq work_package
end
- it 'uses default duration of 1h if not specified' do
- meeting = Meeting.find_by(title: 'Implicit 1h duration')
+ it "uses default duration of 1h if not specified" do
+ meeting = Meeting.find_by(title: "Implicit 1h duration")
expect(meeting.duration).to eq 1
end
end
diff --git a/modules/meeting/spec/services/meeting_contents/update_service_spec.rb b/modules/meeting/spec/services/meeting_contents/update_service_spec.rb
index d7f898747e94..0d7c63e45e13 100644
--- a/modules/meeting/spec/services/meeting_contents/update_service_spec.rb
+++ b/modules/meeting/spec/services/meeting_contents/update_service_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'services/base_services/behaves_like_update_service'
+require "spec_helper"
+require "services/base_services/behaves_like_update_service"
RSpec.describe MeetingContents::UpdateService, type: :model do
- it_behaves_like 'BaseServices update service' do
+ it_behaves_like "BaseServices update service" do
let(:factory) { :meeting_agenda }
end
end
diff --git a/modules/meeting/spec/services/meetings/copy_service_integration_spec.rb b/modules/meeting/spec/services/meetings/copy_service_integration_spec.rb
index 979ae2b76ed4..7f855ea018bb 100644
--- a/modules/meeting/spec/services/meetings/copy_service_integration_spec.rb
+++ b/modules/meeting/spec/services/meetings/copy_service_integration_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe Meetings::CopyService, 'integration', type: :model do
+RSpec.describe Meetings::CopyService, "integration", type: :model do
shared_let(:project) { create(:project, enabled_module_names: %i[meetings]) }
shared_let(:user) do
create(:user, member_with_permissions: { project => %i(view_meetings create_meetings) })
end
- shared_let(:meeting) { create(:structured_meeting, project:, start_time: Time.parse('2013-03-27T15:35:00Z')) }
+ shared_let(:meeting) { create(:structured_meeting, project:, start_time: Time.parse("2013-03-27T15:35:00Z")) }
let(:instance) { described_class.new(model: meeting, user:) }
let(:attributes) { {} }
@@ -42,18 +42,18 @@
let(:service_result) { instance.call(attributes:, **params) }
let(:copy) { service_result.result }
- it 'copies the meeting as is' do
+ it "copies the meeting as is" do
expect(service_result).to be_success
expect(copy.author).to eq(user)
expect(copy.start_time).to eq(meeting.start_time + 1.week)
end
- describe 'with participants' do
+ describe "with participants" do
let(:invited_user) { create(:user, member_with_permissions: { project => %i(view_meetings) }) }
let(:attending_user) { create(:user, member_with_permissions: { project => %i(view_meetings) }) }
let(:invalid_user) { create(:user) }
- it 'copies applicable participants, resetting attended status' do
+ it "copies applicable participants, resetting attended status" do
meeting.participants.create!(user: invited_user, invited: true, attended: false)
meeting.participants.create!(user: attending_user, invited: true, attended: true)
meeting.participants.create!(user: invalid_user, invited: true, attended: true)
@@ -73,10 +73,10 @@
end
end
- describe 'when not saving' do
+ describe "when not saving" do
let(:params) { { save: false } }
- it 'builds the meeting' do
+ it "builds the meeting" do
expect(service_result).to be_success
expect(copy.author).to eq(user)
expect(copy.start_time).to eq(meeting.start_time + 1.week)
@@ -84,14 +84,14 @@
end
end
- context 'with agenda items' do
+ context "with agenda items" do
shared_let(:agenda_item) do
create(:meeting_agenda_item,
meeting:,
notes: "hello there")
end
- it 'copies the agenda item' do
+ it "copies the agenda item" do
expect(copy.agenda_items.length)
.to eq 1
@@ -99,16 +99,16 @@
.to eq agenda_item.notes
end
- context 'when asking not to copy agenda' do
+ context "when asking not to copy agenda" do
let(:params) { { copy_agenda: false } }
- it 'does not copy agenda items' do
+ it "does not copy agenda items" do
expect(copy.agenda_items).to be_empty
end
end
end
- context 'with attachments' do
+ context "with attachments" do
shared_let(:attachment) do
create(:attachment,
container: meeting)
@@ -119,7 +119,7 @@
notes: "![](/api/v3/attachments/#{attachment.id}/content")
end
- it 'copies the attachment' do
+ it "copies the attachment" do
expect(copy.attachments.length)
.to eq 1
@@ -130,10 +130,10 @@
expect(copy.agenda_items.first.notes).to include "attachments/#{copy.attachments.first.id}/content"
end
- context 'when asking not to copy attachments' do
+ context "when asking not to copy attachments" do
let(:params) { { copy_attachments: false } }
- it 'does not copy attachments' do
+ it "does not copy attachments" do
expect(copy.attachments).to be_empty
expect(copy.agenda_items.first.notes).to include "attachments/#{attachment.id}/content"
end
diff --git a/modules/meeting/spec/services/meetings/create_service_spec.rb b/modules/meeting/spec/services/meetings/create_service_spec.rb
index 6e4101a89e24..ed6ff57d5623 100644
--- a/modules/meeting/spec/services/meetings/create_service_spec.rb
+++ b/modules/meeting/spec/services/meetings/create_service_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'services/base_services/behaves_like_create_service'
+require "spec_helper"
+require "services/base_services/behaves_like_create_service"
RSpec.describe Meetings::CreateService, type: :model do
- it_behaves_like 'BaseServices create service' do
+ it_behaves_like "BaseServices create service" do
let(:factory) { :meeting }
end
end
diff --git a/modules/meeting/spec/services/meetings/ical_service_spec.rb b/modules/meeting/spec/services/meetings/ical_service_spec.rb
index 38bb479b0d9d..56aad869dc5f 100644
--- a/modules/meeting/spec/services/meetings/ical_service_spec.rb
+++ b/modules/meeting/spec/services/meetings/ical_service_spec.rb
@@ -26,23 +26,23 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Meetings::ICalService, type: :model do
- shared_let(:user) { create(:user, firstname: 'Bob', lastname: 'Barker', mail: 'bob@example.com') }
- shared_let(:user2) { create(:user, firstname: 'Foo', lastname: 'Fooer', mail: 'foo@example.com') }
- shared_let(:project) { create(:project, name: 'My Project') }
+ shared_let(:user) { create(:user, firstname: "Bob", lastname: "Barker", mail: "bob@example.com") }
+ shared_let(:user2) { create(:user, firstname: "Foo", lastname: "Fooer", mail: "foo@example.com") }
+ shared_let(:project) { create(:project, name: "My Project") }
shared_let(:meeting) do
create(:meeting,
author: user,
project:,
- title: 'Important meeting',
+ title: "Important meeting",
participants: [
MeetingParticipant.new(user:),
MeetingParticipant.new(user: user2)
],
- location: 'https://example.com/meet/important-meeting',
+ location: "https://example.com/meet/important-meeting",
start_time: Time.zone.parse("2021-01-19T10:00:00Z"),
duration: 1.0)
end
@@ -52,31 +52,31 @@
subject(:entry) { Icalendar::Event.parse(result).first }
- describe '#call' do
- it 'returns a success' do
+ describe "#call" do
+ it "returns a success" do
expect(service.call).to be_success
end
- context 'when exception is raised' do
+ context "when exception is raised" do
subject { service.call }
before do
allow(service).to receive(:generate_ical).and_raise StandardError.new("Oh noes")
end
- it 'returns a failure' do
+ it "returns a failure" do
expect(subject).to be_failure
expect(subject.message).to eq("Oh noes")
end
end
- it 'renders the ICS file', :aggregate_failures do
+ it "renders the ICS file", :aggregate_failures do
expect(result).to be_a String
- expect(entry.attendee.map(&:to_s)).to contain_exactly('mailto:foo@example.com', 'mailto:bob@example.com')
+ expect(entry.attendee.map(&:to_s)).to contain_exactly("mailto:foo@example.com", "mailto:bob@example.com")
expect(entry.dtstart.utc).to eq meeting.start_time
expect(entry.dtend.utc).to eq meeting.start_time + 1.hour
- expect(entry.summary).to eq '[My Project] Important meeting'
+ expect(entry.summary).to eq "[My Project] Important meeting"
expect(entry.description).to eq "[My Project] Meeting: Important meeting"
expect(entry.location).to eq(meeting.location.presence)
expect(entry.dtstart).to eq Time.zone.parse("2021-01-19T10:00:00Z").in_time_zone("Europe/Berlin")
diff --git a/modules/meeting/spec/services/meetings/update_service_spec.rb b/modules/meeting/spec/services/meetings/update_service_spec.rb
index f0390ca6572c..0c8abaeab289 100644
--- a/modules/meeting/spec/services/meetings/update_service_spec.rb
+++ b/modules/meeting/spec/services/meetings/update_service_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'services/base_services/behaves_like_update_service'
+require "spec_helper"
+require "services/base_services/behaves_like_update_service"
RSpec.describe Meetings::UpdateService, type: :model do
- it_behaves_like 'BaseServices update service' do
+ it_behaves_like "BaseServices update service" do
let(:factory) { :meeting }
end
end
diff --git a/modules/meeting/spec/services/principals/replace_references_service_call_integration_spec.rb b/modules/meeting/spec/services/principals/replace_references_service_call_integration_spec.rb
index 4b16548a5c77..c647bee6981b 100644
--- a/modules/meeting/spec/services/principals/replace_references_service_call_integration_spec.rb
+++ b/modules/meeting/spec/services/principals/replace_references_service_call_integration_spec.rb
@@ -28,10 +28,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe Principals::ReplaceReferencesService, '#call', type: :model do
+RSpec.describe Principals::ReplaceReferencesService, "#call", type: :model do
shared_let(:principal) { create(:user) }
shared_let(:to_principal) { create(:user) }
@@ -41,17 +41,17 @@
described_class.new
end
- shared_examples 'replaces the creator' do
+ shared_examples "replaces the creator" do
before do
model
end
- it 'is successful' do
+ it "is successful" do
expect(service_call)
.to be_success
end
- it 'replaces principal with to_principal' do
+ it "replaces principal with to_principal" do
service_call
model.reload
@@ -59,8 +59,8 @@
end
end
- context 'with MeetingAgendaItem' do
- it_behaves_like 'replaces the creator' do
+ context "with MeetingAgendaItem" do
+ it_behaves_like "replaces the creator" do
let(:model) { create(:meeting_agenda_item, author: principal) }
end
end
diff --git a/modules/meeting/spec/spec_helper.rb b/modules/meeting/spec/spec_helper.rb
index b2e984d0fa2a..9bf43696be67 100644
--- a/modules/meeting/spec/spec_helper.rb
+++ b/modules/meeting/spec/spec_helper.rb
@@ -27,4 +27,4 @@
#++
# -- load spec_helper from OpenProject core
-require 'spec_helper'
+require "spec_helper"
diff --git a/modules/meeting/spec/support/pages/meetings/edit.rb b/modules/meeting/spec/support/pages/meetings/edit.rb
index 92552b59b30e..bdf14e7ac658 100644
--- a/modules/meeting/spec/support/pages/meetings/edit.rb
+++ b/modules/meeting/spec/support/pages/meetings/edit.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative 'base'
-require_relative 'show'
+require_relative "base"
+require_relative "show"
module Pages::Meetings
class Edit < Base
@@ -56,7 +56,7 @@ def uninvite(user)
end
def click_save
- click_button('Save')
+ click_button("Save")
Pages::Meetings::Show.new(meeting)
end
diff --git a/modules/meeting/spec/support/pages/meetings/index.rb b/modules/meeting/spec/support/pages/meetings/index.rb
index 2df01c40d598..2efdae790a33 100644
--- a/modules/meeting/spec/support/pages/meetings/index.rb
+++ b/modules/meeting/spec/support/pages/meetings/index.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative 'new'
+require_relative "new"
module Pages::Meetings
class Index < Pages::Page
@@ -39,72 +39,72 @@ def initialize(project:)
end
def click_create_new
- within '.toolbar-items' do
- click_link 'Meeting'
+ within ".toolbar-items" do
+ click_link "Meeting"
end
New.new(project)
end
def expect_no_main_menu
- expect(page).to have_no_css '#main-menu'
+ expect(page).to have_no_css "#main-menu"
end
def expect_no_create_new_button
- within '.toolbar-items' do
- expect(page).to have_no_css '#add-meeting-button'
+ within ".toolbar-items" do
+ expect(page).to have_no_css "#add-meeting-button"
end
end
def expect_no_create_new_buttons
- within '.toolbar-items' do
- expect(page).to have_no_css '#add-meeting-button'
+ within ".toolbar-items" do
+ expect(page).to have_no_css "#add-meeting-button"
end
- within '#main-menu' do
- expect(page).to have_no_button 'Meeting'
+ within "#main-menu" do
+ expect(page).to have_no_button "Meeting"
end
end
def expect_create_new_button
- within '.toolbar-items' do
- expect(page).to have_css '#add-meeting-button'
+ within ".toolbar-items" do
+ expect(page).to have_css "#add-meeting-button"
end
end
def expect_create_new_buttons
- within '.toolbar-items' do
- expect(page).to have_css '#add-meeting-button'
+ within ".toolbar-items" do
+ expect(page).to have_css "#add-meeting-button"
end
- within '#main-menu' do
- expect(page).to have_button 'Meeting'
+ within "#main-menu" do
+ expect(page).to have_button "Meeting"
end
end
def set_sidebar_filter(filter_name)
- within '#main-menu' do
+ within "#main-menu" do
click_link text: filter_name
end
end
def expect_no_meetings_listed
- within '#content-wrapper' do
+ within "#content-wrapper" do
expect(page)
.to have_content I18n.t(:no_results_title_text)
end
end
def expect_meetings_listed_in_order(*meetings)
- within '.generic-table tbody' do
- listed_meeting_titles = all('tr td.title').map(&:text)
+ within ".generic-table tbody" do
+ listed_meeting_titles = all("tr td.title").map(&:text)
expect(listed_meeting_titles).to eq(meetings.map(&:title))
end
end
def expect_meetings_listed(*meetings)
- within '.generic-table tbody' do
+ within ".generic-table tbody" do
meetings.each do |meeting|
expect(page).to have_css("td.title",
text: meeting.title)
@@ -113,7 +113,7 @@ def expect_meetings_listed(*meetings)
end
def expect_meetings_not_listed(*meetings)
- within '#content-wrapper' do
+ within "#content-wrapper" do
meetings.each do |meeting|
expect(page).to have_no_css("td.title",
text: meeting.title)
@@ -122,7 +122,7 @@ def expect_meetings_not_listed(*meetings)
end
def expect_link_to_meeting_location(meeting)
- within '#content-wrapper' do
+ within "#content-wrapper" do
within row_for(meeting) do
expect(page).to have_link meeting.location
end
@@ -130,45 +130,45 @@ def expect_link_to_meeting_location(meeting)
end
def expect_plaintext_meeting_location(meeting)
- within '#content-wrapper' do
+ within "#content-wrapper" do
within row_for(meeting) do
- expect(page).to have_css('td.location', text: meeting.location)
+ expect(page).to have_css("td.location", text: meeting.location)
expect(page).to have_no_link meeting.location
end
end
end
def expect_no_meeting_location(meeting)
- within '#content-wrapper' do
+ within "#content-wrapper" do
within row_for(meeting) do
- expect(page).to have_css('td.location', text: '')
+ expect(page).to have_css("td.location", text: "")
end
end
end
def expect_to_be_on_page(number)
expect(page)
- .to have_css('.op-pagination--item_current',
+ .to have_css(".op-pagination--item_current",
text: number)
end
def to_page(number)
- within '.op-pagination--pages' do
+ within ".op-pagination--pages" do
click_link number.to_s
end
end
def navigate_by_project_menu
visit project_path(project)
- within '#main-menu' do
- click_link 'Meetings', match: :first
+ within "#main-menu" do
+ click_link "Meetings", match: :first
end
end
def navigate_by_global_menu
visit root_path
- within '#main-menu' do
- click_link 'Meetings', match: :first
+ within "#main-menu" do
+ click_link "Meetings", match: :first
end
end
@@ -183,7 +183,7 @@ def path
private
def row_for(meeting)
- find('td.title', text: meeting.title).ancestor('tr')
+ find("td.title", text: meeting.title).ancestor("tr")
end
end
end
diff --git a/modules/meeting/spec/support/pages/meetings/new.rb b/modules/meeting/spec/support/pages/meetings/new.rb
index 712f9667f3f7..9dd8beec89de 100644
--- a/modules/meeting/spec/support/pages/meetings/new.rb
+++ b/modules/meeting/spec/support/pages/meetings/new.rb
@@ -26,19 +26,19 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative 'base'
-require_relative 'show'
+require_relative "base"
+require_relative "show"
module Pages::Meetings
class New < Base
include Components::Autocompleter::NgSelectAutocompleteHelpers
def expect_no_main_menu
- expect(page).to have_no_css '#main-menu'
+ expect(page).to have_no_css "#main-menu"
end
def click_create
- click_button 'Create'
+ click_button "Create"
meeting = Meeting.last
@@ -54,7 +54,7 @@ def set_type(type)
end
def set_title(text)
- fill_in 'Title', with: text
+ fill_in "Title", with: text
end
def expect_project_dropdown
@@ -64,22 +64,22 @@ def expect_project_dropdown
def set_project(project)
select_autocomplete find("[data-test-selector='project_id']"),
query: project.name,
- results_selector: 'body'
+ results_selector: "body"
end
def set_start_date(date)
- find_by_id('meeting_start_date').click
+ find_by_id("meeting_start_date").click
datepicker = Components::BasicDatepicker.new
datepicker.set_date(date)
end
def set_start_time(time)
- input = page.find_by_id('meeting-form-start-time')
+ input = page.find_by_id("meeting-form-start-time")
page.execute_script("arguments[0].value = arguments[1]", input.native, time)
end
def set_duration(duration)
- fill_in 'Duration', with: duration
+ fill_in "Duration", with: duration
end
def invite(user)
diff --git a/modules/meeting/spec/support/pages/meetings/show.rb b/modules/meeting/spec/support/pages/meetings/show.rb
index 3a3218475595..75c908dfc201 100644
--- a/modules/meeting/spec/support/pages/meetings/show.rb
+++ b/modules/meeting/spec/support/pages/meetings/show.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative 'base'
+require_relative "base"
module Pages::Meetings
class Show < Base
@@ -83,12 +83,12 @@ def expect_plaintext_location(location)
end
def meeting_details_container
- find('.meeting.details')
+ find(".meeting.details")
end
def click_edit
- within '.meeting--main-toolbar .toolbar-items' do
- click_link 'Edit'
+ within ".meeting--main-toolbar .toolbar-items" do
+ click_link "Edit"
end
end
diff --git a/modules/meeting/spec/support/pages/structured_meeting/mobile/show.rb b/modules/meeting/spec/support/pages/structured_meeting/mobile/show.rb
index 0956e4512226..b5a292d1547b 100644
--- a/modules/meeting/spec/support/pages/structured_meeting/mobile/show.rb
+++ b/modules/meeting/spec/support/pages/structured_meeting/mobile/show.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative '../show'
+require_relative "../show"
module Pages::StructuredMeeting::Mobile
class Show < ::Pages::StructuredMeeting::Show
@@ -41,7 +41,7 @@ def open_participant_form
within(meeting_details_container) do
click_button "Show all"
end
- expect(page).to have_css('#meetings-sidebar-participants-form-component')
+ expect(page).to have_css("#meetings-sidebar-participants-form-component")
end
end
end
diff --git a/modules/meeting/spec/support/pages/structured_meeting/show.rb b/modules/meeting/spec/support/pages/structured_meeting/show.rb
index cfd23e03b0bf..6eae44a7c5fe 100644
--- a/modules/meeting/spec/support/pages/structured_meeting/show.rb
+++ b/modules/meeting/spec/support/pages/structured_meeting/show.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative '../meetings/show'
+require_relative "../meetings/show"
module Pages::StructuredMeeting
class Show < ::Pages::Meetings::Show
@@ -44,12 +44,12 @@ def add_agenda_item(type: MeetingAgendaItem, save: true, &)
in_agenda_form do
yield
- click_button('Save') if save
+ click_button("Save") if save
end
end
def cancel_add_form
- page.within('#meeting-agenda-items-new-component') do
+ page.within("#meeting-agenda-items-new-component") do
click_link I18n.t(:button_cancel)
expect(page).to have_no_link I18n.t(:button_cancel)
end
@@ -63,18 +63,18 @@ def cancel_edit_form(item)
end
def in_agenda_form(&)
- page.within('#meeting-agenda-items-form-component', &)
+ page.within("#meeting-agenda-items-form-component", &)
end
def assert_agenda_order!(*titles)
retry_block do
- found = page.all(:test_id, 'op-meeting-agenda-title').map(&:text)
+ found = page.all(:test_id, "op-meeting-agenda-title").map(&:text)
raise "Expected order of agenda items #{titles.inspect}, but found #{found.inspect}" if titles != found
end
end
def remove_agenda_item(item)
- accept_confirm(I18n.t('text_are_you_sure')) do
+ accept_confirm(I18n.t("text_are_you_sure")) do
select_action item, I18n.t(:button_delete)
end
@@ -82,7 +82,7 @@ def remove_agenda_item(item)
end
def expect_agenda_item(title:)
- expect(page).to have_test_selector('op-meeting-agenda-title', text: title)
+ expect(page).to have_test_selector("op-meeting-agenda-title", text: title)
end
def expect_agenda_link(item)
@@ -94,7 +94,7 @@ def expect_agenda_link(item)
end
def expect_agenda_author(name)
- expect(page).to have_test_selector('op-principal', text: name)
+ expect(page).to have_test_selector("op-principal", text: name)
end
def expect_undisclosed_agenda_link(item)
@@ -103,24 +103,24 @@ def expect_undisclosed_agenda_link(item)
end
def expect_no_agenda_item(title:)
- expect(page).not_to have_test_selector('op-meeting-agenda-title', text: title)
+ expect(page).not_to have_test_selector("op-meeting-agenda-title", text: title)
end
def select_action(item, action)
retry_block do
page.within("#meeting-agenda-items-item-component-#{item.id}") do
- page.find_test_selector('op-meeting-agenda-actions').click
+ page.find_test_selector("op-meeting-agenda-actions").click
end
- page.find('.Overlay')
+ page.find(".Overlay")
end
- page.within('.Overlay') do
+ page.within(".Overlay") do
click_on action
end
end
def edit_agenda_item(item, &)
- select_action item, 'Edit'
+ select_action item, "Edit"
expect_item_edit_form(item)
page.within("#meeting-agenda-items-form-component-#{item.id}", &)
end
@@ -135,7 +135,7 @@ def expect_item_edit_form(item, visible: true)
def expect_item_edit_title(item, value)
page.within("#meeting-agenda-items-form-component-#{item.id}") do
- find_field('Title', with: value)
+ find_field("Title", with: value)
end
end
@@ -151,7 +151,7 @@ def clear_item_edit_work_package_title
end
def in_participant_form(&)
- page.within('#meetings-sidebar-participants-form-component form', &)
+ page.within("#meetings-sidebar-participants-form-component form", &)
end
def expect_participant(participant, invited: false, attended: false, editable: true)
@@ -165,25 +165,25 @@ def invite_participant(participant)
end
def expect_available_participants(count:)
- expect(page).to have_link(class: 'op-principal--name', count:)
+ expect(page).to have_link(class: "op-principal--name", count:)
end
def close_meeting
- click_button('Close meeting')
- expect(page).to have_button('Reopen meeting')
+ click_button("Close meeting")
+ expect(page).to have_button("Reopen meeting")
end
def reopen_meeting
- click_button('Reopen meeting')
- expect(page).to have_button('Close meeting')
+ click_button("Reopen meeting")
+ expect(page).to have_button("Close meeting")
end
def close_dialog
- click_button(class: 'Overlay-closeButton')
+ click_button(class: "Overlay-closeButton")
end
def meeting_details_container
- find_by_id('meetings-sidebar-details-component')
+ find_by_id("meetings-sidebar-details-component")
end
end
end
diff --git a/modules/meeting/spec/support/pages/work_package_meetings_tab.rb b/modules/meeting/spec/support/pages/work_package_meetings_tab.rb
index 4010698bc9ee..6278ddf802af 100644
--- a/modules/meeting/spec/support/pages/work_package_meetings_tab.rb
+++ b/modules/meeting/spec/support/pages/work_package_meetings_tab.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'rbconfig'
-require 'support/pages/page'
+require "rbconfig"
+require "support/pages/page"
module Pages
class MeetingsTab < Page
@@ -43,78 +43,78 @@ def path
end
def expect_tab_present
- expect(page).to have_css('.op-tab-row--link', text: 'MEETINGS')
+ expect(page).to have_css(".op-tab-row--link", text: "MEETINGS")
end
def expect_tab_count(count)
- expect(page).to have_css('.op-tab-row--link', text: "MEETINGS (#{count})", wait: 10)
+ expect(page).to have_css(".op-tab-row--link", text: "MEETINGS (#{count})", wait: 10)
end
def expect_tab_not_present
- expect(page).to have_no_css('.op-tab-row--link', text: 'MEETINGS')
+ expect(page).to have_no_css(".op-tab-row--link", text: "MEETINGS")
end
def expect_tab_content_rendered
- expect(page).to have_test_selector('op-work-package-meetings-tab-container')
+ expect(page).to have_test_selector("op-work-package-meetings-tab-container")
end
def expect_upcoming_counter_to_be(amount)
- page.within_test_selector('op-upcoming-meetings-counter') do
+ page.within_test_selector("op-upcoming-meetings-counter") do
expect(page).to have_content(amount)
end
end
def expect_past_counter_to_be(amount)
- page.within_test_selector('op-past-meetings-counter') do
+ page.within_test_selector("op-past-meetings-counter") do
expect(page).to have_content(amount)
end
end
def expect_add_to_meeting_button_present
- expect(page).to have_test_selector('op-add-work-package-to-meeting-dialog-trigger')
+ expect(page).to have_test_selector("op-add-work-package-to-meeting-dialog-trigger")
end
def expect_add_to_meeting_button_not_present
- expect(page).not_to have_test_selector('op-add-work-package-to-meeting-dialog-trigger')
+ expect(page).not_to have_test_selector("op-add-work-package-to-meeting-dialog-trigger")
end
def expect_add_to_meeting_dialog_shown
- expect(page).to have_test_selector('op-add-work-package-to-meeting-dialog-body')
+ expect(page).to have_test_selector("op-add-work-package-to-meeting-dialog-body")
end
def switch_to_upcoming_meetings_section
within container_element do
- find('.tabnav-tab', text: 'Upcoming').click
+ find(".tabnav-tab", text: "Upcoming").click
end
end
def switch_to_past_meetings_section
within container_element do
- find('.tabnav-tab', text: 'Past').click
+ find(".tabnav-tab", text: "Past").click
end
end
def open_add_to_meeting_dialog
- page.find_test_selector('op-add-work-package-to-meeting-dialog-trigger').click
+ page.find_test_selector("op-add-work-package-to-meeting-dialog-trigger").click
end
def fill_and_submit_meeting_dialog(meeting, notes)
- fill_in('meeting_agenda_item_meeting_id', with: meeting.title)
- expect(page).to have_css('.ng-option-marked', text: meeting.title) # wait for selection
- page.find('.ng-option-marked').click
- page.find('.ck-editor__editable').set(notes)
+ fill_in("meeting_agenda_item_meeting_id", with: meeting.title)
+ expect(page).to have_css(".ng-option-marked", text: meeting.title) # wait for selection
+ page.find(".ng-option-marked").click
+ page.find(".ck-editor__editable").set(notes)
- click_button('Save')
+ click_button("Save")
end
private
def container_element
- page.find_test_selector('op-work-package-meetings-tab-container')
+ page.find_test_selector("op-work-package-meetings-tab-container")
end
def osx?
- RbConfig::CONFIG['host_os'].include?('darwin')
+ RbConfig::CONFIG["host_os"].include?("darwin")
end
end
end
diff --git a/modules/my_page/Gemfile b/modules/my_page/Gemfile
index fa75df156323..b4e2a20bb606 100644
--- a/modules/my_page/Gemfile
+++ b/modules/my_page/Gemfile
@@ -1,3 +1,3 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
gemspec
diff --git a/modules/my_page/config/routes.rb b/modules/my_page/config/routes.rb
index a25a741b4328..a29d8d40c028 100644
--- a/modules/my_page/config/routes.rb
+++ b/modules/my_page/config/routes.rb
@@ -27,5 +27,5 @@
#++
Rails.application.routes.draw do
- get '/my/page', to: 'angular#empty_layout'
+ get "/my/page", to: "angular#empty_layout"
end
diff --git a/modules/my_page/lib/my_page/engine.rb b/modules/my_page/lib/my_page/engine.rb
index 9da20e2359e7..fc120248e3fb 100644
--- a/modules/my_page/lib/my_page/engine.rb
+++ b/modules/my_page/lib/my_page/engine.rb
@@ -6,10 +6,10 @@ class Engine < ::Rails::Engine
MyPage::GridRegistration.register!
end
- initializer 'my_page.conversion' do
+ initializer "my_page.conversion" do
require Rails.root.join("config/constants/ar_to_api_conversions")
- Constants::ARToAPIConversions.add('grids/my_page': 'grid')
+ Constants::ARToAPIConversions.add("grids/my_page": "grid")
end
end
end
diff --git a/modules/my_page/lib/my_page/grid_registration.rb b/modules/my_page/lib/my_page/grid_registration.rb
index 1f4808b98082..6e0085812dcd 100644
--- a/modules/my_page/lib/my_page/grid_registration.rb
+++ b/modules/my_page/lib/my_page/grid_registration.rb
@@ -1,43 +1,43 @@
module MyPage
class GridRegistration < ::Grids::Configuration::Registration
- grid_class 'Grids::MyPage'
+ grid_class "Grids::MyPage"
to_scope :my_page_path
- widgets 'custom_text',
- 'documents',
- 'work_packages_assigned',
- 'work_packages_accountable',
- 'work_packages_watched',
- 'work_packages_created',
- 'work_packages_calendar',
- 'work_packages_table',
- 'time_entries_current_user',
- 'news'
+ widgets "custom_text",
+ "documents",
+ "work_packages_assigned",
+ "work_packages_accountable",
+ "work_packages_watched",
+ "work_packages_created",
+ "work_packages_calendar",
+ "work_packages_table",
+ "time_entries_current_user",
+ "news"
wp_table_strategy_proc = Proc.new do
after_destroy -> { ::Query.find_by(id: options[:queryId])&.destroy }
allowed ->(user, _project) { user.allowed_in_any_project?(:save_queries) }
- options_representer '::API::V3::Grids::Widgets::QueryOptionsRepresenter'
+ options_representer "::API::V3::Grids::Widgets::QueryOptionsRepresenter"
end
- widget_strategy 'work_packages_table', &wp_table_strategy_proc
- widget_strategy 'work_packages_assigned', &wp_table_strategy_proc
- widget_strategy 'work_packages_accountable', &wp_table_strategy_proc
- widget_strategy 'work_packages_watched', &wp_table_strategy_proc
- widget_strategy 'work_packages_created', &wp_table_strategy_proc
+ widget_strategy "work_packages_table", &wp_table_strategy_proc
+ widget_strategy "work_packages_assigned", &wp_table_strategy_proc
+ widget_strategy "work_packages_accountable", &wp_table_strategy_proc
+ widget_strategy "work_packages_watched", &wp_table_strategy_proc
+ widget_strategy "work_packages_created", &wp_table_strategy_proc
- widget_strategy 'time_entries_current_user' do
- options_representer '::API::V3::Grids::Widgets::TimeEntryCalendarOptionsRepresenter'
+ widget_strategy "time_entries_current_user" do
+ options_representer "::API::V3::Grids::Widgets::TimeEntryCalendarOptionsRepresenter"
end
- widget_strategy 'custom_text' do
+ widget_strategy "custom_text" do
# Requiring a permission here as one is required to assign attachments.
# Should be replaced by a global permission to have a my page
allowed ->(user, _project) { user.allowed_in_any_project?(:view_project) }
- options_representer '::API::V3::Grids::Widgets::CustomTextOptionsRepresenter'
+ options_representer "::API::V3::Grids::Widgets::CustomTextOptionsRepresenter"
end
defaults -> {
@@ -46,30 +46,30 @@ class GridRegistration < ::Grids::Configuration::Registration
column_count: 2,
widgets: [
{
- identifier: 'work_packages_table',
+ identifier: "work_packages_table",
start_row: 1,
end_row: 2,
start_column: 1,
end_column: 2,
options: {
- name: I18n.t('js.grid.widgets.work_packages_assigned.title'),
+ name: I18n.t("js.grid.widgets.work_packages_assigned.title"),
queryProps: {
- 'columns[]': %w(id project type subject),
+ "columns[]": %w(id project type subject),
filters: JSON.dump([{ status: { operator: "o", values: [] } },
{ assigned_to: { operator: "=", values: ["me"] } }])
}
}
},
{
- identifier: 'work_packages_table',
+ identifier: "work_packages_table",
start_row: 1,
end_row: 2,
start_column: 2,
end_column: 3,
options: {
- name: I18n.t('js.grid.widgets.work_packages_created.title'),
+ name: I18n.t("js.grid.widgets.work_packages_created.title"),
queryProps: {
- 'columns[]': %w(id project type subject),
+ "columns[]": %w(id project type subject),
filters: JSON.dump([{ status: { operator: "o", values: [] } },
{ author: { operator: "=", values: ["me"] } }])
}
diff --git a/modules/my_page/my_page.gemspec b/modules/my_page/my_page.gemspec
index d9bc2a813ab2..cfe498374cb1 100644
--- a/modules/my_page/my_page.gemspec
+++ b/modules/my_page/my_page.gemspec
@@ -1,11 +1,11 @@
Gem::Specification.new do |s|
s.name = "my_page"
- s.version = '1.0.0'
+ s.version = "1.0.0"
s.authors = ["OpenProject"]
s.summary = "OpenProject MyPage."
s.files = Dir["{app,config,db,lib}/**/*"]
- s.add_dependency 'grids'
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.add_dependency "grids"
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/my_page/spec/contracts/grids/create_contract_spec.rb b/modules/my_page/spec/contracts/grids/create_contract_spec.rb
index 0e49aadc67ab..09b554ae265b 100644
--- a/modules/my_page/spec/contracts/grids/create_contract_spec.rb
+++ b/modules/my_page/spec/contracts/grids/create_contract_spec.rb
@@ -26,31 +26,31 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_examples'
+require "spec_helper"
+require_relative "shared_examples"
RSpec.describe Grids::CreateContract do
- include_context 'grid contract'
- include_context 'model contract'
+ include_context "grid contract"
+ include_context "model contract"
- it_behaves_like 'shared grid contract attributes'
+ it_behaves_like "shared grid contract attributes"
- describe 'user_id' do
- context 'for a Grids::MyPage' do
+ describe "user_id" do
+ context "for a Grids::MyPage" do
let(:grid) { build_stubbed(:my_page, default_values) }
- it_behaves_like 'is writable' do
+ it_behaves_like "is writable" do
let(:attribute) { :user_id }
let(:value) { 5 }
end
end
end
- describe 'project_id' do
- context 'for a Grids::MyPage' do
+ describe "project_id" do
+ context "for a Grids::MyPage" do
let(:grid) { build_stubbed(:my_page, default_values) }
- it_behaves_like 'is not writable' do
+ it_behaves_like "is not writable" do
let(:attribute) { :project_id }
let(:value) { 5 }
end
diff --git a/modules/my_page/spec/contracts/grids/shared_examples.rb b/modules/my_page/spec/contracts/grids/shared_examples.rb
index 00634fc97938..82596925ce85 100644
--- a/modules/my_page/spec/contracts/grids/shared_examples.rb
+++ b/modules/my_page/spec/contracts/grids/shared_examples.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-RSpec.shared_context 'grid contract' do
+RSpec.shared_context "grid contract" do
let(:user) { build_stubbed(:user) }
let(:instance) { described_class.new(grid, user) }
let(:default_values) do
@@ -41,12 +41,12 @@
end
end
-RSpec.shared_examples_for 'shared grid contract attributes' do
- include_context 'model contract'
+RSpec.shared_examples_for "shared grid contract attributes" do
+ include_context "model contract"
let(:model) { grid }
- describe 'widgets' do
- it_behaves_like 'is writable' do
+ describe "widgets" do
+ it_behaves_like "is writable" do
let(:attribute) { :widgets }
let(:value) do
[
@@ -54,233 +54,233 @@
end_row: 4,
start_column: 2,
end_column: 5,
- identifier: 'news')
+ identifier: "news")
]
end
end
- context 'invalid identifier' do
+ context "invalid identifier" do
before do
grid.widgets.build(start_row: 1,
end_row: 4,
start_column: 2,
end_column: 5,
- identifier: 'bogus_identifier')
+ identifier: "bogus_identifier")
end
- it 'is invalid' do
+ it "is invalid" do
expect(instance.validate)
.to be_falsey
end
- it 'notes the error' do
+ it "notes the error" do
instance.validate
expect(instance.errors.details[:widgets])
.to contain_exactly({ error: :inclusion })
end
end
- context 'collisions between widgets' do
+ context "collisions between widgets" do
before do
grid.widgets.build(start_row: 1,
end_row: 3,
start_column: 1,
end_column: 3,
- identifier: 'news')
+ identifier: "news")
grid.widgets.build(start_row: 2,
end_row: 4,
start_column: 2,
end_column: 4,
- identifier: 'documents')
+ identifier: "documents")
end
- it 'is invalid' do
+ it "is invalid" do
expect(instance.validate)
.to be_falsey
end
- it 'notes the error' do
+ it "notes the error" do
instance.validate
expect(instance.errors.details[:widgets])
.to contain_exactly({ error: :overlaps }, { error: :overlaps })
end
end
- context 'widgets having the same start column as another\'s end column' do
+ context "widgets having the same start column as another's end column" do
before do
grid.widgets.build(start_row: 1,
end_row: 3,
start_column: 1,
end_column: 3,
- identifier: 'news')
+ identifier: "news")
grid.widgets.build(start_row: 1,
end_row: 3,
start_column: 3,
end_column: 4,
- identifier: 'documents')
+ identifier: "documents")
end
- it 'is valid' do
+ it "is valid" do
expect(instance.validate)
.to be_truthy
end
end
- context 'widgets having the same start row as another\'s end row' do
+ context "widgets having the same start row as another's end row" do
before do
grid.widgets.build(start_row: 1,
end_row: 3,
start_column: 1,
end_column: 3,
- identifier: 'news')
+ identifier: "news")
grid.widgets.build(start_row: 3,
end_row: 4,
start_column: 1,
end_column: 3,
- identifier: 'documents')
+ identifier: "documents")
end
- it 'is valid' do
+ it "is valid" do
expect(instance.validate)
.to be_truthy
end
end
- context 'widgets being outside (max) of the grid' do
+ context "widgets being outside (max) of the grid" do
before do
grid.widgets.build(start_row: 1,
end_row: grid.row_count + 2,
start_column: 1,
end_column: 3,
- identifier: 'news')
+ identifier: "news")
end
- it 'is invalid' do
+ it "is invalid" do
expect(instance.validate)
.to be_falsey
end
- it 'notes the error' do
+ it "notes the error" do
instance.validate
expect(instance.errors.details[:widgets])
.to contain_exactly({ error: :outside })
end
end
- context 'widgets being outside (min) of the grid' do
+ context "widgets being outside (min) of the grid" do
before do
grid.widgets.build(start_row: 1,
end_row: 2,
start_column: -1,
end_column: 3,
- identifier: 'news')
+ identifier: "news")
end
- it 'is invalid' do
+ it "is invalid" do
expect(instance.validate)
.to be_falsey
end
- it 'notes the error' do
+ it "notes the error" do
instance.validate
expect(instance.errors.details[:widgets])
.to contain_exactly({ error: :outside })
end
end
- context 'widgets spanning the whole grid' do
+ context "widgets spanning the whole grid" do
before do
grid.widgets.build(start_row: 1,
end_row: grid.row_count + 1,
start_column: 1,
end_column: grid.column_count + 1,
- identifier: 'news')
+ identifier: "news")
end
- it 'is valid' do
+ it "is valid" do
expect(instance.validate)
.to be_truthy
end
end
- context 'widgets having start after end column' do
+ context "widgets having start after end column" do
before do
grid.widgets.build(start_row: 1,
end_row: 2,
start_column: 4,
end_column: 3,
- identifier: 'news')
+ identifier: "news")
end
- it 'is invalid' do
+ it "is invalid" do
expect(instance.validate)
.to be_falsey
end
- it 'notes the error' do
+ it "notes the error" do
instance.validate
expect(instance.errors.details[:widgets])
.to contain_exactly({ error: :end_before_start })
end
end
- context 'widgets having start after end row' do
+ context "widgets having start after end row" do
before do
grid.widgets.build(start_row: 4,
end_row: 2,
start_column: 1,
end_column: 3,
- identifier: 'news')
+ identifier: "news")
end
- it 'is invalid' do
+ it "is invalid" do
expect(instance.validate)
.to be_falsey
end
- it 'notes the error' do
+ it "notes the error" do
instance.validate
expect(instance.errors.details[:widgets])
.to contain_exactly({ error: :end_before_start })
end
end
- context 'widgets having start equals end column' do
+ context "widgets having start equals end column" do
before do
grid.widgets.build(start_row: 1,
end_row: 2,
start_column: 4,
end_column: 3,
- identifier: 'news')
+ identifier: "news")
end
- it 'is invalid' do
+ it "is invalid" do
expect(instance.validate)
.to be_falsey
end
- it 'notes the error' do
+ it "notes the error" do
instance.validate
expect(instance.errors.details[:widgets])
.to contain_exactly({ error: :end_before_start })
end
end
- context 'widgets having start equals end row' do
+ context "widgets having start equals end row" do
before do
grid.widgets.build(start_row: 2,
end_row: 2,
start_column: 1,
end_column: 3,
- identifier: 'news')
+ identifier: "news")
end
- it 'is invalid' do
+ it "is invalid" do
expect(instance.validate)
.to be_falsey
end
- it 'notes the error' do
+ it "notes the error" do
instance.validate
expect(instance.errors.details[:widgets])
.to contain_exactly({ error: :end_before_start })
@@ -288,19 +288,19 @@
end
end
- describe 'valid grid subclasses' do
- context 'for a registered subclass' do
+ describe "valid grid subclasses" do
+ context "for a registered subclass" do
let(:grid) do
build_stubbed(:my_page, default_values)
end
- it 'is valid' do
+ it "is valid" do
expect(instance.validate)
.to be_truthy
end
end
- context 'for the Grid superclass itself' do
+ context "for the Grid superclass itself" do
let(:grid) do
build_stubbed(:grid, default_values)
end
@@ -309,7 +309,7 @@
instance.validate
end
- it 'is invalid for the grid superclass itself' do
+ it "is invalid for the grid superclass itself" do
expect(instance.errors.details[:scope])
.to contain_exactly({ error: :inclusion })
end
diff --git a/modules/my_page/spec/contracts/grids/update_contract_spec.rb b/modules/my_page/spec/contracts/grids/update_contract_spec.rb
index 028653ec5398..909e8ad7501a 100644
--- a/modules/my_page/spec/contracts/grids/update_contract_spec.rb
+++ b/modules/my_page/spec/contracts/grids/update_contract_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_examples'
+require "spec_helper"
+require_relative "shared_examples"
RSpec.describe Grids::UpdateContract do
- include_context 'model contract'
- include_context 'grid contract'
+ include_context "model contract"
+ include_context "grid contract"
- it_behaves_like 'shared grid contract attributes'
+ it_behaves_like "shared grid contract attributes"
end
diff --git a/modules/my_page/spec/factories/grid_factory.rb b/modules/my_page/spec/factories/grid_factory.rb
index 14fb7b9ac8de..be2158a85460 100644
--- a/modules/my_page/spec/factories/grid_factory.rb
+++ b/modules/my_page/spec/factories/grid_factory.rb
@@ -1,19 +1,19 @@
FactoryBot.define do
- factory :my_page, class: 'Grids::MyPage' do
+ factory :my_page, class: "Grids::MyPage" do
user
row_count { 7 }
column_count { 4 }
widgets do
[
Grids::Widget.new(
- identifier: 'news',
+ identifier: "news",
start_row: 1,
end_row: 7,
start_column: 1,
end_column: 3
),
Grids::Widget.new(
- identifier: 'documents',
+ identifier: "documents",
start_row: 1,
end_row: 7,
start_column: 3,
diff --git a/modules/my_page/spec/features/my/accountable_spec.rb b/modules/my_page/spec/features/my/accountable_spec.rb
index a73ec008d80d..e595cbc5c325 100644
--- a/modules/my_page/spec/features/my/accountable_spec.rb
+++ b/modules/my_page/spec/features/my/accountable_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../../support/pages/my/page'
+require_relative "../../support/pages/my/page"
-RSpec.describe 'Accountable widget on my page', :js do
+RSpec.describe "Accountable widget on my page", :js do
let!(:type) { create(:type) }
let!(:priority) { create(:default_priority) }
let!(:project) { create(:project, types: [type]) }
@@ -77,12 +77,12 @@
my_page.visit!
end
- it 'can add the widget and see the work packages the user is accountable for' do
+ it "can add the widget and see the work packages the user is accountable for" do
# Added to ensure the page has finished loading.
# The page starts with a "wp created widget".
- created_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(2)')
+ created_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(2)")
expect(created_area.area)
- .to have_css('.subject', text: accountable_work_package.subject)
+ .to have_css(".subject", text: accountable_work_package.subject)
# Add widget below existing widgets
my_page.add_widget(2, 2, :row, "Work packages I am accountable for")
@@ -92,30 +92,30 @@
# browser can get confused. Therefore we wait.
sleep(1)
- my_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ my_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
- accountable_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(3)')
+ accountable_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(3)")
accountable_area.expect_to_span(2, 2, 3, 3)
- assigned_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ assigned_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
assigned_area.remove
- my_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ my_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
- created_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ created_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
created_area.expect_to_span(1, 1, 2, 2)
# as the assigned widget was removed, the numbers have changed
- accountable_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(2)')
+ accountable_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(2)")
accountable_area.expect_to_span(2, 1, 3, 2)
expect(accountable_area.area)
- .to have_css('.subject', text: accountable_work_package.subject)
+ .to have_css(".subject", text: accountable_work_package.subject)
expect(accountable_area.area)
- .to have_no_css('.subject', text: accountable_by_other_work_package.subject)
+ .to have_no_css(".subject", text: accountable_by_other_work_package.subject)
expect(accountable_area.area)
- .to have_no_css('.subject', text: accountable_but_invisible_work_package.subject)
+ .to have_no_css(".subject", text: accountable_but_invisible_work_package.subject)
end
end
diff --git a/modules/my_page/spec/features/my/assigned_to_me_spec.rb b/modules/my_page/spec/features/my/assigned_to_me_spec.rb
index 9c3cbcea941a..fff827fe278d 100644
--- a/modules/my_page/spec/features/my/assigned_to_me_spec.rb
+++ b/modules/my_page/spec/features/my/assigned_to_me_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../../support/pages/my/page'
+require_relative "../../support/pages/my/page"
-RSpec.describe 'Assigned to me embedded query on my page', :js do
+RSpec.describe "Assigned to me embedded query on my page", :js do
let!(:type) { create(:type) }
let!(:priority) { create(:default_priority) }
let!(:project) { create(:project, types: [type]) }
@@ -38,7 +38,7 @@
let!(:assigned_work_package) do
create(:work_package,
project:,
- subject: 'Assigned to me',
+ subject: "Assigned to me",
type:,
author: user,
assigned_to: user)
@@ -46,7 +46,7 @@
let!(:assigned_work_package_2) do
create(:work_package,
project:,
- subject: 'My task 2',
+ subject: "My task 2",
type:,
author: user,
assigned_to: user)
@@ -54,7 +54,7 @@
let!(:assigned_to_other_work_package) do
create(:work_package,
project:,
- subject: 'Not assigned to me',
+ subject: "Not assigned to me",
type:,
author: user,
assigned_to: other_user)
@@ -75,17 +75,17 @@
let(:my_page) do
Pages::My::Page.new
end
- let(:assigned_area) { Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)') }
- let(:created_area) { Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(2)') }
+ let(:assigned_area) { Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)") }
+ let(:created_area) { Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(2)") }
let(:embedded_table) { Pages::EmbeddedWorkPackagesTable.new(assigned_area.area) }
let(:hierarchies) { Components::WorkPackages::Hierarchies.new }
current_user { user }
- context 'with parent work package' do
+ context "with parent work package" do
let!(:assigned_work_package_child) do
create(:work_package,
- subject: 'Child',
+ subject: "Child",
parent: assigned_work_package,
project:,
type:,
@@ -93,7 +93,7 @@
assigned_to: user)
end
- it 'can toggle hierarchy mode in embedded tables (Regression test #29578)' do
+ it "can toggle hierarchy mode in embedded tables (Regression test #29578)" do
my_page.visit!
# exists as default
@@ -127,28 +127,28 @@
end
end
- it 'can create a new ticket with correct me values (Regression test #28488)' do
+ it "can create a new ticket with correct me values (Regression test #28488)" do
my_page.visit!
# exists as default
assigned_area.expect_to_exist
expect(assigned_area.area)
- .to have_css('.subject', text: assigned_work_package.subject)
+ .to have_css(".subject", text: assigned_work_package.subject)
expect(assigned_area.area)
- .to have_no_css('.subject', text: assigned_to_other_work_package.subject)
+ .to have_no_css(".subject", text: assigned_to_other_work_package.subject)
embedded_table.click_inline_create
subject_field = embedded_table.edit_field(nil, :subject)
subject_field.expect_active!
- subject_field.set_value 'Assigned to me'
+ subject_field.set_value "Assigned to me"
subject_field.save!
embedded_table.expect_toast(
- message: 'Project can\'t be blank.',
+ message: "Project can't be blank.",
type: :error
)
@@ -159,17 +159,17 @@
project_field.set_value project.name
embedded_table.expect_toast(
- message: 'Successful creation. Click here to open this work package in fullscreen view.'
+ message: "Successful creation. Click here to open this work package in fullscreen view."
)
wp = WorkPackage.last
- expect(wp.subject).to eq('Assigned to me')
+ expect(wp.subject).to eq("Assigned to me")
expect(wp.assigned_to_id).to eq(user.id)
embedded_table.expect_work_package_listed wp
end
- it 'can paginate in embedded tables (Regression test #29845)', with_settings: { per_page_options: '1' } do
+ it "can paginate in embedded tables (Regression test #29845)", with_settings: { per_page_options: "1" } do
my_page.visit!
# exists as default
@@ -177,21 +177,21 @@
within assigned_area.area do
expect(page)
- .to have_css('.subject', text: assigned_work_package.subject)
+ .to have_css(".subject", text: assigned_work_package.subject)
expect(page)
- .to have_no_css('.subject', text: assigned_work_package_2.subject)
+ .to have_no_css(".subject", text: assigned_work_package_2.subject)
- page.find('.op-pagination--item button', text: '2').click
+ page.find(".op-pagination--item button", text: "2").click
expect(page)
- .to have_no_css('.subject', text: assigned_work_package.subject)
+ .to have_no_css(".subject", text: assigned_work_package.subject)
expect(page)
- .to have_css('.subject', text: assigned_work_package_2.subject)
+ .to have_css(".subject", text: assigned_work_package_2.subject)
end
assigned_area.resize_to(1, 2)
- my_page.expect_toast(message: I18n.t('js.notice_successful_update'))
+ my_page.expect_toast(message: I18n.t("js.notice_successful_update"))
assigned_area.expect_to_span(1, 1, 2, 3)
# has been moved down by resizing
diff --git a/modules/my_page/spec/features/my/custom_text_spec.rb b/modules/my_page/spec/features/my/custom_text_spec.rb
index 78d99a34bd58..438277a8944a 100644
--- a/modules/my_page/spec/features/my/custom_text_spec.rb
+++ b/modules/my_page/spec/features/my/custom_text_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../../support/pages/my/page'
+require_relative "../../support/pages/my/page"
-RSpec.describe 'Custom text widget on my page', :js do
+RSpec.describe "Custom text widget on my page", :js do
let(:permissions) do
[]
end
@@ -49,9 +49,9 @@
let(:my_page) do
Pages::My::Page.new
end
- let(:image_fixture) { UploadedFile.load_from('spec/fixtures/files/image.png') }
- let(:editor) { Components::WysiwygEditor.new 'body' }
- let(:field) { TextEditorField.new(page, 'description', selector: '.inline-edit--active-field') }
+ let(:image_fixture) { UploadedFile.load_from("spec/fixtures/files/image.png") }
+ let(:editor) { Components::WysiwygEditor.new "body" }
+ let(:field) { TextEditorField.new(page, "description", selector: ".inline-edit--active-field") }
before do
login_as user
@@ -59,56 +59,56 @@
my_page.visit!
end
- it 'can add the widget set custom text and upload attachments' do
+ it "can add the widget set custom text and upload attachments" do
my_page.add_widget(1, 1, :within, "Custom text")
sleep(0.1)
# As the user lacks the manage_public_queries and save_queries permission, no other widget is present
- custom_text_widget = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ custom_text_widget = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
custom_text_widget.expect_to_span(1, 1, 2, 2)
within custom_text_widget.area do
- find('.inplace-editing--container').click
+ find(".inplace-editing--container").click
- expect(page).to have_css('.op-uc-container_editing', wait: 10)
+ expect(page).to have_css(".op-uc-container_editing", wait: 10)
- field.set_value('My own little text')
+ field.set_value("My own little text")
field.save!
expect(page)
- .to have_css('.inline-edit--display-field', text: 'My own little text')
+ .to have_css(".inline-edit--display-field", text: "My own little text")
- find('.inplace-editing--container').click
+ find(".inplace-editing--container").click
- field.set_value('My new text')
+ field.set_value("My new text")
field.cancel_by_click
expect(page)
- .to have_css('.inline-edit--display-field', text: 'My own little text')
+ .to have_css(".inline-edit--display-field", text: "My own little text")
# adding an image
- find('.inplace-editing--container').click
+ find(".inplace-editing--container").click
sleep(0.1)
end
# The drag_attachment is written in a way that it requires to be executed with page on body
# so we cannot have it wrapped in the within block.
- editor.drag_attachment image_fixture.path, 'Image uploaded'
+ editor.drag_attachment image_fixture.path, "Image uploaded"
within custom_text_widget.area do
- expect(page).to have_test_selector('op-attachment-list-item', text: 'image.png')
- expect(page).to have_no_css('notifications-upload-progress')
+ expect(page).to have_test_selector("op-attachment-list-item", text: "image.png")
+ expect(page).to have_no_css("notifications-upload-progress")
field.save!
expect(page)
- .to have_css('#content img', count: 1)
+ .to have_css("#content img", count: 1)
expect(page)
- .not_to have_test_selector('op-attachment-list-item', text: 'image.png')
+ .not_to have_test_selector("op-attachment-list-item", text: "image.png")
end
# ensure no one but the page's user can see the uploaded attachment
diff --git a/modules/my_page/spec/features/my/documents_spec.rb b/modules/my_page/spec/features/my/documents_spec.rb
index f451ccb68edf..562e85d40001 100644
--- a/modules/my_page/spec/features/my/documents_spec.rb
+++ b/modules/my_page/spec/features/my/documents_spec.rb
@@ -26,17 +26,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../../support/pages/my/page'
+require_relative "../../support/pages/my/page"
-RSpec.describe 'My page documents widget', :js do
+RSpec.describe "My page documents widget", :js do
let!(:project) { create(:project) }
let!(:other_project) { create(:project) }
let!(:visible_document) do
create(:document,
project:,
- description: 'blubs')
+ description: "blubs")
end
let!(:invisible_document) do
create(:document,
@@ -59,11 +59,11 @@
my_page.visit!
end
- it 'can add the widget and see the visible documents' do
+ it "can add the widget and see the visible documents" do
# within top-right area, add an additional widget
- my_page.add_widget(1, 1, :within, 'Documents')
+ my_page.add_widget(1, 1, :within, "Documents")
- document_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ document_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
document_area.expect_to_span(1, 1, 2, 2)
expect(page)
@@ -71,7 +71,7 @@
expect(page)
.to have_content visible_document.description
expect(page)
- .to have_content visible_document.created_at.strftime('%m/%d/%Y')
+ .to have_content visible_document.created_at.strftime("%m/%d/%Y")
expect(page)
.to have_no_content invisible_document.title
diff --git a/modules/my_page/spec/features/my/my_page_spec.rb b/modules/my_page/spec/features/my/my_page_spec.rb
index 7bd0992590d1..3058d5d57c9e 100644
--- a/modules/my_page/spec/features/my/my_page_spec.rb
+++ b/modules/my_page/spec/features/my/my_page_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../../support/pages/my/page'
+require_relative "../../support/pages/my/page"
-RSpec.describe 'My page', :js do
+RSpec.describe "My page", :js do
let!(:type) { create(:type) }
let!(:project) { create(:project, types: [type]) }
let!(:open_status) { create(:default_status) }
@@ -97,9 +97,9 @@ def find_area(name)
end
end
- it 'renders the default view, allows altering and saving' do
+ it "renders the default view, allows altering and saving" do
# Waits for the default view to be created
- my_page.expect_toast(message: 'Successful update')
+ my_page.expect_toast(message: "Successful update")
assigned_area.expect_to_exist
created_area.expect_to_exist
@@ -113,7 +113,7 @@ def find_area(name)
.to have_content(assigned_work_package.subject)
# add widget above to right area
- my_page.add_widget(1, 1, :row, 'Calendar')
+ my_page.add_widget(1, 1, :row, "Calendar")
sleep(0.5)
reload_grid!
@@ -131,7 +131,7 @@ def find_area(name)
calendar_area.expect_to_span(1, 1, 2, 2)
# add widget right next to the calendar widget
- my_page.add_widget(1, 2, :within, 'News')
+ my_page.add_widget(1, 2, :within, "News")
sleep(0.5)
reload_grid!
@@ -148,7 +148,7 @@ def find_area(name)
assigned_area.expect_to_span(3, 1, 4, 2)
created_area.expect_to_span(2, 2, 3, 3)
- my_page.add_widget(1, 3, :column, 'Work packages watched by me')
+ my_page.add_widget(1, 3, :column, "Work packages watched by me")
sleep(0.5)
reload_grid!
@@ -161,7 +161,7 @@ def find_area(name)
# that widgets that have been there are moved down
created_area.drag_to(1, 3)
- my_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ my_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
reload_grid!
@@ -176,7 +176,7 @@ def find_area(name)
# as no more widgets start in the second column, that column is removed
news_area.drag_to(1, 3)
- my_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ my_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
reload_grid!
diff --git a/modules/my_page/spec/features/my/my_spent_time_widget_with_a_negative_time_zone_spec.rb b/modules/my_page/spec/features/my/my_spent_time_widget_with_a_negative_time_zone_spec.rb
index e83329dafc04..7c4fa6476b7d 100644
--- a/modules/my_page/spec/features/my/my_spent_time_widget_with_a_negative_time_zone_spec.rb
+++ b/modules/my_page/spec/features/my/my_spent_time_widget_with_a_negative_time_zone_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../../support/pages/my/page'
+require_relative "../../support/pages/my/page"
-RSpec.describe 'My spent time widget with a negative time zone', :js,
+RSpec.describe "My spent time widget with a negative time zone", :js,
driver: :chrome_headless_new,
with_settings: { start_of_week: 1 } do
let(:beginning_of_week) { monday }
@@ -39,11 +39,11 @@
let(:tuesday) { beginning_of_week + 1.day }
let(:thursday) { beginning_of_week + 3.days }
let(:sunday) { beginning_of_week + 6.days }
- let(:time_zone) { 'America/Phoenix' }
+ let(:time_zone) { "America/Phoenix" }
let!(:type) { create(:type) }
let!(:project) { create(:project, types: [type]) }
- let!(:activity) { create(:time_entry_activity, name: 'Development') }
+ let!(:activity) { create(:time_entry_activity, name: "Development") }
let!(:work_package) do
create(:work_package,
project:,
@@ -71,7 +71,7 @@
# Configure the time zone of the browser
# @param [String] time_zone The time zone to set, for instance 'Europe/Paris'
def set_browser_time_zone(time_zone)
- page.driver.browser.execute_cdp('Emulation.setTimezoneOverride', timezoneId: time_zone)
+ page.driver.browser.execute_cdp("Emulation.setTimezoneOverride", timezoneId: time_zone)
end
before do
@@ -80,25 +80,25 @@ def set_browser_time_zone(time_zone)
my_page.visit!
end
- it 'correctly displays non-working days and prefills day when logging time [fix #49779]' do
- my_page.add_widget(1, 1, :within, 'My spent time')
+ it "correctly displays non-working days and prefills day when logging time [fix #49779]" do
+ my_page.add_widget(1, 1, :within, "My spent time")
my_page.expect_and_dismiss_toaster message: I18n.t(:notice_successful_update)
aggregate_failures("non-working days are displayed properly") do
- expect(page).to have_button('Today', disabled: true)
- expect(page).to have_no_css('.fc-day-mon.fc-non-working-day', wait: 0)
- expect(page).to have_css('.fc-day-tue.fc-non-working-day', wait: 0)
- expect(page).to have_no_css('.fc-day-wed.fc-non-working-day', wait: 0)
- expect(page).to have_no_css('.fc-day-thu.fc-non-working-day', wait: 0)
- expect(page).to have_no_css('.fc-day-fri.fc-non-working-day', wait: 0)
- expect(page).to have_css('.fc-day-sat.fc-non-working-day', wait: 0)
- expect(page).to have_css('.fc-day-sun.fc-non-working-day', wait: 0)
+ expect(page).to have_button("Today", disabled: true)
+ expect(page).to have_no_css(".fc-day-mon.fc-non-working-day", wait: 0)
+ expect(page).to have_css(".fc-day-tue.fc-non-working-day", wait: 0)
+ expect(page).to have_no_css(".fc-day-wed.fc-non-working-day", wait: 0)
+ expect(page).to have_no_css(".fc-day-thu.fc-non-working-day", wait: 0)
+ expect(page).to have_no_css(".fc-day-fri.fc-non-working-day", wait: 0)
+ expect(page).to have_css(".fc-day-sat.fc-non-working-day", wait: 0)
+ expect(page).to have_css(".fc-day-sun.fc-non-working-day", wait: 0)
end
aggregate_failures("when clicking a day, time entry day is set to the day clicked (Thursday)") do
find(".fc-day-thu .te-calendar--add-entry", visible: false).click
- time_logging_modal.has_field_with_value 'spentOn', thursday.iso8601
+ time_logging_modal.has_field_with_value "spentOn", thursday.iso8601
end
end
end
diff --git a/modules/my_page/spec/features/my/news_spec.rb b/modules/my_page/spec/features/my/news_spec.rb
index a55e7c16f3f5..853b5ded75bb 100644
--- a/modules/my_page/spec/features/my/news_spec.rb
+++ b/modules/my_page/spec/features/my/news_spec.rb
@@ -26,17 +26,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../../support/pages/my/page'
+require_relative "../../support/pages/my/page"
-RSpec.describe 'My page news widget spec', :js do
+RSpec.describe "My page news widget spec", :js do
let!(:project) { create(:project) }
let!(:other_project) { create(:project) }
let!(:visible_news) do
create(:news,
project:,
- description: 'blubs')
+ description: "blubs")
end
let!(:invisible_news) do
create(:news,
@@ -59,12 +59,12 @@
my_page.visit!
end
- it 'can add the widget and see the visible news' do
+ it "can add the widget and see the visible news" do
# No other widgets exist as the user lacks the permissions for the default widgets
# add widget in top right corner
- my_page.add_widget(1, 1, :within, 'News')
+ my_page.add_widget(1, 1, :within, "News")
- news_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ news_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
news_area.expect_to_span(1, 1, 2, 2)
expect(page)
@@ -74,7 +74,7 @@
expect(page)
.to have_content visible_news.project.name
expect(page)
- .to have_content visible_news.created_at.strftime('%m/%d/%Y')
+ .to have_content visible_news.created_at.strftime("%m/%d/%Y")
expect(page)
.to have_no_content invisible_news.title
diff --git a/modules/my_page/spec/features/my/time_entries_current_user_spec.rb b/modules/my_page/spec/features/my/time_entries_current_user_spec.rb
index 8827bb288977..e7f1e5727bd9 100644
--- a/modules/my_page/spec/features/my/time_entries_current_user_spec.rb
+++ b/modules/my_page/spec/features/my/time_entries_current_user_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../../support/pages/my/page'
+require_relative "../../support/pages/my/page"
-RSpec.describe 'My page time entries current user widget spec', :js do
+RSpec.describe "My page time entries current user widget spec", :js do
let!(:type) { create(:type) }
let!(:project) { create(:project, types: [type]) }
let!(:activity) { create(:time_entry_activity) }
@@ -40,14 +40,14 @@
project:,
type:,
author: user,
- subject: 'First work package')
+ subject: "First work package")
end
let!(:other_work_package) do
create(:work_package,
project:,
type:,
author: user,
- subject: 'Another task')
+ subject: "Another task")
end
let!(:visible_time_entry) do
create(:time_entry,
@@ -57,7 +57,7 @@
user:,
spent_on: Date.current.beginning_of_week(:sunday) + 1.day,
hours: 3,
- comments: 'My comment')
+ comments: "My comment")
end
let!(:visible_time_entry_on_project) do
create(:time_entry,
@@ -67,7 +67,7 @@
user:,
spent_on: Date.current.beginning_of_week(:sunday) + 1.day,
hours: 1,
- comments: 'My comment')
+ comments: "My comment")
end
let!(:other_visible_time_entry) do
create(:time_entry,
@@ -77,7 +77,7 @@
user:,
spent_on: Date.current.beginning_of_week(:sunday) + 4.days,
hours: 2,
- comments: 'My other comment')
+ comments: "My other comment")
end
let!(:last_week_visible_time_entry) do
create(:time_entry,
@@ -87,7 +87,7 @@
user:,
spent_on: Date.current - (Date.current.wday + 3).days,
hours: 8,
- comments: 'My last week comment')
+ comments: "My last week comment")
end
let!(:invisible_time_entry) do
create(:time_entry,
@@ -120,53 +120,53 @@
my_page.visit!
end
- it 'adds the widget which then displays time entries and allows manipulating them' do
+ it "adds the widget which then displays time entries and allows manipulating them" do
# within top-right area, add an additional widget
- my_page.add_widget(1, 1, :within, 'My spent time')
+ my_page.add_widget(1, 1, :within, "My spent time")
- entries_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
+ entries_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
my_page.expect_and_dismiss_toaster message: I18n.t(:notice_successful_update)
entries_area.expect_to_span(1, 1, 2, 2)
- expect(page).to have_no_css('.fc-day-mon.fc-non-working-day')
- expect(page).to have_no_css('.fc-day-tue.fc-non-working-day')
- expect(page).to have_no_css('.fc-day-wed.fc-non-working-day')
- expect(page).to have_no_css('.fc-day-thu.fc-non-working-day')
- expect(page).to have_no_css('.fc-day-fri.fc-non-working-day')
- expect(page).to have_css('.fc-day-sat.fc-non-working-day')
- expect(page).to have_css('.fc-day-sun.fc-non-working-day')
+ expect(page).to have_no_css(".fc-day-mon.fc-non-working-day")
+ expect(page).to have_no_css(".fc-day-tue.fc-non-working-day")
+ expect(page).to have_no_css(".fc-day-wed.fc-non-working-day")
+ expect(page).to have_no_css(".fc-day-thu.fc-non-working-day")
+ expect(page).to have_no_css(".fc-day-fri.fc-non-working-day")
+ expect(page).to have_css(".fc-day-sat.fc-non-working-day")
+ expect(page).to have_css(".fc-day-sun.fc-non-working-day")
expect(page)
.to have_content "Total: 6 h"
expect(page)
- .to have_content visible_time_entry.spent_on.strftime('%-m/%-d')
+ .to have_content visible_time_entry.spent_on.strftime("%-m/%-d")
expect(page)
- .to have_css('.fc-event .fc-event-title', text: "#{project.name} - ##{work_package.id}: #{work_package.subject}")
+ .to have_css(".fc-event .fc-event-title", text: "#{project.name} - ##{work_package.id}: #{work_package.subject}")
expect(page)
- .to have_content(other_visible_time_entry.spent_on.strftime('%-m/%-d'))
+ .to have_content(other_visible_time_entry.spent_on.strftime("%-m/%-d"))
expect(page)
- .to have_css('.fc-event .fc-event-title', text: "#{project.name} - ##{work_package.id}: #{work_package.subject}")
+ .to have_css(".fc-event .fc-event-title", text: "#{project.name} - ##{work_package.id}: #{work_package.subject}")
# go to last week
within entries_area.area do
- find('.fc-toolbar .fc-prev-button').click
+ find(".fc-toolbar .fc-prev-button").click
end
expect(page)
.to have_content "Total: 8 h"
expect(page)
- .to have_content(last_week_visible_time_entry.spent_on.strftime('%-m/%-d'))
+ .to have_content(last_week_visible_time_entry.spent_on.strftime("%-m/%-d"))
expect(page)
- .to have_css('.fc-event .fc-event-title', text: "#{project.name} - ##{work_package.id}: #{work_package.subject}")
+ .to have_css(".fc-event .fc-event-title", text: "#{project.name} - ##{work_package.id}: #{work_package.subject}")
# go to today again
within entries_area.area do
- find('.fc-toolbar .fc-today-button').click
+ find(".fc-toolbar .fc-today-button").click
end
expect(page)
@@ -177,7 +177,7 @@
end
expect(page)
- .to have_css('.ui-tooltip', text: "Project: #{project.name}")
+ .to have_css(".ui-tooltip", text: "Project: #{project.name}")
# Adding a time entry
@@ -190,32 +190,32 @@
time_logging_modal.work_package_is_missing true
- time_logging_modal.has_field_with_value 'spentOn', (Date.current.beginning_of_week(:sunday) + 3.days).strftime
+ time_logging_modal.has_field_with_value "spentOn", (Date.current.beginning_of_week(:sunday) + 3.days).strftime
- time_logging_modal.shows_field 'user', false
+ time_logging_modal.shows_field "user", false
expect(page)
- .to have_no_css('.ng-spinner-loader')
+ .to have_no_css(".ng-spinner-loader")
# Expect filtering works
time_logging_modal.work_package_field.autocomplete work_package.subject, select: false
- expect(page).to have_test_selector('op-autocompleter-item-subject', text: work_package.subject)
- expect(page).not_to have_test_selector('op-autocompleter-item-subject', text: other_work_package.subject)
+ expect(page).to have_test_selector("op-autocompleter-item-subject", text: work_package.subject)
+ expect(page).not_to have_test_selector("op-autocompleter-item-subject", text: other_work_package.subject)
time_logging_modal.update_work_package_field other_work_package.subject
time_logging_modal.work_package_is_missing false
- time_logging_modal.update_field 'comment', 'Comment for new entry'
+ time_logging_modal.update_field "comment", "Comment for new entry"
- time_logging_modal.update_field 'activity', activity.name
+ time_logging_modal.update_field "activity", activity.name
- time_logging_modal.update_field 'hours', 4
+ time_logging_modal.update_field "hours", 4
sleep(0.1)
- time_logging_modal.perform_action 'Save'
+ time_logging_modal.perform_action "Save"
time_logging_modal.is_visible false
my_page.expect_and_dismiss_toaster message: I18n.t(:notice_successful_create)
@@ -240,19 +240,19 @@
time_logging_modal.is_visible true
- time_logging_modal.update_field 'activity', other_activity.name
+ time_logging_modal.update_field "activity", other_activity.name
# As the other_work_package now has time logged, it is now considered to be a
# recent work package.
time_logging_modal.update_work_package_field other_work_package.subject, true
- time_logging_modal.update_field 'hours', 6
+ time_logging_modal.update_field "hours", 6
- time_logging_modal.update_field 'comment', 'Some comment'
+ time_logging_modal.update_field "comment", "Some comment"
- cf_field.set_value('Cf text value')
+ cf_field.set_value("Cf text value")
- time_logging_modal.perform_action 'Save'
+ time_logging_modal.perform_action "Save"
time_logging_modal.is_visible false
sleep(0.1)
@@ -263,32 +263,32 @@
end
expect(page)
- .to have_css('.ui-tooltip', text: "Work package: ##{other_work_package.id}: #{other_work_package.subject}")
+ .to have_css(".ui-tooltip", text: "Work package: ##{other_work_package.id}: #{other_work_package.subject}")
expect(page)
- .to have_css('.ui-tooltip', text: "Hours: 6 h")
+ .to have_css(".ui-tooltip", text: "Hours: 6 h")
expect(page)
- .to have_css('.ui-tooltip', text: "Activity: #{other_activity.name}")
+ .to have_css(".ui-tooltip", text: "Activity: #{other_activity.name}")
expect(page)
- .to have_css('.ui-tooltip', text: "Comment: Some comment")
+ .to have_css(".ui-tooltip", text: "Comment: Some comment")
expect(page)
.to have_content "Total: 13 h"
## Hiding weekdays
- entries_area.click_menu_item I18n.t('js.grid.configure')
+ entries_area.click_menu_item I18n.t("js.grid.configure")
- uncheck 'Monday' # the day visible_time_entry is logged for
+ uncheck "Monday" # the day visible_time_entry is logged for
- click_button 'Apply'
+ click_button "Apply"
within entries_area.area do
expect(page)
- .to have_no_css('.fc-day-header', text: 'Mon')
+ .to have_no_css(".fc-day-header", text: "Mon")
expect(page)
- .to have_no_css('.fc-duration', text: "6 h")
+ .to have_no_css(".fc-duration", text: "6 h")
end
## Removing the time entry
@@ -300,7 +300,7 @@
end
time_logging_modal.is_visible true
- time_logging_modal.perform_action 'Delete'
+ time_logging_modal.perform_action "Delete"
page.driver.browser.switch_to.alert.accept
time_logging_modal.is_visible false
@@ -325,7 +325,7 @@
.to have_css(".te-calendar--time-entry", count: 1)
expect(page)
- .to have_no_css('.fc-col-header-cell', text: 'Mon')
+ .to have_no_css(".fc-col-header-cell", text: "Mon")
end
# Removing the widget
diff --git a/modules/my_page/spec/features/my/work_package_table_spec.rb b/modules/my_page/spec/features/my/work_package_table_spec.rb
index 05b3b564014c..ed49057a3a2f 100644
--- a/modules/my_page/spec/features/my/work_package_table_spec.rb
+++ b/modules/my_page/spec/features/my/work_package_table_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../../support/pages/my/page'
+require_relative "../../support/pages/my/page"
-RSpec.describe 'Arbitrary WorkPackage query table widget on my page', :js do
+RSpec.describe "Arbitrary WorkPackage query table widget on my page", :js do
let!(:type) { create(:type) }
let!(:other_type) { create(:type) }
let!(:priority) { create(:default_priority) }
@@ -72,13 +72,13 @@
my_page.visit!
end
- context 'with the permission to save queries' do
- it 'can add the widget and see the work packages of the filtered for types' do
+ context "with the permission to save queries" do
+ it "can add the widget and see the work packages of the filtered for types" do
# This one always exists by default.
# Using it here as a safeguard to govern speed.
- created_by_me_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(2)')
+ created_by_me_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(2)")
expect(created_by_me_area.area)
- .to have_css('.subject', text: type_work_package.subject)
+ .to have_css(".subject", text: type_work_package.subject)
my_page.add_widget(1, 2, :column, "Work packages table")
@@ -87,50 +87,50 @@
# browser can get confused. Therefore we wait.
sleep(2)
- my_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ my_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
- filter_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(3)')
+ filter_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(3)")
filter_area.expect_to_span(1, 2, 2, 3)
# At the beginning, the default query is displayed
expect(filter_area.area)
- .to have_css('.subject', text: type_work_package.subject)
+ .to have_css(".subject", text: type_work_package.subject)
expect(filter_area.area)
- .to have_css('.subject', text: other_type_work_package.subject)
+ .to have_css(".subject", text: other_type_work_package.subject)
# User has the ability to modify the query
filter_area.configure_wp_table
- modal.switch_to('Filters')
+ modal.switch_to("Filters")
filters.expect_filter_count(2)
- filters.add_filter_by('Type', 'is (OR)', type.name)
+ filters.add_filter_by("Type", "is (OR)", type.name)
modal.save
filter_area.configure_wp_table
- modal.switch_to('Columns')
+ modal.switch_to("Columns")
columns.assume_opened
- columns.remove 'Subject'
+ columns.remove "Subject"
expect(filter_area.area)
- .to have_css('.id', text: type_work_package.id)
+ .to have_css(".id", text: type_work_package.id)
# as the Subject column is disabled
expect(filter_area.area)
- .to have_no_css('.subject', text: type_work_package.subject)
+ .to have_no_css(".subject", text: type_work_package.subject)
# As other_type is filtered out
expect(filter_area.area)
- .to have_no_css('.id', text: other_type_work_package.id)
+ .to have_no_css(".id", text: other_type_work_package.id)
scroll_to_element(filter_area.area)
within filter_area.area do
- input = find('.editable-toolbar-title--input')
- input.set('My WP Filter')
+ input = find(".editable-toolbar-title--input")
+ input.set("My WP Filter")
input.native.send_keys(:return)
end
- my_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ my_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
sleep(1)
@@ -140,28 +140,28 @@
visit root_path
my_page.visit!
- filter_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(3)')
+ filter_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(3)")
expect(filter_area.area)
- .to have_css('.id', text: type_work_package.id)
+ .to have_css(".id", text: type_work_package.id)
# as the Subject column is disabled
expect(filter_area.area)
- .to have_no_css('.subject', text: type_work_package.subject)
+ .to have_no_css(".subject", text: type_work_package.subject)
# As other_type is filtered out
expect(filter_area.area)
- .to have_no_css('.id', text: other_type_work_package.id)
+ .to have_no_css(".id", text: other_type_work_package.id)
within filter_area.area do
- expect(page).to have_field('editable-toolbar-title', with: 'My WP Filter', wait: 10)
+ expect(page).to have_field("editable-toolbar-title", with: "My WP Filter", wait: 10)
end
end
end
- context 'without the permission to save queries' do
+ context "without the permission to save queries" do
let(:permissions) { %i[view_work_packages add_work_packages] }
- it 'cannot add the widget' do
+ it "cannot add the widget" do
my_page.expect_unable_to_add_widget(1, 1, :within, "Work packages table")
end
end
diff --git a/modules/my_page/spec/models/grids/my_page_spec.rb b/modules/my_page/spec/models/grids/my_page_spec.rb
index c6e763ec9380..07d81f91096d 100644
--- a/modules/my_page/spec/models/grids/my_page_spec.rb
+++ b/modules/my_page/spec/models/grids/my_page_spec.rb
@@ -26,26 +26,26 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative 'shared_model'
+require_relative "shared_model"
RSpec.describe Grids::MyPage do
let(:instance) { described_class.new(row_count: 5, column_count: 5) }
let(:user) { build_stubbed(:user) }
- it_behaves_like 'grid attributes'
+ it_behaves_like "grid attributes"
- context 'attributes' do
- it '#user' do
+ context "attributes" do
+ it "#user" do
instance.user = user
expect(instance.user)
.to eql user
end
end
- context 'altering widgets' do
- context 'when removing a work_packages_table widget' do
+ context "altering widgets" do
+ context "when removing a work_packages_table widget" do
let(:user) { create(:user) }
let(:query) do
create(:query,
@@ -53,7 +53,7 @@
end
before do
- widget = Grids::Widget.new(identifier: 'work_packages_table',
+ widget = Grids::Widget.new(identifier: "work_packages_table",
start_row: 1,
end_row: 2,
start_column: 1,
@@ -64,7 +64,7 @@
instance.save!
end
- it 'removes the widget\'s query' do
+ it "removes the widget's query" do
instance.widgets = []
expect(Query.find_by(id: query.id))
diff --git a/modules/my_page/spec/models/grids/shared_model.rb b/modules/my_page/spec/models/grids/shared_model.rb
index 57adc5aeba52..ff54c7b20eb1 100644
--- a/modules/my_page/spec/models/grids/shared_model.rb
+++ b/modules/my_page/spec/models/grids/shared_model.rb
@@ -26,33 +26,33 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-RSpec.shared_examples_for 'grid attributes' do
- describe 'attributes' do
- it '#row_count' do
+RSpec.shared_examples_for "grid attributes" do
+ describe "attributes" do
+ it "#row_count" do
instance.row_count = 5
expect(instance.row_count)
.to be 5
end
- it '#column_count' do
+ it "#column_count" do
instance.column_count = 5
expect(instance.column_count)
.to be 5
end
- it '#name' do
- instance.name = 'custom 123'
+ it "#name" do
+ instance.name = "custom 123"
expect(instance.name)
- .to eql 'custom 123'
+ .to eql "custom 123"
# can be empty
instance.name = nil
expect(instance).to be_valid
end
- it '#options' do
+ it "#options" do
value = {
- some: 'value',
+ some: "value",
and: {
also: 1
}
@@ -63,7 +63,7 @@
.to eql value
end
- it '#widgets' do
+ it "#widgets" do
widgets = [
Grids::Widget.new(start_row: 2),
Grids::Widget.new(start_row: 5)
diff --git a/modules/my_page/spec/queries/grids/filters/scope_filter_spec.rb b/modules/my_page/spec/queries/grids/filters/scope_filter_spec.rb
index 4a96fd9c9611..52e45760069d 100644
--- a/modules/my_page/spec/queries/grids/filters/scope_filter_spec.rb
+++ b/modules/my_page/spec/queries/grids/filters/scope_filter_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Grids::Filters::ScopeFilter, type: :model do
- include_context 'filter tests'
- let(:values) { ['/my/page'] }
+ include_context "filter tests"
+ let(:values) { ["/my/page"] }
let(:user) { build_stubbed(:user) }
let(:model) { Grids::Grid }
@@ -38,19 +38,19 @@
login_as(user)
end
- it_behaves_like 'basic query filter' do
+ it_behaves_like "basic query filter" do
let(:class_key) { :scope }
let(:type) { :list }
let(:model) { Grids::Grid.where(user_id: user.id) }
- let(:values) { ['/my/page'] }
+ let(:values) { ["/my/page"] }
end
- describe '#scope' do
+ describe "#scope" do
context 'for "="' do
- let(:operator) { '=' }
+ let(:operator) { "=" }
- context 'for /my/page do' do
- it 'is the same as handwriting the query' do
+ context "for /my/page do" do
+ it "is the same as handwriting the query" do
expected = model.where("(grids.type IN ('Grids::MyPage'))")
expect(instance.scope.to_sql).to eql expected.to_sql
diff --git a/modules/my_page/spec/queries/grids/query_integration_spec.rb b/modules/my_page/spec/queries/grids/query_integration_spec.rb
index 1197ed5c1bd3..2ba8a1e4f3c4 100644
--- a/modules/my_page/spec/queries/grids/query_integration_spec.rb
+++ b/modules/my_page/spec/queries/grids/query_integration_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Grids::Query, type: :model do
let(:user) { create(:user) }
@@ -43,32 +43,32 @@
login_as(user)
end
- context 'without a filter' do
- describe '#results' do
- it 'is the same as getting all the grids visible to the user' do
+ context "without a filter" do
+ describe "#results" do
+ it "is the same as getting all the grids visible to the user" do
expect(instance.results).to contain_exactly(my_page_grid)
end
end
end
- context 'with a scope filter' do
+ context "with a scope filter" do
before do
- instance.where('scope', '=', ['/my/page'])
+ instance.where("scope", "=", ["/my/page"])
end
- describe '#results' do
- it 'is the same as handwriting the query' do
+ describe "#results" do
+ it "is the same as handwriting the query" do
expect(instance.results).to contain_exactly(my_page_grid)
end
end
- describe '#valid?' do
- it 'is true' do
+ describe "#valid?" do
+ it "is true" do
expect(instance).to be_valid
end
- it 'is invalid if the filter is invalid' do
- instance.where('scope', '!', ['/some/other/page'])
+ it "is invalid if the filter is invalid" do
+ instance.where("scope", "!", ["/some/other/page"])
expect(instance).to be_invalid
end
end
diff --git a/modules/my_page/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb b/modules/my_page/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb
index 9175e3717dfd..5428eadaf247 100644
--- a/modules/my_page/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb
+++ b/modules/my_page/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
RSpec.describe "POST /api/v3/grids/form", content_type: :json do
include Rack::Test::Methods
@@ -50,22 +50,22 @@
login_as(current_user)
end
- describe '#post' do
+ describe "#post" do
before do
- post path, params.to_json, 'CONTENT_TYPE' => 'application/json'
+ post path, params.to_json, "CONTENT_TYPE" => "application/json"
end
- it 'contains a Schema embedding the available values' do
+ it "contains a Schema embedding the available values" do
expect(subject.body)
.to be_json_eql("Schema".to_json)
- .at_path('_embedded/schema/_type')
+ .at_path("_embedded/schema/_type")
expect(subject.body)
.to be_json_eql(my_page_path.to_json)
- .at_path('_embedded/schema/scope/_links/allowedValues/0/href')
+ .at_path("_embedded/schema/scope/_links/allowedValues/0/href")
end
- context 'with /my/page for the scope value' do
+ context "with /my/page for the scope value" do
let(:params) do
{
_links: {
@@ -76,7 +76,7 @@
}
end
- it 'contains default data in the payload' do
+ it "contains default data in the payload" do
expected = {
rowCount: 1,
columnCount: 2,
@@ -84,11 +84,11 @@
widgets: [
{
_type: "GridWidget",
- identifier: 'work_packages_table',
+ identifier: "work_packages_table",
options: {
name: "Work packages assigned to me",
queryProps: {
- 'columns[]': %w(id project type subject),
+ "columns[]": %w(id project type subject),
filters: "[{\"status\":{\"operator\":\"o\",\"values\":[]}},{\"assigned_to\":{\"operator\":\"=\",\"values\":[\"me\"]}}]"
}
},
@@ -99,11 +99,11 @@
},
{
_type: "GridWidget",
- identifier: 'work_packages_table',
+ identifier: "work_packages_table",
options: {
name: "Work packages created by me",
queryProps: {
- 'columns[]': %w(id project type subject),
+ "columns[]": %w(id project type subject),
filters: "[{\"status\":{\"operator\":\"o\",\"values\":[]}},{\"author\":{\"operator\":\"=\",\"values\":[\"me\"]}}]"
}
},
@@ -124,23 +124,23 @@
expect(subject.body)
.to be_json_eql(expected.to_json)
- .at_path('_embedded/payload')
+ .at_path("_embedded/payload")
end
- it 'has no validationErrors' do
+ it "has no validationErrors" do
expect(subject.body)
.to be_json_eql({}.to_json)
- .at_path('_embedded/validationErrors')
+ .at_path("_embedded/validationErrors")
end
- it 'has a commit link' do
+ it "has a commit link" do
expect(subject.body)
.to be_json_eql(api_v3_paths.grids.to_json)
- .at_path('_links/commit/href')
+ .at_path("_links/commit/href")
end
end
- context 'with an unsupported widget identifier' do
+ context "with an unsupported widget identifier" do
let(:params) do
{
_links: {
@@ -161,17 +161,17 @@
}
end
- it 'has a validationError on widget' do
+ it "has a validationError on widget" do
expect(subject.body)
.to be_json_eql("Widgets is not set to one of the allowed values.".to_json)
- .at_path('_embedded/validationErrors/widgets/message')
+ .at_path("_embedded/validationErrors/widgets/message")
end
end
- context 'with name set' do
+ context "with name set" do
let(:params) do
{
- name: 'My custom grid 1',
+ name: "My custom grid 1",
_links: {
scope: {
href: my_page_path
@@ -180,18 +180,18 @@
}
end
- it 'feeds it back' do
+ it "feeds it back" do
expect(subject.body)
.to be_json_eql("My custom grid 1".to_json)
- .at_path('_embedded/payload/name')
+ .at_path("_embedded/payload/name")
end
end
- context 'with options set' do
+ context "with options set" do
let(:params) do
{
options: {
- foo: 'bar'
+ foo: "bar"
},
_links: {
scope: {
@@ -201,10 +201,10 @@
}
end
- it 'feeds them back' do
+ it "feeds them back" do
expect(subject.body)
.to be_json_eql("bar".to_json)
- .at_path('_embedded/payload/options/foo')
+ .at_path("_embedded/payload/options/foo")
end
end
end
diff --git a/modules/my_page/spec/requests/api/v3/grids/grids_resource_spec.rb b/modules/my_page/spec/requests/api/v3/grids/grids_resource_spec.rb
index 7ab52ed79da9..110bb9d1d629 100644
--- a/modules/my_page/spec/requests/api/v3/grids/grids_resource_spec.rb
+++ b/modules/my_page/spec/requests/api/v3/grids/grids_resource_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'API v3 Grids resource', content_type: :json do
+RSpec.describe "API v3 Grids resource", content_type: :json do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -49,7 +49,7 @@
subject(:response) { last_response }
- describe '#get INDEX' do
+ describe "#get INDEX" do
let(:path) { api_v3_paths.grids }
let(:stored_grids) do
@@ -63,21 +63,21 @@
get path
end
- it 'sends a collection of grids but only those visible to the current user' do
+ it "sends a collection of grids but only those visible to the current user" do
expect(subject.body)
- .to be_json_eql('Collection'.to_json)
- .at_path('_type')
+ .to be_json_eql("Collection".to_json)
+ .at_path("_type")
expect(subject.body)
- .to be_json_eql('Grid'.to_json)
- .at_path('_embedded/elements/0/_type')
+ .to be_json_eql("Grid".to_json)
+ .at_path("_embedded/elements/0/_type")
expect(subject.body)
.to be_json_eql(1.to_json)
- .at_path('total')
+ .at_path("total")
end
- context 'with a filter on the scope attribute' do
+ context "with a filter on the scope attribute" do
shared_let(:other_grid) do
grid = Grids::Grid.new(row_count: 20,
column_count: 20)
@@ -97,36 +97,36 @@
end
let(:path) do
- filter = [{ 'scope' =>
+ filter = [{ "scope" =>
{
- 'operator' => '=',
- 'values' => [my_page_path]
+ "operator" => "=",
+ "values" => [my_page_path]
} }]
"#{api_v3_paths.grids}?#{{ filters: filter.to_json }.to_query}"
end
- it 'responds with 200 OK' do
+ it "responds with 200 OK" do
expect(subject.status).to eq(200)
end
- it 'sends only the my page of the current user' do
+ it "sends only the my page of the current user" do
expect(subject.body)
- .to be_json_eql('Collection'.to_json)
- .at_path('_type')
+ .to be_json_eql("Collection".to_json)
+ .at_path("_type")
expect(subject.body)
- .to be_json_eql('Grid'.to_json)
- .at_path('_embedded/elements/0/_type')
+ .to be_json_eql("Grid".to_json)
+ .at_path("_embedded/elements/0/_type")
expect(subject.body)
.to be_json_eql(1.to_json)
- .at_path('total')
+ .at_path("total")
end
end
end
- describe '#get' do
+ describe "#get" do
let(:path) { api_v3_paths.grid(my_page_grid.id) }
let(:stored_grids) do
@@ -139,35 +139,35 @@
get path
end
- it 'responds with 200 OK' do
+ it "responds with 200 OK" do
expect(subject.status).to eq(200)
end
- it 'sends a grid block' do
+ it "sends a grid block" do
expect(subject.body)
- .to be_json_eql('Grid'.to_json)
- .at_path('_type')
+ .to be_json_eql("Grid".to_json)
+ .at_path("_type")
end
- it 'identifies the url the grid is stored for' do
+ it "identifies the url the grid is stored for" do
expect(subject.body)
.to be_json_eql(my_page_path.to_json)
- .at_path('_links/scope/href')
+ .at_path("_links/scope/href")
end
- context 'with the page not existing' do
+ context "with the page not existing" do
let(:stored_grids) do
# no pages exist so the page requests for is not existing as well
end
let(:path) { api_v3_paths.grid(5) }
- it 'responds with 404 NOT FOUND' do
+ it "responds with 404 NOT FOUND" do
expect(subject.status).to be 404
end
end
- context 'with the grid belonging to someone else' do
+ context "with the grid belonging to someone else" do
let(:stored_grids) do
my_page_grid
other_my_page_grid
@@ -175,19 +175,19 @@
let(:path) { api_v3_paths.grid(other_my_page_grid.id) }
- it 'responds with 404 NOT FOUND' do
+ it "responds with 404 NOT FOUND" do
expect(subject.status).to be 404
end
end
end
- describe '#patch' do
+ describe "#patch" do
let(:path) { api_v3_paths.grid(my_page_grid.id) }
let(:params) do
{
rowCount: 10,
- name: 'foo',
+ name: "foo",
columnCount: 15,
widgets: [{
identifier: "documents",
@@ -206,34 +206,34 @@
before do
stored_grids
- patch path, params.to_json, 'CONTENT_TYPE' => 'application/json'
+ patch path, params.to_json, "CONTENT_TYPE" => "application/json"
end
- it 'responds with 200 OK' do
+ it "responds with 200 OK" do
expect(subject.status).to eq(200)
end
- it 'returns the altered grid block' do
+ it "returns the altered grid block" do
expect(subject.body)
- .to be_json_eql('Grid'.to_json)
- .at_path('_type')
+ .to be_json_eql("Grid".to_json)
+ .at_path("_type")
expect(subject.body)
- .to be_json_eql('foo'.to_json)
- .at_path('name')
+ .to be_json_eql("foo".to_json)
+ .at_path("name")
expect(subject.body)
- .to be_json_eql(params['rowCount'].to_json)
- .at_path('rowCount')
+ .to be_json_eql(params["rowCount"].to_json)
+ .at_path("rowCount")
expect(subject.body)
- .to be_json_eql(params['widgets'][0]['identifier'].to_json)
- .at_path('widgets/0/identifier')
+ .to be_json_eql(params["widgets"][0]["identifier"].to_json)
+ .at_path("widgets/0/identifier")
end
- it 'perists the changes' do
+ it "perists the changes" do
expect(my_page_grid.reload.row_count)
- .to eql params['rowCount']
+ .to eql params["rowCount"]
end
- context 'with invalid params' do
+ context "with invalid params" do
let(:params) do
{
rowCount: -5,
@@ -248,42 +248,42 @@
}.with_indifferent_access
end
- it 'responds with 422 and mentions the error' do
+ it "responds with 422 and mentions the error" do
expect(subject.status).to eq 422
- expect(JSON.parse(subject.body)['_embedded']['errors'].map { |e| e['message'] })
+ expect(JSON.parse(subject.body)["_embedded"]["errors"].map { |e| e["message"] })
.to contain_exactly("Widgets is outside of the grid.", "Number of rows must be greater than 0.")
end
- it 'does not persist the changes to widgets' do
+ it "does not persist the changes to widgets" do
expect(my_page_grid.reload.widgets.count)
.to eql MyPage::GridRegistration.defaults[:widgets].size
end
end
- context 'with a scope param' do
+ context "with a scope param" do
let(:params) do
{
_links: {
scope: {
- href: ''
+ href: ""
}
}
}.with_indifferent_access
end
- it_behaves_like 'read-only violation', 'scope', Grids::Grid
+ it_behaves_like "read-only violation", "scope", Grids::Grid
end
- context 'with the page not existing' do
+ context "with the page not existing" do
let(:path) { api_v3_paths.grid(5) }
- it 'responds with 404 NOT FOUND' do
+ it "responds with 404 NOT FOUND" do
expect(subject.status).to be 404
end
end
- context 'with the grid belonging to someone else' do
+ context "with the grid belonging to someone else" do
let(:stored_grids) do
my_page_grid
other_my_page_grid
@@ -291,13 +291,13 @@
let(:path) { api_v3_paths.grid(other_my_page_grid.id) }
- it 'responds with 404 NOT FOUND' do
+ it "responds with 404 NOT FOUND" do
expect(subject.status).to be 404
end
end
end
- describe '#post' do
+ describe "#post" do
let(:path) { api_v3_paths.grids }
let(:params) do
@@ -320,31 +320,31 @@
end
before do
- post path, params.to_json, 'CONTENT_TYPE' => 'application/json'
+ post path, params.to_json, "CONTENT_TYPE" => "application/json"
end
- it 'responds with 201 CREATED' do
+ it "responds with 201 CREATED" do
expect(subject.status).to eq(201)
end
- it 'returns the created grid block' do
+ it "returns the created grid block" do
expect(subject.body)
- .to be_json_eql('Grid'.to_json)
- .at_path('_type')
+ .to be_json_eql("Grid".to_json)
+ .at_path("_type")
expect(subject.body)
- .to be_json_eql(params['rowCount'].to_json)
- .at_path('rowCount')
+ .to be_json_eql(params["rowCount"].to_json)
+ .at_path("rowCount")
expect(subject.body)
- .to be_json_eql(params['widgets'][0]['identifier'].to_json)
- .at_path('widgets/0/identifier')
+ .to be_json_eql(params["widgets"][0]["identifier"].to_json)
+ .at_path("widgets/0/identifier")
end
- it 'persists the grid' do
+ it "persists the grid" do
expect(Grids::Grid.count)
.to be(1)
end
- context 'with invalid params' do
+ context "with invalid params" do
let(:params) do
{
rowCount: -5,
@@ -364,21 +364,21 @@
}.with_indifferent_access
end
- it 'responds with 422' do
+ it "responds with 422" do
expect(subject.status).to eq(422)
end
- it 'does not create a grid' do
+ it "does not create a grid" do
expect(Grids::Grid.count)
.to be(0)
end
- it 'returns the errors' do
+ it "returns the errors" do
expect(subject.body)
- .to be_json_eql('Error'.to_json)
- .at_path('_type')
+ .to be_json_eql("Error".to_json)
+ .at_path("_type")
- expect(JSON.parse(subject.body)['_embedded']['errors'].map { |e| e['message'] })
+ expect(JSON.parse(subject.body)["_embedded"]["errors"].map { |e| e["message"] })
.to contain_exactly("Widgets is outside of the grid.", "Number of rows must be greater than 0.",
"Number of columns must be greater than 0.")
end
diff --git a/modules/my_page/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb b/modules/my_page/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb
index 62a9bfb99129..94541a5fc656 100644
--- a/modules/my_page/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb
+++ b/modules/my_page/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
RSpec.describe "PATCH /api/v3/grids/:id/form", content_type: :json do
include Rack::Test::Methods
@@ -49,9 +49,9 @@
login_as(current_user)
end
- describe '#post' do
+ describe "#post" do
before do
- post path, params.to_json, 'CONTENT_TYPE' => 'application/json'
+ post path, params.to_json, "CONTENT_TYPE" => "application/json"
end
let(:expected_payload) do
@@ -62,7 +62,7 @@
widgets: [
{
_type: "GridWidget",
- identifier: 'news',
+ identifier: "news",
options: {},
startRow: 1,
endRow: 7,
@@ -71,7 +71,7 @@
},
{
_type: "GridWidget",
- identifier: 'documents',
+ identifier: "documents",
options: {},
startRow: 1,
endRow: 7,
@@ -89,58 +89,58 @@
}
end
- it 'returns 200 OK' do
+ it "returns 200 OK" do
expect(subject.status)
.to be 200
end
- it 'is of type form' do
+ it "is of type form" do
expect(subject.body)
.to be_json_eql("Form".to_json)
- .at_path('_type')
+ .at_path("_type")
end
- it 'contains a Schema disallowing setting scope' do
+ it "contains a Schema disallowing setting scope" do
expect(subject.body)
.to be_json_eql("Schema".to_json)
- .at_path('_embedded/schema/_type')
+ .at_path("_embedded/schema/_type")
expect(subject.body)
.to be_json_eql(false.to_json)
- .at_path('_embedded/schema/scope/writable')
+ .at_path("_embedded/schema/scope/writable")
end
- it 'contains the current data in the payload' do
+ it "contains the current data in the payload" do
expect(subject.body)
.to be_json_eql(expected_payload.to_json)
- .at_path('_embedded/payload')
+ .at_path("_embedded/payload")
end
- it 'has a commit link' do
+ it "has a commit link" do
expect(subject.body)
.to be_json_eql(api_v3_paths.grid(grid.id).to_json)
- .at_path('_links/commit/href')
+ .at_path("_links/commit/href")
end
- context 'with some value for the scope value' do
+ context "with some value for the scope value" do
let(:params) do
{
_links: {
scope: {
- href: '/some/path'
+ href: "/some/path"
}
}
}
end
- it 'has a validation error on scope as the value is not writable' do
+ it "has a validation error on scope as the value is not writable" do
expect(subject.body)
.to be_json_eql("Scope was attempted to be written but is not writable.".to_json)
- .at_path('_embedded/validationErrors/scope/message')
+ .at_path("_embedded/validationErrors/scope/message")
end
end
- context 'with an unsupported widget identifier' do
+ context "with an unsupported widget identifier" do
let(:params) do
{
widgets: [
@@ -156,20 +156,20 @@
}
end
- it 'has a validationError on widget' do
+ it "has a validationError on widget" do
expect(subject.body)
.to be_json_eql("Widgets is not set to one of the allowed values.".to_json)
- .at_path('_embedded/validationErrors/widgets/message')
+ .at_path("_embedded/validationErrors/widgets/message")
end
end
- context 'for another user\'s grid' do
+ context "for another user's grid" do
let(:other_user) { create(:user) }
let(:other_grid) { create(:my_page, user: other_user) }
let(:path) { api_v3_paths.grid_form(other_grid.id) }
- it 'returns 404 NOT FOUND' do
+ it "returns 404 NOT FOUND" do
expect(subject.status)
.to be 404
end
diff --git a/modules/my_page/spec/support/pages/my/page.rb b/modules/my_page/spec/support/pages/my/page.rb
index 40953ee0257c..92a06968f905 100644
--- a/modules/my_page/spec/support/pages/my/page.rb
+++ b/modules/my_page/spec/support/pages/my/page.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'support/pages/page'
+require "support/pages/page"
-require_relative '../../../../../grids/spec/support/pages/grid'
+require_relative "../../../../../grids/spec/support/pages/grid"
module Pages
module My
diff --git a/modules/openid_connect/app/components/openid_connect/providers/row_component.rb b/modules/openid_connect/app/components/openid_connect/providers/row_component.rb
index 350b8473d53f..220b156153cd 100644
--- a/modules/openid_connect/app/components/openid_connect/providers/row_component.rb
+++ b/modules/openid_connect/app/components/openid_connect/providers/row_component.rb
@@ -14,9 +14,9 @@ def name
def row_css_class
[
- 'openid-connect--provider-row',
+ "openid-connect--provider-row",
"openid-connect--provider-row-#{model.id}"
- ].join(' ')
+ ].join(" ")
end
###
@@ -27,7 +27,7 @@ def button_links
def edit_link
link_to(
- helpers.op_icon('icon icon-edit button--link'),
+ helpers.op_icon("icon icon-edit button--link"),
url_for(action: :edit, id: provider.id),
title: t(:button_edit)
)
@@ -35,7 +35,7 @@ def edit_link
def delete_link
link_to(
- helpers.op_icon('icon icon-delete button--link'),
+ helpers.op_icon("icon icon-delete button--link"),
url_for(action: :destroy, id: provider.id),
method: :delete,
data: { confirm: I18n.t(:text_are_you_sure) },
diff --git a/modules/openid_connect/app/components/openid_connect/providers/table_component.rb b/modules/openid_connect/app/components/openid_connect/providers/table_component.rb
index 781baa1a11dc..8b4225548255 100644
--- a/modules/openid_connect/app/components/openid_connect/providers/table_component.rb
+++ b/modules/openid_connect/app/components/openid_connect/providers/table_component.rb
@@ -12,12 +12,12 @@ def sortable?
end
def empty_row_message
- I18n.t 'openid_connect.providers.no_results_table'
+ I18n.t "openid_connect.providers.no_results_table"
end
def headers
[
- ['name', { caption: I18n.t('attributes.name') }]
+ ["name", { caption: I18n.t("attributes.name") }]
]
end
end
diff --git a/modules/openid_connect/app/controllers/openid_connect/providers_controller.rb b/modules/openid_connect/app/controllers/openid_connect/providers_controller.rb
index 38c504544b9f..f3f817ffc720 100644
--- a/modules/openid_connect/app/controllers/openid_connect/providers_controller.rb
+++ b/modules/openid_connect/app/controllers/openid_connect/providers_controller.rb
@@ -1,6 +1,6 @@
module OpenIDConnect
class ProvidersController < ::ApplicationController
- layout 'admin'
+ layout "admin"
menu_item :plugin_openid_connect
before_action :require_admin
@@ -56,7 +56,7 @@ def destroy
def check_ee
unless EnterpriseToken.allows_to?(:openid_providers)
- render template: '/openid_connect/providers/upsale'
+ render template: "/openid_connect/providers/upsale"
false
end
end
@@ -91,8 +91,8 @@ def openid_connect_providers_available_for_configure
helper_method :openid_connect_providers_available_for_configure
def default_breadcrumb
- if action_name != 'index'
- ActionController::Base.helpers.link_to(t('openid_connect.providers.plural'), openid_connect_providers_path)
+ if action_name != "index"
+ ActionController::Base.helpers.link_to(t("openid_connect.providers.plural"), openid_connect_providers_path)
end
end
diff --git a/modules/openid_connect/app/models/openid_connect/user_session_link.rb b/modules/openid_connect/app/models/openid_connect/user_session_link.rb
index 26bfb6a53969..baa3caab442a 100644
--- a/modules/openid_connect/app/models/openid_connect/user_session_link.rb
+++ b/modules/openid_connect/app/models/openid_connect/user_session_link.rb
@@ -1,7 +1,7 @@
module OpenIDConnect
class UserSessionLink < ::ApplicationRecord
- self.table_name = 'oidc_user_session_links'
+ self.table_name = "oidc_user_session_links"
- belongs_to :session, class_name: 'Sessions::UserSession', dependent: :delete
+ belongs_to :session, class_name: "Sessions::UserSession", dependent: :delete
end
end
diff --git a/modules/openid_connect/app/session/session_controller.rb b/modules/openid_connect/app/session/session_controller.rb
index aa327273930b..c86ec40f5065 100644
--- a/modules/openid_connect/app/session/session_controller.rb
+++ b/modules/openid_connect/app/session/session_controller.rb
@@ -2,7 +2,7 @@ class SessionController < ActionController::Base
def logout_warning
url = signin_url back_url: params[:back_url]
- render 'logout_warning', locals: { message: link_i18n(:logout_warning, url) }
+ render "logout_warning", locals: { message: link_i18n(:logout_warning, url) }
end
private
diff --git a/modules/openid_connect/config/routes.rb b/modules/openid_connect/config/routes.rb
index f27795fcca78..d10644fbc8fe 100644
--- a/modules/openid_connect/config/routes.rb
+++ b/modules/openid_connect/config/routes.rb
@@ -1,5 +1,5 @@
Rails.application.routes.draw do
- get '/session/logout_warning', to: 'session#logout_warning'
+ get "/session/logout_warning", to: "session#logout_warning"
scope :admin do
namespace :openid_connect do
diff --git a/modules/openid_connect/db/migrate/20221122072857_add_oidc_session_link.rb b/modules/openid_connect/db/migrate/20221122072857_add_oidc_session_link.rb
index f0fb006652b3..b90addd98a0e 100644
--- a/modules/openid_connect/db/migrate/20221122072857_add_oidc_session_link.rb
+++ b/modules/openid_connect/db/migrate/20221122072857_add_oidc_session_link.rb
@@ -34,7 +34,7 @@ def change
ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.create_unlogged_tables = true
create_table :oidc_user_session_links do |t|
t.string :oidc_session, null: false, index: true
- t.references :session, index: true, foreign_key: { to_table: 'sessions', on_delete: :cascade }
+ t.references :session, index: true, foreign_key: { to_table: "sessions", on_delete: :cascade }
t.timestamps
end
diff --git a/modules/openid_connect/lib/open_project/openid_connect.rb b/modules/openid_connect/lib/open_project/openid_connect.rb
index f10bee5d4172..c9331a39ee5d 100644
--- a/modules/openid_connect/lib/open_project/openid_connect.rb
+++ b/modules/openid_connect/lib/open_project/openid_connect.rb
@@ -1,10 +1,10 @@
-require 'omniauth/openid_connect'
-require 'omniauth/openid_connect/providers'
-require 'open_project/openid_connect/engine'
+require "omniauth/openid_connect"
+require "omniauth/openid_connect/providers"
+require "open_project/openid_connect/engine"
module OpenProject
module OpenIDConnect
- CONFIG_KEY = 'openid_connect'.freeze
+ CONFIG_KEY = "openid_connect".freeze
def providers
# update base redirect URI in case settings changed
diff --git a/modules/openid_connect/lib/open_project/openid_connect/hooks/hook.rb b/modules/openid_connect/lib/open_project/openid_connect/hooks/hook.rb
index c3411f64c7df..2d3b92c952d9 100644
--- a/modules/openid_connect/lib/open_project/openid_connect/hooks/hook.rb
+++ b/modules/openid_connect/lib/open_project/openid_connect/hooks/hook.rb
@@ -34,7 +34,7 @@ class Hook < OpenProject::Hook::Listener
# we want to map that to the internal session
def user_logged_in(context)
session = context[:session]
- oidc_sid = session['omniauth.oidc_sid']
+ oidc_sid = session["omniauth.oidc_sid"]
return if oidc_sid.nil?
::OpenProject::OpenIDConnect::SessionMapper.handle_login(oidc_sid, session)
diff --git a/modules/openid_connect/lib/openproject-openid_connect.rb b/modules/openid_connect/lib/openproject-openid_connect.rb
index 66b53f45ae8f..74691683e7e7 100644
--- a/modules/openid_connect/lib/openproject-openid_connect.rb
+++ b/modules/openid_connect/lib/openproject-openid_connect.rb
@@ -1 +1 @@
-require 'open_project/openid_connect'
+require "open_project/openid_connect"
diff --git a/modules/openid_connect/openproject-openid_connect.gemspec b/modules/openid_connect/openproject-openid_connect.gemspec
index 2763f0ef235d..929e867192c6 100644
--- a/modules/openid_connect/openproject-openid_connect.gemspec
+++ b/modules/openid_connect/openproject-openid_connect.gemspec
@@ -1,16 +1,16 @@
Gem::Specification.new do |s|
- s.name = 'openproject-openid_connect'
- s.version = '1.0.0'
- s.authors = 'OpenProject GmbH'
- s.email = 'info@openproject.com'
- s.summary = 'OpenProject OpenID Connect'
- s.description = 'Adds OmniAuth OpenID Connect strategy providers to Openproject.'
- s.license = 'GPLv3'
+ s.name = "openproject-openid_connect"
+ s.version = "1.0.0"
+ s.authors = "OpenProject GmbH"
+ s.email = "info@openproject.com"
+ s.summary = "OpenProject OpenID Connect"
+ s.description = "Adds OmniAuth OpenID Connect strategy providers to Openproject."
+ s.license = "GPLv3"
- s.files = Dir['{app,config,db,lib}/**/*'] + %w(CHANGELOG.md README.md)
+ s.files = Dir["{app,config,db,lib}/**/*"] + %w(CHANGELOG.md README.md)
- s.add_dependency 'lobby_boy', '~> 0.1.3'
- s.add_dependency 'omniauth-openid_connect-providers', '~> 0.1'
- s.add_dependency 'openproject-auth_plugins'
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.add_dependency "lobby_boy", "~> 0.1.3"
+ s.add_dependency "omniauth-openid_connect-providers", "~> 0.1"
+ s.add_dependency "openproject-auth_plugins"
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/openid_connect/spec/controllers/providers_controller_spec.rb b/modules/openid_connect/spec/controllers/providers_controller_spec.rb
index 807343eb2f8e..16fb9165fef0 100644
--- a/modules/openid_connect/spec/controllers/providers_controller_spec.rb
+++ b/modules/openid_connect/spec/controllers/providers_controller_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenIDConnect::ProvidersController do
let(:user) { build_stubbed(:admin) }
let(:valid_params) do
{
- name: 'azure',
+ name: "azure",
identifier: "IDENTIFIER",
secret: "SECRET"
}
@@ -43,54 +43,54 @@
login_as user
end
- context 'without an EE token', with_ee: false do
- it 'renders upsale' do
+ context "without an EE token", with_ee: false do
+ it "renders upsale" do
get :index
expect(response).to have_http_status(:ok)
- expect(response).to render_template 'openid_connect/providers/upsale'
+ expect(response).to render_template "openid_connect/providers/upsale"
end
end
- context 'with an EE token', with_ee: %i[openid_providers] do
+ context "with an EE token", with_ee: %i[openid_providers] do
before do
login_as user
end
- context 'when not admin' do
+ context "when not admin" do
let(:user) { build_stubbed(:user) }
- it 'renders 403' do
+ it "renders 403" do
get :index
expect(response).to have_http_status(:forbidden)
end
end
- context 'when not logged in' do
+ context "when not logged in" do
let(:user) { User.anonymous }
- it 'renders 403' do
+ it "renders 403" do
get :index
expect(response.status).to redirect_to(signin_url(back_url: openid_connect_providers_url))
end
end
- describe '#index' do
- it 'renders the index page' do
+ describe "#index" do
+ it "renders the index page" do
get :index
expect(response).to be_successful
- expect(response).to render_template 'index'
+ expect(response).to render_template "index"
end
end
- describe '#new' do
- it 'renders the new page' do
+ describe "#new" do
+ it "renders the new page" do
get :new
expect(response).to be_successful
expect(assigns[:provider]).to be_new_record
- expect(response).to render_template 'new'
+ expect(response).to render_template "new"
end
- it 'redirects to the index page if no provider available', with_settings: {
+ it "redirects to the index page if no provider available", with_settings: {
plugin_openproject_openid_connect: {
"providers" => OpenIDConnect::Provider::ALLOWED_TYPES.inject({}) do |accu, name|
accu.merge(name => { "identifier" => "IDENTIFIER", "secret" => "SECRET" })
@@ -102,64 +102,64 @@
end
end
- describe '#create' do
- context 'with valid params' do
+ describe "#create" do
+ context "with valid params" do
let(:params) { { openid_connect_provider: valid_params } }
before do
post :create, params:
end
- it 'is successful' do
+ it "is successful" do
expect(flash[:notice]).to eq(I18n.t(:notice_successful_create))
expect(Setting.plugin_openproject_openid_connect["providers"]).to have_key("azure")
expect(response).to be_redirect
end
- context 'with limit_self_registration checked' do
+ context "with limit_self_registration checked" do
let(:params) do
{ openid_connect_provider: valid_params.merge(limit_self_registration: 1) }
end
- it 'sets the setting' do
+ it "sets the setting" do
expect(OpenProject::Plugins::AuthPlugin)
.to be_limit_self_registration provider: valid_params[:name]
end
end
- context 'with limit_self_registration unchecked' do
+ context "with limit_self_registration unchecked" do
let(:params) do
{ openid_connect_provider: valid_params.merge(limit_self_registration: 0) }
end
- it 'does not set the setting' do
+ it "does not set the setting" do
expect(OpenProject::Plugins::AuthPlugin)
.not_to be_limit_self_registration provider: valid_params[:name]
end
end
end
- it 'renders an error if invalid params' do
+ it "renders an error if invalid params" do
post :create, params: { openid_connect_provider: valid_params.merge(identifier: "") }
- expect(response).to render_template 'new'
+ expect(response).to render_template "new"
end
end
- describe '#edit' do
- context 'when found', with_settings: {
+ describe "#edit" do
+ context "when found", with_settings: {
plugin_openproject_openid_connect: {
"providers" => { "azure" => { "identifier" => "IDENTIFIER", "secret" => "SECRET" } }
}
} do
- it 'renders the edit page' do
- get :edit, params: { id: 'azure' }
+ it "renders the edit page" do
+ get :edit, params: { id: "azure" }
expect(response).to be_successful
expect(assigns[:provider]).to be_present
- expect(response).to render_template 'edit'
+ expect(response).to render_template "edit"
end
context(
- 'with limit_self_registration set',
+ "with limit_self_registration set",
with_settings: {
plugin_openproject_openid_connect: {
"providers" => {
@@ -173,43 +173,43 @@
}
) do
before do
- get :edit, params: { id: 'azure' }
+ get :edit, params: { id: "azure" }
end
- it 'shows limit_self_registration as checked' do
+ it "shows limit_self_registration as checked" do
expect(assigns[:provider]).to be_limit_self_registration
end
end
- context 'with limit_self_registration not set' do
+ context "with limit_self_registration not set" do
before do
- get :edit, params: { id: 'azure' }
+ get :edit, params: { id: "azure" }
end
- it 'shows limit_self_registration as checked' do
+ it "shows limit_self_registration as checked" do
expect(assigns[:provider]).to be_limit_self_registration
end
end
end
- context 'when not found' do
- it 'renders 404' do
- get :edit, params: { id: 'doesnoexist' }
+ context "when not found" do
+ it "renders 404" do
+ get :edit, params: { id: "doesnoexist" }
expect(response).not_to be_successful
expect(response).to have_http_status(:not_found)
end
end
end
- describe '#update' do
- context 'when found' do
+ describe "#update" do
+ context "when found" do
before do
Setting.plugin_openproject_openid_connect = {
"providers" => { "azure" => { "identifier" => "IDENTIFIER", "secret" => "SECRET" } }
}
end
- it 'successfully updates the provider configuration' do
+ it "successfully updates the provider configuration" do
put :update, params: { id: "azure", openid_connect_provider: valid_params.merge(secret: "NEWSECRET") }
expect(response).to be_redirect
expect(flash[:notice]).to be_present
@@ -217,12 +217,12 @@
expect(provider.secret).to eq("NEWSECRET")
end
- context 'with limit_self_registration checked' do
+ context "with limit_self_registration checked" do
let(:params) do
- { id: 'azure', openid_connect_provider: valid_params.merge(limit_self_registration: 1) }
+ { id: "azure", openid_connect_provider: valid_params.merge(limit_self_registration: 1) }
end
- it 'sets the setting' do
+ it "sets the setting" do
put(:update, params:)
expect(OpenProject::Plugins::AuthPlugin)
@@ -232,12 +232,12 @@
end
end
- context 'with limit_self_registration unchecked' do
+ context "with limit_self_registration unchecked" do
let(:params) do
{ id: :azure, openid_connect_provider: valid_params.merge(limit_self_registration: 0) }
end
- it 'does not set the setting' do
+ it "does not set the setting" do
put(:update, params:)
expect(OpenProject::Plugins::AuthPlugin)
@@ -250,15 +250,15 @@
end
end
- describe '#destroy' do
- context 'when found' do
+ describe "#destroy" do
+ context "when found" do
before do
Setting.plugin_openproject_openid_connect = {
"providers" => { "azure" => { "identifier" => "IDENTIFIER", "secret" => "SECRET" } }
}
end
- it 'removes the provider' do
+ it "removes the provider" do
delete :destroy, params: { id: "azure" }
expect(response).to be_redirect
expect(flash[:notice]).to be_present
diff --git a/modules/openid_connect/spec/factories/user_session_link_factory.rb b/modules/openid_connect/spec/factories/user_session_link_factory.rb
index e85d6659ae7e..4f6d5c681711 100644
--- a/modules/openid_connect/spec/factories/user_session_link_factory.rb
+++ b/modules/openid_connect/spec/factories/user_session_link_factory.rb
@@ -1,6 +1,6 @@
FactoryBot.define do
- factory :user_session_link, class: 'OpenIDConnect::UserSessionLink' do
+ factory :user_session_link, class: "OpenIDConnect::UserSessionLink" do
session { nil }
- oidc_session { 'foobar' }
+ oidc_session { "foobar" }
end
end
diff --git a/modules/openid_connect/spec/lib/session_mapper_spec.rb b/modules/openid_connect/spec/lib/session_mapper_spec.rb
index 011000df1c90..ff0ff73afe6c 100644
--- a/modules/openid_connect/spec/lib/session_mapper_spec.rb
+++ b/modules/openid_connect/spec/lib/session_mapper_spec.rb
@@ -25,7 +25,7 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::OpenIDConnect::SessionMapper do
let(:mock_session) do
@@ -39,34 +39,34 @@ def initialize(id)
end
end
- describe 'handle_login' do
- let(:session) { mock_session.new('foo') }
+ describe "handle_login" do
+ let(:session) { mock_session.new("foo") }
let!(:plain_session) { create(:user_session, session_id: session.id.private_id) }
let!(:user_session) { Sessions::UserSession.find_by(session_id: plain_session.session_id) }
- subject { described_class.handle_login 'oidc_sid_foo', session }
+ subject { described_class.handle_login "oidc_sid_foo", session }
- it 'creates a user link object' do
+ it "creates a user link object" do
expect { subject }.to change(OpenIDConnect::UserSessionLink, :count).by(1)
link = OpenIDConnect::UserSessionLink.find_by(session_id: user_session.id)
expect(link).to be_present
expect(link.session).to eq user_session
- expect(link.oidc_session).to eq 'oidc_sid_foo'
+ expect(link.oidc_session).to eq "oidc_sid_foo"
end
end
- describe 'handle_logout' do
- let(:token) { instance_double(OmniAuth::OpenIDConnect::LogoutToken, sid: 'oidc_foobar') }
+ describe "handle_logout" do
+ let(:token) { instance_double(OmniAuth::OpenIDConnect::LogoutToken, sid: "oidc_foobar") }
subject { described_class.handle_logout token }
- context 'when an unrelated session exists' do
- let!(:plain_session) { create(:user_session, session_id: 'internal_foobar') }
- let!(:user_session) { Sessions::UserSession.find_by(session_id: 'internal_foobar') }
- let!(:link) { create(:user_session_link, oidc_session: 'other_oidc_sid', session: user_session) }
+ context "when an unrelated session exists" do
+ let!(:plain_session) { create(:user_session, session_id: "internal_foobar") }
+ let!(:user_session) { Sessions::UserSession.find_by(session_id: "internal_foobar") }
+ let!(:link) { create(:user_session_link, oidc_session: "other_oidc_sid", session: user_session) }
- it 'does not delete it' do
+ it "does not delete it" do
expect { subject }.not_to change(OpenIDConnect::UserSessionLink, :count)
expect { link.reload }.not_to raise_error
@@ -74,12 +74,12 @@ def initialize(id)
end
end
- context 'when a linked session exists' do
- let!(:plain_session) { create(:user_session, session_id: 'internal_foobar') }
- let!(:user_session) { Sessions::UserSession.find_by(session_id: 'internal_foobar') }
- let!(:link) { create(:user_session_link, oidc_session: 'oidc_foobar', session: user_session) }
+ context "when a linked session exists" do
+ let!(:plain_session) { create(:user_session, session_id: "internal_foobar") }
+ let!(:user_session) { Sessions::UserSession.find_by(session_id: "internal_foobar") }
+ let!(:link) { create(:user_session_link, oidc_session: "oidc_foobar", session: user_session) }
- it 'deletes the linked session' do
+ it "deletes the linked session" do
expect { subject }.to change(OpenIDConnect::UserSessionLink, :count).by(-1)
expect { link.reload }.to raise_error(ActiveRecord::RecordNotFound)
diff --git a/modules/openid_connect/spec/models/openid_connect/provider_spec.rb b/modules/openid_connect/spec/models/openid_connect/provider_spec.rb
index 8ce328858bfc..13e74ddea3f5 100644
--- a/modules/openid_connect/spec/models/openid_connect/provider_spec.rb
+++ b/modules/openid_connect/spec/models/openid_connect/provider_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenIDConnect::Provider do
let(:params) do
@@ -40,19 +40,19 @@ def auth_plugin
OpenProject::Plugins::AuthPlugin
end
- describe 'limit_self_registration' do
+ describe "limit_self_registration" do
before do
# required so that the auth plugin sees any providers (ee feature)
allow(EnterpriseToken).to receive(:show_banners?).and_return false
end
- context 'with no limited providers' do
+ context "with no limited providers" do
it "shows the provider as limited" do
provider.save
expect(auth_plugin).to be_limit_self_registration provider: provider.name
end
- context 'when set to true' do
+ context "when set to true" do
let(:params) do
{ limit_self_registration: true }
end
@@ -64,7 +64,7 @@ def auth_plugin
end
end
- context 'when set to false' do
+ context "when set to false" do
let(:params) do
{ limit_self_registration: false }
end
@@ -78,7 +78,7 @@ def auth_plugin
end
context(
- 'with a limited provider',
+ "with a limited provider",
with_settings: {
plugin_openproject_openid_connect: {
"providers" => {
diff --git a/modules/openid_connect/spec/models/user_session_link_spec.rb b/modules/openid_connect/spec/models/user_session_link_spec.rb
index ccbee29d7609..3a892242bd07 100644
--- a/modules/openid_connect/spec/models/user_session_link_spec.rb
+++ b/modules/openid_connect/spec/models/user_session_link_spec.rb
@@ -25,15 +25,15 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenIDConnect::UserSessionLink do
- describe 'session' do
+ describe "session" do
let(:plain_session) { create(:user_session) }
let(:user_session) { Sessions::UserSession.find_by(session_id: plain_session.session_id) }
let(:link) { create(:user_session_link, session: user_session) }
- it 'gets deleted when session is deleted' do
+ it "gets deleted when session is deleted" do
expect(link).to be_present
expect(link.session).to eq user_session
diff --git a/modules/openid_connect/spec/requests/openid_connect_spec.rb b/modules/openid_connect/spec/requests/openid_connect_spec.rb
index 9b5f4687973f..c09af595b26b 100644
--- a/modules/openid_connect/spec/requests/openid_connect_spec.rb
+++ b/modules/openid_connect/spec/requests/openid_connect_spec.rb
@@ -26,24 +26,24 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'openid_connect_spec_helpers'
+require "spec_helper"
+require_relative "openid_connect_spec_helpers"
RSpec.configure do |c|
c.include OpenIDConnectSpecHelpers
end
-RSpec.describe 'OpenID Connect', :skip_2fa_stage, # Prevent redirects to 2FA stage
+RSpec.describe "OpenID Connect", :skip_2fa_stage, # Prevent redirects to 2FA stage
type: :rails_request,
with_ee: %i[openid_providers] do
- let(:host) { OmniAuth::OpenIDConnect::Heroku.new('foo', {}).host }
+ let(:host) { OmniAuth::OpenIDConnect::Heroku.new("foo", {}).host }
let(:user_info) do
{
- sub: '87117114115116',
- name: 'Hans Wurst',
- email: 'h.wurst@finn.de',
- given_name: 'Hans',
- family_name: 'Wurst'
+ sub: "87117114115116",
+ name: "Hans Wurst",
+ email: "h.wurst@finn.de",
+ given_name: "Hans",
+ family_name: "Wurst"
}
end
@@ -51,7 +51,7 @@
# The redirect will include an authorisation code.
# Since we don't actually get a valid code in the test we will stub the resulting AccessToken.
allow_any_instance_of(OpenIDConnect::Client).to receive(:access_token!) do
- OpenIDConnect::AccessToken.new client: self, access_token: 'foo bar baz'
+ OpenIDConnect::AccessToken.new client: self, access_token: "foo bar baz"
end
# Using the granted AccessToken the client then performs another request to the OpenID Connect
@@ -65,19 +65,19 @@
# be true.
end
- describe 'sign-up and login' do
+ describe "sign-up and login" do
before do
allow(Setting).to receive(:plugin_openproject_openid_connect).and_return(
- 'providers' => {
- 'heroku' => {
- 'identifier' => 'does not',
- 'secret' => 'matter'
+ "providers" => {
+ "heroku" => {
+ "identifier" => "does not",
+ "secret" => "matter"
}
}
)
end
- it 'works' do
+ it "works" do
##
# it should redirect to the provider's openid connect authentication endpoint
click_on_signin
@@ -85,11 +85,11 @@
expect(response).to have_http_status :found
expect(response.location).to match /https:\/\/#{host}.*$/
- params = Rack::Utils.parse_nested_query(response.location.gsub(/^.*\?/, ''))
+ params = Rack::Utils.parse_nested_query(response.location.gsub(/^.*\?/, ""))
- expect(params).to include 'client_id'
- expect(params['redirect_uri']).to match /^.*\/auth\/heroku\/callback$/
- expect(params['scope']).to include 'openid'
+ expect(params).to include "client_id"
+ expect(params["redirect_uri"]).to match /^.*\/auth\/heroku\/callback$/
+ expect(params["scope"]).to include "openid"
##
# it should redirect back from the provider to the login page
@@ -102,7 +102,7 @@
# remove this guard once we are on v4.1
if OpenProject::OmniAuth::Authorization.method(:after_login!).arity.abs > 2
# check that cookie is stored in the access token
- expect(response.cookies['_open_project_session_access_token']).to eq 'foo bar baz'
+ expect(response.cookies["_open_project_session_access_token"]).to eq "foo bar baz"
end
user = User.find_by(mail: user_info[:email])
@@ -129,68 +129,68 @@
expect(response.location).to match /\/my\/page/
end
- context 'with a custom claim and mapping' do
+ context "with a custom claim and mapping" do
let(:user_info) do
{
- sub: '87117114115116',
- name: 'Hans Wurst',
- email: 'h.wurst@finn.de',
- given_name: 'Hans',
- family_name: 'Wurst',
- foobar: 'a.truly.random.value'
+ sub: "87117114115116",
+ name: "Hans Wurst",
+ email: "h.wurst@finn.de",
+ given_name: "Hans",
+ family_name: "Wurst",
+ foobar: "a.truly.random.value"
}
end
before do
allow(Setting).to receive(:plugin_openproject_openid_connect).and_return(
- 'providers' => {
- 'heroku' => {
- 'attribute_map' => { login: :foobar },
- 'identifier' => 'does not',
- 'secret' => 'matter'
+ "providers" => {
+ "heroku" => {
+ "attribute_map" => { login: :foobar },
+ "identifier" => "does not",
+ "secret" => "matter"
}
}
)
end
- it 'maps to the login' do
+ it "maps to the login" do
click_on_signin
redirect_from_provider
- user = User.find_by(login: 'a.truly.random.value')
+ user = User.find_by(login: "a.truly.random.value")
expect(user).to be_present
end
end
end
- context 'provider configuration through the settings' do
+ context "provider configuration through the settings" do
before do
allow(Setting).to receive(:plugin_openproject_openid_connect).and_return(
- 'providers' => {
- 'google' => {
- 'identifier' => 'does not',
- 'secret' => 'matter'
+ "providers" => {
+ "google" => {
+ "identifier" => "does not",
+ "secret" => "matter"
},
- 'azure' => {
- 'identifier' => 'IDENTIFIER',
- 'secret' => 'SECRET'
+ "azure" => {
+ "identifier" => "IDENTIFIER",
+ "secret" => "SECRET"
}
}
)
end
- it 'shows no option unless EE', with_ee: false do
- get '/login'
+ it "shows no option unless EE", with_ee: false do
+ get "/login"
expect(response.body).not_to match /Google/i
expect(response.body).not_to match /Azure/i
end
- it 'makes providers that have been configured through settings available without requiring a restart' do
- get '/login'
+ it "makes providers that have been configured through settings available without requiring a restart" do
+ get "/login"
expect(response.body).to match /Google/i
expect(response.body).to match /Azure/i
- expect { click_on_signin('google') }.not_to raise_error
+ expect { click_on_signin("google") }.not_to raise_error
expect(response).to have_http_status :found
end
end
diff --git a/modules/openid_connect/spec/requests/openid_connect_spec_helpers.rb b/modules/openid_connect/spec/requests/openid_connect_spec_helpers.rb
index b90aba9383f0..042b30cd42f7 100644
--- a/modules/openid_connect/spec/requests/openid_connect_spec_helpers.rb
+++ b/modules/openid_connect/spec/requests/openid_connect_spec_helpers.rb
@@ -1,15 +1,15 @@
module OpenIDConnectSpecHelpers
- def redirect_from_provider(name = 'heroku')
+ def redirect_from_provider(name = "heroku")
# Emulate the provider's redirect with a nonsense code.
get "/auth/#{name}/callback",
params: {
- code: 'foobar',
+ code: "foobar",
redirect_uri: "http://localhost:3000/auth/#{name}/callback",
- state: session['omniauth.state']
+ state: session["omniauth.state"]
}
end
- def click_on_signin(pro_name = 'heroku')
+ def click_on_signin(pro_name = "heroku")
# Emulate click on sign-in for that particular provider
get "/auth/#{pro_name}"
end
diff --git a/modules/openid_connect/spec/routing/openid_connect/providers_controller_spec.rb b/modules/openid_connect/spec/routing/openid_connect/providers_controller_spec.rb
index 3ec5958538e8..3058687a042c 100644
--- a/modules/openid_connect/spec/routing/openid_connect/providers_controller_spec.rb
+++ b/modules/openid_connect/spec/routing/openid_connect/providers_controller_spec.rb
@@ -26,33 +26,33 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'OpenIDConnect Providers' do
- it 'routes to index' do
- expect(get('/admin/openid_connect/providers')).to route_to('openid_connect/providers#index')
+RSpec.describe "OpenIDConnect Providers" do
+ it "routes to index" do
+ expect(get("/admin/openid_connect/providers")).to route_to("openid_connect/providers#index")
end
- it 'routes to new' do
- expect(get('/admin/openid_connect/providers/new')).to route_to('openid_connect/providers#new')
+ it "routes to new" do
+ expect(get("/admin/openid_connect/providers/new")).to route_to("openid_connect/providers#new")
end
- it 'routes to edit' do
- expect(get('/admin/openid_connect/providers/azure/edit')).to(
+ it "routes to edit" do
+ expect(get("/admin/openid_connect/providers/azure/edit")).to(
route_to(
- controller: 'openid_connect/providers',
- action: 'edit',
- id: 'azure'
+ controller: "openid_connect/providers",
+ action: "edit",
+ id: "azure"
)
)
end
- it 'routes to destroy' do
- expect(delete('/admin/openid_connect/providers/azure')).to(
+ it "routes to destroy" do
+ expect(delete("/admin/openid_connect/providers/azure")).to(
route_to(
- controller: 'openid_connect/providers',
- action: 'destroy',
- id: 'azure'
+ controller: "openid_connect/providers",
+ action: "destroy",
+ id: "azure"
)
)
end
diff --git a/modules/openid_connect/spec/spec_helper.rb b/modules/openid_connect/spec/spec_helper.rb
index f8ec36959dea..671fd6c8666d 100644
--- a/modules/openid_connect/spec/spec_helper.rb
+++ b/modules/openid_connect/spec/spec_helper.rb
@@ -1 +1 @@
-require 'spec_helper'
+require "spec_helper"
diff --git a/modules/overviews/db/migrate/20190826083604_my_project_page_to_grid.rb b/modules/overviews/db/migrate/20190826083604_my_project_page_to_grid.rb
index ecc54a71ccfd..34decad8baa4 100644
--- a/modules/overviews/db/migrate/20190826083604_my_project_page_to_grid.rb
+++ b/modules/overviews/db/migrate/20190826083604_my_project_page_to_grid.rb
@@ -29,7 +29,7 @@
class MyProjectPageToGrid < ActiveRecord::Migration[5.2]
# rubocop:disable Rails/ApplicationRecord
class MyPageEntry < ActiveRecord::Base
- self.table_name = 'my_projects_overviews'
+ self.table_name = "my_projects_overviews"
serialize :top
serialize :left
@@ -77,7 +77,7 @@ def remove_my_page_table
def add_permission
Role
.includes(:role_permissions)
- .where(role_permissions: { permission: 'edit_project' })
+ .where(role_permissions: { permission: "edit_project" })
.each do |role|
role.add_permission!(:manage_overview)
end
@@ -101,19 +101,19 @@ def create_grid(entry)
def move_attachments(entry, grid)
Attachment
.where(container_type: "MyProjectsOverview", container_id: entry.id)
- .update_all(container_type: 'Grids::Grid', container_id: grid.id)
+ .update_all(container_type: "Grids::Grid", container_id: grid.id)
end
def build_widget(grid, widget_config, position)
method = case widget_config
when Array
:build_custom_text_widget
- when 'project_details'
+ when "project_details"
:build_project_details_widget
- when 'work_packages_assigned_to_me',
- 'work_packages_reported_by_me',
- 'work_packages_responsible_for',
- 'work_packages_watched'
+ when "work_packages_assigned_to_me",
+ "work_packages_reported_by_me",
+ "work_packages_responsible_for",
+ "work_packages_watched"
:build_wp_table_widget
else
:build_default_widget
@@ -123,7 +123,7 @@ def build_widget(grid, widget_config, position)
end
def build_custom_text_widget(grid, widget_config, position)
- build_widget_with_options(grid, 'custom_text', position) do |options|
+ build_widget_with_options(grid, "custom_text", position) do |options|
name = widget_config[1].presence || grid.project.name
options[:name] = name
@@ -132,8 +132,8 @@ def build_custom_text_widget(grid, widget_config, position)
end
def build_project_details_widget(grid, _identifier, position)
- build_default_widget(grid, 'subprojects', position)
- build_default_widget(grid, 'project_details', position)
+ build_default_widget(grid, "subprojects", position)
+ build_default_widget(grid, "project_details", position)
end
def build_wp_table_widget(grid, identifier, position)
@@ -165,13 +165,13 @@ def build_widget_with_options(grid, identifier, position)
def new_name(name)
{
- news_latest: 'news',
- work_package_tracking: 'work_packages_overview',
- spent_time: 'time_entries_list',
- work_packages_assigned_to_me: 'work_packages_table',
- work_packages_reported_by_me: 'work_packages_table',
- work_packages_responsible_for: 'work_packages_table',
- work_packages_watched: 'work_packages_table'
+ news_latest: "news",
+ work_package_tracking: "work_packages_overview",
+ spent_time: "time_entries_list",
+ work_packages_assigned_to_me: "work_packages_table",
+ work_packages_reported_by_me: "work_packages_table",
+ work_packages_responsible_for: "work_packages_table",
+ work_packages_watched: "work_packages_table"
}.with_indifferent_access[name] || name
end
@@ -213,11 +213,11 @@ def next_right_position(grid)
end
def applicable?
- ActiveRecord::Base.connection.table_exists?('my_projects_overviews')
+ ActiveRecord::Base.connection.table_exists?("my_projects_overviews")
end
def attachments(id)
- Attachment.where(container_type: 'MyProjectsOverview', container_id: id)
+ Attachment.where(container_type: "MyProjectsOverview", container_id: id)
end
def new_default_query(attributes = nil)
@@ -229,13 +229,13 @@ def new_default_query(attributes = nil)
end
def query(grid, identifier)
- query = new_default_query name: '_',
+ query = new_default_query name: "_",
is_public: true,
hidden: true,
project: grid.project,
user: query_user(grid)
- query.add_filter(filter_name(identifier), '=', [::Queries::Filters::MeValue::KEY])
+ query.add_filter(filter_name(identifier), "=", [::Queries::Filters::MeValue::KEY])
query.column_names = %w(id type subject)
User.execute_as(query.user) do
@@ -254,27 +254,27 @@ def migratable_entries
def filter_name(identifier)
case identifier
- when 'work_packages_assigned_to_me'
- 'assigned_to_id'
- when 'work_packages_reported_by_me'
- 'author_id'
- when 'work_packages_responsible_for'
- 'responsible_id'
- when 'work_packages_watched'
- 'watcher_id'
+ when "work_packages_assigned_to_me"
+ "assigned_to_id"
+ when "work_packages_reported_by_me"
+ "author_id"
+ when "work_packages_responsible_for"
+ "responsible_id"
+ when "work_packages_watched"
+ "watcher_id"
end
end
def wp_table_widget_name(identifier)
new_identifier = case identifier
- when 'work_packages_assigned_to_me'
- 'work_packages_assigned'
- when 'work_packages_reported_by_me'
- 'work_packages_created'
- when 'work_packages_responsible_for'
- 'work_packages_accountable'
- when 'work_packages_watched'
- 'work_packages_watched'
+ when "work_packages_assigned_to_me"
+ "work_packages_assigned"
+ when "work_packages_reported_by_me"
+ "work_packages_created"
+ when "work_packages_responsible_for"
+ "work_packages_accountable"
+ when "work_packages_watched"
+ "work_packages_watched"
end
I18n.t("js.grid.widgets.#{new_identifier}.title")
diff --git a/modules/overviews/lib/overviews/grid_registration.rb b/modules/overviews/lib/overviews/grid_registration.rb
index 50b3095a0f99..04de8323cf25 100644
--- a/modules/overviews/lib/overviews/grid_registration.rb
+++ b/modules/overviews/lib/overviews/grid_registration.rb
@@ -1,6 +1,6 @@
module Overviews
class GridRegistration < ::Grids::Configuration::InProjectBaseRegistration
- grid_class 'Grids::Overview'
+ grid_class "Grids::Overview"
to_scope :project_overview_path
view_permission :view_project
@@ -13,53 +13,53 @@ class GridRegistration < ::Grids::Configuration::InProjectBaseRegistration
column_count: 2,
widgets: [
{
- identifier: 'project_description',
+ identifier: "project_description",
start_row: 1,
end_row: 2,
start_column: 1,
end_column: 2,
options: {
- name: I18n.t('js.grid.widgets.project_description.title')
+ name: I18n.t("js.grid.widgets.project_description.title")
}
},
{
- identifier: 'project_status',
+ identifier: "project_status",
start_row: 1,
end_row: 2,
start_column: 2,
end_column: 3,
options: {
- name: I18n.t('js.grid.widgets.project_status.title')
+ name: I18n.t("js.grid.widgets.project_status.title")
}
},
{
- identifier: 'project_details',
+ identifier: "project_details",
start_row: 2,
end_row: 3,
start_column: 1,
end_column: 2,
options: {
- name: I18n.t('js.grid.widgets.project_details.title')
+ name: I18n.t("js.grid.widgets.project_details.title")
}
},
{
- identifier: 'work_packages_overview',
+ identifier: "work_packages_overview",
start_row: 3,
end_row: 4,
start_column: 1,
end_column: 3,
options: {
- name: I18n.t('js.grid.widgets.work_packages_overview.title')
+ name: I18n.t("js.grid.widgets.work_packages_overview.title")
}
},
{
- identifier: 'members',
+ identifier: "members",
start_row: 2,
end_row: 3,
start_column: 2,
end_column: 3,
options: {
- name: I18n.t('js.grid.widgets.members.title')
+ name: I18n.t("js.grid.widgets.members.title")
}
}
]
diff --git a/modules/overviews/overviews.gemspec b/modules/overviews/overviews.gemspec
index 3cea45a216c0..0edf17a9ab7e 100644
--- a/modules/overviews/overviews.gemspec
+++ b/modules/overviews/overviews.gemspec
@@ -1,11 +1,11 @@
Gem::Specification.new do |s|
s.name = "overviews"
- s.version = '1.0.0'
+ s.version = "1.0.0"
s.authors = ["OpenProject"]
s.summary = "OpenProject Project Overviews"
s.files = Dir["{app,config,db,lib}/**/*"]
- s.add_dependency 'grids'
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.add_dependency "grids"
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/overviews/spec/contracts/grids/create_contract_spec.rb b/modules/overviews/spec/contracts/grids/create_contract_spec.rb
index 13935632be8c..c6401a8a4e55 100644
--- a/modules/overviews/spec/contracts/grids/create_contract_spec.rb
+++ b/modules/overviews/spec/contracts/grids/create_contract_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe Grids::CreateContract, 'for Grids::Overview' do
+RSpec.describe Grids::CreateContract, "for Grids::Overview" do
let(:project) do
build_stubbed(:project).tap do |p|
allow(Project)
@@ -51,23 +51,23 @@
end
end
- include_context 'model contract'
+ include_context "model contract"
- describe 'user_id' do
- it_behaves_like 'is not writable' do
+ describe "user_id" do
+ it_behaves_like "is not writable" do
let(:attribute) { :user_id }
let(:value) { 5 }
end
end
- describe 'project_id' do
- it_behaves_like 'is writable' do
+ describe "project_id" do
+ it_behaves_like "is writable" do
let(:attribute) { :project_id }
let(:value) { 5 }
end
end
- context 'if an overview grid already exists for the project' do
+ context "if an overview grid already exists for the project" do
before do
allow(Grids::Overview)
.to receive(:exists?)
@@ -75,7 +75,7 @@
.and_return(true)
end
- it 'reports an error on scope' do
+ it "reports an error on scope" do
instance.validate
expect(instance.errors.symbols_for(:scope))
@@ -83,7 +83,7 @@
end
end
- context 'if the user lacks :manage_overview permission' do
+ context "if the user lacks :manage_overview permission" do
# View project is a public permission so every member will have it but as we stub...
let(:permissions) { [:view_project] }
@@ -93,20 +93,20 @@
grid.widgets = grid.widgets.reject { |w| %w(members work_packages_overview).include?(w.identifier) }
end
- context 'if the grid does not have any changes compared to the default' do
- it 'is valid' do
+ context "if the grid does not have any changes compared to the default" do
+ it "is valid" do
expect(instance.validate)
.to be_truthy
end
end
- context 'if the grid has changes compared to the default' do
- context '(row_count)' do
+ context "if the grid has changes compared to the default" do
+ context "(row_count)" do
before do
grid.row_count += 1
end
- it 'reports an error on row_count' do
+ it "reports an error on row_count" do
instance.validate
expect(instance.errors.symbols_for(:row_count))
@@ -114,12 +114,12 @@
end
end
- context '(column_count)' do
+ context "(column_count)" do
before do
grid.column_count += 1
end
- it 'reports an error on row_count' do
+ it "reports an error on row_count" do
instance.validate
expect(instance.errors.symbols_for(:column_count))
@@ -127,20 +127,20 @@
end
end
- context '(widget added)' do
+ context "(widget added)" do
before do
grid.row_count = 4
- grid.widgets.build(identifier: 'project_details',
+ grid.widgets.build(identifier: "project_details",
start_row: 3,
end_row: 4,
start_column: 1,
end_column: 3,
options: {
- name: I18n.t('js.grid.widgets.work_packages_overview.title')
+ name: I18n.t("js.grid.widgets.work_packages_overview.title")
})
end
- it 'reports an error on widgets' do
+ it "reports an error on widgets" do
instance.validate
expect(instance.errors.symbols_for(:widgets))
@@ -148,13 +148,13 @@
end
end
- context '(widget altered)' do
+ context "(widget altered)" do
before do
grid.row_count = 4
grid.widgets.last.end_row += 1
end
- it 'reports an error on widgets' do
+ it "reports an error on widgets" do
instance.validate
expect(instance.errors.symbols_for(:widgets))
@@ -162,12 +162,12 @@
end
end
- context '(widget options altered)' do
+ context "(widget options altered)" do
before do
- grid.widgets[0].options = { name: 'My own name' }
+ grid.widgets[0].options = { name: "My own name" }
end
- it 'reports an error on widgets' do
+ it "reports an error on widgets" do
instance.validate
expect(instance.errors.symbols_for(:widgets))
diff --git a/modules/overviews/spec/contracts/roles/base_contract_spec.rb b/modules/overviews/spec/contracts/roles/base_contract_spec.rb
index 7fda73f04de7..66b21e14a3a2 100644
--- a/modules/overviews/spec/contracts/roles/base_contract_spec.rb
+++ b/modules/overviews/spec/contracts/roles/base_contract_spec.rb
@@ -24,7 +24,7 @@
#
# See COPYRIGHT and LICENSE files for more details.
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Roles::BaseContract do
let(:work_package_role) { build_stubbed(:work_package_role) }
@@ -34,38 +34,38 @@
let(:current_user) { build_stubbed(:admin) }
let(:contract) { described_class.new(role, current_user) }
- describe 'assignable_permissions' do
- context 'for a work package role' do
+ describe "assignable_permissions" do
+ context "for a work package role" do
let(:role) { work_package_role }
- it 'does not include manage_overview' do
+ it "does not include manage_overview" do
expect(contract.assignable_permissions.map(&:name))
.not_to include :manage_overview
end
end
- context 'for a member role' do
+ context "for a member role" do
let(:role) { member_role }
- it 'includes manage_overview' do
+ it "includes manage_overview" do
expect(contract.assignable_permissions.map(&:name))
.to include :manage_overview
end
end
- context 'for a global role' do
+ context "for a global role" do
let(:role) { global_role }
- it 'does not include manage_overview' do
+ it "does not include manage_overview" do
expect(contract.assignable_permissions.map(&:name))
.not_to include :manage_overview
end
end
- context 'for a builtin role' do
+ context "for a builtin role" do
let(:role) { anonymous_role }
- it 'does not include manage_overview' do
+ it "does not include manage_overview" do
expect(contract.assignable_permissions.map(&:name))
.not_to include :manage_overview
end
diff --git a/modules/overviews/spec/controllers/overviews/overviews_controller_spec.rb b/modules/overviews/spec/controllers/overviews/overviews_controller_spec.rb
index 3c2b2807a9fc..ea0b4b1fd11b 100644
--- a/modules/overviews/spec/controllers/overviews/overviews_controller_spec.rb
+++ b/modules/overviews/spec/controllers/overviews/overviews_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Overviews::OverviewsController do
let(:permissions) do
@@ -54,24 +54,24 @@
login_as current_user
end
- describe '#show' do
- context 'with jump parameter' do
- it 'redirects to active tab' do
- get :show, params: { project_id: project.id, jump: 'news' }
+ describe "#show" do
+ context "with jump parameter" do
+ it "redirects to active tab" do
+ get :show, params: { project_id: project.id, jump: "news" }
expect(response)
.to redirect_to main_app_routes.project_news_index_path(project)
end
- it 'ignores inactive/unpermitted module' do
- get :show, params: { project_id: project.id, jump: 'work_packages' }
+ it "ignores inactive/unpermitted module" do
+ get :show, params: { project_id: project.id, jump: "work_packages" }
expect(response)
.to be_successful
end
- it 'ignores bogus module' do
- get :show, params: { project_id: project.id, jump: 'foobar' }
+ it "ignores bogus module" do
+ get :show, params: { project_id: project.id, jump: "foobar" }
expect(response)
.to be_successful
diff --git a/modules/overviews/spec/factories/grid_factory.rb b/modules/overviews/spec/factories/grid_factory.rb
index d48b998616b5..c7e13364ff11 100644
--- a/modules/overviews/spec/factories/grid_factory.rb
+++ b/modules/overviews/spec/factories/grid_factory.rb
@@ -1,5 +1,5 @@
FactoryBot.define do
- factory :overview, class: 'Grids::Overview' do
+ factory :overview, class: "Grids::Overview" do
project
row_count { 7 }
column_count { 4 }
diff --git a/modules/overviews/spec/features/low_permissions_page_creation_spec.rb b/modules/overviews/spec/features/low_permissions_page_creation_spec.rb
index 283c24cc60e9..3480c1d6987c 100644
--- a/modules/overviews/spec/features/low_permissions_page_creation_spec.rb
+++ b/modules/overviews/spec/features/low_permissions_page_creation_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/overview'
+require_relative "../support/pages/overview"
-RSpec.describe 'Overview page on the fly creation if user lacks :mange_overview permission', :js do
+RSpec.describe "Overview page on the fly creation if user lacks :mange_overview permission", :js do
let!(:type) { create(:type) }
let!(:project) { create(:project, types: [type]) }
let!(:open_status) { create(:default_status) }
@@ -53,10 +53,10 @@
overview_page.visit!
end
- it 'renders the default view, allows altering and saving' do
- description_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
- details_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(2)')
- overview_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(3)')
+ it "renders the default view, allows altering and saving" do
+ description_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
+ details_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(2)")
+ overview_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(3)")
description_area.expect_to_exist
details_area.expect_to_exist
diff --git a/modules/overviews/spec/features/managing_overview_page_spec.rb b/modules/overviews/spec/features/managing_overview_page_spec.rb
index 22fe1ae5da6c..ef6c0e839fd1 100644
--- a/modules/overviews/spec/features/managing_overview_page_spec.rb
+++ b/modules/overviews/spec/features/managing_overview_page_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require_relative '../support/pages/overview'
+require_relative "../support/pages/overview"
-RSpec.describe 'Overview page managing', :js do
+RSpec.describe "Overview page managing", :js do
let!(:type) { create(:type) }
- let!(:project) { create(:project, types: [type], description: 'My **custom** description') }
+ let!(:project) { create(:project, types: [type], description: "My **custom** description") }
let!(:open_status) { create(:default_status) }
let!(:created_work_package) do
create(:work_package,
@@ -70,12 +70,12 @@
overview_page.visit!
end
- it 'renders the default view, allows altering and saving' do
- description_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(1)')
- status_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(2)')
- details_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(3)')
- overview_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(4)')
- members_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(5)')
+ it "renders the default view, allows altering and saving" do
+ description_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(1)")
+ status_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(2)")
+ details_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(3)")
+ overview_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(4)")
+ members_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(5)")
description_area.expect_to_exist
status_area.expect_to_exist
@@ -91,32 +91,32 @@
# The widgets load their respective contents
within description_area.area do
expect(page)
- .to have_content('My custom description')
+ .to have_content("My custom description")
end
# within top-left area, add an additional widget
- overview_page.add_widget(1, 1, :row, 'Work packages table')
+ overview_page.add_widget(1, 1, :row, "Work packages table")
# Actually there are two success messages displayed currently. One for the grid getting updated and one
# for the query assigned to the new widget being created. A user will not notice it but the automated
# browser can get confused. Therefore we wait.
sleep(1)
- overview_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ overview_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
- table_area = Components::Grids::GridArea.new('.grid--area.-widgeted:nth-of-type(6)')
+ table_area = Components::Grids::GridArea.new(".grid--area.-widgeted:nth-of-type(6)")
table_area.expect_to_span(1, 1, 2, 2)
# A useless resizing shows no message and does not alter the size
table_area.resize_to(1, 1)
- overview_page.expect_no_toaster message: I18n.t('js.notice_successful_update')
+ overview_page.expect_no_toaster message: I18n.t("js.notice_successful_update")
table_area.expect_to_span(1, 1, 2, 2)
table_area.resize_to(1, 2)
- overview_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ overview_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
# Resizing leads to the table area now spanning a larger area
table_area.expect_to_span(1, 1, 2, 3)
diff --git a/modules/overviews/spec/features/navigation_spec.rb b/modules/overviews/spec/features/navigation_spec.rb
index 3390a8719b69..ca23d402c4ac 100644
--- a/modules/overviews/spec/features/navigation_spec.rb
+++ b/modules/overviews/spec/features/navigation_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Navigate to overview', :js do
+RSpec.describe "Navigate to overview", :js do
let(:project) { create(:project) }
let(:permissions) { [] }
let(:user) do
@@ -40,16 +40,16 @@
login_as user
end
- it 'can visit the overview page' do
+ it "can visit the overview page" do
visit project_path(project)
- within '#menu-sidebar' do
+ within "#menu-sidebar" do
click_link "Overview"
end
- within '#content' do
+ within "#content" do
expect(page)
- .to have_content('Overview')
+ .to have_content("Overview")
end
end
end
diff --git a/modules/overviews/spec/lib/overview/grid_registration_spec.rb b/modules/overviews/spec/lib/overview/grid_registration_spec.rb
index fbd7cf90297c..cc0e4c112917 100644
--- a/modules/overviews/spec/lib/overview/grid_registration_spec.rb
+++ b/modules/overviews/spec/lib/overview/grid_registration_spec.rb
@@ -1,11 +1,11 @@
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Overviews::GridRegistration do
let(:user) { build_stubbed(:user) }
let(:project) { build_stubbed(:project) }
let(:grid) { build_stubbed(:overview, project:) }
- describe 'writable?' do
+ describe "writable?" do
let(:permissions) { %i[manage_overview view_project] }
before do
@@ -14,27 +14,27 @@
end
end
- context 'if the user has the :manage_overview permission' do
- it 'is truthy' do
+ context "if the user has the :manage_overview permission" do
+ it "is truthy" do
expect(described_class)
.to be_writable(grid, user)
end
end
- context 'if the user lacks the :manage_overview permission and it is a persisted page' do
+ context "if the user lacks the :manage_overview permission and it is a persisted page" do
let(:permissions) { %i[view_project] }
- it 'is falsey' do
+ it "is falsey" do
expect(described_class)
.not_to be_writable(grid, user)
end
end
- context 'if the user lacks the :manage_overview permission and it is a new record' do
+ context "if the user lacks the :manage_overview permission and it is a new record" do
let(:permissions) { %i[view_project] }
let(:grid) { Grids::Overview.new **attributes_for(:overview).merge(project:) }
- it 'is truthy' do
+ it "is truthy" do
expect(described_class)
.to be_writable(grid, user)
end
diff --git a/modules/overviews/spec/requests/api/v3/grids/grids_resource_spec.rb b/modules/overviews/spec/requests/api/v3/grids/grids_resource_spec.rb
index 97fcb670edd7..4e5dd99c3826 100644
--- a/modules/overviews/spec/requests/api/v3/grids/grids_resource_spec.rb
+++ b/modules/overviews/spec/requests/api/v3/grids/grids_resource_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'rack/test'
+require "spec_helper"
+require "rack/test"
-RSpec.describe 'API v3 Grids resource', content_type: :json do
+RSpec.describe "API v3 Grids resource", content_type: :json do
include Rack::Test::Methods
include API::V3::Utilities::PathHelper
@@ -46,7 +46,7 @@
end
let(:widgets) do
[create(:grid_widget,
- identifier: 'custom_text',
+ identifier: "custom_text",
start_column: 1,
end_column: 3,
start_row: 1,
@@ -59,7 +59,7 @@
subject(:response) { last_response }
- describe '#get api/v3/grids/:id' do
+ describe "#get api/v3/grids/:id" do
let(:path) { api_v3_paths.grid(grid.id) }
before do
@@ -68,65 +68,65 @@
get path
end
- it 'responds with 200 OK' do
+ it "responds with 200 OK" do
expect(subject.status).to eq(200)
end
- it 'sends a grid block' do
+ it "sends a grid block" do
expect(subject.body)
- .to be_json_eql('Grid'.to_json)
- .at_path('_type')
+ .to be_json_eql("Grid".to_json)
+ .at_path("_type")
end
- it 'identifies the url the grid is stored for' do
+ it "identifies the url the grid is stored for" do
expect(subject.body)
.to be_json_eql(project_overview_path(project).to_json)
- .at_path('_links/scope/href')
+ .at_path("_links/scope/href")
end
- it 'has a widget that renders custom text' do
+ it "has a widget that renders custom text" do
expect(subject.body)
- .to be_json_eql('custom_text'.to_json)
- .at_path('widgets/0/identifier')
+ .to be_json_eql("custom_text".to_json)
+ .at_path("widgets/0/identifier")
expect(subject.body)
.to be_json_eql(custom_text.to_json)
- .at_path('widgets/0/options/text/raw')
+ .at_path("widgets/0/options/text/raw")
end
- context 'with the grid not existing' do
+ context "with the grid not existing" do
let(:path) { api_v3_paths.grid(grid.id + 1) }
- it 'responds with 404 NOT FOUND' do
+ it "responds with 404 NOT FOUND" do
expect(subject.status).to be 404
end
end
end
- shared_examples_for 'creates a grid resource' do
- it 'responds with 201 CREATED' do
+ shared_examples_for "creates a grid resource" do
+ it "responds with 201 CREATED" do
expect(subject.status).to eq(201)
end
- it 'returns the created grid block' do
+ it "returns the created grid block" do
expect(subject.body)
- .to be_json_eql('Grid'.to_json)
- .at_path('_type')
+ .to be_json_eql("Grid".to_json)
+ .at_path("_type")
if params["rowCount"]
expect(subject.body)
- .to be_json_eql(params['rowCount'].to_json)
- .at_path('rowCount')
+ .to be_json_eql(params["rowCount"].to_json)
+ .at_path("rowCount")
end
end
- it 'persists the grid' do
+ it "persists the grid" do
expect(Grids::Grid.count)
.to be(1)
end
end
- describe '#post api/v3/grids' do
+ describe "#post api/v3/grids" do
let(:path) { api_v3_paths.grids }
let(:permissions) { %i[manage_overview] }
@@ -147,9 +147,9 @@
post path, params.to_json
end
- it_behaves_like 'creates a grid resource'
+ it_behaves_like "creates a grid resource"
- context 'if lacking the manage_overview permission and not changing the default values' do
+ context "if lacking the manage_overview permission and not changing the default values" do
# Creating a grid should be possible for every member in the project to avoid having an empty page for the project
# which is why this test case is the same as the one above.
# But this is only true if only the scope is provided and no other attribute.
@@ -164,36 +164,36 @@
}.with_indifferent_access
end
- it_behaves_like 'creates a grid resource'
+ it_behaves_like "creates a grid resource"
end
- context 'if lacking the manage_overview permission and changing the default values' do
+ context "if lacking the manage_overview permission and changing the default values" do
# Creating a grid should be possible for every member in the project to avoid having an empty page for the project
# which is why this test case is the same as the one above.
# But this is only true if only the scope is provided and no other attribute.
# In this test, the rowCount and columnCount is changed
let(:permissions) { %i[] }
- it 'responds with 422' do
+ it "responds with 422" do
expect(subject.status).to eq(422)
end
- it 'persists no grid' do
+ it "persists no grid" do
expect(Grids::Grid.count)
.to be(0)
end
end
- context 'if not being a member in the project' do
+ context "if not being a member in the project" do
current_user do
create(:user)
end
- it 'responds with 422' do
+ it "responds with 422" do
expect(subject.status).to eq(422)
end
- it 'persists no grid' do
+ it "persists no grid" do
expect(Grids::Grid.count)
.to be(0)
end
diff --git a/modules/overviews/spec/services/copy_service_integration_spec.rb b/modules/overviews/spec/services/copy_service_integration_spec.rb
index 7d24d5deec57..8681551f1b50 100644
--- a/modules/overviews/spec/services/copy_service_integration_spec.rb
+++ b/modules/overviews/spec/services/copy_service_integration_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe Projects::CopyService, 'integration', type: :model do
+RSpec.describe Projects::CopyService, "integration", type: :model do
shared_let(:source) { create(:project, enabled_module_names: %w[wiki work_package_tracking]) }
- shared_let(:source_category) { create(:category, project: source, name: 'Stock management') }
- shared_let(:source_version) { create(:version, project: source, name: 'Version A') }
+ shared_let(:source_category) { create(:category, project: source, name: "Stock management") }
+ shared_let(:source_version) { create(:version, project: source, name: "Version A") }
let(:current_user) do
create(:user,
@@ -43,18 +43,18 @@
end
let(:only_args) { nil }
let(:target_project_params) do
- { name: 'Some name', identifier: 'some-identifier' }
+ { name: "Some name", identifier: "some-identifier" }
end
let(:params) do
{ target_project_params:, only: only_args }
end
- describe 'call' do
+ describe "call" do
subject { instance.call(params) }
let(:project_copy) { subject.result }
- describe 'overview' do
+ describe "overview" do
let(:widget_data) do
[
[[1, 1, 1, 2], "project_description", {}],
@@ -81,7 +81,7 @@
let(:overview) { Grids::Overview.find_by(project: project_copy) }
- context 'when requested' do
+ context "when requested" do
let(:only_args) { %i[work_packages overview] }
before do
@@ -90,12 +90,12 @@
expect(subject).to be_success
end
- it 'is copied' do
+ it "is copied" do
expect(overview.widgets.size).to eq original_overview.widgets.size
end
end
- context 'when not requested' do
+ context "when not requested" do
let(:only_args) { %i[work_packages] }
before do
@@ -104,12 +104,12 @@
expect(subject).to be_success
end
- it 'is ignored' do
+ it "is ignored" do
expect(overview).to be_nil
end
end
- describe 'copy' do
+ describe "copy" do
let(:only_args) { %i[versions categories overview] }
before do
@@ -118,7 +118,7 @@
expect(subject).to be_success
end
- it 'contains the same widgets' do
+ it "contains the same widgets" do
expect(overview.widgets.size).to eq original_overview.widgets.size
fields = %i(identifier options start_row end_row start_column end_column)
@@ -128,12 +128,12 @@
end
end
- context 'with references' do
- describe 'to queries' do
+ context "with references" do
+ describe "to queries" do
let!(:query) do
create(:public_query, project: source).tap do |query|
- query.add_filter 'version_id', '=', [source_version.id.to_s]
- query.add_filter 'category_id', '=', [source_category.id.to_s]
+ query.add_filter "version_id", "=", [source_version.id.to_s]
+ query.add_filter "category_id", "=", [source_category.id.to_s]
query.save!
end
end
@@ -144,7 +144,7 @@
]
end
- it 'copies the widgets and updates references to copied queries' do
+ it "copies the widgets and updates references to copied queries" do
expect(overview.widgets.size).to eq original_overview.widgets.size
overview.widgets.zip(original_overview.widgets).each do |widget, original_widget|
@@ -159,7 +159,7 @@
end
end
- it 'updates references within the copied query' do
+ it "updates references within the copied query" do
query_copy = Query.where(name: query.name, project: project_copy).first
expect(query_copy).to be_present
diff --git a/modules/overviews/spec/support/pages/overview.rb b/modules/overviews/spec/support/pages/overview.rb
index f79af96f932d..2794648b64f6 100644
--- a/modules/overviews/spec/support/pages/overview.rb
+++ b/modules/overviews/spec/support/pages/overview.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'support/pages/page'
+require "support/pages/page"
-require_relative '../../../../grids/spec/support/pages/grid'
+require_relative "../../../../grids/spec/support/pages/grid"
module Pages
class Overview < ::Pages::Grid
diff --git a/modules/recaptcha/Gemfile b/modules/recaptcha/Gemfile
index 851fabc21ddb..3be9c3cd812e 100644
--- a/modules/recaptcha/Gemfile
+++ b/modules/recaptcha/Gemfile
@@ -1,2 +1,2 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
gemspec
diff --git a/modules/recaptcha/app/controllers/recaptcha/admin_controller.rb b/modules/recaptcha/app/controllers/recaptcha/admin_controller.rb
index c23678e18947..9749af2063b9 100644
--- a/modules/recaptcha/app/controllers/recaptcha/admin_controller.rb
+++ b/modules/recaptcha/app/controllers/recaptcha/admin_controller.rb
@@ -4,7 +4,7 @@ class AdminController < ApplicationController
before_action :require_admin
before_action :validate_settings, only: :update
- layout 'admin'
+ layout "admin"
menu_item :plugin_recaptcha
@@ -23,7 +23,7 @@ def validate_settings
allowed_options = recaptcha_available_options.map(&:last)
unless allowed_options.include? new_params[:recaptcha_type]
- flash[:error] = I18n.t(:error_code, code: '400')
+ flash[:error] = I18n.t(:error_code, code: "400")
redirect_to action: :show
return
end
@@ -36,7 +36,7 @@ def permitted_params
end
def default_breadcrumb
- t('recaptcha.label_recaptcha')
+ t("recaptcha.label_recaptcha")
end
def show_local_breadcrumb
diff --git a/modules/recaptcha/app/controllers/recaptcha/request_controller.rb b/modules/recaptcha/app/controllers/recaptcha/request_controller.rb
index 162b29141d20..2d48aa38032e 100644
--- a/modules/recaptcha/app/controllers/recaptcha/request_controller.rb
+++ b/modules/recaptcha/app/controllers/recaptcha/request_controller.rb
@@ -1,9 +1,9 @@
-require 'recaptcha'
+require "recaptcha"
module ::Recaptcha
class RequestController < ApplicationController
# Include global layout helper
- layout 'no_menu'
+ layout "no_menu"
# User is not yet logged in, so skip login required check
skip_before_action :check_if_login_required
@@ -38,7 +38,7 @@ def verify
save_recaptcha_verification_success!
complete_stage_redirect
else
- fail_recaptcha I18n.t('recaptcha.error_captcha')
+ fail_recaptcha I18n.t("recaptcha.error_captcha")
end
end
@@ -63,7 +63,7 @@ def save_recaptcha_verification_success!
end
def recaptcha_version
- case recaptcha_settings['recaptcha_type']
+ case recaptcha_settings["recaptcha_type"]
when ::OpenProject::Recaptcha::TYPE_DISABLED
0
when ::OpenProject::Recaptcha::TYPE_V2, ::OpenProject::Recaptcha::TYPE_HCAPTCHA
@@ -76,9 +76,9 @@ def recaptcha_version
##
#
def valid_recaptcha?
- call_args = { secret_key: recaptcha_settings['secret_key'] }
+ call_args = { secret_key: recaptcha_settings["secret_key"] }
if recaptcha_version == 3
- call_args[:action] = 'login'
+ call_args[:action] = "login"
end
verify_recaptcha call_args
@@ -105,7 +105,7 @@ def recaptcha_settings
end
def skip_if_disabled
- if recaptcha_settings['recaptcha_type'] == ::OpenProject::Recaptcha::TYPE_DISABLED
+ if recaptcha_settings["recaptcha_type"] == ::OpenProject::Recaptcha::TYPE_DISABLED
complete_stage_redirect
end
end
diff --git a/modules/recaptcha/app/helpers/recaptcha_helper.rb b/modules/recaptcha/app/helpers/recaptcha_helper.rb
index b5929cf60f66..662db0a65079 100644
--- a/modules/recaptcha/app/helpers/recaptcha_helper.rb
+++ b/modules/recaptcha/app/helpers/recaptcha_helper.rb
@@ -1,10 +1,10 @@
module RecaptchaHelper
def recaptcha_available_options
[
- [I18n.t('recaptcha.settings.type_disabled'), ::OpenProject::Recaptcha::TYPE_DISABLED],
- [I18n.t('recaptcha.settings.type_v2'), ::OpenProject::Recaptcha::TYPE_V2],
- [I18n.t('recaptcha.settings.type_v3'), ::OpenProject::Recaptcha::TYPE_V3],
- [I18n.t('recaptcha.settings.type_hcaptcha'), ::OpenProject::Recaptcha::TYPE_HCAPTCHA]
+ [I18n.t("recaptcha.settings.type_disabled"), ::OpenProject::Recaptcha::TYPE_DISABLED],
+ [I18n.t("recaptcha.settings.type_v2"), ::OpenProject::Recaptcha::TYPE_V2],
+ [I18n.t("recaptcha.settings.type_v3"), ::OpenProject::Recaptcha::TYPE_V3],
+ [I18n.t("recaptcha.settings.type_hcaptcha"), ::OpenProject::Recaptcha::TYPE_HCAPTCHA]
]
end
diff --git a/modules/recaptcha/app/models/recaptcha/entry.rb b/modules/recaptcha/app/models/recaptcha/entry.rb
index 3af1e68c1efa..59637d25a681 100644
--- a/modules/recaptcha/app/models/recaptcha/entry.rb
+++ b/modules/recaptcha/app/models/recaptcha/entry.rb
@@ -1,6 +1,6 @@
module Recaptcha
class Entry < ::ApplicationRecord
- self.table_name_prefix = 'recaptcha_'
+ self.table_name_prefix = "recaptcha_"
belongs_to :user
end
end
diff --git a/modules/recaptcha/config/routes.rb b/modules/recaptcha/config/routes.rb
index ba999384cf3c..02937c072c1b 100644
--- a/modules/recaptcha/config/routes.rb
+++ b/modules/recaptcha/config/routes.rb
@@ -1,9 +1,9 @@
Rails.application.routes.draw do
- namespace 'recaptcha' do
- get :settings, to: 'admin#show'
- post :settings, to: 'admin#update'
+ namespace "recaptcha" do
+ get :settings, to: "admin#show"
+ post :settings, to: "admin#update"
- get :request, to: 'request#perform', as: 'request'
- post :verify, to: 'request#verify', as: 'verify'
+ get :request, to: "request#perform", as: "request"
+ post :verify, to: "request#verify", as: "verify"
end
end
diff --git a/modules/recaptcha/lib/open_project/recaptcha.rb b/modules/recaptcha/lib/open_project/recaptcha.rb
index 815c7d1cbe1e..d7933a433069 100644
--- a/modules/recaptcha/lib/open_project/recaptcha.rb
+++ b/modules/recaptcha/lib/open_project/recaptcha.rb
@@ -1,9 +1,9 @@
module OpenProject
module Recaptcha
- TYPE_DISABLED ||= 'disabled'
- TYPE_V2 ||= 'v2'
- TYPE_V3 ||= 'v3'
- TYPE_HCAPTCHA ||= 'hcaptcha'
+ TYPE_DISABLED ||= "disabled"
+ TYPE_V2 ||= "v2"
+ TYPE_V3 ||= "v3"
+ TYPE_HCAPTCHA ||= "hcaptcha"
require "open_project/recaptcha/engine"
require "open_project/recaptcha/configuration"
diff --git a/modules/recaptcha/lib/open_project/recaptcha/configuration.rb b/modules/recaptcha/lib/open_project/recaptcha/configuration.rb
index 8c2956fa5d41..205c9ee39362 100644
--- a/modules/recaptcha/lib/open_project/recaptcha/configuration.rb
+++ b/modules/recaptcha/lib/open_project/recaptcha/configuration.rb
@@ -1,7 +1,7 @@
module OpenProject
module Recaptcha
module Configuration
- CONFIG_KEY = 'recaptcha_via_hcaptcha'.freeze
+ CONFIG_KEY = "recaptcha_via_hcaptcha".freeze
extend self
@@ -14,11 +14,11 @@ def use_hcaptcha?
end
def type
- ::Setting.plugin_openproject_recaptcha['recaptcha_type']
+ ::Setting.plugin_openproject_recaptcha["recaptcha_type"]
end
def hcaptcha_response_limit
- (::Setting.plugin_openproject_recaptcha['response_limit'] || '5000').to_i
+ (::Setting.plugin_openproject_recaptcha["response_limit"] || "5000").to_i
end
def hcaptcha_verify_url
diff --git a/modules/recaptcha/lib/open_project/recaptcha/engine.rb b/modules/recaptcha/lib/open_project/recaptcha/engine.rb
index 312cc01b444d..a81b8d846615 100644
--- a/modules/recaptcha/lib/open_project/recaptcha/engine.rb
+++ b/modules/recaptcha/lib/open_project/recaptcha/engine.rb
@@ -1,5 +1,5 @@
-require 'open_project/plugins'
-require 'recaptcha'
+require "open_project/plugins"
+require "recaptcha"
module OpenProject::Recaptcha
class Engine < ::Rails::Engine
@@ -7,8 +7,8 @@ class Engine < ::Rails::Engine
include OpenProject::Plugins::ActsAsOpEngine
- register 'openproject-recaptcha',
- author_url: 'https://www.openproject.org',
+ register "openproject-recaptcha",
+ author_url: "https://www.openproject.org",
settings: {
default: {
recaptcha_type: ::OpenProject::Recaptcha::TYPE_DISABLED,
@@ -18,9 +18,9 @@ class Engine < ::Rails::Engine
bundled: true do
menu :admin_menu,
:plugin_recaptcha,
- { controller: '/recaptcha/admin', action: :show },
+ { controller: "/recaptcha/admin", action: :show },
parent: :authentication,
- caption: ->(*) { I18n.t('recaptcha.label_recaptcha') }
+ caption: ->(*) { I18n.t("recaptcha.label_recaptcha") }
end
initializer "openproject.configuration" do
diff --git a/modules/recaptcha/lib/openproject-recaptcha.rb b/modules/recaptcha/lib/openproject-recaptcha.rb
index f626d3d0e5df..91424a510a5c 100644
--- a/modules/recaptcha/lib/openproject-recaptcha.rb
+++ b/modules/recaptcha/lib/openproject-recaptcha.rb
@@ -1 +1 @@
-require 'open_project/recaptcha'
+require "open_project/recaptcha"
diff --git a/modules/recaptcha/openproject-recaptcha.gemspec b/modules/recaptcha/openproject-recaptcha.gemspec
index b994e33c9f56..8d07ff66c8af 100644
--- a/modules/recaptcha/openproject-recaptcha.gemspec
+++ b/modules/recaptcha/openproject-recaptcha.gemspec
@@ -1,6 +1,6 @@
Gem::Specification.new do |s|
s.name = "openproject-recaptcha"
- s.version = '1.0.0'
+ s.version = "1.0.0"
s.authors = "OpenProject GmbH"
s.email = "info@openproject.com"
s.summary = "OpenProject ReCaptcha"
@@ -8,6 +8,6 @@ Gem::Specification.new do |s|
s.files = Dir["{app,config,db,lib}/**/*", "CHANGELOG.md", "README.rdoc"]
- s.add_dependency 'recaptcha', '~> 5.7'
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.add_dependency "recaptcha", "~> 5.7"
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/recaptcha/spec/controllers/admin_controller_spec.rb b/modules/recaptcha/spec/controllers/admin_controller_spec.rb
index e253baf1d799..b621683c2e76 100644
--- a/modules/recaptcha/spec/controllers/admin_controller_spec.rb
+++ b/modules/recaptcha/spec/controllers/admin_controller_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Recaptcha::AdminController do
let(:user) { build_stubbed(:admin) }
@@ -7,10 +7,10 @@
login_as user
end
- describe 'as non admin' do
+ describe "as non admin" do
let(:user) { build_stubbed(:user) }
- it 'does not allow access' do
+ it "does not allow access" do
get :show
expect(response.status).to eq 403
@@ -19,23 +19,23 @@
end
end
- describe 'show' do
- it 'renders show' do
+ describe "show" do
+ it "renders show" do
get :show
expect(response).to be_successful
- expect(response).to render_template 'recaptcha/admin/show'
+ expect(response).to render_template "recaptcha/admin/show"
end
end
- describe '#update' do
- it 'fails if invalid param' do
+ describe "#update" do
+ it "fails if invalid param" do
post :update, params: { recaptcha_type: :unknown }
expect(response).to be_redirect
expect(flash[:error]).to be_present
end
- it 'succeeds' do
- expected = { recaptcha_type: 'v2', website_key: 'B', secret_key: 'A' }
+ it "succeeds" do
+ expected = { recaptcha_type: "v2", website_key: "B", secret_key: "A" }
expect(Setting)
.to receive(:plugin_openproject_recaptcha=)
diff --git a/modules/recaptcha/spec/controllers/request_controller_spec.rb b/modules/recaptcha/spec/controllers/request_controller_spec.rb
index ac8ac0233ce5..c586259152a7 100644
--- a/modules/recaptcha/spec/controllers/request_controller_spec.rb
+++ b/modules/recaptcha/spec/controllers/request_controller_spec.rb
@@ -1,15 +1,15 @@
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Recaptcha::RequestController do
let(:user) { create(:user) }
- include_context 'with settings' do
+ include_context "with settings" do
let(:settings) do
{
plugin_openproject_recaptcha: {
- 'recaptcha_type' => 'v2',
- 'website_key' => 'A',
- 'secret_key' => 'B'
+ "recaptcha_type" => "v2",
+ "website_key" => "A",
+ "secret_key" => "B"
}
}
end
@@ -19,49 +19,49 @@
login_as user
session[:authenticated_user_id] = user.id
- session[:stage_secrets] = { recaptcha: 'asdf' }
+ session[:stage_secrets] = { recaptcha: "asdf" }
end
- describe 'request' do
- it 'renders the template' do
+ describe "request" do
+ it "renders the template" do
get :perform
expect(response).to be_successful
- expect(response).to render_template 'recaptcha/request/perform'
+ expect(response).to render_template "recaptcha/request/perform"
end
- it 'skips if user is verified' do
+ it "skips if user is verified" do
allow(Recaptcha::Entry)
.to receive(:exists?).with(user_id: user.id)
.and_return true
get :perform
- expect(response).to redirect_to stage_success_path(stage: :recaptcha, secret: 'asdf')
+ expect(response).to redirect_to stage_success_path(stage: :recaptcha, secret: "asdf")
end
- context 'if the user is an admin' do
+ context "if the user is an admin" do
let(:user) { create(:admin) }
- it 'skips the verification' do
+ it "skips the verification" do
allow(controller).to receive(:perform)
get :perform
- expect(response).to redirect_to stage_success_path(stage: :recaptcha, secret: 'asdf')
+ expect(response).to redirect_to stage_success_path(stage: :recaptcha, secret: "asdf")
expect(controller).not_to have_received(:perform)
end
end
end
- describe 'verify' do
- it 'succeeds assuming verification works' do
+ describe "verify" do
+ it "succeeds assuming verification works" do
allow(controller).to receive(:valid_recaptcha?).and_return true
allow(controller).to receive(:save_recaptcha_verification_success!)
post :verify
expect(flash[:error]).to be_nil
- expect(response).to redirect_to stage_success_path(stage: :recaptcha, secret: 'asdf')
+ expect(response).to redirect_to stage_success_path(stage: :recaptcha, secret: "asdf")
expect(controller).to have_received(:save_recaptcha_verification_success!)
end
- it 'fails assuming verification fails' do
+ it "fails assuming verification fails" do
allow(controller).to receive(:valid_recaptcha?).and_return false
post :verify
expect(flash[:error]).to be_present
diff --git a/modules/reporting/app/controllers/cost_reports_controller.rb b/modules/reporting/app/controllers/cost_reports_controller.rb
index e8e8c28b99e5..8014ac1b6e56 100644
--- a/modules/reporting/app/controllers/cost_reports_controller.rb
+++ b/modules/reporting/app/controllers/cost_reports_controller.rb
@@ -65,7 +65,7 @@ class CostReportsController < ApplicationController
before_action :set_cost_types # has to be set AFTER the Report::Controller filters run
- layout 'angular/angular'
+ layout "angular/angular"
# Checks if custom fields have been updated, added or removed since we
# last saw them, to rebuild the filters and group bys.
@@ -120,7 +120,7 @@ def create
@query.send(:"#{user_key}=", current_user.id)
@query.save!
- redirect_params = { action: 'show', id: @query.id }
+ redirect_params = { action: "show", id: @query.id }
redirect_params[:project_id] = @project.identifier if @project
if request.xhr? # Update via AJAX - return url for redirect
@@ -137,7 +137,7 @@ def show
if @query
store_query(@query)
table
- render action: 'index', locals: { menu_name: project_or_global_menu } unless performed?
+ render action: "index", locals: { menu_name: project_or_global_menu } unless performed?
else
raise ActiveRecord::RecordNotFound
end
@@ -152,7 +152,7 @@ def destroy
else
raise ActiveRecord::RecordNotFound
end
- redirect_to action: 'index', default: 1
+ redirect_to action: "index", default: 1
end
##
@@ -169,7 +169,7 @@ def update
if request.xhr?
table
else
- redirect_to action: 'show', id: @query.id
+ redirect_to action: "show", id: @query.id
end
end
@@ -184,7 +184,7 @@ def rename
if request.xhr?
render plain: @query.name
else
- redirect_to action: 'show', id: @query.id
+ redirect_to action: "show", id: @query.id
end
end
@@ -202,7 +202,7 @@ def available_values
filter = f_cls.new.tap do |f|
f.values = JSON.parse(params[:values].tr("'", '"')) if params[:values].present? && params[:values]
end
- render_widget Widget::Filters::Option, filter, to: canvas = ''
+ render_widget Widget::Filters::Option, filter, to: canvas = ""
render plain: canvas, layout: !request.xhr?
end
@@ -224,8 +224,8 @@ def no_progress?
# Set a default query to cut down initial load time
def default_filter_parameters
{
- operators: { spent_on: '>d' },
- values: { spent_on: [30.days.ago.strftime('%Y-%m-%d')] }
+ operators: { spent_on: ">d" },
+ values: { spent_on: [30.days.ago.strftime("%Y-%m-%d")] }
}.tap do |hash|
if @project
set_project_filter(hash, @project.id)
@@ -281,12 +281,12 @@ def update_project_context!(filters)
def set_project_filter(filters, project_id)
filters[:project_context] = project_id
- filters[:operators].merge! project_id: '='
+ filters[:operators].merge! project_id: "="
filters[:values].merge! project_id: [project_id]
end
def set_me_filter(filters)
- filters[:operators].merge! user_id: '='
+ filters[:operators].merge! user_id: "="
filters[:values].merge! user_id: [CostQuery::Filter::UserId.me_value]
end
@@ -329,14 +329,14 @@ def set_unit
def set_cost_type
return unless @query
- @query.filter :cost_type_id, operator: '=', value: @unit_id.to_s, display: false
+ @query.filter :cost_type_id, operator: "=", value: @unit_id.to_s, display: false
@cost_type = CostType.find(@unit_id) if @unit_id > 0
end
# set the @cost_types -> this is used to determine which tabs to display
def set_active_cost_types
unless session[:report] && (@cost_types = session[:report][:filters][:values][:cost_type_id].try(:collect, &:to_i))
- relevant_cost_types = CostType.select(:id).order(Arel.sql('id ASC')).select do |t|
+ relevant_cost_types = CostType.select(:id).order(Arel.sql("id ASC")).select do |t|
t.cost_entries.count > 0
end.collect(&:id)
@cost_types = [-1, 0, *relevant_cost_types]
@@ -411,7 +411,7 @@ def get_filter_class(name)
# Determine the available values for the specified filter and return them as
# json, if that was requested. This will be executed INSTEAD of the actual action
def possibly_only_narrow_values
- if params[:narrow_values] == '1'
+ if params[:narrow_values] == "1"
sources = params[:sources]
dependent = params[:dependent]
@@ -422,9 +422,9 @@ def possibly_only_narrow_values
values: params[:values][dependency])
end
query.column(dependent)
- values = [[::I18n.t(:label_inactive), '<>']] + query.result.map { |r| r.fields[query.group_bys.first.field] }
+ values = [[::I18n.t(:label_inactive), "<>"]] + query.result.map { |r| r.fields[query.group_bys.first.field] }
# replace null-values with corresponding placeholder
- values = values.map { |value| value.nil? ? [::I18n.t(:label_none), '<>'] : value }
+ values = values.map { |value| value.nil? ? [::I18n.t(:label_none), "<>"] : value }
# try to find corresponding labels to the given values
values = values.map do |value|
filter = get_filter_class(dependent)
@@ -463,8 +463,8 @@ def http_filter_parameters
# Extract active group bys from the http params
def http_group_parameters
if params[:groups]
- rows = params[:groups]['rows']
- columns = params[:groups]['columns']
+ rows = params[:groups]["rows"]
+ columns = params[:groups]["columns"]
end
{ rows: rows || [], columns: columns || [] }
end
@@ -507,8 +507,8 @@ def build_query(filters, groups = {})
query = report_engine.new project: @project
query.tap do |q|
filters[:operators].each do |filter, operator|
- unless filters[:values][filter] == ['<>']
- values = Array(filters[:values][filter]).map { |v| v == '<>' ? nil : v }
+ unless filters[:values][filter] == ["<>"]
+ values = Array(filters[:values][filter]).map { |v| v == "<>" ? nil : v }
q.filter(filter.to_sym,
operator:,
values:)
@@ -539,7 +539,7 @@ def store_query(_query)
##
# Override in subclass if user key
def user_key
- 'user_id'
+ "user_id"
end
##
@@ -557,7 +557,7 @@ def make_query_public?
# Raises RecordNotFound if an invalid :id was passed.
#
# @param query An optional query added to the disjunction qualifiying reports to be returned.
- def find_optional_report(query = '1=0')
+ def find_optional_report(query = "1=0")
if params[:id]
@query = report_engine
.where(["#{is_public_sql} OR (#{user_key} = ?) OR (#{query})", current_user.id])
diff --git a/modules/reporting/app/helpers/reporting_helper.rb b/modules/reporting/app/helpers/reporting_helper.rb
index 28f717337ddd..f457ee3d3ba7 100644
--- a/modules/reporting/app/helpers/reporting_helper.rb
+++ b/modules/reporting/app/helpers/reporting_helper.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'digest/md5'
+require "digest/md5"
module ReportingHelper
# ======================= SHARED CODE START
@@ -50,7 +50,7 @@ def mapped(value, klass, default)
def label_for(field)
name = field.to_s
- if name.starts_with?('label')
+ if name.starts_with?("label")
return I18n.t(field)
end
@@ -68,8 +68,8 @@ def label_for(field)
end
end
- def debug_fields(result, prefix = ', ')
- prefix << result.fields.inspect << ', ' << result.important_fields.inspect << ', ' << result.key.inspect if params[:debug]
+ def debug_fields(result, prefix = ", ")
+ prefix << result.fields.inspect << ", " << result.important_fields.inspect << ", " << result.key.inspect if params[:debug]
end
def month_name(index)
@@ -101,7 +101,7 @@ def budget_link(budget_id)
end
def field_representation_map(key, value)
- return I18n.t(:'placeholders.default') if value.blank?
+ return I18n.t(:"placeholders.default") if value.blank?
case key.to_sym
when :activity_id then mapped value, Enumeration, "#{I18n.t(:caption_material_costs)}"
@@ -119,7 +119,7 @@ def field_representation_map(key, value)
when :week then "#{I18n.t(:label_week)} #%s" % value.to_i.modulo(100)
when :priority_id then h(IssuePriority.find(value.to_i).name)
when :version_id then h(Version.find(value.to_i).name)
- when :singleton_value then ''
+ when :singleton_value then ""
when :status_id then h(Status.find(value.to_i).name)
when /custom_field\d+/ then custom_value(key, value)
else h(value.to_s)
@@ -127,7 +127,7 @@ def field_representation_map(key, value)
end
def custom_value(cf_identifier, value)
- cf_id = cf_identifier.gsub('custom_field', '').to_i
+ cf_id = cf_identifier.gsub("custom_field", "").to_i
# Reuses rails cache to locate the custom field
# and then properly cast the value
@@ -137,7 +137,7 @@ def custom_value(cf_identifier, value)
end
def field_sort_map(key, value)
- return '' if value.blank?
+ return "" if value.blank?
case key.to_sym
when :work_package_id, :tweek, :tmonth, :week then value.to_i
@@ -149,7 +149,7 @@ def field_sort_map(key, value)
def show_result(row, unit_id = self.unit_id)
case unit_id
when -1 then l_hours(row.units)
- when 0 then row.real_costs ? number_to_currency(row.real_costs) : '-'
+ when 0 then row.real_costs ? number_to_currency(row.real_costs) : "-"
else
current_cost_type = @cost_type || CostType.find(unit_id)
pluralize(row.units, current_cost_type.unit, current_cost_type.unit_plural)
@@ -157,7 +157,7 @@ def show_result(row, unit_id = self.unit_id)
end
def set_filter_options(struct, key, value)
- struct[:operators][key] = '='
+ struct[:operators][key] = "="
struct[:values][key] = value.to_s
end
@@ -177,7 +177,7 @@ def cost_type_label(cost_type_id, cost_type_inst = nil, _plural = true)
end
def link_to_details(result)
- return '' # unless result.respond_to? :fields # uncomment to display
+ return "" # unless result.respond_to? :fields # uncomment to display
session_filter = { operators: session[:report][:filters][:operators].dup, values: session[:report][:filters][:values].dup }
filters = result.fields.inject session_filter do |struct, (key, value)|
key = key.to_sym
@@ -194,24 +194,24 @@ def link_to_details(result)
struct
end
options = { fields: filters[:operators].keys, set_filter: 1, action: :drill_down }
- link_to '[+]', filters.merge(options), class: 'drill_down', title: I18n.t(:description_drill_down)
+ link_to "[+]", filters.merge(options), class: "drill_down", title: I18n.t(:description_drill_down)
end
##
# Create the appropriate action for an entry with the type of log to use
def action_for(result, options = {})
- options.merge controller: controller_for(result.fields['type']), id: result.fields['id'].to_i
+ options.merge controller: controller_for(result.fields["type"]), id: result.fields["id"].to_i
end
def controller_for(type)
- type == 'TimeEntry' ? 'timelog' : 'costlog'
+ type == "TimeEntry" ? "timelog" : "costlog"
end
##
# Create the appropriate action for an entry with the type of log to use
def entry_for(result)
- type = result.fields['type'] == 'TimeEntry' ? TimeEntry : CostEntry
- type.find(result.fields['id'].to_i)
+ type = result.fields["type"] == "TimeEntry" ? TimeEntry : CostEntry
+ type.find(result.fields["id"].to_i)
end
##
@@ -224,7 +224,7 @@ def show_row(row)
def delimit(items, options = {})
options[:step] ||= 1
- options[:delim] ||= '•'
+ options[:delim] ||= "•"
delimited = []
items.each_with_index do |item, ix|
delimited << if ix != 0 && (ix % options[:step]).zero?
diff --git a/modules/reporting/app/models/cost_query.rb b/modules/reporting/app/models/cost_query.rb
index 726fb0a9569b..75596387f50b 100644
--- a/modules/reporting/app/models/cost_query.rb
+++ b/modules/reporting/app/models/cost_query.rb
@@ -60,24 +60,24 @@ def self.deserialize(hash, object = new)
def self.public(project)
if project
- CostQuery.where(['is_public = ? AND (project_id IS NULL OR project_id = ?)', true, project])
- .order(Arel.sql('name ASC'))
+ CostQuery.where(["is_public = ? AND (project_id IS NULL OR project_id = ?)", true, project])
+ .order(Arel.sql("name ASC"))
else
- CostQuery.where(['is_public = ? AND project_id IS NULL', true])
- .order(Arel.sql('name ASC'))
+ CostQuery.where(["is_public = ? AND project_id IS NULL", true])
+ .order(Arel.sql("name ASC"))
end
end
def self.private(project, user)
if project
- CostQuery.where(['user_id = ? AND is_public = ? AND (project_id IS NULL OR project_id = ?)',
+ CostQuery.where(["user_id = ? AND is_public = ? AND (project_id IS NULL OR project_id = ?)",
user,
false,
project])
- .order(Arel.sql('name ASC'))
+ .order(Arel.sql("name ASC"))
else
- CostQuery.where(['user_id = ? AND is_public = ? AND project_id IS NULL', user, false])
- .order(Arel.sql('name ASC'))
+ CostQuery.where(["user_id = ? AND is_public = ? AND project_id IS NULL", user, false])
+ .order(Arel.sql("name ASC"))
end
end
@@ -93,7 +93,7 @@ def serialize
def deserialize
if @chain
- raise ArgumentError, 'Cannot deserialize a report which already has a chain'
+ raise ArgumentError, "Cannot deserialize a report which already has a chain"
else
hash = serialized || serialize
self.class.deserialize(hash, self)
@@ -214,9 +214,9 @@ def size
def cache_key
deserialize unless @chain
- parts = [self.class.table_name.sub('_reports', '')]
- parts.concat([filters.sort, group_bys].map { |l| l.map(&:cache_key).join(' ') })
- parts.join '/'
+ parts = [self.class.table_name.sub("_reports", "")]
+ parts.concat([filters.sort, group_bys].map { |l| l.map(&:cache_key).join(" ") })
+ parts.join "/"
end
def self.engine
diff --git a/modules/reporting/app/models/cost_query/custom_field_mixin.rb b/modules/reporting/app/models/cost_query/custom_field_mixin.rb
index 8c9f35c2891b..4bf23500170f 100644
--- a/modules/reporting/app/models/cost_query/custom_field_mixin.rb
+++ b/modules/reporting/app/models/cost_query/custom_field_mixin.rb
@@ -32,13 +32,13 @@ module CostQuery::CustomFieldMixin
attr_reader :custom_field
SQL_TYPES = {
- 'string' => 'varchar',
- 'list' => 'varchar',
- 'text' => 'text',
- 'bool' => 'boolean',
- 'date' => 'date',
- 'int' => 'decimal(60,3)',
- 'float' => 'decimal(60,3)'
+ "string" => "varchar",
+ "list" => "varchar",
+ "text" => "text",
+ "bool" => "boolean",
+ "date" => "date",
+ "int" => "decimal(60,3)",
+ "float" => "decimal(60,3)"
}.freeze
def self.extended(base)
diff --git a/modules/reporting/app/models/cost_query/filter/activity_id.rb b/modules/reporting/app/models/cost_query/filter/activity_id.rb
index 266795163489..16a5722ddfe3 100644
--- a/modules/reporting/app/models/cost_query/filter/activity_id.rb
+++ b/modules/reporting/app/models/cost_query/filter/activity_id.rb
@@ -32,6 +32,6 @@ def self.label
end
def self.available_values(*)
- TimeEntryActivity.order(Arel.sql('name')).pluck(:name, :id)
+ TimeEntryActivity.order(Arel.sql("name")).pluck(:name, :id)
end
end
diff --git a/modules/reporting/app/models/cost_query/filter/budget_id.rb b/modules/reporting/app/models/cost_query/filter/budget_id.rb
index 03f3cf8e09ab..8449b1aea8c3 100644
--- a/modules/reporting/app/models/cost_query/filter/budget_id.rb
+++ b/modules/reporting/app/models/cost_query/filter/budget_id.rb
@@ -38,7 +38,7 @@ def self.available_values(*)
Budget
.visible(User.current)
.includes(:project)
- .pluck(:'projects.name', :subject, :id)
+ .pluck(:"projects.name", :subject, :id)
.map { |a| ["#{a[0]} - #{a[1]} ", a[2]] }
.sort_by { |a| a.first.downcase }
end
diff --git a/modules/reporting/app/models/cost_query/filter/cost_type_id.rb b/modules/reporting/app/models/cost_query/filter/cost_type_id.rb
index beea7cb01741..6e3d094edf90 100644
--- a/modules/reporting/app/models/cost_query/filter/cost_type_id.rb
+++ b/modules/reporting/app/models/cost_query/filter/cost_type_id.rb
@@ -60,6 +60,6 @@ def field
end
def self.available_values(*)
- [[::I18n.t(:caption_labor), -1]] + CostType.order(Arel.sql('name')).pluck(:name, :id)
+ [[::I18n.t(:caption_labor), -1]] + CostType.order(Arel.sql("name")).pluck(:name, :id)
end
end
diff --git a/modules/reporting/app/models/cost_query/filter/created_on.rb b/modules/reporting/app/models/cost_query/filter/created_on.rb
index 935e69773399..95627e9d12a2 100644
--- a/modules/reporting/app/models/cost_query/filter/created_on.rb
+++ b/modules/reporting/app/models/cost_query/filter/created_on.rb
@@ -27,7 +27,7 @@
#++
class CostQuery::Filter::CreatedOn < Report::Filter::Base
- db_field 'entries.created_at'
+ db_field "entries.created_at"
use :time_operators
def self.label
diff --git a/modules/reporting/app/models/cost_query/filter/custom_field_entries.rb b/modules/reporting/app/models/cost_query/filter/custom_field_entries.rb
index 8d9ff1d187d9..ad796431406e 100644
--- a/modules/reporting/app/models/cost_query/filter/custom_field_entries.rb
+++ b/modules/reporting/app/models/cost_query/filter/custom_field_entries.rb
@@ -33,12 +33,12 @@ class CostQuery::Filter::CustomFieldEntries < Report::Filter::Base
applies_for :label_work_package_attributes
# redmine internals just suck
case custom_field.field_format
- when 'string', 'text' then use :string_operators
- when 'list' then use :null_operators
- when 'date' then use :time_operators
- when 'int', 'float' then use :integer_operators
- when 'bool'
- @possible_values = [['true', 't'], ['false', 'f']]
+ when "string", "text" then use :string_operators
+ when "list" then use :null_operators
+ when "date" then use :time_operators
+ when "int", "float" then use :integer_operators
+ when "bool"
+ @possible_values = [["true", "t"], ["false", "f"]]
use :null_operators
else
fail "cannot handle #{custom_field.field_format.inspect}"
@@ -53,7 +53,7 @@ def self.field
# Mapping to the human readable value is done for all custom values (e.g. users, versions)
# following the same pattern of code, so simply making the exception here to use the value
# would complicated the code later on.
- if custom_field.field_format == 'list'
+ if custom_field.field_format == "list"
"#{db_field}.value"
else
super
@@ -65,7 +65,7 @@ def self.available_values(*)
end
def self.get_possible_values
- if custom_field.field_format == 'list'
+ if custom_field.field_format == "list"
# Treat list CFs values as string options again, since
# aggregation of groups are made by the values as well
# and otherwise, it won't work as a filter.
diff --git a/modules/reporting/app/models/cost_query/filter/logged_by_id.rb b/modules/reporting/app/models/cost_query/filter/logged_by_id.rb
index 10d93d770ff9..23f4d2a1be62 100644
--- a/modules/reporting/app/models/cost_query/filter/logged_by_id.rb
+++ b/modules/reporting/app/models/cost_query/filter/logged_by_id.rb
@@ -32,7 +32,7 @@ def self.label
end
def self.me_value
- 'me'.freeze
+ "me".freeze
end
def transformed_values
diff --git a/modules/reporting/app/models/cost_query/filter/no_filter.rb b/modules/reporting/app/models/cost_query/filter/no_filter.rb
index c2953c116e27..b2da44996af3 100644
--- a/modules/reporting/app/models/cost_query/filter/no_filter.rb
+++ b/modules/reporting/app/models/cost_query/filter/no_filter.rb
@@ -27,7 +27,7 @@
#++
class CostQuery::Filter::NoFilter < Report::Filter::NoFilter
- table_name 'entries'
+ table_name "entries"
dont_display!
singleton
diff --git a/modules/reporting/app/models/cost_query/filter/overridden_costs.rb b/modules/reporting/app/models/cost_query/filter/overridden_costs.rb
index 0eb28bf1287d..052cf9194ce4 100644
--- a/modules/reporting/app/models/cost_query/filter/overridden_costs.rb
+++ b/modules/reporting/app/models/cost_query/filter/overridden_costs.rb
@@ -32,7 +32,7 @@ def self.label
end
def self.available_operators
- ['y', 'n'].map(&:to_operator)
+ ["y", "n"].map(&:to_operator)
end
def self.available_values(*)
diff --git a/modules/reporting/app/models/cost_query/filter/permission_filter.rb b/modules/reporting/app/models/cost_query/filter/permission_filter.rb
index 86adddfcdbe1..8a59058a9d78 100644
--- a/modules/reporting/app/models/cost_query/filter/permission_filter.rb
+++ b/modules/reporting/app/models/cost_query/filter/permission_filter.rb
@@ -29,7 +29,7 @@
class CostQuery::Filter::PermissionFilter < Report::Filter::Base
dont_display!
not_selectable!
- db_field ''
+ db_field ""
singleton
initialize_query_with { |query| query.filter to_s.demodulize.to_sym }
@@ -46,10 +46,10 @@ def permission_for(type)
def display_costs
"(#{permission_statement :view_hourly_rates} " \
"AND #{permission_statement :view_cost_rates}) " \
- 'OR ' \
+ "OR " \
"(#{permission_statement :view_own_hourly_rate} " \
"AND type = 'TimeEntry' AND user_id = #{User.current.id}) " \
- 'OR ' \
+ "OR " \
"(#{permission_statement :view_cost_rates} " \
"AND type = 'CostEntry' AND user_id = #{User.current.id})"
end
@@ -57,9 +57,9 @@ def display_costs
def sql_statement
super.tap do |query|
query.from.each_subselect do |sub|
- sub.where permission_for(sub == query.from.first ? 'time' : 'cost')
- sub.select.delete_if { |f| f.end_with? 'display_costs' }
- sub.select display_costs: switch(display_costs => '1', else: 0)
+ sub.where permission_for(sub == query.from.first ? "time" : "cost")
+ sub.select.delete_if { |f| f.end_with? "display_costs" }
+ sub.select display_costs: switch(display_costs => "1", else: 0)
end
end
end
diff --git a/modules/reporting/app/models/cost_query/filter/priority_id.rb b/modules/reporting/app/models/cost_query/filter/priority_id.rb
index 258c5800d060..14ef1020177f 100644
--- a/modules/reporting/app/models/cost_query/filter/priority_id.rb
+++ b/modules/reporting/app/models/cost_query/filter/priority_id.rb
@@ -35,6 +35,6 @@ def self.label
end
def self.available_values(*)
- IssuePriority.order(Arel.sql('position DESC')).pluck(:name, :id)
+ IssuePriority.order(Arel.sql("position DESC")).pluck(:name, :id)
end
end
diff --git a/modules/reporting/app/models/cost_query/filter/project_id.rb b/modules/reporting/app/models/cost_query/filter/project_id.rb
index eeeaa1eb2d94..786bd7ad958c 100644
--- a/modules/reporting/app/models/cost_query/filter/project_id.rb
+++ b/modules/reporting/app/models/cost_query/filter/project_id.rb
@@ -27,14 +27,14 @@
#++
class CostQuery::Filter::ProjectId < Report::Filter::Base
- db_field 'entries.project_id'
+ db_field "entries.project_id"
def self.label
Project.model_name.human
end
def self.available_operators
- ['=', '!', '=_child_projects', '!_child_projects'].map(&:to_operator)
+ ["=", "!", "=_child_projects", "!_child_projects"].map(&:to_operator)
end
##
diff --git a/modules/reporting/app/models/cost_query/filter/status_id.rb b/modules/reporting/app/models/cost_query/filter/status_id.rb
index 9dacbdaf7aa8..14ba39203054 100644
--- a/modules/reporting/app/models/cost_query/filter/status_id.rb
+++ b/modules/reporting/app/models/cost_query/filter/status_id.rb
@@ -27,7 +27,7 @@
#++
class CostQuery::Filter::StatusId < Report::Filter::Base
- available_operators 'c', 'o'
+ available_operators "c", "o"
join_table WorkPackage, Status => [WorkPackage, :status]
applies_for :label_work_package_attributes
@@ -36,6 +36,6 @@ def self.label
end
def self.available_values(*)
- Status.order(Arel.sql('name')).pluck(:name, :id)
+ Status.order(Arel.sql("name")).pluck(:name, :id)
end
end
diff --git a/modules/reporting/app/models/cost_query/filter/tmonth.rb b/modules/reporting/app/models/cost_query/filter/tmonth.rb
index 5d62d320fc8b..e3e0c7ceb135 100644
--- a/modules/reporting/app/models/cost_query/filter/tmonth.rb
+++ b/modules/reporting/app/models/cost_query/filter/tmonth.rb
@@ -34,6 +34,6 @@ def self.label
end
def self.available_values(*)
- 1.upto(12).map { |i| [::I18n.t('date.month_names')[i], i] }
+ 1.upto(12).map { |i| [::I18n.t("date.month_names")[i], i] }
end
end
diff --git a/modules/reporting/app/models/cost_query/filter/type_id.rb b/modules/reporting/app/models/cost_query/filter/type_id.rb
index 92bcf3b538ff..dd7b78e2c3a8 100644
--- a/modules/reporting/app/models/cost_query/filter/type_id.rb
+++ b/modules/reporting/app/models/cost_query/filter/type_id.rb
@@ -35,6 +35,6 @@ def self.label
end
def self.available_values(*)
- Type.order(Arel.sql('name')).pluck(:name, :id)
+ Type.order(Arel.sql("name")).pluck(:name, :id)
end
end
diff --git a/modules/reporting/app/models/cost_query/filter/updated_on.rb b/modules/reporting/app/models/cost_query/filter/updated_on.rb
index 9f379d04bd23..623d8381e551 100644
--- a/modules/reporting/app/models/cost_query/filter/updated_on.rb
+++ b/modules/reporting/app/models/cost_query/filter/updated_on.rb
@@ -27,7 +27,7 @@
#++
class CostQuery::Filter::UpdatedOn < Report::Filter::Base
- db_field 'entries.updated_at'
+ db_field "entries.updated_at"
use :time_operators
def self.label
diff --git a/modules/reporting/app/models/cost_query/filter/user_id.rb b/modules/reporting/app/models/cost_query/filter/user_id.rb
index 215e593850c3..9d3c70c31e28 100644
--- a/modules/reporting/app/models/cost_query/filter/user_id.rb
+++ b/modules/reporting/app/models/cost_query/filter/user_id.rb
@@ -32,7 +32,7 @@ def self.label
end
def self.me_value
- 'me'.freeze
+ "me".freeze
end
def transformed_values
diff --git a/modules/reporting/app/models/cost_query/filter/work_package_id.rb b/modules/reporting/app/models/cost_query/filter/work_package_id.rb
index 9174407e3e48..d26f48ffcfb4 100644
--- a/modules/reporting/app/models/cost_query/filter/work_package_id.rb
+++ b/modules/reporting/app/models/cost_query/filter/work_package_id.rb
@@ -40,7 +40,7 @@ def self.available_values(*)
end
def self.available_operators
- ['='].map(&:to_operator)
+ ["="].map(&:to_operator)
end
##
@@ -55,7 +55,7 @@ def self.label_for_value(value)
def self.text_for_tuple(id, subject)
str = "##{id} "
- str << (subject.length > 30 ? subject.first(26) + '...' : subject)
+ str << (subject.length > 30 ? subject.first(26) + "..." : subject)
end
def self.text_for_work_package(i)
diff --git a/modules/reporting/app/models/cost_query/operator.rb b/modules/reporting/app/models/cost_query/operator.rb
index 85675cc42960..47ef027bc1bb 100644
--- a/modules/reporting/app/models/cost_query/operator.rb
+++ b/modules/reporting/app/models/cost_query/operator.rb
@@ -30,7 +30,7 @@ class CostQuery::Operator < Report::Operator
# Operators from Redmine
new "c", arity: 0, label: :label_closed do
def modify(query, field, *_values)
- raise "wrong field" if field.to_s.split('.').last != "status_id"
+ raise "wrong field" if field.to_s.split(".").last != "status_id"
query.where "(#{Status.table_name}.is_closed = #{quoted_true})"
query
@@ -39,7 +39,7 @@ def modify(query, field, *_values)
new "o", arity: 0, label: :label_open do
def modify(query, field, *_values)
- raise "wrong field" if field.to_s.split('.').last != "status_id"
+ raise "wrong field" if field.to_s.split(".").last != "status_id"
query.where "(#{Status.table_name}.is_closed = #{quoted_false})"
query
@@ -62,7 +62,7 @@ def modify(query, field, *values)
def modify(query, field, *values)
p_ids = []
values.each do |value|
- value.to_s.split(',').each do |id|
+ value.to_s.split(",").each do |id|
p_ids += ([id] << Project.find(id).descendants.map(&:id))
end
end
diff --git a/modules/reporting/app/models/cost_query/sql_statement.rb b/modules/reporting/app/models/cost_query/sql_statement.rb
index d7ebfd3d2a8a..db4e05a32dbc 100644
--- a/modules/reporting/app/models/cost_query/sql_statement.rb
+++ b/modules/reporting/app/models/cost_query/sql_statement.rb
@@ -44,7 +44,7 @@ def initialize(table, desc = "")
# this is a hack to ensure that additional joins added by filters do not result
# in additional columns being selected.
def to_s
- select(['entries.*']) if select == ['*'] && group_by.empty? && entry_union
+ select(["entries.*"]) if select == ["*"] && group_by.empty? && entry_union
super
end
diff --git a/modules/reporting/app/models/entry.rb b/modules/reporting/app/models/entry.rb
index 17a4f515aad3..4af0eace0c45 100644
--- a/modules/reporting/app/models/entry.rb
+++ b/modules/reporting/app/models/entry.rb
@@ -64,12 +64,12 @@ def calculate(type, *)
private
def all(*args)
- ActiveSupport::Deprecation.warn('Passing arguments is deprecated') if args.any?
+ ActiveSupport::Deprecation.warn("Passing arguments is deprecated") if args.any?
find_many :all # *args
end
def count(*args)
- ActiveSupport::Deprecation.warn('Passing arguments is deprecated') if args.any?
+ ActiveSupport::Deprecation.warn("Passing arguments is deprecated") if args.any?
find_many :count # *args
end
diff --git a/modules/reporting/app/workers/cost_query/export_job.rb b/modules/reporting/app/workers/cost_query/export_job.rb
index a9b597a955c7..530e40f1134d 100644
--- a/modules/reporting/app/workers/cost_query/export_job.rb
+++ b/modules/reporting/app/workers/cost_query/export_job.rb
@@ -1,10 +1,10 @@
-require 'active_storage/filename'
+require "active_storage/filename"
class CostQuery::ExportJob < Exports::ExportJob
self.model = ::CostQuery
def title
- I18n.t('export.cost_reports.title')
+ I18n.t("export.cost_reports.title")
end
def project
@@ -30,12 +30,12 @@ def export!
def xls_report_result
params = { query:, project:, cost_types: }
content = ::OpenProject::Reporting::CostEntryXlsTable.generate(params).xls
- time = Time.current.strftime('%Y-%m-%d-T-%H-%M-%S')
+ time = Time.current.strftime("%Y-%m-%d-T-%H-%M-%S")
export_title = "cost-report-#{time}.xls"
::Exports::Result.new(format: :xls,
title: export_title,
- mime_type: 'application/vnd.ms-excel',
+ mime_type: "application/vnd.ms-excel",
content:)
end
@@ -44,8 +44,8 @@ def build_query(filters, groups = {})
query = CostQuery.new(project:)
query.tap do |q|
filters[:operators].each do |filter, operator|
- unless filters[:values][filter] == ['<>']
- values = Array(filters[:values][filter]).map { |v| v == '<>' ? nil : v }
+ unless filters[:values][filter] == ["<>"]
+ values = Array(filters[:values][filter]).map { |v| v == "<>" ? nil : v }
q.filter(filter.to_sym,
operator:,
values:)
diff --git a/modules/reporting/config/routes.rb b/modules/reporting/config/routes.rb
index 81d826ae64b6..1cc8ea7b225e 100644
--- a/modules/reporting/config/routes.rb
+++ b/modules/reporting/config/routes.rb
@@ -27,7 +27,7 @@
#++
Rails.application.routes.draw do
- scope 'projects/:project_id' do
+ scope "projects/:project_id" do
resources :cost_reports, except: :create do
collection do
match :index, via: %i[get post]
diff --git a/modules/reporting/db/migrate/20180323130704_to_v710_aggregated_reporting_migrations.rb b/modules/reporting/db/migrate/20180323130704_to_v710_aggregated_reporting_migrations.rb
index 7b4b581cea3e..aa464e64736d 100644
--- a/modules/reporting/db/migrate/20180323130704_to_v710_aggregated_reporting_migrations.rb
+++ b/modules/reporting/db/migrate/20180323130704_to_v710_aggregated_reporting_migrations.rb
@@ -57,7 +57,7 @@ def down
def migrations
MIGRATION_FILES.split.map do |m|
- m.gsub(/_.*\z/, '')
+ m.gsub(/_.*\z/, "")
end
end
end
diff --git a/modules/reporting/lib/open_project/reporting/cost_entry_xls_table.rb b/modules/reporting/lib/open_project/reporting/cost_entry_xls_table.rb
index 11851766e81f..6cdd22eedb73 100644
--- a/modules/reporting/lib/open_project/reporting/cost_entry_xls_table.rb
+++ b/modules/reporting/lib/open_project/reporting/cost_entry_xls_table.rb
@@ -19,7 +19,7 @@ def setup_query_for_tab(query, unit_id)
@unit_id = unit_id
if @unit_id != 0
- @query.filter :cost_type_id, operator: '=', value: @unit_id.to_s
+ @query.filter :cost_type_id, operator: "=", value: @unit_id.to_s
@cost_type = CostType.find(unit_id) if unit_id.positive?
end
end
@@ -53,7 +53,7 @@ def format_columns
end
def cost_row(result)
- current_cost_type_id = result.fields['cost_type_id'].to_i
+ current_cost_type_id = result.fields["cost_type_id"].to_i
cost_entry_attributes
.map { |field| show_field field, result.fields[field.to_s] }
@@ -67,7 +67,7 @@ def cost_row(result)
end
def build_footer
- footer = [''] * cost_entry_attributes.size
+ footer = [""] * cost_entry_attributes.size
footer += if show_result(query, 0) == show_result(query)
multiple_unit_types_footer
else
@@ -77,11 +77,11 @@ def build_footer
end
def one_unit_type_footer
- [show_result(query), '', show_result(query, 0)]
+ [show_result(query), "", show_result(query, 0)]
end
def multiple_unit_types_footer
- ['', '', show_result(query)]
+ ["", "", show_result(query)]
end
def headers
@@ -99,8 +99,8 @@ def sorted_results
query
.each_direct_result
.map(&:itself)
- .group_by { |r| DateTime.parse(r.fields['spent_on']) }
+ .group_by { |r| DateTime.parse(r.fields["spent_on"]) }
.sort
- .flat_map { |_, date_results| date_results.sort_by { |r| r.fields['id'] } }
+ .flat_map { |_, date_results| date_results.sort_by { |r| r.fields["id"] } }
end
end
diff --git a/modules/reporting/lib/open_project/reporting/engine.rb b/modules/reporting/lib/open_project/reporting/engine.rb
index f9e59e754e64..0a1e34e48bff 100644
--- a/modules/reporting/lib/open_project/reporting/engine.rb
+++ b/modules/reporting/lib/open_project/reporting/engine.rb
@@ -34,8 +34,8 @@ class Engine < ::Rails::Engine
config.eager_load_paths += Dir["#{config.root}/lib/"]
- register 'openproject-reporting',
- author_url: 'https://www.openproject.org',
+ register "openproject-reporting",
+ author_url: "https://www.openproject.org",
bundled: true do
view_actions = %i[index show drill_down available_values]
edit_actions = %i[create update rename destroy]
@@ -75,54 +75,54 @@ class Engine < ::Rails::Engine
# menu extensions
menu :top_menu,
:cost_reports_global,
- { controller: '/cost_reports', action: 'index', project_id: nil },
+ { controller: "/cost_reports", action: "index", project_id: nil },
caption: :cost_reports_title,
- icon: 'cost-reports',
+ icon: "cost-reports",
if: should_render
menu :global_menu,
:cost_reports_global,
- { controller: '/cost_reports', action: 'index', project_id: nil },
+ { controller: "/cost_reports", action: "index", project_id: nil },
after: :news,
caption: :cost_reports_title,
- icon: 'cost-reports',
+ icon: "cost-reports",
if: should_render
menu :global_menu,
:cost_reports_global_report_menu,
- { controller: '/cost_reports', action: 'index', project_id: nil },
+ { controller: "/cost_reports", action: "index", project_id: nil },
parent: :cost_reports_global,
- partial: 'cost_reports/report_menu',
+ partial: "cost_reports/report_menu",
if: should_render
menu :project_menu,
:costs,
- { controller: '/cost_reports', action: 'index' },
+ { controller: "/cost_reports", action: "index" },
after: :news,
caption: :cost_reports_title,
if: Proc.new { |project| project.module_enabled?(:costs) },
- icon: 'cost-reports'
+ icon: "cost-reports"
menu :project_menu,
:costs_menu,
- { controller: '/cost_reports', action: 'index' },
+ { controller: "/cost_reports", action: "index" },
if: Proc.new { |project| project.module_enabled?(:costs) },
- partial: '/cost_reports/report_menu',
+ partial: "/cost_reports/report_menu",
parent: :costs
end
initializer "reporting.register_hooks" do
# don't use require_dependency to not reload hooks in development mode
- require 'open_project/reporting/hooks'
+ require "open_project/reporting/hooks"
end
- initializer 'reporting.load_patches' do
- require_relative 'patches/big_decimal_patch'
- require_relative 'patches/to_date_patch'
+ initializer "reporting.load_patches" do
+ require_relative "patches/big_decimal_patch"
+ require_relative "patches/to_date_patch"
end
- initializer 'reporting.configuration' do
- ::Settings::Definition.add 'cost_reporting_cache_filter_classes',
+ initializer "reporting.configuration" do
+ ::Settings::Definition.add "cost_reporting_cache_filter_classes",
default: true,
format: :boolean
end
diff --git a/modules/reporting/lib/open_project/reporting/patches/setting_seeder_patch.rb b/modules/reporting/lib/open_project/reporting/patches/setting_seeder_patch.rb
index 45c7dbb1481b..8a23156abf1d 100644
--- a/modules/reporting/lib/open_project/reporting/patches/setting_seeder_patch.rb
+++ b/modules/reporting/lib/open_project/reporting/patches/setting_seeder_patch.rb
@@ -35,8 +35,8 @@ module InstanceMethods
def data
original_data = super
- unless original_data['default_projects_modules'].include? 'reporting_module'
- original_data['default_projects_modules'] << 'reporting_module'
+ unless original_data["default_projects_modules"].include? "reporting_module"
+ original_data["default_projects_modules"] << "reporting_module"
end
original_data
diff --git a/modules/reporting/lib/open_project/reporting/patches/to_date_patch.rb b/modules/reporting/lib/open_project/reporting/patches/to_date_patch.rb
index 9f53f56f0188..38817aa998ba 100644
--- a/modules/reporting/lib/open_project/reporting/patches/to_date_patch.rb
+++ b/modules/reporting/lib/open_project/reporting/patches/to_date_patch.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'date'
+require "date"
module OpenProject::Reporting::Patches::ToDatePatch
module StringAndNil
diff --git a/modules/reporting/lib/openproject-reporting.rb b/modules/reporting/lib/openproject-reporting.rb
index a8ef79633a7a..3e3364089053 100644
--- a/modules/reporting/lib/openproject-reporting.rb
+++ b/modules/reporting/lib/openproject-reporting.rb
@@ -26,4 +26,4 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'open_project/reporting'
+require "open_project/reporting"
diff --git a/modules/reporting/lib/report/chainable.rb b/modules/reporting/lib/report/chainable.rb
index ebf31f7b80d5..19078a56ea26 100644
--- a/modules/reporting/lib/report/chainable.rb
+++ b/modules/reporting/lib/report/chainable.rb
@@ -37,7 +37,7 @@ class Chainable
# this attr. should point to a symbol useable for translations
inherited_attribute :applies_for, default: :label_cost_entry_attributes
- def_delegators :'self.class', :table_joins, :table_name, :field, :display?, :underscore_name
+ def_delegators :"self.class", :table_joins, :table_name, :field, :display?, :underscore_name
def self.accepts_property(*list)
engine.accepted_properties.push(*list.map(&:to_s))
@@ -72,7 +72,7 @@ def self.available
def self.register(label)
available << klass
- set_inherited_attribute 'label', label
+ set_inherited_attribute "label", label
end
def self.table_joins
@@ -117,7 +117,7 @@ def self.cache_key
inherited_attribute :properties, list: true
def self.label
- 'Translation needed'
+ "Translation needed"
end
class << self
@@ -192,7 +192,7 @@ def compute_to_a
end
def to_s
- URI.escape to_a.map(&:join).join(',')
+ URI.escape to_a.map(&:join).join(",")
end
def serialize
diff --git a/modules/reporting/lib/report/filter/base.rb b/modules/reporting/lib/report/filter/base.rb
index 2f59b0c83212..c029100c4ca8 100644
--- a/modules/reporting/lib/report/filter/base.rb
+++ b/modules/reporting/lib/report/filter/base.rb
@@ -39,12 +39,12 @@ class Base < Report::Chainable
accepts_property :values, :value, :operator
mattr_accessor :skip_inherited_operators
- self.skip_inherited_operators = [:time_operators, 'y', 'n']
+ self.skip_inherited_operators = [:time_operators, "y", "n"]
attr_accessor :values
def cache_key
- self.class.cache_key + operator.to_s + Array(values).join(',')
+ self.class.cache_key + operator.to_s + Array(values).join(",")
end
##
diff --git a/modules/reporting/lib/report/filter/multi_choice.rb b/modules/reporting/lib/report/filter/multi_choice.rb
index fe3f2a5415d9..f8dc5601b007 100644
--- a/modules/reporting/lib/report/filter/multi_choice.rb
+++ b/modules/reporting/lib/report/filter/multi_choice.rb
@@ -29,7 +29,7 @@
class Report::Filter
class MultiChoice < Base
dont_inherit :available_operators
- use '='
+ use "="
def self.is_multiple_choice?
true
diff --git a/modules/reporting/lib/report/filter/no_filter.rb b/modules/reporting/lib/report/filter/no_filter.rb
index 81193f802320..41b2c87219cb 100644
--- a/modules/reporting/lib/report/filter/no_filter.rb
+++ b/modules/reporting/lib/report/filter/no_filter.rb
@@ -27,7 +27,7 @@
#++
class Report::Filter::NoFilter < Report::Filter::Base
- table_name 'entries'
+ table_name "entries"
dont_display!
singleton
diff --git a/modules/reporting/lib/report/group_by/base.rb b/modules/reporting/lib/report/group_by/base.rb
index b71d41191371..cd029d4fa120 100644
--- a/modules/reporting/lib/report/group_by/base.rb
+++ b/modules/reporting/lib/report/group_by/base.rb
@@ -54,7 +54,7 @@ def cache_key
def all_group_fields(prefix = true)
@all_group_fields ||= []
@all_group_fields[prefix ? 0 : 1] ||= begin
- fields = group_fields.reject { |c| c.blank? or c == 'base' }
+ fields = group_fields.reject { |c| c.blank? or c == "base" }
(parent ? parent.all_group_fields(prefix) : []) + (prefix ? with_table(fields) : fields)
end.uniq
end
@@ -78,7 +78,7 @@ def select_fields
def all_select_fields(prefix = true)
@all_select_fields ||= []
@all_select_fields[prefix ? 0 : 1] ||= begin
- fields = select_fields.reject { |c| c.blank? or c == 'base' }
+ fields = select_fields.reject { |c| c.blank? or c == "base" }
(parent ? parent.all_select_fields(prefix) : []) + (prefix ? with_table(fields) : fields)
end.uniq
end
diff --git a/modules/reporting/lib/report/group_by/singleton_value.rb b/modules/reporting/lib/report/group_by/singleton_value.rb
index f2d0777f799c..f41e597066ff 100644
--- a/modules/reporting/lib/report/group_by/singleton_value.rb
+++ b/modules/reporting/lib/report/group_by/singleton_value.rb
@@ -30,12 +30,12 @@ class Report::GroupBy
class SingletonValue < Base
dont_display!
- put_sql_table_names 'singleton_value' => false
- select_fields '1 as singleton_value'
+ put_sql_table_names "singleton_value" => false
+ select_fields "1 as singleton_value"
def define_group(sql)
- sql.select '1 as singleton_value'
- sql.group_by 'singleton_value'
+ sql.select "1 as singleton_value"
+ sql.group_by "singleton_value"
end
end
end
diff --git a/modules/reporting/lib/report/group_by/sql_aggregation.rb b/modules/reporting/lib/report/group_by/sql_aggregation.rb
index c82d0ac134db..bad9b6a4fb0d 100644
--- a/modules/reporting/lib/report/group_by/sql_aggregation.rb
+++ b/modules/reporting/lib/report/group_by/sql_aggregation.rb
@@ -39,7 +39,7 @@ def compute_result
def sql_statement
super.tap do |sql|
define_group sql
- sql.count unless sql.selects.include? 'count'
+ sql.count unless sql.selects.include? "count"
end
end
end
diff --git a/modules/reporting/lib/report/operator.rb b/modules/reporting/lib/report/operator.rb
index 35654636dbe5..e148ef488375 100644
--- a/modules/reporting/lib/report/operator.rb
+++ b/modules/reporting/lib/report/operator.rb
@@ -57,14 +57,14 @@ def label
end
# Operators from Redmine
- new '>t-', label: :label_less_than_ago do
+ new ">t-", label: :label_less_than_ago do
include DateRange
def modify(query, field, value)
super(query, field, -value.to_i, 0)
end
end
- new 'w', arity: 0, label: :label_this_week do
+ new "w", arity: 0, label: :label_this_week do
def modify(query, field, offset = nil)
offset ||= 0
first_day = begin
@@ -75,50 +75,50 @@ def modify(query, field, offset = nil)
from = Time.now.at_beginning_of_week + ((first_day % 7) - 1).days
from -= offset.days
- '<>d'.to_operator.modify query, field, from, from + 7.days
+ "<>d".to_operator.modify query, field, from, from + 7.days
end
end
- new 't+', label: :label_in do
+ new "t+", label: :label_in do
include DateRange
def modify(query, field, *values)
super(query, field, values.first.to_i, values.first.to_i)
end
end
- new '<=', label: :label_less_or_equal
+ new "<=", label: :label_less_or_equal
- new '!', label: :label_not_equals do
+ new "!", label: :label_not_equals do
def modify(query, field, *values)
where_clause = "(#{field} IS NULL"
where_clause += " OR #{field} NOT IN #{collection(*values)}" unless values.all?(&:blank?)
- where_clause += ')'
+ where_clause += ")"
query.where where_clause
query
end
end
- new 't-', label: :label_ago do
+ new "t-", label: :label_ago do
include DateRange
def modify(query, field, *values)
super(query, field, -values.first.to_i, -values.first.to_i)
end
end
- new '!~', arity: 1, label: :label_not_contains do
+ new "!~", arity: 1, label: :label_not_contains do
def modify(query, field, *values)
- value = values.first || ''
+ value = values.first || ""
query.where "LOWER(#{field}) NOT LIKE '%#{quote_string(value.to_s.downcase)}%'"
query
end
end
- new '=', label: :label_equals do
+ new "=", label: :label_equals do
def modify(query, field, *values)
if values.size == 1 && values.first.nil?
query.where "#{field} IS NULL"
elsif values.all?(&:blank?)
- query.where '1=0'
+ query.where "1=0"
else
query.where "#{field} IN #{collection(*values)}"
end
@@ -126,80 +126,80 @@ def modify(query, field, *values)
end
end
- new '~', arity: 1, label: :label_contains do
+ new "~", arity: 1, label: :label_contains do
def modify(query, field, *values)
- value = values.first || ''
+ value = values.first || ""
query.where "LOWER(#{field}) LIKE '%#{quote_string(value.to_s.downcase)}%'"
query
end
end
- new '=', label: :label_greater_or_equal
+ new ">=", label: :label_greater_or_equal
- new '!*', arity: 0, where_clause: '%s IS NULL', label: :label_none
+ new "!*", arity: 0, where_clause: "%s IS NULL", label: :label_none
- new 't+', label: :label_in_more_than do
+ new ">t+", label: :label_in_more_than do
include DateRange
def modify(query, field, value)
super(query, field, value.to_i, nil)
end
end
- new '*', arity: 0, where_clause: '%s IS NOT NULL', label: :label_all
+ new "*", arity: 0, where_clause: "%s IS NOT NULL", label: :label_all
# Our own operators
- new '<', label: :label_less
- new '>', label: :label_greater
+ new "<", label: :label_less
+ new ">", label: :label_greater
- new '=n', label: :label_equals do
+ new "=n", label: :label_equals do
def modify(query, field, value)
query.where "#{field} = #{parse_number_string(value)}"
query
end
end
- new '0', label: :label_none, where_clause: '%s = 0'
- new 'y', label: :label_yes, arity: 0, where_clause: '%s IS NOT NULL'
- new 'n', label: :label_no, arity: 0, where_clause: '%s IS NULL'
+ new "0", label: :label_none, where_clause: "%s = 0"
+ new "y", label: :label_yes, arity: 0, where_clause: "%s IS NOT NULL"
+ new "n", label: :label_no, arity: 0, where_clause: "%s IS NULL"
- new 'd', label: :label_greater_or_equal, validate: :dates do
+ new ">d", label: :label_greater_or_equal, validate: :dates do
def modify(query, field, value)
return query if value.to_s.empty?
- '>='.to_operator.modify query, field, quoted_date(value)
+ ">=".to_operator.modify query, field, quoted_date(value)
end
end
- new '<>d', label: :label_between, validate: :dates do
+ new "<>d", label: :label_between, validate: :dates do
def modify(query, field, from, to)
return query if from.to_s.empty? || to.to_s.empty?
@@ -208,39 +208,39 @@ def modify(query, field, from, to)
end
end
- new '=d', label: :label_date_on, validate: :dates do
+ new "=d", label: :label_date_on, validate: :dates do
def modify(query, field, value)
return query if value.to_s.empty?
- '='.to_operator.modify query, field, quoted_date(value)
+ "=".to_operator.modify query, field, quoted_date(value)
end
end
- new '>=d', label: :label_days_ago, validate: :integers do
+ new ">=d", label: :label_days_ago, validate: :integers do
force! :integers
def modify(query, field, value)
now = Time.now
from = (now - value.to_i.days).beginning_of_day
- '<>d'.to_operator.modify query, field, from, now
+ "<>d".to_operator.modify query, field, from, now
end
end
- new '?=', label: :label_null_or_equal do
+ new "?=", label: :label_null_or_equal do
def modify(query, field, *values)
where_clause = "(#{field} IS NULL"
where_clause += " OR #{field} IN #{collection(*values)}" unless values.compact.empty?
- where_clause += ')'
+ where_clause += ")"
query.where where_clause
query
end
end
- new '?!', label: :label_not_null_and_not_equal do
+ new "?!", label: :label_not_null_and_not_equal do
def modify(query, field, *values)
where_clause = "(#{field} IS NOT NULL"
where_clause += " AND #{field} NOT IN #{collection(*values)}" unless values.compact.empty?
- where_clause += ')'
+ where_clause += ")"
query.where where_clause
query
end
@@ -297,28 +297,28 @@ def self.defaults(&)
end
def self.default_operator
- find '='
+ find "="
end
def self.integer_operators
- ['<', '>', '<=', '>='].map(&:to_operator)
+ ["<", ">", "<=", ">="].map(&:to_operator)
end
def self.null_operators
- ['*', '!*'].map(&:to_operator)
+ ["*", "!*"].map(&:to_operator)
end
def self.string_operators
- ['!~', '~'].map(&:to_operator)
+ ["!~", "~"].map(&:to_operator)
end
def self.time_operators
# ["t-", "t+", ">t-", "t+", "d', '>d', '=d'].map(&:to_operator)
+ ["t", "w", "<>d", ">d", "=d"].map(&:to_operator)
end
def self.default_operators
- ['=', '!'].map(&:to_operator)
+ ["=", "!"].map(&:to_operator)
end
attr_reader :name
@@ -365,7 +365,7 @@ def aka(alt_name, alt_label)
op = all[name].clone
op.send(:rename_to, alt_name)
- op.singleton_class.send(:define_method, 'label') { alt_label }
+ op.singleton_class.send(:define_method, "label") { alt_label }
all[alt] = op
end
diff --git a/modules/reporting/lib/report/query_utils.rb b/modules/reporting/lib/report/query_utils.rb
index 83ecc312938d..d4bd166f3f94 100644
--- a/modules/reporting/lib/report/query_utils.rb
+++ b/modules/reporting/lib/report/query_utils.rb
@@ -30,7 +30,7 @@ module Report::QueryUtils
Infinity = 1.0 / 0
include Engine
- delegate :quoted_false, :quoted_true, to: 'engine.reporting_connection'
+ delegate :quoted_false, :quoted_true, to: "engine.reporting_connection"
attr_writer :engine
include Costs::NumberHelper
@@ -57,7 +57,7 @@ def current_language
# @param [#flatten] *values Ruby collection
# @return [String] SQL collection
def collection(*values)
- return '' if values.empty?
+ return "" if values.empty?
v = if values.is_a?(Array)
values.flatten.each_with_object([]) do |str, l|
@@ -74,7 +74,7 @@ def split_with_safe_return(str)
# From ruby doc:
# When the input str is empty an empty Array is returned as the string is
# considered to have no fields to split.
- str.to_s.empty? ? '' : str.to_s.split(',')
+ str.to_s.empty? ? "" : str.to_s.split(",")
end
##
@@ -129,7 +129,7 @@ def table_name_for(object)
# @param [Object, optional] default_table Table name to use if no table name is given.
# @return [String] Field name.
def field_name_for(arg)
- return 'NULL' unless arg
+ return "NULL" unless arg
return field_name_for(arg.keys.first) if arg.is_a? Hash
return "#{table_name_for(arg.first)}.#{arg.last}" if arg.is_a? Array and arg.size == 2
@@ -179,7 +179,7 @@ def convert_unless_nil(value)
def map_field(key, value)
case key.to_s
- when 'tweek', 'tmonth', 'tweek' then value.to_i
+ when "tweek", "tmonth", "tweek" then value.to_i
else convert_unless_nil(value, &:to_s)
end
end
diff --git a/modules/reporting/lib/report/result.rb b/modules/reporting/lib/report/result.rb
index 7b3375f25a62..bfc6d58069fc 100644
--- a/modules/reporting/lib/report/result.rb
+++ b/modules/reporting/lib/report/result.rb
@@ -162,11 +162,11 @@ def has_children?
end
def count
- self['count'].to_i
+ self["count"].to_i
end
def units
- self['units'].to_d
+ self["units"].to_d
end
##
diff --git a/modules/reporting/lib/report/sql_statement.rb b/modules/reporting/lib/report/sql_statement.rb
index 00417cbe07d4..3a0313e21513 100644
--- a/modules/reporting/lib/report/sql_statement.rb
+++ b/modules/reporting/lib/report/sql_statement.rb
@@ -61,7 +61,7 @@ def gsub(...)
# Generates new SqlStatement.
#
# @param [String, #to_s] table Table name (or subselect) for from part.
- def initialize(table, desc = '')
+ def initialize(table, desc = "")
self.desc = desc
from table
end
@@ -93,7 +93,7 @@ def sum(field, name = :sum, type = :sum)
#
# @param [#to_s] field Name of the field to aggregate on (defaults to *)
# @param [#to_s] name Name of the result (defaults to sum)
- def count(field = '*', name = :count)
+ def count(field = "*", name = :count)
sum field, name, :count
end
@@ -143,7 +143,7 @@ def from(table = nil)
# @param [Array, Hash, String] fields Parameters passed to sanitize_sql_for_conditions.
# @see Report::QueryUtils#sanitize_sql_for_conditions
def where(fields = nil)
- @where ||= ['1=1']
+ @where ||= ["1=1"]
unless fields.nil?
@where << sanitize_sql_for_conditions(fields)
@sql = nil
@@ -171,7 +171,7 @@ def joins
# @see #joins
def join(*list)
@sql = nil
- join_syntax = 'LEFT OUTER JOIN %1$s ON %1$s.id = %2$s_id'
+ join_syntax = "LEFT OUTER JOIN %1$s ON %1$s.id = %2$s_id"
list.each do |e|
case e
when Class then joins << (join_syntax % [table_name_for(e), e.lookup_ancestors.last.model_name.to_s.underscore])
@@ -186,7 +186,7 @@ def join(*list)
def default_select(value = nil)
@default_select = value if value
- @default_select ||= ['*']
+ @default_select ||= ["*"]
end
##
@@ -222,7 +222,7 @@ def select(*fields)
end
# when doing a union in sql, both subselects must have the same order.
# by sorting here we never ever have to worry about this again, sucker!
- @select = @select.uniq.sort_by { |x| x.split(' as ').last }
+ @select = @select.uniq.sort_by { |x| x.split(" as ").last }
end
end
@@ -246,7 +246,7 @@ def never_select(*fields)
# Return the names which have been bound through select statements
# @return [Array] All fields for select part
def selects
- @select.map { |s| s.split(' as ').last }
+ @select.map { |s| s.split(" as ").last }
end
##
diff --git a/modules/reporting/lib/report/validation.rb b/modules/reporting/lib/report/validation.rb
index 72462dfcb5e8..3d555a4e27cf 100644
--- a/modules/reporting/lib/report/validation.rb
+++ b/modules/reporting/lib/report/validation.rb
@@ -40,7 +40,7 @@ def register_validation(val_method)
begin
val_module = Report::Validation.const_get const_name
singleton_class.send(:include, val_module)
- val_method = 'validate_' + val_method.to_s.pluralize
+ val_method = "validate_" + val_method.to_s.pluralize
if method(val_method)
validations << val_method
else
diff --git a/modules/reporting/lib/report/walker.rb b/modules/reporting/lib/report/walker.rb
index 201e6002a422..4ce0749d8c21 100644
--- a/modules/reporting/lib/report/walker.rb
+++ b/modules/reporting/lib/report/walker.rb
@@ -87,7 +87,7 @@ def headers(result = nil, &)
end
def reverse_headers
- fail 'call header first' unless @header_stack
+ fail "call header first" unless @header_stack
first = true
@header_stack.reverse_each do |list|
@@ -99,7 +99,7 @@ def reverse_headers
end
def headers_empty?
- fail 'call header first' unless @header_stack
+ fail "call header first" unless @header_stack
@header_stack.empty?
end
diff --git a/modules/reporting/lib/widget/base.rb b/modules/reporting/lib/widget/base.rb
index 98e213b5c0cb..3138db91fa2e 100644
--- a/modules/reporting/lib/widget/base.rb
+++ b/modules/reporting/lib/widget/base.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'digest/sha1'
+require "digest/sha1"
module ::Widget
class Base < Widget::ReportingWidget
@@ -56,9 +56,9 @@ def initialize(query)
# Write a string to the canvas. The string is marked as html_safe.
# This will write twice, if @cache_output is set.
def write(str)
- str ||= ''
- @output ||= ''.html_safe
- @output = @output + '' if @output.frozen? # Rails 2 freezes tag strings
+ str ||= ""
+ @output ||= "".html_safe
+ @output = @output + "" if @output.frozen? # Rails 2 freezes tag strings
@output.concat str.html_safe
@cache_output.concat(str.html_safe) if @cache_output
str.html_safe
@@ -116,7 +116,7 @@ def render_with_cache(_options = {}, &)
# Set the canvas. If the canvas object isn't a string (e.g. cannot be cached easily),
# a @cache_output String is created, that will mirror what is being written to the canvas.
def set_canvas(canvas)
- @cache_output = ''.html_safe
+ @cache_output = "".html_safe
@output = canvas
end
end
diff --git a/modules/reporting/lib/widget/controls/apply.rb b/modules/reporting/lib/widget/controls/apply.rb
index b77cde8015a0..2ede1fcab776 100644
--- a/modules/reporting/lib/widget/controls/apply.rb
+++ b/modules/reporting/lib/widget/controls/apply.rb
@@ -29,9 +29,9 @@
class Widget::Controls::Apply < Widget::Controls
def render
write link_to(I18n.t(:button_apply),
- '#',
- id: 'query-icon-apply-button',
- class: 'button -primary',
- 'data-target': url_for(action: 'index', set_filter: '1'))
+ "#",
+ id: "query-icon-apply-button",
+ class: "button -primary",
+ "data-target": url_for(action: "index", set_filter: "1"))
end
end
diff --git a/modules/reporting/lib/widget/controls/clear.rb b/modules/reporting/lib/widget/controls/clear.rb
index a08d6bcd59db..dfb4261cf087 100644
--- a/modules/reporting/lib/widget/controls/clear.rb
+++ b/modules/reporting/lib/widget/controls/clear.rb
@@ -29,8 +29,8 @@
class Widget::Controls::Clear < Widget::Controls
def render
write link_to(I18n.t(:button_clear),
- '#',
- id: 'query-link-clear',
- class: 'button icon-context icon-undo')
+ "#",
+ id: "query-link-clear",
+ class: "button icon-context icon-undo")
end
end
diff --git a/modules/reporting/lib/widget/controls/delete.rb b/modules/reporting/lib/widget/controls/delete.rb
index a0bcd75ac4a4..4959c927a63d 100644
--- a/modules/reporting/lib/widget/controls/delete.rb
+++ b/modules/reporting/lib/widget/controls/delete.rb
@@ -28,13 +28,13 @@
class Widget::Controls::Delete < Widget::Controls
def render
- return '' if @subject.new_record? or !@options[:can_delete]
+ return "" if @subject.new_record? or !@options[:can_delete]
button = link_to(I18n.t(:button_delete),
- '#',
- id: 'query-icon-delete',
- class: 'button icon-context icon-delete')
- popup = content_tag :div, id: 'delete_form', style: 'display:none', class: 'button_form' do
+ "#",
+ id: "query-icon-delete",
+ class: "button icon-context icon-delete")
+ popup = content_tag :div, id: "delete_form", style: "display:none", class: "button_form" do
question = content_tag :p, I18n.t(:label_really_delete_question)
url_opts = { id: @subject.id }
@@ -42,11 +42,11 @@ def render
opt1 = link_to I18n.t(:button_delete),
url_for(url_opts),
method: :delete,
- class: 'button -primary icon-context icon-delete'
+ class: "button -primary icon-context icon-delete"
opt2 = link_to I18n.t(:button_cancel),
- '#',
- id: 'query-icon-delete-cancel',
- class: 'button icon-context icon-cancel'
+ "#",
+ id: "query-icon-delete-cancel",
+ class: "button icon-context icon-cancel"
opt1 + opt2
question + opt1 + opt2
diff --git a/modules/reporting/lib/widget/controls/query_name.rb b/modules/reporting/lib/widget/controls/query_name.rb
index 3edf0031e61b..e969f6fa4d2f 100644
--- a/modules/reporting/lib/widget/controls/query_name.rb
+++ b/modules/reporting/lib/widget/controls/query_name.rb
@@ -30,19 +30,19 @@ class Widget::Controls::QueryName < Widget::Controls
dont_cache! # The name might change, but the query stays the same...
def render
- options = { id: 'query_saved_name', 'data-translations' => translations }
+ options = { id: "query_saved_name", "data-translations" => translations }
if @subject.new_record?
name = I18n.t(:label_new_report)
- icon = ''
+ icon = ""
else
name = @subject.name
- options['data-is_public'] = @subject.public?
- options['data-is_new'] = @subject.new_record?
+ options["data-is_public"] = @subject.public?
+ options["data-is_new"] = @subject.new_record?
end
write(content_tag(:span, h(name), options) + icon.to_s)
end
def translations
- { isPublic: I18n.t(:public, scope: 'attributes') }.to_json
+ { isPublic: I18n.t(:public, scope: "attributes") }.to_json
end
end
diff --git a/modules/reporting/lib/widget/controls/save.rb b/modules/reporting/lib/widget/controls/save.rb
index 01bf62c8cfaa..9a7464fe4439 100644
--- a/modules/reporting/lib/widget/controls/save.rb
+++ b/modules/reporting/lib/widget/controls/save.rb
@@ -28,12 +28,12 @@
class Widget::Controls::Save < Widget::Controls
def render
- return '' if @subject.new_record? or !@options[:can_save]
+ return "" if @subject.new_record? or !@options[:can_save]
write link_to(I18n.t(:button_save),
- '#',
- id: 'query-breadcrumb-save',
- class: 'button icon-context icon-save',
- 'data-target': url_for(action: 'update', id: @subject.id, set_filter: '1'))
+ "#",
+ id: "query-breadcrumb-save",
+ class: "button icon-context icon-save",
+ "data-target": url_for(action: "update", id: @subject.id, set_filter: "1"))
end
end
diff --git a/modules/reporting/lib/widget/controls/save_as.rb b/modules/reporting/lib/widget/controls/save_as.rb
index ceea543bcd1c..c23ac74658f7 100644
--- a/modules/reporting/lib/widget/controls/save_as.rb
+++ b/modules/reporting/lib/widget/controls/save_as.rb
@@ -30,12 +30,12 @@ class Widget::Controls::SaveAs < Widget::Controls
def render
if @subject.new_record?
link_name = I18n.t(:button_save)
- icon = 'icon-save'
+ icon = "icon-save"
else
link_name = I18n.t(:button_save_as)
- icon = 'icon-save'
+ icon = "icon-save"
end
- button = link_to(link_name, '#', id: 'query-icon-save-as', class: "button icon-context #{icon}")
+ button = link_to(link_name, "#", id: "query-icon-save-as", class: "button icon-context #{icon}")
write(button + render_popup)
end
@@ -45,15 +45,15 @@ def cache_key
def render_popup_form
name = content_tag :p,
- class: 'form--field -required -wide-label' do
+ class: "form--field -required -wide-label" do
label_tag(:query_name,
- class: 'form--label -transparent') do
+ class: "form--label -transparent") do
Query.human_attribute_name(:name).html_safe
end +
content_tag(:span,
- class: 'form--field-container') do
+ class: "form--field-container") do
content_tag(:span,
- class: 'form--text-field-container') do
+ class: "form--text-field-container") do
text_field_tag(:query_name,
@subject.name,
required: true)
@@ -61,18 +61,18 @@ def render_popup_form
end
end
if @options[:can_save_as_public]
- box = content_tag :p, class: 'form--field -wide-label' do
+ box = content_tag :p, class: "form--field -wide-label" do
label_tag(:query_is_public,
Query.human_attribute_name(:public),
- class: 'form--label -transparent') +
+ class: "form--label -transparent") +
content_tag(:span,
- class: 'form--field-container') do
+ class: "form--field-container") do
content_tag(:span,
- class: 'form--check-box-container') do
+ class: "form--check-box-container") do
check_box_tag(:query_is_public,
1,
false,
- class: 'form--check-box')
+ class: "form--check-box")
end
end
end
@@ -83,24 +83,24 @@ def render_popup_form
end
def render_popup_buttons
- save_url_params = { action: 'create', set_filter: '1' }
+ save_url_params = { action: "create", set_filter: "1" }
save_url_params[:project_id] = @subject.project.id if @subject.project
save = link_to(I18n.t(:button_save),
- '#',
- id: 'query-icon-save-button',
- class: 'button -primary icon-context icon-save',
- 'data-target': url_for(**save_url_params))
+ "#",
+ id: "query-icon-save-button",
+ class: "button -primary icon-context icon-save",
+ "data-target": url_for(**save_url_params))
cancel = link_to(I18n.t(:button_cancel),
- '#',
- id: 'query-icon-save-as-cancel',
- class: 'button icon-context icon-cancel')
+ "#",
+ id: "query-icon-save-as-cancel",
+ class: "button icon-context icon-cancel")
save + cancel
end
def render_popup
- content_tag :div, id: 'save_as_form', class: 'button_form', style: 'display:none' do
+ content_tag :div, id: "save_as_form", class: "button_form", style: "display:none" do
render_popup_form + render_popup_buttons
end
end
diff --git a/modules/reporting/lib/widget/cost_types.rb b/modules/reporting/lib/widget/cost_types.rb
index 5ed55afbdfad..aa47078d88ef 100644
--- a/modules/reporting/lib/widget/cost_types.rb
+++ b/modules/reporting/lib/widget/cost_types.rb
@@ -45,11 +45,11 @@ def contents
types = label_tag "unit_#{id}", h(label), class: "form--label"
types += content_tag :span, class: "form--field-container" do
content_tag :span, class: "form--radio-button-container" do
- radio_button_tag('unit', id, id == @selected_type_id, class: "form--radio-button")
+ radio_button_tag("unit", id, id == @selected_type_id, class: "form--radio-button")
end
end
end
- end.join('').html_safe
+ end.join("").html_safe
end
end
end
diff --git a/modules/reporting/lib/widget/filters.rb b/modules/reporting/lib/widget/filters.rb
index 36a1c842d497..f1a9aaf41456 100644
--- a/modules/reporting/lib/widget/filters.rb
+++ b/modules/reporting/lib/widget/filters.rb
@@ -28,26 +28,26 @@
class Widget::Filters < Widget::Base
def render
- spacer = content_tag :li, '', class: 'advanced-filters--spacer hide-when-print'
+ spacer = content_tag :li, "", class: "advanced-filters--spacer hide-when-print"
- add_filter = content_tag :li, id: 'add_filter_block', class: 'advanced-filters--add-filter hide-when-print' do
- add_filter_label = label_tag 'add_filter_select', I18n.t(:label_filter_add),
- class: 'advanced-filters--add-filter-label'
- add_filter_label += label_tag 'add_filter_select', I18n.t('js.filter.description.text_open_filter') + ' ' +
- I18n.t('js.filter.description.text_close_filter'),
- class: 'hidden-for-sighted'
+ add_filter = content_tag :li, id: "add_filter_block", class: "advanced-filters--add-filter hide-when-print" do
+ add_filter_label = label_tag "add_filter_select", I18n.t(:label_filter_add),
+ class: "advanced-filters--add-filter-label"
+ add_filter_label += label_tag "add_filter_select", I18n.t("js.filter.description.text_open_filter") + " " +
+ I18n.t("js.filter.description.text_close_filter"),
+ class: "hidden-for-sighted"
- add_filter_value = content_tag :div, class: 'advanced-filters--add-filter-value' do
- select_tag 'add_filter_select',
- options_for_select([['', '']] + selectables),
- class: 'advanced-filters--select',
+ add_filter_value = content_tag :div, class: "advanced-filters--add-filter-value" do
+ select_tag "add_filter_select",
+ options_for_select([["", ""]] + selectables),
+ class: "advanced-filters--select",
name: nil
end
(add_filter_label + add_filter_value).html_safe
end
- list = content_tag :ul, id: 'filter_table', class: 'advanced-filters--filters' do
+ list = content_tag :ul, id: "filter_table", class: "advanced-filters--filters" do
render_filters + spacer + add_filter
end
@@ -66,12 +66,12 @@ def render_filters
engine::Filter.all.select(&:selectable?).map do |filter|
opts = { id: "filter_#{filter.underscore_name}",
class: "#{filter.underscore_name} advanced-filters--filter",
- 'data-filter-name': filter.underscore_name }
+ "data-filter-name": filter.underscore_name }
active_instance = active_filters.detect { |f| f.instance_of?(filter) }
if active_instance
- opts[:'data-selected'] = true
+ opts[:"data-selected"] = true
else
- opts[:style] = 'display:none'
+ opts[:style] = "display:none"
end
content_tag :li, opts do
render_filter filter, active_instance
@@ -81,7 +81,7 @@ def render_filters
def render_filter(f_cls, f_inst)
f = f_inst || f_cls
- html = ''.html_safe
+ html = "".html_safe
render_widget Label, f, to: html
render_widget Operators, f, to: html
diff --git a/modules/reporting/lib/widget/filters/date.rb b/modules/reporting/lib/widget/filters/date.rb
index 95e671764ae9..2e11b3285d39 100644
--- a/modules/reporting/lib/widget/filters/date.rb
+++ b/modules/reporting/lib/widget/filters/date.rb
@@ -35,13 +35,13 @@ def render
name = "values[#{filter_class.underscore_name}][]"
id_prefix = "#{filter_class.underscore_name}_"
- write(content_tag(:span, class: 'advanced-filters--filter-value -binary') do
+ write(content_tag(:span, class: "advanced-filters--filter-value -binary") do
label1 = label_tag "#{id_prefix}arg_1_val",
- h(filter_class.label) + ' ' + I18n.t(:label_filter_value),
- class: 'hidden-for-sighted'
+ h(filter_class.label) + " " + I18n.t(:label_filter_value),
+ class: "hidden-for-sighted"
arg1 = content_tag :span, id: "#{id_prefix}arg_1" do
- text1 = angular_component_tag 'op-basic-single-date-picker',
+ text1 = angular_component_tag "op-basic-single-date-picker",
inputs: {
value: filter.values.first.to_s,
id: "#{id_prefix}arg_1_val",
@@ -51,11 +51,11 @@ def render
end
label2 = label_tag "#{id_prefix}arg_2_val",
- h(filter_class.label) + ' ' + I18n.t(:label_filter_value),
- class: 'hidden-for-sighted'
+ h(filter_class.label) + " " + I18n.t(:label_filter_value),
+ class: "hidden-for-sighted"
- arg2 = content_tag :span, id: "#{id_prefix}arg_2", class: 'advanced-filters--filter-value2' do
- text2 = angular_component_tag 'op-basic-single-date-picker',
+ arg2 = content_tag :span, id: "#{id_prefix}arg_2", class: "advanced-filters--filter-value2" do
+ text2 = angular_component_tag "op-basic-single-date-picker",
inputs: {
value: filter.values.second.to_s,
id: "#{id_prefix}arg_2_val",
diff --git a/modules/reporting/lib/widget/filters/heavy.rb b/modules/reporting/lib/widget/filters/heavy.rb
index 0cdf94aca22f..e9701052cfc8 100644
--- a/modules/reporting/lib/widget/filters/heavy.rb
+++ b/modules/reporting/lib/widget/filters/heavy.rb
@@ -37,20 +37,20 @@ def render
# this might be a bug - further research would be fine
values = filter.values.first.is_a?(Array) ? filter.values.first : filter.values
opts = Array(values).empty? ? [] : values.map { |i| filter_class.label_for_value(i.to_i) }
- div = content_tag :div, id: "#{filter_class.underscore_name}_arg_1", class: 'advanced-filters--filter-value hidden' do
- select_options = { 'data-remote-url': url_for(action: 'available_values'),
- 'data-initially-selected': JSON::dump(Array(filter.values).flatten),
+ div = content_tag :div, id: "#{filter_class.underscore_name}_arg_1", class: "advanced-filters--filter-value hidden" do
+ select_options = { "data-remote-url": url_for(action: "available_values"),
+ "data-initially-selected": JSON::dump(Array(filter.values).flatten),
name: "values[#{filter_class.underscore_name}][]",
- 'data-loading': '',
+ "data-loading": "",
id: "#{filter_class.underscore_name}_arg_1_val",
- class: 'advanced-filters--select filter-value',
- 'data-filter-name': filter_class.underscore_name }
+ class: "advanced-filters--select filter-value",
+ "data-filter-name": filter_class.underscore_name }
box = content_tag :select, select_options do
- render_widget Widget::Filters::Option, filter, to: '', content: opts
+ render_widget Widget::Filters::Option, filter, to: "", content: opts
end
box
end
- alternate_text = opts.map(&:first).join(', ').html_safe
+ alternate_text = opts.map(&:first).join(", ").html_safe
write(div + content_tag(:label) do
alternate_text
end)
diff --git a/modules/reporting/lib/widget/filters/label.rb b/modules/reporting/lib/widget/filters/label.rb
index 1a062e62a268..b34dd2c57e18 100644
--- a/modules/reporting/lib/widget/filters/label.rb
+++ b/modules/reporting/lib/widget/filters/label.rb
@@ -30,7 +30,7 @@ class Widget::Filters::Label < Widget::Filters::Base
def render
options = {
id: filter_class.underscore_name,
- class: 'advanced-filters--filter-name',
+ class: "advanced-filters--filter-name",
title: h(filter_class.label)
}
write(content_tag(:label, options) do
diff --git a/modules/reporting/lib/widget/filters/operators.rb b/modules/reporting/lib/widget/filters/operators.rb
index 91057075a24f..1c24fb6a21ed 100644
--- a/modules/reporting/lib/widget/filters/operators.rb
+++ b/modules/reporting/lib/widget/filters/operators.rb
@@ -28,26 +28,26 @@
class Widget::Filters::Operators < Widget::Filters::Base
def render
- write(content_tag(:div, class: 'advanced-filters--filter-operator') do
+ write(content_tag(:div, class: "advanced-filters--filter-operator") do
hide_select_box = filter_class.available_operators.count == 1 || filter_class.heavy?
- options = { class: 'advanced-filters--select filters-select filter_operator',
+ options = { class: "advanced-filters--select filters-select filter_operator",
id: "operators[#{filter_class.underscore_name}]",
name: "operators[#{filter_class.underscore_name}]",
- 'data-filter-name': filter_class.underscore_name }
- options.merge! style: 'display: none' if hide_select_box
+ "data-filter-name": filter_class.underscore_name }
+ options.merge! style: "display: none" if hide_select_box
select_box = content_tag :select, options do
filter_class.available_operators.map do |o|
- opts = { value: h(o.to_s), 'data-arity': o.arity }
- opts.reverse_merge! 'data-forced': o.forced if o.forced?
- opts[:selected] = 'selected' if filter.operator.to_s == o.to_s
+ opts = { value: h(o.to_s), "data-arity": o.arity }
+ opts.reverse_merge! "data-forced": o.forced if o.forced?
+ opts[:selected] = "selected" if filter.operator.to_s == o.to_s
content_tag(:option, opts) { h(I18n.t(o.label)) }
end.join.html_safe
end
label1 = content_tag :label,
hidden_for_sighted_label,
for: "operators[#{filter_class.underscore_name}]",
- class: 'hidden-for-sighted'
+ class: "hidden-for-sighted"
label = content_tag :label do
if filter_class.available_operators.any?
filter_class.available_operators.first.label
@@ -58,6 +58,6 @@ def render
end
def hidden_for_sighted_label
- h(filter_class.label) + ' ' + I18n.t(:label_operator) + ' ' + I18n.t('js.filter.description.text_open_filter')
+ h(filter_class.label) + " " + I18n.t(:label_operator) + " " + I18n.t("js.filter.description.text_open_filter")
end
end
diff --git a/modules/reporting/lib/widget/filters/option.rb b/modules/reporting/lib/widget/filters/option.rb
index 194dd4ecc74b..21c71ebd4d40 100644
--- a/modules/reporting/lib/widget/filters/option.rb
+++ b/modules/reporting/lib/widget/filters/option.rb
@@ -38,13 +38,13 @@ def render
level = options[:level] # nesting_level is optional for values
name = I18n.t(name) if name.is_a? Symbol
name = I18n.t(:label_none) if name.empty?
- name_prefix = (level && level > 0 ? ((' ' * 2 * level) + '> ') : '')
+ name_prefix = (level && level > 0 ? ((" " * 2 * level) + "> ") : "")
if options[:optgroup]
tag :optgroup, label: I18n.t(:label_sector)
else
opts = { value: id }
if (Array(filter.values).map(&:to_s).include? id.to_s) || (first && Array(filter.values).empty?)
- opts[:selected] = 'selected'
+ opts[:selected] = "selected"
end
first = false
content_tag(:option, opts) { name_prefix + name }
diff --git a/modules/reporting/lib/widget/filters/remove_button.rb b/modules/reporting/lib/widget/filters/remove_button.rb
index 5a431c9a2f7f..e32be053a0e8 100644
--- a/modules/reporting/lib/widget/filters/remove_button.rb
+++ b/modules/reporting/lib/widget/filters/remove_button.rb
@@ -29,12 +29,12 @@
class Widget::Filters::RemoveButton < Widget::Filters::Base
def render
hidden_field = tag :input, id: "rm_#{filter_class.underscore_name}",
- name: 'fields[]', type: 'hidden', value: ''
+ name: "fields[]", type: "hidden", value: ""
button = content_tag(:a, href: "#", class: "filter_rem") do
- icon_wrapper('icon-close advanced-filters--remove-filter-icon', I18n.t(:description_remove_filter))
+ icon_wrapper("icon-close advanced-filters--remove-filter-icon", I18n.t(:description_remove_filter))
end
write(content_tag(:div, hidden_field + button, id: "rm_box_#{filter_class.underscore_name}",
- class: 'advanced-filters--remove-filter'))
+ class: "advanced-filters--remove-filter"))
end
end
diff --git a/modules/reporting/lib/widget/filters/text_box.rb b/modules/reporting/lib/widget/filters/text_box.rb
index eed8cd5c564b..73d20e7f9cb3 100644
--- a/modules/reporting/lib/widget/filters/text_box.rb
+++ b/modules/reporting/lib/widget/filters/text_box.rb
@@ -31,14 +31,14 @@ def render
label = content_tag :label,
"#{h(filter_class.label)} #{I18n.t(:label_filter_value)}",
for: "#{filter_class.underscore_name}_arg_1_val",
- class: 'hidden-for-sighted'
+ class: "hidden-for-sighted"
- write(content_tag(:div, id: "#{filter_class.underscore_name}_arg_1", class: 'advanced-filters--filter-value') do
- label + text_field_tag("values[#{filter_class.underscore_name}]", '',
- size: '6',
- class: 'advanced-filters--text-field',
+ write(content_tag(:div, id: "#{filter_class.underscore_name}_arg_1", class: "advanced-filters--filter-value") do
+ label + text_field_tag("values[#{filter_class.underscore_name}]", "",
+ size: "6",
+ class: "advanced-filters--text-field",
id: "#{filter_class.underscore_name}_arg_1_val",
- 'data-filter-name': filter_class.underscore_name)
+ "data-filter-name": filter_class.underscore_name)
end)
end
end
diff --git a/modules/reporting/lib/widget/group_bys.rb b/modules/reporting/lib/widget/group_bys.rb
index d495ccc60fd0..ed3ddd51eaf6 100644
--- a/modules/reporting/lib/widget/group_bys.rb
+++ b/modules/reporting/lib/widget/group_bys.rb
@@ -32,7 +32,7 @@ def render_options(group_by_ary)
next unless group_by.selectable?
label_text = CGI::escapeHTML(h(group_by.label)).to_s
- option_tags = { value: group_by.underscore_name, 'data-label': label_text }
+ option_tags = { value: group_by.underscore_name, "data-label": label_text }
option_tags[:title] = label_text if group_by.label.length > 40
content_tag :option, option_tags do
h(truncate_single_line(group_by.label, length: 40))
@@ -46,29 +46,29 @@ def render_group(type, initially_selected)
end
content_tag :fieldset do
- legend = content_tag :legend, I18n.t("reporting.group_by.selected_#{type}"), class: 'hidden-for-sighted'
+ legend = content_tag :legend, I18n.t("reporting.group_by.selected_#{type}"), class: "hidden-for-sighted"
container = content_tag :div,
id: "group-by--#{type}",
- class: 'group-by--container grid-block',
- 'data-initially-selected': initially_selected.to_json.tr('"', "'") do
- out = content_tag :span, class: 'group-by--caption grid-content shrink' do
+ class: "group-by--container grid-block",
+ "data-initially-selected": initially_selected.to_json.tr('"', "'") do
+ out = content_tag :span, class: "group-by--caption grid-content shrink" do
content_tag :span do
I18n.t(:"label_#{type}")
end
end
- out += content_tag :span, '', id: "group-by--selected-#{type}", class: 'group-by--selected-elements grid-block'
+ out += content_tag :span, "", id: "group-by--selected-#{type}", class: "group-by--selected-elements grid-block"
out += content_tag :span,
- class: 'group-by--control grid-content shrink' do
+ class: "group-by--control grid-content shrink" do
label = label_tag "group-by--add-#{type}",
- I18n.t(:label_group_by_add) + ' ' +
- I18n.t('js.filter.description.text_open_filter'),
- class: 'hidden-for-sighted'
+ I18n.t(:label_group_by_add) + " " +
+ I18n.t("js.filter.description.text_open_filter"),
+ class: "hidden-for-sighted"
- label += content_tag :select, id: "group-by--add-#{type}", class: 'advanced-filters--select' do
- content = content_tag :option, I18n.t(:label_group_by_add), value: '', disabled: true, selected: true
+ label += content_tag :select, id: "group-by--add-#{type}", class: "advanced-filters--select" do
+ content = content_tag :option, I18n.t(:label_group_by_add), value: "", disabled: true, selected: true
content += engine::GroupBy.all_grouped.sort_by do |label, _group_by_ary|
I18n.t(label)
@@ -91,9 +91,9 @@ def render_group(type, initially_selected)
end
def render
- write(content_tag(:div, id: 'group-by--area', class: 'autoscroll') do
- out = render_group 'columns', @subject.group_bys(:column)
- out += render_group 'rows', @subject.group_bys(:row)
+ write(content_tag(:div, id: "group-by--area", class: "autoscroll") do
+ out = render_group "columns", @subject.group_bys(:column)
+ out += render_group "rows", @subject.group_bys(:row)
out.html_safe
end)
end
diff --git a/modules/reporting/lib/widget/settings.rb b/modules/reporting/lib/widget/settings.rb
index cc0dd44d65b7..3adbdf7a3826 100644
--- a/modules/reporting/lib/widget/settings.rb
+++ b/modules/reporting/lib/widget/settings.rb
@@ -31,14 +31,14 @@ class Widget::Settings < Widget::Base
def render_filter_settings
render_widget Widget::Settings::Fieldset, @subject,
- type: 'filters' do
+ type: "filters" do
render_widget Widget::Filters, @subject
end
end
def render_group_by_settings
render_widget Widget::Settings::Fieldset, @subject,
- type: 'group_by' do
+ type: "group_by" do
render_widget Widget::GroupBys, @subject
end
end
@@ -52,8 +52,8 @@ def render_cost_types_settings
end
def render_controls_settings
- content_tag :div, class: 'form--buttons -with-button-form hide-when-print' do
- widgets = ''.html_safe
+ content_tag :div, class: "form--buttons -with-button-form hide-when-print" do
+ widgets = "".html_safe
render_widget(Widget::Controls::Apply, @subject, to: widgets)
render_widget(Widget::Controls::Save, @subject, to: widgets,
can_save: allowed_in_report?(:save, @subject, current_user))
@@ -68,12 +68,12 @@ def render_controls_settings
end
def render
- write(form_tag('#', id: 'query_form', method: :post) do
- content_tag :div, id: 'query_form_content' do
+ write(form_tag("#", id: "query_form", method: :post) do
+ content_tag :div, id: "query_form_content" do
# will render a setting menu for every setting.
# To add new settings, write a new instance method render__setting
# and add to the @@settings_to_render list.
- content = ''.html_safe
+ content = "".html_safe
settings_to_render.each do |setting_name|
render_method_name = "render_#{setting_name}_settings"
content << send(render_method_name) if respond_to? render_method_name
diff --git a/modules/reporting/lib/widget/settings/fieldset.rb b/modules/reporting/lib/widget/settings/fieldset.rb
index e865930db6f7..86a98061b393 100644
--- a/modules/reporting/lib/widget/settings/fieldset.rb
+++ b/modules/reporting/lib/widget/settings/fieldset.rb
@@ -30,7 +30,7 @@ class Widget::Settings::Fieldset < Widget::Base
dont_cache!
def render_with_options(options, &)
- @type = options.delete(:type) || 'filter'
+ @type = options.delete(:type) || "filter"
@id = @type.to_s
@label = :"label_#{@type}"
super(options, &)
@@ -40,14 +40,14 @@ def render
hash = self.hash
write(content_tag(:fieldset,
id: @id,
- class: 'form--fieldset -collapsible') do
+ class: "form--fieldset -collapsible") do
html = content_tag(:legend,
show_at_id: hash.to_s,
icon: "#{@type}-legend-icon",
tooltip: "#{@type}-legend-tip",
- class: 'form--fieldset-legend',
+ class: "form--fieldset-legend",
id: hash.to_s) do
- content_tag(:a, href: '#') { I18n.t(@label) }
+ content_tag(:a, href: "#") { I18n.t(@label) }
end
html + yield
end)
diff --git a/modules/reporting/lib/widget/table.rb b/modules/reporting/lib/widget/table.rb
index b83c3b5ccc67..c66f2e7e80d6 100644
--- a/modules/reporting/lib/widget/table.rb
+++ b/modules/reporting/lib/widget/table.rb
@@ -33,7 +33,7 @@ class Widget::Table < Widget::Base
attr_accessor :debug, :fields, :mapping
def initialize(query)
- raise ArgumentError, 'Tables only work on CostQuery!' unless query.is_a? CostQuery
+ raise ArgumentError, "Tables only work on CostQuery!" unless query.is_a? CostQuery
super
end
@@ -47,11 +47,11 @@ def resolve_table
end
def render
- write('')
+ write("")
if @subject.result.count <= 0
- write(content_tag(:div, '', class: 'generic-table--no-results-container') do
- content_tag(:i, '', class: 'icon-info1') +
- content_tag(:span, I18n.t(:no_results_title_text), class: 'generic-table--no-results-title')
+ write(content_tag(:div, "", class: "generic-table--no-results-container") do
+ content_tag(:i, "", class: "icon-info1") +
+ content_tag(:span, I18n.t(:no_results_title_text), class: "generic-table--no-results-title")
end)
else
str = render_widget(resolve_table, @subject, @options.reverse_merge(to: @output))
diff --git a/modules/reporting/lib/widget/table/entry_table.rb b/modules/reporting/lib/widget/table/entry_table.rb
index a5bdb10e0db4..76cc3958adda 100644
--- a/modules/reporting/lib/widget/table/entry_table.rb
+++ b/modules/reporting/lib/widget/table/entry_table.rb
@@ -30,10 +30,10 @@ class ::Widget::Table::EntryTable < Widget::Table
FIELDS = %i[spent_on user_id activity_id work_package_id comments logged_by_id project_id].freeze
def render
- content = content_tag :div, class: 'generic-table--container -with-footer' do
- content_tag :div, class: 'generic-table--results-container' do
- table = content_tag :table, class: 'generic-table',
- id: 'sortable-table' do
+ content = content_tag :div, class: "generic-table--container -with-footer" do
+ content_tag :div, class: "generic-table--results-container" do
+ table = content_tag :table, class: "generic-table",
+ id: "sortable-table" do
concat colgroup
concat head
concat foot
@@ -48,10 +48,10 @@ def render
def colgroup
content_tag :colgroup do
FIELDS.each do
- concat content_tag(:col, 'opHighlightCol' => true) {}
+ concat content_tag(:col, "opHighlightCol" => true) {}
end
- concat content_tag(:col, 'opHighlightCol' => true) {}
- concat content_tag(:col, 'opHighlightCol' => true) {}
+ concat content_tag(:col, "opHighlightCol" => true) {}
+ concat content_tag(:col, "opHighlightCol" => true) {}
concat content_tag(:col) {}
end
end
@@ -61,23 +61,23 @@ def head
content_tag :tr do
FIELDS.map do |field|
concat content_tag(:th) {
- content_tag(:div, class: 'generic-table--sort-header-outer') do
- content_tag(:div, class: 'generic-table--sort-header') do
+ content_tag(:div, class: "generic-table--sort-header-outer") do
+ content_tag(:div, class: "generic-table--sort-header") do
content_tag(:span, label_for(field))
end
end
}
end
concat content_tag(:th) {
- content_tag(:div, class: 'generic-table--sort-header-outer') do
- content_tag(:div, class: 'generic-table--sort-header') do
+ content_tag(:div, class: "generic-table--sort-header-outer") do
+ content_tag(:div, class: "generic-table--sort-header") do
content_tag(:span, cost_type.try(:unit_plural) || I18n.t(:units))
end
end
}
concat content_tag(:th) {
- content_tag(:div, class: 'generic-table--sort-header-outer') do
- content_tag(:div, class: 'generic-table--sort-header') do
+ content_tag(:div, class: "generic-table--sort-header-outer") do
+ content_tag(:div, class: "generic-table--sort-header") do
content_tag(:span, CostEntry.human_attribute_name(:costs))
end
end
@@ -87,8 +87,8 @@ def head
next if hit
if entry_for(result).editable_by? User.current
- concat content_tag(:th, class: 'unsortable') {
- content_tag(:div, '', class: 'generic-table--empty-header')
+ concat content_tag(:th, class: "unsortable") {
+ content_tag(:div, "", class: "generic-table--empty-header")
}
hit = true
end
@@ -101,48 +101,48 @@ def foot
content_tag :tfoot do
content_tag :tr do
if show_result(@subject, 0) == show_result(@subject)
- concat content_tag(:td, '', colspan: FIELDS.size + 1)
+ concat content_tag(:td, "", colspan: FIELDS.size + 1)
concat content_tag(:td) {
concat content_tag(:div,
show_result(@subject),
- class: 'result generic-table--footer-outer')
+ class: "result generic-table--footer-outer")
}
else
- concat content_tag(:td, '', colspan: FIELDS.size)
+ concat content_tag(:td, "", colspan: FIELDS.size)
concat content_tag(:td) {
concat content_tag(:div,
show_result(@subject),
- class: 'inner generic-table--footer-outer')
+ class: "inner generic-table--footer-outer")
}
concat content_tag(:td) {
concat content_tag(:div,
show_result(@subject, 0),
- class: 'result generic-table--footer-outer')
+ class: "result generic-table--footer-outer")
}
end
- concat content_tag(:th, '', class: 'unsortable')
+ concat content_tag(:th, "", class: "unsortable")
end
end
end
def body
content_tag :tbody do
- rows = ''.html_safe
+ rows = "".html_safe
@subject.each_direct_result do |result|
rows << (content_tag(:tr) do
- ''.html_safe
+ "".html_safe
FIELDS.each do |field|
concat content_tag(:td, show_field(field, result.fields[field.to_s]).html_safe,
- 'raw-data': raw_field(field, result.fields[field.to_s]),
- class: 'left')
+ "raw-data": raw_field(field, result.fields[field.to_s]),
+ class: "left")
end
- concat content_tag :td, show_result(result, result.fields['cost_type_id'].to_i).html_safe,
- class: 'units right',
- 'raw-data': result.units
+ concat content_tag :td, show_result(result, result.fields["cost_type_id"].to_i).html_safe,
+ class: "units right",
+ "raw-data": result.units
concat content_tag :td,
show_result(result, 0).html_safe,
- class: 'currency right',
- 'raw-data': result.real_costs
+ class: "currency right",
+ "raw-data": result.real_costs
concat content_tag :td, icons(result)
end)
end
@@ -151,26 +151,26 @@ def body
end
def icons(result)
- icons = ''
- with_project(result.fields['project_id']) do
+ icons = ""
+ with_project(result.fields["project_id"]) do
if entry_for(result).editable_by? User.current
- if controller_for(result.fields['type']) == 'costlog'
- icons = link_to(icon_wrapper('icon-context icon-edit', I18n.t(:button_edit)),
- action_for(result, action: 'edit'),
- class: 'no-decoration-on-hover',
+ if controller_for(result.fields["type"]) == "costlog"
+ icons = link_to(icon_wrapper("icon-context icon-edit", I18n.t(:button_edit)),
+ action_for(result, action: "edit"),
+ class: "no-decoration-on-hover",
title: I18n.t(:button_edit))
- icons << link_to(icon_wrapper('icon-context icon-delete', I18n.t(:button_delete)),
- action_for(result, action: 'destroy')
+ icons << link_to(icon_wrapper("icon-context icon-delete", I18n.t(:button_delete)),
+ action_for(result, action: "destroy")
.reverse_merge(authenticity_token: form_authenticity_token),
data: { confirm: I18n.t(:text_are_you_sure) },
method: :delete,
- class: 'no-decoration-on-hover',
+ class: "no-decoration-on-hover",
title: I18n.t(:button_delete))
else
- icons = content_tag(:'time-entry--trigger-actions-entry',
- '',
- data: { entry: result['id'] })
+ icons = content_tag(:"time-entry--trigger-actions-entry",
+ "",
+ data: { entry: result["id"] })
end
end
end
diff --git a/modules/reporting/lib/widget/table/report_table.rb b/modules/reporting/lib/widget/table/report_table.rb
index e9d51479a188..a47a9e23798b 100644
--- a/modules/reporting/lib/widget/table/report_table.rb
+++ b/modules/reporting/lib/widget/table/report_table.rb
@@ -63,7 +63,7 @@ def configure_walker
@walker.for_empty_cell { "
".html_safe }
@walker.for_cell do |result|
- write(' '.html_safe) # XXX: This keeps the Apache from timing out on us. Keep-Alive byte!
+ write(" ".html_safe) # XXX: This keeps the Apache from timing out on us. Keep-Alive byte!
"
#{show_result result}#{debug_fields(result)}
".html_safe
end
end
@@ -75,11 +75,11 @@ def render
render_thead
render_tfoot
render_tbody
- write ''
+ write ""
end
def render_tbody
- write ''
+ write ""
first = true
odd = true
walker.body do |line|
@@ -91,7 +91,7 @@ def render_tbody
write "
#{line}
"
odd = !odd
end
- write ''
+ write ""
end
def mark_penultimate_column!(line)
@@ -103,48 +103,48 @@ def mark_penultimate_column!(line)
def render_thead
return if (walker.headers || true) and walker.headers_empty?
- write ''
+ write ""
walker.headers do |list, first, first_in_col, last_in_col|
- write '
' if first_in_col
+ write "
" if first_in_col
if first
write(content_tag(:th, rowspan: @subject.depth_of(:column), colspan: @subject.depth_of(:row)) do
- ''
+ ""
end)
end
list.each do |column|
opts = { colspan: column.final_number(:column) }
- opts.merge!(class: 'inner') if column.final?(:column)
+ opts.merge!(class: "inner") if column.final?(:column)
write(content_tag(:th, opts) do
show_row column
end)
end
if first
write(content_tag(:th, rowspan: @subject.depth_of(:column), colspan: @subject.depth_of(:row)) do
- ''
+ ""
end)
end
- write '
' if last_in_col
+ write "" if last_in_col
end
- write ''
+ write ""
end
def render_tfoot
return if walker.headers_empty?
- write ''
+ write ""
walker.reverse_headers do |list, first, first_in_col, last_in_col|
if first_in_col
- write '
'
+ write "
"
if first
- write(content_tag(:th, rowspan: @subject.depth_of(:column), colspan: @subject.depth_of(:row), class: 'top') do
- ' '
+ write(content_tag(:th, rowspan: @subject.depth_of(:column), colspan: @subject.depth_of(:row), class: "top") do
+ " "
end)
end
end
list.each do |column|
opts = { colspan: column.final_number(:column) }
- opts.merge!(class: 'inner') if first
+ opts.merge!(class: "inner") if first
write(content_tag(:th, opts) do
show_result(column) # {debug_fields(column)}
end)
@@ -154,33 +154,33 @@ def render_tfoot
write(content_tag(:th,
rowspan: @subject.depth_of(:column),
colspan: @subject.depth_of(:row),
- class: 'top result') do
+ class: "top result") do
show_result @subject
end)
end
- write '
'
+ write ""
end
end
- write ''
+ write ""
end
def debug_content
content_tag :pre do
- debug_pre_content = '[ Query ]' +
+ debug_pre_content = "[ Query ]" +
@subject.chain.each do |child|
"#{h child.class.inspect}, #{h child.type}"
end
- debug_pre_content += '[ RESULT ]'
+ debug_pre_content += "[ RESULT ]"
@subject.result.recursive_each_with_level do |level, result|
- debug_pre_content += '>>> ' * (level + 1)
+ debug_pre_content += ">>> " * (level + 1)
debug_pre_content += h(result.inspect)
- debug_pre_content += ' ' * (level + 1)
+ debug_pre_content += " " * (level + 1)
debug_pre_content += h(result.type.inspect)
- debug_pre_content += ' ' * (level + 1)
+ debug_pre_content += " " * (level + 1)
debug_pre_content += h(result.fields.inspect)
end
- debug_pre_content += '[ HEADER STACK ]'
+ debug_pre_content += "[ HEADER STACK ]"
debug_pre_content += walker.header_stack.each do |l|
">>> #{l.inspect}"
end
diff --git a/modules/reporting/openproject-reporting.gemspec b/modules/reporting/openproject-reporting.gemspec
index 1b066934b5f0..aaea75301059 100644
--- a/modules/reporting/openproject-reporting.gemspec
+++ b/modules/reporting/openproject-reporting.gemspec
@@ -1,6 +1,6 @@
Gem::Specification.new do |s|
s.name = "openproject-reporting"
- s.version = '1.0.0'
+ s.version = "1.0.0"
s.authors = "OpenProject GmbH"
s.email = "info@openproject.com"
s.summary = "OpenProject Reporting"
@@ -9,5 +9,5 @@ Gem::Specification.new do |s|
s.files = Dir["{app,config,db,lib,doc}/**/*", "README.md"]
s.add_dependency "costs"
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/reporting/spec/controllers/cost_reports_controller_spec.rb b/modules/reporting/spec/controllers/cost_reports_controller_spec.rb
index 8e772b2942cb..94e81b5c3b2b 100644
--- a/modules/reporting/spec/controllers/cost_reports_controller_spec.rb
+++ b/modules/reporting/spec/controllers/cost_reports_controller_spec.rb
@@ -43,64 +43,64 @@
is_member project, user, [:view_cost_entries]
end
- context 'with invalid units' do
- context 'with :view_cost_entries permission' do
+ context "with invalid units" do
+ context "with :view_cost_entries permission" do
before do
get :show, params: { id: 1, unit: -1 }
end
- it 'returns 404 Not found' do
+ it "returns 404 Not found" do
expect(response).to have_http_status(:not_found)
end
end
end
end
- describe 'DELETE destroy' do
+ describe "DELETE destroy" do
let(:user) { build(:admin) }
let(:cost_query) { create(:public_cost_query, user:, project:) }
- context 'with valid params' do
+ context "with valid params" do
before do
delete :destroy, params: { id: cost_query.id, project_id: project.identifier }
end
- it 'destroyed' do
+ it "destroyed" do
expect(CostQuery.count).to be_zero
end
- it 'redirected' do
+ it "redirected" do
expect(response).to have_http_status(:redirect)
end
end
- context 'with invalid params' do
+ context "with invalid params" do
before do
create(:public_cost_query, user:, project:)
delete :destroy, params: { id: -1, project_id: -1 }
end
- it 'not destroyed' do
+ it "not destroyed" do
expect(CostQuery.count).not_to be_zero
end
- it 'returns 404 Not found' do
+ it "returns 404 Not found" do
expect(response).to have_http_status(:not_found)
end
end
- context 'with non-admin user' do
+ context "with non-admin user" do
let(:user) { build(:user) }
before do
delete :destroy, params: { id: cost_query.id, project_id: project.identifier }
end
- it 'not destroyed' do
+ it "not destroyed" do
expect(CostQuery.count).not_to be_zero
end
- it 'returns 403 Forbidden' do
+ it "returns 403 Forbidden" do
expect(response).to have_http_status(:forbidden)
end
end
diff --git a/modules/reporting/spec/controllers/custom_fields_controller_spec.rb b/modules/reporting/spec/controllers/custom_fields_controller_spec.rb
index e36f3b9166bc..a7710dd26c43 100644
--- a/modules/reporting/spec/controllers/custom_fields_controller_spec.rb
+++ b/modules/reporting/spec/controllers/custom_fields_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe CustomFieldsController do
let!(:custom_field) { create(:work_package_custom_field) }
@@ -47,10 +47,10 @@
CostQuery::GroupBy::CustomFieldEntries.all
end
- describe '#destroy' do
- shared_context 'remove custom field' do
+ describe "#destroy" do
+ shared_context "remove custom field" do
before do
- cost_query.filter(custom_field_permanent_name, { operator: '=', values: [] })
+ cost_query.filter(custom_field_permanent_name, { operator: "=", values: [] })
cost_query.group_by(custom_field_permanent_name)
cost_query.save!
@@ -58,67 +58,67 @@
end
end
- shared_examples_for 'custom field is removed from cost query' do
- include_context 'remove custom field'
+ shared_examples_for "custom field is removed from cost query" do
+ include_context "remove custom field"
- shared_examples_for 'custom field removed' do
+ shared_examples_for "custom field removed" do
it { expect(subject).not_to include(name) }
end
- shared_examples_for 'custom field exists' do
+ shared_examples_for "custom field exists" do
it { expect(subject).to include(name) }
end
- describe 'custom field is removed from cost query filter' do
+ describe "custom field is removed from cost query filter" do
subject { CostQuery.find(cost_query.id).filters.collect(&:class).collect(&:name) }
- it_behaves_like 'custom field removed' do
+ it_behaves_like "custom field removed" do
let(:name) { "CostQuery::Filter::#{custom_field_name}" }
end
end
- describe 'custom field is removed from cost query group bys' do
+ describe "custom field is removed from cost query group bys" do
subject { CostQuery.find(cost_query.id).group_bys.collect(&:class).collect(&:name) }
- it_behaves_like 'custom field removed' do
+ it_behaves_like "custom field removed" do
let(:name) { "CostQuery::GroupBy::#{custom_field_name}" }
end
end
- describe 'permanent custom field still exists in cost query filter' do
+ describe "permanent custom field still exists in cost query filter" do
subject { cost_query.reload.filters.collect(&:class).collect(&:name) }
- it_behaves_like 'custom field exists' do
+ it_behaves_like "custom field exists" do
let(:name) { "CostQuery::Filter::#{custom_field_permanent_name}" }
end
end
- describe 'permanent custom field still exists in cost query group by' do
+ describe "permanent custom field still exists in cost query group by" do
subject { cost_query.reload.group_bys.collect(&:class).collect(&:name) }
- it_behaves_like 'custom field exists' do
+ it_behaves_like "custom field exists" do
let(:name) { "CostQuery::GroupBy::#{custom_field_permanent_name}" }
end
end
end
- context 'with custom field filter set' do
+ context "with custom field filter set" do
before do
- cost_query.filter(custom_field_name, { operator: '=', values: [] })
+ cost_query.filter(custom_field_name, { operator: "=", values: [] })
end
- it_behaves_like 'custom field is removed from cost query'
+ it_behaves_like "custom field is removed from cost query"
end
- context 'with custom field group by set' do
+ context "with custom field group by set" do
before do
cost_query.group_by(custom_field_name)
end
- it_behaves_like 'custom field is removed from cost query'
+ it_behaves_like "custom field is removed from cost query"
end
- context 'session' do
+ context "session" do
let(:engine_name) { CostQuery.name.underscore.to_sym }
let(:key) { :"custom_field#{custom_field.id}" }
let(:query) do
@@ -132,8 +132,8 @@
before { session[engine_name] = query }
- describe 'does not contain custom field reference' do
- include_context 'remove custom field'
+ describe "does not contain custom field reference" do
+ include_context "remove custom field"
it { expect(session[engine_name][:filters][:operators][key]).to be_nil }
diff --git a/modules/reporting/spec/features/calculations_spec.rb b/modules/reporting/spec/features/calculations_spec.rb
index 096b2905a07f..dd4d1f94a6a1 100644
--- a/modules/reporting/spec/features/calculations_spec.rb
+++ b/modules/reporting/spec/features/calculations_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Cost Report', 'calculations', :js, :with_cuprite do
+RSpec.describe "Cost Report", "calculations", :js, :with_cuprite do
let(:project) { create(:project) }
let(:user) { create(:admin) }
let(:work_package) { create(:work_package, project:) }
@@ -26,13 +26,13 @@ def create_time_entries_on(*timestamps_of_recordings)
create_hourly_rates
create_time_entries_on(6.months.ago, 18.months.ago, 30.months.ago)
login_as user
- visit '/cost_reports?set_filter=1'
+ visit "/cost_reports?set_filter=1"
end
- it 'shows the correct calculations' do
- expect(page).to have_text '10.00' # 1 EUR x 10
- expect(page).to have_text '50.00' # 5 EUR x 10
- expect(page).to have_text '100.00' # 10 EUR x 10
- expect(page).to have_text '160.00' # Total
+ it "shows the correct calculations" do
+ expect(page).to have_text "10.00" # 1 EUR x 10
+ expect(page).to have_text "50.00" # 5 EUR x 10
+ expect(page).to have_text "100.00" # 10 EUR x 10
+ expect(page).to have_text "160.00" # Total
end
end
diff --git a/modules/reporting/spec/features/custom_fields_spec.rb b/modules/reporting/spec/features/custom_fields_spec.rb
index 453140787226..f3578cf0fdb2 100644
--- a/modules/reporting/spec/features/custom_fields_spec.rb
+++ b/modules/reporting/spec/features/custom_fields_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Custom fields reporting', :js do
+RSpec.describe "Custom fields reporting", :js do
let(:type) { create(:type) }
let(:project) { create(:project, types: [type]) }
@@ -63,17 +63,17 @@ def custom_value_for(cf, str)
current_user { user }
- context 'with multi value cf' do
+ context "with multi value cf" do
let!(:custom_field) do
create(:list_wp_custom_field,
name: "List CF",
multi_value: true,
types: [type],
projects: [project],
- possible_values: ['First option', 'Second option'])
+ possible_values: ["First option", "Second option"])
end
- let(:initial_custom_values) { { custom_field.id => custom_value_for(custom_field, 'First option') } }
+ let(:initial_custom_values) { { custom_field.id => custom_value_for(custom_field, "First option") } }
let(:cf_id) { "custom_field#{custom_field.id}" }
# Have a second work package in the test that will have no values
@@ -85,70 +85,70 @@ def custom_value_for(cf, str)
end
before do
- visit '/cost_reports'
+ visit "/cost_reports"
sleep(0.1)
end
- it 'filters by the multi CF' do
- expect(page).to have_css('#add_filter_select option', text: 'List CF')
- select 'List CF', from: 'add_filter_select'
+ it "filters by the multi CF" do
+ expect(page).to have_css("#add_filter_select option", text: "List CF")
+ select "List CF", from: "add_filter_select"
# Adds filter to page, filtering out the time entries on the work package
expect(page).to have_css("label##{cf_id}")
custom_field_selector = "##{cf_id}_arg_1_val"
select = find(custom_field_selector)
- expect(select).to have_css('option', text: 'First option')
- expect(select).to have_css('option', text: 'Second option')
- select.find('option', text: 'Second option').select_option
+ expect(select).to have_css("option", text: "First option")
+ expect(select).to have_css("option", text: "Second option")
+ select.find("option", text: "Second option").select_option
- click_link 'Apply'
+ click_link "Apply"
# Expect empty result table
- within('#result-table') do
- expect(page).to have_no_css('.top.result', text: '12.50 hours')
+ within("#result-table") do
+ expect(page).to have_no_css(".top.result", text: "12.50 hours")
end
- expect(page).to have_css('.generic-table--no-results-title')
+ expect(page).to have_css(".generic-table--no-results-title")
# Update filter to value the work package has
select = find(custom_field_selector)
- select.find('option', text: 'First option').select_option
- find_by_id('query-icon-apply-button').click
+ select.find("option", text: "First option").select_option
+ find_by_id("query-icon-apply-button").click
# Expect row of work package
- within('#result-table') do
- expect(page).to have_css('.top.result', text: '12.50 hours')
+ within("#result-table") do
+ expect(page).to have_css(".top.result", text: "12.50 hours")
end
end
- it 'groups by the multi CF (Regression #26050)' do
- expect(page).to have_css('#group-by--add-columns')
- expect(page).to have_css('#group-by--add-rows')
+ it "groups by the multi CF (Regression #26050)" do
+ expect(page).to have_css("#group-by--add-columns")
+ expect(page).to have_css("#group-by--add-rows")
- select 'List CF', from: 'group-by--add-columns'
- select 'Work package', from: 'group-by--add-rows'
+ select "List CF", from: "group-by--add-columns"
+ select "Work package", from: "group-by--add-rows"
- click_link 'Apply'
+ click_link "Apply"
# Expect row of work package
- within('#result-table') do
- expect(page).to have_css('a.work_package', text: "#{work_package.type} ##{work_package.id}")
+ within("#result-table") do
+ expect(page).to have_css("a.work_package", text: "#{work_package.type} ##{work_package.id}")
# There used to be additional and unwanted text after the option name being rendered.
- expect(page).to have_css('th.inner', text: /^First option$/)
- expect(page).to have_no_css('th.inner', text: 'Second option')
+ expect(page).to have_css("th.inner", text: /^First option$/)
+ expect(page).to have_no_css("th.inner", text: "Second option")
# Only first option should have content for the work package
- expect(page).to have_css('table.report tbody tr', count: 1)
- row_elements = page.all('table.report tr.odd th')
+ expect(page).to have_css("table.report tbody tr", count: 1)
+ row_elements = page.all("table.report tr.odd th")
expect(row_elements[0].text).to eq(project.name)
expect(row_elements[1].text).to eq(work_package.to_s)
- row_elements = page.all('table.report tr.odd td')
- expect(row_elements[0].text).to eq('12.50 hours')
+ row_elements = page.all("table.report tr.odd td")
+ expect(row_elements[0].text).to eq("12.50 hours")
end
end
- context 'with additional WP with invalid value' do
+ context "with additional WP with invalid value" do
let!(:custom_field_2) do
create(:list_wp_custom_field,
name: "Invalid List CF",
@@ -161,7 +161,7 @@ def custom_value_for(cf, str)
let!(:work_package2) do
create(:work_package,
project:,
- custom_values: { custom_field_2.id => custom_value_for(custom_field_2, 'A') })
+ custom_values: { custom_field_2.id => custom_value_for(custom_field_2, "A") })
end
let!(:time_entry1) do
@@ -173,73 +173,73 @@ def custom_value_for(cf, str)
end
before do
- CustomValue.find_by(customized_id: work_package2.id).update_columns(value: 'invalid')
+ CustomValue.find_by(customized_id: work_package2.id).update_columns(value: "invalid")
work_package2.reload
- visit '/cost_reports'
+ visit "/cost_reports"
sleep(0.1)
end
- it 'groups by the raw values when an invalid value exists' do
- expect(work_package2.send(custom_field_2.attribute_getter)).to eq(['invalid not found'])
+ it "groups by the raw values when an invalid value exists" do
+ expect(work_package2.send(custom_field_2.attribute_getter)).to eq(["invalid not found"])
- expect(page).to have_css('#group-by--add-columns')
- expect(page).to have_css('#group-by--add-rows')
+ expect(page).to have_css("#group-by--add-columns")
+ expect(page).to have_css("#group-by--add-rows")
- select 'Invalid List CF', from: 'group-by--add-columns'
- select 'Work package', from: 'group-by--add-rows'
+ select "Invalid List CF", from: "group-by--add-columns"
+ select "Work package", from: "group-by--add-rows"
sleep(0.1)
- click_link 'Apply'
+ click_link "Apply"
# Expect row of work package
- within('#result-table') do
- expect(page).to have_css('a.work_package', text: "#{work_package.type} ##{work_package.id}")
- expect(page).to have_css('th.inner', text: '1')
- expect(page).to have_no_css('th.inner', text: 'invalid!')
+ within("#result-table") do
+ expect(page).to have_css("a.work_package", text: "#{work_package.type} ##{work_package.id}")
+ expect(page).to have_css("th.inner", text: "1")
+ expect(page).to have_no_css("th.inner", text: "invalid!")
end
end
end
end
- context 'with text CF' do
+ context "with text CF" do
let(:custom_field) do
create(:text_wp_custom_field,
- name: 'Text CF',
+ name: "Text CF",
types: [type],
projects: [project])
end
- let(:initial_custom_values) { { custom_field.id => 'foo' } }
+ let(:initial_custom_values) { { custom_field.id => "foo" } }
before do
- visit '/cost_reports'
+ visit "/cost_reports"
sleep(0.1)
end
- it 'groups by a text CF' do
- expect(page).to have_css('#group-by--add-columns')
- expect(page).to have_css('#group-by--add-rows')
+ it "groups by a text CF" do
+ expect(page).to have_css("#group-by--add-columns")
+ expect(page).to have_css("#group-by--add-rows")
- select 'Text CF', from: 'group-by--add-columns'
- select 'Work package', from: 'group-by--add-rows'
+ select "Text CF", from: "group-by--add-columns"
+ select "Work package", from: "group-by--add-rows"
- click_link 'Apply'
+ click_link "Apply"
# Expect row of work package
- within('#result-table') do
- expect(page).to have_css('a.work_package', text: "#{work_package.type} ##{work_package.id}")
- expect(page).to have_css('th.inner', text: 'foo')
- expect(page).to have_no_css('th.inner', text: 'None')
+ within("#result-table") do
+ expect(page).to have_css("a.work_package", text: "#{work_package.type} ##{work_package.id}")
+ expect(page).to have_css("th.inner", text: "foo")
+ expect(page).to have_no_css("th.inner", text: "None")
# Only first option should have content for the work package
- expect(page).to have_css('table.report tbody tr', count: 1)
- row_elements = page.all('table.report tr.odd th')
+ expect(page).to have_css("table.report tbody tr", count: 1)
+ row_elements = page.all("table.report tr.odd th")
expect(row_elements[0].text).to eq(project.name)
expect(row_elements[1].text).to eq(work_package.to_s)
- row_elements = page.all('table.report tr.odd td')
- expect(row_elements[0].text).to eq('12.50 hours')
+ row_elements = page.all("table.report tr.odd td")
+ expect(row_elements[0].text).to eq("12.50 hours")
end
end
end
diff --git a/modules/reporting/spec/features/export_cost_report_spec.rb b/modules/reporting/spec/features/export_cost_report_spec.rb
index aac374de3117..8f3fb358d649 100644
--- a/modules/reporting/spec/features/export_cost_report_spec.rb
+++ b/modules/reporting/spec/features/export_cost_report_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require_relative '../spec_helper'
-require_relative 'support/pages/cost_report_page'
+require_relative "../spec_helper"
+require_relative "support/pages/cost_report_page"
RSpec.describe "Cost reports XLS export", :js do
shared_let(:project) { create(:project) }
shared_let(:user) { create(:admin) }
- shared_let(:cost_type) { create(:cost_type, name: 'Post-war', unit: 'cap', unit_plural: 'caps') }
- shared_let(:work_package) { create(:work_package, project:, subject: 'Some task') }
+ shared_let(:cost_type) { create(:cost_type, name: "Post-war", unit: "cap", unit_plural: "caps") }
+ shared_let(:work_package) { create(:work_package, project:, subject: "Some task") }
shared_let(:cost_entry) { create(:cost_entry, user:, work_package:, project:, cost_type:) }
let(:report_page) { Pages::CostReportPage.new project }
let(:sheet) { @download_list.refresh_from(page).latest_downloaded_content } # rubocop:disable RSpec/InstanceVariable
@@ -52,11 +52,11 @@
DownloadList.clear
end
- it 'can download and open the XLS' do
+ it "can download and open the XLS" do
report_page.visit!
- click_on 'Export XLS'
+ click_on "Export XLS"
- expect(page).to have_content I18n.t('js.job_status.generic_messages.in_queue'),
+ expect(page).to have_content I18n.t("js.job_status.generic_messages.in_queue"),
wait: 10
perform_enqueued_jobs
@@ -68,9 +68,9 @@
expect(date).to eq(Time.zone.today.iso8601)
expect(user_ref).to eq(user.name)
- expect(wp_ref).to include 'Some task'
+ expect(wp_ref).to include "Some task"
expect(project_ref).to eq project.name
expect(costs).to eq 1.0
- expect(type).to eq 'Post-war'
+ expect(type).to eq "Post-war"
end
end
diff --git a/modules/reporting/spec/features/filter_spec.rb b/modules/reporting/spec/features/filter_spec.rb
index 708398e9176f..f3466494374d 100644
--- a/modules/reporting/spec/features/filter_spec.rb
+++ b/modules/reporting/spec/features/filter_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Cost report calculations', :js, :with_cuprite do
+RSpec.describe "Cost report calculations", :js, :with_cuprite do
let(:project) { create(:project) }
let(:user) { create(:admin) }
@@ -10,8 +10,8 @@
end
def clear_project_filter
- within '#filter_project_id' do
- find('.filter_rem').click
+ within "#filter_project_id" do
+ find(".filter_rem").click
end
end
@@ -20,7 +20,7 @@ def reload_page
wait_for_reload
end
- it 'provides filtering' do
+ it "provides filtering" do
# Then filter "spent_on" should be visible
# And filter "user_id" should be visible
expect(page).to have_css("#filter_project_id")
@@ -32,11 +32,11 @@ def reload_page
# And I click on the filter's "Clear" button
clear_project_filter
# Then filter "project_id" should not be visible
- expect(page).to have_no_css('#filter_project_id')
+ expect(page).to have_no_css("#filter_project_id")
# Remove filters:
# And I click on "Clear"
- click_on 'Clear'
+ click_on "Clear"
# Then filter "spent_on" should not be visible
# And filter "user_id" should not be visible
expect(page).to have_no_css("#filter_spent_on")
@@ -49,6 +49,6 @@ def reload_page
expect(page).to have_css("#filter_spent_on")
expect(page).to have_css("#filter_user_id")
- expect(page).to have_css("#user_id_arg_1_val", text: 'me')
+ expect(page).to have_css("#user_id_arg_1_val", text: "me")
end
end
diff --git a/modules/reporting/spec/features/group_by_spec.rb b/modules/reporting/spec/features/group_by_spec.rb
index 129ff4e7cbcf..5d41ed4b7364 100644
--- a/modules/reporting/spec/features/group_by_spec.rb
+++ b/modules/reporting/spec/features/group_by_spec.rb
@@ -1,7 +1,7 @@
-require 'spec_helper'
-require_relative 'support/pages/cost_report_page'
+require "spec_helper"
+require_relative "support/pages/cost_report_page"
-RSpec.describe 'Cost report calculations', 'grouping', :js, :with_cuprite do
+RSpec.describe "Cost report calculations", "grouping", :js, :with_cuprite do
let(:project) { create(:project) }
let(:user) { create(:admin) }
let(:work_package) { create(:work_package, project:) }
@@ -23,93 +23,93 @@
visit cost_reports_path(project)
end
- it 'provides grouping' do
+ it "provides grouping" do
# Then I should see "Week (Spent)" in columns
# And I should see "Work package" in rows
- report_page.expect_column_element('Week (Spent)')
- report_page.expect_row_element('Work package')
+ report_page.expect_column_element("Week (Spent)")
+ report_page.expect_row_element("Work package")
# When I click on "Clear"
report_page.clear
# Then I should not see "Week (Spent)" in columns
# And I should not see "Work package" in rows
- report_page.expect_column_element('Week (Spent)', present: false)
- report_page.expect_row_element('Work package', present: false)
+ report_page.expect_column_element("Week (Spent)", present: false)
+ report_page.expect_row_element("Work package", present: false)
# And I group rows by "User"
- report_page.add_to_rows 'User'
+ report_page.add_to_rows "User"
# And I group rows by "Cost type"
- report_page.add_to_rows 'Cost type'
+ report_page.add_to_rows "Cost type"
# When I click on "Clear"
report_page.clear
# Then I should not see "Week (Spent)" in columns
# And I should not see "Work package" in rows
- report_page.expect_column_element('Week (Spent)', present: false)
- report_page.expect_row_element('Work package', present: false)
+ report_page.expect_column_element("Week (Spent)", present: false)
+ report_page.expect_row_element("Work package", present: false)
# And I should not see "User" in rows
# And I should not see "Cost type" in rows
- report_page.expect_row_element('User', present: false)
- report_page.expect_row_element('Cost type', present: false)
+ report_page.expect_row_element("User", present: false)
+ report_page.expect_row_element("Cost type", present: false)
# When I click on "Clear"
report_page.clear
# And I group columns by "Work package"
- report_page.add_to_columns 'Work package'
+ report_page.add_to_columns "Work package"
# Then I should see "Work package" in columns
- report_page.expect_column_element('Work package')
+ report_page.expect_column_element("Work package")
# When I group rows by "Project"
- report_page.add_to_columns 'Project'
+ report_page.add_to_columns "Project"
# Then I should see "Project" in rows
- report_page.expect_column_element('Project')
+ report_page.expect_column_element("Project")
# When I click on "Clear"
report_page.clear
# And I group columns by "Work package"
- report_page.add_to_columns 'Work package'
+ report_page.add_to_columns "Work package"
# And I group rows by "Project"
- report_page.add_to_rows 'Project'
+ report_page.add_to_rows "Project"
# Then I should see "Work package" in columns
- report_page.expect_column_element('Work package')
+ report_page.expect_column_element("Work package")
# And I should see "Project" in rows
- report_page.expect_row_element('Project')
+ report_page.expect_row_element("Project")
# When I remove "Project" from rows
- report_page.remove_row_element('Project')
+ report_page.remove_row_element("Project")
# And I remove "Work package" from columns
- report_page.remove_column_element('Work package')
+ report_page.remove_column_element("Work package")
# Then I should not see "Work package" in columns
- report_page.expect_column_element('Work package', present: false)
+ report_page.expect_column_element("Work package", present: false)
# And I should not see "Project" in rows
- report_page.expect_row_element('Project', present: false)
+ report_page.expect_row_element("Project", present: false)
# When I click on "Clear"
report_page.clear
# And I group columns by "Project"
- report_page.add_to_columns 'Project'
+ report_page.add_to_columns "Project"
# And I group columns by "Work package"
- report_page.add_to_columns 'Work package'
+ report_page.add_to_columns "Work package"
# And I group rows by "User"
- report_page.add_to_rows 'User'
+ report_page.add_to_rows "User"
# And I group rows by "Cost type"
- report_page.add_to_rows 'Cost type'
+ report_page.add_to_rows "Cost type"
# And I send the query
report_page.apply
# Then I should see "Project" in columns
- report_page.expect_column_element('Work package')
+ report_page.expect_column_element("Work package")
# And I should see "Work package" in columns
- report_page.expect_column_element('Project')
+ report_page.expect_column_element("Project")
# And I should see "User" in rows
- report_page.expect_row_element('User')
+ report_page.expect_row_element("User")
# And I should see "Cost type" in rows
- report_page.expect_row_element('Cost type')
+ report_page.expect_row_element("Cost type")
end
end
diff --git a/modules/reporting/spec/features/main_menu_item_spec.rb b/modules/reporting/spec/features/main_menu_item_spec.rb
index 1a90c2f992d0..96e98e89b8d3 100644
--- a/modules/reporting/spec/features/main_menu_item_spec.rb
+++ b/modules/reporting/spec/features/main_menu_item_spec.rb
@@ -29,9 +29,9 @@
# ++
#
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Cost and Reports Main Menu Item', :js, :with_cuprite do
+RSpec.describe "Cost and Reports Main Menu Item", :js, :with_cuprite do
shared_let(:admin) { create(:admin) }
shared_let(:project) { create(:project) }
shared_let(:user_with_permissions) { create(:user, member_with_permissions: { project => %i[view_time_entries] }) }
@@ -42,37 +42,37 @@
visit root_path
end
- shared_examples 'visiting the global cost reports page' do
- it 'allows visiting the global cost reports page' do
- within '#main-menu' do
+ shared_examples "visiting the global cost reports page" do
+ it "allows visiting the global cost reports page" do
+ within "#main-menu" do
click_link I18n.t(:cost_reports_title)
end
- expect(page).to have_current_path(url_for(controller: '/cost_reports',
- action: 'index',
+ expect(page).to have_current_path(url_for(controller: "/cost_reports",
+ action: "index",
project_id: nil,
only_path: true))
end
end
- describe 'Main Menu' do
- context 'as an admin' do
+ describe "Main Menu" do
+ context "as an admin" do
let(:current_user) { admin }
- include_examples 'visiting the global cost reports page'
+ include_examples "visiting the global cost reports page"
end
- context 'as a user with permissions' do
+ context "as a user with permissions" do
let(:current_user) { user_with_permissions }
- include_examples 'visiting the global cost reports page'
+ include_examples "visiting the global cost reports page"
end
- context 'as a user without adequate permissions' do
+ context "as a user without adequate permissions" do
let(:current_user) { user_without_permissions }
- it 'is not rendered' do
- within '#main-menu' do
+ it "is not rendered" do
+ within "#main-menu" do
expect(page).to have_no_link(I18n.t(:cost_reports_title))
end
end
diff --git a/modules/reporting/spec/features/me_value_spec.rb b/modules/reporting/spec/features/me_value_spec.rb
index 7c969b0c2253..0fa670edfd1c 100644
--- a/modules/reporting/spec/features/me_value_spec.rb
+++ b/modules/reporting/spec/features/me_value_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Cost report showing my own times', :js do
+RSpec.describe "Cost report showing my own times", :js do
let(:project) { create(:project) }
let(:user) { create(:admin) }
let(:user2) { create(:admin) }
@@ -31,17 +31,17 @@
visit cost_reports_path(project)
end
- shared_examples 'me filter value' do |filter_name, filter_selector|
+ shared_examples "me filter value" do |filter_name, filter_selector|
it 'keeps the special "me" value for the current user' do
- select 'me', from: filter_selector
- click_on 'Save'
- fill_in 'query_name', with: 'Query ME value'
- check 'query_is_public'
- find_by_id('query-icon-save-button').click
+ select "me", from: filter_selector
+ click_on "Save"
+ fill_in "query_name", with: "Query ME value"
+ check "query_is_public"
+ find_by_id("query-icon-save-button").click
# wait until the save is complete
- expect(page).to have_css('h2', text: 'Query ME value')
+ expect(page).to have_css("h2", text: "Query ME value")
- expect(page).to have_css('.report', text: '10.00')
+ expect(page).to have_css(".report", text: "10.00")
report = nil
retry_block do
@@ -57,14 +57,14 @@
# Create and save cost report
visit cost_report_path(report.id, project_id: project.identifier)
- expect(page).to have_no_css('.report', text: '10.00')
- expect(page).to have_css('.report', text: '15.00')
+ expect(page).to have_no_css(".report", text: "10.00")
+ expect(page).to have_css(".report", text: "15.00")
- expect(page).to have_field(filter_selector, text: 'me')
+ expect(page).to have_field(filter_selector, text: "me")
end
end
- describe 'assignee filter' do
+ describe "assignee filter" do
let(:work_package) { create(:work_package, project:, assigned_to: user) }
let(:work_package2) { create(:work_package, project:, assigned_to: user2) }
@@ -85,14 +85,14 @@
before do
# Remove default user filter, add assignee filter
- find('#rm_box_user_id .filter_rem').click
- select 'Assignee', from: 'add_filter_select'
+ find("#rm_box_user_id .filter_rem").click
+ select "Assignee", from: "add_filter_select"
end
- it_behaves_like 'me filter value', 'AssignedToId', 'assigned_to_id_arg_1_val'
+ it_behaves_like "me filter value", "AssignedToId", "assigned_to_id_arg_1_val"
end
- describe 'user filter' do
- it_behaves_like 'me filter value', 'UserId', 'user_id_arg_1_val'
+ describe "user filter" do
+ it_behaves_like "me filter value", "UserId", "user_id_arg_1_val"
end
end
diff --git a/modules/reporting/spec/features/menu_spec.rb b/modules/reporting/spec/features/menu_spec.rb
index 7813f0117aba..c24941b7f80b 100644
--- a/modules/reporting/spec/features/menu_spec.rb
+++ b/modules/reporting/spec/features/menu_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'project menu' do
+RSpec.describe "project menu" do
let(:current_user) { create(:admin) }
- let!(:project) { create(:valid_project, identifier: 'ponyo', name: 'Ponyo') }
+ let!(:project) { create(:valid_project, identifier: "ponyo", name: "Ponyo") }
before do
allow(User).to receive(:current).and_return current_user
@@ -59,59 +59,59 @@
# Refer to `engine.rb` to see where the menu entries are declared.
#
# * May apply to routes used with parameters in general.
- describe '#18788 (cost reports not found (404)) regression test' do
- describe 'link to project cost reports' do
- shared_examples 'it leads to the project costs reports' do
+ describe "#18788 (cost reports not found (404)) regression test" do
+ describe "link to project cost reports" do
+ shared_examples "it leads to the project costs reports" do
before do
visit current_path
end
- it 'leads to cost reports' do
- find("#main-menu #{test_selector('op-menu--item-action')}", text: 'Time and costs').click
+ it "leads to cost reports" do
+ find("#main-menu #{test_selector('op-menu--item-action')}", text: "Time and costs").click
expect(page).to have_current_path("/projects/ponyo/cost_reports")
end
end
context "when on the project's activity page" do
- let(:current_path) { '/projects/ponyo/activity' }
+ let(:current_path) { "/projects/ponyo/activity" }
- it_behaves_like 'it leads to the project costs reports'
+ it_behaves_like "it leads to the project costs reports"
end
context "when on the project's calendars" do
- let(:current_path) { '/projects/ponyo/calendars' }
+ let(:current_path) { "/projects/ponyo/calendars" }
- it_behaves_like 'it leads to the project costs reports'
+ it_behaves_like "it leads to the project costs reports"
end
end
- describe 'link to global cost reports' do
- shared_examples 'it leads to the cost reports' do
+ describe "link to global cost reports" do
+ shared_examples "it leads to the cost reports" do
before do
visit current_path
end
- it 'leads to cost reports' do
+ it "leads to cost reports" do
# doing what no human can - click on invisible items.
# This way, we avoid having to use selenium and by that increase stability.
- find("#main-menu #{test_selector('op-menu--item-action')}", text: 'Time and costs').click
+ find("#main-menu #{test_selector('op-menu--item-action')}", text: "Time and costs").click
# to make sure we're not seeing the project cost reports:
- expect(page).to have_no_text('Ponyo')
+ expect(page).to have_no_text("Ponyo")
end
end
context "when on the project's activity page" do
- let(:current_path) { '/projects/ponyo/activity' }
+ let(:current_path) { "/projects/ponyo/activity" }
- it_behaves_like 'it leads to the cost reports'
+ it_behaves_like "it leads to the cost reports"
end
context "when on the project's calendar" do
- let(:current_path) { '/projects/ponyo/calendars' }
+ let(:current_path) { "/projects/ponyo/calendars" }
- it_behaves_like 'it leads to the cost reports'
+ it_behaves_like "it leads to the cost reports"
end
end
end
diff --git a/modules/reporting/spec/features/my_time_spec.rb b/modules/reporting/spec/features/my_time_spec.rb
index f3d6e42c4d1c..093811d9c63f 100644
--- a/modules/reporting/spec/features/my_time_spec.rb
+++ b/modules/reporting/spec/features/my_time_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Cost report showing my own times', :js do
+RSpec.describe "Cost report showing my own times", :js do
let(:project) { create(:project) }
let(:user) { create(:admin) }
let(:user2) { create(:admin) }
@@ -21,21 +21,21 @@
visit cost_reports_path(project)
end
- context 'as user with logged time' do
+ context "as user with logged time" do
let(:current_user) { user }
- it 'shows my time' do
- expect(page).to have_css('.report', text: '10.0')
+ it "shows my time" do
+ expect(page).to have_css(".report", text: "10.0")
end
end
- context 'as user without logged time' do
+ context "as user without logged time" do
let(:current_user) { user2 }
- it 'shows my time' do
- expect(page).to have_no_css('.report')
- expect(page).to have_css('.generic-table--no-results-title')
- expect(page).to have_no_text '10.0' # 1 EUR x 10
+ it "shows my time" do
+ expect(page).to have_no_css(".report")
+ expect(page).to have_css(".generic-table--no-results-title")
+ expect(page).to have_no_text "10.0" # 1 EUR x 10
end
end
end
diff --git a/modules/reporting/spec/features/permissions_spec.rb b/modules/reporting/spec/features/permissions_spec.rb
index 1567a9889fb2..73e4b11803cf 100644
--- a/modules/reporting/spec/features/permissions_spec.rb
+++ b/modules/reporting/spec/features/permissions_spec.rb
@@ -1,7 +1,7 @@
-require 'spec_helper'
-require_relative 'support/pages/cost_report_page'
+require "spec_helper"
+require_relative "support/pages/cost_report_page"
-RSpec.describe 'Cost report calculations', :js do
+RSpec.describe "Cost report calculations", :js do
let(:project) { create(:project) }
let(:admin) { create(:admin) }
@@ -33,7 +33,7 @@
hours: 5)
end
let!(:cost_type) do
- type = create(:cost_type, name: 'Translations')
+ type = create(:cost_type, name: "Translations")
create(:cost_rate, cost_type: type, rate: 7.00)
type
end
@@ -48,33 +48,33 @@
before do
login_as current_user
- visit '/cost_reports?set_filter=1'
+ visit "/cost_reports?set_filter=1"
end
- context 'as anonymous' do
+ context "as anonymous" do
let(:current_user) { User.anonymous }
- it 'is redirect to login' do
- expect(page).to have_content 'Username'
- expect(page).to have_content 'Password'
+ it "is redirect to login" do
+ expect(page).to have_content "Username"
+ expect(page).to have_content "Password"
end
end
- context 'as admin' do
+ context "as admin" do
let(:current_user) { admin }
- it 'shows everything' do
- expect(page).to have_content '5.00 hours'
- expect(page).to have_content '10.00 hours'
+ it "shows everything" do
+ expect(page).to have_content "5.00 hours"
+ expect(page).to have_content "10.00 hours"
- report_page.switch_to_type 'Translations'
+ report_page.switch_to_type "Translations"
- expect(page).to have_content '3.0 plural_unit'
- expect(page).to have_content '21.00 EUR'
+ expect(page).to have_content "3.0 plural_unit"
+ expect(page).to have_content "21.00 EUR"
end
end
- context 'as user with all permissions' do
+ context "as user with all permissions" do
let(:current_user) { user }
let!(:permissions) do
%i(view_own_hourly_rate view_hourly_rates view_cost_rates
@@ -82,65 +82,65 @@
view_time_entries)
end
- it 'shows everything' do
- expect(page).to have_content '5.00 hours'
- expect(page).to have_content '10.00 hours'
- report_page.switch_to_type 'Translations'
- expect(page).to have_css('td.units', text: '3.0 plural_unit', wait: 10)
+ it "shows everything" do
+ expect(page).to have_content "5.00 hours"
+ expect(page).to have_content "10.00 hours"
+ report_page.switch_to_type "Translations"
+ expect(page).to have_css("td.units", text: "3.0 plural_unit", wait: 10)
end
end
- context 'as user with no permissions' do
+ context "as user with no permissions" do
let(:current_user) { user }
let!(:permissions) { %i() }
- it 'shows nothing' do
- expect(page).to have_text '[Error 403]'
+ it "shows nothing" do
+ expect(page).to have_text "[Error 403]"
end
end
- context 'as user with own permissions' do
+ context "as user with own permissions" do
let(:current_user) { user }
let!(:permissions) do
%i(view_own_hourly_rate view_own_time_entries view_own_cost_entries)
end
- it 'shows his own costs' do
- expect(page).to have_content '5.00 hours'
- expect(page).to have_no_content '10.00 hours'
- report_page.switch_to_type 'Translations'
- expect(page).to have_css('td.units', text: '3.0 plural_unit', wait: 10)
+ it "shows his own costs" do
+ expect(page).to have_content "5.00 hours"
+ expect(page).to have_no_content "10.00 hours"
+ report_page.switch_to_type "Translations"
+ expect(page).to have_css("td.units", text: "3.0 plural_unit", wait: 10)
end
end
- context 'as user with own time permissions' do
+ context "as user with own time permissions" do
let(:current_user) { user }
let!(:permissions) do
%i(view_own_time_entries)
end
- it 'shows his own time only' do
- expect(page).to have_content '5.00 hours'
- expect(page).to have_no_content '10.00 hours'
+ it "shows his own time only" do
+ expect(page).to have_content "5.00 hours"
+ expect(page).to have_no_content "10.00 hours"
- report_page.switch_to_type 'Translations'
- expect(page).to have_css('.generic-table--no-results-title')
- expect(page).to have_no_css('td.unit', text: '3.0 plural_unit')
+ report_page.switch_to_type "Translations"
+ expect(page).to have_css(".generic-table--no-results-title")
+ expect(page).to have_no_css("td.unit", text: "3.0 plural_unit")
end
end
- context 'as user with own costs permissions' do
+ context "as user with own costs permissions" do
let(:current_user) { user }
let!(:permissions) do
%i(view_own_cost_entries)
end
- it 'shows his own costs' do
- expect(page).to have_css('.generic-table--no-results-title')
- expect(page).to have_no_content '5.00 hours'
- expect(page).to have_no_content '10.00 hours'
- report_page.switch_to_type 'Translations'
- expect(page).to have_no_css('td.unit', text: '3.0 plural_unit')
+ it "shows his own costs" do
+ expect(page).to have_css(".generic-table--no-results-title")
+ expect(page).to have_no_content "5.00 hours"
+ expect(page).to have_no_content "10.00 hours"
+ report_page.switch_to_type "Translations"
+ expect(page).to have_no_css("td.unit", text: "3.0 plural_unit")
end
end
end
diff --git a/modules/reporting/spec/features/project_context_spec.rb b/modules/reporting/spec/features/project_context_spec.rb
index a28f9ffc94e8..755793d0a0fe 100644
--- a/modules/reporting/spec/features/project_context_spec.rb
+++ b/modules/reporting/spec/features/project_context_spec.rb
@@ -1,7 +1,7 @@
-require 'spec_helper'
-require_relative 'support/pages/cost_report_page'
+require "spec_helper"
+require_relative "support/pages/cost_report_page"
-RSpec.describe 'Cost report project context', :js do
+RSpec.describe "Cost report project context", :js do
let(:project1) { create(:project) }
let(:project2) { create(:project) }
let(:admin) { create(:admin) }
@@ -16,9 +16,9 @@
it "switches the project context when visiting another project's cost report" do
visit cost_reports_path(project1)
- expect(page).to have_css('.ng-value-label', text: project1.name)
+ expect(page).to have_css(".ng-value-label", text: project1.name)
visit cost_reports_path(project2)
- expect(page).to have_css('.ng-value-label', text: project2.name)
+ expect(page).to have_css(".ng-value-label", text: project2.name)
end
end
diff --git a/modules/reporting/spec/features/saving_spec.rb b/modules/reporting/spec/features/saving_spec.rb
index 7351eb6bcb78..4210d2f808b3 100644
--- a/modules/reporting/spec/features/saving_spec.rb
+++ b/modules/reporting/spec/features/saving_spec.rb
@@ -1,7 +1,7 @@
-require 'spec_helper'
-require_relative 'support/pages/cost_report_page'
+require "spec_helper"
+require_relative "support/pages/cost_report_page"
-RSpec.describe 'Cost report saving', :js do
+RSpec.describe "Cost report saving", :js do
let(:project) { create(:project) }
let(:user) { create(:admin) }
@@ -12,49 +12,49 @@
visit cost_reports_path(project)
end
- it 'can save reports privately' do
+ it "can save reports privately" do
report_page.clear
- report_page.add_to_columns 'Work package'
- report_page.add_to_rows 'Project'
+ report_page.add_to_columns "Work package"
+ report_page.add_to_rows "Project"
- report_page.save as: 'Testreport'
+ report_page.save as: "Testreport"
# Check if the category is displayed
- expect(page).to have_css('.op-sidemenu--title', text: I18n.t(:label_private_report_plural).upcase)
+ expect(page).to have_css(".op-sidemenu--title", text: I18n.t(:label_private_report_plural).upcase)
# Check if the new report is displayed
- expect(page).to have_css('.op-sidemenu--item-title', text: 'Testreport')
+ expect(page).to have_css(".op-sidemenu--item-title", text: "Testreport")
- report_page.expect_column_element 'Work package'
- report_page.expect_row_element 'Project'
+ report_page.expect_column_element "Work package"
+ report_page.expect_row_element "Project"
end
- it 'can save reports publicly' do
+ it "can save reports publicly" do
report_page.clear
- report_page.add_to_columns 'Work package'
- report_page.add_to_rows 'Project'
+ report_page.add_to_columns "Work package"
+ report_page.add_to_rows "Project"
- report_page.save as: 'Public report', public: true
+ report_page.save as: "Public report", public: true
# Check if the category is displayed
- expect(page).to have_css('.op-sidemenu--title', text: I18n.t(:label_public_report_plural).upcase)
+ expect(page).to have_css(".op-sidemenu--title", text: I18n.t(:label_public_report_plural).upcase)
# Check if the new report is displayed
- expect(page).to have_css('.op-sidemenu--item-title', text: 'Public report')
+ expect(page).to have_css(".op-sidemenu--item-title", text: "Public report")
- report_page.expect_column_element 'Work package'
- report_page.expect_row_element 'Project'
+ report_page.expect_column_element "Work package"
+ report_page.expect_row_element "Project"
end
- context 'as user without permissions' do
+ context "as user without permissions" do
let(:role) { create(:project_role, permissions: %i(view_time_entries)) }
let!(:user) do
create(:user,
member_with_roles: { project => role })
end
- it 'cannot save reports' do
- expect(page).to have_no_css('.buttons', text: 'Save')
+ it "cannot save reports" do
+ expect(page).to have_no_css(".buttons", text: "Save")
end
end
end
diff --git a/modules/reporting/spec/features/subproject_spec.rb b/modules/reporting/spec/features/subproject_spec.rb
index 8e32ca47c97a..68ae8ee3f0a0 100644
--- a/modules/reporting/spec/features/subproject_spec.rb
+++ b/modules/reporting/spec/features/subproject_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Cost report in subproject', :js do
+RSpec.describe "Cost report in subproject", :js do
let!(:project) { create(:project) }
let!(:subproject) { create(:project, parent: project) }
@@ -15,13 +15,13 @@
visit project_path(subproject)
end
- it 'provides filtering' do
- within '#main-menu' do
- click_on 'Time and costs'
+ it "provides filtering" do
+ within "#main-menu" do
+ click_on "Time and costs"
end
- within '#content' do
- expect(page).to have_content 'New cost report'
+ within "#content" do
+ expect(page).to have_content "New cost report"
end
end
end
diff --git a/modules/reporting/spec/features/support/components/cost_reports_base_table.rb b/modules/reporting/spec/features/support/components/cost_reports_base_table.rb
index 8bda2bb010b9..929e8873d5cf 100644
--- a/modules/reporting/spec/features/support/components/cost_reports_base_table.rb
+++ b/modules/reporting/spec/features/support/components/cost_reports_base_table.rb
@@ -39,7 +39,7 @@ def initialize
end
def rows_count(count)
- expect(page).to have_css('#result-table tbody tr', count:)
+ expect(page).to have_css("#result-table tbody tr", count:)
end
def expect_action_icon(icon, row, present: true)
@@ -59,13 +59,13 @@ def edit_time_entry(new_value, row)
page.find("#{row_selector(row)} .icon-edit").click
time_logging_modal.is_visible true
- time_logging_modal.update_field 'hours', new_value
+ time_logging_modal.update_field "hours", new_value
time_logging_modal.work_package_is_missing false
- time_logging_modal.perform_action 'Save'
+ time_logging_modal.perform_action "Save"
SeleniumHubWaiter.wait
- expect_action_icon 'edit', row
+ expect_action_icon "edit", row
expect_value new_value, row
end
@@ -73,12 +73,12 @@ def edit_cost_entry(new_value, row, cost_entry_id)
SeleniumHubWaiter.wait
page.find("#{row_selector(row)} .icon-edit").click
- expect(page).to have_current_path('/cost_entries/' + cost_entry_id + '/edit')
+ expect(page).to have_current_path("/cost_entries/" + cost_entry_id + "/edit")
SeleniumHubWaiter.wait
- fill_in('cost_entry_units', with: new_value)
- click_button 'Save'
- expect(page).to have_css('.op-toast.-success')
+ fill_in("cost_entry_units", with: new_value)
+ click_button "Save"
+ expect(page).to have_css(".op-toast.-success")
end
def delete_entry(row)
diff --git a/modules/reporting/spec/features/support/pages/cost_report_page.rb b/modules/reporting/spec/features/support/pages/cost_report_page.rb
index 97dafbd84c6c..c10eeac31c78 100644
--- a/modules/reporting/spec/features/support/pages/cost_report_page.rb
+++ b/modules/reporting/spec/features/support/pages/cost_report_page.rb
@@ -10,29 +10,29 @@ def clear
# We often clear the page as the first action of the example,
# which is why the frontend might not be fully initialized
retry_block do
- scroll_to_and_click(find_by_id('query-link-clear', text: 'Clear'))
+ scroll_to_and_click(find_by_id("query-link-clear", text: "Clear"))
# Safeguard to force waiting for the form to be cleared
expect(page)
- .to have_no_css('.group-by--selected-element')
+ .to have_no_css(".group-by--selected-element")
end
end
def save(as:, public: false)
# Scroll to report bottom and click
- scroll_to_and_click(find_by_id('query-icon-save-as', text: 'Save'))
+ scroll_to_and_click(find_by_id("query-icon-save-as", text: "Save"))
# Ensure the form is visible
- scroll_to_element find_by_id('save_as_form')
+ scroll_to_element find_by_id("save_as_form")
- page.within('#save_as_form') do
- fill_in 'Name', with: as
+ page.within("#save_as_form") do
+ fill_in "Name", with: as
if public
- check 'Public'
+ check "Public"
end
- click_on 'Save'
+ click_on "Save"
end
end
@@ -52,38 +52,38 @@ def remove_column_element(text)
end
def apply
- scroll_to_and_click(find_by_id('query-icon-apply-button'))
+ scroll_to_and_click(find_by_id("query-icon-apply-button"))
end
def add_to_rows(name)
- select name, from: 'group-by--add-rows'
+ select name, from: "group-by--add-rows"
end
def add_to_columns(name)
- select name, from: 'group-by--add-columns'
+ select name, from: "group-by--add-columns"
end
def expect_row_element(text, present: true)
if present
- expect(page).to have_css('#group-by--selected-rows .group-by--selected-element', text:)
+ expect(page).to have_css("#group-by--selected-rows .group-by--selected-element", text:)
else
- expect(page).to have_no_css('#group-by--selected-rows .group-by--selected-element', text:)
+ expect(page).to have_no_css("#group-by--selected-rows .group-by--selected-element", text:)
end
end
def expect_column_element(text, present: true)
if present
- expect(page).to have_css('#group-by--selected-columns .group-by--selected-element', text:)
+ expect(page).to have_css("#group-by--selected-columns .group-by--selected-element", text:)
else
- expect(page).to have_no_css('#group-by--selected-columns .group-by--selected-element', text:)
+ expect(page).to have_no_css("#group-by--selected-columns .group-by--selected-element", text:)
end
end
def show_loading_indicator(present: true)
if present
- expect(page).to have_css('#ajax-indicator')
+ expect(page).to have_css("#ajax-indicator")
else
- expect(page).to have_no_css('#ajax-indicator')
+ expect(page).to have_no_css("#ajax-indicator")
end
end
diff --git a/modules/reporting/spec/features/top_menu_item_spec.rb b/modules/reporting/spec/features/top_menu_item_spec.rb
index dfac4711d12f..137fcc62e31c 100644
--- a/modules/reporting/spec/features/top_menu_item_spec.rb
+++ b/modules/reporting/spec/features/top_menu_item_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Top menu items', :js do
+RSpec.describe "Top menu items", :js do
let(:user) { create(:user) }
let(:open_menu) { true }
def has_menu_items?(*labels)
- within '.op-app-header' do
+ within ".op-app-header" do
labels.each do |l|
expect(page).to have_link(l)
end
@@ -41,7 +41,7 @@ def has_menu_items?(*labels)
end
def expect_no_menu_item(*labels)
- within '.op-app-header' do
+ within ".op-app-header" do
labels.each do |l|
expect(page).to have_no_link(l)
end
@@ -52,8 +52,8 @@ def click_link_in_open_menu(title)
# if the menu is not completely expanded (e.g. if the frontend thread is too fast),
# the click might be ignored
- within '.op-app-menu--item_has-dropdown .op-app-menu--dropdown[aria-expanded=true]' do
- expect(page).to have_no_css('[style~=overflow]')
+ within ".op-app-menu--item_has-dropdown .op-app-menu--dropdown[aria-expanded=true]" do
+ expect(page).to have_no_css("[style~=overflow]")
page.click_link(title)
end
@@ -72,32 +72,32 @@ def click_link_in_open_menu(title)
top_menu.click if open_menu
end
- describe 'Modules' do
+ describe "Modules" do
let!(:top_menu) { find(:css, "[title=#{I18n.t('label_modules')}]") }
- let(:reporting_item) { I18n.t('cost_reports_title') }
+ let(:reporting_item) { I18n.t("cost_reports_title") }
- context 'as an admin' do
+ context "as an admin" do
let(:user) { create(:admin) }
- it 'displays reporting item' do
+ it "displays reporting item" do
has_menu_items?(reporting_item)
end
- it 'visits the reporting page' do
+ it "visits the reporting page" do
click_link_in_open_menu(reporting_item)
- expect(page).to have_current_path(url_for(controller: '/cost_reports', action: 'index', project_id: nil, only_path: true))
+ expect(page).to have_current_path(url_for(controller: "/cost_reports", action: "index", project_id: nil, only_path: true))
end
end
- context 'as a regular user' do
- it 'has no menu item' do
+ context "as a regular user" do
+ it "has no menu item" do
expect_no_menu_item reporting_item
end
end
- context 'as a user with permissions', :allow_all_permissions do
- it 'displays all options' do
+ context "as a user with permissions", :allow_all_permissions do
+ it "displays all options" do
has_menu_items?(reporting_item)
end
end
diff --git a/modules/reporting/spec/features/update_cost_report_spec.rb b/modules/reporting/spec/features/update_cost_report_spec.rb
index b2b33bab5af9..777ac25966a1 100644
--- a/modules/reporting/spec/features/update_cost_report_spec.rb
+++ b/modules/reporting/spec/features/update_cost_report_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb')
-require_relative 'support/pages/cost_report_page'
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper.rb")
+require_relative "support/pages/cost_report_page"
RSpec.describe "updating a cost report's cost type", :js do
let(:project) { create(:project_with_types, members: { user => create(:project_role) }) }
@@ -36,7 +36,7 @@
end
let(:cost_type) do
- create(:cost_type, name: 'Post-war', unit: 'cap', unit_plural: 'caps')
+ create(:cost_type, name: "Post-war", unit: "cap", unit_plural: "caps")
end
let!(:cost_entry) do
@@ -49,16 +49,16 @@
login_as(user)
end
- it 'works' do
+ it "works" do
report_page.visit!
- report_page.save(as: 'My Query', public: true)
+ report_page.save(as: "My Query", public: true)
report_page.wait_for_page_to_reload
- cost_query = CostQuery.find_by!(name: 'My Query')
+ cost_query = CostQuery.find_by!(name: "My Query")
expect(page).to have_current_path("/projects/#{project.identifier}/cost_reports/#{cost_query.id}")
- expect(page).to have_field('Labor', checked: true)
+ expect(page).to have_field("Labor", checked: true)
report_page.switch_to_type cost_type.name
expect(page).to have_field(cost_type.name, checked: true, wait: 10)
diff --git a/modules/reporting/spec/features/update_entries_spec.rb b/modules/reporting/spec/features/update_entries_spec.rb
index d3c2ae2fe84c..788fa4a3e7a4 100644
--- a/modules/reporting/spec/features/update_entries_spec.rb
+++ b/modules/reporting/spec/features/update_entries_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'support/pages/cost_report_page'
-require_relative 'support/components/cost_reports_base_table'
+require "spec_helper"
+require_relative "support/pages/cost_report_page"
+require_relative "support/components/cost_reports_base_table"
-RSpec.describe 'Updating entries within the cost report', :js do
+RSpec.describe "Updating entries within the cost report", :js do
let(:project) { create(:project) }
let(:user) { create(:admin, member_with_permissions: { project => %i[work_package_assigned] }) }
let(:work_package) { create(:work_package, project:) }
@@ -44,7 +44,7 @@
end
let(:cost_type) do
- type = create(:cost_type, name: 'My cool type')
+ type = create(:cost_type, name: "My cool type")
create(:cost_rate, cost_type: type, rate: 7.00)
type
end
@@ -69,11 +69,11 @@
report_page.show_loading_indicator present: false
end
- it 'can edit and delete time entries' do
+ it "can edit and delete time entries" do
table.rows_count 1
- table.expect_action_icon 'edit', 1
- table.expect_action_icon 'delete', 1
+ table.expect_action_icon "edit", 1
+ table.expect_action_icon "delete", 1
table.edit_time_entry 2, 1
@@ -81,16 +81,16 @@
table.rows_count 0
end
- it 'can edit and delete cost entries' do
+ it "can edit and delete cost entries" do
table.rows_count 1
- report_page.switch_to_type 'My cool type'
+ report_page.switch_to_type "My cool type"
report_page.show_loading_indicator present: false
table.rows_count 1
- table.expect_action_icon 'edit', 1
- table.expect_action_icon 'delete', 1
+ table.expect_action_icon "edit", 1
+ table.expect_action_icon "delete", 1
table.edit_cost_entry 2, 1, cost_entry_user.id.to_s
visit cost_reports_path(project)
@@ -100,11 +100,11 @@
table.rows_count 0
end
- it 'shows the action icons after a table refresh' do
+ it "shows the action icons after a table refresh" do
table.rows_count 1
- table.expect_action_icon 'edit', 1
- table.expect_action_icon 'delete', 1
+ table.expect_action_icon "edit", 1
+ table.expect_action_icon "delete", 1
# Force a reload of the table (although nothing has changed)
report_page.apply
@@ -113,22 +113,22 @@
table.rows_count 1
- table.expect_action_icon 'edit', 1
- table.expect_action_icon 'delete', 1
+ table.expect_action_icon "edit", 1
+ table.expect_action_icon "delete", 1
end
- context 'as user without permissions' do
+ context "as user without permissions" do
let(:role) { create(:project_role, permissions: %i(view_time_entries)) }
let!(:user) do
create(:user,
member_with_roles: { project => role })
end
- it 'cannot edit or delete' do
+ it "cannot edit or delete" do
table.rows_count 1
- table.expect_action_icon 'edit', 1, present: false
- table.expect_action_icon 'delete', 1, present: false
+ table.expect_action_icon "edit", 1, present: false
+ table.expect_action_icon "delete", 1, present: false
end
end
end
diff --git a/modules/reporting/spec/features/work_package_costlog_spec.rb b/modules/reporting/spec/features/work_package_costlog_spec.rb
index 8bb034a5b294..4c8a43983b27 100644
--- a/modules/reporting/spec/features/work_package_costlog_spec.rb
+++ b/modules/reporting/spec/features/work_package_costlog_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Cost report showing my own times', :js do
+RSpec.describe "Cost report showing my own times", :js do
let(:project) { create(:project) }
let(:user) do
create(:user, member_with_roles: { project => role })
@@ -11,7 +11,7 @@
let(:budget) do
create(:budget, project:)
end
- let(:cost_type) { create(:cost_type, name: 'Foobar', unit: 'Foobar', unit_plural: 'Foobars') }
+ let(:cost_type) { create(:cost_type, name: "Foobar", unit: "Foobar", unit_plural: "Foobars") }
let(:work_package) { create(:work_package, project:, budget:) }
let(:wp_page) { Pages::FullWorkPackage.new work_package, project }
@@ -21,9 +21,9 @@
project:,
work_package:,
spent_on: Date.today,
- units: '10',
+ units: "10",
user:,
- comments: 'foobar')
+ comments: "foobar")
end
before do
@@ -32,15 +32,15 @@
wp_page.visit!
end
- it 'allows visiting the costs which redirects to cost reports' do
+ it "allows visiting the costs which redirects to cost reports" do
new_window = window_opened_by do
- page.find('.costsByType a', text: '10 Foobar').click
+ page.find(".costsByType a", text: "10 Foobar").click
end
within_window new_window do
- expect(page).to have_css('#query_saved_name', text: 'New cost report')
- expect(page).to have_field('values[work_package_id][]', with: work_package.id)
- expect(page).to have_css('td.units', text: '10.0 Foobars')
+ expect(page).to have_css("#query_saved_name", text: "New cost report")
+ expect(page).to have_field("values[work_package_id][]", with: work_package.id)
+ expect(page).to have_css("td.units", text: "10.0 Foobars")
end
end
end
diff --git a/modules/reporting/spec/helpers/reporting_helper_spec.rb b/modules/reporting/spec/helpers/reporting_helper_spec.rb
index 840a206c588e..6cd5de8acc28 100644
--- a/modules/reporting/spec/helpers/reporting_helper_spec.rb
+++ b/modules/reporting/spec/helpers/reporting_helper_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe ReportingHelper do
- describe '#field_representation_map' do
- context 'for a custom field' do
- context 'for which a custom option exists (e.g. a list field)' do
+ describe "#field_representation_map" do
+ context "for a custom field" do
+ context "for which a custom option exists (e.g. a list field)" do
let(:custom_field) do
create(
:list_wp_custom_field,
@@ -40,20 +40,20 @@
)
end
- it 'returns the option value' do
+ it "returns the option value" do
option = custom_field.possible_values.first
expect(field_representation_map("custom_field#{custom_field.id}", option.id))
- .to eql 'ham'
+ .to eql "ham"
end
- it 'returns not found for an outdated value value' do
+ it "returns not found for an outdated value value" do
expect(field_representation_map("custom_field#{custom_field.id}", "1234123"))
- .to eql '1234123 not found'
+ .to eql "1234123 not found"
end
end
- context 'for which no custom option exists (e.g. a float field)' do
+ context "for which no custom option exists (e.g. a float field)" do
let(:custom_field) do
create(
:float_wp_custom_field,
@@ -61,15 +61,15 @@
)
end
- it 'returns the option value' do
+ it "returns the option value" do
expect(field_representation_map("custom_field#{custom_field.id}", 3.0))
.to be 3.0
end
end
end
- context 'for which no custom option exists' do
- it 'returns the not found value' do
+ context "for which no custom option exists" do
+ it "returns the not found value" do
expect(field_representation_map("custom_field12345", "345"))
.to eql "345 not found"
end
diff --git a/modules/reporting/spec/lib/open_project/configuration_spec.rb b/modules/reporting/spec/lib/open_project/configuration_spec.rb
index bb506bb36d00..34f7d4792ff4 100644
--- a/modules/reporting/spec/lib/open_project/configuration_spec.rb
+++ b/modules/reporting/spec/lib/open_project/configuration_spec.rb
@@ -26,16 +26,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'OpenProject::Configuration' do
- describe '.cost_reporting_cache_filter_classes' do
- it 'is a true by default via the method' do
+RSpec.describe "OpenProject::Configuration" do
+ describe ".cost_reporting_cache_filter_classes" do
+ it "is a true by default via the method" do
expect(OpenProject::Configuration.cost_reporting_cache_filter_classes).to be_truthy
end
- it 'is true by default via the hash' do
- expect(OpenProject::Configuration['cost_reporting_cache_filter_classes']).to be_truthy
+ it "is true by default via the hash" do
+ expect(OpenProject::Configuration["cost_reporting_cache_filter_classes"]).to be_truthy
end
end
end
diff --git a/modules/reporting/spec/models/cost_query/cache_spec.rb b/modules/reporting/spec/models/cost_query/cache_spec.rb
index 2245b4712ad6..bd04aed28795 100644
--- a/modules/reporting/spec/models/cost_query/cache_spec.rb
+++ b/modules/reporting/spec/models/cost_query/cache_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require File.join(File.dirname(__FILE__), '..', '..', 'support', 'configuration_helper')
+require "spec_helper"
+require File.join(File.dirname(__FILE__), "..", "..", "support", "configuration_helper")
RSpec.describe CostQuery::Cache do
include OpenProject::Reporting::SpecHelper::ConfigurationHelper
@@ -75,20 +75,20 @@ def no_custom_fields_exist
reset_cache_keys
end
- describe '.check' do
- context 'with cache_classes configuration enabled' do
+ describe ".check" do
+ context "with cache_classes configuration enabled" do
before do
mock_cache_classes_setting_with(true)
end
- it 'resets the caches on filters and group by' do
+ it "resets the caches on filters and group by" do
custom_fields_exist
expect_reset_on_caches
described_class.check
end
- it 'stores when the last update was made and does not reset again if nothing changed' do
+ it "stores when the last update was made and does not reset again if nothing changed" do
custom_fields_exist
expect_reset_on_caches
@@ -99,7 +99,7 @@ def no_custom_fields_exist
described_class.check
end
- it 'does reset the cache if last CustomField is removed' do
+ it "does reset the cache if last CustomField is removed" do
custom_fields_exist
expect_reset_on_caches
@@ -112,12 +112,12 @@ def no_custom_fields_exist
end
end
- context 'with_cache_classes configuration disabled' do
+ context "with_cache_classes configuration disabled" do
before do
mock_cache_classes_setting_with(false)
end
- it 'resets the cache again even if nothing changed' do
+ it "resets the cache again even if nothing changed" do
custom_fields_exist
expect_reset_on_caches
diff --git a/modules/reporting/spec/models/cost_query/chaining_spec.rb b/modules/reporting/spec/models/cost_query/chaining_spec.rb
index 65cd5d4f238e..ab7a450bbf4e 100644
--- a/modules/reporting/spec/models/cost_query/chaining_spec.rb
+++ b/modules/reporting/spec/models/cost_query/chaining_spec.rb
@@ -33,7 +33,7 @@
minimal_query
- describe '#chain' do
+ describe "#chain" do
around do |example|
# FIXME: is there a better way to load all filter and groups?
CostQuery::Filter.all && CostQuery::GroupBy.all
@@ -165,7 +165,7 @@ def self.engine
end
describe Report::Chainable do
- describe '#top' do
+ describe "#top" do
let(:chain) { described_class.new }
it "returns for an one element long chain that chain as top" do
@@ -190,7 +190,7 @@ def self.engine
end
end
- describe '#inherited_attribute' do
+ describe "#inherited_attribute" do
before do
@a = Class.new described_class
@a.inherited_attribute :foo, default: 42
@@ -199,31 +199,31 @@ def self.engine
@d = Class.new @b
end
- it 'takes default argument' do
+ it "takes default argument" do
expect(@a.foo).to eq(42)
expect(@b.foo).to eq(42)
expect(@c.foo).to eq(42)
expect(@d.foo).to eq(42)
end
- it 'inherits values' do
+ it "inherits values" do
@a.foo 1337
expect(@d.foo).to eq(1337)
end
- it 'does not change values of parents and akin' do
+ it "does not change values of parents and akin" do
@b.foo 1337
expect(@a.foo).not_to eq(1337)
expect(@c.foo).not_to eq(1337)
end
- it 'is able to map values' do
+ it "is able to map values" do
@a.inherited_attribute :bar, map: proc { |x| x * 2 }
@a.bar 21
expect(@a.bar).to eq(42)
end
- describe '#list' do
+ describe "#list" do
it "merges lists" do
@a.inherited_attribute :bar, list: true
@a.bar 1
@@ -262,7 +262,7 @@ def self.engine
end
end
- describe '#display' do
+ describe "#display" do
it "gives display? == false when a filter says dont_display!" do
class TestFilter < Report::Filter::Base
dont_display!
@@ -287,7 +287,7 @@ class TestFilter < Report::Filter::Base
end
end
- describe '#selectable' do
+ describe "#selectable" do
it "gives selectable? == false when a filter says not_selectable!" do
class TestFilter < Report::Filter::Base
not_selectable!
diff --git a/modules/reporting/spec/models/cost_query/filter_spec.rb b/modules/reporting/spec/models/cost_query/filter_spec.rb
index 745086b4793b..c18b92e60065 100644
--- a/modules/reporting/spec/models/cost_query/filter_spec.rb
+++ b/modules/reporting/spec/models/cost_query/filter_spec.rb
@@ -27,7 +27,7 @@
#++
require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper")
-require File.join(File.dirname(__FILE__), '..', '..', 'support', 'custom_field_filter')
+require File.join(File.dirname(__FILE__), "..", "..", "support", "custom_field_filter")
RSpec.describe CostQuery, :reporting_query_helper do
minimal_query
@@ -69,11 +69,11 @@ def create_work_package_with_time_entry(work_package_params = {}, entry_params =
# Test Work Package attributes that are included in of the result set
[
- [CostQuery::Filter::ProjectId, 'project', "project_id", 2],
- [CostQuery::Filter::UserId, 'user', "user_id", 2],
- [CostQuery::Filter::CostTypeId, 'cost_type', "cost_type_id", 1],
- [CostQuery::Filter::WorkPackageId, 'work_package', "work_package_id", 2],
- [CostQuery::Filter::ActivityId, 'activity', "activity_id", 1]
+ [CostQuery::Filter::ProjectId, "project", "project_id", 2],
+ [CostQuery::Filter::UserId, "user", "user_id", 2],
+ [CostQuery::Filter::CostTypeId, "cost_type", "cost_type_id", 1],
+ [CostQuery::Filter::WorkPackageId, "work_package", "work_package_id", 2],
+ [CostQuery::Filter::ActivityId, "activity", "activity_id", 1]
].each do |filter, object_name, field, expected_count|
describe filter do
let!(:non_matching_entry) { create(:cost_entry) }
@@ -157,7 +157,7 @@ def create_work_package_with_time_entry(work_package_params = {}, entry_params =
end
it "onlies return entries from the given CostQuery::Filter::AuthorId" do
- query.filter 'author_id', value: author.id
+ query.filter "author_id", value: author.id
query.result.each do |result|
work_package_id = result["work_package_id"]
expect(WorkPackage.find(work_package_id).author.id).to eq(author.id)
@@ -165,8 +165,8 @@ def create_work_package_with_time_entry(work_package_params = {}, entry_params =
end
it "allows chaining the same filter" do
- query.filter 'author_id', value: author.id
- query.filter 'author_id', value: author.id
+ query.filter "author_id", value: author.id
+ query.filter "author_id", value: author.id
query.result.each do |result|
work_package_id = result["work_package_id"]
expect(WorkPackage.find(work_package_id).author.id).to eq(author.id)
@@ -174,30 +174,30 @@ def create_work_package_with_time_entry(work_package_params = {}, entry_params =
end
it "returns no results for excluding filters" do
- query.filter 'author_id', value: author.id
- query.filter 'author_id', value: author.id + 1
+ query.filter "author_id", value: author.id
+ query.filter "author_id", value: author.id + 1
expect(query.result.count).to eq(0)
end
it "computes the correct number of results" do
- query.filter 'author_id', value: author.id
+ query.filter "author_id", value: author.id
expect(query.result.count).to eq(2)
end
end
it "filters spent_on" do
- query.filter :spent_on, operator: 'w'
+ query.filter :spent_on, operator: "w"
expect(query.result.count).to eq(Entry.all.count { |e| e.spent_on.cweek == TimeEntry.all.first.spent_on.cweek })
end
it "filters created_at" do
- query.filter :created_on, operator: 't'
+ query.filter :created_on, operator: "t"
# we assume that some of our fixtures set created_at to Time.now
expect(query.result.count).to eq(Entry.all.count { |e| e.created_at.to_date == Time.zone.today })
end
it "filters updated_at" do
- query.filter :updated_on, value: Time.zone.today.years_ago(20), operator: '>d'
+ query.filter :updated_on, value: Time.zone.today.years_ago(20), operator: ">d"
# we assume that our were updated in the last 20 years
expect(query.result.count).to eq(Entry.all.count { |e| e.updated_at.to_date > Time.zone.today.years_ago(20) })
end
@@ -209,7 +209,7 @@ def create_work_package_with_time_entry(work_package_params = {}, entry_params =
create_work_package_with_time_entry({}, { user: anonymous })
# create matching entry
create_work_package_with_time_entry
- query.filter :user_id, value: user.id, operator: '='
+ query.filter :user_id, value: user.id, operator: "="
expect(query.result.count).to eq(1)
end
@@ -227,46 +227,46 @@ def create_matching_object_with_time_entries(factory, work_package_field, entry_
end
it "filters overridden_costs" do
- query.filter :overridden_costs, operator: 'y'
+ query.filter :overridden_costs, operator: "y"
expect(query.result.count).to eq(Entry.all.count { |e| !e.overridden_costs.nil? })
end
it "filters status" do
matching_status = create(:status, is_closed: true)
create_work_packages_and_time_entries(3, status: matching_status)
- query.filter :status_id, operator: 'c'
+ query.filter :status_id, operator: "c"
expect(query.result.count).to eq(3)
end
it "filters types" do
matching_type = project.types.first
create_work_packages_and_time_entries(3, type: matching_type)
- query.filter :type_id, operator: '=', value: matching_type.id
+ query.filter :type_id, operator: "=", value: matching_type.id
expect(query.result.count).to eq(3)
end
it "filters work_package authors" do
matching_author = create_matching_object_with_time_entries(:user, :author, 3)
- query.filter :author_id, operator: '=', value: matching_author.id
+ query.filter :author_id, operator: "=", value: matching_author.id
expect(query.result.count).to eq(3)
end
it "filters priority" do
matching_priority = create_matching_object_with_time_entries(:priority, :priority, 3)
- query.filter :priority_id, operator: '=', value: matching_priority.id
+ query.filter :priority_id, operator: "=", value: matching_priority.id
expect(query.result.count).to eq(3)
end
it "filters assigned to" do
matching_user = create_matching_object_with_time_entries(:user, :assigned_to, 3)
- query.filter :assigned_to_id, operator: '=', value: matching_user.id
+ query.filter :assigned_to_id, operator: "=", value: matching_user.id
expect(query.result.count).to eq(3)
end
it "filters category" do
category = create(:category, project:)
create_work_packages_and_time_entries(3, category:)
- query.filter :category_id, operator: '=', value: category.id
+ query.filter :category_id, operator: "=", value: category.id
expect(query.result.count).to eq(3)
end
@@ -274,32 +274,32 @@ def create_matching_object_with_time_entries(factory, work_package_field, entry_
matching_version = create(:version, project:)
create_work_packages_and_time_entries(3, version: matching_version)
- query.filter :version_id, operator: '=', value: matching_version.id
+ query.filter :version_id, operator: "=", value: matching_version.id
expect(query.result.count).to eq(3)
end
it "filters subject" do
- matching_work_package = create_work_package_with_time_entry(subject: 'matching subject')
- query.filter :subject, operator: '=', value: 'matching subject'
+ matching_work_package = create_work_package_with_time_entry(subject: "matching subject")
+ query.filter :subject, operator: "=", value: "matching subject"
expect(query.result.count).to eq(1)
end
it "filters start" do
start_date = Date.new(2013, 1, 1)
matching_work_package = create_work_package_with_time_entry(start_date:)
- query.filter :start_date, operator: '=d', value: start_date
+ query.filter :start_date, operator: "=d", value: start_date
expect(query.result.count).to eq(1)
end
it "filters due date" do
due_date = Date.new(2013, 1, 1)
matching_work_package = create_work_package_with_time_entry(due_date:)
- query.filter :due_date, operator: '=d', value: due_date
+ query.filter :due_date, operator: "=d", value: due_date
expect(query.result.count).to eq(1)
end
it "raises an error if operator is not supported" do
- expect { query.filter :spent_on, operator: 'c' }.to raise_error(ArgumentError)
+ expect { query.filter :spent_on, operator: "c" }.to raise_error(ArgumentError)
end
end
@@ -353,15 +353,15 @@ def create_matching_object_with_time_entries(factory, work_package_field, entry_
describe CostQuery::Filter::CustomFieldEntries do
let!(:custom_field) do
cf = create(:work_package_custom_field,
- name: 'My custom field')
+ name: "My custom field")
clear_cache
cf
end
let(:custom_field2) do
- build(:work_package_custom_field, name: 'Database',
+ build(:work_package_custom_field, name: "Database",
field_format: "list",
- possible_values: ['value'])
+ possible_values: ["value"])
end
after(:all) do
@@ -458,14 +458,14 @@ def create_searchable_fields_and_values
it "is usable as filter" do
create_searchable_fields_and_values
cf = WorkPackageCustomField.find_by(name: "Searchable Field")
- query.filter cf.attribute_name, operator: '=', value: "125"
+ query.filter cf.attribute_name, operator: "=", value: "125"
expect(query.result.count).to eq(2)
end
it "is usable as filter #2" do
create_searchable_fields_and_values
cf = WorkPackageCustomField.find_by(name: "Searchable Field")
- query.filter cf.attribute_name, operator: '=', value: "finnlabs"
+ query.filter cf.attribute_name, operator: "=", value: "finnlabs"
expect(query.result.count).to eq(0)
end
end
diff --git a/modules/reporting/spec/models/cost_query/group_by_spec.rb b/modules/reporting/spec/models/cost_query/group_by_spec.rb
index 4fbb9c0d4519..174b3e675442 100644
--- a/modules/reporting/spec/models/cost_query/group_by_spec.rb
+++ b/modules/reporting/spec/models/cost_query/group_by_spec.rb
@@ -27,7 +27,7 @@
#++
require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper")
-require File.join(File.dirname(__FILE__), '..', '..', 'support', 'custom_field_filter')
+require File.join(File.dirname(__FILE__), "..", "..", "support", "custom_field_filter")
RSpec.describe CostQuery, :reporting_query_helper do
let!(:type) { create(:type) }
diff --git a/modules/reporting/spec/models/cost_query/integration_spec.rb b/modules/reporting/spec/models/cost_query/integration_spec.rb
index 3af98ccf1df9..1671e337a4e1 100644
--- a/modules/reporting/spec/models/cost_query/integration_spec.rb
+++ b/modules/reporting/spec/models/cost_query/integration_spec.rb
@@ -48,7 +48,7 @@
describe "the reporting system" do
it "computes group_by and a filter" do
query.group_by :project_id
- query.filter :status_id, operator: 'o'
+ query.filter :status_id, operator: "o"
sql_result = query.result
expect(sql_result.size).to eq(2)
@@ -63,9 +63,9 @@
end
it "applies two filter and a group_by correctly" do
- query.filter :project_id, operator: '=', value: [project1.id]
+ query.filter :project_id, operator: "=", value: [project1.id]
query.group_by :user_id
- query.filter :overridden_costs, operator: 'n'
+ query.filter :overridden_costs, operator: "n"
sql_result = query.result
expect(sql_result.size).to eq(2)
@@ -80,21 +80,21 @@
end
it "applies two different filters on the same field" do
- query.filter :project_id, operator: '=', value: [project1.id, project2.id]
- query.filter :project_id, operator: '!', value: [project2.id]
+ query.filter :project_id, operator: "=", value: [project1.id, project2.id]
+ query.filter :project_id, operator: "!", value: [project2.id]
sql_result = query.result
expect(sql_result.count).to eq(2)
end
- it 'processes only _one_ SQL query for any operations on a valid CostQuery' do
+ it "processes only _one_ SQL query for any operations on a valid CostQuery" do
number_of_sql_queries = 0
expect_any_instance_of(CostQuery::SqlStatement).to receive(:to_s) do |*_|
- number_of_sql_queries += 1 unless caller.third.include? 'sql_statement.rb'
+ number_of_sql_queries += 1 unless caller.third.include? "sql_statement.rb"
# Apparently, we have to return a valid SQL query
- 'SELECT 1=1'
+ "SELECT 1=1"
end
# create a random query
diff --git a/modules/reporting/spec/models/cost_query/operator_spec.rb b/modules/reporting/spec/models/cost_query/operator_spec.rb
index 0adef7845b06..3cb849628411 100644
--- a/modules/reporting/spec/models/cost_query/operator_spec.rb
+++ b/modules/reporting/spec/models/cost_query/operator_spec.rb
@@ -53,241 +53,241 @@ def create_project(options = {})
end
it "does =" do
- expect(cost_query('projects', 'id', '=', project1.id).size).to eq(1)
+ expect(cost_query("projects", "id", "=", project1.id).size).to eq(1)
end
it "does = for multiple values" do
- expect(cost_query('projects', 'id', '=', project1.id, project2.id).size).to eq(2)
+ expect(cost_query("projects", "id", "=", project1.id, project2.id).size).to eq(2)
end
it "does = for no values" do
- sql = CostQuery::SqlStatement.new 'projects'
- "=".to_operator.modify sql, 'id'
+ sql = CostQuery::SqlStatement.new "projects"
+ "=".to_operator.modify sql, "id"
result = (ActiveRecord::Base.connection.select_all sql.to_s)
expect(result).to be_empty
end
it "does = for nil" do
- expect(cost_query('projects', 'id', '=', nil).size).to eq(0)
+ expect(cost_query("projects", "id", "=", nil).size).to eq(0)
end
it "does = for empty string" do
- expect(cost_query('projects', 'id', '=', '').size).to eq(0)
+ expect(cost_query("projects", "id", "=", "").size).to eq(0)
end
it "does <=" do
- expect(cost_query('projects', 'id', '<=', project2.id - 1).size).to eq(1)
+ expect(cost_query("projects", "id", "<=", project2.id - 1).size).to eq(1)
end
it "does >=" do
- expect(cost_query('projects', 'id', '>=', project1.id + 1).size).to eq(1)
+ expect(cost_query("projects", "id", ">=", project1.id + 1).size).to eq(1)
end
it "does !" do
- expect(cost_query('projects', 'id', '!', project1.id).size).to eq(1)
+ expect(cost_query("projects", "id", "!", project1.id).size).to eq(1)
end
it "does ! for empty string" do
- expect(cost_query('projects', 'id', '!', '').size).to eq(0)
+ expect(cost_query("projects", "id", "!", "").size).to eq(0)
end
it "does ! for multiple values" do
- expect(cost_query('projects', 'id', '!', project1.id, project2.id).size).to eq(0)
+ expect(cost_query("projects", "id", "!", project1.id, project2.id).size).to eq(0)
end
it "does !*" do
- expect(cost_query('cost_entries', 'project_id', '!*', []).size).to eq(0)
+ expect(cost_query("cost_entries", "project_id", "!*", []).size).to eq(0)
end
it "does ~ (contains)" do
- expect(cost_query('projects', 'name', '~', 'o').size).to eq(Project.all.count { |p| p.name.include?('o') })
- expect(cost_query('projects', 'name', '~', 'test').size).to eq(Project.all.count { |p| p.name.include?('test') })
- expect(cost_query('projects', 'name', '~', 'child').size).to eq(Project.all.count { |p| p.name.include?('child') })
+ expect(cost_query("projects", "name", "~", "o").size).to eq(Project.all.count { |p| p.name.include?("o") })
+ expect(cost_query("projects", "name", "~", "test").size).to eq(Project.all.count { |p| p.name.include?("test") })
+ expect(cost_query("projects", "name", "~", "child").size).to eq(Project.all.count { |p| p.name.include?("child") })
end
it "does !~ (not contains)" do
- expect(cost_query('projects', 'name', '!~', 'o').size).to eq(Project.all.count { |p| p.name.exclude?('o') })
- expect(cost_query('projects', 'name', '!~', 'test').size).to eq(Project.all.count { |p| p.name.exclude?('test') })
- expect(cost_query('projects', 'name', '!~', 'child').size).to eq(Project.all.count { |p| p.name.exclude?('child') })
+ expect(cost_query("projects", "name", "!~", "o").size).to eq(Project.all.count { |p| p.name.exclude?("o") })
+ expect(cost_query("projects", "name", "!~", "test").size).to eq(Project.all.count { |p| p.name.exclude?("test") })
+ expect(cost_query("projects", "name", "!~", "child").size).to eq(Project.all.count { |p| p.name.exclude?("child") })
end
it "does c (closed work_package)" do
- expect(cost_query('work_packages', 'status_id', 'c') { |s| s.join Status => [WorkPackage, :status] }.size).to be >= 0
+ expect(cost_query("work_packages", "status_id", "c") { |s| s.join Status => [WorkPackage, :status] }.size).to be >= 0
end
it "does o (open work_package)" do
- expect(cost_query('work_packages', 'status_id', 'o') { |s| s.join Status => [WorkPackage, :status] }.size).to be >= 0
+ expect(cost_query("work_packages", "status_id", "o") { |s| s.join Status => [WorkPackage, :status] }.size).to be >= 0
end
it "does give the correct number of results when counting closed and open work_packages" do
- a = cost_query('work_packages', 'status_id', 'o') { |s| s.join Status => [WorkPackage, :status] }.size
- b = cost_query('work_packages', 'status_id', 'c') { |s| s.join Status => [WorkPackage, :status] }.size
+ a = cost_query("work_packages", "status_id", "o") { |s| s.join Status => [WorkPackage, :status] }.size
+ b = cost_query("work_packages", "status_id", "c") { |s| s.join Status => [WorkPackage, :status] }.size
expect(WorkPackage.count).to eq(a + b)
end
it "does w (this week)" do
# somehow this test doesn't work on sundays
- n = cost_query('projects', 'created_at', 'w').size
+ n = cost_query("projects", "created_at", "w").size
day_in_this_week = Time.zone.now.at_beginning_of_week + 1.day
create(:project, created_at: day_in_this_week)
- expect(cost_query('projects', 'created_at', 'w').size).to eq(n + 1)
+ expect(cost_query("projects", "created_at", "w").size).to eq(n + 1)
create(:project, created_at: day_in_this_week + 7.days)
create(:project, created_at: day_in_this_week - 7.days)
- expect(cost_query('projects', 'created_at', 'w').size).to eq(n + 1)
+ expect(cost_query("projects", "created_at", "w").size).to eq(n + 1)
end
it "does t (today)" do
- s = cost_query('projects', 'created_at', 't').size
+ s = cost_query("projects", "created_at", "t").size
create(:project, created_at: Date.yesterday)
- expect(cost_query('projects', 'created_at', 't').size).to eq(s)
+ expect(cost_query("projects", "created_at", "t").size).to eq(s)
create(:project, created_at: Time.zone.now)
- expect(cost_query('projects', 'created_at', 't').size).to eq(s + 1)
+ expect(cost_query("projects", "created_at", "t").size).to eq(s + 1)
end
it "does t+ (after the day which is n days in the future)" do
- n = cost_query('projects', 'created_at', '>t+', 1).size
+ n = cost_query("projects", "created_at", ">t+", 1).size
create(:project, created_at: Time.zone.now)
- expect(cost_query('projects', 'created_at', '>t+', 1).size).to eq(n)
+ expect(cost_query("projects", "created_at", ">t+", 1).size).to eq(n)
create(:project, created_at: Date.tomorrow + 1)
- expect(cost_query('projects', 'created_at', '>t+', 1).size).to eq(n + 1)
+ expect(cost_query("projects", "created_at", ">t+", 1).size).to eq(n + 1)
end
it "does >t- (after the day which is n days ago)" do
- n = cost_query('projects', 'created_at', '>t-', 1).size
+ n = cost_query("projects", "created_at", ">t-", 1).size
create(:project, created_at: Date.today)
- expect(cost_query('projects', 'created_at', '>t-', 1).size).to eq(n + 1)
+ expect(cost_query("projects", "created_at", ">t-", 1).size).to eq(n + 1)
create(:project, created_at: Date.yesterday - 1)
- expect(cost_query('projects', 'created_at', '>t-', 1).size).to eq(n + 1)
+ expect(cost_query("projects", "created_at", ">t-", 1).size).to eq(n + 1)
end
it "does t- (n days ago)" do
- n = cost_query('projects', 'created_at', 't-', 1).size
+ n = cost_query("projects", "created_at", "t-", 1).size
create(:project, created_at: Date.yesterday)
- expect(cost_query('projects', 'created_at', 't-', 1).size).to eq(n + 1)
+ expect(cost_query("projects", "created_at", "t-", 1).size).to eq(n + 1)
create(:project, created_at: Date.yesterday - 2)
- expect(cost_query('projects', 'created_at', 't-', 1).size).to eq(n + 1)
+ expect(cost_query("projects", "created_at", "t-", 1).size).to eq(n + 1)
end
it "does d" do
- expect(cost_query('projects', 'created_at', '<>d', Time.zone.now, 5.minutes.from_now).size).to eq(0)
+ expect(cost_query("projects", "created_at", "<>d", Time.zone.now, 5.minutes.from_now).size).to eq(0)
end
it "does >d" do
# assuming that all projects were created in the past
- expect(cost_query('projects', 'created_at', '>d', Time.zone.now).size).to eq(0)
+ expect(cost_query("projects", "created_at", ">d", Time.zone.now).size).to eq(0)
end
- describe 'arity' do
- arities = { 't' => 0, 'w' => 0, '<>d' => 2, '>d' => 1 }
+ describe "arity" do
+ arities = { "t" => 0, "w" => 0, "<>d" => 2, ">d" => 1 }
arities.each do |o, a|
it("#{o} should take #{a} values") { expect(o.to_operator.arity).to eq(a) }
end
diff --git a/modules/reporting/spec/models/cost_query/validation_spec.rb b/modules/reporting/spec/models/cost_query/validation_spec.rb
index 930b57818601..ad4def9a8b56 100644
--- a/modules/reporting/spec/models/cost_query/validation_spec.rb
+++ b/modules/reporting/spec/models/cost_query/validation_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
RSpec.describe "CostQuery::Validation" do
class CostQuery::SomeBase
diff --git a/modules/reporting/spec/requests/custom_field_cache_spec.rb b/modules/reporting/spec/requests/custom_field_cache_spec.rb
index a36a3cacfd49..56bca39f8b8e 100644
--- a/modules/reporting/spec/requests/custom_field_cache_spec.rb
+++ b/modules/reporting/spec/requests/custom_field_cache_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require File.join(File.dirname(__FILE__), '..', 'support', 'custom_field_filter')
-require File.join(File.dirname(__FILE__), '..', 'support', 'configuration_helper')
+require "spec_helper"
+require File.join(File.dirname(__FILE__), "..", "support", "custom_field_filter")
+require File.join(File.dirname(__FILE__), "..", "support", "configuration_helper")
-RSpec.describe 'Custom field filter and group by caching' do
+RSpec.describe "Custom field filter and group by caching" do
include OpenProject::Reporting::SpecHelper::CustomFieldFilterHelper
include OpenProject::Reporting::SpecHelper::ConfigurationHelper
@@ -69,11 +69,11 @@ def expect_filter_all_to_not_exist(custom_field)
def visit_cost_reports_index
header "Content-Type", "text/html"
- header 'X-Requested-With', 'XMLHttpRequest'
+ header "X-Requested-With", "XMLHttpRequest"
get "/projects/#{project.id}/cost_reports"
end
- it 'removes the filter/group_by if the custom field is removed' do
+ it "removes the filter/group_by if the custom field is removed" do
custom_field2.save!
visit_cost_reports_index
@@ -95,7 +95,7 @@ def visit_cost_reports_index
expect_filter_all_to_not_exist(custom_field2)
end
- it 'removes the filter/group_by if the last custom field is removed' do
+ it "removes the filter/group_by if the last custom field is removed" do
visit_cost_reports_index
expect_group_by_all_to_include(custom_field)
diff --git a/modules/reporting/spec/spec_helper.rb b/modules/reporting/spec/spec_helper.rb
index 5c944d50187e..1956c5840108 100644
--- a/modules/reporting/spec/spec_helper.rb
+++ b/modules/reporting/spec/spec_helper.rb
@@ -29,4 +29,4 @@
RAILS_ENV = "test" unless defined? RAILS_ENV
require "spec_helper"
-Dir[File.dirname(__FILE__) + '/support/*.rb'].each { |file| require file }
+Dir[File.dirname(__FILE__) + "/support/*.rb"].each { |file| require file }
diff --git a/modules/reporting/spec/support/configuration_helper.rb b/modules/reporting/spec/support/configuration_helper.rb
index 6e644c51a2b3..99c4f7f3f16d 100644
--- a/modules/reporting/spec/support/configuration_helper.rb
+++ b/modules/reporting/spec/support/configuration_helper.rb
@@ -31,7 +31,7 @@ module ConfigurationHelper
def mock_cache_classes_setting_with(value)
allow(OpenProject::Configuration).to receive(:[]).and_call_original
allow(OpenProject::Configuration).to receive(:[])
- .with('cost_reporting_cache_filter_classes')
+ .with("cost_reporting_cache_filter_classes")
.and_return(value)
allow(OpenProject::Configuration).to receive(:cost_reporting_cache_filter_classes)
.and_return(value)
diff --git a/modules/reporting/spec/support/query_helper.rb b/modules/reporting/spec/support/query_helper.rb
index 7400fead0063..699e92564d11 100644
--- a/modules/reporting/spec/support/query_helper.rb
+++ b/modules/reporting/spec/support/query_helper.rb
@@ -27,7 +27,7 @@
#++
# need to define all the operators
-require 'cost_query/operator'
+require "cost_query/operator"
module OpenProject::Reporting
module QueryHelper
diff --git a/modules/storages/app/common/storages/peripherals/parse_create_params_service.rb b/modules/storages/app/common/storages/peripherals/parse_create_params_service.rb
index b3b021a94ad6..56696f951596 100644
--- a/modules/storages/app/common/storages/peripherals/parse_create_params_service.rb
+++ b/modules/storages/app/common/storages/peripherals/parse_create_params_service.rb
@@ -56,20 +56,20 @@ def assert_valid_elements
def assert_elements_is_present
return if elements.present?
- raise API::Errors::PropertyMissingError.new('_embedded/elements')
+ raise API::Errors::PropertyMissingError.new("_embedded/elements")
end
def assert_elements_is_an_array
return if elements.is_a?(Array)
- raise API::Errors::PropertyFormatError.new('_embedded/elements', 'Array', elements.class.name)
+ raise API::Errors::PropertyFormatError.new("_embedded/elements", "Array", elements.class.name)
end
def assert_elements_does_not_exceed_maximum
return if elements.size <= MAX_ELEMENTS
- raise API::Errors::Validation.new('_embedded/elements',
- I18n.t('api_v3.errors.too_many_elements_created_at_once',
+ raise API::Errors::Validation.new("_embedded/elements",
+ I18n.t("api_v3.errors.too_many_elements_created_at_once",
max: MAX_ELEMENTS, actual: elements.size))
end
end
diff --git a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/add_user_to_group_command.rb b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/add_user_to_group_command.rb
index d955de0b8ec6..6de0ec796fe2 100644
--- a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/add_user_to_group_command.rb
+++ b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/add_user_to_group_command.rb
@@ -46,13 +46,13 @@ def call(user:, group: @group)
response = OpenProject
.httpx
.basic_auth(@username, @password)
- .with(headers: { 'OCS-APIRequest' => 'true' })
+ .with(headers: { "OCS-APIRequest" => "true" })
.post(
Util.join_uri_path(
@uri,
- 'ocs/v1.php/cloud/users',
+ "ocs/v1.php/cloud/users",
CGI.escapeURIComponent(user),
- 'groups'
+ "groups"
),
form: { "groupid" => CGI.escapeURIComponent(group) }
)
@@ -61,7 +61,7 @@ def call(user:, group: @group)
case response
in { status: 200..299 }
- statuscode = Nokogiri::XML(response.body.to_s).xpath('/ocs/meta/statuscode').text
+ statuscode = Nokogiri::XML(response.body.to_s).xpath("/ocs/meta/statuscode").text
case statuscode
when "100"
@@ -78,15 +78,15 @@ def call(user:, group: @group)
Util.error(:error, "Failed to add user to group", error_data)
end
in { status: 405 }
- Util.error(:not_allowed, 'Outbound request method not allowed', error_data)
+ Util.error(:not_allowed, "Outbound request method not allowed", error_data)
in { status: 401 }
- Util.error(:not_found, 'Outbound request destination not found', error_data)
+ Util.error(:not_found, "Outbound request destination not found", error_data)
in { status: 404 }
- Util.error(:unauthorized, 'Outbound request not authorized', error_data)
+ Util.error(:unauthorized, "Outbound request not authorized", error_data)
in { status: 409 }
Util.error(:conflict, Util.error_text_from_response(response), error_data)
else
- Util.error(:error, 'Outbound request failed', error_data)
+ Util.error(:error, "Outbound request failed", error_data)
end
end
diff --git a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/create_folder_command.rb b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/create_folder_command.rb
index 60cfbbe4783d..103e537c1e76 100644
--- a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/create_folder_command.rb
+++ b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/create_folder_command.rb
@@ -60,21 +60,21 @@ def call(folder_path:)
case response
in { status: 200..299 }
- ServiceResult.success(message: 'Folder was successfully created.')
+ ServiceResult.success(message: "Folder was successfully created.")
in { status: 405 }
- if Util.error_text_from_response(response) == 'The resource you tried to create already exists'
- ServiceResult.success(message: 'Folder already exists.')
+ if Util.error_text_from_response(response) == "The resource you tried to create already exists"
+ ServiceResult.success(message: "Folder already exists.")
else
- Util.error(:not_allowed, 'Outbound request method not allowed', error_data)
+ Util.error(:not_allowed, "Outbound request method not allowed", error_data)
end
in { status: 401 }
- Util.error(:unauthorized, 'Outbound request not authorized', error_data)
+ Util.error(:unauthorized, "Outbound request not authorized", error_data)
in { status: 404 }
- Util.error(:not_found, 'Outbound request destination not found', error_data)
+ Util.error(:not_found, "Outbound request destination not found", error_data)
in { status: 409 }
Util.error(:conflict, Util.error_text_from_response(response), error_data)
else
- Util.error(:error, 'Outbound request failed', error_data)
+ Util.error(:error, "Outbound request failed", error_data)
end
end
diff --git a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/download_link_query.rb b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/download_link_query.rb
index ba10f42b97d4..7d5723749126 100644
--- a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/download_link_query.rb
+++ b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/download_link_query.rb
@@ -46,7 +46,7 @@ def call(user:, file_link:)
direct_download_request(token, file_link).bind do |resp|
# The nextcloud API returns a successful response with empty body if the authorization is missing or expired
if resp.body.blank?
- Util.error(:unauthorized, 'Outbound request not authorized!')
+ Util.error(:unauthorized, "Outbound request not authorized!")
else
ServiceResult.success(result: resp.body.to_s)
end
@@ -64,29 +64,29 @@ def direct_download_request(token, file_link)
response = OpenProject
.httpx
.post(
- Util.join_uri_path(@uri, '/ocs/v2.php/apps/dav/api/v1/direct'),
+ Util.join_uri_path(@uri, "/ocs/v2.php/apps/dav/api/v1/direct"),
json: { fileId: file_link.origin_id },
headers: {
- 'Authorization' => "Bearer #{token.access_token}",
- 'OCS-APIRequest' => 'true',
- 'Accept' => 'application/json',
- 'Content-Type' => 'application/json'
+ "Authorization" => "Bearer #{token.access_token}",
+ "OCS-APIRequest" => "true",
+ "Accept" => "application/json",
+ "Content-Type" => "application/json"
}
)
case response
in { status: 200..299 }
ServiceResult.success(result: response)
in { status: 404 }
- Util.error(:not_found, 'Outbound request destination not found!', response)
+ Util.error(:not_found, "Outbound request destination not found!", response)
in { status: 401 }
- Util.error(:unauthorized, 'Outbound request not authorized!', response)
+ Util.error(:unauthorized, "Outbound request not authorized!", response)
else
- Util.error(:error, 'Outbound request failed!')
+ Util.error(:error, "Outbound request failed!")
end
end
def download_link(token, origin_name)
- Util.join_uri_path(@uri, 'index.php/apps/integration_openproject/direct', token, CGI.escape(origin_name))
+ Util.join_uri_path(@uri, "index.php/apps/integration_openproject/direct", token, CGI.escape(origin_name))
end
def direct_download_token(body:)
@@ -105,13 +105,13 @@ def parse_direct_download_token(body:)
return nil
end
- direct_download_url = json.dig('ocs', 'data', 'url')
+ direct_download_url = json.dig("ocs", "data", "url")
return nil if direct_download_url.blank?
path = URI.parse(direct_download_url).path
return nil if path.blank?
- path.split('/').last
+ path.split("/").last
end
end
end
diff --git a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/file_ids_query.rb b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/file_ids_query.rb
index b5cd033310c9..65eece537c05 100644
--- a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/file_ids_query.rb
+++ b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/file_ids_query.rb
@@ -38,7 +38,7 @@ def self.call(storage:, path:)
def call(path:)
query_params = {
- depth: '1',
+ depth: "1",
path:,
props: %w[oc:fileid]
}
diff --git a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/file_info_query.rb b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/file_info_query.rb
index 98c97fcb6a8a..f01c030fbf79 100644
--- a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/file_info_query.rb
+++ b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/file_info_query.rb
@@ -32,7 +32,7 @@ module Storages::Peripherals::StorageInteraction::Nextcloud
class FileInfoQuery
using Storages::Peripherals::ServiceResultRefinements
- FILE_INFO_PATH = 'ocs/v1.php/apps/integration_openproject/fileinfo'
+ FILE_INFO_PATH = "ocs/v1.php/apps/integration_openproject/fileinfo"
def initialize(storage)
@uri = storage.uri
@@ -54,20 +54,20 @@ def call(user:, file_id:)
def file_info(file_id, token)
response = OpenProject
.httpx
- .with(headers: { 'Authorization' => "Bearer #{token.access_token}",
- 'Accept' => 'application/json',
- 'OCS-APIRequest' => 'true' })
+ .with(headers: { "Authorization" => "Bearer #{token.access_token}",
+ "Accept" => "application/json",
+ "OCS-APIRequest" => "true" })
.get(Util.join_uri_path(@uri, FILE_INFO_PATH, file_id))
case response
in { status: 200..299 }
ServiceResult.success(result: response.body)
in { status: 404 }
- Util.error(:not_found, 'Outbound request destination not found!', response)
+ Util.error(:not_found, "Outbound request destination not found!", response)
in { status: 401 }
- Util.error(:unauthorized, 'Outbound request not authorized!', response)
+ Util.error(:unauthorized, "Outbound request not authorized!", response)
else
- Util.error(:error, 'Outbound request failed!')
+ Util.error(:error, "Outbound request failed!")
end
end
@@ -85,11 +85,11 @@ def handle_failure
when 200..299
ServiceResult.success(result: response_object)
when 403
- Util.error(:forbidden, 'Access to storage file forbidden!', response_object)
+ Util.error(:forbidden, "Access to storage file forbidden!", response_object)
when 404
- Util.error(:not_found, 'Storage file not found!', response_object)
+ Util.error(:not_found, "Storage file not found!", response_object)
else
- Util.error(:error, 'Outbound request failed!', response_object)
+ Util.error(:error, "Outbound request failed!", response_object)
end
end
end
@@ -123,9 +123,9 @@ def create_storage_file_info
# rubocop:enable Metrics/AbcSize
def location(file_path)
- prefix = 'files/'
+ prefix = "files/"
idx = file_path.rindex(prefix)
- return '/' if idx == nil
+ return "/" if idx == nil
idx += prefix.length - 1
diff --git a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/files_info_query.rb b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/files_info_query.rb
index 6b423df3fd86..929e27e06aa8 100644
--- a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/files_info_query.rb
+++ b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/files_info_query.rb
@@ -32,7 +32,7 @@ module Storages::Peripherals::StorageInteraction::Nextcloud
class FilesInfoQuery
using Storages::Peripherals::ServiceResultRefinements
- FILES_INFO_PATH = 'ocs/v1.php/apps/integration_openproject/filesinfo'
+ FILES_INFO_PATH = "ocs/v1.php/apps/integration_openproject/filesinfo"
def initialize(storage)
@uri = storage.uri
@@ -45,7 +45,7 @@ def self.call(storage:, user:, file_ids: [])
def call(user:, file_ids: [])
if file_ids.nil?
- return Util.error(:error, 'File IDs can not be nil', file_ids)
+ return Util.error(:error, "File IDs can not be nil", file_ids)
end
if file_ids.empty?
@@ -62,10 +62,10 @@ def call(user:, file_ids: [])
def files_info(file_ids, token)
response = OpenProject
.httpx
- .with(headers: { 'Authorization' => "Bearer #{token.access_token}",
- 'Accept' => 'application/json',
- 'Content-Type' => 'application/json',
- 'OCS-APIRequest' => 'true' })
+ .with(headers: { "Authorization" => "Bearer #{token.access_token}",
+ "Accept" => "application/json",
+ "Content-Type" => "application/json",
+ "OCS-APIRequest" => "true" })
.post(Util.join_uri_path(@uri.to_s, FILES_INFO_PATH),
json: { fileIds: file_ids })
@@ -73,11 +73,11 @@ def files_info(file_ids, token)
in { status: 200..299 }
ServiceResult.success(result: response.body.to_s)
in { status: 404 }
- Util.error(:not_found, 'Outbound request destination not found!', response)
+ Util.error(:not_found, "Outbound request destination not found!", response)
in { status: 401 }
- Util.error(:unauthorized, 'Outbound request not authorized!', response)
+ Util.error(:unauthorized, "Outbound request not authorized!", response)
else
- Util.error(:error, 'Outbound request failed!', response)
+ Util.error(:error, "Outbound request failed!", response)
end
end
@@ -91,10 +91,10 @@ def parse_json
def handle_failure
->(response_object) do
- if response_object.ocs.meta.status == 'ok'
+ if response_object.ocs.meta.status == "ok"
ServiceResult.success(result: response_object)
else
- Util.error(:error, 'Outbound request failed!', response_object)
+ Util.error(:error, "Outbound request failed!", response_object)
end
end
end
@@ -137,14 +137,14 @@ def create_storage_file_infos
# rubocop:enable Metrics/AbcSize
def location(file_path, mimetype)
- prefix = 'files/'
+ prefix = "files/"
idx = file_path.rindex(prefix)
- return '/' if idx == nil
+ return "/" if idx == nil
idx += prefix.length - 1
# Remove the following when /filesinfo starts responding with a trailing slash for directory paths
# in all supported versions of OpenProjectIntegation Nextcloud App.
- file_path << '/' if mimetype == 'application/x-op-directory' && file_path[-1] != '/'
+ file_path << "/" if mimetype == "application/x-op-directory" && file_path[-1] != "/"
Util.escape_path(file_path[idx..])
end
end
diff --git a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/folder_files_file_ids_deep_query.rb b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/folder_files_file_ids_deep_query.rb
index 71a5724dc144..21c2b7c901b7 100644
--- a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/folder_files_file_ids_deep_query.rb
+++ b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/folder_files_file_ids_deep_query.rb
@@ -35,7 +35,7 @@ def self.call(storage:, folder:)
.resolve("nextcloud.queries.propfind")
.call(
storage:,
- depth: 'infinity',
+ depth: "infinity",
path: folder.path,
# nc:acl-list is only required to avoid https://community.openproject.org/wp/49628. See comment #4.
props: %w[oc:fileid nc:acl-list]
diff --git a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/internal/propfind_query.rb b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/internal/propfind_query.rb
index 05d7585c3678..876ab27f04f8 100644
--- a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/internal/propfind_query.rb
+++ b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/internal/propfind_query.rb
@@ -76,14 +76,14 @@ def self.call(storage:, depth:, path:, props:)
# rubocop:disable Metrics/AbcSize
def call(depth:, path:, props:)
body = Nokogiri::XML::Builder.new do |xml|
- xml['d'].propfind(
- 'xmlns:d' => 'DAV:',
- 'xmlns:oc' => 'http://owncloud.org/ns',
- 'xmlns:nc' => 'http://nextcloud.org/ns'
+ xml["d"].propfind(
+ "xmlns:d" => "DAV:",
+ "xmlns:oc" => "http://owncloud.org/ns",
+ "xmlns:nc" => "http://nextcloud.org/ns"
) do
- xml['d'].prop do
+ xml["d"].prop do
props.each do |prop|
- namespace, property = prop.split(':')
+ namespace, property = prop.split(":")
xml[namespace].send(property)
end
end
@@ -98,7 +98,7 @@ def call(depth:, path:, props:)
"PROPFIND",
UTIL.join_uri_path(
@uri,
- 'remote.php/dav/files',
+ "remote.php/dav/files",
CGI.escapeURIComponent(@username),
UTIL.escape_path(path)
),
@@ -111,7 +111,7 @@ def call(depth:, path:, props:)
in { status: 200..299 }
doc = Nokogiri::XML(response.body.to_s)
result = {}
- doc.xpath('/d:multistatus/d:response').each do |resource_section|
+ doc.xpath("/d:multistatus/d:response").each do |resource_section|
resource = CGI.unescape(resource_section.xpath("d:href").text.strip)
.gsub!(UTIL.join_uri_path(@uri.path, "/remote.php/dav/files/#{@username}/"), "")
@@ -126,13 +126,13 @@ def call(depth:, path:, props:)
ServiceResult.success(result:)
in { status: 405 }
- UTIL.error(:not_allowed, 'Outbound request method not allowed', error_data)
+ UTIL.error(:not_allowed, "Outbound request method not allowed", error_data)
in { status: 401 }
- UTIL.error(:unauthorized, 'Outbound request not authorized', error_data)
+ UTIL.error(:unauthorized, "Outbound request not authorized", error_data)
in { status: 404 }
- UTIL.error(:not_found, 'Outbound request destination not found', error_data)
+ UTIL.error(:not_found, "Outbound request destination not found", error_data)
else
- UTIL.error(:error, 'Outbound request failed', error_data)
+ UTIL.error(:error, "Outbound request failed", error_data)
end
end
diff --git a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/open_storage_query.rb b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/open_storage_query.rb
index 2aed80596f86..a512135ea1df 100644
--- a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/open_storage_query.rb
+++ b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/open_storage_query.rb
@@ -43,7 +43,7 @@ def self.call(storage:, user:)
# rubocop:disable Lint/UnusedMethodArgument
def call(user:)
- ServiceResult.success(result: Util.join_uri_path(@uri, 'index.php/apps/files'))
+ ServiceResult.success(result: Util.join_uri_path(@uri, "index.php/apps/files"))
end
# rubocop:enable Lint/UnusedMethodArgument
diff --git a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/remove_user_from_group_command.rb b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/remove_user_from_group_command.rb
index 1972ed3e43ef..167dbc50557b 100644
--- a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/remove_user_from_group_command.rb
+++ b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/remove_user_from_group_command.rb
@@ -46,7 +46,7 @@ def call(user:, group: @group)
response = OpenProject
.httpx
.basic_auth(@username, @password)
- .with(headers: { 'OCS-APIRequest' => 'true' })
+ .with(headers: { "OCS-APIRequest" => "true" })
.delete(
Util.join_uri_path(@uri,
"ocs/v1.php/cloud/users",
@@ -58,7 +58,7 @@ def call(user:, group: @group)
case response
in { status: 200..299 }
- statuscode = Nokogiri::XML(response.body.to_s).xpath('/ocs/meta/statuscode').text
+ statuscode = Nokogiri::XML(response.body.to_s).xpath("/ocs/meta/statuscode").text
case statuscode
when "100"
ServiceResult.success(message: "User has been removed from group")
@@ -71,19 +71,19 @@ def call(user:, group: @group)
when "104"
Util.error(:error, "Insufficient privileges", error_data)
when "105"
- message = Nokogiri::XML(response.body).xpath('/ocs/meta/message').text
+ message = Nokogiri::XML(response.body).xpath("/ocs/meta/message").text
Util.error(:error, "Failed to remove user #{user} from group #{group}: #{message}", error_data)
end
in { status: 405 }
- Util.error(:not_allowed, 'Outbound request method not allowed', error_data)
+ Util.error(:not_allowed, "Outbound request method not allowed", error_data)
in { status: 401 }
- Util.error(:unauthorized, 'Outbound request not authorized', error_data)
+ Util.error(:unauthorized, "Outbound request not authorized", error_data)
in { status: 404 }
- Util.error(:not_found, 'Outbound request destination not found', error_data)
+ Util.error(:not_found, "Outbound request destination not found", error_data)
in { status: 409 }
Util.error(:conflict, Util.error_text_from_response(response), error_data)
else
- Util.error(:error, 'Outbound request failed', error_data)
+ Util.error(:error, "Outbound request failed", error_data)
end
end
diff --git a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/rename_file_command.rb b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/rename_file_command.rb
index 9d8434a41dbf..12f4da101eec 100644
--- a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/rename_file_command.rb
+++ b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/rename_file_command.rb
@@ -51,7 +51,7 @@ def call(source:, target:)
"MOVE",
Util.join_uri_path(@base_path, Util.escape_path(source)),
headers: {
- 'Destination' => Util.join_uri_path(@uri.path,
+ "Destination" => Util.join_uri_path(@uri.path,
"remote.php/dav/files",
CGI.escapeURIComponent(@username),
Util.escape_path(target))
@@ -64,11 +64,11 @@ def call(source:, target:)
in { status: 200..299 }
ServiceResult.success
in { status: 404 }
- Util.error(:not_found, 'Outbound request destination not found', error_data)
+ Util.error(:not_found, "Outbound request destination not found", error_data)
in { status: 401 }
- Util.error(:unauthorized, 'Outbound request not authorized', error_data)
+ Util.error(:unauthorized, "Outbound request not authorized", error_data)
else
- Util.error(:error, 'Outbound request failed', error_data)
+ Util.error(:error, "Outbound request failed", error_data)
end
end
end
diff --git a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/set_permissions_command.rb b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/set_permissions_command.rb
index 6f4d01e0f17b..09f239dd6d99 100644
--- a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/set_permissions_command.rb
+++ b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/set_permissions_command.rb
@@ -51,27 +51,27 @@ def call(path:, permissions:)
groups_permissions = permissions.fetch(:groups)
body = Nokogiri::XML::Builder.new do |xml|
- xml['d'].propertyupdate(
- 'xmlns:d' => 'DAV:',
- 'xmlns:nc' => 'http://nextcloud.org/ns'
+ xml["d"].propertyupdate(
+ "xmlns:d" => "DAV:",
+ "xmlns:nc" => "http://nextcloud.org/ns"
) do
- xml['d'].set do
- xml['d'].prop do
- xml['nc'].send(:'acl-list') do
+ xml["d"].set do
+ xml["d"].prop do
+ xml["nc"].send(:"acl-list") do
groups_permissions.each do |group, group_permissions|
- xml['nc'].acl do
- xml['nc'].send(:'acl-mapping-type', 'group')
- xml['nc'].send(:'acl-mapping-id', group)
- xml['nc'].send(:'acl-mask', '31')
- xml['nc'].send(:'acl-permissions', group_permissions.to_s)
+ xml["nc"].acl do
+ xml["nc"].send(:"acl-mapping-type", "group")
+ xml["nc"].send(:"acl-mapping-id", group)
+ xml["nc"].send(:"acl-mask", "31")
+ xml["nc"].send(:"acl-permissions", group_permissions.to_s)
end
end
users_permissions.each do |user, user_permissions|
- xml['nc'].acl do
- xml['nc'].send(:'acl-mapping-type', 'user')
- xml['nc'].send(:'acl-mapping-id', user)
- xml['nc'].send(:'acl-mask', '31')
- xml['nc'].send(:'acl-permissions', user_permissions.to_s)
+ xml["nc"].acl do
+ xml["nc"].send(:"acl-mapping-type", "user")
+ xml["nc"].send(:"acl-mapping-id", user)
+ xml["nc"].send(:"acl-mask", "31")
+ xml["nc"].send(:"acl-permissions", user_permissions.to_s)
end
end
end
@@ -103,11 +103,11 @@ def call(path:, permissions:)
Util.error(:error, "nc:acl properly has not been set for #{path}", error_data)
end
in { status: 404 }
- Util.error(:not_found, 'Outbound request destination not found', error_data)
+ Util.error(:not_found, "Outbound request destination not found", error_data)
in { status: 401 }
- Util.error(:unauthorized, 'Outbound request not authorized', error_data)
+ Util.error(:unauthorized, "Outbound request not authorized", error_data)
else
- Util.error(:error, 'Outbound request failed', error_data)
+ Util.error(:error, "Outbound request failed", error_data)
end
end
diff --git a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/upload_link_query.rb b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/upload_link_query.rb
index 3bd35834a489..256dd3711e62 100644
--- a/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/upload_link_query.rb
+++ b/modules/storages/app/common/storages/peripherals/storage_interaction/nextcloud/upload_link_query.rb
@@ -32,8 +32,8 @@ module Storages::Peripherals::StorageInteraction::Nextcloud
class UploadLinkQuery
using Storages::Peripherals::ServiceResultRefinements
- URI_TOKEN_REQUEST = 'index.php/apps/integration_openproject/direct-upload-token'
- URI_UPLOAD_BASE_PATH = 'index.php/apps/integration_openproject/direct-upload'
+ URI_TOKEN_REQUEST = "index.php/apps/integration_openproject/direct-upload-token"
+ URI_UPLOAD_BASE_PATH = "index.php/apps/integration_openproject/direct-upload"
def initialize(storage)
@uri = storage.uri
@@ -46,12 +46,12 @@ def self.call(storage:, user:, data:)
def call(user:, data:)
Util.token(user:, configuration: @configuration) do |token|
- if data.nil? || data['parent'].nil?
- Util.error(:error, 'Data is invalid', data)
+ if data.nil? || data["parent"].nil?
+ Util.error(:error, "Data is invalid", data)
else
outbound_response(
relative_path: URI_TOKEN_REQUEST,
- payload: { folder_id: data['parent'] },
+ payload: { folder_id: data["parent"] },
token:
).map do |response|
Storages::UploadLink.new(
@@ -67,9 +67,9 @@ def call(user:, data:)
def outbound_response(relative_path:, payload:, token:)
response = OpenProject
.httpx
- .with(headers: { 'Authorization' => "Bearer #{token.access_token}",
- 'Accept' => 'application/json',
- 'Content-Type' => 'application/json' })
+ .with(headers: { "Authorization" => "Bearer #{token.access_token}",
+ "Accept" => "application/json",
+ "Content-Type" => "application/json" })
.post(
Util.join_uri_path(@uri, relative_path),
json: payload
@@ -82,14 +82,14 @@ def outbound_response(relative_path:, payload:, token:)
result: JSON.parse(response.body.to_s, object_class: OpenStruct) # rubocop:disable Style/OpenStructUse
)
else
- Util.error(:unauthorized, 'Outbound request not authorized!')
+ Util.error(:unauthorized, "Outbound request not authorized!")
end
in { status: 404 }
- Util.error(:not_found, 'Outbound request destination not found!', response)
+ Util.error(:not_found, "Outbound request destination not found!", response)
in { status: 401 }
- Util.error(:unauthorized, 'Outbound request not authorized!', response)
+ Util.error(:unauthorized, "Outbound request not authorized!", response)
else
- Util.error(:error, 'Outbound request failed!')
+ Util.error(:error, "Outbound request failed!")
end
end
end
diff --git a/modules/storages/app/common/storages/peripherals/storage_parent_folder_extractor.rb b/modules/storages/app/common/storages/peripherals/storage_parent_folder_extractor.rb
index 5469199df27f..5a38f9e8ac60 100644
--- a/modules/storages/app/common/storages/peripherals/storage_parent_folder_extractor.rb
+++ b/modules/storages/app/common/storages/peripherals/storage_parent_folder_extractor.rb
@@ -35,7 +35,7 @@ def initialize(path)
end
def root?
- @path == '/'
+ @path == "/"
end
def to_s
@@ -45,7 +45,7 @@ def to_s
module StorageParentFolderExtractor
def extract_parent_folder(params)
- ParentFolder.new(params[:parent].presence || '/')
+ ParentFolder.new(params[:parent].presence || "/")
end
end
end
diff --git a/modules/storages/app/components/storages/admin/forms/automatically_managed_project_folders_form_component.rb b/modules/storages/app/components/storages/admin/forms/automatically_managed_project_folders_form_component.rb
index b513850f7162..d44c4d47015e 100644
--- a/modules/storages/app/components/storages/admin/forms/automatically_managed_project_folders_form_component.rb
+++ b/modules/storages/app/components/storages/admin/forms/automatically_managed_project_folders_form_component.rb
@@ -44,7 +44,7 @@ def form_url
def submit_button_options
{
label: submit_button_label,
- data: { 'storages--automatically-managed-project-folders-form-target': 'submitButton' }.tap do |data_hash|
+ data: { "storages--automatically-managed-project-folders-form-target": "submitButton" }.tap do |data_hash|
# For create action, break from Turbo Frame and follow full page redirect
data_hash[:turbo] = false if new_record?
end
@@ -91,8 +91,8 @@ def provider_credentials_instructions_link
render(
Primer::Beta::Link.new(
href: Storages::Peripherals::StorageInteraction::Nextcloud::Util.join_uri_path(storage.host,
- 'settings/admin/openproject'),
- target: '_blank'
+ "settings/admin/openproject"),
+ target: "_blank"
)
) { I18n.t("storages.instructions.#{storage.short_provider_type}.integration") }
end
diff --git a/modules/storages/app/components/storages/admin/forms/general_info_form_component.rb b/modules/storages/app/components/storages/admin/forms/general_info_form_component.rb
index 0c483823c2e6..e2799ad58107 100644
--- a/modules/storages/app/components/storages/admin/forms/general_info_form_component.rb
+++ b/modules/storages/app/components/storages/admin/forms/general_info_form_component.rb
@@ -49,7 +49,7 @@ def cancel_button_options
data: { turbo_stream: true } }.tap do |options_hash|
if storage.new_record?
options_hash[:data][:turbo_stream] = false
- options_hash[:target] = '_top' # Break out of Turbo Frame, follow full page redirect
+ options_hash[:target] = "_top" # Break out of Turbo Frame, follow full page redirect
end
end
end
@@ -92,15 +92,15 @@ def caption_for_provider_type(provider_type)
def information_for_one_drive_automatic_management
href = ::OpenProject::Static::Links[:storage_docs][:one_drive_drive_id_guide][:href]
I18n.t(
- 'storages.page_titles.managed_project_folders.one_drive_information',
- drive_id_link_text: render(Primer::Beta::Link.new(href:, target: '_blank')) do
- I18n.t('storages.instructions.one_drive.documentation_link_text')
+ "storages.page_titles.managed_project_folders.one_drive_information",
+ drive_id_link_text: render(Primer::Beta::Link.new(href:, target: "_blank")) do
+ I18n.t("storages.instructions.one_drive.documentation_link_text")
end
).html_safe
end
def application_link_text_for(href, link_text)
- render(Primer::Beta::Link.new(href:, target: '_blank')) { link_text }
+ render(Primer::Beta::Link.new(href:, target: "_blank")) { link_text }
end
end
end
diff --git a/modules/storages/app/components/storages/admin/forms/oauth_client_form_component.rb b/modules/storages/app/components/storages/admin/forms/oauth_client_form_component.rb
index 52c4dc0c293e..39da667990e3 100644
--- a/modules/storages/app/components/storages/admin/forms/oauth_client_form_component.rb
+++ b/modules/storages/app/components/storages/admin/forms/oauth_client_form_component.rb
@@ -55,15 +55,15 @@ def storage_provider_credentials_instructions
private
- def one_drive_integration_link(target: '_blank')
+ def one_drive_integration_link(target: "_blank")
href = ::OpenProject::Static::Links[:storage_docs][:one_drive_oauth_application][:href]
- render(Primer::Beta::Link.new(href:, target:)) { I18n.t('storages.instructions.one_drive.application_link_text') }
+ render(Primer::Beta::Link.new(href:, target:)) { I18n.t("storages.instructions.one_drive.application_link_text") }
end
- def nextcloud_integration_link(target: '_blank')
+ def nextcloud_integration_link(target: "_blank")
href = Storages::Peripherals::StorageInteraction::Nextcloud::Util
- .join_uri_path(storage.host, 'settings/admin/openproject')
- render(Primer::Beta::Link.new(href:, target:)) { I18n.t('storages.instructions.nextcloud.integration') }
+ .join_uri_path(storage.host, "settings/admin/openproject")
+ render(Primer::Beta::Link.new(href:, target:)) { I18n.t("storages.instructions.nextcloud.integration") }
end
def first_time_configuration?
diff --git a/modules/storages/app/components/storages/admin/health_status_component.rb b/modules/storages/app/components/storages/admin/health_status_component.rb
index 0df9492fb92e..0c2c31d041b5 100644
--- a/modules/storages/app/components/storages/admin/health_status_component.rb
+++ b/modules/storages/app/components/storages/admin/health_status_component.rb
@@ -36,7 +36,7 @@ class HealthStatusComponent < ApplicationComponent
# formatted manner. e.g. "Not found: Outbound request destination not found since 12/07/2023 03:45 PM"
def formatted_health_reason
"#{storage.health_reason_identifier.tr('_', ' ').strip.capitalize}: #{storage.health_reason_description} " +
- I18n.t('storages.health.since', datetime: helpers.format_time(storage.health_changed_at))
+ I18n.t("storages.health.since", datetime: helpers.format_time(storage.health_changed_at))
end
end
end
diff --git a/modules/storages/app/components/storages/admin/oauth_access_grant_nudge_modal_component.rb b/modules/storages/app/components/storages/admin/oauth_access_grant_nudge_modal_component.rb
index f52353c04da5..cfbd3ff4d80c 100644
--- a/modules/storages/app/components/storages/admin/oauth_access_grant_nudge_modal_component.rb
+++ b/modules/storages/app/components/storages/admin/oauth_access_grant_nudge_modal_component.rb
@@ -30,8 +30,8 @@
#
module Storages::Admin
class OAuthAccessGrantNudgeModalComponent < ApplicationComponent # rubocop:disable OpenProject/AddPreviewForViewComponent
- options dialog_id: 'storages--oauth-grant-nudge-modal-component',
- dialog_body_id: 'storages--oauth-grant-nudge-modal-body-component',
+ options dialog_id: "storages--oauth-grant-nudge-modal-component",
+ dialog_body_id: "storages--oauth-grant-nudge-modal-body-component",
authorized: false
attr_reader :project_storage
@@ -48,41 +48,41 @@ def render?
private
def confirm_button_text
- I18n.t('storages.oauth_grant_nudge_modal.confirm_button_label')
+ I18n.t("storages.oauth_grant_nudge_modal.confirm_button_label")
end
def title
if authorized
- I18n.t('storages.oauth_grant_nudge_modal.access_granted_screen_reader', storage: project_storage.storage.name)
+ I18n.t("storages.oauth_grant_nudge_modal.access_granted_screen_reader", storage: project_storage.storage.name)
else
- I18n.t('storages.oauth_grant_nudge_modal.title')
+ I18n.t("storages.oauth_grant_nudge_modal.title")
end
end
def waiting_title
- I18n.t('storages.oauth_grant_nudge_modal.requesting_access_to', storage: project_storage.storage.name)
+ I18n.t("storages.oauth_grant_nudge_modal.requesting_access_to", storage: project_storage.storage.name)
end
def cancel_button_text
if authorized
- I18n.t('button_close')
+ I18n.t("button_close")
else
- I18n.t('storages.oauth_grant_nudge_modal.cancel_button_label')
+ I18n.t("storages.oauth_grant_nudge_modal.cancel_button_label")
end
end
def body_text
if authorized
- success_title = I18n.t('storages.oauth_grant_nudge_modal.access_granted')
- success_subtitle = I18n.t('storages.oauth_grant_nudge_modal.storage_ready', storage: project_storage.storage.name)
+ success_title = I18n.t("storages.oauth_grant_nudge_modal.access_granted")
+ success_subtitle = I18n.t("storages.oauth_grant_nudge_modal.storage_ready", storage: project_storage.storage.name)
concat(render(Storages::OpenProjectStorageModalComponent::Body.new(:success, success_subtitle:, success_title:)))
else
- I18n.t('storages.oauth_grant_nudge_modal.body', storage: project_storage.storage.name)
+ I18n.t("storages.oauth_grant_nudge_modal.body", storage: project_storage.storage.name)
end
end
def confirm_button_aria_label
- I18n.t('storages.oauth_grant_nudge_modal.confirm_button_aria_label', storage: project_storage.storage.name)
+ I18n.t("storages.oauth_grant_nudge_modal.confirm_button_aria_label", storage: project_storage.storage.name)
end
def confirm_button_url
diff --git a/modules/storages/app/components/storages/admin/oauth_application_info_copy_component.rb b/modules/storages/app/components/storages/admin/oauth_application_info_copy_component.rb
index d5e9fe7e6c07..ca7390e835be 100644
--- a/modules/storages/app/components/storages/admin/oauth_application_info_copy_component.rb
+++ b/modules/storages/app/components/storages/admin/oauth_application_info_copy_component.rb
@@ -44,10 +44,10 @@ def oauth_application_details_link
render(
Primer::Beta::Link.new(
href: Storages::Peripherals::StorageInteraction::Nextcloud::Util.join_uri_path(storage.host,
- 'settings/admin/openproject'),
- target: '_blank'
+ "settings/admin/openproject"),
+ target: "_blank"
)
- ) { I18n.t('storages.instructions.oauth_application_details_link_text') }
+ ) { I18n.t("storages.instructions.oauth_application_details_link_text") }
end
def submit_button_options
diff --git a/modules/storages/app/components/storages/admin/oauth_client_info_component.rb b/modules/storages/app/components/storages/admin/oauth_client_info_component.rb
index 1db9fb9af2a6..0fe220a80a67 100644
--- a/modules/storages/app/components/storages/admin/oauth_client_info_component.rb
+++ b/modules/storages/app/components/storages/admin/oauth_client_info_component.rb
@@ -52,7 +52,7 @@ def edit_icon_button_options
scheme: :invisible,
aria: { label: },
data: edit_icon_button_data_options,
- test_selector: 'storage-edit-oauth-client-button'
+ test_selector: "storage-edit-oauth-client-button"
}
end
@@ -62,7 +62,7 @@ def edit_icon_button_data_options
{}.tap do |data_h|
if oauth_client_configured?
provider_type = I18n.t("storages.provider_types.#{storage.short_provider_type}.name")
- data_h[:confirm] = I18n.t('storages.confirm_replace_oauth_client', provider_type:)
+ data_h[:confirm] = I18n.t("storages.confirm_replace_oauth_client", provider_type:)
end
data_h[:turbo_stream] = true
end
diff --git a/modules/storages/app/components/storages/admin/redirect_uri_component.rb b/modules/storages/app/components/storages/admin/redirect_uri_component.rb
index 6f5d5f5dbd53..48c0f5777ec9 100644
--- a/modules/storages/app/components/storages/admin/redirect_uri_component.rb
+++ b/modules/storages/app/components/storages/admin/redirect_uri_component.rb
@@ -48,7 +48,7 @@ def show_icon_button_options
href: url_helpers.show_redirect_uri_admin_settings_storage_oauth_client_path(storage),
scheme: :invisible,
aria: { label: I18n.t("storages.label_show_storage_redirect_uri") },
- test_selector: 'storage-show-redirect-uri-button'
+ test_selector: "storage-show-redirect-uri-button"
}
end
end
diff --git a/modules/storages/app/components/storages/admin/row_component.rb b/modules/storages/app/components/storages/admin/row_component.rb
index bba7d8ecd875..29b8bd83e4d2 100644
--- a/modules/storages/app/components/storages/admin/row_component.rb
+++ b/modules/storages/app/components/storages/admin/row_component.rb
@@ -48,10 +48,10 @@ def name
if configured?
storage.name
else
- render(Primer::Beta::Octicon.new(:'alert-fill', size: :small, color: :severe)) +
+ render(Primer::Beta::Octicon.new(:"alert-fill", size: :small, color: :severe)) +
content_tag(:span,
storage.name,
- class: 'pl-2')
+ class: "pl-2")
end
end
@@ -65,18 +65,18 @@ def button_links
end
def delete_link
- link_to '',
+ link_to "",
admin_settings_storage_path(storage),
- class: 'icon icon-delete',
- data: { confirm: I18n.t('storages.delete_warning.storage') },
+ class: "icon icon-delete",
+ data: { confirm: I18n.t("storages.delete_warning.storage") },
title: I18n.t(:button_delete),
method: :delete
end
def edit_link
- link_to '',
+ link_to "",
edit_admin_settings_storage_path(storage),
- class: 'icon icon-edit',
+ class: "icon icon-edit",
accesskey: helpers.accesskey(:edit),
title: I18n.t(:button_edit)
end
diff --git a/modules/storages/app/components/storages/admin/storage_view_information.rb b/modules/storages/app/components/storages/admin/storage_view_information.rb
index c971ff0f34ab..880c5a064240 100644
--- a/modules/storages/app/components/storages/admin/storage_view_information.rb
+++ b/modules/storages/app/components/storages/admin/storage_view_information.rb
@@ -11,7 +11,7 @@ def editable_storage?
def storage_description
[I18n.t("storages.provider_types.#{storage.short_provider_type}.name"),
storage.name,
- storage.host].compact.join(' - ')
+ storage.host].compact.join(" - ")
end
def configuration_check_label
@@ -27,9 +27,9 @@ def configuration_check_label_for(*configs)
return if storage.configuration_checks.values.none?
if storage.configuration_checks.slice(*configs.map(&:to_sym)).values.all?
- status_label(I18n.t('storages.label_completed'), scheme: :success, test_selector: "label-#{configs.join('-')}-status")
+ status_label(I18n.t("storages.label_completed"), scheme: :success, test_selector: "label-#{configs.join('-')}-status")
else
- status_label(I18n.t('storages.label_incomplete'), scheme: :attention, test_selector: "label-#{configs.join('-')}-status")
+ status_label(I18n.t("storages.label_incomplete"), scheme: :attention, test_selector: "label-#{configs.join('-')}-status")
end
end
@@ -41,14 +41,14 @@ def automatically_managed_project_folders_status_label
# do not show the status label, if storage is completely empty (initial state)
return if storage.configuration_checks.values.none?
- test_selector = 'label-managed-project-folders-status'
+ test_selector = "label-managed-project-folders-status"
if storage.automatic_management_enabled?
- status_label(I18n.t('storages.label_active'), scheme: :success, test_selector:)
+ status_label(I18n.t("storages.label_active"), scheme: :success, test_selector:)
elsif storage.automatic_management_unspecified?
- status_label(I18n.t('storages.label_incomplete'), scheme: :attention, test_selector:)
+ status_label(I18n.t("storages.label_incomplete"), scheme: :attention, test_selector:)
else
- status_label(I18n.t('storages.label_inactive'), scheme: :secondary, test_selector:)
+ status_label(I18n.t("storages.label_inactive"), scheme: :secondary, test_selector:)
end
end
diff --git a/modules/storages/app/components/storages/admin/table_component.rb b/modules/storages/app/components/storages/admin/table_component.rb
index ff17ecd5f74b..dd845d427629 100644
--- a/modules/storages/app/components/storages/admin/table_component.rb
+++ b/modules/storages/app/components/storages/admin/table_component.rb
@@ -52,25 +52,25 @@ def sortable?
# Purpose: return the link to be used to create the storage
def inline_create_link
link_to(new_admin_settings_storage_path,
- class: 'wp-inline-create--add-link',
- title: I18n.t('storages.label_new_storage')) do
- helpers.op_icon('icon icon-add')
+ class: "wp-inline-create--add-link",
+ title: I18n.t("storages.label_new_storage")) do
+ helpers.op_icon("icon icon-add")
end
end
# Show this pretty message if there are now Storages::Storage objects in the system
def empty_row_message
- I18n.t 'storages.no_results'
+ I18n.t "storages.no_results"
end
# Definition of the table header using the keys from columns above.
def headers
[
- ['name', { caption: ::Storages::Storage.human_attribute_name(:name) }],
- ['provider_type', { caption: I18n.t('storages.provider_types.label') }],
- ['host', { caption: I18n.t('storages.label_host') }],
- ['creator', { caption: I18n.t('storages.label_creator') }],
- ['created_at', { caption: ::Storages::Storage.human_attribute_name(:created_at) }]
+ ["name", { caption: ::Storages::Storage.human_attribute_name(:name) }],
+ ["provider_type", { caption: I18n.t("storages.provider_types.label") }],
+ ["host", { caption: I18n.t("storages.label_host") }],
+ ["creator", { caption: I18n.t("storages.label_creator") }],
+ ["created_at", { caption: ::Storages::Storage.human_attribute_name(:created_at) }]
]
end
end
diff --git a/modules/storages/app/components/storages/open_project_storage_modal_component.rb b/modules/storages/app/components/storages/open_project_storage_modal_component.rb
index 802f120ef4c1..6a7c740c7c2d 100644
--- a/modules/storages/app/components/storages/open_project_storage_modal_component.rb
+++ b/modules/storages/app/components/storages/open_project_storage_modal_component.rb
@@ -27,10 +27,10 @@
class Storages::OpenProjectStorageModalComponent < ViewComponent::Base
def initialize(project_storage_open_url:, redirect_url:, state:, **options)
super
- controller = 'storages--open-project-storage-modal'
+ controller = "storages--open-project-storage-modal"
@data = {
controller:,
- 'application-target': 'dynamic',
+ "application-target": "dynamic",
"#{controller}-project-storage-open-url-value": project_storage_open_url,
"#{controller}-redirect-url-value": redirect_url
}
@@ -38,10 +38,10 @@ def initialize(project_storage_open_url:, redirect_url:, state:, **options)
end
def self.dialog_id
- 'open-project-storage-modal-component'
+ "open-project-storage-modal-component"
end
def self.dialog_body_id
- 'open-project-storage-modal-body-component'
+ "open-project-storage-modal-body-component"
end
end
diff --git a/modules/storages/app/components/storages/open_project_storage_modal_component/body.rb b/modules/storages/app/components/storages/open_project_storage_modal_component/body.rb
index 007277da7c3f..0b856713f408 100644
--- a/modules/storages/app/components/storages/open_project_storage_modal_component/body.rb
+++ b/modules/storages/app/components/storages/open_project_storage_modal_component/body.rb
@@ -25,10 +25,10 @@
#++
class Storages::OpenProjectStorageModalComponent::Body < ApplicationComponent # rubocop:disable OpenProject/AddPreviewForViewComponent
- options success_title: I18n.t('storages.open_project_storage_modal.success.title'),
- success_subtitle: I18n.t('storages.open_project_storage_modal.success.subtitle'),
- waiting_title: I18n.t('storages.open_project_storage_modal.waiting.title'),
- waiting_subtitle: I18n.t('storages.open_project_storage_modal.waiting.subtitle')
+ options success_title: I18n.t("storages.open_project_storage_modal.success.title"),
+ success_subtitle: I18n.t("storages.open_project_storage_modal.success.subtitle"),
+ waiting_title: I18n.t("storages.open_project_storage_modal.waiting.title"),
+ waiting_subtitle: I18n.t("storages.open_project_storage_modal.waiting.subtitle")
def initialize(state, **options)
@state = state
diff --git a/modules/storages/app/components/storages/project_storages/members/row_component.rb b/modules/storages/app/components/storages/project_storages/members/row_component.rb
index 4b7587a5a460..62196a7274eb 100644
--- a/modules/storages/app/components/storages/project_storages/members/row_component.rb
+++ b/modules/storages/app/components/storages/project_storages/members/row_component.rb
@@ -57,12 +57,12 @@ def status
oauth_client_id: storage.oauth_client.client_id,
storage_id: storage.id
)
- helpers.op_icon('icon-warning -warning') +
+ helpers.op_icon("icon-warning -warning") +
content_tag(
:span,
I18n.t("storages.member_connection_status.not_connected",
link: link_to(I18n.t("link"), ensure_connection_url),
- class: 'pl-2').html_safe
+ class: "pl-2").html_safe
)
else
I18n.t("storages.member_connection_status.#{connection_result}")
diff --git a/modules/storages/app/components/storages/project_storages/members/table_component.rb b/modules/storages/app/components/storages/project_storages/members/table_component.rb
index 12cec49d6c20..216ed20ad323 100644
--- a/modules/storages/app/components/storages/project_storages/members/table_component.rb
+++ b/modules/storages/app/components/storages/project_storages/members/table_component.rb
@@ -48,13 +48,13 @@ def sortable?
end
def empty_row_message
- I18n.t 'storages.members_no_results'
+ I18n.t "storages.members_no_results"
end
def headers
[
- ['name', { caption: I18n.t('storages.label_name') }],
- ['status', { caption: I18n.t('storages.label_status') }]
+ ["name", { caption: I18n.t("storages.label_name") }],
+ ["status", { caption: I18n.t("storages.label_status") }]
]
end
end
diff --git a/modules/storages/app/components/storages/project_storages/row_component.rb b/modules/storages/app/components/storages/project_storages/row_component.rb
index cc52af6c0022..a7e897ce79c8 100644
--- a/modules/storages/app/components/storages/project_storages/row_component.rb
+++ b/modules/storages/app/components/storages/project_storages/row_component.rb
@@ -57,24 +57,24 @@ def button_links
end
def members_connection_status_link
- link_to '',
+ link_to "",
project_settings_project_storage_members_path(project_id: project_storage.project,
project_storage_id: project_storage),
- class: 'icon icon-group',
- title: I18n.t(:'storages.page_titles.project_settings.members_connection_status')
+ class: "icon icon-group",
+ title: I18n.t(:"storages.page_titles.project_settings.members_connection_status")
end
def edit_link
- link_to '',
+ link_to "",
edit_project_settings_project_storage_path(project_id: project_storage.project, id: project_storage),
- class: 'icon icon-edit',
+ class: "icon icon-edit",
title: I18n.t(:button_edit)
end
def delete_link
- link_to '',
+ link_to "",
confirm_destroy_project_settings_project_storage_path(project_id: project_storage.project, id: project_storage),
- class: 'icon icon-delete',
+ class: "icon icon-delete",
title: I18n.t(:button_delete),
method: :get
end
diff --git a/modules/storages/app/components/storages/project_storages/table_component.rb b/modules/storages/app/components/storages/project_storages/table_component.rb
index bfc3fdf342f0..2af55d240329 100644
--- a/modules/storages/app/components/storages/project_storages/table_component.rb
+++ b/modules/storages/app/components/storages/project_storages/table_component.rb
@@ -48,22 +48,22 @@ def sortable?
def inline_create_link
link_to(new_project_settings_project_storage_path,
- class: 'wp-inline-create--add-link',
- title: I18n.t('storages.label_new_storage')) do
- helpers.op_icon('icon icon-add')
+ class: "wp-inline-create--add-link",
+ title: I18n.t("storages.label_new_storage")) do
+ helpers.op_icon("icon icon-add")
end
end
def empty_row_message
- I18n.t 'storages.no_results'
+ I18n.t "storages.no_results"
end
def headers
[
- ['name', { caption: ::Storages::Storage.human_attribute_name(:name) }],
- ['provider_type', { caption: I18n.t('storages.provider_types.label') }],
- ['creator', { caption: I18n.t('storages.label_creator') }],
- ['created_at', { caption: ::Storages::ProjectStorage.human_attribute_name(:created_at) }]
+ ["name", { caption: ::Storages::Storage.human_attribute_name(:name) }],
+ ["provider_type", { caption: I18n.t("storages.provider_types.label") }],
+ ["creator", { caption: I18n.t("storages.label_creator") }],
+ ["created_at", { caption: ::Storages::ProjectStorage.human_attribute_name(:created_at) }]
]
end
end
diff --git a/modules/storages/app/constants/storages/admin.rb b/modules/storages/app/constants/storages/admin.rb
index 28785d3c3a21..a155896ede2f 100644
--- a/modules/storages/app/constants/storages/admin.rb
+++ b/modules/storages/app/constants/storages/admin.rb
@@ -30,10 +30,10 @@
module Storages
module Admin
- LABEL_OAUTH_CLIENT_ID = 'OAuth Client ID'
- LABEL_OAUTH_CLIENT_SECRET = 'OAuth Client Secret'
- LABEL_OAUTH_REDIRECT_URI = 'OAuth Redirect URI'
- LABEL_TENANT_ID = 'Tenant ID'
- LABEL_DRIVE_ID = 'Drive ID'
+ LABEL_OAUTH_CLIENT_ID = "OAuth Client ID"
+ LABEL_OAUTH_CLIENT_SECRET = "OAuth Client Secret"
+ LABEL_OAUTH_REDIRECT_URI = "OAuth Redirect URI"
+ LABEL_TENANT_ID = "Tenant ID"
+ LABEL_DRIVE_ID = "Drive ID"
end
end
diff --git a/modules/storages/app/contracts/storages/file_links/create_contract.rb b/modules/storages/app/contracts/storages/file_links/create_contract.rb
index 153ea0148aa8..e58444430475 100644
--- a/modules/storages/app/contracts/storages/file_links/create_contract.rb
+++ b/modules/storages/app/contracts/storages/file_links/create_contract.rb
@@ -85,7 +85,7 @@ def validate_project_storage_link
def require_ee_token_for_one_drive
if model.storage && ::Storages::Storage.one_drive_without_ee_token?(model.storage.provider_type)
- errors.add(:base, I18n.t('api_v3.errors.code_500_missing_enterprise_token'))
+ errors.add(:base, I18n.t("api_v3.errors.code_500_missing_enterprise_token"))
end
end
end
diff --git a/modules/storages/app/contracts/storages/storages/base_contract.rb b/modules/storages/app/contracts/storages/storages/base_contract.rb
index a880f005c37b..96508041aed9 100644
--- a/modules/storages/app/contracts/storages/storages/base_contract.rb
+++ b/modules/storages/app/contracts/storages/storages/base_contract.rb
@@ -28,8 +28,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'net/http'
-require 'uri'
+require "net/http"
+require "uri"
# Purpose: common functionalities shared by CreateContract and UpdateContract
# UpdateService by default checks if UpdateContract exists
@@ -70,7 +70,7 @@ def provider_type_strategy
def require_ee_token_for_one_drive
if ::Storages::Storage.one_drive_without_ee_token?(provider_type)
- errors.add(:base, I18n.t('api_v3.errors.code_500_missing_enterprise_token'))
+ errors.add(:base, I18n.t("api_v3.errors.code_500_missing_enterprise_token"))
end
end
end
diff --git a/modules/storages/app/contracts/storages/storages/nextcloud_contract.rb b/modules/storages/app/contracts/storages/storages/nextcloud_contract.rb
index feca633ea9de..304ddcbfcc56 100644
--- a/modules/storages/app/contracts/storages/storages/nextcloud_contract.rb
+++ b/modules/storages/app/contracts/storages/storages/nextcloud_contract.rb
@@ -31,7 +31,7 @@
module Storages::Storages
class NextcloudContract < ::ModelContract
attribute :host
- validates :host, url: { message: I18n.t('activerecord.errors.messages.invalid_url') }, length: { maximum: 255 }
+ validates :host, url: { message: I18n.t("activerecord.errors.messages.invalid_url") }, length: { maximum: 255 }
# Check that a host actually is a storage server.
# But only do so if the validations above for URL were successful.
validates :host, secure_context_uri: true, nextcloud_compatible_host: true, unless: -> { errors.include?(:host) }
diff --git a/modules/storages/app/controllers/storages/admin/automatically_managed_project_folders_controller.rb b/modules/storages/app/controllers/storages/admin/automatically_managed_project_folders_controller.rb
index 5fe20d91ec2c..34fedfb06b74 100644
--- a/modules/storages/app/controllers/storages/admin/automatically_managed_project_folders_controller.rb
+++ b/modules/storages/app/controllers/storages/admin/automatically_managed_project_folders_controller.rb
@@ -33,7 +33,7 @@
#
class Storages::Admin::AutomaticallyManagedProjectFoldersController < ApplicationController
# See https://guides.rubyonrails.org/layouts_and_rendering.html for reference on layout
- layout 'admin'
+ layout "admin"
# Before executing any action below: Make sure the current user is an admin
# and set the @ variable to the object referenced in the URL.
@@ -65,7 +65,7 @@ def new
.result
respond_to do |format|
- format.html { render '/storages/admin/storages/automatically_managed_project_folders/edit' }
+ format.html { render "/storages/admin/storages/automatically_managed_project_folders/edit" }
format.turbo_stream { render :edit }
end
end
@@ -75,13 +75,13 @@ def create
if service_result.success?
flash[:primer_banner] = {
- message: I18n.t(:'storages.notice_successful_storage_connection'),
+ message: I18n.t(:"storages.notice_successful_storage_connection"),
scheme: :success
}
redirect_to admin_settings_storages_path
else
respond_to do |format|
- format.html { render '/storages/admin/storages/automatically_managed_project_folders/edit' }
+ format.html { render "/storages/admin/storages/automatically_managed_project_folders/edit" }
format.turbo_stream
end
end
@@ -92,7 +92,7 @@ def create
# Called by: Global app/config/routes.rb to serve Web page
def edit
respond_to do |format|
- format.html { render '/storages/admin/storages/automatically_managed_project_folders/edit' }
+ format.html { render "/storages/admin/storages/automatically_managed_project_folders/edit" }
format.turbo_stream
end
end
@@ -106,7 +106,7 @@ def update
if service_result.success?
redirect_to edit_admin_settings_storage_path(@storage)
else
- render '/storages/admin/storages/automatically_managed_project_folders/edit'
+ render "/storages/admin/storages/automatically_managed_project_folders/edit"
end
end
@@ -144,7 +144,7 @@ def permitted_storage_params_with_defaults
permitted_storage_params.tap do |permitted_params|
# If a checkbox is unchecked when its form is submitted, neither the name nor the value is submitted to the server.
# See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/checkbox
- permitted_params.merge!(automatic_management_enabled: false) unless permitted_params.key?('automatic_management_enabled')
+ permitted_params.merge!(automatic_management_enabled: false) unless permitted_params.key?("automatic_management_enabled")
end
end
@@ -153,6 +153,6 @@ def permitted_storage_params_with_defaults
def permitted_storage_params
params
.require(:storages_nextcloud_storage)
- .permit('automatic_management_enabled', 'password')
+ .permit("automatic_management_enabled", "password")
end
end
diff --git a/modules/storages/app/controllers/storages/admin/oauth_clients_controller.rb b/modules/storages/app/controllers/storages/admin/oauth_clients_controller.rb
index f7d1f35c11a5..a1a5667c80ff 100644
--- a/modules/storages/app/controllers/storages/admin/oauth_clients_controller.rb
+++ b/modules/storages/app/controllers/storages/admin/oauth_clients_controller.rb
@@ -30,7 +30,7 @@
class Storages::Admin::OAuthClientsController < ApplicationController
# See https://guides.rubyonrails.org/layouts_and_rendering.html for reference on layout
- layout 'admin'
+ layout "admin"
# Before executing any action below: Make sure the current user is an admin
# and set the @ variable to the object referenced in the URL.
@@ -116,7 +116,7 @@ def show_redirect_uri
end
def finish_setup
- flash[:primer_banner] = { message: I18n.t(:'storages.notice_successful_storage_connection'), scheme: :success }
+ flash[:primer_banner] = { message: I18n.t(:"storages.notice_successful_storage_connection"), scheme: :success }
redirect_to admin_settings_storages_path
end
@@ -147,7 +147,7 @@ def prepare_storage_for_automatic_management_form
def oauth_client_params
params
.require(:oauth_client)
- .permit('client_id', 'client_secret')
+ .permit("client_id", "client_secret")
end
def find_storage
diff --git a/modules/storages/app/controllers/storages/admin/storages_controller.rb b/modules/storages/app/controllers/storages/admin/storages_controller.rb
index 5359107e29fb..7491bd2c6bd7 100644
--- a/modules/storages/app/controllers/storages/admin/storages_controller.rb
+++ b/modules/storages/app/controllers/storages/admin/storages_controller.rb
@@ -34,7 +34,7 @@ class Storages::Admin::StoragesController < ApplicationController
include FlashMessagesHelper
# See https://guides.rubyonrails.org/layouts_and_rendering.html for reference on layout
- layout 'admin'
+ layout "admin"
# specify which model #find_model_object should look up
model_object Storages::Storage
@@ -198,7 +198,7 @@ def replace_oauth_application
# Breadcrumbs is something like OpenProject > Admin > Storages.
# This returns the name of the last part (Storages admin page)
def default_breadcrumb
- if action_name == 'index'
+ if action_name == "index"
t(:project_module_storages)
else
ActionController::Base.helpers.link_to(t(:project_module_storages), admin_settings_storages_path)
@@ -216,7 +216,7 @@ def show_local_breadcrumb
def ensure_valid_provider_type_selected
short_provider_type = params[:provider]
if short_provider_type.blank? || (@provider_type = ::Storages::Storage::PROVIDER_TYPE_SHORT_NAMES[short_provider_type]).blank?
- flash[:primer_banner] = { message: I18n.t('storages.error_invalid_provider_type'), scheme: :danger }
+ flash[:primer_banner] = { message: I18n.t("storages.error_invalid_provider_type"), scheme: :danger }
redirect_to admin_settings_storages_path
end
end
@@ -230,14 +230,14 @@ def oauth_application(service_result)
def permitted_storage_params(model_parameter_name = storage_provider_parameter_name)
params
.require(model_parameter_name)
- .permit('name',
- 'provider_type',
- 'host',
- 'oauth_client_id',
- 'oauth_client_secret',
- 'tenant_id',
- 'drive_id',
- 'automatic_management_enabled')
+ .permit("name",
+ "provider_type",
+ "host",
+ "oauth_client_id",
+ "oauth_client_secret",
+ "tenant_id",
+ "drive_id",
+ "automatic_management_enabled")
end
def storage_provider_parameter_name
diff --git a/modules/storages/app/controllers/storages/project_settings/project_storage_members_controller.rb b/modules/storages/app/controllers/storages/project_settings/project_storage_members_controller.rb
index 730279e39add..f5f7de107e66 100644
--- a/modules/storages/app/controllers/storages/project_settings/project_storage_members_controller.rb
+++ b/modules/storages/app/controllers/storages/project_settings/project_storage_members_controller.rb
@@ -44,11 +44,11 @@ def index
.includes(:principal, :oauth_client_tokens, roles: :role_permissions)
.paginate(page: page_param, per_page: per_page_param)
- render '/storages/project_settings/project_storage_members/index'
+ render "/storages/project_settings/project_storage_members/index"
end
def default_breadcrumb
- t(:'storages.page_titles.project_settings.members_connection_status')
+ t(:"storages.page_titles.project_settings.members_connection_status")
end
def show_local_breadcrumb
diff --git a/modules/storages/app/controllers/storages/project_storages_controller.rb b/modules/storages/app/controllers/storages/project_storages_controller.rb
index ade361d55ebb..f210a5c28549 100644
--- a/modules/storages/app/controllers/storages/project_storages_controller.rb
+++ b/modules/storages/app/controllers/storages/project_storages_controller.rb
@@ -110,7 +110,7 @@ def redirect_to_project_overview_with_modal
project_overview_path(project_id: @project.identifier),
flash: {
modal: {
- type: 'Storages::OpenProjectStorageModalComponent',
+ type: "Storages::OpenProjectStorageModalComponent",
parameters: {
project_storage_open_url: request.path,
redirect_url: api_v3_project_storage_open,
diff --git a/modules/storages/app/forms/storages/admin/managed_project_folders/application_password_input.rb b/modules/storages/app/forms/storages/admin/managed_project_folders/application_password_input.rb
index 780a63cd8e5c..2825ea15ccce 100644
--- a/modules/storages/app/forms/storages/admin/managed_project_folders/application_password_input.rb
+++ b/modules/storages/app/forms/storages/admin/managed_project_folders/application_password_input.rb
@@ -31,7 +31,7 @@ class ApplicationPasswordInput < ApplicationForm
form do |application_password_form|
application_password_form.text_field(
name: :password,
- label: I18n.t(:'storages.label_managed_project_folders.application_password'),
+ label: I18n.t(:"storages.label_managed_project_folders.application_password"),
required: true,
caption: application_password_caption,
value: nil, # IMPORTANT: We don't want to show the password in the form
@@ -48,7 +48,7 @@ def initialize(storage:)
private
def application_password_caption
- I18n.t(:'storages.instructions.managed_project_folders_application_password_caption',
+ I18n.t(:"storages.instructions.managed_project_folders_application_password_caption",
provider_type_link:).html_safe
end
@@ -56,8 +56,8 @@ def provider_type_link
render(
Primer::Beta::Link.new(
href: Storages::Peripherals::StorageInteraction::Nextcloud::Util.join_uri_path(@storage.host,
- 'settings/admin/openproject'),
- target: '_blank'
+ "settings/admin/openproject"),
+ target: "_blank"
)
) { I18n.t("storages.instructions.#{@storage.short_provider_type}.integration") }
end
diff --git a/modules/storages/app/forms/storages/admin/managed_project_folders/automatic_management_checkbox.rb b/modules/storages/app/forms/storages/admin/managed_project_folders/automatic_management_checkbox.rb
index cfc7d0e54f38..ac6ff8742cf6 100644
--- a/modules/storages/app/forms/storages/admin/managed_project_folders/automatic_management_checkbox.rb
+++ b/modules/storages/app/forms/storages/admin/managed_project_folders/automatic_management_checkbox.rb
@@ -31,11 +31,11 @@ class AutomaticManagementCheckbox < ApplicationForm
form do |automatic_management_form|
automatic_management_form.check_box(
name: :automatic_management_enabled,
- label: I18n.t(:'storages.label_managed_project_folders.automatically_managed_folders'),
+ label: I18n.t(:"storages.label_managed_project_folders.automatically_managed_folders"),
checked: @storage.automatic_management_enabled?,
required: true,
data: {
- action: 'change->storages--automatically-managed-project-folders-form#updateDisplay'
+ action: "change->storages--automatically-managed-project-folders-form#updateDisplay"
}
)
end
diff --git a/modules/storages/app/forms/storages/admin/oauth_client_form.rb b/modules/storages/app/forms/storages/admin/oauth_client_form.rb
index 58304f42ad78..3883dd6587bf 100644
--- a/modules/storages/app/forms/storages/admin/oauth_client_form.rb
+++ b/modules/storages/app/forms/storages/admin/oauth_client_form.rb
@@ -63,7 +63,7 @@ def default_client_secret_input_options
def provider_default_client_secret_input_options
{}.tap do |options_h|
if @storage.provider_type_one_drive?
- options_h[:caption] = I18n.t('storages.instructions.one_drive.oauth_client_secret')
+ options_h[:caption] = I18n.t("storages.instructions.one_drive.oauth_client_secret")
end
end
end
diff --git a/modules/storages/app/forms/storages/admin/provider_drive_id_input_form.rb b/modules/storages/app/forms/storages/admin/provider_drive_id_input_form.rb
index 0d53b78c5147..8ead4f90e7d3 100644
--- a/modules/storages/app/forms/storages/admin/provider_drive_id_input_form.rb
+++ b/modules/storages/app/forms/storages/admin/provider_drive_id_input_form.rb
@@ -43,9 +43,9 @@ class ProviderDriveIdInputForm < ApplicationForm
def caption
href = ::OpenProject::Static::Links[:storage_docs][:one_drive_drive_id_guide][:href]
- I18n.t('storages.instructions.one_drive.drive_id',
- drive_id_link_text: render(Primer::Beta::Link.new(href:, target: '_blank')) do
- I18n.t('storages.instructions.one_drive.documentation_link_text')
+ I18n.t("storages.instructions.one_drive.drive_id",
+ drive_id_link_text: render(Primer::Beta::Link.new(href:, target: "_blank")) do
+ I18n.t("storages.instructions.one_drive.documentation_link_text")
end)
end
end
diff --git a/modules/storages/app/forms/storages/admin/provider_host_input_form.rb b/modules/storages/app/forms/storages/admin/provider_host_input_form.rb
index 0e91e5215957..43decb9dff4e 100644
--- a/modules/storages/app/forms/storages/admin/provider_host_input_form.rb
+++ b/modules/storages/app/forms/storages/admin/provider_host_input_form.rb
@@ -31,13 +31,13 @@ class ProviderHostInputForm < ApplicationForm
form do |storage_form|
storage_form.text_field(
name: :host,
- label: I18n.t('activerecord.attributes.storages/storage.host'),
+ label: I18n.t("activerecord.attributes.storages/storage.host"),
visually_hide_label: false,
required: true,
type: :url,
pattern: ".{1,255}",
placeholder: "https://my-file-storage.com",
- caption: I18n.t('storages.instructions.host'),
+ caption: I18n.t("storages.instructions.host"),
input_width: :large
)
end
diff --git a/modules/storages/app/forms/storages/admin/provider_name_input_form.rb b/modules/storages/app/forms/storages/admin/provider_name_input_form.rb
index 5144ba6ad5a8..374d6ccf6e3b 100644
--- a/modules/storages/app/forms/storages/admin/provider_name_input_form.rb
+++ b/modules/storages/app/forms/storages/admin/provider_name_input_form.rb
@@ -31,9 +31,9 @@ class ProviderNameInputForm < ApplicationForm
form do |storage_form|
storage_form.text_field(
name: :name,
- label: I18n.t('activerecord.attributes.storages/storage.name'),
+ label: I18n.t("activerecord.attributes.storages/storage.name"),
required: true,
- caption: I18n.t('storages.instructions.name'),
+ caption: I18n.t("storages.instructions.name"),
placeholder: I18n.t("storages.label_file_storage"),
input_width: :large
)
diff --git a/modules/storages/app/forms/storages/admin/provider_tenant_id_input_form.rb b/modules/storages/app/forms/storages/admin/provider_tenant_id_input_form.rb
index 553f1536f733..8fc69ef10374 100644
--- a/modules/storages/app/forms/storages/admin/provider_tenant_id_input_form.rb
+++ b/modules/storages/app/forms/storages/admin/provider_tenant_id_input_form.rb
@@ -31,11 +31,11 @@ class ProviderTenantIdInputForm < ApplicationForm
form do |storage_form|
storage_form.text_field(
name: :tenant_id,
- label: I18n.t('activerecord.attributes.storages/storage.tenant'),
+ label: I18n.t("activerecord.attributes.storages/storage.tenant"),
visually_hide_label: false,
required: true,
caption: caption.html_safe, # rubocop:disable Rails/OutputSafety
- placeholder: I18n.t('storages.instructions.one_drive.tenant_id_placeholder'),
+ placeholder: I18n.t("storages.instructions.one_drive.tenant_id_placeholder"),
input_width: :large
)
end
@@ -44,9 +44,9 @@ class ProviderTenantIdInputForm < ApplicationForm
def caption
href = ::OpenProject::Static::Links[:storage_docs][:one_drive_oauth_application][:href]
- I18n.t('storages.instructions.one_drive.tenant_id',
- application_link_text: render(Primer::Beta::Link.new(href:, target: '_blank')) do
- I18n.t('storages.instructions.one_drive.application_link_text')
+ I18n.t("storages.instructions.one_drive.tenant_id",
+ application_link_text: render(Primer::Beta::Link.new(href:, target: "_blank")) do
+ I18n.t("storages.instructions.one_drive.application_link_text")
end)
end
end
diff --git a/modules/storages/app/forms/storages/admin/provider_type_hidden_input_form.rb b/modules/storages/app/forms/storages/admin/provider_type_hidden_input_form.rb
index 00d72f3c3b72..df10652002bd 100644
--- a/modules/storages/app/forms/storages/admin/provider_type_hidden_input_form.rb
+++ b/modules/storages/app/forms/storages/admin/provider_type_hidden_input_form.rb
@@ -31,7 +31,7 @@ class ProviderTypeHiddenInputForm < ApplicationForm
form do |storage_form|
storage_form.hidden(
name: :provider_type,
- label: I18n.t('activerecord.attributes.storages/storage.provider_type'),
+ label: I18n.t("activerecord.attributes.storages/storage.provider_type"),
required: true,
value: @storage.provider_type
)
diff --git a/modules/storages/app/forms/storages/admin/submit_or_cancel_form.rb b/modules/storages/app/forms/storages/admin/submit_or_cancel_form.rb
index 064961e92fc4..5504347b3c3c 100644
--- a/modules/storages/app/forms/storages/admin/submit_or_cancel_form.rb
+++ b/modules/storages/app/forms/storages/admin/submit_or_cancel_form.rb
@@ -48,7 +48,7 @@ def default_submit_button_options
{
name: :submit,
scheme: :primary,
- label: I18n.t('storages.buttons.save_and_continue'),
+ label: I18n.t("storages.buttons.save_and_continue"),
disabled: false
}
end
@@ -59,7 +59,7 @@ def default_cancel_button_options
scheme: :default,
tag: :a,
href: OpenProject::StaticRouting::StaticRouter.new.url_helpers.admin_settings_storages_path,
- label: I18n.t('button_cancel')
+ label: I18n.t("button_cancel")
}
end
end
diff --git a/modules/storages/app/models/queries/storages/file_links/filter/storage_filter.rb b/modules/storages/app/models/queries/storages/file_links/filter/storage_filter.rb
index 8bf46c738bb6..929f8049521b 100644
--- a/modules/storages/app/models/queries/storages/file_links/filter/storage_filter.rb
+++ b/modules/storages/app/models/queries/storages/file_links/filter/storage_filter.rb
@@ -43,7 +43,7 @@ def allowed_values
end
def where
- operator_strategy.sql_for_field(values, ::Storages::FileLink.table_name, 'storage_id')
+ operator_strategy.sql_for_field(values, ::Storages::FileLink.table_name, "storage_id")
end
end
end
diff --git a/modules/storages/app/models/queries/storages/project_storages/filter/storage_url_filter.rb b/modules/storages/app/models/queries/storages/project_storages/filter/storage_url_filter.rb
index cfb7d558abc2..b381e33f22b0 100644
--- a/modules/storages/app/models/queries/storages/project_storages/filter/storage_url_filter.rb
+++ b/modules/storages/app/models/queries/storages/project_storages/filter/storage_url_filter.rb
@@ -49,13 +49,13 @@ def joins
end
def where
- operator_strategy.sql_for_field(unescape_hosts(values), Storages::Storage.table_name, 'host')
+ operator_strategy.sql_for_field(unescape_hosts(values), Storages::Storage.table_name, "host")
end
private
def unescape_hosts(hosts)
- hosts.map { |host| CGI.unescape(host).gsub(/\/+$/, '') }
+ hosts.map { |host| CGI.unescape(host).gsub(/\/+$/, "") }
end
end
end
diff --git a/modules/storages/app/models/queries/storages/projects/filter/storage_id_filter.rb b/modules/storages/app/models/queries/storages/projects/filter/storage_id_filter.rb
index f0ad24f67199..4f6b9a1ea4ee 100644
--- a/modules/storages/app/models/queries/storages/projects/filter/storage_id_filter.rb
+++ b/modules/storages/app/models/queries/storages/projects/filter/storage_id_filter.rb
@@ -34,7 +34,7 @@ class StorageIdFilter < ::Queries::Projects::Filters::ProjectFilter
private
def filter_column
- 'id'
+ "id"
end
end
end
diff --git a/modules/storages/app/models/queries/storages/projects/filter/storage_url_filter.rb b/modules/storages/app/models/queries/storages/projects/filter/storage_url_filter.rb
index ad5ffc066e95..9345b6895b81 100644
--- a/modules/storages/app/models/queries/storages/projects/filter/storage_url_filter.rb
+++ b/modules/storages/app/models/queries/storages/projects/filter/storage_url_filter.rb
@@ -34,11 +34,11 @@ class StorageUrlFilter < ::Queries::Projects::Filters::ProjectFilter
private
def filter_column
- 'host'
+ "host"
end
def where_values
- values.map { |host| CGI.unescape(host).gsub(/\/+$/, '') }
+ values.map { |host| CGI.unescape(host).gsub(/\/+$/, "") }
end
end
end
diff --git a/modules/storages/app/models/queries/storages/work_packages/filter/file_link_origin_id_filter.rb b/modules/storages/app/models/queries/storages/work_packages/filter/file_link_origin_id_filter.rb
index 3f0162c41267..d09d351b7b33 100644
--- a/modules/storages/app/models/queries/storages/work_packages/filter/file_link_origin_id_filter.rb
+++ b/modules/storages/app/models/queries/storages/work_packages/filter/file_link_origin_id_filter.rb
@@ -35,7 +35,7 @@ def filter_model
end
def filter_column
- 'origin_id'
+ "origin_id"
end
def permission
diff --git a/modules/storages/app/models/queries/storages/work_packages/filter/linkable_to_storage_id_filter.rb b/modules/storages/app/models/queries/storages/work_packages/filter/linkable_to_storage_id_filter.rb
index ca5bbcd169a6..bccc401daf6b 100644
--- a/modules/storages/app/models/queries/storages/work_packages/filter/linkable_to_storage_id_filter.rb
+++ b/modules/storages/app/models/queries/storages/work_packages/filter/linkable_to_storage_id_filter.rb
@@ -35,7 +35,7 @@ def filter_model
end
def filter_column
- 'id'
+ "id"
end
def permission
diff --git a/modules/storages/app/models/queries/storages/work_packages/filter/linkable_to_storage_url_filter.rb b/modules/storages/app/models/queries/storages/work_packages/filter/linkable_to_storage_url_filter.rb
index 0e48e89526bd..f2c590de89ff 100644
--- a/modules/storages/app/models/queries/storages/work_packages/filter/linkable_to_storage_url_filter.rb
+++ b/modules/storages/app/models/queries/storages/work_packages/filter/linkable_to_storage_url_filter.rb
@@ -35,7 +35,7 @@ def filter_model
end
def filter_column
- 'host'
+ "host"
end
def permission
diff --git a/modules/storages/app/models/queries/storages/work_packages/filter/storage_id_filter.rb b/modules/storages/app/models/queries/storages/work_packages/filter/storage_id_filter.rb
index 0bd491f516bc..5fb70bbb4503 100644
--- a/modules/storages/app/models/queries/storages/work_packages/filter/storage_id_filter.rb
+++ b/modules/storages/app/models/queries/storages/work_packages/filter/storage_id_filter.rb
@@ -35,7 +35,7 @@ def filter_model
end
def filter_column
- 'storage_id'
+ "storage_id"
end
def permission
diff --git a/modules/storages/app/models/queries/storages/work_packages/filter/storage_url_filter.rb b/modules/storages/app/models/queries/storages/work_packages/filter/storage_url_filter.rb
index 865fecb2918f..dbdca749c340 100644
--- a/modules/storages/app/models/queries/storages/work_packages/filter/storage_url_filter.rb
+++ b/modules/storages/app/models/queries/storages/work_packages/filter/storage_url_filter.rb
@@ -35,7 +35,7 @@ def filter_model
end
def filter_column
- 'host'
+ "host"
end
def permission
diff --git a/modules/storages/app/models/queries/storages/work_packages/filter/storages_filter_mixin.rb b/modules/storages/app/models/queries/storages/work_packages/filter/storages_filter_mixin.rb
index 49827f6b74f5..0ece5f3f4107 100644
--- a/modules/storages/app/models/queries/storages/work_packages/filter/storages_filter_mixin.rb
+++ b/modules/storages/app/models/queries/storages/work_packages/filter/storages_filter_mixin.rb
@@ -68,7 +68,7 @@ def where_values
end
def additional_where_condition
- ''
+ ""
end
def joins
@@ -76,6 +76,6 @@ def joins
end
def unescape_hosts(hosts)
- hosts.map { |host| CGI.unescape(host).gsub(/\/+$/, '') }
+ hosts.map { |host| CGI.unescape(host).gsub(/\/+$/, "") }
end
end
diff --git a/modules/storages/app/models/storages/file_link.rb b/modules/storages/app/models/storages/file_link.rb
index 150f7eaa6d7b..caa3a54e5817 100644
--- a/modules/storages/app/models/storages/file_link.rb
+++ b/modules/storages/app/models/storages/file_link.rb
@@ -31,7 +31,7 @@
# FileLinks are attached to a "container", which currently has to be a WorkPackage.
class Storages::FileLink < ApplicationRecord
belongs_to :storage
- belongs_to :creator, class_name: 'User'
+ belongs_to :creator, class_name: "User"
belongs_to :container, polymorphic: true
validates :container_type, inclusion: { in: ["WorkPackage", nil] }
diff --git a/modules/storages/app/models/storages/last_project_folder.rb b/modules/storages/app/models/storages/last_project_folder.rb
index 613ad557caa2..8fb475940a30 100644
--- a/modules/storages/app/models/storages/last_project_folder.rb
+++ b/modules/storages/app/models/storages/last_project_folder.rb
@@ -27,7 +27,7 @@
#++
class Storages::LastProjectFolder < ApplicationRecord
- belongs_to :project_storage, class_name: 'Storages::ProjectStorage'
+ belongs_to :project_storage, class_name: "Storages::ProjectStorage"
- enum mode: { inactive: 'inactive', manual: 'manual', automatic: 'automatic' }.freeze
+ enum mode: { inactive: "inactive", manual: "manual", automatic: "automatic" }.freeze
end
diff --git a/modules/storages/app/models/storages/nextcloud_storage.rb b/modules/storages/app/models/storages/nextcloud_storage.rb
index 174321671979..6121dff82b3f 100644
--- a/modules/storages/app/models/storages/nextcloud_storage.rb
+++ b/modules/storages/app/models/storages/nextcloud_storage.rb
@@ -32,7 +32,7 @@ module Storages
class NextcloudStorage < Storage
PROVIDER_FIELDS_DEFAULTS = {
automatic_management_enabled: true,
- username: 'OpenProject'
+ username: "OpenProject"
}.freeze
store_attribute :provider_fields, :automatically_managed, :boolean
@@ -48,7 +48,7 @@ def oauth_configuration
def automatic_management_new_record?
if provider_fields_changed?
previous_configuration = provider_fields_change.first
- previous_configuration.values_at('automatically_managed', 'password').compact.empty?
+ previous_configuration.values_at("automatically_managed", "password").compact.empty?
else
automatic_management_unspecified?
end
diff --git a/modules/storages/app/models/storages/one_drive_storage.rb b/modules/storages/app/models/storages/one_drive_storage.rb
index 57e2fc90f500..5365da2b2914 100644
--- a/modules/storages/app/models/storages/one_drive_storage.rb
+++ b/modules/storages/app/models/storages/one_drive_storage.rb
@@ -52,7 +52,7 @@ def oauth_configuration
end
def uri
- @uri ||= URI('https://graph.microsoft.com').normalize
+ @uri ||= URI("https://graph.microsoft.com").normalize
end
def connect_src
diff --git a/modules/storages/app/models/storages/project_storage.rb b/modules/storages/app/models/storages/project_storage.rb
index 8e9563377f06..46ec7b7fde47 100644
--- a/modules/storages/app/models/storages/project_storage.rb
+++ b/modules/storages/app/models/storages/project_storage.rb
@@ -33,23 +33,23 @@ class ProjectStorage < ApplicationRecord
using Peripherals::ServiceResultRefinements
belongs_to :project, touch: true
- belongs_to :storage, touch: true, class_name: 'Storages::Storage'
- belongs_to :creator, class_name: 'User'
+ belongs_to :storage, touch: true, class_name: "Storages::Storage"
+ belongs_to :creator, class_name: "User"
has_many :last_project_folders,
- class_name: 'Storages::LastProjectFolder',
+ class_name: "Storages::LastProjectFolder",
dependent: :destroy
# There should be only one ProjectStorage per project and storage.
validates :project, uniqueness: { scope: :storage }
enum project_folder_mode: {
- inactive: 'inactive',
- manual: 'manual',
- automatic: 'automatic'
- }.freeze, _prefix: 'project_folder'
+ inactive: "inactive",
+ manual: "manual",
+ automatic: "automatic"
+ }.freeze, _prefix: "project_folder"
- scope :automatic, -> { where(project_folder_mode: 'automatic') }
+ scope :automatic, -> { where(project_folder_mode: "automatic") }
scope :active, -> { joins(:project).where(project: { active: true }) }
scope :active_automatically_managed, -> do
automatic
@@ -95,7 +95,7 @@ def open_with_connection_ensured
url_helpers = OpenProject::StaticRouting::StaticRouter.new.url_helpers
open_project_storage_url = url_helpers.open_project_storage_url(
host: Setting.host_name,
- protocol: 'https',
+ protocol: "https",
project_id: project.identifier,
id:
)
diff --git a/modules/storages/app/models/storages/storage_file_info.rb b/modules/storages/app/models/storages/storage_file_info.rb
index ccc1dddf772f..2e0397f24ab3 100644
--- a/modules/storages/app/models/storages/storage_file_info.rb
+++ b/modules/storages/app/models/storages/storage_file_info.rb
@@ -81,7 +81,7 @@ def initialize(
end
def self.from_id(file_id)
- new(id: file_id, status: 'OK', status_code: 200)
+ new(id: file_id, status: "OK", status_code: 200)
end
end
end
diff --git a/modules/storages/app/models/storages/upload_link.rb b/modules/storages/app/models/storages/upload_link.rb
index f6d26ffd38c3..7e27db1c4934 100644
--- a/modules/storages/app/models/storages/upload_link.rb
+++ b/modules/storages/app/models/storages/upload_link.rb
@@ -29,7 +29,7 @@
class Storages::UploadLink
attr_reader :destination, :method
- def initialize(destination = '', method = :post)
+ def initialize(destination = "", method = :post)
@destination = destination
@method = method
end
diff --git a/modules/storages/app/services/storages/nextcloud_group_folder_properties_sync_service.rb b/modules/storages/app/services/storages/nextcloud_group_folder_properties_sync_service.rb
index 4b1202e9fe13..9b59079297ab 100644
--- a/modules/storages/app/services/storages/nextcloud_group_folder_properties_sync_service.rb
+++ b/modules/storages/app/services/storages/nextcloud_group_folder_properties_sync_service.rb
@@ -160,7 +160,7 @@ def project_tokens(project_storage)
def hide_inactive_folders(remote_folders)
project_folder_ids = active_project_storages_scope.pluck(:project_folder_id).compact
remote_folders.except("#{@storage.group_folder}/").each do |(path, attrs)|
- next if project_folder_ids.include?(attrs['fileid'])
+ next if project_folder_ids.include?(attrs["fileid"])
command_params = {
path:,
@@ -174,13 +174,13 @@ def hide_inactive_folders(remote_folders)
.resolve("nextcloud.commands.set_permissions")
.call(storage: @storage, **command_params)
.on_failure do |service_result|
- format_and_log_error(service_result.errors, folder: path, context: 'hide_folder')
+ format_and_log_error(service_result.errors, folder: path, context: "hide_folder")
end
end
end
def ensure_folders_exist(remote_folders)
- id_folder_map = remote_folders.to_h { |folder, properties| [properties['fileid'], folder] }
+ id_folder_map = remote_folders.to_h { |folder, properties| [properties["fileid"], folder] }
active_project_storages_scope.includes(:project).map do |project_storage|
next create_folder(project_storage) unless id_folder_map.key?(project_storage.project_folder_id)
@@ -220,7 +220,7 @@ def create_folder(project_storage)
end
folder_id_result = Peripherals::Registry
- .resolve('nextcloud.queries.file_ids')
+ .resolve("nextcloud.queries.file_ids")
.call(storage: @storage, path: folder_path)
.result_or do |error|
format_and_log_error(error, path:)
@@ -228,7 +228,7 @@ def create_folder(project_storage)
return ServiceResult.failure(errors: error)
end
- project_folder_id = folder_id_result.dig(folder_path, 'fileid')
+ project_folder_id = folder_id_result.dig(folder_path, "fileid")
last_project_folder = ::Storages::LastProjectFolder
.find_by(
project_storage_id: project_storage.id,
diff --git a/modules/storages/app/services/storages/oauth_applications/create_service.rb b/modules/storages/app/services/storages/oauth_applications/create_service.rb
index 87906bac1a8d..ff9a40ef9112 100644
--- a/modules/storages/app/services/storages/oauth_applications/create_service.rb
+++ b/modules/storages/app/services/storages/oauth_applications/create_service.rb
@@ -47,7 +47,7 @@ def call
.call({
name: "#{storage.name} (#{I18n.t("storages.provider_types.#{storage.short_provider_type}.name")})",
redirect_uri: File.join(storage.host, "index.php/apps/integration_openproject/oauth-redirect"),
- scopes: 'api_v3',
+ scopes: "api_v3",
confidential: true,
owner: storage.creator,
integration: storage
diff --git a/modules/storages/app/services/storages/one_drive_managed_folder_sync_service.rb b/modules/storages/app/services/storages/one_drive_managed_folder_sync_service.rb
index fdc349a39e14..96d0e917833b 100644
--- a/modules/storages/app/services/storages/one_drive_managed_folder_sync_service.rb
+++ b/modules/storages/app/services/storages/one_drive_managed_folder_sync_service.rb
@@ -75,7 +75,7 @@ def ensure_folders_exist(folder_map)
end
end
- ServiceResult.success(result: 'folders processed')
+ ServiceResult.success(result: "folders processed")
end
def hide_inactive_folders(folder_map)
@@ -84,7 +84,7 @@ def hide_inactive_folders(folder_map)
Peripherals::Registry.resolve("one_drive.commands.set_permissions")
.call(storage: @storage, path: item_id, permissions: { write: [], read: [] })
.on_failure do |service_result|
- format_and_log_error(service_result.errors, folder: path, context: 'hide_folder')
+ format_and_log_error(service_result.errors, folder: path, context: "hide_folder")
end
end
end
@@ -109,14 +109,14 @@ def set_permissions(path, permissions)
def rename_folder(source, target)
Peripherals::Registry
- .resolve('one_drive.commands.rename_file')
+ .resolve("one_drive.commands.rename_file")
.call(storage: @storage, source:, target:)
.result_or { |error| format_and_log_error(error, source:, target:) }
end
def create_folder(project_storage)
Peripherals::Registry
- .resolve('one_drive.commands.create_folder')
+ .resolve("one_drive.commands.create_folder")
.call(storage: @storage, folder_path: project_storage.managed_project_folder_path)
.match(on_failure: ->(error) { format_and_log_error(error, folder_path: project_storage.managed_project_folder_path) },
on_success: ->(folder_info) do
diff --git a/modules/storages/app/services/storages/storages/set_attributes_service.rb b/modules/storages/app/services/storages/storages/set_attributes_service.rb
index 62c2b46eaa22..f35f6d5ab58b 100644
--- a/modules/storages/app/services/storages/storages/set_attributes_service.rb
+++ b/modules/storages/app/services/storages/storages/set_attributes_service.rb
@@ -43,13 +43,13 @@ def set_attributes(params)
end
def remove_host_trailing_slashes
- storage.host = storage.host&.gsub(/\/+$/, '')
+ storage.host = storage.host&.gsub(/\/+$/, "")
end
def replace_empty_host_with_nil(params)
cloned_param = params.clone
- if cloned_param[:host] == ''
+ if cloned_param[:host] == ""
cloned_param[:host] = nil
end
diff --git a/modules/storages/app/validator/nextcloud_compatible_host_validator.rb b/modules/storages/app/validator/nextcloud_compatible_host_validator.rb
index 1b522a651006..e8b47b803f0b 100644
--- a/modules/storages/app/validator/nextcloud_compatible_host_validator.rb
+++ b/modules/storages/app/validator/nextcloud_compatible_host_validator.rb
@@ -41,7 +41,7 @@ def validate_each(contract, attribute, value)
private
def validate_capabilities(contract, attribute, value)
- uri = URI.parse(File.join(value, '/ocs/v2.php/cloud/capabilities'))
+ uri = URI.parse(File.join(value, "/ocs/v2.php/cloud/capabilities"))
response = OpenProject.httpx
.with(HTTPX_TIMEOUT_SETTINGS)
@@ -69,7 +69,7 @@ def check_capabilities_response(response)
# Apache strips that part of the request header by default.
# https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/oauth2.html
def validate_setup_completeness(contract, attribute, value)
- uri = URI.parse(File.join(value, 'index.php/apps/integration_openproject/check-config'))
+ uri = URI.parse(File.join(value, "index.php/apps/integration_openproject/check-config"))
response = OpenProject.httpx
.with(HTTPX_TIMEOUT_SETTINGS)
.get(uri, headers: { "Authorization" => AUTHORIZATION_HEADER })
@@ -117,13 +117,13 @@ def major_version_sufficient?(response)
end
def read_version(response)
- response.json.dig('ocs', 'data', 'version', 'major')
+ response.json.dig("ocs", "data", "version", "major")
rescue HTTPX::Error, MultiJson::ParseError
false
end
def read_authorization_header(response)
- response.json['authorization_header']
+ response.json["authorization_header"]
rescue HTTPX::Error, MultiJson::ParseError
nil
end
diff --git a/modules/storages/config/routes.rb b/modules/storages/config/routes.rb
index 523ed7a55e13..ff40cca7728d 100644
--- a/modules/storages/config/routes.rb
+++ b/modules/storages/config/routes.rb
@@ -31,14 +31,14 @@
Rails.application.routes.draw do
namespace :admin do
namespace :settings do
- resources :storages, controller: '/storages/admin/storages', except: [:show] do
- resource :oauth_client, controller: '/storages/admin/oauth_clients', only: %i[new create] do
+ resources :storages, controller: "/storages/admin/storages", except: [:show] do
+ resource :oauth_client, controller: "/storages/admin/oauth_clients", only: %i[new create] do
patch :update, on: :member
get :show_redirect_uri
post :finish_setup
end
- resource :automatically_managed_project_folders, controller: '/storages/admin/automatically_managed_project_folders',
+ resource :automatically_managed_project_folders, controller: "/storages/admin/automatically_managed_project_folders",
only: %i[new create edit update]
get :select_provider, on: :collection
@@ -55,21 +55,21 @@
end
end
- get 'projects/:project_id/project_storages/:id/open',
- controller: 'storages/project_storages',
- action: 'open',
- as: 'open_project_storage'
+ get "projects/:project_id/project_storages/:id/open",
+ controller: "storages/project_storages",
+ action: "open",
+ as: "open_project_storage"
- scope 'projects/:project_id', as: 'project' do
- namespace 'settings' do
- resources :project_storages, controller: '/storages/admin/project_storages', except: %i[show] do
+ scope "projects/:project_id", as: "project" do
+ namespace "settings" do
+ resources :project_storages, controller: "/storages/admin/project_storages", except: %i[show] do
member do
get :oauth_access_grant
# Destroy uses a get request to prompt the user before the actual DELETE request
- get :destroy_info, as: 'confirm_destroy'
+ get :destroy_info, as: "confirm_destroy"
end
- resources :members, controller: '/storages/project_settings/project_storage_members', only: %i[index]
+ resources :members, controller: "/storages/project_settings/project_storage_members", only: %i[index]
end
end
end
diff --git a/modules/storages/db/migrate/20220712165928_add_storages_permissions_to_roles.rb b/modules/storages/db/migrate/20220712165928_add_storages_permissions_to_roles.rb
index d55d13f12e2f..8a115eb3caad 100644
--- a/modules/storages/db/migrate/20220712165928_add_storages_permissions_to_roles.rb
+++ b/modules/storages/db/migrate/20220712165928_add_storages_permissions_to_roles.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require Rails.root.join('db/migrate/migration_utils/permission_adder')
+require Rails.root.join("db/migrate/migration_utils/permission_adder")
class AddStoragesPermissionsToRoles < ActiveRecord::Migration[6.1]
def up
diff --git a/modules/storages/db/migrate/20230420063148_add_provider_fields_to_storages.rb b/modules/storages/db/migrate/20230420063148_add_provider_fields_to_storages.rb
index 6fcf34f85424..c24a1b2faa6a 100644
--- a/modules/storages/db/migrate/20230420063148_add_provider_fields_to_storages.rb
+++ b/modules/storages/db/migrate/20230420063148_add_provider_fields_to_storages.rb
@@ -27,6 +27,6 @@
class AddProviderFieldsToStorages < ActiveRecord::Migration[7.0]
def change
- add_column :storages, :provider_fields, :jsonb, null: false, default: '{}'
+ add_column :storages, :provider_fields, :jsonb, null: false, default: "{}"
end
end
diff --git a/modules/storages/db/migrate/20230512153303_change_storage_provider_fields_default.rb b/modules/storages/db/migrate/20230512153303_change_storage_provider_fields_default.rb
index 53c653d50608..4f4c8411d454 100644
--- a/modules/storages/db/migrate/20230512153303_change_storage_provider_fields_default.rb
+++ b/modules/storages/db/migrate/20230512153303_change_storage_provider_fields_default.rb
@@ -27,7 +27,7 @@
class ChangeStorageProviderFieldsDefault < ActiveRecord::Migration[7.0]
def change
- change_column_default(:storages, :provider_fields, from: '{}', to: {})
+ change_column_default(:storages, :provider_fields, from: "{}", to: {})
reversible do |dir|
dir.up do
diff --git a/modules/storages/db/migrate/20230601082746_create_last_project_folders.rb b/modules/storages/db/migrate/20230601082746_create_last_project_folders.rb
index bad50f97161b..39dbf0705f73 100644
--- a/modules/storages/db/migrate/20230601082746_create_last_project_folders.rb
+++ b/modules/storages/db/migrate/20230601082746_create_last_project_folders.rb
@@ -29,7 +29,7 @@
class CreateLastProjectFolders < ActiveRecord::Migration[7.0]
def change
create_table :last_project_folders,
- comment: 'This table contains the last used project folder IDs for a project storage per mode.' do |t|
+ comment: "This table contains the last used project folder IDs for a project storage per mode." do |t|
t.references :projects_storage, null: false, foreign_key: { on_delete: :cascade }
t.string :origin_folder_id
t.enum :mode, enum_type: :project_folder_modes, default: :inactive, null: false
diff --git a/modules/storages/db/migrate/20231109080454_add_health_info_to_storages.rb b/modules/storages/db/migrate/20231109080454_add_health_info_to_storages.rb
index 76f953e1f927..d5ffab7a5bab 100644
--- a/modules/storages/db/migrate/20231109080454_add_health_info_to_storages.rb
+++ b/modules/storages/db/migrate/20231109080454_add_health_info_to_storages.rb
@@ -30,8 +30,8 @@ def up
execute <<-SQL.squish
CREATE TYPE storage_health_statuses AS ENUM ('pending', 'healthy', 'unhealthy');
SQL
- add_column(:storages, :health_status, :storage_health_statuses, null: false, default: 'pending')
- add_column(:storages, :health_changed_at, :datetime, null: false, default: -> { 'current_timestamp' })
+ add_column(:storages, :health_status, :storage_health_statuses, null: false, default: "pending")
+ add_column(:storages, :health_changed_at, :datetime, null: false, default: -> { "current_timestamp" })
add_column(:storages, :health_reason, :string)
end
diff --git a/modules/storages/db/migrate/20231208143303_add_health_checked_at_to_storages.rb b/modules/storages/db/migrate/20231208143303_add_health_checked_at_to_storages.rb
index 65c9b5f5497f..f874a875f8cd 100644
--- a/modules/storages/db/migrate/20231208143303_add_health_checked_at_to_storages.rb
+++ b/modules/storages/db/migrate/20231208143303_add_health_checked_at_to_storages.rb
@@ -1,6 +1,6 @@
class AddHealthCheckedAtToStorages < ActiveRecord::Migration[7.0]
def up
- add_column(:storages, :health_checked_at, :datetime, null: false, default: -> { 'current_timestamp' })
+ add_column(:storages, :health_checked_at, :datetime, null: false, default: -> { "current_timestamp" })
end
def down
diff --git a/modules/storages/lib/api/v3/file_links/file_link_representer.rb b/modules/storages/lib/api/v3/file_links/file_link_representer.rb
index 85bf00b127c0..d747a544322d 100644
--- a/modules/storages/lib/api/v3/file_links/file_link_representer.rb
+++ b/modules/storages/lib/api/v3/file_links/file_link_representer.rb
@@ -35,19 +35,19 @@ module API::V3::FileLinks
PERMISSION_LINKS = {
view_allowed: {
href: URN_PERMISSION_VIEW,
- title: 'View allowed'
+ title: "View allowed"
},
view_not_allowed: {
href: URN_PERMISSION_NOT_ALLOWED,
- title: 'View not allowed'
+ title: "View not allowed"
},
not_found: {
href: URN_STATUS_NOT_FOUND,
- title: 'Not found'
+ title: "Not found"
},
error: {
href: URN_STATUS_ERROR,
- title: 'Error'
+ title: "Error"
}
}.freeze
@@ -118,9 +118,9 @@ class FileLinkRepresenter < ::API::Decorators::Single
skip_render: ->(*) { true },
getter: ->(*) {},
setter: ->(fragment:, **) {
- break if fragment['href'].blank?
+ break if fragment["href"].blank?
- canonical_url = fragment['href'].gsub(/\/+$/, '')
+ canonical_url = fragment["href"].gsub(/\/+$/, "")
represented.storage = ::Storages::Storage.find_by(host: canonical_url)
represented.storage ||= ::Storages::Storage::InexistentStorage.new(host: canonical_url)
}
@@ -131,7 +131,7 @@ class FileLinkRepresenter < ::API::Decorators::Single
skip_render: ->(*) { represented.container_id.nil? }
def _type
- 'FileLink'
+ "FileLink"
end
private
@@ -160,10 +160,10 @@ def parse_origin_data(origin_data)
origin_created_by_name: origin_data["createdByName"],
origin_last_modified_by_name: origin_data["lastModifiedByName"],
origin_created_at: ::API::V3::Utilities::DateTimeFormatter.parse_datetime(origin_data["createdAt"],
- 'originData.createdAt',
+ "originData.createdAt",
allow_nil: true),
origin_updated_at: ::API::V3::Utilities::DateTimeFormatter.parse_datetime(origin_data["lastModifiedAt"],
- 'originData.lastModifiedAt',
+ "originData.lastModifiedAt",
allow_nil: true)
}
end
diff --git a/modules/storages/lib/api/v3/file_links/file_links_api.rb b/modules/storages/lib/api/v3/file_links/file_links_api.rb
index c4b2fa44f911..35e6b789064b 100644
--- a/modules/storages/lib/api/v3/file_links/file_links_api.rb
+++ b/modules/storages/lib/api/v3/file_links/file_links_api.rb
@@ -42,7 +42,7 @@ class API::V3::FileLinks::FileLinksAPI < API::OpenProjectAPI
# `route_param` extends the route by a route parameter of the endpoint.
# The input parameter value is parsed into the `:file_link_id` symbol.
- route_param :file_link_id, type: Integer, desc: 'File link id' do
+ route_param :file_link_id, type: Integer, desc: "File link id" do
# The after validation hook executes after the validation of the request format, but before any execution
# inside the endpoint context. Hence, it is a good place to actually fetch the handled resource.
after_validation do
diff --git a/modules/storages/lib/api/v3/file_links/work_packages_file_links_api.rb b/modules/storages/lib/api/v3/file_links/work_packages_file_links_api.rb
index 9575a206fe46..f020e5944a30 100644
--- a/modules/storages/lib/api/v3/file_links/work_packages_file_links_api.rb
+++ b/modules/storages/lib/api/v3/file_links/work_packages_file_links_api.rb
@@ -39,13 +39,13 @@ class API::V3::FileLinks::WorkPackagesFileLinksAPI < API::OpenProjectAPI
.call(params)
unless query.valid?
- message = I18n.t('api_v3.errors.missing_or_malformed_parameter', parameter: 'filters')
+ message = I18n.t("api_v3.errors.missing_or_malformed_parameter", parameter: "filters")
raise ::API::Errors::InvalidQuery.new(message)
end
result = if current_user.allowed_in_project?(:view_file_links, @work_package.project)
file_links = query.results.where(container_id: @work_package.id,
- container_type: 'WorkPackage',
+ container_type: "WorkPackage",
storage: @work_package.project.storages)
::Storages::FileLinkSyncService
.new(user: current_user)
diff --git a/modules/storages/lib/api/v3/project_storages/project_storage_representer.rb b/modules/storages/lib/api/v3/project_storages/project_storage_representer.rb
index eb834cd77641..8a8302c64079 100644
--- a/modules/storages/lib/api/v3/project_storages/project_storage_representer.rb
+++ b/modules/storages/lib/api/v3/project_storages/project_storage_representer.rb
@@ -63,7 +63,7 @@ class ProjectStorageRepresenter < ::API::Decorators::Single
skip_link: ->(*) { false }
def _type
- 'ProjectStorage'
+ "ProjectStorage"
end
end
end
diff --git a/modules/storages/lib/api/v3/project_storages/project_storages_api.rb b/modules/storages/lib/api/v3/project_storages/project_storages_api.rb
index 0d4f9285434a..c83ab701fa88 100644
--- a/modules/storages/lib/api/v3/project_storages/project_storages_api.rb
+++ b/modules/storages/lib/api/v3/project_storages/project_storages_api.rb
@@ -39,7 +39,7 @@ class ProjectStoragesAPI < API::OpenProjectAPI
.call(params)
unless query.valid?
- message = I18n.t('api_v3.errors.missing_or_malformed_parameter', parameter: 'filters')
+ message = I18n.t("api_v3.errors.missing_or_malformed_parameter", parameter: "filters")
raise ::API::Errors::InvalidQuery.new(message)
end
@@ -53,7 +53,7 @@ class ProjectStoragesAPI < API::OpenProjectAPI
)
end
- route_param :id, type: Integer, desc: 'ProjectStorage id' do
+ route_param :id, type: Integer, desc: "ProjectStorage id" do
after_validation do
@project_storage = Storages::ProjectStorage.find(params[:id])
diff --git a/modules/storages/lib/api/v3/storage_files/storage_file_representer.rb b/modules/storages/lib/api/v3/storage_files/storage_file_representer.rb
index dcb1a95cfa72..174f9116b405 100644
--- a/modules/storages/lib/api/v3/storage_files/storage_file_representer.rb
+++ b/modules/storages/lib/api/v3/storage_files/storage_file_representer.rb
@@ -55,7 +55,7 @@ def initialize(model, storage, current_user:)
property :permissions
def _type
- Storages::StorageFile.name.split('::').last
+ Storages::StorageFile.name.split("::").last
end
end
end
diff --git a/modules/storages/lib/api/v3/storage_files/storage_files_representer.rb b/modules/storages/lib/api/v3/storage_files/storage_files_representer.rb
index d148bea077cc..aa2e33bef1f8 100644
--- a/modules/storages/lib/api/v3/storage_files/storage_files_representer.rb
+++ b/modules/storages/lib/api/v3/storage_files/storage_files_representer.rb
@@ -61,7 +61,7 @@ def initialize(model, storage, current_user:)
exec_context: :decorator
def _type
- 'StorageFiles'
+ "StorageFiles"
end
end
end
diff --git a/modules/storages/lib/api/v3/storage_files/storage_upload_link_representer.rb b/modules/storages/lib/api/v3/storage_files/storage_upload_link_representer.rb
index 50b195186b4b..b0dec8173564 100644
--- a/modules/storages/lib/api/v3/storage_files/storage_upload_link_representer.rb
+++ b/modules/storages/lib/api/v3/storage_files/storage_upload_link_representer.rb
@@ -36,12 +36,12 @@ class StorageUploadLinkRepresenter < ::API::Decorators::Single
{
href: represented.destination,
method: represented.method,
- title: 'Upload File'
+ title: "Upload File"
}
end
def _type
- Storages::UploadLink.name.split('::').last
+ Storages::UploadLink.name.split("::").last
end
end
end
diff --git a/modules/storages/lib/api/v3/storages/storages_api.rb b/modules/storages/lib/api/v3/storages/storages_api.rb
index c2599eea4392..71557d77add9 100644
--- a/modules/storages/lib/api/v3/storages/storages_api.rb
+++ b/modules/storages/lib/api/v3/storages/storages_api.rb
@@ -36,7 +36,7 @@ class API::V3::Storages::StoragesAPI < API::OpenProjectAPI
get &API::V3::Utilities::Endpoints::Index.new(model: Storages::Storage, scope: -> { visible_storages }).mount
- route_param :storage_id, type: Integer, desc: 'Storage id' do
+ route_param :storage_id, type: Integer, desc: "Storage id" do
after_validation do
@storage = visible_storages.find(params[:storage_id])
end
diff --git a/modules/storages/lib/open_project/storages.rb b/modules/storages/lib/open_project/storages.rb
index b7ef4ce42ca6..628afdb1ab88 100644
--- a/modules/storages/lib/open_project/storages.rb
+++ b/modules/storages/lib/open_project/storages.rb
@@ -29,7 +29,7 @@
# This file is required by `modules/storages/lib/openproject-storages.rb` and
# loads the Rails engine associated with the plugin.
-require 'open_project/storages/engine'
+require "open_project/storages/engine"
module OpenProject
module Storages
diff --git a/modules/storages/lib/openproject-storages.rb b/modules/storages/lib/openproject-storages.rb
index cf1697fc4360..0b8622e544c5 100644
--- a/modules/storages/lib/openproject-storages.rb
+++ b/modules/storages/lib/openproject-storages.rb
@@ -3,4 +3,4 @@
# The OpenProject plugins, located in modules/, are defined in `Gemfile.modules`.
# They are loaded from `config/application.rb` when the bundler group :opf_plugins is loaded.
# This file is responsible for loading the module.
-require 'open_project/storages'
+require "open_project/storages"
diff --git a/modules/storages/openproject-storages.gemspec b/modules/storages/openproject-storages.gemspec
index d25baefd6a8a..c3fb7d170cdf 100644
--- a/modules/storages/openproject-storages.gemspec
+++ b/modules/storages/openproject-storages.gemspec
@@ -40,13 +40,13 @@
# References: https://guides.rubygems.org/specification-reference/
# rubocop:disable Gemspec/RequireMFA
Gem::Specification.new do |s|
- s.name = 'openproject-storages'
- s.version = '1.0.0'
- s.authors = 'OpenProject GmbH'
- s.email = 'info@openproject.com'
- s.summary = 'OpenProject Storages'
- s.description = 'Allows linking work packages to files in external storages, such as Nextcloud.'
- s.license = 'GPLv3'
- s.files = Dir['{app,config,db,lib}/**/*']
+ s.name = "openproject-storages"
+ s.version = "1.0.0"
+ s.authors = "OpenProject GmbH"
+ s.email = "info@openproject.com"
+ s.summary = "OpenProject Storages"
+ s.description = "Allows linking work packages to files in external storages, such as Nextcloud."
+ s.license = "GPLv3"
+ s.files = Dir["{app,config,db,lib}/**/*"]
end
# rubocop:enable Gemspec/RequireMFA
diff --git a/modules/storages/spec/common/storages/peripherals/registry_spec.rb b/modules/storages/spec/common/storages/peripherals/registry_spec.rb
index 23d150a7b18d..5fff3d2f780a 100644
--- a/modules/storages/spec/common/storages/peripherals/registry_spec.rb
+++ b/modules/storages/spec/common/storages/peripherals/registry_spec.rb
@@ -28,35 +28,35 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Peripherals::Registry, :webmock do
using Storages::Peripherals::ServiceResultRefinements
let(:user) { create(:user) }
- let(:url) { 'https://example.com' }
- let(:origin_user_id) { 'admin' }
- let(:storage) { build(:nextcloud_storage, :as_automatically_managed, host: url, password: 'OpenProjectSecurePassword') }
+ let(:url) { "https://example.com" }
+ let(:origin_user_id) { "admin" }
+ let(:storage) { build(:nextcloud_storage, :as_automatically_managed, host: url, password: "OpenProjectSecurePassword") }
subject(:registry) { described_class }
- context 'when a key is not registered' do
+ context "when a key is not registered" do
it "raises a OperationNotSupported for a non-existent command/query" do
- expect { registry.resolve('nextcloud.commands.destroy_alderaan') }.to raise_error Storages::Errors::OperationNotSupported
- expect { registry.resolve('nextcloud.queries.alderaan') }.to raise_error Storages::Errors::OperationNotSupported
+ expect { registry.resolve("nextcloud.commands.destroy_alderaan") }.to raise_error Storages::Errors::OperationNotSupported
+ expect { registry.resolve("nextcloud.queries.alderaan") }.to raise_error Storages::Errors::OperationNotSupported
end
- it 'raises a MissingContract for a non-existent contract' do
+ it "raises a MissingContract for a non-existent contract" do
expect { registry["warehouse.contracts.storage"] }.to raise_error Storages::Errors::MissingContract
end
- it 'raises a ResolverStandardError in all other cases' do
- expect { registry.resolve('it.is.a.trap') }.to raise_error Storages::Errors::ResolverStandardError
+ it "raises a ResolverStandardError in all other cases" do
+ expect { registry.resolve("it.is.a.trap") }.to raise_error Storages::Errors::ResolverStandardError
end
end
- describe '#group_users_query' do
+ describe "#group_users_query" do
let(:expected_response_body) do
<<~XML
@@ -92,21 +92,21 @@
stub_request(:get, "https://example.com/ocs/v1.php/cloud/groups/#{storage.group}")
.with(
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6T3BlblByb2plY3RTZWN1cmVQYXNzd29yZA==',
- 'OCS-APIRequest' => 'true'
+ "Authorization" => "Basic T3BlblByb2plY3Q6T3BlblByb2plY3RTZWN1cmVQYXNzd29yZA==",
+ "OCS-APIRequest" => "true"
}
)
.to_return(expected_response)
end
- it 'responds with a strings array with group users' do
- result = registry.resolve('nextcloud.queries.group_users').call(storage:)
+ it "responds with a strings array with group users" do
+ result = registry.resolve("nextcloud.queries.group_users").call(storage:)
expect(result).to be_success
expect(result.result).to eq(%w[admin OpenProject reader TestUser TestUser34])
end
end
- describe '#add_user_to_group_command' do
+ describe "#add_user_to_group_command" do
let(:expected_response) do
{
status: 200,
@@ -134,21 +134,21 @@
stub_request(:post, "https://example.com/ocs/v1.php/cloud/users/#{origin_user_id}/groups")
.with(
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6T3BlblByb2plY3RTZWN1cmVQYXNzd29yZA==',
- 'OCS-APIRequest' => 'true'
+ "Authorization" => "Basic T3BlblByb2plY3Q6T3BlblByb2plY3RTZWN1cmVQYXNzd29yZA==",
+ "OCS-APIRequest" => "true"
}
)
.to_return(expected_response)
end
- it 'adds user to the group' do
- result = registry.resolve('nextcloud.commands.add_user_to_group').call(storage:, user: origin_user_id)
+ it "adds user to the group" do
+ result = registry.resolve("nextcloud.commands.add_user_to_group").call(storage:, user: origin_user_id)
expect(result).to be_success
expect(result.message).to eq("User has been added successfully")
end
end
- describe '#remove_user_from_group' do
+ describe "#remove_user_from_group" do
let(:expected_response) do
{
status: 200,
@@ -176,20 +176,20 @@
stub_request(:delete, "https://example.com/ocs/v1.php/cloud/users/#{origin_user_id}/groups?groupid=#{storage.group}")
.with(
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6T3BlblByb2plY3RTZWN1cmVQYXNzd29yZA==',
- 'OCS-APIRequest' => 'true'
+ "Authorization" => "Basic T3BlblByb2plY3Q6T3BlblByb2plY3RTZWN1cmVQYXNzd29yZA==",
+ "OCS-APIRequest" => "true"
}
)
.to_return(expected_response)
end
- it 'removes user from the group' do
- result = registry.resolve('nextcloud.commands.remove_user_from_group').call(storage:, user: origin_user_id)
+ it "removes user from the group" do
+ result = registry.resolve("nextcloud.commands.remove_user_from_group").call(storage:, user: origin_user_id)
expect(result).to be_success
expect(result.message).to eq("User has been removed from group")
end
- context 'when Nextcloud reponds with 105 code in the response body' do
+ context "when Nextcloud reponds with 105 code in the response body" do
let(:expected_response_body) do
<<~XML
@@ -206,8 +206,8 @@
XML
end
- it 'responds with a failure and parses message from the xml response' do
- result = registry.resolve('nextcloud.commands.remove_user_from_group').call(storage:, user: origin_user_id)
+ it "responds with a failure and parses message from the xml response" do
+ result = registry.resolve("nextcloud.commands.remove_user_from_group").call(storage:, user: origin_user_id)
expect(result).to be_failure
expect(result.errors.log_message).to eq(
"Failed to remove user #{origin_user_id} from group OpenProject: " \
@@ -217,36 +217,36 @@
end
end
- describe '#create_folder_command' do
- let(:folder_path) { 'OpenProject/JediProject' }
+ describe "#create_folder_command" do
+ let(:folder_path) { "OpenProject/JediProject" }
before do
stub_request(:mkcol, "https://example.com/remote.php/dav/files/OpenProject/OpenProject/JediProject")
.with(
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6T3BlblByb2plY3RTZWN1cmVQYXNzd29yZA=='
+ "Authorization" => "Basic T3BlblByb2plY3Q6T3BlblByb2plY3RTZWN1cmVQYXNzd29yZA=="
}
)
.to_return(expected_response)
end
- context 'when folder does not exist yet' do
+ context "when folder does not exist yet" do
let(:expected_response) do
{
status: 201,
- body: '',
+ body: "",
headers: {}
}
end
- it 'creates a folder and responds with a success' do
- result = registry.resolve('nextcloud.commands.create_folder').call(storage:, folder_path:)
+ it "creates a folder and responds with a success" do
+ result = registry.resolve("nextcloud.commands.create_folder").call(storage:, folder_path:)
expect(result).to be_success
expect(result.message).to eq("Folder was successfully created.")
end
end
- context 'when folder exists already' do
+ context "when folder exists already" do
let(:expected_response_body) do
<<~XML
@@ -264,14 +264,14 @@
}
end
- it 'does not create a folder and responds with a success' do
- result = registry.resolve('nextcloud.commands.create_folder').call(storage:, folder_path:)
+ it "does not create a folder and responds with a success" do
+ result = registry.resolve("nextcloud.commands.create_folder").call(storage:, folder_path:)
expect(result).to be_success
expect(result.message).to eq("Folder already exists.")
end
end
- context 'when parent folder is missing for any reason' do
+ context "when parent folder is missing for any reason" do
let(:expected_response_body) do
<<~XML
@@ -289,23 +289,23 @@
}
end
- it 'does not create a folder and responds with a failure' do
- result = registry.resolve('nextcloud.commands.create_folder').call(storage:, folder_path:)
+ it "does not create a folder and responds with a failure" do
+ result = registry.resolve("nextcloud.commands.create_folder").call(storage:, folder_path:)
expect(result).to be_failure
expect(result.result).to eq(:conflict)
- expect(result.errors.log_message).to eq('Parent node does not exist')
+ expect(result.errors.log_message).to eq("Parent node does not exist")
end
end
end
- describe '#set_permissions_command' do
- let(:path) { 'OpenProject/JediProject' }
+ describe "#set_permissions_command" do
+ let(:path) { "OpenProject/JediProject" }
let(:permissions) do
{
users: {
OpenProject: 31,
- 'Obi-Wan': 31,
- 'Qui-Gon': 31
+ "Obi-Wan": 31,
+ "Qui-Gon": 31
},
groups: {
OpenProject: 0
@@ -351,20 +351,20 @@
XML
end
- context 'with Nextcloud storage type selected' do
- context 'with outbound request' do
+ context "with Nextcloud storage type selected" do
+ context "with outbound request" do
before do
stub_request(:proppatch, "#{url}/remote.php/dav/files/OpenProject/OpenProject/JediProject")
.with(
body: expected_request_body,
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6T3BlblByb2plY3RTZWN1cmVQYXNzd29yZA=='
+ "Authorization" => "Basic T3BlblByb2plY3Q6T3BlblByb2plY3RTZWN1cmVQYXNzd29yZA=="
}
)
.to_return(expected_response)
end
- context 'when permissions can be set' do
+ context "when permissions can be set" do
let(:expected_response_body) do
<<~XML
@@ -393,13 +393,13 @@
}
end
- it 'returns success when permissions can be set' do
- result = registry.resolve('nextcloud.commands.set_permissions').call(storage:, path:, permissions:)
+ it "returns success when permissions can be set" do
+ result = registry.resolve("nextcloud.commands.set_permissions").call(storage:, path:, permissions:)
expect(result).to be_success
end
end
- context 'when the password is wrong' do
+ context "when the password is wrong" do
let(:expected_response_body) do
<<~XML
@@ -419,13 +419,13 @@
}
end
- it 'returns failure' do
- result = registry.resolve('nextcloud.commands.set_permissions').call(storage:, path:, permissions:)
+ it "returns failure" do
+ result = registry.resolve("nextcloud.commands.set_permissions").call(storage:, path:, permissions:)
expect(result).to be_failure
end
end
- context 'when the NC control user cannot read(see) the project folder' do
+ context "when the NC control user cannot read(see) the project folder" do
let(:expected_response_body) do
<<~XML
@@ -445,31 +445,31 @@
}
end
- it 'returns failure' do
- result = registry.resolve('nextcloud.commands.set_permissions').call(storage:, path:, permissions:)
+ it "returns failure" do
+ result = registry.resolve("nextcloud.commands.set_permissions").call(storage:, path:, permissions:)
expect(result).to be_failure
end
end
end
- context 'when forbidden values are given as folder' do
- it 'raises an ArgumentError on nil' do
+ context "when forbidden values are given as folder" do
+ it "raises an ArgumentError on nil" do
expect do
- registry.resolve('nextcloud.commands.set_permissions').call(storage:, path: nil, permissions:)
+ registry.resolve("nextcloud.commands.set_permissions").call(storage:, path: nil, permissions:)
end.to raise_error(ArgumentError)
end
- it 'raises an ArgumentError on empty string' do
+ it "raises an ArgumentError on empty string" do
expect do
- registry.resolve('nextcloud.commands.set_permissions').call(path: '', permissions:)
+ registry.resolve("nextcloud.commands.set_permissions").call(path: "", permissions:)
end.to raise_error(ArgumentError)
end
end
end
end
- describe '#file_ids_query' do
- let(:nextcloud_subpath) { '' }
+ describe "#file_ids_query" do
+ let(:nextcloud_subpath) { "" }
let(:url) { "https://example.com#{nextcloud_subpath}" }
let(:expected_request_body) do
<<~XML
@@ -560,15 +560,15 @@
stub_request(:propfind, "#{url}/remote.php/dav/files/OpenProject/OpenProject").with(
body: expected_request_body,
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6T3BlblByb2plY3RTZWN1cmVQYXNzd29yZA==',
- 'Depth' => '1'
+ "Authorization" => "Basic T3BlblByb2plY3Q6T3BlblByb2plY3RTZWN1cmVQYXNzd29yZA==",
+ "Depth" => "1"
}
).to_return(status: 200, body: expected_response_body, headers: {})
end
- shared_examples 'a file_ids_query response' do
- it 'responds with a list of paths and attributes for each of them' do
- result = registry.resolve('nextcloud.queries.file_ids').call(storage:, path: 'OpenProject')
+ shared_examples "a file_ids_query response" do
+ it "responds with a list of paths and attributes for each of them" do
+ result = registry.resolve("nextcloud.queries.file_ids").call(storage:, path: "OpenProject")
.result
expect(result).to eq({ "OpenProject/" => { "fileid" => "349" },
"OpenProject/Project #2/" => { "fileid" => "381" },
@@ -580,45 +580,45 @@
end
end
- it_behaves_like 'a file_ids_query response'
+ it_behaves_like "a file_ids_query response"
- context 'when NC is deployed under subpath' do
- let(:nexcloud_subpath) { '/subpath' }
+ context "when NC is deployed under subpath" do
+ let(:nexcloud_subpath) { "/subpath" }
- it_behaves_like 'a file_ids_query response'
+ it_behaves_like "a file_ids_query response"
end
end
- describe '#rename_file_command' do
+ describe "#rename_file_command" do
before do
stub_request(:move, "https://example.com/remote.php/dav/files/OpenProject/OpenProject/asd")
.with(
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6T3BlblByb2plY3RTZWN1cmVQYXNzd29yZA==',
- 'Destination' => '/remote.php/dav/files/OpenProject/OpenProject/qwe'
+ "Authorization" => "Basic T3BlblByb2plY3Q6T3BlblByb2plY3RTZWN1cmVQYXNzd29yZA==",
+ "Destination" => "/remote.php/dav/files/OpenProject/OpenProject/qwe"
}
- ).to_return(status: 201, body: '', headers: {})
+ ).to_return(status: 201, body: "", headers: {})
end
- describe 'with Nextcloud storage type selected' do
- it 'moves the file' do
- result = registry.resolve('nextcloud.commands.rename_file').call(storage:, source: 'OpenProject/asd',
- target: 'OpenProject/qwe')
+ describe "with Nextcloud storage type selected" do
+ it "moves the file" do
+ result = registry.resolve("nextcloud.commands.rename_file").call(storage:, source: "OpenProject/asd",
+ target: "OpenProject/qwe")
expect(result).to be_success
end
end
end
- describe '#delete_folder_command' do
+ describe "#delete_folder_command" do
before do
stub_request(:delete, "https://example.com/remote.php/dav/files/OpenProject/OpenProject/Folder%201")
- .with(headers: { 'Authorization' => 'Basic T3BlblByb2plY3Q6T3BlblByb2plY3RTZWN1cmVQYXNzd29yZA==' })
- .to_return(status: 204, body: '', headers: {})
+ .with(headers: { "Authorization" => "Basic T3BlblByb2plY3Q6T3BlblByb2plY3RTZWN1cmVQYXNzd29yZA==" })
+ .to_return(status: 204, body: "", headers: {})
end
- describe 'with Nextcloud storage type selected' do
- it 'deletes the folder' do
- result = registry.resolve('nextcloud.commands.delete_folder').call(storage:, location: 'OpenProject/Folder 1')
+ describe "with Nextcloud storage type selected" do
+ it "deletes the folder" do
+ result = registry.resolve("nextcloud.commands.delete_folder").call(storage:, location: "OpenProject/Folder 1")
expect(result).to be_success
end
end
diff --git a/modules/storages/spec/common/storages/peripherals/storage_interaction/nextcloud/download_link_query_spec.rb b/modules/storages/spec/common/storages/peripherals/storage_interaction/nextcloud/download_link_query_spec.rb
index 9d2514d3b37f..51efef368754 100644
--- a/modules/storages/spec/common/storages/peripherals/storage_interaction/nextcloud/download_link_query_spec.rb
+++ b/modules/storages/spec/common/storages/peripherals/storage_interaction/nextcloud/download_link_query_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Peripherals::StorageInteraction::Nextcloud::DownloadLinkQuery, :webmock do
@@ -41,9 +41,9 @@
{
ocs: {
meta: {
- status: 'ok',
+ status: "ok",
statuscode: 200,
- message: 'OK'
+ message: "OK"
},
data: {
url: "https://example.com/remote.php/direct/#{download_token}"
@@ -63,35 +63,35 @@
stub_request(:post, "#{url}/ocs/v2.php/apps/dav/api/v1/direct").to_return(status: 200, body: json, headers: {})
end
- it 'must return a download link URL' do
+ it "must return a download link URL" do
result = described_class.call(storage:, user:, file_link:)
expect(result).to be_success
expect(result.result).to eql(uri)
end
- context 'if Nextcloud is running on a sub path' do
- let(:storage) { create(:nextcloud_storage, :with_oauth_client, host: 'https://example.com/html') }
+ context "if Nextcloud is running on a sub path" do
+ let(:storage) { create(:nextcloud_storage, :with_oauth_client, host: "https://example.com/html") }
- it 'must return a download link URL' do
+ it "must return a download link URL" do
result = described_class.call(storage:, user:, file_link:)
expect(result).to be_success
expect(result.result).to eql(uri)
end
end
- describe 'with outbound request returning 200 and an empty body' do
+ describe "with outbound request returning 200 and an empty body" do
before do
- stub_request(:post, "#{url}/ocs/v2.php/apps/dav/api/v1/direct").to_return(status: 200, body: '')
+ stub_request(:post, "#{url}/ocs/v2.php/apps/dav/api/v1/direct").to_return(status: 200, body: "")
end
- it 'must return :unauthorized ServiceResult' do
+ it "must return :unauthorized ServiceResult" do
result = described_class.call(user:, file_link:, storage:)
expect(result).to be_failure
expect(result.errors.code).to be(:unauthorized)
end
end
- shared_examples_for 'outbound is failing' do |code = 500, symbol = :error|
+ shared_examples_for "outbound is failing" do |code = 500, symbol = :error|
describe "with outbound request returning #{code}" do
before do
stub_request(:post, "#{url}/ocs/v2.php/apps/dav/api/v1/direct").to_return(status: code)
@@ -105,7 +105,7 @@
end
end
- include_examples 'outbound is failing', 404, :not_found
- include_examples 'outbound is failing', 401, :unauthorized
- include_examples 'outbound is failing', 500, :error
+ include_examples "outbound is failing", 404, :not_found
+ include_examples "outbound is failing", 401, :unauthorized
+ include_examples "outbound is failing", 500, :error
end
diff --git a/modules/storages/spec/common/storages/peripherals/storage_interaction/nextcloud/files_info_query_spec.rb b/modules/storages/spec/common/storages/peripherals/storage_interaction/nextcloud/files_info_query_spec.rb
index cd8b755ea775..a9e61226e7bd 100644
--- a/modules/storages/spec/common/storages/peripherals/storage_interaction/nextcloud/files_info_query_spec.rb
+++ b/modules/storages/spec/common/storages/peripherals/storage_interaction/nextcloud/files_info_query_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Peripherals::StorageInteraction::Nextcloud::FilesInfoQuery, :webmock do
@@ -42,12 +42,12 @@
subject { described_class.new(storage) }
- describe '#call' do
+ describe "#call" do
let(:file_ids) { %w[182 203 222] }
- context 'without outbound request involved' do
- context 'with an empty array of file ids' do
- it 'returns an empty array' do
+ context "without outbound request involved" do
+ context "with an empty array of file ids" do
+ it "returns an empty array" do
result = subject.call(user:, file_ids: [])
expect(result).to be_success
@@ -55,8 +55,8 @@
end
end
- context 'with nil' do
- it 'returns an error' do
+ context "with nil" do
+ it "returns an error" do
result = subject.call(user:, file_ids: nil)
expect(result).to be_failure
@@ -65,10 +65,10 @@
end
end
- context 'with outbound request successful',
- vcr: 'nextcloud/files_info_query_success' do
- context 'with an array of file ids' do
- it 'must return an array of file information when called' do
+ context "with outbound request successful",
+ vcr: "nextcloud/files_info_query_success" do
+ context "with an array of file ids" do
+ it "must return an array of file information when called" do
result = subject.call(user:, file_ids:)
expect(result).to be_success
@@ -83,9 +83,9 @@
end
end
- context 'with outbound request not authorized',
- vcr: 'nextcloud/files_info_query_unauthorized' do
- context 'with an array of file ids' do
+ context "with outbound request not authorized",
+ vcr: "nextcloud/files_info_query_unauthorized" do
+ context "with an array of file ids" do
before do
token = build_stubbed(:oauth_client_token, oauth_client: storage.oauth_client)
allow(Storages::Peripherals::StorageInteraction::Nextcloud::Util)
@@ -93,7 +93,7 @@
.and_yield(token)
end
- it 'must return an error when called' do
+ it "must return an error when called" do
subject.call(user:, file_ids:).match(
on_success: ->(file_infos) { fail "Expected failure, got #{file_infos}" },
on_failure: ->(error) { expect(error.code).to eq(:unauthorized) }
@@ -102,16 +102,16 @@
end
end
- context 'with outbound request not found' do
- context 'with a single file id',
- vcr: 'nextcloud/files_info_query_not_found' do
+ context "with outbound request not found" do
+ context "with a single file id",
+ vcr: "nextcloud/files_info_query_not_found" do
let(:file_ids) { %w[1234] }
- it 'returns an HTTP 200 with individual status code per file ID' do
+ it "returns an HTTP 200 with individual status code per file ID" do
subject.call(user:, file_ids:).match(
on_success: ->(file_infos) do
expect(file_infos.size).to eq(1)
- expect(file_infos.first.to_h).to include(status: 'Not Found', status_code: 404)
+ expect(file_infos.first.to_h).to include(status: "Not Found", status_code: 404)
end,
on_failure: ->(error) { fail "Expected success, got #{error}" }
)
@@ -119,12 +119,12 @@
end
end
- context 'with outbound request not authorized' do
- context 'with multiple file IDs, one of which is not authorized',
- vcr: 'nextcloud/files_info_query_only_one_not_authorized' do
+ context "with outbound request not authorized" do
+ context "with multiple file IDs, one of which is not authorized",
+ vcr: "nextcloud/files_info_query_only_one_not_authorized" do
let(:file_ids) { %w[182 1234] }
- it 'returns an HTTP 200 with individual status code per file ID' do
+ it "returns an HTTP 200 with individual status code per file ID" do
subject.call(user:, file_ids:).match(
on_success: ->(file_infos) do
expect(file_infos.size).to eq(2)
diff --git a/modules/storages/spec/common/storages/peripherals/storage_interaction/nextcloud/open_file_link_query_spec.rb b/modules/storages/spec/common/storages/peripherals/storage_interaction/nextcloud/open_file_link_query_spec.rb
index 45a35f69b072..584f7ce1ee71 100644
--- a/modules/storages/spec/common/storages/peripherals/storage_interaction/nextcloud/open_file_link_query_spec.rb
+++ b/modules/storages/spec/common/storages/peripherals/storage_interaction/nextcloud/open_file_link_query_spec.rb
@@ -28,35 +28,35 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Peripherals::StorageInteraction::Nextcloud::OpenFileLinkQuery do
- let(:storage) { create(:nextcloud_storage, host: 'https://example.com') }
+ let(:storage) { create(:nextcloud_storage, host: "https://example.com") }
let(:user) { create(:user) }
- let(:file_id) { '1337' }
+ let(:file_id) { "1337" }
- it 'responds to .call' do
+ it "responds to .call" do
expect(described_class).to respond_to(:call)
method = described_class.method(:call)
expect(method.parameters).to contain_exactly(%i[keyreq storage], %i[keyreq user], %i[keyreq file_id], %i[key open_location])
end
- it 'returns the url for opening the file on storage' do
+ it "returns the url for opening the file on storage" do
url = described_class.call(storage:, user:, file_id:).result
expect(url).to eq("#{storage.host}/index.php/f/#{file_id}?openfile=1")
end
- it 'returns the url for opening the file\'s location on storage' do
+ it "returns the url for opening the file's location on storage" do
url = described_class.call(storage:, user:, file_id:, open_location: true).result
expect(url).to eq("#{storage.host}/index.php/f/#{file_id}?openfile=0")
end
- context 'with a storage with host url with a sub path' do
- let(:storage) { create(:nextcloud_storage, host: 'https://example.com/html') }
+ context "with a storage with host url with a sub path" do
+ let(:storage) { create(:nextcloud_storage, host: "https://example.com/html") }
- it 'returns the url for opening the file on storage' do
+ it "returns the url for opening the file on storage" do
url = described_class.call(storage:, user:, file_id:).result
expect(url).to eq("#{storage.host}/index.php/f/#{file_id}?openfile=1")
end
diff --git a/modules/storages/spec/common/storages/peripherals/storage_interaction/nextcloud/open_storage_query_spec.rb b/modules/storages/spec/common/storages/peripherals/storage_interaction/nextcloud/open_storage_query_spec.rb
index 7f22330e23c4..a4a6c1d291b6 100644
--- a/modules/storages/spec/common/storages/peripherals/storage_interaction/nextcloud/open_storage_query_spec.rb
+++ b/modules/storages/spec/common/storages/peripherals/storage_interaction/nextcloud/open_storage_query_spec.rb
@@ -28,29 +28,29 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Peripherals::StorageInteraction::Nextcloud::OpenStorageQuery do
- let(:storage) { create(:nextcloud_storage, host: 'https://example.com') }
+ let(:storage) { create(:nextcloud_storage, host: "https://example.com") }
let(:user) { create(:user) }
- it 'responds to .call' do
+ it "responds to .call" do
expect(described_class).to respond_to(:call)
method = described_class.method(:call)
expect(method.parameters).to contain_exactly(%i[keyreq storage], %i[keyreq user])
end
- it 'returns the url for opening the file on storage' do
+ it "returns the url for opening the file on storage" do
url = described_class.call(storage:, user:).result
expect(url).to eq("#{storage.host}/index.php/apps/files")
end
- context 'with a storage with host url with a sub path' do
- let(:storage) { create(:nextcloud_storage, host: 'https://example.com/html') }
+ context "with a storage with host url with a sub path" do
+ let(:storage) { create(:nextcloud_storage, host: "https://example.com/html") }
- it 'returns the url for opening the file on storage' do
+ it "returns the url for opening the file on storage" do
url = described_class.call(storage:, user:).result
expect(url).to eq("#{storage.host}/index.php/apps/files")
end
diff --git a/modules/storages/spec/common/storages/peripherals/storage_interaction/nextcloud/upload_link_query_spec.rb b/modules/storages/spec/common/storages/peripherals/storage_interaction/nextcloud/upload_link_query_spec.rb
index 469863310eab..30344962814c 100644
--- a/modules/storages/spec/common/storages/peripherals/storage_interaction/nextcloud/upload_link_query_spec.rb
+++ b/modules/storages/spec/common/storages/peripherals/storage_interaction/nextcloud/upload_link_query_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Peripherals::StorageInteraction::Nextcloud::UploadLinkQuery, :webmock do
@@ -38,7 +38,7 @@
let(:url) { storage.uri.to_s }
let(:query_payload) { Struct.new(:parent).new(42) }
- let(:upload_token) { 'valid-token' }
+ let(:upload_token) { "valid-token" }
subject(:query) { described_class }
@@ -49,14 +49,14 @@
.to_return(status: 200, body: { token: upload_token, expires_on: 1673883865 }.to_json)
end
- it '.call requires 3 arguments: storage, user, and data' do
+ it ".call requires 3 arguments: storage, user, and data" do
expect(described_class).to respond_to(:call)
method = described_class.method(:call)
expect(method.parameters).to contain_exactly(%i[keyreq storage], %i[keyreq user], %i[keyreq data])
end
- it 'must return an upload link URL' do
+ it "must return an upload link URL" do
link = query.call(storage:, user:, data: query_payload).result
expect(link.destination.path).to eql("/index.php/apps/integration_openproject/direct-upload/#{upload_token}")
expect(link.destination.host).to eql(URI(url).host)
@@ -66,7 +66,7 @@
expect(link.method).to eq(:post)
end
- shared_examples_for 'outbound is failing' do |code, symbol|
+ shared_examples_for "outbound is failing" do |code, symbol|
describe "with outbound request returning #{code}" do
before do
stub_request(:post, "#{url}index.php/apps/integration_openproject/direct-upload-token").and_return(status: code)
@@ -81,8 +81,8 @@
end
end
- include_examples 'outbound is failing', 400, :error
- include_examples 'outbound is failing', 401, :unauthorized
- include_examples 'outbound is failing', 404, :not_found
- include_examples 'outbound is failing', 500, :error
+ include_examples "outbound is failing", 400, :error
+ include_examples "outbound is failing", 401, :unauthorized
+ include_examples "outbound is failing", 404, :not_found
+ include_examples "outbound is failing", 500, :error
end
diff --git a/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/create_folder_command_spec.rb b/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/create_folder_command_spec.rb
index dc60261e6187..08ade61f2d21 100644
--- a/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/create_folder_command_spec.rb
+++ b/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/create_folder_command_spec.rb
@@ -28,34 +28,34 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Peripherals::StorageInteraction::OneDrive::CreateFolderCommand, :vcr, :webmock do
shared_let(:storage) { create(:sharepoint_dev_drive_storage) }
- let(:delete_command) { Storages::Peripherals::Registry.resolve('one_drive.commands.delete_folder') }
- let(:folder_path) { 'Földer CreatedBy Çommand' }
+ let(:delete_command) { Storages::Peripherals::Registry.resolve("one_drive.commands.delete_folder") }
+ let(:folder_path) { "Földer CreatedBy Çommand" }
shared_let(:original_ids) do
WebMock.enable! && VCR.turn_on!
- VCR.use_cassette('one_drive/create_folder_setup') { original_files }
+ VCR.use_cassette("one_drive/create_folder_setup") { original_files }
ensure
VCR.turn_off! && WebMock.disable!
end
- it 'responds to .call with correct parameters' do
+ it "responds to .call with correct parameters" do
expect(described_class).to respond_to(:call)
method = described_class.method(:call)
expect(method.parameters).to contain_exactly(%i[keyreq storage], %i[keyreq folder_path])
end
- it 'is registered as create_folder' do
- expect(Storages::Peripherals::Registry.resolve('one_drive.commands.create_folder')).to eq(described_class)
+ it "is registered as create_folder" do
+ expect(Storages::Peripherals::Registry.resolve("one_drive.commands.create_folder")).to eq(described_class)
end
- it 'creates a folder and responds with a success', vcr: 'one_drive/create_folder_base' do
+ it "creates a folder and responds with a success", vcr: "one_drive/create_folder_base" do
result = described_class.call(storage:, folder_path:)
expect(result).to be_success
expect(result.message).to eq("Folder was successfully created.")
@@ -65,7 +65,7 @@
delete_created_files
end
- it 'creates a sub folder', vcr: 'one_drive/create_folder_sub_folder' do
+ it "creates a sub folder", vcr: "one_drive/create_folder_sub_folder" do
folder = described_class.call(storage:, folder_path:).result
sub_folder = described_class.new(storage).call(folder_path: "Another Folder", parent_location: folder.id).result
@@ -75,8 +75,8 @@
delete_created_files
end
- context 'when the folder already exists', vcr: 'one_drive/create_folder_already_exists' do
- it 'returns a failure' do
+ context "when the folder already exists", vcr: "one_drive/create_folder_already_exists" do
+ it "returns a failure" do
described_class.call(storage:, folder_path:)
result = described_class.call(storage:, folder_path:)
@@ -85,7 +85,7 @@
error_data = result.errors.data
expect(error_data.payload.status).to eq(409)
- expect(error_data.payload.json.dig('error', 'code')).to match /nameAlreadyExists/
+ expect(error_data.payload.json.dig("error", "code")).to match /nameAlreadyExists/
ensure
delete_created_files
end
diff --git a/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/delete_folder_command_spec.rb b/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/delete_folder_command_spec.rb
index ecd8d7b52d41..d03e471382e2 100644
--- a/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/delete_folder_command_spec.rb
+++ b/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/delete_folder_command_spec.rb
@@ -28,35 +28,35 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Peripherals::StorageInteraction::OneDrive::DeleteFolderCommand, :vcr, :webmock do
let(:storage) { create(:sharepoint_dev_drive_storage) }
- it 'is registered as commands.one_drive.delete_folder' do
- expect(Storages::Peripherals::Registry.resolve('one_drive.commands.delete_folder')).to eq(described_class)
+ it "is registered as commands.one_drive.delete_folder" do
+ expect(Storages::Peripherals::Registry.resolve("one_drive.commands.delete_folder")).to eq(described_class)
end
- it '.call requires storage and location as keyword arguments' do
+ it ".call requires storage and location as keyword arguments" do
expect(described_class).to respond_to(:call)
method = described_class.method(:call)
expect(method.parameters).to contain_exactly(%i[keyreq storage], %i[keyreq location])
end
- it 'deletes a folder', vcr: 'one_drive/delete_folder' do
+ it "deletes a folder", vcr: "one_drive/delete_folder" do
create_result = Storages::Peripherals::Registry
- .resolve('one_drive.commands.create_folder')
- .call(storage:, folder_path: 'To Be Deleted Soon')
+ .resolve("one_drive.commands.create_folder")
+ .call(storage:, folder_path: "To Be Deleted Soon")
folder = create_result.result
expect(described_class.call(storage:, location: folder.id)).to be_success
end
- it 'when the folder is not found, returns a failure', vcr: 'one_drive/delete_folder_not_found' do
- result = described_class.call(storage:, location: 'NOT_HERE')
+ it "when the folder is not found, returns a failure", vcr: "one_drive/delete_folder_not_found" do
+ result = described_class.call(storage:, location: "NOT_HERE")
expect(result).to be_failure
expect(result.result).to eq(:not_found)
end
diff --git a/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/download_link_query_spec.rb b/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/download_link_query_spec.rb
index f1c2728e3b2d..c46e1a5cae3e 100644
--- a/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/download_link_query_spec.rb
+++ b/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/download_link_query_spec.rb
@@ -28,11 +28,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Peripherals::StorageInteraction::OneDrive::DownloadLinkQuery, :webmock do
- let(:storage) { create(:one_drive_storage, :with_oauth_client, drive_id: 'JUMBLEOFLETTERSANDNUMB3R5') }
+ let(:storage) { create(:one_drive_storage, :with_oauth_client, drive_id: "JUMBLEOFLETTERSANDNUMB3R5") }
let(:user) { create(:user) }
let(:file_link) { create(:file_link) }
let(:token) { create(:oauth_client_token, oauth_client: storage.oauth_client, user:) }
@@ -42,21 +42,21 @@
before do
allow(Storages::Peripherals::StorageInteraction::OneDrive).to receive(:token).and_yield(token)
stub_request(:get, "https://graph.microsoft.com/v1.0/drives/#{storage.drive_id}/items/#{file_link.origin_id}/content")
- .with(headers: { 'Authorization' => "Bearer #{token.access_token}" })
- .and_return(status: 302, body: nil, headers: { 'Location' => 'https://somecool.link/from/microsoft' })
+ .with(headers: { "Authorization" => "Bearer #{token.access_token}" })
+ .and_return(status: 302, body: nil, headers: { "Location" => "https://somecool.link/from/microsoft" })
end
- it 'returns a result with a download url' do
+ it "returns a result with a download url" do
download_link = download_link_query.call(user:, file_link:)
expect(download_link).to be_success
- expect(download_link.result).to eq('https://somecool.link/from/microsoft')
+ expect(download_link.result).to eq("https://somecool.link/from/microsoft")
end
- it 'return an error if any other response is received' do
+ it "return an error if any other response is received" do
stub_request(:get, "https://graph.microsoft.com/v1.0/drives/#{storage.drive_id}/items/#{file_link.origin_id}/content")
- .with(headers: { 'Authorization' => "Bearer #{token.access_token}" })
- .and_return(status: 200, body: '')
+ .with(headers: { "Authorization" => "Bearer #{token.access_token}" })
+ .and_return(status: 200, body: "")
download_link = download_link_query.call(user:, file_link:)
diff --git a/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/files_info_query_spec.rb b/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/files_info_query_spec.rb
index d3c9a3417663..ddb07c5c36d6 100644
--- a/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/files_info_query_spec.rb
+++ b/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/files_info_query_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Peripherals::StorageInteraction::OneDrive::FilesInfoQuery, :vcr, :webmock do
@@ -39,17 +39,17 @@
subject { described_class.new(storage) }
- describe '#call' do
- it 'responds with correct parameters' do
+ describe "#call" do
+ it "responds with correct parameters" do
expect(described_class).to respond_to(:call)
method = described_class.method(:call)
expect(method.parameters).to contain_exactly(%i[keyreq storage], %i[keyreq user], %i[key file_ids])
end
- context 'without outbound request involved' do
- context 'with an empty array of file ids' do
- it 'returns an empty array' do
+ context "without outbound request involved" do
+ context "with an empty array of file ids" do
+ it "returns an empty array" do
result = subject.call(user:, file_ids: [])
expect(result).to be_success
@@ -57,8 +57,8 @@
end
end
- context 'with nil' do
- it 'returns an error' do
+ context "with nil" do
+ it "returns an error" do
result = subject.call(user:, file_ids: nil)
expect(result).to be_failure
@@ -67,8 +67,8 @@
end
end
- context 'with outbound requests successful', vcr: 'one_drive/files_info_query_success' do
- context 'with an array of file ids' do
+ context "with outbound requests successful", vcr: "one_drive/files_info_query_success" do
+ context "with an array of file ids" do
let(:file_ids) do
%w(
01AZJL5PKU2WV3U3RKKFF2A7ZCWVBXRTEU
@@ -78,7 +78,7 @@
end
# rubocop:disable RSpec/ExampleLength
- it 'must return an array of file information when called' do
+ it "must return an array of file information when called" do
result = subject.call(user:, file_ids:)
expect(result).to be_success
@@ -89,55 +89,55 @@
expect(file_infos.map(&:to_h))
.to eq([
{
- status: 'ok',
+ status: "ok",
status_code: 200,
- id: '01AZJL5PKU2WV3U3RKKFF2A7ZCWVBXRTEU',
- name: 'Folder with spaces',
+ id: "01AZJL5PKU2WV3U3RKKFF2A7ZCWVBXRTEU",
+ name: "Folder with spaces",
size: 35141,
- mime_type: 'application/x-op-directory',
- created_at: Time.parse('2023-09-26T14:38:57Z'),
- last_modified_at: Time.parse('2023-09-26T14:38:57Z'),
- owner_name: 'Eric Schubert',
- owner_id: '0a0d38a9-a59b-4245-93fa-0d2cf727f17a',
- last_modified_by_name: 'Eric Schubert',
- last_modified_by_id: '0a0d38a9-a59b-4245-93fa-0d2cf727f17a',
+ mime_type: "application/x-op-directory",
+ created_at: Time.parse("2023-09-26T14:38:57Z"),
+ last_modified_at: Time.parse("2023-09-26T14:38:57Z"),
+ owner_name: "Eric Schubert",
+ owner_id: "0a0d38a9-a59b-4245-93fa-0d2cf727f17a",
+ last_modified_by_name: "Eric Schubert",
+ last_modified_by_id: "0a0d38a9-a59b-4245-93fa-0d2cf727f17a",
permissions: nil,
trashed: false,
- location: '/Folder with spaces'
+ location: "/Folder with spaces"
},
{
- status: 'ok',
+ status: "ok",
status_code: 200,
- id: '01AZJL5PJTICED3C5YSVAY6NWTBNA2XERU',
- name: 'Document.docx',
+ id: "01AZJL5PJTICED3C5YSVAY6NWTBNA2XERU",
+ name: "Document.docx",
size: 22514,
- mime_type: 'application/vnd.openxmlformats-officedocument.wordprocessingml.document',
- created_at: Time.parse('2023-09-26T14:40:58Z'),
- last_modified_at: Time.parse('2023-09-26T14:42:03Z'),
- owner_name: 'Eric Schubert',
- owner_id: '0a0d38a9-a59b-4245-93fa-0d2cf727f17a',
- last_modified_by_name: 'Eric Schubert',
- last_modified_by_id: '0a0d38a9-a59b-4245-93fa-0d2cf727f17a',
+ mime_type: "application/vnd.openxmlformats-officedocument.wordprocessingml.document",
+ created_at: Time.parse("2023-09-26T14:40:58Z"),
+ last_modified_at: Time.parse("2023-09-26T14:42:03Z"),
+ owner_name: "Eric Schubert",
+ owner_id: "0a0d38a9-a59b-4245-93fa-0d2cf727f17a",
+ last_modified_by_name: "Eric Schubert",
+ last_modified_by_id: "0a0d38a9-a59b-4245-93fa-0d2cf727f17a",
permissions: nil,
trashed: false,
- location: '/Folder/Document.docx'
+ location: "/Folder/Document.docx"
},
{
- status: 'ok',
+ status: "ok",
status_code: 200,
- id: '01AZJL5PNCQCEBFI3N7JGZSX5AOX32Z3LA',
- name: 'NextcloudHub.md',
+ id: "01AZJL5PNCQCEBFI3N7JGZSX5AOX32Z3LA",
+ name: "NextcloudHub.md",
size: 1095,
- mime_type: 'application/octet-stream',
- created_at: Time.parse('2023-09-26T14:45:25Z'),
- last_modified_at: Time.parse('2023-09-26T14:46:13Z'),
- owner_name: 'Eric Schubert',
- owner_id: '0a0d38a9-a59b-4245-93fa-0d2cf727f17a',
- last_modified_by_name: 'Eric Schubert',
- last_modified_by_id: '0a0d38a9-a59b-4245-93fa-0d2cf727f17a',
+ mime_type: "application/octet-stream",
+ created_at: Time.parse("2023-09-26T14:45:25Z"),
+ last_modified_at: Time.parse("2023-09-26T14:46:13Z"),
+ owner_name: "Eric Schubert",
+ owner_id: "0a0d38a9-a59b-4245-93fa-0d2cf727f17a",
+ last_modified_by_name: "Eric Schubert",
+ last_modified_by_id: "0a0d38a9-a59b-4245-93fa-0d2cf727f17a",
permissions: nil,
trashed: false,
- location: '/Folder/Subfolder/NextcloudHub.md'
+ location: "/Folder/Subfolder/NextcloudHub.md"
}
])
end,
@@ -148,11 +148,11 @@
end
end
- context 'with one outbound request returning not found', vcr: 'one_drive/files_info_query_one_not_found' do
- context 'with an array of file ids' do
+ context "with one outbound request returning not found", vcr: "one_drive/files_info_query_one_not_found" do
+ context "with an array of file ids" do
let(:file_ids) { %w[01AZJL5PJTICED3C5YSVAY6NWTBNA2XERU not_existent] }
- it 'must return an array of file information when called' do
+ it "must return an array of file information when called" do
result = subject.call(user:, file_ids:)
expect(result).to be_success
@@ -160,8 +160,8 @@
on_success: ->(file_infos) do
expect(file_infos.size).to eq(2)
expect(file_infos).to all(be_a(Storages::StorageFileInfo))
- expect(file_infos[1].id).to eq('not_existent')
- expect(file_infos[1].status).to eq('itemNotFound')
+ expect(file_infos[1].id).to eq("not_existent")
+ expect(file_infos[1].status).to eq("itemNotFound")
expect(file_infos[1].status_code).to eq(404)
end,
on_failure: ->(error) { fail "Expected success, got #{error}" }
@@ -170,7 +170,7 @@
end
end
- context 'with invalid oauth token', vcr: 'one_drive/files_info_query_invalid_token' do
+ context "with invalid oauth token", vcr: "one_drive/files_info_query_invalid_token" do
before do
token = build_stubbed(:oauth_client_token, oauth_client: storage.oauth_client)
allow(Storages::Peripherals::StorageInteraction::OneDrive::Util)
@@ -178,10 +178,10 @@
.and_yield(token)
end
- context 'with an array of file ids' do
+ context "with an array of file ids" do
let(:file_ids) { %w[01AZJL5PKU2WV3U3RKKFF2A7ZCWVBXRTEU] }
- it 'must return an array of file information when called' do
+ it "must return an array of file information when called" do
result = subject.call(user:, file_ids:)
expect(result).to be_success
@@ -189,8 +189,8 @@
on_success: ->(file_infos) do
expect(file_infos.size).to eq(1)
expect(file_infos).to all(be_a(Storages::StorageFileInfo))
- expect(file_infos[0].id).to eq('01AZJL5PKU2WV3U3RKKFF2A7ZCWVBXRTEU')
- expect(file_infos[0].status).to eq('InvalidAuthenticationToken')
+ expect(file_infos[0].id).to eq("01AZJL5PKU2WV3U3RKKFF2A7ZCWVBXRTEU")
+ expect(file_infos[0].status).to eq("InvalidAuthenticationToken")
expect(file_infos[0].status_code).to eq(401)
end,
on_failure: ->(error) { fail "Expected success, got #{error}" }
@@ -199,11 +199,11 @@
end
end
- context 'with not existent oauth token' do
+ context "with not existent oauth token" do
let(:file_ids) { %w[01AZJL5PKU2WV3U3RKKFF2A7ZCWVBXRTEU] }
let(:user_without_token) { create(:user) }
- it 'must return unauthorized when called' do
+ it "must return unauthorized when called" do
result = subject.call(user: user_without_token, file_ids:)
expect(result).to be_failure
expect(result.error_source).to be_a(OAuthClients::ConnectionManager)
@@ -215,17 +215,17 @@
end
end
- context 'with network errors' do
+ context "with network errors" do
let(:file_ids) { %w[01AZJL5PKU2WV3U3RKKFF2A7ZCWVBXRTEU] }
before do
- request = HTTPX::Request.new(:get, 'https://my.timeout.org/')
- httpx_double = class_double(HTTPX, get: HTTPX::ErrorResponse.new(request, 'Timeout happens', {}))
+ request = HTTPX::Request.new(:get, "https://my.timeout.org/")
+ httpx_double = class_double(HTTPX, get: HTTPX::ErrorResponse.new(request, "Timeout happens", {}))
allow(OpenProject).to receive(:httpx).and_return(httpx_double)
end
- it 'must return an array of file information when called' do
+ it "must return an array of file information when called" do
result = subject.call(user:, file_ids:)
expect(result).to be_success
@@ -233,8 +233,8 @@
on_success: ->(file_infos) do
expect(file_infos.size).to eq(1)
expect(file_infos).to all(be_a(Storages::StorageFileInfo))
- expect(file_infos[0].id).to eq('01AZJL5PKU2WV3U3RKKFF2A7ZCWVBXRTEU')
- expect(file_infos[0].status).to eq('Timeout happens')
+ expect(file_infos[0].id).to eq("01AZJL5PKU2WV3U3RKKFF2A7ZCWVBXRTEU")
+ expect(file_infos[0].status).to eq("Timeout happens")
expect(file_infos[0].status_code).to eq(500)
end,
on_failure: ->(error) { fail "Expected success, got #{error}" }
diff --git a/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/rename_file_command_spec.rb b/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/rename_file_command_spec.rb
index f485a4d961c6..7109f67a52d7 100644
--- a/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/rename_file_command_spec.rb
+++ b/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/rename_file_command_spec.rb
@@ -28,31 +28,31 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Peripherals::StorageInteraction::OneDrive::RenameFileCommand, :webmock do
let(:storage) { create(:sharepoint_dev_drive_storage) }
let(:folder) do
Storages::Peripherals::Registry
- .resolve('one_drive.commands.create_folder')
+ .resolve("one_drive.commands.create_folder")
.call(storage:, folder_path: "Wrong Name")
end
subject(:command) { described_class.new(storage) }
- it 'is registered as rename_file' do
- expect(Storages::Peripherals::Registry.resolve('one_drive.commands.rename_file')).to eq(described_class)
+ it "is registered as rename_file" do
+ expect(Storages::Peripherals::Registry.resolve("one_drive.commands.rename_file")).to eq(described_class)
end
- it 'responds to .call with correct parameters' do
+ it "responds to .call with correct parameters" do
expect(described_class).to respond_to(:call)
method = described_class.method(:call)
expect(method.parameters).to contain_exactly(%i[keyreq storage], %i[keyreq source], %i[keyreq target])
end
- it 'renames a folder', vcr: 'one_drive/rename_folder_success' do
+ it "renames a folder", vcr: "one_drive/rename_folder_success" do
file_info = folder.result
result = command.call(source: file_info.id, target: "My Project No. 1 (19)")
@@ -70,7 +70,7 @@
def delete_folder(folder_id)
Storages::Peripherals::Registry
- .resolve('one_drive.commands.delete_folder')
+ .resolve("one_drive.commands.delete_folder")
.call(storage:, location: folder_id)
end
end
diff --git a/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/set_permissions_command_spec.rb b/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/set_permissions_command_spec.rb
index b341f70bff59..8769edf4b867 100644
--- a/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/set_permissions_command_spec.rb
+++ b/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/set_permissions_command_spec.rb
@@ -28,116 +28,116 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Peripherals::StorageInteraction::OneDrive::SetPermissionsCommand, :webmock do
let(:storage) do
create(:sharepoint_dev_drive_storage,
- drive_id: 'b!dmVLG22QlE2PSW0AqVB7UOhZ8n7tjkVGkgqLNnuw2ODRDvn3haLiQIhB5UYNdqMy')
+ drive_id: "b!dmVLG22QlE2PSW0AqVB7UOhZ8n7tjkVGkgqLNnuw2ODRDvn3haLiQIhB5UYNdqMy")
end
let(:permissions_command) { described_class.new(storage) }
let(:folder) do
Storages::Peripherals::Registry
- .resolve('one_drive.commands.create_folder')
+ .resolve("one_drive.commands.create_folder")
.call(storage:, folder_path: "Permission Test Folder")
.result
end
let(:path) { folder.id }
- it 'is registered at commands.one_drive.set_permissions' do
- expect(Storages::Peripherals::Registry.resolve('one_drive.commands.set_permissions')).to eq(described_class)
+ it "is registered at commands.one_drive.set_permissions" do
+ expect(Storages::Peripherals::Registry.resolve("one_drive.commands.set_permissions")).to eq(described_class)
end
- it 'responds to .call with storage, path and permissions keyword args' do
+ it "responds to .call with storage, path and permissions keyword args" do
expect(described_class).to respond_to(:call)
method = described_class.method(:call)
expect(method.parameters).to contain_exactly(%i[keyreq storage], %i[keyreq path], %i[keyreq permissions])
end
- describe '#call' do
+ describe "#call" do
after do
Storages::Peripherals::Registry
- .resolve('one_drive.commands.delete_folder')
+ .resolve("one_drive.commands.delete_folder")
.call(storage:, location: path)
end
- context 'when trying to access a non-existing driveItem' do
- it 'returns a failure', vcr: 'one_drive/set_permissions_not_found_folder' do
- result = permissions_command.call(path: 'THIS_IS_NOT_THE_FOLDER_YOURE_LOOKING_FOR', permissions: { write: [] })
+ context "when trying to access a non-existing driveItem" do
+ it "returns a failure", vcr: "one_drive/set_permissions_not_found_folder" do
+ result = permissions_command.call(path: "THIS_IS_NOT_THE_FOLDER_YOURE_LOOKING_FOR", permissions: { write: [] })
expect(result).to be_failure
expect(result.result).to eq(:not_found)
end
end
- context 'when a permission set already exists' do
- it 'replaces the write permission grant with the provided list',
- vcr: 'one_drive/set_permissions_replace_permissions_write' do
- permissions_command.call(path:, permissions: { write: ['84acc1d5-61be-470b-9d79-0d1f105c2c5f'] })
- expect(user_list('write')).to match_array('84acc1d5-61be-470b-9d79-0d1f105c2c5f')
+ context "when a permission set already exists" do
+ it "replaces the write permission grant with the provided list",
+ vcr: "one_drive/set_permissions_replace_permissions_write" do
+ permissions_command.call(path:, permissions: { write: ["84acc1d5-61be-470b-9d79-0d1f105c2c5f"] })
+ expect(user_list("write")).to match_array("84acc1d5-61be-470b-9d79-0d1f105c2c5f")
- permissions_command.call(path:, permissions: { write: ['d6e00f6d-1ae7-43e6-b0af-15d99a56d4ce'] })
- expect(user_list('write')).to match_array('d6e00f6d-1ae7-43e6-b0af-15d99a56d4ce')
+ permissions_command.call(path:, permissions: { write: ["d6e00f6d-1ae7-43e6-b0af-15d99a56d4ce"] })
+ expect(user_list("write")).to match_array("d6e00f6d-1ae7-43e6-b0af-15d99a56d4ce")
end
- it 'replaces the read permission grant with the provided list',
- vcr: 'one_drive/set_permissions_replace_permissions_read' do
- permissions_command.call(path:, permissions: { read: ['84acc1d5-61be-470b-9d79-0d1f105c2c5f'] })
- expect(user_list('read')).to match_array('84acc1d5-61be-470b-9d79-0d1f105c2c5f')
+ it "replaces the read permission grant with the provided list",
+ vcr: "one_drive/set_permissions_replace_permissions_read" do
+ permissions_command.call(path:, permissions: { read: ["84acc1d5-61be-470b-9d79-0d1f105c2c5f"] })
+ expect(user_list("read")).to match_array("84acc1d5-61be-470b-9d79-0d1f105c2c5f")
- permissions_command.call(path:, permissions: { read: ['d6e00f6d-1ae7-43e6-b0af-15d99a56d4ce'] })
- expect(user_list('read')).to match_array('d6e00f6d-1ae7-43e6-b0af-15d99a56d4ce')
+ permissions_command.call(path:, permissions: { read: ["d6e00f6d-1ae7-43e6-b0af-15d99a56d4ce"] })
+ expect(user_list("read")).to match_array("d6e00f6d-1ae7-43e6-b0af-15d99a56d4ce")
end
end
- context 'when no expected permission exists' do
- it 'creates the write permission', vcr: 'one_drive/set_permissions_create_permission_write' do
+ context "when no expected permission exists" do
+ it "creates the write permission", vcr: "one_drive/set_permissions_create_permission_write" do
current_roles = remote_permissions.map { |permission| permission[:roles].first }
- expect(current_roles).not_to include('write')
+ expect(current_roles).not_to include("write")
- permissions_command.call(path:, permissions: { write: ['d6e00f6d-1ae7-43e6-b0af-15d99a56d4ce'] })
+ permissions_command.call(path:, permissions: { write: ["d6e00f6d-1ae7-43e6-b0af-15d99a56d4ce"] })
current_roles = remote_permissions.map { |permission| permission[:roles].first }
- expect(current_roles).to include('write')
+ expect(current_roles).to include("write")
end
- it 'creates the read permission', vcr: 'one_drive/set_permissions_create_permission_read' do
+ it "creates the read permission", vcr: "one_drive/set_permissions_create_permission_read" do
current_roles = remote_permissions.map { |permission| permission[:roles].first }
- expect(current_roles).not_to include('read')
+ expect(current_roles).not_to include("read")
- permissions_command.call(path:, permissions: { read: ['d6e00f6d-1ae7-43e6-b0af-15d99a56d4ce'] })
+ permissions_command.call(path:, permissions: { read: ["d6e00f6d-1ae7-43e6-b0af-15d99a56d4ce"] })
current_roles = remote_permissions.map { |permission| permission[:roles].first }
- expect(current_roles).to include('read')
+ expect(current_roles).to include("read")
end
end
- context 'when there are no user to set permissions' do
- it 'deletes the write permission', vcr: 'one_drive/set_permissions_delete_permission_write' do
- permissions_command.call(path:, permissions: { write: ['d6e00f6d-1ae7-43e6-b0af-15d99a56d4ce'] })
+ context "when there are no user to set permissions" do
+ it "deletes the write permission", vcr: "one_drive/set_permissions_delete_permission_write" do
+ permissions_command.call(path:, permissions: { write: ["d6e00f6d-1ae7-43e6-b0af-15d99a56d4ce"] })
current_roles = remote_permissions.map { |permission| permission[:roles].first }
- expect(current_roles).to include('write')
+ expect(current_roles).to include("write")
permissions_command.call(path:, permissions: { write: [] })
current_roles = remote_permissions.map { |permission| permission[:roles].first }
- expect(current_roles).not_to include('write')
+ expect(current_roles).not_to include("write")
end
- it 'deletes the read permission', vcr: 'one_drive/set_permissions_delete_permission_read' do
- permissions_command.call(path:, permissions: { read: ['d6e00f6d-1ae7-43e6-b0af-15d99a56d4ce'] })
+ it "deletes the read permission", vcr: "one_drive/set_permissions_delete_permission_read" do
+ permissions_command.call(path:, permissions: { read: ["d6e00f6d-1ae7-43e6-b0af-15d99a56d4ce"] })
current_roles = remote_permissions.map { |permission| permission[:roles].first }
- expect(current_roles).to include('read')
+ expect(current_roles).to include("read")
permissions_command.call(path:, permissions: { read: [] })
current_roles = remote_permissions.map { |permission| permission[:roles].first }
- expect(current_roles).not_to include('read')
+ expect(current_roles).not_to include("read")
end
end
end
diff --git a/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/upload_link_query_spec.rb b/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/upload_link_query_spec.rb
index 2ea2acbe02af..0b36c3d23183 100644
--- a/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/upload_link_query_spec.rb
+++ b/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/upload_link_query_spec.rb
@@ -28,16 +28,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Peripherals::StorageInteraction::OneDrive::UploadLinkQuery, :webmock do
- let(:storage) { create(:one_drive_storage, :with_oauth_client, drive_id: 'b!~bunchOfLettersAndNumb3rs') }
+ let(:storage) { create(:one_drive_storage, :with_oauth_client, drive_id: "b!~bunchOfLettersAndNumb3rs") }
let(:token) { create(:oauth_client_token, oauth_client: storage.oauth_client) }
let(:user) { token.user }
# Need to verify the actual object
- let(:query_payload) { { 'parent' => 'LFHLUDSILANC', 'file_name' => 'it_is_a_trap.flac' } }
+ let(:query_payload) { { "parent" => "LFHLUDSILANC", "file_name" => "it_is_a_trap.flac" } }
subject(:upload_query) { described_class.new(storage) }
@@ -46,31 +46,31 @@
:post,
"https://graph.microsoft.com/v1.0/drives/b!~bunchOfLettersAndNumb3rs/items/LFHLUDSILANC:/it_is_a_trap.flac:/createUploadSession"
).with(
- headers: { 'Authorization' => "Bearer #{token.access_token}", 'Content-Type' => 'application/json' },
- body: { item: { "@microsoft.graph.conflictBehavior" => "rename", name: query_payload['file_name'] } }
+ headers: { "Authorization" => "Bearer #{token.access_token}", "Content-Type" => "application/json" },
+ body: { item: { "@microsoft.graph.conflictBehavior" => "rename", name: query_payload["file_name"] } }
).to_return(
status: 200,
- headers: { 'Content-Type' => 'application/json' },
+ headers: { "Content-Type" => "application/json" },
body: { uploadUrl: "https://sn3302.up.1drv.com/up/fe6987415ace7X4e1eF866337",
expirationDateTime: "2015-01-29T09:21:55.523Z" }.to_json
)
end
- it '.call requires 3 arguments: storage, user, and data' do
+ it ".call requires 3 arguments: storage, user, and data" do
expect(described_class).to respond_to(:call)
method = described_class.method(:call)
expect(method.parameters).to contain_exactly(%i[keyreq storage], %i[keyreq user], %i[keyreq data])
end
- it 'must return an upload link URL' do
+ it "must return an upload link URL" do
link = upload_query.call(user:, data: query_payload).result
expect(link.destination).not_to be_nil
expect(link.method).to eq(:put)
end
- shared_examples_for 'outbound is failing' do |code, symbol|
+ shared_examples_for "outbound is failing" do |code, symbol|
describe "with outbound request returning #{code}" do
before do
stub_request(
@@ -87,8 +87,8 @@
end
end
- include_examples 'outbound is failing', 400, :error
- include_examples 'outbound is failing', 401, :unauthorized
- include_examples 'outbound is failing', 404, :not_found
- include_examples 'outbound is failing', 500, :error
+ include_examples "outbound is failing", 400, :error
+ include_examples "outbound is failing", 401, :unauthorized
+ include_examples "outbound is failing", 404, :not_found
+ include_examples "outbound is failing", 500, :error
end
diff --git a/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/util_spec.rb b/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/util_spec.rb
index 28a3795fa225..8919c7aeb761 100644
--- a/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/util_spec.rb
+++ b/modules/storages/spec/common/storages/peripherals/storage_interaction/one_drive/util_spec.rb
@@ -28,45 +28,45 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Peripherals::StorageInteraction::OneDrive::Util do
let(:storage) { create(:sharepoint_dev_drive_storage) }
- describe '.using_admin_token' do
- it 'return a httpx session with an authorization header', vcr: 'one_drive/utils_access_tokens' do
+ describe ".using_admin_token" do
+ it "return a httpx session with an authorization header", vcr: "one_drive/utils_access_tokens" do
described_class.using_admin_token(storage) do |http|
expect(http).to be_a(HTTPX::Session)
- authorization_header = extract_headers(http)['authorization']
+ authorization_header = extract_headers(http)["authorization"]
expect(authorization_header).not_to be_nil
expect(authorization_header).to match /Bearer .+$/
end
end
- it 'caches the token', vcr: 'one_drive/utils_access_token' do
+ it "caches the token", vcr: "one_drive/utils_access_token" do
described_class.using_admin_token(storage) do |http|
- cached = Rails.cache.fetch("storage.#{storage.id}.access_token") { fail 'No value found in the cache' }
- token = extract_headers(http)['authorization'].split.last
+ cached = Rails.cache.fetch("storage.#{storage.id}.access_token") { fail "No value found in the cache" }
+ token = extract_headers(http)["authorization"].split.last
expect(cached.result).not_to be_nil
expect(cached.result.access_token).to eq(token)
end
end
- context 'when getting the token fails' do
- it 'returns a ServiceResult.failure', vcr: 'one_drive/util_access_token_failure' do
- storage.oauth_client.update(client_secret: 'this_is_wrong')
+ context "when getting the token fails" do
+ it "returns a ServiceResult.failure", vcr: "one_drive/util_access_token_failure" do
+ storage.oauth_client.update(client_secret: "this_is_wrong")
- result = described_class.using_admin_token(storage) { |_| fail 'this should not run' }
+ result = described_class.using_admin_token(storage) { |_| fail "this should not run" }
expect(result).to be_failure
end
- it 'does not store data in the cache', vcr: 'one_drive/util_access_token_failure' do
- storage.oauth_client.update(client_secret: 'this_is_wrong')
- described_class.using_admin_token(storage) { |_| fail 'this should not run' }
+ it "does not store data in the cache", vcr: "one_drive/util_access_token_failure" do
+ storage.oauth_client.update(client_secret: "this_is_wrong")
+ described_class.using_admin_token(storage) { |_| fail "this should not run" }
cached = Rails.cache.fetch("storage.#{storage.id}.access_token")
expect(cached).to be_nil
diff --git a/modules/storages/spec/components/project_storages/row_component_spec.rb b/modules/storages/spec/components/project_storages/row_component_spec.rb
index b4bc90554af6..94d176a06c2f 100644
--- a/modules/storages/spec/components/project_storages/row_component_spec.rb
+++ b/modules/storages/spec/components/project_storages/row_component_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
#
-require_relative '../../spec_helper'
+require_relative "../../spec_helper"
RSpec.describe Storages::ProjectStorages::RowComponent,
type: :component do
- describe '#button_links' do
- context 'with non-automatic project storage' do
- it 'renders edit and delete buttons' do
+ describe "#button_links" do
+ context "with non-automatic project storage" do
+ it "renders edit and delete buttons" do
project_storage = build_stubbed(:project_storage)
expect(project_storage).not_to be_project_folder_automatic
@@ -41,14 +41,14 @@
render_inline(component)
- expect(page).to have_no_css('a.icon.icon-group')
- expect(page).to have_css('a.icon.icon-edit')
- expect(page).to have_css('a.icon.icon-delete')
+ expect(page).to have_no_css("a.icon.icon-group")
+ expect(page).to have_css("a.icon.icon-edit")
+ expect(page).to have_css("a.icon.icon-delete")
end
end
- context 'with automatic project storage' do
- it 'renders members connection status, edit and delete buttons' do
+ context "with automatic project storage" do
+ it "renders members connection status, edit and delete buttons" do
project_storage = build_stubbed(:project_storage, :as_automatically_managed)
expect(project_storage).to be_project_folder_automatic
@@ -57,9 +57,9 @@
render_inline(component)
- expect(page).to have_css('a.icon.icon-group')
- expect(page).to have_css('a.icon.icon-edit')
- expect(page).to have_css('a.icon.icon-delete')
+ expect(page).to have_css("a.icon.icon-group")
+ expect(page).to have_css("a.icon.icon-edit")
+ expect(page).to have_css("a.icon.icon-delete")
end
end
end
diff --git a/modules/storages/spec/components/storages/admin/health_status_component_spec.rb b/modules/storages/spec/components/storages/admin/health_status_component_spec.rb
index 8a3f32857415..efc6df63df9a 100644
--- a/modules/storages/spec/components/storages/admin/health_status_component_spec.rb
+++ b/modules/storages/spec/components/storages/admin/health_status_component_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
#
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Admin::HealthStatusComponent, type: :component do
@@ -39,55 +39,55 @@
render_inline(health_status_component)
end
- context 'with healthy storage' do
+ context "with healthy storage" do
shared_let(:storage) do
travel_to(frozen_date_time) do
create(:nextcloud_storage_with_complete_configuration, :as_healthy)
end
end
- it 'shows a healthy status' do
- expect(page).to have_test_selector('storage-health-label-healthy', text: 'Healthy')
- expect(page).to have_test_selector('storage-health-checked-at', text: "Last checked 11/28/2023 01:02 AM")
+ it "shows a healthy status" do
+ expect(page).to have_test_selector("storage-health-label-healthy", text: "Healthy")
+ expect(page).to have_test_selector("storage-health-checked-at", text: "Last checked 11/28/2023 01:02 AM")
end
end
- context 'with storage health pending' do
+ context "with storage health pending" do
shared_let(:storage) do
travel_to(frozen_date_time) do
create(:nextcloud_storage_with_complete_configuration)
end
end
- it 'shows pending label' do
- expect(page).to have_test_selector('storage-health-label-pending', text: 'Pending')
+ it "shows pending label" do
+ expect(page).to have_test_selector("storage-health-label-pending", text: "Pending")
end
end
- context 'with unhealthy storage' do
+ context "with unhealthy storage" do
shared_let(:storage) do
travel_to(frozen_date_time) do
create(:nextcloud_storage_with_complete_configuration, :as_unhealthy)
end
end
- it 'shows an error status' do
- expect(page).to have_test_selector('storage-health-label-error', text: 'Error')
- expect(page).to have_test_selector('storage-health-reason', text: 'Error code: description since 11/28/2023 01:02 AM')
+ it "shows an error status" do
+ expect(page).to have_test_selector("storage-health-label-error", text: "Error")
+ expect(page).to have_test_selector("storage-health-reason", text: "Error code: description since 11/28/2023 01:02 AM")
end
end
- context 'with unhealthy storage, long reason' do
+ context "with unhealthy storage, long reason" do
shared_let(:storage) do
travel_to(frozen_date_time) do
create(:nextcloud_storage_with_complete_configuration, :as_unhealthy_long_reason)
end
end
- it 'shows a formatted error reason' do
- expect(page).to have_test_selector('storage-health-label-error', text: 'Error')
- expect(page).to have_test_selector('storage-health-reason',
- text: 'Unauthorized: Outbound request not authorized since 11/28/2023 01:02 AM')
+ it "shows a formatted error reason" do
+ expect(page).to have_test_selector("storage-health-label-error", text: "Error")
+ expect(page).to have_test_selector("storage-health-reason",
+ text: "Unauthorized: Outbound request not authorized since 11/28/2023 01:02 AM")
end
end
end
diff --git a/modules/storages/spec/components/storages/admin/new_storage_button_component_spec.rb b/modules/storages/spec/components/storages/admin/new_storage_button_component_spec.rb
index 3694a38b2013..1ded64dab4f8 100644
--- a/modules/storages/spec/components/storages/admin/new_storage_button_component_spec.rb
+++ b/modules/storages/spec/components/storages/admin/new_storage_button_component_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
#
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Admin::NewStorageButtonComponent, type: :component do
@@ -34,9 +34,9 @@
it 'renders a "New Storage" Action Menu' do
render_inline(described_class.new)
- expect(page).to have_button 'Storage', aria: { label: 'Add new storage' }
+ expect(page).to have_button "Storage", aria: { label: "Add new storage" }
- expect(page).to have_link 'Nextcloud', href: select_provider_admin_settings_storages_path(provider: 'nextcloud')
- expect(page).to have_link 'OneDrive/SharePoint', href: select_provider_admin_settings_storages_path(provider: 'one_drive')
+ expect(page).to have_link "Nextcloud", href: select_provider_admin_settings_storages_path(provider: "nextcloud")
+ expect(page).to have_link "OneDrive/SharePoint", href: select_provider_admin_settings_storages_path(provider: "one_drive")
end
end
diff --git a/modules/storages/spec/components/storages/admin/oauth_access_grant_nudge_modal_component_spec.rb b/modules/storages/spec/components/storages/admin/oauth_access_grant_nudge_modal_component_spec.rb
index 03aea4066874..d8751f10a29e 100644
--- a/modules/storages/spec/components/storages/admin/oauth_access_grant_nudge_modal_component_spec.rb
+++ b/modules/storages/spec/components/storages/admin/oauth_access_grant_nudge_modal_component_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
#
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Admin::OAuthAccessGrantNudgeModalComponent, type: :component do # rubocop:disable RSpec/SpecFilePathFormat
@@ -36,52 +36,52 @@
render_inline(oauth_access_grant_nudge_modal_component)
end
- context 'with access pending authorization' do
+ context "with access pending authorization" do
let(:oauth_access_grant_nudge_modal_component) { described_class.new(project_storage:) }
- it 'renders the nudge modal' do
- expect(page).to have_css('[role="alert"]', text: 'One more step...', aria: { live: :assertive })
+ it "renders the nudge modal" do
+ expect(page).to have_css('[role="alert"]', text: "One more step...", aria: { live: :assertive })
expect(page).to have_test_selector(
- 'oauth-access-grant-nudge-modal-body',
+ "oauth-access-grant-nudge-modal-body",
text: "To get access to the project folder you need to login to #{project_storage.storage.name}.",
aria: { hidden: false }
)
- expect(page).to have_button('I will do it later')
- expect(page).to have_button('Login', aria: { label: "Login to #{project_storage.storage.name}" })
+ expect(page).to have_button("I will do it later")
+ expect(page).to have_button("Login", aria: { label: "Login to #{project_storage.storage.name}" })
end
end
- context 'with access authorized' do
+ context "with access authorized" do
let(:oauth_access_grant_nudge_modal_component) do
described_class.new(project_storage:, authorized: true)
end
- it 'renders a success modal' do
+ it "renders a success modal" do
expect(page).to have_css(
- 'h1.sr-only',
+ "h1.sr-only",
text: "Access granted. You are now ready to use #{project_storage.storage.name}"
)
expect(page).to have_test_selector(
- 'oauth-access-grant-nudge-modal-body',
- text: 'Access granted',
+ "oauth-access-grant-nudge-modal-body",
+ text: "Access granted",
aria: { hidden: true }
)
expect(page).to have_test_selector(
- 'oauth-access-grant-nudge-modal-body',
+ "oauth-access-grant-nudge-modal-body",
text: "You are now ready to use #{project_storage.storage.name}",
aria: { hidden: true }
)
- expect(page).to have_button('Close')
+ expect(page).to have_button("Close")
end
end
- context 'with no project storage' do
+ context "with no project storage" do
let(:oauth_access_grant_nudge_modal_component) { described_class.new(project_storage: nil) }
- it 'does not render' do
+ it "does not render" do
expect(page.text).to be_empty
end
end
diff --git a/modules/storages/spec/components/storages/admin/oauth_client_info_component_spec.rb b/modules/storages/spec/components/storages/admin/oauth_client_info_component_spec.rb
index 381532c65a8a..e9942019b621 100644
--- a/modules/storages/spec/components/storages/admin/oauth_client_info_component_spec.rb
+++ b/modules/storages/spec/components/storages/admin/oauth_client_info_component_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
#
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Admin::OAuthClientInfoComponent, type: :component do # rubocop:disable RSpec/SpecFilePathFormat
- describe '#edit_icon_button_options' do
- context 'with oauth client configured' do
- it 'returns false, does not render view component' do
+ describe "#edit_icon_button_options" do
+ context "with oauth client configured" do
+ it "returns false, does not render view component" do
storage = build_stubbed(:nextcloud_storage,
oauth_client: build_stubbed(:oauth_client))
component = described_class.new(storage:, oauth_client: storage.oauth_client)
@@ -46,8 +46,8 @@
end
end
- context 'without oauth client' do
- it 'returns true, renders view component' do
+ context "without oauth client" do
+ it "returns true, renders view component" do
storage = build_stubbed(:nextcloud_storage)
component = described_class.new(storage:, oauth_client: nil)
diff --git a/modules/storages/spec/components/storages/admin/storage_list_component_spec.rb b/modules/storages/spec/components/storages/admin/storage_list_component_spec.rb
index dd688c6d41b6..22ca86a8eb87 100644
--- a/modules/storages/spec/components/storages/admin/storage_list_component_spec.rb
+++ b/modules/storages/spec/components/storages/admin/storage_list_component_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
#
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Admin::StorageListComponent, type: :component do
@@ -41,18 +41,18 @@
render_inline(storage_list_component)
end
- context 'with storages' do
- it 'lists all storages' do
+ context "with storages" do
+ it "lists all storages" do
expect(page).to have_list_item(count: 2)
expect(page).to have_list_item(nextcloud_storage.name)
expect(page).to have_list_item(one_drive_storage.name)
end
end
- context 'with no storages' do
+ context "with no storages" do
let(:storages) { [] }
- it 'renders a blank slate' do
+ it "renders a blank slate" do
expect(page).to have_text("You don't have any storages yet.")
end
end
diff --git a/modules/storages/spec/components/storages/admin/storage_row_component_spec.rb b/modules/storages/spec/components/storages/admin/storage_row_component_spec.rb
index d9954ac0ed60..0bf605083c0a 100644
--- a/modules/storages/spec/components/storages/admin/storage_row_component_spec.rb
+++ b/modules/storages/spec/components/storages/admin/storage_row_component_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
#
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Admin::StorageRowComponent, type: :component do
@@ -38,92 +38,92 @@
render_inline(storage_row_component)
end
- describe 'Nextcloud storage' do
- shared_examples 'a Nextcloud storage row' do
- it 'render the storage name' do
+ describe "Nextcloud storage" do
+ shared_examples "a Nextcloud storage row" do
+ it "render the storage name" do
expect(page).to have_link(storage.name, href: edit_admin_settings_storage_path(storage))
end
- it 'renders the storage creator' do
- pending 'Invisible on small screens: Find a way to render inline'
- expect(page).to have_test_selector('storage-creator', text: storage.creator.name)
+ it "renders the storage creator" do
+ pending "Invisible on small screens: Find a way to render inline"
+ expect(page).to have_test_selector("storage-creator", text: storage.creator.name)
end
- it 'renders the storage provider' do
- expect(page).to have_test_selector('storage-provider', text: 'Nextcloud')
+ it "renders the storage provider" do
+ expect(page).to have_test_selector("storage-provider", text: "Nextcloud")
end
- it 'renders the storage host' do
- expect(page).to have_test_selector('storage-host', text: storage.host)
+ it "renders the storage host" do
+ expect(page).to have_test_selector("storage-host", text: storage.host)
end
end
- context 'with complete storage' do
+ context "with complete storage" do
shared_let(:storage) { create(:nextcloud_storage_with_local_connection) }
- it_behaves_like 'a Nextcloud storage row'
+ it_behaves_like "a Nextcloud storage row"
- it 'does not show an incomplete label' do
- expect(page).not_to have_test_selector('label-incomplete')
+ it "does not show an incomplete label" do
+ expect(page).not_to have_test_selector("label-incomplete")
end
end
- context 'with incomplete storage' do
+ context "with incomplete storage" do
shared_let(:storage) { create(:nextcloud_storage) }
- it_behaves_like 'a Nextcloud storage row'
+ it_behaves_like "a Nextcloud storage row"
it 'renders an "Incomplete" label' do
- expect(page).to have_test_selector('label-incomplete', text: 'Incomplete')
+ expect(page).to have_test_selector("label-incomplete", text: "Incomplete")
end
end
- context 'with unhealthy storage' do
+ context "with unhealthy storage" do
shared_let(:storage) do
create(:nextcloud_storage_with_complete_configuration, :as_unhealthy)
end
- it_behaves_like 'a Nextcloud storage row'
+ it_behaves_like "a Nextcloud storage row"
it 'renders an "Error" label' do
- expect(page).to have_test_selector('storage-health-label-error', text: 'Error')
+ expect(page).to have_test_selector("storage-health-label-error", text: "Error")
end
end
end
- describe 'OneDrive/SharePoint storage' do
- shared_examples 'a OneDrive/SharePoint storage row' do
- it 'render the storage name' do
+ describe "OneDrive/SharePoint storage" do
+ shared_examples "a OneDrive/SharePoint storage row" do
+ it "render the storage name" do
expect(page).to have_link(storage.name, href: edit_admin_settings_storage_path(storage))
end
- it 'renders the storage creator' do
- pending 'Invisible on small screens: Find a way to render inline'
- expect(page).to have_test_selector('storage-creator', text: storage.creator.name)
+ it "renders the storage creator" do
+ pending "Invisible on small screens: Find a way to render inline"
+ expect(page).to have_test_selector("storage-creator", text: storage.creator.name)
end
- it 'renders the storage provider' do
- expect(page).to have_test_selector('storage-provider', text: 'OneDrive/SharePoint')
+ it "renders the storage provider" do
+ expect(page).to have_test_selector("storage-provider", text: "OneDrive/SharePoint")
end
end
- context 'with complete storage' do
+ context "with complete storage" do
shared_let(:storage) { create(:sharepoint_dev_drive_storage) }
- it_behaves_like 'a OneDrive/SharePoint storage row'
+ it_behaves_like "a OneDrive/SharePoint storage row"
- it 'does not show an incomplete label' do
- expect(page).not_to have_test_selector('label-incomplete')
+ it "does not show an incomplete label" do
+ expect(page).not_to have_test_selector("label-incomplete")
end
end
- context 'with incomplete storage' do
+ context "with incomplete storage" do
shared_let(:storage) { create(:one_drive_storage) }
- it_behaves_like 'a OneDrive/SharePoint storage row'
+ it_behaves_like "a OneDrive/SharePoint storage row"
it 'renders an "Incomplete" label' do
- expect(page).to have_test_selector('label-incomplete', text: 'Incomplete')
+ expect(page).to have_test_selector("label-incomplete", text: "Incomplete")
end
end
end
diff --git a/modules/storages/spec/contracts/storages/file_links/create_contract_spec.rb b/modules/storages/spec/contracts/storages/file_links/create_contract_spec.rb
index 04ec5bab054c..898afbaa5b13 100644
--- a/modules/storages/spec/contracts/storages/file_links/create_contract_spec.rb
+++ b/modules/storages/spec/contracts/storages/file_links/create_contract_spec.rb
@@ -26,30 +26,30 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require_relative 'shared_contract_examples'
+require_relative "shared_contract_examples"
RSpec.describe Storages::FileLinks::CreateContract do
- it_behaves_like 'file_link contract' do
+ it_behaves_like "file_link contract" do
let(:contract) { described_class.new(file_link, current_user) }
- context 'when creator is not the current user' do
+ context "when creator is not the current user" do
let(:file_link_creator) { build_stubbed(:user) }
- include_examples 'contract is invalid', creator: :invalid
+ include_examples "contract is invalid", creator: :invalid
end
- context 'with one drive storage and missing ee token', with_ee: false do
+ context "with one drive storage and missing ee token", with_ee: false do
let(:storage) { create(:one_drive_storage) }
- include_examples 'contract is invalid', base: I18n.t('api_v3.errors.code_500_missing_enterprise_token')
+ include_examples "contract is invalid", base: I18n.t("api_v3.errors.code_500_missing_enterprise_token")
end
- context 'with one drive storage and valid ee token', with_ee: %i[one_drive_sharepoint_file_storage] do
+ context "with one drive storage and valid ee token", with_ee: %i[one_drive_sharepoint_file_storage] do
let(:storage) { create(:one_drive_storage) }
- include_examples 'contract is valid'
+ include_examples "contract is valid"
end
end
end
diff --git a/modules/storages/spec/contracts/storages/file_links/delete_contract_spec.rb b/modules/storages/spec/contracts/storages/file_links/delete_contract_spec.rb
index d14a4ff24bc8..744ea35af08b 100644
--- a/modules/storages/spec/contracts/storages/file_links/delete_contract_spec.rb
+++ b/modules/storages/spec/contracts/storages/file_links/delete_contract_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require 'contracts/shared/model_contract_shared_context'
+require "contracts/shared/model_contract_shared_context"
RSpec.describe Storages::FileLinks::DeleteContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:current_user) { create(:user) }
let(:role) { create(:project_role, permissions: [:manage_file_links]) }
@@ -46,17 +46,17 @@
# Default test setup should be valid ("happy test setup").
# This tests works with manage_storages_in_project permissions for current_user.
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
# Now we remove the permissions from the user by creating a role without special perms.
- context 'without manage_storages_in_project permission for project' do
+ context "without manage_storages_in_project permission for project" do
let(:role) { create(:project_role) }
- it_behaves_like 'contract is invalid'
+ it_behaves_like "contract is invalid"
end
# Generic checks that the contract is valid for valid admin, but invalid otherwise
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
diff --git a/modules/storages/spec/contracts/storages/file_links/shared_contract_examples.rb b/modules/storages/spec/contracts/storages/file_links/shared_contract_examples.rb
index 433fd71c7648..9e2689f6dcd6 100644
--- a/modules/storages/spec/contracts/storages/file_links/shared_contract_examples.rb
+++ b/modules/storages/spec/contracts/storages/file_links/shared_contract_examples.rb
@@ -28,12 +28,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require 'contracts/shared/model_contract_shared_context'
+require "contracts/shared/model_contract_shared_context"
-RSpec.shared_examples_for 'file_link contract' do
- include_context 'ModelContract shared context'
+RSpec.shared_examples_for "file_link contract" do
+ include_context "ModelContract shared context"
let(:current_user) { create(:user) }
let(:role) { create(:project_role, permissions: [:manage_file_links]) }
@@ -50,125 +50,125 @@
let(:file_link_creator) { current_user }
let(:file_link_attributes) { {} }
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
- describe 'validations' do
- context 'when all attributes are valid' do
- it_behaves_like 'contract is valid'
+ describe "validations" do
+ context "when all attributes are valid" do
+ it_behaves_like "contract is valid"
end
- describe 'storage_id' do
- context 'when empty' do
+ describe "storage_id" do
+ context "when empty" do
let(:storage_id) { "" }
let(:file_link) { create(:file_link, container: work_package, storage_id:) }
- include_examples 'contract is invalid', storage: :blank
+ include_examples "contract is invalid", storage: :blank
end
end
- describe 'origin_id' do
- context 'when empty' do
- let(:file_link_attributes) { { origin_id: '' } }
+ describe "origin_id" do
+ context "when empty" do
+ let(:file_link_attributes) { { origin_id: "" } }
- include_examples 'contract is invalid', origin_id: %i[blank too_short]
+ include_examples "contract is invalid", origin_id: %i[blank too_short]
end
- context 'when nil' do
+ context "when nil" do
let(:file_link_attributes) { { origin_id: nil } }
- include_examples 'contract is invalid', origin_id: %i[blank too_short]
+ include_examples "contract is invalid", origin_id: %i[blank too_short]
end
- context 'when numeric' do
+ context "when numeric" do
let(:file_link_attributes) { { origin_id: 12345 } }
- include_examples 'contract is valid'
+ include_examples "contract is valid"
end
- context 'when uuid-like' do
- let(:file_link_attributes) { { origin_id: '5eda571a-819e-44b2-939c-2301f9322ac6' } }
+ context "when uuid-like" do
+ let(:file_link_attributes) { { origin_id: "5eda571a-819e-44b2-939c-2301f9322ac6" } }
- include_examples 'contract is valid'
+ include_examples "contract is valid"
end
- context 'when having non ascii characters' do
- let(:file_link_attributes) { { origin_id: 'Hëllò Wôrłd!' } }
+ context "when having non ascii characters" do
+ let(:file_link_attributes) { { origin_id: "Hëllò Wôrłd!" } }
- include_examples 'contract is valid'
+ include_examples "contract is valid"
end
- context 'when longer than 100 characters' do
- let(:file_link_attributes) { { origin_id: '1' * 201 } }
+ context "when longer than 100 characters" do
+ let(:file_link_attributes) { { origin_id: "1" * 201 } }
- include_examples 'contract is invalid', origin_id: :too_long
+ include_examples "contract is invalid", origin_id: :too_long
end
end
- describe 'origin_name' do
- context 'when empty' do
- let(:file_link_attributes) { { origin_name: '' } }
+ describe "origin_name" do
+ context "when empty" do
+ let(:file_link_attributes) { { origin_name: "" } }
- include_examples 'contract is invalid', origin_name: :blank
+ include_examples "contract is invalid", origin_name: :blank
end
- context 'when nil' do
+ context "when nil" do
let(:file_link_attributes) { { origin_name: nil } }
- include_examples 'contract is invalid', origin_name: :blank
+ include_examples "contract is invalid", origin_name: :blank
end
end
- describe 'origin_mime_type' do
- context 'when empty' do
- let(:file_link_attributes) { { origin_mime_type: '' } }
+ describe "origin_mime_type" do
+ context "when empty" do
+ let(:file_link_attributes) { { origin_mime_type: "" } }
- include_examples 'contract is valid'
+ include_examples "contract is valid"
end
- context 'when nil' do
+ context "when nil" do
let(:file_link_attributes) { { origin_mime_type: nil } }
- include_examples 'contract is valid'
+ include_examples "contract is valid"
end
- context 'when anything' do
- let(:file_link_attributes) { { origin_mime_type: 'abcdef/zyxwvut' } }
+ context "when anything" do
+ let(:file_link_attributes) { { origin_mime_type: "abcdef/zyxwvut" } }
- include_examples 'contract is valid'
+ include_examples "contract is valid"
end
- context 'when longer than 255 characters' do
- let(:file_link_attributes) { { origin_mime_type: 'a' * 256 } }
+ context "when longer than 255 characters" do
+ let(:file_link_attributes) { { origin_mime_type: "a" * 256 } }
- include_examples 'contract is invalid', origin_mime_type: :too_long
+ include_examples "contract is invalid", origin_mime_type: :too_long
end
end
- shared_examples_for 'optional attribute' do |params|
- context 'when nil' do
+ shared_examples_for "optional attribute" do |params|
+ context "when nil" do
let(:file_link_attributes) { params.transform_values { nil } }
- include_examples 'contract is valid'
+ include_examples "contract is valid"
end
context "when #{params.inspect}" do
let(:file_link_attributes) { params }
- include_examples 'contract is valid'
+ include_examples "contract is valid"
end
end
{
- origin_created_by_name: 'someone',
- origin_last_modified_by_name: 'someone',
+ origin_created_by_name: "someone",
+ origin_last_modified_by_name: "someone",
origin_created_at: Time.zone.now,
origin_updated_at: Time.zone.now
}.each do |(attribute, a_valid_value)|
describe attribute.name do
- it_behaves_like 'optional attribute', attribute => a_valid_value
+ it_behaves_like "optional attribute", attribute => a_valid_value
end
end
end
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
diff --git a/modules/storages/spec/contracts/storages/last_project_folders/base_contract_spec.rb b/modules/storages/spec/contracts/storages/last_project_folders/base_contract_spec.rb
index 7562957cf4c1..2e2618a31a34 100644
--- a/modules/storages/spec/contracts/storages/last_project_folders/base_contract_spec.rb
+++ b/modules/storages/spec/contracts/storages/last_project_folders/base_contract_spec.rb
@@ -28,48 +28,48 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require 'contracts/shared/model_contract_shared_context'
+require "contracts/shared/model_contract_shared_context"
RSpec.describe Storages::LastProjectFolders::BaseContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:last_project_folder) { build(:last_project_folder) }
let(:contract) { described_class.new(last_project_folder, build_stubbed(:admin)) }
- context 'if no project storage is given' do
+ context "if no project storage is given" do
before do
last_project_folder.project_storage = nil
end
- it_behaves_like 'contract is invalid'
+ it_behaves_like "contract is invalid"
end
- context 'if the project folder mode is `inactive`' do
+ context "if the project folder mode is `inactive`" do
before do
- last_project_folder.mode = 'inactive'
+ last_project_folder.mode = "inactive"
end
- it_behaves_like 'contract is invalid'
+ it_behaves_like "contract is invalid"
end
- context 'if the project folder mode is `manual`' do
+ context "if the project folder mode is `manual`" do
before do
- last_project_folder.mode = 'manual'
+ last_project_folder.mode = "manual"
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'if the project folder mode is `automatic`' do
+ context "if the project folder mode is `automatic`" do
before do
- last_project_folder.mode = 'automatic'
+ last_project_folder.mode = "automatic"
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
diff --git a/modules/storages/spec/contracts/storages/project_storages/base_contract_spec.rb b/modules/storages/spec/contracts/storages/project_storages/base_contract_spec.rb
index 546c483d2018..1d364cf1e434 100644
--- a/modules/storages/spec/contracts/storages/project_storages/base_contract_spec.rb
+++ b/modules/storages/spec/contracts/storages/project_storages/base_contract_spec.rb
@@ -28,61 +28,61 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require 'contracts/shared/model_contract_shared_context'
+require "contracts/shared/model_contract_shared_context"
RSpec.describe Storages::ProjectStorages::BaseContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:contract) { described_class.new(project_storage, build_stubbed(:admin)) }
let(:storage) { build_stubbed(:nextcloud_storage) }
let(:project_storage) { build(:project_storage, storage:) }
- context 'if the project folder mode is `inactive`' do
+ context "if the project folder mode is `inactive`" do
before do
- project_storage.project_folder_mode = 'inactive'
+ project_storage.project_folder_mode = "inactive"
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'if the project folder mode is `automatic`' do
+ context "if the project folder mode is `automatic`" do
before do
- project_storage.project_folder_mode = 'automatic'
+ project_storage.project_folder_mode = "automatic"
project_storage.storage.automatic_management_enabled = true
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'when the project folder mode is `automatic` but the storage is not automatically managed' do
+ context "when the project folder mode is `automatic` but the storage is not automatically managed" do
before do
- project_storage.project_folder_mode = 'automatic'
+ project_storage.project_folder_mode = "automatic"
project_storage.storage.automatic_management_enabled = false
end
- it_behaves_like 'contract is invalid', project_folder_mode: :mode_unavailable
+ it_behaves_like "contract is invalid", project_folder_mode: :mode_unavailable
end
- context 'if the project folder mode is `manual`' do
+ context "if the project folder mode is `manual`" do
before do
- project_storage.project_folder_mode = 'manual'
+ project_storage.project_folder_mode = "manual"
end
- context 'with no project_folder_id' do
- it_behaves_like 'contract is invalid', project_folder_id: :blank
+ context "with no project_folder_id" do
+ it_behaves_like "contract is invalid", project_folder_id: :blank
end
- context 'with project_folder_id' do
+ context "with project_folder_id" do
before do
- project_storage.project_folder_id = 'Project#1'
+ project_storage.project_folder_id = "Project#1"
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
end
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
diff --git a/modules/storages/spec/contracts/storages/project_storages/create_contract_spec.rb b/modules/storages/spec/contracts/storages/project_storages/create_contract_spec.rb
index 0df3cc186d04..d48546a5405d 100644
--- a/modules/storages/spec/contracts/storages/project_storages/create_contract_spec.rb
+++ b/modules/storages/spec/contracts/storages/project_storages/create_contract_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require_relative 'shared_contract_examples'
+require_relative "shared_contract_examples"
RSpec.describe Storages::ProjectStorages::CreateContract do
- it_behaves_like 'ProjectStorages contract' do
+ it_behaves_like "ProjectStorages contract" do
# current_user, project, storage and other objects defined in the shared_contract_examples
# that includes all the stuff shared between create and update.
let(:project_storage) do
@@ -48,7 +48,7 @@
described_class.new(project_storage, current_user)
end
- context 'when checking creator_id' do
+ context "when checking creator_id" do
let(:contract) { described_class.new(project_storage, current_user) }
let(:project_storage) { build(:project_storage, creator:) }
let(:current_user) { build_stubbed(:admin) }
@@ -57,16 +57,16 @@
login_as(current_user)
end
- context 'as creator_id == current_user_id' do
+ context "as creator_id == current_user_id" do
let(:creator) { current_user }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'as creator_id != current_user_id' do
+ context "as creator_id != current_user_id" do
let(:creator) { build_stubbed(:user) }
- it_behaves_like 'contract is invalid', creator: :invalid
+ it_behaves_like "contract is invalid", creator: :invalid
end
end
end
diff --git a/modules/storages/spec/contracts/storages/project_storages/delete_contract_spec.rb b/modules/storages/spec/contracts/storages/project_storages/delete_contract_spec.rb
index 305617a88a66..612b6ffe51c0 100644
--- a/modules/storages/spec/contracts/storages/project_storages/delete_contract_spec.rb
+++ b/modules/storages/spec/contracts/storages/project_storages/delete_contract_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require 'contracts/shared/model_contract_shared_context'
+require "contracts/shared/model_contract_shared_context"
RSpec.describe Storages::ProjectStorages::DeleteContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:current_user) { create(:user) }
let(:role) { create(:project_role, permissions: [:manage_storages_in_project]) }
@@ -42,18 +42,18 @@
# Default test setup should be valid ("happy test setup").
# The example below was included above from "ModelContract shared context".
# This tests works with manage_storages_in_project permissions for current_user.
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
# Now we remove the permissions from the user by creating a role without special perms.
- context 'without manage_storages_in_project permission for project' do
+ context "without manage_storages_in_project permission for project" do
# existing_role is a role _without_ the :manage_storages_in_project permission
let(:role) { create(:project_role) }
- it_behaves_like 'contract is invalid'
+ it_behaves_like "contract is invalid"
end
# Generic checks that the contract is valid for valid admin, but invalid otherwise
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
diff --git a/modules/storages/spec/contracts/storages/project_storages/shared_contract_examples.rb b/modules/storages/spec/contracts/storages/project_storages/shared_contract_examples.rb
index bea5e5e0164a..df44a81e358c 100644
--- a/modules/storages/spec/contracts/storages/project_storages/shared_contract_examples.rb
+++ b/modules/storages/spec/contracts/storages/project_storages/shared_contract_examples.rb
@@ -29,13 +29,13 @@
#++
# Include OpenProject support/*.rb files
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require 'contracts/shared/model_contract_shared_context'
+require "contracts/shared/model_contract_shared_context"
# Purpose: Common testing logic shared between create and update specs.
-RSpec.shared_examples_for 'ProjectStorages contract' do
- include_context 'ModelContract shared context'
+RSpec.shared_examples_for "ProjectStorages contract" do
+ include_context "ModelContract shared context"
let(:current_user) { create(:user) }
# The user needs "edit_project" to see the project's settings page
@@ -51,35 +51,35 @@
# This is not 100% precise, as the required permission is not :admin
# but :manage_storages_in_project, but let's still include this.
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
- describe 'validations' do
- context 'when authorized, with permissions and all attributes are valid' do
- it_behaves_like 'contract is valid'
+ describe "validations" do
+ context "when authorized, with permissions and all attributes are valid" do
+ it_behaves_like "contract is valid"
end
- context 'when project is invalid' do
- context 'as it is nil' do
+ context "when project is invalid" do
+ context "as it is nil" do
let(:project) { nil }
- it_behaves_like 'contract is invalid'
+ it_behaves_like "contract is invalid"
end
end
- context 'when storage is invalid' do
- context 'as it is nil' do
+ context "when storage is invalid" do
+ context "as it is nil" do
let(:storage) { nil }
- it_behaves_like 'contract is invalid'
+ it_behaves_like "contract is invalid"
end
end
- context 'when not the necessary permissions' do
+ context "when not the necessary permissions" do
let(:current_user) { build_stubbed(:user) }
- it_behaves_like 'contract user is unauthorized'
+ it_behaves_like "contract user is unauthorized"
end
end
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
diff --git a/modules/storages/spec/contracts/storages/storages/nextcloud_contract_spec.rb b/modules/storages/spec/contracts/storages/storages/nextcloud_contract_spec.rb
index 7f2bac5af98e..b576fbf51f07 100644
--- a/modules/storages/spec/contracts/storages/storages/nextcloud_contract_spec.rb
+++ b/modules/storages/spec/contracts/storages/storages/nextcloud_contract_spec.rb
@@ -28,19 +28,19 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Storages::NextcloudContract, :storage_server_helpers, :webmock do
let(:current_user) { create(:admin) }
- let(:storage_host) { 'https://host1.example.com' }
+ let(:storage_host) { "https://host1.example.com" }
let(:storage) { build(:nextcloud_storage, host: storage_host) }
# As the NextcloudContract is selected by the BaseContract to make writable attributes available,
# the BaseContract needs to be instantiated here.
subject { Storages::Storages::BaseContract.new(storage, current_user) }
- it 'checks the storage url only when changed' do
+ it "checks the storage url only when changed" do
capabilities_request = mock_server_capabilities_response(storage_host)
host_request = mock_server_config_check_response(storage_host)
subject.validate
@@ -54,8 +54,8 @@
expect(host_request).not_to have_been_made
end
- describe 'Nextcloud application credentials validation' do
- context 'with valid credentials' do
+ describe "Nextcloud application credentials validation" do
+ context "with valid credentials" do
let(:storage) { build(:nextcloud_storage, :as_automatically_managed) }
before do
@@ -63,17 +63,17 @@
mock_server_config_check_response(storage.host)
end
- it 'passes validation' do
+ it "passes validation" do
credentials_request = mock_nextcloud_application_credentials_validation(storage.host)
expect(subject).to be_valid
expect(credentials_request).to have_been_made.once
end
- context 'with invalid credentials' do
+ context "with invalid credentials" do
let(:storage) { build(:nextcloud_storage, :as_automatically_managed) }
- it 'fails validation' do
+ it "fails validation" do
credentials_request = mock_nextcloud_application_credentials_validation(storage.host, response_code: 401)
expect(subject).not_to be_valid
@@ -83,10 +83,10 @@
end
end
- context 'with timeout' do
+ context "with timeout" do
let(:storage) { build(:nextcloud_storage, :as_automatically_managed) }
- it 'fails validation' do
+ it "fails validation" do
credentials_request = mock_nextcloud_application_credentials_validation(storage.host, timeout: true)
expect(subject).not_to be_valid
@@ -98,10 +98,10 @@
end
end
- context 'with unknown error' do
+ context "with unknown error" do
let(:storage) { build(:nextcloud_storage, :as_automatically_managed) }
- it 'fails validation' do
+ it "fails validation" do
credentials_request = mock_nextcloud_application_credentials_validation(storage.host, response_code: 500)
expect(subject).not_to be_valid
@@ -112,10 +112,10 @@
end
end
- context 'when the storage is not automatically managed' do
+ context "when the storage is not automatically managed" do
let(:storage) { build(:nextcloud_storage, :as_not_automatically_managed) }
- it 'skips credentials validation' do
+ it "skips credentials validation" do
credentials_request = mock_nextcloud_application_credentials_validation(storage.host)
expect(subject).to be_valid
@@ -123,10 +123,10 @@
end
end
- context 'when the storage host has a subpath' do
- let(:storage) { build(:nextcloud_storage, :as_automatically_managed, host: 'https://host1.example.com/api') }
+ context "when the storage host has a subpath" do
+ let(:storage) { build(:nextcloud_storage, :as_automatically_managed, host: "https://host1.example.com/api") }
- it 'passes validation' do
+ it "passes validation" do
credentials_request = mock_nextcloud_application_credentials_validation(storage.host)
expect(subject).to be_valid
@@ -135,14 +135,14 @@
end
end
- context 'when the storage host is nil' do
+ context "when the storage host is nil" do
let(:storage) { build(:nextcloud_storage, :as_automatically_managed, host: nil) }
before do
allow(NextcloudApplicationCredentialsValidator).to receive(:new).and_call_original
end
- it 'fails validation' do
+ it "fails validation" do
expect(subject).not_to be_valid
expect(subject.errors.to_hash).to eq({ host: ["is not a valid URL."] })
expect(NextcloudApplicationCredentialsValidator).not_to have_received(:new)
diff --git a/modules/storages/spec/contracts/storages/storages/nextcloud_create_contract_spec.rb b/modules/storages/spec/contracts/storages/storages/nextcloud_create_contract_spec.rb
index 8eb7aabdf16c..78604fdc5132 100644
--- a/modules/storages/spec/contracts/storages/storages/nextcloud_create_contract_spec.rb
+++ b/modules/storages/spec/contracts/storages/storages/nextcloud_create_contract_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require_relative 'shared_contract_examples'
+require_relative "shared_contract_examples"
RSpec.describe Storages::Storages::CreateContract do
- it_behaves_like 'nextcloud storage contract' do
+ it_behaves_like "nextcloud storage contract" do
let(:storage) do
build_stubbed(:nextcloud_storage,
creator: storage_creator,
@@ -41,10 +41,10 @@
end
let(:contract) { described_class.new(storage, current_user) }
- context 'when creator is not the current user' do
+ context "when creator is not the current user" do
let(:storage_creator) { build_stubbed(:user) }
- include_examples 'contract is invalid', creator: :invalid
+ include_examples "contract is invalid", creator: :invalid
end
end
end
diff --git a/modules/storages/spec/contracts/storages/storages/nextcloud_delete_contract_spec.rb b/modules/storages/spec/contracts/storages/storages/nextcloud_delete_contract_spec.rb
index 4b3f7ade1f1a..c4e0b0768574 100644
--- a/modules/storages/spec/contracts/storages/storages/nextcloud_delete_contract_spec.rb
+++ b/modules/storages/spec/contracts/storages/storages/nextcloud_delete_contract_spec.rb
@@ -26,20 +26,20 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require 'contracts/shared/model_contract_shared_context'
+require "contracts/shared/model_contract_shared_context"
RSpec.describe Storages::Storages::DeleteContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:storage) { create(:nextcloud_storage) }
let(:contract) { described_class.new(storage, current_user) }
# Generic checks that the contract is valid for valid admin, but invalid otherwise
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
- include_examples 'contract reuses the model errors' do
+ include_examples "contract reuses the model errors" do
let(:current_user) { build_stubbed(:user) }
end
end
diff --git a/modules/storages/spec/contracts/storages/storages/nextcloud_update_contract_spec.rb b/modules/storages/spec/contracts/storages/storages/nextcloud_update_contract_spec.rb
index 557ee7573241..2ff68ae2759f 100644
--- a/modules/storages/spec/contracts/storages/storages/nextcloud_update_contract_spec.rb
+++ b/modules/storages/spec/contracts/storages/storages/nextcloud_update_contract_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require_relative 'shared_contract_examples'
+require_relative "shared_contract_examples"
RSpec.describe Storages::Storages::UpdateContract do
- it_behaves_like 'nextcloud storage contract' do
+ it_behaves_like "nextcloud storage contract" do
let(:storage) do
build_stubbed(:nextcloud_storage,
creator: storage_creator,
@@ -41,10 +41,10 @@
end
let(:contract) { described_class.new(storage, current_user) }
- context 'when current user is not the initial storage creator' do
+ context "when current user is not the initial storage creator" do
let(:storage_creator) { build_stubbed(:user) }
- include_examples 'contract is valid'
+ include_examples "contract is valid"
end
end
end
diff --git a/modules/storages/spec/contracts/storages/storages/one_drive_contract_spec.rb b/modules/storages/spec/contracts/storages/storages/one_drive_contract_spec.rb
index 6b8c7cc38cb3..b40600e4aa9a 100644
--- a/modules/storages/spec/contracts/storages/storages/one_drive_contract_spec.rb
+++ b/modules/storages/spec/contracts/storages/storages/one_drive_contract_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Storages::OneDriveContract, :storage_server_helpers, :webmock do
@@ -39,20 +39,20 @@
# the BaseContract needs to be instantiated here.
subject(:contract) { Storages::Storages::BaseContract.new(storage, current_user) }
- describe 'when a host is set' do
+ describe "when a host is set" do
before do
storage.host = "https://exmaple.com/"
end
- it 'must be invalid' do
+ it "must be invalid" do
expect(contract).not_to be_valid
end
end
- context 'with blank Drive ID' do
- let(:storage) { build(:one_drive_storage, drive_id: '') }
+ context "with blank Drive ID" do
+ let(:storage) { build(:one_drive_storage, drive_id: "") }
- it 'is invalid' do
+ it "is invalid" do
expect(contract).not_to be_valid
expect(contract.errors[:drive_id]).to eq(["can't be blank."])
diff --git a/modules/storages/spec/contracts/storages/storages/one_drive_create_contract_spec.rb b/modules/storages/spec/contracts/storages/storages/one_drive_create_contract_spec.rb
index 838e1b948768..d33667ebc52e 100644
--- a/modules/storages/spec/contracts/storages/storages/one_drive_create_contract_spec.rb
+++ b/modules/storages/spec/contracts/storages/storages/one_drive_create_contract_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require_relative 'shared_contract_examples'
+require_relative "shared_contract_examples"
RSpec.describe Storages::Storages::CreateContract, with_ee: %i[one_drive_sharepoint_file_storage] do
let(:storage) do
@@ -39,15 +39,15 @@
end
let(:contract) { described_class.new(storage, current_user) }
- it_behaves_like 'onedrive storage contract' do
- context 'when creator is not the current user' do
+ it_behaves_like "onedrive storage contract" do
+ context "when creator is not the current user" do
let(:storage_creator) { build_stubbed(:user) }
- include_examples 'contract is invalid', creator: :invalid
+ include_examples "contract is invalid", creator: :invalid
end
- context 'without ee token', with_ee: false do
- include_examples 'contract is invalid', base: I18n.t('api_v3.errors.code_500_missing_enterprise_token')
+ context "without ee token", with_ee: false do
+ include_examples "contract is invalid", base: I18n.t("api_v3.errors.code_500_missing_enterprise_token")
end
end
end
diff --git a/modules/storages/spec/contracts/storages/storages/one_drive_delete_contract_spec.rb b/modules/storages/spec/contracts/storages/storages/one_drive_delete_contract_spec.rb
index 24f29ff95ac8..77e73f071ca5 100644
--- a/modules/storages/spec/contracts/storages/storages/one_drive_delete_contract_spec.rb
+++ b/modules/storages/spec/contracts/storages/storages/one_drive_delete_contract_spec.rb
@@ -26,20 +26,20 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require 'contracts/shared/model_contract_shared_context'
+require "contracts/shared/model_contract_shared_context"
RSpec.describe Storages::Storages::DeleteContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:storage) { create(:one_drive_storage) }
let(:contract) { described_class.new(storage, current_user) }
# Generic checks that the contract is valid for valid admin, but invalid otherwise
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
- include_examples 'contract reuses the model errors' do
+ include_examples "contract reuses the model errors" do
let(:current_user) { build_stubbed(:user) }
end
end
diff --git a/modules/storages/spec/contracts/storages/storages/one_drive_update_contract_spec.rb b/modules/storages/spec/contracts/storages/storages/one_drive_update_contract_spec.rb
index cf5e1d968557..7c86f8f27867 100644
--- a/modules/storages/spec/contracts/storages/storages/one_drive_update_contract_spec.rb
+++ b/modules/storages/spec/contracts/storages/storages/one_drive_update_contract_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require_relative 'shared_contract_examples'
+require_relative "shared_contract_examples"
RSpec.describe Storages::Storages::UpdateContract do
- it_behaves_like 'onedrive storage contract' do
+ it_behaves_like "onedrive storage contract" do
let(:storage) do
build_stubbed(:one_drive_storage,
creator: storage_creator,
@@ -40,10 +40,10 @@
end
let(:contract) { described_class.new(storage, current_user) }
- context 'when current user is not the initial storage creator' do
+ context "when current user is not the initial storage creator" do
let(:storage_creator) { build_stubbed(:user) }
- include_examples 'contract is valid'
+ include_examples "contract is valid"
end
end
end
diff --git a/modules/storages/spec/contracts/storages/storages/shared_contract_examples.rb b/modules/storages/spec/contracts/storages/storages/shared_contract_examples.rb
index ab76b5545399..2132f5dde839 100644
--- a/modules/storages/spec/contracts/storages/storages/shared_contract_examples.rb
+++ b/modules/storages/spec/contracts/storages/storages/shared_contract_examples.rb
@@ -28,75 +28,75 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require 'contracts/shared/model_contract_shared_context'
+require "contracts/shared/model_contract_shared_context"
-RSpec.shared_examples_for 'storage contract' do
- describe 'validations' do
- context 'when all attributes are valid' do
- include_examples 'contract is valid'
+RSpec.shared_examples_for "storage contract" do
+ describe "validations" do
+ context "when all attributes are valid" do
+ include_examples "contract is valid"
end
- context 'when name is invalid' do
- context 'as it is too long' do
- let(:storage_name) { 'X' * 257 }
+ context "when name is invalid" do
+ context "as it is too long" do
+ let(:storage_name) { "X" * 257 }
- include_examples 'contract is invalid', name: :too_long
+ include_examples "contract is invalid", name: :too_long
end
- context 'as it is empty' do
- let(:storage_name) { '' }
+ context "as it is empty" do
+ let(:storage_name) { "" }
- include_examples 'contract is invalid', name: :blank
+ include_examples "contract is invalid", name: :blank
end
- context 'as it is nil' do
+ context "as it is nil" do
let(:storage_name) { nil }
- include_examples 'contract is invalid', name: :blank
+ include_examples "contract is invalid", name: :blank
end
end
- context 'when provider_type is invalid' do
- context 'as it is empty' do
- let(:storage_provider_type) { '' }
+ context "when provider_type is invalid" do
+ context "as it is empty" do
+ let(:storage_provider_type) { "" }
- include_examples 'contract is invalid', provider_type: :inclusion
+ include_examples "contract is invalid", provider_type: :inclusion
end
- context 'as it is nil' do
+ context "as it is nil" do
let(:storage_provider_type) { nil }
- include_examples 'contract is invalid', provider_type: :inclusion
+ include_examples "contract is invalid", provider_type: :inclusion
end
end
end
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
-RSpec.shared_examples_for 'onedrive storage contract' do
- include_context 'ModelContract shared context'
+RSpec.shared_examples_for "onedrive storage contract" do
+ include_context "ModelContract shared context"
let(:current_user) { create(:admin) }
- let(:storage_name) { 'Storage 1' }
+ let(:storage_name) { "Storage 1" }
let(:storage_provider_type) { Storages::Storage::PROVIDER_TYPE_ONE_DRIVE }
let(:storage_creator) { current_user }
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
- it_behaves_like 'storage contract'
+ it_behaves_like "storage contract"
end
-RSpec.shared_examples_for 'nextcloud storage contract', :storage_server_helpers, :webmock do
- include_context 'ModelContract shared context'
+RSpec.shared_examples_for "nextcloud storage contract", :storage_server_helpers, :webmock do
+ include_context "ModelContract shared context"
# Only admins have the right to create/delete storages.
let(:current_user) { create(:admin) }
- let(:storage_name) { 'Storage 1' }
+ let(:storage_name) { "Storage 1" }
let(:storage_provider_type) { Storages::Storage::PROVIDER_TYPE_NEXTCLOUD }
- let(:storage_host) { 'https://host1.example.com' }
+ let(:storage_host) { "https://host1.example.com" }
let(:storage_creator) { current_user }
before do
@@ -107,49 +107,49 @@
end
end
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
- it_behaves_like 'storage contract'
+ it_behaves_like "storage contract"
- describe 'validations' do
- context 'when host is invalid' do
- context 'as host is not a URL' do
- let(:storage_host) { '---invalid-url---' }
+ describe "validations" do
+ context "when host is invalid" do
+ context "as host is not a URL" do
+ let(:storage_host) { "---invalid-url---" }
- include_examples 'contract is invalid', host: I18n.t('activerecord.errors.messages.invalid_url')
+ include_examples "contract is invalid", host: I18n.t("activerecord.errors.messages.invalid_url")
end
- context 'as host is an empty string' do
- let(:storage_host) { '' }
+ context "as host is an empty string" do
+ let(:storage_host) { "" }
- include_examples 'contract is invalid', host: I18n.t('activerecord.errors.messages.invalid_url')
+ include_examples "contract is invalid", host: I18n.t("activerecord.errors.messages.invalid_url")
end
- context 'as host is longer than 255' do
+ context "as host is longer than 255" do
let(:storage_host) { "http://#{'a' * 250}.com" }
- include_examples 'contract is invalid', host: :too_long
+ include_examples "contract is invalid", host: :too_long
end
- context 'as host is nil' do
+ context "as host is nil" do
let(:storage_host) { nil }
- include_examples 'contract is invalid', host: :url
+ include_examples "contract is invalid", host: :url
end
- context 'when host is an unsafe IP' do
- let(:storage_host) { 'http://172.16.193.146' }
+ context "when host is an unsafe IP" do
+ let(:storage_host) { "http://172.16.193.146" }
- include_examples 'contract is invalid', host: :url_not_secure_context
+ include_examples "contract is invalid", host: :url_not_secure_context
end
- context 'when host is an unsafe hostname' do
- let(:storage_host) { 'http://nc.openproject.com' }
+ context "when host is an unsafe hostname" do
+ let(:storage_host) { "http://nc.openproject.com" }
- include_examples 'contract is invalid', host: :url_not_secure_context
+ include_examples "contract is invalid", host: :url_not_secure_context
end
- context 'when provider_type is nextcloud' do
+ context "when provider_type is nextcloud" do
let(:capabilities_response_body) { nil } # use default
let(:capabilities_response_code) { nil } # use default
let(:capabilities_response_headers) { nil } # use default
@@ -184,25 +184,25 @@
stub_config_check
end
- context 'when connection fails' do
- context 'when server capabilities request times out' do
+ context "when connection fails" do
+ context "when server capabilities request times out" do
let(:timeout_server_capabilities) { true }
- include_examples 'contract is invalid', host: :cannot_be_connected_to
+ include_examples "contract is invalid", host: :cannot_be_connected_to
- it 'retries failed request once' do
+ it "retries failed request once" do
contract.validate
# twice due to HTTPX retry plugin being enabled.
expect(stub_server_capabilities).to have_been_made.twice
end
end
- context 'when server config check request times out' do
+ context "when server config check request times out" do
let(:timeout_server_config_check) { true }
- include_examples 'contract is invalid', host: :cannot_be_connected_to
+ include_examples "contract is invalid", host: :cannot_be_connected_to
- it 'retries failed request once' do
+ it "retries failed request once" do
contract.validate
# twice due to HTTPX retry plugin being enabled.
@@ -211,133 +211,133 @@
end
end
- context 'when response code is a 404 NOT FOUND' do
+ context "when response code is a 404 NOT FOUND" do
let(:capabilities_response_code) { 404 }
- include_examples 'contract is invalid', host: :cannot_be_connected_to
+ include_examples "contract is invalid", host: :cannot_be_connected_to
end
- context 'when response code is a 500 PERMISSION DENIED' do
+ context "when response code is a 500 PERMISSION DENIED" do
let(:capabilities_response_code) { 500 }
- include_examples 'contract is invalid', host: :cannot_be_connected_to
+ include_examples "contract is invalid", host: :cannot_be_connected_to
end
- context 'when response content type is not application/json' do
+ context "when response content type is not application/json" do
let(:capabilities_response_headers) do
{
- 'Content-Type' => 'text/html'
+ "Content-Type" => "text/html"
}
end
- include_examples 'contract is invalid', host: :not_nextcloud_server
+ include_examples "contract is invalid", host: :not_nextcloud_server
end
- context 'when response is unparsable JSON' do
- let(:capabilities_response_body) { '{' }
+ context "when response is unparsable JSON" do
+ let(:capabilities_response_body) { "{" }
- include_examples 'contract is invalid', host: :not_nextcloud_server
+ include_examples "contract is invalid", host: :not_nextcloud_server
end
- context 'when response is valid JSON but not the expected data' do
- let(:capabilities_response_body) { '{}' }
+ context "when response is valid JSON but not the expected data" do
+ let(:capabilities_response_body) { "{}" }
- include_examples 'contract is invalid', host: :not_nextcloud_server
+ include_examples "contract is invalid", host: :not_nextcloud_server
end
- context 'when Nextcloud version is below the required minimal version which is 22' do
+ context "when Nextcloud version is below the required minimal version which is 22" do
let(:capabilities_response_major_version) { 21 }
- include_examples 'contract is invalid', host: :minimal_nextcloud_version_unmet
+ include_examples "contract is invalid", host: :minimal_nextcloud_version_unmet
end
context 'when Nextcloud instance is missing the "OpenProject integration" app' do
let(:check_config_response_code) { 302 }
- include_examples 'contract is invalid', host: :op_application_not_installed
+ include_examples "contract is invalid", host: :op_application_not_installed
end
- context 'when Nextcloud instance is misconfigured and strips AUTHORIZATION header from HTTP request' do
- let(:check_config_response_body) { { authorization_header: '' }.to_json }
+ context "when Nextcloud instance is misconfigured and strips AUTHORIZATION header from HTTP request" do
+ let(:check_config_response_body) { { authorization_header: "" }.to_json }
- include_examples 'contract is invalid', host: :authorization_header_missing
+ include_examples "contract is invalid", host: :authorization_header_missing
end
end
end
- context 'when host secure' do
- context 'when host is localhost' do
- let(:storage_host) { 'http://localhost:1234' }
+ context "when host secure" do
+ context "when host is localhost" do
+ let(:storage_host) { "http://localhost:1234" }
- include_examples 'contract is valid'
+ include_examples "contract is valid"
end
- context 'when host uses https protocol' do
- let(:storage_host) { 'https://172.16.193.146' }
+ context "when host uses https protocol" do
+ let(:storage_host) { "https://172.16.193.146" }
- include_examples 'contract is valid'
+ include_examples "contract is valid"
end
end
- context 'when automatically managed, no username or password' do
+ context "when automatically managed, no username or password" do
before { storage.automatic_management_enabled = true }
- it_behaves_like 'contract is invalid', password: :blank
+ it_behaves_like "contract is invalid", password: :blank
end
- context 'when automatically managed, with username and password' do
+ context "when automatically managed, with username and password" do
before do
- storage.assign_attributes(automatic_management_enabled: true, username: 'OpenProject', password: 'Password')
+ storage.assign_attributes(automatic_management_enabled: true, username: "OpenProject", password: "Password")
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'when not automatically managed, no username or password' do
+ context "when not automatically managed, no username or password" do
before do
storage.provider_fields = {}
storage.assign_attributes(automatic_management_enabled: false)
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'when not automatically managed, with username default and password' do
+ context "when not automatically managed, with username default and password" do
before do
- storage.assign_attributes(automatic_management_enabled: false, username: 'OpenProject', password: 'Password')
+ storage.assign_attributes(automatic_management_enabled: false, username: "OpenProject", password: "Password")
end
- it_behaves_like 'contract is invalid', password: :present
+ it_behaves_like "contract is invalid", password: :present
end
- context 'when not automatically managed, with user defined username and password' do
+ context "when not automatically managed, with user defined username and password" do
before do
- storage.assign_attributes(automatic_management_enabled: false, username: 'Username', password: 'Password')
+ storage.assign_attributes(automatic_management_enabled: false, username: "Username", password: "Password")
end
- it_behaves_like 'contract is invalid', username: :present, password: :present
+ it_behaves_like "contract is invalid", username: :present, password: :present
end
- describe 'provider_type_strategy' do
+ describe "provider_type_strategy" do
before do
allow(contract).to receive(:provider_type_strategy)
end
- context 'without `skip_provider_type_strategy` option' do
- it 'validates the provider type contract' do
+ context "without `skip_provider_type_strategy` option" do
+ it "validates the provider type contract" do
contract.validate
expect(contract).to have_received(:provider_type_strategy)
end
end
- context 'with `skip_provider_type_strategy` option' do
+ context "with `skip_provider_type_strategy` option" do
let(:contract) do
described_class.new(storage, build_stubbed(:admin),
options: { skip_provider_type_strategy: true })
end
- it 'does not validate the provider type' do
+ it "does not validate the provider type" do
contract.validate
expect(contract).not_to have_received(:provider_type_strategy)
diff --git a/modules/storages/spec/factories/file_link_element_factory.rb b/modules/storages/spec/factories/file_link_element_factory.rb
index af66880a6aa2..54820243c235 100644
--- a/modules/storages/spec/factories/file_link_element_factory.rb
+++ b/modules/storages/spec/factories/file_link_element_factory.rb
@@ -41,12 +41,12 @@
storage_url { "https://nextcloud.example.com" }
trait :invalid do
- origin_id { ' ' }
+ origin_id { " " }
end
initialize_with do
- origin_data = attributes.select { |key, _| key.starts_with?('origin_') }
- .transform_keys { |key| key.to_s.gsub('origin_', '').camelcase(:lower).to_sym }
+ origin_data = attributes.select { |key, _| key.starts_with?("origin_") }
+ .transform_keys { |key| key.to_s.gsub("origin_", "").camelcase(:lower).to_sym }
.then { |data| data.transform_values { |v| v.respond_to?(:iso8601) ? v.iso8601 : v } }
.then { |data| data.transform_keys { |k| k.to_sym == :updatedAt ? :lastModifiedAt : k } }
{
diff --git a/modules/storages/spec/factories/file_link_factory.rb b/modules/storages/spec/factories/file_link_factory.rb
index 185fb9a3f6a6..93177559d0a2 100644
--- a/modules/storages/spec/factories/file_link_factory.rb
+++ b/modules/storages/spec/factories/file_link_factory.rb
@@ -28,7 +28,7 @@
# Expects parameters: storage
FactoryBot.define do
- factory :file_link, class: '::Storages::FileLink' do
+ factory :file_link, class: "::Storages::FileLink" do
creator factory: :user
sequence(:origin_id) { |n| "10000#{n}" } # ID within external storage (i.e. Nextcloud)
sequence(:origin_name) { |n| "file_name_#{n}.txt" } # File name within external storage (i.e. Nextcloud)
diff --git a/modules/storages/spec/factories/last_project_folder_factory.rb b/modules/storages/spec/factories/last_project_folder_factory.rb
index 66a96991a370..bf4f424cb91c 100644
--- a/modules/storages/spec/factories/last_project_folder_factory.rb
+++ b/modules/storages/spec/factories/last_project_folder_factory.rb
@@ -27,7 +27,7 @@
#++
FactoryBot.define do
- factory :last_project_folder, class: '::Storages::LastProjectFolder' do
+ factory :last_project_folder, class: "::Storages::LastProjectFolder" do
project_storage factory: :project_storage
end
end
diff --git a/modules/storages/spec/factories/project_storage_factory.rb b/modules/storages/spec/factories/project_storage_factory.rb
index 7112fdce1b5f..f9ec495cc2c8 100644
--- a/modules/storages/spec/factories/project_storage_factory.rb
+++ b/modules/storages/spec/factories/project_storage_factory.rb
@@ -28,15 +28,15 @@
# Required parameters: project and storage
FactoryBot.define do
- factory :project_storage, class: '::Storages::ProjectStorage' do
+ factory :project_storage, class: "::Storages::ProjectStorage" do
creator factory: :user
storage factory: :nextcloud_storage
project factory: :project
project_folder_id { nil }
- project_folder_mode { 'inactive' }
+ project_folder_mode { "inactive" }
trait :as_automatically_managed do
- project_folder_mode { 'automatic' }
+ project_folder_mode { "automatic" }
end
trait :with_historical_data do
diff --git a/modules/storages/spec/factories/storage_file_info_factory.rb b/modules/storages/spec/factories/storage_file_info_factory.rb
index 969ad8e201db..78558f8de1f0 100644
--- a/modules/storages/spec/factories/storage_file_info_factory.rb
+++ b/modules/storages/spec/factories/storage_file_info_factory.rb
@@ -27,7 +27,7 @@
#++
FactoryBot.define do
- factory :storage_file_info, class: '::Storages::StorageFileInfo' do
+ factory :storage_file_info, class: "::Storages::StorageFileInfo" do
status { "OK" }
status_code { 200 }
sequence(:id) { |n| "20000#{n}" } # rubocop:disable FactoryBot/IdSequence
diff --git a/modules/storages/spec/factories/webdav_data_factory.rb b/modules/storages/spec/factories/webdav_data_factory.rb
index 02e50453f229..c3c98ca9da9e 100644
--- a/modules/storages/spec/factories/webdav_data_factory.rb
+++ b/modules/storages/spec/factories/webdav_data_factory.rb
@@ -27,109 +27,109 @@
#++
FactoryBot.define do
- factory :webdav_data, class: 'String' do
+ factory :webdav_data, class: "String" do
transient do
- origin_user_id { 'admin' }
- root_path { '' }
- parent_path { '' }
+ origin_user_id { "admin" }
+ root_path { "" }
+ parent_path { "" }
end
skip_create
initialize_with do
- url_safe_user_id = origin_user_id.gsub(' ', '%20')
- base_path = File.join(root_path, '/remote.php/dav/files', url_safe_user_id, parent_path)
+ url_safe_user_id = origin_user_id.gsub(" ", "%20")
+ base_path = File.join(root_path, "/remote.php/dav/files", url_safe_user_id, parent_path)
Nokogiri::XML::Builder.new do |xml|
- xml['d'].multistatus(
- 'xmlns:d' => 'DAV:',
- 'xmlns:s' => 'http://sabredav.org/ns',
- 'xmlns:oc' => 'http://owncloud.org/ns',
- 'xmlns:nc' => 'http://nextcloud.org/ns'
+ xml["d"].multistatus(
+ "xmlns:d" => "DAV:",
+ "xmlns:s" => "http://sabredav.org/ns",
+ "xmlns:oc" => "http://owncloud.org/ns",
+ "xmlns:nc" => "http://nextcloud.org/ns"
) do
- xml['d'].response do
- xml['d'].href(base_path)
- xml['d'].propstat do
- xml['d'].prop do
- xml['oc'].fileid('6')
- xml['oc'].size('20028269')
- xml['d'].getlastmodified('Fri, 28 Oct 2022 14:27:36 GMT')
- xml['oc'].permissions('RGDNVCK')
- xml['oc'].send(:'owner-display-name', url_safe_user_id)
+ xml["d"].response do
+ xml["d"].href(base_path)
+ xml["d"].propstat do
+ xml["d"].prop do
+ xml["oc"].fileid("6")
+ xml["oc"].size("20028269")
+ xml["d"].getlastmodified("Fri, 28 Oct 2022 14:27:36 GMT")
+ xml["oc"].permissions("RGDNVCK")
+ xml["oc"].send(:"owner-display-name", url_safe_user_id)
end
- xml['d'].status('HTTP/1.1 200 OK')
+ xml["d"].status("HTTP/1.1 200 OK")
end
- xml['d'].propstat do
- xml['d'].prop do
- xml['d'].getcontenttype
+ xml["d"].propstat do
+ xml["d"].prop do
+ xml["d"].getcontenttype
end
- xml['d'].status('HTTP/1.1 404 Not Found')
+ xml["d"].status("HTTP/1.1 404 Not Found")
end
end
- xml['d'].response do
- xml['d'].href(File.join(base_path, 'Folder1', ''))
- xml['d'].propstat do
- xml['d'].prop do
- xml['oc'].fileid('11')
- xml['oc'].size('6592')
- xml['d'].getlastmodified('Fri, 28 Oct 2022 14:31:26 GMT')
- xml['oc'].permissions('RGDNVCK')
- xml['oc'].send(:'owner-display-name', url_safe_user_id)
+ xml["d"].response do
+ xml["d"].href(File.join(base_path, "Folder1", ""))
+ xml["d"].propstat do
+ xml["d"].prop do
+ xml["oc"].fileid("11")
+ xml["oc"].size("6592")
+ xml["d"].getlastmodified("Fri, 28 Oct 2022 14:31:26 GMT")
+ xml["oc"].permissions("RGDNVCK")
+ xml["oc"].send(:"owner-display-name", url_safe_user_id)
end
- xml['d'].status('HTTP/1.1 200 OK')
+ xml["d"].status("HTTP/1.1 200 OK")
end
- xml['d'].propstat do
- xml['d'].prop do
- xml['d'].getcontenttype
+ xml["d"].propstat do
+ xml["d"].prop do
+ xml["d"].getcontenttype
end
- xml['d'].status('HTTP/1.1 404 Not Found')
+ xml["d"].status("HTTP/1.1 404 Not Found")
end
end
- xml['d'].response do
- xml['d'].href(File.join(base_path, 'Folder2', ''))
- xml['d'].propstat do
- xml['d'].prop do
- xml['oc'].fileid('20')
- xml['oc'].size('8592')
- xml['d'].getlastmodified('Fri, 28 Oct 2022 14:43:26 GMT')
- xml['oc'].permissions('RGDNV')
- xml['oc'].send(:'owner-display-name', url_safe_user_id)
+ xml["d"].response do
+ xml["d"].href(File.join(base_path, "Folder2", ""))
+ xml["d"].propstat do
+ xml["d"].prop do
+ xml["oc"].fileid("20")
+ xml["oc"].size("8592")
+ xml["d"].getlastmodified("Fri, 28 Oct 2022 14:43:26 GMT")
+ xml["oc"].permissions("RGDNV")
+ xml["oc"].send(:"owner-display-name", url_safe_user_id)
end
- xml['d'].status('HTTP/1.1 200 OK')
+ xml["d"].status("HTTP/1.1 200 OK")
end
- xml['d'].propstat do
- xml['d'].prop do
- xml['d'].getcontenttype
+ xml["d"].propstat do
+ xml["d"].prop do
+ xml["d"].getcontenttype
end
- xml['d'].status('HTTP/1.1 404 Not Found')
+ xml["d"].status("HTTP/1.1 404 Not Found")
end
end
- xml['d'].response do
- xml['d'].href(File.join(base_path, 'README.md'))
- xml['d'].propstat do
- xml['d'].prop do
- xml['oc'].fileid('12')
- xml['oc'].size('1024')
- xml['d'].getcontenttype('text/markdown')
- xml['d'].getlastmodified('Thu, 14 Jul 2022 08:42:15 GMT')
- xml['oc'].permissions('RGDNVW')
- xml['oc'].send(:'owner-display-name', url_safe_user_id)
+ xml["d"].response do
+ xml["d"].href(File.join(base_path, "README.md"))
+ xml["d"].propstat do
+ xml["d"].prop do
+ xml["oc"].fileid("12")
+ xml["oc"].size("1024")
+ xml["d"].getcontenttype("text/markdown")
+ xml["d"].getlastmodified("Thu, 14 Jul 2022 08:42:15 GMT")
+ xml["oc"].permissions("RGDNVW")
+ xml["oc"].send(:"owner-display-name", url_safe_user_id)
end
- xml['d'].status('HTTP/1.1 200 OK')
+ xml["d"].status("HTTP/1.1 200 OK")
end
end
- xml['d'].response do
- xml['d'].href(File.join(base_path, 'Manual.pdf'))
- xml['d'].propstat do
- xml['d'].prop do
- xml['oc'].fileid('13')
- xml['oc'].size('12706214')
- xml['d'].getcontenttype('application/pdf')
- xml['d'].getlastmodified('Thu, 14 Jul 2022 08:42:15 GMT')
- xml['oc'].permissions('RGDNV')
- xml['oc'].send(:'owner-display-name', url_safe_user_id)
+ xml["d"].response do
+ xml["d"].href(File.join(base_path, "Manual.pdf"))
+ xml["d"].propstat do
+ xml["d"].prop do
+ xml["oc"].fileid("13")
+ xml["oc"].size("12706214")
+ xml["d"].getcontenttype("application/pdf")
+ xml["d"].getlastmodified("Thu, 14 Jul 2022 08:42:15 GMT")
+ xml["oc"].permissions("RGDNV")
+ xml["oc"].send(:"owner-display-name", url_safe_user_id)
end
- xml['d'].status('HTTP/1.1 200 OK')
+ xml["d"].status("HTTP/1.1 200 OK")
end
end
end
@@ -137,76 +137,76 @@
end
end
- factory :webdav_data_folder, class: 'String' do
+ factory :webdav_data_folder, class: "String" do
skip_create
initialize_with do
Nokogiri::XML::Builder.new do |xml|
- xml['d'].multistatus(
- 'xmlns:d' => 'DAV:',
- 'xmlns:s' => 'http://sabredav.org/ns',
- 'xmlns:oc' => 'http://owncloud.org/ns',
- 'xmlns:nc' => 'http://nextcloud.org/ns'
+ xml["d"].multistatus(
+ "xmlns:d" => "DAV:",
+ "xmlns:s" => "http://sabredav.org/ns",
+ "xmlns:oc" => "http://owncloud.org/ns",
+ "xmlns:nc" => "http://nextcloud.org/ns"
) do
- xml['d'].response do
- xml['d'].href('/remote.php/dav/files/admin/Folder1')
- xml['d'].propstat do
- xml['d'].prop do
- xml['oc'].fileid('11')
- xml['oc'].size('6592')
- xml['d'].getlastmodified('Fri, 28 Oct 2022 14:31:26 GMT')
- xml['oc'].permissions('RGDNVCK')
- xml['oc'].send(:'owner-display-name', 'admin')
+ xml["d"].response do
+ xml["d"].href("/remote.php/dav/files/admin/Folder1")
+ xml["d"].propstat do
+ xml["d"].prop do
+ xml["oc"].fileid("11")
+ xml["oc"].size("6592")
+ xml["d"].getlastmodified("Fri, 28 Oct 2022 14:31:26 GMT")
+ xml["oc"].permissions("RGDNVCK")
+ xml["oc"].send(:"owner-display-name", "admin")
end
- xml['d'].status('HTTP/1.1 200 OK')
+ xml["d"].status("HTTP/1.1 200 OK")
end
- xml['d'].propstat do
- xml['d'].prop do
- xml['d'].getcontenttype
+ xml["d"].propstat do
+ xml["d"].prop do
+ xml["d"].getcontenttype
end
- xml['d'].status('HTTP/1.1 404 Not Found')
+ xml["d"].status("HTTP/1.1 404 Not Found")
end
end
- xml['d'].response do
- xml['d'].href('/remote.php/dav/files/admin/Folder1/logo.png')
- xml['d'].propstat do
- xml['d'].prop do
- xml['oc'].fileid('21')
- xml['oc'].size('2048')
- xml['d'].getcontenttype('image/png')
- xml['d'].getlastmodified('Fri, 28 Oct 2022 14:31:26 GMT')
- xml['oc'].permissions('RGDNVW')
- xml['oc'].send(:'owner-display-name', 'admin')
+ xml["d"].response do
+ xml["d"].href("/remote.php/dav/files/admin/Folder1/logo.png")
+ xml["d"].propstat do
+ xml["d"].prop do
+ xml["oc"].fileid("21")
+ xml["oc"].size("2048")
+ xml["d"].getcontenttype("image/png")
+ xml["d"].getlastmodified("Fri, 28 Oct 2022 14:31:26 GMT")
+ xml["oc"].permissions("RGDNVW")
+ xml["oc"].send(:"owner-display-name", "admin")
end
- xml['d'].status('HTTP/1.1 200 OK')
+ xml["d"].status("HTTP/1.1 200 OK")
end
end
- xml['d'].response do
- xml['d'].href('/remote.php/dav/files/admin/Folder1/jingle.ogg')
- xml['d'].propstat do
- xml['d'].prop do
- xml['oc'].fileid('22')
- xml['oc'].size('22736218')
- xml['d'].getcontenttype('audio/ogg')
- xml['d'].getlastmodified('Fri, 28 Oct 2022 14:31:26 GMT')
- xml['oc'].permissions('RGDNVW')
- xml['oc'].send(:'owner-display-name', 'admin')
+ xml["d"].response do
+ xml["d"].href("/remote.php/dav/files/admin/Folder1/jingle.ogg")
+ xml["d"].propstat do
+ xml["d"].prop do
+ xml["oc"].fileid("22")
+ xml["oc"].size("22736218")
+ xml["d"].getcontenttype("audio/ogg")
+ xml["d"].getlastmodified("Fri, 28 Oct 2022 14:31:26 GMT")
+ xml["oc"].permissions("RGDNVW")
+ xml["oc"].send(:"owner-display-name", "admin")
end
- xml['d'].status('HTTP/1.1 200 OK')
+ xml["d"].status("HTTP/1.1 200 OK")
end
end
- xml['d'].response do
- xml['d'].href('/remote.php/dav/files/admin/Folder1/notes.txt')
- xml['d'].propstat do
- xml['d'].prop do
- xml['oc'].fileid('23')
- xml['oc'].size('128')
- xml['d'].getcontenttype('text/plain')
- xml['d'].getlastmodified('Fri, 28 Oct 2022 14:31:26 GMT')
- xml['oc'].permissions('RGDNVW')
- xml['oc'].send(:'owner-display-name', 'admin')
+ xml["d"].response do
+ xml["d"].href("/remote.php/dav/files/admin/Folder1/notes.txt")
+ xml["d"].propstat do
+ xml["d"].prop do
+ xml["oc"].fileid("23")
+ xml["oc"].size("128")
+ xml["d"].getcontenttype("text/plain")
+ xml["d"].getlastmodified("Fri, 28 Oct 2022 14:31:26 GMT")
+ xml["oc"].permissions("RGDNVW")
+ xml["oc"].send(:"owner-display-name", "admin")
end
- xml['d'].status('HTTP/1.1 200 OK')
+ xml["d"].status("HTTP/1.1 200 OK")
end
end
end
diff --git a/modules/storages/spec/features/create_file_links_spec.rb b/modules/storages/spec/features/create_file_links_spec.rb
index 0221ffaabf79..e08534c17fe6 100644
--- a/modules/storages/spec/features/create_file_links_spec.rb
+++ b/modules/storages/spec/features/create_file_links_spec.rb
@@ -28,21 +28,21 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe 'Managing file links in work package', :js, :webmock do
+RSpec.describe "Managing file links in work package", :js, :webmock do
let(:permissions) { %i(view_work_packages edit_work_packages view_file_links manage_file_links) }
let(:project) { create(:project) }
let(:current_user) { create(:user, member_with_permissions: { project => permissions }) }
- let(:work_package) { create(:work_package, project:, description: 'Initial description') }
+ let(:work_package) { create(:work_package, project:, description: "Initial description") }
let(:oauth_application) { create(:oauth_application) }
- let(:storage) { create(:nextcloud_storage, name: 'My Storage', oauth_application:) }
+ let(:storage) { create(:nextcloud_storage, name: "My Storage", oauth_application:) }
let(:oauth_client) { create(:oauth_client, integration: storage) }
let(:oauth_client_token) { create(:oauth_client_token, oauth_client:, user: current_user) }
- let(:project_storage) { create(:project_storage, project:, storage:, project_folder_id: nil, project_folder_mode: 'inactive') }
- let(:file_link) { create(:file_link, container: work_package, storage:, origin_id: '22', origin_name: 'jingle.ogg') }
+ let(:project_storage) { create(:project_storage, project:, storage:, project_folder_id: nil, project_folder_mode: "inactive") }
+ let(:file_link) { create(:file_link, container: work_package, storage:, origin_id: "22", origin_name: "jingle.ogg") }
let(:root_xml_response) { create(:webdav_data) }
let(:folder1_xml_response) { create(:webdav_data_folder) }
@@ -64,9 +64,9 @@
stub_request(:get, "#{storage.host}/ocs/v1.php/cloud/user")
.with(
headers: {
- 'Authorization' => "Bearer #{oauth_client_token.access_token}",
- 'Ocs-Apirequest' => 'true',
- 'Accept' => "application/json"
+ "Authorization" => "Bearer #{oauth_client_token.access_token}",
+ "Ocs-Apirequest" => "true",
+ "Accept" => "application/json"
}
)
.to_return(status: 200, body: "", headers: {})
@@ -82,66 +82,66 @@
wp_page.visit_tab! :files
end
- context 'with select all in file picker enabled', with_flag: { storage_file_picking_select_all: true } do
- it 'must enable the user to select files from file picker to create file links' do
- within_test_selector('op-tab-content--tab-section', text: 'MY STORAGE', wait: 25) do
+ context "with select all in file picker enabled", with_flag: { storage_file_picking_select_all: true } do
+ it "must enable the user to select files from file picker to create file links" do
+ within_test_selector("op-tab-content--tab-section", text: "MY STORAGE", wait: 25) do
expect(page).to have_list_item(count: 1)
- expect(page).to have_list_item(text: 'jingle.ogg')
- page.click_on('Link existing files')
+ expect(page).to have_list_item(text: "jingle.ogg")
+ page.click_on("Link existing files")
end
modal.expect_open
- modal.expect_title('Select files')
+ modal.expect_title("Select files")
modal.within_modal do
- expect(page).to have_button('Select files to link', disabled: true)
+ expect(page).to have_button("Select files to link", disabled: true)
- within(:list_item, text: 'Manual.pdf') { page.click }
+ within(:list_item, text: "Manual.pdf") { page.click }
- expect(page).to have_button('Link 1 file', disabled: false)
+ expect(page).to have_button("Link 1 file", disabled: false)
- within(:list_item, text: 'Folder1') { page.click }
+ within(:list_item, text: "Folder1") { page.click }
- within(:list_item, text: 'jingle.ogg') do
- expect(page).to have_field(type: 'checkbox', checked: true, disabled: true)
+ within(:list_item, text: "jingle.ogg") do
+ expect(page).to have_field(type: "checkbox", checked: true, disabled: true)
end
- page.click_on('Select all')
- expect(page).to have_button('Link 3 files', disabled: false)
+ page.click_on("Select all")
+ expect(page).to have_button("Link 3 files", disabled: false)
- within(:list_item, text: 'notes.txt') { page.click }
- expect(page).to have_button('Link 2 files', disabled: false)
+ within(:list_item, text: "notes.txt") { page.click }
+ expect(page).to have_button("Link 2 files", disabled: false)
- page.click_on('My Storage')
- within(:list_item, text: 'Manual.pdf') do
- expect(page).to have_field(type: 'checkbox', checked: true, disabled: false)
+ page.click_on("My Storage")
+ within(:list_item, text: "Manual.pdf") do
+ expect(page).to have_field(type: "checkbox", checked: true, disabled: false)
end
- page.click_on('Link 2 files')
+ page.click_on("Link 2 files")
end
- within_test_selector('op-tab-content--tab-section', text: 'MY STORAGE') do
+ within_test_selector("op-tab-content--tab-section", text: "MY STORAGE") do
expect(page).to have_list_item(count: 3)
- expect(page).to have_list_item(text: 'jingle.ogg')
- expect(page).to have_list_item(text: 'Manual.pdf')
- expect(page).to have_list_item(text: 'logo.png')
+ expect(page).to have_list_item(text: "jingle.ogg")
+ expect(page).to have_list_item(text: "Manual.pdf")
+ expect(page).to have_list_item(text: "logo.png")
end
end
end
- it 'must enable the user to remove a file link' do
- within_test_selector('op-tab-content--tab-section', text: 'MY STORAGE') do
- within(:list_item, text: 'jingle.ogg') do
- page.find('span', text: 'jingle.ogg').hover
- page.click_on('Remove file link')
+ it "must enable the user to remove a file link" do
+ within_test_selector("op-tab-content--tab-section", text: "MY STORAGE") do
+ within(:list_item, text: "jingle.ogg") do
+ page.find("span", text: "jingle.ogg").hover
+ page.click_on("Remove file link")
end
end
modal.expect_open
- modal.expect_title('Remove file link')
+ modal.expect_title("Remove file link")
modal.within_modal do
- page.click_on('Remove link')
+ page.click_on("Remove link")
end
- expect(page).not_to have_list_item(text: 'jingle.ogg')
+ expect(page).not_to have_list_item(text: "jingle.ogg")
end
end
diff --git a/modules/storages/spec/features/delete_project_storage_and_file_links_spec.rb b/modules/storages/spec/features/delete_project_storage_and_file_links_spec.rb
index b5747553eb86..c432d4dec0f6 100644
--- a/modules/storages/spec/features/delete_project_storage_and_file_links_spec.rb
+++ b/modules/storages/spec/features/delete_project_storage_and_file_links_spec.rb
@@ -28,18 +28,18 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
# Test if the deletion of a ProjectStorage actually deletes related FileLink
# objects.
-RSpec.describe 'Delete ProjectStorage with FileLinks', :js, :webmock do
+RSpec.describe "Delete ProjectStorage with FileLinks", :js, :webmock do
let(:user) { create(:user) }
let(:role) { create(:project_role, permissions: [:manage_storages_in_project]) }
let(:project) do
create(:project,
- name: 'Project 1',
- identifier: 'demo-project',
+ name: "Project 1",
+ identifier: "demo-project",
members: { user => role },
enabled_module_names: %i[storages work_package_tracking])
end
@@ -64,35 +64,35 @@
login_as user
end
- it 'deletes ProjectStorage with dependent FileLinks' do
+ it "deletes ProjectStorage with dependent FileLinks" do
# Go to Projects -> Settings -> File Storages
visit project_settings_project_storages_path(project)
# The list of enabled file storages should now contain Storage 1
- expect(page).to have_text('File storages available in this project')
- expect(page).to have_text('Storage 1')
+ expect(page).to have_text("File storages available in this project")
+ expect(page).to have_text("Storage 1")
# Press Delete icon to remove the storage from the project
- page.find('.icon.icon-delete').click
+ page.find(".icon.icon-delete").click
# Danger zone confirmation flow
- expect(page).to have_css('.form--section-title', text: "DELETE FILE STORAGE")
- expect(page).to have_css('.danger-zone--warning', text: "Deleting a file storage is an irreversible action.")
- expect(page).to have_button('Delete', disabled: true)
+ expect(page).to have_css(".form--section-title", text: "DELETE FILE STORAGE")
+ expect(page).to have_css(".danger-zone--warning", text: "Deleting a file storage is an irreversible action.")
+ expect(page).to have_button("Delete", disabled: true)
# Cancel Confirmation
- page.click_link('Cancel')
+ page.click_link("Cancel")
expect(page).to have_current_path project_settings_project_storages_path(project)
- page.find('.icon.icon-delete').click
+ page.find(".icon.icon-delete").click
# Approve Confirmation
- page.fill_in 'delete_confirmation', with: storage.name
- page.click_button('Delete')
+ page.fill_in "delete_confirmation", with: storage.name
+ page.click_button("Delete")
# List of ProjectStorages empty again
expect(page).to have_current_path project_settings_project_storages_path(project)
- expect(page).to have_text(I18n.t('storages.no_results'))
+ expect(page).to have_text(I18n.t("storages.no_results"))
# Also check in the database that ProjectStorage and dependent FileLinks are gone
expect(Storages::ProjectStorage.count).to be 0
diff --git a/modules/storages/spec/features/shared_context.rb b/modules/storages/spec/features/shared_context.rb
index fc3566c906d3..1082fa16786d 100644
--- a/modules/storages/spec/features/shared_context.rb
+++ b/modules/storages/spec/features/shared_context.rb
@@ -28,11 +28,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require_relative '../support/pages/storage_tab'
+require_relative "../support/pages/storage_tab"
-RSpec.shared_context 'with storages full access' do
+RSpec.shared_context "with storages full access" do
current_user { user }
end
diff --git a/modules/storages/spec/features/show_file_links_spec.rb b/modules/storages/spec/features/show_file_links_spec.rb
index 441d07ca928b..3cad19dd1f93 100644
--- a/modules/storages/spec/features/show_file_links_spec.rb
+++ b/modules/storages/spec/features/show_file_links_spec.rb
@@ -28,21 +28,21 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe 'Showing of file links in work package', :js do
+RSpec.describe "Showing of file links in work package", :js do
let(:permissions) { %i(view_work_packages edit_work_packages view_file_links manage_file_links) }
let(:project) { create(:project) }
let(:current_user) { create(:user, member_with_permissions: { project => permissions }) }
- let(:work_package) { create(:work_package, project:, description: 'Initial description') }
+ let(:work_package) { create(:work_package, project:, description: "Initial description") }
let(:oauth_application) { create(:oauth_application) }
- let(:storage) { create(:nextcloud_storage, name: 'My storage', oauth_application:) }
+ let(:storage) { create(:nextcloud_storage, name: "My storage", oauth_application:) }
let(:oauth_client) { create(:oauth_client, integration: storage) }
let(:oauth_client_token) { create(:oauth_client_token, oauth_client:, user: current_user) }
let(:project_storage) { create(:project_storage, project:, storage:) }
- let(:file_link) { create(:file_link, container: work_package, storage:, origin_id: '42', origin_name: 'logo.png') }
+ let(:file_link) { create(:file_link, container: work_package, storage:, origin_id: "42", origin_name: "logo.png") }
let(:wp_page) { Pages::FullWorkPackage.new(work_package, project) }
let(:connection_manager) { instance_double(OAuthClients::ConnectionManager) }
@@ -71,57 +71,57 @@
wp_page.visit_tab! :files
end
- context 'if work package has associated file links' do
- it 'must show associated file links' do
- expect(page).to have_test_selector('op-tab-content--tab-section', count: 2)
- within_test_selector('op-tab-content--tab-section', text: 'MY STORAGE') do
+ context "if work package has associated file links" do
+ it "must show associated file links" do
+ expect(page).to have_test_selector("op-tab-content--tab-section", count: 2)
+ within_test_selector("op-tab-content--tab-section", text: "MY STORAGE") do
expect(page).to have_list_item(count: 1)
- expect(page).to have_list_item(text: 'logo.png')
+ expect(page).to have_list_item(text: "logo.png")
end
end
end
- context 'if user has no permission to see file links' do
+ context "if user has no permission to see file links" do
let(:permissions) { %i(view_work_packages edit_work_packages) }
- it 'must not show a file links section' do
- expect(page).to have_test_selector('op-tab-content--tab-section', count: 1)
+ it "must not show a file links section" do
+ expect(page).to have_test_selector("op-tab-content--tab-section", count: 1)
end
end
- context 'if project has no storage' do
+ context "if project has no storage" do
let(:project_storage) { {} }
- it 'must not show a file links section' do
- expect(page).to have_test_selector('op-tab-content--tab-section', count: 1)
+ it "must not show a file links section" do
+ expect(page).to have_test_selector("op-tab-content--tab-section", count: 1)
end
end
- context 'if user is not authorized in Nextcloud' do
+ context "if user is not authorized in Nextcloud" do
before do
allow(connection_manager).to receive_messages(authorization_state: :failed_authorization,
- get_authorization_uri: 'https://example.com/authorize')
+ get_authorization_uri: "https://example.com/authorize")
end
- it 'must show storage information box with login button' do
- within_test_selector('op-tab-content--tab-section', text: 'MY STORAGE', wait: 25) do
- expect(page).to have_button('Nextcloud login')
- expect(page).to have_text('Login to Nextcloud')
- expect(page).to have_list_item(text: 'logo.png')
+ it "must show storage information box with login button" do
+ within_test_selector("op-tab-content--tab-section", text: "MY STORAGE", wait: 25) do
+ expect(page).to have_button("Nextcloud login")
+ expect(page).to have_text("Login to Nextcloud")
+ expect(page).to have_list_item(text: "logo.png")
end
end
end
- context 'if an error occurred while authorizing to Nextcloud' do
+ context "if an error occurred while authorizing to Nextcloud" do
before do
allow(connection_manager).to receive(:authorization_state).and_return(:error)
end
- it 'must show storage information box' do
- within_test_selector('op-tab-content--tab-section', text: 'MY STORAGE', wait: 25) do
+ it "must show storage information box" do
+ within_test_selector("op-tab-content--tab-section", text: "MY STORAGE", wait: 25) do
expect(page).to have_no_button
- expect(page).to have_text('No Nextcloud connection')
- expect(page).to have_list_item(text: 'logo.png')
+ expect(page).to have_text("No Nextcloud connection")
+ expect(page).to have_list_item(text: "logo.png")
end
end
end
diff --git a/modules/storages/spec/features/storages/admin/create_storage_spec.rb b/modules/storages/spec/features/storages/admin/create_storage_spec.rb
index d21972003f23..85e7892292f3 100644
--- a/modules/storages/spec/features/storages/admin/create_storage_spec.rb
+++ b/modules/storages/spec/features/storages/admin/create_storage_spec.rb
@@ -28,153 +28,153 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe 'Admin Create a new file storage',
+RSpec.describe "Admin Create a new file storage",
:js,
:storage_server_helpers do
- shared_let(:admin) { create(:admin, preferences: { time_zone: 'Etc/UTC' }) }
+ shared_let(:admin) { create(:admin, preferences: { time_zone: "Etc/UTC" }) }
current_user { admin }
- context 'with Nextcloud Storage' do
- let(:secret) { 'awesome_secret' }
+ context "with Nextcloud Storage" do
+ let(:secret) { "awesome_secret" }
before do
allow(Doorkeeper::OAuth::Helpers::UniqueToken).to receive(:generate).and_return(secret)
end
- it 'renders a Nextcloud specific multi-step form', :webmock do
+ it "renders a Nextcloud specific multi-step form", :webmock do
visit admin_settings_storages_path
- expect(page).to be_axe_clean.within '#content'
+ expect(page).to be_axe_clean.within "#content"
- within('.PageHeader') { click_on("Storage") }
- within_test_selector('storages-select-provider-action-menu') { click_on('Nextcloud') }
+ within(".PageHeader") { click_on("Storage") }
+ within_test_selector("storages-select-provider-action-menu") { click_on("Nextcloud") }
- expect(page).to have_current_path(select_provider_admin_settings_storages_path(provider: 'nextcloud'))
+ expect(page).to have_current_path(select_provider_admin_settings_storages_path(provider: "nextcloud"))
- aggregate_failures 'Select provider view' do
+ aggregate_failures "Select provider view" do
# Page Header
- expect(page).to have_test_selector('storage-new-page-header--title', text: 'New Nextcloud storage')
- expect(page).to have_test_selector('storage-new-page-header--description',
+ expect(page).to have_test_selector("storage-new-page-header--title", text: "New Nextcloud storage")
+ expect(page).to have_test_selector("storage-new-page-header--description",
text: "Read our documentation on setting up a Nextcloud file storage " \
"integration for more information.")
# General information
- expect(page).to have_test_selector('storage-provider-configuration-instructions',
+ expect(page).to have_test_selector("storage-provider-configuration-instructions",
text: "Please make sure you have administration privileges in your " \
"Nextcloud instance and the application “Integration OpenProject” " \
"is installed before doing the setup.")
# OAuth application
- expect(page).to have_test_selector('storage-openproject-oauth-label', text: 'OpenProject OAuth')
- expect(page).not_to have_test_selector('label-openproject_oauth_application_configured-status')
+ expect(page).to have_test_selector("storage-openproject-oauth-label", text: "OpenProject OAuth")
+ expect(page).not_to have_test_selector("label-openproject_oauth_application_configured-status")
# OAuth client
- wait_for(page).to have_test_selector('storage-oauth-client-label', text: 'Nextcloud OAuth')
- expect(page).not_to have_test_selector('label-storage_oauth_client_configured-status')
- expect(page).to have_test_selector('storage-oauth-client-id-description',
+ wait_for(page).to have_test_selector("storage-oauth-client-label", text: "Nextcloud OAuth")
+ expect(page).not_to have_test_selector("label-storage_oauth_client_configured-status")
+ expect(page).to have_test_selector("storage-oauth-client-id-description",
text: "Allow OpenProject to access Nextcloud data using OAuth.")
# Automatically managed project folders
- expect(page).to have_test_selector('storage-managed-project-folders-label',
- text: 'Automatically managed folders')
- expect(page).not_to have_test_selector('label-managed-project-folders-status')
- expect(page).to have_test_selector('storage-automatically-managed-project-folders-description',
- text: 'Let OpenProject create folders per project automatically.')
+ expect(page).to have_test_selector("storage-managed-project-folders-label",
+ text: "Automatically managed folders")
+ expect(page).not_to have_test_selector("label-managed-project-folders-status")
+ expect(page).to have_test_selector("storage-automatically-managed-project-folders-description",
+ text: "Let OpenProject create folders per project automatically.")
end
- aggregate_failures 'General information' do
- within_test_selector('storage-general-info-form') do
- fill_in 'Name', with: 'My Nextcloud', fill_options: { clear: :backspace }
- click_on 'Save and continue'
+ aggregate_failures "General information" do
+ within_test_selector("storage-general-info-form") do
+ fill_in "Name", with: "My Nextcloud", fill_options: { clear: :backspace }
+ click_on "Save and continue"
expect(page).to have_text("Host is not a valid URL.")
mock_server_capabilities_response("https://example.com")
mock_server_config_check_response("https://example.com")
- fill_in 'Host', with: 'https://example.com'
- click_on 'Save and continue'
+ fill_in "Host", with: "https://example.com"
+ click_on "Save and continue"
end
- expect(page).to have_test_selector('label-host_name_configured-status', text: 'Completed')
- expect(page).to have_test_selector('storage-description', text: "Nextcloud - My Nextcloud - https://example.com")
+ expect(page).to have_test_selector("label-host_name_configured-status", text: "Completed")
+ expect(page).to have_test_selector("storage-description", text: "Nextcloud - My Nextcloud - https://example.com")
end
- aggregate_failures 'OAuth application' do
- within_test_selector('storage-openproject-oauth-application-form') do
- warning_section = find_test_selector('storage-openproject_oauth_application_warning')
- expect(warning_section).to have_text('The client secret value will not be accessible again after you close ' \
- 'this window. Please copy these values into the Nextcloud ' \
- 'OpenProject Integration settings.')
- expect(warning_section).to have_link('Nextcloud OpenProject Integration settings',
+ aggregate_failures "OAuth application" do
+ within_test_selector("storage-openproject-oauth-application-form") do
+ warning_section = find_test_selector("storage-openproject_oauth_application_warning")
+ expect(warning_section).to have_text("The client secret value will not be accessible again after you close " \
+ "this window. Please copy these values into the Nextcloud " \
+ "OpenProject Integration settings.")
+ expect(warning_section).to have_link("Nextcloud OpenProject Integration settings",
href: "https://example.com/settings/admin/openproject")
- storage = Storages::NextcloudStorage.find_by(host: 'https://example.com')
- expect(page).to have_css('#openproject_oauth_application_uid',
+ storage = Storages::NextcloudStorage.find_by(host: "https://example.com")
+ expect(page).to have_css("#openproject_oauth_application_uid",
value: storage.reload.oauth_application.uid)
- expect(page).to have_css('#openproject_oauth_application_secret',
+ expect(page).to have_css("#openproject_oauth_application_secret",
value: secret)
- click_on 'Done, continue'
+ click_on "Done, continue"
end
end
- aggregate_failures 'OAuth Client' do
- within_test_selector('storage-oauth-client-form') do
- expect(page).to have_test_selector('storage-provider-credentials-instructions',
- text: 'Copy these values from Nextcloud Administration / OpenProject.')
+ aggregate_failures "OAuth Client" do
+ within_test_selector("storage-oauth-client-form") do
+ expect(page).to have_test_selector("storage-provider-credentials-instructions",
+ text: "Copy these values from Nextcloud Administration / OpenProject.")
# With null values, form should render inline errors
- expect(page).to have_css('#oauth_client_client_id', value: '')
- expect(page).to have_css('#oauth_client_client_secret', value: '')
- click_on 'Save and continue'
+ expect(page).to have_css("#oauth_client_client_id", value: "")
+ expect(page).to have_css("#oauth_client_client_secret", value: "")
+ click_on "Save and continue"
expect(page).to have_text("Client ID can't be blank.")
expect(page).to have_text("Client secret can't be blank.")
# Happy path - Submit valid values
- fill_in 'Nextcloud OAuth Client ID', with: '1234567890'
- fill_in 'Nextcloud OAuth Client Secret', with: '0987654321'
- click_on 'Save and continue'
+ fill_in "Nextcloud OAuth Client ID", with: "1234567890"
+ fill_in "Nextcloud OAuth Client Secret", with: "0987654321"
+ click_on "Save and continue"
end
- expect(page).to have_test_selector('label-storage_oauth_client_configured-status', text: 'Completed')
- expect(page).to have_test_selector('storage-oauth-client-id-description', text: "OAuth Client ID: 1234567890")
+ expect(page).to have_test_selector("label-storage_oauth_client_configured-status", text: "Completed")
+ expect(page).to have_test_selector("storage-oauth-client-id-description", text: "OAuth Client ID: 1234567890")
end
- aggregate_failures 'Automatically managed project folders' do
- within_test_selector('storage-automatically-managed-project-folders-form') do
+ aggregate_failures "Automatically managed project folders" do
+ within_test_selector("storage-automatically-managed-project-folders-form") do
automatically_managed_switch = page.find('[name="storages_nextcloud_storage[automatic_management_enabled]"]')
- application_password_input = page.find_by_id('storages_nextcloud_storage_password')
+ application_password_input = page.find_by_id("storages_nextcloud_storage_password")
expect(automatically_managed_switch).to be_checked
expect(application_password_input.value).to be_empty
# Clicking submit with application password empty should show an error
- click_on('Done, complete setup')
+ click_on("Done, complete setup")
expect(page).to have_text("Password can't be blank.")
# Test the error path for an invalid storage password.
# Mock a valid response (=401) for example.com, so the password validation should fail
- mock_nextcloud_application_credentials_validation('https://example.com', password: "1234567890",
+ mock_nextcloud_application_credentials_validation("https://example.com", password: "1234567890",
response_code: 401)
automatically_managed_switch = page.find('[name="storages_nextcloud_storage[automatic_management_enabled]"]')
expect(automatically_managed_switch).to be_checked
- fill_in 'Application password', with: "1234567890"
+ fill_in "Application password", with: "1234567890"
# Clicking submit with application password empty should show an error
- click_on('Done, complete setup')
+ click_on("Done, complete setup")
expect(page).to have_text("Password is not valid.")
# Test the happy path for a valid storage password.
# Mock a valid response (=200) for example.com, so the password validation should succeed
# Fill in application password and submit
- mock_nextcloud_application_credentials_validation('https://example.com', password: "1234567890")
+ mock_nextcloud_application_credentials_validation("https://example.com", password: "1234567890")
automatically_managed_switch = page.find('[name="storages_nextcloud_storage[automatic_management_enabled]"]')
expect(automatically_managed_switch).to be_checked
- fill_in 'Application password', with: "1234567890"
- click_on('Done, complete setup')
+ fill_in "Application password", with: "1234567890"
+ click_on("Done, complete setup")
end
expect(page).to have_current_path(admin_settings_storages_path)
@@ -187,14 +187,14 @@
end
end
- context 'with OneDrive Storage and enterprise token missing', with_ee: false do
- it 'renders enterprise icon and redirects to upsale', :webmock do
+ context "with OneDrive Storage and enterprise token missing", with_ee: false do
+ it "renders enterprise icon and redirects to upsale", :webmock do
visit admin_settings_storages_path
- within('.PageHeader') { click_on("Storage") }
+ within(".PageHeader") { click_on("Storage") }
- within_test_selector('storages-select-provider-action-menu') do
- expect(page).to have_css('.octicon-op-enterprise-addons')
- click_on('OneDrive/SharePoint')
+ within_test_selector("storages-select-provider-action-menu") do
+ expect(page).to have_css(".octicon-op-enterprise-addons")
+ click_on("OneDrive/SharePoint")
end
expect(page).to have_current_path(upsale_admin_settings_storages_path)
@@ -202,81 +202,81 @@
end
end
- context 'with OneDrive Storage', with_ee: %i[one_drive_sharepoint_file_storage] do
- it 'renders a One Drive specific multi-step form', :webmock do
+ context "with OneDrive Storage", with_ee: %i[one_drive_sharepoint_file_storage] do
+ it "renders a One Drive specific multi-step form", :webmock do
visit admin_settings_storages_path
- expect(page).to be_axe_clean.within '#content'
+ expect(page).to be_axe_clean.within "#content"
- within('.PageHeader') { click_on("Storage") }
- within_test_selector('storages-select-provider-action-menu') { click_on('OneDrive/SharePoint') }
+ within(".PageHeader") { click_on("Storage") }
+ within_test_selector("storages-select-provider-action-menu") { click_on("OneDrive/SharePoint") }
- expect(page).to have_current_path(select_provider_admin_settings_storages_path(provider: 'one_drive'))
+ expect(page).to have_current_path(select_provider_admin_settings_storages_path(provider: "one_drive"))
- aggregate_failures 'Select provider view' do
+ aggregate_failures "Select provider view" do
# Page Header
- expect(page).to have_test_selector('storage-new-page-header--title', text: 'New OneDrive/SharePoint storage')
- expect(page).to have_test_selector('storage-new-page-header--description',
+ expect(page).to have_test_selector("storage-new-page-header--title", text: "New OneDrive/SharePoint storage")
+ expect(page).to have_test_selector("storage-new-page-header--description",
text: "Read our documentation on setting up a OneDrive/SharePoint " \
"file storage integration for more information.")
# General information
- expect(page).to have_test_selector('storage-provider-configuration-instructions',
+ expect(page).to have_test_selector("storage-provider-configuration-instructions",
text: "Please make sure you have administration privileges in the " \
"Azure portal or contact your Microsoft administrator before " \
"doing the setup. In the portal, you also need to register an " \
"Azure application or use an existing one for authentication.")
# OAuth client
- wait_for(page).to have_test_selector('storage-oauth-client-label', text: 'Azure OAuth')
- expect(page).not_to have_test_selector('label-storage_oauth_client_configured-status')
- expect(page).to have_test_selector('storage-oauth-client-id-description',
+ wait_for(page).to have_test_selector("storage-oauth-client-label", text: "Azure OAuth")
+ expect(page).not_to have_test_selector("label-storage_oauth_client_configured-status")
+ expect(page).to have_test_selector("storage-oauth-client-id-description",
text: "Allow OpenProject to access Azure data using OAuth " \
"to connect OneDrive/Sharepoint.")
- expect(page).to have_test_selector('storage-redirect-uri-description',
+ expect(page).to have_test_selector("storage-redirect-uri-description",
text: "Complete the setup with the correct URI redirection.")
end
- aggregate_failures 'General information' do
- within_test_selector('storage-general-info-form') do
- fill_in 'Name', with: 'My OneDrive', fill_options: { clear: :backspace }
- fill_in 'Directory (tenant) ID', with: '029d4741-a4be-44c6-a8e4-e4eff7b19f65'
- click_on 'Save and continue'
+ aggregate_failures "General information" do
+ within_test_selector("storage-general-info-form") do
+ fill_in "Name", with: "My OneDrive", fill_options: { clear: :backspace }
+ fill_in "Directory (tenant) ID", with: "029d4741-a4be-44c6-a8e4-e4eff7b19f65"
+ click_on "Save and continue"
expect(page).to have_text("Drive ID can't be blank.")
- fill_in 'Drive ID', with: '1234567890'
- click_on 'Save and continue'
+ fill_in "Drive ID", with: "1234567890"
+ click_on "Save and continue"
end
- wait_for(page).to have_test_selector('label-host_name_configured-storage_tenant_drive_configured-status',
- text: 'Completed')
- expect(page).to have_test_selector('storage-description', text: 'OneDrive/SharePoint - My OneDrive')
+ wait_for(page).to have_test_selector("label-host_name_configured-storage_tenant_drive_configured-status",
+ text: "Completed")
+ expect(page).to have_test_selector("storage-description", text: "OneDrive/SharePoint - My OneDrive")
end
- aggregate_failures 'OAuth Client' do
- within_test_selector('storage-oauth-client-form') do
- expect(page).to have_test_selector('storage-provider-credentials-instructions',
- text: 'Copy these values from the desired application in the ' \
- 'Azure portal.')
+ aggregate_failures "OAuth Client" do
+ within_test_selector("storage-oauth-client-form") do
+ expect(page).to have_test_selector("storage-provider-credentials-instructions",
+ text: "Copy these values from the desired application in the " \
+ "Azure portal.")
# With null values, upon submit validation errors are show
- expect(page).to have_css('#oauth_client_client_id', value: '')
- expect(page).to have_css('#oauth_client_client_secret', value: '')
- click_on 'Save and continue'
+ expect(page).to have_css("#oauth_client_client_id", value: "")
+ expect(page).to have_css("#oauth_client_client_secret", value: "")
+ click_on "Save and continue"
expect(page).to have_text("Client ID can't be blank.")
expect(page).to have_text("Client secret can't be blank.")
# Happy path - Submit valid values
- fill_in 'Azure OAuth Application (client) ID', with: '1234567890'
- fill_in 'Azure OAuth Client Secret Value', with: '0987654321'
- expect(find_test_selector('storage-oauth-client-submit-button')).not_to be_disabled
- click_on 'Save and continue'
+ fill_in "Azure OAuth Application (client) ID", with: "1234567890"
+ fill_in "Azure OAuth Client Secret Value", with: "0987654321"
+ expect(find_test_selector("storage-oauth-client-submit-button")).not_to be_disabled
+ click_on "Save and continue"
- expect(page).to have_test_selector('storage-oauth-client-redirect-uri')
+ expect(page).to have_test_selector("storage-oauth-client-redirect-uri")
- click_on 'Done, complete setup'
+ click_on "Done, complete setup"
end
expect(page).to have_current_path(admin_settings_storages_path)
@@ -289,9 +289,9 @@
end
end
- describe 'Select provider page' do
- context 'when navigating directly to the page' do
- it 'redirects you back to the index page' do
+ describe "Select provider page" do
+ context "when navigating directly to the page" do
+ it "redirects you back to the index page" do
visit select_provider_admin_settings_storages_path
expect(page).to have_current_path(admin_settings_storages_path)
@@ -299,9 +299,9 @@
end
end
- context 'when navigating to the page with an invalid provider' do
- it 'redirects you back to the index page' do
- visit select_provider_admin_settings_storages_path(provider: 'foobar')
+ context "when navigating to the page with an invalid provider" do
+ it "redirects you back to the index page" do
+ visit select_provider_admin_settings_storages_path(provider: "foobar")
expect(page).to have_current_path(admin_settings_storages_path)
wait_for(page).to have_text("Please select a valid storage provider.")
diff --git a/modules/storages/spec/features/storages/admin/index_storages_spec.rb b/modules/storages/spec/features/storages/admin/index_storages_spec.rb
index 5ee804522e3f..1d7e00cb790d 100644
--- a/modules/storages/spec/features/storages/admin/index_storages_spec.rb
+++ b/modules/storages/spec/features/storages/admin/index_storages_spec.rb
@@ -28,17 +28,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe 'Admin List File storages',
+RSpec.describe "Admin List File storages",
:js,
:storage_server_helpers do
- shared_let(:admin) { create(:admin, preferences: { time_zone: 'Etc/UTC' }) }
+ shared_let(:admin) { create(:admin, preferences: { time_zone: "Etc/UTC" }) }
current_user { admin }
- context 'with storages' do
+ context "with storages" do
shared_let(:nextcloud_storage) { create(:nextcloud_storage) }
shared_let(:one_drive_storage) { create(:one_drive_storage) }
@@ -46,32 +46,32 @@
visit admin_settings_storages_path
end
- it 'renders a list of all storages' do
- within :css, '#content' do
+ it "renders a list of all storages" do
+ within :css, "#content" do
expect(page).to have_list_item(count: 2)
expect(page).to have_list_item(nextcloud_storage.name)
expect(page).to have_list_item(one_drive_storage.name)
end
end
- it 'renders content that is accessible' do
- expect(page).to be_axe_clean.within('#content')
+ it "renders content that is accessible" do
+ expect(page).to be_axe_clean.within("#content")
end
end
- context 'with no storages' do
+ context "with no storages" do
before do
visit admin_settings_storages_path
end
- it 'renders a blank slate' do
- expect(page).to have_title('File storages')
- expect(page.find('.PageHeader-title')).to have_text('File storages')
+ it "renders a blank slate" do
+ expect(page).to have_title("File storages")
+ expect(page.find(".PageHeader-title")).to have_text("File storages")
expect(page).to have_text("You don't have any storages yet.")
end
- it 'renders content that is accessible' do
- expect(page).to be_axe_clean.within('#content')
+ it "renders content that is accessible" do
+ expect(page).to be_axe_clean.within("#content")
end
end
end
diff --git a/modules/storages/spec/features/storages/project_settings/oauth_access_grant_spec.rb b/modules/storages/spec/features/storages/project_settings/oauth_access_grant_spec.rb
index 18e74a656954..bdbc78c13065 100644
--- a/modules/storages/spec/features/storages/project_settings/oauth_access_grant_spec.rb
+++ b/modules/storages/spec/features/storages/project_settings/oauth_access_grant_spec.rb
@@ -28,13 +28,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe 'OAuth Access Grant Nudge upon adding a storage to a project',
+RSpec.describe "OAuth Access Grant Nudge upon adding a storage to a project",
:js,
:webmock do
- shared_let(:user) { create(:user, preferences: { time_zone: 'Etc/UTC' }) }
+ shared_let(:user) { create(:user, preferences: { time_zone: "Etc/UTC" }) }
shared_let(:role) do
create(:project_role, permissions: %i[manage_storages_in_project
@@ -54,7 +54,7 @@
current_user { user }
- let(:nonce) { '57a17c3f-b2ed-446e-9dd8-651ba3aec37d' }
+ let(:nonce) { "57a17c3f-b2ed-446e-9dd8-651ba3aec37d" }
let(:redirect_uri) do
"#{CGI.escape(OpenProject::Application.root_url)}/oauth_clients/#{storage.oauth_client.client_id}/callback"
end
@@ -64,24 +64,24 @@
allow(SecureRandom).to receive(:uuid).and_return(nonce).ordered
end
- it 'adds a storage, nudges the project admin to grant OAuth access' do
+ it "adds a storage, nudges the project admin to grant OAuth access" do
visit project_settings_project_storages_path(project_id: project)
- click_on('Storage')
+ click_on("Storage")
- expect(page).to have_select('Storage', options: ["#{storage.name} (nextcloud)"])
- click_on('Continue')
+ expect(page).to have_select("Storage", options: ["#{storage.name} (nextcloud)"])
+ click_on("Continue")
expect(page).to have_checked_field("New folder with automatically managed permissions")
- click_on('Add')
+ click_on("Add")
- expect(page).to have_text('File storages available in this project')
+ expect(page).to have_text("File storages available in this project")
expect(page).to have_text(storage.name)
- within_test_selector('oauth-access-grant-nudge-modal') do
+ within_test_selector("oauth-access-grant-nudge-modal") do
expect(page).to be_axe_clean
- expect(page).to have_text('One more step...')
- click_on('Login')
+ expect(page).to have_text("One more step...")
+ click_on("Login")
wait_for(page).to have_current_path("/index.php/apps/oauth2/authorize?client_id=#{storage.oauth_client.client_id}&" \
"redirect_uri=#{redirect_uri}&response_type=code&state=#{nonce}")
end
diff --git a/modules/storages/spec/features/storages_module_spec.rb b/modules/storages/spec/features/storages_module_spec.rb
index 5b17f8fe2d2b..06af43e500ae 100644
--- a/modules/storages/spec/features/storages_module_spec.rb
+++ b/modules/storages/spec/features/storages_module_spec.rb
@@ -28,116 +28,116 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe 'Storages module', :js do
+RSpec.describe "Storages module", :js do
current_user { create(:admin) }
let(:role) { create(:project_role, permissions: %i[manage_storages_in_project select_project_modules edit_project]) }
let(:storage) { create(:nextcloud_storage, name: "Storage 1") }
let(:project) { create(:project, enabled_module_names: %i[storages work_package_tracking]) }
- shared_examples_for 'content section has storages module' do |is_upcase = false|
+ shared_examples_for "content section has storages module" do |is_upcase = false|
it 'must show "storages" in content section' do
- within '#content' do
+ within "#content" do
text = I18n.t(:project_module_storages)
expect(page).to have_text(is_upcase ? text.upcase : text)
end
end
end
- shared_examples_for 'sidebar has storages module' do
+ shared_examples_for "sidebar has storages module" do
it 'must show "storages" in sidebar' do
- within '#menu-sidebar' do
+ within "#menu-sidebar" do
expect(page).to have_text(I18n.t(:project_module_storages))
end
end
end
- shared_examples_for 'has storages module' do |sections: %i[content sidebar], is_upcase: false|
+ shared_examples_for "has storages module" do |sections: %i[content sidebar], is_upcase: false|
before do
visit(path)
end
- include_examples 'content section has storages module', is_upcase if sections.include?(:content)
- include_examples 'sidebar has storages module' if sections.include?(:sidebar)
+ include_examples "content section has storages module", is_upcase if sections.include?(:content)
+ include_examples "sidebar has storages module" if sections.include?(:sidebar)
end
- context 'when in administration' do
- context 'when showing index page' do
- it_behaves_like 'has storages module' do
+ context "when in administration" do
+ context "when showing index page" do
+ it_behaves_like "has storages module" do
let(:path) { admin_index_path }
end
end
- context 'when showing system project settings page' do
- it_behaves_like 'has storages module', sections: [:content] do
+ context "when showing system project settings page" do
+ it_behaves_like "has storages module", sections: [:content] do
let(:path) { admin_settings_projects_path }
end
end
- context 'when showing system storage settings page' do
+ context "when showing system storage settings page" do
before do
visit admin_settings_storages_path
end
- it 'must show the page' do
+ it "must show the page" do
expect(page).to have_text(I18n.t(:project_module_storages))
end
end
- context 'when creating a new role' do
- it_behaves_like 'has storages module', sections: [:content], is_upcase: true do
+ context "when creating a new role" do
+ it_behaves_like "has storages module", sections: [:content], is_upcase: true do
let(:path) { new_role_path }
end
end
- context 'when editing a role' do
- it_behaves_like 'has storages module', sections: [:content], is_upcase: true do
+ context "when editing a role" do
+ it_behaves_like "has storages module", sections: [:content], is_upcase: true do
let(:path) { edit_role_path(role) }
end
end
- context 'when showing the role permissions report' do
- it_behaves_like 'has storages module', sections: [:content], is_upcase: true do
+ context "when showing the role permissions report" do
+ it_behaves_like "has storages module", sections: [:content], is_upcase: true do
let(:path) { report_roles_path(role) }
end
end
end
- context 'when in project administration' do
+ context "when in project administration" do
before do
storage
project
end
- context 'when showing the project module settings' do
- it_behaves_like 'has storages module' do
+ context "when showing the project module settings" do
+ it_behaves_like "has storages module" do
let(:path) { project_settings_modules_path(project) }
end
end
- context 'when showing project storages settings page' do
- context 'with storages module is enabled' do
+ context "when showing project storages settings page" do
+ context "with storages module is enabled" do
before do
visit project_settings_project_storages_path(project)
end
- it 'must show the page' do
- expect(page).to have_text(I18n.t('storages.page_titles.project_settings.index'))
+ it "must show the page" do
+ expect(page).to have_text(I18n.t("storages.page_titles.project_settings.index"))
end
end
- context 'with storages module is disabled' do
+ context "with storages module is disabled" do
let(:project) { create(:project, enabled_module_names: %i[work_package_tracking]) }
before do
visit project_settings_project_storages_path(project)
end
- it 'mustn\'t show the page' do
- expect(page).to have_no_text(I18n.t('storages.page_titles.project_settings.index'))
+ it "mustn't show the page" do
+ expect(page).to have_no_text(I18n.t("storages.page_titles.project_settings.index"))
end
end
end
diff --git a/modules/storages/spec/features/view_project_storage_members_spec.rb b/modules/storages/spec/features/view_project_storage_members_spec.rb
index 24a2f9d44387..5a05e768a6de 100644
--- a/modules/storages/spec/features/view_project_storage_members_spec.rb
+++ b/modules/storages/spec/features/view_project_storage_members_spec.rb
@@ -28,10 +28,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe 'Project storage members connection status view' do
+RSpec.describe "Project storage members connection status view" do
let(:user) { create(:user) }
let(:admin_user) { create(:admin) }
let(:connected_user) { create(:user) }
@@ -49,34 +49,34 @@
connected_no_permissions_user])
end
- it 'cannot be accessed without being logged in' do
+ it "cannot be accessed without being logged in" do
visit project_settings_project_storage_members_path(project, project_storage_id: project_storage.id)
- expect(page).to have_title('Sign in | OpenProject')
- expect(page).to have_no_text('Members connection status')
+ expect(page).to have_title("Sign in | OpenProject")
+ expect(page).to have_no_text("Members connection status")
end
- it 'lists project members connection statuses' do
+ it "lists project members connection statuses" do
login_as user
# Go to Projects -> Settings -> File Storages
visit project_settings_project_storages_path(project)
- expect(page).to have_title('File storages')
+ expect(page).to have_title("File storages")
expect(page).to have_text(storage.name)
- page.find('.icon.icon-group').click
+ page.find(".icon.icon-group").click
# Members connection status page
expect(page).to have_current_path project_settings_project_storage_members_path(project_id: project,
project_storage_id: project_storage)
- aggregate_failures 'Verifying Connection Statuses' do
+ aggregate_failures "Verifying Connection Statuses" do
[
- [user, 'Not connected. The user should login to the storage via the following link.'],
- [admin_user, 'Connected'],
- [connected_user, 'Connected'],
- [connected_no_permissions_user, 'User role has no storages permissions'],
- [disconnected_user, 'Not connected. The user should login to the storage via the following link.']
+ [user, "Not connected. The user should login to the storage via the following link."],
+ [admin_user, "Connected"],
+ [connected_user, "Connected"],
+ [connected_no_permissions_user, "User role has no storages permissions"],
+ [disconnected_user, "Not connected. The user should login to the storage via the following link."]
].each do |(principal, status)|
expect(page).to have_css("#member-#{principal.id} .name", text: principal.name)
expect(page).to have_css("#member-#{principal.id} .status", text: status)
@@ -84,7 +84,7 @@
end
end
- it 'lists no results when there are no project members' do
+ it "lists no results when there are no project members" do
login_as admin_user
project_no_members = create(:project, enabled_module_names: %i[storages])
project_storage_no_members = create(:project_storage, :as_automatically_managed, project: project_no_members, storage:)
@@ -92,16 +92,16 @@
# Go to Projects -> Settings -> File Storages
visit project_settings_project_storages_path(project_no_members)
- expect(page).to have_title('File storages')
+ expect(page).to have_title("File storages")
expect(page).to have_text(storage.name)
- page.find('.icon.icon-group').click
+ page.find(".icon.icon-group").click
# Members connection status page
expected_current_path = project_settings_project_storage_members_path(project_id: project_no_members,
project_storage_id: project_storage_no_members)
expect(page).to have_current_path(expected_current_path)
- expect(page).to have_text('No members to display.')
+ expect(page).to have_text("No members to display.")
end
def create_project_with_storage_and_members
diff --git a/modules/storages/spec/lib/api/v3/file_links/file_link_representer_parsing_spec.rb b/modules/storages/spec/lib/api/v3/file_links/file_link_representer_parsing_spec.rb
index 397683dfc1a0..00bedb0b16d9 100644
--- a/modules/storages/spec/lib/api/v3/file_links/file_link_representer_parsing_spec.rb
+++ b/modules/storages/spec/lib/api/v3/file_links/file_link_representer_parsing_spec.rb
@@ -28,10 +28,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe API::V3::FileLinks::FileLinkRepresenter, 'parsing' do
+RSpec.describe API::V3::FileLinks::FileLinkRepresenter, "parsing" do
include API::V3::Utilities::PathHelper
let(:file_link) { build_stubbed(:file_link) }
@@ -45,7 +45,7 @@
.and_return storage
end
- describe 'parsing' do
+ describe "parsing" do
subject(:parsed) { representer.from_hash parsed_hash }
let(:representer) do
@@ -71,8 +71,8 @@
}
end
- describe 'storage' do
- context 'if storage url is given with trailing slashes' do
+ describe "storage" do
+ context "if storage url is given with trailing slashes" do
let(:parsed_hash) do
{
"_links" => {
@@ -83,12 +83,12 @@
}
end
- it 'is parsed correctly' do
+ it "is parsed correctly" do
expect(parsed).to have_attributes(storage_id: storage.id)
end
end
- context 'if storage is given as resource' do
+ context "if storage is given as resource" do
let(:parsed_hash) do
{
"_links" => {
@@ -99,22 +99,22 @@
}
end
- it 'is parsed correctly' do
+ it "is parsed correctly" do
expect(parsed).to have_attributes(storage_id: storage.id)
end
end
end
- describe 'originData' do
- it 'is parsed correctly' do
+ describe "originData" do
+ it "is parsed correctly" do
expect(parsed).to have_attributes(storage_id: storage.id,
origin_id: "5503",
origin_name: "logo.png",
origin_mime_type: "image/png",
origin_created_by_name: "Luke Skywalker",
origin_last_modified_by_name: "Anakin Skywalker",
- origin_created_at: DateTime.new(2021, 12, 19, 9, 42, 10.17, '+00:00').in_time_zone,
- origin_updated_at: DateTime.new(2021, 12, 20, 14, 0, 13.987, '+00:00').in_time_zone)
+ origin_created_at: DateTime.new(2021, 12, 19, 9, 42, 10.17, "+00:00").in_time_zone,
+ origin_updated_at: DateTime.new(2021, 12, 20, 14, 0, 13.987, "+00:00").in_time_zone)
end
end
end
diff --git a/modules/storages/spec/lib/api/v3/file_links/file_link_representer_rendering_spec.rb b/modules/storages/spec/lib/api/v3/file_links/file_link_representer_rendering_spec.rb
index c9c706618b77..ff4d5bcc29d4 100644
--- a/modules/storages/spec/lib/api/v3/file_links/file_link_representer_rendering_spec.rb
+++ b/modules/storages/spec/lib/api/v3/file_links/file_link_representer_rendering_spec.rb
@@ -28,16 +28,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe API::V3::FileLinks::FileLinkRepresenter, 'rendering' do
+RSpec.describe API::V3::FileLinks::FileLinkRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
let(:storage) { build_stubbed(:nextcloud_storage) }
let(:container) { build_stubbed(:work_package) }
let(:project) { container.project }
- let(:creator) { build_stubbed(:user, firstname: 'Rey', lastname: 'Palpatine') }
+ let(:creator) { build_stubbed(:user, firstname: "Rey", lastname: "Palpatine") }
let(:origin_status) { :view_allowed }
let(:file_link) { build_stubbed(:file_link, storage:, container:, creator:, origin_status:) }
let(:user) { build_stubbed(:user) }
@@ -45,162 +45,162 @@
subject(:generated) { representer.to_json }
- describe '_links' do
- describe 'self' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ describe "self" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { "/api/v3/file_links/#{file_link.id}" }
let(:title) { file_link.name }
end
end
- describe 'storage' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'storage' }
+ describe "storage" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "storage" }
let(:href) { "/api/v3/storages/#{storage.id}" }
let(:title) { storage.name }
end
end
- describe 'container' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'container' }
+ describe "container" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "container" }
let(:href) { "/api/v3/work_packages/#{container.id}" }
let(:title) { container.name }
end
end
- describe 'creator' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'creator' }
+ describe "creator" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "creator" }
let(:href) { "/api/v3/users/#{creator.id}" }
let(:title) { creator.name }
end
end
- describe 'delete' do
+ describe "delete" do
let(:permission) { :manage_file_links }
- it_behaves_like 'has an untitled action link' do
- let(:link) { 'delete' }
+ it_behaves_like "has an untitled action link" do
+ let(:link) { "delete" }
let(:href) { "/api/v3/file_links/#{file_link.id}" }
let(:method) { :delete }
end
end
- describe 'status' do
- context 'with permission' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'status' }
- let(:href) { 'urn:openproject-org:api:v3:file-links:permission:ViewAllowed' }
- let(:title) { 'View allowed' }
+ describe "status" do
+ context "with permission" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "status" }
+ let(:href) { "urn:openproject-org:api:v3:file-links:permission:ViewAllowed" }
+ let(:title) { "View allowed" }
end
end
- context 'without permission' do
+ context "without permission" do
let(:origin_status) { :view_not_allowed }
- it_behaves_like 'has a titled link' do
- let(:link) { 'status' }
- let(:href) { 'urn:openproject-org:api:v3:file-links:permission:ViewNotAllowed' }
- let(:title) { 'View not allowed' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "status" }
+ let(:href) { "urn:openproject-org:api:v3:file-links:permission:ViewNotAllowed" }
+ let(:title) { "View not allowed" }
end
end
- context 'if not found' do
+ context "if not found" do
let(:origin_status) { :not_found }
- it_behaves_like 'has a titled link' do
- let(:link) { 'status' }
- let(:href) { 'urn:openproject-org:api:v3:file-links:NotFound' }
- let(:title) { 'Not found' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "status" }
+ let(:href) { "urn:openproject-org:api:v3:file-links:NotFound" }
+ let(:title) { "Not found" }
end
end
- context 'with status not defined (nil)' do
+ context "with status not defined (nil)" do
let(:origin_status) { nil }
- it_behaves_like 'has no link' do
- let(:link) { 'status' }
+ it_behaves_like "has no link" do
+ let(:link) { "status" }
end
end
- context 'with status check had an error' do
+ context "with status check had an error" do
let(:origin_status) { :error }
- it_behaves_like 'has a titled link' do
- let(:link) { 'status' }
- let(:href) { 'urn:openproject-org:api:v3:file-links:Error' }
- let(:title) { 'Error' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "status" }
+ let(:href) { "urn:openproject-org:api:v3:file-links:Error" }
+ let(:title) { "Error" }
end
end
end
- describe 'staticOriginOpen' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'staticOriginOpen' }
+ describe "staticOriginOpen" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "staticOriginOpen" }
let(:href) { "/api/v3/file_links/#{file_link.id}/open" }
end
end
- describe 'staticOriginOpenLocation' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'staticOriginOpenLocation' }
+ describe "staticOriginOpenLocation" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "staticOriginOpenLocation" }
let(:href) { "/api/v3/file_links/#{file_link.id}/open?location=true" }
end
end
- describe 'staticOriginDownload' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'staticOriginDownload' }
+ describe "staticOriginDownload" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "staticOriginDownload" }
let(:href) { "/api/v3/file_links/#{file_link.id}/download" }
end
end
end
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'FileLink' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "FileLink" }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { file_link.id }
end
- it_behaves_like 'datetime property', :createdAt do
+ it_behaves_like "datetime property", :createdAt do
let(:value) { file_link.created_at }
end
- it_behaves_like 'datetime property', :updatedAt do
+ it_behaves_like "datetime property", :updatedAt do
let(:value) { file_link.updated_at }
end
- describe 'originData' do
- it_behaves_like 'property', 'originData/id' do
+ describe "originData" do
+ it_behaves_like "property", "originData/id" do
let(:value) { file_link.origin_id }
end
- it_behaves_like 'property', 'originData/name' do
+ it_behaves_like "property", "originData/name" do
let(:value) { file_link.origin_name }
end
- it_behaves_like 'property', 'originData/mimeType' do
+ it_behaves_like "property", "originData/mimeType" do
let(:value) { file_link.origin_mime_type }
end
- it_behaves_like 'datetime property', 'originData/createdAt' do
+ it_behaves_like "datetime property", "originData/createdAt" do
let(:value) { file_link.origin_created_at }
end
- it_behaves_like 'datetime property', 'originData/lastModifiedAt' do
+ it_behaves_like "datetime property", "originData/lastModifiedAt" do
let(:value) { file_link.origin_updated_at }
end
- it_behaves_like 'property', 'originData/createdByName' do
+ it_behaves_like "property", "originData/createdByName" do
let(:value) { file_link.origin_created_by_name }
end
- it_behaves_like 'property', 'originData/lastModifiedByName' do
+ it_behaves_like "property", "originData/lastModifiedByName" do
let(:value) { file_link.origin_last_modified_by_name }
end
end
diff --git a/modules/storages/spec/lib/api/v3/project_storages/project_storage_representer_spec.rb b/modules/storages/spec/lib/api/v3/project_storages/project_storage_representer_spec.rb
index 01b27131d0f3..1fbfa228d1f1 100644
--- a/modules/storages/spec/lib/api/v3/project_storages/project_storage_representer_spec.rb
+++ b/modules/storages/spec/lib/api/v3/project_storages/project_storage_representer_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe API::V3::ProjectStorages::ProjectStorageRepresenter do
@@ -37,73 +37,73 @@
let(:user) { build_stubbed(:user) }
- let(:project_storage) { build_stubbed(:project_storage, project_folder_mode: 'manual', project_folder_id: '1337') }
+ let(:project_storage) { build_stubbed(:project_storage, project_folder_mode: "manual", project_folder_id: "1337") }
let(:representer) { described_class.new(project_storage, current_user: user) }
subject { representer.to_json }
- describe 'properties' do
- it_behaves_like 'property', :_type do
+ describe "properties" do
+ it_behaves_like "property", :_type do
let(:value) { representer._type }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { project_storage.id }
end
- it_behaves_like 'datetime property', :createdAt do
+ it_behaves_like "datetime property", :createdAt do
let(:value) { project_storage.created_at }
end
- it_behaves_like 'datetime property', :updatedAt do
+ it_behaves_like "datetime property", :updatedAt do
let(:value) { project_storage.updated_at }
end
- it_behaves_like 'property', :projectFolderMode do
+ it_behaves_like "property", :projectFolderMode do
let(:value) { project_storage.project_folder_mode }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'storage' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "storage" }
let(:href) { api_v3_paths.storage(project_storage.storage.id) }
let(:title) { project_storage.storage.name }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'project' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "project" }
let(:href) { api_v3_paths.project(project_storage.project.id) }
let(:title) { project_storage.project.name }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'creator' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "creator" }
let(:href) { api_v3_paths.user(project_storage.creator.id) }
let(:title) { project_storage.creator.name }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'projectFolder' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "projectFolder" }
let(:href) { api_v3_paths.storage_file(project_storage.storage.id, project_storage.project_folder_id) }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'open' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "open" }
let(:href) { api_v3_paths.project_storage_open(project_storage.id) }
end
- context 'when storage is not configured' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'openWithConnectionEnsured' }
+ context "when storage is not configured" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "openWithConnectionEnsured" }
let(:href) { nil }
end
end
- context 'when storage is not configured' do
+ context "when storage is not configured" do
before { project_storage.storage = create(:nextcloud_storage_configured) }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'openWithConnectionEnsured' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "openWithConnectionEnsured" }
let(:href) { ensure_connection_path(project_storage) }
end
end
diff --git a/modules/storages/spec/lib/api/v3/storage_files/storage_file_representer_spec.rb b/modules/storages/spec/lib/api/v3/storage_files/storage_file_representer_spec.rb
index 84e088d34b00..66c21f64b297 100644
--- a/modules/storages/spec/lib/api/v3/storage_files/storage_file_representer_spec.rb
+++ b/modules/storages/spec/lib/api/v3/storage_files/storage_file_representer_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe API::V3::StorageFiles::StorageFileRepresenter do
@@ -39,14 +39,14 @@
let(:file) do
Storages::StorageFile.new(
id: 42,
- name: 'readme.md',
+ name: "readme.md",
size: 4096,
- mime_type: 'text/plain',
+ mime_type: "text/plain",
created_at:,
last_modified_at:,
- created_by_name: 'admin',
- last_modified_by_name: 'admin',
- location: '/readme.md',
+ created_by_name: "admin",
+ last_modified_by_name: "admin",
+ location: "/readme.md",
permissions: %i[readable writeable]
)
end
@@ -54,56 +54,56 @@
subject { representer.to_json }
- describe 'properties' do
- it_behaves_like 'property', :_type do
+ describe "properties" do
+ it_behaves_like "property", :_type do
let(:value) { representer._type }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { file.id }
end
- it_behaves_like 'property', :name do
+ it_behaves_like "property", :name do
let(:value) { file.name }
end
- it_behaves_like 'property', :size do
+ it_behaves_like "property", :size do
let(:value) { file.size }
end
- it_behaves_like 'property', :mimeType do
+ it_behaves_like "property", :mimeType do
let(:value) { file.mime_type }
end
- it_behaves_like 'datetime property', :createdAt do
+ it_behaves_like "datetime property", :createdAt do
let(:value) { file.created_at }
end
- it_behaves_like 'datetime property', :lastModifiedAt do
+ it_behaves_like "datetime property", :lastModifiedAt do
let(:value) { file.last_modified_at }
end
- it_behaves_like 'property', :createdByName do
+ it_behaves_like "property", :createdByName do
let(:value) { file.created_by_name }
end
- it_behaves_like 'property', :lastModifiedByName do
+ it_behaves_like "property", :lastModifiedByName do
let(:value) { file.last_modified_by_name }
end
- it_behaves_like 'property', :location do
+ it_behaves_like "property", :location do
let(:value) { file.location }
end
- it_behaves_like 'property', :permissions do
+ it_behaves_like "property", :permissions do
let(:value) { file.permissions }
end
end
- describe '_links' do
- describe 'self' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ describe "self" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { "/api/v3/storages/#{storage.id}/files/#{file.id}" }
let(:title) { file.name }
end
diff --git a/modules/storages/spec/lib/api/v3/storage_files/storage_files_representer_spec.rb b/modules/storages/spec/lib/api/v3/storage_files/storage_files_representer_spec.rb
index 8d5778cbe9cc..960cc52c1f0a 100644
--- a/modules/storages/spec/lib/api/v3/storage_files/storage_files_representer_spec.rb
+++ b/modules/storages/spec/lib/api/v3/storage_files/storage_files_representer_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe API::V3::StorageFiles::StorageFilesRepresenter do
@@ -40,14 +40,14 @@
let(:parent) do
Storages::StorageFile.new(
id: 23,
- name: 'Documents',
+ name: "Documents",
size: 2048,
- mime_type: 'application/x-op-directory',
+ mime_type: "application/x-op-directory",
created_at:,
last_modified_at:,
- created_by_name: 'admin',
- last_modified_by_name: 'admin',
- location: '/Documents',
+ created_by_name: "admin",
+ last_modified_by_name: "admin",
+ location: "/Documents",
permissions: %i[readable writeable]
)
end
@@ -55,14 +55,14 @@
let(:file) do
Storages::StorageFile.new(
id: 42,
- name: 'readme.md',
+ name: "readme.md",
size: 4096,
- mime_type: 'text/plain',
+ mime_type: "text/plain",
created_at:,
last_modified_at:,
- created_by_name: 'admin',
- last_modified_by_name: 'admin',
- location: '/Documents/readme.md',
+ created_by_name: "admin",
+ last_modified_by_name: "admin",
+ location: "/Documents/readme.md",
permissions: %i[readable writeable]
)
end
@@ -70,14 +70,14 @@
let(:ancestor) do
Storages::StorageFile.new(
id: 47,
- name: '/',
+ name: "/",
size: 4096,
- mime_type: 'application/x-op-directory',
+ mime_type: "application/x-op-directory",
created_at:,
last_modified_at:,
- created_by_name: 'admin',
- last_modified_by_name: 'admin',
- location: '/',
+ created_by_name: "admin",
+ last_modified_by_name: "admin",
+ location: "/",
permissions: %i[readable writeable]
)
end
@@ -90,26 +90,26 @@
subject { representer.to_json }
- describe 'properties' do
- it_behaves_like 'property', :_type do
+ describe "properties" do
+ it_behaves_like "property", :_type do
let(:value) { representer._type }
end
- it_behaves_like 'collection', :files do
+ it_behaves_like "collection", :files do
let(:value) { files.files }
let(:element_decorator) do
->(value) { API::V3::StorageFiles::StorageFileRepresenter.new(value, storage, current_user: user) }
end
end
- it_behaves_like 'collection', :ancestors do
+ it_behaves_like "collection", :ancestors do
let(:value) { files.ancestors }
let(:element_decorator) do
->(value) { API::V3::StorageFiles::StorageFileRepresenter.new(value, storage, current_user: user) }
end
end
- it_behaves_like 'property', :parent do
+ it_behaves_like "property", :parent do
let(:value) { API::V3::StorageFiles::StorageFileRepresenter.new(files.parent, storage, current_user: user) }
end
end
diff --git a/modules/storages/spec/lib/api/v3/storage_files/storage_upload_link_representer_spec.rb b/modules/storages/spec/lib/api/v3/storage_files/storage_upload_link_representer_spec.rb
index ea98d586da16..faee87adc671 100644
--- a/modules/storages/spec/lib/api/v3/storage_files/storage_upload_link_representer_spec.rb
+++ b/modules/storages/spec/lib/api/v3/storage_files/storage_upload_link_representer_spec.rb
@@ -28,14 +28,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe API::V3::StorageFiles::StorageUploadLinkRepresenter, 'rendering' do
+RSpec.describe API::V3::StorageFiles::StorageUploadLinkRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
let(:user) { build_stubbed(:user) }
- let(:token) { 'xyz123' }
+ let(:token) { "xyz123" }
let(:destination) { "https://example.com/upload/#{token}" }
let(:upload_link) do
Storages::UploadLink.new("https://example.com/upload/#{token}")
@@ -44,28 +44,28 @@
subject { representer.to_json }
- describe 'links' do
- it { is_expected.to have_json_type(Object).at_path('_links') }
+ describe "links" do
+ it { is_expected.to have_json_type(Object).at_path("_links") }
- describe 'to self' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ describe "to self" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { "#{API::V3::URN_PREFIX}storages:upload_link:no_link_provided" }
end
end
- describe 'without finalize link' do
- describe 'to destination' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'destination' }
+ describe "without finalize link" do
+ describe "to destination" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "destination" }
let(:href) { destination }
- let(:title) { 'Upload File' }
+ let(:title) { "Upload File" }
end
end
- describe 'not to finalize' do
- it_behaves_like 'has no link' do
- let(:link) { 'finalize' }
+ describe "not to finalize" do
+ it_behaves_like "has no link" do
+ let(:link) { "finalize" }
end
end
end
diff --git a/modules/storages/spec/lib/api/v3/storages/storages_representer_parsing_spec.rb b/modules/storages/spec/lib/api/v3/storages/storages_representer_parsing_spec.rb
index 4f28cf83b85c..576043ba878c 100644
--- a/modules/storages/spec/lib/api/v3/storages/storages_representer_parsing_spec.rb
+++ b/modules/storages/spec/lib/api/v3/storages/storages_representer_parsing_spec.rb
@@ -28,14 +28,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe API::V3::Storages::StorageRepresenter, 'parsing' do
+RSpec.describe API::V3::Storages::StorageRepresenter, "parsing" do
let(:storage) { build_stubbed(:nextcloud_storage) }
let(:current_user) { build_stubbed(:user) }
- describe 'parsing' do
+ describe "parsing" do
subject(:parsed) { representer.from_hash parsed_hash }
let(:representer) { described_class.new(storage, current_user:) }
@@ -54,50 +54,50 @@
}
end
- context 'with basic attributes' do
- it 'is parsed correctly' do
- expect(parsed).to have_attributes(name: 'Nextcloud Local', host: storage.host,
+ context "with basic attributes" do
+ it "is parsed correctly" do
+ expect(parsed).to have_attributes(name: "Nextcloud Local", host: storage.host,
provider_type: "Storages::NextcloudStorage")
- aggregate_failures 'does not parse nextcloud provider fields' do
+ aggregate_failures "does not parse nextcloud provider fields" do
expect(parsed.provider_fields).to eq({})
end
end
end
- describe 'automatically managed project folders' do
- context 'with applicationPassword' do
+ describe "automatically managed project folders" do
+ context "with applicationPassword" do
let(:parsed_hash) do
super().merge(
"applicationPassword" => "secret"
)
end
- it 'is parsed correctly' do
- expect(parsed).to have_attributes(automatically_managed: true, password: 'secret')
+ it "is parsed correctly" do
+ expect(parsed).to have_attributes(automatically_managed: true, password: "secret")
end
end
- context 'with applicationPassword null' do
+ context "with applicationPassword null" do
let(:parsed_hash) do
super().merge(
"applicationPassword" => nil
)
end
- it 'is parsed as automatic folder management disabled' do
+ it "is parsed as automatic folder management disabled" do
expect(parsed).to have_attributes(automatically_managed: false, password: nil)
end
end
- context 'with applicationPassword blank' do
+ context "with applicationPassword blank" do
let(:parsed_hash) do
super().merge(
- "applicationPassword" => ''
+ "applicationPassword" => ""
)
end
- it 'is parsed as automatic folder management disabled' do
+ it "is parsed as automatic folder management disabled" do
expect(parsed).to have_attributes(automatically_managed: false, password: nil)
end
end
diff --git a/modules/storages/spec/lib/append_storages_hosts_to_csp_hook_spec.rb b/modules/storages/spec/lib/append_storages_hosts_to_csp_hook_spec.rb
index 7ce24de46e6f..2a8f48f0a9ef 100644
--- a/modules/storages/spec/lib/append_storages_hosts_to_csp_hook_spec.rb
+++ b/modules/storages/spec/lib/append_storages_hosts_to_csp_hook_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
# These specs mainly check that error messages from a sub-service
@@ -52,53 +52,53 @@ def trigger_application_controller_before_action_hook
hook_listener.application_controller_before_action(controller:)
end
- shared_examples 'content security policy directives' do
- it 'adds CSP connect_src directives' do
+ shared_examples "content security policy directives" do
+ it "adds CSP connect_src directives" do
trigger_application_controller_before_action_hook
expect(controller).to have_received(:append_content_security_policy_directives).with(connect_src: [storage.host])
end
end
- shared_examples 'does not change CSP' do
- it 'does not change CSP directives' do
+ shared_examples "does not change CSP" do
+ it "does not change CSP directives" do
trigger_application_controller_before_action_hook
expect(controller).not_to have_received(:append_content_security_policy_directives)
end
end
- context 'with a project with an active Nextcloud storage' do
- context 'when current user is an admin without being a member of any project' do
+ context "with a project with an active Nextcloud storage" do
+ context "when current user is an admin without being a member of any project" do
current_user { admin }
- include_examples 'content security policy directives'
+ include_examples "content security policy directives"
end
- context 'when current user is a member of the project with permission to manage file links' do
+ context "when current user is a member of the project with permission to manage file links" do
current_user { create(:user, member_with_permissions: { project => %i[manage_file_links] }) }
- include_examples 'content security policy directives'
+ include_examples "content security policy directives"
end
- context 'when current user is a member of the project without permission to manage file links' do
+ context "when current user is a member of the project without permission to manage file links" do
current_user { create(:user, member_with_permissions: { project => [] }) }
- it 'does not add CSP connect_src directive' do
+ it "does not add CSP connect_src directive" do
trigger_application_controller_before_action_hook
expect(controller).not_to have_received(:append_content_security_policy_directives).with(connect_src: [storage.host])
end
end
- context 'when the project is archived' do
+ context "when the project is archived" do
current_user { admin }
before do
project.update(active: false)
end
- it 'does not add CSP connect_src directive' do
+ it "does not add CSP connect_src directive" do
trigger_application_controller_before_action_hook
expect(controller).not_to have_received(:append_content_security_policy_directives).with(connect_src: [storage.host])
@@ -106,45 +106,45 @@ def trigger_application_controller_before_action_hook
end
end
- context 'with a project without an active storage' do
+ context "with a project without an active storage" do
current_user { admin }
let(:project_storage) { nil }
- include_examples 'does not change CSP'
+ include_examples "does not change CSP"
end
- context 'with a project without any storages configured' do
+ context "with a project without any storages configured" do
current_user { admin }
let(:project_storage) { nil }
let(:storage) { nil }
- include_examples 'does not change CSP'
+ include_examples "does not change CSP"
end
- context 'with an active Nextcloud storage having a host with a non-standard port' do
- let(:storage) { create(:nextcloud_storage, host: 'http://somehost.com:8080') }
+ context "with an active Nextcloud storage having a host with a non-standard port" do
+ let(:storage) { create(:nextcloud_storage, host: "http://somehost.com:8080") }
current_user { admin }
- it 'adds the port to the CSP directive' do
+ it "adds the port to the CSP directive" do
trigger_application_controller_before_action_hook
expect(controller).to have_received(:append_content_security_policy_directives) do |args|
- expect(args).to eq(connect_src: ['http://somehost.com:8080'])
+ expect(args).to eq(connect_src: ["http://somehost.com:8080"])
end
end
end
- context 'with an active Nextcloud storage having a host with a path' do
- let(:storage) { create(:nextcloud_storage, host: 'https://my.server.com/nextcloud') }
+ context "with an active Nextcloud storage having a host with a path" do
+ let(:storage) { create(:nextcloud_storage, host: "https://my.server.com/nextcloud") }
current_user { admin }
- it 'removes the path from the host for the CSP directive' do
+ it "removes the path from the host for the CSP directive" do
trigger_application_controller_before_action_hook
expect(controller).to have_received(:append_content_security_policy_directives) do |args|
- expect(args).to eq(connect_src: ['https://my.server.com'])
+ expect(args).to eq(connect_src: ["https://my.server.com"])
end
end
end
diff --git a/modules/storages/spec/models/storages/file_link_spec.rb b/modules/storages/spec/models/storages/file_link_spec.rb
index a619cf68ca6f..b46d82f77ec0 100644
--- a/modules/storages/spec/models/storages/file_link_spec.rb
+++ b/modules/storages/spec/models/storages/file_link_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::FileLink do
@@ -50,7 +50,7 @@
}
end
- describe '#create' do
+ describe "#create" do
it "creates an instance" do
file_link = described_class.create attributes
expect(file_link).to be_valid
@@ -67,7 +67,7 @@
end
end
- describe '#destroy' do
+ describe "#destroy" do
let(:file_link_to_destroy) { described_class.create(attributes) }
before do
diff --git a/modules/storages/spec/models/storages/last_project_folder_spec.rb b/modules/storages/spec/models/storages/last_project_folder_spec.rb
index 5dbfa50b88b4..74059939d6d1 100644
--- a/modules/storages/spec/models/storages/last_project_folder_spec.rb
+++ b/modules/storages/spec/models/storages/last_project_folder_spec.rb
@@ -28,16 +28,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::LastProjectFolder do
- describe '#mode' do
+ describe "#mode" do
let(:last_project_folder) { build(:last_project_folder) }
it do
expect(last_project_folder).to define_enum_for(:mode)
- .with_values(inactive: 'inactive', manual: 'manual', automatic: 'automatic')
+ .with_values(inactive: "inactive", manual: "manual", automatic: "automatic")
.backed_by_column_of_type(:string)
end
end
diff --git a/modules/storages/spec/models/storages/nextcloud_storage_spec.rb b/modules/storages/spec/models/storages/nextcloud_storage_spec.rb
index eae9c58e41bd..15c9c801b98a 100644
--- a/modules/storages/spec/models/storages/nextcloud_storage_spec.rb
+++ b/modules/storages/spec/models/storages/nextcloud_storage_spec.rb
@@ -28,59 +28,59 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_base_storage_spec'
+require "spec_helper"
+require_relative "shared_base_storage_spec"
require_module_spec_helper
RSpec.describe Storages::NextcloudStorage do
let(:storage) { create(:nextcloud_storage) }
- it_behaves_like 'base storage'
+ it_behaves_like "base storage"
- describe '.automatic_management_enabled' do
+ describe ".automatic_management_enabled" do
let!(:automatically_managed_storage) { create(:nextcloud_storage, :as_automatically_managed) }
let!(:not_automatically_managed_storage) { create(:nextcloud_storage, :as_not_automatically_managed) }
- it 'returns only storages with automatic management enabled' do
+ it "returns only storages with automatic management enabled" do
expect(described_class.automatic_management_enabled).to contain_exactly(automatically_managed_storage)
end
end
- describe '#provider_type?' do
+ describe "#provider_type?" do
it { expect(storage).to be_a_provider_type_nextcloud }
it { expect(storage).not_to be_a_provider_type_one_drive }
end
- describe 'health attributes' do
- it 'can be marked as healthy or unhealthy' do
- healthy_time = Time.parse '2021-03-14T15:17:00Z'
- unhealthy_time = Time.parse '2023-03-14T15:17:00Z'
+ describe "health attributes" do
+ it "can be marked as healthy or unhealthy" do
+ healthy_time = Time.parse "2021-03-14T15:17:00Z"
+ unhealthy_time = Time.parse "2023-03-14T15:17:00Z"
Timecop.freeze(healthy_time) do
expect do
storage.mark_as_healthy
end.to(change(storage, :health_changed_at).to(healthy_time)
- .and(change(storage, :health_status).from('pending').to('healthy')))
+ .and(change(storage, :health_status).from("pending").to("healthy")))
expect(storage.health_healthy?).to be(true)
expect(storage.health_unhealthy?).to be(false)
end
Timecop.freeze(unhealthy_time) do
expect do
- storage.mark_as_unhealthy(reason: 'thou_shall_not_pass_error')
+ storage.mark_as_unhealthy(reason: "thou_shall_not_pass_error")
end.to(change(storage, :health_changed_at).from(healthy_time).to(unhealthy_time)
- .and(change(storage, :health_status).from('healthy').to('unhealthy'))
- .and(change(storage, :health_reason).from(nil).to('thou_shall_not_pass_error')))
+ .and(change(storage, :health_status).from("healthy").to("unhealthy"))
+ .and(change(storage, :health_reason).from(nil).to("thou_shall_not_pass_error")))
end
expect(storage.health_healthy?).to be(false)
expect(storage.health_unhealthy?).to be(true)
end
- it 'has the correct changed_at and checked_at attributes' do
- healthy_time = Time.parse '2021-03-14T15:17:00Z'
- unhealthy_time_a = Time.parse '2023-03-14T00:00:00Z'
- unhealthy_time_b = Time.parse '2023-03-14T22:22:00Z'
- unhealthy_time_c = Time.parse '2023-03-14T11:11:00Z'
+ it "has the correct changed_at and checked_at attributes" do
+ healthy_time = Time.parse "2021-03-14T15:17:00Z"
+ unhealthy_time_a = Time.parse "2023-03-14T00:00:00Z"
+ unhealthy_time_b = Time.parse "2023-03-14T22:22:00Z"
+ unhealthy_time_c = Time.parse "2023-03-14T11:11:00Z"
reason_a = "thou_shall_not_pass_error"
reason_b = "inception_error"
@@ -116,18 +116,18 @@
end
end
- describe '#configured?' do
- context 'with a complete configuration' do
+ describe "#configured?" do
+ context "with a complete configuration" do
let(:storage) do
build(:nextcloud_storage,
oauth_application: build(:oauth_application),
oauth_client: build(:oauth_client))
end
- it 'returns true' do
+ it "returns true" do
expect(storage.configured?).to be(true)
- aggregate_failures 'configuration_checks' do
+ aggregate_failures "configuration_checks" do
expect(storage.configuration_checks)
.to eq(host_name_configured: true,
storage_oauth_client_configured: true,
@@ -136,26 +136,26 @@
end
end
- context 'without host name' do
+ context "without host name" do
let(:storage) { build(:nextcloud_storage, host: nil, name: nil) }
- it 'returns false' do
+ it "returns false" do
aggregate_failures do
expect(storage.configured?).to be(false)
- aggregate_failures 'configuration_checks' do
+ aggregate_failures "configuration_checks" do
expect(storage.configuration_checks[:host_name_configured]).to be(false)
end
end
end
end
- context 'without openproject and storage integrations' do
+ context "without openproject and storage integrations" do
let(:storage) { build(:nextcloud_storage) }
- it 'returns false' do
+ it "returns false" do
expect(storage.configured?).to be(false)
- aggregate_failures 'configuration_checks' do
+ aggregate_failures "configuration_checks" do
expect(storage.configuration_checks[:openproject_oauth_application_configured]).to be(false)
expect(storage.configuration_checks[:storage_oauth_client_configured]).to be(false)
end
@@ -163,7 +163,7 @@
end
end
- shared_examples 'a stored attribute with default value' do |attribute, default_value|
+ shared_examples "a stored attribute with default value" do |attribute, default_value|
context "when the provider fields are empty" do
let(:storage) { build(:nextcloud_storage, provider_fields: {}) }
@@ -175,26 +175,26 @@
context "with a new value of 'foo'" do
it "sets the value to 'foo'" do
- storage.public_send(:"#{attribute}=", 'foo')
- expect(storage.public_send(attribute)).to eq('foo')
+ storage.public_send(:"#{attribute}=", "foo")
+ expect(storage.public_send(attribute)).to eq("foo")
end
end
end
- describe '#username' do
- it_behaves_like 'a stored attribute with default value', :username, 'OpenProject'
+ describe "#username" do
+ it_behaves_like "a stored attribute with default value", :username, "OpenProject"
end
- describe '#group' do
- it_behaves_like 'a stored attribute with default value', :group, 'OpenProject'
+ describe "#group" do
+ it_behaves_like "a stored attribute with default value", :group, "OpenProject"
end
- describe '#group_folder' do
- it_behaves_like 'a stored attribute with default value', :group_folder, 'OpenProject'
+ describe "#group_folder" do
+ it_behaves_like "a stored attribute with default value", :group_folder, "OpenProject"
end
- describe '#automatic_management_new_record?' do
- context 'when automatic management has just been specified but not yet persisted' do
+ describe "#automatic_management_new_record?" do
+ context "when automatic management has just been specified but not yet persisted" do
let(:storage) { build_stubbed(:nextcloud_storage, provider_fields: {}) }
before { storage.automatic_management_enabled = false }
@@ -203,14 +203,14 @@
it { expect(storage).to be_automatic_management_new_record }
end
- context 'when automatic management was already specified' do
+ context "when automatic management was already specified" do
let(:storage) { build_stubbed(:nextcloud_storage, :as_not_automatically_managed) }
it { expect(storage).not_to be_provider_fields_changed }
it { expect(storage).not_to be_automatic_management_new_record }
end
- context 'when automatic management is unspecified' do
+ context "when automatic management is unspecified" do
let(:storage) { build_stubbed(:nextcloud_storage, provider_fields: {}) }
it { expect(storage).not_to be_provider_fields_changed }
@@ -218,31 +218,31 @@
end
end
- describe '#automatic_management_unspecified?' do
- context 'when automatic management enabled is nil' do
+ describe "#automatic_management_unspecified?" do
+ context "when automatic management enabled is nil" do
let(:storage) { build(:nextcloud_storage, automatic_management_enabled: nil) }
it { expect(storage).to be_automatic_management_unspecified }
end
- context 'when automatic management enabled is true' do
+ context "when automatic management enabled is true" do
let(:storage) { build(:nextcloud_storage, automatic_management_enabled: true) }
it { expect(storage).not_to be_automatic_management_unspecified }
end
- context 'when automatic management enabled is false' do
+ context "when automatic management enabled is false" do
let(:storage) { build(:nextcloud_storage, automatic_management_enabled: false) }
it { expect(storage).not_to be_automatic_management_unspecified }
end
end
- describe '#provider_fields_defaults' do
+ describe "#provider_fields_defaults" do
let(:storage) { build(:nextcloud_storage) }
- it 'returns the default values for nextcloud' do
- expect(storage.provider_fields_defaults).to eq({ automatic_management_enabled: true, username: 'OpenProject' })
+ it "returns the default values for nextcloud" do
+ expect(storage.provider_fields_defaults).to eq({ automatic_management_enabled: true, username: "OpenProject" })
end
end
end
diff --git a/modules/storages/spec/models/storages/one_drive_storage_spec.rb b/modules/storages/spec/models/storages/one_drive_storage_spec.rb
index d4c5c48cf146..dfbdd1cf64ba 100644
--- a/modules/storages/spec/models/storages/one_drive_storage_spec.rb
+++ b/modules/storages/spec/models/storages/one_drive_storage_spec.rb
@@ -28,27 +28,27 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_base_storage_spec'
+require "spec_helper"
+require_relative "shared_base_storage_spec"
RSpec.describe Storages::OneDriveStorage do
let(:storage) { build(:one_drive_storage) }
- it_behaves_like 'base storage'
+ it_behaves_like "base storage"
- describe '#provider_type?' do
+ describe "#provider_type?" do
it { expect(storage).to be_a_provider_type_one_drive }
it { expect(storage).not_to be_a_provider_type_nextcloud }
end
- describe '#configured?' do
- context 'with a complete configuration' do
+ describe "#configured?" do
+ context "with a complete configuration" do
let(:storage) { build(:one_drive_storage, oauth_client: build(:oauth_client)) }
- it 'returns true' do
+ it "returns true" do
expect(storage.configured?).to be(true)
- aggregate_failures 'configuration_checks' do
+ aggregate_failures "configuration_checks" do
expect(storage.configuration_checks)
.to eq(host_name_configured: true,
storage_oauth_client_configured: true,
@@ -57,13 +57,13 @@
end
end
- context 'without oauth client' do
+ context "without oauth client" do
let(:storage) { build(:one_drive_storage) }
- it 'returns false' do
+ it "returns false" do
expect(storage.configured?).to be(false)
- aggregate_failures 'configuration_checks' do
+ aggregate_failures "configuration_checks" do
expect(storage.configuration_checks[:storage_oauth_client_configured]).to be(false)
end
end
diff --git a/modules/storages/spec/models/storages/project_storage_spec.rb b/modules/storages/spec/models/storages/project_storage_spec.rb
index 79f49229c539..61ef1f8d33ee 100644
--- a/modules/storages/spec/models/storages/project_storage_spec.rb
+++ b/modules/storages/spec/models/storages/project_storage_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::ProjectStorage do
@@ -44,7 +44,7 @@
}
end
- describe '#create' do
+ describe "#create" do
it "creates an instance" do
project_storage = described_class.create attributes
expect(project_storage).to be_valid
@@ -63,7 +63,7 @@
end
end
- describe '#destroy' do
+ describe "#destroy" do
let(:project_storage_to_destroy) { described_class.create(attributes) }
let(:work_package) { create(:work_package, project:) }
let(:file_link) { create(:file_link, storage:, container_id: work_package.id) }
@@ -81,10 +81,10 @@
end
end
- describe '#automatic_management_possible?' do
+ describe "#automatic_management_possible?" do
let(:project_storage) { build_stubbed(:project_storage, storage:) }
- context 'when the storage is not a NextcloudStorage' do
+ context "when the storage is not a NextcloudStorage" do
let(:storage) { build_stubbed(:storage, :as_generic) }
it "returns false" do
@@ -92,16 +92,16 @@
end
end
- context 'when the storage is a NextcloudStorage' do
+ context "when the storage is a NextcloudStorage" do
let(:storage) { build_stubbed(:nextcloud_storage) }
- context 'when the storage is not automatically managed' do
+ context "when the storage is not automatically managed" do
it "returns false" do
expect(project_storage.automatic_management_possible?).to be false
end
end
- context 'when the storage is automatically managed' do
+ context "when the storage is automatically managed" do
before do
storage.automatically_managed = true
end
@@ -113,18 +113,18 @@
end
end
- describe '#project_folder_mode' do
+ describe "#project_folder_mode" do
let(:project_storage) { build(:project_storage) }
it do
expect(project_storage).to define_enum_for(:project_folder_mode)
- .with_values(inactive: 'inactive', manual: 'manual', automatic: 'automatic')
+ .with_values(inactive: "inactive", manual: "manual", automatic: "automatic")
.with_prefix(:project_folder)
.backed_by_column_of_type(:string)
end
end
- describe '#open' do
+ describe "#open" do
let(:user) { create(:user, member_with_permissions: { project => permissions }) }
let(:permissions) { %i[] }
let(:project_storage) do
@@ -136,56 +136,56 @@
end
let(:project_folder_id) { nil }
- context 'when inactive' do
- let(:project_folder_mode) { 'inactive' }
+ context "when inactive" do
+ let(:project_folder_mode) { "inactive" }
- it 'opens storage' do
+ it "opens storage" do
expect(project_storage.open(user).result).to eq("#{storage.host}/index.php/apps/files")
end
end
- context 'when manual' do
- let(:project_folder_mode) { 'manual' }
+ context "when manual" do
+ let(:project_folder_mode) { "manual" }
- context 'when project_folder_id is missing' do
- it 'opens storage' do
+ context "when project_folder_id is missing" do
+ it "opens storage" do
expect(project_storage.open(user).result).to eq("#{storage.host}/index.php/apps/files")
end
end
- context 'when project_folder_id is present' do
- let(:project_folder_id) { '123' }
+ context "when project_folder_id is present" do
+ let(:project_folder_id) { "123" }
- it 'opens project_folder' do
+ it "opens project_folder" do
expect(project_storage.open(user).result).to eq("#{storage.host}/index.php/f/123?openfile=1")
end
end
end
- context 'when automatic' do
- let(:project_folder_mode) { 'automatic' }
+ context "when automatic" do
+ let(:project_folder_mode) { "automatic" }
- context 'when user has no permissions to read files in storage' do
- let(:project_folder_mode) { 'automatic' }
+ context "when user has no permissions to read files in storage" do
+ let(:project_folder_mode) { "automatic" }
- it 'opens storage' do
+ it "opens storage" do
expect(project_storage.open(user).result).to eq("#{storage.host}/index.php/apps/files")
end
end
- context 'when user has permissions to read files in storage' do
+ context "when user has permissions to read files in storage" do
let(:permissions) { %i[read_files] }
- context 'when project_folder_id is missing' do
- it 'opens storage' do
+ context "when project_folder_id is missing" do
+ it "opens storage" do
expect(project_storage.open(user).result).to eq("#{storage.host}/index.php/apps/files")
end
end
- context 'when project_folder_id is present' do
- let(:project_folder_id) { '123' }
+ context "when project_folder_id is present" do
+ let(:project_folder_id) { "123" }
- it 'opens project_folder' do
+ it "opens project_folder" do
expect(project_storage.open(user).result).to eq("#{storage.host}/index.php/f/123?openfile=1")
end
end
diff --git a/modules/storages/spec/models/storages/shared_base_storage_spec.rb b/modules/storages/spec/models/storages/shared_base_storage_spec.rb
index 03b7fe0c4ab7..5ec1b5575a1b 100644
--- a/modules/storages/spec/models/storages/shared_base_storage_spec.rb
+++ b/modules/storages/spec/models/storages/shared_base_storage_spec.rb
@@ -28,46 +28,46 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-RSpec.shared_examples_for 'base storage' do
+RSpec.shared_examples_for "base storage" do
let(:default_attributes) do
{
- name: 'My storage',
- host: 'https://example.com',
+ name: "My storage",
+ host: "https://example.com",
creator: create(:user)
}
end
- describe '.shorten_provider_type' do
- context 'when provider_type matches the signature' do
- it 'responds with shortened provider type' do
+ describe ".shorten_provider_type" do
+ context "when provider_type matches the signature" do
+ it "responds with shortened provider type" do
expect(
described_class.shorten_provider_type(described_class::PROVIDER_TYPE_NEXTCLOUD)
- ).to eq('nextcloud')
+ ).to eq("nextcloud")
expect(
described_class.shorten_provider_type(described_class::PROVIDER_TYPE_ONE_DRIVE)
- ).to eq('one_drive')
+ ).to eq("one_drive")
end
end
- context 'when provider_type does not match the signature' do
- it 'raises an error', :aggregate_failures do
+ context "when provider_type does not match the signature" do
+ it "raises an error", :aggregate_failures do
expect do
- described_class.shorten_provider_type('Storages::Nextcloud')
- end.to raise_error('Unknown provider_type! Given: Storages::Nextcloud. ' \
- 'Expected the following signature: Storages::{Name of the provider}Storage')
+ described_class.shorten_provider_type("Storages::Nextcloud")
+ end.to raise_error("Unknown provider_type! Given: Storages::Nextcloud. " \
+ "Expected the following signature: Storages::{Name of the provider}Storage")
expect do
- described_class.shorten_provider_type('Storages:NextcloudStorage')
- end.to raise_error('Unknown provider_type! Given: Storages:NextcloudStorage. ' \
- 'Expected the following signature: Storages::{Name of the provider}Storage')
+ described_class.shorten_provider_type("Storages:NextcloudStorage")
+ end.to raise_error("Unknown provider_type! Given: Storages:NextcloudStorage. " \
+ "Expected the following signature: Storages::{Name of the provider}Storage")
expect do
- described_class.shorten_provider_type('Storages::NextcloudStorag')
- end.to raise_error('Unknown provider_type! Given: Storages::NextcloudStorag. ' \
- 'Expected the following signature: Storages::{Name of the provider}Storage')
+ described_class.shorten_provider_type("Storages::NextcloudStorag")
+ end.to raise_error("Unknown provider_type! Given: Storages::NextcloudStorag. " \
+ "Expected the following signature: Storages::{Name of the provider}Storage")
end
end
end
- describe '#create' do
+ describe "#create" do
it "creates an instance" do
storage = described_class.create default_attributes
expect(storage).to be_valid
@@ -81,16 +81,16 @@
end
it "fails the validation if name is not unique" do
- expect(described_class.create(default_attributes.merge({ host: 'https://example2.com' }))).not_to be_valid
+ expect(described_class.create(default_attributes.merge({ host: "https://example2.com" }))).not_to be_valid
end
it "fails the validation if host is not unique" do
- expect(described_class.create(default_attributes.merge({ name: 'Another storage' }))).not_to be_valid
+ expect(described_class.create(default_attributes.merge({ name: "Another storage" }))).not_to be_valid
end
end
end
- describe '#destroy' do
+ describe "#destroy" do
let(:project) { create(:project) }
let(:storage) { described_class.create(default_attributes) }
let(:project_storage) { create(:project_storage, project:, storage:, creator: create(:user)) }
diff --git a/modules/storages/spec/models/storages/storage_spec.rb b/modules/storages/spec/models/storages/storage_spec.rb
index 0b55a825b24d..358a850879cd 100644
--- a/modules/storages/spec/models/storages/storage_spec.rb
+++ b/modules/storages/spec/models/storages/storage_spec.rb
@@ -28,19 +28,19 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Storage do
describe "provider_fields" do
let(:storage) { build(:storage, provider_fields: {}) }
- shared_examples 'a stored boolean attribute' do |attribute|
+ shared_examples "a stored boolean attribute" do |attribute|
it "#{attribute} has a default value of false" do
expect(storage.public_send(:"#{attribute}?")).to be(false)
end
- ['1', 'true', true].each do |boolean_like|
+ ["1", "true", true].each do |boolean_like|
context "with truthy value #{boolean_like}" do
it "sets #{attribute} to true" do
storage.public_send(:"#{attribute}=", boolean_like)
@@ -57,24 +57,24 @@
end
end
- describe '#automatically_managed' do
- it_behaves_like 'a stored boolean attribute', :automatically_managed
+ describe "#automatically_managed" do
+ it_behaves_like "a stored boolean attribute", :automatically_managed
end
- describe '#automatic_management_enabled?' do
- context 'when automatic management enabled is true' do
+ describe "#automatic_management_enabled?" do
+ context "when automatic management enabled is true" do
let(:storage) { build(:storage, automatic_management_enabled: true) }
it { expect(storage).to be_automatic_management_enabled }
end
- context 'when automatic management enabled is false' do
+ context "when automatic management enabled is false" do
let(:storage) { build(:storage, automatic_management_enabled: false) }
it { expect(storage).not_to be_automatic_management_enabled }
end
- context 'when automatic management enabled is nil' do
+ context "when automatic management enabled is nil" do
let(:storage) { build(:storage, automatic_management_enabled: nil) }
it { expect(storage.automatic_management_enabled?).to be(false) }
diff --git a/modules/storages/spec/permissions/manage_storage_in_project_spec.rb b/modules/storages/spec/permissions/manage_storage_in_project_spec.rb
index ce5787ac0451..659be862fbf9 100644
--- a/modules/storages/spec/permissions/manage_storage_in_project_spec.rb
+++ b/modules/storages/spec/permissions/manage_storage_in_project_spec.rb
@@ -28,11 +28,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
# rubocop:disable RSpec/EmptyExampleGroup
-RSpec.describe Storages::Admin::ProjectStoragesController, 'manage_storage_in_project permission', type: :controller do
+RSpec.describe Storages::Admin::ProjectStoragesController, "manage_storage_in_project permission", type: :controller do
include PermissionSpecs
controller_actions.each do |action|
diff --git a/modules/storages/spec/requests/api/v3/file_links/mixed_case_file_links_integration_spec.rb b/modules/storages/spec/requests/api/v3/file_links/mixed_case_file_links_integration_spec.rb
index 52ce9309fd27..e4a3729c7ee6 100644
--- a/modules/storages/spec/requests/api/v3/file_links/mixed_case_file_links_integration_spec.rb
+++ b/modules/storages/spec/requests/api/v3/file_links/mixed_case_file_links_integration_spec.rb
@@ -28,11 +28,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
# We want to check the case of file_links from multiple storages
-RSpec.describe 'API v3 file links resource' do
+RSpec.describe "API v3 file links resource" do
include API::V3::Utilities::PathHelper
let(:project) { create(:project) }
@@ -72,8 +72,8 @@
# No token for oauth_client_notoken!
let(:file_link_happy) { create(:file_link, origin_id: "24", storage: storage_good, container: work_package) }
- let(:file_link_other_user) { create(:file_link, origin_id: '25', storage: storage_good, container: work_package) }
- let(:file_link_deleted) { create(:file_link, origin_id: '26', storage: storage_good, container: work_package) }
+ let(:file_link_other_user) { create(:file_link, origin_id: "25", storage: storage_good, container: work_package) }
+ let(:file_link_deleted) { create(:file_link, origin_id: "26", storage: storage_good, container: work_package) }
let(:file_link_unauth_happy) { create(:file_link, origin_id: "28", storage: storage_unauth, container: work_package) }
let(:file_link_error_happy) { create(:file_link, origin_id: "29", storage: storage_error, container: work_package) }
@@ -129,16 +129,16 @@
login_as user
end
- describe 'GET /api/v3/work_packages/:work_package_id/file_links', :webmock do
+ describe "GET /api/v3/work_packages/:work_package_id/file_links", :webmock do
let(:path) { api_v3_paths.file_links(work_package.id) }
let(:response_host_happy) do
{
ocs: {
meta: ocs_meta_s200,
data: {
- '24': file_info_happy,
- '25': file_info_s403,
- '26': file_info_s404
+ "24": file_info_happy,
+ "25": file_info_s403,
+ "26": file_info_s404
}
}
}.to_json
@@ -148,12 +148,12 @@
oauth_client_token_good
# https://host-good/: Simulate a successfully authorized reply with updates from Nextcloud
- stub_request(:post, File.join(host_good, '/ocs/v1.php/apps/integration_openproject/filesinfo'))
- .to_return(status: 200, headers: { 'Content-Type': 'application/json' }, body: response_host_happy)
+ stub_request(:post, File.join(host_good, "/ocs/v1.php/apps/integration_openproject/filesinfo"))
+ .to_return(status: 200, headers: { "Content-Type": "application/json" }, body: response_host_happy)
# https://host-unauth/: Simulates a Nextcloud with Bearer token expired or non existing
- stub_request(:post, File.join(host_unauth, '/ocs/v1.php/apps/integration_openproject/filesinfo'))
- .to_return(status: 200, headers: { 'Content-Type': 'application/json' }, body: response_host_happy)
+ stub_request(:post, File.join(host_unauth, "/ocs/v1.php/apps/integration_openproject/filesinfo"))
+ .to_return(status: 200, headers: { "Content-Type": "application/json" }, body: response_host_happy)
# https://host-error/: Simulates a Nextcloud with network timeout
stub_request(:post, host_error).to_return(status: 500)
@@ -162,14 +162,14 @@
stub_request(:post, host_timeout).to_timeout
# https://host-notoken/: Simulate a Nextcloud with no oauth_token yet
- stub_request(:post, File.join(host_notoken, '/ocs/v1.php/apps/integration_openproject/filesinfo'))
- .to_return(status: 200, headers: { 'Content-Type': 'application/json' }, body: response_host_happy)
+ stub_request(:post, File.join(host_notoken, "/ocs/v1.php/apps/integration_openproject/filesinfo"))
+ .to_return(status: 200, headers: { "Content-Type": "application/json" }, body: response_host_happy)
get path
end
# total, count, element_type, collection_type = 'Collection'
- it_behaves_like 'API V3 collection response', 6, 6, 'FileLink', 'Collection' do
+ it_behaves_like "API V3 collection response", 6, 6, "FileLink", "Collection" do
let(:elements) do
[
file_link_timeout_happy,
@@ -182,7 +182,7 @@
end
end
- it 'returns the file_links with correct Nextcloud data applied' do
+ it "returns the file_links with correct Nextcloud data applied" do
# GET returns a collection of FileLinks in "_embedded/elements"
elements = JSON.parse(subject.body).dig("_embedded", "elements")
@@ -199,7 +199,7 @@
# The deleted_file_link should not even appear in the Database anymore
deleted_file_link = elements.detect { |e| e["originData"]["id"] == "27" }
expect(deleted_file_link).to be_nil
- expect(Storages::FileLink.where(origin_id: '27').count).to be 0
+ expect(Storages::FileLink.where(origin_id: "27").count).to be 0
# The FileLink from a Nextcloud with error should have origin_status=:error
error_file_link = elements.detect { |e| e["originData"]["id"] == "29" }
diff --git a/modules/storages/spec/requests/api/v3/project_storages/project_storages_spec.rb b/modules/storages/spec/requests/api/v3/project_storages/project_storages_spec.rb
index d79ea2ecfa52..0fd70f3a284c 100644
--- a/modules/storages/spec/requests/api/v3/project_storages/project_storages_spec.rb
+++ b/modules/storages/spec/requests/api/v3/project_storages/project_storages_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe 'API v3 project storages resource', :webmock, content_type: :json do
+RSpec.describe "API v3 project storages resource", :webmock, content_type: :json do
include API::V3::Utilities::PathHelper
let(:view_permissions) { %i(view_work_packages view_file_links) }
@@ -52,16 +52,16 @@
before { login_as current_user }
- describe 'GET /api/v3/project_storages' do
+ describe "GET /api/v3/project_storages" do
let(:path) { api_v3_paths.project_storages }
- context 'as admin' do
+ context "as admin" do
let(:current_user) { create(:admin) }
subject { last_response.body }
- describe 'gets full project storage collection' do
- it_behaves_like 'API V3 collection response', 6, 6, 'ProjectStorage', 'Collection' do
+ describe "gets full project storage collection" do
+ it_behaves_like "API V3 collection response", 6, 6, "ProjectStorage", "Collection" do
let(:elements) do
[
project_storage31,
@@ -75,99 +75,99 @@
end
end
- context 'with project filter' do
+ context "with project filter" do
let(:filters) { [{ projectId: { operator: "=", values: [project_id] } }] }
let(:path) { api_v3_paths.path_for(:project_storages, filters:) }
- describe 'gets all project storages of the filtered project' do
+ describe "gets all project storages of the filtered project" do
let(:project_id) { project2.id }
- it_behaves_like 'API V3 collection response', 2, 2, 'ProjectStorage', 'Collection' do
+ it_behaves_like "API V3 collection response", 2, 2, "ProjectStorage", "Collection" do
let(:elements) { [project_storage21, project_storage23] }
end
end
- context 'with invalid project id' do
- let(:project_id) { '1337' }
+ context "with invalid project id" do
+ let(:project_id) { "1337" }
- it_behaves_like 'invalid filters'
+ it_behaves_like "invalid filters"
end
- context 'with project id of project with no storages' do
+ context "with project id of project with no storages" do
let(:project) { create(:project) }
let(:project_id) { project.id }
- it_behaves_like 'API V3 collection response', 0, 0, 'ProjectStorage', 'Collection' do
+ it_behaves_like "API V3 collection response", 0, 0, "ProjectStorage", "Collection" do
let(:elements) { [] }
end
end
end
- context 'with storage id filter' do
+ context "with storage id filter" do
let(:filters) { [{ storageId: { operator: "=", values: [storage_id] } }] }
let(:path) { api_v3_paths.path_for(:project_storages, filters:) }
- describe 'gets all project storages of the filtered project' do
+ describe "gets all project storages of the filtered project" do
let(:storage_id) { storage3.id }
- it_behaves_like 'API V3 collection response', 2, 2, 'ProjectStorage', 'Collection' do
+ it_behaves_like "API V3 collection response", 2, 2, "ProjectStorage", "Collection" do
let(:elements) { [project_storage23, project_storage13] }
end
end
- context 'with unknown storage id' do
- let(:storage_id) { '1337' }
+ context "with unknown storage id" do
+ let(:storage_id) { "1337" }
- it_behaves_like 'API V3 collection response', 0, 0, 'ProjectStorage', 'Collection' do
+ it_behaves_like "API V3 collection response", 0, 0, "ProjectStorage", "Collection" do
let(:elements) { [] }
end
end
- context 'with storage id of storage with no linked projects' do
+ context "with storage id of storage with no linked projects" do
let(:storage) { create(:nextcloud_storage) }
let(:storage_id) { storage.id }
- it_behaves_like 'API V3 collection response', 0, 0, 'ProjectStorage', 'Collection' do
+ it_behaves_like "API V3 collection response", 0, 0, "ProjectStorage", "Collection" do
let(:elements) { [] }
end
end
end
- context 'with storage url filter' do
+ context "with storage url filter" do
let(:filters) { [{ storageUrl: { operator: "=", values: [storage_url] } }] }
let(:path) { api_v3_paths.path_for(:project_storages, filters:) }
- describe 'gets all project storages of the filtered project' do
+ describe "gets all project storages of the filtered project" do
let(:storage_url) { CGI.escape(storage3.host) }
- it_behaves_like 'API V3 collection response', 2, 2, 'ProjectStorage', 'Collection' do
+ it_behaves_like "API V3 collection response", 2, 2, "ProjectStorage", "Collection" do
let(:elements) { [project_storage23, project_storage13] }
end
end
- context 'with invalid storage url' do
+ context "with invalid storage url" do
let(:storage_url) { nil }
- it_behaves_like 'invalid filters'
+ it_behaves_like "invalid filters"
end
- context 'with storage url of storage with no linked projects' do
+ context "with storage url of storage with no linked projects" do
let(:storage) { create(:nextcloud_storage) }
let(:storage_url) { storage.host }
- it_behaves_like 'API V3 collection response', 0, 0, 'ProjectStorage', 'Collection' do
+ it_behaves_like "API V3 collection response", 0, 0, "ProjectStorage", "Collection" do
let(:elements) { [] }
end
end
end
end
- context 'as user with permissions' do
+ context "as user with permissions" do
let(:current_user) do
create(:user, member_with_permissions: { project1 => view_permissions, project3 => view_permissions })
end
- it_behaves_like 'API V3 collection response', 4, 4, 'ProjectStorage', 'Collection' do
+ it_behaves_like "API V3 collection response", 4, 4, "ProjectStorage", "Collection" do
let(:elements) do
[
project_storage31,
@@ -179,24 +179,24 @@
end
end
- context 'as user without permissions' do
+ context "as user without permissions" do
let(:current_user) do
create(:user, member_with_permissions: { project1 => [], project2 => [], project3 => [] })
end
- it_behaves_like 'API V3 collection response', 0, 0, 'ProjectStorage', 'Collection' do
+ it_behaves_like "API V3 collection response", 0, 0, "ProjectStorage", "Collection" do
let(:elements) { [] }
end
end
end
- describe 'GET /api/v3/project_storages/:id' do
+ describe "GET /api/v3/project_storages/:id" do
let(:project_storage) do
create(:project_storage,
project: project3,
storage: storage3,
- project_folder_id: '1337',
- project_folder_mode: 'manual')
+ project_folder_id: "1337",
+ project_folder_mode: "manual")
end
let(:project_storage_id) { project_storage.id }
let(:path) { api_v3_paths.project_storage(project_storage_id) }
@@ -206,94 +206,94 @@
subject { last_response.body }
- it_behaves_like 'successful response'
+ it_behaves_like "successful response"
- it { is_expected.to be_json_eql(api_v3_paths.storage_file(storage3.id, '1337').to_json).at_path('_links/projectFolder/href') }
+ it { is_expected.to be_json_eql(api_v3_paths.storage_file(storage3.id, "1337").to_json).at_path("_links/projectFolder/href") }
- it { is_expected.to be_json_eql('manual'.to_json).at_path('projectFolderMode') }
+ it { is_expected.to be_json_eql("manual".to_json).at_path("projectFolderMode") }
- context 'if user has permission to see file storages in project' do
+ context "if user has permission to see file storages in project" do
let(:current_user) do
create(:user, member_with_permissions: { project3 => [] })
end
- it_behaves_like 'not found'
+ it_behaves_like "not found"
end
- context 'if user is not member in related project' do
+ context "if user is not member in related project" do
let(:project_storage_id) { project_storage11.id }
- it_behaves_like 'not found'
+ it_behaves_like "not found"
end
- context 'if project storage does not exists' do
- let(:project_storage_id) { '1337' }
+ context "if project storage does not exists" do
+ let(:project_storage_id) { "1337" }
- it_behaves_like 'not found'
+ it_behaves_like "not found"
end
end
- describe 'GET /api/v3/project_storages/:id/open' do
+ describe "GET /api/v3/project_storages/:id/open" do
let(:path) { api_v3_paths.project_storage_open(project_storage11.id) }
- let(:location) { 'https://deathstar.storage.org/files' }
- let(:location_project_folder) { 'https://deathstar.storage.org/files/data/project_destroy_alderan' }
+ let(:location) { "https://deathstar.storage.org/files" }
+ let(:location_project_folder) { "https://deathstar.storage.org/files/data/project_destroy_alderan" }
let(:current_user) do
create(:user, member_with_permissions: { project1 => view_permissions })
end
before do
Storages::Peripherals::Registry.stub(
- 'nextcloud.queries.open_storage',
+ "nextcloud.queries.open_storage",
->(_) { ServiceResult.success(result: location) }
)
Storages::Peripherals::Registry.stub(
- 'nextcloud.queries.open_file_link',
+ "nextcloud.queries.open_file_link",
->(_) { ServiceResult.success(result: location_project_folder) }
)
end
- context 'as admin' do
+ context "as admin" do
let(:current_user) { create(:admin) }
- it_behaves_like 'redirect response'
+ it_behaves_like "redirect response"
end
- context 'if user belongs to a project related to project storage' do
- it_behaves_like 'redirect response'
+ context "if user belongs to a project related to project storage" do
+ it_behaves_like "redirect response"
- context 'if project storage has a configured project folder' do
+ context "if project storage has a configured project folder" do
before(:all) do
project_storage12.update(
- project_folder_id: '1337',
- project_folder_mode: 'manual'
+ project_folder_id: "1337",
+ project_folder_mode: "manual"
)
end
after(:all) do
project_storage12.update(
project_folder_id: nil,
- project_folder_mode: 'inactive'
+ project_folder_mode: "inactive"
)
end
let(:path) { api_v3_paths.project_storage_open(project_storage12.id) }
- it_behaves_like 'redirect response' do
+ it_behaves_like "redirect response" do
let(:location) { location_project_folder }
end
end
- context 'if user is missing permission view_file_links' do
+ context "if user is missing permission view_file_links" do
let(:view_permissions) { [] }
- it_behaves_like 'not found'
+ it_behaves_like "not found"
end
end
- context 'if user is not member of the project' do
+ context "if user is not member of the project" do
let(:path) { api_v3_paths.project_storage_open(project_storage21.id) }
- it_behaves_like 'not found'
+ it_behaves_like "not found"
end
end
end
diff --git a/modules/storages/spec/requests/api/v3/projects/projects_storages_filter_spec.rb b/modules/storages/spec/requests/api/v3/projects/projects_storages_filter_spec.rb
index 12d3e22380c0..50edb46fbe32 100644
--- a/modules/storages/spec/requests/api/v3/projects/projects_storages_filter_spec.rb
+++ b/modules/storages/spec/requests/api/v3/projects/projects_storages_filter_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe 'API v3 projects resource with filters for the linked storages',
+RSpec.describe "API v3 projects resource with filters for the linked storages",
content_type: :json do
include API::V3::Utilities::PathHelper
@@ -63,58 +63,58 @@ def disable_module(project, modul)
before { login_as user }
- describe 'GET /api/v3/projects' do
+ describe "GET /api/v3/projects" do
let(:path) { api_v3_paths.path_for :projects, filters: }
before { get path }
- context 'with filter for storage id' do
+ context "with filter for storage id" do
let(:storage_id) { storage1.id }
- let(:filters) { [{ storageId: { operator: '=', values: [storage_id] } }] }
+ let(:filters) { [{ storageId: { operator: "=", values: [storage_id] } }] }
- it_behaves_like 'API V3 collection response', 3, 3, 'Project', 'Collection' do
+ it_behaves_like "API V3 collection response", 3, 3, "Project", "Collection" do
let(:elements) { [project3, project2, project1] }
end
- context 'if a project has the storages module deactivated' do
- before(:all) { disable_module(project1, 'storages') }
- after(:all) { enable_module(project1, 'storages') }
+ context "if a project has the storages module deactivated" do
+ before(:all) { disable_module(project1, "storages") }
+ after(:all) { enable_module(project1, "storages") }
- it_behaves_like 'API V3 collection response', 2, 2, 'Project', 'Collection' do
+ it_behaves_like "API V3 collection response", 2, 2, "Project", "Collection" do
let(:elements) { [project3, project2] }
end
end
- context 'if the filter is set to an unknown storage id' do
- let(:storage_id) { '1337' }
+ context "if the filter is set to an unknown storage id" do
+ let(:storage_id) { "1337" }
- it_behaves_like 'API V3 collection response', 0, 0, 'Project', 'Collection' do
+ it_behaves_like "API V3 collection response", 0, 0, "Project", "Collection" do
let(:elements) { [] }
end
end
end
- context 'with filter for storage url' do
+ context "with filter for storage url" do
let(:storage_url) { CGI.escape(storage1.host) }
- let(:filters) { [{ storageUrl: { operator: '=', values: [storage_url] } }] }
+ let(:filters) { [{ storageUrl: { operator: "=", values: [storage_url] } }] }
- it_behaves_like 'API V3 collection response', 3, 3, 'Project', 'Collection' do
+ it_behaves_like "API V3 collection response", 3, 3, "Project", "Collection" do
let(:elements) { [project3, project2, project1] }
end
- context 'if a project has the storages module deactivated' do
- before(:all) { disable_module(project1, 'storages') }
- after(:all) { enable_module(project1, 'storages') }
+ context "if a project has the storages module deactivated" do
+ before(:all) { disable_module(project1, "storages") }
+ after(:all) { enable_module(project1, "storages") }
- it_behaves_like 'API V3 collection response', 2, 2, 'Project', 'Collection' do
+ it_behaves_like "API V3 collection response", 2, 2, "Project", "Collection" do
let(:elements) { [project3, project2] }
end
end
- context 'if the filter is set to an unknown storage url' do
+ context "if the filter is set to an unknown storage url" do
let(:storage_url) { CGI.escape("https://not.my-domain.org") }
- it_behaves_like 'API V3 collection response', 0, 0, 'Project', 'Collection' do
+ it_behaves_like "API V3 collection response", 0, 0, "Project", "Collection" do
let(:elements) { [] }
end
end
diff --git a/modules/storages/spec/requests/api/v3/storages/storage_files_api_spec.rb b/modules/storages/spec/requests/api/v3/storages/storage_files_api_spec.rb
index aef42954a19b..afe0bd2febe5 100644
--- a/modules/storages/spec/requests/api/v3/storages/storage_files_api_spec.rb
+++ b/modules/storages/spec/requests/api/v3/storages/storage_files_api_spec.rb
@@ -28,10 +28,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe 'API v3 storage files', :webmock, content_type: :json do
+RSpec.describe "API v3 storage files", :webmock, content_type: :json do
include API::V3::Utilities::PathHelper
include StorageServerHelpers
@@ -55,7 +55,7 @@
login_as current_user
end
- describe 'GET /api/v3/storages/:storage_id/files' do
+ describe "GET /api/v3/storages/:storage_id/files" do
let(:path) { api_v3_paths.storage_files(storage.id) }
let(:response) do
@@ -63,148 +63,148 @@
[
Storages::StorageFile.new(
id: 1,
- name: 'new_younglings.md',
+ name: "new_younglings.md",
size: 4096,
- mime_type: 'text/markdown',
+ mime_type: "text/markdown",
created_at: DateTime.now,
last_modified_at: DateTime.now,
- created_by_name: 'Obi-Wan Kenobi',
- last_modified_by_name: 'Obi-Wan Kenobi',
- location: '/',
+ created_by_name: "Obi-Wan Kenobi",
+ last_modified_by_name: "Obi-Wan Kenobi",
+ location: "/",
permissions: %i[readable]
),
Storages::StorageFile.new(
id: 2,
- name: 'holocron_inventory.md',
+ name: "holocron_inventory.md",
size: 4096,
- mime_type: 'text/markdown',
+ mime_type: "text/markdown",
created_at: DateTime.now,
last_modified_at: DateTime.now,
- created_by_name: 'Obi-Wan Kenobi',
- last_modified_by_name: 'Obi-Wan Kenobi',
- location: '/',
+ created_by_name: "Obi-Wan Kenobi",
+ last_modified_by_name: "Obi-Wan Kenobi",
+ location: "/",
permissions: %i[readable writeable]
)
],
Storages::StorageFile.new(
id: 32,
- name: '/',
+ name: "/",
size: 4096 * 2,
- mime_type: 'application/x-op-directory',
+ mime_type: "application/x-op-directory",
created_at: DateTime.now,
last_modified_at: DateTime.now,
- created_by_name: 'Obi-Wan Kenobi',
- last_modified_by_name: 'Obi-Wan Kenobi',
- location: '/',
+ created_by_name: "Obi-Wan Kenobi",
+ last_modified_by_name: "Obi-Wan Kenobi",
+ location: "/",
permissions: %i[readable writeable]
),
[]
)
end
- context 'with successful response' do
+ context "with successful response" do
before do
Storages::Peripherals::Registry.stub(
- 'nextcloud.queries.files',
+ "nextcloud.queries.files",
->(_) { ServiceResult.success(result: response) }
)
end
subject { last_response.body }
- it 'responds with appropriate JSON' do
- expect(subject).to be_json_eql(response.files[0].id.to_json).at_path('files/0/id')
- expect(subject).to be_json_eql(response.files[0].name.to_json).at_path('files/0/name')
- expect(subject).to be_json_eql(response.files[1].id.to_json).at_path('files/1/id')
- expect(subject).to be_json_eql(response.files[1].name.to_json).at_path('files/1/name')
- expect(subject).to be_json_eql(response.files[0].permissions.to_json).at_path('files/0/permissions')
- expect(subject).to be_json_eql(response.files[1].permissions.to_json).at_path('files/1/permissions')
- expect(subject).to be_json_eql(response.parent.id.to_json).at_path('parent/id')
- expect(subject).to be_json_eql(response.parent.name.to_json).at_path('parent/name')
- expect(subject).to be_json_eql(response.ancestors.to_json).at_path('ancestors')
+ it "responds with appropriate JSON" do
+ expect(subject).to be_json_eql(response.files[0].id.to_json).at_path("files/0/id")
+ expect(subject).to be_json_eql(response.files[0].name.to_json).at_path("files/0/name")
+ expect(subject).to be_json_eql(response.files[1].id.to_json).at_path("files/1/id")
+ expect(subject).to be_json_eql(response.files[1].name.to_json).at_path("files/1/name")
+ expect(subject).to be_json_eql(response.files[0].permissions.to_json).at_path("files/0/permissions")
+ expect(subject).to be_json_eql(response.files[1].permissions.to_json).at_path("files/1/permissions")
+ expect(subject).to be_json_eql(response.parent.id.to_json).at_path("parent/id")
+ expect(subject).to be_json_eql(response.parent.name.to_json).at_path("parent/name")
+ expect(subject).to be_json_eql(response.ancestors.to_json).at_path("ancestors")
end
end
- context 'with query failed' do
+ context "with query failed" do
before do
Storages::Peripherals::Registry.stub(
- 'nextcloud.queries.files',
+ "nextcloud.queries.files",
->(_) { ServiceResult.failure(result: error, errors: Storages::StorageError.new(code: error)) }
)
end
- context 'with authorization failure' do
+ context "with authorization failure" do
let(:error) { :unauthorized }
it { expect(last_response.status).to be(500) }
end
- context 'with internal error' do
+ context "with internal error" do
let(:error) { :error }
it { expect(last_response.status).to be(500) }
end
- context 'with not found' do
+ context "with not found" do
let(:error) { :not_found }
- it 'fails with outbound request failure' do
+ it "fails with outbound request failure" do
expect(last_response.status).to be(500)
body = JSON.parse(last_response.body)
- expect(body['message']).to eq(I18n.t('api_v3.errors.code_500_outbound_request_failure', status_code: 404))
- expect(body['errorIdentifier']).to eq('urn:openproject-org:api:v3:errors:OutboundRequest:NotFound')
+ expect(body["message"]).to eq(I18n.t("api_v3.errors.code_500_outbound_request_failure", status_code: 404))
+ expect(body["errorIdentifier"]).to eq("urn:openproject-org:api:v3:errors:OutboundRequest:NotFound")
end
end
end
end
- describe 'GET /api/v3/storages/:storage_id/files/:file_id' do
- let(:file_id) { '42' }
+ describe "GET /api/v3/storages/:storage_id/files/:file_id" do
+ let(:file_id) { "42" }
let(:path) { api_v3_paths.storage_file(storage.id, file_id) }
- context 'with successful response' do
+ context "with successful response" do
let(:response) do
Storages::StorageFileInfo.new(
- status: 'OK',
+ status: "OK",
status_code: 200,
id: file_id,
name: "Documents",
last_modified_at: DateTime.now,
created_at: DateTime.now,
- mime_type: 'application/x-op-directory',
+ mime_type: "application/x-op-directory",
size: 1108864,
- owner_name: 'Darth Vader',
- owner_id: 'darthvader',
+ owner_name: "Darth Vader",
+ owner_id: "darthvader",
trashed: false,
- last_modified_by_name: 'Darth Sidious',
- last_modified_by_id: 'palpatine',
- permissions: 'RGDNVCK',
- location: '/Documents'
+ last_modified_by_name: "Darth Sidious",
+ last_modified_by_id: "palpatine",
+ permissions: "RGDNVCK",
+ location: "/Documents"
)
end
before do
files_info_query = ->(_) { ServiceResult.success(result: response) }
- Storages::Peripherals::Registry.stub('nextcloud.queries.file_info', files_info_query)
+ Storages::Peripherals::Registry.stub("nextcloud.queries.file_info", files_info_query)
end
subject { last_response.body }
- it 'responds with appropriate JSON' do
- expect(subject).to be_json_eql('StorageFile'.to_json).at_path('_type')
- expect(subject).to be_json_eql(response.id.to_json).at_path('id')
- expect(subject).to be_json_eql(response.name.to_json).at_path('name')
- expect(subject).to be_json_eql(response.size.to_json).at_path('size')
- expect(subject).to be_json_eql(response.mime_type.to_json).at_path('mimeType')
- expect(subject).to be_json_eql(response.owner_name.to_json).at_path('createdByName')
- expect(subject).to be_json_eql(response.last_modified_by_name.to_json).at_path('lastModifiedByName')
- expect(subject).to be_json_eql(response.location.to_json).at_path('location')
- expect(subject).to be_json_eql(response.permissions.to_json).at_path('permissions')
+ it "responds with appropriate JSON" do
+ expect(subject).to be_json_eql("StorageFile".to_json).at_path("_type")
+ expect(subject).to be_json_eql(response.id.to_json).at_path("id")
+ expect(subject).to be_json_eql(response.name.to_json).at_path("name")
+ expect(subject).to be_json_eql(response.size.to_json).at_path("size")
+ expect(subject).to be_json_eql(response.mime_type.to_json).at_path("mimeType")
+ expect(subject).to be_json_eql(response.owner_name.to_json).at_path("createdByName")
+ expect(subject).to be_json_eql(response.last_modified_by_name.to_json).at_path("lastModifiedByName")
+ expect(subject).to be_json_eql(response.location.to_json).at_path("location")
+ expect(subject).to be_json_eql(response.permissions.to_json).at_path("permissions")
end
end
- context 'with query failed' do
+ context "with query failed" do
before do
clazz = Storages::Peripherals::StorageInteraction::Nextcloud::FileInfoQuery
instance = instance_double(clazz)
@@ -214,109 +214,109 @@
)
end
- context 'with authorization failure' do
+ context "with authorization failure" do
let(:error) { :forbidden }
- it 'fails with outbound request failure' do
+ it "fails with outbound request failure" do
expect(last_response.status).to be(500)
body = JSON.parse(last_response.body)
- expect(body['message']).to eq(I18n.t('api_v3.errors.code_500_outbound_request_failure', status_code: 403))
- expect(body['errorIdentifier']).to eq('urn:openproject-org:api:v3:errors:OutboundRequest:Forbidden')
+ expect(body["message"]).to eq(I18n.t("api_v3.errors.code_500_outbound_request_failure", status_code: 403))
+ expect(body["errorIdentifier"]).to eq("urn:openproject-org:api:v3:errors:OutboundRequest:Forbidden")
end
end
- context 'with internal error' do
+ context "with internal error" do
let(:error) { :error }
it { expect(last_response.status).to be(500) }
end
- context 'with not found' do
+ context "with not found" do
let(:error) { :not_found }
- it 'fails with outbound request failure' do
+ it "fails with outbound request failure" do
expect(last_response.status).to be(500)
body = JSON.parse(last_response.body)
- expect(body['message']).to eq(I18n.t('api_v3.errors.code_500_outbound_request_failure', status_code: 404))
- expect(body['errorIdentifier']).to eq('urn:openproject-org:api:v3:errors:OutboundRequest:NotFound')
+ expect(body["message"]).to eq(I18n.t("api_v3.errors.code_500_outbound_request_failure", status_code: 404))
+ expect(body["errorIdentifier"]).to eq("urn:openproject-org:api:v3:errors:OutboundRequest:NotFound")
end
end
end
end
- describe 'POST /api/v3/storages/:storage_id/files/prepare_upload' do
+ describe "POST /api/v3/storages/:storage_id/files/prepare_upload" do
let(:permissions) { %i(view_work_packages view_file_links manage_file_links) }
let(:path) { api_v3_paths.prepare_upload(storage.id) }
- let(:upload_link) { Storages::UploadLink.new('https://example.com/upload/xyz123') }
+ let(:upload_link) { Storages::UploadLink.new("https://example.com/upload/xyz123") }
let(:body) { { fileName: "ape.png", parent: "/Pictures", projectId: project.id }.to_json }
subject(:last_response) do
post(path, body)
end
- describe 'with successful response' do
+ describe "with successful response" do
before do
Storages::Peripherals::Registry.stub(
- 'nextcloud.queries.upload_link',
+ "nextcloud.queries.upload_link",
->(_) { ServiceResult.success(result: upload_link) }
)
end
subject { last_response.body }
- it 'responds with appropriate JSON' do
- expect(subject).to be_json_eql(Storages::UploadLink.name.split('::').last.to_json).at_path('_type')
+ it "responds with appropriate JSON" do
+ expect(subject).to be_json_eql(Storages::UploadLink.name.split("::").last.to_json).at_path("_type")
expect(subject)
.to(be_json_eql("#{API::V3::URN_PREFIX}storages:upload_link:no_link_provided".to_json)
- .at_path('_links/self/href'))
- expect(subject).to be_json_eql(upload_link.destination.to_json).at_path('_links/destination/href')
- expect(subject).to be_json_eql("post".to_json).at_path('_links/destination/method')
- expect(subject).to be_json_eql("Upload File".to_json).at_path('_links/destination/title')
+ .at_path("_links/self/href"))
+ expect(subject).to be_json_eql(upload_link.destination.to_json).at_path("_links/destination/href")
+ expect(subject).to be_json_eql("post".to_json).at_path("_links/destination/method")
+ expect(subject).to be_json_eql("Upload File".to_json).at_path("_links/destination/title")
end
end
- context 'with query failed' do
+ context "with query failed" do
before do
Storages::Peripherals::Registry.stub(
- 'nextcloud.queries.upload_link',
+ "nextcloud.queries.upload_link",
->(_) { ServiceResult.failure(result: error, errors: Storages::StorageError.new(code: error)) }
)
end
- describe 'due to authorization failure' do
+ describe "due to authorization failure" do
let(:error) { :unauthorized }
it { expect(last_response.status).to be(500) }
end
- describe 'due to internal error' do
+ describe "due to internal error" do
let(:error) { :error }
it { expect(last_response.status).to be(500) }
end
- describe 'due to not found' do
+ describe "due to not found" do
let(:error) { :not_found }
- it 'fails with outbound request failure' do
+ it "fails with outbound request failure" do
expect(last_response.status).to be(500)
body = JSON.parse(last_response.body)
- expect(body['message']).to eq(I18n.t('api_v3.errors.code_500_outbound_request_failure', status_code: 404))
- expect(body['errorIdentifier']).to eq('urn:openproject-org:api:v3:errors:OutboundRequest:NotFound')
+ expect(body["message"]).to eq(I18n.t("api_v3.errors.code_500_outbound_request_failure", status_code: 404))
+ expect(body["errorIdentifier"]).to eq("urn:openproject-org:api:v3:errors:OutboundRequest:NotFound")
end
end
end
- context 'with invalid request body' do
+ context "with invalid request body" do
let(:body) { { fileNam_: "ape.png", parent: "/Pictures", projectId: project.id }.to_json }
it { expect(last_response.status).to be(400) }
end
- context 'without ee token', with_ee: false do
+ context "without ee token", with_ee: false do
let(:storage) { create(:one_drive_storage, creator: current_user) }
it { expect(last_response.status).to be(500) }
diff --git a/modules/storages/spec/requests/api/v3/work_packages/work_packages_linkable_filter_spec.rb b/modules/storages/spec/requests/api/v3/work_packages/work_packages_linkable_filter_spec.rb
index b0bbb754072a..429e011c219a 100644
--- a/modules/storages/spec/requests/api/v3/work_packages/work_packages_linkable_filter_spec.rb
+++ b/modules/storages/spec/requests/api/v3/work_packages/work_packages_linkable_filter_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe 'API v3 work packages resource with filters for the linkable to storage attribute',
+RSpec.describe "API v3 work packages resource with filters for the linkable to storage attribute",
content_type: :json do
include API::V3::Utilities::PathHelper
@@ -73,92 +73,92 @@
login_as current_user
end
- describe 'GET /api/v3/work_packages' do
+ describe "GET /api/v3/work_packages" do
let(:path) { api_v3_paths.path_for :work_packages, filters: }
before do
get path
end
- context 'with filter for storage id' do
+ context "with filter for storage id" do
let(:storage_id) { storage.id }
let(:filters) do
[
{
linkable_to_storage_id: {
- operator: '=',
+ operator: "=",
values: [storage_id]
}
}
]
end
- it_behaves_like 'API V3 collection response', 4, 4, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 4, 4, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [work_package1, work_package2, work_package3, work_package4] }
end
- context 'if user has no sufficient permissions in one project' do
+ context "if user has no sufficient permissions in one project" do
let(:role2) { create(:project_role, permissions: %i(view_work_packages view_file_links)) }
- it_behaves_like 'API V3 collection response', 2, 2, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 2, 2, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [work_package1, work_package2] }
end
end
- context 'if a project has the storages module deactivated' do
+ context "if a project has the storages module deactivated" do
let(:project1) { create(:project, disable_modules: :storages, members: { current_user => role1 }) }
- it_behaves_like 'API V3 collection response', 2, 2, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 2, 2, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [work_package3, work_package4] }
end
end
- context 'if the filter is set to an unknown storage id' do
+ context "if the filter is set to an unknown storage id" do
let(:storage_id) { "1337" }
- it_behaves_like 'API V3 collection response', 0, 0, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 0, 0, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [] }
end
end
end
- context 'with filter for storage url' do
+ context "with filter for storage url" do
let(:storage_url) { CGI.escape(storage.host) }
let(:filters) do
[
{
linkable_to_storage_url: {
- operator: '=',
+ operator: "=",
values: [storage_url]
}
}
]
end
- it_behaves_like 'API V3 collection response', 4, 4, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 4, 4, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [work_package1, work_package2, work_package3, work_package4] }
end
- context 'if user has no sufficient permissions in one project' do
+ context "if user has no sufficient permissions in one project" do
let(:role2) { create(:project_role, permissions: %i(view_work_packages view_file_links)) }
- it_behaves_like 'API V3 collection response', 2, 2, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 2, 2, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [work_package1, work_package2] }
end
end
- context 'if a project has the storages module deactivated' do
+ context "if a project has the storages module deactivated" do
let(:project1) { create(:project, disable_modules: :storages, members: { current_user => role1 }) }
- it_behaves_like 'API V3 collection response', 2, 2, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 2, 2, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [work_package3, work_package4] }
end
end
- context 'if the filter is set to an unknown storage url' do
+ context "if the filter is set to an unknown storage url" do
let(:storage_url) { CGI.escape("https://not.my-domain.org") }
- it_behaves_like 'API V3 collection response', 0, 0, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 0, 0, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [] }
end
end
diff --git a/modules/storages/spec/requests/api/v3/work_packages/work_packages_linked_filter_spec.rb b/modules/storages/spec/requests/api/v3/work_packages/work_packages_linked_filter_spec.rb
index 0808fbc1e672..35137b2abb69 100644
--- a/modules/storages/spec/requests/api/v3/work_packages/work_packages_linked_filter_spec.rb
+++ b/modules/storages/spec/requests/api/v3/work_packages/work_packages_linked_filter_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe 'API v3 work packages resource with filters for linked storage file',
+RSpec.describe "API v3 work packages resource with filters for linked storage file",
content_type: :json do
include API::V3::Utilities::PathHelper
@@ -81,208 +81,208 @@
login_as current_user
end
- describe 'GET /api/v3/work_packages' do
+ describe "GET /api/v3/work_packages" do
let(:path) { api_v3_paths.path_for :work_packages, filters: }
before do
get path
end
- context 'with single filter for file id' do
+ context "with single filter for file id" do
let(:origin_id_value) { file_link1.origin_id.to_s }
let(:filters) do
[
{
file_link_origin_id: {
- operator: '=',
+ operator: "=",
values: [origin_id_value]
}
}
]
end
- it_behaves_like 'API V3 collection response', 2, 2, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 2, 2, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [work_package1, work_package3] }
end
- context 'if one project has not sufficient permissions' do
+ context "if one project has not sufficient permissions" do
let(:role2) { create(:project_role, permissions: %i(view_work_packages)) }
- it_behaves_like 'API V3 collection response', 1, 1, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 1, 1, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [work_package1] }
end
end
- context 'if a project has the storages module deactivated' do
+ context "if a project has the storages module deactivated" do
let(:project1) { create(:project, disable_modules: :storages, members: { current_user => role1 }) }
- it_behaves_like 'API V3 collection response', 1, 1, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 1, 1, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [work_package3] }
end
end
- context 'if the filter is set to an unknown file id from origin' do
+ context "if the filter is set to an unknown file id from origin" do
let(:origin_id_value) { "1337" }
- it_behaves_like 'API V3 collection response', 0, 0, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 0, 0, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [] }
end
end
- context 'if the filter is set to a file linked to a work package in an unlinked project' do
+ context "if the filter is set to a file linked to a work package in an unlinked project" do
let(:origin_id_value) { file_link4.origin_id.to_s }
- it_behaves_like 'API V3 collection response', 0, 0, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 0, 0, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [] }
end
end
- context 'if using signaling' do
- let(:path) { api_v3_paths.path_for :work_packages, select: 'total,count,_type,elements/*', filters: }
+ context "if using signaling" do
+ let(:path) { api_v3_paths.path_for :work_packages, select: "total,count,_type,elements/*", filters: }
- it_behaves_like 'API V3 collection response', 2, 2, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 2, 2, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [work_package1, work_package3] }
end
end
end
- context 'with single filter for storage id' do
+ context "with single filter for storage id" do
let(:storage_id_value) { storage1.id.to_s }
let(:filters) do
[
{
storage_id: {
- operator: '=',
+ operator: "=",
values: [storage_id_value]
}
}
]
end
- it_behaves_like 'API V3 collection response', 2, 2, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 2, 2, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [work_package1, work_package2] }
end
- context 'if one project has not sufficient permissions' do
+ context "if one project has not sufficient permissions" do
let(:role1) { create(:project_role, permissions: %i(view_work_packages)) }
- it_behaves_like 'API V3 collection response', 0, 0, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 0, 0, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [] }
end
end
- context 'if the filter is set to an unknown storage id' do
+ context "if the filter is set to an unknown storage id" do
let(:storage_id_value) { "1337" }
- it_behaves_like 'API V3 collection response', 0, 0, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 0, 0, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [] }
end
end
end
- context 'with single filter for storage url' do
+ context "with single filter for storage url" do
let(:storage_url_value) { CGI.escape(storage2.host) }
let(:filters) do
[
{
storage_url: {
- operator: '=',
+ operator: "=",
values: [storage_url_value]
}
}
]
end
- it_behaves_like 'API V3 collection response', 1, 1, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 1, 1, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [work_package3] }
end
- context 'if any of the matching work packages is in a project without a mapping to that storage' do
+ context "if any of the matching work packages is in a project without a mapping to that storage" do
let(:storage_url_value) { CGI.escape(storage1.host) }
- it_behaves_like 'API V3 collection response', 2, 2, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 2, 2, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [work_package1, work_package2] }
end
end
- context 'if one project has not sufficient permissions' do
+ context "if one project has not sufficient permissions" do
let(:role2) { create(:project_role, permissions: %i(view_work_packages)) }
- it_behaves_like 'API V3 collection response', 0, 0, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 0, 0, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [] }
end
end
- context 'if the filter is set to an unknown storage url' do
+ context "if the filter is set to an unknown storage url" do
let(:storage_url_value) { "https://not.my-domain.org" }
- it_behaves_like 'API V3 collection response', 0, 0, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 0, 0, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [] }
end
end
end
- context 'with combined filter of file id and storage id' do
+ context "with combined filter of file id and storage id" do
let(:origin_id_value) { file_link1.origin_id }
let(:storage_id_value) { storage1.id }
let(:filters) do
[
{
file_link_origin_id: {
- operator: '=',
+ operator: "=",
values: [origin_id_value]
}
},
{
storage_id: {
- operator: '=',
+ operator: "=",
values: [storage_id_value]
}
}
]
end
- it_behaves_like 'API V3 collection response', 1, 1, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 1, 1, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [work_package1] }
end
- context 'if just the storage id is switched' do
+ context "if just the storage id is switched" do
let(:storage_id_value) { storage2.id }
- it_behaves_like 'API V3 collection response', 1, 1, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 1, 1, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [work_package3] }
end
end
end
- context 'with combined filter of file id and storage url' do
+ context "with combined filter of file id and storage url" do
let(:origin_id_value) { file_link1.origin_id }
let(:storage_url_value) { CGI.escape(storage1.host) }
let(:filters) do
[
{
file_link_origin_id: {
- operator: '=',
+ operator: "=",
values: [origin_id_value]
}
},
{
storage_url: {
- operator: '=',
+ operator: "=",
values: [storage_url_value]
}
}
]
end
- it_behaves_like 'API V3 collection response', 1, 1, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 1, 1, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [work_package1] }
end
- context 'if just the storage url is switched' do
+ context "if just the storage url is switched" do
let(:storage_url_value) { CGI.escape(storage2.host) }
- it_behaves_like 'API V3 collection response', 1, 1, 'WorkPackage', 'WorkPackageCollection' do
+ it_behaves_like "API V3 collection response", 1, 1, "WorkPackage", "WorkPackageCollection" do
let(:elements) { [work_package3] }
end
end
diff --git a/modules/storages/spec/requests/append_content_security_policy_spec.rb b/modules/storages/spec/requests/append_content_security_policy_spec.rb
index ddfb510166cd..8571a1894f99 100644
--- a/modules/storages/spec/requests/append_content_security_policy_spec.rb
+++ b/modules/storages/spec/requests/append_content_security_policy_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe 'Appendix of default CSP for external file storage hosts' do
+RSpec.describe "Appendix of default CSP for external file storage hosts" do
def parse_csp(csp_string)
csp_string
- .split('; ')
+ .split("; ")
.map(&:split)
.each_with_object({}) { |csp_part, csp_hash_map| csp_hash_map[csp_part[0]] = csp_part[1..] }
end
@@ -41,24 +41,24 @@ def parse_csp(csp_string)
shared_let(:storage) { create(:nextcloud_storage) }
shared_let(:project_storage) { create(:project_storage, project:, storage:) }
- describe 'GET /' do
- context 'when logged in' do
+ describe "GET /" do
+ context "when logged in" do
current_user { create(:user, member_with_permissions: { project => %i[manage_file_links] }) }
- it 'appends storage host to the connect-src CSP' do
- get '/'
+ it "appends storage host to the connect-src CSP" do
+ get "/"
- csp = parse_csp(last_response.headers['Content-Security-Policy'])
- expect(csp['connect-src']).to include(storage.host)
+ csp = parse_csp(last_response.headers["Content-Security-Policy"])
+ expect(csp["connect-src"]).to include(storage.host)
end
end
- context 'when not logged in' do
- it 'does not append host to connect-src CSP' do
- get '/'
+ context "when not logged in" do
+ it "does not append host to connect-src CSP" do
+ get "/"
- csp = parse_csp(last_response.headers['Content-Security-Policy'])
- expect(csp['connect-src']).not_to include(storage.host)
+ csp = parse_csp(last_response.headers["Content-Security-Policy"])
+ expect(csp["connect-src"]).not_to include(storage.host)
end
end
end
diff --git a/modules/storages/spec/requests/project_storages_open_spec.rb b/modules/storages/spec/requests/project_storages_open_spec.rb
index 535065e24c96..9db041b8c55e 100644
--- a/modules/storages/spec/requests/project_storages_open_spec.rb
+++ b/modules/storages/spec/requests/project_storages_open_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe 'projects/:project_id/project_storages/:id/open' do
+RSpec.describe "projects/:project_id/project_storages/:id/open" do
let(:expected_redirect_path) do
API::V3::Utilities::PathHelper::ApiV3Path.project_storage_open(project_storage.id)
end
@@ -42,37 +42,37 @@
shared_let(:project) { create(:project) }
shared_let(:storage) { create(:nextcloud_storage_configured) }
- context 'when user is logged in' do
+ context "when user is logged in" do
current_user { create(:user, member_with_permissions: { project => permissions }) }
- context 'when user has permissions' do
+ context "when user has permissions" do
let(:permissions) { %i[view_file_links] }
- context 'when project_folder is automatic' do
+ context "when project_folder is automatic" do
let(:project_storage) { create(:project_storage, :as_automatically_managed, project:, storage:) }
- context 'when project_folder_id has been set by background job already' do
- before { project_storage.update_attribute(:project_folder_id, '123') }
+ context "when project_folder_id has been set by background job already" do
+ before { project_storage.update_attribute(:project_folder_id, "123") }
- context 'when user is able to read project_folder' do
+ context "when user is able to read project_folder" do
before do
Storages::Peripherals::Registry.stub(
- 'nextcloud.queries.file_info', ->(_) { ServiceResult.success }
+ "nextcloud.queries.file_info", ->(_) { ServiceResult.success }
)
end
- context 'html' do
- it 'redirects to api_v3_projects_storage_open_url' do
- get route, {}, { 'HTTP_ACCEPT' => 'text/html' }
+ context "html" do
+ it "redirects to api_v3_projects_storage_open_url" do
+ get route, {}, { "HTTP_ACCEPT" => "text/html" }
expect(last_response.status).to eq (302)
expect(last_response.headers["Location"]).to eq(expected_redirect_url)
end
end
- context 'turbo_stream' do
- it 'renders an appropirate turbo_stream' do
- get route, {}, { 'HTTP_ACCEPT' => 'text/vnd.turbo-stream.html' }
+ context "turbo_stream" do
+ it "renders an appropirate turbo_stream" do
+ get route, {}, { "HTTP_ACCEPT" => "text/vnd.turbo-stream.html" }
expect(last_response.status).to eq (200)
expect(last_response.body).to eq ("\n \n
\n
\n
\n
Integration setup completed
\n
\n
You are being redirected\n
\n
\n\n\n \n\n\n")
@@ -80,24 +80,24 @@
end
end
- context 'when user is not able to read project_folder' do
+ context "when user is not able to read project_folder" do
let(:code) { :forbidden }
before do
Storages::Peripherals::Registry.stub(
- 'nextcloud.queries.file_info', ->(_) do
+ "nextcloud.queries.file_info", ->(_) do
ServiceResult.failure(result: code,
errors: Storages::StorageError.new(code:))
end
)
end
- context 'html' do
- context 'when error code is unauthorized' do
+ context "html" do
+ context "when error code is unauthorized" do
let(:code) { :unauthorized }
- it 'redirects to ensure_connection url with current request url as a destination_url' do
- get route, {}, { 'HTTP_ACCEPT' => 'text/html' }
+ it "redirects to ensure_connection url with current request url as a destination_url" do
+ get route, {}, { "HTTP_ACCEPT" => "text/html" }
expect(last_response.status).to eq (302)
expect(last_response.headers["Location"]).to eq (
@@ -106,13 +106,13 @@
end
end
- context 'when error code is forbidden' do
- it 'redirects to project overview page with modal flash set up' do
- get route, {}, { 'HTTP_ACCEPT' => 'text/html' }
+ context "when error code is forbidden" do
+ it "redirects to project overview page with modal flash set up" do
+ get route, {}, { "HTTP_ACCEPT" => "text/html" }
expect(last_response.status).to eq (302)
expect(last_response.headers["Location"]).to eq ("http://example.org/projects/#{project.identifier}")
- expect(last_request.session['flash']['flashes'])
+ expect(last_request.session["flash"]["flashes"])
.to eq({
"modal" => {
type: "Storages::OpenProjectStorageModalComponent",
@@ -125,9 +125,9 @@
end
end
- context 'turbo_stream' do
- it 'responds with 204 no content' do
- get route, {}, { 'HTTP_ACCEPT' => 'text/vnd.turbo-stream.html' }
+ context "turbo_stream" do
+ it "responds with 204 no content" do
+ get route, {}, { "HTTP_ACCEPT" => "text/vnd.turbo-stream.html" }
expect(last_response.status).to eq (204)
expect(last_response.body).to eq ("")
@@ -136,14 +136,14 @@
end
end
- context 'when project_folder_id has not been set by background job yet' do
- context 'html' do
- it 'redirects to project overview page with modal flash set up' do
- get route, {}, { 'HTTP_ACCEPT' => 'text/html' }
+ context "when project_folder_id has not been set by background job yet" do
+ context "html" do
+ it "redirects to project overview page with modal flash set up" do
+ get route, {}, { "HTTP_ACCEPT" => "text/html" }
expect(last_response.status).to eq (302)
expect(last_response.headers["Location"]).to eq ("http://example.org/projects/#{project.identifier}")
- expect(last_request.session['flash']['flashes'])
+ expect(last_request.session["flash"]["flashes"])
.to eq({
"modal" => {
type: "Storages::OpenProjectStorageModalComponent",
@@ -155,9 +155,9 @@
end
end
- context 'turbo_stream' do
- it 'responds with 204 no content' do
- get route, {}, { 'HTTP_ACCEPT' => 'text/vnd.turbo-stream.html' }
+ context "turbo_stream" do
+ it "responds with 204 no content" do
+ get route, {}, { "HTTP_ACCEPT" => "text/vnd.turbo-stream.html" }
expect(last_response.status).to eq (204)
expect(last_response.body).to eq ("")
@@ -166,9 +166,9 @@
end
end
- context 'when project_folder is not automatic' do
- it 'redirects to storage_open_url' do
- get route, {}, { 'HTTP_ACCEPT' => 'text/html' }
+ context "when project_folder is not automatic" do
+ it "redirects to storage_open_url" do
+ get route, {}, { "HTTP_ACCEPT" => "text/html" }
expect(last_response.status).to eq (302)
expect(last_response.headers["Location"]).to eq (expected_redirect_url)
@@ -176,18 +176,18 @@
end
end
- context 'when user has no permissions' do
+ context "when user has no permissions" do
let(:permissions) { %i[] }
- it 'responds with 403' do
- get route, {}, { 'HTTP_ACCEPT' => 'text/html' }
+ it "responds with 403" do
+ get route, {}, { "HTTP_ACCEPT" => "text/html" }
expect(last_response.status).to eq(403)
end
end
end
- context 'when user is not logged in' do
- it 'responds with 401' do
+ context "when user is not logged in" do
+ it "responds with 401" do
get route
expect(last_response.status).to eq(401)
end
diff --git a/modules/storages/spec/requests/storages/project_settings/oauth_access_grant_flow_spec.rb b/modules/storages/spec/requests/storages/project_settings/oauth_access_grant_flow_spec.rb
index 0a0954c6de76..86647c0c511b 100644
--- a/modules/storages/spec/requests/storages/project_settings/oauth_access_grant_flow_spec.rb
+++ b/modules/storages/spec/requests/storages/project_settings/oauth_access_grant_flow_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe "GET /projects/:project_id/settings/project_storages/:id/oauth_access_grant", :webmock do
- shared_let(:user) { create(:user, preferences: { time_zone: 'Etc/UTC' }) }
+ shared_let(:user) { create(:user, preferences: { time_zone: "Etc/UTC" }) }
shared_let(:role) do
create(:project_role, permissions: %i[manage_storages_in_project
@@ -49,8 +49,8 @@
end
shared_let(:project_storage) { create(:project_storage, project:, storage:) }
- context 'when user is not logged in' do
- it 'requires login' do
+ context "when user is not logged in" do
+ it "requires login" do
get oauth_access_grant_project_settings_project_storage_path(
project_id: project_storage.project.id,
id: project_storage
@@ -59,11 +59,11 @@
end
end
- context 'when user is logged in' do
+ context "when user is logged in" do
before { login_as(user) }
context 'when user is not "connected"' do
- let(:nonce) { '57a17c3f-b2ed-446e-9dd8-651ba3aec37d' }
+ let(:nonce) { "57a17c3f-b2ed-446e-9dd8-651ba3aec37d" }
let(:redirect_uri) do
CGI.escape("#{OpenProject::Application.root_url}/oauth_clients/#{storage.oauth_client.client_id}/callback")
end
@@ -73,7 +73,7 @@
allow(SecureRandom).to receive(:uuid).and_return(nonce).ordered
end
- it 'redirects to storage authorization_uri with oauth_state_* cookie set' do
+ it "redirects to storage authorization_uri with oauth_state_* cookie set" do
get oauth_access_grant_project_settings_project_storage_path(
project_id: project_storage.project.id,
id: project_storage
@@ -98,14 +98,14 @@
stub_request(:get, "#{storage.host}/ocs/v1.php/cloud/user")
.with(
headers: {
- 'Accept' => 'application/json',
- 'Authorization' => "Bearer #{oauth_client_token.access_token}",
- 'Ocs-Apirequest' => 'true'
+ "Accept" => "application/json",
+ "Authorization" => "Bearer #{oauth_client_token.access_token}",
+ "Ocs-Apirequest" => "true"
}
).to_return(status: 200, body: "", headers: {})
end
- it 'redirects to destination_url' do
+ it "redirects to destination_url" do
get oauth_access_grant_project_settings_project_storage_path(
project_id: project_storage.project.id,
id: project_storage
diff --git a/modules/storages/spec/seeders/seeder_spec.rb b/modules/storages/spec/seeders/seeder_spec.rb
index f3f1dedb833e..4c9f0f225a00 100644
--- a/modules/storages/spec/seeders/seeder_spec.rb
+++ b/modules/storages/spec/seeders/seeder_spec.rb
@@ -28,11 +28,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe RootSeeder, 'Storage module' do
- it 'seeds role permissions for Storages' do
+RSpec.describe RootSeeder, "Storage module" do
+ it "seeds role permissions for Storages" do
described_class.new.seed_data!
expect(RolePermission.where(permission: :view_file_links).count).to eq 7
diff --git a/modules/storages/spec/services/principals/replace_references_service_call_integration_spec.rb b/modules/storages/spec/services/principals/replace_references_service_call_integration_spec.rb
index 8033f8f480de..1eadf7a0b417 100644
--- a/modules/storages/spec/services/principals/replace_references_service_call_integration_spec.rb
+++ b/modules/storages/spec/services/principals/replace_references_service_call_integration_spec.rb
@@ -28,10 +28,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.describe Principals::ReplaceReferencesService, '#call', type: :model do
+RSpec.describe Principals::ReplaceReferencesService, "#call", type: :model do
shared_let(:principal) { create(:user) }
shared_let(:to_principal) { create(:user) }
@@ -41,17 +41,17 @@
described_class.new
end
- shared_examples 'replaces the creator' do
+ shared_examples "replaces the creator" do
before do
model
end
- it 'is successful' do
+ it "is successful" do
expect(service_call)
.to be_success
end
- it 'replaces principal with to_principal' do
+ it "replaces principal with to_principal" do
service_call
model.reload
@@ -59,20 +59,20 @@
end
end
- context 'with Storage' do
- it_behaves_like 'replaces the creator' do
+ context "with Storage" do
+ it_behaves_like "replaces the creator" do
let(:model) { create(:nextcloud_storage, creator: principal) }
end
end
- context 'with ProjectStorage' do
- it_behaves_like 'replaces the creator' do
+ context "with ProjectStorage" do
+ it_behaves_like "replaces the creator" do
let(:model) { create(:project_storage, creator: principal) }
end
end
- context 'with FileLink' do
- it_behaves_like 'replaces the creator' do
+ context "with FileLink" do
+ it_behaves_like "replaces the creator" do
let(:work_package) { create(:work_package) }
let(:model) { create(:file_link, creator: principal, container: work_package) }
end
diff --git a/modules/storages/spec/services/storages/file_links/create_service_spec.rb b/modules/storages/spec/services/storages/file_links/create_service_spec.rb
index 8e9f368dbe6b..72535c1a21fa 100644
--- a/modules/storages/spec/services/storages/file_links/create_service_spec.rb
+++ b/modules/storages/spec/services/storages/file_links/create_service_spec.rb
@@ -28,17 +28,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require 'services/base_services/behaves_like_create_service'
+require "services/base_services/behaves_like_create_service"
RSpec.describe Storages::FileLinks::CreateService, type: :model do
- it_behaves_like 'BaseServices create service' do
+ it_behaves_like "BaseServices create service" do
let(:factory) { :file_link }
end
- it 'creates a journal entry for its container' do
+ it "creates a journal entry for its container" do
project_storage = create(:project_storage)
storage = project_storage.storage
@@ -49,7 +49,7 @@
user = create(:admin)
service = described_class.new(user:, contract_class: Storages::FileLinks::CreateContract)
- params = { creator: user, container: work_package, origin_id: 200, origin_name: 'bob_the_fake_file.png', storage: }
+ params = { creator: user, container: work_package, origin_id: 200, origin_name: "bob_the_fake_file.png", storage: }
expect do
result = service.call(params)
diff --git a/modules/storages/spec/services/storages/file_links/delete_service_spec.rb b/modules/storages/spec/services/storages/file_links/delete_service_spec.rb
index db4a4c6b4acd..1ab5cada3fef 100644
--- a/modules/storages/spec/services/storages/file_links/delete_service_spec.rb
+++ b/modules/storages/spec/services/storages/file_links/delete_service_spec.rb
@@ -28,17 +28,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require 'services/base_services/behaves_like_delete_service'
+require "services/base_services/behaves_like_delete_service"
RSpec.describe Storages::FileLinks::DeleteService, type: :model do
- it_behaves_like 'BaseServices delete service' do
+ it_behaves_like "BaseServices delete service" do
let(:factory) { :file_link }
end
- it 'creates a journal entry for its container', with_settings: { journal_aggregation_time_minutes: 0 } do
+ it "creates a journal entry for its container", with_settings: { journal_aggregation_time_minutes: 0 } do
project_storage = create(:project_storage)
# Tap as the changes would otherwise mess with the journal creation i.e. the updated_at timestamp
work_package = create(:work_package, project: project_storage.project).tap(&:clear_changes_information)
diff --git a/modules/storages/spec/services/storages/file_links/file_link_sync_service_spec.rb b/modules/storages/spec/services/storages/file_links/file_link_sync_service_spec.rb
index 9b19425db8cf..688b31fec162 100644
--- a/modules/storages/spec/services/storages/file_links/file_link_sync_service_spec.rb
+++ b/modules/storages/spec/services/storages/file_links/file_link_sync_service_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::FileLinkSyncService, type: :model do
@@ -47,17 +47,17 @@
subject(:service) { described_class.new(user:).call(file_links) }
- describe '#call' do
- context 'with one file link' do
+ describe "#call" do
+ context "with one file link" do
let(:file_info) { build(:storage_file_info) }
let(:file_link_one) { create(:file_link, origin_id: file_info.id, storage: storage_one, container: work_package) }
before do
Storages::Peripherals::Registry
- .stub('nextcloud.queries.files_info', ->(_) { ServiceResult.success(result: [file_info]) })
+ .stub("nextcloud.queries.files_info", ->(_) { ServiceResult.success(result: [file_info]) })
end
- it 'updates all origin_* fields' do
+ it "updates all origin_* fields" do
expect(service.success).to be_truthy
expect(service.result.count).to be 1
expect(service.result.first).to be_a Storages::FileLink
@@ -71,22 +71,22 @@
end
end
- context 'without permission to read file (403)' do
+ context "without permission to read file (403)" do
let(:file_info) { build(:storage_file_info, status_code: 403) }
let(:file_link_one) { create(:file_link, origin_id: file_info.id, storage: storage_one, container: work_package) }
before do
Storages::Peripherals::Registry
- .stub('nextcloud.queries.files_info', ->(_) { ServiceResult.success(result: [file_info]) })
+ .stub("nextcloud.queries.files_info", ->(_) { ServiceResult.success(result: [file_info]) })
end
- it 'returns a FileLink with #origin_status :not_allowed' do
+ it "returns a FileLink with #origin_status :not_allowed" do
expect(service.success).to be_truthy
expect(service.result.first.origin_status).to be :view_not_allowed
end
end
- context 'with two file links, one updated and other not allowed' do
+ context "with two file links, one updated and other not allowed" do
let(:file_info_one) { build(:storage_file_info) }
let(:file_info_two) { build(:storage_file_info, status_code: 403) }
@@ -97,11 +97,11 @@
before do
Storages::Peripherals::Registry
- .stub('nextcloud.queries.files_info',
+ .stub("nextcloud.queries.files_info",
->(_) { ServiceResult.success(result: [file_info_one, file_info_two]) })
end
- it 'returns a successful result with two file links with different permissions' do
+ it "returns a successful result with two file links with different permissions" do
expect(service.success).to be_truthy
expect(service.result.count).to be 2
expect(service.result[0].origin_id).to eql file_info_one.id
@@ -111,16 +111,16 @@
end
end
- context 'when file was not found (404)' do
+ context "when file was not found (404)" do
let(:file_info) { build(:storage_file_info, status_code: 404) }
let(:file_link_one) { create(:file_link, origin_id: file_info.id, storage: storage_one, container: work_package) }
before do
Storages::Peripherals::Registry
- .stub('nextcloud.queries.files_info', ->(_) { ServiceResult.success(result: [file_info]) })
+ .stub("nextcloud.queries.files_info", ->(_) { ServiceResult.success(result: [file_info]) })
end
- it 'returns the file link with a status set to :not_found' do
+ it "returns the file link with a status set to :not_found" do
expect(service.success).to be_truthy
expect(service.result.count).to be 1
expect(Storages::FileLink.count).to be 1
@@ -128,16 +128,16 @@
end
end
- context 'when file has a different error (555)' do
+ context "when file has a different error (555)" do
let(:file_info) { build(:storage_file_info, status_code: 555) }
let(:file_link_one) { create(:file_link, origin_id: file_info.id, storage: storage_one, container: work_package) }
before do
Storages::Peripherals::Registry
- .stub('nextcloud.queries.files_info', ->(_) { ServiceResult.success(result: [file_info]) })
+ .stub("nextcloud.queries.files_info", ->(_) { ServiceResult.success(result: [file_info]) })
end
- it 'returns the file link with a status set to :error' do
+ it "returns the file link with a status set to :error" do
expect(service.success).to be_truthy
expect(service.result.count).to be 1
expect(Storages::FileLink.count).to be 1
@@ -145,14 +145,14 @@
end
end
- context 'with files_info_query failing' do
+ context "with files_info_query failing" do
before do
Storages::Peripherals::Registry
- .stub('nextcloud.queries.files_info',
+ .stub("nextcloud.queries.files_info",
->(_) { ServiceResult.failure(result: :error, errors: Storages::StorageError.new(code: :error)) })
end
- it 'leaves the list of file_links unchanged with permissions = :error' do
+ it "leaves the list of file_links unchanged with permissions = :error" do
expect(service.success).to be_truthy
expect(service.result.first.origin_status).to be :error
end
diff --git a/modules/storages/spec/services/storages/file_links/set_attributes_service_spec.rb b/modules/storages/spec/services/storages/file_links/set_attributes_service_spec.rb
index c5cfdfd350c5..50f73f17407a 100644
--- a/modules/storages/spec/services/storages/file_links/set_attributes_service_spec.rb
+++ b/modules/storages/spec/services/storages/file_links/set_attributes_service_spec.rb
@@ -28,20 +28,20 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::FileLinks::SetAttributesService, type: :model do
let(:current_user) { build_stubbed(:admin) }
let(:contract_instance) do
- contract = instance_double(Storages::Storages::BaseContract, 'contract_instance')
+ contract = instance_double(Storages::Storages::BaseContract, "contract_instance")
allow(contract)
.to receive_messages(validate: contract_valid, errors: contract_errors)
contract
end
- let(:contract_errors) { instance_double(ActiveModel::Errors, 'contract_errors') }
+ let(:contract_errors) { instance_double(ActiveModel::Errors, "contract_errors") }
let(:contract_valid) { true }
let(:model_valid) { true }
@@ -70,34 +70,34 @@
subject { instance.call(params) }
- it 'returns the instance as the result' do
+ it "returns the instance as the result" do
expect(subject.result)
.to eql model_instance
end
- it 'is a success' do
+ it "is a success" do
expect(subject)
.to be_success
end
- context 'with params' do
+ context "with params" do
let(:params) do
{
- name: 'Foobar'
+ name: "Foobar"
}
end
- it 'assigns the params' do
+ it "assigns the params" do
subject
- expect(model_instance.name).to eq 'Foobar'
+ expect(model_instance.name).to eq "Foobar"
end
end
- context 'with an invalid contract' do
+ context "with an invalid contract" do
let(:contract_valid) { false }
- it 'returns failure' do
+ it "returns failure" do
expect(subject).not_to be_success
end
diff --git a/modules/storages/spec/services/storages/nextcloud_group_folder_properties_sync_service_spec.rb b/modules/storages/spec/services/storages/nextcloud_group_folder_properties_sync_service_spec.rb
index a61675ce848b..2541490f6f6c 100644
--- a/modules/storages/spec/services/storages/nextcloud_group_folder_properties_sync_service_spec.rb
+++ b/modules/storages/spec/services/storages/nextcloud_group_folder_properties_sync_service_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::NextcloudGroupFolderPropertiesSyncService, :webmock do
@@ -540,28 +540,28 @@
let(:project1) do
create(:project,
- name: '[Sample] Project Name / Ehuu',
+ name: "[Sample] Project Name / Ehuu",
members: { multiple_projects_user => ordinary_role, single_project_user => ordinary_role })
end
let(:project2) do
create(:project,
- name: 'Jedi Project Folder ///',
+ name: "Jedi Project Folder ///",
members: { multiple_projects_user => ordinary_role })
end
let(:project3) do
create(:project,
- name: 'Project3',
+ name: "Project3",
members: { multiple_projects_user => ordinary_role })
end
let(:project_not_active) do
create(:project,
- name: 'NOT ACTIVE PROJECT',
+ name: "NOT ACTIVE PROJECT",
active: false,
members: { multiple_projects_user => ordinary_role })
end
let(:project_public) do
create(:public_project,
- name: 'PUBLIC PROJECT',
+ name: "PUBLIC PROJECT",
active: true)
end
@@ -572,27 +572,27 @@
let(:ordinary_role) { create(:project_role, permissions: %w[read_files write_files]) }
let!(:non_member_role) { create(:non_member, permissions: %w[read_files]) }
- let(:storage) { create(:nextcloud_storage, :with_oauth_client, :as_automatically_managed, password: '12345678') }
+ let(:storage) { create(:nextcloud_storage, :with_oauth_client, :as_automatically_managed, password: "12345678") }
let!(:project_storage1) do
create(:project_storage,
:with_historical_data,
- project_folder_mode: 'automatic',
+ project_folder_mode: "automatic",
project: project1,
storage:)
end
let!(:project_storage2) do
create(:project_storage,
:with_historical_data,
- project_folder_mode: 'automatic',
+ project_folder_mode: "automatic",
project: project2,
storage:,
- project_folder_id: '123')
+ project_folder_id: "123")
end
let!(:project_storage3) do
create(:project_storage,
:with_historical_data,
- project_folder_mode: 'automatic',
+ project_folder_mode: "automatic",
project: project3,
storage:,
project_folder_id: nil)
@@ -600,112 +600,112 @@
let!(:project_storage4) do
create(:project_storage,
:with_historical_data,
- project_folder_mode: 'automatic',
+ project_folder_mode: "automatic",
project: project_not_active,
storage:,
- project_folder_id: '778')
+ project_folder_id: "778")
end
let!(:project_storage5) do
create(:project_storage,
:with_historical_data,
- project_folder_mode: 'automatic',
+ project_folder_mode: "automatic",
project: project_public,
storage:,
- project_folder_id: '999')
+ project_folder_id: "999")
end
let(:oauth_client) { storage.oauth_client }
# rubocop:enable RSpec/IndexedLet
- describe '#call' do
+ describe "#call" do
before do
- create(:oauth_client_token, origin_user_id: 'Obi-Wan', user: multiple_projects_user, oauth_client:)
- create(:oauth_client_token, origin_user_id: 'Yoda', user: single_project_user, oauth_client:)
- create(:oauth_client_token, origin_user_id: 'Darth Vader', user: admin, oauth_client:)
+ create(:oauth_client_token, origin_user_id: "Obi-Wan", user: multiple_projects_user, oauth_client:)
+ create(:oauth_client_token, origin_user_id: "Yoda", user: single_project_user, oauth_client:)
+ create(:oauth_client_token, origin_user_id: "Darth Vader", user: admin, oauth_client:)
setup_request_stubs
end
- it 'sets project folders properties' do
+ it "sets project folders properties" do
expect(project_storage1.project_folder_id).to be_nil
- expect(project_storage2.project_folder_id).to eq('123')
+ expect(project_storage2.project_folder_id).to eq("123")
expect(project_storage3.project_folder_id).to be_nil
expect(project_storage1.last_project_folders.pluck(:origin_folder_id)).to eq([nil])
- expect(project_storage2.last_project_folders.pluck(:origin_folder_id)).to eq(['123'])
+ expect(project_storage2.last_project_folders.pluck(:origin_folder_id)).to eq(["123"])
expect(project_storage3.last_project_folders.pluck(:origin_folder_id)).to eq([nil])
described_class.new(storage).call
- expect(project_storage1.reload.project_folder_id).to eq('819')
- expect(project_storage2.reload.project_folder_id).to eq('123')
- expect(project_storage3.reload.project_folder_id).to eq('2600003')
+ expect(project_storage1.reload.project_folder_id).to eq("819")
+ expect(project_storage2.reload.project_folder_id).to eq("123")
+ expect(project_storage3.reload.project_folder_id).to eq("2600003")
- expect(project_storage1.last_project_folders.pluck(:origin_folder_id)).to eq(['819'])
- expect(project_storage2.last_project_folders.pluck(:origin_folder_id)).to eq(['123'])
- expect(project_storage3.last_project_folders.pluck(:origin_folder_id)).to eq(['2600003'])
+ expect(project_storage1.last_project_folders.pluck(:origin_folder_id)).to eq(["819"])
+ expect(project_storage2.last_project_folders.pluck(:origin_folder_id)).to eq(["123"])
+ expect(project_storage3.last_project_folders.pluck(:origin_folder_id)).to eq(["2600003"])
expect(request_stubs).to all have_been_requested
end
- describe 'error handling and flow control' do
- context 'when getting the root folder properties fail' do
- context 'on a handled error case' do
+ describe "error handling and flow control" do
+ context "when getting the root folder properties fail" do
+ context "on a handled error case" do
before do
request_stubs[0] = stub_request(:propfind, "#{storage.host}/remote.php/dav/files/OpenProject/OpenProject")
.with(
body: propfind_request_body,
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=',
- 'Depth' => '1'
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=",
+ "Depth" => "1"
}
).to_return(status: 404, body: "", headers: {})
end
- it 'stops the flow immediately if the response is anything but a success' do
+ it "stops the flow immediately if the response is anything but a success" do
described_class.new(storage).call
request_stubs[1..].each { |request| expect(request).not_to have_been_requested }
end
- it 'logs an error message' do
+ it "logs an error message" do
allow(OpenProject.logger).to receive(:warn)
described_class.new(storage).call
expect(OpenProject.logger)
.to have_received(:warn)
- .with(folder: 'OpenProject',
+ .with(folder: "OpenProject",
command: Storages::Peripherals::StorageInteraction::Nextcloud::Internal::PropfindQuery,
- message: 'Outbound request destination not found',
- data: { status: 404, body: '' })
+ message: "Outbound request destination not found",
+ data: { status: 404, body: "" })
end
- it 'returns a failure' do
+ it "returns a failure" do
result = described_class.new(storage).call
expect(result).to be_failure
end
end
- it 'raises an error when dealing with an unhandled error case' do
+ it "raises an error when dealing with an unhandled error case" do
request_stubs[0] = stub_request(:propfind, "#{storage.host}/remote.php/dav/files/OpenProject/OpenProject")
.with(
body: propfind_request_body,
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=',
- 'Depth' => '1'
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=",
+ "Depth" => "1"
}
).to_return(status: 500, body: "", headers: {})
expect(described_class.new(storage).call).to be_failure
end
- it 'raises an error when dealing with a socket or connection error' do
+ it "raises an error when dealing with a socket or connection error" do
request_stubs[0] = stub_request(:propfind, "#{storage.host}/remote.php/dav/files/OpenProject/OpenProject")
.with(
body: propfind_request_body,
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=',
- 'Depth' => '1'
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=",
+ "Depth" => "1"
}
).to_timeout
@@ -713,38 +713,38 @@
end
end
- context 'when setting the root folder permissions fail' do
- context 'on a handled error case' do
+ context "when setting the root folder permissions fail" do
+ context "on a handled error case" do
before do
request_stubs[1] = stub_request(:proppatch, "#{storage.host}/remote.php/dav/files/OpenProject/OpenProject")
.with(
body: root_folder_set_permissions_request_body,
- headers: { 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=' }
- ).to_return(status: 401, body: 'Heute nicht', headers: {})
+ headers: { "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=" }
+ ).to_return(status: 401, body: "Heute nicht", headers: {})
end
- it 'interrupts the flow' do
+ it "interrupts the flow" do
described_class.new(storage).call
expect(request_stubs[0..1]).to all(have_been_requested)
request_stubs[2..].each { |request| expect(request).not_to have_been_requested }
end
- it 'logs an error message' do
+ it "logs an error message" do
allow(OpenProject.logger).to receive(:warn)
described_class.new(storage).call
expect(OpenProject.logger)
.to have_received(:warn)
- .with(folder: 'OpenProject',
+ .with(folder: "OpenProject",
command: Storages::Peripherals::StorageInteraction::Nextcloud::SetPermissionsCommand,
- message: 'Outbound request not authorized',
- data: { status: 401, body: 'Heute nicht' })
+ message: "Outbound request not authorized",
+ data: { status: 401, body: "Heute nicht" })
end
end
end
- context 'when folder creation fails' do
+ context "when folder creation fails" do
before do
request_stubs[2] = stub_request(
:mkcol,
@@ -752,12 +752,12 @@
"%5BSample%5D%20Project%20Name%20%7C%20Ehuu%20(#{project1.id})/"
).with(
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg='
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg="
}
).to_return(status: 404, body: "", headers: {})
end
- it 'continues normally ignoring that folder' do
+ it "continues normally ignoring that folder" do
expect { described_class.new(storage).call }.not_to change(project_storage1, :project_folder_id)
expect(request_stubs.delete_at(5)).not_to have_been_requested
@@ -765,7 +765,7 @@
expect(request_stubs).to all(have_been_requested)
end
- it 'logs the occurrence' do
+ it "logs the occurrence" do
allow(OpenProject.logger).to receive(:warn)
described_class.new(storage).call
@@ -773,29 +773,29 @@
.to have_received(:warn)
.with(folder: "OpenProject/[Sample] Project Name | Ehuu (#{project1.id})/",
command: Storages::Peripherals::StorageInteraction::Nextcloud::CreateFolderCommand,
- message: 'Outbound request destination not found',
- data: { status: 404, body: '' })
+ message: "Outbound request destination not found",
+ data: { status: 404, body: "" })
end
end
- context 'when renaming a folder fail' do
+ context "when renaming a folder fail" do
before do
request_stubs[4] = stub_request(:move,
"#{storage.host}/remote.php/dav/files/OpenProject/OpenProject/" \
"Lost%20Jedi%20Project%20Folder%20%233/")
.with(headers:
- { 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=',
- 'Destination' => "/remote.php/dav/files/OpenProject/OpenProject/" \
+ { "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=",
+ "Destination" => "/remote.php/dav/files/OpenProject/OpenProject/" \
"Jedi%20Project%20Folder%20%7C%7C%7C%20%28#{project2.id}%29/" })
.to_return(status: 404, body: "", headers: {})
end
- it 'we stop processing to avoid issues with permissions' do
+ it "we stop processing to avoid issues with permissions" do
described_class.new(storage).call
request_stubs[5..].each { |request| expect(request).not_to have_been_requested }
end
- it 'logs the occurrence' do
+ it "logs the occurrence" do
allow(OpenProject.logger).to receive(:warn)
described_class.new(storage).call
@@ -804,62 +804,62 @@
.with(source: "OpenProject/Lost Jedi Project Folder #3/",
target: project_storage2.managed_project_folder_path,
command: Storages::Peripherals::StorageInteraction::Nextcloud::RenameFileCommand,
- message: 'Outbound request destination not found',
- data: { status: 404, body: '' })
+ message: "Outbound request destination not found",
+ data: { status: 404, body: "" })
end
end
- context 'when hiding a folder fail' do
+ context "when hiding a folder fail" do
before do
request_stubs[6] = stub_request(:proppatch,
"#{storage.host}/remote.php/dav/files/OpenProject/OpenProject/" \
"Lost%20Jedi%20Project%20Folder%20%232/")
.with(body: hide_folder_set_permissions_request_body,
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg='
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg="
})
- .to_return(status: 500, body: 'A server error occurred', headers: {})
+ .to_return(status: 500, body: "A server error occurred", headers: {})
end
- it 'does not interrupt the flow' do
+ it "does not interrupt the flow" do
described_class.new(storage).call
expect(request_stubs).to all(have_been_requested)
end
- it 'logs the occurrence' do
+ it "logs the occurrence" do
allow(OpenProject.logger).to receive(:warn)
described_class.new(storage).call
expect(OpenProject.logger)
.to have_received(:warn)
- .with(context: 'hide_folder',
- folder: 'OpenProject/Lost Jedi Project Folder #2/',
+ .with(context: "hide_folder",
+ folder: "OpenProject/Lost Jedi Project Folder #2/",
command: Storages::Peripherals::StorageInteraction::Nextcloud::SetPermissionsCommand,
- message: 'Outbound request failed',
- data: { status: 500, body: 'A server error occurred' })
+ message: "Outbound request failed",
+ data: { status: 500, body: "A server error occurred" })
end
end
- context 'when setting project folder permissions fail' do
+ context "when setting project folder permissions fail" do
before do
request_stubs[8] = stub_request(:proppatch,
"#{storage.host}/remote.php/dav/files/OpenProject/OpenProject/" \
"Jedi%20Project%20Folder%20%7C%7C%7C%20%28#{project2.id}%29/")
.with(body: set_permissions_request_body,
- headers: { 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=' })
+ headers: { "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=" })
.to_return(status: 500,
- body: 'Divide by cucumber error. Please reinstall universe and reboot.',
+ body: "Divide by cucumber error. Please reinstall universe and reboot.",
headers: {})
end
- it 'does not interrupt the flow' do
+ it "does not interrupt the flow" do
described_class.new(storage).call
expect(request_stubs).to all(have_been_requested)
end
- it 'logs the occurrence' do
+ it "logs the occurrence" do
allow(OpenProject.logger).to receive(:warn)
described_class.new(storage).call
@@ -867,44 +867,44 @@
.to have_received(:warn)
.with(folder: "OpenProject/Jedi Project Folder ||| (#{project2.id})/",
command: Storages::Peripherals::StorageInteraction::Nextcloud::SetPermissionsCommand,
- message: 'Outbound request failed',
- data: { status: 500, body: 'Divide by cucumber error. Please reinstall universe and reboot.' })
+ message: "Outbound request failed",
+ data: { status: 500, body: "Divide by cucumber error. Please reinstall universe and reboot." })
end
end
- context 'when adding a user to the group fails' do
+ context "when adding a user to the group fails" do
before do
request_stubs[12] = stub_request(:post, "#{storage.host}/ocs/v1.php/cloud/users/Obi-Wan/groups")
.with(
body: "groupid=OpenProject",
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=',
- 'Ocs-Apirequest' => 'true'
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=",
+ "Ocs-Apirequest" => "true"
}
- ).to_return(status: 302, body: '', headers: {})
+ ).to_return(status: 302, body: "", headers: {})
end
- it 'does not interrupt te flow' do
+ it "does not interrupt te flow" do
described_class.new(storage).call
expect(request_stubs).to all have_been_requested
end
- it 'logs the occurrence' do
+ it "logs the occurrence" do
allow(OpenProject.logger).to receive(:warn)
described_class.new(storage).call
expect(OpenProject.logger)
.to have_received(:warn)
- .with(group: 'OpenProject',
- user: 'Obi-Wan',
+ .with(group: "OpenProject",
+ user: "Obi-Wan",
command: Storages::Peripherals::StorageInteraction::Nextcloud::AddUserToGroupCommand,
- message: 'Outbound request failed',
- data: { status: 302, body: '' })
+ message: "Outbound request failed",
+ data: { status: 302, body: "" })
end
end
- context 'when removing a user to the group fails' do
+ context "when removing a user to the group fails" do
let(:remove_user_from_group_response) do
<<~XML
@@ -919,23 +919,23 @@
XML
end
- it 'does not interrupt the flow' do
+ it "does not interrupt the flow" do
described_class.new(storage).call
expect(request_stubs).to all have_been_requested
end
- it 'logs the occurrence and continues the flow' do
+ it "logs the occurrence and continues the flow" do
allow(OpenProject.logger).to receive(:warn)
described_class.new(storage).call
expect(OpenProject.logger)
.to have_received(:warn)
- .with(group: 'OpenProject',
- user: 'Darth Maul',
+ .with(group: "OpenProject",
+ user: "Darth Maul",
command: Storages::Peripherals::StorageInteraction::Nextcloud::RemoveUserFromGroupCommand,
- message: 'Failed to remove user Darth Maul from group OpenProject: ' \
- 'Not viable to remove user from the last group you are SubAdmin of',
+ message: "Failed to remove user Darth Maul from group OpenProject: " \
+ "Not viable to remove user from the last group you are SubAdmin of",
data: { status: 200, body: remove_user_from_group_response })
end
end
@@ -950,8 +950,8 @@ def setup_request_stubs
.with(
body: propfind_request_body,
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=',
- 'Depth' => '1'
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=",
+ "Depth" => "1"
}
).to_return(status: 207, body: root_folder_propfind_response_body, headers: {})
@@ -960,7 +960,7 @@ def setup_request_stubs
.with(
body: root_folder_set_permissions_request_body,
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg='
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg="
}
).to_return(status: 207, body: root_folder_set_permissions_response_body, headers: {})
@@ -971,7 +971,7 @@ def setup_request_stubs
"%5BSample%5D%20Project%20Name%20%7C%20Ehuu%20(#{project1.id})/"
).with(
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg='
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg="
}
).to_return(status: 201, body: "", headers: {})
@@ -983,8 +983,8 @@ def setup_request_stubs
).with(
body: propfind_request_body,
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=',
- 'Depth' => '1'
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=",
+ "Depth" => "1"
}
).to_return(status: 207, body: created_folder_propfind_response_body, headers: {})
@@ -994,8 +994,8 @@ def setup_request_stubs
"#{storage.host}/remote.php/dav/files/OpenProject/OpenProject/Lost%20Jedi%20Project%20Folder%20%233/"
).with(
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=',
- 'Destination' => "/remote.php/dav/files/OpenProject/OpenProject/" \
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=",
+ "Destination" => "/remote.php/dav/files/OpenProject/OpenProject/" \
"Jedi%20Project%20Folder%20%7C%7C%7C%20%28#{project2.id}%29/"
}
).to_return(status: 201, body: "", headers: {})
@@ -1008,7 +1008,7 @@ def setup_request_stubs
).with(
body: created_folder_set_permissions_request_body,
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg='
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg="
}
).to_return(status: 207, body: created_folder_set_permissions_response_body, headers: {})
@@ -1019,7 +1019,7 @@ def setup_request_stubs
).with(
body: hide_folder_set_permissions_request_body,
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg='
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg="
}
).to_return(status: 207, body: hide_folder_set_permissions_response_body, headers: {})
@@ -1030,7 +1030,7 @@ def setup_request_stubs
).with(
body: set_permissions_request_body5,
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg='
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg="
}
).to_return(status: 207, body: set_permissions_response_body5, headers: {})
@@ -1042,7 +1042,7 @@ def setup_request_stubs
).with(
body: set_permissions_request_body,
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg='
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg="
}
).to_return(status: 207, body: set_permissions_response_body, headers: {})
@@ -1053,7 +1053,7 @@ def setup_request_stubs
).with(
body: set_permissions_request_body6,
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg='
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg="
}
).to_return(status: 207, body: set_permissions_response_body6, headers: {})
@@ -1063,7 +1063,7 @@ def setup_request_stubs
).with(
body: set_permissions_request_body,
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg='
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg="
}
).to_return(status: 207, body: set_permissions_response_body7, headers: {})
@@ -1071,8 +1071,8 @@ def setup_request_stubs
request_stubs << stub_request(:get, "#{storage.host}/ocs/v1.php/cloud/groups/#{storage.group}")
.with(
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=',
- 'OCS-APIRequest' => 'true'
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=",
+ "OCS-APIRequest" => "true"
}
).to_return(status: 200, body: group_users_response_body, headers: {})
@@ -1081,8 +1081,8 @@ def setup_request_stubs
.with(
body: "groupid=OpenProject",
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=',
- 'Ocs-Apirequest' => 'true'
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=",
+ "Ocs-Apirequest" => "true"
}
).to_return(status: 200, body: add_user_to_group_response_body, headers: {})
@@ -1090,8 +1090,8 @@ def setup_request_stubs
.with(
body: "groupid=OpenProject",
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=',
- 'Ocs-Apirequest' => 'true'
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=",
+ "Ocs-Apirequest" => "true"
}
).to_return(status: 200, body: add_user_to_group_response_body, headers: {})
@@ -1099,8 +1099,8 @@ def setup_request_stubs
.with(
body: "groupid=OpenProject",
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=',
- 'Ocs-Apirequest' => 'true'
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=",
+ "Ocs-Apirequest" => "true"
}
).to_return(status: 200, body: add_user_to_group_response_body, headers: {})
@@ -1110,8 +1110,8 @@ def setup_request_stubs
"#{storage.host}/ocs/v1.php/cloud/users/Darth%20Maul/groups?groupid=OpenProject"
).with(
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=',
- 'Ocs-Apirequest' => 'true'
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=",
+ "Ocs-Apirequest" => "true"
}
).to_return(status: 200, body: remove_user_from_group_response, headers: {})
@@ -1121,7 +1121,7 @@ def setup_request_stubs
"#{storage.host}/remote.php/dav/files/OpenProject/OpenProject/Project3%20(#{project3.id})/"
).with(
headers: {
- 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg='
+ "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg="
}
).to_return(status: 405, body: <<~XML, headers: {})
@@ -1136,7 +1136,7 @@ def setup_request_stubs
:propfind,
"#{storage.host}/remote.php/dav/files/OpenProject/OpenProject/Project3%20(#{project3.id})/"
).with(
- headers: { 'Authorization' => 'Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=' },
+ headers: { "Authorization" => "Basic T3BlblByb2plY3Q6MTIzNDU2Nzg=" },
body: propfind_request_body
).to_return(status: 200, body: propfind_response_body3, headers: {})
end
diff --git a/modules/storages/spec/services/storages/oauth_applications/create_service_spec.rb b/modules/storages/spec/services/storages/oauth_applications/create_service_spec.rb
index fb3393aa31a5..061680296ceb 100644
--- a/modules/storages/spec/services/storages/oauth_applications/create_service_spec.rb
+++ b/modules/storages/spec/services/storages/oauth_applications/create_service_spec.rb
@@ -28,20 +28,20 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require 'services/base_services/behaves_like_create_service'
+require "services/base_services/behaves_like_create_service"
RSpec.describe Storages::OAuthApplications::CreateService, type: :model do
let(:user) { create(:admin) }
let(:storage) { create(:nextcloud_storage, creator: user) }
let(:instance) { described_class.new(user:, storage:) }
- describe '#call' do
+ describe "#call" do
subject { instance.call }
- it 'returns a OAuthApplication' do
+ it "returns a OAuthApplication" do
expect(subject).to be_a ServiceResult
expect(subject).to be_success
expect(subject.result).to be_a Doorkeeper::Application
@@ -49,7 +49,7 @@
expect(subject.result.name).to include I18n.t("storages.provider_types.#{storage.short_provider_type}.name")
expect(subject.result.scopes.to_s).to eql "api_v3"
expect(subject.result.redirect_uri).to include storage.host
- expect(subject.result.redirect_uri).to include 'apps/integration_openproject/oauth-redirect'
+ expect(subject.result.redirect_uri).to include "apps/integration_openproject/oauth-redirect"
expect(subject.result.integration).to eql storage
expect(subject.result.confidential).to be_truthy
expect(subject.result.owner).to eql user
diff --git a/modules/storages/spec/services/storages/one_drive_managed_folder_sync_service_spec.rb b/modules/storages/spec/services/storages/one_drive_managed_folder_sync_service_spec.rb
index d186e321c838..de0d3ffcd495 100644
--- a/modules/storages/spec/services/storages/one_drive_managed_folder_sync_service_spec.rb
+++ b/modules/storages/spec/services/storages/one_drive_managed_folder_sync_service_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec::Matchers.define_negated_matcher :not_change, :change
@@ -39,7 +39,7 @@
shared_let(:storage) do
# Automatically Managed Project Folder Drive
create(:sharepoint_dev_drive_storage,
- drive_id: 'b!dmVLG22QlE2PSW0AqVB7UOhZ8n7tjkVGkgqLNnuw2ODRDvn3haLiQIhB5UYNdqMy',
+ drive_id: "b!dmVLG22QlE2PSW0AqVB7UOhZ8n7tjkVGkgqLNnuw2ODRDvn3haLiQIhB5UYNdqMy",
oauth_client_token_user: admin)
end
@@ -49,7 +49,7 @@
create(:oauth_client_token,
user: single_project_user,
oauth_client: storage.oauth_client,
- origin_user_id: '2ff33b8f-2843-40c1-9a17-d786bca17fba')
+ origin_user_id: "2ff33b8f-2843-40c1-9a17-d786bca17fba")
end
shared_let(:multiple_projects_user) { create(:user) }
@@ -57,7 +57,7 @@
create(:oauth_client_token,
user: multiple_projects_user,
oauth_client: storage.oauth_client,
- origin_user_id: '248aeb72-b231-4e71-a466-67fa7df2a285')
+ origin_user_id: "248aeb72-b231-4e71-a466-67fa7df2a285")
end
# ROLE FACTORIES
@@ -68,37 +68,37 @@
# PROJECT FACTORIES
shared_let(:project) do
create(:project,
- name: '[Sample] Project Name / Ehuu',
+ name: "[Sample] Project Name / Ehuu",
members: { multiple_projects_user => ordinary_role, single_project_user => ordinary_role })
end
shared_let(:project_storage) do
- create(:project_storage, :with_historical_data, project_folder_mode: 'automatic', storage:, project:)
+ create(:project_storage, :with_historical_data, project_folder_mode: "automatic", storage:, project:)
end
shared_let(:disallowed_chars_project) do
create(:project, name: '<=o=> | "Jedi" Project Folder ///', members: { multiple_projects_user => ordinary_role })
end
shared_let(:disallowed_chars_project_storage) do
- create(:project_storage, :with_historical_data, project_folder_mode: 'automatic', project: disallowed_chars_project, storage:)
+ create(:project_storage, :with_historical_data, project_folder_mode: "automatic", project: disallowed_chars_project, storage:)
end
shared_let(:inactive_project) do
- create(:project, name: 'INACTIVE PROJECT! f0r r34lz', active: false, members: { multiple_projects_user => ordinary_role })
+ create(:project, name: "INACTIVE PROJECT! f0r r34lz", active: false, members: { multiple_projects_user => ordinary_role })
end
shared_let(:inactive_project_storage) do
- create(:project_storage, :with_historical_data, project_folder_mode: 'automatic', project: inactive_project, storage:)
+ create(:project_storage, :with_historical_data, project_folder_mode: "automatic", project: inactive_project, storage:)
end
- shared_let(:public_project) { create(:public_project, name: 'PUBLIC PROJECT', active: true) }
+ shared_let(:public_project) { create(:public_project, name: "PUBLIC PROJECT", active: true) }
shared_let(:public_project_storage) do
- create(:project_storage, :with_historical_data, project_folder_mode: 'automatic', project: public_project, storage:)
+ create(:project_storage, :with_historical_data, project_folder_mode: "automatic", project: public_project, storage:)
end
shared_let(:unmanaged_project) do
- create(:project, name: 'Non Managed Project', active: true, members: { multiple_projects_user => ordinary_role })
+ create(:project, name: "Non Managed Project", active: true, members: { multiple_projects_user => ordinary_role })
end
shared_let(:unmanaged_project_storage) do
- create(:project_storage, :with_historical_data, project_folder_mode: 'manual', project: unmanaged_project, storage:)
+ create(:project_storage, :with_historical_data, project_folder_mode: "manual", project: unmanaged_project, storage:)
end
# This is a remote service call. We need to enable WebMock and VCR in order to record it,
@@ -106,7 +106,7 @@
# Then we disable both VCR and WebMock to return to the usual state
shared_let(:original_folder_ids) do
WebMock.enable! && VCR.turn_on!
- VCR.use_cassette('one_drive/sync_service_original_folders') do
+ VCR.use_cassette("one_drive/sync_service_original_folders") do
original_folders(storage)
end
ensure
@@ -115,23 +115,23 @@
subject(:service) { described_class.new(storage) }
- it 'responds to .call' do
+ it "responds to .call" do
method = described_class.method(:call)
expect(method.parameters).to contain_exactly(%i[req storage])
end
- it 'return if the storage is not automatically managed' do
+ it "return if the storage is not automatically managed" do
expect(described_class.call(storage)).to be_falsey
end
- describe '#call' do
+ describe "#call" do
before { storage.update(automatically_managed: true) }
after { delete_created_folders }
- context 'when successful' do
- it 'updates the project folder id for all active automatically managed projects',
- vcr: 'one_drive/sync_service_create_folder' do
+ context "when successful" do
+ it "updates the project folder id for all active automatically managed projects",
+ vcr: "one_drive/sync_service_create_folder" do
expect { service.call }.to change { disallowed_chars_project_storage.reload.project_folder_id }
.from(nil).to(String)
.and(change { project_storage.reload.project_folder_id }.from(nil).to(String))
@@ -140,8 +140,8 @@
.and(not_change { unmanaged_project_storage.reload.project_folder_id })
end
- it 'adds a record to the LastProjectFolder for each new folder',
- vcr: 'one_drive/sync_service_create_folder' do
+ it "adds a record to the LastProjectFolder for each new folder",
+ vcr: "one_drive/sync_service_create_folder" do
scope = ->(project_storage) { Storages::LastProjectFolder.where(project_storage:).last }
expect { service.call }.to not_change { scope[unmanaged_project_storage].reload.origin_folder_id }
@@ -153,8 +153,8 @@
.to eq(disallowed_chars_project_storage.reload.project_folder_id)
end
- it 'creates the remote folders for all projects with automatically managed folders enabled',
- vcr: 'one_drive/sync_service_create_folder' do
+ it "creates the remote folders for all projects with automatically managed folders enabled",
+ vcr: "one_drive/sync_service_create_folder" do
service.call
[project_storage, disallowed_chars_project_storage, public_project_storage].each do |proj_storage|
@@ -162,8 +162,8 @@
end
end
- it 'makes sure that the last_project_folder.origin_folder_id match the current project_folder_id',
- vcr: 'one_drive/sync_service_create_folder' do
+ it "makes sure that the last_project_folder.origin_folder_id match the current project_folder_id",
+ vcr: "one_drive/sync_service_create_folder" do
service.call
[project_storage, disallowed_chars_project_storage, public_project_storage].each do |proj_storage|
@@ -175,7 +175,7 @@
end
end
- it 'renames an already existing project folder', vcr: 'one_drive/sync_service_rename_folder' do
+ it "renames an already existing project folder", vcr: "one_drive/sync_service_rename_folder" do
original_folder = create_folder_for(disallowed_chars_project_storage, "Old Jedi Project")
disallowed_chars_project_storage.update(project_folder_id: original_folder.result.id)
@@ -186,16 +186,16 @@
expect(result[:name]).to match(/_=o=_ _ _Jedi_ Project Folder ___ \(\d+\)/)
end
- it 'hides (removes all permissions) from inactive project folders', vcr: 'one_drive/sync_service_hide_inactive' do
+ it "hides (removes all permissions) from inactive project folders", vcr: "one_drive/sync_service_hide_inactive" do
original_folder = create_folder_for(inactive_project_storage)
inactive_project_storage.update(project_folder_id: original_folder.result.id)
set_permissions_on(original_folder.result.id,
- { read: ['2ff33b8f-2843-40c1-9a17-d786bca17fba'],
+ { read: ["2ff33b8f-2843-40c1-9a17-d786bca17fba"],
write: %w[33db2c84-275d-46af-afb0-c26eb786b194 248aeb72-b231-4e71-a466-67fa7df2a285] })
expect(permissions_for(inactive_project_storage))
- .to eq({ read: ['2ff33b8f-2843-40c1-9a17-d786bca17fba'],
+ .to eq({ read: ["2ff33b8f-2843-40c1-9a17-d786bca17fba"],
write: %w[248aeb72-b231-4e71-a466-67fa7df2a285 33db2c84-275d-46af-afb0-c26eb786b194] })
service.call
@@ -203,7 +203,7 @@
expect(permissions_for(inactive_project_storage)).to be_empty
end
- it 'adds already logged in users to the project folder', vcr: 'one_drive/sync_service_set_permissions' do
+ it "adds already logged in users to the project folder", vcr: "one_drive/sync_service_set_permissions" do
original_folder = create_folder_for(inactive_project_storage)
inactive_project_storage.update(project_folder_id: original_folder.result.id)
@@ -220,20 +220,20 @@
expect(permissions_for(inactive_project_storage)).to be_empty
end
- it 'if the project is public allows any logged in user to read the files',
- vcr: 'one_drive/sync_service_public_project' do
+ it "if the project is public allows any logged in user to read the files",
+ vcr: "one_drive/sync_service_public_project" do
service.call
expect(permissions_for(public_project_storage))
.to eq({ read: %w[248aeb72-b231-4e71-a466-67fa7df2a285 2ff33b8f-2843-40c1-9a17-d786bca17fba],
- write: ['33db2c84-275d-46af-afb0-c26eb786b194'] })
+ write: ["33db2c84-275d-46af-afb0-c26eb786b194"] })
end
- it 'ensures that admins have full access to all folders', vcr: 'one_drive/sync_service_admin_access' do
+ it "ensures that admins have full access to all folders", vcr: "one_drive/sync_service_admin_access" do
service.call
[project_storage, disallowed_chars_project_storage, public_project_storage].each do |ps|
- expect(permissions_for(ps)[:write]).to include('33db2c84-275d-46af-afb0-c26eb786b194')
+ expect(permissions_for(ps)[:write]).to include("33db2c84-275d-46af-afb0-c26eb786b194")
end
end
@@ -241,13 +241,13 @@
before { allow(OpenProject.logger).to receive(:warn) }
context "when reading the root folder fails" do
- it 'returns a failure in case retrieving the root list fails', vcr: 'one_drive/sync_service_root_read_failure' do
- storage.update(drive_id: 'THIS-IS-NOT-A-DRIVE-ID')
+ it "returns a failure in case retrieving the root list fails", vcr: "one_drive/sync_service_root_read_failure" do
+ storage.update(drive_id: "THIS-IS-NOT-A-DRIVE-ID")
expect(service.call).to be_failure
end
- it 'logs the occurrence', vcr: 'one_drive/sync_service_root_read_failure' do
- storage.update(drive_id: 'THIS-IS-NOT-A-DRIVE-ID')
+ it "logs the occurrence", vcr: "one_drive/sync_service_root_read_failure" do
+ storage.update(drive_id: "THIS-IS-NOT-A-DRIVE-ID")
service.call
expect(OpenProject.logger)
@@ -258,8 +258,8 @@
end
end
- context 'when folder creation fails' do
- it "doesn't update the project_storage", vcr: 'one_drive/sync_service_creation_fail' do
+ context "when folder creation fails" do
+ it "doesn't update the project_storage", vcr: "one_drive/sync_service_creation_fail" do
already_existing_folder = create_folder_for(project_storage).result
expect { service.call }.not_to change(project_storage, :project_folder_id)
@@ -267,7 +267,7 @@
delete_folder(already_existing_folder.id)
end
- it 'logs the occurrence', vcr: 'one_drive/sync_service_creation_fail' do
+ it "logs the occurrence", vcr: "one_drive/sync_service_creation_fail" do
already_existing_folder = create_folder_for(project_storage).result
service.call
@@ -282,8 +282,8 @@
end
end
- context 'when folder renaming fails' do
- it 'logs the occurrence', vcr: 'one_drive/sync_service_rename_failed' do
+ context "when folder renaming fails" do
+ it "logs the occurrence", vcr: "one_drive/sync_service_rename_failed" do
already_existing_folder = create_folder_for(project_storage)
original_folder = create_folder_for(project_storage, "Flawless Death Star Blueprints")
project_storage.update(project_folder_id: original_folder.result.id)
@@ -302,9 +302,9 @@
end
end
- context 'when setting permission fails' do
- it 'logs the occurrence', vcr: 'one_drive/sync_service_fail_add_user' do
- single_project_user_token.update(origin_user_id: 'my_name_is_mud')
+ context "when setting permission fails" do
+ it "logs the occurrence", vcr: "one_drive/sync_service_fail_add_user" do
+ single_project_user_token.update(origin_user_id: "my_name_is_mud")
service.call
expect(OpenProject.logger)
@@ -325,7 +325,7 @@ def permissions_for(project_storage)
Storages::Peripherals::StorageInteraction::OneDrive::Util.using_admin_token(storage) do |http|
response = http.get("/v1.0/drives/#{storage.drive_id}/items/#{project_storage.project_folder_id}/permissions")
response.json(symbolize_keys: true).fetch(:value, []).each_with_object({}) do |grant, hash|
- next if grant[:roles].member?('owner')
+ next if grant[:roles].member?("owner")
hash[grant[:roles].first.to_sym] ||= []
hash[grant[:roles].first.to_sym] << grant.dig(:grantedToV2, :user, :id)
@@ -360,12 +360,12 @@ def project_folder_info(project_storage)
def create_folder_for(project_storage, folder_override = nil)
folder_path = folder_override || project_storage.managed_project_folder_path
- Storages::Peripherals::Registry.resolve('one_drive.commands.create_folder')
+ Storages::Peripherals::Registry.resolve("one_drive.commands.create_folder")
.call(storage: project_storage.storage, folder_path:)
end
def set_permissions_on(item_id, permissions)
- Storages::Peripherals::Registry.resolve('one_drive.commands.set_permissions')
+ Storages::Peripherals::Registry.resolve("one_drive.commands.set_permissions")
.call(storage:, path: item_id, permissions:)
end
@@ -377,6 +377,6 @@ def delete_created_folders
end
def delete_folder(item_id)
- Storages::Peripherals::Registry.resolve('one_drive.commands.delete_folder').call(storage:, location: item_id)
+ Storages::Peripherals::Registry.resolve("one_drive.commands.delete_folder").call(storage:, location: item_id)
end
end
diff --git a/modules/storages/spec/services/storages/project_storages/create_service_spec.rb b/modules/storages/spec/services/storages/project_storages/create_service_spec.rb
index bf555fb9ec19..5f360213b71e 100644
--- a/modules/storages/spec/services/storages/project_storages/create_service_spec.rb
+++ b/modules/storages/spec/services/storages/project_storages/create_service_spec.rb
@@ -28,16 +28,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require 'services/base_services/behaves_like_create_service'
-require_relative 'shared_event_gun_examples'
+require "services/base_services/behaves_like_create_service"
+require_relative "shared_event_gun_examples"
RSpec.describe Storages::ProjectStorages::CreateService, type: :model do
- it_behaves_like 'BaseServices create service' do
+ it_behaves_like "BaseServices create service" do
let(:factory) { :project_storage }
- it_behaves_like('an event gun', OpenProject::Events::PROJECT_STORAGE_CREATED)
+ it_behaves_like("an event gun", OpenProject::Events::PROJECT_STORAGE_CREATED)
end
end
diff --git a/modules/storages/spec/services/storages/project_storages/delete_service_spec.rb b/modules/storages/spec/services/storages/project_storages/delete_service_spec.rb
index bbd2f192a260..00b9572f9353 100644
--- a/modules/storages/spec/services/storages/project_storages/delete_service_spec.rb
+++ b/modules/storages/spec/services/storages/project_storages/delete_service_spec.rb
@@ -28,54 +28,54 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require 'services/base_services/behaves_like_delete_service'
-require_relative 'shared_event_gun_examples'
+require "services/base_services/behaves_like_delete_service"
+require_relative "shared_event_gun_examples"
RSpec.describe Storages::ProjectStorages::DeleteService, :webmock, type: :model do
- shared_examples_for 'deleting project storages with project folders' do
+ shared_examples_for "deleting project storages with project folders" do
let(:delete_folder_stub) do
stub_request(:delete, delete_folder_url).to_return(status: 204, body: nil, headers: {})
end
before { delete_folder_stub }
- context 'if project folder mode is set to automatic' do
+ context "if project folder mode is set to automatic" do
let(:project_storage) do
- create(:project_storage, project:, storage:, project_folder_id: '1337', project_folder_mode: 'automatic')
+ create(:project_storage, project:, storage:, project_folder_id: "1337", project_folder_mode: "automatic")
end
- it 'tries to remove the project folder at the remote storage' do
+ it "tries to remove the project folder at the remote storage" do
expect(described_class.new(model: project_storage, user:).call).to be_success
expect(delete_folder_stub).to have_been_requested
end
- context 'if project folder deletion request fails' do
+ context "if project folder deletion request fails" do
let(:delete_folder_stub) do
stub_request(:delete, delete_folder_url).to_return(status: 404, body: nil, headers: {})
end
- it 'tries to remove the project folder at the remote storage and still succeed with deletion' do
+ it "tries to remove the project folder at the remote storage and still succeed with deletion" do
expect(described_class.new(model: project_storage, user:).call).to be_success
expect(delete_folder_stub).to have_been_requested
end
end
end
- context 'if project folder mode is set to manual' do
+ context "if project folder mode is set to manual" do
let(:project_storage) do
- create(:project_storage, project:, storage:, project_folder_id: '1337', project_folder_mode: 'manual')
+ create(:project_storage, project:, storage:, project_folder_id: "1337", project_folder_mode: "manual")
end
- it 'must not try to delete manual project folders' do
+ it "must not try to delete manual project folders" do
expect(described_class.new(model: project_storage, user:).call).to be_success
expect(delete_folder_stub).not_to have_been_requested
end
end
end
- context 'with records written to DB' do
+ context "with records written to DB" do
let(:user) { create(:user) }
let(:role) { create(:project_role, permissions: [:manage_storages_in_project]) }
let(:project) { create(:project, members: { user => role }) }
@@ -87,14 +87,14 @@
let(:file_link) { create(:file_link, container: work_package, storage:) }
let(:other_file_link) { create(:file_link, container: other_work_package, storage:) }
- it 'destroys the record' do
+ it "destroys the record" do
project_storage
described_class.new(model: project_storage, user:).call
expect(Storages::ProjectStorage.where(id: project_storage.id)).not_to exist
end
- it 'deletes all FileLinks that belong to containers of the related project' do
+ it "deletes all FileLinks that belong to containers of the related project" do
file_link
other_file_link
@@ -104,15 +104,15 @@
expect(Storages::FileLink.where(id: other_file_link.id)).to exist
end
- context 'with Nextcloud storage' do
+ context "with Nextcloud storage" do
let(:delete_folder_url) do
"#{storage.host}/remote.php/dav/files/#{storage.username}/#{project_storage.project_folder_location}"
end
- it_behaves_like 'deleting project storages with project folders'
+ it_behaves_like "deleting project storages with project folders"
end
- context 'with OneDrive storage' do
+ context "with OneDrive storage" do
let(:storage) { create(:one_drive_storage) }
let(:delete_folder_url) do
"https://graph.microsoft.com/v1.0/drives/#{storage.drive_id}/items/#{project_storage.project_folder_location}"
@@ -124,11 +124,11 @@
.and_yield(HTTPX.with(origin: storage.uri))
end
- it_behaves_like 'deleting project storages with project folders'
+ it_behaves_like "deleting project storages with project folders"
end
end
- it_behaves_like 'BaseServices delete service' do
+ it_behaves_like "BaseServices delete service" do
let(:factory) { :project_storage }
let(:host) { model_instance.storage.host }
let(:username) { model_instance.storage.username }
@@ -141,6 +141,6 @@
stub_request(:delete, delete_folder_url).to_return(status: 204, body: nil, headers: {})
end
- it_behaves_like('an event gun', OpenProject::Events::PROJECT_STORAGE_DESTROYED)
+ it_behaves_like("an event gun", OpenProject::Events::PROJECT_STORAGE_DESTROYED)
end
end
diff --git a/modules/storages/spec/services/storages/project_storages/set_attributes_service_spec.rb b/modules/storages/spec/services/storages/project_storages/set_attributes_service_spec.rb
index 03da16866a83..2bc58c3d43a2 100644
--- a/modules/storages/spec/services/storages/project_storages/set_attributes_service_spec.rb
+++ b/modules/storages/spec/services/storages/project_storages/set_attributes_service_spec.rb
@@ -28,20 +28,20 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::ProjectStorages::SetAttributesService, type: :model do
let(:current_user) { build_stubbed(:admin) }
let(:contract_instance) do
- contract = instance_double(Storages::ProjectStorages::BaseContract, 'contract_instance')
+ contract = instance_double(Storages::ProjectStorages::BaseContract, "contract_instance")
allow(contract)
.to receive_messages(validate: contract_valid, errors: contract_errors)
contract
end
- let(:contract_errors) { instance_double(ActiveModel::Errors, 'contract_errors') }
+ let(:contract_errors) { instance_double(ActiveModel::Errors, "contract_errors") }
let(:contract_valid) { true }
let(:model_valid) { true }
@@ -70,34 +70,34 @@
subject { instance.call(params) }
- it 'returns the instance as the result' do
+ it "returns the instance as the result" do
expect(subject.result)
.to eql model_instance
end
- it 'is a success' do
+ it "is a success" do
expect(subject)
.to be_success
end
- context 'with new record' do
- it 'sets creator to current user' do
+ context "with new record" do
+ it "sets creator to current user" do
expect(subject.result.creator).to eq current_user
end
end
- context 'with existing record' do
+ context "with existing record" do
let(:model_instance) { build_stubbed(:project_storage, creator: build_stubbed(:user)) }
- it 'keeps its creator' do
+ it "keeps its creator" do
expect(subject.result.creator).not_to eq current_user
end
end
- context 'with an invalid contract' do
+ context "with an invalid contract" do
let(:contract_valid) { false }
- it 'returns failure' do
+ it "returns failure" do
expect(subject).not_to be_success
end
diff --git a/modules/storages/spec/services/storages/project_storages/shared_event_gun_examples.rb b/modules/storages/spec/services/storages/project_storages/shared_event_gun_examples.rb
index 9386eb5326e1..7039fbf212ac 100644
--- a/modules/storages/spec/services/storages/project_storages/shared_event_gun_examples.rb
+++ b/modules/storages/spec/services/storages/project_storages/shared_event_gun_examples.rb
@@ -28,13 +28,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-RSpec.shared_examples 'an event gun' do |event|
+RSpec.shared_examples "an event gun" do |event|
%i[automatic manual inactive].each do |mode|
context "when project_folder mode is #{mode}" do
- it 'fires an appropriate event' do
+ it "fires an appropriate event" do
allow(OpenProject::Notifications).to(receive(:send))
model_instance.project_folder_mode = mode
diff --git a/modules/storages/spec/services/storages/project_storages/update_service_spec.rb b/modules/storages/spec/services/storages/project_storages/update_service_spec.rb
index b65fc29bd06f..26fa762f5792 100644
--- a/modules/storages/spec/services/storages/project_storages/update_service_spec.rb
+++ b/modules/storages/spec/services/storages/project_storages/update_service_spec.rb
@@ -28,16 +28,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require 'services/base_services/behaves_like_update_service'
-require_relative 'shared_event_gun_examples'
+require "services/base_services/behaves_like_update_service"
+require_relative "shared_event_gun_examples"
RSpec.describe Storages::ProjectStorages::UpdateService, type: :model do
- it_behaves_like 'BaseServices update service' do
+ it_behaves_like "BaseServices update service" do
let(:factory) { :project_storage }
- it_behaves_like('an event gun', OpenProject::Events::PROJECT_STORAGE_UPDATED)
+ it_behaves_like("an event gun", OpenProject::Events::PROJECT_STORAGE_UPDATED)
end
end
diff --git a/modules/storages/spec/services/storages/storages/create_service_spec.rb b/modules/storages/spec/services/storages/storages/create_service_spec.rb
index f7edfcc03fa4..353b72ff5b24 100644
--- a/modules/storages/spec/services/storages/storages/create_service_spec.rb
+++ b/modules/storages/spec/services/storages/storages/create_service_spec.rb
@@ -28,13 +28,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require 'services/base_services/behaves_like_create_service'
+require "services/base_services/behaves_like_create_service"
RSpec.describe Storages::Storages::CreateService, type: :model do
- it_behaves_like 'BaseServices create service' do
+ it_behaves_like "BaseServices create service" do
let(:factory) { :storage }
let!(:user) { create(:admin) }
@@ -46,9 +46,9 @@
let(:call_attributes) do
{
- name: 'My storage',
- host: 'https://example.org',
- provider_type: 'Storages::NextcloudStorage'
+ name: "My storage",
+ host: "https://example.org",
+ provider_type: "Storages::NextcloudStorage"
}
end
diff --git a/modules/storages/spec/services/storages/storages/delete_service_spec.rb b/modules/storages/spec/services/storages/storages/delete_service_spec.rb
index 9bc95f258a4a..387f40875254 100644
--- a/modules/storages/spec/services/storages/storages/delete_service_spec.rb
+++ b/modules/storages/spec/services/storages/storages/delete_service_spec.rb
@@ -28,13 +28,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require 'services/base_services/behaves_like_delete_service'
+require "services/base_services/behaves_like_delete_service"
RSpec.describe Storages::Storages::DeleteService, type: :model do
- it_behaves_like 'BaseServices delete service' do
+ it_behaves_like "BaseServices delete service" do
let(:factory) { :storage }
end
end
diff --git a/modules/storages/spec/services/storages/storages/set_attributes_service_spec.rb b/modules/storages/spec/services/storages/storages/set_attributes_service_spec.rb
index 1e36ddeeaa35..e5fe1297283c 100644
--- a/modules/storages/spec/services/storages/storages/set_attributes_service_spec.rb
+++ b/modules/storages/spec/services/storages/storages/set_attributes_service_spec.rb
@@ -28,19 +28,19 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Storages::SetAttributesService, type: :model do
let(:current_user) { build_stubbed(:admin) }
let(:contract_instance) do
- contract = instance_double(Storages::Storages::CreateContract, 'contract_instance')
+ contract = instance_double(Storages::Storages::CreateContract, "contract_instance")
allow(contract).to receive_messages(validate: contract_valid, errors: contract_errors)
contract
end
- let(:contract_errors) { instance_double(ActiveModel::Errors, 'contract_errors') }
+ let(:contract_errors) { instance_double(ActiveModel::Errors, "contract_errors") }
let(:contract_valid) { true }
let(:model_valid) { true }
@@ -69,53 +69,53 @@
subject { instance.call(params) }
- it 'returns the instance as the result' do
+ it "returns the instance as the result" do
expect(subject.result)
.to eql model_instance
end
- it 'is a success' do
+ it "is a success" do
expect(subject)
.to be_success
end
- context 'with new record' do
- it 'sets creator to current user' do
+ context "with new record" do
+ it "sets creator to current user" do
expect(subject.result.creator).to eq current_user
end
- it 'sets provider_type to nextcloud' do
+ it "sets provider_type to nextcloud" do
expect(subject.result.provider_type).to eq Storages::Storage::PROVIDER_TYPE_NEXTCLOUD
end
- context 'when setting host' do
+ context "when setting host" do
before do
params[:host] = "https://some.host.com//"
end
- it 'removes trailing slashes from host' do
+ it "removes trailing slashes from host" do
expect(subject.result.host).to eq("https://some.host.com")
end
end
end
- context 'with existing record' do
- let(:model_instance) { build_stubbed(:nextcloud_storage, name: 'My Storage', creator: build_stubbed(:user)) }
+ context "with existing record" do
+ let(:model_instance) { build_stubbed(:nextcloud_storage, name: "My Storage", creator: build_stubbed(:user)) }
- it 'keeps its name' do
- expect(subject.result.name).to eq 'My Storage'
+ it "keeps its name" do
+ expect(subject.result.name).to eq "My Storage"
end
- it 'keeps its creator' do
+ it "keeps its creator" do
expect(subject.result.creator).not_to eq current_user
end
end
- context 'with params' do
+ context "with params" do
let(:params) do
{
- name: 'Foobar',
- provider_type: 'foo provider'
+ name: "Foobar",
+ provider_type: "foo provider"
}
end
@@ -123,16 +123,16 @@
subject
end
- it 'assigns the params' do
- expect(model_instance.name).to eq 'Foobar'
- expect(model_instance.provider_type).to eq 'foo provider'
+ it "assigns the params" do
+ expect(model_instance.name).to eq "Foobar"
+ expect(model_instance.provider_type).to eq "foo provider"
end
end
- context 'with an invalid contract' do
+ context "with an invalid contract" do
let(:contract_valid) { false }
- it 'returns failure' do
+ it "returns failure" do
expect(subject).not_to be_success
end
@@ -142,10 +142,10 @@
end
end
- describe 'automatically managed project folders' do
+ describe "automatically managed project folders" do
let(:model_instance) { build_stubbed(:nextcloud_storage) }
- context 'with password' do
+ context "with password" do
let(:params) do
super().merge(
"automatically_managed" => true,
@@ -153,33 +153,33 @@
)
end
- it 'enables automatic folder management with password' do
- expect(subject.result).to have_attributes(automatically_managed: true, username: 'OpenProject',
- password: 'secret')
+ it "enables automatic folder management with password" do
+ expect(subject.result).to have_attributes(automatically_managed: true, username: "OpenProject",
+ password: "secret")
end
end
- context 'with automatically_managed false' do
+ context "with automatically_managed false" do
let(:params) do
super().merge(
"automatically_managed" => false
)
end
- it 'disables automatic folder management' do
+ it "disables automatic folder management" do
expect(subject.result).to have_attributes(automatically_managed: false)
expect(subject.result.attributes.keys).not_to include(:username, :password)
end
end
- context 'with automatically_managed nil' do
+ context "with automatically_managed nil" do
let(:params) do
super().merge(
"automatically_managed" => nil
)
end
- it 'does not change the value' do
+ it "does not change the value" do
expect(subject.result).to have_attributes(automatically_managed: nil)
expect(subject.result.attributes.keys).not_to include(:username, :password)
end
diff --git a/modules/storages/spec/services/storages/storages/set_provider_fields_attributes_service_spec.rb b/modules/storages/spec/services/storages/storages/set_provider_fields_attributes_service_spec.rb
index 94ee6d974605..dabd89e4bff6 100644
--- a/modules/storages/spec/services/storages/storages/set_provider_fields_attributes_service_spec.rb
+++ b/modules/storages/spec/services/storages/storages/set_provider_fields_attributes_service_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::Storages::SetProviderFieldsAttributesService, type: :model do
@@ -42,59 +42,59 @@
before { allow(storage).to receive(:valid?).and_return(true) }
- context 'when automatically_managed is not set' do
+ context "when automatically_managed is not set" do
let(:storage) { build(:nextcloud_storage, provider_fields: {}) }
- it 'sets automatically_managed to true' do
+ it "sets automatically_managed to true" do
expect { provider_fields_attributes_service }
- .to change(storage, :provider_fields).from({}).to({ 'automatically_managed' => true })
+ .to change(storage, :provider_fields).from({}).to({ "automatically_managed" => true })
- aggregate_failures 'returns the storage model object as the result' do
+ aggregate_failures "returns the storage model object as the result" do
expect(provider_fields_attributes_service.result).to eq(storage)
end
- aggregate_failures 'is valid contract' do
+ aggregate_failures "is valid contract" do
expect(provider_fields_attributes_service).to be_a_success
end
end
end
- context 'when automatically_managed is already set as true' do
+ context "when automatically_managed is already set as true" do
let(:storage) { build(:nextcloud_storage, :as_automatically_managed) }
- it 'retains the set value, does not change the object' do
+ it "retains the set value, does not change the object" do
expect { provider_fields_attributes_service }.not_to change(storage, :provider_fields)
expect(provider_fields_attributes_service.result.automatically_managed).to be(true)
- aggregate_failures 'returns the storage model object as the result' do
+ aggregate_failures "returns the storage model object as the result" do
expect(provider_fields_attributes_service.result).to eq(storage)
end
- aggregate_failures 'is valid contract' do
+ aggregate_failures "is valid contract" do
expect(provider_fields_attributes_service).to be_a_success
end
end
end
- context 'when automatically_managed is set as false' do
+ context "when automatically_managed is set as false" do
let(:storage) { build(:nextcloud_storage, :as_not_automatically_managed) }
- it 'retains the set value, does not change the object' do
+ it "retains the set value, does not change the object" do
expect { provider_fields_attributes_service }.not_to change(storage, :provider_fields)
expect(provider_fields_attributes_service.result.automatically_managed).to be(false)
- aggregate_failures 'returns the storage model object as the result' do
+ aggregate_failures "returns the storage model object as the result" do
expect(provider_fields_attributes_service.result).to eq(storage)
end
- aggregate_failures 'is valid contract' do
+ aggregate_failures "is valid contract" do
expect(provider_fields_attributes_service).to be_a_success
end
end
end
def stub_valid_contract(contract_class)
- contract_errors = instance_double(ActiveModel::Errors, 'contract_errors')
+ contract_errors = instance_double(ActiveModel::Errors, "contract_errors")
contract_valid = true
contract_instance = stub_contract_instance(contract_class, contract_valid, contract_errors)
allow(contract_class).to receive(:new).and_return(contract_instance)
@@ -103,7 +103,7 @@ def stub_valid_contract(contract_class)
end
def stub_contract_instance(contract_class, contract_valid, contract_errors)
- contract_instance = instance_double(contract_class, 'contract_instance')
+ contract_instance = instance_double(contract_class, "contract_instance")
allow(contract_instance).to receive_messages(validate: contract_valid, errors: contract_errors)
contract_instance
end
diff --git a/modules/storages/spec/services/storages/storages/update_service_spec.rb b/modules/storages/spec/services/storages/storages/update_service_spec.rb
index 3ecfb18d2f2b..9982c41ec300 100644
--- a/modules/storages/spec/services/storages/storages/update_service_spec.rb
+++ b/modules/storages/spec/services/storages/storages/update_service_spec.rb
@@ -28,13 +28,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require 'services/base_services/behaves_like_update_service'
+require "services/base_services/behaves_like_update_service"
RSpec.describe Storages::Storages::UpdateService, type: :model do
- it_behaves_like 'BaseServices update service' do
+ it_behaves_like "BaseServices update service" do
let(:factory) { :nextcloud_storage }
let!(:user) { create(:admin) }
@@ -46,16 +46,16 @@
let(:call_attributes) do
{
- name: 'My updated storage',
- host: 'https://new.example.org'
+ name: "My updated storage",
+ host: "https://new.example.org"
}
end
let!(:model_instance) do
build_stubbed(factory,
creator: user,
- name: 'My updated storage',
- host: 'https://updated.example.org')
+ name: "My updated storage",
+ host: "https://updated.example.org")
end
let!(:oauth_application) { create(:oauth_application, integration: model_instance) }
@@ -63,12 +63,12 @@
it "creates an OAuth application (::Doorkeeper::Application)" do
expect(subject).to be_success
expect(subject.result.oauth_application).to be_a(Doorkeeper::Application)
- expect(subject.result.oauth_application.name).to include 'My updated storage'
- expect(subject.result.oauth_application.redirect_uri).to include 'https://updated.example.org'
+ expect(subject.result.oauth_application.name).to include "My updated storage"
+ expect(subject.result.oauth_application.redirect_uri).to include "https://updated.example.org"
end
end
- it 'cannot update storage creator' do
+ it "cannot update storage creator" do
storage_creator = create(:admin, login: "storage_creator")
storage = create(:nextcloud_storage, creator: storage_creator)
service = described_class.new(user: create(:admin),
@@ -81,11 +81,11 @@
expect(storage.reload.creator).to eq(storage_creator)
end
- describe 'updates the nested OAuth application' do
+ describe "updates the nested OAuth application" do
let(:storage) { create(:nextcloud_storage) }
let!(:oauth_application) { create(:oauth_application, integration: storage) }
let(:user) { create(:admin) }
- let(:name) { 'Awesome Storage' }
+ let(:name) { "Awesome Storage" }
subject do
described_class
@@ -93,7 +93,7 @@
.call({ name: })
end
- it 'must update the name of the OAuth application' do
+ it "must update the name of the OAuth application" do
expect(subject.result.oauth_application.name).to eq("Awesome Storage (Nextcloud)")
end
end
diff --git a/modules/storages/spec/spec_helper.rb b/modules/storages/spec/spec_helper.rb
index dea4304f0878..73dc77606672 100644
--- a/modules/storages/spec/spec_helper.rb
+++ b/modules/storages/spec/spec_helper.rb
@@ -33,22 +33,22 @@
# Loads spec_helper from OpenProject core
# This will include any support file from OpenProject core
-require 'spec_helper'
-require 'dry/container/stub'
+require "spec_helper"
+require "dry/container/stub"
# Record Storages Cassettes in module
VCR.configure do |config|
- config.cassette_library_dir = 'modules/storages/spec/support/fixtures/vcr_cassettes'
- config.filter_sensitive_data('') do
- ENV.fetch('ONE_DRIVE_TEST_OAUTH_CLIENT_ACCESS_TOKEN', 'MISSING_ONE_DRIVE_TEST_OAUTH_CLIENT_ACCESS_TOKEN')
+ config.cassette_library_dir = "modules/storages/spec/support/fixtures/vcr_cassettes"
+ config.filter_sensitive_data("") do
+ ENV.fetch("ONE_DRIVE_TEST_OAUTH_CLIENT_ACCESS_TOKEN", "MISSING_ONE_DRIVE_TEST_OAUTH_CLIENT_ACCESS_TOKEN")
end
- config.filter_sensitive_data('') do
- ENV.fetch('NEXTCLOUD_LOCAL_OAUTH_CLIENT_ACCESS_TOKEN', 'MISSING_NEXTCLOUD_LOCAL_OAUTH_CLIENT_ACCESS_TOKEN')
+ config.filter_sensitive_data("") do
+ ENV.fetch("NEXTCLOUD_LOCAL_OAUTH_CLIENT_ACCESS_TOKEN", "MISSING_NEXTCLOUD_LOCAL_OAUTH_CLIENT_ACCESS_TOKEN")
end
end
# Loads files from relative support/ directory
-Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].each { |f| require f }
+Dir[File.join(File.dirname(__FILE__), "support/**/*.rb")].each { |f| require f }
RSpec.configure do |config|
config.prepend_before { Storages::Peripherals::Registry.enable_stubs! }
diff --git a/modules/storages/spec/support/components/file_picker_dialog.rb b/modules/storages/spec/support/components/file_picker_dialog.rb
index 507ed9e6d92b..cfb0bbbefc0e 100644
--- a/modules/storages/spec/support/components/file_picker_dialog.rb
+++ b/modules/storages/spec/support/components/file_picker_dialog.rb
@@ -45,10 +45,10 @@ def confirm_button_state(selection_count:)
case selection_count
when 0
expect(page).to have_button(disabled: true,
- exact_text: I18n.t('js.storages.file_links.selection.zero'))
+ exact_text: I18n.t("js.storages.file_links.selection.zero"))
else
expect(page).to have_button(disabled: false,
- exact_text: I18n.t('js.storages.file_links.selection', count: selection_count))
+ exact_text: I18n.t("js.storages.file_links.selection", count: selection_count))
end
end
end
@@ -74,7 +74,7 @@ def select_file(text)
def has_list_item?(text:, checked:, disabled:)
page.within(container) do
expect(page.find('[data-test-selector="op-files-picker-modal--list-item"]', text:))
- .to have_field(type: 'checkbox', checked:, disabled:)
+ .to have_field(type: "checkbox", checked:, disabled:)
end
end
@@ -92,17 +92,17 @@ def select_all
end
end
- def use_breadcrumb(position: 'root' | 'grandparent' | 'parent')
+ def use_breadcrumb(position: "root" | "grandparent" | "parent")
page.within(container) do
crumbs = page.all('[data-test-selector="op-breadcrumb"]')
case position
- when 'root'
+ when "root"
expect(crumbs.size).to be > 1
crumbs[0].click
- when 'parent'
+ when "parent"
expect(crumbs.size).to be > 2
crumbs[-2].click
- when 'grandparent'
+ when "grandparent"
expect(crumbs.size).to be > 3
crumbs[-3].click
end
diff --git a/modules/storages/spec/support/ensure_connection_path_helper.rb b/modules/storages/spec/support/ensure_connection_path_helper.rb
index 58d1baecda45..ee5a63ff5f85 100644
--- a/modules/storages/spec/support/ensure_connection_path_helper.rb
+++ b/modules/storages/spec/support/ensure_connection_path_helper.rb
@@ -35,7 +35,7 @@ def ensure_connection_path(project_storage)
oauth_client_id: project_storage.storage.oauth_client.client_id,
storage_id: project_storage.storage.id,
destination_url: url_helpers.open_project_storage_url(
- protocol: 'https',
+ protocol: "https",
project_id: project_storage.project.identifier,
id: project_storage.id
)
diff --git a/modules/storages/spec/support/json_response_helper.rb b/modules/storages/spec/support/json_response_helper.rb
index 20a0dbf8bf56..c83f67794f20 100644
--- a/modules/storages/spec/support/json_response_helper.rb
+++ b/modules/storages/spec/support/json_response_helper.rb
@@ -36,18 +36,18 @@ def read_json(name)
private
def payload_path
- Pathname.new(Rails.root).join('modules/storages/spec/support/payloads/')
+ Pathname.new(Rails.root).join("modules/storages/spec/support/payloads/")
end
def not_found_response
{
error: {
- code: 'itemNotFound',
- message: 'The resource could not be found.',
+ code: "itemNotFound",
+ message: "The resource could not be found.",
innerError: {
- date: '2023-09-08T08:20:55',
- 'request-id': '286b0215-7f33-46dc-b1fe-67720fe1616a',
- 'client-request-id': '286b0215-7f33-46dc-b1fe-67720fe1616a'
+ date: "2023-09-08T08:20:55",
+ "request-id": "286b0215-7f33-46dc-b1fe-67720fe1616a",
+ "client-request-id": "286b0215-7f33-46dc-b1fe-67720fe1616a"
}
}
}.to_json
@@ -56,12 +56,12 @@ def not_found_response
def forbidden_response
{
error: {
- code: 'accessDenied',
- message: 'Access denied',
+ code: "accessDenied",
+ message: "Access denied",
innerError: {
- date: '2023-09-08T08:20:55',
- 'request-id': '286b0215-7f33-46dc-b1fe-67720fe1616f',
- 'client-request-id': '286b0215-7f33-46dc-b1fe-67720fe1616b'
+ date: "2023-09-08T08:20:55",
+ "request-id": "286b0215-7f33-46dc-b1fe-67720fe1616f",
+ "client-request-id": "286b0215-7f33-46dc-b1fe-67720fe1616b"
}
}
}.to_json
diff --git a/modules/storages/spec/support/storage_server_helpers.rb b/modules/storages/spec/support/storage_server_helpers.rb
index 33d5d91c314d..2074e627f1ce 100644
--- a/modules/storages/spec/support/storage_server_helpers.rb
+++ b/modules/storages/spec/support/storage_server_helpers.rb
@@ -35,7 +35,7 @@ def mock_server_capabilities_response(nextcloud_host,
response_nextcloud_major_version: 22)
response_code ||= 200
response_headers ||= {
- 'Content-Type' => 'application/json; charset=utf-8'
+ "Content-Type" => "application/json; charset=utf-8"
}
response_body ||=
%{
@@ -56,7 +56,7 @@ def mock_server_capabilities_response(nextcloud_host,
}
stub = stub_request(
:get,
- File.join(nextcloud_host, '/ocs/v2.php/cloud/capabilities')
+ File.join(nextcloud_host, "/ocs/v2.php/cloud/capabilities")
)
if timeout
stub.to_timeout
@@ -76,7 +76,7 @@ def mock_server_config_check_response(nextcloud_host,
response_body: nil)
response_code ||= 200
response_headers ||= {
- 'Content-Type' => 'application/json; charset=utf-8'
+ "Content-Type" => "application/json; charset=utf-8"
}
response_body ||=
@@ -88,7 +88,7 @@ def mock_server_config_check_response(nextcloud_host,
}
stub = stub_request(
:get,
- File.join(nextcloud_host, 'index.php/apps/integration_openproject/check-config')
+ File.join(nextcloud_host, "index.php/apps/integration_openproject/check-config")
)
if timeout
stub.to_timeout
@@ -102,21 +102,21 @@ def mock_server_config_check_response(nextcloud_host,
end
def mock_nextcloud_application_credentials_validation(nextcloud_host,
- username: 'OpenProject',
- password: 'Password123',
+ username: "OpenProject",
+ password: "Password123",
timeout: false,
response_code: nil,
response_headers: nil,
response_body: nil)
response_code ||= 200
response_headers ||= {
- 'Content-Type' => 'text/html; charset=UTF-8',
- 'Authorization' => "Basic #{Base64::strict_encode64("#{username}:#{password}")}"
+ "Content-Type" => "text/html; charset=UTF-8",
+ "Authorization" => "Basic #{Base64::strict_encode64("#{username}:#{password}")}"
}
stub = stub_request(
:head,
- File.join(nextcloud_host, 'remote.php/dav')
+ File.join(nextcloud_host, "remote.php/dav")
)
if timeout
stub.to_timeout
diff --git a/modules/storages/spec/support/user_permissions_helper.rb b/modules/storages/spec/support/user_permissions_helper.rb
index 0a1ed24d3757..3626323d1213 100644
--- a/modules/storages/spec/support/user_permissions_helper.rb
+++ b/modules/storages/spec/support/user_permissions_helper.rb
@@ -30,13 +30,13 @@
module UserPermissionsHelper
def add_permissions(user, *)
- role = Role.joins(members: :principal).where('users.id': user).first
+ role = Role.joins(members: :principal).where("users.id": user).first
role.add_permission!(*)
user.reload # clear user's project_role_cache
end
def remove_permissions(user, *)
- role = Role.joins(members: :principal).where('users.id': user).first
+ role = Role.joins(members: :principal).where("users.id": user).first
role.remove_permission!(*)
user.reload # clear user's project_role_cache
end
diff --git a/modules/storages/spec/workers/storages/cleanup_uncontainered_file_links_job_spec.rb b/modules/storages/spec/workers/storages/cleanup_uncontainered_file_links_job_spec.rb
index 5ae9c52fac30..f60f3286a663 100644
--- a/modules/storages/spec/workers/storages/cleanup_uncontainered_file_links_job_spec.rb
+++ b/modules/storages/spec/workers/storages/cleanup_uncontainered_file_links_job_spec.rb
@@ -28,12 +28,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::CleanupUncontaineredFileLinksJob, type: :job do
- describe '#perform' do
- it 'removes uncontainered file_links which are old enough' do
+ describe "#perform" do
+ it "removes uncontainered file_links which are old enough" do
grace_period = 10
allow(OpenProject::Configuration)
.to receive(:attachments_grace_period)
diff --git a/modules/storages/spec/workers/storages/manage_nextcloud_integration_job_spec.rb b/modules/storages/spec/workers/storages/manage_nextcloud_integration_job_spec.rb
index 304280583485..7e150dbed67a 100644
--- a/modules/storages/spec/workers/storages/manage_nextcloud_integration_job_spec.rb
+++ b/modules/storages/spec/workers/storages/manage_nextcloud_integration_job_spec.rb
@@ -28,15 +28,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
RSpec.describe Storages::ManageNextcloudIntegrationJob, :webmock, type: :job do
- describe '.debounce' do
- context 'when has been debounced by other thread' do
+ describe ".debounce" do
+ context "when has been debounced by other thread" do
before { ActiveJob::Base.disable_test_adapter }
- it 'does not change the number of enqueued jobs' do
+ it "does not change the number of enqueued jobs" do
expect(GoodJob::Job.count).to eq(0)
expect(described_class.perform_later.successfully_enqueued?).to be(true)
expect(described_class.perform_later).to be(false)
@@ -46,12 +46,12 @@
end
end
- context 'when has not been debounced by other thread' do
- it 'schedules a job' do
+ context "when has not been debounced by other thread" do
+ it "schedules a job" do
expect { described_class.debounce }.to change(enqueued_jobs, :count).from(0).to(1)
end
- it 'tries to schedule once when called 1000 times in a short period of time' do
+ it "tries to schedule once when called 1000 times in a short period of time" do
expect_any_instance_of(ActiveJob::ConfiguredJob)
.to receive(:perform_later).once.and_call_original
@@ -62,16 +62,16 @@
end
end
- describe '.disable_cron_job_if_needed' do
+ describe ".disable_cron_job_if_needed" do
before { ActiveJob::Base.disable_test_adapter }
subject { described_class.disable_cron_job_if_needed }
- context 'when there is an active nextcloud project storage' do
+ context "when there is an active nextcloud project storage" do
shared_let(:storage1) { create(:nextcloud_storage, :as_automatically_managed) }
shared_let(:project_storage) { create(:project_storage, :as_automatically_managed, storage: storage1) }
- it 'enables the cron_job if was disabled before' do
+ it "enables the cron_job if was disabled before" do
GoodJob::Setting.cron_key_disable(described_class::CRON_JOB_KEY)
good_job_setting = GoodJob::Setting.first
@@ -85,7 +85,7 @@
expect(good_job_setting.value).to eq([])
end
- it 'does nothing if the cron_job is not disabled' do
+ it "does nothing if the cron_job is not disabled" do
expect(GoodJob::Setting.cron_key_enabled?(described_class::CRON_JOB_KEY)).to be(true)
expect { subject }.not_to change(GoodJob::Setting, :count).from(0)
@@ -94,8 +94,8 @@
end
end
- context 'when there is no active nextcloud project storage' do
- it 'disables the cron job' do
+ context "when there is no active nextcloud project storage" do
+ it "disables the cron job" do
expect { subject }.to change(GoodJob::Setting, :count).from(0).to(1)
good_job_setting = GoodJob::Setting.first
@@ -105,12 +105,12 @@
end
end
- describe '.perform' do
+ describe ".perform" do
let(:storage1) { create(:nextcloud_storage_configured, :as_automatically_managed) }
subject { described_class.new.perform }
- it 'calls NextcloudGroupFolderPropertiesSyncService for each automatically managed storage' do
+ it "calls NextcloudGroupFolderPropertiesSyncService for each automatically managed storage" do
storage2 = create(:nextcloud_storage, :as_not_automatically_managed)
storage3 = create(:nextcloud_storage, :as_automatically_managed)
@@ -124,35 +124,35 @@
expect(Storages::NextcloudGroupFolderPropertiesSyncService).not_to have_received(:call).with(storage3)
end
- it 'marks storage as healthy if sync was successful' do
+ it "marks storage as healthy if sync was successful" do
allow(Storages::NextcloudGroupFolderPropertiesSyncService)
.to receive(:call).with(storage1).and_return(ServiceResult.success)
- Timecop.freeze('2023-03-14T15:17:00Z') do
+ Timecop.freeze("2023-03-14T15:17:00Z") do
expect do
subject
storage1.reload
end.to(
change(storage1, :health_changed_at).to(Time.now.utc)
- .and(change(storage1, :health_status).from('pending').to('healthy'))
+ .and(change(storage1, :health_status).from("pending").to("healthy"))
)
end
end
- it 'marks storage as unhealthy if sync was unsuccessful' do
+ it "marks storage as unhealthy if sync was unsuccessful" do
allow(Storages::NextcloudGroupFolderPropertiesSyncService)
.to receive(:call)
.with(storage1)
.and_return(ServiceResult.failure(errors: Storages::StorageError.new(code: :not_found)))
- Timecop.freeze('2023-03-14T15:17:00Z') do
+ Timecop.freeze("2023-03-14T15:17:00Z") do
expect do
subject
storage1.reload
end.to(
change(storage1, :health_changed_at).to(Time.now.utc)
- .and(change(storage1, :health_status).from('pending').to('unhealthy'))
- .and(change(storage1, :health_reason).from(nil).to('not_found'))
+ .and(change(storage1, :health_status).from("pending").to("unhealthy"))
+ .and(change(storage1, :health_reason).from(nil).to("not_found"))
)
end
end
diff --git a/modules/team_planner/app/components/team_planner/add_button_component.rb b/modules/team_planner/app/components/team_planner/add_button_component.rb
index 3804d9a6f83b..a824a55a6546 100644
--- a/modules/team_planner/app/components/team_planner/add_button_component.rb
+++ b/modules/team_planner/app/components/team_planner/add_button_component.rb
@@ -44,15 +44,15 @@ def dynamic_path
end
def id
- 'add-team-planner-button'
+ "add-team-planner-button"
end
def accessibility_label_text
- I18n.t('team_planner.label_create_new_team_planner')
+ I18n.t("team_planner.label_create_new_team_planner")
end
def label_text
- t(:'team_planner.label_team_planner')
+ t(:"team_planner.label_team_planner")
end
end
end
diff --git a/modules/team_planner/app/components/team_planner/overview/table_component.rb b/modules/team_planner/app/components/team_planner/overview/table_component.rb
index 8a6858511fd7..f6fce2c8575d 100644
--- a/modules/team_planner/app/components/team_planner/overview/table_component.rb
+++ b/modules/team_planner/app/components/team_planner/overview/table_component.rb
@@ -34,13 +34,13 @@ class TableComponent < ::TableComponent
sortable_columns :name, :project_name, :created_at
def initial_sort_correlation
- ['queries.name', 'asc']
+ ["queries.name", "asc"]
end
def sortable_columns_correlation
- super.merge(name: 'queries.name',
- project_name: 'projects.name',
- created_at: 'queries.created_at')
+ super.merge(name: "queries.name",
+ project_name: "projects.name",
+ created_at: "queries.created_at")
end
def paginated?
diff --git a/modules/team_planner/app/components/team_planner/row_component.rb b/modules/team_planner/app/components/team_planner/row_component.rb
index c9d625b672bb..4294462b31c0 100644
--- a/modules/team_planner/app/components/team_planner/row_component.rb
+++ b/modules/team_planner/app/components/team_planner/row_component.rb
@@ -56,13 +56,13 @@ def button_links
def delete_link
if table.current_user.allowed_in_project?(:manage_team_planner, project)
link_to(
- '',
+ "",
project_team_planner_path(project, query.id),
- class: 'spot-link icon icon-delete',
+ class: "spot-link icon icon-delete",
method: :delete,
data: {
confirm: I18n.t(:text_are_you_sure),
- 'test-selector': "team-planner-remove-#{query.id}"
+ "test-selector": "team-planner-remove-#{query.id}"
},
title: t(:button_delete)
)
diff --git a/modules/team_planner/app/components/team_planner/table_component.rb b/modules/team_planner/app/components/team_planner/table_component.rb
index d7b4df5e462c..42b6277934ff 100644
--- a/modules/team_planner/app/components/team_planner/table_component.rb
+++ b/modules/team_planner/app/components/team_planner/table_component.rb
@@ -37,9 +37,9 @@ def sortable?
def headers
[
- ['name', { caption: I18n.t(:label_name) }],
- ['assignees', { caption: I18n.t('team_planner.label_assignees') }],
- ['created_at', { caption: I18n.t('attributes.created_at') }]
+ ["name", { caption: I18n.t(:label_name) }],
+ ["assignees", { caption: I18n.t("team_planner.label_assignees") }],
+ ["created_at", { caption: I18n.t("attributes.created_at") }]
]
end
end
diff --git a/modules/team_planner/app/controllers/team_planner/team_planner_controller.rb b/modules/team_planner/app/controllers/team_planner/team_planner_controller.rb
index c4ff4690694d..aecacbec217b 100644
--- a/modules/team_planner/app/controllers/team_planner/team_planner_controller.rb
+++ b/modules/team_planner/app/controllers/team_planner/team_planner_controller.rb
@@ -17,7 +17,7 @@ def index
def overview
@views = visible_plans
- render layout: 'global'
+ render layout: "global"
end
def new; end
@@ -37,7 +37,7 @@ def create
end
def show
- render layout: 'angular/angular'
+ render layout: "angular/angular"
end
def upsale; end
@@ -94,11 +94,11 @@ def visible_plans(project = nil)
.includes(:project)
.joins(:views)
.references(:projects)
- .where('views.type' => 'team_planner')
- .order('queries.name ASC')
+ .where("views.type" => "team_planner")
+ .order("queries.name ASC")
if project
- query = query.where('queries.project_id' => project.id)
+ query = query.where("queries.project_id" => project.id)
else
allowed_projects = Project.allowed_to(User.current, :view_team_planner)
query = query.where(queries: { project: allowed_projects })
diff --git a/modules/team_planner/app/services/team_planner/views/global_create_service.rb b/modules/team_planner/app/services/team_planner/views/global_create_service.rb
index d099700ca30c..8c43fdd47194 100644
--- a/modules/team_planner/app/services/team_planner/views/global_create_service.rb
+++ b/modules/team_planner/app/services/team_planner/views/global_create_service.rb
@@ -34,7 +34,7 @@ class GlobalCreateService < ::Views::GlobalCreateService
private
def view_type
- 'team_planner'
+ "team_planner"
end
end
end
diff --git a/modules/team_planner/config/routes.rb b/modules/team_planner/config/routes.rb
index 8922404f2b9f..2f694e154101 100644
--- a/modules/team_planner/config/routes.rb
+++ b/modules/team_planner/config/routes.rb
@@ -1,26 +1,26 @@
Rails.application.routes.draw do
resources :team_planners,
- controller: 'team_planner/team_planner',
+ controller: "team_planner/team_planner",
only: %i[create] do
collection do
- get '/', to: 'team_planner/team_planner#overview'
- get '/new', to: 'team_planner/team_planner#new'
- get '/upsale', to: 'team_planner/team_planner#upsale', as: :upsale
+ get "/", to: "team_planner/team_planner#overview"
+ get "/new", to: "team_planner/team_planner#new"
+ get "/upsale", to: "team_planner/team_planner#upsale", as: :upsale
end
end
- scope 'projects/:project_id', as: 'project' do
+ scope "projects/:project_id", as: "project" do
resources :team_planners,
- controller: 'team_planner/team_planner',
+ controller: "team_planner/team_planner",
only: %i[index destroy],
as: :team_planners do
collection do
- get '/upsale', to: 'team_planner/team_planner#upsale', as: :upsale
- get '/new', to: 'team_planner/team_planner#show', as: :new
+ get "/upsale", to: "team_planner/team_planner#upsale", as: :upsale
+ get "/new", to: "team_planner/team_planner#show", as: :new
end
member do
- get '(/*state)' => 'team_planner/team_planner#show', as: ''
+ get "(/*state)" => "team_planner/team_planner#show", as: ""
end
end
end
diff --git a/modules/team_planner/lib/open_project/team_planner.rb b/modules/team_planner/lib/open_project/team_planner.rb
index 693b37db10e3..d84f5da7e26a 100644
--- a/modules/team_planner/lib/open_project/team_planner.rb
+++ b/modules/team_planner/lib/open_project/team_planner.rb
@@ -28,6 +28,6 @@
module OpenProject
module TeamPlanner
- require 'open_project/team_planner/engine'
+ require "open_project/team_planner/engine"
end
end
diff --git a/modules/team_planner/lib/open_project/team_planner/engine.rb b/modules/team_planner/lib/open_project/team_planner/engine.rb
index ede95f00f612..c60fdf5fbc57 100644
--- a/modules/team_planner/lib/open_project/team_planner/engine.rb
+++ b/modules/team_planner/lib/open_project/team_planner/engine.rb
@@ -32,18 +32,18 @@ class Engine < ::Rails::Engine
include OpenProject::Plugins::ActsAsOpEngine
- register 'openproject-team_planner',
- author_url: 'https://www.openproject.org',
+ register "openproject-team_planner",
+ author_url: "https://www.openproject.org",
bundled: true,
settings: {} do
project_module :team_planner_view, dependencies: :work_package_tracking, enterprise_feature: true do
permission :view_team_planner,
- { 'team_planner/team_planner': %i[index show upsale overview] },
+ { "team_planner/team_planner": %i[index show upsale overview] },
permissible_on: :project,
dependencies: %i[view_work_packages],
contract_actions: { team_planner: %i[read] }
permission :manage_team_planner,
- { 'team_planner/team_planner': %i[index show new create destroy upsale] },
+ { "team_planner/team_planner": %i[index show new create destroy upsale] },
permissible_on: :project,
dependencies: %i[view_team_planner
add_work_packages
@@ -60,42 +60,42 @@ class Engine < ::Rails::Engine
menu :global_menu,
:team_planners,
- { controller: '/team_planner/team_planner', action: :overview },
- caption: :'team_planner.label_team_planner_plural',
+ { controller: "/team_planner/team_planner", action: :overview },
+ caption: :"team_planner.label_team_planner_plural",
before: :boards,
after: :calendar_view,
- icon: 'team-planner',
+ icon: "team-planner",
if: should_render_global_menu_item,
- enterprise_feature: 'team_planner_view'
+ enterprise_feature: "team_planner_view"
menu :project_menu,
:team_planner_view,
- { controller: '/team_planner/team_planner', action: :index },
- caption: :'team_planner.label_team_planner_plural',
+ { controller: "/team_planner/team_planner", action: :index },
+ caption: :"team_planner.label_team_planner_plural",
after: :work_packages,
- icon: 'team-planner',
- enterprise_feature: 'team_planner_view'
+ icon: "team-planner",
+ enterprise_feature: "team_planner_view"
menu :project_menu,
:team_planner_menu,
- { controller: '/team_planner/team_planner', action: :index },
+ { controller: "/team_planner/team_planner", action: :index },
parent: :team_planner_view,
- partial: 'team_planner/team_planner/menu',
+ partial: "team_planner/team_planner/menu",
last: true,
- caption: :'team_planner.label_team_planner_plural'
+ caption: :"team_planner.label_team_planner_plural"
menu :top_menu,
- :team_planners, { controller: '/team_planner/team_planner', action: :overview },
+ :team_planners, { controller: "/team_planner/team_planner", action: :overview },
context: :modules,
- caption: :'team_planner.label_team_planner_plural',
+ caption: :"team_planner.label_team_planner_plural",
before: :boards,
after: :calendar_view,
- icon: 'team-planner',
+ icon: "team-planner",
if: should_render_global_menu_item,
- enterprise_feature: 'team_planner_view'
+ enterprise_feature: "team_planner_view"
end
add_view :TeamPlanner,
- contract_strategy: 'TeamPlanner::Views::ContractStrategy'
+ contract_strategy: "TeamPlanner::Views::ContractStrategy"
end
end
diff --git a/modules/team_planner/lib/openproject-team_planner.rb b/modules/team_planner/lib/openproject-team_planner.rb
index 1a33de790065..3da00db4f605 100644
--- a/modules/team_planner/lib/openproject-team_planner.rb
+++ b/modules/team_planner/lib/openproject-team_planner.rb
@@ -1 +1 @@
-require 'open_project/team_planner'
+require "open_project/team_planner"
diff --git a/modules/team_planner/openproject-team_planner.gemspec b/modules/team_planner/openproject-team_planner.gemspec
index edb46f1e78fc..41eef6c2fbe8 100644
--- a/modules/team_planner/openproject-team_planner.gemspec
+++ b/modules/team_planner/openproject-team_planner.gemspec
@@ -1,12 +1,12 @@
Gem::Specification.new do |s|
- s.name = 'openproject-team_planner'
- s.version = '1.0.0'
- s.authors = 'OpenProject GmbH'
- s.email = 'info@openproject.com'
- s.summary = 'OpenProject Team Planner'
- s.description = 'Provides team planner views'
- s.license = 'GPLv3'
+ s.name = "openproject-team_planner"
+ s.version = "1.0.0"
+ s.authors = "OpenProject GmbH"
+ s.email = "info@openproject.com"
+ s.summary = "OpenProject Team Planner"
+ s.description = "Provides team planner views"
+ s.license = "GPLv3"
- s.files = Dir['{app,config,db,lib}/**/*']
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.files = Dir["{app,config,db,lib}/**/*"]
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/team_planner/spec/contracts/views/create_contract_team_planner_spec.rb b/modules/team_planner/spec/contracts/views/create_contract_team_planner_spec.rb
index 1cabdc8f6244..2d17f3bd81ea 100644
--- a/modules/team_planner/spec/contracts/views/create_contract_team_planner_spec.rb
+++ b/modules/team_planner/spec/contracts/views/create_contract_team_planner_spec.rb
@@ -26,18 +26,18 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
-require 'contracts/views/shared_contract_examples'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
+require "contracts/views/shared_contract_examples"
RSpec.describe Views::CreateContract do
- it_behaves_like 'view contract', true do
+ it_behaves_like "view contract", true do
let(:view) do
View.new(query: view_query,
type: view_type)
end
let(:view_type) do
- 'team_planner'
+ "team_planner"
end
let(:permissions) { %i[view_work_packages save_queries manage_team_planner] }
@@ -45,23 +45,23 @@
described_class.new(view, current_user)
end
- describe 'validation' do
- context 'with the type being nil' do
+ describe "validation" do
+ context "with the type being nil" do
let(:view_type) { nil }
- it_behaves_like 'contract is invalid', type: :inclusion
+ it_behaves_like "contract is invalid", type: :inclusion
end
- context 'with the type not being one of the configured' do
- let(:view_type) { 'blubs' }
+ context "with the type not being one of the configured" do
+ let(:view_type) { "blubs" }
- it_behaves_like 'contract is invalid', type: :inclusion
+ it_behaves_like "contract is invalid", type: :inclusion
end
- context 'without the :manage_team_planner permission' do
+ context "without the :manage_team_planner permission" do
let(:permissions) { %i[view_work_packages save_queries] }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
end
end
diff --git a/modules/team_planner/spec/features/onboarding/team_planner_onboarding_tour_spec.rb b/modules/team_planner/spec/features/onboarding/team_planner_onboarding_tour_spec.rb
index 5f3359d9822f..d01ce86a0338 100644
--- a/modules/team_planner/spec/features/onboarding/team_planner_onboarding_tour_spec.rb
+++ b/modules/team_planner/spec/features/onboarding/team_planner_onboarding_tour_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../../support/onboarding/onboarding_steps'
+require "spec_helper"
+require_relative "../../support/onboarding/onboarding_steps"
-RSpec.describe 'team planner onboarding tour',
+RSpec.describe "team planner onboarding tour",
:js,
with_cuprite: false,
with_ee: %i[team_planner_view],
@@ -37,12 +37,12 @@
# of the JS code rely on something triggering the Angular change detection.
# This is usually done by the notification polling, but we don't want to wait
with_settings: { notifications_polling_interval: 1_000 } do
- let(:next_button) { find('.enjoyhint_next_btn') }
+ let(:next_button) { find(".enjoyhint_next_btn") }
let(:demo_project) do
create(:project,
- name: 'Demo project',
- identifier: 'demo-project',
+ name: "Demo project",
+ identifier: "demo-project",
public: true,
enabled_module_names: %w[work_package_tracking gantt wiki team_planner_view])
end
@@ -62,7 +62,7 @@
due_date: Time.zone.today)
end
- let(:query) { create(:query, user:, project: demo_project, public: true, name: 'Team planner') }
+ let(:query) { create(:query, user:, project: demo_project, public: true, name: "Team planner") }
let(:team_plan) do
create(:view_team_planner,
query:,
@@ -83,8 +83,8 @@
page.execute_script("window.sessionStorage.clear();")
end
- context 'as a new user' do
- it 'I see the team planner onboarding tour in the demo project' do
+ context "as a new user" do
+ it "I see the team planner onboarding tour in the demo project" do
# Set the tour parameter so that we can start on the wp page
visit "/projects/#{demo_project.identifier}/work_packages?start_onboarding_tour=true"
diff --git a/modules/team_planner/spec/features/query_handling_spec.rb b/modules/team_planner/spec/features/query_handling_spec.rb
index 6a9417c99e9e..7388ee6f9f8f 100644
--- a/modules/team_planner/spec/features/query_handling_spec.rb
+++ b/modules/team_planner/spec/features/query_handling_spec.rb
@@ -28,11 +28,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../support/pages/team_planner'
-require_relative '../../../../spec/features/views/shared_examples'
+require "spec_helper"
+require_relative "../support/pages/team_planner"
+require_relative "../../../../spec/features/views/shared_examples"
-RSpec.describe 'Team planner query handling', :js, with_ee: %i[team_planner_view] do
+RSpec.describe "Team planner query handling", :js, with_ee: %i[team_planner_view] do
shared_let(:type_task) { create(:type_task) }
shared_let(:type_bug) { create(:type_bug) }
shared_let(:project) do
@@ -60,7 +60,7 @@
assigned_to: user,
start_date: Time.zone.today - 1.day,
due_date: Time.zone.today + 1.day,
- subject: 'A task for the user')
+ subject: "A task for the user")
end
shared_let(:bug) do
create(:work_package,
@@ -69,7 +69,7 @@
assigned_to: user,
start_date: Time.zone.today - 1.day,
due_date: Time.zone.today + 1.day,
- subject: 'A bug for the user')
+ subject: "A bug for the user")
end
let(:team_planner) { Pages::TeamPlanner.new project }
@@ -92,11 +92,11 @@
end
end
- it 'allows saving the team planner' do
+ it "allows saving the team planner" do
filters.expect_filter_count("1")
filters.open
- filters.add_filter_by('Type', 'is (OR)', [type_bug.name])
+ filters.add_filter_by("Type", "is (OR)", [type_bug.name])
filters.expect_filter_count("2")
@@ -109,35 +109,35 @@
query_title.press_save_button
- team_planner.expect_and_dismiss_toaster(message: I18n.t('js.notice_successful_create'))
+ team_planner.expect_and_dismiss_toaster(message: I18n.t("js.notice_successful_create"))
end
- it 'shows only team planner queries' do
+ it "shows only team planner queries" do
# Go to team planner where no query is shown, only the create option
query_menu.expect_no_menu_entry
- expect(page).to have_test_selector('team-planner--create-button')
+ expect(page).to have_test_selector("team-planner--create-button")
# Change filter
filters.open
- filters.add_filter_by('Type', 'is (OR)', [type_bug.name])
+ filters.add_filter_by("Type", "is (OR)", [type_bug.name])
filters.expect_filter_count("2")
# Save current filters
query_title.expect_changed
- query_title.rename 'I am your Query'
- team_planner.expect_and_dismiss_toaster(message: I18n.t('js.notice_successful_create'))
+ query_title.rename "I am your Query"
+ team_planner.expect_and_dismiss_toaster(message: I18n.t("js.notice_successful_create"))
# The saved query appears in the side menu...
- query_menu.expect_menu_entry 'I am your Query'
+ query_menu.expect_menu_entry "I am your Query"
# .. but not in the work packages module
work_package_page.visit!
- query_menu.expect_menu_entry_not_visible 'I am your Query'
+ query_menu.expect_menu_entry_not_visible "I am your Query"
end
- it_behaves_like 'module specific query view management' do
+ it_behaves_like "module specific query view management" do
let(:module_page) { team_planner }
- let(:default_name) { 'Unnamed team planner' }
+ let(:default_name) { "Unnamed team planner" }
let(:initial_filter_count) { 1 }
end
end
diff --git a/modules/team_planner/spec/features/shared_context.rb b/modules/team_planner/spec/features/shared_context.rb
index bdb1ad3b363a..ba86b0b64b3d 100644
--- a/modules/team_planner/spec/features/shared_context.rb
+++ b/modules/team_planner/spec/features/shared_context.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../support/pages/team_planner'
+require "spec_helper"
+require_relative "../support/pages/team_planner"
-RSpec.shared_context 'with team planner full access' do
+RSpec.shared_context "with team planner full access" do
shared_let(:project) do
create(:project)
end
diff --git a/modules/team_planner/spec/features/team_planner_add_existing_work_packages_spec.rb b/modules/team_planner/spec/features/team_planner_add_existing_work_packages_spec.rb
index 38e6afc02a93..e7149f7aedd2 100644
--- a/modules/team_planner/spec/features/team_planner_add_existing_work_packages_spec.rb
+++ b/modules/team_planner/spec/features/team_planner_add_existing_work_packages_spec.rb
@@ -26,26 +26,26 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_context'
-require_relative '../support/components/add_existing_pane'
+require "spec_helper"
+require_relative "shared_context"
+require_relative "../support/components/add_existing_pane"
-RSpec.describe 'Team planner add existing work packages', :js do
- include_context 'with team planner full access'
+RSpec.describe "Team planner add existing work packages", :js do
+ include_context "with team planner full access"
let(:closed_status) { create(:status, is_closed: true) }
let(:start_of_week) { Time.zone.today.beginning_of_week(:sunday) }
let!(:other_user) do
create(:user,
- firstname: 'Bernd',
+ firstname: "Bernd",
member_with_permissions: { project => %w[view_work_packages view_team_planner] })
end
let!(:first_wp) do
create(:work_package,
project:,
- subject: 'Task 1',
+ subject: "Task 1",
assigned_to: user,
start_date: start_of_week.next_occurring(:tuesday),
due_date: start_of_week.next_occurring(:thursday))
@@ -53,7 +53,7 @@
let!(:second_wp) do
create(:work_package,
project:,
- subject: 'Task 2',
+ subject: "Task 2",
parent: first_wp,
assigned_to: other_user,
start_date: 10.days.from_now,
@@ -62,14 +62,14 @@
let!(:third_wp) do
create(:work_package,
project:,
- subject: 'TA Aufgabe 3',
+ subject: "TA Aufgabe 3",
status: closed_status)
end
let(:add_existing_pane) { Components::AddExistingPane.new }
let(:filters) { Components::WorkPackages::Filters.new }
- context 'with full permissions', with_ee: %i[team_planner_view] do
+ context "with full permissions", with_ee: %i[team_planner_view] do
before do
team_planner.visit!
@@ -86,17 +86,17 @@
add_existing_pane.expect_empty
end
- context 'with a removable item' do
+ context "with a removable item" do
let!(:second_wp) do
create(:work_package,
project:,
- subject: 'Task 2',
+ subject: "Task 2",
assigned_to: other_user,
start_date: 10.days.from_now,
due_date: 12.days.from_now)
end
- it 'shows work packages removed from the team planner' do
+ it "shows work packages removed from the team planner" do
team_planner.within_lane(user) do
team_planner.expect_event first_wp
end
@@ -113,9 +113,9 @@
end
end
- it 'allows to click cards to open split view when open' do
+ it "allows to click cards to open split view when open" do
# Search for a work package
- add_existing_pane.search 'Task'
+ add_existing_pane.search "Task"
add_existing_pane.expect_result second_wp
# Open first wp
@@ -130,9 +130,9 @@
expect(page).to have_current_path /\/details\/#{second_wp.id}/
end
- it 'allows to add work packages via drag&drop from the left hand shortlist' do
+ it "allows to add work packages via drag&drop from the left hand shortlist" do
# Search for a work package
- add_existing_pane.search 'Task'
+ add_existing_pane.search "Task"
add_existing_pane.expect_result second_wp
sleep 2
@@ -149,7 +149,7 @@
expect(second_wp.assigned_to_id).to eq(user.id)
# Search for another work package
- add_existing_pane.search 'Ta'
+ add_existing_pane.search "Ta"
add_existing_pane.expect_result third_wp
sleep 2
@@ -170,9 +170,9 @@
split_view.expect_open
end
- it 'the search applies the filter from the team planner' do
+ it "the search applies the filter from the team planner" do
# Search for a work package
- add_existing_pane.search 'Task'
+ add_existing_pane.search "Task"
add_existing_pane.expect_result second_wp
add_existing_pane.expect_result third_wp, visible: false
@@ -181,23 +181,23 @@
filters.expect_filter_count 1
filters.open
- filters.expect_filter_by 'Status', 'is not empty', nil
+ filters.expect_filter_by "Status", "is not empty", nil
# Change the filter for the whole page
- filters.set_filter 'Status', 'open', nil
+ filters.set_filter "Status", "open", nil
# Expect the filter to auto update
add_existing_pane.expect_result second_wp
add_existing_pane.expect_result third_wp, visible: false
end
- context 'with a subproject' do
+ context "with a subproject" do
let!(:sub_project) do
- create(:project, name: 'Child', parent: project, enabled_module_names: %w[work_package_tracking])
+ create(:project, name: "Child", parent: project, enabled_module_names: %w[work_package_tracking])
end
let!(:sub_work_package) do
- create(:work_package, subject: 'Subtask', project: sub_project)
+ create(:work_package, subject: "Subtask", project: sub_project)
end
let(:permissions) do
@@ -214,9 +214,9 @@
let(:dropdown) { Components::ProjectIncludeComponent.new }
- it 'applies the project include filter' do
+ it "applies the project include filter" do
# Search for the work package in the child project
- add_existing_pane.search 'Subtask'
+ add_existing_pane.search "Subtask"
add_existing_pane.expect_empty
add_existing_pane.expect_result sub_work_package, visible: false
@@ -229,7 +229,7 @@
dropdown.expect_checkbox(project.id, true)
dropdown.expect_checkbox(sub_project.id, false)
- dropdown.click_button 'Apply'
+ dropdown.click_button "Apply"
dropdown.expect_closed
dropdown.expect_count 1
dropdown.toggle!
@@ -240,7 +240,7 @@
dropdown.expect_checkbox(project.id, true)
dropdown.expect_checkbox(sub_project.id, true)
- dropdown.click_button 'Apply'
+ dropdown.click_button "Apply"
dropdown.expect_closed
dropdown.expect_count 2
@@ -250,15 +250,15 @@
end
end
- context 'without permission to edit' do
+ context "without permission to edit" do
current_user { other_user }
before do
team_planner.visit!
end
- it 'does not show the button to add existing work packages' do
- expect(page).not_to have_test_selector('op-team-planner--add-existing-toggle')
+ it "does not show the button to add existing work packages" do
+ expect(page).not_to have_test_selector("op-team-planner--add-existing-toggle")
add_existing_pane.expect_closed
end
end
diff --git a/modules/team_planner/spec/features/team_planner_context_menu_spec.rb b/modules/team_planner/spec/features/team_planner_context_menu_spec.rb
index 6813a415f088..45cb6f9b1a99 100644
--- a/modules/team_planner/spec/features/team_planner_context_menu_spec.rb
+++ b/modules/team_planner/spec/features/team_planner_context_menu_spec.rb
@@ -1,12 +1,12 @@
-require 'spec_helper'
-require_relative 'shared_context'
-require 'features/work_packages/table/context_menu/context_menu_shared_examples'
+require "spec_helper"
+require_relative "shared_context"
+require "features/work_packages/table/context_menu/context_menu_shared_examples"
-RSpec.describe 'Work package table context menu',
+RSpec.describe "Work package table context menu",
:js,
with_ee: %i[team_planner_view],
with_settings: { start_of_week: 1 } do
- include_context 'with team planner full access'
+ include_context "with team planner full access"
let!(:work_package) do
create(:work_package,
@@ -37,7 +37,7 @@
end
end
- it_behaves_like 'provides a single WP context menu' do
+ it_behaves_like "provides a single WP context menu" do
let(:open_context_menu) do
-> {
team_planner.visit!
diff --git a/modules/team_planner/spec/features/team_planner_create_spec.rb b/modules/team_planner/spec/features/team_planner_create_spec.rb
index 7bc0eee95ce5..cb98f3814024 100644
--- a/modules/team_planner/spec/features/team_planner_create_spec.rb
+++ b/modules/team_planner/spec/features/team_planner_create_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_context'
+require "spec_helper"
+require_relative "shared_context"
-RSpec.describe 'Team planner create new work package', :js, with_ee: %i[team_planner_view] do
- include_context 'with team planner full access'
+RSpec.describe "Team planner create new work package", :js, with_ee: %i[team_planner_view] do
+ include_context "with team planner full access"
let(:type_task) { create(:type_task) }
let!(:status) { create(:default_status) }
@@ -40,8 +40,8 @@
project.types << type_task
end
- shared_examples 'can create a new work package' do
- it 'creates a new work package for the given user' do
+ shared_examples "can create a new work package" do
+ it "creates a new work package for the given user" do
start_of_week = Time.zone.today.beginning_of_week(:sunday)
team_planner.expect_assignee(user)
split_create = team_planner.add_item "/api/v3/users/#{user.id}",
@@ -49,19 +49,19 @@
start_of_week.iso8601
subject = split_create.edit_field(:subject)
- subject.set_value 'Newly planned task'
+ subject.set_value "Newly planned task"
split_create.save!
- split_create.expect_and_dismiss_toaster(message: I18n.t('js.notice_successful_create'))
+ split_create.expect_and_dismiss_toaster(message: I18n.t("js.notice_successful_create"))
split_create.expect_attributes(
- combinedDate: start_of_week.strftime('%m/%d/%Y'),
+ combinedDate: start_of_week.strftime("%m/%d/%Y"),
assignee: user.name
)
wp = WorkPackage.last
- expect(wp.subject).to eq 'Newly planned task'
+ expect(wp.subject).to eq "Newly planned task"
expect(wp.start_date).to eq start_of_week
expect(wp.due_date).to eq start_of_week
@@ -71,7 +71,7 @@
end
end
- context 'with a single user' do
+ context "with a single user" do
before do
team_planner.visit!
@@ -80,14 +80,14 @@
team_planner.add_assignee user.name
end
- it_behaves_like 'can create a new work package'
+ it_behaves_like "can create a new work package"
end
- context 'with multiple users added' do
+ context "with multiple users added" do
let!(:other_user) do
create(:user,
- firstname: 'Other',
- lastname: 'User',
+ firstname: "Other",
+ lastname: "User",
member_with_permissions: { project => %w[
view_work_packages edit_work_packages add_work_packages
view_team_planner manage_team_planner
@@ -98,8 +98,8 @@
let!(:third_user) do
create(:user,
- firstname: 'Other',
- lastname: 'User',
+ firstname: "Other",
+ lastname: "User",
member_with_permissions: { project => %w[
view_work_packages edit_work_packages add_work_packages
view_team_planner manage_team_planner
@@ -120,6 +120,6 @@
team_planner.add_assignee user.name
end
- it_behaves_like 'can create a new work package'
+ it_behaves_like "can create a new work package"
end
end
diff --git a/modules/team_planner/spec/features/team_planner_dates_spec.rb b/modules/team_planner/spec/features/team_planner_dates_spec.rb
index 50d521d2b9f3..4712b00eecea 100644
--- a/modules/team_planner/spec/features/team_planner_dates_spec.rb
+++ b/modules/team_planner/spec/features/team_planner_dates_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_context'
+require "spec_helper"
+require_relative "shared_context"
-RSpec.describe 'Team planner working days', :js,
+RSpec.describe "Team planner working days", :js,
with_ee: %i[team_planner_view],
with_settings: { start_of_week: 1 } do
- include_context 'with team planner full access'
+ include_context "with team planner full access"
- context 'with week days defined' do
+ context "with week days defined" do
let!(:week_days) { week_with_saturday_and_sunday_as_weekend }
it 'hides sat and sun in the "Work week" view andd renders sat and sun as non working in the "1-week" view' do
@@ -44,37 +44,37 @@
team_planner.add_assignee user.name
# Initially, in the "Work week" view, non working days are hidden
- expect(page).to have_css('.fc-day-mon')
- expect(page).to have_css('.fc-day-tue')
- expect(page).to have_css('.fc-day-wed')
- expect(page).to have_css('.fc-day-thu')
- expect(page).to have_css('.fc-day-fri')
+ expect(page).to have_css(".fc-day-mon")
+ expect(page).to have_css(".fc-day-tue")
+ expect(page).to have_css(".fc-day-wed")
+ expect(page).to have_css(".fc-day-thu")
+ expect(page).to have_css(".fc-day-fri")
- expect(page).to have_no_css('.fc-day-sat')
- expect(page).to have_no_css('.fc-day-sun')
+ expect(page).to have_no_css(".fc-day-sat")
+ expect(page).to have_no_css(".fc-day-sun")
# In the "1-week" view, non working days are displayed but marked
- team_planner.switch_view_mode '1-week'
+ team_planner.switch_view_mode "1-week"
- expect(page).to have_css('.fc-day-sat.fc-non-working-day', minimum: 1, wait: 10)
- expect(page).to have_css('.fc-day-sun.fc-non-working-day', minimum: 1)
+ expect(page).to have_css(".fc-day-sat.fc-non-working-day", minimum: 1, wait: 10)
+ expect(page).to have_css(".fc-day-sun.fc-non-working-day", minimum: 1)
- expect(page).to have_no_css('.fc-day-mon.fc-non-working-day')
- expect(page).to have_no_css('.fc-day-tue.fc-non-working-day')
- expect(page).to have_no_css('.fc-day-wed.fc-non-working-day')
- expect(page).to have_no_css('.fc-day-thu.fc-non-working-day')
- expect(page).to have_no_css('.fc-day-fri.fc-non-working-day')
+ expect(page).to have_no_css(".fc-day-mon.fc-non-working-day")
+ expect(page).to have_no_css(".fc-day-tue.fc-non-working-day")
+ expect(page).to have_no_css(".fc-day-wed.fc-non-working-day")
+ expect(page).to have_no_css(".fc-day-thu.fc-non-working-day")
+ expect(page).to have_no_css(".fc-day-fri.fc-non-working-day")
- find('.fc-next-button').click
+ find(".fc-next-button").click
- expect(page).to have_css('.fc-day-sat.fc-non-working-day', minimum: 1, wait: 10)
- expect(page).to have_css('.fc-day-sun.fc-non-working-day', minimum: 1)
+ expect(page).to have_css(".fc-day-sat.fc-non-working-day", minimum: 1, wait: 10)
+ expect(page).to have_css(".fc-day-sun.fc-non-working-day", minimum: 1)
- expect(page).to have_no_css('.fc-day-mon.fc-non-working-day')
- expect(page).to have_no_css('.fc-day-tue.fc-non-working-day')
- expect(page).to have_no_css('.fc-day-wed.fc-non-working-day')
- expect(page).to have_no_css('.fc-day-thu.fc-non-working-day')
- expect(page).to have_no_css('.fc-day-fri.fc-non-working-day')
+ expect(page).to have_no_css(".fc-day-mon.fc-non-working-day")
+ expect(page).to have_no_css(".fc-day-tue.fc-non-working-day")
+ expect(page).to have_no_css(".fc-day-wed.fc-non-working-day")
+ expect(page).to have_no_css(".fc-day-thu.fc-non-working-day")
+ expect(page).to have_no_css(".fc-day-fri.fc-non-working-day")
end
end
end
diff --git a/modules/team_planner/spec/features/team_planner_error_handling_spec.rb b/modules/team_planner/spec/features/team_planner_error_handling_spec.rb
index 923ed7167655..b08930fb21ef 100644
--- a/modules/team_planner/spec/features/team_planner_error_handling_spec.rb
+++ b/modules/team_planner/spec/features/team_planner_error_handling_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_context'
+require "spec_helper"
+require_relative "shared_context"
-RSpec.describe 'Team planner error handling', :js,
+RSpec.describe "Team planner error handling", :js,
with_settings: { start_of_week: 1 } do
- include_context 'with team planner full access'
+ include_context "with team planner full access"
let!(:work_package) do
create(:work_package,
@@ -51,7 +51,7 @@
let(:type) { create(:type, custom_fields: [custom_field]) }
- context 'with full permissions', with_ee: %i[team_planner_view] do
+ context "with full permissions", with_ee: %i[team_planner_view] do
before do
project.types << type
project.save!
@@ -65,7 +65,7 @@
end
end
- it 'cannot change the wp because of required fields not being set' do
+ it "cannot change the wp because of required fields not being set" do
custom_field.is_required = true
custom_field.save!
@@ -80,10 +80,10 @@
end
end
- it 'cannot change the wp because of conflicting modifications' do
+ it "cannot change the wp because of conflicting modifications" do
# Try to move the wp
retry_block do
- wp_strip = page.find('.fc-event', text: work_package.subject)
+ wp_strip = page.find(".fc-event", text: work_package.subject)
page
.driver
@@ -105,7 +105,7 @@
.perform
end
- team_planner.expect_toast(type: :error, message: I18n.t('api_v3.errors.code_409'))
+ team_planner.expect_toast(type: :error, message: I18n.t("api_v3.errors.code_409"))
work_package.reload
expect(work_package.start_date).to eq(Time.zone.today.beginning_of_week.next_occurring(:tuesday))
diff --git a/modules/team_planner/spec/features/team_planner_global_create_spec.rb b/modules/team_planner/spec/features/team_planner_global_create_spec.rb
index f369d1f28bf5..d523e7332dff 100644
--- a/modules/team_planner/spec/features/team_planner_global_create_spec.rb
+++ b/modules/team_planner/spec/features/team_planner_global_create_spec.rb
@@ -28,43 +28,43 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
-require_relative 'shared_context'
+require "spec_helper"
+require_relative "shared_context"
-RSpec.describe 'Team Planner',
- 'Creating a view from a Global Context',
+RSpec.describe "Team Planner",
+ "Creating a view from a Global Context",
:js,
:with_cuprite,
with_ee: %i[team_planner_view] do
- include_context 'with team planner full access'
+ include_context "with team planner full access"
- context 'within the overview page' do
+ context "within the overview page" do
before do
visit team_planners_path
end
- context 'when clicking on the create button' do
+ context "when clicking on the create button" do
before do
team_planner.click_on_create_button
end
- it 'navigates to the global create form' do
+ it "navigates to the global create form" do
expect(page).to have_current_path(new_team_planners_path)
- expect(page).to have_content I18n.t('team_planner.label_new_team_planner')
+ expect(page).to have_content I18n.t("team_planner.label_new_team_planner")
end
end
end
- context 'within the global create page' do
+ context "within the global create page" do
before do
visit new_team_planners_path
end
- context 'with all fields set' do
+ context "with all fields set" do
before do
wait_for_reload # Halt until the project autocompleter is ready
- team_planner.set_title('Gotham Renewal')
+ team_planner.set_title("Gotham Renewal")
team_planner.set_project(project)
team_planner.set_public
team_planner.set_favoured
@@ -73,15 +73,15 @@
wait_for_reload
end
- it 'creates a view and redirects me to it' do
+ it "creates a view and redirects me to it" do
expect(page).to have_text(I18n.t(:notice_successful_create))
expect(page).to have_current_path(project_team_planner_path(project, Query.last), ignore_query: true)
- expect(page).to have_text('Gotham Renewal')
+ expect(page).to have_text("Gotham Renewal")
end
end
- context 'when missing a required field' do
- describe 'title' do
+ context "when missing a required field" do
+ describe "title" do
before do
wait_for_reload # Halt until the project autocompleter is ready
@@ -89,7 +89,7 @@
team_planner.click_on_submit
end
- it 'renders a required attribute validation error' do
+ it "renders a required attribute validation error" do
expect(Query.all).to be_empty
# Required HTML attribute just warns
@@ -97,15 +97,15 @@
end
end
- describe 'project_id' do
+ describe "project_id" do
before do
- team_planner.set_title('Gotham Renewal')
+ team_planner.set_title("Gotham Renewal")
team_planner.click_on_submit
wait_for_reload
end
- it 'renders a required attribute validation error' do
+ it "renders a required attribute validation error" do
expect(Query.all).to be_empty
expect(page).to have_text("Project can't be blank.")
@@ -113,13 +113,13 @@
end
end
- describe 'cancel button' do
+ describe "cancel button" do
context "when it's clicked" do
before do
team_planner.click_on_cancel_button
end
- it 'navigates back to the overview page' do
+ it "navigates back to the overview page" do
expect(page).to have_current_path(team_planners_path)
end
end
diff --git a/modules/team_planner/spec/features/team_planner_index_spec.rb b/modules/team_planner/spec/features/team_planner_index_spec.rb
index f0db27a51432..067fbb09ec3e 100644
--- a/modules/team_planner/spec/features/team_planner_index_spec.rb
+++ b/modules/team_planner/spec/features/team_planner_index_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_context'
+require "spec_helper"
+require_relative "shared_context"
-RSpec.describe 'Team planner index', :js, :with_cuprite, with_ee: %i[team_planner_view] do
+RSpec.describe "Team planner index", :js, :with_cuprite, with_ee: %i[team_planner_view] do
shared_let(:project) do
create(:project)
end
@@ -45,7 +45,7 @@
end
shared_let(:user_with_limited_permissions) do
create(:user,
- firstname: 'Bernd',
+ firstname: "Bernd",
member_with_permissions: { project => %w[view_work_packages view_team_planner] })
end
@@ -58,24 +58,24 @@
visit project_team_planners_path(project)
end
- it 'shows a create button' do
+ it "shows a create button" do
team_planner.expect_create_button
end
- it 'can create an action through the sidebar' do
- find_test_selector('team-planner--create-button').click
+ it "can create an action through the sidebar" do
+ find_test_selector("team-planner--create-button").click
team_planner.expect_no_toaster
team_planner.expect_title
end
- context 'with no views' do
- it 'shows an empty index action' do
+ context "with no views" do
+ it "shows an empty index action" do
team_planner.expect_no_views_rendered
end
end
- context 'with existing views' do
+ context "with existing views" do
shared_let(:query) do
create(:public_query, user: user_with_full_permissions, project:)
end
@@ -97,19 +97,19 @@
create(:view_team_planner, query: private_query)
end
- context 'as a user with full permissions within a project' do
+ context "as a user with full permissions within a project" do
let(:current_user) { user_with_full_permissions }
- it 'shows views' do
+ it "shows views" do
team_planner.expect_views_rendered(query, private_query, other_query)
end
- it 'shows management buttons' do
+ it "shows management buttons" do
team_planner.expect_delete_buttons_for(query, private_query, other_query)
end
- context 'and as the author of a private view' do
- it 'shows my private view' do
+ context "and as the author of a private view" do
+ it "shows my private view" do
team_planner.expect_views_rendered(query, private_query, other_query)
team_planner.expect_delete_buttons_for(query, private_query, other_query)
@@ -117,15 +117,15 @@
end
end
- context 'as a user with limited permissions within a project' do
+ context "as a user with limited permissions within a project" do
let(:current_user) { user_with_limited_permissions }
- it 'does not show the management buttons' do
+ it "does not show the management buttons" do
team_planner.expect_no_create_button
team_planner.expect_no_delete_buttons_for(query, other_query)
end
- it 'shows public views only' do
+ it "shows public views only" do
team_planner.expect_views_rendered(query, other_query)
end
end
diff --git a/modules/team_planner/spec/features/team_planner_menu_spec.rb b/modules/team_planner/spec/features/team_planner_menu_spec.rb
index a7377ee05e28..0732a7378215 100644
--- a/modules/team_planner/spec/features/team_planner_menu_spec.rb
+++ b/modules/team_planner/spec/features/team_planner_menu_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Team planner Menu Item', :js, :with_cuprite do
+RSpec.describe "Team planner Menu Item", :js, :with_cuprite do
shared_let(:project) do
create(:project, enabled_module_names: %w[work_package_tracking team_planner_view])
end
@@ -47,77 +47,77 @@
] })
end
- context 'within the global menu' do
+ context "within the global menu" do
before do
login_as user_without_rights
visit root_path
- within '#main-menu' do
- click_link 'Team planners'
+ within "#main-menu" do
+ click_link "Team planners"
end
end
- context 'when EE enabled', with_ee: %i[team_planner_view] do
- it 'navigates to the global index page' do
+ context "when EE enabled", with_ee: %i[team_planner_view] do
+ it "navigates to the global index page" do
expect(page).to have_current_path(team_planners_path)
end
end
end
- context 'within the project side menu' do
- context 'as a user that does not have create rights' do
+ context "within the project side menu" do
+ context "as a user that does not have create rights" do
current_user { user_without_rights }
- context 'when EE disabled' do
- it 'does not show the create team planner option' do
+ context "when EE disabled" do
+ it "does not show the create team planner option" do
visit project_path(project)
- within '#main-menu' do
- click_link 'Team planners'
+ within "#main-menu" do
+ click_link "Team planners"
end
- expect(page).not_to have_test_selector('team-planner--create-button')
+ expect(page).not_to have_test_selector("team-planner--create-button")
end
end
- context 'when EE enabled', with_ee: %i[team_planner_view] do
- it 'does not show the create team planner option' do
+ context "when EE enabled", with_ee: %i[team_planner_view] do
+ it "does not show the create team planner option" do
visit project_path(project)
- within '#main-menu' do
- click_link 'Team planners'
+ within "#main-menu" do
+ click_link "Team planners"
end
- expect(page).not_to have_test_selector('team-planner--create-button')
+ expect(page).not_to have_test_selector("team-planner--create-button")
end
end
end
- context 'as a user that has create rights' do
+ context "as a user that has create rights" do
current_user { user_with_rights }
- context 'when EE disabled' do
- it 'does not show the create team planner option' do
+ context "when EE disabled" do
+ it "does not show the create team planner option" do
visit project_path(project)
- within '#main-menu' do
- click_link 'Team planners'
+ within "#main-menu" do
+ click_link "Team planners"
end
- expect(page).not_to have_test_selector('team-planner--create-button')
+ expect(page).not_to have_test_selector("team-planner--create-button")
end
end
- context 'when EE enabled', with_ee: %i[team_planner_view] do
- it 'shows the create team planner option' do
+ context "when EE enabled", with_ee: %i[team_planner_view] do
+ it "shows the create team planner option" do
visit project_path(project)
- within '#main-menu' do
- click_link 'Team planners'
+ within "#main-menu" do
+ click_link "Team planners"
end
- expect(page).to have_test_selector('team-planner--create-button')
+ expect(page).to have_test_selector("team-planner--create-button")
end
end
end
diff --git a/modules/team_planner/spec/features/team_planner_overview_spec.rb b/modules/team_planner/spec/features/team_planner_overview_spec.rb
index 4f72fd148952..c48758d8d251 100644
--- a/modules/team_planner/spec/features/team_planner_overview_spec.rb
+++ b/modules/team_planner/spec/features/team_planner_overview_spec.rb
@@ -29,17 +29,17 @@
# ++
#
-require 'spec_helper'
-require_relative 'shared_context'
+require "spec_helper"
+require_relative "shared_context"
-RSpec.describe 'Team planner overview',
+RSpec.describe "Team planner overview",
:with_cuprite,
with_ee: %i[team_planner_view] do
# The order the Projects are created in is important. By naming `project` alphanumerically
# after `other_project`, we can ensure that subsequent specs that assert sorting is
# correct for the right reasons (sorting by Project name and not id)
- shared_let(:project) { create(:project, name: 'Project 2') }
- shared_let(:other_project) { create(:project, name: 'Project 1') }
+ shared_let(:project) { create(:project, name: "Project 2") }
+ shared_let(:other_project) { create(:project, name: "Project 1") }
shared_let(:admin) { create(:admin) }
shared_let(:user_with_full_permissions) do
@@ -53,7 +53,7 @@
end
shared_let(:user_with_limited_permissions) do
create(:user,
- firstname: 'Bernd',
+ firstname: "Bernd",
member_with_permissions: { project => %w[view_work_packages view_team_planner] })
end
@@ -66,23 +66,23 @@
visit team_planners_path
end
- it 'renders a global menu with its item selected' do
- within '#main-menu' do
- expect(page).to have_css '.selected', text: 'Team planners'
+ it "renders a global menu with its item selected" do
+ within "#main-menu" do
+ expect(page).to have_css ".selected", text: "Team planners"
end
end
- it 'shows a create button' do
+ it "shows a create button" do
team_planner.expect_create_button
end
- context 'with no views' do
- it 'shows an empty overview action' do
+ context "with no views" do
+ it "shows an empty overview action" do
team_planner.expect_no_views_rendered
end
end
- context 'with existing views' do
+ context "with existing views" do
shared_let(:query) do
create(:public_query, user: user_with_full_permissions, project:)
end
@@ -111,27 +111,27 @@
create(:view_team_planner, query: other_project_query)
end
- context 'as an admin' do
+ context "as an admin" do
let(:current_user) { admin }
- it 'shows those views' do
+ it "shows those views" do
team_planner.expect_views_rendered(query, other_query, other_project_query)
team_planner.expect_no_delete_buttons_for(query, other_query, other_project_query)
end
end
- context 'as a user with full permissions within a project' do
+ context "as a user with full permissions within a project" do
let(:current_user) { user_with_full_permissions }
- it 'shows views in projects the user is a member of' do
+ it "shows views in projects the user is a member of" do
team_planner.expect_views_rendered(query, private_query, other_query)
team_planner.expect_no_delete_buttons_for(query, private_query, other_query)
end
- context 'and as the author of a private view' do
- it 'shows my private view' do
+ context "and as the author of a private view" do
+ it "shows my private view" do
team_planner.expect_views_rendered(query, private_query, other_query)
team_planner.expect_no_delete_buttons_for(query, private_query, other_query)
@@ -139,36 +139,36 @@
end
end
- context 'as a user with limited permissions within a project' do
+ context "as a user with limited permissions within a project" do
let(:current_user) { user_with_limited_permissions }
- it 'does not show the management buttons' do
+ it "does not show the management buttons" do
team_planner.expect_no_create_button
team_planner.expect_no_delete_buttons_for(query, other_query)
end
- it 'shows views in projects the user is a member of' do
+ it "shows views in projects the user is a member of" do
team_planner.expect_views_rendered(query, other_query)
end
end
- describe 'sorting' do
+ describe "sorting" do
let(:current_user) { admin }
- it 'allows sorting by all columns' do
+ it "allows sorting by all columns" do
# Initial sort is Name ASC
# We can assert this by expecting the order to be
# 1. query
# 2. other_query
# 3. other_project_query
- aggregate_failures 'Sorting by Name' do
+ aggregate_failures "Sorting by Name" do
team_planner.expect_views_listed_in_order(query, other_query, other_project_query)
- team_planner.click_to_sort_by('Name')
+ team_planner.click_to_sort_by("Name")
team_planner.expect_views_listed_in_order(other_project_query, other_query, query)
end
- aggregate_failures 'Sorting by Project' do
- team_planner.click_to_sort_by('Project')
+ aggregate_failures "Sorting by Project" do
+ team_planner.click_to_sort_by("Project")
# Sorting is performed on multiple columns at a time, taking into account
# previous sorting criteria and using the latest clicked column as
# the first column in the +ORDER BY+ clause and previously sorted by columns after.
@@ -180,14 +180,14 @@
# visual feedback of all columns currently being taken into account for
# sorting.
team_planner.expect_views_listed_in_order(other_project_query, other_query, query)
- team_planner.click_to_sort_by('Project')
+ team_planner.click_to_sort_by("Project")
team_planner.expect_views_listed_in_order(other_query, query, other_project_query)
end
- aggregate_failures 'Sorting by Created on' do
- team_planner.click_to_sort_by('Created on')
+ aggregate_failures "Sorting by Created on" do
+ team_planner.click_to_sort_by("Created on")
team_planner.expect_views_listed_in_order(query, other_query, other_project_query)
- team_planner.click_to_sort_by('Created on')
+ team_planner.click_to_sort_by("Created on")
team_planner.expect_views_listed_in_order(other_project_query, other_query, query)
end
end
diff --git a/modules/team_planner/spec/features/team_planner_project_include_spec.rb b/modules/team_planner/spec/features/team_planner_project_include_spec.rb
index 3d5a42ad9a7c..42c0856d2ef3 100644
--- a/modules/team_planner/spec/features/team_planner_project_include_spec.rb
+++ b/modules/team_planner/spec/features/team_planner_project_include_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/work_packages/project_include/project_include_shared_examples'
-require_relative '../support/pages/team_planner'
+require "spec_helper"
+require "features/work_packages/project_include/project_include_shared_examples"
+require_relative "../support/pages/team_planner"
-RSpec.describe 'Team planner project include', :js, with_ee: %i[team_planner_view] do
+RSpec.describe "Team planner project include", :js, with_ee: %i[team_planner_view] do
shared_let(:enabled_modules) { %w[work_package_tracking team_planner_view] }
shared_let(:permissions) do
%w[view_work_packages edit_work_packages add_work_packages
@@ -38,17 +38,17 @@
save_queries manage_public_queries]
end
- it_behaves_like 'has a project include dropdown' do
+ it_behaves_like "has a project include dropdown" do
let(:work_package_view) { Pages::TeamPlanner.new(project) }
let(:dropdown) { Components::ProjectIncludeComponent.new }
- it 'correctly filters work packages by project' do
+ it "correctly filters work packages by project" do
dropdown.expect_count 1
# Make sure the filter gets set once
dropdown.toggle!
dropdown.expect_open
- dropdown.click_button 'Apply'
+ dropdown.click_button "Apply"
dropdown.expect_closed
work_package_view.expect_empty_state
@@ -79,7 +79,7 @@
dropdown.toggle!
dropdown.toggle_checkbox(sub_sub_sub_project.id)
- dropdown.click_button 'Apply'
+ dropdown.click_button "Apply"
dropdown.expect_count 1
work_package_view.within_lane(user) do
@@ -90,7 +90,7 @@
dropdown.toggle!
dropdown.toggle_checkbox(other_project.id)
- dropdown.click_button 'Apply'
+ dropdown.click_button "Apply"
dropdown.expect_count 2
work_package_view.within_lane(other_user) do
diff --git a/modules/team_planner/spec/features/team_planner_remove_event_spec.rb b/modules/team_planner/spec/features/team_planner_remove_event_spec.rb
index ff9fa67f6203..620b1df7caa0 100644
--- a/modules/team_planner/spec/features/team_planner_remove_event_spec.rb
+++ b/modules/team_planner/spec/features/team_planner_remove_event_spec.rb
@@ -26,21 +26,21 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_context'
-require_relative '../support/components/add_existing_pane'
+require "spec_helper"
+require_relative "shared_context"
+require_relative "../support/components/add_existing_pane"
-RSpec.describe 'Team planner remove event',
+RSpec.describe "Team planner remove event",
:js,
with_ee: %i[team_planner_view],
with_settings: { start_of_week: 1 } do
- include_context 'with team planner full access'
+ include_context "with team planner full access"
let!(:viewer_role) { create(:project_role, permissions: [:view_work_packages]) }
let!(:other_user) do
create(:user,
- firstname: 'Bernd',
+ firstname: "Bernd",
member_with_permissions: { project => %w[
view_work_packages view_team_planner
] })
@@ -49,7 +49,7 @@
let!(:removable_wp) do
create(:work_package,
project:,
- subject: 'Some task',
+ subject: "Some task",
assigned_to: other_user,
start_date: Time.zone.today.beginning_of_week.next_occurring(:tuesday),
due_date: Time.zone.today.beginning_of_week.next_occurring(:thursday))
@@ -58,7 +58,7 @@
let!(:non_removable_wp) do
create(:work_package,
project:,
- subject: 'Parent work package',
+ subject: "Parent work package",
assigned_to: other_user,
start_date: Time.zone.today.beginning_of_week.next_occurring(:wednesday),
due_date: Time.zone.today.beginning_of_week.next_occurring(:thursday),
@@ -87,21 +87,21 @@
sleep 2
end
- it 'can remove one of the work packages' do
+ it "can remove one of the work packages" do
team_planner.drag_to_remove_dropzone non_removable_wp, expect_removable: false
team_planner.drag_to_remove_dropzone removable_wp, expect_removable: true
end
- context 'with the add existing open searching for the task' do
+ context "with the add existing open searching for the task" do
let(:add_existing_pane) { Components::AddExistingPane.new }
- it 'the removed task shows up again' do
+ it "the removed task shows up again" do
# Open the left hand pane
add_existing_pane.open
add_existing_pane.expect_empty
# Search for the task, expect empty
- add_existing_pane.search 'task'
+ add_existing_pane.search "task"
add_existing_pane.expect_empty
# Remove the task
diff --git a/modules/team_planner/spec/features/team_planner_spec.rb b/modules/team_planner/spec/features/team_planner_spec.rb
index 7326ac8e795e..a426f08a70f5 100644
--- a/modules/team_planner/spec/features/team_planner_spec.rb
+++ b/modules/team_planner/spec/features/team_planner_spec.rb
@@ -26,24 +26,24 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_context'
+require "spec_helper"
+require_relative "shared_context"
-RSpec.describe 'Team planner',
+RSpec.describe "Team planner",
:js,
with_ee: %i[team_planner_view],
with_settings: { start_of_week: 1 } do
- include_context 'with team planner full access'
+ include_context "with team planner full access"
- it 'hides the internally used filters' do
+ it "hides the internally used filters" do
visit project_path(project)
- within '#main-menu' do
- click_link 'Team planners'
+ within "#main-menu" do
+ click_link "Team planners"
end
- expect(page).to have_content 'There is currently nothing to display.'
- click_on 'Create', match: :first
+ expect(page).to have_content "There is currently nothing to display."
+ click_on "Create", match: :first
team_planner.expect_title
@@ -51,26 +51,26 @@
filters.open
filters.open_available_filter_list
- filters.expect_available_filter 'Author', present: true
- filters.expect_available_filter 'Subject', present: true
- filters.expect_available_filter 'Finish date', present: false
- filters.expect_available_filter 'Start date', present: false
- filters.expect_available_filter 'Assignee', present: false
- filters.expect_available_filter 'Assignee or belonging group', present: false
+ filters.expect_available_filter "Author", present: true
+ filters.expect_available_filter "Subject", present: true
+ filters.expect_available_filter "Finish date", present: false
+ filters.expect_available_filter "Start date", present: false
+ filters.expect_available_filter "Assignee", present: false
+ filters.expect_available_filter "Assignee or belonging group", present: false
filters.expect_available_filter "Assignee's group", present: false
filters.expect_available_filter "Assignee's role", present: false
end
- context 'with an assigned work package', with_settings: { working_days: [1, 2, 3, 4, 5] } do
+ context "with an assigned work package", with_settings: { working_days: [1, 2, 3, 4, 5] } do
let!(:other_user) do
create(:user,
- firstname: 'Other',
- lastname: 'User',
+ firstname: "Other",
+ lastname: "User",
member_with_permissions: { project => %w[
view_work_packages edit_work_packages view_team_planner manage_team_planner
] })
end
- let!(:user_outside_project) { create(:user, firstname: 'Not', lastname: 'In Project') }
+ let!(:user_outside_project) { create(:user, firstname: "Not", lastname: "In Project") }
let(:type_task) { create(:type_task) }
let(:type_bug) { create(:type_bug) }
let(:closed_status) { create(:status, is_closed: true) }
@@ -82,7 +82,7 @@
assigned_to: other_user,
start_date: Time.zone.today.monday + 1.day,
due_date: Time.zone.today.monday + 3.days,
- subject: 'A task for the other user')
+ subject: "A task for the other user")
end
let!(:other_bug) do
create(:work_package,
@@ -91,7 +91,7 @@
assigned_to: other_user,
start_date: Time.zone.today.monday + 1.day,
due_date: Time.zone.today.monday + 3.days,
- subject: 'Another task for the other user')
+ subject: "Another task for the other user")
end
let!(:closed_bug) do
create(:work_package,
@@ -101,7 +101,7 @@
status: closed_status,
start_date: Time.zone.today.monday + 1.day,
due_date: Time.zone.today.monday + 3.days,
- subject: 'Closed bug')
+ subject: "Closed bug")
end
let!(:user_bug) do
create(:work_package,
@@ -110,7 +110,7 @@
assigned_to: user,
start_date: Time.zone.today - 10.days,
due_date: Time.zone.today + 20.days,
- subject: 'A task for the logged in user')
+ subject: "A task for the logged in user")
end
let!(:user_bug_next_week) do
create(:work_package,
@@ -119,7 +119,7 @@
assigned_to: user,
start_date: Time.zone.today.monday + 7.days,
due_date: Time.zone.today.monday + 12.days,
- subject: 'A task for the logged in user in the next week')
+ subject: "A task for the logged in user in the next week")
end
let!(:user_bug_last_week) do
create(:work_package,
@@ -128,7 +128,7 @@
assigned_to: user,
start_date: Time.zone.today.monday - 7.days,
due_date: Time.zone.today.monday - 5.days,
- subject: 'A task for the logged in user in the last week')
+ subject: "A task for the logged in user in the last week")
end
let!(:user_bug_on_weekend) do
create(:work_package,
@@ -137,7 +137,7 @@
assigned_to: user,
start_date: Time.zone.today.monday + 5.days,
due_date: Time.zone.today.monday + 6.days,
- subject: 'A task for the logged in user on the weekend')
+ subject: "A task for the logged in user on the weekend")
end
before do
@@ -145,7 +145,7 @@
project.types << type_task
end
- it 'renders a team planner displaying work packages by assignee and date' do
+ it "renders a team planner displaying work packages by assignee and date" do
team_planner.visit!
team_planner.title
@@ -184,7 +184,7 @@
# Switching to the '1-week' view means that
# work packages on the weekend are displayed now but
# those outside of the current week are still hidden.
- team_planner.switch_view_mode('1-week')
+ team_planner.switch_view_mode("1-week")
team_planner.within_lane(user) do
team_planner.expect_event user_bug
@@ -197,7 +197,7 @@
# work packages on the weekend and those of the upcoming week are displayed.
# Those in the last week are still hidden.
- team_planner.switch_view_mode('2-week')
+ team_planner.switch_view_mode("2-week")
team_planner.within_lane(user) do
team_planner.expect_event user_bug
@@ -210,8 +210,8 @@
filters.expect_filter_count("1")
filters.open
- filters.add_filter_by('Type', 'is (OR)', [type_task.name])
- filters.expect_filter_by('Type', 'is (OR)', [type_task.name])
+ filters.add_filter_by("Type", "is (OR)", [type_task.name])
+ filters.expect_filter_by("Type", "is (OR)", [type_task.name])
filters.expect_filter_count("2")
team_planner.expect_assignee(user, present: true)
@@ -234,7 +234,7 @@
team_planner.expect_empty_state(present: false)
end
- it 'can add and remove assignees' do
+ it "can add and remove assignees" do
team_planner.visit!
team_planner.expect_empty_state
@@ -270,12 +270,12 @@
team_planner.expect_assignee(other_user, present: false)
end
- it 'filters possible assignees correctly' do
+ it "filters possible assignees correctly" do
team_planner.visit!
team_planner.search_assignee(user_outside_project.name)
- expect(page).to have_css('.ng-option-disabled', text: "No items found")
+ expect(page).to have_css(".ng-option-disabled", text: "No items found")
retry_block do
team_planner.select_user_to_add user.name
@@ -285,17 +285,17 @@
team_planner.search_assignee user.name
- expect(page).to have_css('.ng-option-disabled', text: "No items found")
+ expect(page).to have_css(".ng-option-disabled", text: "No items found")
end
- context 'when the page size is smaller than the number of assignees' do
+ context "when the page size is smaller than the number of assignees" do
before do
allow(Setting)
.to receive(:per_page_options_array)
.and_return([1])
end
- it 'renders assignees and assignee dropdown correctly' do
+ it "renders assignees and assignee dropdown correctly" do
team_planner.visit!
team_planner.wait_for_loaded
@@ -308,7 +308,7 @@
team_planner.add_assignee user
team_planner.add_assignee other_user
- team_planner.save_as('TP1')
+ team_planner.save_as("TP1")
page.refresh
team_planner.wait_for_loaded
@@ -324,7 +324,7 @@
end
end
- context 'with a readonly work package' do
+ context "with a readonly work package" do
let(:readonly_status) { create(:status, is_readonly: true) }
let!(:blocked_task) do
@@ -334,10 +334,10 @@
status: readonly_status,
start_date: Time.zone.today - 1.day,
due_date: Time.zone.today + 1.day,
- subject: 'A blocked task')
+ subject: "A blocked task")
end
- it 'disables editing on readonly tasks', with_ee: %i[team_planner_view readonly_work_packages] do
+ it "disables editing on readonly tasks", with_ee: %i[team_planner_view readonly_work_packages] do
team_planner.visit!
team_planner.wait_for_loaded
diff --git a/modules/team_planner/spec/features/team_planner_split_view_spec.rb b/modules/team_planner/spec/features/team_planner_split_view_spec.rb
index 173b02309d9d..d765a35aa267 100644
--- a/modules/team_planner/spec/features/team_planner_split_view_spec.rb
+++ b/modules/team_planner/spec/features/team_planner_split_view_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_context'
+require "spec_helper"
+require_relative "shared_context"
-RSpec.describe 'Team planner split view navigation', :js, with_ee: %i[team_planner_view] do
- include_context 'with team planner full access'
+RSpec.describe "Team planner split view navigation", :js, with_ee: %i[team_planner_view] do
+ include_context "with team planner full access"
let!(:view) { create(:view_team_planner, query:) }
let!(:query) { create(:query, user:, project:, public: true) }
@@ -40,7 +40,7 @@
let!(:work_package1) do
create(:work_package,
project:,
- subject: 'First task',
+ subject: "First task",
assigned_to: user,
start_date: start_of_week.next_occurring(:tuesday),
due_date: start_of_week.next_occurring(:thursday))
@@ -49,13 +49,13 @@
let!(:work_package2) do
create(:work_package,
project:,
- subject: 'Another task',
+ subject: "Another task",
assigned_to: user,
start_date: start_of_week.next_occurring(:tuesday),
due_date: start_of_week.next_occurring(:thursday))
end
- it 'allows to navigate to the split view' do
+ it "allows to navigate to the split view" do
team_planner.visit!
team_planner.add_assignee user
@@ -65,7 +65,7 @@
end
# Expect clicking on a work package does not open the details
- page.find_test_selector('op-wp-single-card--content-subject', text: work_package1.subject).click
+ page.find_test_selector("op-wp-single-card--content-subject", text: work_package1.subject).click
expect(page).to have_no_current_path /team_planners\/new\/details\/#{work_package1.id}/
# Open split view through info icon
@@ -76,7 +76,7 @@
card1.expect_selected
# now clicking on another card switches
- page.find_test_selector('op-wp-single-card--content-subject', text: work_package2.subject).click
+ page.find_test_selector("op-wp-single-card--content-subject", text: work_package2.subject).click
expect(page).to have_current_path /team_planners\/new\/details\/#{work_package2.id}/
card2 = Pages::WorkPackageCard.new work_package2
diff --git a/modules/team_planner/spec/features/team_planner_subproject_constraints_spec.rb b/modules/team_planner/spec/features/team_planner_subproject_constraints_spec.rb
index c3ff5fc2a77b..55c76a623845 100644
--- a/modules/team_planner/spec/features/team_planner_subproject_constraints_spec.rb
+++ b/modules/team_planner/spec/features/team_planner_subproject_constraints_spec.rb
@@ -26,18 +26,18 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_context'
+require "spec_helper"
+require_relative "shared_context"
-RSpec.describe 'Team planner constraints for a subproject',
+RSpec.describe "Team planner constraints for a subproject",
:js,
with_ee: %i[team_planner_view],
with_settings: { start_of_week: 1 } do
- include_context 'with team planner full access'
+ include_context "with team planner full access"
let!(:other_user) do
create(:user,
- firstname: 'Bernd',
+ firstname: "Bernd",
member_with_permissions: { project => %w[view_work_packages view_team_planner work_package_assigned] })
end
@@ -54,7 +54,7 @@
due_date: Time.zone.today.beginning_of_week.next_occurring(:thursday))
end
- it 'shows a visual aid that the other user cannot be assigned' do
+ it "shows a visual aid that the other user cannot be assigned" do
team_planner.visit!
team_planner.add_assignee user
@@ -63,7 +63,7 @@
# Include the subproject
project_include.toggle!
project_include.toggle_checkbox(subproject.id)
- project_include.click_button 'Apply'
+ project_include.click_button "Apply"
project_include.expect_count 1
team_planner.within_lane(user) do
diff --git a/modules/team_planner/spec/features/team_planner_upsale_spec.rb b/modules/team_planner/spec/features/team_planner_upsale_spec.rb
index f93714bdcacc..33a21f6c9564 100644
--- a/modules/team_planner/spec/features/team_planner_upsale_spec.rb
+++ b/modules/team_planner/spec/features/team_planner_upsale_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_context'
+require "spec_helper"
+require_relative "shared_context"
-RSpec.describe 'Team planner index', :js, :with_cuprite do
- include_context 'with team planner full access'
+RSpec.describe "Team planner index", :js, :with_cuprite do
+ include_context "with team planner full access"
let(:current_user) { user }
@@ -38,21 +38,21 @@
login_as current_user
end
- it 'redirects routes to upsale' do
+ it "redirects routes to upsale" do
visit team_planners_path
- expect(page).to have_text 'Upgrade now'
+ expect(page).to have_text "Upgrade now"
visit project_team_planners_path(project)
- expect(page).to have_text 'Upgrade now'
+ expect(page).to have_text "Upgrade now"
visit new_project_team_planners_path(project)
- expect(page).to have_text 'Upgrade now'
+ expect(page).to have_text "Upgrade now"
- visit project_team_planner_path(project, id: 'new')
+ visit project_team_planner_path(project, id: "new")
- expect(page).to have_text 'Upgrade now'
+ expect(page).to have_text "Upgrade now"
end
end
diff --git a/modules/team_planner/spec/features/team_planner_user_interaction_spec.rb b/modules/team_planner/spec/features/team_planner_user_interaction_spec.rb
index 460e46f86d52..36e6ee4a703c 100644
--- a/modules/team_planner/spec/features/team_planner_user_interaction_spec.rb
+++ b/modules/team_planner/spec/features/team_planner_user_interaction_spec.rb
@@ -26,18 +26,18 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_context'
+require "spec_helper"
+require_relative "shared_context"
-RSpec.describe 'Team planner drag&dop and resizing',
+RSpec.describe "Team planner drag&dop and resizing",
:js,
with_ee: %i[team_planner_view],
with_settings: { start_of_week: 1 } do
- include_context 'with team planner full access'
+ include_context "with team planner full access"
let!(:other_user) do
create(:user,
- firstname: 'Bernd',
+ firstname: "Bernd",
member_with_permissions: { project => %w[view_work_packages view_team_planner work_package_assigned] })
end
@@ -74,7 +74,7 @@
due_date: Time.zone.today.beginning_of_week.next_occurring(:tuesday))
end
- context 'with full permissions' do
+ context "with full permissions" do
before do
team_planner.visit!
@@ -96,12 +96,12 @@
end
end
- it 'allows to drag&drop between the lanes to change the assignee' do
+ it "allows to drag&drop between the lanes to change the assignee" do
# Move first wp to the user
retry_block do
team_planner.drag_wp_to_lane(first_wp, user)
end
- team_planner.expect_and_dismiss_toaster(message: I18n.t('js.notice_successful_update'))
+ team_planner.expect_and_dismiss_toaster(message: I18n.t("js.notice_successful_update"))
team_planner.within_lane(user) do
team_planner.expect_event first_wp
@@ -121,7 +121,7 @@
retry_block do
team_planner.drag_wp_to_lane(second_wp, user)
end
- team_planner.expect_and_dismiss_toaster(message: I18n.t('js.notice_successful_update'))
+ team_planner.expect_and_dismiss_toaster(message: I18n.t("js.notice_successful_update"))
team_planner.within_lane(user) do
team_planner.expect_event first_wp
@@ -141,7 +141,7 @@
retry_block do
team_planner.drag_wp_to_lane(third_wp, other_user)
end
- team_planner.expect_and_dismiss_toaster(message: I18n.t('js.notice_successful_update'))
+ team_planner.expect_and_dismiss_toaster(message: I18n.t("js.notice_successful_update"))
team_planner.within_lane(user) do
team_planner.expect_event first_wp
@@ -161,7 +161,7 @@
retry_block do
team_planner.drag_wp_to_lane(fourth_wp, other_user)
end
- team_planner.expect_and_dismiss_toaster(message: I18n.t('js.notice_successful_update'))
+ team_planner.expect_and_dismiss_toaster(message: I18n.t("js.notice_successful_update"))
team_planner.within_lane(user) do
team_planner.expect_event first_wp
@@ -178,13 +178,13 @@
end
end
- it 'allows to resize to change the dates of a wp' do
+ it "allows to resize to change the dates of a wp" do
retry_block do
# Change date of second_wp by resizing it
team_planner.change_wp_date_by_resizing(second_wp, number_of_days: 1, is_start_date: true)
end
- team_planner.expect_and_dismiss_toaster(message: I18n.t('js.notice_successful_update'))
+ team_planner.expect_and_dismiss_toaster(message: I18n.t("js.notice_successful_update"))
# The date has changed, but the assignee remains unchanged.
# Because of the hierarchy, the first wp is updated, too.
@@ -204,7 +204,7 @@
retry_block do
team_planner.drag_wp_by_pixel(second_wp, -150, 0)
end
- team_planner.expect_and_dismiss_toaster(message: I18n.t('js.notice_successful_update'))
+ team_planner.expect_and_dismiss_toaster(message: I18n.t("js.notice_successful_update"))
first_wp.reload
second_wp.reload
@@ -229,7 +229,7 @@
retry_block do
team_planner.drag_wp_by_pixel(fourth_wp, 150, 0)
end
- team_planner.expect_and_dismiss_toaster(message: I18n.t('js.notice_successful_update'))
+ team_planner.expect_and_dismiss_toaster(message: I18n.t("js.notice_successful_update"))
fourth_wp.reload
expect(fourth_wp.start_date).to eq(Time.zone.today.beginning_of_week.next_occurring(:wednesday))
@@ -238,7 +238,7 @@
end
end
- context 'without permission to edit' do
+ context "without permission to edit" do
current_user { other_user }
before do
@@ -248,7 +248,7 @@
team_planner.add_assignee other_user
end
- it 'allows neither dragging nor resizing any wp' do
+ it "allows neither dragging nor resizing any wp" do
team_planner.expect_wp_not_resizable(first_wp)
team_planner.expect_wp_not_resizable(second_wp)
team_planner.expect_wp_not_resizable(third_wp)
diff --git a/modules/team_planner/spec/features/team_planner_view_modes_spec.rb b/modules/team_planner/spec/features/team_planner_view_modes_spec.rb
index 56ded17546f8..9bd264483650 100644
--- a/modules/team_planner/spec/features/team_planner_view_modes_spec.rb
+++ b/modules/team_planner/spec/features/team_planner_view_modes_spec.rb
@@ -26,44 +26,44 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_context'
+require "spec_helper"
+require_relative "shared_context"
-RSpec.describe 'Team planner', :js, with_ee: %i[team_planner_view] do
- include_context 'with team planner full access'
+RSpec.describe "Team planner", :js, with_ee: %i[team_planner_view] do
+ include_context "with team planner full access"
- it 'allows switching of view modes', with_settings: { working_days: [1, 2, 3, 4, 5] } do
+ it "allows switching of view modes", with_settings: { working_days: [1, 2, 3, 4, 5] } do
team_planner.visit!
team_planner.expect_empty_state
team_planner.add_assignee user.name
- team_planner.expect_view_mode 'Work week'
- expect(page).to have_css('.fc-timeline-slot-frame', count: 5)
+ team_planner.expect_view_mode "Work week"
+ expect(page).to have_css(".fc-timeline-slot-frame", count: 5)
# weekly: Expect 7 slots
- team_planner.switch_view_mode '1-week'
- expect(page).to have_css('.fc-timeline-slot-frame', count: 7)
+ team_planner.switch_view_mode "1-week"
+ expect(page).to have_css(".fc-timeline-slot-frame", count: 7)
# 2 weeks: expect 14 slots
- team_planner.switch_view_mode '2-week'
- expect(page).to have_css('.fc-timeline-slot-frame', count: 14)
+ team_planner.switch_view_mode "2-week"
+ expect(page).to have_css(".fc-timeline-slot-frame", count: 14)
start_of_week = Time.zone.today.beginning_of_week(:sunday)
- start_date = start_of_week.strftime('%d %a')
- end_date = (start_of_week + 13.days).strftime('%d %a')
+ start_date = start_of_week.strftime("%d %a")
+ end_date = (start_of_week + 13.days).strftime("%d %a")
- expect(page).to have_css('.fc-timeline-slot', text: start_date)
- expect(page).to have_css('.fc-timeline-slot', text: end_date)
+ expect(page).to have_css(".fc-timeline-slot", text: start_date)
+ expect(page).to have_css(".fc-timeline-slot", text: end_date)
# Click next button, advance one week
- find('.fc-next-button').click
+ find(".fc-next-button").click
start_of_week = (Time.zone.today + 1.week).beginning_of_week(:sunday)
- start_date = start_of_week.strftime('%d %a')
- end_date = (start_of_week + 13.days).strftime('%d %a')
+ start_date = start_of_week.strftime("%d %a")
+ end_date = (start_of_week + 13.days).strftime("%d %a")
- expect(page).to have_css('.fc-timeline-slot', text: start_date)
- expect(page).to have_css('.fc-timeline-slot', text: end_date)
+ expect(page).to have_css(".fc-timeline-slot", text: start_date)
+ expect(page).to have_css(".fc-timeline-slot", text: end_date)
end
end
diff --git a/modules/team_planner/spec/permissions/view_team_planner_spec.rb b/modules/team_planner/spec/permissions/view_team_planner_spec.rb
index 395b4b4aaf46..115767b52d0d 100644
--- a/modules/team_planner/spec/permissions/view_team_planner_spec.rb
+++ b/modules/team_planner/spec/permissions/view_team_planner_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'support/permission_specs'
+require "spec_helper"
+require "support/permission_specs"
-RSpec.describe TeamPlanner::TeamPlannerController, 'view_team_planner permission', type: :controller do
+RSpec.describe TeamPlanner::TeamPlannerController, "view_team_planner permission", type: :controller do
include PermissionSpecs
- check_permission_required_for('team_planner/team_planner#index', :view_team_planner)
+ check_permission_required_for("team_planner/team_planner#index", :view_team_planner)
end
diff --git a/modules/team_planner/spec/requests/api/v3/views/create_resource_spec.rb b/modules/team_planner/spec/requests/api/v3/views/create_resource_spec.rb
index 3afeb541f10c..936e42baae79 100644
--- a/modules/team_planner/spec/requests/api/v3/views/create_resource_spec.rb
+++ b/modules/team_planner/spec/requests/api/v3/views/create_resource_spec.rb
@@ -25,10 +25,10 @@
#
# See COPYRIGHT and LICENSE files for more details.
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Views::ViewsAPI,
- 'create',
+ "create",
content_type: :json do
include API::V3::Utilities::PathHelper
@@ -65,7 +65,7 @@
end
let(:send_request) do
- post api_v3_paths.views_type('team_planner'), body
+ post api_v3_paths.views_type("team_planner"), body
end
current_user { permitted_user }
@@ -78,25 +78,25 @@
send_request
end
- describe 'POST /api/v3/views/team_planner' do
- context 'with a user allowed to save the query' do
- it 'returns 201 CREATED' do
+ describe "POST /api/v3/views/team_planner" do
+ context "with a user allowed to save the query" do
+ it "returns 201 CREATED" do
expect(response.status)
.to eq(201)
end
- it 'returns the view' do
+ it "returns the view" do
expect(response.body)
- .to be_json_eql('Views::TeamPlanner'.to_json)
- .at_path('_type')
+ .to be_json_eql("Views::TeamPlanner".to_json)
+ .at_path("_type")
expect(response.body)
.to be_json_eql(View.last.id.to_json)
- .at_path('id')
+ .at_path("id")
end
end
- context 'with a user not allowed to manage team planners' do
+ context "with a user not allowed to manage team planners" do
let(:additional_setup) do
role.update_attribute(:permissions,
%w[view_work_packages
@@ -104,7 +104,7 @@
manage_public_queries])
end
- it_behaves_like 'unauthorized access'
+ it_behaves_like "unauthorized access"
end
end
end
diff --git a/modules/team_planner/spec/routing/team_planner_routing_spec.rb b/modules/team_planner/spec/routing/team_planner_routing_spec.rb
index b19c3fcefdba..3bb81a2d0ee1 100644
--- a/modules/team_planner/spec/routing/team_planner_routing_spec.rb
+++ b/modules/team_planner/spec/routing/team_planner_routing_spec.rb
@@ -26,71 +26,71 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Team planner routing' do
- it 'routes to team_planner#overview' do
+RSpec.describe "Team planner routing" do
+ it "routes to team_planner#overview" do
expect(subject)
- .to route(:get, '/team_planners')
- .to(controller: 'team_planner/team_planner', action: :overview)
+ .to route(:get, "/team_planners")
+ .to(controller: "team_planner/team_planner", action: :overview)
end
- it 'routes to team_planner#index' do
+ it "routes to team_planner#index" do
expect(subject)
- .to route(:get, '/projects/foobar/team_planners')
- .to(controller: 'team_planner/team_planner', action: :index, project_id: 'foobar')
+ .to route(:get, "/projects/foobar/team_planners")
+ .to(controller: "team_planner/team_planner", action: :index, project_id: "foobar")
end
- it 'routes to team_planner#show' do
+ it "routes to team_planner#show" do
expect(subject)
- .to route(:get, '/projects/foobar/team_planners/1234')
- .to(controller: 'team_planner/team_planner', action: :show, project_id: 'foobar', id: '1234')
+ .to route(:get, "/projects/foobar/team_planners/1234")
+ .to(controller: "team_planner/team_planner", action: :show, project_id: "foobar", id: "1234")
end
- context 'with :project_id' do
- it 'routes to team_planner#upsale' do
+ context "with :project_id" do
+ it "routes to team_planner#upsale" do
expect(subject)
- .to route(:get, '/projects/foobar/team_planners/upsale')
- .to(controller: 'team_planner/team_planner', action: :upsale, project_id: 'foobar')
+ .to route(:get, "/projects/foobar/team_planners/upsale")
+ .to(controller: "team_planner/team_planner", action: :upsale, project_id: "foobar")
end
- it 'routes to team_planner#show' do
+ it "routes to team_planner#show" do
expect(subject)
- .to route(:get, '/projects/foobar/team_planners/new')
- .to(controller: 'team_planner/team_planner', action: :show, project_id: 'foobar')
+ .to route(:get, "/projects/foobar/team_planners/new")
+ .to(controller: "team_planner/team_planner", action: :show, project_id: "foobar")
end
end
- context 'without :project_id' do
- it 'routes to team_planner#upsale' do
+ context "without :project_id" do
+ it "routes to team_planner#upsale" do
expect(subject)
- .to route(:get, '/team_planners/upsale')
- .to(controller: 'team_planner/team_planner', action: :upsale)
+ .to route(:get, "/team_planners/upsale")
+ .to(controller: "team_planner/team_planner", action: :upsale)
end
- it 'routes to team_planner#new' do
+ it "routes to team_planner#new" do
expect(subject)
- .to route(:get, '/team_planners/new')
- .to(controller: 'team_planner/team_planner', action: :new)
+ .to route(:get, "/team_planners/new")
+ .to(controller: "team_planner/team_planner", action: :new)
end
end
- it 'routes to team_planner#create' do
+ it "routes to team_planner#create" do
expect(subject)
- .to route(:post, '/team_planners')
- .to(controller: 'team_planner/team_planner', action: :create)
+ .to route(:post, "/team_planners")
+ .to(controller: "team_planner/team_planner", action: :create)
end
- it 'routes to team_planner#show with state' do
+ it "routes to team_planner#show with state" do
expect(subject)
- .to route(:get, '/projects/foobar/team_planners/1234/details/555')
- .to(controller: 'team_planner/team_planner', action: :show, project_id: 'foobar', id: '1234',
- state: 'details/555')
+ .to route(:get, "/projects/foobar/team_planners/1234/details/555")
+ .to(controller: "team_planner/team_planner", action: :show, project_id: "foobar", id: "1234",
+ state: "details/555")
end
- it 'routes to team_planner#destroy' do
+ it "routes to team_planner#destroy" do
expect(subject)
- .to route(:delete, '/projects/foobar/team_planners/1234')
- .to(controller: 'team_planner/team_planner', action: :destroy, project_id: 'foobar', id: '1234')
+ .to route(:delete, "/projects/foobar/team_planners/1234")
+ .to(controller: "team_planner/team_planner", action: :destroy, project_id: "foobar", id: "1234")
end
end
diff --git a/modules/team_planner/spec/services/team_planner/views/global_create_service_spec.rb b/modules/team_planner/spec/services/team_planner/views/global_create_service_spec.rb
index c790749f6233..a804b663e5e3 100644
--- a/modules/team_planner/spec/services/team_planner/views/global_create_service_spec.rb
+++ b/modules/team_planner/spec/services/team_planner/views/global_create_service_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe TeamPlanner::Views::GlobalCreateService, with_ee: %i[team_planner_view] do
shared_let(:project) { create(:project) }
@@ -37,27 +37,27 @@
subject { instance.call(params) }
- context 'with all valid params' do
+ context "with all valid params" do
let(:params) do
{
- name: 'Gotham Renewal',
+ name: "Gotham Renewal",
project_id: project.id,
public: true,
starred: false
}
end
- it 'is successful' do
+ it "is successful" do
expect(subject).to be_success
end
- it 'creates a team planner view and its query' do
+ it "creates a team planner view and its query" do
view = subject.result
query = view.query
- expect(view.type).to eq 'team_planner'
+ expect(view.type).to eq "team_planner"
- expect(query.name).to eq 'Gotham Renewal'
+ expect(query.name).to eq "Gotham Renewal"
expect(query.project).to eql(project)
expect(query).to be_public
expect(query).not_to be_starred
diff --git a/modules/team_planner/spec/support/onboarding/onboarding_steps.rb b/modules/team_planner/spec/support/onboarding/onboarding_steps.rb
index 2b9022d594f3..cb73b8d271da 100644
--- a/modules/team_planner/spec/support/onboarding/onboarding_steps.rb
+++ b/modules/team_planner/spec/support/onboarding/onboarding_steps.rb
@@ -29,7 +29,7 @@
module OnboardingSteps
def step_through_onboarding_team_planner_tour
next_button.click
- expect(page).to have_text sanitize_string(I18n.t('js.onboarding.steps.team_planner.overview')), normalize_ws: true
+ expect(page).to have_text sanitize_string(I18n.t("js.onboarding.steps.team_planner.overview")), normalize_ws: true
next_button.click
# The team planner (and in fact every PartitionedQuerySpacePageComponent page) suffers from not being shown upon
@@ -43,22 +43,22 @@ def step_through_onboarding_team_planner_tour
retry_block do
page.execute_script("document.querySelector('#content').dispatchEvent(new MouseEvent('mouseover'));")
- page.find('.enjoy_hint_label',
- text: sanitize_string(I18n.t('js.onboarding.steps.team_planner.calendar')),
+ page.find(".enjoy_hint_label",
+ text: sanitize_string(I18n.t("js.onboarding.steps.team_planner.calendar")),
normalize_ws: true)
end
next_button.click
expect(page)
- .to have_text sanitize_string(I18n.t('js.onboarding.steps.team_planner.add_assignee')), normalize_ws: true
+ .to have_text sanitize_string(I18n.t("js.onboarding.steps.team_planner.add_assignee")), normalize_ws: true
next_button.click
expect(page)
- .to have_text sanitize_string(I18n.t('js.onboarding.steps.team_planner.add_existing')), normalize_ws: true
+ .to have_text sanitize_string(I18n.t("js.onboarding.steps.team_planner.add_existing")), normalize_ws: true
next_button.click
expect(page)
- .to have_text sanitize_string(I18n.t('js.onboarding.steps.team_planner.card')), normalize_ws: true
+ .to have_text sanitize_string(I18n.t("js.onboarding.steps.team_planner.card")), normalize_ws: true
end
end
diff --git a/modules/team_planner/spec/support/pages/team_planner.rb b/modules/team_planner/spec/support/pages/team_planner.rb
index 5b83fd3f574c..6332f6a38663 100644
--- a/modules/team_planner/spec/support/pages/team_planner.rb
+++ b/modules/team_planner/spec/support/pages/team_planner.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'support/pages/page'
-require 'support/pages/work_packages/work_package_cards'
+require "support/pages/page"
+require "support/pages/work_packages/work_package_cards"
module Pages
class TeamPlanner < ::Pages::WorkPackageCards
@@ -45,18 +45,18 @@ def path
new_project_team_planners_path(project)
end
- def expect_title(title = 'Unnamed team planner')
- expect(page).to have_css('.editable-toolbar-title--input') { |node| node.value == title }
+ def expect_title(title = "Unnamed team planner")
+ expect(page).to have_css(".editable-toolbar-title--input") { |node| node.value == title }
end
def save_as(name)
- click_setting_item 'Save as'
+ click_setting_item "Save as"
- fill_in 'save-query-name', with: name
+ fill_in "save-query-name", with: name
- click_button 'Save'
+ click_button "Save"
- expect_toast message: 'Successful creation.'
+ expect_toast message: "Successful creation."
expect_title name
end
@@ -67,17 +67,17 @@ def click_setting_item(label)
def expect_empty_state(present: true)
expect(page).to have_conditional_selector(present,
- '.op-team-planner--no-data',
- text: 'Add assignees to set up your team planner.')
+ ".op-team-planner--no-data",
+ text: "Add assignees to set up your team planner.")
end
def expect_view_mode(text)
expect(page).to have_css('[data-test-selector="op-team-planner--view-select-dropdown"]', text:)
param = {
- 'Work week' => :resourceTimelineWorkWeek,
- '1-week' => :resourceTimelineWeek,
- '2-week' => :resourceTimelineTwoWeeks
+ "Work week" => :resourceTimelineWorkWeek,
+ "1-week" => :resourceTimelineWeek,
+ "2-week" => :resourceTimelineTwoWeeks
}[text]
expect(page).to have_current_path(/cview=#{param}/)
@@ -87,7 +87,7 @@ def switch_view_mode(text)
retry_block do
find('[data-test-selector="op-team-planner--view-select-dropdown"]').click
- within('#op-team-planner--view-select-dropdown') do
+ within("#op-team-planner--view-select-dropdown") do
click_button(text)
end
end
@@ -97,7 +97,7 @@ def switch_view_mode(text)
def expect_assignee(user, present: true)
name = user.is_a?(User) ? user.name : user.to_s
- expect(page).to have_conditional_selector(present, '.fc-resource', text: name, wait: 10)
+ expect(page).to have_conditional_selector(present, ".fc-resource", text: name, wait: 10)
end
def add_item(assignee, start_date, end_date)
@@ -131,26 +131,26 @@ def within_lane(user, &)
def expect_event(work_package, present: true)
if present
- expect(page).to have_css('.fc-event', text: work_package.subject, wait: 10)
+ expect(page).to have_css(".fc-event", text: work_package.subject, wait: 10)
else
- expect(page).to have_no_css('.fc-event', text: work_package.subject)
+ expect(page).to have_no_css(".fc-event", text: work_package.subject)
end
end
def expect_resizable(work_package, resizable: true)
if resizable
- expect(page).to have_css('.fc-event.fc-event-resizable', text: work_package.subject, wait: 10)
+ expect(page).to have_css(".fc-event.fc-event-resizable", text: work_package.subject, wait: 10)
else
- expect(page).to have_css('.fc-event:not(.fc-event-resizable)', text: work_package.subject, wait: 10)
+ expect(page).to have_css(".fc-event:not(.fc-event-resizable)", text: work_package.subject, wait: 10)
end
end
def expect_no_views_rendered
- expect(page).to have_text 'There is currently nothing to display.'
+ expect(page).to have_text "There is currently nothing to display."
end
def expect_views_rendered(*queries)
- rendered_query_names = all('td.name').map(&:text)
+ rendered_query_names = all("td.name").map(&:text)
expect(rendered_query_names).to match_array(queries.map(&:name))
end
@@ -168,65 +168,65 @@ def expect_no_delete_buttons_for(*queries)
end
def expect_view_not_rendered(query)
- expect(page).to have_no_css 'td', text: query.name
+ expect(page).to have_no_css "td", text: query.name
end
def expect_create_button
- within '.toolbar-items' do
- expect(page).to have_link text: 'Team planner'
+ within ".toolbar-items" do
+ expect(page).to have_link text: "Team planner"
end
end
def expect_no_create_button
- within '.toolbar-items' do
- expect(page).to have_no_link text: 'Team planner'
+ within ".toolbar-items" do
+ expect(page).to have_no_link text: "Team planner"
end
end
def expect_views_listed_in_order(*queries)
- within '.generic-table tbody' do
- listed_view_names = all('tr td.name').map(&:text)
+ within ".generic-table tbody" do
+ listed_view_names = all("tr td.name").map(&:text)
expect(listed_view_names).to eq(queries.map(&:name))
end
end
def click_on_create_button
- within '.toolbar-items' do
- click_link 'Team planner'
+ within ".toolbar-items" do
+ click_link "Team planner"
end
end
def click_on_cancel_button
- click_on 'Cancel'
+ click_on "Cancel"
end
def set_title(title)
- fill_in 'Title', with: title
+ fill_in "Title", with: title
end
def set_project(project)
select_autocomplete(find('[data-test-selector="project_id"]'),
query: project,
- results_selector: 'body',
+ results_selector: "body",
wait_for_fetched_options: false)
end
def set_public
- check 'Public'
+ check "Public"
end
def set_favoured
- check 'Favoured'
+ check "Favoured"
end
def click_on_submit
- click_on 'Create'
+ click_on "Create"
end
def add_assignee(name)
retry_block do
- return if page.has_selector?('.fc-resource', text: name, wait: 0)
+ return if page.has_selector?(".fc-resource", text: name, wait: 0)
click_add_user
page.find("#{page.test_selector('tp-add-assignee')} input")
@@ -240,7 +240,7 @@ def search_assignee(name)
page.find("#{page.test_selector('tp-add-assignee')} input")
search_autocomplete page.find('[data-test-selector="tp-add-assignee"]'),
query: name,
- results_selector: 'body'
+ results_selector: "body"
end
end
@@ -254,7 +254,7 @@ def click_add_user
def select_user_to_add(name)
select_autocomplete page.find('[data-test-selector="tp-add-assignee"]'),
query: name,
- results_selector: 'body'
+ results_selector: "body"
end
def expect_user_selectable(user, present: true)
@@ -262,7 +262,7 @@ def expect_user_selectable(user, present: true)
expect_ng_option page.find('[data-test-selector="tp-add-assignee"]'),
name,
- results_selector: 'body',
+ results_selector: "body",
present:
end
@@ -276,7 +276,7 @@ def change_wp_date_by_resizing(work_package, number_of_days:, is_start_date:)
.move_to(wp_strip.native)
.perform
- resizer = is_start_date ? wp_strip.find('.fc-event-resizer-start') : wp_strip.find('.fc-event-resizer-end')
+ resizer = is_start_date ? wp_strip.find(".fc-event-resizer-start") : wp_strip.find(".fc-event-resizer-end")
drag_by_pixel(element: resizer, by_x: number_of_days * 250, by_y: 0) unless resizer.nil?
end
@@ -310,9 +310,9 @@ def drag_to_remove_dropzone(work_package, expect_removable: true)
drag_element_to(dropzone)
if expect_removable
- expect(page).to have_css('span', text: I18n.t('js.team_planner.drag_here_to_remove'))
+ expect(page).to have_css("span", text: I18n.t("js.team_planner.drag_here_to_remove"))
else
- expect(page).to have_css('span', text: I18n.t('js.team_planner.cannot_drag_here'))
+ expect(page).to have_css("span", text: I18n.t("js.team_planner.cannot_drag_here"))
end
drag_release
@@ -328,7 +328,7 @@ def drag_to_remove_dropzone(work_package, expect_removable: true)
end
def event(work_package)
- page.find('.fc-event', text: work_package.subject)
+ page.find(".fc-event", text: work_package.subject)
end
def lane(user)
@@ -339,15 +339,15 @@ def lane(user)
end
def expect_wp_not_resizable(work_package)
- expect(page).to have_css('.fc-event:not(.fc-event-resizable)', text: work_package.subject)
+ expect(page).to have_css(".fc-event:not(.fc-event-resizable)", text: work_package.subject)
end
def expect_wp_not_draggable(work_package)
- expect(page).to have_css('.fc-event:not(.fc-event-draggable)', text: work_package.subject)
+ expect(page).to have_css(".fc-event:not(.fc-event-draggable)", text: work_package.subject)
end
def expect_no_menu_item(name)
- expect(page).to have_no_css('.op-sidemenu--item-title', text: name)
+ expect(page).to have_no_css(".op-sidemenu--item-title", text: name)
end
def y_distance(from:, to:)
@@ -359,8 +359,8 @@ def y_center(element)
end
def wait_for_loaded
- expect(page).to have_css('.op-team-planner--wp-loading-skeleton')
- expect(page).to have_no_css('.op-team-planner--wp-loading-skeleton', wait: 10)
+ expect(page).to have_css(".op-team-planner--wp-loading-skeleton")
+ expect(page).to have_no_css(".op-team-planner--wp-loading-skeleton", wait: 10)
end
end
end
diff --git a/modules/two_factor_authentication/Gemfile b/modules/two_factor_authentication/Gemfile
index 851fabc21ddb..3be9c3cd812e 100644
--- a/modules/two_factor_authentication/Gemfile
+++ b/modules/two_factor_authentication/Gemfile
@@ -1,2 +1,2 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
gemspec
diff --git a/modules/two_factor_authentication/app/components/two_factor_authentication/devices/row_component.rb b/modules/two_factor_authentication/app/components/two_factor_authentication/devices/row_component.rb
index f5fb85361938..df46c05bfd9c 100644
--- a/modules/two_factor_authentication/app/components/two_factor_authentication/devices/row_component.rb
+++ b/modules/two_factor_authentication/app/components/two_factor_authentication/devices/row_component.rb
@@ -17,21 +17,21 @@ def device_type
def default
if device.default
- helpers.op_icon 'icon-yes'
+ helpers.op_icon "icon-yes"
else
- '-'
+ "-"
end
end
def confirmed
if device.active
- helpers.op_icon 'icon-yes'
+ helpers.op_icon "icon-yes"
elsif table.self_table?
- link_to t('two_factor_authentication.devices.confirm_now'),
+ link_to t("two_factor_authentication.devices.confirm_now"),
{ controller: table.target_controller, action: :confirm, device_id: device.id }
else
- helpers.op_icon 'icon-no'
+ helpers.op_icon "icon-no"
end
end
@@ -49,17 +49,17 @@ def make_default_link
device,
url: { controller: table.target_controller, action: :make_default, device_id: device.id },
method: :post,
- html: { id: 'two_factor_make_default_form', class: 'form--inline' }
+ html: { id: "two_factor_make_default_form", class: "form--inline" }
) do |f|
f.submit I18n.t(:button_make_default),
- class: 'button--link two-factor--mark-default-button'
+ class: "button--link two-factor--mark-default-button"
end
end
def delete_link
title =
if deletion_blocked?
- I18n.t('two_factor_authentication.devices.is_default_cannot_delete')
+ I18n.t("two_factor_authentication.devices.is_default_cannot_delete")
else
I18n.t(:button_delete)
end
@@ -68,10 +68,10 @@ def delete_link
device,
url: { controller: table.target_controller, action: :destroy, device_id: device.id },
method: :delete,
- html: { id: 'two_factor_delete_form', class: '' }
+ html: { id: "two_factor_delete_form", class: "" }
) do |f|
f.submit I18n.t(:button_delete),
- class: 'button--link two-factor--delete-button',
+ class: "button--link two-factor--delete-button",
disabled: deletion_blocked?,
title:
end
@@ -85,7 +85,7 @@ def deletion_blocked?
def column_css_class(_column)
if device.default
- 'mobile-otp--device-default'
+ "mobile-otp--device-default"
end
end
end
diff --git a/modules/two_factor_authentication/app/components/two_factor_authentication/devices/table_component.rb b/modules/two_factor_authentication/app/components/two_factor_authentication/devices/table_component.rb
index e689d01a5ab9..ce1bb3df4022 100644
--- a/modules/two_factor_authentication/app/components/two_factor_authentication/devices/table_component.rb
+++ b/modules/two_factor_authentication/app/components/two_factor_authentication/devices/table_component.rb
@@ -18,9 +18,9 @@ def admin_table?
def target_controller
if self_table?
- 'two_factor_authentication/my/two_factor_devices'
+ "two_factor_authentication/my/two_factor_devices"
else
- 'two_factor_authentication/users/two_factor_devices'
+ "two_factor_authentication/users/two_factor_devices"
end
end
@@ -31,9 +31,9 @@ def sortable?
def inline_create_link
if self_table?
link_to({ controller: target_controller, action: :new },
- class: 'budget-add-row wp-inline-create--add-link',
- title: I18n.t('two_factor_authentication.devices.add_new')) do
- helpers.op_icon('icon icon-add')
+ class: "budget-add-row wp-inline-create--add-link",
+ title: I18n.t("two_factor_authentication.devices.add_new")) do
+ helpers.op_icon("icon icon-add")
end
end
end
@@ -46,17 +46,17 @@ def strategy_manager
def empty_row_message
if admin_table?
- I18n.t 'two_factor_authentication.admin.no_devices_for_user'
+ I18n.t "two_factor_authentication.admin.no_devices_for_user"
else
- I18n.t 'two_factor_authentication.devices.not_existing'
+ I18n.t "two_factor_authentication.devices.not_existing"
end
end
def headers
[
- ['device_type', { caption: I18n.t('two_factor_authentication.label_device_type') }],
- ['default', { caption: I18n.t(:label_default) }],
- ['confirmed', { caption: I18n.t(:label_confirmed) }]
+ ["device_type", { caption: I18n.t("two_factor_authentication.label_device_type") }],
+ ["default", { caption: I18n.t(:label_default) }],
+ ["confirmed", { caption: I18n.t(:label_confirmed) }]
]
end
end
diff --git a/modules/two_factor_authentication/app/controllers/concerns/two_factor_authentication/backup_codes.rb b/modules/two_factor_authentication/app/controllers/concerns/two_factor_authentication/backup_codes.rb
index b13833e99d86..c5d1eace0985 100644
--- a/modules/two_factor_authentication/app/controllers/concerns/two_factor_authentication/backup_codes.rb
+++ b/modules/two_factor_authentication/app/controllers/concerns/two_factor_authentication/backup_codes.rb
@@ -12,14 +12,14 @@ def enter_backup_code
# Verify backup code
def verify_backup_code
code = params[:backup_code]
- return fail_login(t('two_factor_authentication.error_invalid_backup_code')) unless code.present?
+ return fail_login(t("two_factor_authentication.error_invalid_backup_code")) unless code.present?
service = TwoFactorAuthentication::UseBackupCodeService.new user: @authenticated_user
result = service.verify code
if result.success?
complete_stage_redirect
else
- fail_login(t('two_factor_authentication.error_invalid_backup_code'))
+ fail_login(t("two_factor_authentication.error_invalid_backup_code"))
end
end
end
diff --git a/modules/two_factor_authentication/app/controllers/two_factor_authentication/forced_registration/two_factor_devices_controller.rb b/modules/two_factor_authentication/app/controllers/two_factor_authentication/forced_registration/two_factor_devices_controller.rb
index bedf5f1dcf69..384d95fec427 100644
--- a/modules/two_factor_authentication/app/controllers/two_factor_authentication/forced_registration/two_factor_devices_controller.rb
+++ b/modules/two_factor_authentication/app/controllers/two_factor_authentication/forced_registration/two_factor_devices_controller.rb
@@ -41,13 +41,13 @@ def register # rubocop:disable Metrics/AbcSize
if needs_confirmation
redirect_to action: :confirm, device_id: @device.id
else
- flash[:notice] = t('two_factor_authentication.devices.registration_complete')
+ flash[:notice] = t("two_factor_authentication.devices.registration_complete")
@device.confirm_registration_and_save
redirect_to registration_success_path
end
else
Rails.logger.warn { "User ##{target_user.id} forced to register failed for #{@device_type}." }
- render 'two_factor_authentication/two_factor_devices/new'
+ render "two_factor_authentication/two_factor_devices/new"
end
end
@@ -76,7 +76,7 @@ def registration_failure_path
##
# Ensure the authentication stage from the core provided the authenticated user
def require_authenticated_user
- raise ArgumentError, 'Missing param' unless session[:authenticated_user_force_2fa]
+ raise ArgumentError, "Missing param" unless session[:authenticated_user_force_2fa]
@authenticated_user = User.find(session[:authenticated_user_id])
true
diff --git a/modules/two_factor_authentication/app/controllers/two_factor_authentication/my/backup_codes_controller.rb b/modules/two_factor_authentication/app/controllers/two_factor_authentication/my/backup_codes_controller.rb
index d76c26b22150..9ed10ef1d1ed 100644
--- a/modules/two_factor_authentication/app/controllers/two_factor_authentication/my/backup_codes_controller.rb
+++ b/modules/two_factor_authentication/app/controllers/two_factor_authentication/my/backup_codes_controller.rb
@@ -11,7 +11,7 @@ class BackupCodesController < ::ApplicationController
# Verify that flash was set (coming from create)
before_action :check_regenerate_done, only: [:show]
- layout 'my'
+ layout "my"
menu_item :two_factor_authentication
def create
diff --git a/modules/two_factor_authentication/app/controllers/two_factor_authentication/my/remember_cookie_controller.rb b/modules/two_factor_authentication/app/controllers/two_factor_authentication/my/remember_cookie_controller.rb
index ae7b5c8c56ac..3f9d0d520557 100644
--- a/modules/two_factor_authentication/app/controllers/two_factor_authentication/my/remember_cookie_controller.rb
+++ b/modules/two_factor_authentication/app/controllers/two_factor_authentication/my/remember_cookie_controller.rb
@@ -7,14 +7,14 @@ class RememberCookieController < ::ApplicationController
# Ensure user is logged in
before_action :require_login
- layout 'my'
+ layout "my"
menu_item :two_factor_authentication
##
# Remove the remember token
def destroy
clear_remember_token!
- flash[:notice] = I18n.t('two_factor_authentication.remember.cookie_removed')
+ flash[:notice] = I18n.t("two_factor_authentication.remember.cookie_removed")
redirect_to my_2fa_devices_path
end
end
diff --git a/modules/two_factor_authentication/app/controllers/two_factor_authentication/my/two_factor_devices_controller.rb b/modules/two_factor_authentication/app/controllers/two_factor_authentication/my/two_factor_devices_controller.rb
index 7ffaccafaafb..d8d2844cbf06 100644
--- a/modules/two_factor_authentication/app/controllers/two_factor_authentication/my/two_factor_devices_controller.rb
+++ b/modules/two_factor_authentication/app/controllers/two_factor_authentication/my/two_factor_devices_controller.rb
@@ -19,7 +19,7 @@ class TwoFactorDevicesController < ::TwoFactorAuthentication::BaseController
# Delete remember token on destroy
before_action :clear_remember_token!, only: [:destroy]
- layout 'my'
+ layout "my"
menu_item :two_factor_authentication
def index
@@ -51,13 +51,13 @@ def register # rubocop:disable Metrics/AbcSize
if needs_confirmation
redirect_to action: :confirm, device_id: @device.id
else
- flash[:notice] = t('two_factor_authentication.devices.registration_complete')
+ flash[:notice] = t("two_factor_authentication.devices.registration_complete")
@device.confirm_registration_and_save
redirect_to registration_success_path
end
else
Rails.logger.warn { "User ##{current_user.id} failed to register a device #{@device_type}." }
- render 'two_factor_authentication/two_factor_devices/new'
+ render "two_factor_authentication/two_factor_devices/new"
end
end
@@ -81,8 +81,8 @@ def request_device_confirmation_token
request_token_for_device(
@device,
confirm_path: url_for(action: :confirm, device_id: @device.id),
- title: I18n.t('two_factor_authentication.devices.confirm_device'),
- message: I18n.t('two_factor_authentication.devices.text_confirm_to_complete_html', identifier: @device.identifier)
+ title: I18n.t("two_factor_authentication.devices.confirm_device"),
+ message: I18n.t("two_factor_authentication.devices.text_confirm_to_complete_html", identifier: @device.identifier)
)
end
@@ -93,10 +93,10 @@ def request_token_for_device(device, locals)
flash[:notice] = transmit.result if transmit.result.present?
# Request confirmation from user as in the regular login flow
- render 'two_factor_authentication/two_factor_devices/confirm', layout: 'base', locals:
+ render "two_factor_authentication/two_factor_devices/confirm", layout: "base", locals:
else
error = transmit.errors.full_messages.join(". ")
- default_message = t('two_factor_authentication.devices.confirm_send_failed')
+ default_message = t("two_factor_authentication.devices.confirm_send_failed")
flash[:error] = "#{default_message} #{error}"
redirect_to action: :index
diff --git a/modules/two_factor_authentication/app/controllers/two_factor_authentication/two_factor_settings_controller.rb b/modules/two_factor_authentication/app/controllers/two_factor_authentication/two_factor_settings_controller.rb
index c1e74978c7dd..41d46935a51b 100644
--- a/modules/two_factor_authentication/app/controllers/two_factor_authentication/two_factor_settings_controller.rb
+++ b/modules/two_factor_authentication/app/controllers/two_factor_authentication/two_factor_settings_controller.rb
@@ -4,11 +4,11 @@ class TwoFactorSettingsController < ApplicationController
before_action :require_admin
before_action :check_enabled
- layout 'admin'
+ layout "admin"
menu_item :two_factor_authentication
def show
- render template: 'two_factor_authentication/settings',
+ render template: "two_factor_authentication/settings",
locals: {
settings: Setting.plugin_openproject_two_factor_authentication,
strategy_manager: manager,
@@ -24,7 +24,7 @@ def update
flash[:notice] = I18n.t(:notice_successful_update)
rescue ArgumentError => e
Setting.plugin_openproject_two_factor_authentication = current_settings
- flash[:error] = I18n.t('two_factor_authentication.settings.failed_to_save_settings', message: e.message)
+ flash[:error] = I18n.t("two_factor_authentication.settings.failed_to_save_settings", message: e.message)
Rails.logger.error "Failed to save 2FA settings: #{e.message}"
end
@@ -53,7 +53,7 @@ def manager
end
def default_breadcrumb
- t('two_factor_authentication.settings.title')
+ t("two_factor_authentication.settings.title")
end
def show_local_breadcrumb
diff --git a/modules/two_factor_authentication/app/controllers/two_factor_authentication/users/two_factor_devices_controller.rb b/modules/two_factor_authentication/app/controllers/two_factor_authentication/users/two_factor_devices_controller.rb
index f41a771062f0..7d438e05e25a 100644
--- a/modules/two_factor_authentication/app/controllers/two_factor_authentication/users/two_factor_devices_controller.rb
+++ b/modules/two_factor_authentication/app/controllers/two_factor_authentication/users/two_factor_devices_controller.rb
@@ -34,7 +34,7 @@ def register
redirect_to index_path
else
Rails.logger.info "Admin ##{current_user.id} failed to register a new device #{@device_type} for #{@user.id}."
- render 'two_factor_authentication/two_factor_devices/new'
+ render "two_factor_authentication/two_factor_devices/new"
end
end
@@ -42,7 +42,7 @@ def register
# Delete all devices
def delete_all
@user.otp_devices.delete_all
- flash[:notice] = I18n.t('two_factor_authentication.admin.all_devices_deleted')
+ flash[:notice] = I18n.t("two_factor_authentication.admin.all_devices_deleted")
redirect_to index_path
end
@@ -54,7 +54,7 @@ def make_default
if @device.make_default!
flash[:notice] = t(:notice_successful_update)
else
- flash[:error] = t('two_factor_authentication.devices.make_default_failed')
+ flash[:error] = t("two_factor_authentication.devices.make_default_failed")
end
redirect_to index_path
@@ -64,14 +64,14 @@ def make_default
# Destroy the given device if its not the default
def destroy
if @device.default && strategy_manager.enforced?
- render_400 message: t('two_factor_authentication.devices.is_default_cannot_delete')
+ render_400 message: t("two_factor_authentication.devices.is_default_cannot_delete")
return
end
if @device.destroy
flash[:notice] = t(:notice_successful_delete)
else
- flash[:error] = t('two_factor_authentication.devices.failed_to_delete')
+ flash[:error] = t("two_factor_authentication.devices.failed_to_delete")
Rails.logger.error "Failed to delete #{@device.id} of user#{@user.id}. Errors: #{@device.errors.full_messages.join(' ')}"
end
@@ -81,9 +81,9 @@ def destroy
private
def ensure_only_sms_type
- return if params[:type] == 'sms'
+ return if params[:type] == "sms"
- render_400(message: I18n.t('two_factor_authentication.admin.only_sms_allowed'))
+ render_400(message: I18n.t("two_factor_authentication.admin.only_sms_allowed"))
end
def new_device_params
@@ -115,7 +115,7 @@ def target_user
def require_not_self
if current_user.id == @user.id
- render_403(message: I18n.t('two_factor_authentication.admin.self_edit_forbidden'))
+ render_403(message: I18n.t("two_factor_authentication.admin.self_edit_forbidden"))
end
end
end
diff --git a/modules/two_factor_authentication/app/models/two_factor_authentication.rb b/modules/two_factor_authentication/app/models/two_factor_authentication.rb
index ece37388ac85..b56bf137a297 100644
--- a/modules/two_factor_authentication/app/models/two_factor_authentication.rb
+++ b/modules/two_factor_authentication/app/models/two_factor_authentication.rb
@@ -1,5 +1,5 @@
module TwoFactorAuthentication
def self.table_name_prefix
- 'two_factor_authentication_'
+ "two_factor_authentication_"
end
end
diff --git a/modules/two_factor_authentication/app/models/two_factor_authentication/device.rb b/modules/two_factor_authentication/app/models/two_factor_authentication/device.rb
index 9618588635c8..9c47b969f396 100644
--- a/modules/two_factor_authentication/app/models/two_factor_authentication/device.rb
+++ b/modules/two_factor_authentication/app/models/two_factor_authentication/device.rb
@@ -1,6 +1,6 @@
module TwoFactorAuthentication
class Device < ApplicationRecord
- default_scope { order('id ASC') }
+ default_scope { order("id ASC") }
belongs_to :user
validates_presence_of :user_id
diff --git a/modules/two_factor_authentication/app/models/two_factor_authentication/device/sms.rb b/modules/two_factor_authentication/app/models/two_factor_authentication/device/sms.rb
index 54496f4774f2..b8640ef04dcc 100644
--- a/modules/two_factor_authentication/app/models/two_factor_authentication/device/sms.rb
+++ b/modules/two_factor_authentication/app/models/two_factor_authentication/device/sms.rb
@@ -43,19 +43,19 @@ def default_identifier
def request_2fa_identifier(channel)
channel_name =
if channel == :sms
- 'SMS'
+ "SMS"
else
- 'Voice'
+ "Voice"
end
- I18n.t 'two_factor_authentication.devices.sms.request_2fa_identifier',
+ I18n.t "two_factor_authentication.devices.sms.request_2fa_identifier",
redacted_identifier:, delivery_channel: channel_name
end
def redacted_identifier
number = phone_number.dup
- number[1..-3] = '*' * number[1..-3].length
- I18n.t 'two_factor_authentication.devices.sms.redacted_identifier',
+ number[1..-3] = "*" * number[1..-3].length
+ I18n.t "two_factor_authentication.devices.sms.redacted_identifier",
redacted_number: number
end
diff --git a/modules/two_factor_authentication/app/models/two_factor_authentication/device/totp.rb b/modules/two_factor_authentication/app/models/two_factor_authentication/device/totp.rb
index a4570de8a15b..cfee774b9918 100644
--- a/modules/two_factor_authentication/app/models/two_factor_authentication/device/totp.rb
+++ b/modules/two_factor_authentication/app/models/two_factor_authentication/device/totp.rb
@@ -1,4 +1,4 @@
-require 'rotp'
+require "rotp"
module TwoFactorAuthentication
class Device::Totp < Device
@@ -57,11 +57,11 @@ def provisioning_url
end
def allowed_drift
- self.class.manager.configuration['otp_drift_window'] || 60
+ self.class.manager.configuration["otp_drift_window"] || 60
end
def totp
- @totp ||= ::ROTP::TOTP.new otp_secret, issuer: Setting.app_title.presence || 'OpenProject'
+ @totp ||= ::ROTP::TOTP.new otp_secret, issuer: Setting.app_title.presence || "OpenProject"
end
end
end
diff --git a/modules/two_factor_authentication/app/models/two_factor_authentication/login_token.rb b/modules/two_factor_authentication/app/models/two_factor_authentication/login_token.rb
index 846376fe21ec..4ce92b142366 100644
--- a/modules/two_factor_authentication/app/models/two_factor_authentication/login_token.rb
+++ b/modules/two_factor_authentication/app/models/two_factor_authentication/login_token.rb
@@ -8,7 +8,7 @@ def self.validity_time
def self.generate_token_value
chars = ("0".."9").to_a
- password = ''
+ password = ""
6.times { |_i| password << chars[rand(chars.size - 1)] }
password
end
diff --git a/modules/two_factor_authentication/app/models/two_factor_authentication/remembered_auth_token.rb b/modules/two_factor_authentication/app/models/two_factor_authentication/remembered_auth_token.rb
index 09f8c3b9f60d..730d7a69b717 100644
--- a/modules/two_factor_authentication/app/models/two_factor_authentication/remembered_auth_token.rb
+++ b/modules/two_factor_authentication/app/models/two_factor_authentication/remembered_auth_token.rb
@@ -22,7 +22,7 @@ def single_value?
def validate_remember_time
unless self.class.allow_remember_for_days > 0
- errors.add :base, 'Invalid remember time'
+ errors.add :base, "Invalid remember time"
end
end
diff --git a/modules/two_factor_authentication/app/services/two_factor_authentication/token_service.rb b/modules/two_factor_authentication/app/services/two_factor_authentication/token_service.rb
index f8e8e021f189..84a0ff401b04 100644
--- a/modules/two_factor_authentication/app/services/two_factor_authentication/token_service.rb
+++ b/modules/two_factor_authentication/app/services/two_factor_authentication/token_service.rb
@@ -88,13 +88,13 @@ def get_matching_strategy
##
# Perform service checks for the request and validate endpoints of this service
def verify_device_and_strategy
- raise I18n.t('two_factor_authentication.error_2fa_disabled') unless manager.enabled?
+ raise I18n.t("two_factor_authentication.error_2fa_disabled") unless manager.enabled?
# Ensure the user's default device for OTP exists
- raise I18n.t('two_factor_authentication.error_no_device') if device.nil?
+ raise I18n.t("two_factor_authentication.error_no_device") if device.nil?
# Ensure a matching registered strategy for the device's channel exists
- raise I18n.t('two_factor_authentication.error_no_matching_strategy') if strategy.nil?
+ raise I18n.t("two_factor_authentication.error_no_matching_strategy") if strategy.nil?
end
def manager
diff --git a/modules/two_factor_authentication/app/services/two_factor_authentication/use_backup_code_service.rb b/modules/two_factor_authentication/app/services/two_factor_authentication/use_backup_code_service.rb
index 1a90bfbb8448..19d9d160adb1 100644
--- a/modules/two_factor_authentication/app/services/two_factor_authentication/use_backup_code_service.rb
+++ b/modules/two_factor_authentication/app/services/two_factor_authentication/use_backup_code_service.rb
@@ -13,7 +13,7 @@ def initialize(user:)
def verify(code)
token = user.otp_backup_codes.find_by_plaintext_value(code)
- raise I18n.t('two_factor_authentication.error_invalid_backup_code') if token.nil?
+ raise I18n.t("two_factor_authentication.error_invalid_backup_code") if token.nil?
use_valid_token! token
rescue StandardError => e
diff --git a/modules/two_factor_authentication/config/routes.rb b/modules/two_factor_authentication/config/routes.rb
index b3c15627233a..27fbab7b1430 100644
--- a/modules/two_factor_authentication/config/routes.rb
+++ b/modules/two_factor_authentication/config/routes.rb
@@ -1,24 +1,24 @@
Rails.application.routes.draw do
- namespace 'two_factor_authentication' do
- get :request, to: 'authentication#request_otp'
- post :confirm, to: 'authentication#confirm_otp'
- post :retry, to: 'authentication#retry'
- get :backup_code, to: 'authentication#enter_backup_code'
- post :backup_code, to: 'authentication#verify_backup_code'
+ namespace "two_factor_authentication" do
+ get :request, to: "authentication#request_otp"
+ post :confirm, to: "authentication#confirm_otp"
+ post :retry, to: "authentication#retry"
+ get :backup_code, to: "authentication#enter_backup_code"
+ post :backup_code, to: "authentication#verify_backup_code"
- get :settings, to: 'two_factor_settings#show', as: 'settings_2fa'
- post :settings, to: 'two_factor_settings#update', as: 'update_settings_2fa'
+ get :settings, to: "two_factor_settings#show", as: "settings_2fa"
+ post :settings, to: "two_factor_settings#update", as: "update_settings_2fa"
# Request a challenge for WebAuthn
- get :webauthn_challenge, to: 'authentication#webauthn_challenge', as: 'webauthn_challenge'
+ get :webauthn_challenge, to: "authentication#webauthn_challenge", as: "webauthn_challenge"
end
- scope 'two_factor_authentication' do # Avoids adding the namespace prefix
+ scope "two_factor_authentication" do # Avoids adding the namespace prefix
# forced registration
- scope 'device_registration', controller: 'two_factor_authentication/forced_registration/two_factor_devices' do
- get :new, action: :new, as: 'new_forced_2fa_device'
- post :register, action: :register, as: 'register_forced_2fa_device'
- match '/:device_id/confirm', action: :confirm, via: %i[get post], as: 'confirm_forced_2fa_device'
+ scope "device_registration", controller: "two_factor_authentication/forced_registration/two_factor_devices" do
+ get :new, action: :new, as: "new_forced_2fa_device"
+ post :register, action: :register, as: "register_forced_2fa_device"
+ match "/:device_id/confirm", action: :confirm, via: %i[get post], as: "confirm_forced_2fa_device"
# Request a challenge for WebAuthn
get :webauthn_challenge
@@ -29,8 +29,8 @@
member do
resources :two_factor_devices,
param: :device_id,
- controller: 'two_factor_authentication/users/two_factor_devices',
- as: 'user_2fa_devices',
+ controller: "two_factor_authentication/users/two_factor_devices",
+ as: "user_2fa_devices",
only: %i[new create destroy] do
# Register new device ( 'create' )
post :register, on: :collection
@@ -44,21 +44,21 @@
end
end
- scope 'my' do
+ scope "my" do
resource :backup_codes,
- controller: 'two_factor_authentication/my/backup_codes',
- as: 'my_2fa_backup_codes',
+ controller: "two_factor_authentication/my/backup_codes",
+ as: "my_2fa_backup_codes",
only: %i[show create]
resource :remember_cookie,
- controller: 'two_factor_authentication/my/remember_cookie',
- as: 'my_2fa_remember_cookie',
+ controller: "two_factor_authentication/my/remember_cookie",
+ as: "my_2fa_remember_cookie",
only: [:destroy]
resources :two_factor_devices,
- controller: 'two_factor_authentication/my/two_factor_devices',
+ controller: "two_factor_authentication/my/two_factor_devices",
param: :device_id,
- as: 'my_2fa_devices',
+ as: "my_2fa_devices",
only: %i[index new destroy] do
# Register new device ( 'create' )
post :register, on: :collection
diff --git a/modules/two_factor_authentication/db/migrate/20120214103300_aggregated_mobile_otp_migrations.rb b/modules/two_factor_authentication/db/migrate/20120214103300_aggregated_mobile_otp_migrations.rb
index 205526f0b008..c50a84634baf 100644
--- a/modules/two_factor_authentication/db/migrate/20120214103300_aggregated_mobile_otp_migrations.rb
+++ b/modules/two_factor_authentication/db/migrate/20120214103300_aggregated_mobile_otp_migrations.rb
@@ -28,7 +28,7 @@
require Rails.root.join("db/migrate/migration_utils/migration_squasher").to_s
require Rails.root.join("db/migrate/migration_utils/setting_renamer").to_s
-require 'open_project/plugins/migration_mapping'
+require "open_project/plugins/migration_mapping"
# This migration aggregates the migrations detailed in MIGRATION_FILES
class AggregatedMobileOtpMigrations < ActiveRecord::Migration[5.0]
diff --git a/modules/two_factor_authentication/db/migrate/20130214130336_add_default_otp_channel_to_user.rb b/modules/two_factor_authentication/db/migrate/20130214130336_add_default_otp_channel_to_user.rb
index 6133bab639c2..c4ae6a4318b7 100644
--- a/modules/two_factor_authentication/db/migrate/20130214130336_add_default_otp_channel_to_user.rb
+++ b/modules/two_factor_authentication/db/migrate/20130214130336_add_default_otp_channel_to_user.rb
@@ -28,7 +28,7 @@
class AddDefaultOtpChannelToUser < ActiveRecord::Migration[5.0]
def self.up
- add_column :users, :default_otp_channel, :string, default: 'text'
+ add_column :users, :default_otp_channel, :string, default: "text"
end
def self.down
diff --git a/modules/two_factor_authentication/db/migrate/20160331190036_change_default_channel.rb b/modules/two_factor_authentication/db/migrate/20160331190036_change_default_channel.rb
index b9583c128b4b..341bc62bcb00 100644
--- a/modules/two_factor_authentication/db/migrate/20160331190036_change_default_channel.rb
+++ b/modules/two_factor_authentication/db/migrate/20160331190036_change_default_channel.rb
@@ -28,12 +28,12 @@
class ChangeDefaultChannel < ActiveRecord::Migration[5.0]
def self.up
- change_column_default(:users, :default_otp_channel, 'sms')
- User.where(default_otp_channel: 'text').update_all(default_otp_channel: 'sms')
+ change_column_default(:users, :default_otp_channel, "sms")
+ User.where(default_otp_channel: "text").update_all(default_otp_channel: "sms")
end
def self.down
- change_column_default(:users, :default_otp_channel, 'text')
- User.where(default_otp_channel: 'sms').update_all(default_otp_channel: 'text')
+ change_column_default(:users, :default_otp_channel, "text")
+ User.where(default_otp_channel: "sms").update_all(default_otp_channel: "text")
end
end
diff --git a/modules/two_factor_authentication/db/migrate/20171023190036_model_reorganization.rb b/modules/two_factor_authentication/db/migrate/20171023190036_model_reorganization.rb
index 53a58d84075a..02b677236d15 100644
--- a/modules/two_factor_authentication/db/migrate/20171023190036_model_reorganization.rb
+++ b/modules/two_factor_authentication/db/migrate/20171023190036_model_reorganization.rb
@@ -55,7 +55,7 @@ def self.up
t.integer "last_used_at", null: true
# OTP secret for totp
- t.text 'otp_secret', null: true
+ t.text "otp_secret", null: true
end
add_reference :two_factor_authentication_devices, :user, foreign_key: true, type: :integer
@@ -67,7 +67,7 @@ def self.up
sms = ::TwoFactorAuthentication::Device::Sms.create!(
user_id: user.id,
- identifier: 'Mobile',
+ identifier: "Mobile",
channel: user.default_otp_channel,
phone_number: phone,
active: true
@@ -76,7 +76,7 @@ def self.up
end
end
- change_table 'users' do |t|
+ change_table "users" do |t|
t.remove :verified_phone
t.remove :unverified_phone
t.remove :default_otp_channel
@@ -84,10 +84,10 @@ def self.up
end
def self.down
- change_table 'users' do |t|
+ change_table "users" do |t|
t.string :verified_phone
t.string :unverified_phone
- t.string :default_otp_channel, default: 'sms'
+ t.string :default_otp_channel, default: "sms"
end
# Write back information from sms devices to table
diff --git a/modules/two_factor_authentication/lib/open_project/two_factor_authentication/engine.rb b/modules/two_factor_authentication/lib/open_project/two_factor_authentication/engine.rb
index 6b7a9cfc16be..becd5206b7d0 100644
--- a/modules/two_factor_authentication/lib/open_project/two_factor_authentication/engine.rb
+++ b/modules/two_factor_authentication/lib/open_project/two_factor_authentication/engine.rb
@@ -1,5 +1,5 @@
-require 'open_project/plugins'
-require 'webauthn'
+require "open_project/plugins"
+require "webauthn"
module OpenProject::TwoFactorAuthentication
class Engine < ::Rails::Engine
@@ -7,8 +7,8 @@ class Engine < ::Rails::Engine
include OpenProject::Plugins::ActsAsOpEngine
- register 'openproject-two_factor_authentication',
- author_url: 'https://www.openproject.org',
+ register "openproject-two_factor_authentication",
+ author_url: "https://www.openproject.org",
settings: {
default: {
# Only app-based 2FA allowed per default
@@ -19,21 +19,21 @@ class Engine < ::Rails::Engine
# Don't allow remember cookie
allow_remember_for_days: 0
},
- env_alias: 'OPENPROJECT_2FA'
+ env_alias: "OPENPROJECT_2FA"
},
bundled: true do
menu :my_menu,
:two_factor_authentication,
- { controller: '/two_factor_authentication/my/two_factor_devices', action: :index },
- caption: ->(*) { I18n.t('two_factor_authentication.label_two_factor_authentication') },
+ { controller: "/two_factor_authentication/my/two_factor_devices", action: :index },
+ caption: ->(*) { I18n.t("two_factor_authentication.label_two_factor_authentication") },
after: :password,
if: ->(*) { ::OpenProject::TwoFactorAuthentication::TokenStrategyManager.enabled? },
- icon: 'two-factor-authentication'
+ icon: "two-factor-authentication"
menu :admin_menu,
:two_factor_authentication,
- { controller: '/two_factor_authentication/two_factor_settings', action: :show },
- caption: ->(*) { I18n.t('two_factor_authentication.label_two_factor_authentication') },
+ { controller: "/two_factor_authentication/two_factor_settings", action: :show },
+ caption: ->(*) { I18n.t("two_factor_authentication.label_two_factor_authentication") },
parent: :authentication,
if: ->(*) { ::OpenProject::TwoFactorAuthentication::TokenStrategyManager.configurable_by_ui? }
end
@@ -41,10 +41,10 @@ class Engine < ::Rails::Engine
patches %i[User]
add_tab_entry :user,
- name: 'two_factor_authentication',
- partial: 'users/two_factor_authentication',
+ name: "two_factor_authentication",
+ partial: "users/two_factor_authentication",
path: ->(params) { edit_user_path(params[:user], tab: :two_factor_authentication) },
- label: 'two_factor_authentication.label_two_factor_authentication',
+ label: "two_factor_authentication.label_two_factor_authentication",
only_if: ->(*) { User.current.admin? && OpenProject::TwoFactorAuthentication::TokenStrategyManager.enabled? }
config.to_prepare do
diff --git a/modules/two_factor_authentication/lib/open_project/two_factor_authentication/patches/user_patch.rb b/modules/two_factor_authentication/lib/open_project/two_factor_authentication/patches/user_patch.rb
index 47318247dfb5..6c4f8d001952 100644
--- a/modules/two_factor_authentication/lib/open_project/two_factor_authentication/patches/user_patch.rb
+++ b/modules/two_factor_authentication/lib/open_project/two_factor_authentication/patches/user_patch.rb
@@ -2,9 +2,9 @@ module OpenProject::TwoFactorAuthentication::Patches
module UserPatch
def self.included(base)
base.class_eval do
- has_many :otp_tokens, class_name: 'TwoFactorAuthentication::LoginToken', dependent: :destroy
- has_many :otp_devices, class_name: 'TwoFactorAuthentication::Device', dependent: :destroy
- has_many :otp_backup_codes, class_name: 'TwoFactorAuthentication::BackupCode', dependent: :destroy
+ has_many :otp_tokens, class_name: "TwoFactorAuthentication::LoginToken", dependent: :destroy
+ has_many :otp_devices, class_name: "TwoFactorAuthentication::Device", dependent: :destroy
+ has_many :otp_backup_codes, class_name: "TwoFactorAuthentication::BackupCode", dependent: :destroy
end
end
end
diff --git a/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy/base.rb b/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy/base.rb
index f17222a067e0..d2db49090035 100644
--- a/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy/base.rb
+++ b/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy/base.rb
@@ -7,7 +7,7 @@ def initialize(user:, device:, channel: nil)
@channel = channel.presence || device.channel
unless self.class.supported?(device.channel)
- raise ArgumentError, I18n.t('two_factor_authentication.channel_unavailable', channel: device.channel)
+ raise ArgumentError, I18n.t("two_factor_authentication.channel_unavailable", channel: device.channel)
end
@user = user
@@ -16,7 +16,7 @@ def initialize(user:, device:, channel: nil)
def verify(input_token, **)
# Ensure this strategy uses mobile tokens or overrode this method
- raise 'Cannot verify mobile token' unless self.class.mobile_token?
+ raise "Cannot verify mobile token" unless self.class.mobile_token?
token = user.otp_tokens.find_by_plaintext_value(input_token)
@@ -44,7 +44,7 @@ def identifier
end
def transmit_success_message
- I18n.t('two_factor_authentication.mobile_transmit_notification')
+ I18n.t("two_factor_authentication.mobile_transmit_notification")
end
def self.mobile_token?
diff --git a/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy/message_bird.rb b/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy/message_bird.rb
index eef8f1387ac2..336360644196 100644
--- a/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy/message_bird.rb
+++ b/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy/message_bird.rb
@@ -1,11 +1,11 @@
-require 'messagebird'
+require "messagebird"
module OpenProject::TwoFactorAuthentication
module TokenStrategy
class MessageBird < Base
def self.validate!
if configuration_params.nil?
- raise ArgumentError, 'Missing configuration hash'
+ raise ArgumentError, "Missing configuration hash"
end
validate_params configuration_params
@@ -35,16 +35,16 @@ def send_sms
params[:message],
validity: 720
- raise "Failed to deliver SMS" if response.recipients['totalDeliveryFailedCount'] > 0
+ raise "Failed to deliver SMS" if response.recipients["totalDeliveryFailedCount"] > 0
rescue StandardError => e
Rails.logger.error("[2FA] MessageBird SMS delivery failed for user #{user.login}. Error: #{e} #{e.message}")
- raise I18n.t('two_factor_authentication.message_bird.sms_delivery_failed')
+ raise I18n.t("two_factor_authentication.message_bird.sms_delivery_failed")
end
##
# TODO ensure the originator cannot be larger than 11 characters
def originator
- 'OpenProject'
+ "OpenProject"
end
def send_voice
@@ -56,14 +56,14 @@ def send_voice
ifMachine: :continue,
language: params[:language]
- raise "Failed to initiate voice message" if response.recipients['totalDeliveryFailedCount'] > 0
+ raise "Failed to initiate voice message" if response.recipients["totalDeliveryFailedCount"] > 0
rescue StandardError => e
Rails.logger.error("[2FA] MessageBird VOICE delivery failed for user #{user.login}. Error: #{e} #{e.message}")
- raise I18n.t('two_factor_authentication.message_bird.voice_delivery_failed')
+ raise I18n.t("two_factor_authentication.message_bird.voice_delivery_failed")
end
def message_bird_client
- ::MessageBird::Client.new(configuration_params['apikey'])
+ ::MessageBird::Client.new(configuration_params["apikey"])
end
##
@@ -136,7 +136,7 @@ def get_matching_language(language)
##
# Fallback language
def fallback_language
- :'en-us'
+ :"en-us"
end
##
@@ -151,11 +151,11 @@ def has_localized_text?(locale_key)
##
# Localize the message
def localized_message(locale_key, token_value, fallback: true, raise_on_missing: false)
- pause = ''
+ pause = ""
# Output pauses for TTS in voice mode
if channel.to_sym == :voice
- token_value = token_value.split('').join('')
+ token_value = token_value.split("").join('')
pause = ''
end
@@ -173,7 +173,7 @@ def localized_message(locale_key, token_value, fallback: true, raise_on_missing:
# Output format: xxyyyyyyyyyy
def build_recipients(params)
phone = device.phone_number
- phone.gsub!(/[+\s]/, '')
+ phone.gsub!(/[+\s]/, "")
params[:recipients] = phone
end
diff --git a/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy/sns.rb b/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy/sns.rb
index b6514851a602..bf75a9ce96d9 100644
--- a/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy/sns.rb
+++ b/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy/sns.rb
@@ -1,5 +1,5 @@
-require 'net/http'
-require 'aws-sdk-sns'
+require "net/http"
+require "aws-sdk-sns"
module OpenProject::TwoFactorAuthentication
module TokenStrategy
@@ -48,7 +48,7 @@ def build_sms_params
end
def build_token_text(token)
- I18n.t('two_factor_authentication.text_otp_delivery_message_sms', app_title: Setting.app_title, token:)
+ I18n.t("two_factor_authentication.text_otp_delivery_message_sms", app_title: Setting.app_title, token:)
end
##
@@ -57,24 +57,24 @@ def build_token_text(token)
# Stored format: +xx yyy yyy yyyy (optional whitespacing)
def build_user_phone
phone = device.phone_number
- phone.gsub!(/\s/, '')
+ phone.gsub!(/\s/, "")
phone
end
# rubocop:disable Metrics/AbcSize
def submit
- aws_params = configuration_params.slice 'region', 'access_key_id', 'secret_access_key'
+ aws_params = configuration_params.slice "region", "access_key_id", "secret_access_key"
sns = ::Aws::SNS::Client.new aws_params
sns.set_sms_attributes(
attributes: {
# Use transactional message type to ensure timely delivery.
# Amazon SNS optimizes the message delivery to achieve the highest reliability.
- 'DefaultSMSType' => 'Transactional',
+ "DefaultSMSType" => "Transactional",
# Set sender ID name (may not be supported in all countries)
- 'DefaultSenderID' => configuration_params.fetch('sender_id', 'OpenProject')
+ "DefaultSenderID" => configuration_params.fetch("sender_id", "OpenProject")
}
)
@@ -94,7 +94,7 @@ def submit
"[2FA] SNS delivery failed for user #{user.login} (Error: #{e})"
end
- raise I18n.t('two_factor_authentication.sns.delivery_failed')
+ raise I18n.t("two_factor_authentication.sns.delivery_failed")
end
# rubocop:enable Metrics/AbcSize
end
diff --git a/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy/totp.rb b/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy/totp.rb
index 4221c8cd5a99..d1431aad5fb9 100644
--- a/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy/totp.rb
+++ b/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy/totp.rb
@@ -1,4 +1,4 @@
-require 'rotp'
+require "rotp"
module OpenProject::TwoFactorAuthentication
module TokenStrategy
diff --git a/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy/webauthn.rb b/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy/webauthn.rb
index 3c035a22130c..6a511ee78135 100644
--- a/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy/webauthn.rb
+++ b/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy/webauthn.rb
@@ -1,4 +1,4 @@
-require 'webauthn'
+require "webauthn"
module OpenProject::TwoFactorAuthentication
module TokenStrategy
diff --git a/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy_manager.rb b/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy_manager.rb
index 558adf26bcbb..a212beced7e7 100644
--- a/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy_manager.rb
+++ b/modules/two_factor_authentication/lib/open_project/two_factor_authentication/token_strategy_manager.rb
@@ -51,17 +51,17 @@ def admin_register_sms_strategy
##
# Whether the system requires 2FA for all users
def enforced?
- !!configuration['enforced']
+ !!configuration["enforced"]
end
##
# Determine whether the plugin settings can be changed from the UI
def configurable_by_ui?
- !configuration['hide_settings_menu_item']
+ !configuration["hide_settings_menu_item"]
end
def allow_remember_for_days
- configuration['allow_remember_for_days'].to_i
+ configuration["allow_remember_for_days"].to_i
end
##
@@ -73,7 +73,7 @@ def invalid_configuration?
##
# Fetch all active strategies
def active_strategies
- configuration.fetch('active_strategies', [])
+ configuration.fetch("active_strategies", [])
.map(&:to_s)
.uniq
.map { |strategy| lookup_active_strategy strategy }
@@ -107,18 +107,18 @@ def configuration
end
def enforced_by_configuration?
- enforced = (OpenProject::Configuration['2fa'] || {})['enforced']
+ enforced = (OpenProject::Configuration["2fa"] || {})["enforced"]
ActiveModel::Type::Boolean.new.cast enforced
end
def merge_with_settings!(config)
- config['active_strategies'] ||= []
+ config["active_strategies"] ||= []
# Always enable webauthn and totp if nothing is enabled
- config['active_strategies'] += %i[totp webauthn] if add_default_strategy?(config)
+ config["active_strategies"] += %i[totp webauthn] if add_default_strategy?(config)
end
def add_default_strategy?(config)
- config['active_strategies'].empty? && config['disabled'].blank?
+ config["active_strategies"].empty? && config["disabled"].blank?
end
def available_strategies
diff --git a/modules/two_factor_authentication/lib/openproject-two_factor_authentication.rb b/modules/two_factor_authentication/lib/openproject-two_factor_authentication.rb
index 520554f8269a..e5913b2cef82 100644
--- a/modules/two_factor_authentication/lib/openproject-two_factor_authentication.rb
+++ b/modules/two_factor_authentication/lib/openproject-two_factor_authentication.rb
@@ -1 +1 @@
-require 'open_project/two_factor_authentication'
+require "open_project/two_factor_authentication"
diff --git a/modules/two_factor_authentication/openproject-two_factor_authentication.gemspec b/modules/two_factor_authentication/openproject-two_factor_authentication.gemspec
index 369b9e4377c8..ed69c02057e4 100644
--- a/modules/two_factor_authentication/openproject-two_factor_authentication.gemspec
+++ b/modules/two_factor_authentication/openproject-two_factor_authentication.gemspec
@@ -1,6 +1,6 @@
Gem::Specification.new do |s|
s.name = "openproject-two_factor_authentication"
- s.version = '1.0.0'
+ s.version = "1.0.0"
s.authors = "OpenProject GmbH"
s.email = "info@openproject.com"
s.summary = "OpenProject Two-factor authentication"
@@ -10,10 +10,10 @@ Gem::Specification.new do |s|
s.files = Dir["{app,config,db,lib}/**/*", "CHANGELOG.md", "README.rdoc"]
- s.add_dependency 'messagebird-rest', '~> 1.4.2'
- s.add_dependency 'rotp', '~> 6.1'
- s.add_dependency 'webauthn', '~> 3.0'
+ s.add_dependency "messagebird-rest", "~> 1.4.2"
+ s.add_dependency "rotp", "~> 6.1"
+ s.add_dependency "webauthn", "~> 3.0"
- s.add_dependency 'aws-sdk-sns', '~> 1.72.0'
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.add_dependency "aws-sdk-sns", "~> 1.72.0"
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/authentication_controller_shared_examples.rb b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/authentication_controller_shared_examples.rb
index cb6ea2cefd6a..4224071927c0 100644
--- a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/authentication_controller_shared_examples.rb
+++ b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/authentication_controller_shared_examples.rb
@@ -1,7 +1,7 @@
-require_relative '../../spec_helper'
+require_relative "../../spec_helper"
-RSpec.shared_examples 'immediate success login' do
- context 'with valid credentials' do
+RSpec.shared_examples "immediate success login" do
+ context "with valid credentials" do
it "does not yet log in user" do
expect(User.current).not_to eq(user)
end
@@ -11,12 +11,12 @@
end
it "renders redirect" do
- expect(response).to redirect_to stage_success_path(stage: :two_factor_authentication, secret: 'asdf')
+ expect(response).to redirect_to stage_success_path(stage: :two_factor_authentication, secret: "asdf")
end
end
end
-RSpec.shared_examples '2FA forced registry' do
+RSpec.shared_examples "2FA forced registry" do
it "does not log in user" do
expect(User.current).not_to eq(user)
end
@@ -35,7 +35,7 @@
end
end
-RSpec.shared_examples '2FA response failure' do |expected_error|
+RSpec.shared_examples "2FA response failure" do |expected_error|
it "does not log in user" do
expect(User.current).not_to eq(user)
end
@@ -50,17 +50,17 @@
end
end
-RSpec.shared_examples '2FA login request failure' do |expected_error|
+RSpec.shared_examples "2FA login request failure" do |expected_error|
before do
session[:authenticated_user_id] = user.id
get :request_otp
end
- it_behaves_like '2FA response failure', expected_error
+ it_behaves_like "2FA response failure", expected_error
end
-RSpec.shared_examples '2FA credentials authentication success' do
- describe 'requesting the token' do
+RSpec.shared_examples "2FA credentials authentication success" do
+ describe "requesting the token" do
before do
session[:authenticated_user_id] = user.id
get :request_otp
@@ -75,17 +75,17 @@
end
it "renders the login_otp" do
- expect(response).to render_template 'request_otp'
+ expect(response).to render_template "request_otp"
end
end
end
-RSpec.shared_examples '2FA login_otp fails without authenticated user' do
- describe 'follow-up post of the login token without authenticated user' do
+RSpec.shared_examples "2FA login_otp fails without authenticated user" do
+ describe "follow-up post of the login token without authenticated user" do
before do
# Assume the user is NOT pending
session[:authenticated_user_id] = nil
- post :confirm_otp, params: { otp: 'does not matter' }
+ post :confirm_otp, params: { otp: "does not matter" }
end
it "redirects to login page" do
@@ -98,15 +98,15 @@
end
end
-RSpec.shared_examples '2FA TOTP request success' do
+RSpec.shared_examples "2FA TOTP request success" do
# 1FA redirects to login_otp
- it_behaves_like '2FA credentials authentication success'
+ it_behaves_like "2FA credentials authentication success"
# Cannot post to login_otp without authenticated user session
- it_behaves_like '2FA login_otp fails without authenticated user'
+ it_behaves_like "2FA login_otp fails without authenticated user"
# Can post to login_otp with pending and token
- describe 'follow-up post of a login token' do
+ describe "follow-up post of a login token" do
before do
# Assume the user is pending
session[:authenticated_user_id] = user.id
@@ -114,36 +114,36 @@
post :confirm_otp, params: { otp: token }
end
- context 'with a valid token' do
+ context "with a valid token" do
let(:token) { device.totp.now }
- it_behaves_like 'immediate success login'
+ it_behaves_like "immediate success login"
end
- context 'with an invalid token' do
- let(:token) { 'bogus' }
+ context "with an invalid token" do
+ let(:token) { "bogus" }
- it_behaves_like '2FA response failure', I18n.t(:notice_account_otp_invalid)
+ it_behaves_like "2FA response failure", I18n.t(:notice_account_otp_invalid)
end
end
end
-RSpec.shared_examples '2FA SMS request success' do
+RSpec.shared_examples "2FA SMS request success" do
# 1FA redirects to login_otp
- it_behaves_like '2FA credentials authentication success'
+ it_behaves_like "2FA credentials authentication success"
# Cannot post to login_otp without pending user session
- it_behaves_like '2FA login_otp fails without authenticated user'
+ it_behaves_like "2FA login_otp fails without authenticated user"
- describe 'follow-up post of a login token' do
- let(:valid_token) { instance_double(TwoFactorAuthentication::LoginToken, value: '123456') }
+ describe "follow-up post of a login token" do
+ let(:valid_token) { instance_double(TwoFactorAuthentication::LoginToken, value: "123456") }
before do
# Assume the user is pending
session[:authenticated_user_id] = user.id
end
- context 'with a valid token' do
+ context "with a valid token" do
before do
# Return the value upon find
expect(TwoFactorAuthentication::LoginToken)
@@ -155,31 +155,31 @@
post :confirm_otp, params: { otp: valid_token.value }
end
- context 'when not expired' do
+ context "when not expired" do
let(:expired) { false }
- it_behaves_like 'immediate success login'
+ it_behaves_like "immediate success login"
end
- context 'when expired' do
+ context "when expired" do
let(:expired) { true }
- it_behaves_like '2FA response failure', I18n.t(:notice_account_otp_invalid)
+ it_behaves_like "2FA response failure", I18n.t(:notice_account_otp_invalid)
end
end
- context 'with an invalid token' do
+ context "with an invalid token" do
before do
# Return the value upon find
expect(TwoFactorAuthentication::LoginToken)
.to receive(:find_by_plaintext_value)
- .with('bogus')
+ .with("bogus")
.and_return(nil)
- post :confirm_otp, params: { otp: 'bogus' }
+ post :confirm_otp, params: { otp: "bogus" }
end
- it_behaves_like '2FA response failure', I18n.t(:notice_account_otp_invalid)
+ it_behaves_like "2FA response failure", I18n.t(:notice_account_otp_invalid)
end
end
end
diff --git a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/authentication_controller_spec.rb b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/authentication_controller_spec.rb
index a8233f4c85d6..82208614009b 100644
--- a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/authentication_controller_spec.rb
+++ b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/authentication_controller_spec.rb
@@ -1,29 +1,29 @@
-require_relative '../../spec_helper'
-require_relative 'authentication_controller_shared_examples'
+require_relative "../../spec_helper"
+require_relative "authentication_controller_shared_examples"
RSpec.describe TwoFactorAuthentication::AuthenticationController, with_settings: { login_required?: true } do
let(:valid_credentials) do
- { username: 'foobar', password: 'AAA1111!!!!' }
+ { username: "foobar", password: "AAA1111!!!!" }
end
- let(:user) { create(:user, login: 'foobar', password: 'AAA1111!!!!', password_confirmation: 'AAA1111!!!!') }
+ let(:user) { create(:user, login: "foobar", password: "AAA1111!!!!", password_confirmation: "AAA1111!!!!") }
before do
# Assume the user has any memberships
- session[:stage_secrets] = { two_factor_authentication: 'asdf' }
+ session[:stage_secrets] = { two_factor_authentication: "asdf" }
allow_any_instance_of(User).to receive(:any_active_memberships?).and_return(true)
end
- describe 'with no active strategy', with_settings: { 'plugin_openproject_two_factor_authentication' => {} } do
+ describe "with no active strategy", with_settings: { "plugin_openproject_two_factor_authentication" => {} } do
before do
session[:authenticated_user_id] = user.id
get :request_otp
end
- it_behaves_like 'immediate success login'
+ it_behaves_like "immediate success login"
end
- describe 'with no active strategy, but 2FA enforced as configuration',
- with_settings: { 'plugin_openproject_two_factor_authentication' => { active_strategies: [], enforced: true } } do
+ describe "with no active strategy, but 2FA enforced as configuration",
+ with_settings: { "plugin_openproject_two_factor_authentication" => { active_strategies: [], enforced: true } } do
before do
allow(OpenProject::TwoFactorAuthentication::TokenStrategyManager)
.to receive(:add_default_strategy?)
@@ -32,37 +32,37 @@
get :request_otp
end
- it 'returns a 500' do
+ it "returns a 500" do
expect(response.status).to eq 500
end
end
- describe 'with one active strategy, enforced', with_settings: {
- 'plugin_openproject_two_factor_authentication' => { active_strategies: [:developer], enforced: true }
+ describe "with one active strategy, enforced", with_settings: {
+ "plugin_openproject_two_factor_authentication" => { active_strategies: [:developer], enforced: true }
} do
- context 'with no device' do
+ context "with no device" do
before do
session[:authenticated_user_id] = user.id
get :request_otp
end
- it_behaves_like '2FA forced registry'
+ it_behaves_like "2FA forced registry"
end
end
- describe 'with one active strategy',
- with_settings: { 'plugin_openproject_two_factor_authentication' => { active_strategies: [:developer] } } do
- context 'with no device' do
+ describe "with one active strategy",
+ with_settings: { "plugin_openproject_two_factor_authentication" => { active_strategies: [:developer] } } do
+ context "with no device" do
before do
session[:authenticated_user_id] = user.id
get :request_otp
end
# User can login without 2FA, since its not enforced
- it_behaves_like 'immediate success login'
+ it_behaves_like "immediate success login"
end
- context 'with a non-default device' do
+ context "with a non-default device" do
let!(:device) { create(:two_factor_authentication_device_sms, user:, default: false, channel: :sms) }
before do
@@ -71,38 +71,38 @@
end
# User can login without 2FA, since its not enforced
- it_behaves_like 'immediate success login'
+ it_behaves_like "immediate success login"
end
- context 'with an invalid device' do
+ context "with an invalid device" do
let!(:device) { create(:two_factor_authentication_device_totp, user:, channel: :totp) }
- it_behaves_like '2FA login request failure', I18n.t('two_factor_authentication.error_no_matching_strategy')
+ it_behaves_like "2FA login request failure", I18n.t("two_factor_authentication.error_no_matching_strategy")
end
- context 'with an active device' do
+ context "with an active device" do
let!(:device) { create(:two_factor_authentication_device_sms, user:, channel: :sms) }
- it_behaves_like '2FA SMS request success'
+ it_behaves_like "2FA SMS request success"
end
end
- describe 'with two active strategy',
- with_settings: { 'plugin_openproject_two_factor_authentication' => { active_strategies: %i[developer totp] } } do
- context 'with a totp device' do
+ describe "with two active strategy",
+ with_settings: { "plugin_openproject_two_factor_authentication" => { active_strategies: %i[developer totp] } } do
+ context "with a totp device" do
let!(:device) { create(:two_factor_authentication_device_totp, user:, channel: :totp) }
- it_behaves_like '2FA TOTP request success'
+ it_behaves_like "2FA TOTP request success"
end
- context 'with an sms device' do
+ context "with an sms device" do
let!(:device) { create(:two_factor_authentication_device_sms, user:, channel: :sms) }
- it_behaves_like '2FA SMS request success'
+ it_behaves_like "2FA SMS request success"
end
end
- describe '#login_otp', "for a get request" do
+ describe "#login_otp", "for a get request" do
before do
get :confirm_otp
end
diff --git a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/forced_registration/two_factor_devices_controller_spec.rb b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/forced_registration/two_factor_devices_controller_spec.rb
index 3bdd4bb7c322..914fefebb05e 100644
--- a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/forced_registration/two_factor_devices_controller_spec.rb
+++ b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/forced_registration/two_factor_devices_controller_spec.rb
@@ -1,19 +1,19 @@
-require_relative '../../../spec_helper'
-require_relative '../authentication_controller_shared_examples'
+require_relative "../../../spec_helper"
+require_relative "../authentication_controller_shared_examples"
RSpec.describe TwoFactorAuthentication::ForcedRegistration::TwoFactorDevicesController do
- let(:user) { create(:user, login: 'foobar') }
+ let(:user) { create(:user, login: "foobar") }
let(:logged_in_user) { User.anonymous }
let(:active_strategies) { [] }
let(:authenticated_user_id) { user.id }
let(:user_force_2fa) { true }
- include_context 'with settings' do
+ include_context "with settings" do
let(:settings) do
{
plugin_openproject_two_factor_authentication: {
- 'active_strategies' => active_strategies
+ "active_strategies" => active_strategies
}
}
end
@@ -23,161 +23,161 @@
allow(User).to receive(:current).and_return(User.anonymous)
session[:authenticated_user_id] = authenticated_user_id
session[:authenticated_user_force_2fa] = user_force_2fa
- session[:stage_secrets] = { two_factor_authentication: 'asdf' }
+ session[:stage_secrets] = { two_factor_authentication: "asdf" }
allow(OpenProject::TwoFactorAuthentication::TokenStrategyManager)
.to receive(:add_default_strategy?)
.and_return false
end
- describe 'accessing' do
+ describe "accessing" do
before do
get :new
end
- context 'when no authenticated_user present' do
+ context "when no authenticated_user present" do
let(:active_strategies) { [:developer] }
let(:authenticated_user_id) { nil }
let(:user_force_2fa) { nil }
- it 'does not give access' do
+ it "does not give access" do
expect(response).to be_redirect
expect(response).to redirect_to stage_failure_path(stage: :two_factor_authentication)
end
end
- context 'when logged in, but not enabled' do
- it 'does not give access' do
+ context "when logged in, but not enabled" do
+ it "does not give access" do
expect(response.status).to eq 404
end
end
- context 'when authenticated in and active strategies' do
+ context "when authenticated in and active strategies" do
let(:active_strategies) { [:developer] }
- it 'renders the new page' do
+ it "renders the new page" do
expect(response).to be_successful
- expect(response).to render_template 'two_factor_authentication/two_factor_devices/new_type'
+ expect(response).to render_template "two_factor_authentication/two_factor_devices/new_type"
end
end
end
- describe 'with active strategy' do
+ describe "with active strategy" do
let(:active_strategies) { [:developer] }
- describe '#new' do
- context 'without type' do
+ describe "#new" do
+ context "without type" do
before do
get :new
end
- it 'renders the new form' do
+ it "renders the new form" do
expect(response).to be_successful
- expect(response).to render_template 'new_type'
+ expect(response).to render_template "new_type"
end
end
- context 'with type' do
+ context "with type" do
before do
get :new, params: { type: :sms }
end
- it 'renders the new form' do
+ it "renders the new form" do
expect(response).to be_successful
- expect(response).to render_template 'new'
+ expect(response).to render_template "new"
end
end
end
- describe '#register' do
+ describe "#register" do
before do
post :register, params: { key: :sms, device: params }
end
- context 'with missing phone' do
- let(:params) { { identifier: 'foo' } }
+ context "with missing phone" do
+ let(:params) { { identifier: "foo" } }
- it 'renders action new' do
+ it "renders action new" do
expect(response).to be_successful
- expect(response).to render_template 'new'
+ expect(response).to render_template "new"
expect(assigns[:device]).to be_invalid
end
end
- context 'with valid params' do
- let(:params) { { phone_number: '+49123456789', identifier: 'foo' } }
+ context "with valid params" do
+ let(:params) { { phone_number: "+49123456789", identifier: "foo" } }
- it 'redirects to confirm' do
+ it "redirects to confirm" do
device = user.otp_devices.reload.last
expect(response).to redirect_to action: :confirm, device_id: device.id
- expect(device.identifier).to eq 'foo (+49123456789)'
- expect(device.phone_number).to eq '+49123456789'
+ expect(device.identifier).to eq "foo (+49123456789)"
+ expect(device.phone_number).to eq "+49123456789"
expect(device.default).to be_falsey
expect(device.active).to be_falsey
end
end
end
- describe '#confirm' do
- describe '#get' do
- it 'croaks on missing id' do
+ describe "#confirm" do
+ describe "#get" do
+ it "croaks on missing id" do
get :confirm, params: { device_id: 1234 }
expect(response.status).to eq 404
end
- describe 'and registered totp device' do
+ describe "and registered totp device" do
let(:active_strategies) { [:totp] }
let!(:device) { create(:two_factor_authentication_device_totp, user:, active: false, default: false) }
- it 'renders the confirmation page' do
+ it "renders the confirmation page" do
get :confirm, params: { device_id: device.id }
expect(response).to be_successful
- expect(response).to render_template 'confirm'
+ expect(response).to render_template "confirm"
expect(flash[:notice]).not_to be_present
end
end
- describe 'with registered device' do
+ describe "with registered device" do
let!(:device) { create(:two_factor_authentication_device_sms, user:, active: false, default: false) }
- it 'renders the confirmation page' do
+ it "renders the confirmation page" do
get :confirm, params: { device_id: device.id }
expect(response).to be_successful
- expect(response).to render_template 'confirm'
+ expect(response).to render_template "confirm"
end
- it 'redirects to failure path if token request failed' do
+ it "redirects to failure path if token request failed" do
allow_any_instance_of(TwoFactorAuthentication::TokenService)
.to receive(:request)
.and_return(ServiceResult.failure)
get :confirm, params: { device_id: device.id }
expect(response).to redirect_to stage_failure_path(stage: :two_factor_authentication)
- expect(flash[:error]).to include I18n.t('two_factor_authentication.devices.confirm_send_failed')
+ expect(flash[:error]).to include I18n.t("two_factor_authentication.devices.confirm_send_failed")
end
end
end
- describe '#post' do
- it 'croaks on missing id' do
+ describe "#post" do
+ it "croaks on missing id" do
get :confirm, params: { device_id: 1234 }
expect(response.status).to eq 404
end
- describe 'and registered totp device' do
+ describe "and registered totp device" do
let(:active_strategies) { [:totp] }
let!(:device) { create(:two_factor_authentication_device_totp, user:, active: false, default: false) }
- it 'renders a 400 on missing token' do
+ it "renders a 400 on missing token" do
post :confirm, params: { device_id: device.id }
expect(response).to redirect_to stage_failure_path(stage: :two_factor_authentication)
end
- it 'redirects to the confirmation on faulty entry' do
- post :confirm, params: { device_id: device.id, otp: '1234' }
+ it "redirects to the confirmation on faulty entry" do
+ post :confirm, params: { device_id: device.id, otp: "1234" }
expect(response).to redirect_to action: :confirm, device_id: device.id
- expect(flash[:error]).to include I18n.t('two_factor_authentication.devices.registration_failed_token_invalid')
+ expect(flash[:error]).to include I18n.t("two_factor_authentication.devices.registration_failed_token_invalid")
device.reload
@@ -185,20 +185,20 @@
expect(device.default).to be false
end
- it 'activates the device when entered correctly and logs out the user' do
+ it "activates the device when entered correctly and logs out the user" do
allow(Sessions::DropAllSessionsService)
.to receive(:call)
# rubocop:disable RSpec/AnyInstance
allow_any_instance_of(TwoFactorAuthentication::TokenService)
.to receive(:verify)
- .with('1234')
+ .with("1234")
.and_return(ServiceResult.success)
# rubocop:enable RSpec/AnyInstance
- post :confirm, params: { device_id: device.id, otp: '1234' }
- expect(response).to redirect_to stage_success_path(stage: :two_factor_authentication, secret: 'asdf')
- expect(flash[:notice]).to include I18n.t('two_factor_authentication.devices.registration_complete')
+ post :confirm, params: { device_id: device.id, otp: "1234" }
+ expect(response).to redirect_to stage_success_path(stage: :two_factor_authentication, secret: "asdf")
+ expect(flash[:notice]).to include I18n.t("two_factor_authentication.devices.registration_complete")
device.reload
expect(device.active).to be true
expect(device.default).to be true
diff --git a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/my/remember_cookie_controller_spec.rb b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/my/remember_cookie_controller_spec.rb
index 61ecaf90aa40..8a8ff06ef27d 100644
--- a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/my/remember_cookie_controller_spec.rb
+++ b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/my/remember_cookie_controller_spec.rb
@@ -1,30 +1,30 @@
-require_relative '../../../spec_helper'
-require_relative '../authentication_controller_shared_examples'
+require_relative "../../../spec_helper"
+require_relative "../authentication_controller_shared_examples"
RSpec.describe TwoFactorAuthentication::My::RememberCookieController do
- let(:user) { create(:user, login: 'foobar') }
+ let(:user) { create(:user, login: "foobar") }
let(:logged_in_user) { user }
before do
allow(User).to receive(:current).and_return(logged_in_user)
end
- describe '#destroy' do
+ describe "#destroy" do
before do
delete :destroy
end
- context 'when not logged in' do
+ context "when not logged in" do
let(:logged_in_user) { User.anonymous }
- it 'does not give access' do
+ it "does not give access" do
expect(response).to be_redirect
expect(response).to redirect_to signin_path(back_url: my_2fa_remember_cookie_url)
end
end
- context 'when logged in and active strategies' do
- it 'renders the index page' do
+ context "when logged in and active strategies" do
+ it "renders the index page" do
expect(response).to be_redirect
expect(flash[:notice]).to be_present
end
diff --git a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/my/two_factor_devices_controller_spec.rb b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/my/two_factor_devices_controller_spec.rb
index 7eb1064e14f8..3715283ff620 100644
--- a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/my/two_factor_devices_controller_spec.rb
+++ b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/my/two_factor_devices_controller_spec.rb
@@ -1,18 +1,18 @@
-require_relative '../../../spec_helper'
-require_relative '../authentication_controller_shared_examples'
+require_relative "../../../spec_helper"
+require_relative "../authentication_controller_shared_examples"
RSpec.describe TwoFactorAuthentication::My::TwoFactorDevicesController do
- let(:user) { create(:user, login: 'foobar') }
+ let(:user) { create(:user, login: "foobar") }
let(:other_user) { create(:user) }
let(:logged_in_user) { user }
let(:active_strategies) { [] }
let(:config) { {} }
- include_context 'with settings' do
+ include_context "with settings" do
let(:settings) do
{
plugin_openproject_two_factor_authentication: {
- 'active_strategies' => active_strategies
+ "active_strategies" => active_strategies
}.merge(config)
}
end
@@ -25,153 +25,153 @@
.and_return false
end
- describe 'accessing' do
+ describe "accessing" do
before do
get :index
end
- context 'when not logged in' do
+ context "when not logged in" do
let(:active_strategies) { [:developer] }
let(:logged_in_user) { User.anonymous }
- it 'does not give access' do
+ it "does not give access" do
expect(response).to be_redirect
expect(response).to redirect_to signin_path(back_url: my_2fa_devices_url)
end
end
- context 'when logged in, but not enabled' do
- it 'does not give access' do
+ context "when logged in, but not enabled" do
+ it "does not give access" do
expect(response.status).to eq 404
end
end
- context 'when logged in and active strategies' do
+ context "when logged in and active strategies" do
let(:active_strategies) { [:developer] }
- it 'renders the index page' do
+ it "renders the index page" do
expect(response).to be_successful
- expect(response).to render_template 'index'
+ expect(response).to render_template "index"
end
end
end
- describe 'with active strategy' do
+ describe "with active strategy" do
let(:active_strategies) { [:developer] }
- describe '#new' do
- context 'without type' do
+ describe "#new" do
+ context "without type" do
before do
get :new
end
- it 'renders the new form' do
+ it "renders the new form" do
expect(response).to be_successful
- expect(response).to render_template 'new_type'
+ expect(response).to render_template "new_type"
end
end
- context 'with type' do
+ context "with type" do
before do
get :new, params: { type: :sms }
end
- it 'renders the new form' do
+ it "renders the new form" do
expect(response).to be_successful
- expect(response).to render_template 'new'
+ expect(response).to render_template "new"
end
end
end
- describe '#register' do
+ describe "#register" do
before do
post :register, params: { key: :sms, device: params }
end
- context 'with missing phone' do
- let(:params) { { identifier: 'foo' } }
+ context "with missing phone" do
+ let(:params) { { identifier: "foo" } }
- it 'renders action new' do
+ it "renders action new" do
expect(response).to be_successful
- expect(response).to render_template 'new'
+ expect(response).to render_template "new"
expect(assigns[:device]).to be_invalid
end
end
- context 'with valid params' do
- let(:params) { { phone_number: '+49123456789', identifier: 'foo' } }
+ context "with valid params" do
+ let(:params) { { phone_number: "+49123456789", identifier: "foo" } }
- it 'redirects to confirm' do
+ it "redirects to confirm" do
device = user.otp_devices.reload.last
expect(response).to redirect_to action: :confirm, device_id: device.id
- expect(device.identifier).to eq 'foo (+49123456789)'
- expect(device.phone_number).to eq '+49123456789'
+ expect(device.identifier).to eq "foo (+49123456789)"
+ expect(device.phone_number).to eq "+49123456789"
expect(device.default).to be_falsey
expect(device.active).to be_falsey
end
end
end
- describe '#confirm' do
- describe '#get' do
- it 'croaks on missing id' do
+ describe "#confirm" do
+ describe "#get" do
+ it "croaks on missing id" do
get :confirm, params: { device_id: 1234 }
expect(response.status).to eq 404
end
- describe 'and registered totp device' do
+ describe "and registered totp device" do
let(:active_strategies) { [:totp] }
let!(:device) { create(:two_factor_authentication_device_totp, user:, active: false, default: false) }
- it 'renders the confirmation page' do
+ it "renders the confirmation page" do
get :confirm, params: { device_id: device.id }
expect(response).to be_successful
- expect(response).to render_template 'confirm'
+ expect(response).to render_template "confirm"
expect(flash[:notice]).not_to be_present
end
end
- describe 'with registered device' do
+ describe "with registered device" do
let!(:device) { create(:two_factor_authentication_device_sms, user:, active: false, default: false) }
- it 'renders the confirmation page' do
+ it "renders the confirmation page" do
get :confirm, params: { device_id: device.id }
expect(response).to be_successful
- expect(response).to render_template 'confirm'
+ expect(response).to render_template "confirm"
end
- it 'redirects to index if token request failed' do
+ it "redirects to index if token request failed" do
allow_any_instance_of(TwoFactorAuthentication::TokenService)
.to receive(:request)
.and_return(ServiceResult.failure)
get :confirm, params: { device_id: device.id }
expect(response).to redirect_to action: :index
- expect(flash[:error]).to include I18n.t('two_factor_authentication.devices.confirm_send_failed')
+ expect(flash[:error]).to include I18n.t("two_factor_authentication.devices.confirm_send_failed")
end
end
end
- describe '#post' do
- it 'croaks on missing id' do
+ describe "#post" do
+ it "croaks on missing id" do
get :confirm, params: { device_id: 1234 }
expect(response.status).to eq 404
end
- describe 'and registered totp device' do
+ describe "and registered totp device" do
let(:active_strategies) { [:totp] }
let!(:device) { create(:two_factor_authentication_device_totp, user:, active: false, default: false) }
- it 'renders a 400 on missing token' do
+ it "renders a 400 on missing token" do
post :confirm, params: { device_id: device.id }
expect(response).to redirect_to action: :index
end
- it 'redirects to the confirmation on faulty entry' do
- post :confirm, params: { device_id: device.id, otp: '1234' }
+ it "redirects to the confirmation on faulty entry" do
+ post :confirm, params: { device_id: device.id, otp: "1234" }
expect(response).to redirect_to action: :confirm, device_id: device.id
- expect(flash[:error]).to include I18n.t('two_factor_authentication.devices.registration_failed_token_invalid')
+ expect(flash[:error]).to include I18n.t("two_factor_authentication.devices.registration_failed_token_invalid")
device.reload
@@ -179,39 +179,39 @@
expect(device.default).to be false
end
- context 'when user has another active session' do
+ context "when user has another active session" do
let!(:plain_session) { create(:user_session, user:) }
let!(:user_session) { Sessions::UserSession.find_by(session_id: plain_session.session_id) }
- it 'activates the device when entered correctly and clears other sessions' do
+ it "activates the device when entered correctly and clears other sessions" do
allow_any_instance_of(TwoFactorAuthentication::TokenService)
.to receive(:verify)
- .with('1234')
+ .with("1234")
.and_return(ServiceResult.success)
- post :confirm, params: { device_id: device.id, otp: '1234' }
+ post :confirm, params: { device_id: device.id, otp: "1234" }
expect(response).to redirect_to action: :index
- expect(flash[:notice]).to include I18n.t('two_factor_authentication.devices.registration_complete')
+ expect(flash[:notice]).to include I18n.t("two_factor_authentication.devices.registration_complete")
device.reload
expect(device.active).to be true
expect(device.default).to be true
expect { user_session.reload }.to raise_error(ActiveRecord::RecordNotFound)
end
- context 'with another default device present' do
+ context "with another default device present" do
let!(:default_device) { create(:two_factor_authentication_device_totp, user:, default: true) }
- it 'activates the device when entered correctly' do
+ it "activates the device when entered correctly" do
# rubocop:disable RSpec/AnyInstance
allow_any_instance_of(TwoFactorAuthentication::TokenService)
.to receive(:verify)
- .with('1234')
+ .with("1234")
.and_return(ServiceResult.success)
# rubocop:enable RSpec/AnyInstance
- post :confirm, params: { device_id: device.id, otp: '1234' }
+ post :confirm, params: { device_id: device.id, otp: "1234" }
expect(response).to redirect_to action: :index
- expect(flash[:notice]).to include I18n.t('two_factor_authentication.devices.registration_complete')
+ expect(flash[:notice]).to include I18n.t("two_factor_authentication.devices.registration_complete")
device.reload
expect(device.active).to be true
# but does not set default
@@ -223,42 +223,42 @@
end
end
- describe '#destroy' do
- it 'croaks on missing id' do
- delete :destroy, params: { device_id: '1234' }
+ describe "#destroy" do
+ it "croaks on missing id" do
+ delete :destroy, params: { device_id: "1234" }
expect(response.status).to eq 404
end
- context 'assuming password check is valid' do
+ context "assuming password check is valid" do
before do
expect(controller).to receive(:check_password_confirmation).and_return true
end
- context 'with existing non-default device' do
+ context "with existing non-default device" do
let!(:device) { create(:two_factor_authentication_device_totp, user:, default: false) }
- it 'deletes it' do
+ it "deletes it" do
delete :destroy, params: { device_id: device.id }
expect(response).to redirect_to action: :index
expect(user.otp_devices.reload).to eq []
end
end
- context 'with existing default device' do
+ context "with existing default device" do
let!(:device) { create(:two_factor_authentication_device_totp, user:, default: true) }
- it 'deletes it' do
+ it "deletes it" do
delete :destroy, params: { device_id: device.id }
expect(response).to redirect_to action: :index
expect(user.otp_devices.reload).to eq []
end
end
- context 'with existing default device AND enforced' do
+ context "with existing default device AND enforced" do
let!(:device) { create(:two_factor_authentication_device_totp, user:, default: true) }
let(:config) { { enforced: true } }
- it 'cannot be deleted' do
+ it "cannot be deleted" do
delete :destroy, params: { device_id: device.id }
expect(user.otp_devices.reload).to eq [device]
end
diff --git a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/users/two_factor_devices_controller_spec.rb b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/users/two_factor_devices_controller_spec.rb
index 828d1e29bd78..a3765104c703 100644
--- a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/users/two_factor_devices_controller_spec.rb
+++ b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/users/two_factor_devices_controller_spec.rb
@@ -1,19 +1,19 @@
-require_relative '../../../spec_helper'
-require_relative '../authentication_controller_shared_examples'
+require_relative "../../../spec_helper"
+require_relative "../authentication_controller_shared_examples"
RSpec.describe TwoFactorAuthentication::Users::TwoFactorDevicesController do
let(:admin) { create(:admin) }
- let(:user) { create(:user, login: 'foobar') }
+ let(:user) { create(:user, login: "foobar") }
let(:other_user) { create(:user) }
let(:logged_in_user) { admin }
let(:active_strategies) { [:developer] }
let(:config) { {} }
- include_context 'with settings' do
+ include_context "with settings" do
let(:settings) do
{
plugin_openproject_two_factor_authentication: {
- 'active_strategies' => active_strategies
+ "active_strategies" => active_strategies
}.merge(config)
}
end
@@ -26,110 +26,110 @@
.and_return false
end
- describe 'accessing' do
+ describe "accessing" do
before do
get :new, params: { id: user.id, type: :sms }
end
- context 'when the same user' do
+ context "when the same user" do
let(:logged_in_user) { other_user }
- it 'does not give access' do
+ it "does not give access" do
expect(response.status).to eq 403
end
end
- context 'when not the same user' do
+ context "when not the same user" do
let(:logged_in_user) { user }
- it 'does not give access' do
+ it "does not give access" do
expect(response.status).to eq 403
end
end
- context 'when not the same user and admin' do
+ context "when not the same user and admin" do
let(:logged_in_user) { admin }
- it 'renders the page' do
+ it "renders the page" do
expect(response).to be_successful
- expect(response).to render_template 'new'
+ expect(response).to render_template "new"
end
- context 'when no active strategies' do
+ context "when no active strategies" do
let(:active_strategies) { [] }
- it 'renders a 404 because no strategies enabled' do
+ it "renders a 404 because no strategies enabled" do
expect(response.status).to eq 404
end
end
end
end
- describe 'with active strategy' do
+ describe "with active strategy" do
let(:active_strategies) { [:developer] }
- describe '#new' do
- context 'without type' do
+ describe "#new" do
+ context "without type" do
before do
get :new, params: { id: user.id }
end
- it 'shows an error' do
+ it "shows an error" do
expect(response).to have_http_status(:bad_request)
end
end
- context 'with unsupported type' do
+ context "with unsupported type" do
before do
get :new, params: { id: user.id, type: :totp }
end
- it 'shows an error' do
+ it "shows an error" do
expect(response).to have_http_status(:bad_request)
end
end
- context 'with type' do
+ context "with type" do
before do
get :new, params: { id: user.id, type: :sms }
end
- it 'renders the new form' do
+ it "renders the new form" do
expect(response).to be_successful
- expect(response).to render_template 'new'
+ expect(response).to render_template "new"
end
end
end
- describe '#register' do
- context 'with missing phone' do
- let(:params) { { identifier: 'foo' } }
+ describe "#register" do
+ context "with missing phone" do
+ let(:params) { { identifier: "foo" } }
- it 'renders action new' do
+ it "renders action new" do
post :register, params: { id: user.id, key: :sms, device: params }
expect(response).to be_successful
- expect(response).to render_template 'new'
+ expect(response).to render_template "new"
expect(assigns[:device]).to be_invalid
end
end
- context 'with valid params' do
- let(:params) { { phone_number: '+49123456789', identifier: 'foo' } }
+ context "with valid params" do
+ let(:params) { { phone_number: "+49123456789", identifier: "foo" } }
- it 'redirects to result' do
+ it "redirects to result" do
post :register, params: { id: user.id, key: :sms, device: params }
device = user.otp_devices.reload.last
expect(response).to redirect_to edit_user_path(user.id, tab: :two_factor_authentication)
- expect(device.identifier).to eq 'foo (+49123456789)'
- expect(device.phone_number).to eq '+49123456789'
+ expect(device.identifier).to eq "foo (+49123456789)"
+ expect(device.phone_number).to eq "+49123456789"
expect(device.default).to be_truthy
expect(device.active).to be_truthy
end
- context 'when user has active sessions' do
+ context "when user has active sessions" do
let!(:plain_session1) { create(:user_session, user:) }
let!(:user_session1) { Sessions::UserSession.find_by(session_id: plain_session1.session_id) }
@@ -139,7 +139,7 @@
let!(:other_plain_session) { create(:user_session, user: other_user) }
let!(:other_session) { Sessions::UserSession.find_by(session_id: other_plain_session.session_id) }
- it 'drops all sessions of that user' do
+ it "drops all sessions of that user" do
post :register, params: { id: user.id, key: :sms, device: params }
expect { user_session1.reload }.to raise_error(ActiveRecord::RecordNotFound)
@@ -148,10 +148,10 @@
expect { other_session.reload }.not_to raise_error
end
- context 'when user has an active device' do
+ context "when user has an active device" do
let!(:device) { create(:two_factor_authentication_device_totp, user:, default: true) }
- it 'does nothing' do
+ it "does nothing" do
post :register, params: { id: user.id, key: :sms, device: params }
expect(user.otp_devices.count).to eq 2
@@ -169,47 +169,47 @@
end
end
- describe '#confirm' do
- it 'fails on GET' do
+ describe "#confirm" do
+ it "fails on GET" do
expect { get :confirm }.to raise_error(ActionController::UrlGenerationError)
end
- it 'fails on POST' do
+ it "fails on POST" do
expect { post :confirm }.to raise_error(ActionController::UrlGenerationError)
end
end
- describe '#destroy' do
- it 'croaks on missing id' do
- delete :destroy, params: { id: user.id, device_id: '1234' }
+ describe "#destroy" do
+ it "croaks on missing id" do
+ delete :destroy, params: { id: user.id, device_id: "1234" }
expect(response.status).to eq 404
end
- context 'with existing non-default device' do
+ context "with existing non-default device" do
let!(:device) { create(:two_factor_authentication_device_totp, user:, default: false) }
- it 'deletes it' do
+ it "deletes it" do
delete :destroy, params: { id: user.id, device_id: device.id }
expect(response).to redirect_to edit_user_path(user, tab: :two_factor_authentication)
expect(user.otp_devices.reload).to eq []
end
end
- context 'with existing default device' do
+ context "with existing default device" do
let!(:device) { create(:two_factor_authentication_device_totp, user:, default: true) }
- it 'deletes it' do
+ it "deletes it" do
delete :destroy, params: { id: user.id, device_id: device.id }
expect(response).to redirect_to edit_user_path(user, tab: :two_factor_authentication)
expect(user.otp_devices.reload).to eq []
end
end
- context 'with existing default device AND enforced' do
+ context "with existing default device AND enforced" do
let!(:device) { create(:two_factor_authentication_device_totp, user:, default: true) }
let(:config) { { enforced: true } }
- it 'cannot be deleted' do
+ it "cannot be deleted" do
delete :destroy, params: { id: user.id, device_id: device.id }
expect(user.otp_devices.reload).to eq [device]
end
diff --git a/modules/two_factor_authentication/spec/factories/two_factor_authentication_device_factory.rb b/modules/two_factor_authentication/spec/factories/two_factor_authentication_device_factory.rb
index 50ff998750b5..f4ab1f841e44 100644
--- a/modules/two_factor_authentication/spec/factories/two_factor_authentication_device_factory.rb
+++ b/modules/two_factor_authentication/spec/factories/two_factor_authentication_device_factory.rb
@@ -1,11 +1,11 @@
FactoryBot.define do
- factory :two_factor_authentication_device_sms, class: '::TwoFactorAuthentication::Device::Sms' do
+ factory :two_factor_authentication_device_sms, class: "::TwoFactorAuthentication::Device::Sms" do
user
channel { :sms }
active { true }
default { true }
- phone_number { '+49 123456789' }
- identifier { 'Phone number (+49 123456789)' }
+ phone_number { "+49 123456789" }
+ identifier { "Phone number (+49 123456789)" }
transient do
make_default { false }
@@ -16,12 +16,12 @@
end
end
- factory :two_factor_authentication_device_totp, class: '::TwoFactorAuthentication::Device::Totp' do
+ factory :two_factor_authentication_device_totp, class: "::TwoFactorAuthentication::Device::Totp" do
user
channel { :totp }
active { true }
default { true }
- identifier { 'TOTP device' }
+ identifier { "TOTP device" }
transient do
make_default { false }
@@ -32,12 +32,12 @@
end
end
- factory :two_factor_authentication_device_webauthn, class: '::TwoFactorAuthentication::Device::Webauthn' do
+ factory :two_factor_authentication_device_webauthn, class: "::TwoFactorAuthentication::Device::Webauthn" do
user
channel { :webauthn }
active { true }
default { true }
- identifier { 'WebAuthn device' }
+ identifier { "WebAuthn device" }
webauthn_external_id { "foo" }
webauthn_public_key { "bar" }
diff --git a/modules/two_factor_authentication/spec/features/account_activation_spec.rb b/modules/two_factor_authentication/spec/features/account_activation_spec.rb
index c89014c1a97e..7d1f3118bd5e 100644
--- a/modules/two_factor_authentication/spec/features/account_activation_spec.rb
+++ b/modules/two_factor_authentication/spec/features/account_activation_spec.rb
@@ -1,9 +1,9 @@
-require_relative '../spec_helper'
-require_relative 'shared_2fa_examples'
+require_relative "../spec_helper"
+require_relative "shared_2fa_examples"
-RSpec.describe 'activating an invited account', :js,
+RSpec.describe "activating an invited account", :js,
with_settings: {
- plugin_openproject_two_factor_authentication: { 'active_strategies' => [:developer] }
+ plugin_openproject_two_factor_authentication: { "active_strategies" => [:developer] }
} do
let(:user) do
user = build(:user, first_login: true)
@@ -21,25 +21,25 @@ def activate!
expect(page).to have_current_path account_register_path
- fill_in I18n.t('attributes.password'), with: 'Password1234'
- fill_in I18n.t('activerecord.attributes.user.password_confirmation'), with: 'Password1234'
+ fill_in I18n.t("attributes.password"), with: "Password1234"
+ fill_in I18n.t("activerecord.attributes.user.password_confirmation"), with: "Password1234"
click_button I18n.t(:button_create)
end
- context 'when not enforced and no device present' do
- it 'redirects to active' do
+ context "when not enforced and no device present" do
+ it "redirects to active" do
activate!
visit my_account_path
- expect(page).to have_css('.form--field-container', text: user.login)
+ expect(page).to have_css(".form--field-container", text: user.login)
end
end
- context 'when not enforced, but device present' do
+ context "when not enforced, but device present" do
let!(:device) { create(:two_factor_authentication_device_sms, user:, default: true) }
- it 'requests a OTP' do
+ it "requests a OTP" do
sms_token = nil
# rubocop:disable RSpec/AnyInstance
allow_any_instance_of(OpenProject::TwoFactorAuthentication::TokenStrategy::Developer)
@@ -50,22 +50,22 @@ def activate!
activate!
- expect(page).to have_css('.op-toast.-success', text: 'Developer strategy generated the following one-time password:')
+ expect(page).to have_css(".op-toast.-success", text: "Developer strategy generated the following one-time password:")
SeleniumHubWaiter.wait
fill_in I18n.t(:field_otp), with: sms_token
click_button I18n.t(:button_login)
visit my_account_path
- expect(page).to have_css('.form--field-container', text: user.login)
+ expect(page).to have_css(".form--field-container", text: user.login)
end
- it 'handles faulty user input on two factor authentication' do
+ it "handles faulty user input on two factor authentication" do
activate!
- expect(page).to have_css('.op-toast.-success', text: 'Developer strategy generated the following one-time password:')
+ expect(page).to have_css(".op-toast.-success", text: "Developer strategy generated the following one-time password:")
- fill_in I18n.t(:field_otp), with: 'asdf' # faulty token
+ fill_in I18n.t(:field_otp), with: "asdf" # faulty token
click_button I18n.t(:button_login)
expect(page).to have_current_path signin_path
@@ -73,17 +73,17 @@ def activate!
end
end
- context 'when enforced',
+ context "when enforced",
with_settings: {
plugin_openproject_two_factor_authentication: {
- 'active_strategies' => [:developer],
- 'enforced' => true
+ "active_strategies" => [:developer],
+ "enforced" => true
}
} do
before do
activate!
end
- it_behaves_like 'create enforced sms device'
+ it_behaves_like "create enforced sms device"
end
end
diff --git a/modules/two_factor_authentication/spec/features/admin_edit_two_factor_devices_spec.rb b/modules/two_factor_authentication/spec/features/admin_edit_two_factor_devices_spec.rb
index 205aa53ded80..86c5d6230c37 100644
--- a/modules/two_factor_authentication/spec/features/admin_edit_two_factor_devices_spec.rb
+++ b/modules/two_factor_authentication/spec/features/admin_edit_two_factor_devices_spec.rb
@@ -1,11 +1,11 @@
-require_relative '../spec_helper'
+require_relative "../spec_helper"
-RSpec.describe 'Admin 2FA management', :js, with_settings: {
- plugin_openproject_two_factor_authentication: { 'active_strategies' => %i[developer totp] }
+RSpec.describe "Admin 2FA management", :js, with_settings: {
+ plugin_openproject_two_factor_authentication: { "active_strategies" => %i[developer totp] }
} do
let(:dialog) { Components::PasswordConfirmationDialog.new }
- let(:user_password) { 'admin!' * 4 }
- let(:other_user) { create(:user, login: 'bob') }
+ let(:user_password) { "admin!" * 4 }
+ let(:other_user) { create(:user, login: "bob") }
let(:admin) do
create(:admin,
password: user_password,
@@ -16,69 +16,69 @@
login_as admin
end
- it 'forbids the admin editing his own account' do
+ it "forbids the admin editing his own account" do
visit edit_user_path(admin, tab: :two_factor_authentication)
- expect(page).to have_css('.on-off-status.-disabled')
+ expect(page).to have_css(".on-off-status.-disabled")
- expect(page).to have_no_css('.generic-table--empty-row', wait: 1)
- page.find('.admin--edit-section a').click
+ expect(page).to have_no_css(".generic-table--empty-row", wait: 1)
+ page.find(".admin--edit-section a").click
- expect(page).to have_css('.generic-table--empty-row')
+ expect(page).to have_css(".generic-table--empty-row")
expect(page).to have_current_path my_2fa_devices_path
end
- it 'allows 2FA device management of the user' do
+ it "allows 2FA device management of the user" do
visit edit_user_path(other_user, tab: :two_factor_authentication)
# Visit empty index
- expect(page).to have_css('.generic-table--empty-row',
- text: I18n.t('two_factor_authentication.admin.no_devices_for_user'))
- expect(page).to have_css('.on-off-status.-disabled')
+ expect(page).to have_css(".generic-table--empty-row",
+ text: I18n.t("two_factor_authentication.admin.no_devices_for_user"))
+ expect(page).to have_css(".on-off-status.-disabled")
# Visit inline create
- find('.button', text: I18n.t('two_factor_authentication.admin.button_register_mobile_phone_for_user')).click
+ find(".button", text: I18n.t("two_factor_authentication.admin.button_register_mobile_phone_for_user")).click
SeleniumHubWaiter.wait
# Try to save with invalid phone number
- fill_in 'device_phone_number', with: 'invalid!'
+ fill_in "device_phone_number", with: "invalid!"
click_button I18n.t(:button_continue)
# Enter valid phone number
- expect(page).to have_css('#errorExplanation', text: 'Phone number must be of format +XX XXXXXXXXX')
+ expect(page).to have_css("#errorExplanation", text: "Phone number must be of format +XX XXXXXXXXX")
SeleniumHubWaiter.wait
- fill_in 'device_phone_number', with: '+49 123456789'
+ fill_in "device_phone_number", with: "+49 123456789"
click_button I18n.t(:button_continue)
- expect(page).to have_css('.mobile-otp--two-factor-device-row td', text: 'Mobile phone (bob) (+49 123456789)')
- expect(page).to have_css('.mobile-otp--two-factor-device-row td .icon-yes', count: 2)
- expect(page).to have_css('.on-off-status.-enabled')
+ expect(page).to have_css(".mobile-otp--two-factor-device-row td", text: "Mobile phone (bob) (+49 123456789)")
+ expect(page).to have_css(".mobile-otp--two-factor-device-row td .icon-yes", count: 2)
+ expect(page).to have_css(".on-off-status.-enabled")
SeleniumHubWaiter.wait
# Delete the one
- find('.two-factor--delete-button').click
+ find(".two-factor--delete-button").click
dialog.confirm_flow_with user_password, should_fail: false
- expect(page).to have_css('.mobile-otp--two-factor-device-row', count: 0)
- expect(page).to have_css('.on-off-status.-disabled')
+ expect(page).to have_css(".mobile-otp--two-factor-device-row", count: 0)
+ expect(page).to have_css(".on-off-status.-disabled")
expect(other_user.otp_devices.count).to eq 0
end
- context 'with multiple devices registered' do
+ context "with multiple devices registered" do
let!(:device1) { create(:two_factor_authentication_device_sms, user: other_user) }
let!(:device2) { create(:two_factor_authentication_device_totp, user: other_user, default: false) }
- it 'allows to delete all' do
+ it "allows to delete all" do
visit edit_user_path(other_user, tab: :two_factor_authentication)
- expect(page).to have_css('.mobile-otp--two-factor-device-row', count: 2)
- expect(page).to have_css('.on-off-status.-enabled')
- find('.button', text: I18n.t('two_factor_authentication.admin.button_delete_all_devices')).click
+ expect(page).to have_css(".mobile-otp--two-factor-device-row", count: 2)
+ expect(page).to have_css(".on-off-status.-enabled")
+ find(".button", text: I18n.t("two_factor_authentication.admin.button_delete_all_devices")).click
page.driver.browser.switch_to.alert.accept
- expect(page).to have_css('.generic-table--empty-row',
- text: I18n.t('two_factor_authentication.admin.no_devices_for_user'), wait: 20)
- expect(page).to have_css('.on-off-status.-disabled')
+ expect(page).to have_css(".generic-table--empty-row",
+ text: I18n.t("two_factor_authentication.admin.no_devices_for_user"), wait: 20)
+ expect(page).to have_css(".on-off-status.-disabled")
end
end
end
diff --git a/modules/two_factor_authentication/spec/features/backup_codes/generate_backup_codes_spec.rb b/modules/two_factor_authentication/spec/features/backup_codes/generate_backup_codes_spec.rb
index d09416616080..681720b9900e 100644
--- a/modules/two_factor_authentication/spec/features/backup_codes/generate_backup_codes_spec.rb
+++ b/modules/two_factor_authentication/spec/features/backup_codes/generate_backup_codes_spec.rb
@@ -1,11 +1,11 @@
-require_relative '../../spec_helper'
-require_relative '../shared_2fa_examples'
+require_relative "../../spec_helper"
+require_relative "../shared_2fa_examples"
-RSpec.describe 'Generate 2FA backup codes', :js, with_config: { '2fa': { active_strategies: [:developer] } } do
- let(:user_password) { 'bob!' * 4 }
+RSpec.describe "Generate 2FA backup codes", :js, with_config: { "2fa": { active_strategies: [:developer] } } do
+ let(:user_password) { "bob!" * 4 }
let(:user) do
create(:user,
- login: 'bob',
+ login: "bob",
password: user_password,
password_confirmation: user_password)
end
@@ -15,7 +15,7 @@
login_as user
end
- it 'allows generating backup codes' do
+ it "allows generating backup codes" do
visit my_2fa_devices_path
# Log token for next access
@@ -27,18 +27,18 @@
end
# Confirm with wrong password
- expect(page).to have_css('h2', text: I18n.t('two_factor_authentication.backup_codes.plural'))
- click_on I18n.t('two_factor_authentication.backup_codes.generate.title')
- dialog.confirm_flow_with 'wrong_password', should_fail: true
+ expect(page).to have_css("h2", text: I18n.t("two_factor_authentication.backup_codes.plural"))
+ click_on I18n.t("two_factor_authentication.backup_codes.generate.title")
+ dialog.confirm_flow_with "wrong_password", should_fail: true
# Confirm with correct password
- expect(page).to have_css('h2', text: I18n.t('two_factor_authentication.backup_codes.plural'))
- click_on I18n.t('two_factor_authentication.backup_codes.generate.title')
+ expect(page).to have_css("h2", text: I18n.t("two_factor_authentication.backup_codes.plural"))
+ click_on I18n.t("two_factor_authentication.backup_codes.generate.title")
dialog.confirm_flow_with user_password, should_fail: false
- expect(page).to have_css('.op-toast.-warning')
+ expect(page).to have_css(".op-toast.-warning")
backup_codes.each do |code|
- expect(page).to have_css('.two-factor-authentication--backup-codes li', text: code)
+ expect(page).to have_css(".two-factor-authentication--backup-codes li", text: code)
end
end
end
diff --git a/modules/two_factor_authentication/spec/features/backup_codes/login_with_backup_code_spec.rb b/modules/two_factor_authentication/spec/features/backup_codes/login_with_backup_code_spec.rb
index 5f670c2f9acd..628c10f9e54a 100644
--- a/modules/two_factor_authentication/spec/features/backup_codes/login_with_backup_code_spec.rb
+++ b/modules/two_factor_authentication/spec/features/backup_codes/login_with_backup_code_spec.rb
@@ -1,37 +1,37 @@
-require_relative '../../spec_helper'
-require_relative '../shared_2fa_examples'
+require_relative "../../spec_helper"
+require_relative "../shared_2fa_examples"
-RSpec.describe 'Login with 2FA backup code', :js, with_settings: {
- plugin_openproject_two_factor_authentication: { 'active_strategies' => [:developer] }
+RSpec.describe "Login with 2FA backup code", :js, with_settings: {
+ plugin_openproject_two_factor_authentication: { "active_strategies" => [:developer] }
} do
- let(:user_password) { 'bob!' * 4 }
+ let(:user_password) { "bob!" * 4 }
let(:user) do
create(:user,
- login: 'bob',
+ login: "bob",
password: user_password,
password_confirmation: user_password)
end
let!(:device) { create(:two_factor_authentication_device_sms, user:, active: true, default: true) }
- context 'when user has no backup code' do
- it 'does not show the backup code link' do
+ context "when user has no backup code" do
+ it "does not show the backup code link" do
first_login_step
# Open other options
- find_by_id('toggle_resend_form').click
- expect(page).to have_no_css('a', text: I18n.t('two_factor_authentication.login.enter_backup_code_title'))
+ find_by_id("toggle_resend_form").click
+ expect(page).to have_no_css("a", text: I18n.t("two_factor_authentication.login.enter_backup_code_title"))
end
end
- context 'when user has backup codes' do
+ context "when user has backup codes" do
let!(:valid_backup_codes) { TwoFactorAuthentication::BackupCode.regenerate! user }
- it 'allows entering a backup code' do
+ it "allows entering a backup code" do
expect(valid_backup_codes.length).to eq(10)
first_login_step
- expect(page).to have_css('#toggle_resend_form', wait: 10)
+ expect(page).to have_css("#toggle_resend_form", wait: 10)
# Wait for the frontend to be loaded and initialized
# On downstream configurations, this might take longer than marionette selecting the element
@@ -40,30 +40,30 @@
# Open other options
# This may fail on the first request when the assets aren't ready yet
SeleniumHubWaiter.wait
- find_by_id('toggle_resend_form').click
+ find_by_id("toggle_resend_form").click
SeleniumHubWaiter.wait
- find('a', text: I18n.t('two_factor_authentication.login.enter_backup_code_title'), wait: 2).click
+ find("a", text: I18n.t("two_factor_authentication.login.enter_backup_code_title"), wait: 2).click
- expect(page).to have_css('h2', text: I18n.t('two_factor_authentication.login.enter_backup_code_title'))
+ expect(page).to have_css("h2", text: I18n.t("two_factor_authentication.login.enter_backup_code_title"))
SeleniumHubWaiter.wait
- fill_in 'backup_code', with: 'whatever'
- click_on 'Submit'
+ fill_in "backup_code", with: "whatever"
+ click_on "Submit"
# Expect failure
- expect(page).to have_css('.op-toast.-error', text: I18n.t('two_factor_authentication.error_invalid_backup_code'))
+ expect(page).to have_css(".op-toast.-error", text: I18n.t("two_factor_authentication.error_invalid_backup_code"))
expect(page).to have_current_path signin_path
# Try again!
first_login_step
SeleniumHubWaiter.wait
- find_by_id('toggle_resend_form').click
+ find_by_id("toggle_resend_form").click
SeleniumHubWaiter.wait
- find('a', text: I18n.t('two_factor_authentication.login.enter_backup_code_title')).click
+ find("a", text: I18n.t("two_factor_authentication.login.enter_backup_code_title")).click
- expect(page).to have_css('h2', text: I18n.t('two_factor_authentication.login.enter_backup_code_title'))
+ expect(page).to have_css("h2", text: I18n.t("two_factor_authentication.login.enter_backup_code_title"))
SeleniumHubWaiter.wait
- fill_in 'backup_code', with: valid_backup_codes.first
- click_on 'Submit'
+ fill_in "backup_code", with: valid_backup_codes.first
+ click_on "Submit"
expect_logged_in
end
diff --git a/modules/two_factor_authentication/spec/features/login/login_enforced_2fa_spec.rb b/modules/two_factor_authentication/spec/features/login/login_enforced_2fa_spec.rb
index d98ce73f099c..18f840fdacdb 100644
--- a/modules/two_factor_authentication/spec/features/login/login_enforced_2fa_spec.rb
+++ b/modules/two_factor_authentication/spec/features/login/login_enforced_2fa_spec.rb
@@ -1,24 +1,24 @@
-require_relative '../../spec_helper'
-require_relative '../shared_2fa_examples'
+require_relative "../../spec_helper"
+require_relative "../shared_2fa_examples"
-RSpec.describe 'Login with enforced 2FA', :js, with_settings: {
+RSpec.describe "Login with enforced 2FA", :js, with_settings: {
plugin_openproject_two_factor_authentication: {
- 'active_strategies' => [:developer],
- 'enforced' => true
+ "active_strategies" => [:developer],
+ "enforced" => true
}
} do
- let(:user_password) { 'bob!' * 4 }
+ let(:user_password) { "bob!" * 4 }
let(:user) do
create(:user,
- login: 'bob',
+ login: "bob",
password: user_password,
password_confirmation: user_password)
end
- context 'with a default device' do
+ context "with a default device" do
let!(:device) { create(:two_factor_authentication_device_sms, user:, active: true, default: true) }
- it 'requests a 2FA' do
+ it "requests a 2FA" do
sms_token = nil
# rubocop:disable RSpec/AnyInstance
allow_any_instance_of(OpenProject::TwoFactorAuthentication::TokenStrategy::Developer)
@@ -32,20 +32,20 @@
expect_logged_in
end
- it 'returns to 2FA page if invalid' do
+ it "returns to 2FA page if invalid" do
first_login_step
- two_factor_step('whatever')
+ two_factor_step("whatever")
- expect(page).to have_css('.op-toast.-error', text: I18n.t(:notice_account_otp_invalid))
+ expect(page).to have_css(".op-toast.-error", text: I18n.t(:notice_account_otp_invalid))
expect(page).to have_current_path signin_path
end
end
- context 'without a device' do
+ context "without a device" do
before do
first_login_step
end
- it_behaves_like 'create enforced sms device'
+ it_behaves_like "create enforced sms device"
end
end
diff --git a/modules/two_factor_authentication/spec/features/login/login_with_2fa_spec.rb b/modules/two_factor_authentication/spec/features/login/login_with_2fa_spec.rb
index 14dafa042d59..52a93882d145 100644
--- a/modules/two_factor_authentication/spec/features/login/login_with_2fa_spec.rb
+++ b/modules/two_factor_authentication/spec/features/login/login_with_2fa_spec.rb
@@ -1,23 +1,23 @@
-require_relative '../../spec_helper'
-require_relative '../shared_2fa_examples'
+require_relative "../../spec_helper"
+require_relative "../shared_2fa_examples"
-RSpec.describe 'Login with 2FA device', :js, with_settings: {
+RSpec.describe "Login with 2FA device", :js, with_settings: {
plugin_openproject_two_factor_authentication: {
- 'active_strategies' => [:developer]
+ "active_strategies" => [:developer]
}
} do
- let(:user_password) { 'bob!' * 4 }
+ let(:user_password) { "bob!" * 4 }
let(:user) do
create(:user,
- login: 'bob',
+ login: "bob",
password: user_password,
password_confirmation: user_password)
end
- context 'with a default device' do
+ context "with a default device" do
let!(:device) { create(:two_factor_authentication_device_sms, user:, active: true, default: true) }
- it 'requests a 2FA' do
+ it "requests a 2FA" do
sms_token = nil
# rubocop:disable RSpec/AnyInstance
allow_any_instance_of(OpenProject::TwoFactorAuthentication::TokenStrategy::Developer)
@@ -31,11 +31,11 @@
expect_logged_in
end
- it 'returns to 2FA page if invalid' do
+ it "returns to 2FA page if invalid" do
first_login_step
- two_factor_step('whatever')
+ two_factor_step("whatever")
- expect(page).to have_css('.op-toast.-error', text: I18n.t(:notice_account_otp_invalid))
+ expect(page).to have_css(".op-toast.-error", text: I18n.t(:notice_account_otp_invalid))
expect(page).to have_current_path signin_path
end
end
diff --git a/modules/two_factor_authentication/spec/features/login/login_without_2fa_spec.rb b/modules/two_factor_authentication/spec/features/login/login_without_2fa_spec.rb
index b328710607c9..0ee982a3e077 100644
--- a/modules/two_factor_authentication/spec/features/login/login_without_2fa_spec.rb
+++ b/modules/two_factor_authentication/spec/features/login/login_without_2fa_spec.rb
@@ -1,27 +1,27 @@
-require_relative '../../spec_helper'
-require_relative '../shared_2fa_examples'
+require_relative "../../spec_helper"
+require_relative "../shared_2fa_examples"
-RSpec.describe 'Login with no required OTP', :js, with_config: { '2fa': { active_strategies: [:developer] } } do
- let(:user_password) { 'bob!' * 4 }
+RSpec.describe "Login with no required OTP", :js, with_config: { "2fa": { active_strategies: [:developer] } } do
+ let(:user_password) { "bob!" * 4 }
let(:user) do
create(:user,
- login: 'bob',
+ login: "bob",
password: user_password,
password_confirmation: user_password)
end
- context 'non-default device' do
+ context "non-default device" do
let!(:device) { create(:two_factor_authentication_device_sms, user:, active: true, default: false) }
- it_behaves_like 'login without 2FA'
+ it_behaves_like "login without 2FA"
end
- context 'not enabled',
- with_config: { '2fa': { active_strategies: [] } } do
- it_behaves_like 'login without 2FA'
+ context "not enabled",
+ with_config: { "2fa": { active_strategies: [] } } do
+ it_behaves_like "login without 2FA"
end
- context 'no device' do
- it_behaves_like 'login without 2FA'
+ context "no device" do
+ it_behaves_like "login without 2FA"
end
end
diff --git a/modules/two_factor_authentication/spec/features/login/switch_available_devices_spec.rb b/modules/two_factor_authentication/spec/features/login/switch_available_devices_spec.rb
index 5b35d5e456e7..015a621fc6a9 100644
--- a/modules/two_factor_authentication/spec/features/login/switch_available_devices_spec.rb
+++ b/modules/two_factor_authentication/spec/features/login/switch_available_devices_spec.rb
@@ -1,35 +1,35 @@
-require_relative '../../spec_helper'
-require_relative '../shared_2fa_examples'
+require_relative "../../spec_helper"
+require_relative "../shared_2fa_examples"
-RSpec.describe 'Login by switching 2FA device', :js, with_settings: {
- plugin_openproject_two_factor_authentication: { 'active_strategies' => %i[developer totp] }
+RSpec.describe "Login by switching 2FA device", :js, with_settings: {
+ plugin_openproject_two_factor_authentication: { "active_strategies" => %i[developer totp] }
} do
- let(:user_password) { 'bob!' * 4 }
+ let(:user_password) { "bob!" * 4 }
let(:user) do
create(:user,
- login: 'bob',
+ login: "bob",
password: user_password,
password_confirmation: user_password)
end
- context 'with two default device' do
+ context "with two default device" do
let!(:device) { create(:two_factor_authentication_device_sms, user:, active: true, default: true) }
let!(:device2) { create(:two_factor_authentication_device_totp, user:, active: true, default: false) }
- it 'requests a 2FA and allows switching' do
+ it "requests a 2FA and allows switching" do
first_login_step
- expect(page).to have_css('input#otp')
+ expect(page).to have_css("input#otp")
SeleniumHubWaiter.wait
# Toggle device to TOTP
- find_by_id('toggle_resend_form').click
+ find_by_id("toggle_resend_form").click
SeleniumHubWaiter.wait
find(".button--link[value='#{device2.redacted_identifier}']").click
- expect(page).to have_css('input#otp')
- expect(page).to have_css('#submit_otp p', text: device2.redacted_identifier)
+ expect(page).to have_css("input#otp")
+ expect(page).to have_css("#submit_otp p", text: device2.redacted_identifier)
two_factor_step(device2.totp.now)
expect_logged_in
diff --git a/modules/two_factor_authentication/spec/features/my_two_factor_devices_spec.rb b/modules/two_factor_authentication/spec/features/my_two_factor_devices_spec.rb
index bb9dd2886111..5187f9b91cd3 100644
--- a/modules/two_factor_authentication/spec/features/my_two_factor_devices_spec.rb
+++ b/modules/two_factor_authentication/spec/features/my_two_factor_devices_spec.rb
@@ -1,13 +1,13 @@
-require_relative '../spec_helper'
+require_relative "../spec_helper"
-RSpec.describe 'My Account 2FA configuration', :js, with_settings: {
- plugin_openproject_two_factor_authentication: { 'active_strategies' => %i[developer totp] }
+RSpec.describe "My Account 2FA configuration", :js, with_settings: {
+ plugin_openproject_two_factor_authentication: { "active_strategies" => %i[developer totp] }
} do
let(:dialog) { Components::PasswordConfirmationDialog.new }
- let(:user_password) { 'boB!4' * 4 }
+ let(:user_password) { "boB!4" * 4 }
let(:user) do
create(:user,
- login: 'bob',
+ login: "bob",
password: user_password,
password_confirmation: user_password)
end
@@ -16,31 +16,31 @@
login_as user
end
- it 'allows 2FA device management' do
+ it "allows 2FA device management" do
# Visit empty index
visit my_2fa_devices_path
- expect(page).to have_css('.generic-table--empty-row', text: I18n.t('two_factor_authentication.devices.not_existing'))
- expect(page).to have_css('.on-off-status.-disabled')
+ expect(page).to have_css(".generic-table--empty-row", text: I18n.t("two_factor_authentication.devices.not_existing"))
+ expect(page).to have_css(".on-off-status.-disabled")
# Visit inline create
- find('.wp-inline-create--add-link').click
- expect(page).to have_css('h2', text: I18n.t('two_factor_authentication.devices.add_new'))
+ find(".wp-inline-create--add-link").click
+ expect(page).to have_css("h2", text: I18n.t("two_factor_authentication.devices.add_new"))
expect(page).to have_current_path new_my_2fa_device_path
# Select SMS
- find('.mobile-otp-new-device-sms .button').click
+ find(".mobile-otp-new-device-sms .button").click
# Try to save with invalid phone number
- fill_in 'device_phone_number', with: 'invalid!'
+ fill_in "device_phone_number", with: "invalid!"
click_button I18n.t(:button_continue)
# Enter valid phone number
- expect(page).to have_css('#errorExplanation', text: 'Phone number must be of format +XX XXXXXXXXX')
- fill_in 'device_phone_number', with: '+49 123456789'
+ expect(page).to have_css("#errorExplanation", text: "Phone number must be of format +XX XXXXXXXXX")
+ fill_in "device_phone_number", with: "+49 123456789"
click_button I18n.t(:button_continue)
# Fill in wrong token
- fill_in 'otp', with: 'whatever'
+ fill_in "otp", with: "whatever"
# Log token for next access
sms_token = nil
@@ -53,51 +53,51 @@
click_button I18n.t(:button_continue)
- expect(page).to have_css('h2', text: I18n.t('two_factor_authentication.devices.confirm_device'))
- expect(page).to have_css('input#otp')
- expect(page).to have_css('.op-toast.-error',
- text: I18n.t('two_factor_authentication.devices.registration_failed_token_invalid'))
+ expect(page).to have_css("h2", text: I18n.t("two_factor_authentication.devices.confirm_device"))
+ expect(page).to have_css("input#otp")
+ expect(page).to have_css(".op-toast.-error",
+ text: I18n.t("two_factor_authentication.devices.registration_failed_token_invalid"))
# Fill in correct token
- fill_in 'otp', with: sms_token
+ fill_in "otp", with: sms_token
click_button I18n.t(:button_continue)
# Assert that it exists and is default
- expect(page).to have_css('.mobile-otp--two-factor-device-row td', text: 'Mobile phone (bob) (+49 123456789)')
- expect(page).to have_css('.mobile-otp--two-factor-device-row td .icon-yes', count: 2)
- expect(page).to have_css('.on-off-status.-enabled')
+ expect(page).to have_css(".mobile-otp--two-factor-device-row td", text: "Mobile phone (bob) (+49 123456789)")
+ expect(page).to have_css(".mobile-otp--two-factor-device-row td .icon-yes", count: 2)
+ expect(page).to have_css(".on-off-status.-enabled")
# Create another one as totp
# Visit create button
visit my_2fa_devices_path
- find('.toolbar-item .button', text: '2FA device').click
- expect(page).to have_css('h2', text: I18n.t('two_factor_authentication.devices.add_new'))
+ find(".toolbar-item .button", text: "2FA device").click
+ expect(page).to have_css("h2", text: I18n.t("two_factor_authentication.devices.add_new"))
expect(page).to have_current_path new_my_2fa_device_path, ignore_query: true
# Select totp
- find('.mobile-otp-new-device-totp .button').click
+ find(".mobile-otp-new-device-totp .button").click
# Change identifier
- fill_in 'device_identifier', with: 'custom identifier'
+ fill_in "device_identifier", with: "custom identifier"
click_button I18n.t(:button_continue)
# Confirm token
- expect(page).to have_css('h2', text: I18n.t('two_factor_authentication.devices.confirm_device'))
- expect(page).to have_css('input#otp')
+ expect(page).to have_css("h2", text: I18n.t("two_factor_authentication.devices.confirm_device"))
+ expect(page).to have_css("input#otp")
device = user.otp_devices.order(:id).last
- expect(device.identifier).to eq 'custom identifier'
+ expect(device.identifier).to eq "custom identifier"
expect(device.default).to be_falsey
expect(device.active).to be_falsey
- fill_in 'otp', with: device.totp.now
+ fill_in "otp", with: device.totp.now
click_button I18n.t(:button_continue)
- expect(page).to have_css('.mobile-otp--two-factor-device-row', count: 2)
- rows = page.all('.mobile-otp--two-factor-device-row')
- expect(rows[0]).to have_css('.mobile-otp--two-factor-device-row td .icon-yes', count: 2)
- expect(rows[1]).to have_css('.mobile-otp--two-factor-device-row td', text: 'custom identifier')
- expect(rows[1]).to have_css('.mobile-otp--two-factor-device-row td .icon-yes', count: 1)
+ expect(page).to have_css(".mobile-otp--two-factor-device-row", count: 2)
+ rows = page.all(".mobile-otp--two-factor-device-row")
+ expect(rows[0]).to have_css(".mobile-otp--two-factor-device-row td .icon-yes", count: 2)
+ expect(rows[1]).to have_css(".mobile-otp--two-factor-device-row td", text: "custom identifier")
+ expect(rows[1]).to have_css(".mobile-otp--two-factor-device-row td .icon-yes", count: 1)
device.reload
expect(device.active).to be_truthy
@@ -105,42 +105,42 @@
# Make the second one the default
# Confirm the password wrongly
- find('.two-factor--mark-default-button').click
- dialog.confirm_flow_with 'wrong_password', should_fail: true
+ find(".two-factor--mark-default-button").click
+ dialog.confirm_flow_with "wrong_password", should_fail: true
# Confirm again
- find('.two-factor--mark-default-button').click
+ find(".two-factor--mark-default-button").click
dialog.confirm_flow_with user_password, should_fail: false
- expect(page).to have_css('.mobile-otp--two-factor-device-row', count: 2)
- rows = page.all('.mobile-otp--two-factor-device-row')
- expect(rows[0]).to have_css('.mobile-otp--two-factor-device-row td .icon-yes', count: 1)
- expect(rows[1]).to have_css('.mobile-otp--two-factor-device-row td .icon-yes', count: 2)
+ expect(page).to have_css(".mobile-otp--two-factor-device-row", count: 2)
+ rows = page.all(".mobile-otp--two-factor-device-row")
+ expect(rows[0]).to have_css(".mobile-otp--two-factor-device-row td .icon-yes", count: 1)
+ expect(rows[1]).to have_css(".mobile-otp--two-factor-device-row td .icon-yes", count: 2)
device.reload
expect(device.default).to be_truthy
# Delete the sms device
- rows[0].find('.two-factor--delete-button').click
+ rows[0].find(".two-factor--delete-button").click
dialog.confirm_flow_with user_password, should_fail: false
- expect(page).to have_css('.mobile-otp--two-factor-device-row', count: 1)
- expect(page).to have_css('.on-off-status.-enabled')
+ expect(page).to have_css(".mobile-otp--two-factor-device-row", count: 1)
+ expect(page).to have_css(".on-off-status.-enabled")
expect(user.otp_devices.count).to eq 1
# Delete the totp device
- find('.two-factor--delete-button').click
+ find(".two-factor--delete-button").click
dialog.confirm_flow_with user_password, should_fail: false
- expect(page).to have_css('.generic-table--empty-row', text: I18n.t('two_factor_authentication.devices.not_existing'))
- expect(page).to have_css('.on-off-status.-disabled')
+ expect(page).to have_css(".generic-table--empty-row", text: I18n.t("two_factor_authentication.devices.not_existing"))
+ expect(page).to have_css(".on-off-status.-disabled")
expect(user.otp_devices.count).to eq 0
end
- context 'when a device has been registered already' do
+ context "when a device has been registered already" do
let!(:device) { create(:two_factor_authentication_device_totp, user:) }
- it 'loads the page correctly (Regression #41719)' do
+ it "loads the page correctly (Regression #41719)" do
visit my_2fa_devices_path
expect(page).to have_content device.identifier
diff --git a/modules/two_factor_authentication/spec/features/password_change_spec.rb b/modules/two_factor_authentication/spec/features/password_change_spec.rb
index 90a22195cece..414b7475957a 100644
--- a/modules/two_factor_authentication/spec/features/password_change_spec.rb
+++ b/modules/two_factor_authentication/spec/features/password_change_spec.rb
@@ -1,15 +1,15 @@
-require_relative '../spec_helper'
+require_relative "../spec_helper"
-RSpec.describe 'Password change with OTP', :js, with_settings: {
+RSpec.describe "Password change with OTP", :js, with_settings: {
plugin_openproject_two_factor_authentication: {
- 'active_strategies' => [:developer]
+ "active_strategies" => [:developer]
}
} do
- let(:user_password) { 'boB&' * 4 }
- let(:new_user_password) { '%obB' * 4 }
+ let(:user_password) { "boB&" * 4 }
+ let(:new_user_password) { "%obB" * 4 }
let(:user) do
create(:user,
- login: 'bob',
+ login: "bob",
password: user_password,
password_confirmation: user_password)
end
@@ -17,9 +17,9 @@
def handle_password_change(requires_otp: true)
visit signin_path
- within('#login-form') do
- fill_in('username', with: user.login)
- fill_in('password', with: user_password)
+ within("#login-form") do
+ fill_in("username", with: user.login)
+ fill_in("password", with: user_password)
click_link_or_button I18n.t(:button_login)
end
@@ -31,35 +31,35 @@ def handle_password_change(requires_otp: true)
end
# rubocop:enable RSpec/AnyInstance
- expect(page).to have_css('h2', text: I18n.t(:button_change_password))
- within('#content') do
+ expect(page).to have_css("h2", text: I18n.t(:button_change_password))
+ within("#content") do
SeleniumHubWaiter.wait
- fill_in('password', with: user_password)
- fill_in('new_password', with: new_user_password)
- fill_in('new_password_confirmation', with: new_user_password)
+ fill_in("password", with: user_password)
+ fill_in("new_password", with: new_user_password)
+ fill_in("new_password_confirmation", with: new_user_password)
click_link_or_button I18n.t(:button_save)
end
if requires_otp
- expect(page).to have_css('input#otp')
+ expect(page).to have_css("input#otp")
SeleniumHubWaiter.wait
- fill_in 'otp', with: sms_token
+ fill_in "otp", with: sms_token
click_button I18n.t(:button_login)
end
expect(page).to have_current_path(expected_path_after_login, ignore_query: true)
end
- context 'when password is expired',
+ context "when password is expired",
with_settings: { password_days_valid: 7 } do
before do
user
end
- context 'when device present' do
+ context "when device present" do
let!(:device) { create(:two_factor_authentication_device_sms, user:, default: true) }
- it 'requires the password change after expired' do
+ it "requires the password change after expired" do
expect(user.current_password).not_to be_expired
Timecop.travel(2.weeks.from_now) do
@@ -72,10 +72,10 @@ def handle_password_change(requires_otp: true)
end
end
- context 'when no device present' do
+ context "when no device present" do
let!(:device) { nil }
- it 'requires the password change after expired' do
+ it "requires the password change after expired" do
expect(user.current_password).not_to be_expired
Timecop.travel(2.weeks.from_now) do
@@ -89,12 +89,12 @@ def handle_password_change(requires_otp: true)
end
end
- context 'when force password change is set' do
+ context "when force password change is set" do
let(:user) do
create(:user,
force_password_change: true,
first_login: true,
- login: 'bob',
+ login: "bob",
password: user_password,
password_confirmation: user_password)
end
@@ -104,18 +104,18 @@ def handle_password_change(requires_otp: true)
user
end
- context 'when device present' do
+ context "when device present" do
let!(:device) { create(:two_factor_authentication_device_sms, user:, default: true) }
- it 'requires the password change' do
+ it "requires the password change" do
handle_password_change
end
end
- context 'when no device present' do
+ context "when no device present" do
let!(:device) { nil }
- it 'requires the password change without otp' do
+ it "requires the password change without otp" do
handle_password_change(requires_otp: false)
end
end
diff --git a/modules/two_factor_authentication/spec/features/remember_cookie/login_with_remember_cookie_spec.rb b/modules/two_factor_authentication/spec/features/remember_cookie/login_with_remember_cookie_spec.rb
index af0ce3b0e716..dc11cfc15754 100644
--- a/modules/two_factor_authentication/spec/features/remember_cookie/login_with_remember_cookie_spec.rb
+++ b/modules/two_factor_authentication/spec/features/remember_cookie/login_with_remember_cookie_spec.rb
@@ -1,7 +1,7 @@
-require_relative '../../spec_helper'
-require_relative '../shared_2fa_examples'
+require_relative "../../spec_helper"
+require_relative "../shared_2fa_examples"
-RSpec.describe 'Login with 2FA remember cookie', :js, with_settings: {
+RSpec.describe "Login with 2FA remember cookie", :js, with_settings: {
plugin_openproject_two_factor_authentication: {
active_strategies: [:developer],
allow_remember_for_days: 30
@@ -26,9 +26,9 @@ def login_with_cookie
first_login_step
- expect(page).to have_css('input#remember_me')
+ expect(page).to have_css("input#remember_me")
SeleniumHubWaiter.wait
- check 'remember_me'
+ check "remember_me"
two_factor_step sms_token
expect_logged_in
@@ -37,42 +37,42 @@ def login_with_cookie
def expect_no_autologin
first_login_step
- expect(page).to have_css('input#otp')
+ expect(page).to have_css("input#otp")
expect_not_logged_in
end
- context 'when not enabled',
+ context "when not enabled",
with_settings: {
plugin_openproject_two_factor_authentication: {
active_strategies: [:developer],
allow_remember_for_days: 0
}
} do
- it 'does not show the save form' do
+ it "does not show the save form" do
first_login_step
- expect(page).to have_no_css('input#remember_me')
+ expect(page).to have_no_css("input#remember_me")
end
end
- context 'when user has no remember cookie' do
- it 'can remove the autologin cookie after login' do
+ context "when user has no remember cookie" do
+ it "can remove the autologin cookie after login" do
login_with_cookie
visit my_2fa_devices_path
- find('.two-factor-authentication--remove-remember-cookie-link').click
- expect(page).to have_css('.op-toast.-success')
- expect(page).to have_no_css('.two-factor-authentication--remove-remember-cookie-link')
+ find(".two-factor-authentication--remove-remember-cookie-link").click
+ expect(page).to have_css(".op-toast.-success")
+ expect(page).to have_no_css(".two-factor-authentication--remove-remember-cookie-link")
# Log out and in again
- visit '/logout'
+ visit "/logout"
expect_no_autologin
end
- it 'allows to save a cookie on the login step for subsequent steps' do
+ it "allows to save a cookie on the login step for subsequent steps" do
login_with_cookie
# Log out and in again
- visit '/logout'
+ visit "/logout"
first_login_step
# Expect no OTP required
@@ -84,7 +84,7 @@ def expect_no_autologin
token.update_columns(expires_on: 1.day.ago, created_at: 31.days.ago)
# Log out and in again
- visit '/logout'
+ visit "/logout"
expect_no_autologin
# Login to save cookie again
@@ -96,7 +96,7 @@ def expect_no_autologin
.and_return(0)
# Log out and in again
- visit '/logout'
+ visit "/logout"
expect_no_autologin
# Enable functionality
diff --git a/modules/two_factor_authentication/spec/features/shared_2fa_examples.rb b/modules/two_factor_authentication/spec/features/shared_2fa_examples.rb
index 998043be12e4..461a35b159bc 100644
--- a/modules/two_factor_authentication/spec/features/shared_2fa_examples.rb
+++ b/modules/two_factor_authentication/spec/features/shared_2fa_examples.rb
@@ -1,64 +1,64 @@
def first_login_step
visit signin_path
SeleniumHubWaiter.wait
- within('#login-form') do
- fill_in('username', with: user.login)
- fill_in('password', with: user_password)
+ within("#login-form") do
+ fill_in("username", with: user.login)
+ fill_in("password", with: user_password)
click_link_or_button I18n.t(:button_login)
end
end
def two_factor_step(token)
- expect(page).to have_css('input#otp')
+ expect(page).to have_css("input#otp")
SeleniumHubWaiter.wait
- fill_in 'otp', with: token
+ fill_in "otp", with: token
click_button I18n.t(:button_login)
end
def expect_logged_in
visit my_account_path
SeleniumHubWaiter.wait
- expect(page).to have_css('.form--field-container', text: user.login)
+ expect(page).to have_css(".form--field-container", text: user.login)
end
def expect_not_logged_in
visit my_account_path
- expect(page).to have_no_css('.form--field-container', text: user.login)
+ expect(page).to have_no_css(".form--field-container", text: user.login)
end
-RSpec.shared_examples 'login without 2FA' do
- it 'logs in the user without any active devices' do
+RSpec.shared_examples "login without 2FA" do
+ it "logs in the user without any active devices" do
first_login_step
expect_logged_in
end
end
-RSpec.shared_examples 'create enforced sms device' do
+RSpec.shared_examples "create enforced sms device" do
it do
- expect(page).to have_css('.op-toast.-info',
- text: I18n.t('two_factor_authentication.forced_registration.required_to_add_device'))
+ expect(page).to have_css(".op-toast.-info",
+ text: I18n.t("two_factor_authentication.forced_registration.required_to_add_device"))
SeleniumHubWaiter.wait
# Create SMS device
- find('.mobile-otp-new-device-sms .button--tiny').click
+ find(".mobile-otp-new-device-sms .button--tiny").click
SeleniumHubWaiter.wait
- fill_in 'device_phone_number', with: 'invalid'
- click_on 'Continue'
+ fill_in "device_phone_number", with: "invalid"
+ click_on "Continue"
# Expect error on invalid phone
- expect(page).to have_css('#errorExplanation', text: 'Phone number must be of format +XX XXXXXXXXX')
+ expect(page).to have_css("#errorExplanation", text: "Phone number must be of format +XX XXXXXXXXX")
SeleniumHubWaiter.wait
- fill_in 'device_phone_number', with: '+49 123456789'
- click_on 'Continue'
+ fill_in "device_phone_number", with: "+49 123456789"
+ click_on "Continue"
# Confirm page
- expect(page).to have_css('h2', text: I18n.t('two_factor_authentication.devices.confirm_device'))
- expect(page).to have_css('input#otp')
+ expect(page).to have_css("h2", text: I18n.t("two_factor_authentication.devices.confirm_device"))
+ expect(page).to have_css("input#otp")
SeleniumHubWaiter.wait
# Fill in wrong token
- fill_in 'otp', with: 'whatever'
+ fill_in "otp", with: "whatever"
# Log token for next access
sms_token = nil
@@ -69,14 +69,14 @@ def expect_not_logged_in
click_button I18n.t(:button_continue)
- expect(page).to have_css('h2', text: I18n.t('two_factor_authentication.devices.confirm_device'))
- expect(page).to have_css('input#otp')
- expect(page).to have_css('.op-toast.-error',
- text: I18n.t('two_factor_authentication.devices.registration_failed_token_invalid'))
+ expect(page).to have_css("h2", text: I18n.t("two_factor_authentication.devices.confirm_device"))
+ expect(page).to have_css("input#otp")
+ expect(page).to have_css(".op-toast.-error",
+ text: I18n.t("two_factor_authentication.devices.registration_failed_token_invalid"))
SeleniumHubWaiter.wait
# Fill in wrong token
- fill_in 'otp', with: sms_token
+ fill_in "otp", with: sms_token
click_button I18n.t(:button_continue)
# Expected logged in after correct registration
diff --git a/modules/two_factor_authentication/spec/lib/token_strategies/message_bird_spec.rb b/modules/two_factor_authentication/spec/lib/token_strategies/message_bird_spec.rb
index 6c49196a1825..4134dc85c170 100644
--- a/modules/two_factor_authentication/spec/lib/token_strategies/message_bird_spec.rb
+++ b/modules/two_factor_authentication/spec/lib/token_strategies/message_bird_spec.rb
@@ -1,69 +1,69 @@
-require_relative '../../spec_helper'
-require 'messagebird'
+require_relative "../../spec_helper"
+require "messagebird"
RSpec.describe OpenProject::TwoFactorAuthentication::TokenStrategy::MessageBird do
let(:channel) { :sms }
- let(:locale) { 'en' }
+ let(:locale) { "en" }
let(:user) { create(:user, language: locale) }
let(:device) { create(:two_factor_authentication_device_sms, user:, channel:) }
let(:strategy) { described_class.new user:, device:, channel: }
before do
- allow(strategy).to receive(:token).and_return '1234'
+ allow(strategy).to receive(:token).and_return "1234"
end
- describe '#build_recipients' do
+ describe "#build_recipients" do
subject do
{}.tap do |params|
strategy.send(:build_recipients, params)
end[:recipients]
end
- it 'strips all spaces and country lead' do
- expect(subject).to eq '49123456789'
+ it "strips all spaces and country lead" do
+ expect(subject).to eq "49123456789"
end
end
- describe '#build_localized_message' do
+ describe "#build_localized_message" do
subject do
{}.tap do |params|
strategy.send(:build_localized_message, params)
end
end
- context 'with en' do
- let(:locale) { 'en' }
+ context "with en" do
+ let(:locale) { "en" }
- it 'returns the correct language and message' do
- expect(subject[:language]).to eq :'en-us'
- expect(subject[:message]).to include 'Your OpenProject one-time password is 1234'
+ it "returns the correct language and message" do
+ expect(subject[:language]).to eq :"en-us"
+ expect(subject[:message]).to include "Your OpenProject one-time password is 1234"
end
end
- context 'with de' do
- let(:locale) { 'de' }
+ context "with de" do
+ let(:locale) { "de" }
- it 'returns the correct language and message' do
+ it "returns the correct language and message" do
expected_message = I18n.t("two_factor_authentication.text_otp_delivery_message_sms",
app_title: Setting.app_title,
- locale: 'de',
- token: '1234')
+ locale: "de",
+ token: "1234")
- expect(subject[:language]).to be :'de-de'
+ expect(subject[:language]).to be :"de-de"
expect(subject[:message]).to eql expected_message
end
end
- context 'with unsupported locale ar (Arabic is not supported in message bird)' do
- let(:locale) { 'ar' }
+ context "with unsupported locale ar (Arabic is not supported in message bird)" do
+ let(:locale) { "ar" }
- it 'falls back to english' do
+ it "falls back to english" do
expected_message = I18n.t("two_factor_authentication.text_otp_delivery_message_sms",
app_title: Setting.app_title,
- locale: 'en',
- token: '1234')
+ locale: "en",
+ token: "1234")
- expect(subject[:language]).to eq :'en-us'
+ expect(subject[:language]).to eq :"en-us"
expect(subject[:message]).to eql expected_message
end
end
diff --git a/modules/two_factor_authentication/spec/lib/token_strategy_manager_spec.rb b/modules/two_factor_authentication/spec/lib/token_strategy_manager_spec.rb
index 4e948f49167f..103e3a365588 100644
--- a/modules/two_factor_authentication/spec/lib/token_strategy_manager_spec.rb
+++ b/modules/two_factor_authentication/spec/lib/token_strategy_manager_spec.rb
@@ -1,4 +1,4 @@
-require_relative '../spec_helper'
+require_relative "../spec_helper"
RSpec.describe OpenProject::TwoFactorAuthentication::TokenStrategyManager do
let(:dev_strategy) { OpenProject::TwoFactorAuthentication::TokenStrategy::Developer }
@@ -11,7 +11,7 @@
end
let(:enforced) { false }
- include_context 'with settings' do
+ include_context "with settings" do
let(:settings) do
{
plugin_openproject_two_factor_authentication: configuration
@@ -19,52 +19,52 @@
end
end
- describe '#find_matching_strategy' do
+ describe "#find_matching_strategy" do
subject { described_class.find_matching_strategy(:sms) }
- context 'when no strategy is set' do
+ context "when no strategy is set" do
let(:active_strategies) { [] }
- it 'returns nil' do
+ it "returns nil" do
expect(subject).to be_nil
end
end
- context 'when matching strategy exists' do
+ context "when matching strategy exists" do
let(:active_strategies) { [:developer] }
- it 'returns the strategy' do
+ it "returns the strategy" do
expect(subject).to eq(dev_strategy)
end
end
- context 'when non-matching strategy exists' do
+ context "when non-matching strategy exists" do
let(:active_strategies) { [:totp] }
- it 'returns the strategy' do
+ it "returns the strategy" do
expect(subject).to be_nil
end
end
end
- describe '#active_strategies' do
- context 'with bogus strategy' do
+ describe "#active_strategies" do
+ context "with bogus strategy" do
let(:active_strategies) { [:doesnotexist] }
- it 'raises when accessing' do
+ it "raises when accessing" do
expect { described_class.active_strategies }.to raise_error(ArgumentError)
end
- it 'raises when validating' do
+ it "raises when validating" do
expect { described_class.validate_active_strategies! }.to raise_error(ArgumentError)
end
end
end
- describe '#validate_active_strategies!' do
+ describe "#validate_active_strategies!" do
subject { described_class.validate_active_strategies! }
- context 'when no strategy is set' do
+ context "when no strategy is set" do
let(:active_strategies) { [] }
before do
@@ -73,20 +73,20 @@
.and_return false
end
- context 'when enforced is false' do
+ context "when enforced is false" do
let(:enforced) { false }
- it 'accepts that' do
+ it "accepts that" do
expect { subject }.not_to raise_error
expect(described_class).not_to be_enabled
expect(described_class).not_to be_enforced
end
end
- context 'when enforced is true' do
+ context "when enforced is true" do
let(:enforced) { true }
- it 'raises and error that a strategy is needed' do
+ it "raises and error that a strategy is needed" do
expect { subject }.to raise_error(ArgumentError)
expect(described_class).not_to be_enabled
expect(described_class).to be_enforced
@@ -94,11 +94,11 @@
end
end
- context 'when a strategy is set' do
+ context "when a strategy is set" do
let(:active_strategies) { [:developer] }
- context 'when it is valid' do
- it 'returns that' do
+ context "when it is valid" do
+ it "returns that" do
expect { subject }.not_to raise_error
expect(described_class.active_strategies).to eq([dev_strategy])
expect(described_class).to be_enabled
@@ -106,11 +106,11 @@
end
end
- context 'when it is invalid' do
- it 'raises' do
- allow(dev_strategy).to receive(:validate!).and_raise 'Error!'
+ context "when it is invalid" do
+ it "raises" do
+ allow(dev_strategy).to receive(:validate!).and_raise "Error!"
- expect { subject }.to raise_error 'Error!'
+ expect { subject }.to raise_error "Error!"
expect(described_class).to be_enabled
expect(described_class).not_to be_enforced
end
diff --git a/modules/two_factor_authentication/spec/models/device/default_device_spec.rb b/modules/two_factor_authentication/spec/models/device/default_device_spec.rb
index 14cf614d04c3..a4735a54070b 100644
--- a/modules/two_factor_authentication/spec/models/device/default_device_spec.rb
+++ b/modules/two_factor_authentication/spec/models/device/default_device_spec.rb
@@ -1,19 +1,19 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Default device' do
+RSpec.describe "Default device" do
let(:user) { create(:user) }
let(:other_otp) { build(:two_factor_authentication_device_totp, user:, default: true) }
subject { build(:two_factor_authentication_device_totp, user:, default: true) }
- it 'can be set if nothing else exists' do
+ it "can be set if nothing else exists" do
expect(subject.save).to be true
expect(other_otp).to be_invalid
- expect(other_otp.errors[:default]).to include 'is already set for another OTP device.'
+ expect(other_otp.errors[:default]).to include "is already set for another OTP device."
end
- context 'assuming another default exists' do
+ context "assuming another default exists" do
let(:other_otp) { create(:two_factor_authentication_device_totp, user:, default: true) }
let(:other_sms) { create(:two_factor_authentication_device_sms, user:, default: false) }
@@ -25,7 +25,7 @@
subject
end
- it 'can be set through make_default!' do
+ it "can be set through make_default!" do
expect(user.otp_devices.count).to eq(3)
expect(user.otp_devices.get_default).to eq(other_otp)
diff --git a/modules/two_factor_authentication/spec/models/device/totp_spec.rb b/modules/two_factor_authentication/spec/models/device/totp_spec.rb
index 2b7c87ad5d23..aad1993cdc47 100644
--- a/modules/two_factor_authentication/spec/models/device/totp_spec.rb
+++ b/modules/two_factor_authentication/spec/models/device/totp_spec.rb
@@ -1,50 +1,50 @@
-require 'spec_helper'
-require 'timecop'
+require "spec_helper"
+require "timecop"
RSpec.describe TwoFactorAuthentication::Device::Totp do
let(:user) { create(:user) }
let(:channel) { :totp }
- subject { described_class.new identifier: 'foo', channel:, user:, active: true }
+ subject { described_class.new identifier: "foo", channel:, user:, active: true }
- describe 'validations' do
- context 'with invalid channel' do
+ describe "validations" do
+ context "with invalid channel" do
let(:channel) { :whatver }
- it 'is invalid' do
+ it "is invalid" do
expect(subject).to be_invalid
expect(subject.errors[:channel]).to be_present
end
end
- context 'with valid channel' do
- it 'is valid' do
+ context "with valid channel" do
+ it "is valid" do
expect(subject).to be_valid
expect(subject.errors).to be_empty
end
end
end
- describe 'token validation' do
+ describe "token validation" do
let(:totp) { subject.send :totp }
- context 'when setting drift',
+ context "when setting drift",
with_settings: {
plugin_openproject_two_factor_authentication: {
- 'otp_drift_window' => 30
+ "otp_drift_window" => 30
}
} do
- it 'uses the drift window from configuration' do
+ it "uses the drift window from configuration" do
expect(subject.allowed_drift).to eq 30
end
end
- context 'when no drift set' do
- it 'uses the default drift window' do
+ context "when no drift set" do
+ it "uses the default drift window" do
expect(subject.allowed_drift).to eq 60
end
- it 'uses the drift value for verification' do
+ it "uses the drift value for verification" do
# Assume never used
# rubocop:disable RSpec/SubjectStub
allow(subject).to receive(:last_used_at).and_return nil
@@ -73,7 +73,7 @@
end
end
- it 'avoids double verification' do
+ it "avoids double verification" do
subject.save!
valid = totp.at(Time.current)
diff --git a/modules/two_factor_authentication/spec/models/device/webauthn_spec.rb b/modules/two_factor_authentication/spec/models/device/webauthn_spec.rb
index 8403472c2c46..bbe39d927652 100644
--- a/modules/two_factor_authentication/spec/models/device/webauthn_spec.rb
+++ b/modules/two_factor_authentication/spec/models/device/webauthn_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
RSpec.describe TwoFactorAuthentication::Device::Webauthn do
let(:user) { create(:user) }
diff --git a/modules/two_factor_authentication/spec/models/login_token_spec.rb b/modules/two_factor_authentication/spec/models/login_token_spec.rb
index 558d85fb31ea..ad5d37d87445 100644
--- a/modules/two_factor_authentication/spec/models/login_token_spec.rb
+++ b/modules/two_factor_authentication/spec/models/login_token_spec.rb
@@ -1,4 +1,4 @@
-require_relative '../spec_helper'
+require_relative "../spec_helper"
RSpec.describe TwoFactorAuthentication::LoginToken, :with_2fa_ee do
shared_let(:user) { create(:user) }
diff --git a/modules/two_factor_authentication/spec/models/user_spec.rb b/modules/two_factor_authentication/spec/models/user_spec.rb
index 94428d16cfb2..32ef36ec6eb0 100644
--- a/modules/two_factor_authentication/spec/models/user_spec.rb
+++ b/modules/two_factor_authentication/spec/models/user_spec.rb
@@ -1,4 +1,4 @@
-require_relative '../spec_helper'
+require_relative "../spec_helper"
module OpenProject::TwoFactorAuthentication::Patches
module UserSpec
@@ -32,7 +32,7 @@ def login_with(login, password)
create_user
end
- describe '#try_to_login', "with valid username but invalid pwd" do
+ describe "#try_to_login", "with valid username but invalid pwd" do
it "returns nil" do
expect(invalid_login).to be_nil
end
diff --git a/modules/two_factor_authentication/spec/routing/two_factor_authentication/my/two_factor_devices_spec.rb b/modules/two_factor_authentication/spec/routing/two_factor_authentication/my/two_factor_devices_spec.rb
index 5964cc6d5084..810b2793a168 100644
--- a/modules/two_factor_authentication/spec/routing/two_factor_authentication/my/two_factor_devices_spec.rb
+++ b/modules/two_factor_authentication/spec/routing/two_factor_authentication/my/two_factor_devices_spec.rb
@@ -26,42 +26,42 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'users 2fa devices' do
- it 'route to index' do
- expect(get('/my/two_factor_devices')).to route_to('two_factor_authentication/my/two_factor_devices#index')
+RSpec.describe "users 2fa devices" do
+ it "route to index" do
+ expect(get("/my/two_factor_devices")).to route_to("two_factor_authentication/my/two_factor_devices#index")
end
- it 'route to new' do
- expect(get('/my/two_factor_devices/new')).to route_to('two_factor_authentication/my/two_factor_devices#new')
+ it "route to new" do
+ expect(get("/my/two_factor_devices/new")).to route_to("two_factor_authentication/my/two_factor_devices#new")
end
- it 'route to register' do
- expect(post('/my/two_factor_devices/register')).to route_to('two_factor_authentication/my/two_factor_devices#register')
+ it "route to register" do
+ expect(post("/my/two_factor_devices/register")).to route_to("two_factor_authentication/my/two_factor_devices#register")
end
- it 'route to confirm' do
- expect(get('/my/two_factor_devices/1/confirm')).to route_to(controller: 'two_factor_authentication/my/two_factor_devices',
- action: 'confirm',
- device_id: '1')
+ it "route to confirm" do
+ expect(get("/my/two_factor_devices/1/confirm")).to route_to(controller: "two_factor_authentication/my/two_factor_devices",
+ action: "confirm",
+ device_id: "1")
end
- it 'route to POST confirm' do
- expect(post('/my/two_factor_devices/1/confirm')).to route_to(controller: 'two_factor_authentication/my/two_factor_devices',
- action: 'confirm',
- device_id: '1')
+ it "route to POST confirm" do
+ expect(post("/my/two_factor_devices/1/confirm")).to route_to(controller: "two_factor_authentication/my/two_factor_devices",
+ action: "confirm",
+ device_id: "1")
end
- it 'route to POST make_default' do
- expect(post('/my/two_factor_devices/1/make_default')).to route_to(controller: 'two_factor_authentication/my/two_factor_devices',
- action: 'make_default',
- device_id: '1')
+ it "route to POST make_default" do
+ expect(post("/my/two_factor_devices/1/make_default")).to route_to(controller: "two_factor_authentication/my/two_factor_devices",
+ action: "make_default",
+ device_id: "1")
end
- it 'route to DELETE destroy' do
- expect(delete('/my/two_factor_devices/1')).to route_to(controller: 'two_factor_authentication/my/two_factor_devices',
- action: 'destroy',
- device_id: '1')
+ it "route to DELETE destroy" do
+ expect(delete("/my/two_factor_devices/1")).to route_to(controller: "two_factor_authentication/my/two_factor_devices",
+ action: "destroy",
+ device_id: "1")
end
end
diff --git a/modules/two_factor_authentication/spec/routing/two_factor_authentication/users/two_factor_devices_spec.rb b/modules/two_factor_authentication/spec/routing/two_factor_authentication/users/two_factor_devices_spec.rb
index f712fe9db11d..790511b898e7 100644
--- a/modules/two_factor_authentication/spec/routing/two_factor_authentication/users/two_factor_devices_spec.rb
+++ b/modules/two_factor_authentication/spec/routing/two_factor_authentication/users/two_factor_devices_spec.rb
@@ -26,38 +26,38 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'users 2fa devices' do
- it 'route to GET new' do
- expect(get('/users/2/two_factor_devices/new')).to route_to(controller: 'two_factor_authentication/users/two_factor_devices',
- action: 'new',
- id: '2')
+RSpec.describe "users 2fa devices" do
+ it "route to GET new" do
+ expect(get("/users/2/two_factor_devices/new")).to route_to(controller: "two_factor_authentication/users/two_factor_devices",
+ action: "new",
+ id: "2")
end
- it 'route to POST register' do
- expect(post('/users/2/two_factor_devices/register')).to route_to(controller: 'two_factor_authentication/users/two_factor_devices',
- action: 'register',
- id: '2')
+ it "route to POST register" do
+ expect(post("/users/2/two_factor_devices/register")).to route_to(controller: "two_factor_authentication/users/two_factor_devices",
+ action: "register",
+ id: "2")
end
- it 'route to POST confirm' do
- expect(post('/users/2/two_factor_devices/1/make_default')).to route_to(controller: 'two_factor_authentication/users/two_factor_devices',
- action: 'make_default',
- id: '2',
- device_id: '1')
+ it "route to POST confirm" do
+ expect(post("/users/2/two_factor_devices/1/make_default")).to route_to(controller: "two_factor_authentication/users/two_factor_devices",
+ action: "make_default",
+ id: "2",
+ device_id: "1")
end
- it 'route to POST delete_all' do
- expect(post('/users/2/two_factor_devices/delete_all')).to route_to(controller: 'two_factor_authentication/users/two_factor_devices',
- action: 'delete_all',
- id: '2')
+ it "route to POST delete_all" do
+ expect(post("/users/2/two_factor_devices/delete_all")).to route_to(controller: "two_factor_authentication/users/two_factor_devices",
+ action: "delete_all",
+ id: "2")
end
- it 'route to DELETE destroy' do
- expect(delete('/users/2/two_factor_devices/1')).to route_to(controller: 'two_factor_authentication/users/two_factor_devices',
- action: 'destroy',
- id: '2',
- device_id: '1')
+ it "route to DELETE destroy" do
+ expect(delete("/users/2/two_factor_devices/1")).to route_to(controller: "two_factor_authentication/users/two_factor_devices",
+ action: "destroy",
+ id: "2",
+ device_id: "1")
end
end
diff --git a/modules/two_factor_authentication/spec/services/token_delivery/message_bird_spec.rb b/modules/two_factor_authentication/spec/services/token_delivery/message_bird_spec.rb
index 6093eae370e4..7ef6394e0aa3 100644
--- a/modules/two_factor_authentication/spec/services/token_delivery/message_bird_spec.rb
+++ b/modules/two_factor_authentication/spec/services/token_delivery/message_bird_spec.rb
@@ -1,14 +1,14 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
-require 'messagebird'
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
+require "messagebird"
RSpec.describe OpenProject::TwoFactorAuthentication::TokenStrategy::MessageBird do
- describe 'sending messages' do
+ describe "sending messages" do
let!(:user) { create(:user, language: locale) }
- let!(:locale) { 'en' }
+ let!(:locale) { "en" }
let!(:device) { create(:two_factor_authentication_device_sms, user:, channel:) }
- let(:service_url) { 'https://example.org/foobar' }
- let(:apikey) { 'whatever' }
+ let(:service_url) { "https://example.org/foobar" }
+ let(:apikey) { "whatever" }
let(:params) do
{
apikey:
@@ -19,12 +19,12 @@
subject { TwoFactorAuthentication::TokenService.new user: }
- include_context 'with settings' do
+ include_context "with settings" do
let(:settings) do
{
plugin_openproject_two_factor_authentication: {
- 'active_strategies' => [:message_bird],
- 'message_bird' => params
+ "active_strategies" => [:message_bird],
+ "message_bird" => params
}
}
end
@@ -33,61 +33,61 @@
before do
allow_any_instance_of(OpenProject::TwoFactorAuthentication::TokenStrategy::MessageBird)
.to receive(:create_mobile_otp)
- .and_return('1234')
+ .and_return("1234")
end
- describe '#setup' do
+ describe "#setup" do
let(:channel) { :sms }
let(:params) { { apikey: nil } }
- it 'raises an exception for incomplete params' do
+ it "raises an exception for incomplete params" do
expect { described_class.validate! }
.to raise_exception(ArgumentError)
end
end
- describe 'calling a mocked test API' do
+ describe "calling a mocked test API" do
let(:channel) { :sms }
before do
allow(MessageBird::Client).to receive(:new)
end
- it 'uses the api key defined in the settings' do
+ it "uses the api key defined in the settings" do
result
expect(MessageBird::Client).to have_received(:new).with(apikey)
end
end
- describe 'calling the real test API' do
- let(:apikey) { ENV.fetch('MESSAGEBIRD_TEST_APIKEY', nil) }
+ describe "calling the real test API" do
+ let(:apikey) { ENV.fetch("MESSAGEBIRD_TEST_APIKEY", nil) }
before do
- skip 'Missing MESSAGEBIRD_TEST_APIKEY environment variable' unless apikey.present?
+ skip "Missing MESSAGEBIRD_TEST_APIKEY environment variable" unless apikey.present?
end
- context 'with SMS' do
+ context "with SMS" do
let(:channel) { :sms }
- it 'returns success in the service' do
+ it "returns success in the service" do
expect(result).to be_success
end
end
- context 'with VOICE' do
+ context "with VOICE" do
let(:channel) { :voice }
- it 'returns success in the service' do
+ it "returns success in the service" do
expect(result).to be_success
end
end
end
- describe 'calling a mocked API Client' do
+ describe "calling a mocked API Client" do
let(:messagebird) { instance_double(MessageBird::Client) }
let(:failed_count) { 0 }
- let(:response) { instance_double(MessageBird::Message, recipients: { 'totalDeliveryFailedCount' => failed_count }) }
+ let(:response) { instance_double(MessageBird::Message, recipients: { "totalDeliveryFailedCount" => failed_count }) }
let(:channel) { :sms }
before do
@@ -96,34 +96,34 @@
.and_return(messagebird)
end
- context 'with SMS' do
+ context "with SMS" do
before do
allow(messagebird)
.to receive(:message_create)
.with(Setting.app_title,
- '49123456789',
- I18n.t('two_factor_authentication.text_otp_delivery_message_sms', app_title: Setting.app_title, token: '1234'),
+ "49123456789",
+ I18n.t("two_factor_authentication.text_otp_delivery_message_sms", app_title: Setting.app_title, token: "1234"),
validity: 720)
.and_return(response)
end
- it 'returns success in the service' do
+ it "returns success in the service" do
expect(result).to be_success
end
- context 'failure' do
+ context "failure" do
let(:failed_count) { 1 }
- it 'returns error in the service' do
+ it "returns error in the service" do
expect(result).not_to be_success
expect(result.errors).to be_present
end
end
end
- context 'with voice' do
+ context "with voice" do
let(:channel) { :voice }
- let(:expected_language) { :'en-us' }
+ let(:expected_language) { :"en-us" }
before do
allow(subject.strategy)
@@ -136,35 +136,35 @@
.and_return(response)
end
- it 'returns success in the service' do
+ it "returns success in the service" do
expect(result).to be_success
expect(messagebird)
.to have_received(:voice_message_create)
- .with('49123456789',
- subject.strategy.send(:localized_message, locale, '1234'),
+ .with("49123456789",
+ subject.strategy.send(:localized_message, locale, "1234"),
ifMachine: :continue,
language: expected_language)
end
- context 'failure' do
+ context "failure" do
let(:failed_count) { 1 }
- it 'returns error in the service' do
+ it "returns error in the service" do
expect(result).not_to be_success
expect(result.errors).to be_present
end
end
- context 'with german locale' do
- let(:locale) { 'de' }
- let(:expected_language) { :'de-de' }
+ context "with german locale" do
+ let(:locale) { "de" }
+ let(:expected_language) { :"de-de" }
- it 'returns success in the service' do
+ it "returns success in the service" do
expect(result).to be_success
expect(messagebird)
.to have_received(:voice_message_create)
- .with('49123456789',
- subject.strategy.send(:localized_message, locale, '1234'),
+ .with("49123456789",
+ subject.strategy.send(:localized_message, locale, "1234"),
ifMachine: :continue,
language: expected_language)
end
diff --git a/modules/two_factor_authentication/spec/services/token_delivery/sns_spec.rb b/modules/two_factor_authentication/spec/services/token_delivery/sns_spec.rb
index 44d0acf3b1ed..9c2a538555e2 100644
--- a/modules/two_factor_authentication/spec/services/token_delivery/sns_spec.rb
+++ b/modules/two_factor_authentication/spec/services/token_delivery/sns_spec.rb
@@ -1,26 +1,26 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
RSpec.describe OpenProject::TwoFactorAuthentication::TokenStrategy::Sns do
- describe 'sending messages' do
- let(:phone) { '+49 123456789' }
+ describe "sending messages" do
+ let(:phone) { "+49 123456789" }
let!(:user) { create(:user) }
let!(:device) { create(:two_factor_authentication_device_sms, user:, channel:) }
let(:channel) { :sms }
let(:sns_params) do
{
- region: 'eu-west-1',
- access_key_id: 'foobar',
- secret_access_key: 'foobar key'
+ region: "eu-west-1",
+ access_key_id: "foobar",
+ secret_access_key: "foobar key"
}
end
- include_context 'with settings' do
+ include_context "with settings" do
let(:settings) do
{
plugin_openproject_two_factor_authentication: {
- 'active_strategies' => [:sns],
- 'sns' => sns_params
+ "active_strategies" => [:sns],
+ "sns" => sns_params
}
}
end
@@ -29,28 +29,28 @@
before do
allow_any_instance_of(OpenProject::TwoFactorAuthentication::TokenStrategy::Sns)
.to receive(:create_mobile_otp)
- .and_return('1234')
+ .and_return("1234")
end
- describe '#setup' do
- context 'for valid params' do
- it 'validates without errors' do
+ describe "#setup" do
+ context "for valid params" do
+ it "validates without errors" do
expect { described_class.validate! }
.not_to raise_exception
end
end
- context 'for incomplete params' do
+ context "for incomplete params" do
let(:sns_params) { { region: nil } }
- it 'raises an exception' do
+ it "raises an exception" do
expect { described_class.validate! }
.to raise_exception(ArgumentError)
end
end
end
- describe 'calling a mocked AWS API' do
+ describe "calling a mocked AWS API" do
subject { TwoFactorAuthentication::TokenService.new user: }
let(:result) { subject.request }
@@ -60,21 +60,21 @@
expect(Aws::SNS::Client).to receive(:new).and_return api
end
- context 'assuming invalid credentials' do
+ context "assuming invalid credentials" do
before do
expect(api)
.to receive(:set_sms_attributes)
.with(any_args)
- .and_raise('The security token included in the request is invalid.')
+ .and_raise("The security token included in the request is invalid.")
end
- it 'does not raise an exception out of delivery' do
+ it "does not raise an exception out of delivery" do
expect(result).not_to be_success
- expect(result.errors.full_messages).to eq([I18n.t('two_factor_authentication.sns.delivery_failed')])
+ expect(result.errors.full_messages).to eq([I18n.t("two_factor_authentication.sns.delivery_failed")])
end
end
- context 'assuming valid credential' do
+ context "assuming valid credential" do
let(:api_result) { double }
before do
@@ -83,13 +83,13 @@
expect(api).to receive(:set_sms_attributes).and_return(nil)
expect(api)
.to receive(:publish)
- .with({ phone_number: phone.delete(' '),
- message: I18n.t('two_factor_authentication.text_otp_delivery_message_sms',
+ .with({ phone_number: phone.delete(" "),
+ message: I18n.t("two_factor_authentication.text_otp_delivery_message_sms",
app_title: Setting.app_title, token: 1234) })
.and_return(api_result)
end
- it 'returns a successful delivery' do
+ it "returns a successful delivery" do
expect(result).to be_success
end
end
diff --git a/modules/two_factor_authentication/spec/services/token_delivery/totp_spec.rb b/modules/two_factor_authentication/spec/services/token_delivery/totp_spec.rb
index b8718c58f823..ca6e598524aa 100644
--- a/modules/two_factor_authentication/spec/services/token_delivery/totp_spec.rb
+++ b/modules/two_factor_authentication/spec/services/token_delivery/totp_spec.rb
@@ -1,23 +1,23 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
RSpec.describe OpenProject::TwoFactorAuthentication::TokenStrategy::Totp do
- describe 'sending messages' do
+ describe "sending messages" do
let!(:user) { create(:user) }
let!(:device) { create(:two_factor_authentication_device_totp, user:, default: true) }
- describe '#verify' do
+ describe "#verify" do
subject { TwoFactorAuthentication::TokenService.new user: }
let(:result) { subject.verify token }
- context 'with valid current token' do
+ context "with valid current token" do
let(:token) { device.totp.now }
- it 'is validated' do
+ it "is validated" do
expect(result).to be_success
end
- it 'is validated only once' do
+ it "is validated only once" do
expect(subject.verify(token)).to be_success
# Last OTP date is remembered for the device.
@@ -25,26 +25,26 @@
end
end
- context 'with invalid token' do
- let(:token) { 'definitely invalid' }
+ context "with invalid token" do
+ let(:token) { "definitely invalid" }
- it 'is not validated' do
+ it "is not validated" do
expect(result).not_to be_success
expect(result.errors[:base]).to include I18n.t(:notice_account_otp_invalid)
end
end
- context 'with internal error' do
+ context "with internal error" do
let(:token) { 1234 }
before do
allow_any_instance_of(TwoFactorAuthentication::Device::Totp)
- .to receive(:verify_token).and_raise 'Some internal error!'
+ .to receive(:verify_token).and_raise "Some internal error!"
end
- it 'returns a successful delivery' do
+ it "returns a successful delivery" do
expect(result).not_to be_success
- expect(result.errors[:base]).to include 'Some internal error!'
+ expect(result.errors[:base]).to include "Some internal error!"
end
end
end
diff --git a/modules/two_factor_authentication/spec/services/token_service_spec.rb b/modules/two_factor_authentication/spec/services/token_service_spec.rb
index 067f86dcc61e..f9e0f525c8d2 100644
--- a/modules/two_factor_authentication/spec/services/token_service_spec.rb
+++ b/modules/two_factor_authentication/spec/services/token_service_spec.rb
@@ -1,13 +1,13 @@
-require_relative '../spec_helper'
+require_relative "../spec_helper"
RSpec.describe TwoFactorAuthentication::TokenService do
- describe 'sending messages' do
+ describe "sending messages" do
let(:user) { create(:user) }
let(:dev_strategy) { OpenProject::TwoFactorAuthentication::TokenStrategy::Developer }
let(:configuration) do
{
- 'active_strategies' => active_strategies,
- 'enforced' => enforced
+ "active_strategies" => active_strategies,
+ "enforced" => enforced
}
end
let(:enforced) { false }
@@ -16,7 +16,7 @@
subject { described_class.new user: }
- include_context 'with settings' do
+ include_context "with settings" do
let(:settings) do
{
plugin_openproject_two_factor_authentication: configuration
@@ -24,10 +24,10 @@
end
end
- context 'when no strategy is set' do
+ context "when no strategy is set" do
let(:active_strategies) { [] }
- context 'when enforced' do
+ context "when enforced" do
let(:enforced) { true }
before do
@@ -36,17 +36,17 @@
.and_return false
end
- it 'requires a token' do
+ it "requires a token" do
expect(subject).to be_requires_token
end
- it 'returns error when requesting' do
+ it "returns error when requesting" do
expect(result).not_to be_success
- expect(result.errors.full_messages).to eq [I18n.t('two_factor_authentication.error_2fa_disabled')]
+ expect(result.errors.full_messages).to eq [I18n.t("two_factor_authentication.error_2fa_disabled")]
end
end
- context 'when not enforced' do
+ context "when not enforced" do
let(:enforced) { false }
before do
@@ -55,59 +55,59 @@
.and_return false
end
- it 'requires no token' do
+ it "requires no token" do
expect(subject).not_to be_requires_token
end
- it 'returns error when requesting' do
+ it "returns error when requesting" do
expect(result).not_to be_success
- expect(result.errors.full_messages).to eq [I18n.t('two_factor_authentication.error_2fa_disabled')]
+ expect(result.errors.full_messages).to eq [I18n.t("two_factor_authentication.error_2fa_disabled")]
end
end
end
- context 'when developer strategy is set' do
+ context "when developer strategy is set" do
let(:active_strategies) { [:developer] }
- context 'when no device exists' do
- it 'returns an error' do
+ context "when no device exists" do
+ it "returns an error" do
expect(result).not_to be_success
- expect(result.errors.full_messages).to eq [I18n.t('two_factor_authentication.error_no_device')]
+ expect(result.errors.full_messages).to eq [I18n.t("two_factor_authentication.error_no_device")]
end
end
- context 'when matching device exists' do
+ context "when matching device exists" do
let!(:device) { create(:two_factor_authentication_device_sms, user:, default: true) }
- it 'submits the request' do
+ it "submits the request" do
expect(subject).to be_requires_token
expect(result).to be_success
expect(result.errors).to be_empty
end
end
- context 'when non-matching device exists' do
+ context "when non-matching device exists" do
let!(:device) { create(:two_factor_authentication_device_totp, user:, default: true) }
- it 'submits the request' do
+ it "submits the request" do
expect(subject).to be_requires_token
expect(result).not_to be_success
- expect(result.errors.full_messages).to eq [I18n.t('two_factor_authentication.error_no_matching_strategy')]
+ expect(result.errors.full_messages).to eq [I18n.t("two_factor_authentication.error_no_matching_strategy")]
end
end
end
- context 'when developer and totp strategies are set' do
+ context "when developer and totp strategies are set" do
let(:active_strategies) { %i[developer totp] }
let!(:totp_device) { create(:two_factor_authentication_device_totp, user:, default: true) }
let!(:sms_device) { create(:two_factor_authentication_device_sms, user:, default: false) }
subject { described_class.new user:, use_device: }
- context 'with default device/channel' do
+ context "with default device/channel" do
let(:use_device) { nil }
- it 'uses the totp device' do
+ it "uses the totp device" do
expect(subject).to be_requires_token
expect(result).to be_success
expect(result.errors).to be_empty
@@ -117,10 +117,10 @@
end
end
- context 'with overridden device' do
+ context "with overridden device" do
let(:use_device) { sms_device }
- it 'uses the overridden device' do
+ it "uses the overridden device" do
expect(subject).to be_requires_token
expect(result).to be_success
expect(result.errors).to be_empty
diff --git a/modules/webhooks/app/components/webhooks/outgoing/deliveries/response_component.rb b/modules/webhooks/app/components/webhooks/outgoing/deliveries/response_component.rb
index 36b3b2259a19..f5b50f05b78f 100644
--- a/modules/webhooks/app/components/webhooks/outgoing/deliveries/response_component.rb
+++ b/modules/webhooks/app/components/webhooks/outgoing/deliveries/response_component.rb
@@ -7,7 +7,7 @@ class ResponseComponent < ApplicationComponent
property :response_body
def title
- model.class.human_attribute_name('response_body')
+ model.class.human_attribute_name("response_body")
end
end
end
diff --git a/modules/webhooks/app/components/webhooks/outgoing/deliveries/table_component.rb b/modules/webhooks/app/components/webhooks/outgoing/deliveries/table_component.rb
index 26a01092973a..e85a8cf93498 100644
--- a/modules/webhooks/app/components/webhooks/outgoing/deliveries/table_component.rb
+++ b/modules/webhooks/app/components/webhooks/outgoing/deliveries/table_component.rb
@@ -9,16 +9,16 @@ def sortable?
end
def empty_row_message
- I18n.t 'webhooks.outgoing.deliveries.no_results_table'
+ I18n.t "webhooks.outgoing.deliveries.no_results_table"
end
def headers
[
- ['id', { caption: I18n.t('attributes.id') }],
- ['event_name', { caption: ::Webhooks::Log.human_attribute_name('event_name') }],
- ['time', { caption: I18n.t('webhooks.outgoing.deliveries.time') }],
- ['response_code', { caption: ::Webhooks::Log.human_attribute_name('response_code') }],
- ['response_body', { caption: ::Webhooks::Log.human_attribute_name('response_body') }]
+ ["id", { caption: I18n.t("attributes.id") }],
+ ["event_name", { caption: ::Webhooks::Log.human_attribute_name("event_name") }],
+ ["time", { caption: I18n.t("webhooks.outgoing.deliveries.time") }],
+ ["response_code", { caption: ::Webhooks::Log.human_attribute_name("response_code") }],
+ ["response_body", { caption: ::Webhooks::Log.human_attribute_name("response_body") }]
]
end
end
diff --git a/modules/webhooks/app/components/webhooks/outgoing/webhooks/row_component.rb b/modules/webhooks/app/components/webhooks/outgoing/webhooks/row_component.rb
index 1833c9c235f4..0cf9b561dd2e 100644
--- a/modules/webhooks/app/components/webhooks/outgoing/webhooks/row_component.rb
+++ b/modules/webhooks/app/components/webhooks/outgoing/webhooks/row_component.rb
@@ -15,7 +15,7 @@ def name
def enabled
if webhook.enabled?
- helpers.op_icon 'icon-yes'
+ helpers.op_icon "icon-yes"
end
end
@@ -30,9 +30,9 @@ def events
count = selected_events.count
if count <= 3
- selected_events.join(', ')
+ selected_events.join(", ")
else
- content_tag('span', count, class: 'badge -border-only')
+ content_tag("span", count, class: "badge -border-only")
end
end
@@ -50,17 +50,17 @@ def selected_projects
if selected.empty?
"(#{I18n.t(:label_all)})"
elsif selected.size <= 3
- webhook.projects.pluck(:name).join(', ')
+ webhook.projects.pluck(:name).join(", ")
else
- content_tag('span', selected, class: 'badge -border-only')
+ content_tag("span", selected, class: "badge -border-only")
end
end
def row_css_class
[
- 'webhooks--outgoing-webhook-row',
+ "webhooks--outgoing-webhook-row",
"webhooks--outgoing-webhook-row-#{model.id}"
- ].join(' ')
+ ].join(" ")
end
###
@@ -71,7 +71,7 @@ def button_links
def edit_link
link_to(
- helpers.op_icon('icon icon-edit button--link'),
+ helpers.op_icon("icon icon-edit button--link"),
{ controller: table.target_controller, action: :edit, webhook_id: webhook.id },
title: t(:button_edit)
)
@@ -79,7 +79,7 @@ def edit_link
def delete_link
link_to(
- helpers.op_icon('icon icon-delete button--link'),
+ helpers.op_icon("icon icon-delete button--link"),
{ controller: table.target_controller, action: :destroy, webhook_id: webhook.id },
method: :delete,
data: { confirm: I18n.t(:text_are_you_sure) },
diff --git a/modules/webhooks/app/components/webhooks/outgoing/webhooks/table_component.rb b/modules/webhooks/app/components/webhooks/outgoing/webhooks/table_component.rb
index b9c2cf52ce6c..b337ed5c4793 100644
--- a/modules/webhooks/app/components/webhooks/outgoing/webhooks/table_component.rb
+++ b/modules/webhooks/app/components/webhooks/outgoing/webhooks/table_component.rb
@@ -9,7 +9,7 @@ def initial_sort
end
def target_controller
- 'webhooks/outgoing/admin'
+ "webhooks/outgoing/admin"
end
def sortable?
@@ -18,23 +18,23 @@ def sortable?
def inline_create_link
link_to({ controller: target_controller, action: :new },
- class: 'webhooks--add-row wp-inline-create--add-link',
- title: I18n.t('webhooks.outgoing.label_add_new')) do
- helpers.op_icon('icon icon-add')
+ class: "webhooks--add-row wp-inline-create--add-link",
+ title: I18n.t("webhooks.outgoing.label_add_new")) do
+ helpers.op_icon("icon icon-add")
end
end
def empty_row_message
- I18n.t 'webhooks.outgoing.no_results_table'
+ I18n.t "webhooks.outgoing.no_results_table"
end
def headers
[
- ['name', { caption: I18n.t('attributes.name') }],
- ['enabled', { caption: I18n.t(:label_active) }],
- ['selected_projects', { caption: ::Webhooks::Webhook.human_attribute_name('projects') }],
- ['events', { caption: I18n.t('webhooks.outgoing.label_event_resources') }],
- ['description', { caption: I18n.t('attributes.description') }]
+ ["name", { caption: I18n.t("attributes.name") }],
+ ["enabled", { caption: I18n.t(:label_active) }],
+ ["selected_projects", { caption: ::Webhooks::Webhook.human_attribute_name("projects") }],
+ ["events", { caption: I18n.t("webhooks.outgoing.label_event_resources") }],
+ ["description", { caption: I18n.t("attributes.description") }]
]
end
end
diff --git a/modules/webhooks/app/controllers/webhooks/incoming/hooks_controller.rb b/modules/webhooks/app/controllers/webhooks/incoming/hooks_controller.rb
index acfbceb747f5..208399b7d3fb 100644
--- a/modules/webhooks/app/controllers/webhooks/incoming/hooks_controller.rb
+++ b/modules/webhooks/app/controllers/webhooks/incoming/hooks_controller.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'json'
+require "json"
module Webhooks
module Incoming
@@ -50,7 +50,7 @@ def api_request?
end
def handle_hook
- hook = OpenProject::Webhooks.find(params.require('hook_name'))
+ hook = OpenProject::Webhooks.find(params.require("hook_name"))
if hook
code = hook.handle(request, params, find_current_user)
diff --git a/modules/webhooks/app/controllers/webhooks/outgoing/admin_controller.rb b/modules/webhooks/app/controllers/webhooks/outgoing/admin_controller.rb
index 7643afaffbf6..9f673f86b841 100644
--- a/modules/webhooks/app/controllers/webhooks/outgoing/admin_controller.rb
+++ b/modules/webhooks/app/controllers/webhooks/outgoing/admin_controller.rb
@@ -1,7 +1,7 @@
module Webhooks
module Outgoing
class AdminController < ::ApplicationController
- layout 'admin'
+ layout "admin"
before_action :require_admin
before_action :find_webhook, only: %i[show edit update destroy]
diff --git a/modules/webhooks/app/models/webhooks.rb b/modules/webhooks/app/models/webhooks.rb
index 03e7ca351281..e802584216a2 100644
--- a/modules/webhooks/app/models/webhooks.rb
+++ b/modules/webhooks/app/models/webhooks.rb
@@ -1,5 +1,5 @@
module Webhooks
def self.table_name_prefix
- 'webhooks_'
+ "webhooks_"
end
end
diff --git a/modules/webhooks/app/models/webhooks/log.rb b/modules/webhooks/app/models/webhooks/log.rb
index f09b689f2b33..ca0829ee60ae 100644
--- a/modules/webhooks/app/models/webhooks/log.rb
+++ b/modules/webhooks/app/models/webhooks/log.rb
@@ -1,6 +1,6 @@
module Webhooks
class Log < ApplicationRecord
- belongs_to :webhook, foreign_key: :webhooks_webhook_id, class_name: '::Webhooks::Webhook', dependent: :destroy
+ belongs_to :webhook, foreign_key: :webhooks_webhook_id, class_name: "::Webhooks::Webhook", dependent: :destroy
validates :url, presence: true
validates :event_name, presence: true
diff --git a/modules/webhooks/app/models/webhooks/project.rb b/modules/webhooks/app/models/webhooks/project.rb
index 539b6f94cdc5..438986db6ce5 100644
--- a/modules/webhooks/app/models/webhooks/project.rb
+++ b/modules/webhooks/app/models/webhooks/project.rb
@@ -1,7 +1,7 @@
module Webhooks
class Project < ApplicationRecord
belongs_to :webhook
- belongs_to :project, class_name: '::Project'
+ belongs_to :project, class_name: "::Project"
validates_presence_of :project
end
diff --git a/modules/webhooks/app/models/webhooks/webhook.rb b/modules/webhooks/app/models/webhooks/webhook.rb
index 5cc5c9d91eaf..c8084c301d17 100644
--- a/modules/webhooks/app/models/webhooks/webhook.rb
+++ b/modules/webhooks/app/models/webhooks/webhook.rb
@@ -8,10 +8,10 @@ class Webhook < ApplicationRecord
validates_uniqueness_of :name
validates :url, url: true
- has_many :events, foreign_key: :webhooks_webhook_id, class_name: '::Webhooks::Event', dependent: :delete_all
- has_many :webhook_projects, foreign_key: :webhooks_webhook_id, class_name: '::Webhooks::Project', dependent: :delete_all
+ has_many :events, foreign_key: :webhooks_webhook_id, class_name: "::Webhooks::Event", dependent: :delete_all
+ has_many :webhook_projects, foreign_key: :webhooks_webhook_id, class_name: "::Webhooks::Project", dependent: :delete_all
has_many :projects, through: :webhook_projects
- has_many :deliveries, foreign_key: :webhooks_webhook_id, class_name: '::Webhooks::Log', dependent: :delete_all
+ has_many :deliveries, foreign_key: :webhooks_webhook_id, class_name: "::Webhooks::Log", dependent: :delete_all
def self.enabled
where(enabled: true)
diff --git a/modules/webhooks/app/services/webhooks/outgoing/update_webhook_service.rb b/modules/webhooks/app/services/webhooks/outgoing/update_webhook_service.rb
index 3dbdfc8d0d82..35874386206d 100644
--- a/modules/webhooks/app/services/webhooks/outgoing/update_webhook_service.rb
+++ b/modules/webhooks/app/services/webhooks/outgoing/update_webhook_service.rb
@@ -35,7 +35,7 @@ def set_selected_projects!(params)
option = params.delete :project_ids
selected = params.delete :selected_project_ids
- if option == 'all'
+ if option == "all"
webhook.all_projects = true
else
webhook.all_projects = false
diff --git a/modules/webhooks/app/workers/cleanup_webhook_logs_job.rb b/modules/webhooks/app/workers/cleanup_webhook_logs_job.rb
index c3b310737107..00fd8f2233ae 100644
--- a/modules/webhooks/app/workers/cleanup_webhook_logs_job.rb
+++ b/modules/webhooks/app/workers/cleanup_webhook_logs_job.rb
@@ -30,7 +30,7 @@ class CleanupWebhookLogsJob < ApplicationJob
# Clean any logs older than 7 days
def perform
::Webhooks::Log
- .where('created_at < ?', 7.days.ago)
+ .where("created_at < ?", 7.days.ago)
.delete_all
end
end
diff --git a/modules/webhooks/app/workers/project_webhook_job.rb b/modules/webhooks/app/workers/project_webhook_job.rb
index 2d04c479cf65..1951fa10ea2e 100644
--- a/modules/webhooks/app/workers/project_webhook_job.rb
+++ b/modules/webhooks/app/workers/project_webhook_job.rb
@@ -32,7 +32,7 @@ def payload_key
end
def accepted_in_project?
- if event_name == 'project:created'
+ if event_name == "project:created"
true
else
webhook.enabled_for_project?(resource.id)
diff --git a/modules/webhooks/app/workers/represented_webhook_job.rb b/modules/webhooks/app/workers/represented_webhook_job.rb
index 68fb45bec7cc..c058938a5237 100644
--- a/modules/webhooks/app/workers/represented_webhook_job.rb
+++ b/modules/webhooks/app/workers/represented_webhook_job.rb
@@ -43,7 +43,7 @@ def perform(webhook_id, resource, event_name)
response = nil
if signature = request_signature(body)
- headers['X-OP-Signature'] = signature
+ headers["X-OP-Signature"] = signature
end
begin
diff --git a/modules/webhooks/config/routes.rb b/modules/webhooks/config/routes.rb
index fd28b654c70c..f2bc12676202 100644
--- a/modules/webhooks/config/routes.rb
+++ b/modules/webhooks/config/routes.rb
@@ -27,16 +27,16 @@
#++
Rails.application.routes.draw do
- namespace 'webhooks' do
- match ":hook_name", to: 'incoming/hooks#handle_hook', via: %i(get post)
+ namespace "webhooks" do
+ match ":hook_name", to: "incoming/hooks#handle_hook", via: %i(get post)
end
- scope 'admin' do
+ scope "admin" do
scope :settings do
resources :webhooks,
param: :webhook_id,
- controller: 'webhooks/outgoing/admin',
- as: 'admin_outgoing_webhooks'
+ controller: "webhooks/outgoing/admin",
+ as: "admin_outgoing_webhooks"
end
end
end
diff --git a/modules/webhooks/lib/open_project/webhooks/engine.rb b/modules/webhooks/lib/open_project/webhooks/engine.rb
index 7f540ee16676..4b65c8343fa1 100644
--- a/modules/webhooks/lib/open_project/webhooks/engine.rb
+++ b/modules/webhooks/lib/open_project/webhooks/engine.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'open_project/plugins'
+require "open_project/plugins"
module OpenProject::Webhooks
class Engine < ::Rails::Engine
@@ -34,18 +34,18 @@ class Engine < ::Rails::Engine
include OpenProject::Plugins::ActsAsOpEngine
- register 'openproject-webhooks',
+ register "openproject-webhooks",
bundled: true,
- author_url: 'https://www.openproject.org' do
+ author_url: "https://www.openproject.org" do
menu :admin_menu,
:plugin_webhooks,
- { controller: 'webhooks/outgoing/admin', action: :index },
+ { controller: "webhooks/outgoing/admin", action: :index },
if: Proc.new { User.current.admin? },
parent: :api_and_webhooks,
- caption: :'webhooks.plural'
+ caption: :"webhooks.plural"
end
- initializer 'webhooks.subscribe_to_notifications' do |app|
+ initializer "webhooks.subscribe_to_notifications" do |app|
app.config.after_initialize do
::OpenProject::Webhooks::EventResources.subscribe!
end
@@ -54,7 +54,7 @@ class Engine < ::Rails::Engine
add_cron_jobs do
{
CleanupWebhookLogsJob: {
- cron: '28 5 * * 7', # runs at 5:28 on Sunday
+ cron: "28 5 * * 7", # runs at 5:28 on Sunday
class: ::CleanupWebhookLogsJob.name
}
}
diff --git a/modules/webhooks/lib/open_project/webhooks/event_resources/attachment.rb b/modules/webhooks/lib/open_project/webhooks/event_resources/attachment.rb
index cde2ea91e38e..2d2f21ffd1a9 100644
--- a/modules/webhooks/lib/open_project/webhooks/event_resources/attachment.rb
+++ b/modules/webhooks/lib/open_project/webhooks/event_resources/attachment.rb
@@ -1,4 +1,4 @@
-require_relative 'base'
+require_relative "base"
module OpenProject::Webhooks::EventResources
class Attachment < Base
@@ -14,13 +14,13 @@ def available_actions
end
def resource_name
- I18n.t :'attributes.attachments'
+ I18n.t :"attributes.attachments"
end
protected
def handle_notification(payload, event_name)
- action = event_name.split('_').last
+ action = event_name.split("_").last
event_name = prefixed_event_name(action)
active_webhooks.with_event_name(event_name).pluck(:id).each do |id|
diff --git a/modules/webhooks/lib/open_project/webhooks/event_resources/base.rb b/modules/webhooks/lib/open_project/webhooks/event_resources/base.rb
index 172cfaf1f211..501c2a1f29c4 100644
--- a/modules/webhooks/lib/open_project/webhooks/event_resources/base.rb
+++ b/modules/webhooks/lib/open_project/webhooks/event_resources/base.rb
@@ -40,7 +40,7 @@ def available_actions
##
# Localize the given event name
def localize_event_name(key)
- I18n.t(key, scope: 'webhooks.outgoing.events')
+ I18n.t(key, scope: "webhooks.outgoing.events")
end
##
diff --git a/modules/webhooks/lib/open_project/webhooks/event_resources/project.rb b/modules/webhooks/lib/open_project/webhooks/event_resources/project.rb
index 5b357acf2b8b..93d67692550d 100644
--- a/modules/webhooks/lib/open_project/webhooks/event_resources/project.rb
+++ b/modules/webhooks/lib/open_project/webhooks/event_resources/project.rb
@@ -1,4 +1,4 @@
-require_relative 'base'
+require_relative "base"
module OpenProject::Webhooks::EventResources
class Project < Base
@@ -21,7 +21,7 @@ def resource_name
protected
def handle_notification(payload, event_name)
- action = event_name.split('_').last
+ action = event_name.split("_").last
event_name = prefixed_event_name(action)
active_webhooks.with_event_name(event_name).pluck(:id).each do |id|
diff --git a/modules/webhooks/lib/open_project/webhooks/event_resources/time_entry.rb b/modules/webhooks/lib/open_project/webhooks/event_resources/time_entry.rb
index 1f9b4ae63230..5c0bc713241a 100644
--- a/modules/webhooks/lib/open_project/webhooks/event_resources/time_entry.rb
+++ b/modules/webhooks/lib/open_project/webhooks/event_resources/time_entry.rb
@@ -1,4 +1,4 @@
-require_relative 'base'
+require_relative "base"
module OpenProject::Webhooks::EventResources
class TimeEntry < Base
@@ -14,7 +14,7 @@ def available_actions
end
def resource_name
- I18n.t 'webhooks.resources.time_entry.name'
+ I18n.t "webhooks.resources.time_entry.name"
end
protected
diff --git a/modules/webhooks/lib/open_project/webhooks/event_resources/work_package.rb b/modules/webhooks/lib/open_project/webhooks/event_resources/work_package.rb
index 3e9100f770c3..41e380c1007d 100644
--- a/modules/webhooks/lib/open_project/webhooks/event_resources/work_package.rb
+++ b/modules/webhooks/lib/open_project/webhooks/event_resources/work_package.rb
@@ -1,4 +1,4 @@
-require_relative 'base'
+require_relative "base"
module OpenProject::Webhooks::EventResources
class WorkPackage < Base
diff --git a/modules/webhooks/lib/openproject-webhooks.rb b/modules/webhooks/lib/openproject-webhooks.rb
index d804ed38fafb..0d1b5c7c464c 100644
--- a/modules/webhooks/lib/openproject-webhooks.rb
+++ b/modules/webhooks/lib/openproject-webhooks.rb
@@ -26,4 +26,4 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'open_project/webhooks'
+require "open_project/webhooks"
diff --git a/modules/webhooks/openproject-webhooks.gemspec b/modules/webhooks/openproject-webhooks.gemspec
index ebe5a382904c..2e5272dc381b 100644
--- a/modules/webhooks/openproject-webhooks.gemspec
+++ b/modules/webhooks/openproject-webhooks.gemspec
@@ -1,13 +1,13 @@
Gem::Specification.new do |s|
s.name = "openproject-webhooks"
- s.version = '1.0.0'
+ s.version = "1.0.0"
s.authors = "OpenProject GmbH"
s.email = "info@openproject.com"
s.homepage = "https://github.com/opf/openproject-webhooks"
- s.summary = 'OpenProject Webhooks'
- s.description = 'Provides a plug-in API to support OpenProject webhooks for better 3rd party integration'
- s.license = 'GPLv3'
+ s.summary = "OpenProject Webhooks"
+ s.description = "Provides a plug-in API to support OpenProject webhooks for better 3rd party integration"
+ s.license = "GPLv3"
s.files = Dir["{app,config,db,doc,lib}/**/*"] + %w(README.md)
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/webhooks/spec/components/webhooks/outgoing/deliveries/table_component_spec.rb b/modules/webhooks/spec/components/webhooks/outgoing/deliveries/table_component_spec.rb
index d463d231b712..920d70b4e1cd 100644
--- a/modules/webhooks/spec/components/webhooks/outgoing/deliveries/table_component_spec.rb
+++ b/modules/webhooks/spec/components/webhooks/outgoing/deliveries/table_component_spec.rb
@@ -25,25 +25,25 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Webhooks::Outgoing::Deliveries::TableComponent, type: :component do
- it 'escapes response body html' do
- delivery = create(:webhook_log, response_body: 'Hello world!')
+ it "escapes response body html" do
+ delivery = create(:webhook_log, response_body: "Hello world!")
render_inline described_class.new(rows: [delivery])
expect(page).to have_css("pre.webhooks--response-body", text: delivery.response_body)
end
- it 'escapes response headers html' do
+ it "escapes response headers html" do
header_name = "x_header_evil_name"
header_value = "header evil value"
delivery = create(:webhook_log, response_headers: { header_name => header_value })
render_inline described_class.new(rows: [delivery])
- response_headers_node = page.find('pre.webhooks--response-headers')
+ response_headers_node = page.find("pre.webhooks--response-headers")
aggregate_failures do
- expect(response_headers_node).to have_no_css('b', text: 'evil')
+ expect(response_headers_node).to have_no_css("b", text: "evil")
expect(response_headers_node.text).to include(header_name)
expect(response_headers_node.text).to include(header_value)
end
diff --git a/modules/webhooks/spec/controllers/outgoing/admin_controller_spec.rb b/modules/webhooks/spec/controllers/outgoing/admin_controller_spec.rb
index fd8b011a9655..449c04b3c769 100644
--- a/modules/webhooks/spec/controllers/outgoing/admin_controller_spec.rb
+++ b/modules/webhooks/spec/controllers/outgoing/admin_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Webhooks::Outgoing::AdminController do
let(:user) { build_stubbed(:admin) }
@@ -35,58 +35,58 @@
login_as user
end
- context 'when not admin' do
+ context "when not admin" do
let(:user) { build_stubbed(:user) }
- it 'renders 403' do
+ it "renders 403" do
get :index
expect(response.status).to eq 403
end
end
- context 'when not logged in' do
+ context "when not logged in" do
let(:user) { User.anonymous }
- it 'renders 403' do
+ it "renders 403" do
get :index
expect(response.status).to redirect_to(signin_url(back_url: admin_outgoing_webhooks_url))
end
end
- describe '#index' do
- it 'renders the index page' do
+ describe "#index" do
+ it "renders the index page" do
get :index
expect(response).to be_successful
- expect(response).to render_template 'index'
+ expect(response).to render_template "index"
end
end
- describe '#new' do
- it 'renders the new page' do
+ describe "#new" do
+ it "renders the new page" do
get :new
expect(response).to be_successful
expect(assigns[:webhook]).to be_new_record
- expect(response).to render_template 'new'
+ expect(response).to render_template "new"
end
end
- describe '#create' do
+ describe "#create" do
let(:service) { double(Webhooks::Outgoing::UpdateWebhookService) }
let(:webhook_params) do
{
- name: 'foo',
+ name: "foo",
enabled: true
}
end
- describe 'with invalid params' do
- it 'renders an error' do
- post :create, params: { foo: 'bar' }
+ describe "with invalid params" do
+ it "renders an error" do
+ post :create, params: { foo: "bar" }
expect(response).not_to be_successful
end
end
- describe 'Calling the service' do
+ describe "Calling the service" do
before do
expect(Webhooks::Outgoing::UpdateWebhookService)
.to receive(:new)
@@ -99,69 +99,69 @@
post :create, params: { webhook: webhook_params }
end
- context 'when success' do
+ context "when success" do
let(:success) { true }
- it 'renders success' do
+ it "renders success" do
expect(flash[:notice]).to be_present
expect(response).to redirect_to(action: :index)
end
end
- context 'when not success' do
+ context "when not success" do
let(:success) { false }
- it 'renders the form again' do
+ it "renders the form again" do
expect(flash[:notice]).not_to be_present
- expect(response).to render_template 'new'
+ expect(response).to render_template "new"
end
end
end
end
- describe '#edit' do
- context 'when found' do
+ describe "#edit" do
+ context "when found" do
before do
expect(Webhooks::Webhook)
.to receive(:find)
.and_return(double(Webhooks::Webhook))
end
- it 'renders the edit page' do
- get :edit, params: { webhook_id: 'mocked' }
+ it "renders the edit page" do
+ get :edit, params: { webhook_id: "mocked" }
expect(response).to be_successful
expect(assigns[:webhook]).to be_present
- expect(response).to render_template 'edit'
+ expect(response).to render_template "edit"
end
end
- context 'when not found' do
- it 'renders 404' do
- get :edit, params: { webhook_id: '1234' }
+ context "when not found" do
+ it "renders 404" do
+ get :edit, params: { webhook_id: "1234" }
expect(response).not_to be_successful
expect(response.status).to eq 404
end
end
end
- describe '#update' do
+ describe "#update" do
let(:service) { double(Webhooks::Outgoing::UpdateWebhookService) }
let(:webhook_params) do
{
- name: 'foo',
+ name: "foo",
enabled: true
}
end
- describe 'when not found' do
- it 'renders an error' do
- put :update, params: { webhook_id: 'bar' }
+ describe "when not found" do
+ it "renders an error" do
+ put :update, params: { webhook_id: "bar" }
expect(response).not_to be_successful
expect(response.status).to eq 404
end
end
- describe 'Calling the service' do
+ describe "Calling the service" do
let(:webhook) { double(Webhooks::Webhook) }
before do
@@ -177,33 +177,33 @@
.to receive(:call)
.and_return(ServiceResult.new(success:))
- put :update, params: { webhook_id: '1234', webhook: webhook_params }
+ put :update, params: { webhook_id: "1234", webhook: webhook_params }
end
- context 'when success' do
+ context "when success" do
let(:success) { true }
- it 'renders success' do
+ it "renders success" do
expect(flash[:notice]).to be_present
expect(response).to redirect_to(action: :index)
end
end
- context 'when not success' do
+ context "when not success" do
let(:success) { false }
- it 'renders the form again' do
+ it "renders the form again" do
expect(flash[:notice]).not_to be_present
- expect(response).to render_template 'edit'
+ expect(response).to render_template "edit"
end
end
end
end
- describe '#destroy' do
+ describe "#destroy" do
let(:webhook) { double(Webhooks::Webhook) }
- context 'when found' do
+ context "when found" do
before do
expect(Webhooks::Webhook)
.to receive(:find)
@@ -214,22 +214,22 @@
.and_return(success)
end
- context 'when delete failed' do
+ context "when delete failed" do
let(:success) { false }
- it 'redirects to index' do
- delete :destroy, params: { webhook_id: 'mocked' }
+ it "redirects to index" do
+ delete :destroy, params: { webhook_id: "mocked" }
expect(response).to be_redirect
expect(flash[:notice]).not_to be_present
expect(flash[:error]).to be_present
end
end
- context 'when delete success' do
+ context "when delete success" do
let(:success) { true }
- it 'destroys the object' do
- delete :destroy, params: { webhook_id: 'mocked' }
+ it "destroys the object" do
+ delete :destroy, params: { webhook_id: "mocked" }
expect(response).to be_redirect
expect(flash[:notice]).to be_present
end
diff --git a/modules/webhooks/spec/controllers/webhooks_controller_spec.rb b/modules/webhooks/spec/controllers/webhooks_controller_spec.rb
index 5fcb518ba248..0f802cc9f582 100644
--- a/modules/webhooks/spec/controllers/webhooks_controller_spec.rb
+++ b/modules/webhooks/spec/controllers/webhooks_controller_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path('../spec_helper', __dir__)
+require File.expand_path("../spec_helper", __dir__)
RSpec.describe Webhooks::Incoming::HooksController do
let(:hook) { double(OpenProject::Webhooks::Hook) }
let(:user) { double(User).as_null_object }
- describe '#handle_hook' do
+ describe "#handle_hook" do
before do
- expect(OpenProject::Webhooks).to receive(:find).with('testhook').and_return(hook)
+ expect(OpenProject::Webhooks).to receive(:find).with("testhook").and_return(hook)
allow(controller).to receive(:find_current_user).and_return(user)
end
@@ -43,20 +43,20 @@
User.current = nil
end
- it 'is successful' do
+ it "is successful" do
expect(hook).to receive(:handle)
- post :handle_hook, params: { hook_name: 'testhook' }
+ post :handle_hook, params: { hook_name: "testhook" }
expect(response).to be_successful
end
- it 'calls the hook with a user' do
+ it "calls the hook with a user" do
expect(hook).to receive(:handle) { |_env, _params, user|
expect(user).to equal(user)
}
- post :handle_hook, params: { hook_name: 'testhook' }
+ post :handle_hook, params: { hook_name: "testhook" }
end
end
end
diff --git a/modules/webhooks/spec/factories/webhook_factory.rb b/modules/webhooks/spec/factories/webhook_factory.rb
index ee1484c3c016..190584c69fde 100644
--- a/modules/webhooks/spec/factories/webhook_factory.rb
+++ b/modules/webhooks/spec/factories/webhook_factory.rb
@@ -27,7 +27,7 @@
#++
FactoryBot.define do
- factory :webhook, class: 'Webhooks::Webhook' do
+ factory :webhook, class: "Webhooks::Webhook" do
name { "Example Webhook" }
url { "http://example.net/webhook_receiver/42" }
description { "This is an example webhook" }
diff --git a/modules/webhooks/spec/factories/webhook_log_factory.rb b/modules/webhooks/spec/factories/webhook_log_factory.rb
index 00cda0310a63..7d3f7e10b676 100644
--- a/modules/webhooks/spec/factories/webhook_log_factory.rb
+++ b/modules/webhooks/spec/factories/webhook_log_factory.rb
@@ -27,14 +27,14 @@
#++
FactoryBot.define do
- factory :webhook_log, class: 'Webhooks::Log' do
+ factory :webhook_log, class: "Webhooks::Log" do
webhook factory: :webhook
url { "http://example.net/webhook_receiver/42" }
- event_name { 'foobar' }
- response_code { '200' }
+ event_name { "foobar" }
+ response_code { "200" }
request_headers { { foo: :bar } }
- request_body { 'Request body' }
+ request_body { "Request body" }
response_headers { { response: :foo } }
- response_body { 'Response body' }
+ response_body { "Response body" }
end
end
diff --git a/modules/webhooks/spec/features/manage_webhooks_spec.rb b/modules/webhooks/spec/features/manage_webhooks_spec.rb
index 4fe0679c5b5f..dad6fbf95bfc 100644
--- a/modules/webhooks/spec/features/manage_webhooks_spec.rb
+++ b/modules/webhooks/spec/features/manage_webhooks_spec.rb
@@ -1,55 +1,55 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Manage webhooks through UI', :js do
+RSpec.describe "Manage webhooks through UI", :js do
before do
login_as user
end
- context 'as regular user' do
+ context "as regular user" do
let(:user) { create(:user) }
- it 'forbids accessing the webhooks management view' do
+ it "forbids accessing the webhooks management view" do
visit admin_outgoing_webhooks_path
- expect(page).to have_text '[Error 403]'
+ expect(page).to have_text "[Error 403]"
end
end
- context 'as admin' do
+ context "as admin" do
let(:user) { create(:admin) }
let!(:project) { create(:project) }
- it 'allows the management flow' do
+ it "allows the management flow" do
visit admin_outgoing_webhooks_path
- expect(page).to have_css('.generic-table--empty-row')
+ expect(page).to have_css(".generic-table--empty-row")
# Visit inline create
- find('.wp-inline-create--add-link').click
+ find(".wp-inline-create--add-link").click
SeleniumHubWaiter.wait
# Fill in elements
- fill_in 'webhook_name', with: 'My webhook'
- fill_in 'webhook_url', with: 'http://example.org'
+ fill_in "webhook_name", with: "My webhook"
+ fill_in "webhook_url", with: "http://example.org"
# Check one event
find('.form--check-box[value="work_package:created"]').set true
# Create
- click_on 'Create'
+ click_on "Create"
#
# 1st webhook created
#
- expect(page).to have_css('.op-toast.-success', text: I18n.t(:notice_successful_create))
- expect(page).to have_css('.webhooks--outgoing-webhook-row .name', text: 'My webhook')
+ expect(page).to have_css(".op-toast.-success", text: I18n.t(:notice_successful_create))
+ expect(page).to have_css(".webhooks--outgoing-webhook-row .name", text: "My webhook")
webhook = Webhooks::Webhook.last
expect(webhook.event_names).to eq %w(work_package:created)
expect(webhook.all_projects).to be_truthy
- expect(page).to have_css('.webhooks--outgoing-webhook-row .enabled .icon-yes')
- expect(page).to have_css('.webhooks--outgoing-webhook-row .selected_projects', text: '(all)')
- expect(page).to have_css('.webhooks--outgoing-webhook-row .events', text: 'Work packages')
- expect(page).to have_css('.webhooks--outgoing-webhook-row .description', text: webhook.description)
+ expect(page).to have_css(".webhooks--outgoing-webhook-row .enabled .icon-yes")
+ expect(page).to have_css(".webhooks--outgoing-webhook-row .selected_projects", text: "(all)")
+ expect(page).to have_css(".webhooks--outgoing-webhook-row .events", text: "Work packages")
+ expect(page).to have_css(".webhooks--outgoing-webhook-row .description", text: webhook.description)
SeleniumHubWaiter.wait
# Edit this webhook
@@ -61,12 +61,12 @@
find('.form--check-box[value="work_package:updated"]').set true
# Check a subset of projects
- choose 'webhook_project_ids_selection'
+ choose "webhook_project_ids_selection"
find(".webhooks--selected-project-ids[value='#{project.id}']").set true
- click_on 'Save'
- expect(page).to have_css('.op-toast.-success', text: I18n.t(:notice_successful_update))
- expect(page).to have_css('.webhooks--outgoing-webhook-row .name', text: 'My webhook')
+ click_on "Save"
+ expect(page).to have_css(".op-toast.-success", text: I18n.t(:notice_successful_update))
+ expect(page).to have_css(".webhooks--outgoing-webhook-row .name", text: "My webhook")
webhook = Webhooks::Webhook.last
expect(webhook.event_names).to eq %w(work_package:updated)
expect(webhook.projects.all).to eq [project]
@@ -77,54 +77,54 @@
find(".webhooks--outgoing-webhook-row-#{webhook.id} .icon-delete").click
page.driver.browser.switch_to.alert.accept
- expect(page).to have_css('.op-toast.-success', text: I18n.t(:notice_successful_delete))
- expect(page).to have_css('.generic-table--empty-row')
+ expect(page).to have_css(".op-toast.-success", text: I18n.t(:notice_successful_delete))
+ expect(page).to have_css(".generic-table--empty-row")
end
- context 'with existing webhook' do
- let!(:webhook) { create(:webhook, name: 'testing') }
+ context "with existing webhook" do
+ let!(:webhook) { create(:webhook, name: "testing") }
let!(:log) { create(:webhook_log, response_headers: { test: :foo }, webhook:) }
- it 'shows the delivery' do
+ it "shows the delivery" do
visit admin_outgoing_webhooks_path
SeleniumHubWaiter.wait
- find('.webhooks--outgoing-webhook-row .name a', text: 'testing').click
+ find(".webhooks--outgoing-webhook-row .name a", text: "testing").click
- expect(page).to have_css('.on-off-status.-enabled')
- expect(page).to have_css('td.event_name', text: 'foo')
- expect(page).to have_css('td.response_code', text: '200')
+ expect(page).to have_css(".on-off-status.-enabled")
+ expect(page).to have_css("td.event_name", text: "foo")
+ expect(page).to have_css("td.response_code", text: "200")
# Open modal
SeleniumHubWaiter.wait
- find('td.response_body a', text: 'Show').click
+ find("td.response_body a", text: "Show").click
- page.within('.spot-modal') do
- expect(page).to have_css('.webhooks--response-headers strong', text: 'test')
- expect(page).to have_css('.webhooks--response-body', text: log.response_body)
+ page.within(".spot-modal") do
+ expect(page).to have_css(".webhooks--response-headers strong", text: "test")
+ expect(page).to have_css(".webhooks--response-body", text: log.response_body)
end
end
- context 'with multiple logs' do
- let!(:log2) { create(:webhook_log, response_body: 'This is the second log', webhook:) }
- let!(:log3) { create(:webhook_log, response_body: 'This is the third log', webhook:) }
+ context "with multiple logs" do
+ let!(:log2) { create(:webhook_log, response_body: "This is the second log", webhook:) }
+ let!(:log3) { create(:webhook_log, response_body: "This is the third log", webhook:) }
- it 'shows the response of the log being clicked' do
+ it "shows the response of the log being clicked" do
visit admin_outgoing_webhook_path(webhook)
# Open modal
SeleniumHubWaiter.wait
- all('tbody tr').each do |row_element|
+ all("tbody tr").each do |row_element|
matching_log = nil
within(row_element) do
- id = find('td.id').text.to_i
+ id = find("td.id").text.to_i
matching_log = [log, log2, log3].find { |l| l.id == id }
- find('td.response_body a', text: 'Show').click
+ find("td.response_body a", text: "Show").click
end
- page.within('.spot-modal') do
- expect(page).to have_css('.webhooks--response-body', text: matching_log.response_body)
- click_button('Close')
+ page.within(".spot-modal") do
+ expect(page).to have_css(".webhooks--response-body", text: matching_log.response_body)
+ click_button("Close")
end
end
end
diff --git a/modules/webhooks/spec/lib/hook_spec.rb b/modules/webhooks/spec/lib/hook_spec.rb
index 84c789fe5822..4fed053dc768 100644
--- a/modules/webhooks/spec/lib/hook_spec.rb
+++ b/modules/webhooks/spec/lib/hook_spec.rb
@@ -26,26 +26,26 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path('../spec_helper', __dir__)
+require File.expand_path("../spec_helper", __dir__)
RSpec.describe OpenProject::Webhooks::Hook do
- describe '#relative_url' do
- let(:hook) { OpenProject::Webhooks::Hook.new('myhook') }
+ describe "#relative_url" do
+ let(:hook) { OpenProject::Webhooks::Hook.new("myhook") }
it "returns the correct URL" do
- expect(hook.relative_url).to eql('webhooks/myhook')
+ expect(hook.relative_url).to eql("webhooks/myhook")
end
end
- describe '#handle' do
+ describe "#handle" do
let(:probe) { lambda {} }
- let(:hook) { OpenProject::Webhooks::Hook.new('myhook', &probe) }
+ let(:hook) { OpenProject::Webhooks::Hook.new("myhook", &probe) }
before do
expect(probe).to receive(:call).with(hook, 1, 2, 3)
end
- it 'executes the callback with the correct parameters' do
+ it "executes the callback with the correct parameters" do
hook.handle(1, 2, 3)
end
end
diff --git a/modules/webhooks/spec/lib/webhooks_spec.rb b/modules/webhooks/spec/lib/webhooks_spec.rb
index bbfeac19eb29..869ffeaa8b41 100644
--- a/modules/webhooks/spec/lib/webhooks_spec.rb
+++ b/modules/webhooks/spec/lib/webhooks_spec.rb
@@ -26,41 +26,41 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require File.expand_path('../spec_helper', __dir__)
+require File.expand_path("../spec_helper", __dir__)
RSpec.describe OpenProject::Webhooks do
- describe '.register_hook' do
+ describe ".register_hook" do
after do
- OpenProject::Webhooks.unregister_hook('testhook1')
+ OpenProject::Webhooks.unregister_hook("testhook1")
end
- it 'succeeds' do
- OpenProject::Webhooks.register_hook('testhook1') {}
+ it "succeeds" do
+ OpenProject::Webhooks.register_hook("testhook1") {}
end
end
- describe '.find' do
- let!(:hook) { OpenProject::Webhooks.register_hook('testhook3') {} }
+ describe ".find" do
+ let!(:hook) { OpenProject::Webhooks.register_hook("testhook3") {} }
after do
- OpenProject::Webhooks.unregister_hook('testhook3')
+ OpenProject::Webhooks.unregister_hook("testhook3")
end
- it 'succeeds' do
- expect(OpenProject::Webhooks.find('testhook3')).to equal(hook)
+ it "succeeds" do
+ expect(OpenProject::Webhooks.find("testhook3")).to equal(hook)
end
end
- describe '.unregister_hook' do
+ describe ".unregister_hook" do
let(:probe) { lambda {} }
before do
- OpenProject::Webhooks.register_hook('testhook2', &probe)
+ OpenProject::Webhooks.register_hook("testhook2", &probe)
end
- it 'results in the hook no longer being found' do
- OpenProject::Webhooks.unregister_hook('testhook2')
- expect(OpenProject::Webhooks.find('testhook2')).to be_nil
+ it "results in the hook no longer being found" do
+ OpenProject::Webhooks.unregister_hook("testhook2")
+ expect(OpenProject::Webhooks.find("testhook2")).to be_nil
end
end
end
diff --git a/modules/webhooks/spec/models/webhook_spec.rb b/modules/webhooks/spec/models/webhook_spec.rb
index 04e95c8f090f..b85a87c574be 100644
--- a/modules/webhooks/spec/models/webhook_spec.rb
+++ b/modules/webhooks/spec/models/webhook_spec.rb
@@ -1,29 +1,29 @@
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Webhooks::Webhook do
subject { build(:webhook) }
- describe 'attributes' do
- describe '#url' do
- it 'accepts http' do
- subject.url = 'http://foo.example.org'
+ describe "attributes" do
+ describe "#url" do
+ it "accepts http" do
+ subject.url = "http://foo.example.org"
expect(subject).to be_valid
end
- it 'accepts http' do
- subject.url = 'https://foo.example.org'
+ it "accepts http" do
+ subject.url = "https://foo.example.org"
expect(subject).to be_valid
end
- it 'accepts other schemas' do
- subject.url = 'ftp://foo.example.org'
+ it "accepts other schemas" do
+ subject.url = "ftp://foo.example.org"
expect(subject).not_to be_valid
expect(subject.errors).to have_key(:url)
end
end
end
- describe '#events' do
+ describe "#events" do
let(:events) { %w(work_package:updated work_package:created) }
before do
@@ -31,18 +31,18 @@
subject.save!
end
- it 'has an event association' do
+ it "has an event association" do
expect(subject.events.count).to eq 2
expect(subject.event_names).to eq events
end
- it 'finds the webhook with the saved events' do
+ it "finds the webhook with the saved events" do
expect(described_class.with_event_name(events[0]).first).to eq(subject)
expect(described_class.with_event_name(events[1]).first).to eq(subject)
end
end
- describe '#projects' do
+ describe "#projects" do
let(:project1) { create(:project) }
before do
@@ -51,7 +51,7 @@
subject.save!
end
- it 'has an event association' do
+ it "has an event association" do
expect(subject.projects.count).to eq 1
expect(subject.project_ids).to eq([project1.id])
diff --git a/modules/webhooks/spec/routing/webhooks/outgoing/admin_controller_spec.rb b/modules/webhooks/spec/routing/webhooks/outgoing/admin_controller_spec.rb
index ea5a64fe84bd..4beaefcdc52c 100644
--- a/modules/webhooks/spec/routing/webhooks/outgoing/admin_controller_spec.rb
+++ b/modules/webhooks/spec/routing/webhooks/outgoing/admin_controller_spec.rb
@@ -26,38 +26,38 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Outgoing webhooks administration' do
- it 'route to index' do
- expect(get('/admin/settings/webhooks')).to route_to('webhooks/outgoing/admin#index')
+RSpec.describe "Outgoing webhooks administration" do
+ it "route to index" do
+ expect(get("/admin/settings/webhooks")).to route_to("webhooks/outgoing/admin#index")
end
- it 'route to new' do
- expect(get('/admin/settings/webhooks/new')).to route_to('webhooks/outgoing/admin#new')
+ it "route to new" do
+ expect(get("/admin/settings/webhooks/new")).to route_to("webhooks/outgoing/admin#new")
end
- it 'route to show' do
- expect(get('/admin/settings/webhooks/1')).to route_to(controller: 'webhooks/outgoing/admin',
- action: 'show',
- webhook_id: '1')
+ it "route to show" do
+ expect(get("/admin/settings/webhooks/1")).to route_to(controller: "webhooks/outgoing/admin",
+ action: "show",
+ webhook_id: "1")
end
- it 'route to edit' do
- expect(get('/admin/settings/webhooks/1/edit')).to route_to(controller: 'webhooks/outgoing/admin',
- action: 'edit',
- webhook_id: '1')
+ it "route to edit" do
+ expect(get("/admin/settings/webhooks/1/edit")).to route_to(controller: "webhooks/outgoing/admin",
+ action: "edit",
+ webhook_id: "1")
end
- it 'route to PUT update' do
- expect(put('/admin/settings/webhooks/1')).to route_to(controller: 'webhooks/outgoing/admin',
- action: 'update',
- webhook_id: '1')
+ it "route to PUT update" do
+ expect(put("/admin/settings/webhooks/1")).to route_to(controller: "webhooks/outgoing/admin",
+ action: "update",
+ webhook_id: "1")
end
- it 'route to DELETE destroy' do
- expect(delete('/admin/settings/webhooks/1')).to route_to(controller: 'webhooks/outgoing/admin',
- action: 'destroy',
- webhook_id: '1')
+ it "route to DELETE destroy" do
+ expect(delete("/admin/settings/webhooks/1")).to route_to(controller: "webhooks/outgoing/admin",
+ action: "destroy",
+ webhook_id: "1")
end
end
diff --git a/modules/webhooks/spec/spec_helper.rb b/modules/webhooks/spec/spec_helper.rb
index 5974eaa856cf..e9b86f472dd9 100644
--- a/modules/webhooks/spec/spec_helper.rb
+++ b/modules/webhooks/spec/spec_helper.rb
@@ -26,4 +26,4 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
diff --git a/modules/webhooks/spec/workers/attachment_webhook_job_spec.rb b/modules/webhooks/spec/workers/attachment_webhook_job_spec.rb
index 5ab63be0d1b8..dcf1a38ef0b4 100644
--- a/modules/webhooks/spec/workers/attachment_webhook_job_spec.rb
+++ b/modules/webhooks/spec/workers/attachment_webhook_job_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe AttachmentWebhookJob, :webmock, type: :job do
shared_let(:user) { create(:admin) }
shared_let(:request_url) { "http://example.net/test/42" }
- shared_let(:project) { create(:project, name: 'Foo Bar') }
+ shared_let(:project) { create(:project, name: "Foo Bar") }
shared_let(:container) { create(:work_package, project:) }
shared_let(:attachment) { create(:attachment, container:) }
shared_let(:webhook) { create(:webhook, all_projects: true, url: request_url, secret: nil) }
@@ -56,7 +56,7 @@
"action" => event,
"attachment" => hash_including(
"_type" => "Attachment",
- 'id' => attachment.id
+ "id" => attachment.id
)
),
headers: request_headers
@@ -82,7 +82,7 @@
end
describe "attachment webhook call" do
- it 'requests with all projects' do
+ it "requests with all projects" do
allow(webhook)
.to receive(:enabled_for_project?).with(project.id)
.and_call_original
@@ -91,7 +91,7 @@
expect(stub).to have_been_requested
end
- it 'does not request when project does not match unless create case' do
+ it "does not request when project does not match unless create case" do
allow(webhook)
.to receive(:enabled_for_project?).with(project.id)
.and_return(false)
@@ -100,10 +100,10 @@
expect(stub).not_to have_been_requested
end
- context 'with uncontainered' do
+ context "with uncontainered" do
shared_let(:attachment) { create(:attachment, container: nil) }
- it 'does requests even if project nil' do
+ it "does requests even if project nil" do
allow(webhook)
.to receive(:enabled_for_project?).with(project.id)
.and_return(false)
@@ -113,7 +113,7 @@
end
end
- describe 'successful flow' do
+ describe "successful flow" do
before do
subject
end
diff --git a/modules/webhooks/spec/workers/project_webhook_job_spec.rb b/modules/webhooks/spec/workers/project_webhook_job_spec.rb
index 1b1c8eada27c..02be1c5e54d6 100644
--- a/modules/webhooks/spec/workers/project_webhook_job_spec.rb
+++ b/modules/webhooks/spec/workers/project_webhook_job_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe ProjectWebhookJob, :webmock, type: :job do
shared_let(:user) { create(:admin) }
shared_let(:request_url) { "http://example.net/test/42" }
- shared_let(:project) { create(:project, name: 'Foo Bar') }
+ shared_let(:project) { create(:project, name: "Foo Bar") }
shared_let(:webhook) { create(:webhook, all_projects: true, url: request_url, secret: nil) }
shared_examples "a project webhook call" do
@@ -57,7 +57,7 @@
"action" => event,
"project" => hash_including(
"_type" => "Project",
- "name" => 'Foo Bar'
+ "name" => "Foo Bar"
)
),
headers: request_headers
@@ -82,7 +82,7 @@
stub
end
- it 'requests with all projects' do
+ it "requests with all projects" do
allow(webhook)
.to receive(:enabled_for_project?).with(project.id)
.and_call_original
@@ -91,20 +91,20 @@
expect(stub).to have_been_requested
end
- it 'does not request when project does not match unless create case' do
+ it "does not request when project does not match unless create case" do
allow(webhook)
.to receive(:enabled_for_project?).with(project.id)
.and_return(false)
subject
- if event == 'project:created'
+ if event == "project:created"
expect(stub).to have_been_requested
else
expect(stub).not_to have_been_requested
end
end
- describe 'successful flow' do
+ describe "successful flow" do
before do
subject
end
diff --git a/modules/webhooks/spec/workers/time_entry_webhook_job_spec.rb b/modules/webhooks/spec/workers/time_entry_webhook_job_spec.rb
index 6f82a98e39af..f6ac9eb0be60 100644
--- a/modules/webhooks/spec/workers/time_entry_webhook_job_spec.rb
+++ b/modules/webhooks/spec/workers/time_entry_webhook_job_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe TimeEntryWebhookJob, :webmock, type: :job do
shared_let(:user) { create(:admin) }
@@ -57,7 +57,7 @@
"action" => event,
"time_entry" => hash_including(
"_type" => "TimeEntry",
- "hours" => 'PT10H'
+ "hours" => "PT10H"
)
),
headers: request_headers
@@ -82,7 +82,7 @@
stub
end
- it 'requests with all projects' do
+ it "requests with all projects" do
expect(webhook)
.to receive(:enabled_for_project?).with(time_entry.project_id)
.and_call_original
@@ -91,7 +91,7 @@
expect(stub).to have_been_requested
end
- it 'does not request when project does not match' do
+ it "does not request when project does not match" do
expect(webhook)
.to receive(:enabled_for_project?).with(time_entry.project_id)
.and_return(false)
@@ -100,7 +100,7 @@
expect(stub).not_to have_been_requested
end
- describe 'successful flow' do
+ describe "successful flow" do
before do
subject
end
diff --git a/modules/webhooks/spec/workers/work_package_webhook_job_spec.rb b/modules/webhooks/spec/workers/work_package_webhook_job_spec.rb
index 260bd650950c..39856faa9953 100644
--- a/modules/webhooks/spec/workers/work_package_webhook_job_spec.rb
+++ b/modules/webhooks/spec/workers/work_package_webhook_job_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WorkPackageWebhookJob, :webmock, type: :model do
shared_let(:user) { create(:admin) }
@@ -78,7 +78,7 @@
stub
end
- it 'requests with all projects' do
+ it "requests with all projects" do
expect(webhook)
.to receive(:enabled_for_project?).with(work_package.project_id)
.and_call_original
@@ -87,7 +87,7 @@
expect(stub).to have_been_requested
end
- it 'does not request when project does not match' do
+ it "does not request when project does not match" do
expect(webhook)
.to receive(:enabled_for_project?).with(work_package.project_id)
.and_return(false)
@@ -96,7 +96,7 @@
expect(stub).not_to have_been_requested
end
- describe 'successful flow' do
+ describe "successful flow" do
before do
subject
end
diff --git a/modules/xls_export/app/models/xls_export/concerns/spreadsheet_builder.rb b/modules/xls_export/app/models/xls_export/concerns/spreadsheet_builder.rb
index 10db849c3e4a..60780f76ddb1 100644
--- a/modules/xls_export/app/models/xls_export/concerns/spreadsheet_builder.rb
+++ b/modules/xls_export/app/models/xls_export/concerns/spreadsheet_builder.rb
@@ -18,7 +18,7 @@ def success(content)
.new format: :xls,
content:,
title: xls_export_filename,
- mime_type: 'application/vnd.ms-excel'
+ mime_type: "application/vnd.ms-excel"
end
def spreadsheet
diff --git a/modules/xls_export/app/models/xls_export/work_package/exporter/xls.rb b/modules/xls_export/app/models/xls_export/work_package/exporter/xls.rb
index abd2e9fb110b..d9b4f9cf4463 100644
--- a/modules/xls_export/app/models/xls_export/work_package/exporter/xls.rb
+++ b/modules/xls_export/app/models/xls_export/work_package/exporter/xls.rb
@@ -140,9 +140,9 @@ def relation_type(work_package, other, relation)
normalized = relation.relation_type_for(work_package)
I18n.t("js.relation_labels.#{normalized}", default: normalized)
elsif work_package.parent_id == other.id
- I18n.t 'xls_export.child_of'
+ I18n.t "xls_export.child_of"
elsif work_package.children.where(id: other.id).exists?
- I18n.t 'xls_export.parent_of'
+ I18n.t "xls_export.parent_of"
end
end
diff --git a/modules/xls_export/lib/open_project/xls_export/engine.rb b/modules/xls_export/lib/open_project/xls_export/engine.rb
index 884d18c94076..51c0405fc5b5 100644
--- a/modules/xls_export/lib/open_project/xls_export/engine.rb
+++ b/modules/xls_export/lib/open_project/xls_export/engine.rb
@@ -4,23 +4,23 @@ class Engine < ::Rails::Engine
include OpenProject::Plugins::ActsAsOpEngine
- register 'openproject-xls_export',
- author_url: 'https://www.openproject.org',
+ register "openproject-xls_export",
+ author_url: "https://www.openproject.org",
bundled: true
config.to_prepare do
OpenProject::XlsExport::Hooks::WorkPackageHook
end
- initializer 'xls_export.register_mimetypes' do
+ initializer "xls_export.register_mimetypes" do
next if defined? Mime::XLS
- Mime::Type.register('application/vnd.ms-excel',
+ Mime::Type.register("application/vnd.ms-excel",
:xls,
%w(application/vnd.ms-excel))
end
- class_inflection_override('xls' => 'XLS')
+ class_inflection_override("xls" => "XLS")
config.to_prepare do
::Exports::Register.register do
diff --git a/modules/xls_export/lib/open_project/xls_export/spreadsheet_builder.rb b/modules/xls_export/lib/open_project/xls_export/spreadsheet_builder.rb
index 1247efb187a4..ddf0e0c5b337 100644
--- a/modules/xls_export/lib/open_project/xls_export/spreadsheet_builder.rb
+++ b/modules/xls_export/lib/open_project/xls_export/spreadsheet_builder.rb
@@ -1,4 +1,4 @@
-require 'spreadsheet'
+require "spreadsheet"
# A simple convenience class that wraps some of the spreadsheet
# gem's functionality. It's designed to build spreadsheets incrementally
@@ -17,7 +17,7 @@ class SpreadsheetBuilder
Worksheet = Struct.new(:sheet, :column_widths) unless defined? Worksheet
def initialize(name = nil)
- Spreadsheet.client_encoding = 'UTF-8'
+ Spreadsheet.client_encoding = "UTF-8"
@xls = Spreadsheet::Workbook.new
@worksheets = []
worksheet(0, name)
@@ -53,7 +53,7 @@ def update_sheet_widths
# Get the approximate width of a value as seen in the excel sheet
def get_value_width(value)
- if ['Time', 'Date'].include?(value.class.name) && !(value.to_s.length < 18)
+ if ["Time", "Date"].include?(value.class.name) && !(value.to_s.length < 18)
return 18
end
@@ -61,11 +61,11 @@ def get_value_width(value)
idx = 0
value.to_s.each_char do |c|
case c
- when '0'..'9'
+ when "0".."9"
tot_w[idx] += 1.2
- when '.', ';', ':', ',', ' ', 'i', 'I', 'j', 'J', '(', ')', '[', ']', '!', '-', 't', 'l'
+ when ".", ";", ":", ",", " ", "i", "I", "j", "J", "(", ")", "[", "]", "!", "-", "t", "l"
tot_w[idx] += 0.7
- when 'W', 'M', 'D'
+ when "W", "M", "D"
tot_w[idx] += 1.2
when "\n"
idx = idx + 1
@@ -215,11 +215,11 @@ def raw_sheet
end
def currency_sign
- Setting.plugin_costs['costs_currency']
+ Setting.plugin_costs["costs_currency"]
end
def escaped_worksheet_name(name)
- name.gsub!(/[\/\\*\[\]:?]/, '#')
+ name.gsub!(/[\/\\*\[\]:?]/, "#")
name = name[0, [name.length, 27].min] + "..." if name.length > 31
name
diff --git a/modules/xls_export/lib/open_project/xls_export/xls_views.rb b/modules/xls_export/lib/open_project/xls_export/xls_views.rb
index d4aac6ff4208..e2f597647d5f 100644
--- a/modules/xls_export/lib/open_project/xls_export/xls_views.rb
+++ b/modules/xls_export/lib/open_project/xls_export/xls_views.rb
@@ -12,7 +12,7 @@ def field_representation_map(key, value)
case key.to_sym
when :units then value.to_i
when :spent_on then value
- when :activity_id then mapped value, Enumeration, I18n.t('placeholders.default')
+ when :activity_id then mapped value, Enumeration, I18n.t("placeholders.default")
when :project_id then project_representation(value)
when :user_id, :assigned_to_id then user_representation(value)
when :work_package_id then work_package_representation(value)
@@ -32,7 +32,7 @@ def show_result(row, unit_id = @unit_id, as_text = false)
def cost_type_unit_label(cost_type_id, cost_type_inst = nil, plural = true)
case cost_type_id
when -1 then l_hours(2).split[1..-1].join(" ") # get the plural for hours
- when 0 then Setting.plugin_costs['costs_currency']
+ when 0 then Setting.plugin_costs["costs_currency"]
else cost_type_label(cost_type_id, cost_type_inst, plural)
end
end
diff --git a/modules/xls_export/lib/openproject-xls_export.rb b/modules/xls_export/lib/openproject-xls_export.rb
index 912133ee042c..8f27e50d500c 100644
--- a/modules/xls_export/lib/openproject-xls_export.rb
+++ b/modules/xls_export/lib/openproject-xls_export.rb
@@ -1 +1 @@
-require 'open_project/xls_export'
+require "open_project/xls_export"
diff --git a/modules/xls_export/openproject-xls_export.gemspec b/modules/xls_export/openproject-xls_export.gemspec
index bdd739ea5e0a..524990abc299 100644
--- a/modules/xls_export/openproject-xls_export.gemspec
+++ b/modules/xls_export/openproject-xls_export.gemspec
@@ -1,14 +1,14 @@
Gem::Specification.new do |s|
s.name = "openproject-xls_export"
- s.version = '1.0.0'
+ s.version = "1.0.0"
s.authors = "OpenProject GmbH"
s.email = "info@openproject.com"
- s.summary = 'OpenProject XLS Export'
- s.description = 'Export issue lists as Excel spreadsheets (.xls)'
+ s.summary = "OpenProject XLS Export"
+ s.description = "Export issue lists as Excel spreadsheets (.xls)"
s.license = "GPLv3"
s.files = Dir["{app,config,db,lib}/**/*"] + %w(CHANGELOG.md README.md)
s.add_dependency "spreadsheet", "~>1.3.0"
- s.metadata['rubygems_mfa_required'] = 'true'
+ s.metadata["rubygems_mfa_required"] = "true"
end
diff --git a/modules/xls_export/spec/lib/custom_field_xls_export_spec.rb b/modules/xls_export/spec/lib/custom_field_xls_export_spec.rb
index 495f3da7b087..6254c91b8070 100644
--- a/modules/xls_export/spec/lib/custom_field_xls_export_spec.rb
+++ b/modules/xls_export/spec/lib/custom_field_xls_export_spec.rb
@@ -1,5 +1,5 @@
-require 'spec_helper'
-require 'spreadsheet'
+require "spec_helper"
+require "spreadsheet"
RSpec.describe "WorkPackageXlsExport Custom Fields" do
let(:type) { create(:type) }
@@ -19,7 +19,7 @@
let(:work_package1) do
wp = create(:work_package, project:, type:)
wp.custom_field_values = {
- custom_field.id => custom_values_for('ham', 'onions')
+ custom_field.id => custom_values_for("ham", "onions")
}
wp.save
wp
@@ -28,7 +28,7 @@
let(:work_package2) do
wp = create(:work_package, project:, type:)
wp.custom_field_values = {
- custom_field.id => custom_values_for('pineapple')
+ custom_field.id => custom_values_for("pineapple")
}
wp.save
wp
@@ -40,7 +40,7 @@
let!(:query) do
query = build(:query, user: current_user, project:)
- query.column_names = ['subject', custom_field.column_name]
+ query.column_names = ["subject", custom_field.column_name]
query.sort_criteria = [%w[id asc]]
query.save!
@@ -66,9 +66,9 @@ def custom_values_for(*values)
end
end
- it 'produces the valid XLS result' do
+ it "produces the valid XLS result" do
expect(query.columns.map(&:name)).to eq [:subject, custom_field.column_name.to_sym]
- expect(sheet.rows.first.take(2)).to eq ['Subject', 'Ingredients']
+ expect(sheet.rows.first.take(2)).to eq ["Subject", "Ingredients"]
# Subjects
expect(sheet.row(1)[0]).to eq(work_package1.subject)
@@ -76,8 +76,8 @@ def custom_values_for(*values)
expect(sheet.row(3)[0]).to eq(work_package3.subject)
# CF values
- expect(sheet.row(1)[1]).to eq('ham, onions')
- expect(sheet.row(2)[1]).to eq('pineapple')
+ expect(sheet.row(1)[1]).to eq("ham, onions")
+ expect(sheet.row(2)[1]).to eq("pineapple")
expect(sheet.row(3)[1]).to be_nil
end
end
diff --git a/modules/xls_export/spec/lib/spreadsheet_builder_spec.rb b/modules/xls_export/spec/lib/spreadsheet_builder_spec.rb
index fce9c2122b78..4cad7059fa8c 100644
--- a/modules/xls_export/spec/lib/spreadsheet_builder_spec.rb
+++ b/modules/xls_export/spec/lib/spreadsheet_builder_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
RSpec.describe "SpreadsheetBuilder" do
before do
diff --git a/modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb b/modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb
index 912122cb4b83..97cdaa0659f9 100644
--- a/modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb
+++ b/modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb
@@ -1,5 +1,5 @@
-require 'spec_helper'
-require 'spreadsheet'
+require "spec_helper"
+require "spreadsheet"
RSpec.describe XlsExport::WorkPackage::Exporter::XLS do
let(:project) { create(:project) }
@@ -12,7 +12,7 @@
query.filters.clear
query.column_names = column_names
- query.sort_criteria = [['id', 'asc']]
+ query.sort_criteria = [["id", "asc"]]
query
end
@@ -36,26 +36,26 @@
)
end
- context 'with relations' do
+ context "with relations" do
let(:options) { { show_relations: true } }
- let(:parent) { create(:work_package, project:, subject: 'Parent') }
+ let(:parent) { create(:work_package, project:, subject: "Parent") }
let(:child_1) do
- create(:work_package, parent:, project:, subject: 'Child 1')
+ create(:work_package, parent:, project:, subject: "Child 1")
end
let(:child_2) do
- create(:work_package, parent:, project:, subject: 'Child 2')
+ create(:work_package, parent:, project:, subject: "Child 2")
end
- let(:single) { create(:work_package, project:, subject: 'Single') }
- let(:followed) { create(:work_package, project:, subject: 'Followed') }
+ let(:single) { create(:work_package, project:, subject: "Single") }
+ let(:followed) { create(:work_package, project:, subject: "Followed") }
let(:child_2_child) do
create(:work_package, parent: child_2, project:, subject: "Child 2's child")
end
let(:relation) do
- create(:follows_relation, from: child_2, to: followed, description: 'description foobar')
+ create(:follows_relation, from: child_2, to: followed, description: "description foobar")
end
let(:relations) { [relation] }
@@ -77,18 +77,18 @@
RELATION_DESCRIPTION = 10
RELATED_SUBJECT = 13
- it 'produces the correct result' do
+ it "produces the correct result" do
expect(query.columns.map(&:name)).to eq %i[type id subject status assigned_to priority]
# the first header row divides the sheet into work packages and relation columns
- expect(sheet.rows.first.take(8)).to eq ['Work packages', nil, nil, nil, nil, nil, nil, 'Relations']
+ expect(sheet.rows.first.take(8)).to eq ["Work packages", nil, nil, nil, nil, nil, nil, "Relations"]
# the second header row includes the column names for work packages and relations and the related work package
expect(sheet.rows[1])
.to eq [
- nil, 'Type', 'ID', 'Subject', 'Status', 'Assignee', 'Priority',
- nil, 'Relation type', 'Delay', 'Description',
- 'Type', 'ID', 'Subject', 'Status', 'Assignee', 'Priority',
+ nil, "Type", "ID", "Subject", "Status", "Assignee", "Priority",
+ nil, "Relation type", "Delay", "Description",
+ "Type", "ID", "Subject", "Status", "Assignee", "Priority",
nil
]
@@ -98,41 +98,41 @@
.to eq [parent.id, parent.id, child_1.id, c2id, c2id, c2id, single.id, followed.id, child_2_child.id].map(&:to_s)
# marks Parent as parent of Child 1 and 2
- expect(sheet.row(PARENT)[RELATION]).to eq 'parent of'
- expect(sheet.row(PARENT)[RELATED_SUBJECT]).to eq 'Child 1'
+ expect(sheet.row(PARENT)[RELATION]).to eq "parent of"
+ expect(sheet.row(PARENT)[RELATED_SUBJECT]).to eq "Child 1"
- expect(sheet.row(PARENT + 1)[RELATION]).to eq 'parent of'
- expect(sheet.row(PARENT + 1)[RELATED_SUBJECT]).to eq 'Child 2'
+ expect(sheet.row(PARENT + 1)[RELATION]).to eq "parent of"
+ expect(sheet.row(PARENT + 1)[RELATED_SUBJECT]).to eq "Child 2"
# shows Child 1 as child of Parent
- expect(sheet.row(CHILD_1)[RELATION]).to eq 'child of'
- expect(sheet.row(CHILD_1)[RELATED_SUBJECT]).to eq 'Parent'
+ expect(sheet.row(CHILD_1)[RELATION]).to eq "child of"
+ expect(sheet.row(CHILD_1)[RELATED_SUBJECT]).to eq "Parent"
# shows Child 2 as child of Parent
- expect(sheet.row(CHILD_2)[RELATION]).to eq 'child of'
- expect(sheet.row(CHILD_2)[RELATED_SUBJECT]).to eq 'Parent'
+ expect(sheet.row(CHILD_2)[RELATION]).to eq "child of"
+ expect(sheet.row(CHILD_2)[RELATED_SUBJECT]).to eq "Parent"
# shows Child 2 as parent of Child 2's child
- expect(sheet.row(CHILD_2 + 1)[RELATION]).to eq 'parent of'
+ expect(sheet.row(CHILD_2 + 1)[RELATION]).to eq "parent of"
expect(sheet.row(CHILD_2 + 1)[RELATED_SUBJECT]).to eq "Child 2's child"
# shows Child 2 as following Followed
- expect(sheet.row(CHILD_2 + 2)[RELATION]).to eq 'Follows'
- expect(sheet.row(CHILD_2 + 2)[RELATED_SUBJECT]).to eq 'Followed'
+ expect(sheet.row(CHILD_2 + 2)[RELATION]).to eq "Follows"
+ expect(sheet.row(CHILD_2 + 2)[RELATED_SUBJECT]).to eq "Followed"
# shows no relation information for Single
expect(sheet.row(SINGLE).drop(7).compact).to eq []
# shows Followed as preceding Child 2'
- expect(sheet.row(FOLLOWED)[RELATION]).to eq 'Precedes'
- expect(sheet.row(FOLLOWED)[RELATION_DESCRIPTION]).to eq 'description foobar'
- expect(sheet.row(FOLLOWED)[RELATED_SUBJECT]).to eq 'Child 2'
+ expect(sheet.row(FOLLOWED)[RELATION]).to eq "Precedes"
+ expect(sheet.row(FOLLOWED)[RELATION_DESCRIPTION]).to eq "description foobar"
+ expect(sheet.row(FOLLOWED)[RELATED_SUBJECT]).to eq "Child 2"
# exports the correct data (examples)
expect(sheet.row(PARENT))
.to eq [
nil, parent.type.name, parent.id.to_s, parent.subject, parent.status.name, parent.assigned_to, parent.priority.name,
- nil, 'parent of', nil, nil,
+ nil, "parent of", nil, nil,
child_1.type.name, child_1.id.to_s, child_1.subject, child_1.status.name, child_1.assigned_to, child_1.priority.name
] # delay nil as this is a parent-child relation not represented by an actual Relation record
@@ -145,28 +145,28 @@
.to eq [
nil,
followed.type.name, followed.id.to_s, followed.subject, followed.status.name, followed.assigned_to, followed.priority.name,
- nil, 'Precedes', 0, relation.description,
+ nil, "Precedes", 0, relation.description,
child_2.type.name, child_2.id.to_s, child_2.subject, child_2.status.name, child_2.assigned_to, child_2.priority.name
]
end
- context 'with someone who may not see related work packages' do
+ context "with someone who may not see related work packages" do
let(:current_user) { create(:user) }
- it 'exports no information without visibility' do
+ it "exports no information without visibility" do
expect(sheet.rows.length).to eq(2)
expect(sheet.column(1).drop(2)).to be_empty
end
end
end
- describe 'with cost and time entries' do
+ describe "with cost and time entries" do
# Since this test has to work without the actual costs plugin we'll just add
# a custom field called 'costs' to emulate it.
let(:custom_field) do
create(:float_wp_custom_field,
- name: 'unit costs')
+ name: "unit costs")
end
let(:custom_value) do
create(:custom_value,
@@ -195,15 +195,15 @@
wps[3].save!
wps
end
- let(:column_names) { ['subject', 'status', 'estimated_hours', custom_field.column_name] }
+ let(:column_names) { ["subject", "status", "estimated_hours", custom_field.column_name] }
before do
allow(Setting)
.to receive(:plugin_costs)
- .and_return('costs_currency' => 'EUR', 'costs_currency_format' => '%n %u')
+ .and_return("costs_currency" => "EUR", "costs_currency_format" => "%n %u")
end
- it 'successfullies export the work packages with a cost column' do
+ it "successfullies export the work packages with a cost column" do
expect(sheet.rows.size).to eq(4 + 1)
cost_column = sheet.columns.last.to_a
@@ -212,10 +212,10 @@
end
end
- context 'with german locale' do
+ context "with german locale" do
let(:current_user) { create(:admin, language: :de) }
- it 'successfullies export the work packages with a cost column localized' do
+ it "successfullies export the work packages with a cost column localized" do
I18n.with_locale :de do
sheet
end
@@ -228,7 +228,7 @@
end
end
- it 'includes estimated hours' do
+ it "includes estimated hours" do
expect(sheet.rows.size).to eq(4 + 1)
# Check row after header row
@@ -237,7 +237,7 @@
end
end
- context 'with descriptions' do
+ context "with descriptions" do
let(:options) { { show_descriptions: true } }
let(:work_package) do
@@ -249,7 +249,7 @@
let(:work_packages) { [work_package] }
let(:column_names) { %w[id] }
- it 'includes the HTML sanitized description' do
+ it "includes the HTML sanitized description" do
expect(sheet.rows.size).to eq(1 + 1)
expect(sheet.rows[1][1])
@@ -257,17 +257,17 @@
end
end
- context 'with underscore in subject' do
+ context "with underscore in subject" do
let(:work_package) do
create(:work_package,
- subject: 'underscore_is included',
+ subject: "underscore_is included",
project:,
type: project.types.first)
end
let(:work_packages) { [work_package] }
let(:column_names) { %w[id subject] }
- it 'includes the underscore' do
+ it "includes the underscore" do
expect(sheet.rows.size).to eq(1 + 1)
expect(sheet.rows[1][1])
@@ -275,15 +275,15 @@
end
end
- describe 'empty result' do
+ describe "empty result" do
let(:work_packages) { [] }
- it 'yields an empty XLS file' do
+ it "yields an empty XLS file" do
expect(sheet.rows.size).to eq(1) # just the headers
end
end
- describe 'with user time zone' do
+ describe "with user time zone" do
let(:zone) { +2 }
let(:work_package) do
create(:work_package,
@@ -304,14 +304,14 @@
allow(current_user).to receive(:time_zone).and_return(zone)
end
- it 'adapts the datetime fields to the user time zone' do
+ it "adapts the datetime fields to the user time zone" do
work_package.reload
updated_at_cell = sheet.rows.last.to_a.last
expect(updated_at_cell).to eq(i18n_helper.format_time(work_package.updated_at).to_s)
end
end
- describe 'with derived estimated hours' do
+ describe "with derived estimated hours" do
let(:work_package) do
create(:work_package,
project:,
@@ -322,14 +322,14 @@
let(:column_names) { %w[subject status updated_at estimated_hours] }
- it 'adapts the datetime fields to the user time zone' do
+ it "adapts the datetime fields to the user time zone" do
work_package.reload
estimated_cell = sheet.rows.last.to_a.last
- expect(estimated_cell).to eq '(15.0 h)'
+ expect(estimated_cell).to eq "(15.0 h)"
end
end
- describe 'with derived estimated hours and estimated_hours set to zero' do
+ describe "with derived estimated hours and estimated_hours set to zero" do
let(:work_package) do
create(:work_package,
project:,
@@ -341,10 +341,10 @@
let(:column_names) { %w[subject status updated_at estimated_hours] }
- it 'outputs both values' do
+ it "outputs both values" do
work_package.reload
estimated_cell = sheet.rows.last.to_a.last
- expect(estimated_cell).to eq '0.0 h (15.0 h)'
+ expect(estimated_cell).to eq "0.0 h (15.0 h)"
end
end
end
diff --git a/modules/xls_export/spec/patches/work_packages_controller_patch_spec.rb b/modules/xls_export/spec/patches/work_packages_controller_patch_spec.rb
index 431a6667d3b2..0b0c2b90270b 100644
--- a/modules/xls_export/spec/patches/work_packages_controller_patch_spec.rb
+++ b/modules/xls_export/spec/patches/work_packages_controller_patch_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WorkPackagesController, type: :controller do
before do
login_as current_user
end
- let(:project) { create(:project, identifier: 'test_project', public: false) }
- let(:stub_project) { build_stubbed(:project, identifier: 'test_project', public: false) }
+ let(:project) { create(:project, identifier: "test_project", public: false) }
+ let(:stub_project) { build_stubbed(:project, identifier: "test_project", public: false) }
let(:type) { build_stubbed(:type) }
let(:stub_work_package) do
build_stubbed(:work_package,
@@ -72,7 +72,7 @@ def self.requires_export_permission(&)
instance_eval(&)
end
- describe 'w/o the export permission' do
+ describe "w/o the export permission" do
let(:project) { nil }
before do
@@ -81,16 +81,16 @@ def self.requires_export_permission(&)
call_action
end
- it 'renders a 403' do
+ it "renders a 403" do
expect(response.response_code).to eq(403)
end
end
end
- describe 'index' do
+ describe "index" do
let(:query) { build_stubbed(:query).tap(&:add_default_filter) }
- let(:work_packages) { double('work packages').as_null_object }
- let(:results) { double('results').as_null_object }
+ let(:work_packages) { double("work packages").as_null_object }
+ let(:results) { double("results").as_null_object }
before do
mock_permissions_for(User.current) do |mock|
@@ -98,20 +98,20 @@ def self.requires_export_permission(&)
end
end
- describe 'with valid query' do
+ describe "with valid query" do
before do
allow(controller).to receive(:retrieve_query).and_return(query)
end
- describe 'xls' do
+ describe "xls" do
let(:params) { {} }
- let(:call_action) { get('index', params: params.merge(format: mime_type)) }
- let(:mime_type) { 'xls' }
- let(:export_result) { 'uuid of the job' }
+ let(:call_action) { get("index", params: params.merge(format: mime_type)) }
+ let(:mime_type) { "xls" }
+ let(:export_result) { "uuid of the job" }
requires_export_permission do
before do
- service_instance = double('service_instance')
+ service_instance = double("service_instance")
allow(WorkPackages::Exports::ScheduleService)
.to receive(:new)
@@ -124,17 +124,17 @@ def self.requires_export_permission(&)
.and_return(ServiceResult.failure(result: export_result))
end
- it 'fulfills the defined should_receives' do
+ it "fulfills the defined should_receives" do
call_action
- expect(response).to redirect_to job_status_path('uuid of the job')
+ expect(response).to redirect_to job_status_path("uuid of the job")
end
- context 'with json accept' do
- it 'fulfills the defined should_receives' do
- request.headers['Accept'] = 'application/json'
+ context "with json accept" do
+ it "fulfills the defined should_receives" do
+ request.headers["Accept"] = "application/json"
call_action
- expect(response.body).to eq({ job_id: 'uuid of the job' }.to_json)
+ expect(response.body).to eq({ job_id: "uuid of the job" }.to_json)
end
end
end
diff --git a/script/api/spec b/script/api/spec
index a56167823ee1..934d6f3dd5dc 100755
--- a/script/api/spec
+++ b/script/api/spec
@@ -7,11 +7,11 @@ if /((-h)|(--help))/.match?(ARGV.join(" "))
return
end
-require 'pathname'
-require 'yaml'
-require 'json'
+require "pathname"
+require "yaml"
+require "json"
-require_relative '../../lib/api/open_api'
+require_relative "../../lib/api/open_api"
path = Pathname(__dir__).join("../../docs/api/apiv3/openapi-spec.yml")
spec = API::OpenAPI.assemble_spec path
diff --git a/script/api/validate_spec b/script/api/validate_spec
index bf6f89d4af12..470604d092a9 100755
--- a/script/api/validate_spec
+++ b/script/api/validate_spec
@@ -1,10 +1,10 @@
#!/usr/bin/env ruby
-require 'pathname'
-require 'tempfile'
+require "pathname"
+require "tempfile"
-openapi_yaml_spec_path = Pathname(__dir__).join('../../tmp/oas-generated.yml')
-full_spec = `#{Pathname(__dir__).join('spec')} --format yaml`
+openapi_yaml_spec_path = Pathname(__dir__).join("../../tmp/oas-generated.yml")
+full_spec = `#{Pathname(__dir__).join("spec")} --format yaml`
status = $?.exitstatus
if status != 0
warn "failed to bundle the openapi spec yaml file"
diff --git a/script/bulk_run_rspec b/script/bulk_run_rspec
index 05e8ddedfaef..fa4ce930a922 100755
--- a/script/bulk_run_rspec
+++ b/script/bulk_run_rspec
@@ -5,18 +5,18 @@
# Run with --help for more information
# rubocop:disable Rails
-require 'fileutils'
-require 'optparse'
-require 'ostruct'
-require 'pathname'
+require "fileutils"
+require "optparse"
+require "ostruct"
+require "pathname"
-RAILS_ROOT = Pathname.new File.expand_path('../', __dir__)
-RSPEC_EXAMPLE_STATUS_PERSISTENCE_FILE_PATH = RAILS_ROOT.join('tmp/spec_examples.txt')
-PATTERN = ENV['BULK_RUN_PATTERN'] ? Regexp.new(ENV['BULK_RUN_PATTERN']) : /features/
+RAILS_ROOT = Pathname.new File.expand_path("../", __dir__)
+RSPEC_EXAMPLE_STATUS_PERSISTENCE_FILE_PATH = RAILS_ROOT.join("tmp/spec_examples.txt")
+PATTERN = ENV["BULK_RUN_PATTERN"] ? Regexp.new(ENV["BULK_RUN_PATTERN"]) : /features/
class Options
DEFAULTS = {
- run_count: ENV['BULK_RUN_COUNT'] ? ENV['BULK_RUN_COUNT'].to_i : 5
+ run_count: ENV["BULK_RUN_COUNT"] ? ENV["BULK_RUN_COUNT"].to_i : 5
}.freeze
BANNER = <<~BANNER.freeze
@@ -89,7 +89,7 @@ class Options
end
def normalized(path)
- path.sub(/^\.\//, '').tr('/', '__').tr('[]:', '_')
+ path.sub(/^\.\//, "").tr("/", "__").tr("[]:", "_")
end
class String
@@ -112,7 +112,7 @@ class Test
end
def to_line
- [path, normalized_name, runs.count, runs.count(&:passed?), runs.count(&:failed?)].join(' | ')
+ [path, normalized_name, runs.count, runs.count(&:passed?), runs.count(&:failed?)].join(" | ")
end
def normalized_name
@@ -162,7 +162,7 @@ class BulkRunner
else
lines = File.readlines(RSPEC_EXAMPLE_STATUS_PERSISTENCE_FILE_PATH)
lines = lines.grep(PATTERN)
- lines.map { |line| line.split('|').first.strip }
+ lines.map { |line| line.split("|").first.strip }
end
end
@@ -172,23 +172,23 @@ class BulkRunner
# rubocop:disable Metrics/AbcSize
def run
- FileUtils.rm_rf(bulk_run_dir('logs')) if bulk_run_dir('logs').exist?
- `mkdir -p #{bulk_run_dir('logs')}`
+ FileUtils.rm_rf(bulk_run_dir("logs")) if bulk_run_dir("logs").exist?
+ `mkdir -p #{bulk_run_dir("logs")}`
puts "#{tests.count} tests to run"
puts "logs: #{bulk_run_dir('logs')}"
tests.each do |test|
- puts '=' * 80
+ puts "=" * 80
puts "Running #{test.path} #{Options.run_count} times"
- puts '=' * 80
+ puts "=" * 80
Options.run_count.times do |i|
- puts " Run #{i} ".center(80, '-')
+ puts " Run #{i} ".center(80, "-")
run = Run.new(test.path)
run.output = `DISABLE_PRY=1 CI=true bundle exec rspec '#{run.path}' 2>&1`
if $?.success?
- puts 'ok'.green
+ puts "ok".green
run.passed!
else
- puts 'ko'.red
+ puts "ko".red
run.failed!
end
File.write(bulk_run_dir("logs/#{test.normalized_name}.#{run.result}.#{i}.log"), run.output)
@@ -196,22 +196,22 @@ class BulkRunner
end
if test.runs.all?(&:passed?)
- puts 'PASSED'.green
+ puts "PASSED".green
else
- puts 'FAILED'.red
+ puts "FAILED".red
end
end
end
# rubocop:enable Metrics/AbcSize
def bulk_run_dir(path)
- RAILS_ROOT.join('tmp/bulk_run').join(path)
+ RAILS_ROOT.join("tmp/bulk_run").join(path)
end
def save
puts "Saving"
- File.open(bulk_run_dir('results.txt'), 'w') do |results|
- results.puts('test_path | log_prefix | count | passed | failed')
+ File.open(bulk_run_dir("results.txt"), "w") do |results|
+ results.puts("test_path | log_prefix | count | passed | failed")
tests.each do |test|
results.puts(test.to_line)
end
diff --git a/script/docs/check_links b/script/docs/check_links
index 42ccd28b8886..7bc27e1cb208 100755
--- a/script/docs/check_links
+++ b/script/docs/check_links
@@ -1,10 +1,10 @@
#!/usr/bin/env ruby
-require 'pathname'
-require 'yaml'
-require 'markly'
-require 'uri'
-require 'active_support/inflector'
+require "pathname"
+require "yaml"
+require "markly"
+require "uri"
+require "active_support/inflector"
def parse_markdown(content)
id_gen = IdGenerator.new
@@ -15,7 +15,7 @@ def parse_markdown(content)
if node.type == :link || node.type == :image
links.push({ url: node.url, pos: node.source_position, type: node.type })
elsif node.type == :header
- text = node.to_plaintext.delete("\n").tr(' ', ' ')
+ text = node.to_plaintext.delete("\n").tr(" ", " ")
id = id_gen.generate_id(text)
anchors.push(id)
end
@@ -26,8 +26,8 @@ end
class IdGenerator
def generate_markdown_header_id(text)
id = text.downcase
- id.gsub!(/[^\p{Word}\- ]/u, '') # remove punctuation
- id.tr!(' ', '-') # replace spaces with dash
+ id.gsub!(/[^\p{Word}\- ]/u, "") # remove punctuation
+ id.tr!(" ", "-") # replace spaces with dash
id = "section" if id.empty?
id
end
@@ -57,8 +57,8 @@ class APIChecker
filename = Pathname(@root_path).join("api/apiv3/openapi-spec.yml")
spec = YAML.load_file(filename)
@operations = collect_operations_from_spec(spec)
- spec['tags']
- .map { |ref| api_page_by_tag(ref['$ref']) }
+ spec["tags"]
+ .map { |ref| api_page_by_tag(ref["$ref"]) }
.push(
introduction_page(spec, filename),
markdown_page("api/README.md", "api"),
@@ -70,7 +70,7 @@ class APIChecker
private
def introduction_page(spec, filename)
- anchors, links = parse_markdown(spec['info']['description'])
+ anchors, links = parse_markdown(spec["info"]["description"])
{ path: "#{@root_path}/api/introduction", anchors:, links:, filename: }
end
@@ -81,8 +81,8 @@ class APIChecker
end
def collect_operations_from_spec(spec)
- spec['paths'].map do |p|
- path_obj_path = Pathname(@root_path).join("api/apiv3/", p[1]['$ref'])
+ spec["paths"].map do |p|
+ path_obj_path = Pathname(@root_path).join("api/apiv3/", p[1]["$ref"])
path_obj = YAML.load_file(path_obj_path)
path_obj.keys.map { |key| path_obj[key] }
end.flatten
@@ -90,16 +90,16 @@ class APIChecker
def operation_ids_by_tag(tag, id_gen)
@operations
- .select { |operation| operation['tags']&.include?(tag['name']) }
- .map { |operation| id_gen.generate_id(operation['summary']) }
+ .select { |operation| operation["tags"]&.include?(tag["name"]) }
+ .map { |operation| id_gen.generate_id(operation["summary"]) }
end
def api_page_by_tag(ref)
tag_source = Pathname(@root_path).join("api/apiv3", ref)
tag = YAML.load_file(tag_source)
- anchors, links, id_gen = parse_markdown(tag['description'])
+ anchors, links, id_gen = parse_markdown(tag["description"])
anchors.concat(operation_ids_by_tag(tag, id_gen))
- tag_path = ActiveSupport::Inflector.parameterize(tag['name'])
+ tag_path = ActiveSupport::Inflector.parameterize(tag["name"])
tag_path = "endpoints/#{tag_path}" unless PULLED_UP_TAG_PAGES.include?(tag_path)
{ path: "#{@root_path}/api/#{tag_path}", anchors:, links:, filename: tag_source }
end
@@ -128,7 +128,7 @@ class DocsChecker
def scan
@docs = Dir.glob("#{@root_path}/**/README.md")
- .reject { |filename| filename.include?('/api/') }
+ .reject { |filename| filename.include?("/api/") }
.map { |filename| build_doc(filename) }
end
@@ -148,7 +148,7 @@ class DocsChecker
def check_link(uri, link, doc)
full_url = File.expand_path(uri.to_s, doc[:path])
- target_doc_path = URI(full_url).path.chomp('/')
+ target_doc_path = URI(full_url).path.chomp("/")
target_doc = @docs.find { |d| d[:path] == target_doc_path }
if target_doc.nil?
return if File.exist?(target_doc_path) # linked files in doc e.g. "./restore.sql"
@@ -156,16 +156,16 @@ class DocsChecker
full_url = File.expand_path(uri.to_s, File.dirname(doc[:filename]))
return if File.exist?(full_url) # linked images in doc e.g. "api/bcf/BCFicon128.png" (but target is api/bcf-rest-api/BCFicon128.png)
- return { error: (link[:type] || 'Page').capitalize, link:, doc: }
+ return { error: (link[:type] || "Page").capitalize, link:, doc: }
end
unless uri.fragment.nil? || target_doc[:anchors].include?(uri.fragment)
- { error: 'Anchor', link:, doc: }
+ { error: "Anchor", link:, doc: }
end
end
def strip_external_link_to_doc(url, path)
uri = URI(url)
- full_path = File.expand_path(uri.path.sub('/docs', '.'), @root_path)
+ full_path = File.expand_path(uri.path.sub("/docs", "."), @root_path)
relative_url = Pathname.new(full_path).relative_path_from("#{path}/").to_s
"#{relative_url}/##{uri.fragment}" unless uri.fragment.nil?
@@ -174,7 +174,7 @@ class DocsChecker
def parse_uri(link, doc)
uri = URI(link[:url])
- if uri.hostname == 'www.openproject.org' && uri.path&.start_with?('/docs')
+ if uri.hostname == "www.openproject.org" && uri.path&.start_with?("/docs")
uri = URI(strip_external_link_to_doc(link[:url], doc[:path]))
end
uri unless %w[mailto https http].include?(uri.scheme)
@@ -199,17 +199,17 @@ class DocsChecker
@errors.each do |error|
pos = error[:link][:pos]
report_item(
- 'error',
+ "error",
error[:doc][:filename],
pos[:start_line], pos[:start_column], pos[:end_line], pos[:end_column],
"#{error[:error]} not found for link address `#{error[:link][:url]}`"
)
end
- puts 'Done. No broken references found.' if @errors.empty?
+ puts "Done. No broken references found." if @errors.empty?
end
def github_escape(str)
- str.gsub(/[%:\n\r]/, { "%" => "%25", "\n" => "%0A", "\r" => "%0D", ':' => '%3A' }).squeeze(' ')
+ str.gsub(/[%:\n\r]/, { "%" => "%25", "\n" => "%0A", "\r" => "%0D", ":" => "%3A" }).squeeze(" ")
end
def report_item(*)
@@ -241,5 +241,5 @@ class DocsChecker
end
exit 1 unless DocsChecker.new(
- File.expand_path('../../docs/', __dir__)
+ File.expand_path("../../docs/", __dir__)
).run
diff --git a/script/github_pr_errors b/script/github_pr_errors
index 3eb86c0f04ad..f71b34f0e5be 100755
--- a/script/github_pr_errors
+++ b/script/github_pr_errors
@@ -1,26 +1,26 @@
#!/usr/bin/env ruby
-require 'rubygems'
-require 'bundler'
+require "rubygems"
+require "bundler"
Bundler.setup(:default, :development)
-require 'colored2'
-require 'json'
-require 'optparse'
-require 'base64'
-require 'pathname'
-require 'pry'
-require 'yaml'
-require 'httpx'
-
-GITHUB_API_OPENPROJECT_PREFIX = 'https://api.github.com/repos/opf/openproject'.freeze
-GITHUB_HTML_OPENPROJECT_PREFIX = 'https://github.com/opf/openproject'.freeze
+require "colored2"
+require "json"
+require "optparse"
+require "base64"
+require "pathname"
+require "pry"
+require "yaml"
+require "httpx"
+
+GITHUB_API_OPENPROJECT_PREFIX = "https://api.github.com/repos/opf/openproject".freeze
+GITHUB_HTML_OPENPROJECT_PREFIX = "https://github.com/opf/openproject".freeze
RAILS_ROOT = Pathname.new(__dir__).dirname
EXCLUDED_JOB_NAMES = %w[eslint rubocop].freeze
-if !ENV['GITHUB_USERNAME']
+if !ENV["GITHUB_USERNAME"]
raise "Missing GITHUB_USERNAME env"
-elsif !ENV['GITHUB_TOKEN']
+elsif !ENV["GITHUB_TOKEN"]
raise "Missing GITHUB_TOKEN env, go to https://github.com/settings/tokens and create one with 'repo' access"
end
@@ -152,7 +152,7 @@ def current_branch_name
end
def github_url(path)
- if path.start_with?('http')
+ if path.start_with?("http")
path
else
"#{GITHUB_API_OPENPROJECT_PREFIX}/#{path}"
@@ -163,7 +163,7 @@ def http
HTTPX
.plugin(:follow_redirects)
.plugin(:basic_auth)
- .basic_auth(ENV.fetch('GITHUB_USERNAME'), ENV.fetch('GITHUB_TOKEN'))
+ .basic_auth(ENV.fetch("GITHUB_USERNAME"), ENV.fetch("GITHUB_TOKEN"))
end
def get_http(path)
@@ -201,18 +201,18 @@ end
def path_to_cache_key(path)
path
- .gsub(/\?.*$/, '') # remove query parameter
- .gsub(/^#{GITHUB_API_OPENPROJECT_PREFIX}\/?/o, '') # remove https://.../
- .gsub(/\W/, '_') # transform non alphanum chars
+ .gsub(/\?.*$/, "") # remove query parameter
+ .gsub(/^#{GITHUB_API_OPENPROJECT_PREFIX}\/?/o, "") # remove https://.../
+ .gsub(/\W/, "_") # transform non alphanum chars
end
def get_jobs(workflow_run)
- workflow_run['jobs_url']
+ workflow_run["jobs_url"]
cache_key = [
- path_to_cache_key(workflow_run['jobs_url']),
- workflow_run['updated_at'].delete(':')
- ].join('_')
- cached(cache_key) { get_json(workflow_run['jobs_url']) }
+ path_to_cache_key(workflow_run["jobs_url"]),
+ workflow_run["updated_at"].delete(":")
+ ].join("_")
+ cached(cache_key) { get_json(workflow_run["jobs_url"]) }
end
def get_log(job)
@@ -242,18 +242,18 @@ end
def last_with_status(workflow_runs, status)
workflow_runs
- .select { |entry| entry['status'] == status }
- .max_by { |entry| entry['run_number'] }
+ .select { |entry| entry["status"] == status }
+ .max_by { |entry| entry["run_number"] }
end
def get_last_workflow_run(branch_name)
test_workflow_runs =
get_json("actions/runs?branch=#{CGI.escape(branch_name)}")
- .then { |response| response['workflow_runs'] }
- .select { |entry| entry['name'] == 'Test suite' }
+ .then { |response| response["workflow_runs"] }
+ .select { |entry| entry["name"] == "Test suite" }
- last_completed = last_with_status(test_workflow_runs, 'completed')
- last_in_progress = last_with_status(test_workflow_runs, 'in_progress')
+ last_completed = last_with_status(test_workflow_runs, "completed")
+ last_in_progress = last_with_status(test_workflow_runs, "in_progress")
last_completed || last_in_progress or raise "No workflow run found for branch #{branch_name}"
end
@@ -511,7 +511,7 @@ class Formatter
return
end
begin
- Open3.popen2e('imgcat', '--width', '50%', '--url', screenshot_url) do |stdin, stdout_and_stderr, _thread|
+ Open3.popen2e("imgcat", "--width", "50%", "--url", screenshot_url) do |stdin, stdout_and_stderr, _thread|
stdin.close
warn stdout_and_stderr.read
end
@@ -528,7 +528,7 @@ class Formatter
warn [
" ",
- '↳'.blue.bold,
+ "↳".blue.bold,
" ",
name.blue,
": ",
@@ -551,9 +551,9 @@ class Formatter
end
def display_pull_request_info(workflow_run)
- return unless workflow_run['event'] == 'pull_request'
+ return unless workflow_run["event"] == "pull_request"
- if pr = workflow_run['pull_requests'].first
+ if pr = workflow_run["pull_requests"].first
pr_number = "##{pr['number']}"
pr_html_url = "#{GITHUB_HTML_OPENPROJECT_PREFIX}/pull/#{pr['number']}"
pr_display_title = "#{workflow_run['display_title']} #{pr_number.white.dark} #{pr_html_url.white.dark}"
@@ -564,17 +564,17 @@ class Formatter
end
def commit_message(workflow_run)
- workflow_run['head_commit']
+ workflow_run["head_commit"]
.then { |commit| commit["message"] }
.then { |message| message.split("\n", 2).first }
end
def status_icon(job)
- case job['status']
+ case job["status"]
when "queued", "in_progress"
"●".yellow
else
- case job['conclusion']
+ case job["conclusion"]
when "success"
"✓".green
when "failure"
@@ -586,9 +586,9 @@ class Formatter
end
def status_url(job)
- return if job['conclusion'] == "success"
+ return if job["conclusion"] == "success"
- job['html_url'].white.dark
+ job["html_url"].white.dark
end
def status_line(job)
@@ -610,11 +610,11 @@ def get_failed_jobs_logs_from_github(formatter)
formatter.display_workflow_status(workflow_run)
get_jobs(workflow_run)
- .then { |jobs_response| jobs_response['jobs'] }
- .sort_by { _1['name'] }
+ .then { |jobs_response| jobs_response["jobs"] }
+ .sort_by { _1["name"] }
.each { |job| formatter.display_job_status(job) }
- .select { _1['conclusion'] == 'failure' }
- .reject { EXCLUDED_JOB_NAMES.include?(_1['name']) }
+ .select { _1["conclusion"] == "failure" }
+ .reject { EXCLUDED_JOB_NAMES.include?(_1["name"]) }
.map { |job| get_log(job) }
end
diff --git a/script/i18n/generate_languages_translations b/script/i18n/generate_languages_translations
index d1e91aab0bb4..33b60ad38dfc 100755
--- a/script/i18n/generate_languages_translations
+++ b/script/i18n/generate_languages_translations
@@ -1,7 +1,7 @@
#!/usr/bin/env ruby
begin
- require 'cldr'
+ require "cldr"
rescue LoadError
warn <<~MSG
Error: the ruby-cldr gem is not installed
@@ -9,15 +9,15 @@ rescue LoadError
MSG
exit 1
end
-require 'pathname'
-require 'yaml'
+require "pathname"
+require "yaml"
class App
class << self
def locales
- @locales ||= rails_root.glob('config/locales/**/*.yml')
- .map { |f| f.basename.to_s.split('.', 2).first }
- .reject! { |l| l.start_with?('js-') || l == 'lol' }
+ @locales ||= rails_root.glob("config/locales/**/*.yml")
+ .map { |f| f.basename.to_s.split(".", 2).first }
+ .reject! { |l| l.start_with?("js-") || l == "lol" }
.uniq
.map(&:to_sym)
end
@@ -26,7 +26,7 @@ class App
@rails_root ||=
Pathname.new(__dir__)
.ascend
- .find { |dir| dir.join('Gemfile').exist? }
+ .find { |dir| dir.join("Gemfile").exist? }
.tap { |dir| raise "Unable to find Rails root directory (looking up from #{__dir__})" if dir.nil? }
end
end
@@ -37,7 +37,7 @@ class CldrTranslations
def initialize
ensure_cldr_database_is_downloaded
- Cldr::Export::Data.dir = cldr_db_location.join('common').to_s
+ Cldr::Export::Data.dir = cldr_db_location.join("common").to_s
end
def language_name(locale)
@@ -72,8 +72,8 @@ class CldrTranslations
# zh-TW <=> zh-Hant (zh-Hant or zh-Hant-TW (Taiwan) is preferred zh-TW)
def cldr_supported(locale)
case locale
- when :'zh-CN' then :'zh-Hans-CN'
- when :'zh-TW' then :'zh-Hant-TW'
+ when :"zh-CN" then :"zh-Hans-CN"
+ when :"zh-TW" then :"zh-Hant-TW"
else locale
end
end
@@ -85,8 +85,8 @@ class CldrTranslations
# From :'pt-PT', returns [:'pt-PT', :pt]
def variations(locale)
locale.to_s
- .split('-')
- .reduce([]) { |variations, part| variations.unshift([variations.first, part].compact.join('-')) }
+ .split("-")
+ .reduce([]) { |variations, part| variations.unshift([variations.first, part].compact.join("-")) }
.then { |variations| insert_self_variation(variations) }
.select { |variation| available_locale?(variation) }
.map(&:to_sym)
@@ -106,13 +106,13 @@ class CldrTranslations
end
def available_locales
- @available_locales ||= Set.new(Cldr::Export::Data.locales.map { _1.tr('_', '-') })
+ @available_locales ||= Set.new(Cldr::Export::Data.locales.map { _1.tr("_", "-") })
end
def ensure_cldr_database_is_downloaded
return if cldr_db_location.exist?
- require 'cldr/download'
+ require "cldr/download"
target = cldr_db_location.to_s
source = "https://unicode.org/Public/cldr/#{CLDR_VERSION}/core.zip"
puts <<~MSG
@@ -153,7 +153,7 @@ class GenerateTranslationFiles
end
def create_translation_file(locale)
- translations_directory.join("#{locale}.yml").open('w') do |f|
+ translations_directory.join("#{locale}.yml").open("w") do |f|
f.puts COMMENT
YAML.dump(yaml_content(locale), f)
end
@@ -162,8 +162,8 @@ class GenerateTranslationFiles
def yaml_content(locale)
{
locale.to_s => {
- 'cldr' => {
- 'language_name' => cldr_translations.language_name(locale)
+ "cldr" => {
+ "language_name" => cldr_translations.language_name(locale)
}
}
}
@@ -174,7 +174,7 @@ class GenerateTranslationFiles
end
def translations_directory
- @translations_directory ||= App.rails_root.join('config/locales/generated').tap do |dir|
+ @translations_directory ||= App.rails_root.join("config/locales/generated").tap do |dir|
dir.mkdir unless dir.exist?
end
end
diff --git a/script/i18n/generate_seeders_i18n_source_file b/script/i18n/generate_seeders_i18n_source_file
index 9939d6fbb2e6..ee008ac502fc 100755
--- a/script/i18n/generate_seeders_i18n_source_file
+++ b/script/i18n/generate_seeders_i18n_source_file
@@ -29,19 +29,19 @@
#++
if !defined? Rails
- puts 'Loading necessary files to run without loading Rails'
+ puts "Loading necessary files to run without loading Rails"
puts "(Alternatively, you can try running bundle exec rails runner #{$0})"
puts
- require 'pathname'
- require 'yaml'
- require 'active_support/core_ext/hash/deep_merge'
- require 'active_support/core_ext/hash/keys'
- require 'active_support/core_ext/object/blank'
+ require "pathname"
+ require "yaml"
+ require "active_support/core_ext/hash/deep_merge"
+ require "active_support/core_ext/hash/keys"
+ require "active_support/core_ext/object/blank"
class Rails
def self.root
- Pathname.new File.expand_path('../../', __dir__)
+ Pathname.new File.expand_path("../../", __dir__)
end
end
@@ -71,7 +71,7 @@ class GenerateSeederSourceTranslationFiles
source_data = translatable_data(seed_files)
return if source_data.blank?
- source_file_path(dir).open('w') do |f|
+ source_file_path(dir).open("w") do |f|
puts "Generate crowdin source file #{relative_path(f.path)}"
f.puts comment
@@ -80,7 +80,7 @@ class GenerateSeederSourceTranslationFiles
end
def create_additional_dummy_crowdin_source_file
- dummy_file = Rails.root.join('modules/boards/config/locales/en.seeders.yml')
+ dummy_file = Rails.root.join("modules/boards/config/locales/en.seeders.yml")
content = <<~CONTENT
#{comment}
#
@@ -101,9 +101,9 @@ class GenerateSeederSourceTranslationFiles
base_path = seed_file_path
loop do
base_path, dir = base_path.split
- break if dir.to_s == 'app'
+ break if dir.to_s == "app"
end
- base_path.join('config/locales/en.seeders.yml')
+ base_path.join("config/locales/en.seeders.yml")
end
def comment
@@ -125,14 +125,14 @@ class GenerateSeederSourceTranslationFiles
return if merged_translatables.blank?
{
- 'en' => {
+ "en" => {
Source::Translate::I18N_PREFIX => merged_translatables
}
}
end
def relative_path(path)
- return path unless path.start_with?('/')
+ return path unless path.start_with?("/")
Pathname.new(path).relative_path_from(Rails.root).to_s
end
diff --git a/script/i18n/print_packager_languages_choices b/script/i18n/print_packager_languages_choices
index 41a77fdd8466..89cc574cdc9e 100755
--- a/script/i18n/print_packager_languages_choices
+++ b/script/i18n/print_packager_languages_choices
@@ -5,8 +5,8 @@
#
# The template is located at packaging/addons/openproject/templates
-require 'pathname'
-require 'yaml'
+require "pathname"
+require "yaml"
class App
class << self
@@ -14,7 +14,7 @@ class App
@rails_root ||=
Pathname.new(__dir__)
.ascend
- .find { |dir| dir.join('Gemfile').exist? }
+ .find { |dir| dir.join("Gemfile").exist? }
.tap { |dir| raise "Unable to find Rails root directory (looking up from #{__dir__})" if dir.nil? }
end
end
@@ -38,12 +38,12 @@ class PrintPackagerLanguagesChoices
end
def translations_files
- App.rails_root.glob('config/locales/generated/*.yml')
+ App.rails_root.glob("config/locales/generated/*.yml")
end
def language_code_and_name_from(translation_file)
YAML.load_file(translation_file.to_s)
- .map { |(lang, data)| [lang, data.dig('cldr', 'language_name')] }
+ .map { |(lang, data)| [lang, data.dig("cldr", "language_name")] }
end
end
end
diff --git a/script/pdf_export/generate_styles_doc b/script/pdf_export/generate_styles_doc
index db61d65032aa..9e154c190ae5 100755
--- a/script/pdf_export/generate_styles_doc
+++ b/script/pdf_export/generate_styles_doc
@@ -2,17 +2,17 @@
# Generates the PDF export styling yaml documentation.
-require 'md_to_pdf/style/schema_doc'
+require "md_to_pdf/style/schema_doc"
require "yaml"
require "json"
root = File.expand_path("../../", __dir__)
-schema_file = File.join(root, 'app', 'models', 'work_package', 'pdf_export', 'schema.json')
+schema_file = File.join(root, "app", "models", "work_package", "pdf_export", "schema.json")
schema = JSON::load_file(schema_file)
generator = MarkdownToPDF::StyleSchemaDocsGenerator.new(schema)
markdown = generator.generate_markdown
-styles_doc_folder = File.join(root, 'docs', 'system-admin-guide', 'design', 'pdf-export-styles')
+styles_doc_folder = File.join(root, "docs", "system-admin-guide", "design", "pdf-export-styles")
FileUtils.mkdir_p(styles_doc_folder)
-styles_doc_file = File.join(styles_doc_folder, 'README.md')
+styles_doc_file = File.join(styles_doc_folder, "README.md")
File.write(styles_doc_file, markdown)
puts "Doc written: #{styles_doc_file}"
diff --git a/script/pdf_export/validate_styles b/script/pdf_export/validate_styles
index 37f931c02c03..2f9d2af3a28a 100755
--- a/script/pdf_export/validate_styles
+++ b/script/pdf_export/validate_styles
@@ -1,17 +1,17 @@
#!/usr/bin/env ruby
-require 'md_to_pdf/style/validation'
-require 'md_to_pdf/core'
-require 'yaml'
-require 'json'
+require "md_to_pdf/style/validation"
+require "md_to_pdf/core"
+require "yaml"
+require "json"
class SchemaValidator
include MarkdownToPDF::StyleValidation
def validate
root = File.expand_path("../../", __dir__)
- schema = JSON::load_file(File.join(root, 'app', 'models', 'work_package', 'pdf_export', 'schema.json'))
- styles_file = File.join(root, 'app', 'models', 'work_package', 'pdf_export', 'standard.yml')
+ schema = JSON::load_file(File.join(root, "app", "models", "work_package", "pdf_export", "schema.json"))
+ styles_file = File.join(root, "app", "models", "work_package", "pdf_export", "standard.yml")
styles = YAML.load_file(styles_file)
validate_schema!(styles, schema)
puts "Valid: #{styles_file}"
diff --git a/spec/components/activities/item_component_spec.rb b/spec/components/activities/item_component_spec.rb
index 140b31cdf6f9..2959b13345d6 100644
--- a/spec/components/activities/item_component_spec.rb
+++ b/spec/components/activities/item_component_spec.rb
@@ -42,87 +42,87 @@
journal:
)
end
- let(:project) { build_stubbed(:project, name: 'My project') }
+ let(:project) { build_stubbed(:project, name: "My project") }
let(:journal) { build_stubbed(:work_package_journal) }
- it 'renders the activity title' do
+ it "renders the activity title" do
render_inline(described_class.new(event:))
- expect(page).to have_css('.op-activity-list--item-title', text: 'Event Title')
+ expect(page).to have_css(".op-activity-list--item-title", text: "Event Title")
end
it 'adds "(Project: ...)" suffix after the activity title' do
render_inline(described_class.new(event:))
- expect(page).to have_css('.op-activity-list--item-title', text: /Event Title\s+\(Project: My project\)/)
+ expect(page).to have_css(".op-activity-list--item-title", text: /Event Title\s+\(Project: My project\)/)
end
- it 'escapes HTML in the activity title and the project suffix' do
- event.event_title = 'Hello World!'
- event.project.name = 'Project name with HTML'
+ it "escapes HTML in the activity title and the project suffix" do
+ event.event_title = "Hello World!"
+ event.project.name = "Project name with HTML"
render_inline(described_class.new(event:))
- expect(page).to have_css('.op-activity-list--item-title', text: 'Hello World!')
- expect(page).to have_css('.op-activity-list--item-title', text: 'Project: Project name with HTML)')
+ expect(page).to have_css(".op-activity-list--item-title", text: "Hello World!")
+ expect(page).to have_css(".op-activity-list--item-title", text: "Project: Project name with HTML)")
end
- it 'does not truncate the title' do
- event.event_title = 'Hello, World!' * 20
+ it "does not truncate the title" do
+ event.event_title = "Hello, World!" * 20
render_inline(described_class.new(event:))
- expect(page).to have_css('.op-activity-list--item-title', text: event.event_title)
+ expect(page).to have_css(".op-activity-list--item-title", text: event.event_title)
end
- it 'removes line breaks and tabs from the title and replaces them with spaces' do
+ it "removes line breaks and tabs from the title and replaces them with spaces" do
event.event_title = "This \t should\n\rbe\n all\ncleaned"
render_inline(described_class.new(event:))
- expect(page).to have_css('.op-activity-list--item-title', text: 'This should be all cleaned')
+ expect(page).to have_css(".op-activity-list--item-title", text: "This should be all cleaned")
end
- context 'for Project activities' do
+ context "for Project activities" do
let(:journal) { build_stubbed(:project_journal) }
- it 'does not add the project suffix' do
+ it "does not add the project suffix" do
component = described_class.new(event:)
render_inline(component)
expect(component.project_suffix).to be_nil
- expect(page).to have_css('.op-activity-list--item-title', text: /\A\s*Event Title\s*\z/)
+ expect(page).to have_css(".op-activity-list--item-title", text: /\A\s*Event Title\s*\z/)
end
end
- context 'when :current_project is set' do
- it 'does not display the project suffix for activities of the current project' do
- event.project.name = 'My project'
+ context "when :current_project is set" do
+ it "does not display the project suffix for activities of the current project" do
+ event.project.name = "My project"
component = described_class.new(event:, current_project: project)
render_inline(component)
expect(component.project_suffix).to be_nil
- expect(page).to have_no_css('.op-activity-list--item-title', text: '(Project: My project)')
+ expect(page).to have_no_css(".op-activity-list--item-title", text: "(Project: My project)")
end
it 'adds "(Subproject: ...)" suffix for activities of subprojects of the current project' do
parent_project = build_stubbed(:project)
event.project.parent = parent_project
- event.project.name = 'My subproject'
+ event.project.name = "My subproject"
render_inline(described_class.new(event:, current_project: parent_project))
- expect(page).to have_css('.op-activity-list--item-title', text: '(Subproject: My subproject)')
+ expect(page).to have_css(".op-activity-list--item-title", text: "(Subproject: My subproject)")
end
end
- context 'when a journal change does not have a formatter associated' do
- it 'does not display the change information' do
- event.event_description = ''
- allow(event.journal).to receive(:details).and_return(i_do_not_have_a_formatter_associated: ['old', 'new'])
+ context "when a journal change does not have a formatter associated" do
+ it "does not display the change information" do
+ event.event_description = ""
+ allow(event.journal).to receive(:details).and_return(i_do_not_have_a_formatter_associated: ["old", "new"])
render_inline(described_class.new(event:))
- expect(page).to have_no_css('.op-activity-list--item-detail')
+ expect(page).to have_no_css(".op-activity-list--item-detail")
end
end
- context 'for TimeEntry activities' do
+ context "for TimeEntry activities" do
let(:journal) { build_stubbed(:time_entry_journal) }
let(:event) do
Activities::Event.new(
@@ -134,10 +134,10 @@
)
end
- it 'displays the title correctly' do
+ it "displays the title correctly" do
component = described_class.new(event:)
render_inline(component)
- expect(page).to have_css('.op-activity-list--item-title', text: /Event Title\s+\(Project: My project\)/)
+ expect(page).to have_css(".op-activity-list--item-title", text: /Event Title\s+\(Project: My project\)/)
end
end
end
diff --git a/spec/components/application_component_spec.rb b/spec/components/application_component_spec.rb
index 1b8722e4a3e1..9ab464741688 100644
--- a/spec/components/application_component_spec.rb
+++ b/spec/components/application_component_spec.rb
@@ -31,29 +31,29 @@
require "rails_helper"
RSpec.describe ApplicationComponent, type: :component do
- describe '.options' do
+ describe ".options" do
let(:component_class) do
Class.new(described_class) do
- options title: 'Hello World!', subtitle: 'How are you today?'
+ options title: "Hello World!", subtitle: "How are you today?"
options enabled: true
options :x, :y
end
end
- it 'defines options with default values as constructor attributes' do
+ it "defines options with default values as constructor attributes" do
component = component_class.new
- expect(component.title).to eq('Hello World!')
- expect(component.subtitle).to eq('How are you today?')
+ expect(component.title).to eq("Hello World!")
+ expect(component.subtitle).to eq("How are you today?")
expect(component.enabled).to be(true)
expect(component.x).to be_nil
expect(component.y).to be_nil
end
- it 'returns value used in constructor if present' do
- component = component_class.new(title: 'My title', subtitle: nil, enabled: false, x: 13, y: 37)
+ it "returns value used in constructor if present" do
+ component = component_class.new(title: "My title", subtitle: nil, enabled: false, x: 13, y: 37)
- expect(component.title).to eq('My title')
+ expect(component.title).to eq("My title")
expect(component.subtitle).to be_nil
expect(component.enabled).to be(false)
expect(component.x).to eq(13)
diff --git a/spec/components/attribute_groups/attribute_group_component_spec.rb b/spec/components/attribute_groups/attribute_group_component_spec.rb
index 80e40e3aa6b7..9798f0dce21f 100644
--- a/spec/components/attribute_groups/attribute_group_component_spec.rb
+++ b/spec/components/attribute_groups/attribute_group_component_spec.rb
@@ -31,7 +31,7 @@
require "rails_helper"
RSpec.describe AttributeGroups::AttributeGroupComponent, type: :component do
- it 'renders the title' do
+ it "renders the title" do
render_inline(described_class.new) do |component|
component.with_header(title: "A Title")
@@ -41,32 +41,32 @@
)
end
- aggregate_failures 'group header' do
- expect(page).to have_css('.attributes-group')
- expect(page).to have_css('h3.attributes-group--header-text', text: 'A Title')
+ aggregate_failures "group header" do
+ expect(page).to have_css(".attributes-group")
+ expect(page).to have_css("h3.attributes-group--header-text", text: "A Title")
end
- aggregate_failures 'attribute key value' do
- expect(page).to have_css('.attributes-key-value')
- expect(page).to have_css('.attributes-key-value--key', text: 'Attribute Key 1') &
- have_css('.attributes-key-value--value.-text', text: 'Attribute Value 1')
- expect(page).to have_css('.attributes-key-value--key', text: 'Attribute Key 2') &
- have_css('.attributes-key-value--value.-text', text: 'Attribute Value 2')
+ aggregate_failures "attribute key value" do
+ expect(page).to have_css(".attributes-key-value")
+ expect(page).to have_css(".attributes-key-value--key", text: "Attribute Key 1") &
+ have_css(".attributes-key-value--value.-text", text: "Attribute Value 1")
+ expect(page).to have_css(".attributes-key-value--key", text: "Attribute Key 2") &
+ have_css(".attributes-key-value--value.-text", text: "Attribute Value 2")
end
end
- it 'renders content when provided' do
+ it "renders content when provided" do
render_inline(described_class.new) do |component|
component.with_header(title: "A Title")
"Raw Content"
end
- expect(page).to have_css('.attributes-group--content', text: 'Raw Content')
+ expect(page).to have_css(".attributes-group--content", text: "Raw Content")
- aggregate_failures 'group header' do
- expect(page).to have_css('.attributes-group')
- expect(page).to have_css('h3.attributes-group--header-text', text: 'A Title')
+ aggregate_failures "group header" do
+ expect(page).to have_css(".attributes-group")
+ expect(page).to have_css("h3.attributes-group--header-text", text: "A Title")
end
end
end
diff --git a/spec/components/attribute_groups/attribute_group_header_component_spec.rb b/spec/components/attribute_groups/attribute_group_header_component_spec.rb
index acf67ba5f857..e81c1e73515c 100644
--- a/spec/components/attribute_groups/attribute_group_header_component_spec.rb
+++ b/spec/components/attribute_groups/attribute_group_header_component_spec.rb
@@ -31,9 +31,9 @@
require "rails_helper"
RSpec.describe AttributeGroups::AttributeGroupHeaderComponent, type: :component do
- it 'renders the title' do
- render_inline(described_class.new(title: 'A Title'))
+ it "renders the title" do
+ render_inline(described_class.new(title: "A Title"))
- expect(page).to have_css('h3.attributes-group--header-text', text: 'A Title')
+ expect(page).to have_css("h3.attributes-group--header-text", text: "A Title")
end
end
diff --git a/spec/components/attribute_groups/attribute_key_value_component_spec.rb b/spec/components/attribute_groups/attribute_key_value_component_spec.rb
index dfa482ee538e..70ab3b63c009 100644
--- a/spec/components/attribute_groups/attribute_key_value_component_spec.rb
+++ b/spec/components/attribute_groups/attribute_key_value_component_spec.rb
@@ -31,40 +31,40 @@
require "rails_helper"
RSpec.describe AttributeGroups::AttributeKeyValueComponent, type: :component do
- it 'renders the attribute key and value' do
- render_inline(described_class.new(key: 'Attribute Key', value: 'Attribute Value'))
+ it "renders the attribute key and value" do
+ render_inline(described_class.new(key: "Attribute Key", value: "Attribute Value"))
- expect(page).to have_css('.attributes-key-value--key', text: 'Attribute Key') &
- have_css('.attributes-key-value--value.-text', text: 'Attribute Value')
+ expect(page).to have_css(".attributes-key-value--key", text: "Attribute Key") &
+ have_css(".attributes-key-value--value.-text", text: "Attribute Value")
end
it "preserve html in the value if it's a safe string" do
- render_inline(described_class.new(key: 'Attribute Key', value: '
")
+ expect(page).to have_css(".attributes-key-value--value.-text", text: "Some value")
end
- context 'with value and content' do
- it 'renders the content' do
- render_inline(described_class.new(key: 'Attribute Key', value: 'Attribute Value')) do
+ context "with value and content" do
+ it "renders the content" do
+ render_inline(described_class.new(key: "Attribute Key", value: "Attribute Value")) do
"
")
end
end
- context 'with content, no value' do
- it 'renders the content' do
- render_inline(described_class.new(key: 'Attribute Key')) do
+ context "with content, no value" do
+ it "renders the content" do
+ render_inline(described_class.new(key: "Attribute Key")) do
"
")
end
end
end
diff --git a/spec/components/op_turbo/frame_component_spec.rb b/spec/components/op_turbo/frame_component_spec.rb
index 0f5bb5126ad9..cbb460b207e5 100644
--- a/spec/components/op_turbo/frame_component_spec.rb
+++ b/spec/components/op_turbo/frame_component_spec.rb
@@ -26,41 +26,41 @@
# See COPYRIGHT and LICENSE files for more details.
#++
#
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpTurbo::FrameComponent, type: :component do
- describe '#turbo_frame_id' do
- context 'with `context:` option' do
- it 'returns the turbo frame id' do
+ describe "#turbo_frame_id" do
+ context "with `context:` option" do
+ it "returns the turbo frame id" do
storage = build_stubbed(:nextcloud_storage, id: 1)
component = described_class.new(storage, context: :general_info)
- expect(component.turbo_frame_id).to eq('general_info_storages_nextcloud_storage_1')
+ expect(component.turbo_frame_id).to eq("general_info_storages_nextcloud_storage_1")
end
end
- context 'without `context:` option' do
- it 'returns just the model dom id' do
+ context "without `context:` option" do
+ it "returns just the model dom id" do
storage = build_stubbed(:nextcloud_storage, id: 1)
component = described_class.new(storage)
- expect(component.turbo_frame_id).to eq('storages_nextcloud_storage_1')
+ expect(component.turbo_frame_id).to eq("storages_nextcloud_storage_1")
end
end
- context 'with `id:` option' do
- it 'returns the turbo frame id' do
- component = described_class.new(id: 'test_id')
+ context "with `id:` option" do
+ it "returns the turbo frame id" do
+ component = described_class.new(id: "test_id")
- expect(component.turbo_frame_id).to eq('test_id')
+ expect(component.turbo_frame_id).to eq("test_id")
end
end
- context 'with `id:` and `context:` option' do
- it 'returns the turbo frame id' do
- component = described_class.new(id: 'test_id', context: :general_info)
+ context "with `id:` and `context:` option" do
+ it "returns the turbo frame id" do
+ component = described_class.new(id: "test_id", context: :general_info)
- expect(component.turbo_frame_id).to eq('general_info_test_id')
+ expect(component.turbo_frame_id).to eq("general_info_test_id")
end
end
end
diff --git a/spec/components/open_project/common/duration_component_spec.rb b/spec/components/open_project/common/duration_component_spec.rb
index 7442b65a4789..761186f953d9 100644
--- a/spec/components/open_project/common/duration_component_spec.rb
+++ b/spec/components/open_project/common/duration_component_spec.rb
@@ -9,7 +9,7 @@
subject { described_class.new(duration, type, **args) }
- shared_examples 'renders a duration' do |duration, type, **args|
+ shared_examples "renders a duration" do |duration, type, **args|
let(:duration) { duration }
let(:type) { type }
let(:args) { args }
@@ -19,54 +19,54 @@
end
end
- context 'with numeric duration' do
- it_behaves_like 'renders a duration', 1, :minutes do
- let(:expected) { '1 minute' }
+ context "with numeric duration" do
+ it_behaves_like "renders a duration", 1, :minutes do
+ let(:expected) { "1 minute" }
end
- it_behaves_like 'renders a duration', 20, :minutes do
- let(:expected) { '20 minutes' }
+ it_behaves_like "renders a duration", 20, :minutes do
+ let(:expected) { "20 minutes" }
end
- it_behaves_like 'renders a duration', 63, :minutes do
- let(:expected) { '1 hour, 3 minutes' }
+ it_behaves_like "renders a duration", 63, :minutes do
+ let(:expected) { "1 hour, 3 minutes" }
end
- it_behaves_like 'renders a duration', 125, :minutes, abbreviated: true do
- let(:expected) { '2 hrs, 5 mins' }
+ it_behaves_like "renders a duration", 125, :minutes, abbreviated: true do
+ let(:expected) { "2 hrs, 5 mins" }
end
end
- context 'with ISO8601 duration' do
- it_behaves_like 'renders a duration', 'P3DT12H25M' do
- let(:expected) { '3 days, 12 hours, 25 minutes' }
+ context "with ISO8601 duration" do
+ it_behaves_like "renders a duration", "P3DT12H25M" do
+ let(:expected) { "3 days, 12 hours, 25 minutes" }
end
end
- context 'with AS::Duration' do
- it_behaves_like 'renders a duration', 3612.seconds do
- let(:expected) { '1 hour, 12 seconds' }
+ context "with AS::Duration" do
+ it_behaves_like "renders a duration", 3612.seconds do
+ let(:expected) { "1 hour, 12 seconds" }
end
- it_behaves_like 'renders a duration', 3680.seconds do
- let(:expected) { '1 hour, 1 minute, 20 seconds' }
+ it_behaves_like "renders a duration", 3680.seconds do
+ let(:expected) { "1 hour, 1 minute, 20 seconds" }
end
end
- context 'when providing an invalid type' do
+ context "when providing an invalid type" do
let(:duration) { 1234 }
let(:type) { :bogus }
- it 'raises an error' do
- expected = 'Provide known type (seconds, minutes, hours, days, weeks, months, years) ' \
- 'when providing a number to this component.'
+ it "raises an error" do
+ expected = "Provide known type (seconds, minutes, hours, days, weeks, months, years) " \
+ "when providing a number to this component."
expect { subject }.to raise_error(ArgumentError, expected)
end
end
- context 'when providing an invalid duration' do
+ context "when providing an invalid duration" do
let(:duration) { %w[what's this] }
let(:type) { :minutes }
- it 'raises an error' do
- expect { subject }.to raise_error(ArgumentError, 'Invalid duration type Array.')
+ it "raises an error" do
+ expect { subject }.to raise_error(ArgumentError, "Invalid duration type Array.")
end
end
end
diff --git a/spec/components/work_packages/share/user_details_component_spec.rb b/spec/components/work_packages/share/user_details_component_spec.rb
index b1337756d103..aeb385aa6ca1 100644
--- a/spec/components/work_packages/share/user_details_component_spec.rb
+++ b/spec/components/work_packages/share/user_details_component_spec.rb
@@ -27,7 +27,7 @@
#
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WorkPackages::Share::UserDetailsComponent, type: :component do
subject { render_inline(described_class.new(share:, manager_mode:, invite_resent:)) }
@@ -35,11 +35,11 @@
shared_let(:project) { create(:project) }
shared_let(:work_package) { create(:work_package, project:) }
shared_let(:work_package_role) { create(:view_work_package_role) }
- shared_let(:project_role) { create(:project_role, name: 'Cool role') }
+ shared_let(:project_role) { create(:project_role, name: "Cool role") }
- shared_let(:user_firstname) { 'Richard' }
- shared_let(:user_lastname) { 'Hendricks' }
- shared_let(:group_name) { 'Cool group' }
+ shared_let(:user_firstname) { "Richard" }
+ shared_let(:user_lastname) { "Hendricks" }
+ shared_let(:group_name) { "Cool group" }
let(:invite_resent) { false }
@@ -50,11 +50,11 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
inherited_from: group_membership.member_roles.first.id)
end
- describe 'when not in manager mode' do
+ describe "when not in manager mode" do
let(:manager_mode) { false }
- describe 'rendering for a user in a non-active state' do
- context 'when the user is locked' do
+ describe "rendering for a user in a non-active state" do
+ context "when the user is locked" do
let!(:principal) { create(:user, firstname: user_firstname, lastname: user_lastname, status: :locked) }
let!(:share) do
create(:work_package_member,
@@ -71,7 +71,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- context 'when the user is invited' do
+ context "when the user is invited" do
let!(:principal) { create(:user, firstname: user_firstname, lastname: user_lastname, status: :invited) }
let!(:share) do
create(:work_package_member,
@@ -80,7 +80,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
roles: [work_package_role])
end
- context 'and the invite has not been resent' do
+ context "and the invite has not been resent" do
it do
subject
@@ -89,7 +89,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- context 'and the invite has been resent' do
+ context "and the invite has been resent" do
let(:invite_resent) { true }
it do
@@ -102,7 +102,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- describe 'rendering for a group' do
+ describe "rendering for a group" do
shared_let(:principal) { create(:group, name: group_name) }
shared_let(:share) do
create(:work_package_member,
@@ -111,7 +111,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
roles: [work_package_role])
end
- context 'when it is a member in the project' do
+ context "when it is a member in the project" do
before do
create(:member, project:, principal:, roles: [project_role])
end
@@ -124,7 +124,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- context 'when it is not a member in the project' do
+ context "when it is not a member in the project" do
it do
subject
@@ -134,7 +134,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- describe 'rendering for a user' do
+ describe "rendering for a user" do
shared_let(:principal) { create(:user, firstname: user_firstname, lastname: user_lastname) }
shared_let(:share) do
create(:work_package_member,
@@ -143,8 +143,8 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
roles: [work_package_role])
end
- context 'when the user is not part of a shared with group' do
- context 'and the user is not a project member' do
+ context "when the user is not part of a shared with group" do
+ context "and the user is not a project member" do
it do
subject
@@ -153,7 +153,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- context 'and the user is a project member' do
+ context "and the user is a project member" do
before do
create(:member, project:, principal:, roles: [project_role])
end
@@ -167,7 +167,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- context 'when the user is part of a shared with group' do
+ context "when the user is part of a shared with group" do
shared_let(:group) { create(:group, name: group_name, members: [principal]) }
before do
@@ -179,7 +179,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
build_inherited_membership(group_membership: group_share, user_membership: share)
end
- context 'and the user is not a project member' do
+ context "and the user is not a project member" do
it do
subject
@@ -188,7 +188,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- context 'and the user is a project member' do
+ context "and the user is a project member" do
before do
create(:member, project:, principal:, roles: [project_role])
end
@@ -204,11 +204,11 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- describe 'when in manager mode' do
+ describe "when in manager mode" do
let(:manager_mode) { true }
- describe 'rendering for a user in a non-active state' do
- context 'when the user is locked' do
+ describe "rendering for a user in a non-active state" do
+ context "when the user is locked" do
let!(:principal) { create(:user, firstname: user_firstname, lastname: user_lastname, status: :locked) }
let!(:share) do
create(:work_package_member,
@@ -227,7 +227,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- context 'when the user is invited' do
+ context "when the user is invited" do
let!(:principal) { create(:user, firstname: user_firstname, lastname: user_lastname, status: :invited) }
let!(:share) do
create(:work_package_member,
@@ -236,7 +236,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
roles: [work_package_role])
end
- context 'and the invite has not been resent' do
+ context "and the invite has not been resent" do
it do
subject
@@ -245,7 +245,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- context 'and the invite has been resent' do
+ context "and the invite has been resent" do
let(:invite_resent) { true }
it do
@@ -258,7 +258,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- describe 'rendering for a group' do
+ describe "rendering for a group" do
shared_let(:principal) { create(:group, name: group_name) }
shared_let(:share) do
create(:work_package_member,
@@ -267,7 +267,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
roles: [work_package_role])
end
- context 'when it is a member in the project' do
+ context "when it is a member in the project" do
before do
create(:member, project:, principal:, roles: [project_role])
end
@@ -280,7 +280,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- context 'when it is not a member in the project' do
+ context "when it is not a member in the project" do
it do
subject
@@ -290,7 +290,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- describe 'rendering for a user' do
+ describe "rendering for a user" do
shared_let(:principal) { create(:user, firstname: user_firstname, lastname: user_lastname) }
shared_let(:share) do
create(:work_package_member,
@@ -299,10 +299,10 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
roles: [work_package_role])
end
- context 'when the user is a project member' do
+ context "when the user is a project member" do
shared_let(:user_membership) { create(:member, project:, principal:, roles: [project_role]) }
- context 'and the user is not part of any group' do
+ context "and the user is not part of any group" do
it do
subject
@@ -311,10 +311,10 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- context 'and the user is part of a group' do
+ context "and the user is part of a group" do
shared_let(:group) { create(:group, name: group_name, members: [principal]) }
- context 'and the group is a project member itself' do
+ context "and the group is a project member itself" do
before do
group_membership = create(:member,
project:,
@@ -324,7 +324,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
build_inherited_membership(group_membership:, user_membership:, role: project_role)
end
- context 'and the group is shared with' do
+ context "and the group is shared with" do
before do
group_share = create(:work_package_member,
principal: group,
@@ -343,7 +343,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- context 'and the group is not shared with' do
+ context "and the group is not shared with" do
it do
subject
@@ -354,8 +354,8 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- context 'and the group is not a project member itself' do
- context 'and the group is shared with' do
+ context "and the group is not a project member itself" do
+ context "and the group is shared with" do
before do
group_share = create(:work_package_member,
principal: group,
@@ -374,7 +374,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- context 'and the group is not shared with' do
+ context "and the group is not shared with" do
it do
subject
@@ -387,8 +387,8 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- context 'when the user is not a project member' do
- context 'and the user is not part of any group' do
+ context "when the user is not a project member" do
+ context "and the user is not part of any group" do
it do
subject
@@ -397,10 +397,10 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- context 'and the user is part of a group' do
+ context "and the user is part of a group" do
shared_let(:group) { create(:group, name: group_name, members: [principal]) }
- context 'and the group is a project member itself' do
+ context "and the group is a project member itself" do
before do
group_membership = create(:member, project:, principal: group, roles: [project_role])
user_membership = create(:member, project:, principal:, roles: [project_role])
@@ -408,7 +408,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
build_inherited_membership(group_membership:, user_membership:, role: project_role)
end
- context 'and the group is shared with' do
+ context "and the group is shared with" do
before do
group_share = create(:work_package_member,
principal: group,
@@ -427,7 +427,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- context 'and the group is not shared with' do
+ context "and the group is not shared with" do
it do
subject
@@ -438,8 +438,8 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- context 'and the group is not a project member itself' do
- context 'and the group is shared with' do
+ context "and the group is not a project member itself" do
+ context "and the group is shared with" do
before do
group_share = create(:work_package_member,
principal: group,
@@ -458,7 +458,7 @@ def build_inherited_membership(group_membership:, user_membership:, role: work_p
end
end
- context 'and the group is not shared with' do
+ context "and the group is not shared with" do
it do
subject
diff --git a/spec/constants/settings/definition_spec.rb b/spec/constants/settings/definition_spec.rb
index e66d4b0fd13d..c0e15fb79f06 100644
--- a/spec/constants/settings/definition_spec.rb
+++ b/spec/constants/settings/definition_spec.rb
@@ -26,11 +26,11 @@
# See docs/COPYRIGHT.rdoc for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Settings::Definition, :settings_reset do
- describe '.add_all' do
- it 'adds all core setting definitions if they are not loaded' do
+ describe ".add_all" do
+ it "adds all core setting definitions if they are not loaded" do
described_class.instance_variable_set(:@all, nil)
expect(described_class.all).to eq({})
@@ -39,7 +39,7 @@
expect(described_class.all.keys).to eq(described_class::DEFINITIONS.keys)
end
- it 'does not add any plugin/feature settings if they were removed for some reason' do
+ it "does not add any plugin/feature settings if they were removed for some reason" do
not_core_settings = described_class.all.keys - described_class::DEFINITIONS.keys
expect(not_core_settings).not_to be_empty
described_class.instance_variable_set(:@all, nil)
@@ -50,7 +50,7 @@
end
end
- describe '.all' do
+ describe ".all" do
subject(:all) { described_class.all }
it "is a hash map of setting definitions" do
@@ -58,65 +58,65 @@
expect(all.values).to(be_all { |d| d.is_a?(described_class) })
end
- it 'contains a definition from settings' do
+ it "contains a definition from settings" do
expect(all[:smtp_address]).to be_present
end
- it 'contains a definition from configuration' do
+ it "contains a definition from configuration" do
expect(all[:edition]).to be_present
end
- it 'contains a definition from settings.yml' do
+ it "contains a definition from settings.yml" do
expect(all[:sendmail_location]).to be_present
end
- it 'casts the value from settings.yml' do
+ it "casts the value from settings.yml" do
expect(all[:brute_force_block_after_failed_logins].value).to eq(20)
end
- context 'when overriding from ENV',
+ context "when overriding from ENV",
with_env: {
- 'OPENPROJECT_EDITION' => 'bim',
- 'OPENPROJECT_DEFAULT__LANGUAGE' => 'de'
+ "OPENPROJECT_EDITION" => "bim",
+ "OPENPROJECT_DEFAULT__LANGUAGE" => "de"
} do
- it 'allows overriding configuration from ENV with OPENPROJECT_ prefix with double underscore case (legacy)' do
+ it "allows overriding configuration from ENV with OPENPROJECT_ prefix with double underscore case (legacy)" do
reset(:edition)
reset(:default_language)
- expect(all[:edition].value).to eql 'bim'
- expect(all[:default_language].value).to eql 'de'
+ expect(all[:edition].value).to eql "bim"
+ expect(all[:default_language].value).to eql "de"
end
- it 'allows overriding configuration from ENV with OPENPROJECT_ prefix with single underscore case',
- with_env: { 'OPENPROJECT_DEFAULT_LANGUAGE' => 'de' } do
+ it "allows overriding configuration from ENV with OPENPROJECT_ prefix with single underscore case",
+ with_env: { "OPENPROJECT_DEFAULT_LANGUAGE" => "de" } do
reset(:default_language)
- expect(all[:default_language].value).to eql 'de'
+ expect(all[:default_language].value).to eql "de"
end
- it 'allows overriding configuration from ENV without OPENPROJECT_ prefix',
- with_env: { 'EDITION' => 'bim' } do
+ it "allows overriding configuration from ENV without OPENPROJECT_ prefix",
+ with_env: { "EDITION" => "bim" } do
reset(:edition)
- expect(all[:edition].value).to eql 'bim'
+ expect(all[:edition].value).to eql "bim"
end
- it 'does not allows overriding configuration from ENV without OPENPROJECT_ prefix if setting is writable',
- with_env: { 'DEFAULT_LANGUAGE' => 'de' } do
+ it "does not allows overriding configuration from ENV without OPENPROJECT_ prefix if setting is writable",
+ with_env: { "DEFAULT_LANGUAGE" => "de" } do
reset(:default_language)
- expect(all[:default_language].value).to eql 'en'
+ expect(all[:default_language].value).to eql "en"
end
- it 'allows overriding email/smtp configuration from ENV without OPENPROJECT_ prefix even though setting is writable',
+ it "allows overriding email/smtp configuration from ENV without OPENPROJECT_ prefix even though setting is writable",
with_env: {
- 'EMAIL_DELIVERY_CONFIGURATION' => 'legacy',
- 'EMAIL_DELIVERY_METHOD' => 'smtp',
- 'SMTP_ADDRESS' => 'smtp.somedomain.org',
- 'SMTP_AUTHENTICATION' => 'something',
- 'SMTP_DOMAIN' => 'email.bogus.abc',
- 'SMTP_ENABLE_STARTTLS_AUTO' => 'true',
- 'SMTP_PASSWORD' => 'password',
- 'SMTP_PORT' => '987',
- 'SMTP_USER_NAME' => 'user',
- 'SMTP_SSL' => 'true'
+ "EMAIL_DELIVERY_CONFIGURATION" => "legacy",
+ "EMAIL_DELIVERY_METHOD" => "smtp",
+ "SMTP_ADDRESS" => "smtp.somedomain.org",
+ "SMTP_AUTHENTICATION" => "something",
+ "SMTP_DOMAIN" => "email.bogus.abc",
+ "SMTP_ENABLE_STARTTLS_AUTO" => "true",
+ "SMTP_PASSWORD" => "password",
+ "SMTP_PORT" => "987",
+ "SMTP_USER_NAME" => "user",
+ "SMTP_SSL" => "true"
} do
reset(:email_delivery_configuration)
reset(:email_delivery_method)
@@ -129,143 +129,143 @@
reset(:smtp_user_name)
reset(:smtp_ssl)
- expect(all[:email_delivery_configuration].value).to eql 'legacy'
+ expect(all[:email_delivery_configuration].value).to eql "legacy"
expect(all[:email_delivery_method].value).to eq :smtp
- expect(all[:smtp_address].value).to eql 'smtp.somedomain.org'
- expect(all[:smtp_authentication].value).to eql 'something'
- expect(all[:smtp_domain].value).to eql 'email.bogus.abc'
+ expect(all[:smtp_address].value).to eql "smtp.somedomain.org"
+ expect(all[:smtp_authentication].value).to eql "something"
+ expect(all[:smtp_domain].value).to eql "email.bogus.abc"
expect(all[:smtp_enable_starttls_auto].value).to be true
- expect(all[:smtp_password].value).to eql 'password'
+ expect(all[:smtp_password].value).to eql "password"
expect(all[:smtp_port].value).to eq 987
- expect(all[:smtp_user_name].value).to eq 'user'
+ expect(all[:smtp_user_name].value).to eq "user"
expect(all[:smtp_ssl].value).to be true
end
- it 'logs a deprecation warning when overriding configuration from ENV without OPENPROJECT_ prefix',
- with_env: { 'EDITION' => 'bim' } do
+ it "logs a deprecation warning when overriding configuration from ENV without OPENPROJECT_ prefix",
+ with_env: { "EDITION" => "bim" } do
allow(Rails.logger).to receive(:warn)
reset(:edition)
- expect(all[:edition].value).to eql 'bim'
+ expect(all[:edition].value).to eql "bim"
expect(Rails.logger).to have_received(:warn)
.with(a_string_including("use OPENPROJECT_EDITION instead of EDITION"))
end
- it 'overriding boolean configuration from ENV will cast the value',
- with_env: { 'OPENPROJECT_REST__API__ENABLED' => '0' } do
+ it "overriding boolean configuration from ENV will cast the value",
+ with_env: { "OPENPROJECT_REST__API__ENABLED" => "0" } do
reset(:rest_api_enabled)
expect(all[:rest_api_enabled].value).to be false
end
- it 'overriding symbol configuration having allowed values from ENV will cast the value before validation check',
- with_env: { 'OPENPROJECT_RAILS__CACHE__STORE' => 'memcache' } do
+ it "overriding symbol configuration having allowed values from ENV will cast the value before validation check",
+ with_env: { "OPENPROJECT_RAILS__CACHE__STORE" => "memcache" } do
reset(:rails_cache_store)
expect(all[:rails_cache_store].value).to eq :memcache
end
- it 'overriding datetime configuration from ENV will cast the value',
- with_env: { 'OPENPROJECT_CONSENT__TIME' => '2222-01-01' } do
+ it "overriding datetime configuration from ENV will cast the value",
+ with_env: { "OPENPROJECT_CONSENT__TIME" => "2222-01-01" } do
reset(:consent_time)
- expect(all[:consent_time].value).to eql DateTime.parse('2222-01-01')
+ expect(all[:consent_time].value).to eql DateTime.parse("2222-01-01")
end
- it 'overriding timezone configuration from ENV will cast the value',
- with_env: { 'OPENPROJECT_USER__DEFAULT__TIMEZONE' => 'Europe/Berlin' } do
+ it "overriding timezone configuration from ENV will cast the value",
+ with_env: { "OPENPROJECT_USER__DEFAULT__TIMEZONE" => "Europe/Berlin" } do
reset(:user_default_timezone)
- expect(all[:user_default_timezone].value).to eq 'Europe/Berlin'
+ expect(all[:user_default_timezone].value).to eq "Europe/Berlin"
end
- it 'overriding timezone configuration from ENV with a bogus value',
- with_env: { 'OPENPROJECT_USER__DEFAULT__TIMEZONE' => 'foobar' } do
+ it "overriding timezone configuration from ENV with a bogus value",
+ with_env: { "OPENPROJECT_USER__DEFAULT__TIMEZONE" => "foobar" } do
expect { reset(:user_default_timezone) }.to raise_error(ArgumentError)
end
- it 'overriding configuration from ENV will set it to non writable',
- with_env: { 'OPENPROJECT_EDITION' => 'bim' } do
+ it "overriding configuration from ENV will set it to non writable",
+ with_env: { "OPENPROJECT_EDITION" => "bim" } do
reset(:edition)
expect(all[:edition]).not_to be_writable
end
- it 'allows overriding settings array from ENV',
- with_env: { 'OPENPROJECT_PASSWORD__ACTIVE__RULES' => YAML.dump(['lowercase']) } do
+ it "allows overriding settings array from ENV",
+ with_env: { "OPENPROJECT_PASSWORD__ACTIVE__RULES" => YAML.dump(["lowercase"]) } do
reset(:password_active_rules)
- expect(all[:password_active_rules].value).to eql ['lowercase']
+ expect(all[:password_active_rules].value).to eql ["lowercase"]
end
- it 'overriding settings from ENV will set it to non writable',
- with_env: { 'OPENPROJECT_WELCOME__TITLE' => 'Some title' } do
+ it "overriding settings from ENV will set it to non writable",
+ with_env: { "OPENPROJECT_WELCOME__TITLE" => "Some title" } do
reset(:welcome_title)
expect(all[:welcome_title]).not_to be_writable
end
- it 'allows overriding settings hash partially from ENV',
- with_env: { 'OPENPROJECT_REPOSITORY__CHECKOUT__DATA_GIT_ENABLED' => '1' } do
+ it "allows overriding settings hash partially from ENV",
+ with_env: { "OPENPROJECT_REPOSITORY__CHECKOUT__DATA_GIT_ENABLED" => "1" } do
reset(:repository_checkout_data)
expect(all[:repository_checkout_data].value).to eql({
- 'git' => { 'enabled' => 1 },
- 'subversion' => { 'enabled' => 0 }
+ "git" => { "enabled" => 1 },
+ "subversion" => { "enabled" => 0 }
})
end
- it 'allows overriding settings hash partially from ENV with single underscore name',
- with_env: { 'OPENPROJECT_REPOSITORY_CHECKOUT_DATA_GIT_ENABLED' => '1' } do
+ it "allows overriding settings hash partially from ENV with single underscore name",
+ with_env: { "OPENPROJECT_REPOSITORY_CHECKOUT_DATA_GIT_ENABLED" => "1" } do
reset(:repository_checkout_data)
expect(all[:repository_checkout_data].value).to eql({
- 'git' => { 'enabled' => 1 },
- 'subversion' => { 'enabled' => 0 }
+ "git" => { "enabled" => 1 },
+ "subversion" => { "enabled" => 0 }
})
end
- it 'allows overriding settings hash partially from ENV with yaml data',
- with_env: { 'OPENPROJECT_REPOSITORY_CHECKOUT_DATA' => '{git: {enabled: 1}}' } do
+ it "allows overriding settings hash partially from ENV with yaml data",
+ with_env: { "OPENPROJECT_REPOSITORY_CHECKOUT_DATA" => "{git: {enabled: 1}}" } do
reset(:repository_checkout_data)
expect(all[:repository_checkout_data].value).to eql({
- 'git' => { 'enabled' => 1 },
- 'subversion' => { 'enabled' => 0 }
+ "git" => { "enabled" => 1 },
+ "subversion" => { "enabled" => 0 }
})
end
- it 'allows overriding settings hash fully from repeated ENV values' do
+ it "allows overriding settings hash fully from repeated ENV values" do
stub_const(
- 'ENV',
+ "ENV",
{
- 'OPENPROJECT_REPOSITORY__CHECKOUT__DATA' => '{hg: {enabled: 0}}',
- 'OPENPROJECT_REPOSITORY__CHECKOUT__DATA_CVS_ENABLED' => '0',
- 'OPENPROJECT_REPOSITORY_CHECKOUT_DATA_GIT_ENABLED' => '1',
- 'OPENPROJECT_REPOSITORY_CHECKOUT_DATA_GIT_MINIMUM__VERSION' => '42',
- 'OPENPROJECT_REPOSITORY_CHECKOUT_DATA_SUBVERSION_ENABLED' => '1'
+ "OPENPROJECT_REPOSITORY__CHECKOUT__DATA" => "{hg: {enabled: 0}}",
+ "OPENPROJECT_REPOSITORY__CHECKOUT__DATA_CVS_ENABLED" => "0",
+ "OPENPROJECT_REPOSITORY_CHECKOUT_DATA_GIT_ENABLED" => "1",
+ "OPENPROJECT_REPOSITORY_CHECKOUT_DATA_GIT_MINIMUM__VERSION" => "42",
+ "OPENPROJECT_REPOSITORY_CHECKOUT_DATA_SUBVERSION_ENABLED" => "1"
}
)
reset(:repository_checkout_data)
expect(all[:repository_checkout_data].value).to eql({
- 'cvs' => { 'enabled' => 0 },
- 'git' => { 'enabled' => 1, 'minimum_version' => 42 },
- 'hg' => { 'enabled' => 0 },
- 'subversion' => { 'enabled' => 1 }
+ "cvs" => { "enabled" => 0 },
+ "git" => { "enabled" => 1, "minimum_version" => 42 },
+ "hg" => { "enabled" => 0 },
+ "subversion" => { "enabled" => 1 }
})
end
- it 'allows overriding settings hash fully from ENV with yaml data' do
+ it "allows overriding settings hash fully from ENV with yaml data" do
stub_const(
- 'ENV',
+ "ENV",
{
- 'OPENPROJECT_REPOSITORY_CHECKOUT_DATA' => '{git: {enabled: 1, key: "42"}, cvs: {enabled: 0}}'
+ "OPENPROJECT_REPOSITORY_CHECKOUT_DATA" => '{git: {enabled: 1, key: "42"}, cvs: {enabled: 0}}'
}
)
reset(:repository_checkout_data)
expect(all[:repository_checkout_data].value).to eql({
- 'git' => { 'enabled' => 1, 'key' => '42' },
- 'cvs' => { 'enabled' => 0 },
- 'subversion' => { 'enabled' => 0 }
+ "git" => { "enabled" => 1, "key" => "42" },
+ "cvs" => { "enabled" => 0 },
+ "subversion" => { "enabled" => 0 }
})
end
- it 'allows overriding settings hash fully from ENV with yaml data multiline' do
+ it "allows overriding settings hash fully from ENV with yaml data multiline" do
stub_const(
- 'ENV',
+ "ENV",
{
- 'OPENPROJECT_REPOSITORY_CHECKOUT_DATA' => <<~YML
+ "OPENPROJECT_REPOSITORY_CHECKOUT_DATA" => <<~YML
---
git:
enabled: 1
@@ -277,113 +277,113 @@
)
reset(:repository_checkout_data)
expect(all[:repository_checkout_data].value).to eql({
- 'git' => { 'enabled' => 1, 'key' => '42' },
- 'cvs' => { 'enabled' => 0 },
- 'subversion' => { 'enabled' => 0 }
+ "git" => { "enabled" => 1, "key" => "42" },
+ "cvs" => { "enabled" => 0 },
+ "subversion" => { "enabled" => 0 }
})
end
- it 'allows overriding settings hash fully from ENV with json data' do
+ it "allows overriding settings hash fully from ENV with json data" do
stub_const(
- 'ENV',
+ "ENV",
{
- 'OPENPROJECT_REPOSITORY_CHECKOUT_DATA' => '{"git": {"enabled": 1, "key": "42"}, "cvs": {"enabled": 0}}'
+ "OPENPROJECT_REPOSITORY_CHECKOUT_DATA" => '{"git": {"enabled": 1, "key": "42"}, "cvs": {"enabled": 0}}'
}
)
reset(:repository_checkout_data)
expect(all[:repository_checkout_data].value).to eql({
- 'git' => { 'enabled' => 1, 'key' => '42' },
- 'cvs' => { 'enabled' => 0 },
- 'subversion' => { 'enabled' => 0 }
+ "git" => { "enabled" => 1, "key" => "42" },
+ "cvs" => { "enabled" => 0 },
+ "subversion" => { "enabled" => 0 }
})
end
- it 'allows overriding configuration array from ENV with yaml/json data' do
+ it "allows overriding configuration array from ENV with yaml/json data" do
stub_const(
- 'ENV',
+ "ENV",
{
- 'OPENPROJECT_BLACKLISTED_ROUTES' => '["admin/info", "admin/plugins"]'
+ "OPENPROJECT_BLACKLISTED_ROUTES" => '["admin/info", "admin/plugins"]'
}
)
reset(:blacklisted_routes)
- expect(all[:blacklisted_routes].value).to eq(['admin/info', 'admin/plugins'])
+ expect(all[:blacklisted_routes].value).to eq(["admin/info", "admin/plugins"])
end
- it 'allows overriding configuration array from ENV with space separated string' do
+ it "allows overriding configuration array from ENV with space separated string" do
stub_const(
- 'ENV',
+ "ENV",
{
- 'OPENPROJECT_BLACKLISTED_ROUTES' => 'admin/info admin/plugins'
+ "OPENPROJECT_BLACKLISTED_ROUTES" => "admin/info admin/plugins"
}
)
reset(:blacklisted_routes)
expect(OpenProject::Configuration.blacklisted_routes)
- .to eq(['admin/info', 'admin/plugins'])
+ .to eq(["admin/info", "admin/plugins"])
expect(Setting.blacklisted_routes)
- .to eq(['admin/info', 'admin/plugins'])
+ .to eq(["admin/info", "admin/plugins"])
end
- it 'allows overriding configuration array from ENV with single string' do
+ it "allows overriding configuration array from ENV with single string" do
stub_const(
- 'ENV',
+ "ENV",
{
- 'OPENPROJECT_DISABLED__MODULES' => 'repository'
+ "OPENPROJECT_DISABLED__MODULES" => "repository"
}
)
reset(:disabled_modules)
expect(OpenProject::Configuration.disabled_modules)
- .to eq(['repository'])
+ .to eq(["repository"])
expect(Setting.disabled_modules)
- .to eq(['repository'])
+ .to eq(["repository"])
end
- context 'with definitions from plugins' do
- it 'allows overriding settings hash partially from ENV with aliased env name' do
+ context "with definitions from plugins" do
+ it "allows overriding settings hash partially from ENV with aliased env name" do
stub_const(
- 'ENV',
+ "ENV",
{
- 'OPENPROJECT_2FA_ENFORCED' => 'true',
- 'OPENPROJECT_2FA_ALLOW__REMEMBER__FOR__DAYS' => '15'
+ "OPENPROJECT_2FA_ENFORCED" => "true",
+ "OPENPROJECT_2FA_ALLOW__REMEMBER__FOR__DAYS" => "15"
}
)
# override from env manually because these settings are added by plugin itself
described_class.send(:override_value, all[:plugin_openproject_two_factor_authentication])
expect(all[:plugin_openproject_two_factor_authentication].value).to eq(
- 'active_strategies' => %i[totp webauthn],
- 'enforced' => true,
- 'allow_remember_for_days' => 15
+ "active_strategies" => %i[totp webauthn],
+ "enforced" => true,
+ "allow_remember_for_days" => 15
)
end
- it 'allows overriding settings hash from ENV with aliased env name' do
+ it "allows overriding settings hash from ENV with aliased env name" do
stub_const(
- 'ENV',
+ "ENV",
{
- 'OPENPROJECT_2FA' => '{"enforced": true, "allow_remember_for_days": 15}'
+ "OPENPROJECT_2FA" => '{"enforced": true, "allow_remember_for_days": 15}'
}
)
# override from env manually because these settings are added by plugin itself
described_class.send(:override_value, all[:plugin_openproject_two_factor_authentication])
expect(all[:plugin_openproject_two_factor_authentication].value)
- .to eq({ 'active_strategies' => %i[totp webauthn], 'enforced' => true, 'allow_remember_for_days' => 15 })
+ .to eq({ "active_strategies" => %i[totp webauthn], "enforced" => true, "allow_remember_for_days" => 15 })
end
end
- it 'does not handle ENV vars for which no definition exists',
- with_env: { 'OPENPROJECT_BOGUS' => '1234' } do
+ it "does not handle ENV vars for which no definition exists",
+ with_env: { "OPENPROJECT_BOGUS" => "1234" } do
expect(all[:bogus]).to be_nil
end
- it 'handles ENV vars for definitions added after #all was called (e.g. in a module)',
- with_env: { 'OPENPROJECT_BOGUS' => '1' } do
+ it "handles ENV vars for definitions added after #all was called (e.g. in a module)",
+ with_env: { "OPENPROJECT_BOGUS" => "1" } do
described_class.add(:bogus, default: 0)
expect(all[:bogus].value).to eq 1
end
end
- context 'when overriding from file' do
+ context "when overriding from file" do
let(:configuration_yml) do
<<~YAML
---
@@ -403,74 +403,74 @@
before { stub_configuration_yml }
- it 'overrides from file default' do
+ it "overrides from file default" do
reset(:edition)
- expect(all[:edition].value).to eql 'bim'
+ expect(all[:edition].value).to eql "bim"
end
- it 'marks the value overwritten from file default unwritable' do
+ it "marks the value overwritten from file default unwritable" do
reset(:edition)
expect(all[:edition]).not_to be_writable
end
- it 'overrides from file default path but once again from current env' do
+ it "overrides from file default path but once again from current env" do
reset(:sendmail_location)
- expect(all[:sendmail_location].value).to eql 'test location'
+ expect(all[:sendmail_location].value).to eql "test location"
end
- it 'marks the value overwritten from file default and again from current unwritable' do
+ it "marks the value overwritten from file default and again from current unwritable" do
reset(:sendmail_location)
expect(all[:sendmail_location]).not_to be_writable
end
- it 'overrides from file current env' do
+ it "overrides from file current env" do
reset(:smtp_address)
- expect(all[:smtp_address].value).to eql 'test address'
+ expect(all[:smtp_address].value).to eql "test address"
end
- it 'marks the value overwritten from file current unwritable' do
+ it "marks the value overwritten from file current unwritable" do
reset(:smtp_address)
expect(all[:smtp_address]).not_to be_writable
end
- it 'does not accept undefined settings' do
+ it "does not accept undefined settings" do
expect(all[:bogus]).to be_nil
end
- it 'correctly parses date objects' do
+ it "correctly parses date objects" do
reset(:consent_time)
expect(all[:consent_time].value).to eql DateTime.parse("2222-01-01")
end
- it 'correctly converts a space separated string into array for array format' do
+ it "correctly converts a space separated string into array for array format" do
reset(:disabled_modules)
- expect(all[:disabled_modules].value).to eq ['repository']
+ expect(all[:disabled_modules].value).to eq ["repository"]
reset(:blacklisted_routes)
- expect(all[:blacklisted_routes].value).to eq ['admin/info', 'admin/plugins']
+ expect(all[:blacklisted_routes].value).to eq ["admin/info", "admin/plugins"]
end
- it 'correctly overrides a default by a false value' do
+ it "correctly overrides a default by a false value" do
reset(:direct_uploads)
expect(all[:direct_uploads].value).to be false
end
- context 'when Rails environment is test' do
+ context "when Rails environment is test" do
before do
allow(Rails.env).to receive(:test?).and_return(true)
end
- it 'does not override from file default' do
+ it "does not override from file default" do
reset(:edition)
- expect(all[:edition].value).not_to eql 'bim'
+ expect(all[:edition].value).not_to eql "bim"
end
- it 'overrides from file current env' do
+ it "overrides from file current env" do
reset(:smtp_address)
- expect(all[:smtp_address].value).to eql 'test address'
+ expect(all[:smtp_address].value).to eql "test address"
end
end
- context 'when having invalid values in the file' do
+ context "when having invalid values in the file" do
let(:configuration_yml) do
<<~YAML
---
@@ -479,30 +479,30 @@
YAML
end
- it 'is invalid' do
+ it "is invalid" do
expect do
reset(:smtp_openssl_verify_mode)
end.to raise_error ArgumentError
end
end
- context 'when overwritten from ENV',
- with_env: { 'OPENPROJECT_SENDMAIL__LOCATION' => 'env location' } do
- it 'overrides from ENV' do
+ context "when overwritten from ENV",
+ with_env: { "OPENPROJECT_SENDMAIL__LOCATION" => "env location" } do
+ it "overrides from ENV" do
reset(:sendmail_location)
- expect(all[:sendmail_location].value).to eql 'env location'
+ expect(all[:sendmail_location].value).to eql "env location"
end
- it 'marks the overwritten value unwritable' do
+ it "marks the overwritten value unwritable" do
reset(:sendmail_location)
expect(all[:sendmail_location]).not_to be_writable
end
end
end
- context 'when adding an additional setting' do
- it 'includes the setting' do
- described_class.add('bogus', default: 1, format: :integer)
+ context "when adding an additional setting" do
+ it "includes the setting" do
+ described_class.add("bogus", default: 1, format: :integer)
expect(all[:bogus].value).to eq(1)
end
end
@@ -511,84 +511,84 @@
describe ".[name]" do
subject(:definition) { described_class[key] }
- context 'with a string' do
- let(:key) { 'smtp_address' }
+ context "with a string" do
+ let(:key) { "smtp_address" }
- it 'returns the definition matching the name' do
+ it "returns the definition matching the name" do
expect(definition.name)
.to eql key
end
end
- context 'with a symbol' do
+ context "with a symbol" do
let(:key) { :smtp_address }
- it 'returns the definition matching the name' do
+ it "returns the definition matching the name" do
expect(definition.name)
.to eql key.to_s
end
end
- context 'with a non existing key' do
- let(:key) { 'bogus' }
+ context "with a non existing key" do
+ let(:key) { "bogus" }
- it 'returns nil' do
+ it "returns nil" do
expect(definition)
.to be_nil
end
end
- context 'when adding a setting late', :settings_reset do
- let(:key) { 'bogus' }
+ context "when adding a setting late", :settings_reset do
+ let(:key) { "bogus" }
before do
described_class[key]
- described_class.add 'bogus',
+ described_class.add "bogus",
default: 1,
format: :integer
end
- it 'has the setting' do
+ it "has the setting" do
expect(definition.name)
.to eql key.to_s
end
end
end
- describe '#override_value' do
+ describe "#override_value" do
let(:format) { :string }
- let(:default) { 'abc' }
+ let(:default) { "abc" }
let(:instance) do
described_class
- .new 'bogus',
+ .new "bogus",
format:,
default:
end
- context 'with string format' do
+ context "with string format" do
before do
- instance.override_value('xyz')
+ instance.override_value("xyz")
end
- it 'overwrites the value' do
+ it "overwrites the value" do
expect(instance.value)
- .to eql 'xyz'
+ .to eql "xyz"
end
- it 'does not overwrite the default' do
+ it "does not overwrite the default" do
expect(instance.default)
- .to eql 'abc'
+ .to eql "abc"
end
- it 'turns the definition unwritable' do
+ it "turns the definition unwritable" do
expect(instance)
.not_to be_writable
end
end
- context 'with hash format' do
+ context "with hash format" do
let(:format) { :hash }
let(:default) do
{
@@ -601,39 +601,39 @@
end
before do
- instance.override_value({ abc: { 'a' => 5 }, xyz: 2 })
+ instance.override_value({ abc: { "a" => 5 }, xyz: 2 })
end
- it 'deep merges and transforms keys to string' do
+ it "deep merges and transforms keys to string" do
expect(instance.value)
.to eql({
- 'abc' => {
- 'a' => 5,
- 'b' => 2
+ "abc" => {
+ "a" => 5,
+ "b" => 2
},
- 'cde' => 1,
- 'xyz' => 2
+ "cde" => 1,
+ "xyz" => 2
})
end
- it 'does not overwrite the default' do
+ it "does not overwrite the default" do
expect(instance.default)
.to eql({
- 'abc' => {
- 'a' => 1,
- 'b' => 2
+ "abc" => {
+ "a" => 1,
+ "b" => 2
},
- 'cde' => 1
+ "cde" => 1
})
end
- it 'turns the definition unwritable' do
+ it "turns the definition unwritable" do
expect(instance)
.not_to be_writable
end
end
- context 'with array format' do
+ context "with array format" do
let(:format) { :array }
let(:default) { [1, 2, 3] }
@@ -641,323 +641,323 @@
instance.override_value([4, 5, 6])
end
- it 'overwrites the value' do
+ it "overwrites the value" do
expect(instance.value)
.to eql [4, 5, 6]
end
- it 'does not overwrite the default' do
+ it "does not overwrite the default" do
expect(instance.default)
.to eql [1, 2, 3]
end
- it 'turns the definition unwritable' do
+ it "turns the definition unwritable" do
expect(instance)
.not_to be_writable
end
end
- context 'with an invalid value' do
+ context "with an invalid value" do
let(:instance) do
described_class
- .new 'bogus',
+ .new "bogus",
format:,
- default: 'foo',
+ default: "foo",
allowed: %w[foo bar]
end
- it 'raises an error' do
- expect { instance.override_value('invalid') }
+ it "raises an error" do
+ expect { instance.override_value("invalid") }
.to raise_error ArgumentError
end
end
end
- describe '.exists?' do
- context 'with an existing setting' do
- it 'is truthy' do
+ describe ".exists?" do
+ context "with an existing setting" do
+ it "is truthy" do
expect(described_class)
- .to exist('smtp_address')
+ .to exist("smtp_address")
end
end
- context 'with a non existing setting' do
- it 'is truthy' do
+ context "with a non existing setting" do
+ it "is truthy" do
expect(described_class)
- .not_to exist('foobar')
+ .not_to exist("foobar")
end
end
end
- describe '.new' do
- context 'with all the attributes' do
+ describe ".new" do
+ context "with all the attributes" do
let(:instance) do
- described_class.new 'bogus',
+ described_class.new "bogus",
format: :integer,
default: 1,
writable: false,
allowed: [1, 2, 3]
end
- it 'has the name' do
+ it "has the name" do
expect(instance.name)
- .to eql 'bogus'
+ .to eql "bogus"
end
- it 'has the format (in symbol)' do
+ it "has the format (in symbol)" do
expect(instance.format)
.to eq :integer
end
- it 'has the default' do
+ it "has the default" do
expect(instance.default)
.to eq 1
end
- it 'has the value' do
+ it "has the value" do
expect(instance.value)
.to eq 1
end
- it 'is not serialized' do
+ it "is not serialized" do
expect(instance)
.not_to be_serialized
end
- it 'has the writable value' do
+ it "has the writable value" do
expect(instance)
.not_to be_writable
end
- it 'has the allowed value' do
+ it "has the allowed value" do
expect(instance.allowed)
.to eql [1, 2, 3]
end
end
- context 'with the minimal attributes (integer value)' do
+ context "with the minimal attributes (integer value)" do
let(:instance) do
- described_class.new 'bogus',
+ described_class.new "bogus",
default: 1
end
- it 'has the name' do
+ it "has the name" do
expect(instance.name)
- .to eql 'bogus'
+ .to eql "bogus"
end
- it 'has the format (in symbol) deduced' do
+ it "has the format (in symbol) deduced" do
expect(instance.format)
.to eq :integer
end
- it 'has the default' do
+ it "has the default" do
expect(instance.default)
.to eq 1
end
- it 'has the default frozen' do
+ it "has the default frozen" do
expect(instance.default)
.to be_frozen
end
- it 'has the value' do
+ it "has the value" do
expect(instance.value)
.to eq 1
end
- it 'is not serialized' do
+ it "is not serialized" do
expect(instance)
.not_to be_serialized
end
- it 'has the writable value' do
+ it "has the writable value" do
expect(instance)
.to be_writable
end
end
- context 'with the minimal attributes (hash value)' do
+ context "with the minimal attributes (hash value)" do
let(:instance) do
- described_class.new 'bogus',
- default: { a: 'b', c: { d: 'e' } }
+ described_class.new "bogus",
+ default: { a: "b", c: { d: "e" } }
end
- it 'has the format (in symbol) deduced' do
+ it "has the format (in symbol) deduced" do
expect(instance.format)
.to eq :hash
end
- it 'is serialized' do
+ it "is serialized" do
expect(instance)
.to be_serialized
end
- it 'has the default frozen' do
+ it "has the default frozen" do
expect(instance.default)
.to be_frozen
end
- it 'transforms keys to string' do
+ it "transforms keys to string" do
expect(instance.value)
.to eq({
- 'a' => 'b',
- 'c' => { 'd' => 'e' }
+ "a" => "b",
+ "c" => { "d" => "e" }
})
end
end
- context 'with the minimal attributes (array value)' do
+ context "with the minimal attributes (array value)" do
let(:instance) do
- described_class.new 'bogus',
+ described_class.new "bogus",
default: %i[a b]
end
- it 'has the format (in symbol) deduced' do
+ it "has the format (in symbol) deduced" do
expect(instance.format)
.to eq :array
end
- it 'is serialized' do
+ it "is serialized" do
expect(instance)
.to be_serialized
end
end
- context 'with the minimal attributes (true value)' do
+ context "with the minimal attributes (true value)" do
let(:instance) do
- described_class.new 'bogus',
+ described_class.new "bogus",
default: true
end
- it 'has the format (in symbol) deduced' do
+ it "has the format (in symbol) deduced" do
expect(instance.format)
.to eq :boolean
end
end
- context 'with the minimal attributes (false value)' do
+ context "with the minimal attributes (false value)" do
let(:instance) do
- described_class.new 'bogus',
+ described_class.new "bogus",
default: false
end
- it 'has the format (in symbol) deduced' do
+ it "has the format (in symbol) deduced" do
expect(instance.format)
.to eq :boolean
end
end
- context 'with the minimal attributes (date value)' do
+ context "with the minimal attributes (date value)" do
let(:instance) do
- described_class.new 'bogus',
+ described_class.new "bogus",
default: Time.zone.today
end
- it 'has the format (in symbol) deduced' do
+ it "has the format (in symbol) deduced" do
expect(instance.format)
.to eq :date
end
end
- context 'with the minimal attributes (datetime value)' do
+ context "with the minimal attributes (datetime value)" do
let(:instance) do
- described_class.new 'bogus',
+ described_class.new "bogus",
default: DateTime.now
end
- it 'has the format (in symbol) deduced' do
+ it "has the format (in symbol) deduced" do
expect(instance.format)
.to eq :date_time
end
end
- context 'with the minimal attributes (string value)' do
+ context "with the minimal attributes (string value)" do
let(:instance) do
- described_class.new 'bogus',
- default: 'abc'
+ described_class.new "bogus",
+ default: "abc"
end
- it 'has the format (in symbol) deduced' do
+ it "has the format (in symbol) deduced" do
expect(instance.format)
.to eq :string
end
end
- context 'with procs for value, writable and allowed' do
+ context "with procs for value, writable and allowed" do
let(:instance) do
- described_class.new 'bogus',
- format: 'string',
- default: -> { 'some value' },
+ described_class.new "bogus",
+ format: "string",
+ default: -> { "some value" },
writable: -> { false },
allowed: -> { %w[a b c] }
end
- it 'returns the procs return value for default' do
+ it "returns the procs return value for default" do
expect(instance.default)
- .to eql 'some value'
+ .to eql "some value"
end
- it 'returns the procs return value for value' do
+ it "returns the procs return value for value" do
expect(instance.value)
- .to eql 'some value'
+ .to eql "some value"
end
- it 'returns the procs return value for writable' do
+ it "returns the procs return value for writable" do
expect(instance)
.not_to be_writable
end
- it 'returns the procs return value for allowed' do
+ it "returns the procs return value for allowed" do
expect(instance.allowed)
.to eql %w[a b c]
end
end
- context 'with an integer provided as a string' do
+ context "with an integer provided as a string" do
let(:instance) do
- described_class.new 'bogus',
+ described_class.new "bogus",
format: :integer,
- default: '5'
+ default: "5"
end
- it 'returns default as an int' do
+ it "returns default as an int" do
expect(instance.default)
.to eq 5
end
- it 'returns value as an int' do
+ it "returns value as an int" do
expect(instance.value)
.to eq 5
end
end
- context 'with a float provided as a string' do
+ context "with a float provided as a string" do
let(:instance) do
- described_class.new 'bogus',
+ described_class.new "bogus",
format: :float,
- default: '0.5'
+ default: "0.5"
end
- it 'returns default as a float' do
+ it "returns default as a float" do
expect(instance.default)
.to eq 0.5
end
- it 'returns value as a float' do
+ it "returns value as a float" do
expect(instance.value)
.to eq 0.5
end
end
- context 'with a boolean provided with a proc default' do
+ context "with a boolean provided with a proc default" do
let(:instance) do
- described_class.new 'bogus',
+ described_class.new "bogus",
format: :boolean,
default: -> { false }
end
- it 'calls the proc as a default' do
+ it "calls the proc as a default" do
expect(instance.default)
.to be false
end
diff --git a/spec/contracts/attachments/create_contract_integration_spec.rb b/spec/contracts/attachments/create_contract_integration_spec.rb
index 93ffad7eed5c..5fe9d1563b41 100644
--- a/spec/contracts/attachments/create_contract_integration_spec.rb
+++ b/spec/contracts/attachments/create_contract_integration_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
-RSpec.describe Attachments::CreateContract, 'integration' do
- include_context 'ModelContract shared context'
+RSpec.describe Attachments::CreateContract, "integration" do
+ include_context "ModelContract shared context"
let(:model) do
build(:attachment,
@@ -48,36 +48,36 @@
let(:file) do
Rack::Test::UploadedFile.new(
Rails.root.join("spec/fixtures/files/image.png"),
- 'image/png',
+ "image/png",
true
)
end
- let(:content_type) { 'image/png' }
- let(:filename) { 'image.png' }
+ let(:content_type) { "image/png" }
+ let(:filename) { "image.png" }
- context 'with anonymous user that can view the project' do
+ context "with anonymous user that can view the project" do
current_user do
create(:anonymous_role, permissions: %i[view_project])
User.anonymous
end
- describe 'uncontainered' do
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ describe "uncontainered" do
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
- describe 'invalid container' do
+ describe "invalid container" do
let(:container) { build_stubbed(:work_package) }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
- describe 'valid container' do
+ describe "valid container" do
# create a project so that the anonymous permission has something to attach to
let!(:project) { create(:project, public: true) }
let(:container) { build_stubbed(:project_export) }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
end
end
diff --git a/spec/contracts/attachments/create_contract_spec.rb b/spec/contracts/attachments/create_contract_spec.rb
index 1c9443e56723..26dc11f1fb4f 100644
--- a/spec/contracts/attachments/create_contract_spec.rb
+++ b/spec/contracts/attachments/create_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe Attachments::CreateContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:current_user) { build_stubbed(:user) }
let(:model) do
@@ -49,12 +49,12 @@
let(:file) do
Rack::Test::UploadedFile.new(
Rails.root.join("spec/fixtures/files/image.png"),
- 'image/png',
+ "image/png",
true
)
end
- let(:content_type) { 'image/png' }
- let(:filename) { 'image.png' }
+ let(:content_type) { "image/png" }
+ let(:filename) { "image.png" }
let(:can_attach_global) { true }
@@ -63,23 +63,23 @@
.to receive(:none?).and_return(!can_attach_global)
end
- context 'with user who has no permissions' do
+ context "with user who has no permissions" do
let(:can_attach_global) { false }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
- context 'with a user that is not the author' do
+ context "with a user that is not the author" do
let(:user) { build_stubbed(:user) }
- it_behaves_like 'contract is invalid', author: :invalid
+ it_behaves_like "contract is invalid", author: :invalid
end
- context 'with user who has permissions to add' do
- it_behaves_like 'contract is valid'
+ context "with user who has permissions to add" do
+ it_behaves_like "contract is valid"
end
- context 'with a container' do
+ context "with a container" do
let(:container) { build_stubbed(:work_package) }
before do
@@ -89,54 +89,54 @@
.and_return(can_attach)
end
- context 'with user who has no permissions' do
+ context "with user who has no permissions" do
let(:can_attach) { false }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
- context 'with user who has permissions to add' do
+ context "with user who has permissions to add" do
let(:can_attach) { true }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
end
- context 'with an empty whitelist',
+ context "with an empty whitelist",
with_settings: { attachment_whitelist: %w[] } do
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'with a matching mime whitelist',
+ context "with a matching mime whitelist",
with_settings: { attachment_whitelist: %w[image/png] } do
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'with a matching extension whitelist',
+ context "with a matching extension whitelist",
with_settings: { attachment_whitelist: %w[*.png] } do
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'with a non-matching whitelist',
+ context "with a non-matching whitelist",
with_settings: { attachment_whitelist: %w[*.jpg image/jpeg] } do
- it_behaves_like 'contract is invalid', content_type: :not_whitelisted
+ it_behaves_like "contract is invalid", content_type: :not_whitelisted
- context 'when disabling the whitelist check' do
+ context "when disabling the whitelist check" do
let(:contract_options) do
{ whitelist: [] }
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'when overriding the whitelist' do
+ context "when overriding the whitelist" do
let(:contract_options) do
{ whitelist: %w[*.png] }
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
end
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
diff --git a/spec/contracts/attribute_help_texts/base_contract_spec.rb b/spec/contracts/attribute_help_texts/base_contract_spec.rb
index 22db06452055..662c9dad3e0a 100644
--- a/spec/contracts/attribute_help_texts/base_contract_spec.rb
+++ b/spec/contracts/attribute_help_texts/base_contract_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe AttributeHelpTexts::BaseContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:model) { build_stubbed(:work_package_help_text) }
let(:contract) { described_class.new(model, current_user) }
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
end
diff --git a/spec/contracts/authentication/omniauth_auth_hash_contract_spec.rb b/spec/contracts/authentication/omniauth_auth_hash_contract_spec.rb
index d2fb12e7302a..048dc193e02c 100644
--- a/spec/contracts/authentication/omniauth_auth_hash_contract_spec.rb
+++ b/spec/contracts/authentication/omniauth_auth_hash_contract_spec.rb
@@ -26,17 +26,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Authentication::OmniauthAuthHashContract do
let(:auth_hash) do
OmniAuth::AuthHash.new(
- provider: 'google',
- uid: '123545',
- info: { name: 'foo',
- email: 'foo@bar.com',
- first_name: 'foo',
- last_name: 'bar' }
+ provider: "google",
+ uid: "123545",
+ info: { name: "foo",
+ email: "foo@bar.com",
+ first_name: "foo",
+ last_name: "bar" }
)
end
@@ -47,57 +47,57 @@
instance
end
- shared_examples_for 'has error on' do |property, message|
+ shared_examples_for "has error on" do |property, message|
it property do
expect(subject.errors[property]).to include message
end
end
- shared_examples_for 'is valid' do
- it 'is valid' do
+ shared_examples_for "is valid" do
+ it "is valid" do
expect(subject).to be_valid
expect(subject.errors).to be_empty
end
end
- describe '#validate_auth_hash' do
- context 'if valid' do
- it_behaves_like 'is valid'
+ describe "#validate_auth_hash" do
+ context "if valid" do
+ it_behaves_like "is valid"
end
- context 'if invalid' do
+ context "if invalid" do
before do
allow(auth_hash).to receive(:valid?).and_return false
end
- it_behaves_like 'has error on', :base, I18n.t(:error_omniauth_invalid_auth)
+ it_behaves_like "has error on", :base, I18n.t(:error_omniauth_invalid_auth)
end
end
- describe '#validate_auth_hash_not_expired' do
- context 'hash contains valid timestamp' do
+ describe "#validate_auth_hash_not_expired" do
+ context "hash contains valid timestamp" do
before do
auth_hash[:timestamp] = Time.now
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'hash contains invalid timestamp' do
+ context "hash contains invalid timestamp" do
before do
auth_hash[:timestamp] = Time.now - 1.hour
end
- it_behaves_like 'has error on', :base, I18n.t(:error_omniauth_registration_timed_out)
+ it_behaves_like "has error on", :base, I18n.t(:error_omniauth_registration_timed_out)
end
- context 'hash contains no timestamp' do
- it_behaves_like 'is valid'
+ context "hash contains no timestamp" do
+ it_behaves_like "is valid"
end
end
- describe '#validate_authorization_callback' do
- let(:auth_double) { double('Authorization', approve?: authorized, message:) }
+ describe "#validate_authorization_callback" do
+ let(:auth_double) { double("Authorization", approve?: authorized, message:) }
before do
allow(OpenProject::OmniAuth::Authorization)
@@ -106,18 +106,18 @@
.and_return(auth_double)
end
- context 'if authorized' do
+ context "if authorized" do
let(:authorized) { true }
let(:message) { nil }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if invalid' do
+ context "if invalid" do
let(:authorized) { false }
- let(:message) { 'ERROR!' }
+ let(:message) { "ERROR!" }
- it_behaves_like 'has error on', :base, 'ERROR!'
+ it_behaves_like "has error on", :base, "ERROR!"
end
end
end
diff --git a/spec/contracts/custom_actions/cu_contract_spec.rb b/spec/contracts/custom_actions/cu_contract_spec.rb
index 5e7ef1dffc94..3f171d377802 100644
--- a/spec/contracts/custom_actions/cu_contract_spec.rb
+++ b/spec/contracts/custom_actions/cu_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe CustomActions::CuContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:user) { build_stubbed(:user) }
let(:action) do
@@ -39,30 +39,30 @@
end
let(:contract) { described_class.new(action) }
- describe 'name' do
- it 'is writable' do
- action.name = 'blubs'
+ describe "name" do
+ it "is writable" do
+ action.name = "blubs"
expect_contract_valid
end
- it 'needs to be set' do
+ it "needs to be set" do
action.name = nil
expect_contract_invalid
end
end
- describe 'description' do
- it 'is writable' do
- action.description = 'blubs'
+ describe "description" do
+ it "is writable" do
+ action.description = "blubs"
expect_contract_valid
end
end
- describe 'actions' do
- it 'is writable' do
+ describe "actions" do
+ it "is writable" do
responsible_action = CustomActions::Actions::Responsible.new
action.actions = [responsible_action]
@@ -70,63 +70,63 @@
expect_contract_valid
end
- it 'needs to have one' do
+ it "needs to have one" do
action.actions = []
expect_contract_invalid actions: :empty
end
- it 'requires a value if the action requires one' do
+ it "requires a value if the action requires one" do
action.actions = [CustomActions::Actions::Status.new([])]
expect_contract_invalid actions: :empty
end
- it 'allows only the allowed values' do
+ it "allows only the allowed values" do
status_action = CustomActions::Actions::Status.new([0])
allow(status_action)
.to receive(:allowed_values)
- .and_return([{ value: nil, label: '-' },
- { value: 1, label: 'some status' }])
+ .and_return([{ value: nil, label: "-" },
+ { value: 1, label: "some status" }])
action.actions = [status_action]
expect_contract_invalid actions: :inclusion
end
- it 'is not allowed to have an inexistent action' do
+ it "is not allowed to have an inexistent action" do
action.actions = [CustomActions::Actions::Inexistent.new]
expect_contract_invalid actions: :does_not_exist
end
end
- describe 'conditions' do
- it 'is writable' do
- action.conditions = [double('some bogus condition', key: 'some', values: 'bogus', validate: true)]
+ describe "conditions" do
+ it "is writable" do
+ action.conditions = [double("some bogus condition", key: "some", values: "bogus", validate: true)]
expect(contract.validate)
.to be_truthy
end
- it 'allows only the allowed values' do
+ it "allows only the allowed values" do
status_condition = CustomActions::Conditions::Status.new([0])
allow(status_condition)
.to receive(:allowed_values)
- .and_return([{ value: nil, label: '-' },
- { value: 1, label: 'some status' }])
+ .and_return([{ value: nil, label: "-" },
+ { value: 1, label: "some status" }])
action.conditions = [status_condition]
expect_contract_invalid conditions: :inclusion
end
- it 'is not allowed to have an inexistent condition' do
+ it "is not allowed to have an inexistent condition" do
action.conditions = [CustomActions::Conditions::Inexistent.new]
expect_contract_invalid conditions: :does_not_exist
end
end
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
diff --git a/spec/contracts/custom_fields/create_contract_spec.rb b/spec/contracts/custom_fields/create_contract_spec.rb
index 61702e115ad1..3717ea3058a0 100644
--- a/spec/contracts/custom_fields/create_contract_spec.rb
+++ b/spec/contracts/custom_fields/create_contract_spec.rb
@@ -26,16 +26,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe CustomFields::CreateContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:cf) { build(:project_custom_field) }
let(:contract) do
described_class.new(cf, current_user, options: {})
end
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
end
diff --git a/spec/contracts/custom_fields/update_contract_spec.rb b/spec/contracts/custom_fields/update_contract_spec.rb
index 9ff30cdb5718..66764dfa422f 100644
--- a/spec/contracts/custom_fields/update_contract_spec.rb
+++ b/spec/contracts/custom_fields/update_contract_spec.rb
@@ -26,16 +26,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe CustomFields::UpdateContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:cf) { build(:project_custom_field) }
let(:contract) do
described_class.new(cf, current_user)
end
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
end
diff --git a/spec/contracts/groups/create_contract_spec.rb b/spec/contracts/groups/create_contract_spec.rb
index 89b6f6e380d7..dab836d27ba3 100644
--- a/spec/contracts/groups/create_contract_spec.rb
+++ b/spec/contracts/groups/create_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Groups::CreateContract do
- it_behaves_like 'group contract' do
+ it_behaves_like "group contract" do
let(:group) do
Group.new(name: group_name,
group_users:)
@@ -38,16 +38,16 @@
let(:contract) { described_class.new(group, current_user) }
- describe 'validations' do
+ describe "validations" do
let(:current_user) { build_stubbed(:admin) }
- describe 'type' do
- context 'type and class mismatch' do
+ describe "type" do
+ context "type and class mismatch" do
before do
group.type = User.name
end
- it_behaves_like 'contract is invalid', type: 'Type and class mismatch'
+ it_behaves_like "contract is invalid", type: "Type and class mismatch"
end
end
end
diff --git a/spec/contracts/groups/shared_contract_examples.rb b/spec/contracts/groups/shared_contract_examples.rb
index e40046ca314e..a52fa642e280 100644
--- a/spec/contracts/groups/shared_contract_examples.rb
+++ b/spec/contracts/groups/shared_contract_examples.rb
@@ -26,19 +26,19 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
-RSpec.shared_examples_for 'group contract' do
- include_context 'ModelContract shared context'
+RSpec.shared_examples_for "group contract" do
+ include_context "ModelContract shared context"
- let(:group_name) { 'The group' }
+ let(:group_name) { "The group" }
let(:group_users_user_ids) { [42, 43] }
let(:group_users) do
group_users_user_ids.map { |id| build_stubbed(:group_user, user_id: id) }
end
- shared_context 'with real group users' do
+ shared_context "with real group users" do
# make sure users actually exist (not just stubbed) in this case
# so GroupUser validations checking for the existence of group and user don't fail
before do
@@ -48,52 +48,52 @@
end
end
- it_behaves_like 'contract is valid for active admins and invalid for regular users' do
- include_context 'with real group users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users" do
+ include_context "with real group users"
end
- describe 'validations' do
+ describe "validations" do
let(:current_user) { build_stubbed(:admin) }
- context 'name' do
- context 'is valid' do
- include_context 'with real group users'
+ context "name" do
+ context "is valid" do
+ include_context "with real group users"
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'is too long' do
- let(:group_name) { 'X' * 257 }
+ context "is too long" do
+ let(:group_name) { "X" * 257 }
- it_behaves_like 'contract is invalid', name: :too_long
+ it_behaves_like "contract is invalid", name: :too_long
end
- context 'is not empty' do
- let(:group_name) { '' }
+ context "is not empty" do
+ let(:group_name) { "" }
- it_behaves_like 'contract is invalid', name: :blank
+ it_behaves_like "contract is invalid", name: :blank
end
- context 'is unique' do
+ context "is unique" do
before do
Group.create(name: group_name)
end
- it_behaves_like 'contract is invalid', name: :taken
+ it_behaves_like "contract is invalid", name: :taken
end
end
- context 'groups_users' do
+ context "groups_users" do
let(:group_users) do
[build_stubbed(:group_user, user_id: 1),
build_stubbed(:group_user, user_id: 1)]
end
- it_behaves_like 'contract is invalid', group_users: :taken
+ it_behaves_like "contract is invalid", group_users: :taken
end
end
- include_examples 'contract reuses the model errors' do
+ include_examples "contract reuses the model errors" do
let(:current_user) { build_stubbed(:user) }
end
end
diff --git a/spec/contracts/groups/update_contract_spec.rb b/spec/contracts/groups/update_contract_spec.rb
index 1caee73d5a71..298fbf213101 100644
--- a/spec/contracts/groups/update_contract_spec.rb
+++ b/spec/contracts/groups/update_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Groups::UpdateContract do
- it_behaves_like 'group contract' do
+ it_behaves_like "group contract" do
let(:group) do
build_stubbed(:group,
name: group_name,
@@ -39,15 +39,15 @@
let(:contract) { described_class.new(group, current_user) }
- describe 'validations' do
+ describe "validations" do
let(:current_user) { build_stubbed(:admin) }
- describe 'type' do
+ describe "type" do
before do
- group.type = 'A new type'
+ group.type = "A new type"
end
- it_behaves_like 'contract is invalid', type: :error_readonly
+ it_behaves_like "contract is invalid", type: :error_readonly
end
end
end
diff --git a/spec/contracts/members/create_contract_spec.rb b/spec/contracts/members/create_contract_spec.rb
index b0fd87d925c6..9782d67e8ccb 100644
--- a/spec/contracts/members/create_contract_spec.rb
+++ b/spec/contracts/members/create_contract_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Members::CreateContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
- it_behaves_like 'member contract' do
+ it_behaves_like "member contract" do
let(:member) do
Member.new(project: member_project,
roles: member_roles,
@@ -41,36 +41,36 @@
let(:contract) { described_class.new(member, current_user) }
- describe '#validation' do
- context 'if the principal is nil' do
+ describe "#validation" do
+ context "if the principal is nil" do
let(:member_principal) { nil }
- it_behaves_like 'contract is invalid', principal: :blank
+ it_behaves_like "contract is invalid", principal: :blank
end
- context 'if the principal is a builtin user' do
+ context "if the principal is a builtin user" do
let(:member_principal) { build_stubbed(:anonymous) }
- it_behaves_like 'contract is invalid', principal: :unassignable
+ it_behaves_like "contract is invalid", principal: :unassignable
end
- context 'if the principal is a locked user' do
+ context "if the principal is a locked user" do
let(:member_principal) { build_stubbed(:locked_user) }
- it_behaves_like 'contract is invalid', principal: :unassignable
+ it_behaves_like "contract is invalid", principal: :unassignable
end
end
- describe '#assignable_projects' do
- context 'as a user without permission' do
+ describe "#assignable_projects" do
+ context "as a user without permission" do
let(:current_user) { build_stubbed(:user) }
- it 'is empty' do
+ it "is empty" do
expect(contract.assignable_projects).to be_empty
end
end
- context 'as a user with permission in one project' do
+ context "as a user with permission in one project" do
let!(:project1) { create(:project) }
let!(:project2) { create(:project) }
let(:current_user) do
@@ -78,7 +78,7 @@
member_with_permissions: { project1 => %i[manage_members] })
end
- it 'returns the one project' do
+ it "returns the one project" do
expect(contract.assignable_projects.to_a).to eq [project1]
end
end
diff --git a/spec/contracts/members/shared_contract_examples.rb b/spec/contracts/members/shared_contract_examples.rb
index a24f5747f259..cfaf6363d57f 100644
--- a/spec/contracts/members/shared_contract_examples.rb
+++ b/spec/contracts/members/shared_contract_examples.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
-RSpec.shared_examples_for 'member contract' do
- include_context 'ModelContract shared context'
+RSpec.shared_examples_for "member contract" do
+ include_context "ModelContract shared context"
let(:current_user) { build_stubbed(:user, admin: current_user_admin) }
@@ -63,93 +63,93 @@ def expect_valid(valid, symbols = {})
end
end
- describe 'validation' do
- shared_examples 'is valid' do
- it 'is valid' do
+ describe "validation" do
+ shared_examples "is valid" do
+ it "is valid" do
expect_valid(true)
end
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
- context 'if the roles are nil' do
+ context "if the roles are nil" do
let(:member_roles) { [] }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, roles: %i(role_blank))
end
end
- context 'if any role is not assignable (e.g. builtin)' do
+ context "if any role is not assignable (e.g. builtin)" do
let(:member_roles) do
[build_stubbed(:project_role), build_stubbed(:anonymous_role)]
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, roles: %i(ungrantable))
end
end
- context 'if the user lacks :manage_members permission in the project' do
+ context "if the user lacks :manage_members permission in the project" do
let(:permissions) { [:view_members] }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, base: %i(error_unauthorized))
end
end
- context 'if the project is nil (global membership)' do
+ context "if the project is nil (global membership)" do
let(:member_project) { nil }
let(:role) do
build_stubbed(:global_role)
end
- context 'if the user is no admin' do
- it 'is invalid' do
+ context "if the user is no admin" do
+ it "is invalid" do
expect_valid(false, project: %i(blank))
end
end
- context 'if the user is admin and the role is global' do
+ context "if the user is admin and the role is global" do
let(:current_user_admin) { true }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if the role is not a global role' do
+ context "if the role is not a global role" do
let(:current_user_admin) { true }
let(:role) do
build_stubbed(:project_role)
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, roles: %i(ungrantable))
end
end
end
- context 'if the project is set to one not being manageable by the user' do
+ context "if the project is set to one not being manageable by the user" do
let(:permissions) { [] }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, project: %i(invalid))
end
end
end
- describe 'principal' do
- it 'returns the member\'s principal' do
+ describe "principal" do
+ it "returns the member's principal" do
expect(contract.principal)
.to eql(member.principal)
end
end
- describe 'project' do
- it 'returns the member\'s project' do
+ describe "project" do
+ it "returns the member's project" do
expect(contract.project)
.to eql(member.project)
end
end
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
diff --git a/spec/contracts/members/update_contract_spec.rb b/spec/contracts/members/update_contract_spec.rb
index e35f97950dc7..1b2a40cd10e8 100644
--- a/spec/contracts/members/update_contract_spec.rb
+++ b/spec/contracts/members/update_contract_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Members::UpdateContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
- it_behaves_like 'member contract' do
+ it_behaves_like "member contract" do
let(:member) do
build_stubbed(:member,
project: member_project,
@@ -42,27 +42,27 @@
let(:contract) { described_class.new(member, current_user) }
- describe 'validation' do
- context 'if the principal is changed' do
+ describe "validation" do
+ context "if the principal is changed" do
before do
member.principal = build_stubbed(:user)
end
- it_behaves_like 'contract is invalid', user_id: :error_readonly
+ it_behaves_like "contract is invalid", user_id: :error_readonly
end
- context 'if the project is changed' do
+ context "if the project is changed" do
before do
member.project = build_stubbed(:project)
end
- it_behaves_like 'contract is invalid', project_id: :error_readonly
+ it_behaves_like "contract is invalid", project_id: :error_readonly
end
- context 'if the principal is a locked user' do
+ context "if the principal is a locked user" do
let(:member_principal) { build_stubbed(:locked_user) }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
end
end
diff --git a/spec/contracts/messages/create_contract_spec.rb b/spec/contracts/messages/create_contract_spec.rb
index 77cce4ab669b..cbd38a0f069a 100644
--- a/spec/contracts/messages/create_contract_spec.rb
+++ b/spec/contracts/messages/create_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Messages::CreateContract do
- it_behaves_like 'message contract' do
+ it_behaves_like "message contract" do
let(:message) do
Message.new(forum: message_forum,
parent: message_parent,
diff --git a/spec/contracts/messages/shared_contract_examples.rb b/spec/contracts/messages/shared_contract_examples.rb
index fe5c6b6d577f..b1e31740e203 100644
--- a/spec/contracts/messages/shared_contract_examples.rb
+++ b/spec/contracts/messages/shared_contract_examples.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.shared_examples_for 'message contract' do
+RSpec.shared_examples_for "message contract" do
let(:current_user) { build_stubbed(:user) }
before do
@@ -60,11 +60,11 @@ def expect_valid(valid, symbols = {})
end
end
- shared_examples 'is valid' do
- it 'is valid' do
+ shared_examples "is valid" do
+ it "is valid" do
expect_valid(true)
end
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
diff --git a/spec/contracts/messages/update_contract_spec.rb b/spec/contracts/messages/update_contract_spec.rb
index 1cb7557c3b2c..b8bcff8cd7eb 100644
--- a/spec/contracts/messages/update_contract_spec.rb
+++ b/spec/contracts/messages/update_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Messages::UpdateContract do
- it_behaves_like 'message contract' do
+ it_behaves_like "message contract" do
let(:message) do
build_stubbed(:message).tap do |message|
message.forum = message_forum
@@ -44,8 +44,8 @@
end
subject(:contract) { described_class.new(message, current_user) }
- context 'if the author is changed' do
- it 'is invalid' do
+ context "if the author is changed" do
+ it "is invalid" do
message.author = other_user
expect_valid(false, author_id: %i(error_readonly))
end
diff --git a/spec/contracts/notifications/create_contract_spec.rb b/spec/contracts/notifications/create_contract_spec.rb
index 19ffbd01d339..3a3c6d79e610 100644
--- a/spec/contracts/notifications/create_contract_spec.rb
+++ b/spec/contracts/notifications/create_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe Notifications::CreateContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:current_user) do
build_stubbed(:user) do |user|
@@ -40,7 +40,7 @@
let(:notification_context) { build_stubbed(:project) }
let(:notification_resource) { build_stubbed(:journal) }
let(:notification_recipient) { build_stubbed(:user) }
- let(:notification_subject) { 'Some text' }
+ let(:notification_subject) { "Some text" }
let(:notification_reason) { :mentioned }
let(:notification_read_ian) { false }
let(:notification_mail_reminder_sent) { false }
@@ -57,45 +57,45 @@
let(:contract) { described_class.new(notification, current_user) }
- describe '#validation' do
- it_behaves_like 'contract is valid'
+ describe "#validation" do
+ it_behaves_like "contract is valid"
- context 'without a recipient' do
+ context "without a recipient" do
let(:notification_recipient) { nil }
- it_behaves_like 'contract is invalid', recipient: :blank
+ it_behaves_like "contract is invalid", recipient: :blank
end
- context 'without a reason' do
+ context "without a reason" do
let(:notification_reason) { nil }
- it_behaves_like 'contract is invalid', reason: :no_notification_reason
+ it_behaves_like "contract is invalid", reason: :no_notification_reason
end
- context 'without a subject' do
+ context "without a subject" do
let(:notification_subject) { nil }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'with an empty subject' do
- let(:notification_subject) { '' }
+ context "with an empty subject" do
+ let(:notification_subject) { "" }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'with read_ian true' do
+ context "with read_ian true" do
let(:notification_read_ian) { true }
- it_behaves_like 'contract is invalid', read_ian: :read_on_creation
+ it_behaves_like "contract is invalid", read_ian: :read_on_creation
end
- context 'with mail_reminder_sent true' do
+ context "with mail_reminder_sent true" do
let(:notification_mail_reminder_sent) { true }
- it_behaves_like 'contract is invalid', mail_reminder_sent: :set_on_creation
+ it_behaves_like "contract is invalid", mail_reminder_sent: :set_on_creation
end
end
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
diff --git a/spec/contracts/oauth_clients/create_contract_spec.rb b/spec/contracts/oauth_clients/create_contract_spec.rb
index 02a44a899f10..69999601333e 100644
--- a/spec/contracts/oauth_clients/create_contract_spec.rb
+++ b/spec/contracts/oauth_clients/create_contract_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require 'contracts/shared/model_contract_shared_context'
+require "contracts/shared/model_contract_shared_context"
RSpec.describe OAuthClients::CreateContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:current_user) { create(:admin) }
let(:client_id) { "1234567889" }
@@ -43,57 +43,57 @@
let(:contract) { described_class.new(oauth_client, current_user) }
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
- describe 'validations' do
- context 'when all attributes are valid' do
- include_examples 'contract is valid'
+ describe "validations" do
+ context "when all attributes are valid" do
+ include_examples "contract is valid"
end
%i[client_id client_secret].each do |attribute_name|
- context 'when client_id is invalid' do
- context 'as it is too long' do
- let(attribute_name) { 'X' * 257 }
+ context "when client_id is invalid" do
+ context "as it is too long" do
+ let(attribute_name) { "X" * 257 }
- include_examples 'contract is invalid', attribute_name => :too_long
+ include_examples "contract is invalid", attribute_name => :too_long
end
- context 'as it is empty' do
- let(attribute_name) { '' }
+ context "as it is empty" do
+ let(attribute_name) { "" }
- include_examples 'contract is invalid', attribute_name => :blank
+ include_examples "contract is invalid", attribute_name => :blank
end
- context 'as it is nil' do
+ context "as it is nil" do
let(attribute_name) { nil }
- include_examples 'contract is invalid', attribute_name => :blank
+ include_examples "contract is invalid", attribute_name => :blank
end
end
end
- context 'with blank client ID' do
- let(:client_id) { '' }
+ context "with blank client ID" do
+ let(:client_id) { "" }
- it 'is invalid' do
+ it "is invalid" do
expect(contract).not_to be_valid
expect(contract.errors[:client_id]).to eq(["can't be blank."])
end
end
- context 'with integration (polymorphic attribute) linked' do
+ context "with integration (polymorphic attribute) linked" do
let(:integration) { create(:nextcloud_storage) }
- include_examples 'contract is valid'
+ include_examples "contract is valid"
end
- context 'without integration (polymorphic attribute)' do
+ context "without integration (polymorphic attribute)" do
let(:integration) { nil }
- include_examples 'contract is invalid', { integration_id: :blank, integration_type: :blank }
+ include_examples "contract is invalid", { integration_id: :blank, integration_type: :blank }
end
end
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
diff --git a/spec/contracts/oauth_clients/delete_contract_spec.rb b/spec/contracts/oauth_clients/delete_contract_spec.rb
index bc3e0e423c35..7f2f0666dfda 100644
--- a/spec/contracts/oauth_clients/delete_contract_spec.rb
+++ b/spec/contracts/oauth_clients/delete_contract_spec.rb
@@ -26,22 +26,22 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
require_module_spec_helper
-require 'contracts/shared/model_contract_shared_context'
+require "contracts/shared/model_contract_shared_context"
# This DeleteContract spec just tests if the user is _allowed_
# to execute the operation.
RSpec.describe OAuthClients::DeleteContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:oauth_client) { create(:oauth_client) }
let(:contract) { described_class.new(oauth_client, current_user) }
# Generic checks that the contract is valid for valid admin, but invalid otherwise
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
- include_examples 'contract reuses the model errors' do
+ include_examples "contract reuses the model errors" do
let(:current_user) { build_stubbed(:admin) }
end
end
diff --git a/spec/contracts/placeholder_users/create_contract_spec.rb b/spec/contracts/placeholder_users/create_contract_spec.rb
index 5c97854159be..76c4e4d1611e 100644
--- a/spec/contracts/placeholder_users/create_contract_spec.rb
+++ b/spec/contracts/placeholder_users/create_contract_spec.rb
@@ -26,31 +26,31 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe PlaceholderUsers::CreateContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
- context 'without enterprise' do
- let(:placeholder_user) { PlaceholderUser.new(name: 'foo') }
+ context "without enterprise" do
+ let(:placeholder_user) { PlaceholderUser.new(name: "foo") }
let(:contract) { described_class.new(placeholder_user, current_user) }
- context 'when user with global permission' do
+ context "when user with global permission" do
let(:current_user) { create(:user, global_permissions: %i[manage_placeholder_user]) }
- it_behaves_like 'contract is invalid', base: :error_enterprise_only
+ it_behaves_like "contract is invalid", base: :error_enterprise_only
end
- context 'when user with admin permission' do
+ context "when user with admin permission" do
let(:current_user) { build_stubbed(:admin) }
- it_behaves_like 'contract is invalid', base: :error_enterprise_only
+ it_behaves_like "contract is invalid", base: :error_enterprise_only
end
end
- context 'with enterprise', with_ee: %i[placeholder_users] do
- it_behaves_like 'placeholder user contract' do
+ context "with enterprise", with_ee: %i[placeholder_users] do
+ it_behaves_like "placeholder user contract" do
let(:placeholder_user) { PlaceholderUser.new(name: placeholder_user_name) }
let(:contract) { described_class.new(placeholder_user, current_user) }
end
diff --git a/spec/contracts/placeholder_users/delete_contract_spec.rb b/spec/contracts/placeholder_users/delete_contract_spec.rb
index 5f48d5c5186f..2d67edfe69e5 100644
--- a/spec/contracts/placeholder_users/delete_contract_spec.rb
+++ b/spec/contracts/placeholder_users/delete_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe PlaceholderUsers::DeleteContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:placeholder_user) { create(:placeholder_user) }
let(:role) { create(:existing_project_role, permissions: [:manage_members]) }
@@ -38,29 +38,29 @@
let(:not_shared_project) { create(:project, members: { placeholder_user => role }) }
let(:contract) { described_class.new(placeholder_user, current_user) }
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
- context 'when user with global permission to manage_placeholders' do
+ context "when user with global permission to manage_placeholders" do
let(:current_user) { create(:user, global_permissions: %i[manage_placeholder_user]) }
before do
shared_project
end
- context 'when user is allowed to manage members in all projects of the placeholder user' do
- it_behaves_like 'contract is valid'
+ context "when user is allowed to manage members in all projects of the placeholder user" do
+ it_behaves_like "contract is valid"
end
- context 'when user is not allowed to manage members in all projects of the placeholder user' do
+ context "when user is not allowed to manage members in all projects of the placeholder user" do
before do
not_shared_project
end
- it_behaves_like 'contract user is unauthorized'
+ it_behaves_like "contract user is unauthorized"
end
end
- include_examples 'contract reuses the model errors' do
+ include_examples "contract reuses the model errors" do
let(:current_user) { build_stubbed(:admin) }
end
end
diff --git a/spec/contracts/placeholder_users/shared_contract_examples.rb b/spec/contracts/placeholder_users/shared_contract_examples.rb
index 86bf396358e4..15507f1911c1 100644
--- a/spec/contracts/placeholder_users/shared_contract_examples.rb
+++ b/spec/contracts/placeholder_users/shared_contract_examples.rb
@@ -26,61 +26,61 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
-RSpec.shared_examples_for 'placeholder user contract' do
- let(:placeholder_user_name) { 'UX Designer' }
+RSpec.shared_examples_for "placeholder user contract" do
+ let(:placeholder_user_name) { "UX Designer" }
- context 'when user with global permission' do
+ context "when user with global permission" do
let(:current_user) { create(:user, global_permissions: %i[manage_placeholder_user]) }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
- describe 'validations' do
+ describe "validations" do
let(:current_user) { build_stubbed(:admin) }
- context 'name' do
- context 'is valid' do
- it_behaves_like 'contract is valid'
+ context "name" do
+ context "is valid" do
+ it_behaves_like "contract is valid"
end
- context 'is not too long' do
- let(:placeholder_user) { PlaceholderUser.new(name: 'X' * 257) }
+ context "is not too long" do
+ let(:placeholder_user) { PlaceholderUser.new(name: "X" * 257) }
- it_behaves_like 'contract is invalid'
+ it_behaves_like "contract is invalid"
end
- context 'is not empty' do
- let(:placeholder_user) { PlaceholderUser.new(name: '') }
+ context "is not empty" do
+ let(:placeholder_user) { PlaceholderUser.new(name: "") }
- it_behaves_like 'contract is invalid'
+ it_behaves_like "contract is invalid"
end
- context 'is unique' do
+ context "is unique" do
before do
PlaceholderUser.create(name: placeholder_user_name)
end
- it_behaves_like 'contract is invalid'
+ it_behaves_like "contract is invalid"
end
end
- describe 'type' do
- context 'type and class mismatch' do
+ describe "type" do
+ context "type and class mismatch" do
before do
placeholder_user.type = User.name
end
- it_behaves_like 'contract is invalid'
+ it_behaves_like "contract is invalid"
end
end
end
- include_examples 'contract reuses the model errors' do
+ include_examples "contract reuses the model errors" do
let(:current_user) { build_stubbed(:admin) }
end
end
diff --git a/spec/contracts/placeholder_users/update_contract_spec.rb b/spec/contracts/placeholder_users/update_contract_spec.rb
index 7a6cd7d25c47..6c078df4d534 100644
--- a/spec/contracts/placeholder_users/update_contract_spec.rb
+++ b/spec/contracts/placeholder_users/update_contract_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe PlaceholderUsers::UpdateContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
- it_behaves_like 'placeholder user contract' do
+ it_behaves_like "placeholder user contract" do
let(:placeholder_user) { build_stubbed(:placeholder_user, name: placeholder_user_name) }
let(:contract) { described_class.new(placeholder_user, current_user) }
end
diff --git a/spec/contracts/projects/archive_contract_spec.rb b/spec/contracts/projects/archive_contract_spec.rb
index 1c5052d70e99..bf9f765d7c79 100644
--- a/spec/contracts/projects/archive_contract_spec.rb
+++ b/spec/contracts/projects/archive_contract_spec.rb
@@ -26,82 +26,82 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe Projects::ArchiveContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
shared_let(:archivist_role) { create(:project_role, permissions: %i[archive_project]) }
let(:project) { build_stubbed(:project) }
let(:contract) { described_class.new(project, current_user) }
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
- context 'when user has archive_project permission' do
+ context "when user has archive_project permission" do
let(:project) { create(:project) }
let(:current_user) { create(:user, member_with_roles: { project => archivist_role }) }
- include_examples 'contract is valid'
+ include_examples "contract is valid"
end
- context 'with subprojects' do
+ context "with subprojects" do
shared_let(:subproject1) { create(:project) }
shared_let(:subproject2) { create(:project) }
shared_let(:project) { create(:project, children: [subproject1, subproject2]) }
shared_let(:current_user) { create(:user, member_with_roles: { project => archivist_role }) }
- shared_examples 'with archive_project permission on all/some/none of subprojects' do
- context 'when user does not have archive_project permission on any subprojects' do
- include_examples 'contract is invalid', base: :archive_permission_missing_on_subprojects
+ shared_examples "with archive_project permission on all/some/none of subprojects" do
+ context "when user does not have archive_project permission on any subprojects" do
+ include_examples "contract is invalid", base: :archive_permission_missing_on_subprojects
end
- context 'when user has archive_project permission on some subprojects but not all' do
+ context "when user has archive_project permission on some subprojects but not all" do
before do
create(:member, user: current_user, project: subproject1, roles: [archivist_role])
end
- include_examples 'contract is invalid', base: :archive_permission_missing_on_subprojects
+ include_examples "contract is invalid", base: :archive_permission_missing_on_subprojects
end
- context 'when user has archive_project permission on all subprojects' do
+ context "when user has archive_project permission on all subprojects" do
before do
create(:member, user: current_user, project: subproject1, roles: [archivist_role])
create(:member, user: current_user, project: subproject2, roles: [archivist_role])
end
- include_examples 'contract is valid'
+ include_examples "contract is valid"
end
- context 'when some of subprojects are archived but not all' do
+ context "when some of subprojects are archived but not all" do
before do
subproject1.update_column(:active, false)
create(:member, user: current_user, project: subproject2, roles: [archivist_role])
end
- include_examples 'contract is valid'
+ include_examples "contract is valid"
end
- context 'when all of subprojects are archived' do
+ context "when all of subprojects are archived" do
before do
subproject1.update_column(:active, false)
subproject2.update_column(:active, false)
end
- include_examples 'contract is valid'
+ include_examples "contract is valid"
end
end
- include_examples 'contract is valid for active admins and invalid for regular users'
- include_examples 'with archive_project permission on all/some/none of subprojects'
+ include_examples "contract is valid for active admins and invalid for regular users"
+ include_examples "with archive_project permission on all/some/none of subprojects"
- context 'with deep nesting' do
+ context "with deep nesting" do
before do
subproject2.update(parent: subproject1)
end
- include_examples 'contract is valid for active admins and invalid for regular users'
- include_examples 'with archive_project permission on all/some/none of subprojects'
+ include_examples "contract is valid for active admins and invalid for regular users"
+ include_examples "with archive_project permission on all/some/none of subprojects"
end
end
end
diff --git a/spec/contracts/projects/base_contract_spec.rb b/spec/contracts/projects/base_contract_spec.rb
index 6febab49348f..679e42bc31e0 100644
--- a/spec/contracts/projects/base_contract_spec.rb
+++ b/spec/contracts/projects/base_contract_spec.rb
@@ -26,16 +26,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Projects::BaseContract do
- let(:project) { Project.new(name: 'Foo', identifier: 'foo', templated: false) }
+ let(:project) { Project.new(name: "Foo", identifier: "foo", templated: false) }
let(:contract) { described_class.new(project, current_user) }
subject { contract.validate }
- describe 'templated attribute' do
+ describe "templated attribute" do
before do
# Assume the user may manage the project
allow(contract)
@@ -47,18 +47,18 @@
expect(project.templated_changed?).to be true
end
- context 'as admin' do
+ context "as admin" do
let(:current_user) { build_stubbed(:admin) }
- it 'validates the contract' do
+ it "validates the contract" do
expect(subject).to be true
end
end
- context 'as regular user' do
+ context "as regular user" do
let(:current_user) { build_stubbed(:user) }
- it 'returns an error on validation' do
+ it "returns an error on validation" do
expect(subject).to be false
expect(contract.errors.symbols_for(:templated))
.to contain_exactly(:error_unauthorized)
diff --git a/spec/contracts/projects/create_contract_spec.rb b/spec/contracts/projects/create_contract_spec.rb
index ed6be8f5d485..dc31da93c078 100644
--- a/spec/contracts/projects/create_contract_spec.rb
+++ b/spec/contracts/projects/create_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Projects::CreateContract do
- it_behaves_like 'project contract' do
+ it_behaves_like "project contract" do
let(:project) do
Project.new(name: project_name,
identifier: project_identifier,
@@ -48,10 +48,10 @@
subject(:contract) { described_class.new(project, current_user) }
- context 'if the identifier is nil' do
+ context "if the identifier is nil" do
let(:project_identifier) { nil }
- it 'is replaced for new project' do
+ it "is replaced for new project" do
expect_valid(true)
end
end
@@ -72,7 +72,7 @@
it_behaves_like "can not write", :updated_at, 1.day.ago
it "can write created_at", :aggregate_failures do
- expect(contract.writable_attributes).to include('created_at')
+ expect(contract.writable_attributes).to include("created_at")
project.created_at = 10.days.ago
expect(validated_contract.errors[attribute]).to be_empty
diff --git a/spec/contracts/projects/delete_contract_spec.rb b/spec/contracts/projects/delete_contract_spec.rb
index a60a786c3cec..a33d84e90716 100644
--- a/spec/contracts/projects/delete_contract_spec.rb
+++ b/spec/contracts/projects/delete_contract_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe Projects::DeleteContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:project) { build_stubbed(:project) }
let(:contract) { described_class.new(project, current_user) }
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
end
diff --git a/spec/contracts/projects/enabled_modules_contract_spec.rb b/spec/contracts/projects/enabled_modules_contract_spec.rb
index a525d67476b0..35a8de068259 100644
--- a/spec/contracts/projects/enabled_modules_contract_spec.rb
+++ b/spec/contracts/projects/enabled_modules_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe Projects::EnabledModulesContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:project) { build_stubbed(:project, enabled_module_names: enabled_modules) }
let(:enabled_modules) { %i[a_module b_module] }
@@ -50,19 +50,19 @@
allow(I18n).to receive(:t).with("project_module_b_module").and_return("B Module")
end
- describe '#valid?' do
- it_behaves_like 'contract is valid'
+ describe "#valid?" do
+ it_behaves_like "contract is valid"
- context 'when the dependencies are not met' do
+ context "when the dependencies are not met" do
let(:enabled_modules) { %i[a_module] }
- it_behaves_like 'contract is invalid', enabled_modules: :dependency_missing
+ it_behaves_like "contract is invalid", enabled_modules: :dependency_missing
end
- context 'when the user lacks the select_project_modules permission' do
+ context "when the user lacks the select_project_modules permission" do
let(:permissions) { %i[] }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
end
end
diff --git a/spec/contracts/projects/shared_contract_examples.rb b/spec/contracts/projects/shared_contract_examples.rb
index bc18c9904749..be680d01a77b 100644
--- a/spec/contracts/projects/shared_contract_examples.rb
+++ b/spec/contracts/projects/shared_contract_examples.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.shared_examples_for 'project contract' do
+RSpec.shared_examples_for "project contract" do
let(:current_user) { build_stubbed(:user) }
before do
@@ -40,20 +40,20 @@
let(:project_permissions) { [] }
let(:global_permissions) { [] }
- let(:project_name) { 'Project name' }
- let(:project_identifier) { 'project_identifier' }
- let(:project_description) { 'Project description' }
+ let(:project_name) { "Project name" }
+ let(:project_identifier) { "project_identifier" }
+ let(:project_description) { "Project description" }
let(:project_active) { true }
let(:project_public) { true }
- let(:project_status_code) { 'on_track' }
- let(:project_status_explanation) { 'some explanation' }
+ let(:project_status_code) { "on_track" }
+ let(:project_status_explanation) { "some explanation" }
let(:project_parent) do
build_stubbed(:project)
end
let(:parent_assignable) { true }
let!(:assignable_parents) do
- assignable_parents_scope = double('assignable parents scope')
- assignable_parents = double('assignable parents')
+ assignable_parents_scope = double("assignable parents scope")
+ assignable_parents = double("assignable parents")
allow(Project)
.to receive(:allowed_to)
@@ -91,165 +91,165 @@ def expect_valid(valid, symbols = {})
end
end
- shared_examples 'is valid' do
- it 'is valid' do
+ shared_examples "is valid" do
+ it "is valid" do
expect_valid(true)
end
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
- context 'if the name is nil' do
+ context "if the name is nil" do
let(:project_name) { nil }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, name: %i(blank))
end
end
- context 'if the description is nil' do
+ context "if the description is nil" do
let(:project_description) { nil }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if the parent is nil' do
+ context "if the parent is nil" do
let(:project_parent) { nil }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if the parent is not in the set of assignable_parents' do
+ context "if the parent is not in the set of assignable_parents" do
let(:parent_assignable) { false }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, parent: %i(does_not_exist))
end
end
- context 'if active is nil' do
+ context "if active is nil" do
let(:project_active) { nil }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, active: %i(blank))
end
end
- context 'if status code is nil' do
+ context "if status code is nil" do
let(:project_status_code) { nil }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if status explanation is nil' do
+ context "if status explanation is nil" do
let(:project_status_explanation) { nil }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if status code is invalid' do
+ context "if status code is invalid" do
before do
# Hack in order to handle setting an Enum value without raising an
# ArgumentError and letting the Contract perform the validation.
#
# This is the behavior that would be expected to be performed by
# the SetAttributesService at that layer of the flow.
- bogus_project_status_code = 'bogus'
- code_attributes = project.instance_variable_get(:@attributes)['status_code']
+ bogus_project_status_code = "bogus"
+ code_attributes = project.instance_variable_get(:@attributes)["status_code"]
code_attributes.instance_variable_set(:@value_before_type_cast, bogus_project_status_code)
code_attributes.instance_variable_set(:@value, bogus_project_status_code)
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, status: %i(inclusion))
end
end
- context 'when the identifier consists of only letters' do
- let(:project_identifier) { 'abc' }
+ context "when the identifier consists of only letters" do
+ let(:project_identifier) { "abc" }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'when the identifier consists of letters followed by numbers' do
- let(:project_identifier) { 'abc12' }
+ context "when the identifier consists of letters followed by numbers" do
+ let(:project_identifier) { "abc12" }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'when the identifier consists of letters followed by numbers with a hyphen in between' do
- let(:project_identifier) { 'abc-12' }
+ context "when the identifier consists of letters followed by numbers with a hyphen in between" do
+ let(:project_identifier) { "abc-12" }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'when the identifier consists of letters followed by numbers with an underscore in between' do
- let(:project_identifier) { 'abc_12' }
+ context "when the identifier consists of letters followed by numbers with an underscore in between" do
+ let(:project_identifier) { "abc_12" }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'when the identifier consists of numbers followed by letters with a hyphen in between' do
- let(:project_identifier) { '12-abc' }
+ context "when the identifier consists of numbers followed by letters with a hyphen in between" do
+ let(:project_identifier) { "12-abc" }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'when the identifier consists of numbers followed by letters with an underscore in between' do
- let(:project_identifier) { '12_abc' }
+ context "when the identifier consists of numbers followed by letters with an underscore in between" do
+ let(:project_identifier) { "12_abc" }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'when the identifier consists of only numbers' do
- let(:project_identifier) { '12' }
+ context "when the identifier consists of only numbers" do
+ let(:project_identifier) { "12" }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, identifier: %i(invalid))
end
end
- context 'when the identifier consists of a reserved word' do
- let(:project_identifier) { 'new' }
+ context "when the identifier consists of a reserved word" do
+ let(:project_identifier) { "new" }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, identifier: %i(exclusion))
end
end
- context 'if the user lacks permission' do
+ context "if the user lacks permission" do
let(:global_permissions) { [] }
let(:project_permissions) { [] }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, base: %i(error_unauthorized))
end
end
- describe 'assignable_values' do
- context 'for project' do
+ describe "assignable_values" do
+ context "for project" do
before do
assignable_parents
end
- it 'returns all projects the user has the add_subprojects permissions for' do
+ it "returns all projects the user has the add_subprojects permissions for" do
expect(contract.assignable_parents)
.to eql assignable_parents
end
end
- context 'for a list custom field' do
+ context "for a list custom field" do
let(:custom_field) { build_stubbed(:list_project_custom_field) }
- it 'is the list of custom field values' do
+ it "is the list of custom field values" do
expect(subject.assignable_custom_field_values(custom_field))
.to eql custom_field.possible_values
end
end
- context 'for a version custom field' do
+ context "for a version custom field" do
let(:custom_field) { build_stubbed(:version_project_custom_field) }
- let(:versions) { double('versions') }
+ let(:versions) { double("versions") }
before do
allow(project)
@@ -257,14 +257,14 @@ def expect_valid(valid, symbols = {})
.and_return(versions)
end
- it 'is the list of versions for the project' do
+ it "is the list of versions for the project" do
expect(subject.assignable_custom_field_values(custom_field))
.to eql versions
end
end
end
- describe 'available_custom_fields' do
+ describe "available_custom_fields" do
let(:visible_custom_field) { build_stubbed(:integer_project_custom_field, visible: true) }
let(:invisible_custom_field) { build_stubbed(:integer_project_custom_field, visible: false) }
@@ -274,21 +274,21 @@ def expect_valid(valid, symbols = {})
.and_return([visible_custom_field, invisible_custom_field])
end
- context 'if the user is admin' do
+ context "if the user is admin" do
before do
allow(current_user)
.to receive(:admin?)
.and_return(true)
end
- it 'returns all available_custom_fields of the project' do
+ it "returns all available_custom_fields of the project" do
expect(subject.available_custom_fields)
.to contain_exactly(visible_custom_field, invisible_custom_field)
end
end
- context 'if the user is no admin' do
- it 'returns all visible and available_custom_fields of the project' do
+ context "if the user is no admin" do
+ it "returns all visible and available_custom_fields of the project" do
expect(subject.available_custom_fields)
.to contain_exactly(visible_custom_field)
end
diff --git a/spec/contracts/projects/unarchive_contract_spec.rb b/spec/contracts/projects/unarchive_contract_spec.rb
index 82661cd1341c..6cb59bdf68c8 100644
--- a/spec/contracts/projects/unarchive_contract_spec.rb
+++ b/spec/contracts/projects/unarchive_contract_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe Projects::UnarchiveContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:project) { build_stubbed(:project) }
let(:contract) { described_class.new(project, current_user) }
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
end
diff --git a/spec/contracts/projects/update_contract_spec.rb b/spec/contracts/projects/update_contract_spec.rb
index 5e427df6e41e..6259841b68c8 100644
--- a/spec/contracts/projects/update_contract_spec.rb
+++ b/spec/contracts/projects/update_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Projects::UpdateContract do
- it_behaves_like 'project contract' do
+ it_behaves_like "project contract" do
let(:project) do
build_stubbed(:project,
active: project_active,
@@ -47,10 +47,10 @@
subject(:contract) { described_class.new(project, current_user) }
- context 'if the identifier is nil' do
+ context "if the identifier is nil" do
let(:project_identifier) { nil }
- it 'is replaced for new project' do
+ it "is replaced for new project" do
expect_valid(false, identifier: %i(blank))
end
end
diff --git a/spec/contracts/queries/base_contract_spec.rb b/spec/contracts/queries/base_contract_spec.rb
index c950011e502c..9b1b6c0ab7a8 100644
--- a/spec/contracts/queries/base_contract_spec.rb
+++ b/spec/contracts/queries/base_contract_spec.rb
@@ -26,85 +26,85 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Queries::BaseContract do
- include_context 'with queries contract'
+ include_context "with queries contract"
- describe 'timestamps' do
+ describe "timestamps" do
let(:query) { build_stubbed(:query, timestamps:) }
- context 'with EE', with_ee: %i[baseline_comparison] do
+ context "with EE", with_ee: %i[baseline_comparison] do
Timestamp::ALLOWED_DATE_KEYWORDS.each do |timestamp_date_keyword|
context "when the '#{timestamp_date_keyword}' value is provided" do
let(:timestamps) { ["#{timestamp_date_keyword}@12:00+00:00"] }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
end
context "when the shortcut value 'now' is provided" do
let(:timestamps) { ["now"] }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
context "when a duration value is provided" do
let(:timestamps) { ["P-2D"] }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
context "when an iso8601 datetime value is provided" do
let(:timestamps) { [1.week.ago.iso8601] }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
end
- context 'without EE', with_ee: false do
+ context "without EE", with_ee: false do
context "when the 'oneDayAgo' value is provided" do
let(:timestamps) { ["oneDayAgo@12:00+00:00"] }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
context "when the shortcut value 'now' is provided" do
let(:timestamps) { ["now"] }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
context "when the 'PT0S' duration value is provided" do
let(:timestamps) { ["PT0S"] }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
context "when the 'P-1D' duration value is provided" do
let(:timestamps) { ["P-1D"] }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
context "when an iso8601 datetime value from yesterday is provided" do
let(:timestamps) { [1.day.ago.beginning_of_day.iso8601] }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
context "when the 'lastWorkingDay' value is provided and it's yesterday" do
let(:timestamps) { "lastWorkingDay@00:00+00:00" }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
Timestamp::ALLOWED_DATE_KEYWORDS[2..].each do |timestamp_date_keyword|
context "when the '#{timestamp_date_keyword}' value is provided" do
let(:timestamps) { ["#{timestamp_date_keyword}@12:00+00:00"] }
- it_behaves_like 'contract is invalid', timestamps: :forbidden
+ it_behaves_like "contract is invalid", timestamps: :forbidden
end
end
@@ -115,19 +115,19 @@
allow(Day).to receive(:last_working) { Day.new(date: 7.days.ago) }
end
- it_behaves_like 'contract is invalid', timestamps: :forbidden
+ it_behaves_like "contract is invalid", timestamps: :forbidden
end
context "when a duration value older than yesterday is provided" do
let(:timestamps) { ["P-2D"] }
- it_behaves_like 'contract is invalid', timestamps: :forbidden
+ it_behaves_like "contract is invalid", timestamps: :forbidden
end
context "when an iso8601 datetime value older than yesterday is provided" do
let(:timestamps) { [2.days.ago.end_of_day.iso8601] }
- it_behaves_like 'contract is invalid', timestamps: :forbidden
+ it_behaves_like "contract is invalid", timestamps: :forbidden
end
end
end
diff --git a/spec/contracts/queries/create_contract_spec.rb b/spec/contracts/queries/create_contract_spec.rb
index 36b80d8e6d17..09ca9bafb2d5 100644
--- a/spec/contracts/queries/create_contract_spec.rb
+++ b/spec/contracts/queries/create_contract_spec.rb
@@ -26,35 +26,35 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Queries::CreateContract do
- include_context 'with queries contract'
+ include_context "with queries contract"
- describe 'include subprojects' do
+ describe "include subprojects" do
let(:query) do
- Query.new name: 'foo',
+ Query.new name: "foo",
include_subprojects:,
project:
end
- context 'when true' do
+ context "when true" do
let(:include_subprojects) { true }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'when false' do
+ context "when false" do
let(:include_subprojects) { false }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'when nil' do
+ context "when nil" do
let(:include_subprojects) { nil }
- it_behaves_like 'contract is invalid', include_subprojects: %i[inclusion]
+ it_behaves_like "contract is invalid", include_subprojects: %i[inclusion]
end
end
end
diff --git a/spec/contracts/queries/global_create_contract_spec.rb b/spec/contracts/queries/global_create_contract_spec.rb
index 0036af9f8b01..eff721e69a53 100644
--- a/spec/contracts/queries/global_create_contract_spec.rb
+++ b/spec/contracts/queries/global_create_contract_spec.rb
@@ -28,17 +28,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/queries/shared_contract_examples'
+require "spec_helper"
+require "contracts/queries/shared_contract_examples"
RSpec.describe Queries::GlobalCreateContract do
- include_context 'with queries contract'
+ include_context "with queries contract"
- describe 'validation' do
- context 'if the project_id is nil' do
+ describe "validation" do
+ context "if the project_id is nil" do
let(:project) { nil }
- it_behaves_like 'contract is invalid', project_id: :blank
+ it_behaves_like "contract is invalid", project_id: :blank
end
end
end
diff --git a/spec/contracts/queries/ical_sharing_contract_spec.rb b/spec/contracts/queries/ical_sharing_contract_spec.rb
index 0637f6d42803..4e58fa7356ea 100644
--- a/spec/contracts/queries/ical_sharing_contract_spec.rb
+++ b/spec/contracts/queries/ical_sharing_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe Queries::ICalSharingContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
# using `create` approach here as many underlying checks base on
# real database checks which should not be mocked
@@ -50,96 +50,96 @@
# override as this contract additionally needs the ical_token
let(:contract) { described_class.new(query, current_user, options: { ical_token: }) }
- describe 'private query' do
+ describe "private query" do
let(:public) { false }
- context 'when user is author', with_settings: { ical_enabled: true } do
+ context "when user is author", with_settings: { ical_enabled: true } do
let(:user) { current_user }
- context 'when user has no permission to share via ical' do
+ context "when user has no permission to share via ical" do
let(:permissions) { %i(view_work_packages view_calendar manage_calendars) }
- it_behaves_like 'contract user is unauthorized'
+ it_behaves_like "contract user is unauthorized"
end
- context 'when user has permission to share via' do
+ context "when user has permission to share via" do
let(:permissions) { %i(view_work_packages share_calendars) }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
- context 'when iCalendar subscriptions are globally disabled', with_settings: { ical_enabled: false } do
- it_behaves_like 'contract user is unauthorized'
+ context "when iCalendar subscriptions are globally disabled", with_settings: { ical_enabled: false } do
+ it_behaves_like "contract user is unauthorized"
end
end
- context 'when ical_token is not scoped to query' do
+ context "when ical_token is not scoped to query" do
let(:other_query) do
create(:query, project:, public:, user:)
end
let(:ical_token) { create(:ical_token, query: other_query, user: current_user, name: "Some Token") }
- context 'when user has no permission to share via ical' do
+ context "when user has no permission to share via ical" do
let(:permissions) { %i(view_work_packages view_calendar manage_calendars) }
- it_behaves_like 'contract user is unauthorized'
+ it_behaves_like "contract user is unauthorized"
end
- context 'when user has permission to share via ical' do
+ context "when user has permission to share via ical" do
let(:permissions) { %i(view_work_packages share_calendars) }
- it_behaves_like 'contract user is unauthorized'
+ it_behaves_like "contract user is unauthorized"
end
end
end
- context 'when author is someone else', with_settings: { ical_enabled: true } do
+ context "when author is someone else", with_settings: { ical_enabled: true } do
let(:user) { create(:user) } # other user as owner of query
let(:permissions) { %i(view_work_packages share_calendars) } # all necessary permissions
- it_behaves_like 'contract user is unauthorized' # unauthorized as user is not author
+ it_behaves_like "contract user is unauthorized" # unauthorized as user is not author
end
end
- describe 'public query' do
+ describe "public query" do
let(:public) { true }
let(:user) { current_user }
- context 'when user has no permission to share via ical', with_settings: { ical_enabled: true } do
+ context "when user has no permission to share via ical", with_settings: { ical_enabled: true } do
let(:permissions) { %i(view_work_packages view_calendar manage_calendars) }
- it_behaves_like 'contract user is unauthorized'
+ it_behaves_like "contract user is unauthorized"
- context 'when author is someone else' do
+ context "when author is someone else" do
let(:user) { create(:user) } # other user as owner of query
- it_behaves_like 'contract user is unauthorized' # authorized as query is public
+ it_behaves_like "contract user is unauthorized" # authorized as query is public
end
end
- context 'when user has permission to share via ical', with_settings: { ical_enabled: true } do
+ context "when user has permission to share via ical", with_settings: { ical_enabled: true } do
let(:permissions) { %i(view_work_packages share_calendars) }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
- context 'when author is someone else' do
+ context "when author is someone else" do
let(:user) { create(:user) } # other user as owner of query
- it_behaves_like 'contract is valid' # authorized as query is public
+ it_behaves_like "contract is valid" # authorized as query is public
end
- context 'when iCalendar subscriptions are globally disabled', with_settings: { ical_enabled: false } do
- it_behaves_like 'contract user is unauthorized'
+ context "when iCalendar subscriptions are globally disabled", with_settings: { ical_enabled: false } do
+ it_behaves_like "contract user is unauthorized"
- context 'when author is someone else' do
+ context "when author is someone else" do
let(:user) { create(:user) } # other user as owner of query
- it_behaves_like 'contract user is unauthorized'
+ it_behaves_like "contract user is unauthorized"
end
end
end
end
- describe 'project membership' do
+ describe "project membership" do
let(:public) { false }
let(:other_project) { create(:project) }
let(:current_user) do
@@ -147,16 +147,16 @@
member_with_permissions: { other_project => permissions })
end
- context 'when user is author but not member of project (anymore)', with_settings: { ical_enabled: true } do
+ context "when user is author but not member of project (anymore)", with_settings: { ical_enabled: true } do
let(:user) { current_user }
- context 'when user has no permission to share via ical' do
+ context "when user has no permission to share via ical" do
let(:permissions) { %i(view_work_packages view_calendar manage_calendars) }
- it_behaves_like 'contract user is unauthorized'
+ it_behaves_like "contract user is unauthorized"
end
end
end
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
diff --git a/spec/contracts/queries/projects/project_queries/create_contract_spec.rb b/spec/contracts/queries/projects/project_queries/create_contract_spec.rb
index 6b56f3cfe076..ec9466424cfd 100644
--- a/spec/contracts/queries/projects/project_queries/create_contract_spec.rb
+++ b/spec/contracts/queries/projects/project_queries/create_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Queries::Projects::ProjectQueries::CreateContract do
- it_behaves_like 'project queries contract' do
+ it_behaves_like "project queries contract" do
let(:query) do
Queries::Projects::ProjectQuery.new(name: query_name).tap do |query|
query.extend(OpenProject::ChangedBySystem)
diff --git a/spec/contracts/queries/projects/project_queries/delete_contract_spec.rb b/spec/contracts/queries/projects/project_queries/delete_contract_spec.rb
index 7195d530aa9f..2b7047e0a78c 100644
--- a/spec/contracts/queries/projects/project_queries/delete_contract_spec.rb
+++ b/spec/contracts/queries/projects/project_queries/delete_contract_spec.rb
@@ -28,22 +28,22 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe Queries::Projects::ProjectQueries::DeleteContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:current_user) { build_stubbed(:user) }
let(:query_user) { current_user }
let(:query) { build_stubbed(:project_query, user: query_user) }
let(:contract) { described_class.new(query, current_user) }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
- context 'if the current user is not the query user' do
+ context "if the current user is not the query user" do
let(:query_user) { build_stubbed(:user) }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
end
diff --git a/spec/contracts/queries/projects/project_queries/loading_contract_spec.rb b/spec/contracts/queries/projects/project_queries/loading_contract_spec.rb
index fc469506d000..7afe890ed826 100644
--- a/spec/contracts/queries/projects/project_queries/loading_contract_spec.rb
+++ b/spec/contracts/queries/projects/project_queries/loading_contract_spec.rb
@@ -26,17 +26,17 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe Queries::Projects::ProjectQueries::LoadingContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:current_user) { build_stubbed(:user) }
let(:query_user) { current_user }
- let(:query_filters) { [[:active, '=', 't']] }
+ let(:query_filters) { [[:active, "=", "t"]] }
let(:query_orders) { [%w[name asc]] }
- let(:query_columns) { ['name', 'public'] }
+ let(:query_columns) { ["name", "public"] }
let(:query) do
Queries::Projects::ProjectQuery.new do |query|
query_filters.each do |key, operator, values|
@@ -49,7 +49,7 @@
end
let(:contract) { described_class.new(query, current_user) }
- describe 'validation' do
- it_behaves_like 'contract is valid'
+ describe "validation" do
+ it_behaves_like "contract is valid"
end
end
diff --git a/spec/contracts/queries/projects/project_queries/shared_contract_examples.rb b/spec/contracts/queries/projects/project_queries/shared_contract_examples.rb
index 854316f71def..6a3315276f10 100644
--- a/spec/contracts/queries/projects/project_queries/shared_contract_examples.rb
+++ b/spec/contracts/queries/projects/project_queries/shared_contract_examples.rb
@@ -26,54 +26,54 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
-RSpec.shared_examples_for 'project queries contract' do
- include_context 'ModelContract shared context'
+RSpec.shared_examples_for "project queries contract" do
+ include_context "ModelContract shared context"
let(:current_user) { build_stubbed(:user) }
let(:query_name) { "Query name" }
let(:query_user) { current_user }
let(:query_selects) { %i[name project_status] }
- describe 'validation' do
- it_behaves_like 'contract is valid'
+ describe "validation" do
+ it_behaves_like "contract is valid"
- context 'if the name is nil' do
+ context "if the name is nil" do
let(:query_name) { nil }
- it_behaves_like 'contract is invalid', name: :blank
+ it_behaves_like "contract is invalid", name: :blank
end
- context 'if the name is too long' do
- let(:query_name) { 'A' * 256 }
+ context "if the name is too long" do
+ let(:query_name) { "A" * 256 }
- it_behaves_like 'contract is invalid', name: :too_long
+ it_behaves_like "contract is invalid", name: :too_long
end
- context 'if the user is not the current user' do
+ context "if the user is not the current user" do
let(:query_user) { build_stubbed(:user) }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
- context 'if the user and the current user is anonymous' do
+ context "if the user and the current user is anonymous" do
let(:current_user) { build_stubbed(:anonymous) }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
- context 'if the selects do not include the name column' do
+ context "if the selects do not include the name column" do
let(:query_selects) { %i[project_status] }
- it_behaves_like 'contract is invalid', selects: :name_not_included
+ it_behaves_like "contract is invalid", selects: :name_not_included
end
- context 'if the selects include a non existing one' do
+ context "if the selects include a non existing one" do
let(:query_selects) { %i[project_status name foo_bar] }
- it_behaves_like 'contract is invalid', selects: :nonexistent
+ it_behaves_like "contract is invalid", selects: :nonexistent
end
end
end
diff --git a/spec/contracts/queries/shared_contract_examples.rb b/spec/contracts/queries/shared_contract_examples.rb
index cd4590700388..0c57c4d2a686 100644
--- a/spec/contracts/queries/shared_contract_examples.rb
+++ b/spec/contracts/queries/shared_contract_examples.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
-RSpec.shared_context 'with queries contract' do
- include_context 'ModelContract shared context'
+RSpec.shared_context "with queries contract" do
+ include_context "ModelContract shared context"
let(:project) { build_stubbed(:project) }
- let(:name) { 'Some query name' }
+ let(:name) { "Some query name" }
let(:public) { false }
let(:user) { current_user }
let(:permissions) { %i[save_queries] }
@@ -56,21 +56,21 @@
allow(contract).to receive(:project_visible?).and_return true
end
- describe 'validation' do
- it_behaves_like 'contract is valid'
+ describe "validation" do
+ it_behaves_like "contract is valid"
- context 'if the name is nil' do
+ context "if the name is nil" do
let(:name) { nil }
- it_behaves_like 'contract is invalid', name: :blank
+ it_behaves_like "contract is invalid", name: :blank
end
- context 'if the name is empty' do
- let(:name) { '' }
+ context "if the name is empty" do
+ let(:name) { "" }
- it_behaves_like 'contract is invalid', name: :blank
+ it_behaves_like "contract is invalid", name: :blank
end
end
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
diff --git a/spec/contracts/queries/update_contract_spec.rb b/spec/contracts/queries/update_contract_spec.rb
index 4e657c17d502..1c65b1fd87dc 100644
--- a/spec/contracts/queries/update_contract_spec.rb
+++ b/spec/contracts/queries/update_contract_spec.rb
@@ -26,59 +26,59 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Queries::UpdateContract do
- include_context 'with queries contract'
+ include_context "with queries contract"
- describe 'private query' do
+ describe "private query" do
let(:public) { false }
- context 'when user is author' do
+ context "when user is author" do
let(:user) { current_user }
- context 'when user has no permission to save' do
+ context "when user has no permission to save" do
let(:permissions) { %i(edit_work_packages) }
- it_behaves_like 'contract user is unauthorized'
+ it_behaves_like "contract user is unauthorized"
end
- context 'when user has permission to save' do
+ context "when user has permission to save" do
let(:permissions) { %i(save_queries) }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
end
- context 'when user is someone else' do
+ context "when user is someone else" do
let(:user) { build_stubbed(:user) }
let(:permissions) { %i(save_queries) }
- it_behaves_like 'contract user is unauthorized'
+ it_behaves_like "contract user is unauthorized"
end
end
- describe 'public query' do
+ describe "public query" do
let(:public) { true }
let(:user) { nil }
- context 'when user has no permission to save' do
+ context "when user has no permission to save" do
let(:permissions) { %i() }
- it_behaves_like 'contract user is unauthorized'
+ it_behaves_like "contract user is unauthorized"
end
- context 'when user has no permission to manage public' do
+ context "when user has no permission to manage public" do
let(:permissions) { %i(manage_public_queries) }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'when user has permission to save only own' do
+ context "when user has permission to save only own" do
let(:permissions) { %i(save_queries) }
- it_behaves_like 'contract user is unauthorized'
+ it_behaves_like "contract user is unauthorized"
end
end
end
diff --git a/spec/contracts/relations/create_contract_spec.rb b/spec/contracts/relations/create_contract_spec.rb
index 4e3f5f150367..47cd3de84b0c 100644
--- a/spec/contracts/relations/create_contract_spec.rb
+++ b/spec/contracts/relations/create_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Relations::CreateContract do
- it_behaves_like 'relation contract' do
+ it_behaves_like "relation contract" do
let(:relation) do
Relation.new from: relation_from,
to: relation_to,
diff --git a/spec/contracts/relations/shared_contract_examples.rb b/spec/contracts/relations/shared_contract_examples.rb
index d81355229d95..175801fd373f 100644
--- a/spec/contracts/relations/shared_contract_examples.rb
+++ b/spec/contracts/relations/shared_contract_examples.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'contracts/shared/model_contract_shared_context'
+require "contracts/shared/model_contract_shared_context"
-RSpec.shared_examples_for 'relation contract' do
- include_context 'ModelContract shared context'
+RSpec.shared_examples_for "relation contract" do
+ include_context "ModelContract shared context"
let(:current_user) { build_stubbed(:user) }
let(:relation_from) do
- build_stubbed(:work_package, subject: 'From WP') do |wp|
+ build_stubbed(:work_package, subject: "From WP") do |wp|
allow(wp_visible_scope)
.to receive(:exists?)
.with(wp.id)
@@ -41,7 +41,7 @@
end
end
let(:relation_to) do
- build_stubbed(:work_package, subject: 'To WP') do |wp|
+ build_stubbed(:work_package, subject: "To WP") do |wp|
allow(wp_visible_scope)
.to receive(:exists?)
.with(wp.id)
@@ -100,41 +100,41 @@
end
end
- describe 'validation' do
- it_behaves_like 'contract is valid'
+ describe "validation" do
+ it_behaves_like "contract is valid"
- context 'when lacking the necessary permission' do
+ context "when lacking the necessary permission" do
let(:permissions) { [] }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
- context 'when the work package for from is not visible' do
+ context "when the work package for from is not visible" do
let(:relation_from_visible) { false }
- it_behaves_like 'contract is invalid', from: :error_not_found
+ it_behaves_like "contract is invalid", from: :error_not_found
end
- context 'when the work package for to is not visible' do
+ context "when the work package for to is not visible" do
let(:relation_to_visible) { false }
- it_behaves_like 'contract is invalid', to: :error_not_found
+ it_behaves_like "contract is invalid", to: :error_not_found
end
Relation::TYPES.each_key do |available_type|
context "when having the type '#{available_type}'" do
let(:relation_type) { available_type }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
end
- context 'when the work package type is unknown' do
- let(:relation_type) { 'some_bogus' }
+ context "when the work package type is unknown" do
+ let(:relation_type) { "some_bogus" }
- it_behaves_like 'contract is invalid', relation_type: :inclusion
+ it_behaves_like "contract is invalid", relation_type: :inclusion
end
end
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
diff --git a/spec/contracts/relations/update_contract_spec.rb b/spec/contracts/relations/update_contract_spec.rb
index e7f770ff3d7c..d8c925dd0959 100644
--- a/spec/contracts/relations/update_contract_spec.rb
+++ b/spec/contracts/relations/update_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Relations::UpdateContract do
- it_behaves_like 'relation contract' do
+ it_behaves_like "relation contract" do
let(:relation) do
build_stubbed(:relation,
from: relation_from,
@@ -40,12 +40,12 @@
end
end
- describe 'valid?' do
+ describe "valid?" do
create_shared_association_defaults_for_work_package_factory
let(:current_user) { build_stubbed(:admin) }
let(:contract) { described_class.new(relation, current_user) }
- context 'when an isolated relation is reversed' do
+ context "when an isolated relation is reversed" do
let(:relation) do
create(:relation, relation_type: Relation::TYPE_BLOCKS)
end
@@ -54,12 +54,12 @@
relation.relation_type = Relation::TYPE_BLOCKED
end
- it 'is valid' do
+ it "is valid" do
expect(contract).to be_valid
end
end
- context 'when a relation that cannot be reversed is reversed' do
+ context "when a relation that cannot be reversed is reversed" do
let(:relation_from_wp) { create(:work_package) }
let(:relation_to_wp) { create(:work_package) }
let(:intermediary_wp) { create(:work_package) }
@@ -88,7 +88,7 @@
relation.relation_type = Relation::TYPE_PRECEDES
end
- it 'is invalid' do
+ it "is invalid" do
expect(contract).not_to be_valid
end
end
diff --git a/spec/contracts/roles/create_contract_spec.rb b/spec/contracts/roles/create_contract_spec.rb
index 72d78d0f5d39..776d8d94399a 100644
--- a/spec/contracts/roles/create_contract_spec.rb
+++ b/spec/contracts/roles/create_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Roles::CreateContract do
- it_behaves_like 'roles contract' do
+ it_behaves_like "roles contract" do
let(:work_package_role) do
build(:work_package_role) do |r|
r.name = role_name
@@ -54,21 +54,21 @@
subject(:contract) { described_class.new(role, current_user) }
- describe 'validation' do
- context 'with the type set manually' do
+ describe "validation" do
+ context "with the type set manually" do
before do
- role.type = 'GlobalRole'
+ role.type = "GlobalRole"
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'with the type set manually to something other than Role or GlobalRole' do
+ context "with the type set manually to something other than Role or GlobalRole" do
before do
- role.type = 'MyRole'
+ role.type = "MyRole"
end
- it 'is invalid' do
+ it "is invalid" do
# The inclusion is in here twice because:
# * The contract validates the type (to check that only GlobalRole and ProjectRole are created)
# * The model validates the type (to check that only Role subclasses are created)
diff --git a/spec/contracts/roles/shared_contract_examples.rb b/spec/contracts/roles/shared_contract_examples.rb
index 61a2943ed833..04cee35ae438 100644
--- a/spec/contracts/roles/shared_contract_examples.rb
+++ b/spec/contracts/roles/shared_contract_examples.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.shared_examples_for 'roles contract' do
+RSpec.shared_examples_for "roles contract" do
let(:current_user) do
build_stubbed(:admin)
end
let(:role_instance) { Role.new }
- let(:role_name) { 'A role name' }
+ let(:role_name) { "A role name" }
let(:role_permissions) { [:view_work_packages] }
def expect_valid(valid, symbols = {})
@@ -44,33 +44,33 @@ def expect_valid(valid, symbols = {})
end
end
- shared_examples 'is valid' do
- it 'is valid' do
+ shared_examples "is valid" do
+ it "is valid" do
expect_valid(true)
end
end
- describe 'validation' do
- it_behaves_like 'is valid'
+ describe "validation" do
+ it_behaves_like "is valid"
- context 'if the name is nil' do
+ context "if the name is nil" do
let(:role_name) { nil }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, name: %i(blank))
end
end
- context 'if the permissions do not include their dependency' do
+ context "if the permissions do not include their dependency" do
let(:role_permissions) { [:manage_members] }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, permissions: %i(dependency_missing))
end
end
end
- describe '#assignable_permissions' do
+ describe "#assignable_permissions" do
let(:permission1) { instance_double(OpenProject::AccessControl::Permission, name: :perm1, public?: false) }
let(:permission2) { instance_double(OpenProject::AccessControl::Permission, name: :perm2, public?: true) }
let(:permission3) { instance_double(OpenProject::AccessControl::Permission, name: :perm3, public?: false) }
@@ -78,36 +78,36 @@ def expect_valid(valid, symbols = {})
let(:all_permissions) { [permission1, permission2, permission3] }
let(:public_permissions) { [permission2] }
- context 'for a project role' do
+ context "for a project role" do
before do
allow(OpenProject::AccessControl).to receive_messages(project_permissions: all_permissions, public_permissions:)
end
- it 'is all project permissions' do
+ it "is all project permissions" do
expect(contract.assignable_permissions).to match_array(all_permissions - public_permissions)
end
end
- context 'for a work package role' do
+ context "for a work package role" do
let(:role) { work_package_role }
before do
allow(OpenProject::AccessControl).to receive(:work_package_permissions).and_return(all_permissions)
end
- it 'is all work package permissions' do
+ it "is all work package permissions" do
expect(contract.assignable_permissions).to match_array(all_permissions - public_permissions)
end
end
- context 'for a global role' do
+ context "for a global role" do
let(:role) { global_role }
before do
allow(OpenProject::AccessControl).to receive(:global_permissions).and_return(all_permissions)
end
- it 'is all the global permissions' do
+ it "is all the global permissions" do
expect(contract.assignable_permissions).to match_array(all_permissions - public_permissions)
end
end
diff --git a/spec/contracts/roles/update_contract_spec.rb b/spec/contracts/roles/update_contract_spec.rb
index 792ad15bcf98..0888b09bf1ec 100644
--- a/spec/contracts/roles/update_contract_spec.rb
+++ b/spec/contracts/roles/update_contract_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Roles::UpdateContract do
- it_behaves_like 'roles contract' do
+ it_behaves_like "roles contract" do
let(:work_package_role) do
build_stubbed(:work_package_role,
- name: 'Some name') do |r|
+ name: "Some name") do |r|
r.name = role_name
r.permissions = role_permissions
end
@@ -41,7 +41,7 @@
let(:role) do
build_stubbed(:project_role,
- name: 'Some name') do |r|
+ name: "Some name") do |r|
r.name = role_name
r.permissions = role_permissions
end
@@ -49,7 +49,7 @@
let(:global_role) do
build_stubbed(:global_role,
- name: 'Some name') do |r|
+ name: "Some name") do |r|
r.name = role_name
r.permissions = role_permissions
end
@@ -57,13 +57,13 @@
subject(:contract) { described_class.new(role, current_user) }
- describe 'validation' do
- context 'with the type set manually' do
+ describe "validation" do
+ context "with the type set manually" do
before do
- role.type = 'GlobalRole'
+ role.type = "GlobalRole"
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, type: %i(error_readonly))
end
end
diff --git a/spec/contracts/settings/update_contract_spec.rb b/spec/contracts/settings/update_contract_spec.rb
index 81b52742b9dc..71f1f807adca 100644
--- a/spec/contracts/settings/update_contract_spec.rb
+++ b/spec/contracts/settings/update_contract_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe Settings::UpdateContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:contract) do
described_class.new(nil, current_user)
end
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
end
diff --git a/spec/contracts/shared/model_contract_shared_context.rb b/spec/contracts/shared/model_contract_shared_context.rb
index 47de6311421b..6fa875de44fc 100644
--- a/spec/contracts/shared/model_contract_shared_context.rb
+++ b/spec/contracts/shared/model_contract_shared_context.rb
@@ -1,4 +1,4 @@
-RSpec.shared_context 'ModelContract shared context' do # rubocop:disable RSpec/ContextWording
+RSpec.shared_context "ModelContract shared context" do # rubocop:disable RSpec/ContextWording
def expect_contract_valid
expect(contract.validate)
.to be(true),
@@ -15,14 +15,14 @@ def expect_contract_invalid(errors = {})
end
end
- shared_examples 'contract is valid' do
- it 'contract is valid' do
+ shared_examples "contract is valid" do
+ it "contract is valid" do
expect_contract_valid
end
end
- shared_examples 'contract is invalid' do |error_symbols = {}|
- example_title = 'contract is invalid'
+ shared_examples "contract is invalid" do |error_symbols = {}|
+ example_title = "contract is invalid"
example_title << " with #{error_symbols.inspect}" if error_symbols.any?
it example_title do
@@ -30,34 +30,34 @@ def expect_contract_invalid(errors = {})
end
end
- shared_examples 'contract user is unauthorized' do
- include_examples 'contract is invalid', base: :error_unauthorized
+ shared_examples "contract user is unauthorized" do
+ include_examples "contract is invalid", base: :error_unauthorized
end
- shared_examples 'contract is valid for active admins and invalid for regular users' do
- context 'when admin' do
+ shared_examples "contract is valid for active admins and invalid for regular users" do
+ context "when admin" do
let(:current_user) { build_stubbed(:admin) }
- context 'when active' do
- include_examples 'contract is valid'
+ context "when active" do
+ include_examples "contract is valid"
end
- context 'when not active' do
+ context "when not active" do
let(:current_user) { build_stubbed(:admin, status: User.statuses[:locked]) }
- it_behaves_like 'contract user is unauthorized'
+ it_behaves_like "contract user is unauthorized"
end
end
- context 'when not admin' do
+ context "when not admin" do
let(:current_user) { build_stubbed(:user) }
- it_behaves_like 'contract user is unauthorized'
+ it_behaves_like "contract user is unauthorized"
end
end
- shared_examples 'contract reuses the model errors' do
- it 'reuses the model`s errors object' do
+ shared_examples "contract reuses the model errors" do
+ it "reuses the model`s errors object" do
expect(contract.errors.object_id).to be(contract.model.errors.object_id)
end
end
diff --git a/spec/contracts/user_preferences/params_contract_spec.rb b/spec/contracts/user_preferences/params_contract_spec.rb
index e436195d0724..937c2fcf70b5 100644
--- a/spec/contracts/user_preferences/params_contract_spec.rb
+++ b/spec/contracts/user_preferences/params_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe UserPreferences::ParamsContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:current_user) { build_stubbed(:user) }
let(:preference_user) { current_user }
@@ -47,20 +47,20 @@
{
hide_mail: true,
auto_hide_popups: true,
- comments_sorting: 'desc',
+ comments_sorting: "desc",
daily_reminders: {
enabled: true,
times: %w[08:00:00+00:00 12:00:00+00:00]
},
- time_zone: 'Brasilia',
+ time_zone: "Brasilia",
warn_on_leaving_unsaved: true,
notification_settings:
}
end
let(:contract) { described_class.new(user_preference, current_user, params:) }
- describe 'notification settings' do
- context 'when multiple global settings' do
+ describe "notification settings" do
+ context "when multiple global settings" do
let(:notification_settings) do
[
{ project_id: nil, mentioned: true },
@@ -68,39 +68,39 @@
]
end
- it_behaves_like 'contract is invalid', notification_settings: :only_one_global_setting
+ it_behaves_like "contract is invalid", notification_settings: :only_one_global_setting
end
- context 'when project settings with an email alert set' do
+ context "when project settings with an email alert set" do
let(:notification_settings) do
[
{ project_id: 1234, news_added: true }
]
end
- it_behaves_like 'contract is invalid', notification_settings: :email_alerts_global
+ it_behaves_like "contract is invalid", notification_settings: :email_alerts_global
end
- context 'when global settings with an email alert set' do
+ context "when global settings with an email alert set" do
let(:notification_settings) do
[
{ project_id: nil, news_added: true }
]
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'without enterprise' do
- context 'when global setting with start_date, due_date and overdue set' do
+ context "without enterprise" do
+ context "when global setting with start_date, due_date and overdue set" do
let(:notification_settings) do
[
{ start_date: 1, due_date: 1, overdue: 1 }
]
end
- it_behaves_like 'contract is invalid', base: :error_enterprise_only do
- it 'displays the error message containing the feature name' do
+ it_behaves_like "contract is invalid", base: :error_enterprise_only do
+ it "displays the error message containing the feature name" do
contract.validate
expect(contract.errors.full_messages)
.to eq(["Date Alerts is only available in the OpenProject Enterprise edition"])
@@ -108,117 +108,117 @@
end
end
- context 'when project setting with start_date, due_date and overdue set' do
+ context "when project setting with start_date, due_date and overdue set" do
let(:notification_settings) do
[
{ project_id: 1234, start_date: 1, due_date: 1, overdue: 1 }
]
end
- it_behaves_like 'contract is invalid', base: :error_enterprise_only
+ it_behaves_like "contract is invalid", base: :error_enterprise_only
end
end
- context 'with enterprise', with_ee: %i[date_alerts] do
- context 'when project setting with start_date, due_date and overdue set' do
+ context "with enterprise", with_ee: %i[date_alerts] do
+ context "when project setting with start_date, due_date and overdue set" do
let(:notification_settings) do
[
{ project_id: 1234, start_date: 1, due_date: 1, overdue: 1 }
]
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'when global setting with start_date, due_date and overdue set' do
+ context "when global setting with start_date, due_date and overdue set" do
let(:notification_settings) do
[
{ start_date: 1, due_date: 1, overdue: 1 }
]
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'when project setting with valid start_date, valid due_date and invalid overdue' do
+ context "when project setting with valid start_date, valid due_date and invalid overdue" do
let(:notification_settings) do
[
{ project_id: 1234, start_date: 1, due_date: 1, overdue: 0 }
]
end
- it_behaves_like 'contract is invalid', notification_settings: :wrong_date
+ it_behaves_like "contract is invalid", notification_settings: :wrong_date
end
- context 'when global setting with invalid start_date, valid due_date and valid overdue' do
+ context "when global setting with invalid start_date, valid due_date and valid overdue" do
let(:notification_settings) do
[
{ start_date: -1, due_date: 1, overdue: 1 }
]
end
- it_behaves_like 'contract is invalid', notification_settings: :wrong_date
+ it_behaves_like "contract is invalid", notification_settings: :wrong_date
end
- context 'when project setting with start_date, due_date and overdue missing' do
+ context "when project setting with start_date, due_date and overdue missing" do
let(:notification_settings) do
[
{ project_id: 1234, start_date: 1, due_date: 1 }
]
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'when global setting with start_date, due_date and overdue missing' do
+ context "when global setting with start_date, due_date and overdue missing" do
let(:notification_settings) do
[
{ start_date: 1, due_date: 1 }
]
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'when project setting with valid start_date, invalid due_date and overdue missing' do
+ context "when project setting with valid start_date, invalid due_date and overdue missing" do
let(:notification_settings) do
[
{ project_id: 1234, start_date: 1, due_date: 24 }
]
end
- it_behaves_like 'contract is invalid', notification_settings: :wrong_date
+ it_behaves_like "contract is invalid", notification_settings: :wrong_date
end
- context 'when global setting with invalid start_date, valid due_date and overdue missing' do
+ context "when global setting with invalid start_date, valid due_date and overdue missing" do
let(:notification_settings) do
[
{ start_date: 24, due_date: 1 }
]
end
- it_behaves_like 'contract is invalid', notification_settings: :wrong_date
+ it_behaves_like "contract is invalid", notification_settings: :wrong_date
end
end
- context 'when notification_settings empty' do
+ context "when notification_settings empty" do
let(:params) do
{
hide_mail: true,
auto_hide_popups: true,
- comments_sorting: 'desc',
+ comments_sorting: "desc",
daily_reminders: {
enabled: true,
times: %w[08:00:00+00:00 12:00:00+00:00]
},
- time_zone: 'Brasilia',
+ time_zone: "Brasilia",
warn_on_leaving_unsaved: true
}
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
end
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
diff --git a/spec/contracts/user_preferences/update_contract_spec.rb b/spec/contracts/user_preferences/update_contract_spec.rb
index 582dda716bb3..b5e17029ff89 100644
--- a/spec/contracts/user_preferences/update_contract_spec.rb
+++ b/spec/contracts/user_preferences/update_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
RSpec.describe UserPreferences::UpdateContract do
- include_context 'ModelContract shared context'
+ include_context "ModelContract shared context"
let(:current_user) { build_stubbed(:user) }
let(:preference_user) { current_user }
@@ -43,27 +43,27 @@
{
hide_mail: true,
auto_hide_popups: true,
- comments_sorting: 'desc',
+ comments_sorting: "desc",
daily_reminders: {
enabled: true,
times: %w[08:00:00+00:00 12:00:00+00:00]
},
- time_zone: 'America/Sao_Paulo',
+ time_zone: "America/Sao_Paulo",
warn_on_leaving_unsaved: true,
workdays: [1, 2, 4, 6]
}
end
let(:contract) { described_class.new(user_preference, current_user) }
- describe 'validation' do
- context 'when current_user is admin' do
+ describe "validation" do
+ context "when current_user is admin" do
let(:current_user) { build_stubbed(:admin) }
let(:preference_user) { build_stubbed(:user) }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'when current_user has manage_user permission' do
+ context "when current_user has manage_user permission" do
let(:preference_user) { build_stubbed(:user) }
before do
@@ -72,65 +72,65 @@
end
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'when current_user is the own user' do
- it_behaves_like 'contract is valid'
+ context "when current_user is the own user" do
+ it_behaves_like "contract is valid"
end
- context 'when current_user is the own user but not active' do
+ context "when current_user is the own user but not active" do
before do
allow(current_user).to receive(:active?).and_return false
end
- it_behaves_like 'contract user is unauthorized'
+ it_behaves_like "contract user is unauthorized"
end
- context 'when current_user is anonymous' do
+ context "when current_user is anonymous" do
let(:current_user) { User.anonymous }
- it_behaves_like 'contract user is unauthorized'
+ it_behaves_like "contract user is unauthorized"
end
- context 'when current_user is a regular user' do
+ context "when current_user is a regular user" do
let(:preference_user) { build_stubbed(:user) }
- it_behaves_like 'contract user is unauthorized'
+ it_behaves_like "contract user is unauthorized"
end
- context 'with empty settings' do
+ context "with empty settings" do
let(:settings) do
{}
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'with a string for hide_mail' do
+ context "with a string for hide_mail" do
let(:settings) do
{
- hide_mail: 'yes please'
+ hide_mail: "yes please"
}
end
- it_behaves_like 'contract is invalid', hide_mail: :type_mismatch
+ it_behaves_like "contract is invalid", hide_mail: :type_mismatch
end
- context 'with a field within the daily_reminders having the wrong type' do
+ context "with a field within the daily_reminders having the wrong type" do
let(:settings) do
{
daily_reminders: {
- enabled: 'sure',
+ enabled: "sure",
times: %w[08:00:00+00:00 12:00:00+00:00]
}
}
end
- it_behaves_like 'contract is invalid', daily_reminders: :type_mismatch_nested
+ it_behaves_like "contract is invalid", daily_reminders: :type_mismatch_nested
end
- context 'with a field within the daily_reminders missing' do
+ context "with a field within the daily_reminders missing" do
let(:settings) do
{
daily_reminders: {
@@ -139,20 +139,20 @@
}
end
- it_behaves_like 'contract is invalid', daily_reminders: :blank_nested
+ it_behaves_like "contract is invalid", daily_reminders: :blank_nested
end
- context 'with an extra property' do
+ context "with an extra property" do
let(:settings) do
{
foo: true
}
end
- it_behaves_like 'contract is invalid', foo: :unknown_property
+ it_behaves_like "contract is invalid", foo: :unknown_property
end
- context 'with an extra property within the daily_reminders' do
+ context "with an extra property within the daily_reminders" do
let(:settings) do
{
daily_reminders: {
@@ -163,10 +163,10 @@
}
end
- it_behaves_like 'contract is invalid', daily_reminders: :unknown_property_nested
+ it_behaves_like "contract is invalid", daily_reminders: :unknown_property_nested
end
- context 'with an invalid time for the daily_reminders' do
+ context "with an invalid time for the daily_reminders" do
let(:settings) do
{
daily_reminders: {
@@ -176,10 +176,10 @@
}
end
- it_behaves_like 'contract is invalid', daily_reminders: %i[format_nested full_hour]
+ it_behaves_like "contract is invalid", daily_reminders: %i[format_nested full_hour]
end
- context 'with a sub hour time for the daily_reminders' do
+ context "with a sub hour time for the daily_reminders" do
let(:settings) do
{
daily_reminders: {
@@ -189,25 +189,25 @@
}
end
- it_behaves_like 'contract is invalid', daily_reminders: :full_hour
+ it_behaves_like "contract is invalid", daily_reminders: :full_hour
end
- context 'with an invalid order for comments_sorting' do
+ context "with an invalid order for comments_sorting" do
let(:settings) do
{
- comments_sorting: 'up'
+ comments_sorting: "up"
}
end
- it_behaves_like 'contract is invalid', comments_sorting: :inclusion
+ it_behaves_like "contract is invalid", comments_sorting: :inclusion
end
- context 'without a time_zone' do
+ context "without a time_zone" do
let(:settings) do
{
hide_mail: true,
auto_hide_popups: true,
- comments_sorting: 'desc',
+ comments_sorting: "desc",
daily_reminders: {
enabled: true,
times: %w[08:00:00+00:00 12:00:00+00:00]
@@ -216,165 +216,165 @@
}
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'with a full time_zone' do
+ context "with a full time_zone" do
let(:settings) do
{
- time_zone: 'Europe/Paris'
+ time_zone: "Europe/Paris"
}
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'with a non ActiveSupport::Timezone timezone' do
+ context "with a non ActiveSupport::Timezone timezone" do
let(:settings) do
{
- time_zone: 'America/Adak'
+ time_zone: "America/Adak"
}
end
- it_behaves_like 'contract is invalid', time_zone: :inclusion
+ it_behaves_like "contract is invalid", time_zone: :inclusion
end
- context 'with a malformed time_zone' do
+ context "with a malformed time_zone" do
let(:settings) do
{
- time_zone: '123Brasilia'
+ time_zone: "123Brasilia"
}
end
- it_behaves_like 'contract is invalid', time_zone: :inclusion
+ it_behaves_like "contract is invalid", time_zone: :inclusion
end
- context 'with a non tzinfo time_zone' do
+ context "with a non tzinfo time_zone" do
let(:settings) do
{
- time_zone: 'Brasilia'
+ time_zone: "Brasilia"
}
end
- it_behaves_like 'contract is invalid', time_zone: :inclusion
+ it_behaves_like "contract is invalid", time_zone: :inclusion
end
- context 'with duplicate workday entries' do
+ context "with duplicate workday entries" do
let(:settings) do
{
workdays: [1, 1]
}
end
- it_behaves_like 'contract is invalid', workdays: :no_duplicates
+ it_behaves_like "contract is invalid", workdays: :no_duplicates
end
- context 'with non-iso workday entries' do
+ context "with non-iso workday entries" do
let(:settings) do
{
- workdays: [nil, 'foo', :bar, 21345, 2.0]
+ workdays: [nil, "foo", :bar, 21345, 2.0]
}
end
- it_behaves_like 'contract is invalid', workdays: %i[invalid type_mismatch_nested
+ it_behaves_like "contract is invalid", workdays: %i[invalid type_mismatch_nested
type_mismatch_nested type_mismatch_nested]
end
end
- describe '#assignable_time_zones' do
+ describe "#assignable_time_zones" do
subject(:time_zones) { contract.assignable_time_zones }
- it 'returns a list of AS::TimeZones' do
+ it "returns a list of AS::TimeZones" do
expect(time_zones)
.to(be_all { |tz| tz.is_a?(ActiveSupport::TimeZone) })
end
- it 'includes only the namesake zone if multiple AS::Timezone map to the same TZInfo' do
+ it "includes only the namesake zone if multiple AS::Timezone map to the same TZInfo" do
# In this case 'Edinburgh' and 'Bern' are not included
expect(time_zones.select { |tz| %w[Europe/London Europe/Zurich].include? tz.tzinfo.canonical_zone.name })
- .to contain_exactly(ActiveSupport::TimeZone['London'], ActiveSupport::TimeZone['Zurich'])
+ .to contain_exactly(ActiveSupport::TimeZone["London"], ActiveSupport::TimeZone["Zurich"])
end
end
- describe 'pause_reminders' do
- context 'with enabled false' do
+ describe "pause_reminders" do
+ context "with enabled false" do
let(:settings) do
{
pause_reminders: { enabled: false }
}
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'with enabled true but and valid range' do
+ context "with enabled true but and valid range" do
let(:settings) do
{
pause_reminders: {
enabled: true,
- first_day: '2021-10-05',
- last_day: '2021-10-10'
+ first_day: "2021-10-05",
+ last_day: "2021-10-10"
}
}
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'with empty object' do
+ context "with empty object" do
let(:settings) do
{
pause_reminders: {}
}
end
- it_behaves_like 'contract is invalid', pause_reminders: :blank_nested
+ it_behaves_like "contract is invalid", pause_reminders: :blank_nested
end
- context 'with enabled true but no days' do
+ context "with enabled true but no days" do
let(:settings) do
{
pause_reminders: { enabled: true }
}
end
- it_behaves_like 'contract is invalid', pause_reminders: :blank
+ it_behaves_like "contract is invalid", pause_reminders: :blank
end
- context 'with enabled true but invalid dates' do
+ context "with enabled true but invalid dates" do
let(:settings) do
{
pause_reminders: {
enabled: true,
- first_day: '2021-10-05T08:21:35Z',
- last_day: '2021-10-05T08:21:35Z'
+ first_day: "2021-10-05T08:21:35Z",
+ last_day: "2021-10-05T08:21:35Z"
}
}
end
- it_behaves_like 'contract is invalid', pause_reminders: %i[format_nested format_nested]
+ it_behaves_like "contract is invalid", pause_reminders: %i[format_nested format_nested]
end
- context 'with enabled true but only first day' do
+ context "with enabled true but only first day" do
let(:settings) do
{
- pause_reminders: { enabled: true, first_day: '2021-10-05' }
+ pause_reminders: { enabled: true, first_day: "2021-10-05" }
}
end
- it_behaves_like 'contract is invalid', pause_reminders: :blank
+ it_behaves_like "contract is invalid", pause_reminders: :blank
end
- context 'with enabled true but only last day' do
+ context "with enabled true but only last day" do
let(:settings) do
{
- pause_reminders: { enabled: true, last_day: '2021-10-05' }
+ pause_reminders: { enabled: true, last_day: "2021-10-05" }
}
end
- it_behaves_like 'contract is invalid', pause_reminders: :blank
+ it_behaves_like "contract is invalid", pause_reminders: :blank
end
end
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
diff --git a/spec/contracts/users/create_contract_spec.rb b/spec/contracts/users/create_contract_spec.rb
index 6bb0bf6ac3fc..f145a076731f 100644
--- a/spec/contracts/users/create_contract_spec.rb
+++ b/spec/contracts/users/create_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Users::CreateContract do
- it_behaves_like 'user contract' do
+ it_behaves_like "user contract" do
let(:user) { User.new(attributes) }
let(:contract) { described_class.new(user, current_user) }
let(:attributes) do
@@ -45,35 +45,35 @@
}
end
- context 'when admin' do
+ context "when admin" do
let(:current_user) { build_stubbed(:admin) }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
- describe 'requires a password set when active' do
+ describe "requires a password set when active" do
before do
user.password = nil
user.password_confirmation = nil
user.activate
end
- it_behaves_like 'contract is invalid', password: :blank
+ it_behaves_like "contract is invalid", password: :blank
- context 'when password is set' do
+ context "when password is set" do
before do
- user.password = user.password_confirmation = 'password!password!'
+ user.password = user.password_confirmation = "password!password!"
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
end
- context 'when user limit reached' do
+ context "when user limit reached" do
before do
allow(OpenProject::Enterprise).to receive(:user_limit_reached?).and_return(true)
end
- it_behaves_like 'contract is invalid', base: :user_limit_reached
+ it_behaves_like "contract is invalid", base: :user_limit_reached
end
end
end
diff --git a/spec/contracts/users/shared_contract_examples.rb b/spec/contracts/users/shared_contract_examples.rb
index fcc447a150e4..b49c82e8b613 100644
--- a/spec/contracts/users/shared_contract_examples.rb
+++ b/spec/contracts/users/shared_contract_examples.rb
@@ -26,50 +26,50 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
-RSpec.shared_examples_for 'user contract' do
- include_context 'ModelContract shared context'
+RSpec.shared_examples_for "user contract" do
+ include_context "ModelContract shared context"
- let(:user_firstname) { 'Bob' }
- let(:user_lastname) { 'Bobbit' }
- let(:user_login) { 'bob' }
- let(:user_mail) { 'bobbit@bob.com' }
- let(:user_password) { 'adminADMIN!' }
- let(:user_password_confirmation) { 'adminADMIN!' }
+ let(:user_firstname) { "Bob" }
+ let(:user_lastname) { "Bobbit" }
+ let(:user_login) { "bob" }
+ let(:user_mail) { "bobbit@bob.com" }
+ let(:user_password) { "adminADMIN!" }
+ let(:user_password_confirmation) { "adminADMIN!" }
- it_behaves_like 'contract is valid for active admins and invalid for regular users'
+ it_behaves_like "contract is valid for active admins and invalid for regular users"
- context 'when admin' do
+ context "when admin" do
let(:current_user) { build_stubbed(:admin) }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
- context 'when global user' do
+ context "when global user" do
let(:current_user) { create(:user, global_permissions: %i[create_user manage_user]) }
- describe 'cannot set the password' do
+ describe "cannot set the password" do
before do
- user.password = user.password_confirmation = 'password!password!'
+ user.password = user.password_confirmation = "password!password!"
end
- it_behaves_like 'contract is invalid', password: :error_readonly
+ it_behaves_like "contract is invalid", password: :error_readonly
end
- describe 'can set the status' do
+ describe "can set the status" do
before do
user.password = user.password_confirmation = nil
user.status = Principal.statuses[:invited]
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- describe 'can set the auth_source' do
+ describe "can set the auth_source" do
let!(:auth_source) { create(:ldap_auth_source) }
before do
@@ -77,25 +77,25 @@
user.ldap_auth_source = auth_source
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- describe 'cannot set the identity url' do
+ describe "cannot set the identity url" do
before do
- user.identity_url = 'saml:123412foo'
+ user.identity_url = "saml:123412foo"
end
- it_behaves_like 'contract is invalid', identity_url: :error_readonly
+ it_behaves_like "contract is invalid", identity_url: :error_readonly
end
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
- context 'when unauthorized user' do
+ context "when unauthorized user" do
let(:current_user) { build_stubbed(:user) }
- it_behaves_like 'contract user is unauthorized'
+ it_behaves_like "contract user is unauthorized"
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
end
diff --git a/spec/contracts/users/update_contract_spec.rb b/spec/contracts/users/update_contract_spec.rb
index a9bc4963268e..033514260c48 100644
--- a/spec/contracts/users/update_contract_spec.rb
+++ b/spec/contracts/users/update_contract_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Users::UpdateContract do
let!(:default_admin) { create(:admin) }
- it_behaves_like 'user contract' do
+ it_behaves_like "user contract" do
let(:current_user) { create(:admin) }
let(:user) { build_stubbed(:user, attributes) }
let(:contract) { described_class.new(user, current_user) }
@@ -47,54 +47,54 @@
}
end
- context 'with a system user' do
+ context "with a system user" do
let(:current_user) { create(:system) }
let(:user) { create(:admin, attributes) }
- context 'when admin flag is removed' do
+ context "when admin flag is removed" do
before do
user.admin = false
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
- context 'when no admins left' do
+ context "when no admins left" do
let(:default_admin) { nil }
- it_behaves_like 'contract is invalid', base: :one_must_be_active
+ it_behaves_like "contract is invalid", base: :one_must_be_active
end
end
- context 'when status is locked on an admin user' do
+ context "when status is locked on an admin user" do
before do
user.status = :locked
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
- context 'when no admins left' do
+ context "when no admins left" do
let(:default_admin) { nil }
- it_behaves_like 'contract is invalid', base: :one_must_be_active
+ it_behaves_like "contract is invalid", base: :one_must_be_active
end
end
end
- context 'when global user' do
+ context "when global user" do
let(:current_user) { create(:user, global_permissions: :manage_user) }
- describe 'can lock the user' do
+ describe "can lock the user" do
before do
user.status = Principal.statuses[:locked]
end
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- describe 'cannot update an administrator' do
+ describe "cannot update an administrator" do
let(:user) { build_stubbed(:admin, attributes) }
- it_behaves_like 'contract is invalid'
+ it_behaves_like "contract is invalid"
end
end
@@ -102,14 +102,14 @@
# That scenario is the only that is not covered by the shared examples
let(:current_user) { user }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
- context 'when setting status' do
+ context "when setting status" do
before do
user.status = Principal.statuses[:locked]
end
- it_behaves_like 'contract is invalid', status: :error_readonly
+ it_behaves_like "contract is invalid", status: :error_readonly
end
end
end
diff --git a/spec/contracts/versions/create_contract_spec.rb b/spec/contracts/versions/create_contract_spec.rb
index b06af3050952..1304fa278019 100644
--- a/spec/contracts/versions/create_contract_spec.rb
+++ b/spec/contracts/versions/create_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Versions::CreateContract do
- it_behaves_like 'version contract' do
+ it_behaves_like "version contract" do
let(:version) do
Version.new(name: version_name,
project: version_project,
@@ -44,9 +44,9 @@
subject(:contract) { described_class.new(version, current_user) }
- describe 'assignable_values' do
- context 'for project' do
- let(:assignable_projects) { double('assignable projects') }
+ describe "assignable_values" do
+ context "for project" do
+ let(:assignable_projects) { double("assignable projects") }
before do
allow(Project)
@@ -55,37 +55,37 @@
.and_return(assignable_projects)
end
- it 'is all projects the user has :manage_versions permission in' do
+ it "is all projects the user has :manage_versions permission in" do
expect(subject.assignable_values(:project, current_user))
.to eql assignable_projects
end
end
- context 'for status' do
- it 'is a list of all available status' do
+ context "for status" do
+ it "is a list of all available status" do
expect(subject.assignable_values(:status, current_user))
.to eql %w(open locked closed)
end
end
- context 'for sharing' do
- it 'is a list of values' do
+ context "for sharing" do
+ it "is a list of values" do
expect(subject.assignable_values(:sharing, current_user))
.to match_array %w(none descendants hierarchy tree)
end
- context 'if the user is admin' do
+ context "if the user is admin" do
let(:current_user) { build_stubbed(:admin) }
- it 'is a list of values' do
+ it "is a list of values" do
expect(subject.assignable_values(:sharing, current_user))
.to match_array %w(none descendants system hierarchy tree)
end
end
end
- context 'for something else' do
- it 'is nil' do
+ context "for something else" do
+ it "is nil" do
expect(subject.assignable_values(:start_date, current_user))
.to be_nil
end
diff --git a/spec/contracts/versions/shared_contract_examples.rb b/spec/contracts/versions/shared_contract_examples.rb
index b2adb3bee2d1..5cde71bd8f11 100644
--- a/spec/contracts/versions/shared_contract_examples.rb
+++ b/spec/contracts/versions/shared_contract_examples.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.shared_examples_for 'version contract' do
+RSpec.shared_examples_for "version contract" do
let(:current_user) { build_stubbed(:user) }
before do
@@ -55,23 +55,23 @@
end
end
let(:find_page_result) do
- double('page found')
+ double("page found")
end
let(:wiki_pages) do
[build_stubbed(:wiki_page),
build_stubbed(:wiki_page)]
end
- let(:version_name) { 'Version name' }
- let(:version_description) { 'Version description' }
+ let(:version_name) { "Version name" }
+ let(:version_description) { "Version description" }
let(:version_start_date) { Date.current - 5.days }
let(:version_due_date) { Date.current + 5.days }
- let(:version_status) { 'open' }
- let(:version_sharing) { 'none' }
- let(:version_wiki_page_title) { 'some page' }
+ let(:version_status) { "open" }
+ let(:version_sharing) { "none" }
+ let(:version_wiki_page_title) { "some page" }
let(:permissions) { [:manage_versions] }
let(:root_permissions) { [:manage_versions] }
- context 'validations' do
+ context "validations" do
def expect_valid(valid, symbols = {})
expect(contract.validate).to eq(valid)
@@ -80,211 +80,211 @@ def expect_valid(valid, symbols = {})
end
end
- shared_examples 'is valid' do
- it 'is valid' do
+ shared_examples "is valid" do
+ it "is valid" do
expect_valid(true)
end
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
- context 'if the project is nil' do
+ context "if the project is nil" do
let(:version_project) { nil }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, project_id: %i(blank))
end
end
- context 'if the name is nil' do
+ context "if the name is nil" do
let(:version_name) { nil }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, name: %i(blank))
end
end
- context 'if the description is nil' do
+ context "if the description is nil" do
let(:version_description) { nil }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if the start_date is nil' do
+ context "if the start_date is nil" do
let(:version_start_date) { nil }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if the end_date is nil' do
+ context "if the end_date is nil" do
let(:version_due_date) { nil }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if the status is nil' do
+ context "if the status is nil" do
let(:version_status) { nil }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, status: %i(inclusion))
end
end
- context 'if the status is something other than the allowed values' do
- let(:version_status) { 'other_status' }
+ context "if the status is something other than the allowed values" do
+ let(:version_status) { "other_status" }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, status: %i(inclusion))
end
end
- context 'if sharing is nil' do
+ context "if sharing is nil" do
before do
- version.sharing = 'nil'
+ version.sharing = "nil"
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, sharing: %i(inclusion))
end
end
- context 'if sharing is bogus' do
+ context "if sharing is bogus" do
before do
- version.sharing = 'bogus'
+ version.sharing = "bogus"
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, sharing: %i(inclusion))
end
end
- context 'if sharing is system and the user an admin' do
+ context "if sharing is system and the user an admin" do
let(:current_user) { build_stubbed(:admin) }
before do
- version.sharing = 'system'
+ version.sharing = "system"
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if sharing is system and the user no admin' do
+ context "if sharing is system and the user no admin" do
before do
- version.sharing = 'system'
+ version.sharing = "system"
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, sharing: %i(inclusion))
end
end
- context 'if sharing is descendants' do
+ context "if sharing is descendants" do
before do
- version.sharing = 'descendants'
+ version.sharing = "descendants"
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if sharing is tree and the user has manage permission on the root project' do
+ context "if sharing is tree and the user has manage permission on the root project" do
before do
- version.sharing = 'tree'
+ version.sharing = "tree"
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if sharing is tree and the user has no manage permission on the root project' do
+ context "if sharing is tree and the user has no manage permission on the root project" do
let(:root_permissions) { [] }
before do
- version.sharing = 'tree'
+ version.sharing = "tree"
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, sharing: %i(inclusion))
end
end
- context 'if sharing is hierarchy and the user has manage permission on the root project' do
+ context "if sharing is hierarchy and the user has manage permission on the root project" do
before do
- version.sharing = 'hierarchy'
+ version.sharing = "hierarchy"
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if sharing is hierarchy and the user has no manage permission on the root project' do
+ context "if sharing is hierarchy and the user has no manage permission on the root project" do
let(:root_permissions) { [] }
before do
- version.sharing = 'hierarchy'
+ version.sharing = "hierarchy"
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, sharing: %i(inclusion))
end
end
- context 'if the user lacks the manage_versions permission' do
+ context "if the user lacks the manage_versions permission" do
let(:permissions) { [] }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, base: %i(error_unauthorized))
end
end
- context 'if the start date is after the effective date' do
+ context "if the start date is after the effective date" do
let(:version_start_date) { version_due_date + 1.day }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, effective_date: %i(greater_than_start_date))
end
end
- context 'if wiki_page_title is nil' do
+ context "if wiki_page_title is nil" do
let(:version_wiki_page_title) { nil }
let(:find_page_result) do
nil
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if wiki_page_title is blank' do
- let(:version_wiki_page_title) { '' }
+ context "if wiki_page_title is blank" do
+ let(:version_wiki_page_title) { "" }
let(:find_page_result) do
nil
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if wiki_page_title contains a non existing page' do
- let(:version_wiki_page_title) { 'http://some/url/i/made/up' }
+ context "if wiki_page_title contains a non existing page" do
+ let(:version_wiki_page_title) { "http://some/url/i/made/up" }
let(:find_page_result) do
nil
end
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, wiki_page_title: %i(inclusion))
end
end
end
- describe 'assignable values' do
- describe 'assignable_wiki_pages' do
- context 'with a wiki assigned' do
- it 'returns the pages of the project`s wiki' do
+ describe "assignable values" do
+ describe "assignable_wiki_pages" do
+ context "with a wiki assigned" do
+ it "returns the pages of the project`s wiki" do
expect(contract.assignable_wiki_pages)
.to match_array(wiki_pages)
end
end
- context 'without a wiki assigned' do
+ context "without a wiki assigned" do
let(:project_wiki) { nil }
- it 'is empty' do
+ it "is empty" do
expect(contract.assignable_wiki_pages)
.to be_empty
end
diff --git a/spec/contracts/versions/update_contract_spec.rb b/spec/contracts/versions/update_contract_spec.rb
index a80ab2a32fea..b4ae8b5f1797 100644
--- a/spec/contracts/versions/update_contract_spec.rb
+++ b/spec/contracts/versions/update_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Versions::UpdateContract do
- it_behaves_like 'version contract' do
+ it_behaves_like "version contract" do
let(:version) do
build_stubbed(:version,
project: version_project,
@@ -47,39 +47,39 @@
subject(:contract) { described_class.new(version, current_user) }
- describe 'assignable_values' do
- context 'for project' do
- it 'is empty' do
+ describe "assignable_values" do
+ context "for project" do
+ it "is empty" do
expect(subject.assignable_values(:project, current_user))
.to be_empty
end
end
- context 'for status' do
- it 'is a list of all available status' do
+ context "for status" do
+ it "is a list of all available status" do
expect(subject.assignable_values(:status, current_user))
.to eql %w(open locked closed)
end
end
- context 'for sharing' do
- it 'is a list of values' do
+ context "for sharing" do
+ it "is a list of values" do
expect(subject.assignable_values(:sharing, current_user))
.to match_array %w(none descendants hierarchy tree)
end
- context 'if the user is admin' do
+ context "if the user is admin" do
let(:current_user) { build_stubbed(:admin) }
- it 'is a list of values' do
+ it "is a list of values" do
expect(subject.assignable_values(:sharing, current_user))
.to match_array %w(none descendants system hierarchy tree)
end
end
end
- context 'for something else' do
- it 'is nil' do
+ context "for something else" do
+ it "is nil" do
expect(subject.assignable_values(:start_date, current_user))
.to be_nil
end
diff --git a/spec/contracts/views/create_contract_work_packages_table_spec.rb b/spec/contracts/views/create_contract_work_packages_table_spec.rb
index 05167c53fb17..f3b749170c8c 100644
--- a/spec/contracts/views/create_contract_work_packages_table_spec.rb
+++ b/spec/contracts/views/create_contract_work_packages_table_spec.rb
@@ -26,48 +26,48 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Views::CreateContract do
- it_behaves_like 'view contract' do
+ it_behaves_like "view contract" do
let(:view) do
View.new(query: view_query,
type: view_type)
end
let(:view_type) do
- 'work_packages_table'
+ "work_packages_table"
end
subject(:contract) do
described_class.new(view, current_user)
end
- describe 'validation' do
- context 'with the type being nil' do
+ describe "validation" do
+ context "with the type being nil" do
let(:view_type) { nil }
- it_behaves_like 'contract is invalid', type: :inclusion
+ it_behaves_like "contract is invalid", type: :inclusion
end
- context 'with the type not being one of the configured' do
- let(:view_type) { 'blubs' }
+ context "with the type not being one of the configured" do
+ let(:view_type) { "blubs" }
- it_behaves_like 'contract is invalid', type: :inclusion
+ it_behaves_like "contract is invalid", type: :inclusion
end
- context 'with a work_packages_calendar view with the user having the permission to view_calendar' do
+ context "with a work_packages_calendar view with the user having the permission to view_calendar" do
let(:permissions) { %i[view_work_packages save_queries view_calendar] }
- let(:view_type) { 'work_packages_calendar' }
+ let(:view_type) { "work_packages_calendar" }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
- context 'with a work_packages_calendar view with the user not having the permission to view_calendar' do
+ context "with a work_packages_calendar view with the user not having the permission to view_calendar" do
let(:permissions) { %i[view_work_packages save_queries] }
- let(:view_type) { 'work_packages_calendar' }
+ let(:view_type) { "work_packages_calendar" }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
end
end
diff --git a/spec/contracts/views/shared_contract_examples.rb b/spec/contracts/views/shared_contract_examples.rb
index 90ebb53260e9..9431d711f74b 100644
--- a/spec/contracts/views/shared_contract_examples.rb
+++ b/spec/contracts/views/shared_contract_examples.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
-RSpec.shared_examples_for 'view contract' do |disabled_permission_checks|
- include_context 'ModelContract shared context'
+RSpec.shared_examples_for "view contract" do |disabled_permission_checks|
+ include_context "ModelContract shared context"
let(:current_user) { build_stubbed(:user) }
@@ -68,46 +68,46 @@
.and_return(query_visible)
end
- describe 'validation' do
- it_behaves_like 'contract is valid'
+ describe "validation" do
+ it_behaves_like "contract is valid"
- context 'with the query being nil' do
+ context "with the query being nil" do
let(:view_query) { nil }
- it_behaves_like 'contract is invalid', query: :blank
+ it_behaves_like "contract is invalid", query: :blank
end
- context 'with the query being invisible to the user' do
+ context "with the query being invisible to the user" do
let(:query_visible) { false }
- it_behaves_like 'contract is invalid', query: :does_not_exist
+ it_behaves_like "contract is invalid", query: :does_not_exist
end
- context 'with the query being private, the user being the query user and having the :save_queries permission' do
- it_behaves_like 'contract is valid'
+ context "with the query being private, the user being the query user and having the :save_queries permission" do
+ it_behaves_like "contract is valid"
end
unless disabled_permission_checks
- context 'with the query being private, the user being the query user and not having the :save_queries permission' do
+ context "with the query being private, the user being the query user and not having the :save_queries permission" do
let(:permissions) { %i[view_work_packages] }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
- context 'with the query being public, the user being the query user but only having the :save_queries permission' do
+ context "with the query being public, the user being the query user but only having the :save_queries permission" do
let(:query_public) { true }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
- context 'with the query being public, the user not being the query user but having the :manage_public_queries permission' do
+ context "with the query being public, the user not being the query user but having the :manage_public_queries permission" do
let(:query_public) { true }
let(:permissions) { %i[view_work_packages manage_public_queries] }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
end
end
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
diff --git a/spec/contracts/views/update_contract_spec.rb b/spec/contracts/views/update_contract_spec.rb
index 613203a5e233..c0ea4e071261 100644
--- a/spec/contracts/views/update_contract_spec.rb
+++ b/spec/contracts/views/update_contract_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe Views::UpdateContract do
# TODO: this is just a stub to ensure that the type is not altered
- it_behaves_like 'view contract' do
+ it_behaves_like "view contract" do
let(:view) do
build_stubbed(:view_work_packages_table).tap do |view|
view.type = view_type if defined?(view_type)
@@ -43,11 +43,11 @@
described_class.new(view, current_user)
end
- describe 'validation' do
- context 'with the type being changed' do
- let(:view_type) { 'team_planner' }
+ describe "validation" do
+ context "with the type being changed" do
+ let(:view_type) { "team_planner" }
- it_behaves_like 'contract is invalid', type: %i[error_readonly]
+ it_behaves_like "contract is invalid", type: %i[error_readonly]
end
end
end
diff --git a/spec/contracts/wiki_pages/create_contract_spec.rb b/spec/contracts/wiki_pages/create_contract_spec.rb
index a24d078eae42..fc8a18f47720 100644
--- a/spec/contracts/wiki_pages/create_contract_spec.rb
+++ b/spec/contracts/wiki_pages/create_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe WikiPages::CreateContract do
- it_behaves_like 'wiki page contract' do
+ it_behaves_like "wiki page contract" do
subject(:contract) { described_class.new(page, current_user, options: {}) }
let(:page) do
@@ -58,19 +58,19 @@
end
end
- describe '#validation' do
- context 'if the author is different from the current user' do
+ describe "#validation" do
+ context "if the author is different from the current user" do
let(:page_author) { build_stubbed(:user) }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, author: :not_current_user)
end
end
- context 'if the author was not set by system' do
+ context "if the author was not set by system" do
let(:changed_by_system) { {} }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, author_id: %i(error_readonly))
end
end
diff --git a/spec/contracts/wiki_pages/shared_contract_examples.rb b/spec/contracts/wiki_pages/shared_contract_examples.rb
index 3eb5bf8ee70d..83648b9fc651 100644
--- a/spec/contracts/wiki_pages/shared_contract_examples.rb
+++ b/spec/contracts/wiki_pages/shared_contract_examples.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.shared_examples_for 'wiki page contract' do
+RSpec.shared_examples_for "wiki page contract" do
let(:current_user) { build_stubbed(:user) }
before do
@@ -39,11 +39,11 @@
let(:page_wiki) { build_stubbed(:wiki) }
let(:page_author) { current_user }
- let(:page_title) { 'Wiki title' }
- let(:page_slug) { 'wiki slug' }
+ let(:page_title) { "Wiki title" }
+ let(:page_slug) { "wiki slug" }
let(:page_protected) { false }
let(:page_parent) { nil }
- let(:page_text) { 'Wiki text' }
+ let(:page_text) { "Wiki text" }
let(:permissions) { %i[view_wiki_pages edit_wiki_pages] }
def expect_valid(valid, symbols = {})
@@ -54,53 +54,53 @@ def expect_valid(valid, symbols = {})
end
end
- describe 'validation' do
- shared_examples 'is valid' do
- it 'is valid' do
+ describe "validation" do
+ shared_examples "is valid" do
+ it "is valid" do
expect_valid(true)
end
end
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
- context 'if the title is nil' do
+ context "if the title is nil" do
let(:page_title) { nil }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, title: :blank)
end
end
- context 'if the slug is nil' do
+ context "if the slug is nil" do
let(:page_slug) { nil }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if the wiki is nil' do
+ context "if the wiki is nil" do
let(:page_wiki) { nil }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, wiki: :blank)
end
end
- context 'if the parent is in the same wiki' do
+ context "if the parent is in the same wiki" do
let(:page_parent) { build_stubbed(:wiki_page, wiki: page_wiki) }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if the parent is in a different wiki' do
+ context "if the parent is in a different wiki" do
let(:page_parent) { build_stubbed(:wiki_page) }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, parent_title: :not_same_project)
end
end
- context 'if the parent is a child of the page (circular dependency)' do
- it 'is invalid' do
+ context "if the parent is a child of the page (circular dependency)" do
+ it "is invalid" do
page.parent = build_stubbed(:wiki_page, wiki: page_wiki).tap do |parent|
# Using stubbing here to avoid infinite loops
allow(parent)
@@ -112,41 +112,41 @@ def expect_valid(valid, symbols = {})
end
end
- context 'if the parent the page itself (circular dependency' do
- it 'is invalid' do
+ context "if the parent the page itself (circular dependency" do
+ it "is invalid" do
page.parent = page
expect_valid(false, parent_title: :circular_dependency)
end
end
- context 'if the author is nil' do
+ context "if the author is nil" do
let(:page_author) { nil }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, author: %i[blank not_current_user])
end
end
- context 'if the user lacks permission' do
+ context "if the user lacks permission" do
let(:permissions) { %i[view_wiki_pages] }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, base: :error_unauthorized)
end
end
- context 'if the page is protected and the user has permission to protect pages' do
+ context "if the page is protected and the user has permission to protect pages" do
let(:permissions) { %i[view_wiki_pages edit_wiki_pages protect_wiki_pages] }
let(:page_protected) { true }
- it_behaves_like 'is valid'
+ it_behaves_like "is valid"
end
- context 'if the page is protected and the user lacks permission to protect pages' do
+ context "if the page is protected and the user lacks permission to protect pages" do
let(:page_protected) { true }
- it 'is invalid' do
+ it "is invalid" do
expect_valid(false, protected: :error_unauthorized)
end
end
diff --git a/spec/contracts/work_package_members/create_contract_spec.rb b/spec/contracts/work_package_members/create_contract_spec.rb
index a48c3734ed00..291380cb657f 100644
--- a/spec/contracts/work_package_members/create_contract_spec.rb
+++ b/spec/contracts/work_package_members/create_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe WorkPackageMembers::CreateContract do
- it_behaves_like 'work package member contract' do
+ it_behaves_like "work package member contract" do
let(:member) do
Member.new(roles: member_roles,
principal: member_principal,
@@ -46,52 +46,52 @@
let(:contract) { described_class.new(member, current_user) }
- describe 'validation' do
- context 'if the principal is nil' do
+ describe "validation" do
+ context "if the principal is nil" do
let(:member_principal) { nil }
- it_behaves_like 'contract is invalid', principal: :blank
+ it_behaves_like "contract is invalid", principal: :blank
end
- context 'if the principal is a locked user' do
+ context "if the principal is a locked user" do
let(:member_principal) { build_stubbed(:locked_user) }
- it_behaves_like 'contract is invalid', principal: :unassignable
+ it_behaves_like "contract is invalid", principal: :unassignable
end
- context 'if the principal is a builtin user' do
+ context "if the principal is a builtin user" do
let(:member_principal) { build_stubbed(:anonymous) }
- it_behaves_like 'contract is invalid', principal: :unassignable
+ it_behaves_like "contract is invalid", principal: :unassignable
end
- context 'if the project is nil' do
+ context "if the project is nil" do
let(:member_project) { nil }
- it_behaves_like 'contract is invalid', project: :blank
+ it_behaves_like "contract is invalid", project: :blank
end
- context 'if the project is not set by the system' do
+ context "if the project is not set by the system" do
before do
member.project = build_stubbed(:project)
end
- it_behaves_like 'contract is invalid', project_id: :error_readonly
+ it_behaves_like "contract is invalid", project_id: :error_readonly
end
- context 'if the entity is nil' do
+ context "if the entity is nil" do
let(:member_entity) { nil }
let(:member_project) { build_stubbed(:project) }
- it_behaves_like 'contract is invalid', entity: :blank
+ it_behaves_like "contract is invalid", entity: :blank
end
- context 'if the entity is something else' do
+ context "if the entity is something else" do
before do
- member.entity_type = 'Meeting'
+ member.entity_type = "Meeting"
end
- it_behaves_like 'contract is invalid', entity_type: :inclusion
+ it_behaves_like "contract is invalid", entity_type: :inclusion
end
end
end
diff --git a/spec/contracts/work_package_members/shared_contract_examples.rb b/spec/contracts/work_package_members/shared_contract_examples.rb
index ecf5a3f8e83b..fe14e69d2afe 100644
--- a/spec/contracts/work_package_members/shared_contract_examples.rb
+++ b/spec/contracts/work_package_members/shared_contract_examples.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
-require 'contracts/shared/model_contract_shared_context'
+require "spec_helper"
+require "contracts/shared/model_contract_shared_context"
-RSpec.shared_examples_for 'work package member contract' do
- include_context 'ModelContract shared context'
+RSpec.shared_examples_for "work package member contract" do
+ include_context "ModelContract shared context"
let(:current_user) { build_stubbed(:user, admin: current_user_admin) }
before do
@@ -57,44 +57,44 @@
let(:permissions) { [:share_work_packages] }
let(:current_user_admin) { false }
- describe 'validation' do
- it_behaves_like 'contract is valid'
+ describe "validation" do
+ it_behaves_like "contract is valid"
- context 'if the roles are nil' do
+ context "if the roles are nil" do
let(:member_roles) { [] }
- it_behaves_like 'contract is invalid', roles: :role_blank
+ it_behaves_like "contract is invalid", roles: :role_blank
end
- context 'if any role is not assignable (e.g. builtin)' do
+ context "if any role is not assignable (e.g. builtin)" do
let(:member_roles) do
[build_stubbed(:project_role)]
end
- it_behaves_like 'contract is invalid', roles: :ungrantable
+ it_behaves_like "contract is invalid", roles: :ungrantable
end
- context 'if the principal is the current user' do
+ context "if the principal is the current user" do
let(:member_principal) { current_user }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
- context 'if more than one non-inherited role is assigned' do
+ context "if more than one non-inherited role is assigned" do
let(:member_roles) do
[build_stubbed(:view_work_package_role), build_stubbed(:comment_work_package_role)]
end
- it_behaves_like 'contract is invalid', roles: :more_than_one
+ it_behaves_like "contract is invalid", roles: :more_than_one
end
- context 'if the user lacks :share_work_packages permission in the project' do
+ context "if the user lacks :share_work_packages permission in the project" do
# This permission would work for a project member.
let(:permissions) { [:manage_members] }
- it_behaves_like 'contract is invalid', base: :error_unauthorized
+ it_behaves_like "contract is invalid", base: :error_unauthorized
end
end
- include_examples 'contract reuses the model errors'
+ include_examples "contract reuses the model errors"
end
diff --git a/spec/contracts/work_package_members/update_contract_spec.rb b/spec/contracts/work_package_members/update_contract_spec.rb
index 970970e2e509..707e3b021b11 100644
--- a/spec/contracts/work_package_members/update_contract_spec.rb
+++ b/spec/contracts/work_package_members/update_contract_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
-require_relative 'shared_contract_examples'
+require "spec_helper"
+require_relative "shared_contract_examples"
RSpec.describe WorkPackageMembers::UpdateContract do
- it_behaves_like 'work package member contract' do
+ it_behaves_like "work package member contract" do
let(:member) do
build_stubbed(:work_package_member,
project: member_project,
@@ -41,35 +41,35 @@
let(:contract) { described_class.new(member, current_user) }
- describe 'validation' do
- context 'if the principal is changed' do
+ describe "validation" do
+ context "if the principal is changed" do
before do
member.principal = build_stubbed(:user)
end
- it_behaves_like 'contract is invalid', principal: :error_readonly
+ it_behaves_like "contract is invalid", principal: :error_readonly
end
- context 'if the project is changed' do
+ context "if the project is changed" do
before do
member.project = build_stubbed(:project)
end
- it_behaves_like 'contract is invalid', project_id: :error_readonly
+ it_behaves_like "contract is invalid", project_id: :error_readonly
end
- context 'if the entity is changed' do
+ context "if the entity is changed" do
before do
member.entity = build_stubbed(:work_package)
end
- it_behaves_like 'contract is invalid', entity_id: :error_readonly
+ it_behaves_like "contract is invalid", entity_id: :error_readonly
end
- context 'if the principal is a locked user' do
+ context "if the principal is a locked user" do
let(:member_principal) { build_stubbed(:locked_user) }
- it_behaves_like 'contract is valid'
+ it_behaves_like "contract is valid"
end
end
end
diff --git a/spec/contracts/work_packages/create_note_contract_spec.rb b/spec/contracts/work_packages/create_note_contract_spec.rb
index 67270182fe88..fc8c55797d2e 100644
--- a/spec/contracts/work_packages/create_note_contract_spec.rb
+++ b/spec/contracts/work_packages/create_note_contract_spec.rb
@@ -25,7 +25,7 @@
#
# See COPYRIGHT and LICENSE files for more details.
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WorkPackages::CreateNoteContract do
let(:work_package) do
@@ -39,55 +39,55 @@
wp
end
let(:user) { build_stubbed(:user) }
- let(:policy_instance) { double('WorkPackagePolicyInstance') }
+ let(:policy_instance) { double("WorkPackagePolicyInstance") }
subject(:contract) do
contract = described_class.new(work_package, user)
- contract.send(:'policy=', policy_instance)
+ contract.send(:"policy=", policy_instance)
contract
end
- describe 'note' do
+ describe "note" do
before do
- work_package.journal_notes = 'blubs'
+ work_package.journal_notes = "blubs"
end
- context 'if the user has the permissions' do
+ context "if the user has the permissions" do
before do
allow(policy_instance).to receive(:allowed?).with(work_package, :comment).and_return true
contract.validate
end
- it('is valid') { expect(contract.errors).to be_empty }
+ it("is valid") { expect(contract.errors).to be_empty }
end
- context 'if the user lacks the permissions' do
+ context "if the user lacks the permissions" do
before do
allow(policy_instance).to receive(:allowed?).with(work_package, :comment).and_return false
contract.validate
end
- it 'is invalid' do
+ it "is invalid" do
expect(contract.errors.symbols_for(:journal_notes))
.to contain_exactly(:error_unauthorized)
end
end
end
- describe 'subject' do
+ describe "subject" do
before do
- work_package.subject = 'blubs'
+ work_package.subject = "blubs"
allow(policy_instance).to receive(:allowed?).and_return true
contract.validate
end
- it 'is invalid' do
+ it "is invalid" do
expect(contract.errors.symbols_for(:subject))
.to contain_exactly(:error_readonly)
end
diff --git a/spec/contracts/work_packages/shared_base_contract.rb b/spec/contracts/work_packages/shared_base_contract.rb
index 791531b2f87d..163865dfc4c1 100644
--- a/spec/contracts/work_packages/shared_base_contract.rb
+++ b/spec/contracts/work_packages/shared_base_contract.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-RSpec.shared_examples_for 'work package contract' do
+RSpec.shared_examples_for "work package contract" do
let(:user) { build_stubbed(:user) }
let(:other_user) { build_stubbed(:user) }
let(:policy) { double(WorkPackagePolicy, allowed?: true) }
@@ -47,7 +47,7 @@
let(:possible_assignees) { [] }
let!(:assignable_assignees_scope) do
- scope = double 'assignable assignees scope'
+ scope = double "assignable assignees scope"
if work_package.persisted?
allow(Principal)
@@ -69,73 +69,73 @@
scope
end
- shared_examples_for 'has no error on' do |property|
+ shared_examples_for "has no error on" do |property|
it property do
expect(validated_contract.errors[property]).to be_empty
end
end
- describe 'assigned_to_id' do
+ describe "assigned_to_id" do
before do
work_package.assigned_to_id = other_user.id
end
- context 'if the assigned user is a possible assignee' do
+ context "if the assigned user is a possible assignee" do
let(:possible_assignees) { [other_user] }
- it_behaves_like 'has no error on', :assigned_to
+ it_behaves_like "has no error on", :assigned_to
end
- context 'if the assigned user is not a possible assignee' do
- it 'is not a valid assignee' do
- error = I18n.t('api_v3.errors.validation.invalid_user_assigned_to_work_package',
- property: I18n.t('attributes.assignee'))
+ context "if the assigned user is not a possible assignee" do
+ it "is not a valid assignee" do
+ error = I18n.t("api_v3.errors.validation.invalid_user_assigned_to_work_package",
+ property: I18n.t("attributes.assignee"))
expect(validated_contract.errors[:assigned_to]).to contain_exactly(error)
end
end
- context 'if the project is not set' do
+ context "if the project is not set" do
let(:work_package_project) { nil }
- it_behaves_like 'has no error on', :assigned_to
+ it_behaves_like "has no error on", :assigned_to
end
end
- describe 'responsible_id' do
+ describe "responsible_id" do
before do
work_package.responsible_id = other_user.id
end
- context 'if the responsible user is a possible responsible' do
+ context "if the responsible user is a possible responsible" do
let(:possible_assignees) { [other_user] }
- it_behaves_like 'has no error on', :responsible
+ it_behaves_like "has no error on", :responsible
end
- context 'if the assigned user is not a possible responsible' do
- it 'is not a valid responsible' do
- error = I18n.t('api_v3.errors.validation.invalid_user_assigned_to_work_package',
- property: I18n.t('attributes.responsible'))
+ context "if the assigned user is not a possible responsible" do
+ it "is not a valid responsible" do
+ error = I18n.t("api_v3.errors.validation.invalid_user_assigned_to_work_package",
+ property: I18n.t("attributes.responsible"))
expect(validated_contract.errors[:responsible]).to contain_exactly(error)
end
end
- context 'if the project is not set' do
+ context "if the project is not set" do
let(:work_package_project) { nil }
- it_behaves_like 'has no error on', :responsible
+ it_behaves_like "has no error on", :responsible
end
end
- describe '#assignable_assignees' do
- it 'returns the Principal`s possible_assignee scope' do
+ describe "#assignable_assignees" do
+ it "returns the Principal`s possible_assignee scope" do
expect(subject.assignable_assignees)
.to eql assignable_assignees_scope
end
end
- describe '#assignable_responsibles' do
- it 'returns the Principal`s possible_assignee scope' do
+ describe "#assignable_responsibles" do
+ it "returns the Principal`s possible_assignee scope" do
expect(subject.assignable_responsibles)
.to eql assignable_assignees_scope
end
diff --git a/spec/contracts/work_packages/update_contract_spec.rb b/spec/contracts/work_packages/update_contract_spec.rb
index d98772abd06c..888bca9959e9 100644
--- a/spec/contracts/work_packages/update_contract_spec.rb
+++ b/spec/contracts/work_packages/update_contract_spec.rb
@@ -25,8 +25,8 @@
#
# See COPYRIGHT and LICENSE files for more details.
-require 'spec_helper'
-require 'contracts/work_packages/shared_base_contract'
+require "spec_helper"
+require "contracts/work_packages/shared_base_contract"
RSpec.describe WorkPackages::UpdateContract do
shared_let(:persistent_project) { create(:project, public: false) }
@@ -37,7 +37,7 @@
project: work_package_project,
type:,
status:) do |wp|
- wp_scope = double('wp scope')
+ wp_scope = double("wp scope")
allow(WorkPackage)
.to receive(:visible)
@@ -62,15 +62,15 @@
subject(:contract) { described_class.new(work_package, user) }
- it_behaves_like 'work package contract' do
+ it_behaves_like "work package contract" do
let(:work_package) do
build_stubbed(:work_package,
project: work_package_project)
end
end
- describe 'lock_version' do
- context 'no lock_version present' do
+ describe "lock_version" do
+ context "no lock_version present" do
before do
work_package.lock_version = nil
contract.validate
@@ -79,7 +79,7 @@
it { expect(contract.errors.symbols_for(:base)).to include(:error_conflict) }
end
- context 'lock_version changed' do
+ context "lock_version changed" do
before do
work_package.lock_version += 1
contract.validate
@@ -88,7 +88,7 @@
it { expect(contract.errors.symbols_for(:base)).to include(:error_conflict) }
end
- context 'lock_version present and unchanged' do
+ context "lock_version present and unchanged" do
before do
contract.validate
end
@@ -97,7 +97,7 @@
end
end
- describe 'authorization' do
+ describe "authorization" do
let(:attributes) { {} }
before do
@@ -105,54 +105,54 @@
contract.validate
end
- context 'full access' do
- it 'is valid' do
+ context "full access" do
+ it "is valid" do
expect(contract.errors).to be_empty
end
end
- context 'no read access' do
+ context "no read access" do
let(:permissions) { [:edit_work_packages] }
it { expect(contract.errors.symbols_for(:base)).to include(:error_not_found) }
end
- context 'no write access' do
+ context "no write access" do
let(:permissions) { [:view_work_packages] }
it { expect(contract.errors.symbols_for(:base)).to include(:error_unauthorized) }
end
- context 'only comment permission' do
+ context "only comment permission" do
let(:permissions) { %i[view_work_packages add_work_package_notes] }
- context 'when only adding a journal' do
- let(:attributes) { { journal_notes: 'some notes' } }
+ context "when only adding a journal" do
+ let(:attributes) { { journal_notes: "some notes" } }
- it 'is valid' do
+ it "is valid" do
expect(contract.errors).to be_empty
end
end
- context 'when changing more than a journal' do
- let(:attributes) { { journal_notes: 'some notes', subject: 'blubs' } }
+ context "when changing more than a journal" do
+ let(:attributes) { { journal_notes: "some notes", subject: "blubs" } }
- it 'is invalid' do
+ it "is invalid" do
expect(contract.errors.symbols_for(:base)).to include(:error_unauthorized)
end
end
end
- context 'only assign_versions permission' do
+ context "only assign_versions permission" do
let(:permissions) { %i[view_work_packages assign_versions] }
- it 'is valid' do
+ it "is valid" do
expect(contract.errors).to be_empty
end
end
end
- describe 'project_id' do
+ describe "project_id" do
let(:target_project) { create(:project, types: [type]) }
let(:target_permissions) { [:move_work_packages] }
@@ -175,20 +175,20 @@
contract.validate
end
- context 'if the user has the permissions' do
- it('is valid') { expect(contract.errors).to be_empty }
+ context "if the user has the permissions" do
+ it("is valid") { expect(contract.errors).to be_empty }
end
- context 'if the user lacks the permissions' do
+ context "if the user lacks the permissions" do
let(:target_permissions) { [] }
- it 'is invalid' do
+ it "is invalid" do
expect(contract.errors.symbols_for(:project_id)).to contain_exactly(:error_readonly)
end
end
end
- describe 'version' do
+ describe "version" do
let(:version) { build_stubbed(:version) }
before do
@@ -201,32 +201,32 @@
contract.validate
end
- context 'having full access' do
- context 'with an assignable_version' do
+ context "having full access" do
+ context "with an assignable_version" do
let(:attributes) { { version_id: version.id } }
- it 'is valid' do
+ it "is valid" do
expect(contract.errors).to be_empty
end
end
- context 'with an unassignable_version' do
+ context "with an unassignable_version" do
let(:attributes) { { version_id: version.id + 1 } }
- it 'adds an error' do
+ it "adds an error" do
expect(contract.errors.symbols_for(:version_id))
.to include(:inclusion)
end
end
end
- context 'write access' do
+ context "write access" do
let(:permissions) { %i[view_work_packages edit_work_packages] }
- context 'if assigning a version' do
+ context "if assigning a version" do
let(:attributes) { { version_id: version.id } }
- it 'adds an error' do
+ it "adds an error" do
expect(contract.errors.symbols_for(:version_id))
.to include(:error_readonly)
end
@@ -234,8 +234,8 @@
end
end
- describe 'ignore_non_working_days' do
- context 'when having children and not being scheduled manually' do
+ describe "ignore_non_working_days" do
+ context "when having children and not being scheduled manually" do
before do
allow(work_package)
.to receive(:leaf?)
@@ -247,13 +247,13 @@
contract.validate
end
- it 'is invalid' do
+ it "is invalid" do
expect(contract.errors.symbols_for(:ignore_non_working_days))
.to contain_exactly(:error_readonly)
end
end
- context 'when having children and being scheduled manually' do
+ context "when having children and being scheduled manually" do
before do
allow(work_package)
.to receive(:leaf?)
@@ -265,14 +265,14 @@
contract.validate
end
- it 'is valid' do
+ it "is valid" do
expect(contract.errors).to be_empty
end
end
end
- describe 'with children' do
- context 'changing to milestone' do
+ describe "with children" do
+ context "changing to milestone" do
let(:milestone) { build_stubbed(:type, is_milestone: true) }
let(:children) { [build_stubbed(:work_package)] }
@@ -282,13 +282,13 @@
contract.validate
end
- it 'adds an error because cannot change to milestone with children' do
+ it "adds an error because cannot change to milestone with children" do
expect(contract.errors.symbols_for(:type)).to include(:cannot_be_milestone_due_to_children)
end
end
end
- describe 'parent_id' do
+ describe "parent_id" do
shared_let(:parent) { create(:work_package) }
let(:parent_visible) { true }
@@ -299,18 +299,18 @@
contract.validate
end
- context 'if the user has only edit permissions' do
+ context "if the user has only edit permissions" do
it { expect(contract.errors.symbols_for(:parent_id)).to include(:error_readonly) }
end
- context 'if the user has edit and subtasks permissions' do
+ context "if the user has edit and subtasks permissions" do
let(:permissions) { %i[edit_work_packages view_work_packages manage_subtasks] }
- it('is valid') do
+ it("is valid") do
expect(contract.errors).to be_empty
end
- describe 'invalid lock version' do
+ describe "invalid lock version" do
before do
work_package.lock_version = 9999
contract.validate
@@ -320,22 +320,22 @@
end
end
- context 'no write access' do
+ context "no write access" do
let(:permissions) { [:view_work_packages] }
it { expect(contract.errors.symbols_for(:parent_id)).to include(:error_readonly) }
end
- context 'with manage_subtasks permission' do
+ context "with manage_subtasks permission" do
let(:permissions) { %i[view_work_packages manage_subtasks] }
- it('is valid') do
+ it("is valid") do
expect(contract.errors).to be_empty
end
- describe 'changing more than the parent_id' do
+ describe "changing more than the parent_id" do
before do
- work_package.subject = 'Foobar!'
+ work_package.subject = "Foobar!"
contract.validate
end
@@ -343,46 +343,46 @@
end
end
- context 'when the user does not have access to the parent' do
+ context "when the user does not have access to the parent" do
let(:parent_visible) { false }
it { expect(contract.errors.symbols_for(:parent_id)).to include(:error_unauthorized) }
end
end
- describe '#writable_attributes' do
+ describe "#writable_attributes" do
subject { contract.writable_attributes }
- context 'for a user having only the edit_work_packages permission' do
+ context "for a user having only the edit_work_packages permission" do
let(:permissions) { %i[edit_work_packages] }
- it 'includes all attributes except version_id' do
+ it "includes all attributes except version_id" do
expect(subject)
- .to include('subject', 'start_date', 'description')
+ .to include("subject", "start_date", "description")
expect(subject)
- .not_to include('version_id', 'version')
+ .not_to include("version_id", "version")
end
end
- context 'for a user having only the assign_versions permission' do
+ context "for a user having only the assign_versions permission" do
let(:permissions) { %i[assign_versions] }
- it 'includes all attributes except version_id' do
+ it "includes all attributes except version_id" do
expect(subject)
- .to include('version_id', 'version')
+ .to include("version_id", "version")
expect(subject)
- .not_to include('subject', 'start_date', 'description')
+ .not_to include("subject", "start_date", "description")
end
end
end
- describe 'readonly status' do
- context 'with the status being readonly', with_ee: %i[readonly_work_packages] do
+ describe "readonly status" do
+ context "with the status being readonly", with_ee: %i[readonly_work_packages] do
let(:status) { build_stubbed(:status, is_readonly: true) }
- describe 'updating the priority' do
+ describe "updating the priority" do
let(:new_priority) { build_stubbed(:priority) }
before do
@@ -391,79 +391,79 @@
contract.validate
end
- it 'is invalid' do
+ it "is invalid" do
expect(contract)
.not_to be_valid
end
- it 'adds an error to the written to attribute' do
+ it "adds an error to the written to attribute" do
expect(contract.errors.symbols_for(:priority_id))
.to include(:error_readonly)
end
- it 'adds an error to base to better explain' do
+ it "adds an error to base to better explain" do
expect(contract.errors.symbols_for(:base))
.to include(:readonly_status)
end
end
- describe 'updating the custom field values' do
+ describe "updating the custom field values" do
let(:cf1) { create(:string_wp_custom_field) }
before do
work_package_project.work_package_custom_fields << cf1
type.custom_fields << cf1
- work_package.custom_field_values = { cf1.id => 'test' }
+ work_package.custom_field_values = { cf1.id => "test" }
contract.validate
end
- shared_examples_for 'custom_field readonly errors' do
- it 'adds an error to the written custom field attribute' do
+ shared_examples_for "custom_field readonly errors" do
+ it "adds an error to the written custom field attribute" do
expect(contract.errors.symbols_for(cf1.attribute_name.to_sym))
.to include(:error_readonly)
end
- it 'adds an error to base to better explain' do
+ it "adds an error to base to better explain" do
expect(contract.errors.symbols_for(:base))
.to include(:readonly_status)
end
end
- context 'when the subject does not extends OpenProject::ChangedBySystem' do
- include_examples 'custom_field readonly errors'
+ context "when the subject does not extends OpenProject::ChangedBySystem" do
+ include_examples "custom_field readonly errors"
end
- context 'when the subject extends OpenProject::ChangedBySystem' do
+ context "when the subject extends OpenProject::ChangedBySystem" do
before do
work_package.extend(OpenProject::ChangedBySystem)
end
- include_examples 'custom_field readonly errors'
+ include_examples "custom_field readonly errors"
end
end
end
end
- describe 'remaining hours' do
- context 'when is not a parent' do
+ describe "remaining hours" do
+ context "when is not a parent" do
before do
contract.validate
end
- context 'when has not changed' do
- it('is valid') { expect(contract.errors.empty?).to be true }
+ context "when has not changed" do
+ it("is valid") { expect(contract.errors.empty?).to be true }
end
- context 'when has changed' do
+ context "when has changed" do
before do
work_package.remaining_hours = 10
end
- it('is valid') { expect(contract.errors.empty?).to be true }
+ it("is valid") { expect(contract.errors.empty?).to be true }
end
end
- context 'when is a parent' do
+ context "when is a parent" do
let(:work_package) do
build_stubbed(:work_package,
project: work_package_project,
@@ -488,16 +488,16 @@
contract.validate
end
- context 'when has not changed' do
- it('is valid') { expect(contract.errors.empty?).to be true }
+ context "when has not changed" do
+ it("is valid") { expect(contract.errors.empty?).to be true }
end
- context 'when has changed' do
+ context "when has changed" do
before do
work_package.remaining_hours = 10
end
- it('is valid') { expect(contract.errors.empty?).to be true }
+ it("is valid") { expect(contract.errors.empty?).to be true }
end
end
end
diff --git a/spec/controllers/account_controller_spec.rb b/spec/controllers/account_controller_spec.rb
index 0b106959222b..00f6d528e6bf 100644
--- a/spec/controllers/account_controller_spec.rb
+++ b/spec/controllers/account_controller_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe AccountController, :skip_2fa_stage do
let(:user_hook_class) do
@@ -57,69 +57,69 @@ def reset!
hook.reset!
end
- describe 'GET #login' do
+ describe "GET #login" do
let(:params) { {} }
- context 'when the user is not already logged in' do
+ context "when the user is not already logged in" do
before do
get :login, params:
end
- it 'renders the view' do
- expect(response).to render_template 'login'
+ it "renders the view" do
+ expect(response).to render_template "login"
expect(response).to be_successful
end
end
- context 'when the user is already logged in' do
+ context "when the user is already logged in" do
before do
login_as user
get :login, params:
end
- it 'redirects to home' do
+ it "redirects to home" do
expect(response)
.to redirect_to my_page_path
end
- context 'and a valid back url is present' do
+ context "and a valid back url is present" do
let(:params) { { back_url: "/projects" } }
- it 'redirects to back_url value' do
+ it "redirects to back_url value" do
expect(response)
.to redirect_to projects_path
end
end
- context 'and an invalid back url present' do
- let(:params) { { back_url: 'http://test.foo/work_packages/show/1' } }
+ context "and an invalid back url present" do
+ let(:params) { { back_url: "http://test.foo/work_packages/show/1" } }
- it 'redirects to home' do
+ it "redirects to home" do
expect(response).to redirect_to my_page_path
end
end
end
end
- describe 'GET #internal_login' do
+ describe "GET #internal_login" do
shared_let(:admin) { create(:admin) }
- context 'when direct login enabled', with_config: { omniauth_direct_login_provider: 'some_provider' } do
- it 'allows to login internally using a special route' do
+ context "when direct login enabled", with_config: { omniauth_direct_login_provider: "some_provider" } do
+ it "allows to login internally using a special route" do
get :internal_login
- expect(response).to render_template 'account/login'
+ expect(response).to render_template "account/login"
end
- it 'allows to post to login' do
- post :login, params: { username: admin.login, password: 'adminADMIN!' }
- expect(response).to redirect_to '/my/page'
+ it "allows to post to login" do
+ post :login, params: { username: admin.login, password: "adminADMIN!" }
+ expect(response).to redirect_to "/my/page"
end
end
- context 'when direct login disabled' do
- it 'the internal login route is inactive' do
+ context "when direct login disabled" do
+ it "the internal login route is inactive" do
get :internal_login
expect(response).to have_http_status(:not_found)
@@ -128,171 +128,171 @@ def reset!
end
end
- describe 'POST #login' do
+ describe "POST #login" do
shared_let(:admin) { create(:admin) }
- describe 'wrong password' do
- it 'redirects back to login' do
- post :login, params: { username: 'admin', password: 'bad' }
+ describe "wrong password" do
+ it "redirects back to login" do
+ post :login, params: { username: "admin", password: "bad" }
expect(response).to be_successful
- expect(response).to render_template 'login'
- expect(flash[:error]).to include 'Invalid user or password'
+ expect(response).to render_template "login"
+ expect(flash[:error]).to include "Invalid user or password"
end
end
- context 'with first login' do
+ context "with first login" do
before do
admin.update first_login: true
- post :login, params: { username: admin.login, password: 'adminADMIN!' }
+ post :login, params: { username: admin.login, password: "adminADMIN!" }
end
- it 'redirect to default path with ?first_time_user=true' do
+ it "redirect to default path with ?first_time_user=true" do
expect(response).to redirect_to "/?first_time_user=true"
end
- it 'calls the user_first_login hook' do
+ it "calls the user_first_login hook" do
expect(hook.first_login_user).to eq admin
end
end
- context 'without first login' do
+ context "without first login" do
before do
- post :login, params: { username: admin.login, password: 'adminADMIN!' }
+ post :login, params: { username: admin.login, password: "adminADMIN!" }
end
- it 'redirect to the my page' do
+ it "redirect to the my page" do
expect(response).to redirect_to "/my/page"
end
- it 'does not call the user_first_login hook' do
+ it "does not call the user_first_login hook" do
expect(hook.first_login_user).to be_nil
end
end
- describe 'User logging in with back_url' do
- it 'redirects to a relative path' do
+ describe "User logging in with back_url" do
+ it "redirects to a relative path" do
post :login,
- params: { username: admin.login, password: 'adminADMIN!', back_url: '/' }
+ params: { username: admin.login, password: "adminADMIN!", back_url: "/" }
expect(response).to redirect_to root_path
end
- it 'redirects to an absolute path given the same host' do
+ it "redirects to an absolute path given the same host" do
# note: test.host is the hostname during tests
post :login,
params: {
username: admin.login,
- password: 'adminADMIN!',
- back_url: 'http://test.host/work_packages/show/1'
+ password: "adminADMIN!",
+ back_url: "http://test.host/work_packages/show/1"
}
- expect(response).to redirect_to '/work_packages/show/1'
+ expect(response).to redirect_to "/work_packages/show/1"
end
- it 'does not redirect to another host' do
+ it "does not redirect to another host" do
post :login,
params: {
username: admin.login,
- password: 'adminADMIN!',
- back_url: 'http://test.foo/work_packages/show/1'
+ password: "adminADMIN!",
+ back_url: "http://test.foo/work_packages/show/1"
}
expect(response).to redirect_to my_page_path
end
- it 'does not redirect to another host with a protocol relative url' do
+ it "does not redirect to another host with a protocol relative url" do
post :login,
params: {
username: admin.login,
- password: 'adminADMIN!',
- back_url: '//test.foo/fake'
+ password: "adminADMIN!",
+ back_url: "//test.foo/fake"
}
expect(response).to redirect_to my_page_path
end
- it 'does not redirect to logout' do
+ it "does not redirect to logout" do
post :login,
params: {
username: admin.login,
- password: 'adminADMIN!',
- back_url: '/logout'
+ password: "adminADMIN!",
+ back_url: "/logout"
}
expect(response).to redirect_to my_page_path
end
- context 'with a relative url root' do
+ context "with a relative url root" do
around do |example|
- old_relative_url_root = OpenProject::Configuration['rails_relative_url_root']
- OpenProject::Configuration['rails_relative_url_root'] = '/openproject'
+ old_relative_url_root = OpenProject::Configuration["rails_relative_url_root"]
+ OpenProject::Configuration["rails_relative_url_root"] = "/openproject"
example.run
ensure
- OpenProject::Configuration['rails_relative_url_root'] = old_relative_url_root
+ OpenProject::Configuration["rails_relative_url_root"] = old_relative_url_root
end
- it 'redirects to the same subdirectory with an absolute path' do
+ it "redirects to the same subdirectory with an absolute path" do
post :login,
params: {
username: admin.login,
- password: 'adminADMIN!',
- back_url: 'http://test.host/openproject/work_packages/show/1'
+ password: "adminADMIN!",
+ back_url: "http://test.host/openproject/work_packages/show/1"
}
- expect(response).to redirect_to '/openproject/work_packages/show/1'
+ expect(response).to redirect_to "/openproject/work_packages/show/1"
end
- it 'redirects to the same subdirectory with a relative path' do
+ it "redirects to the same subdirectory with a relative path" do
post :login,
params: {
username: admin.login,
- password: 'adminADMIN!',
- back_url: '/openproject/work_packages/show/1'
+ password: "adminADMIN!",
+ back_url: "/openproject/work_packages/show/1"
}
- expect(response).to redirect_to '/openproject/work_packages/show/1'
+ expect(response).to redirect_to "/openproject/work_packages/show/1"
end
- it 'does not redirect to another subdirectory with an absolute path' do
+ it "does not redirect to another subdirectory with an absolute path" do
post :login,
params: {
username: admin.login,
- password: 'adminADMIN!',
- back_url: 'http://test.host/foo/work_packages/show/1'
+ password: "adminADMIN!",
+ back_url: "http://test.host/foo/work_packages/show/1"
}
expect(response).to redirect_to my_page_path
end
- it 'does not redirect to another subdirectory with a relative path' do
+ it "does not redirect to another subdirectory with a relative path" do
post :login,
params: {
username: admin.login,
- password: 'adminADMIN!',
- back_url: '/foo/work_packages/show/1'
+ password: "adminADMIN!",
+ back_url: "/foo/work_packages/show/1"
}
expect(response).to redirect_to my_page_path
end
- it 'does not redirect to another subdirectory by going up the path hierarchy' do
+ it "does not redirect to another subdirectory by going up the path hierarchy" do
post :login,
params: {
username: admin.login,
- password: 'adminADMIN!',
- back_url: 'http://test.host/openproject/../foo/work_packages/show/1'
+ password: "adminADMIN!",
+ back_url: "http://test.host/openproject/../foo/work_packages/show/1"
}
expect(response).to redirect_to my_page_path
end
- it 'does not redirect to another subdirectory with a protocol relative path' do
+ it "does not redirect to another subdirectory with a protocol relative path" do
post :login,
params: {
username: admin.login,
- password: 'adminADMIN!',
- back_url: '//test.host/foo/work_packages/show/1'
+ password: "adminADMIN!",
+ back_url: "//test.host/foo/work_packages/show/1"
}
expect(response).to redirect_to my_page_path
end
end
end
- describe 'GET #logout' do
+ describe "GET #logout" do
shared_let(:admin) { create(:admin) }
- it 'calls reset_session' do
+ it "calls reset_session" do
allow(controller).to receive(:reset_session)
login_as admin
@@ -302,11 +302,11 @@ def reset!
expect(response).to be_redirect
end
- context 'with a user with an SSO provider attached' do
- let(:user) { build_stubbed(:user, login: 'bob', identity_url: 'saml:foo') }
+ context "with a user with an SSO provider attached" do
+ let(:user) { build_stubbed(:user, login: "bob", identity_url: "saml:foo") }
let(:slo_callback) { nil }
let(:sso_provider) do
- { name: 'saml', single_sign_out_callback: slo_callback }
+ { name: "saml", single_sign_out_callback: slo_callback }
end
before do
@@ -316,50 +316,50 @@ def reset!
login_as user
end
- context 'with no provider' do
- it 'redirects to default' do
+ context "with no provider" do
+ it "redirects to default" do
get :logout
expect(response).to redirect_to home_path
end
end
- context 'with a redirecting callback' do
+ context "with a redirecting callback" do
let(:slo_callback) do
Proc.new do |prev_session, prev_user|
- if prev_session[:foo] && prev_user[:login] = 'bob'
- redirect_to '/login'
+ if prev_session[:foo] && prev_user[:login] = "bob"
+ redirect_to "/login"
end
end
end
- context 'with direct login and redirecting callback',
- with_config: { omniauth_direct_login_provider: 'foo' }, with_settings: { login_required?: true } do
- it 'stills call the callback' do
+ context "with direct login and redirecting callback",
+ with_config: { omniauth_direct_login_provider: "foo" }, with_settings: { login_required?: true } do
+ it "stills call the callback" do
# Set the previous session
- session[:foo] = 'bar'
+ session[:foo] = "bar"
get :logout
- expect(response).to redirect_to '/login'
+ expect(response).to redirect_to "/login"
# Expect session to be cleared
expect(session[:foo]).to be_nil
end
end
- it 'calls the callback' do
+ it "calls the callback" do
# Set the previous session
- session[:foo] = 'bar'
+ session[:foo] = "bar"
get :logout
- expect(response).to redirect_to '/login'
+ expect(response).to redirect_to "/login"
# Expect session to be cleared
expect(session[:foo]).to be_nil
end
end
- context 'with a no-op callback' do
- it 'redirects to default if the callback does nothing' do
+ context "with a no-op callback" do
+ it "redirects to default if the callback does nothing" do
was_called = false
sso_provider[:single_sign_out_callback] = Proc.new do
was_called = true
@@ -371,10 +371,10 @@ def reset!
end
end
- context 'with a provider that does not have slo_callback' do
+ context "with a provider that does not have slo_callback" do
let(:slo_callback) { nil }
- it 'redirects to default if the callback does nothing' do
+ it "redirects to default if the callback does nothing" do
get :logout
expect(response).to redirect_to home_path
end
@@ -382,59 +382,59 @@ def reset!
end
end
- describe 'for a user trying to log in via an API request' do
+ describe "for a user trying to log in via an API request" do
before do
post :login,
params: {
username: admin.login,
- password: 'adminADMIN!'
+ password: "adminADMIN!"
},
format: :json
end
- it 'returns a 410' do
- expect(response.code.to_s).to eql('410')
+ it "returns a 410" do
+ expect(response.code.to_s).to eql("410")
end
- it 'does not login the user' do
+ it "does not login the user" do
expect(controller.send(:current_user)).to be_anonymous
end
end
- context 'with disabled password login' do
+ context "with disabled password login" do
before do
allow(OpenProject::Configuration).to receive(:disable_password_login?).and_return(true)
post :login
end
- it 'is not found' do
+ it "is not found" do
expect(response).to have_http_status :not_found
end
end
end
- describe '#login with omniauth_direct_login enabled',
- with_config: { omniauth_direct_login_provider: 'some_provider' } do
- describe 'GET' do
- it 'redirects to some_provider' do
+ describe "#login with omniauth_direct_login enabled",
+ with_config: { omniauth_direct_login_provider: "some_provider" } do
+ describe "GET" do
+ it "redirects to some_provider" do
get :login
- expect(response).to redirect_to '/auth/some_provider'
+ expect(response).to redirect_to "/auth/some_provider"
end
end
- describe 'POST' do
+ describe "POST" do
shared_let(:admin) { create(:admin) }
- it 'allows to login internally still' do
- post :login, params: { username: admin.login, password: 'adminADMIN!' }
+ it "allows to login internally still" do
+ post :login, params: { username: admin.login, password: "adminADMIN!" }
expect(response).to redirect_to "/my/page"
end
end
end
- describe 'Login for user with forced password change' do
+ describe "Login for user with forced password change" do
let(:admin) { create(:admin, force_password_change: true) }
before do
@@ -443,106 +443,106 @@ def reset!
describe "Missing flash data for user initiated password change" do
before do
- post 'change_password',
+ post "change_password",
flash: {
_password_change_user_id: nil
},
params: {
username: admin.login,
- password: 'whatever',
- new_password: 'whatever',
- new_password_confirmation: 'whatever2'
+ password: "whatever",
+ new_password: "whatever",
+ new_password_confirmation: "whatever2"
}
end
- it 'renders 404' do
+ it "renders 404" do
expect(response).to have_http_status :not_found
end
end
describe "User who is not allowed to change password can't login" do
before do
- post 'change_password',
+ post "change_password",
params: {
password_change_user_id: admin.id,
username: admin.login,
- password: 'adminADMIN!',
- new_password: 'adminADMIN!New',
- new_password_confirmation: 'adminADMIN!New'
+ password: "adminADMIN!",
+ new_password: "adminADMIN!New",
+ new_password_confirmation: "adminADMIN!New"
}
end
- it 'redirects to the login page' do
- expect(response).to redirect_to '/login'
+ it "redirects to the login page" do
+ expect(response).to redirect_to "/login"
end
end
- describe 'User who is not allowed to change password, is not redirected to the login page' do
+ describe "User who is not allowed to change password, is not redirected to the login page" do
before do
- post 'login', params: { username: admin.login, password: 'adminADMIN!' }
+ post "login", params: { username: admin.login, password: "adminADMIN!" }
end
- it 'redirects to the login page' do
- expect(response).to redirect_to '/login'
+ it "redirects to the login page" do
+ expect(response).to redirect_to "/login"
end
end
end
- describe 'POST #change_password' do
- context 'with disabled password login' do
+ describe "POST #change_password" do
+ context "with disabled password login" do
before do
allow(OpenProject::Configuration).to receive(:disable_password_login?).and_return(true)
post :change_password
end
- it 'is not found' do
+ it "is not found" do
expect(response).to have_http_status :not_found
end
end
end
- describe 'POST #lost_password' do
- context 'when the user has been invited but not yet activated' do
+ describe "POST #lost_password" do
+ context "when the user has been invited but not yet activated" do
shared_let(:admin) { create(:admin, status: :invited) }
shared_let(:token) { create(:recovery_token, user: admin) }
- context 'with a valid token' do
+ context "with a valid token" do
before do
allow(controller).to receive(:allow_lost_password_recovery).and_return(true)
post :lost_password, params: { token: token.value }
end
- it 'redirects to the login page' do
- expect(response).to redirect_to '/login'
+ it "redirects to the login page" do
+ expect(response).to redirect_to "/login"
end
end
end
end
- shared_examples 'registration disabled' do
- it 'redirects to back the login page' do
+ shared_examples "registration disabled" do
+ it "redirects to back the login page" do
expect(response).to redirect_to signin_path
end
- it 'informs the user that registration is disabled' do
- expect(flash[:error]).to eq(I18n.t('account.error_self_registration_disabled'))
+ it "informs the user that registration is disabled" do
+ expect(flash[:error]).to eq(I18n.t("account.error_self_registration_disabled"))
end
- it 'does not call the user_registered callback' do
+ it "does not call the user_registered callback" do
expect(hook.registered_user).to be_nil
end
end
- describe 'GET #register' do
- context 'with self registration on',
+ describe "GET #register" do
+ context "with self registration on",
with_settings: { self_registration: Setting::SelfRegistration.automatic } do
- context 'and password login enabled' do
+ context "and password login enabled" do
before do
get :register
end
- it 'is successful' do
+ it "is successful" do
expect(subject).to respond_with :success
expect(response).to render_template :register
expect(assigns[:user]).not_to be_nil
@@ -550,27 +550,27 @@ def reset!
end
end
- context 'and password login disabled' do
+ context "and password login disabled" do
before do
allow(OpenProject::Configuration).to receive(:disable_password_login?).and_return(true)
get :register
end
- it_behaves_like 'registration disabled'
+ it_behaves_like "registration disabled"
end
end
- context 'with self registration off',
+ context "with self registration off",
with_settings: { self_registration: Setting::SelfRegistration.disabled } do
before do
get :register
end
- it_behaves_like 'registration disabled'
+ it_behaves_like "registration disabled"
end
- context 'with self registration off but an ongoing invitation activation',
+ context "with self registration off but an ongoing invitation activation",
with_settings: { self_registration: Setting::SelfRegistration.disabled } do
let(:token) { create(:invitation_token) }
@@ -580,7 +580,7 @@ def reset!
get :register
end
- it 'is successful' do
+ it "is successful" do
expect(subject).to respond_with :success
expect(response).to render_template :register
expect(assigns[:user]).not_to be_nil
@@ -589,44 +589,44 @@ def reset!
end
# See integration/account_test.rb for the full test
- describe 'POST #register' do
- context 'with self registration on automatic',
+ describe "POST #register" do
+ context "with self registration on automatic",
with_settings: { self_registration: Setting::SelfRegistration.automatic } do
before do
allow(OpenProject::Configuration).to receive(:disable_password_login?).and_return(false)
end
- context 'with password login enabled' do
+ context "with password login enabled" do
# expects `redirect_to_path`
- shared_examples 'automatic self registration succeeds' do
+ shared_examples "automatic self registration succeeds" do
before do
post :register,
params: {
user: {
- login: 'register',
- password: 'adminADMIN!',
- password_confirmation: 'adminADMIN!',
- firstname: 'John',
- lastname: 'Doe',
- mail: 'register@example.com'
+ login: "register",
+ password: "adminADMIN!",
+ password_confirmation: "adminADMIN!",
+ firstname: "John",
+ lastname: "Doe",
+ mail: "register@example.com"
}
}
end
- it 'redirects to the expected path' do
+ it "redirects to the expected path" do
expect(subject).to respond_with :redirect
expect(assigns[:user]).not_to be_nil
expect(subject).to redirect_to(redirect_to_path)
- expect(User.where(login: 'register').last).not_to be_nil
+ expect(User.where(login: "register").last).not_to be_nil
end
- it 'set the user status to active' do
- user = User.where(login: 'register').last
+ it "set the user status to active" do
+ user = User.where(login: "register").last
expect(user).not_to be_nil
expect(user).to be_active
end
- it 'calls the user_registered callback' do
+ it "calls the user_registered callback" do
user = hook.registered_user
expect(user.mail).to eq "register@example.com"
@@ -634,7 +634,7 @@ def reset!
end
end
- it_behaves_like 'automatic self registration succeeds' do
+ it_behaves_like "automatic self registration succeeds" do
let(:redirect_to_path) { "/?first_time_user=true" }
it "calls the user_first_login callback" do
@@ -650,12 +650,12 @@ def reset!
let(:params) do
{
user: {
- login: 'register',
- password: 'adminADMIN!',
- password_confirmation: 'adminADMIN!',
- firstname: 'John',
- lastname: 'Doe',
- mail: 'register@example.com'
+ login: "register",
+ password: "adminADMIN!",
+ password_confirmation: "adminADMIN!",
+ firstname: "John",
+ lastname: "Doe",
+ mail: "register@example.com"
}
}
end
@@ -681,53 +681,53 @@ def reset!
expect(mail.body.parts.first.to_s).to match /new user \(#{params[:user][:mail]}\)/
end
- it 'does not call the user_registered callback' do
+ it "does not call the user_registered callback" do
expect(hook.registered_user).to be_nil
end
end
end
- context 'with password login disabled' do
+ context "with password login disabled" do
before do
allow(OpenProject::Configuration).to receive(:disable_password_login?).and_return(true)
post :register
end
- it_behaves_like 'registration disabled'
+ it_behaves_like "registration disabled"
end
end
- context 'with self registration by email',
+ context "with self registration by email",
with_settings: { self_registration: Setting::SelfRegistration.by_email } do
- context 'with password login enabled' do
+ context "with password login enabled" do
before do
Token::Invitation.delete_all
post :register,
params: {
user: {
- login: 'register',
- password: 'adminADMIN!',
- password_confirmation: 'adminADMIN!',
- firstname: 'John',
- lastname: 'Doe',
- mail: 'register@example.com'
+ login: "register",
+ password: "adminADMIN!",
+ password_confirmation: "adminADMIN!",
+ firstname: "John",
+ lastname: "Doe",
+ mail: "register@example.com"
}
}
end
- it 'redirects to the login page' do
- expect(subject).to redirect_to '/login'
+ it "redirects to the login page" do
+ expect(subject).to redirect_to "/login"
end
it "doesn't activate the user but sends out a token instead" do
- expect(User.find_by_login('register')).not_to be_active # rubocop:disable Rails/DynamicFindBy
+ expect(User.find_by_login("register")).not_to be_active # rubocop:disable Rails/DynamicFindBy
token = Token::Invitation.last
- expect(token.user.mail).to eq('register@example.com')
+ expect(token.user.mail).to eq("register@example.com")
expect(token).not_to be_expired
end
- it 'calls the user_registered callback' do
+ it "calls the user_registered callback" do
user = hook.registered_user
expect(user.mail).to eq "register@example.com"
@@ -735,42 +735,42 @@ def reset!
end
end
- context 'with password login disabled' do
+ context "with password login disabled" do
before do
allow(OpenProject::Configuration).to receive(:disable_password_login?).and_return(true)
post :register
end
- it_behaves_like 'registration disabled'
+ it_behaves_like "registration disabled"
end
end
- context 'with manual activation',
+ context "with manual activation",
with_settings: { self_registration: Setting::SelfRegistration.manual } do
let(:user_hash) do
- { login: 'register',
- password: 'adminADMIN!',
- password_confirmation: 'adminADMIN!',
- firstname: 'John',
- lastname: 'Doe',
- mail: 'register@example.com' }
+ { login: "register",
+ password: "adminADMIN!",
+ password_confirmation: "adminADMIN!",
+ firstname: "John",
+ lastname: "Doe",
+ mail: "register@example.com" }
end
- context 'without back_url' do
+ context "without back_url" do
before do
post :register, params: { user: user_hash }
end
- it 'redirects to the login page' do
- expect(response).to redirect_to '/login'
+ it "redirects to the login page" do
+ expect(response).to redirect_to "/login"
end
it "doesn't activate the user" do
- expect(User.find_by_login('register')).not_to be_active # rubocop:disable Rails/DynamicFindBy
+ expect(User.find_by_login("register")).not_to be_active # rubocop:disable Rails/DynamicFindBy
end
- it 'calls the user_registered callback' do
+ it "calls the user_registered callback" do
user = hook.registered_user
expect(user.mail).to eq "register@example.com"
@@ -778,16 +778,16 @@ def reset!
end
end
- context 'with back_url' do
+ context "with back_url" do
before do
- post :register, params: { user: user_hash, back_url: 'https://example.net/some_back_url' }
+ post :register, params: { user: user_hash, back_url: "https://example.net/some_back_url" }
end
- it 'preserves the back url' do
- expect(response).to redirect_to('/login?back_url=https%3A%2F%2Fexample.net%2Fsome_back_url')
+ it "preserves the back url" do
+ expect(response).to redirect_to("/login?back_url=https%3A%2F%2Fexample.net%2Fsome_back_url")
end
- it 'calls the user_registered callback' do
+ it "calls the user_registered callback" do
user = hook.registered_user
expect(user.mail).to eq "register@example.com"
@@ -795,68 +795,68 @@ def reset!
end
end
- context 'with password login disabled' do
+ context "with password login disabled" do
before do
allow(OpenProject::Configuration).to receive(:disable_password_login?).and_return(true)
post :register
end
- it_behaves_like 'registration disabled'
+ it_behaves_like "registration disabled"
end
end
- context 'with self registration off',
+ context "with self registration off",
with_settings: { self_registration: Setting::SelfRegistration.disabled } do
before do
post :register,
params: {
user: {
- login: 'register',
- password: 'adminADMIN!',
- password_confirmation: 'adminADMIN!',
- firstname: 'John',
- lastname: 'Doe',
- mail: 'register@example.com'
+ login: "register",
+ password: "adminADMIN!",
+ password_confirmation: "adminADMIN!",
+ firstname: "John",
+ lastname: "Doe",
+ mail: "register@example.com"
}
}
end
- it_behaves_like 'registration disabled'
+ it_behaves_like "registration disabled"
end
- context 'with on-the-fly registration',
+ context "with on-the-fly registration",
with_settings: { self_registration: Setting::SelfRegistration.disabled } do
before do
allow_any_instance_of(User).to receive(:change_password_allowed?).and_return(false) # rubocop:disable RSpec/AnyInstance
end
- context 'with password login disabled' do
+ context "with password login disabled" do
before do
allow(OpenProject::Configuration).to receive(:disable_password_login?).and_return(true)
end
- describe 'registration' do
+ describe "registration" do
before do
post :register,
params: {
user: {
- firstname: 'Foo',
- lastname: 'Smith',
- mail: 'foo@bar.com'
+ firstname: "Foo",
+ lastname: "Smith",
+ mail: "foo@bar.com"
}
}
end
- it_behaves_like 'registration disabled'
+ it_behaves_like "registration disabled"
end
end
end
end
- describe 'POST #activate' do
- describe 'account activation' do
- shared_examples 'account activation' do
+ describe "POST #activate" do
+ describe "account activation" do
+ shared_examples "account activation" do
let(:token) { Token::Invitation.create user: }
let(:activation_params) do
@@ -865,19 +865,19 @@ def reset!
}
end
- context 'with an expired token' do
+ context "with an expired token" do
before do
token.update_column :expires_on, 1.day.ago
post :activate, params: activation_params
end
- it 'fails and shows an expiration warning' do
- expect(subject).to redirect_to('/')
- expect(flash[:warning]).to include 'expired'
+ it "fails and shows an expiration warning" do
+ expect(subject).to redirect_to("/")
+ expect(flash[:warning]).to include "expired"
end
- it 'deletes the old token and generates a new one' do
+ it "deletes the old token and generates a new one" do
old_token = Token::Invitation.find_by(id: token.id)
new_token = Token::Invitation.find_by(user_id: token.user.id)
@@ -887,7 +887,7 @@ def reset!
expect(new_token).not_to be_expired
end
- it 'sends out a new activation email' do
+ it "sends out a new activation email" do
new_token = Token::Invitation.find_by(user_id: token.user.id)
perform_enqueued_jobs
@@ -898,20 +898,20 @@ def reset!
end
end
- context 'with an invited user' do
- it_behaves_like 'account activation' do
+ context "with an invited user" do
+ it_behaves_like "account activation" do
let(:user) { create(:user, status: 4) }
end
end
- context 'with a registered user' do
- it_behaves_like 'account activation' do
+ context "with a registered user" do
+ it_behaves_like "account activation" do
let(:user) { create(:user, status: 2) }
end
end
end
- describe 'user limit' do
+ describe "user limit" do
let!(:admin) { create(:admin) }
let(:user) { create(:user, status:) }
let(:status) { -1 }
@@ -943,13 +943,13 @@ def reset!
end
end
- context 'with an invited user' do
+ context "with an invited user" do
let(:status) { User.statuses[:invited] }
it_behaves_like "activation is blocked due to user limit"
end
- context 'with a registered user' do
+ context "with a registered user" do
let(:status) { User.statuses[:registered] }
it_behaves_like "activation is blocked due to user limit"
@@ -957,13 +957,13 @@ def reset!
end
end
- describe 'GET #auth_source_sso_failed (/sso)' do
+ describe "GET #auth_source_sso_failed (/sso)" do
render_views
let(:failure) do
{
login:,
- back_url: '/my/account',
+ back_url: "/my/account",
ttl: 1
}
end
@@ -991,9 +991,9 @@ def reset!
context "with an invalid user" do
let!(:duplicate) { create(:user, mail: "login@DerpLAP.net") }
- let(:login) { 'foo' }
+ let(:login) { "foo" }
let(:attrs) do
- { mail: duplicate.mail, login:, firstname: 'bla', lastname: 'bar' }
+ { mail: duplicate.mail, login:, firstname: "bla", lastname: "bar" }
end
before do
@@ -1012,9 +1012,9 @@ def reset!
context "with a missing email" do
let!(:duplicate) { create(:user, mail: "login@DerpLAP.net") }
- let(:login) { 'foo' }
+ let(:login) { "foo" }
let(:attrs) do
- { login:, firstname: 'bla', lastname: 'bar' }
+ { login:, firstname: "bla", lastname: "bar" }
end
before do
diff --git a/spec/controllers/activities_controller_spec.rb b/spec/controllers/activities_controller_spec.rb
index b62983dce603..4c657ca01535 100644
--- a/spec/controllers/activities_controller_spec.rb
+++ b/spec/controllers/activities_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe ActivitiesController do
shared_let(:admin) { create(:admin) }
@@ -38,103 +38,103 @@
@params = {}
end
- describe 'for GET index' do
- shared_examples_for 'valid index response' do
+ describe "for GET index" do
+ shared_examples_for "valid index response" do
it { expect(response).to be_successful }
- it { expect(response).to render_template 'index' }
+ it { expect(response).to render_template "index" }
end
- describe 'global' do
+ describe "global" do
let!(:work_package) { create(:work_package, :created_in_past, created_at: 3.days.ago) }
- before { get 'index' }
+ before { get "index" }
- it_behaves_like 'valid index response'
+ it_behaves_like "valid index response"
it { expect(assigns(:events)).not_to be_empty }
- describe 'view' do
+ describe "view" do
render_views
it do
- assert_select 'h3',
+ assert_select "h3",
content: /#{3.days.ago.to_date.day}/,
- sibling: { tag: 'dl',
- child: { tag: 'dt',
+ sibling: { tag: "dl",
+ child: { tag: "dt",
attributes: { class: /work_package/ },
- child: { tag: 'a',
+ child: { tag: "a",
content: /#{ERB::Util.html_escape(work_package.subject)}/ } } }
end
end
- describe 'empty filter selection' do
+ describe "empty filter selection" do
before do
- get 'index', params: { event_types: [''] }
+ get "index", params: { event_types: [""] }
end
- it_behaves_like 'valid index response'
+ it_behaves_like "valid index response"
it { expect(assigns(:events)).to be_empty }
end
end
- describe 'with activated activity module' do
+ describe "with activated activity module" do
let(:project) do
create(:project,
enabled_module_names: %w[activity wiki])
end
- it 'renders activity' do
- get 'index', params: { project_id: project.id }
+ it "renders activity" do
+ get "index", params: { project_id: project.id }
expect(response).to be_successful
- expect(response).to render_template 'index'
+ expect(response).to render_template "index"
end
end
- describe 'without activated activity module' do
+ describe "without activated activity module" do
let(:project) do
create(:project,
enabled_module_names: %w[wiki])
end
- it 'renders 403' do
- get 'index', params: { project_id: project.id }
+ it "renders 403" do
+ get "index", params: { project_id: project.id }
expect(response).to have_http_status(:forbidden)
- expect(response).to render_template 'common/error'
+ expect(response).to render_template "common/error"
end
end
- shared_context 'for GET index with params' do
+ shared_context "for GET index with params" do
let(:session_values) { defined?(session_hash) ? session_hash : {} }
before { get :index, params:, session: session_values }
end
- describe '#atom_feed' do
+ describe "#atom_feed" do
let(:user) { create(:user) }
let(:project) { create(:project) }
- context 'with work packages' do
+ context "with work packages" do
let!(:wp1) do
create(:work_package,
project:,
author: user)
end
- describe 'global' do
+ describe "global" do
render_views
- before { get 'index', format: 'atom' }
+ before { get "index", format: "atom" }
- it 'contains a link to the work package' do
- assert_select 'entry',
- child: { tag: 'link',
+ it "contains a link to the work package" do
+ assert_select "entry",
+ child: { tag: "link",
attributes: { href: Regexp.new("/work_packages/#{wp1.id}#") } }
end
end
- describe 'list' do
+ describe "list" do
let!(:wp2) do
create(:work_package,
project:,
@@ -147,15 +147,15 @@
format: :atom }
end
- include_context 'for GET index with params'
+ include_context "for GET index with params"
it { expect(assigns(:items).pluck(:event_type)).to match_array(%w[work_package-edit work_package-edit]) }
- it { expect(response).to render_template('common/feed') }
+ it { expect(response).to render_template("common/feed") }
end
end
- context 'with forums' do
+ context "with forums" do
let(:forum) do
create(:forum,
project:)
@@ -174,20 +174,20 @@
format: :atom }
end
- include_context 'for GET index with params'
+ include_context "for GET index with params"
it { expect(assigns(:items).pluck(:event_type)).to match_array(%w[message message]) }
- it { expect(response).to render_template('common/feed') }
+ it { expect(response).to render_template("common/feed") }
end
end
- describe 'user selection' do
- describe 'first activity request' do
- let(:default_scope) { ['work_packages', 'changesets'] }
+ describe "user selection" do
+ describe "first activity request" do
+ let(:default_scope) { ["work_packages", "changesets"] }
let(:params) { {} }
- include_context 'for GET index with params'
+ include_context "for GET index with params"
it { expect(assigns(:activity).scope).to match_array(default_scope) }
@@ -196,12 +196,12 @@
it { expect(session[:activity][:with_subprojects]).to be(true) }
end
- describe 'subsequent activity requests' do
+ describe "subsequent activity requests" do
let(:scope) { [] }
let(:params) { {} }
let(:session_hash) { { activity: { scope: [], with_subprojects: true } } }
- include_context 'for GET index with params'
+ include_context "for GET index with params"
it { expect(assigns(:activity).scope).to match_array(scope) }
@@ -210,11 +210,11 @@
it { expect(session[:activity][:with_subprojects]).to be(true) }
end
- describe 'selection with apply' do
+ describe "selection with apply" do
let(:scope) { [] }
- let(:params) { { event_types: [''], with_subprojects: 0 } }
+ let(:params) { { event_types: [""], with_subprojects: 0 } }
- include_context 'for GET index with params'
+ include_context "for GET index with params"
it { expect(assigns(:activity).scope).to match_array(scope) }
diff --git a/spec/controllers/admin/settings/aggregation_settings_controller_spec.rb b/spec/controllers/admin/settings/aggregation_settings_controller_spec.rb
index 226e68413297..6fb616571b9c 100644
--- a/spec/controllers/admin/settings/aggregation_settings_controller_spec.rb
+++ b/spec/controllers/admin/settings/aggregation_settings_controller_spec.rb
@@ -29,12 +29,12 @@
# ++
#
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Admin::Settings::AggregationSettingsController do # rubocop:disable RSpec/EmptyExampleGroup
shared_let(:user) { create(:admin) }
current_user { user }
- require_admin_and_render_template('aggregation_settings')
+ require_admin_and_render_template("aggregation_settings")
end
diff --git a/spec/controllers/admin/settings/api_settings_controller_spec.rb b/spec/controllers/admin/settings/api_settings_controller_spec.rb
index b5e7b94141dd..cdb51c270559 100644
--- a/spec/controllers/admin/settings/api_settings_controller_spec.rb
+++ b/spec/controllers/admin/settings/api_settings_controller_spec.rb
@@ -29,12 +29,12 @@
# ++
#
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Admin::Settings::APISettingsController do # rubocop:disable RSpec/EmptyExampleGroup
shared_let(:user) { create(:admin) }
current_user { user }
- require_admin_and_render_template('api_settings')
+ require_admin_and_render_template("api_settings")
end
diff --git a/spec/controllers/admin/settings/attachments_settings_controller_spec.rb b/spec/controllers/admin/settings/attachments_settings_controller_spec.rb
index fd8c04fc1738..f579676aedf7 100644
--- a/spec/controllers/admin/settings/attachments_settings_controller_spec.rb
+++ b/spec/controllers/admin/settings/attachments_settings_controller_spec.rb
@@ -29,12 +29,12 @@
# ++
#
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Admin::Settings::AttachmentsSettingsController do # rubocop:disable RSpec/EmptyExampleGroup
shared_let(:user) { create(:admin) }
current_user { user }
- require_admin_and_render_template('attachments_settings')
+ require_admin_and_render_template("attachments_settings")
end
diff --git a/spec/controllers/admin/settings/authentication_settings_controller_spec.rb b/spec/controllers/admin/settings/authentication_settings_controller_spec.rb
index e8483b137ed2..c10ea68dd230 100644
--- a/spec/controllers/admin/settings/authentication_settings_controller_spec.rb
+++ b/spec/controllers/admin/settings/authentication_settings_controller_spec.rb
@@ -26,22 +26,22 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Admin::Settings::AuthenticationSettingsController do
shared_let(:user) { create(:admin) }
current_user { user }
- require_admin_and_render_template('authentication_settings')
+ require_admin_and_render_template("authentication_settings")
- describe 'PATCH #update' do
- describe 'registration_footer' do
+ describe "PATCH #update" do
+ describe "registration_footer" do
let(:old_settings) do
{
registration_footer: {
- 'de' => 'Old German registration footer',
- 'en' => 'Old English registration footer'
+ "de" => "Old German registration footer",
+ "en" => "Old English registration footer"
}
}
end
@@ -49,8 +49,8 @@
let(:new_settings) do
{
registration_footer: {
- 'de' => 'New German registration footer',
- 'en' => 'New English registration footer'
+ "de" => "New German registration footer",
+ "en" => "New English registration footer"
}
}
end
@@ -61,31 +61,31 @@
end
end
- describe 'when writable' do
+ describe "when writable" do
before do
- patch 'update', params: { settings: new_settings }
+ patch "update", params: { settings: new_settings }
end
- it 'is successful' do
+ it "is successful" do
expect(response).to redirect_to(admin_settings_authentication_path)
end
- it 'changes the registration_footer' do
+ it "changes the registration_footer" do
expect(Setting.registration_footer).to eq new_settings[:registration_footer]
end
end
- describe 'when non-writable (set via env var)' do
+ describe "when non-writable (set via env var)" do
before do
allow(Setting).to receive(:registration_footer_writable?).and_return(false)
- patch 'update', params: { settings: new_settings }
+ patch "update", params: { settings: new_settings }
end
- it 'is successful' do
+ it "is successful" do
expect(response).to redirect_to(admin_settings_authentication_path)
end
- it 'does not change the registration_footer' do
+ it "does not change the registration_footer" do
expect(Setting.registration_footer).to eq old_settings[:registration_footer]
end
end
diff --git a/spec/controllers/admin/settings/date_format_settings_controller_spec.rb b/spec/controllers/admin/settings/date_format_settings_controller_spec.rb
index 350457c50720..da10096690e5 100644
--- a/spec/controllers/admin/settings/date_format_settings_controller_spec.rb
+++ b/spec/controllers/admin/settings/date_format_settings_controller_spec.rb
@@ -29,16 +29,16 @@
# ++
#
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Admin::Settings::DateFormatSettingsController do
shared_let(:user) { create(:admin) }
current_user { user }
- require_admin_and_render_template('date_format_settings')
+ require_admin_and_render_template("date_format_settings")
- describe 'PATCH #update' do
- subject { patch 'update', params: }
+ describe "PATCH #update" do
+ subject { patch "update", params: }
let(:start_of_week) { 1 }
let(:first_week_of_year) { 1 }
@@ -49,25 +49,25 @@
end
let(:params) { { settings: } }
- shared_examples 'invalid combination of start_of_week and first_week_of_year' do |missing_param:|
+ shared_examples "invalid combination of start_of_week and first_week_of_year" do |missing_param:|
provided_param = (%i[start_of_week first_week_of_year] - [missing_param]).first
context "when setting only #{provided_param} but not #{missing_param}" do
let(:settings) { base_settings.except(missing_param) }
- it 'redirects and sets the flash error' do
+ it "redirects and sets the flash error" do
subject
expect(response).to redirect_to action: :show
expect(flash[:error])
- .to eq(I18n.t('settings.date_format.first_date_of_week_and_year_set',
+ .to eq(I18n.t("settings.date_format.first_date_of_week_and_year_set",
first_week_setting_name: I18n.t(:setting_first_week_of_year),
day_of_week_setting_name: I18n.t(:setting_start_of_week)))
end
end
end
- include_examples 'invalid combination of start_of_week and first_week_of_year', missing_param: :first_week_of_year
- include_examples 'invalid combination of start_of_week and first_week_of_year', missing_param: :start_of_week
+ include_examples "invalid combination of start_of_week and first_week_of_year", missing_param: :first_week_of_year
+ include_examples "invalid combination of start_of_week and first_week_of_year", missing_param: :start_of_week
end
end
diff --git a/spec/controllers/admin/settings/general_settings_controller_spec.rb b/spec/controllers/admin/settings/general_settings_controller_spec.rb
index d7421267a999..849f80be42b1 100644
--- a/spec/controllers/admin/settings/general_settings_controller_spec.rb
+++ b/spec/controllers/admin/settings/general_settings_controller_spec.rb
@@ -29,12 +29,12 @@
# ++
#
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Admin::Settings::GeneralSettingsController do # rubocop:disable RSpec/EmptyExampleGroup
shared_let(:user) { create(:admin) }
current_user { user }
- require_admin_and_render_template('general_settings')
+ require_admin_and_render_template("general_settings")
end
diff --git a/spec/controllers/admin/settings/icalendar_settings_controller_spec.rb b/spec/controllers/admin/settings/icalendar_settings_controller_spec.rb
index 8dfa9d7bf5a5..92ff27937995 100644
--- a/spec/controllers/admin/settings/icalendar_settings_controller_spec.rb
+++ b/spec/controllers/admin/settings/icalendar_settings_controller_spec.rb
@@ -29,27 +29,27 @@
# ++
#
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Admin::Settings::IcalendarSettingsController do
shared_let(:user) { create(:admin) }
current_user { user }
- require_admin_and_render_template('icalendar_settings')
+ require_admin_and_render_template("icalendar_settings")
- describe 'PATCH #update' do
- subject { patch 'update', params: }
+ describe "PATCH #update" do
+ subject { patch "update", params: }
let(:base_settings) do
{ ical_enabled: true }
end
let(:params) { { settings: } }
- context 'with valid params' do
+ context "with valid params" do
let(:settings) { base_settings }
- it 'succeeds' do
+ it "succeeds" do
subject
expect(response).to redirect_to action: :show
diff --git a/spec/controllers/admin/settings/incoming_mails_settings_controller_spec.rb b/spec/controllers/admin/settings/incoming_mails_settings_controller_spec.rb
index 45a779273c9c..bdf7577974e8 100644
--- a/spec/controllers/admin/settings/incoming_mails_settings_controller_spec.rb
+++ b/spec/controllers/admin/settings/incoming_mails_settings_controller_spec.rb
@@ -29,12 +29,12 @@
# ++
#
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Admin::Settings::IncomingMailsSettingsController do # rubocop:disable RSpec/EmptyExampleGroup
shared_let(:user) { create(:admin) }
current_user { user }
- require_admin_and_render_template('incoming_mails_settings')
+ require_admin_and_render_template("incoming_mails_settings")
end
diff --git a/spec/controllers/admin/settings/languages_settings_controller_spec.rb b/spec/controllers/admin/settings/languages_settings_controller_spec.rb
index 931f00d430ad..c07c48713de1 100644
--- a/spec/controllers/admin/settings/languages_settings_controller_spec.rb
+++ b/spec/controllers/admin/settings/languages_settings_controller_spec.rb
@@ -29,17 +29,17 @@
# ++
#
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Admin::Settings::LanguagesSettingsController do
shared_let(:user) { create(:admin) }
current_user { user }
- require_admin_and_render_template('languages_settings')
+ require_admin_and_render_template("languages_settings")
- describe 'PATCH #update' do
- subject { patch 'update', params: }
+ describe "PATCH #update" do
+ subject { patch "update", params: }
let(:available_languages) { %w[en fr de] }
let(:base_settings) do
@@ -47,31 +47,31 @@
end
let(:params) { { settings: } }
- context 'with valid params' do
+ context "with valid params" do
let(:settings) { base_settings }
- it 'succeeds' do
+ it "succeeds" do
subject
expect(response).to redirect_to action: :show
expect(flash[:notice]).to eq I18n.t(:notice_successful_update)
end
- it 'sets language of users having a non-available language to the default language',
- with_settings: { available_languages: %w[en de ja], default_language: 'de' } do
- user_de = create(:user, language: 'de')
- user_en = create(:user, language: 'en')
- user_foo = create(:user, language: 'foo')
- user_fr = create(:user, language: 'fr')
- user_ja = create(:user, language: 'ja')
+ it "sets language of users having a non-available language to the default language",
+ with_settings: { available_languages: %w[en de ja], default_language: "de" } do
+ user_de = create(:user, language: "de")
+ user_en = create(:user, language: "en")
+ user_foo = create(:user, language: "foo")
+ user_fr = create(:user, language: "fr")
+ user_ja = create(:user, language: "ja")
subject
- expect(user_de.reload.language).to eq('de')
- expect(user_en.reload.language).to eq('en')
- expect(user_foo.reload.language).to eq('de')
- expect(user_fr.reload.language).to eq('de')
- expect(user_ja.reload.language).to eq('ja')
+ expect(user_de.reload.language).to eq("de")
+ expect(user_en.reload.language).to eq("en")
+ expect(user_foo.reload.language).to eq("de")
+ expect(user_fr.reload.language).to eq("de")
+ expect(user_ja.reload.language).to eq("ja")
end
end
end
diff --git a/spec/controllers/admin/settings/mail_notifications_settings_controller_spec.rb b/spec/controllers/admin/settings/mail_notifications_settings_controller_spec.rb
index 74e65b4a546d..163f6f974e66 100644
--- a/spec/controllers/admin/settings/mail_notifications_settings_controller_spec.rb
+++ b/spec/controllers/admin/settings/mail_notifications_settings_controller_spec.rb
@@ -29,12 +29,12 @@
# ++
#
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Admin::Settings::MailNotificationsSettingsController do # rubocop:disable RSpec/EmptyExampleGroup
shared_let(:user) { create(:admin) }
current_user { user }
- require_admin_and_render_template('mail_notifications_settings')
+ require_admin_and_render_template("mail_notifications_settings")
end
diff --git a/spec/controllers/admin/settings/projects_settings_controller_spec.rb b/spec/controllers/admin/settings/projects_settings_controller_spec.rb
index 3149f313b693..d4c6250c0225 100644
--- a/spec/controllers/admin/settings/projects_settings_controller_spec.rb
+++ b/spec/controllers/admin/settings/projects_settings_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Admin::Settings::ProjectsSettingsController do
shared_let(:user) { create(:admin) }
@@ -36,43 +36,43 @@
allow(controller).to receive(:set_localization)
end
- describe 'GET #show' do
+ describe "GET #show" do
render_views
- describe 'default project modules' do
- it 'contains a check box for the activity module on the projects tab' do
- get 'show', params: { tab: 'projects' }
+ describe "default project modules" do
+ it "contains a check box for the activity module on the projects tab" do
+ get "show", params: { tab: "projects" }
expect(response).to be_successful
- expect(response).to render_template 'admin/settings/projects_settings/show'
+ expect(response).to render_template "admin/settings/projects_settings/show"
expect(response.body).to have_css "input[@name='settings[default_projects_modules][]'][@value='activity']"
end
- context 'without activated activity module' do
+ context "without activated activity module" do
before do
Setting.default_projects_modules = %w[wiki]
end
- it 'contains an unchecked checkbox for activity' do
- get 'show', params: { tab: 'projects' }
+ it "contains an unchecked checkbox for activity" do
+ get "show", params: { tab: "projects" }
expect(response).to be_successful
- expect(response).to render_template 'admin/settings/projects_settings/show'
+ expect(response).to render_template "admin/settings/projects_settings/show"
expect(response.body).to have_no_css "input[@name='settings[default_projects_modules][]'][@value='activity'][@checked='checked']"
end
end
- context 'with activity in Setting.default_projects_modules' do
+ context "with activity in Setting.default_projects_modules" do
before do
Setting.default_projects_modules = %w[activity]
end
- it 'contains a checked checkbox for activity' do
- get 'show', params: { tab: 'projects' }
+ it "contains a checked checkbox for activity" do
+ get "show", params: { tab: "projects" }
expect(response).to be_successful
- expect(response).to render_template 'admin/settings/projects_settings/show'
+ expect(response).to render_template "admin/settings/projects_settings/show"
expect(response.body).to have_css "input[@name='settings[default_projects_modules][]'][@value='activity'][@checked='checked']"
end
@@ -80,42 +80,42 @@
end
end
- describe 'PATCH #update' do
+ describe "PATCH #update" do
render_views
- describe 'default project modules' do
- it 'does not store the activity in the default_projects_modules if unchecked' do
- patch 'update',
+ describe "default project modules" do
+ it "does not store the activity in the default_projects_modules if unchecked" do
+ patch "update",
params: {
- tab: 'projects',
+ tab: "projects",
settings: {
- default_projects_modules: ['wiki']
+ default_projects_modules: ["wiki"]
}
}
expect(response).to be_redirect
- expect(response).to redirect_to action: 'show', tab: 'projects'
+ expect(response).to redirect_to action: "show", tab: "projects"
- expect(Setting.default_projects_modules).to eq(['wiki'])
+ expect(Setting.default_projects_modules).to eq(["wiki"])
end
- it 'stores the activity in the default_projects_modules if checked' do
- patch 'update',
+ it "stores the activity in the default_projects_modules if checked" do
+ patch "update",
params: {
- tab: 'projects',
+ tab: "projects",
settings: {
- default_projects_modules: ['activity', 'wiki']
+ default_projects_modules: ["activity", "wiki"]
}
}
expect(response).to be_redirect
- expect(response).to redirect_to action: 'show', tab: 'projects'
+ expect(response).to redirect_to action: "show", tab: "projects"
- expect(Setting.default_projects_modules).to eq(['activity', 'wiki'])
+ expect(Setting.default_projects_modules).to eq(["activity", "wiki"])
end
end
- describe 'password settings' do
+ describe "password settings" do
let(:new_settings) do
{
password_min_length: 42,
@@ -142,74 +142,74 @@
end
end
- context 'with password login enabled' do
+ context "with password login enabled" do
before do
allow(OpenProject::Configuration).to receive(:disable_password_login?).and_return(false)
- patch 'update', params: { tab: 'authentication', settings: new_settings }
+ patch "update", params: { tab: "authentication", settings: new_settings }
end
- it 'is successful' do
+ it "is successful" do
expect(response).to be_redirect # to auth tab
end
- it 'sets the minimum password length to 42' do
+ it "sets the minimum password length to 42" do
expect(Setting[:password_min_length]).to eq 42
end
- it 'sets the active character classes to lowercase and uppercase' do
+ it "sets the active character classes to lowercase and uppercase" do
expect(Setting[:password_active_rules]).to eq %w[uppercase lowercase]
end
- it 'sets the required number of classes to 7' do
+ it "sets the required number of classes to 7" do
expect(Setting[:password_min_adhered_rules]).to eq 7
end
- it 'sets passwords to expire after 13 days' do
+ it "sets passwords to expire after 13 days" do
expect(Setting[:password_days_valid]).to eq 13
end
- it 'bans the last 80 passwords' do
+ it "bans the last 80 passwords" do
expect(Setting[:password_count_former_banned]).to eq 80
end
- it 'sets the lost password option to false' do
+ it "sets the lost password option to false" do
expect(Setting[:lost_password]).to be false
end
end
- describe 'with password login disabled' do
+ describe "with password login disabled" do
before do
allow(OpenProject::Configuration).to receive(:disable_password_login?).and_return(true)
- patch 'update', params: { tab: 'authentication', settings: new_settings }
+ patch "update", params: { tab: "authentication", settings: new_settings }
end
- it 'is successful' do
+ it "is successful" do
expect(response).to be_redirect # to auth tab
end
- it 'does not set the minimum password length to 42' do
+ it "does not set the minimum password length to 42" do
expect(Setting[:password_min_length]).to eq 10
end
- it 'does not set the active character classes to lowercase and uppercase' do
+ it "does not set the active character classes to lowercase and uppercase" do
expect(Setting[:password_active_rules]).to eq []
end
- it 'does not set the required number of classes to 7' do
+ it "does not set the required number of classes to 7" do
expect(Setting[:password_min_adhered_rules]).to eq 0
end
- it 'does not set passwords to expire after 13 days' do
+ it "does not set passwords to expire after 13 days" do
expect(Setting[:password_days_valid]).to eq 365
end
- it 'does not ban the last 80 passwords' do
+ it "does not ban the last 80 passwords" do
expect(Setting[:password_count_former_banned]).to eq 2
end
- it 'keeps the lost password option' do
+ it "keeps the lost password option" do
expect(Setting[:lost_password]).to be true
end
end
diff --git a/spec/controllers/admin/settings/repositories_settings_controller_spec.rb b/spec/controllers/admin/settings/repositories_settings_controller_spec.rb
index 24679ec12642..c7ee75bcec88 100644
--- a/spec/controllers/admin/settings/repositories_settings_controller_spec.rb
+++ b/spec/controllers/admin/settings/repositories_settings_controller_spec.rb
@@ -29,12 +29,12 @@
# ++
#
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Admin::Settings::RepositoriesSettingsController do # rubocop:disable RSpec/EmptyExampleGroup
shared_let(:user) { create(:admin) }
current_user { user }
- require_admin_and_render_template('repositories_settings')
+ require_admin_and_render_template("repositories_settings")
end
diff --git a/spec/controllers/admin/settings/users_settings_controller_spec.rb b/spec/controllers/admin/settings/users_settings_controller_spec.rb
index 3a48b7b2f8a3..cf98d178b61f 100644
--- a/spec/controllers/admin/settings/users_settings_controller_spec.rb
+++ b/spec/controllers/admin/settings/users_settings_controller_spec.rb
@@ -29,12 +29,12 @@
# ++
#
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Admin::Settings::UsersSettingsController do # rubocop:disable RSpec/EmptyExampleGroup
shared_let(:user) { create(:admin) }
current_user { user }
- require_admin_and_render_template('users_settings')
+ require_admin_and_render_template("users_settings")
end
diff --git a/spec/controllers/admin/settings/work_packages_settings_controller_spec.rb b/spec/controllers/admin/settings/work_packages_settings_controller_spec.rb
index b0dae291c33a..03a3f0c98489 100644
--- a/spec/controllers/admin/settings/work_packages_settings_controller_spec.rb
+++ b/spec/controllers/admin/settings/work_packages_settings_controller_spec.rb
@@ -29,12 +29,12 @@
# ++
#
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Admin::Settings::WorkPackagesSettingsController do # rubocop:disable RSpec/EmptyExampleGroup
shared_let(:user) { create(:admin) }
current_user { user }
- require_admin_and_render_template('work_packages_settings')
+ require_admin_and_render_template("work_packages_settings")
end
diff --git a/spec/controllers/admin/settings/working_days_settings_controller_spec.rb b/spec/controllers/admin/settings/working_days_settings_controller_spec.rb
index f4b695e9a12d..8063cf1fd809 100644
--- a/spec/controllers/admin/settings/working_days_settings_controller_spec.rb
+++ b/spec/controllers/admin/settings/working_days_settings_controller_spec.rb
@@ -26,76 +26,76 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Admin::Settings::WorkingDaysSettingsController do
shared_let(:user) { create(:admin) }
current_user { user }
- require_admin_and_render_template('working_days_settings')
+ require_admin_and_render_template("working_days_settings")
- describe 'update' do
- let(:working_days) { [*'1'..'7'] }
+ describe "update" do
+ let(:working_days) { [*"1".."7"] }
let(:non_working_days_attributes) { {} }
let(:params) do
{ settings: { working_days:, non_working_days_attributes: } }
end
- subject { patch 'update', params: }
+ subject { patch "update", params: }
- it 'succeeds' do
+ it "succeeds" do
subject
- expect(response).to redirect_to action: 'show'
+ expect(response).to redirect_to action: "show"
expect(flash[:notice]).to eq I18n.t(:notice_successful_update)
end
- context 'with non_working_days' do
+ context "with non_working_days" do
let(:non_working_days_attributes) do
- { '0' => { 'name' => 'Christmas Eve', 'date' => '2022-12-24' } }
+ { "0" => { "name" => "Christmas Eve", "date" => "2022-12-24" } }
end
- it 'succeeds' do
+ it "succeeds" do
subject
- expect(response).to redirect_to action: 'show'
+ expect(response).to redirect_to action: "show"
expect(flash[:notice]).to eq I18n.t(:notice_successful_update)
end
- it 'creates the non_working_days' do
+ it "creates the non_working_days" do
expect { subject }.to change(NonWorkingDay, :count).by(1)
- expect(NonWorkingDay.first).to have_attributes(name: 'Christmas Eve', date: Date.parse('2022-12-24'))
+ expect(NonWorkingDay.first).to have_attributes(name: "Christmas Eve", date: Date.parse("2022-12-24"))
end
end
- context 'when fails with a duplicate entry' do
- let(:nwd_to_delete) { create(:non_working_day, name: 'NWD to delete') }
+ context "when fails with a duplicate entry" do
+ let(:nwd_to_delete) { create(:non_working_day, name: "NWD to delete") }
let(:non_working_days_attributes) do
{
- '0' => { 'name' => 'Christmas Eve', 'date' => '2022-12-24' },
- '1' => { 'name' => 'Christmas Eve2', 'date' => '2022-12-24' },
- '2' => { 'id' => nwd_to_delete.id, '_destroy' => true }
+ "0" => { "name" => "Christmas Eve", "date" => "2022-12-24" },
+ "1" => { "name" => "Christmas Eve2", "date" => "2022-12-24" },
+ "2" => { "id" => nwd_to_delete.id, "_destroy" => true }
}
end
- it 'displays the error message' do
+ it "displays the error message" do
subject
expect(response).to render_template :show
- expect(flash[:error]).to eq 'A non-working day already exists for 2022-12-24.'
+ expect(flash[:error]).to eq "A non-working day already exists for 2022-12-24."
end
- it 'sets the @modified_non_working_days variable' do
+ it "sets the @modified_non_working_days variable" do
subject
expect(assigns(:modified_non_working_days)).to contain_exactly(
- hash_including('name' => 'Christmas Eve', 'date' => '2022-12-24'),
- hash_including('name' => 'Christmas Eve2', 'date' => '2022-12-24'),
- hash_including(nwd_to_delete.as_json(only: %i[id name date]).merge('_destroy' => true))
+ hash_including("name" => "Christmas Eve", "date" => "2022-12-24"),
+ hash_including("name" => "Christmas Eve2", "date" => "2022-12-24"),
+ hash_including(nwd_to_delete.as_json(only: %i[id name date]).merge("_destroy" => true))
)
end
- it 'does not destroys other records' do
+ it "does not destroys other records" do
subject
expect { nwd_to_delete.reload }.not_to raise_error
end
diff --git a/spec/controllers/admin_controller_spec.rb b/spec/controllers/admin_controller_spec.rb
index 05807d28a85f..275e764b6795 100644
--- a/spec/controllers/admin_controller_spec.rb
+++ b/spec/controllers/admin_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe AdminController do
let(:user) { build(:admin) }
@@ -35,12 +35,12 @@
allow(User).to receive(:current).and_return user
end
- describe '#index' do
- it 'renders index' do
+ describe "#index" do
+ it "renders index" do
get :index
expect(response).to be_successful
- expect(response).to render_template 'index'
+ expect(response).to render_template "index"
end
describe "with a plugin adding a menu item" do
@@ -56,9 +56,9 @@
Redmine::Plugin.register name.to_sym do
menu :admin_menu,
:"#{name}_settings",
- { controller: '/admin/settings', action: :show_plugin, id: :"openproject_#{name}" },
+ { controller: "/admin/settings", action: :show_plugin, id: :"openproject_#{name}" },
caption: name.capitalize,
- icon: 'arrow',
+ icon: "arrow",
if: ->(*) { show }
end
@@ -70,7 +70,7 @@
let(:visible) { true }
it "shows the plugin in the overview" do
- expect(response.body).to have_css('a.menu-block', text: plugin_name.capitalize)
+ expect(response.body).to have_css("a.menu-block", text: plugin_name.capitalize)
end
end
@@ -79,16 +79,16 @@
let(:visible) { false }
it "does not show the plugin in the overview" do
- expect(response.body).to have_no_css('a.menu-block', text: plugin_name.capitalize)
+ expect(response.body).to have_no_css("a.menu-block", text: plugin_name.capitalize)
end
end
end
end
- describe '#plugins' do
+ describe "#plugins" do
render_views
- context 'with plugins' do
+ context "with plugins" do
before do
Redmine::Plugin.register :foo do
end
@@ -96,36 +96,36 @@
end
end
- it 'renders the plugins' do
+ it "renders the plugins" do
get :plugins
expect(response).to be_successful
- expect(response).to render_template 'plugins'
+ expect(response).to render_template "plugins"
- expect(response.body).to have_css('td span', text: 'Foo')
- expect(response.body).to have_css('td span', text: 'Bar')
+ expect(response.body).to have_css("td span", text: "Foo")
+ expect(response.body).to have_css("td span", text: "Bar")
end
end
- context 'without plugins' do
+ context "without plugins" do
before do
Redmine::Plugin.clear
end
- it 'renders even without plugins' do
+ it "renders even without plugins" do
get :plugins
expect(response).to be_successful
- expect(response).to render_template 'plugins'
+ expect(response).to render_template "plugins"
end
end
end
- describe '#info' do
- it 'renders info' do
+ describe "#info" do
+ it "renders info" do
get :info
expect(response).to be_successful
- expect(response).to render_template 'info'
+ expect(response).to render_template "info"
end
end
end
diff --git a/spec/controllers/announcements_controller_spec.rb b/spec/controllers/announcements_controller_spec.rb
index 2a28c91619ed..51b27f8c430f 100644
--- a/spec/controllers/announcements_controller_spec.rb
+++ b/spec/controllers/announcements_controller_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
RSpec.describe AnnouncementsController do
let(:announcement) { build(:announcement) }
@@ -10,7 +10,7 @@
allow(Announcement).to receive(:only_one).and_return(announcement)
end
- describe '#edit' do
+ describe "#edit" do
before do
get :edit
end
@@ -22,20 +22,20 @@
it { expect(response).to be_successful }
end
- describe '#update' do
+ describe "#update" do
before do
expect(announcement).to receive(:save).and_call_original
put :update,
params: {
announcement: {
- until_date: '2011-01-11',
- text: 'announcement!!!',
+ until_date: "2011-01-11",
+ text: "announcement!!!",
active: 1
}
}
end
- it 'edits the announcement' do
+ it "edits the announcement" do
expect(response).to redirect_to action: :edit
expect(controller).to set_flash[:notice].to I18n.t(:notice_successful_update)
end
diff --git a/spec/controllers/application_controller_spec.rb b/spec/controllers/application_controller_spec.rb
index 244968946d0a..1445e4aa56d6 100644
--- a/spec/controllers/application_controller_spec.rb
+++ b/spec/controllers/application_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe ApplicationController do
let(:user) { create(:user, lastname: "Crazy name") }
@@ -39,20 +39,20 @@ def index
end
end
- describe 'logging requesting users', with_settings: { login_required: false } do
+ describe "logging requesting users", with_settings: { login_required: false } do
let(:user_message) do
"OpenProject User: #{user.firstname} Crazy name (#{user.login} ID: #{user.id} <#{user.mail}>)"
end
- let(:anonymous_message) { 'OpenProject User: Anonymous' }
+ let(:anonymous_message) { "OpenProject User: Anonymous" }
- describe 'with log_requesting_user enabled' do
+ describe "with log_requesting_user enabled" do
before do
allow(Rails.logger).to receive(:info)
allow(Setting).to receive(:log_requesting_user?).and_return(true)
end
- it 'logs the current user' do
+ it "logs the current user" do
expect(Rails.logger).to receive(:info).once.with(user_message)
as_logged_in_user(user) do
@@ -60,7 +60,7 @@ def index
end
end
- it 'logs an anonymous user' do
+ it "logs an anonymous user" do
expect(Rails.logger).to receive(:info).once.with(anonymous_message)
# no login, so this is done as Anonymous
@@ -68,12 +68,12 @@ def index
end
end
- describe 'with log_requesting_user disabled' do
+ describe "with log_requesting_user disabled" do
before do
allow(Setting).to receive(:log_requesting_user?).and_return(false)
end
- it 'does not log the current user' do
+ it "does not log the current user" do
expect(Rails.logger).not_to receive(:info).with(user_message)
as_logged_in_user(user) do
@@ -83,8 +83,8 @@ def index
end
end
- describe 'unverified request', with_settings: { login_required: false } do
- shared_examples 'handle_unverified_request resets session' do
+ describe "unverified request", with_settings: { login_required: false } do
+ shared_examples "handle_unverified_request resets session" do
before do
ActionController::Base.allow_forgery_protection = true
end
@@ -93,8 +93,8 @@ def index
ActionController::Base.allow_forgery_protection = false
end
- it 'deletes the autologin cookie' do
- cookies_double = double('cookies').as_null_object
+ it "deletes the autologin cookie" do
+ cookies_double = double("cookies").as_null_object
allow(controller)
.to receive(:cookies)
@@ -102,12 +102,12 @@ def index
expect(cookies_double)
.to receive(:delete)
- .with(OpenProject::Configuration['autologin_cookie_name'])
+ .with(OpenProject::Configuration["autologin_cookie_name"])
post :index
end
- it 'logs out the user' do
+ it "logs out the user" do
@controller.send(:logged_user=, create(:user))
allow(@controller).to receive(:render_error)
@@ -117,14 +117,14 @@ def index
end
end
- context 'for non-API resources' do
+ context "for non-API resources" do
before do
allow(@controller).to receive(:api_request?).and_return(false)
end
- it_behaves_like 'handle_unverified_request resets session'
+ it_behaves_like "handle_unverified_request resets session"
- it 'gives 422' do
+ it "gives 422" do
expect(@controller).to receive(:render_error) do |options|
expect(options[:status]).to be(422)
end
@@ -133,14 +133,14 @@ def index
end
end
- context 'for API resources' do
+ context "for API resources" do
before do
allow(@controller).to receive(:api_request?).and_return(true)
end
- it_behaves_like 'handle_unverified_request resets session'
+ it_behaves_like "handle_unverified_request resets session"
- it 'does not render an error' do
+ it "does not render an error" do
expect(@controller).not_to receive(:render_error)
@controller.send :handle_unverified_request
@@ -148,7 +148,7 @@ def index
end
end
- describe 'rack timeout duplicate error suppression', with_settings: { login_required: false } do
+ describe "rack timeout duplicate error suppression", with_settings: { login_required: false } do
controller do
include OpenProjectErrorHelper
diff --git a/spec/controllers/attribute_help_texts_controller_spec.rb b/spec/controllers/attribute_help_texts_controller_spec.rb
index 399437dabdc1..061db98398fa 100644
--- a/spec/controllers/attribute_help_texts_controller_spec.rb
+++ b/spec/controllers/attribute_help_texts_controller_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
RSpec.describe AttributeHelpTextsController do
let(:user) { build_stubbed(:user) }
@@ -19,34 +19,34 @@
end
end
- describe '#index' do
+ describe "#index" do
before do
allow(AttributeHelpText).to receive(:all).and_return [model]
get :index
end
- it 'is successful' do
+ it "is successful" do
expect(response).to be_successful
- expect(assigns(:texts_by_type)).to eql('WorkPackage' => [model])
+ expect(assigns(:texts_by_type)).to eql("WorkPackage" => [model])
end
end
- describe '#edit' do
+ describe "#edit" do
before do
find_expectation
get :edit, params: { id: 1234 }
end
- context 'when found' do
- it 'is successful' do
+ context "when found" do
+ it "is successful" do
expect(response).to be_successful
expect(assigns(:attribute_help_text)).to eql model
end
end
- context 'when not found' do
+ context "when not found" do
let(:find_expectation) do
allow(AttributeHelpText)
.to receive(:find)
@@ -54,19 +54,19 @@
.and_raise(ActiveRecord::RecordNotFound)
end
- it 'returns 404' do
+ it "returns 404" do
expect(response).to have_http_status :not_found
end
end
end
- describe '#update' do
+ describe "#update" do
let(:call) do
put :update,
params: {
id: 1234,
attribute_help_text: {
- help_text: 'my new help text'
+ help_text: "my new help text"
}
}
end
@@ -75,35 +75,35 @@
find_expectation
end
- context 'when save is success' do
+ context "when save is success" do
before do
expect(model).to receive(:save).and_return(true)
call
end
- it 'edits the announcement' do
- expect(response).to redirect_to action: :index, tab: 'WorkPackage'
+ it "edits the announcement" do
+ expect(response).to redirect_to action: :index, tab: "WorkPackage"
expect(controller).to set_flash[:notice].to I18n.t(:notice_successful_update)
- expect(model.help_text).to eq('my new help text')
+ expect(model.help_text).to eq("my new help text")
end
end
- context 'when save is failure' do
+ context "when save is failure" do
before do
expect(model).to receive(:save).and_return(false)
call
end
- it 'fails to update the announcement' do
+ it "fails to update the announcement" do
expect(response).to be_successful
- expect(response).to render_template 'edit'
+ expect(response).to render_template "edit"
end
end
- context 'when not found' do
+ context "when not found" do
let(:find_expectation) do
allow(AttributeHelpText)
.to receive(:find)
@@ -115,7 +115,7 @@
call
end
- it 'returns 404' do
+ it "returns 404" do
expect(response).to have_http_status :not_found
end
end
diff --git a/spec/controllers/categories_controller_spec.rb b/spec/controllers/categories_controller_spec.rb
index 4653a1bfa0ba..859bc1cbf06c 100644
--- a/spec/controllers/categories_controller_spec.rb
+++ b/spec/controllers/categories_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe CategoriesController do
let(:user) { create(:user) }
@@ -48,7 +48,7 @@
allow(User).to receive(:current).and_return user
end
- shared_examples_for 'redirect' do
+ shared_examples_for "redirect" do
subject { response }
it { is_expected.to be_redirect }
@@ -56,7 +56,7 @@
it { is_expected.to redirect_to("/projects/#{project.identifier}/settings/categories") }
end
- describe '#new' do
+ describe "#new" do
before do
get :new, params: { project_id: project.id }
end
@@ -65,11 +65,11 @@
it { is_expected.to be_successful }
- it { is_expected.to render_template('new') }
+ it { is_expected.to render_template("new") }
end
- describe '#create' do
- let(:category_name) { 'New category' }
+ describe "#create" do
+ let(:category_name) { "New category" }
before do
post :create,
@@ -80,7 +80,7 @@
}
end
- describe '#categories' do
+ describe "#categories" do
subject { Category.find_by(name: category_name) }
it { expect(subject.project_id).to eq(project.id) }
@@ -88,10 +88,10 @@
it { expect(subject.assigned_to_id).to eq(user.id) }
end
- it_behaves_like 'redirect'
+ it_behaves_like "redirect"
end
- describe '#edit' do
+ describe "#edit" do
let(:category) do
create(:category,
project:)
@@ -103,24 +103,24 @@
get :edit, params: { id: category_id }
end
- context 'valid category' do
+ context "valid category" do
let(:category_id) { category.id }
it { is_expected.to be_successful }
- it { is_expected.to render_template('edit') }
+ it { is_expected.to render_template("edit") }
end
- context 'invalid category' do
+ context "invalid category" do
let(:category_id) { 404 }
it { is_expected.to be_not_found }
end
end
- describe '#update' do
- let(:name) { 'Testing' }
+ describe "#update" do
+ let(:name) { "Testing" }
- context 'valid category' do
+ context "valid category" do
let(:category) do
create(:category,
project:)
@@ -138,16 +138,16 @@
it { is_expected.to eq(name) }
- describe '#category_count' do
+ describe "#category_count" do
subject { Category.count }
it { is_expected.to eq(1) }
end
- it_behaves_like 'redirect'
+ it_behaves_like "redirect"
end
- context 'invalid category' do
+ context "invalid category" do
before do
post :update,
params: {
@@ -162,7 +162,7 @@
end
end
- describe '#destroy' do
+ describe "#destroy" do
let(:category) do
create(:category,
project:)
@@ -175,23 +175,23 @@
before { category }
- shared_examples_for 'delete' do
+ shared_examples_for "delete" do
subject { Category.find_by(id: category.id) }
it { is_expected.to be_nil }
end
- context 'unused' do
+ context "unused" do
before do
delete :destroy, params: { id: category.id }
end
- it_behaves_like 'redirect'
+ it_behaves_like "redirect"
- it_behaves_like 'delete'
+ it_behaves_like "delete"
end
- context 'in use' do
+ context "in use" do
before do
work_package
@@ -202,16 +202,16 @@
it { is_expected.not_to be_nil }
- describe '#response' do
+ describe "#response" do
subject { response }
it { is_expected.to be_successful }
- it { is_expected.to render_template('destroy') }
+ it { is_expected.to render_template("destroy") }
end
end
- describe '#reassign' do
+ describe "#reassign" do
let(:target) do
create(:category,
project:)
@@ -223,7 +223,7 @@
delete :destroy,
params: {
id: category.id,
- todo: 'reassign',
+ todo: "reassign",
reassign_to_id: target.id
}
end
@@ -232,19 +232,19 @@
it { is_expected.to eq(target.id) }
- it_behaves_like 'delete'
+ it_behaves_like "delete"
- it_behaves_like 'redirect'
+ it_behaves_like "redirect"
end
- describe '#nullify' do
+ describe "#nullify" do
before do
work_package
delete :destroy,
params: {
id: category.id,
- todo: 'nullify'
+ todo: "nullify"
}
end
@@ -252,9 +252,9 @@
it { is_expected.to be_nil }
- it_behaves_like 'delete'
+ it_behaves_like "delete"
- it_behaves_like 'redirect'
+ it_behaves_like "redirect"
end
end
end
diff --git a/spec/controllers/colors_controller_spec.rb b/spec/controllers/colors_controller_spec.rb
index ee82de965387..36c74d34bffe 100644
--- a/spec/controllers/colors_controller_spec.rb
+++ b/spec/controllers/colors_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe ColorsController do
let(:current_user) { create(:admin) }
@@ -35,68 +35,68 @@
allow(User).to receive(:current).and_return current_user
end
- describe 'index.html' do
+ describe "index.html" do
def fetch
- get 'index'
+ get "index"
end
- it_behaves_like 'a controller action with require_admin'
+ it_behaves_like "a controller action with require_admin"
end
- describe 'new.html' do
+ describe "new.html" do
def fetch
- get 'new'
+ get "new"
end
- it_behaves_like 'a controller action with require_admin'
+ it_behaves_like "a controller action with require_admin"
end
- describe 'create.html' do
+ describe "create.html" do
def fetch
- post 'create', params: { color: build(:color).attributes }
+ post "create", params: { color: build(:color).attributes }
end
def expect_redirect_to
Regexp.new(colors_path)
end
- it_behaves_like 'a controller action with require_admin'
+ it_behaves_like "a controller action with require_admin"
end
- describe 'edit.html' do
+ describe "edit.html" do
def fetch
- @available_color = create(:color, id: '1337')
- get 'edit', params: { id: '1337' }
+ @available_color = create(:color, id: "1337")
+ get "edit", params: { id: "1337" }
end
- it_behaves_like 'a controller action with require_admin'
+ it_behaves_like "a controller action with require_admin"
end
- describe 'update.html' do
+ describe "update.html" do
def fetch
- @available_color = create(:color, id: '1337')
- put 'update', params: { id: '1337', color: { 'name' => 'blubs' } }
+ @available_color = create(:color, id: "1337")
+ put "update", params: { id: "1337", color: { "name" => "blubs" } }
end
def expect_redirect_to
colors_path
end
- it_behaves_like 'a controller action with require_admin'
+ it_behaves_like "a controller action with require_admin"
end
- describe 'confirm_destroy.html' do
+ describe "confirm_destroy.html" do
def fetch
- @available_color = create(:color, id: '1337')
- get 'confirm_destroy', params: { id: '1337' }
+ @available_color = create(:color, id: "1337")
+ get "confirm_destroy", params: { id: "1337" }
end
- it_behaves_like 'a controller action with require_admin'
+ it_behaves_like "a controller action with require_admin"
end
- describe 'destroy.html' do
+ describe "destroy.html" do
def fetch
- @available_color = create(:color, id: '1337')
- post 'destroy', params: { id: '1337' }
+ @available_color = create(:color, id: "1337")
+ post "destroy", params: { id: "1337" }
end
def expect_redirect_to
colors_path
end
- it_behaves_like 'a controller action with require_admin'
+ it_behaves_like "a controller action with require_admin"
end
end
diff --git a/spec/controllers/concerns/auth_source_slo_spec.rb b/spec/controllers/concerns/auth_source_slo_spec.rb
index 6e68a4f82cce..fe320d74fa9f 100644
--- a/spec/controllers/concerns/auth_source_slo_spec.rb
+++ b/spec/controllers/concerns/auth_source_slo_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
##
-RSpec.describe AccountController, 'Auth header logout' do
+RSpec.describe AccountController, "Auth header logout" do
render_views
let!(:auth_source) { create(:ldap_auth_source, name: "Dummy LDAP") }
@@ -44,34 +44,34 @@
end
end
- describe 'logout' do
- context 'when a logout URL is present' do
+ describe "logout" do
+ context "when a logout URL is present" do
let(:sso_config) do
{
- logout_url: 'https://example.org/foo?logout=true'
+ logout_url: "https://example.org/foo?logout=true"
}
end
- context 'and the user came from auth source' do
+ context "and the user came from auth source" do
before do
login_as user
session[:user_from_auth_header] = true
get :logout
end
- it 'is redirected to the logout URL' do
- expect(response).to redirect_to 'https://example.org/foo?logout=true'
+ it "is redirected to the logout URL" do
+ expect(response).to redirect_to "https://example.org/foo?logout=true"
end
end
- context 'and the user did not come from auth source' do
+ context "and the user did not come from auth source" do
before do
login_as user
session[:user_from_auth_header] = nil
get :logout
end
- it 'is redirected to the home URL' do
+ it "is redirected to the home URL" do
expect(response).to redirect_to home_url
end
end
diff --git a/spec/controllers/concerns/auth_source_sso_spec.rb b/spec/controllers/concerns/auth_source_sso_spec.rb
index bfea1e110231..edd5322155a0 100644
--- a/spec/controllers/concerns/auth_source_sso_spec.rb
+++ b/spec/controllers/concerns/auth_source_sso_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe MyController, :skip_2fa_stage do
render_views
@@ -48,7 +48,7 @@
let(:header_value) { "#{header_login_value}#{secret ? ':' : ''}#{secret}" }
let(:find_user_result) { user }
- shared_examples 'should log in the user' do
+ shared_examples "should log in the user" do
it "logs in given user" do
expect(response).to redirect_to my_account_path
expect(user.reload.last_login_on).to be_within(10.seconds).of(Time.current)
@@ -68,7 +68,7 @@
expect(failure[:ttl]).to eq 1
end
- context 'when the config is marked optional' do
+ context "when the config is marked optional" do
let(:sso_config) do
{
header:,
@@ -77,7 +77,7 @@
}
end
- context 'when no header is present' do
+ context "when no header is present" do
let(:header_value) { nil }
it "redirects to login" do
@@ -85,7 +85,7 @@
end
end
- context 'when the header is present' do
+ context "when the header is present" do
it "shows an error" do
expect(response).to redirect_to("/sso")
expect(session).to have_key(:auth_source_sso_failure)
@@ -108,32 +108,32 @@
request.headers[header] = header_value
end
- describe 'login' do
+ describe "login" do
before do
get :account
end
- it_behaves_like 'should log in the user'
+ it_behaves_like "should log in the user"
- context 'when the secret being null' do
+ context "when the secret being null" do
let(:secret) { nil }
- it_behaves_like 'should log in the user'
+ it_behaves_like "should log in the user"
end
- context 'when the secret is a number' do
+ context "when the secret is a number" do
let(:secret) { 42 }
- it_behaves_like 'should log in the user'
+ it_behaves_like "should log in the user"
end
- context 'when the header values does not match the case' do
- let(:header_login_value) { 'H.wUrSt' }
+ context "when the header values does not match the case" do
+ let(:header_login_value) { "H.wUrSt" }
- it_behaves_like 'should log in the user'
+ it_behaves_like "should log in the user"
end
- context 'when the user is invited' do
+ context "when the user is invited" do
let!(:user) do
create(:user, login:, status: Principal.statuses[:invited], ldap_auth_source:)
end
@@ -173,8 +173,8 @@
end
end
- context 'when the logged-in user differs in case' do
- let(:header_login_value) { 'h.WURST' }
+ context "when the logged-in user differs in case" do
+ let(:header_login_value) { "h.WURST" }
let(:session_update_time) { 1.minute.ago }
let(:last_login) { 1.minute.ago }
@@ -185,7 +185,7 @@
session[:should_be_kept] = true
end
- it 'logs in the user' do
+ it "logs in the user" do
get :account
expect(response).not_to be_redirect
@@ -201,8 +201,8 @@
end
end
- context 'when the logged-in user differs from the header' do
- let(:other_user) { create(:user, login: 'other_user') }
+ context "when the logged-in user differs from the header" do
+ let(:other_user) { create(:user, login: "other_user") }
let(:session_update_time) { 1.minute.ago }
let(:service) { Users::LogoutService.new(controller:) }
@@ -211,7 +211,7 @@
session[:updated_at] = session_update_time
end
- it 'logs out the user and logs it in again' do
+ it "logs out the user and logs it in again" do
allow(Users::LogoutService).to receive(:new).and_return(service)
allow(service).to receive(:call!).with(other_user).and_call_original
diff --git a/spec/controllers/concerns/omniauth_login_spec.rb b/spec/controllers/concerns/omniauth_login_spec.rb
index 9037116d4a7b..5c78e08132dd 100644
--- a/spec/controllers/concerns/omniauth_login_spec.rb
+++ b/spec/controllers/concerns/omniauth_login_spec.rb
@@ -26,100 +26,100 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
# Concern is included into AccountController and depends on methods available there
RSpec.describe AccountController, :skip_2fa_stage do
- let(:omniauth_strategy) { double('Google Strategy', name: 'google') }
+ let(:omniauth_strategy) { double("Google Strategy", name: "google") }
let(:omniauth_hash) do
OmniAuth::AuthHash.new(
- provider: 'google',
+ provider: "google",
strategy: omniauth_strategy,
- uid: '123545',
- info: { name: 'foo',
- email: 'foo@bar.com',
- first_name: 'foo',
- last_name: 'bar' }
+ uid: "123545",
+ info: { name: "foo",
+ email: "foo@bar.com",
+ first_name: "foo",
+ last_name: "bar" }
)
end
before do
- request.env['omniauth.auth'] = omniauth_hash
- request.env['omniauth.strategy'] = omniauth_strategy
+ request.env["omniauth.auth"] = omniauth_hash
+ request.env["omniauth.strategy"] = omniauth_strategy
end
after do
User.current = nil
end
- context 'GET #omniauth_login', with_settings: { self_registration: Setting::SelfRegistration.automatic } do
- describe 'with on-the-fly registration' do
- context 'providing all required fields' do
+ context "GET #omniauth_login", with_settings: { self_registration: Setting::SelfRegistration.automatic } do
+ describe "with on-the-fly registration" do
+ context "providing all required fields" do
before do
- request.env['omniauth.origin'] = 'https://example.net/some_back_url'
+ request.env["omniauth.origin"] = "https://example.net/some_back_url"
post :omniauth_login, params: { provider: :google }
end
- it 'registers the user on-the-fly' do
- user = User.find_by_login('foo@bar.com')
+ it "registers the user on-the-fly" do
+ user = User.find_by_login("foo@bar.com")
expect(user).to be_an_instance_of(User)
expect(user.ldap_auth_source_id).to be_nil
expect(user.current_password).to be_nil
- expect(user.identity_url).to eql('google:123545')
- expect(user.login).to eql('foo@bar.com')
- expect(user.firstname).to eql('foo')
- expect(user.lastname).to eql('bar')
- expect(user.mail).to eql('foo@bar.com')
+ expect(user.identity_url).to eql("google:123545")
+ expect(user.login).to eql("foo@bar.com")
+ expect(user.firstname).to eql("foo")
+ expect(user.lastname).to eql("bar")
+ expect(user.mail).to eql("foo@bar.com")
end
- it 'redirects to the first login page with a back_url' do
+ it "redirects to the first login page with a back_url" do
expect(response).to redirect_to(home_url(first_time_user: true))
end
end
- describe 'strategy uid mapping override' do
+ describe "strategy uid mapping override" do
let(:omniauth_hash) do
OmniAuth::AuthHash.new(
- provider: 'google',
+ provider: "google",
strategy: omniauth_strategy,
- uid: 'foo',
+ uid: "foo",
info: {
- uid: 'internal',
- email: 'whattheheck@example.com',
- first_name: 'what',
- last_name: 'theheck'
+ uid: "internal",
+ email: "whattheheck@example.com",
+ first_name: "what",
+ last_name: "theheck"
}
)
end
- it 'takes the uid from the mapped attributes' do
+ it "takes the uid from the mapped attributes" do
post :omniauth_login, params: { provider: :google }
- user = User.find_by_login('whattheheck@example.com')
+ user = User.find_by_login("whattheheck@example.com")
expect(user).to be_an_instance_of(User)
- expect(user.identity_url).to eq 'google:internal'
+ expect(user.identity_url).to eq "google:internal"
end
end
- describe 'strategy attribute mapping override' do
+ describe "strategy attribute mapping override" do
let(:omniauth_hash) do
OmniAuth::AuthHash.new(
- provider: 'google',
+ provider: "google",
strategy: omniauth_strategy,
- uid: 'foo',
- info: { email: 'whattheheck@example.com',
- first_name: 'what',
- last_name: 'theheck' },
+ uid: "foo",
+ info: { email: "whattheheck@example.com",
+ first_name: "what",
+ last_name: "theheck" },
extra: { raw_info: {
- real_uid: 'bar@example.org',
- first_name: 'foo',
- last_name: 'bar'
+ real_uid: "bar@example.org",
+ first_name: "foo",
+ last_name: "bar"
} }
)
end
- context 'available' do
- it 'merges the strategy mapping' do
+ context "available" do
+ it "merges the strategy mapping" do
allow(omniauth_strategy).to receive(:omniauth_hash_to_user_attributes) do |auth|
raw_info = auth[:extra][:raw_info]
{
@@ -133,44 +133,44 @@
post :omniauth_login, params: { provider: :google }
- user = User.find_by_login('bar@example.org')
+ user = User.find_by_login("bar@example.org")
expect(user).to be_an_instance_of(User)
- expect(user.firstname).to eql('foo')
- expect(user.lastname).to eql('bar')
+ expect(user.firstname).to eql("foo")
+ expect(user.lastname).to eql("bar")
end
end
- context 'unavailable' do
- it 'keeps the default mapping' do
+ context "unavailable" do
+ it "keeps the default mapping" do
post :omniauth_login, params: { provider: :google }
- user = User.find_by_login('whattheheck@example.com')
+ user = User.find_by_login("whattheheck@example.com")
expect(user).to be_an_instance_of(User)
- expect(user.firstname).to eql('what')
- expect(user.lastname).to eql('theheck')
+ expect(user.firstname).to eql("what")
+ expect(user.lastname).to eql("theheck")
end
end
end
- context 'not providing all required fields' do
+ context "not providing all required fields" do
let(:omniauth_hash) do
OmniAuth::AuthHash.new(
- provider: 'google',
- uid: '123545',
- info: { name: 'foo', email: 'foo@bar.com' }
+ provider: "google",
+ uid: "123545",
+ info: { name: "foo", email: "foo@bar.com" }
# first_name and last_name not set
)
end
- it 'renders user form' do
+ it "renders user form" do
post :omniauth_login, params: { provider: :google }
expect(response).to render_template :register
- expect(assigns(:user).mail).to eql('foo@bar.com')
+ expect(assigns(:user).mail).to eql("foo@bar.com")
end
- it 'registers user via post' do
+ it "registers user via post" do
expect(OpenProject::OmniAuth::Authorization).to receive(:after_login!) do |user, auth_hash|
- new_user = User.find_by_login('login@bar.com')
+ new_user = User.find_by_login("login@bar.com")
expect(user).to eq new_user
expect(auth_hash).to include(omniauth_hash)
end
@@ -183,22 +183,22 @@
post :register,
params: {
user: {
- login: 'login@bar.com',
- firstname: 'Foo',
- lastname: 'Smith',
- mail: 'foo@bar.com'
+ login: "login@bar.com",
+ firstname: "Foo",
+ lastname: "Smith",
+ mail: "foo@bar.com"
}
}
expect(response).to redirect_to home_url(first_time_user: true)
- user = User.find_by_login('login@bar.com')
+ user = User.find_by_login("login@bar.com")
expect(user).to be_an_instance_of(User)
expect(user.ldap_auth_source_id).to be_nil
expect(user.current_password).to be_nil
- expect(user.identity_url).to eql('google:123545')
+ expect(user.identity_url).to eql("google:123545")
end
- context 'after a timeout expired' do
+ context "after a timeout expired" do
before do
session[:auth_source_registration] = omniauth_hash.merge(
omniauth: true,
@@ -206,97 +206,97 @@
)
end
- it 'does not register the user when providing all the missing fields' do
+ it "does not register the user when providing all the missing fields" do
post :register,
params: {
user: {
- firstname: 'Foo',
- lastname: 'Smith',
- mail: 'foo@bar.com'
+ firstname: "Foo",
+ lastname: "Smith",
+ mail: "foo@bar.com"
}
}
expect(response).to redirect_to signin_path
expect(flash[:error]).to eq(I18n.t(:error_omniauth_registration_timed_out))
- expect(User.find_by_login('foo@bar.com')).to be_nil
+ expect(User.find_by_login("foo@bar.com")).to be_nil
end
- it 'does not register the user when providing all the missing fields' do
+ it "does not register the user when providing all the missing fields" do
post :register,
params: {
user: {
- firstname: 'Foo',
+ firstname: "Foo",
# lastname intentionally not provided
- mail: 'foo@bar.com'
+ mail: "foo@bar.com"
}
}
expect(response).to redirect_to signin_path
expect(flash[:error]).to eq(I18n.t(:error_omniauth_registration_timed_out))
- expect(User.find_by_login('foo@bar.com')).to be_nil
+ expect(User.find_by_login("foo@bar.com")).to be_nil
end
end
end
- context 'with self-registration disabled',
+ context "with self-registration disabled",
with_settings: { self_registration: Setting::SelfRegistration.disabled } do
let(:omniauth_hash) do
OmniAuth::AuthHash.new(
- provider: 'google',
- uid: '123',
- info: { name: 'foo',
- email: 'foo@bar.com',
- first_name: 'foo',
- last_name: 'bar' }
+ provider: "google",
+ uid: "123",
+ info: { name: "foo",
+ email: "foo@bar.com",
+ first_name: "foo",
+ last_name: "bar" }
)
end
before do
- request.env['omniauth.origin'] = 'https://example.net/some_back_url'
+ request.env["omniauth.origin"] = "https://example.net/some_back_url"
post :omniauth_login, params: { provider: :google }
end
- it 'shows a notice about the activated account', :aggregate_failures do
- expect(flash[:notice]).to eq(I18n.t('notice_account_registered_and_logged_in'))
+ it "shows a notice about the activated account", :aggregate_failures do
+ expect(flash[:notice]).to eq(I18n.t("notice_account_registered_and_logged_in"))
user = User.last
- expect(user.firstname).to eq 'foo'
- expect(user.lastname).to eq 'bar'
- expect(user.mail).to eq 'foo@bar.com'
+ expect(user.firstname).to eq "foo"
+ expect(user.lastname).to eq "bar"
+ expect(user.mail).to eq "foo@bar.com"
expect(user).to be_active
end
end
end
- describe 'login' do
+ describe "login" do
let(:omniauth_hash) do
OmniAuth::AuthHash.new(
- provider: 'google',
- uid: '123545',
- info: { name: 'foo',
- last_name: 'bar',
- email: 'foo@bar.com' }
+ provider: "google",
+ uid: "123545",
+ info: { name: "foo",
+ last_name: "bar",
+ email: "foo@bar.com" }
)
end
let(:user) do
build(:user, force_password_change: false,
- identity_url: 'google:123545')
+ identity_url: "google:123545")
end
- context 'with an active account' do
+ context "with an active account" do
before do
user.save!
end
- it 'signs in the user after successful external authentication' do
+ it "signs in the user after successful external authentication" do
post :omniauth_login, params: { provider: :google }
expect(response).to redirect_to my_page_path
end
- it 'logs a successful login' do
+ it "logs a successful login" do
post_at = Time.now.utc
post :omniauth_login, params: { provider: :google }
@@ -304,53 +304,53 @@
expect(user.last_login_on.utc.to_i).to be >= post_at.utc.to_i
end
- context 'with a back_url present' do
+ context "with a back_url present" do
before do
- request.env['omniauth.origin'] = 'http://test.host/projects'
+ request.env["omniauth.origin"] = "http://test.host/projects"
post :omniauth_login, params: { provider: :google }
end
- it 'redirects to that url', :aggregate_failures do
- expect(response).to redirect_to '/projects'
+ it "redirects to that url", :aggregate_failures do
+ expect(response).to redirect_to "/projects"
end
end
- context 'with a back_url from a login path' do
+ context "with a back_url from a login path" do
before do
- request.env['omniauth.origin'] = 'http://test.host/login'
+ request.env["omniauth.origin"] = "http://test.host/login"
post :omniauth_login, params: { provider: :google }
end
- it 'redirects to that url', :aggregate_failures do
- expect(response).to redirect_to '/my/page'
+ it "redirects to that url", :aggregate_failures do
+ expect(response).to redirect_to "/my/page"
end
end
- context 'with a partially blank auth_hash' do
+ context "with a partially blank auth_hash" do
let(:omniauth_hash) do
OmniAuth::AuthHash.new(
- provider: 'google',
- uid: '123545',
- info: { name: 'foo',
- first_name: '',
- last_name: 'newLastname',
- email: 'foo@bar.com' }
+ provider: "google",
+ uid: "123545",
+ info: { name: "foo",
+ first_name: "",
+ last_name: "newLastname",
+ email: "foo@bar.com" }
)
end
- it 'signs in the user after successful external authentication' do
+ it "signs in the user after successful external authentication" do
expect { post :omniauth_login, params: { provider: :google } }
.not_to change { user.reload.firstname }
expect(response).to redirect_to my_page_path
- expect(user.lastname).to eq 'newLastname'
+ expect(user.lastname).to eq "newLastname"
end
end
- describe 'authorization' do
+ describe "authorization" do
let(:config) do
- Struct.new(:google_name, :global_email).new 'foo', 'foo@bar.com'
+ Struct.new(:google_name, :global_email).new "foo", "foo@bar.com"
end
before do
@@ -377,7 +377,7 @@
# ineffective callback
OpenProject::OmniAuth::Authorization.authorize_user provider: :foobar do |dec, _|
- dec.reject 'Though shalt not pass!'
+ dec.reject "Though shalt not pass!"
end
# free for all callback
@@ -390,7 +390,7 @@
OpenProject::OmniAuth::Authorization.callbacks.clear
end
- it 'works' do
+ it "works" do
expect(OpenProject::OmniAuth::Authorization).to receive(:after_login!) do |u, auth|
expect(u).to eq user
expect(auth).to eq omniauth_hash
@@ -401,55 +401,55 @@
expect(response).to redirect_to my_page_path
end
- context 'with wrong email address' do
+ context "with wrong email address" do
before do
- config.global_email = 'other@mail.com'
+ config.global_email = "other@mail.com"
end
- it 'is rejected against google' do
+ it "is rejected against google" do
expect(OpenProject::OmniAuth::Authorization).not_to receive(:after_login!).with(user)
post :omniauth_login, params: { provider: :google }
expect(response).to redirect_to signin_path
- expect(flash[:error]).to eq 'I only want to see other@mail.com here.'
+ expect(flash[:error]).to eq "I only want to see other@mail.com here."
end
- it 'is rejected against any other provider too' do
+ it "is rejected against any other provider too" do
expect(OpenProject::OmniAuth::Authorization).not_to receive(:after_login!).with(user)
- omniauth_hash.provider = 'any other'
+ omniauth_hash.provider = "any other"
post :omniauth_login, params: { provider: :google }
expect(response).to redirect_to signin_path
- expect(flash[:error]).to eq 'I only want to see other@mail.com here.'
+ expect(flash[:error]).to eq "I only want to see other@mail.com here."
end
end
- context 'with the wrong name' do
+ context "with the wrong name" do
render_views
before do
- config.google_name = 'hans'
+ config.google_name = "hans"
end
- it 'is rejected against google' do
+ it "is rejected against google" do
expect(OpenProject::OmniAuth::Authorization).not_to receive(:after_login!).with(user)
post :omniauth_login, params: { provider: :google }
expect(response).to redirect_to signin_path
- expect(flash[:error]).to eq 'Go away foo!'
+ expect(flash[:error]).to eq "Go away foo!"
end
- it 'is approved against any other provider' do
+ it "is approved against any other provider" do
expect(OpenProject::OmniAuth::Authorization).to receive(:after_login!) do |u|
- new_user = User.find_by identity_url: 'some other:123545'
+ new_user = User.find_by identity_url: "some other:123545"
expect(u).to eq new_user
end
- omniauth_hash.provider = 'some other'
+ omniauth_hash.provider = "some other"
post :omniauth_login, params: { provider: :google }
@@ -460,22 +460,22 @@
end
# ... and to confirm that, here's what happens when the authorization fails
- it 'is rejected against any other provider with the wrong email' do
+ it "is rejected against any other provider with the wrong email" do
expect(OpenProject::OmniAuth::Authorization).not_to receive(:after_login!).with(user)
- omniauth_hash.provider = 'yet another'
- config.global_email = 'yarrrr@joro.es'
+ omniauth_hash.provider = "yet another"
+ config.global_email = "yarrrr@joro.es"
post :omniauth_login, params: { provider: :google }
expect(response).to redirect_to signin_path
- expect(flash[:error]).to eq 'I only want to see yarrrr@joro.es here.'
+ expect(flash[:error]).to eq "I only want to see yarrrr@joro.es here."
end
end
end
end
- context 'with a registered and not activated accout',
+ context "with a registered and not activated accout",
with_settings: { self_registration: Setting::SelfRegistration.by_email } do
before do
user.register
@@ -484,13 +484,13 @@
post :omniauth_login, params: { provider: :google }
end
- it 'shows a notice about the activated account', :aggregate_failures do
- expect(flash[:notice]).to eq(I18n.t('notice_account_registered_and_logged_in'))
+ it "shows a notice about the activated account", :aggregate_failures do
+ expect(flash[:notice]).to eq(I18n.t("notice_account_registered_and_logged_in"))
expect(user.reload).to be_active
end
end
- context 'with an invited user and self registration disabled',
+ context "with an invited user and self registration disabled",
with_settings: { self_registration: Setting::SelfRegistration.disabled } do
before do
user.invite
@@ -499,13 +499,13 @@
post :omniauth_login, params: { provider: :google }
end
- it 'shows a notice about the activated account', :aggregate_failures do
- expect(flash[:notice]).to eq(I18n.t('notice_account_registered_and_logged_in'))
+ it "shows a notice about the activated account", :aggregate_failures do
+ expect(flash[:notice]).to eq(I18n.t("notice_account_registered_and_logged_in"))
expect(user.reload).to be_active
end
end
- context 'with a locked account',
+ context "with a locked account",
with_settings: { brute_force_block_after_failed_logins: 0 } do
before do
user.lock
@@ -514,20 +514,20 @@
post :omniauth_login, params: { provider: :google }
end
- it 'shows an error indicating a failed login', :aggregate_failures do
+ it "shows an error indicating a failed login", :aggregate_failures do
expect(flash[:error]).to eql(I18n.t(:notice_account_invalid_credentials))
expect(response).to redirect_to signin_path
end
end
end
- describe 'with an invalid auth_hash' do
+ describe "with an invalid auth_hash" do
let(:omniauth_hash) do
OmniAuth::AuthHash.new(
- provider: 'google',
+ provider: "google",
# id is deliberately missing here to make the auth_hash invalid
- info: { name: 'foo',
- email: 'foo@bar.com' }
+ info: { name: "foo",
+ email: "foo@bar.com" }
)
end
@@ -535,29 +535,29 @@
post :omniauth_login, params: { provider: :google }
end
- it 'responds with an error' do
- expect(flash[:error]).to include 'The authentication information returned from the identity provider was invalid.'
+ it "responds with an error" do
+ expect(flash[:error]).to include "The authentication information returned from the identity provider was invalid."
expect(response).to redirect_to signin_path
end
- it 'does not sign in the user' do
+ it "does not sign in the user" do
expect(controller.send(:current_user).logged?).to be_falsey
end
- it 'does not set registration information in the session' do
+ it "does not set registration information in the session" do
expect(session[:auth_source_registration]).to be_nil
end
end
- describe 'Error occurs during authentication' do
- it 'redirects to login page' do
+ describe "Error occurs during authentication" do
+ it "redirects to login page" do
post :omniauth_failure
expect(response).to redirect_to signin_path
end
- it 'logs a warn message' do
- expect(Rails.logger).to receive(:warn).with('invalid_credentials')
- post :omniauth_failure, params: { message: 'invalid_credentials' }
+ it "logs a warn message" do
+ expect(Rails.logger).to receive(:warn).with("invalid_credentials")
+ post :omniauth_failure, params: { message: "invalid_credentials" }
end
end
end
diff --git a/spec/controllers/concerns/user_invitation_spec.rb b/spec/controllers/concerns/user_invitation_spec.rb
index 6e9ea09f8fdc..a4bd7eaae779 100644
--- a/spec/controllers/concerns/user_invitation_spec.rb
+++ b/spec/controllers/concerns/user_invitation_spec.rb
@@ -26,22 +26,22 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe UserInvitation do
- describe '.reinvite_user' do
+ describe ".reinvite_user" do
let(:user) { create(:invited_user) }
let!(:token) { create(:invitation_token, user:) }
- it 'notifies listeners of the re-invite' do
+ it "notifies listeners of the re-invite" do
expect(OpenProject::Notifications).to receive(:send) do |event, _new_token|
- expect(event).to eq 'user_reinvited'
+ expect(event).to eq "user_reinvited"
end
UserInvitation.reinvite_user user.id
end
- it 'creates a new token' do
+ it "creates a new token" do
new_token = UserInvitation.reinvite_user user.id
expect(new_token.value).not_to eq token.value
diff --git a/spec/controllers/custom_actions_controller_spec.rb b/spec/controllers/custom_actions_controller_spec.rb
index 0fc07f5376c3..f13fd01a8202 100644
--- a/spec/controllers/custom_actions_controller_spec.rb
+++ b/spec/controllers/custom_actions_controller_spec.rb
@@ -26,63 +26,63 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe CustomActionsController, with_ee: %i[custom_actions] do
let(:admin) { build(:admin) }
let(:non_admin) { build(:user) }
let(:action) { build_stubbed(:custom_action) }
let(:params) do
- { custom_action: { name: 'blubs',
+ { custom_action: { name: "blubs",
actions: { assigned_to: 1 } } }
end
- shared_examples_for 'read requires enterprise token' do
- context 'without an enterprise token', with_ee: false do
+ shared_examples_for "read requires enterprise token" do
+ context "without an enterprise token", with_ee: false do
before do
login_as(admin)
call
end
- it 'renders enterprise_token' do
+ it "renders enterprise_token" do
expect(response)
- .to render_template 'common/upsale'
+ .to render_template "common/upsale"
end
end
end
- shared_examples_for 'write requires enterprise token' do
- context 'without an enterprise token', with_ee: false do
+ shared_examples_for "write requires enterprise token" do
+ context "without an enterprise token", with_ee: false do
before do
login_as(admin)
call
end
- it 'renders enterprise_token' do
+ it "renders enterprise_token" do
expect(response.response_code)
.to be 403
end
end
end
- shared_examples_for '403 for non admins' do
- context 'for non admins' do
+ shared_examples_for "403 for non admins" do
+ context "for non admins" do
before do
login_as(non_admin)
call
end
- it 'returns 403' do
+ it "returns 403" do
expect(response.response_code)
.to be 403
end
end
end
- describe '#index' do
+ describe "#index" do
let(:call) { get :index }
before do
@@ -91,37 +91,37 @@
.and_return([action])
end
- context 'for admins' do
+ context "for admins" do
before do
login_as(admin)
call
end
- it 'returns 200' do
+ it "returns 200" do
expect(response.response_code)
.to be 200
end
- it 'renders index template' do
+ it "renders index template" do
expect(response)
- .to render_template('index')
+ .to render_template("index")
end
- it 'assigns the custom actions' do
+ it "assigns the custom actions" do
expect(assigns(:custom_actions))
.to contain_exactly(action)
end
end
- it_behaves_like '403 for non admins'
- it_behaves_like 'read requires enterprise token'
+ it_behaves_like "403 for non admins"
+ it_behaves_like "read requires enterprise token"
end
- describe '#new' do
+ describe "#new" do
let(:call) { get(:new) }
- context 'for admins' do
+ context "for admins" do
before do
login_as(admin)
@@ -132,27 +132,27 @@
call
end
- it 'returns 200' do
+ it "returns 200" do
expect(response.response_code)
.to be 200
end
- it 'renders new template' do
+ it "renders new template" do
expect(response)
- .to render_template('new')
+ .to render_template("new")
end
- it 'assigns custom_action' do
+ it "assigns custom_action" do
expect(assigns(:custom_action))
.to eql action
end
end
- it_behaves_like '403 for non admins'
- it_behaves_like 'read requires enterprise token'
+ it_behaves_like "403 for non admins"
+ it_behaves_like "read requires enterprise token"
end
- describe '#create' do
+ describe "#create" do
let(:call) { post :create, params: }
let(:current_user) { admin }
let(:service_success) { true }
@@ -164,7 +164,7 @@
.merge(ActionController::Parameters.new(actions: { assigned_to: "1" }).permit!)
end
let!(:service) do
- service = double('create service')
+ service = double("create service")
allow(CustomActions::CreateService)
.to receive(:new)
@@ -183,40 +183,40 @@
result: action)
end
- context 'for admins' do
+ context "for admins" do
before do
login_as(current_user)
call
end
- context 'on success' do
- it 'redirects to index' do
+ context "on success" do
+ it "redirects to index" do
expect(response)
.to redirect_to(custom_actions_path)
end
end
- context 'on failure' do
+ context "on failure" do
let(:service_success) { false }
- it 'renders new' do
+ it "renders new" do
expect(response)
.to render_template(:new)
end
- it 'assigns custom action' do
+ it "assigns custom action" do
expect(assigns[:custom_action])
.to eql action
end
end
end
- it_behaves_like '403 for non admins'
- it_behaves_like 'write requires enterprise token'
+ it_behaves_like "403 for non admins"
+ it_behaves_like "write requires enterprise token"
end
- describe '#edit' do
+ describe "#edit" do
let(:params) do
{ id: "42" }
end
@@ -231,30 +231,30 @@
.and_return(action)
end
- context 'for admins' do
+ context "for admins" do
before do
login_as(admin)
call
end
- it 'returns 200' do
+ it "returns 200" do
expect(response.response_code)
.to be 200
end
- it 'renders edit template' do
+ it "renders edit template" do
expect(response)
- .to render_template('edit')
+ .to render_template("edit")
end
- it 'assigns custom_action' do
+ it "assigns custom_action" do
expect(assigns(:custom_action))
.to eql action
end
end
- context 'for admins on invalid id' do
+ context "for admins on invalid id" do
before do
allow(CustomAction)
.to receive(:find)
@@ -266,17 +266,17 @@
call
end
- it 'returns 404 NOT FOUND' do
+ it "returns 404 NOT FOUND" do
expect(response.response_code)
.to be 404
end
end
- it_behaves_like '403 for non admins'
- it_behaves_like 'read requires enterprise token'
+ it_behaves_like "403 for non admins"
+ it_behaves_like "read requires enterprise token"
end
- describe '#update' do
+ describe "#update" do
let(:call) { patch :update, params: }
let(:current_user) { admin }
let(:service_success) { true }
@@ -288,12 +288,12 @@
.merge(ActionController::Parameters.new(actions: { assigned_to: "1" }).permit!)
end
let(:params) do
- { custom_action: { name: 'blubs',
+ { custom_action: { name: "blubs",
actions: { assigned_to: 1 } },
id: "42" }
end
let!(:service) do
- service = double('update service')
+ service = double("update service")
allow(CustomActions::UpdateService)
.to receive(:new)
@@ -319,36 +319,36 @@
.and_return(action)
end
- context 'for admins' do
+ context "for admins" do
before do
login_as(current_user)
call
end
- context 'on success' do
- it 'redirects to index' do
+ context "on success" do
+ it "redirects to index" do
expect(response)
.to redirect_to(custom_actions_path)
end
end
- context 'on failure' do
+ context "on failure" do
let(:service_success) { false }
- it 'rerenders edit action' do
+ it "rerenders edit action" do
expect(response)
.to render_template(:edit)
end
- it 'assigns the action' do
+ it "assigns the action" do
expect(assigns[:custom_action])
.to eql(action)
end
end
end
- context 'for admins on invalid id' do
+ context "for admins on invalid id" do
before do
allow(CustomAction)
.to receive(:find)
@@ -360,17 +360,17 @@
call
end
- it 'returns 404 NOT FOUND' do
+ it "returns 404 NOT FOUND" do
expect(response.response_code)
.to be 404
end
end
- it_behaves_like '403 for non admins'
- it_behaves_like 'write requires enterprise token'
+ it_behaves_like "403 for non admins"
+ it_behaves_like "write requires enterprise token"
end
- describe '#destroy' do
+ describe "#destroy" do
let(:call) { delete :destroy, params: }
let(:current_user) { admin }
let(:params) do
@@ -384,7 +384,7 @@
.and_return(action)
end
- context 'for admins' do
+ context "for admins" do
before do
expect(action)
.to receive(:destroy)
@@ -395,13 +395,13 @@
call
end
- it 'redirects to index' do
+ it "redirects to index" do
expect(response)
.to redirect_to(custom_actions_path)
end
end
- context 'for admins on invalid id' do
+ context "for admins on invalid id" do
before do
allow(CustomAction)
.to receive(:find)
@@ -413,13 +413,13 @@
call
end
- it 'returns 404 NOT FOUND' do
+ it "returns 404 NOT FOUND" do
expect(response.response_code)
.to be 404
end
end
- it_behaves_like '403 for non admins'
- it_behaves_like 'write requires enterprise token'
+ it_behaves_like "403 for non admins"
+ it_behaves_like "write requires enterprise token"
end
end
diff --git a/spec/controllers/custom_fields_controller_spec.rb b/spec/controllers/custom_fields_controller_spec.rb
index a8705c01d000..793459ffb53e 100644
--- a/spec/controllers/custom_fields_controller_spec.rb
+++ b/spec/controllers/custom_fields_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe CustomFieldsController do
shared_let(:admin) { create(:admin) }
@@ -37,16 +37,16 @@
login_as admin
end
- describe 'POST edit' do
+ describe "POST edit" do
before do
allow(CustomField).to receive(:find).and_return(custom_field)
allow(custom_field).to receive(:save).and_return(true)
end
- describe 'WITH all ok params' do
+ describe "WITH all ok params" do
let(:params) do
{
- 'custom_field' => { 'name' => 'Issue Field' }
+ "custom_field" => { "name" => "Issue Field" }
}
end
@@ -54,21 +54,21 @@
put :update, params: params.merge(id: custom_field.id)
end
- it 'works' do
+ it "works" do
expect(response).to be_redirect
- expect(custom_field.name).to eq('Issue Field')
+ expect(custom_field.name).to eq("Issue Field")
end
end
end
- describe 'POST new' do
- describe 'WITH empty name param' do
+ describe "POST new" do
+ describe "WITH empty name param" do
let(:params) do
{
- 'type' => 'WorkPackageCustomField',
- 'custom_field' => {
- 'name' => '',
- 'field_format' => 'string'
+ "type" => "WorkPackageCustomField",
+ "custom_field" => {
+ "name" => "",
+ "field_format" => "string"
}
}
end
@@ -77,19 +77,19 @@
post :create, params:
end
- it 'responds with error' do
- expect(response).to render_template 'new'
+ it "responds with error" do
+ expect(response).to render_template "new"
expect(assigns(:custom_field).errors.messages[:name].first).to eq("can't be blank.")
end
end
- describe 'WITH all ok params' do
+ describe "WITH all ok params" do
let(:params) do
{
- 'type' => 'WorkPackageCustomField',
- 'custom_field' => {
- 'name' => 'field',
- 'field_format' => 'string'
+ "type" => "WorkPackageCustomField",
+ "custom_field" => {
+ "name" => "field",
+ "field_format" => "string"
}
}
end
@@ -98,9 +98,9 @@
post :create, params:
end
- it 'responds ok' do
+ it "responds ok" do
expect(response).to be_redirect
- expect(CustomField.last.name).to eq 'field'
+ expect(CustomField.last.name).to eq "field"
end
end
end
diff --git a/spec/controllers/custom_styles_controller_spec.rb b/spec/controllers/custom_styles_controller_spec.rb
index 3d8122a03eac..3577715bc3e7 100644
--- a/spec/controllers/custom_styles_controller_spec.rb
+++ b/spec/controllers/custom_styles_controller_spec.rb
@@ -26,32 +26,32 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe CustomStylesController do
before do
login_as user
end
- context 'with admin' do
+ context "with admin" do
let(:user) { build(:admin) }
- describe '#show' do
+ describe "#show" do
subject { get :show }
- context 'when active token exists', with_ee: %i[define_custom_style] do
- it 'renders show' do
+ context "when active token exists", with_ee: %i[define_custom_style] do
+ it "renders show" do
expect(subject).to be_successful
- expect(response).to render_template 'show'
+ expect(response).to render_template "show"
end
end
- context 'when no active token exists' do
+ context "when no active token exists" do
before do
allow(EnterpriseToken).to receive(:current).and_return(nil)
end
- it 'redirects to #upsale' do
+ it "redirects to #upsale" do
expect(subject).to redirect_to action: :upsale
end
end
@@ -60,9 +60,9 @@
describe "#upsale" do
subject { get :upsale }
- it 'renders upsale' do
+ it "renders upsale" do
expect(subject).to be_successful
- expect(subject).to render_template 'upsale'
+ expect(subject).to render_template "upsale"
end
end
@@ -70,7 +70,7 @@
let(:custom_style) { CustomStyle.new }
let(:params) do
{
- custom_style: { logo: 'foo', favicon: 'bar', icon_touch: 'yay' }
+ custom_style: { logo: "foo", favicon: "bar", icon_touch: "yay" }
}
end
@@ -81,20 +81,20 @@
post :create, params:
end
- context 'with valid custom_style input' do
+ context "with valid custom_style input" do
let(:valid) { true }
- it 'redirects to show' do
+ it "redirects to show" do
expect(response).to redirect_to action: :show
end
end
- context 'with invalid custom_style input' do
+ context "with invalid custom_style input" do
let(:valid) { false }
- it 'renders with error' do
+ it "renders with error" do
expect(response).not_to be_redirect
- expect(response).to render_template 'custom_styles/show'
+ expect(response).to render_template "custom_styles/show"
end
end
end
@@ -103,11 +103,11 @@
let(:custom_style) { build(:custom_style_with_logo) }
let(:params) do
{
- custom_style: { logo: 'foo', favicon: 'bar', icon_touch: 'yay' }
+ custom_style: { logo: "foo", favicon: "bar", icon_touch: "yay" }
}
end
- context 'with an existing CustomStyle' do
+ context "with an existing CustomStyle" do
before do
allow(CustomStyle).to receive(:current).and_return(custom_style)
allow(custom_style).to receive(:update).and_return(valid)
@@ -115,25 +115,25 @@
post :update, params:
end
- context 'with valid custom_style input' do
+ context "with valid custom_style input" do
let(:valid) { true }
- it 'redirects to show' do
+ it "redirects to show" do
expect(response).to redirect_to action: :show
end
end
- context 'with invalid custom_style input' do
+ context "with invalid custom_style input" do
let(:valid) { false }
- it 'renders with error' do
+ it "renders with error" do
expect(response).not_to be_redirect
- expect(response).to render_template 'custom_styles/show'
+ expect(response).to render_template "custom_styles/show"
end
end
end
- context 'without an existing CustomStyle' do
+ context "without an existing CustomStyle" do
before do
allow(CustomStyle).to receive(:create!).and_return(custom_style)
allow(custom_style).to receive(:update).and_return(valid)
@@ -141,20 +141,20 @@
post :update, params:
end
- context 'with valid custom_style input' do
+ context "with valid custom_style input" do
let(:valid) { true }
- it 'redirects to show' do
+ it "redirects to show" do
expect(response).to redirect_to action: :show
end
end
- context 'with invalid custom_style input' do
+ context "with invalid custom_style input" do
let(:valid) { false }
- it 'renders with error' do
+ it "renders with error" do
expect(response).not_to be_redirect
- expect(response).to render_template 'custom_styles/show'
+ expect(response).to render_template "custom_styles/show"
end
end
end
@@ -170,7 +170,7 @@
context "when logo is present" do
let(:custom_style) { build(:custom_style_with_logo) }
- it 'sends a file' do
+ it "sends a file" do
expect(response).to have_http_status(:ok)
end
end
@@ -178,7 +178,7 @@
context "when no custom style is present" do
let(:custom_style) { nil }
- it 'renders with error' do
+ it "renders with error" do
expect(controller).not_to have_received(:send_file)
expect(response).to have_http_status(:not_found)
end
@@ -187,7 +187,7 @@
context "when no logo is present" do
let(:custom_style) { build_stubbed(:custom_style) }
- it 'renders with error' do
+ it "renders with error" do
expect(controller).not_to have_received(:send_file)
expect(response).to have_http_status(:not_found)
end
@@ -197,25 +197,25 @@
describe "#logo_delete", with_ee: %i[define_custom_style] do
let(:custom_style) { create(:custom_style_with_logo) }
- context 'if it exists' do
+ context "if it exists" do
before do
allow(CustomStyle).to receive(:current).and_return(custom_style)
allow(custom_style).to receive(:remove_logo).and_call_original
delete :logo_delete
end
- it 'removes the logo from custom_style' do
+ it "removes the logo from custom_style" do
expect(response).to redirect_to action: :show
end
end
- context 'if it does not exist' do
+ context "if it does not exist" do
before do
allow(CustomStyle).to receive(:current).and_return(nil)
delete :logo_delete
end
- it 'renders 404' do
+ it "renders 404" do
expect(response).to have_http_status :not_found
end
end
@@ -231,7 +231,7 @@
context "when export logo is present" do
let(:custom_style) { build(:custom_style_with_export_logo) }
- it 'sends a file' do
+ it "sends a file" do
expect(response).to have_http_status(:ok)
end
end
@@ -239,7 +239,7 @@
context "when no custom style is present" do
let(:custom_style) { nil }
- it 'renders with error' do
+ it "renders with error" do
expect(controller).not_to have_received(:send_file)
expect(response).to have_http_status(:not_found)
end
@@ -248,7 +248,7 @@
context "when no export logo is present" do
let(:custom_style) { build_stubbed(:custom_style) }
- it 'renders with error' do
+ it "renders with error" do
expect(controller).not_to have_received(:send_file)
expect(response).to have_http_status(:not_found)
end
@@ -258,25 +258,25 @@
describe "#export_logo_delete", with_ee: %i[define_custom_style] do
let(:custom_style) { create(:custom_style_with_export_logo) }
- context 'if it exists' do
+ context "if it exists" do
before do
allow(CustomStyle).to receive(:current).and_return(custom_style)
allow(custom_style).to receive(:remove_export_logo).and_call_original
delete :export_logo_delete
end
- it 'removes the export logo from custom_style' do
+ it "removes the export logo from custom_style" do
expect(response).to redirect_to action: :show
end
end
- context 'if it does not exist' do
+ context "if it does not exist" do
before do
allow(CustomStyle).to receive(:current).and_return(nil)
delete :export_logo_delete
end
- it 'renders 404' do
+ it "renders 404" do
expect(response).to have_http_status :not_found
end
end
@@ -292,7 +292,7 @@
context "when export cover is present" do
let(:custom_style) { build(:custom_style_with_export_cover) }
- it 'sends a file' do
+ it "sends a file" do
expect(response).to have_http_status(:ok)
end
end
@@ -300,7 +300,7 @@
context "when no custom style is present" do
let(:custom_style) { nil }
- it 'renders with error' do
+ it "renders with error" do
expect(controller).not_to have_received(:send_file)
expect(response).to have_http_status(:not_found)
end
@@ -309,7 +309,7 @@
context "when no export cover is present" do
let(:custom_style) { build_stubbed(:custom_style) }
- it 'renders with error' do
+ it "renders with error" do
expect(controller).not_to have_received(:send_file)
expect(response).to have_http_status(:not_found)
end
@@ -319,25 +319,25 @@
describe "#export_cover_delete", with_ee: %i[define_custom_style] do
let(:custom_style) { create(:custom_style_with_export_cover) }
- context 'if it exists' do
+ context "if it exists" do
before do
allow(CustomStyle).to receive(:current).and_return(custom_style)
allow(custom_style).to receive(:remove_cover).and_call_original
delete :export_cover_delete
end
- it 'removes the export cover from custom_style' do
+ it "removes the export cover from custom_style" do
expect(response).to redirect_to action: :show
end
end
- context 'if it does not exist' do
+ context "if it does not exist" do
before do
allow(CustomStyle).to receive(:current).and_return(nil)
delete :export_cover_delete
end
- it 'renders 404' do
+ it "renders 404" do
expect(response).to have_http_status :not_found
end
end
@@ -353,7 +353,7 @@
context "when favicon is present" do
let(:custom_style) { build(:custom_style_with_favicon) }
- it 'sends a file' do
+ it "sends a file" do
expect(response).to have_http_status(:ok)
end
end
@@ -361,7 +361,7 @@
context "when no custom style is present" do
let(:custom_style) { nil }
- it 'renders with error' do
+ it "renders with error" do
expect(controller).not_to have_received(:send_file)
expect(response).to have_http_status(:not_found)
end
@@ -370,7 +370,7 @@
context "when no favicon is present" do
let(:custom_style) { build(:custom_style) }
- it 'renders with error' do
+ it "renders with error" do
expect(controller).not_to have_received(:send_file)
expect(response).to have_http_status(:not_found)
end
@@ -380,25 +380,25 @@
describe "#favicon_delete", with_ee: %i[define_custom_style] do
let(:custom_style) { create(:custom_style_with_favicon) }
- context 'if it exists' do
+ context "if it exists" do
before do
allow(CustomStyle).to receive(:current).and_return(custom_style)
allow(custom_style).to receive(:remove_favicon).and_call_original
delete :favicon_delete
end
- it 'removes the favicon from custom_style' do
+ it "removes the favicon from custom_style" do
expect(response).to redirect_to action: :show
end
end
- context 'if it does not exist' do
+ context "if it does not exist" do
before do
allow(CustomStyle).to receive(:current).and_return(nil)
delete :favicon_delete
end
- it 'renders 404' do
+ it "renders 404" do
expect(response).to have_http_status :not_found
end
end
@@ -414,7 +414,7 @@
context "when touch icon is present" do
let(:custom_style) { build(:custom_style_with_touch_icon) }
- it 'sends a file' do
+ it "sends a file" do
expect(response).to have_http_status(:ok)
end
end
@@ -422,7 +422,7 @@
context "when no custom style is present" do
let(:custom_style) { nil }
- it 'renders with error' do
+ it "renders with error" do
expect(controller).not_to have_received(:send_file)
expect(response).to have_http_status(:not_found)
end
@@ -431,7 +431,7 @@
context "when no touch icon is present" do
let(:custom_style) { build(:custom_style) }
- it 'renders with error' do
+ it "renders with error" do
expect(controller).not_to have_received(:send_file)
expect(response).to have_http_status(:not_found)
end
@@ -441,25 +441,25 @@
describe "#touch_icon_delete", with_ee: %i[define_custom_style] do
let(:custom_style) { create(:custom_style_with_touch_icon) }
- context 'if it exists' do
+ context "if it exists" do
before do
allow(CustomStyle).to receive(:current).and_return(custom_style)
allow(custom_style).to receive(:remove_touch_icon).and_call_original
delete :touch_icon_delete
end
- it 'removes the touch icon from custom_style' do
+ it "removes the touch icon from custom_style" do
expect(response).to redirect_to action: :show
end
end
- context 'if it does not exist' do
+ context "if it does not exist" do
before do
allow(CustomStyle).to receive(:current).and_return(nil)
delete :touch_icon_delete
end
- it 'renders 404' do
+ it "renders 404" do
expect(response).to have_http_status :not_found
end
end
@@ -470,7 +470,7 @@
{ export_cover_text_color: "#990000" }
end
- context 'if CustomStyle exists' do
+ context "if CustomStyle exists" do
let(:custom_style) { CustomStyle.new }
before do
@@ -478,7 +478,7 @@
allow(custom_style).to receive(:export_cover_text_color).and_call_original
end
- context 'with valid parameter' do
+ context "with valid parameter" do
before do
post :update_export_cover_text_color, params:
end
@@ -489,9 +489,9 @@
end
end
- context 'with valid empty parameter' do
+ context "with valid empty parameter" do
let(:params) do
- { export_cover_text_color: '' }
+ { export_cover_text_color: "" }
end
before do
@@ -506,7 +506,7 @@
end
end
- context 'with invalid parameter' do
+ context "with invalid parameter" do
let(:params) do
{ export_cover_text_color: "red" } # we only accept hexcodes
end
@@ -522,13 +522,13 @@
end
end
- context 'if CustomStyle does not exist' do
+ context "if CustomStyle does not exist" do
before do
allow(CustomStyle).to receive(:current).and_return(nil)
post :update_export_cover_text_color, params:
end
- it 'is created' do
+ it "is created" do
expect(response).to redirect_to action: :show
end
end
@@ -569,21 +569,21 @@
end
end
- context 'for a regular user' do
+ context "for a regular user" do
let(:user) { build(:user) }
- describe '#get' do
+ describe "#get" do
before do
get :show
end
- it 'requires admin' do
+ it "requires admin" do
expect(response).to have_http_status :forbidden
end
end
end
- context 'for an anonymous user' do
+ context "for an anonymous user" do
let(:user) { User.anonymous }
describe "#logo_download" do
@@ -596,7 +596,7 @@
context "when logo is present" do
let(:custom_style) { build(:custom_style_with_logo) }
- it 'sends a file' do
+ it "sends a file" do
expect(response).to have_http_status(:ok)
end
end
@@ -604,7 +604,7 @@
context "when no logo is present" do
let(:custom_style) { nil }
- it 'renders with error' do
+ it "renders with error" do
expect(controller).not_to have_received(:send_file)
expect(response).to have_http_status(:not_found)
end
diff --git a/spec/controllers/enterprises_controller_spec.rb b/spec/controllers/enterprises_controller_spec.rb
index 9abf16a2bed7..d836668e2c83 100644
--- a/spec/controllers/enterprises_controller_spec.rb
+++ b/spec/controllers/enterprises_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe EnterprisesController do
let(:a_token) { EnterpriseToken.new }
@@ -49,46 +49,46 @@
allow(a_token).to receive(:token_object).and_return(token_object)
end
- context 'with admin' do
+ context "with admin" do
let(:user) { build(:admin) }
- describe '#show' do
+ describe "#show" do
render_views
- context 'when token exists' do
+ context "when token exists" do
before do
allow(EnterpriseToken).to receive(:current).and_return(a_token)
get :show
end
- shared_examples 'it renders the EE overview' do
- it 'renders the overview' do
+ shared_examples "it renders the EE overview" do
+ it "renders the overview" do
expect(response).to be_successful
- expect(response).to render_template 'show'
- expect(response).to render_template partial: 'enterprises/_current'
- expect(response).to render_template partial: 'enterprises/_form'
+ expect(response).to render_template "show"
+ expect(response).to render_template partial: "enterprises/_current"
+ expect(response).to render_template partial: "enterprises/_form"
end
end
- it_behaves_like 'it renders the EE overview'
+ it_behaves_like "it renders the EE overview"
- context 'with version >= 2.0' do
+ context "with version >= 2.0" do
let(:token_attributes) { super().merge version: "2.0" }
- context 'with correct domain', with_settings: { host_name: 'community.openproject.com' } do
- let(:token_attributes) { super().merge domain: 'community.openproject.com' }
+ context "with correct domain", with_settings: { host_name: "community.openproject.com" } do
+ let(:token_attributes) { super().merge domain: "community.openproject.com" }
- it_behaves_like 'it renders the EE overview'
+ it_behaves_like "it renders the EE overview"
it "doesn't show any warnings or errors" do
expect(controller).not_to set_flash.now
end
end
- context 'with wrong domain', with_settings: { host_name: 'community.openproject.com' } do
- let(:token_attributes) { super().merge domain: 'localhost' }
+ context "with wrong domain", with_settings: { host_name: "community.openproject.com" } do
+ let(:token_attributes) { super().merge domain: "localhost" }
- it_behaves_like 'it renders the EE overview'
+ it_behaves_like "it renders the EE overview"
it "shows an invalid domain error" do
expect(controller).to set_flash.now[:error].to(/.*localhost.*does not match.*community.openproject.com/)
@@ -96,13 +96,13 @@
end
end
- context 'with version < 2.0' do
+ context "with version < 2.0" do
let(:token_attributes) { super().merge version: "1.0.3" }
- context 'with wrong domain', with_settings: { host_name: 'community.openproject.com' } do
- let(:token_attributes) { super().merge domain: 'localhost' }
+ context "with wrong domain", with_settings: { host_name: "community.openproject.com" } do
+ let(:token_attributes) { super().merge domain: "localhost" }
- it_behaves_like 'it renders the EE overview'
+ it_behaves_like "it renders the EE overview"
it "doesn't show any warnings or errors" do
expect(controller).not_to set_flash.now
@@ -111,56 +111,56 @@
end
end
- context 'when no token exists' do
+ context "when no token exists" do
before do
allow(EnterpriseToken).to receive(:current).and_return(nil)
get :show
end
- it 'still renders #show with form' do
- expect(response).not_to render_template partial: 'enterprises/_current'
- expect(response.body).to have_css '.upsale-benefits'
+ it "still renders #show with form" do
+ expect(response).not_to render_template partial: "enterprises/_current"
+ expect(response.body).to have_css ".upsale-benefits"
end
end
end
- describe '#create' do
+ describe "#create" do
let(:params) do
{
- enterprise_token: { encoded_token: 'foo' }
+ enterprise_token: { encoded_token: "foo" }
}
end
before do
allow(EnterpriseToken).to receive(:current).and_return(nil)
allow(EnterpriseToken).to receive(:new).and_return(a_token)
- expect(a_token).to receive(:encoded_token=).with('foo')
+ expect(a_token).to receive(:encoded_token=).with("foo")
expect(a_token).to receive(:save).and_return(valid)
post :create, params:
end
- context 'valid token input' do
+ context "valid token input" do
let(:valid) { true }
- it 'redirects to index' do
+ it "redirects to index" do
expect(controller).to set_flash[:notice].to I18n.t(:notice_successful_update)
expect(response).to redirect_to action: :show
end
end
- context 'invalid token input' do
+ context "invalid token input" do
let(:valid) { false }
- it 'renders with error' do
+ it "renders with error" do
expect(response).not_to be_redirect
- expect(response).to render_template 'enterprises/show'
+ expect(response).to render_template "enterprises/show"
end
end
end
- describe '#destroy' do
- context 'when a token exists' do
+ describe "#destroy" do
+ context "when a token exists" do
before do
expect(EnterpriseToken).to receive(:current).and_return(a_token)
expect(a_token).to receive(:destroy)
@@ -168,33 +168,33 @@
delete :destroy
end
- it 'redirects to show' do
+ it "redirects to show" do
expect(controller).to set_flash[:notice].to I18n.t(:notice_successful_delete)
expect(response).to redirect_to action: :show
end
end
- context 'when no token exists' do
+ context "when no token exists" do
before do
expect(EnterpriseToken).to receive(:current).and_return(nil)
delete :destroy
end
- it 'renders 404' do
+ it "renders 404" do
expect(response.status).to eq(404)
end
end
end
end
- context 'regular user' do
+ context "regular user" do
let(:user) { build(:user) }
before do
get :show
end
- it 'is forbidden' do
+ it "is forbidden" do
expect(response.status).to eq 403
end
end
diff --git a/spec/controllers/enumerations_controller_spec.rb b/spec/controllers/enumerations_controller_spec.rb
index 27a5b80b1e5d..4a9c187c22a7 100644
--- a/spec/controllers/enumerations_controller_spec.rb
+++ b/spec/controllers/enumerations_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe EnumerationsController do
shared_let(:admin) { create(:admin) }
@@ -35,23 +35,23 @@
admin
end
- describe '#index' do
+ describe "#index" do
before do
get :index
end
- it 'is successful' do
+ it "is successful" do
expect(response)
.to have_http_status(:ok)
end
- it 'renders the index template' do
+ it "renders the index template" do
expect(response)
- .to render_template 'index'
+ .to render_template "index"
end
end
- describe '#destroy' do
+ describe "#destroy" do
let(:enum) { create(:priority) }
let(:params) { { id: enum.id } }
let(:work_packages) { [] }
@@ -62,46 +62,46 @@
delete :destroy, params:
end
- it 'redirects' do
+ it "redirects" do
expect(response)
.to redirect_to enumerations_path
end
- it 'destroys the enum' do
+ it "destroys the enum" do
expect(Enumeration.where(id: enum.id))
.not_to exist
end
- context 'when in use' do
+ context "when in use" do
let(:work_packages) { [create(:work_package, priority: enum)] }
- it 'keeps the enum (as it needs to be reassigned)' do
+ it "keeps the enum (as it needs to be reassigned)" do
expect(Enumeration.where(id: enum.id))
.to exist
end
- it 'keeps the usage' do
+ it "keeps the usage" do
expect(work_packages.first.reload.priority)
.to eql enum
end
- it 'renders destroy template' do
+ it "renders destroy template" do
expect(response)
.to render_template :destroy
end
end
- context 'when in use and reassigning' do
+ context "when in use and reassigning" do
let(:work_packages) { [create(:work_package, priority: enum)] }
let!(:other_enum) { create(:priority) }
let(:params) { { id: enum.id, reassign_to_id: other_enum.id } }
- it 'destroys the enum' do
+ it "destroys the enum" do
expect(Enumeration.where(id: enum.id))
.not_to exist
end
- it 'reassigns the usage' do
+ it "reassigns the usage" do
expect(work_packages.first.reload.priority)
.to eql other_enum
end
diff --git a/spec/controllers/forums_controller_spec.rb b/spec/controllers/forums_controller_spec.rb
index ee6ffff79be9..b2df0e6b6847 100644
--- a/spec/controllers/forums_controller_spec.rb
+++ b/spec/controllers/forums_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe ForumsController do
shared_let(:user) { create(:user) }
@@ -37,25 +37,25 @@
disable_flash_sweep
end
- describe '#index' do
- context 'public project' do
+ describe "#index" do
+ context "public project" do
let(:project) { create(:public_project) }
let!(:role) { create(:non_member) }
- it 'renders the index template' do
+ it "renders the index template" do
as_logged_in_user(user) do
get :index, params: { project_id: project.id }
end
expect(response).to be_successful
- expect(response).to render_template 'forums/index'
+ expect(response).to render_template "forums/index"
expect(assigns(:forums)).to be_present
expect(assigns(:project)).to be_present
end
end
- context 'assuming authorized' do
- it 'renders the index template' do
+ context "assuming authorized" do
+ it "renders the index template" do
as_logged_in_user(user) do
allow(@controller).to receive(:authorize).and_return(true)
get :index, params: { project_id: project.id }
@@ -64,22 +64,22 @@
end
end
- context 'when login_required', with_settings: { login_required: true } do
- it 'redirects to login' do
- get :index, params: { project_id: 'not found' }
- expect(response).to redirect_to signin_path(back_url: project_forums_url('not found'))
+ context "when login_required", with_settings: { login_required: true } do
+ it "redirects to login" do
+ get :index, params: { project_id: "not found" }
+ expect(response).to redirect_to signin_path(back_url: project_forums_url("not found"))
end
end
- context 'when not login_required', with_settings: { login_required: false } do
- it 'renders 404 for not found' do
- get :index, params: { project_id: 'not found' }
+ context "when not login_required", with_settings: { login_required: false } do
+ it "renders 404 for not found" do
+ get :index, params: { project_id: "not found" }
expect(response.status).to eq 404
end
end
end
- describe '#show' do
+ describe "#show" do
before do
allow(project).to receive_message_chain(:forums, :find).and_return(forum)
allow(@controller).to receive(:authorize)
@@ -88,25 +88,25 @@
end
end
- context 'when login_required', with_settings: { login_required: true } do
- it 'redirects to login' do
+ context "when login_required", with_settings: { login_required: true } do
+ it "redirects to login" do
get :show, params: { project_id: project.id, id: 1 }
expect(response).to redirect_to signin_path(back_url: project_forum_url(project.id, 1))
end
end
- context 'when not login_required', with_settings: { login_required: false } do
- it 'renders the show template' do
+ context "when not login_required", with_settings: { login_required: false } do
+ it "renders the show template" do
get :show, params: { project_id: project.id, id: 1 }
expect(response).to be_successful
- expect(response).to render_template 'forums/show'
+ expect(response).to render_template "forums/show"
end
end
end
- describe '#create' do
+ describe "#create" do
let(:params) { { project_id: project.id, forum: forum_params } }
- let(:forum_params) { { name: 'my forum', description: 'awesome forum' } }
+ let(:forum_params) { { name: "my forum", description: "awesome forum" } }
before do
expect(@controller).to receive(:authorize)
@@ -121,7 +121,7 @@
.and_return(forum)
end
- describe 'w/ the params being valid' do
+ describe "w/ the params being valid" do
before do
expect(forum).to receive(:save).and_return(true)
@@ -130,19 +130,19 @@
end
end
- it 'redirects to the index page if successful' do
+ it "redirects to the index page if successful" do
expect(response)
- .to redirect_to controller: '/forums',
- action: 'index',
+ .to redirect_to controller: "/forums",
+ action: "index",
project_id: project.id
end
- it 'have a successful creation flash' do
+ it "have a successful creation flash" do
expect(flash[:notice]).to eq(I18n.t(:notice_successful_create))
end
end
- describe 'w/ the params being invalid' do
+ describe "w/ the params being invalid" do
before do
expect(forum).to receive(:save).and_return(false)
@@ -151,14 +151,14 @@
end
end
- it 'renders the new template' do
- expect(response).to render_template('new')
+ it "renders the new template" do
+ expect(response).to render_template("new")
end
end
end
- describe '#destroy', with_settings: { login_required: false } do
- let(:forum_params) { { name: 'my forum', description: 'awesome forum' } }
+ describe "#destroy", with_settings: { login_required: false } do
+ let(:forum_params) { { name: "my forum", description: "awesome forum" } }
before do
expect(@controller).to receive(:authorize)
@@ -168,14 +168,14 @@
end
end
- it 'requests destruction and redirect' do
+ it "requests destruction and redirect" do
expect(forum).to receive(:destroy)
delete :destroy, params: { project_id: project.id, id: 1 }
expect(response).to be_redirect
end
end
- describe '#move' do
+ describe "#move" do
let(:project) { create(:project) }
let!(:forum_1) do
create(:forum,
@@ -192,11 +192,11 @@
allow(@controller).to receive(:authorize).and_return(true)
end
- describe '#higher', with_settings: { login_required: false } do
- let(:move_to) { 'higher' }
+ describe "#higher", with_settings: { login_required: false } do
+ let(:move_to) { "higher" }
before do
- post 'move', params: { id: forum_2.id,
+ post "move", params: { id: forum_2.id,
project_id: forum_2.project_id,
forum: { move_to: } }
end
@@ -211,124 +211,124 @@
it do
expect(response)
- .to redirect_to controller: '/forums',
- action: 'index',
+ .to redirect_to controller: "/forums",
+ action: "index",
project_id: project.id
end
end
end
- describe '#update' do
+ describe "#update" do
let!(:forum) do
- create(:forum, name: 'Forum name',
- description: 'Forum description')
+ create(:forum, name: "Forum name",
+ description: "Forum description")
end
before do
expect(@controller).to receive(:authorize)
end
- describe 'w/ the params being valid' do
+ describe "w/ the params being valid" do
before do
as_logged_in_user user do
put :update, params: { id: forum.id,
project_id: forum.project_id,
- forum: { name: 'New name', description: 'New description' } }
+ forum: { name: "New name", description: "New description" } }
end
end
- it 'redirects to the index page if successful' do
- expect(response).to redirect_to controller: '/forums',
- action: 'index',
+ it "redirects to the index page if successful" do
+ expect(response).to redirect_to controller: "/forums",
+ action: "index",
project_id: forum.project_id
end
- it 'have a successful update flash' do
+ it "have a successful update flash" do
expect(flash[:notice]).to eq(I18n.t(:notice_successful_update))
end
- it 'changes the database entry' do
+ it "changes the database entry" do
forum.reload
- expect(forum.name).to eq('New name')
- expect(forum.description).to eq('New description')
+ expect(forum.name).to eq("New name")
+ expect(forum.description).to eq("New description")
end
end
- describe 'w/ the params being invalid' do
+ describe "w/ the params being invalid" do
before do
as_logged_in_user user do
post :update, params: { id: forum.id,
project_id: forum.project_id,
- forum: { name: '', description: 'New description' } }
+ forum: { name: "", description: "New description" } }
end
end
- it 'renders the edit template' do
- expect(response).to render_template('edit')
+ it "renders the edit template" do
+ expect(response).to render_template("edit")
end
- it 'does not change the database entry' do
+ it "does not change the database entry" do
forum.reload
- expect(forum.name).to eq('Forum name')
- expect(forum.description).to eq('Forum description')
+ expect(forum.name).to eq("Forum name")
+ expect(forum.description).to eq("Forum description")
end
end
end
- describe '#sticky', with_settings: { login_required: false } do
+ describe "#sticky", with_settings: { login_required: false } do
let!(:message1) { create(:message, forum:) }
let!(:message2) { create(:message, forum:) }
let!(:sticked_message1) do
create(:message, forum_id: forum.id,
- subject: 'How to',
- content: 'How to install this cool app',
- sticky: '1',
+ subject: "How to",
+ content: "How to install this cool app",
+ sticky: "1",
sticked_on: Time.now - 2.minutes)
end
let!(:sticked_message2) do
create(:message, forum_id: forum.id,
- subject: 'FAQ',
- content: 'Frequestly asked question',
- sticky: '1',
+ subject: "FAQ",
+ content: "Frequestly asked question",
+ sticky: "1",
sticked_on:
Time.now - 1.minute)
end
- describe 'all sticky messages' do
+ describe "all sticky messages" do
before do
expect(@controller).to receive(:authorize)
get :show, params: { project_id: project.id, id: forum.id }
end
- it 'renders show' do
- expect(response).to render_template 'show'
+ it "renders show" do
+ expect(response).to render_template "show"
end
- it 'is displayed on top' do
+ it "is displayed on top" do
expect(assigns[:topics][0].id).to eq(sticked_message1.id)
end
end
- describe 'edit a sticky message' do
+ describe "edit a sticky message" do
before do
sticked_message1.sticky = 0
sticked_message1.save!
end
- describe 'when sticky is unset from message' do
+ describe "when sticky is unset from message" do
before do
expect(@controller).to receive(:authorize)
get :show, params: { project_id: project.id, id: forum.id }
end
- it 'is not displayed as sticky message' do
+ it "is not displayed as sticky message" do
expect(sticked_message1.sticked_on).to be_nil
expect(assigns[:topics][0].id).not_to eq(sticked_message1.id)
end
end
- describe 'when sticky is set back to message' do
+ describe "when sticky is set back to message" do
before do
sticked_message1.sticky = 1
sticked_message1.save!
@@ -337,7 +337,7 @@
get :show, params: { project_id: project.id, id: forum.id }
end
- it 'is not displayed on first position' do
+ it "is not displayed on first position" do
expect(assigns[:topics][0].id).to eq(sticked_message2.id)
end
end
diff --git a/spec/controllers/groups_controller_spec.rb b/spec/controllers/groups_controller_spec.rb
index 711800383679..12857c576280 100644
--- a/spec/controllers/groups_controller_spec.rb
+++ b/spec/controllers/groups_controller_spec.rb
@@ -25,7 +25,7 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe GroupsController do
let(:group) { create(:group, members: group_members) }
@@ -35,51 +35,51 @@
login_as current_user
end
- context 'as admin' do
+ context "as admin" do
shared_let(:admin) { create(:admin) }
let(:current_user) { admin }
- it 'indexes' do
+ it "indexes" do
get :index
expect(response).to be_successful
- expect(response).to render_template 'index'
+ expect(response).to render_template "index"
end
- it 'shows' do
+ it "shows" do
get :show, params: { id: group.id }
expect(response).to be_successful
- expect(response).to render_template 'show'
+ expect(response).to render_template "show"
end
- it 'shows new' do
+ it "shows new" do
get :new
expect(response).to be_successful
- expect(response).to render_template 'new'
+ expect(response).to render_template "new"
end
- it 'creates' do
+ it "creates" do
expect do
- post :create, params: { group: { lastname: 'New group' } }
+ post :create, params: { group: { lastname: "New group" } }
end.to change(Group, :count).by(1)
expect(response).to redirect_to groups_path
end
- it 'edits' do
+ it "edits" do
get :edit, params: { id: group.id }
expect(response).to be_successful
- expect(response).to render_template 'edit'
+ expect(response).to render_template "edit"
end
- it 'updates' do
+ it "updates" do
expect do
- put :update, params: { id: group.id, group: { lastname: 'new name' } }
- end.to change { group.reload.name }.to('new name')
+ put :update, params: { id: group.id, group: { lastname: "new name" } }
+ end.to change { group.reload.name }.to("new name")
expect(response).to redirect_to groups_path
end
- it 'destroys' do
+ it "destroys" do
perform_enqueued_jobs do
delete :destroy, params: { id: group.id }
end
@@ -89,28 +89,28 @@
expect(response).to redirect_to groups_path
end
- context 'with two existing users' do
+ context "with two existing users" do
let(:user1) { create(:user) }
let(:user2) { create(:user) }
- it 'adds users' do
+ it "adds users" do
post :add_users, params: { id: group.id, user_ids: [user1.id, user2.id] }
expect(group.reload.users.count).to eq 2
end
end
- context 'with a group member' do
+ context "with a group member" do
let(:user1) { create(:user) }
let(:user2) { create(:user) }
let(:group_members) { [user1] }
- it 'adds users' do
+ it "adds users" do
post :add_users, params: { id: group.id, user_ids: [user2.id] }
expect(group.reload.users.count).to eq 2
end
end
- context 'with a global role membership' do
+ context "with a global role membership" do
render_views
let!(:member_group) do
@@ -119,20 +119,20 @@
roles: [create(:global_role)])
end
- it 'displays edit memberships' do
- get :edit, params: { id: group.id, tab: 'memberships' }
+ it "displays edit memberships" do
+ get :edit, params: { id: group.id, tab: "memberships" }
expect(response).to be_successful
- expect(response).to render_template 'edit'
+ expect(response).to render_template "edit"
end
end
- context 'with project and role' do
+ context "with project and role" do
let(:project) { create(:project) }
let(:role1) { create(:project_role) }
let(:role2) { create(:project_role) }
- it 'creates membership' do
+ it "creates membership" do
post :create_memberships,
params: { id: group.id, membership: { project_id: project.id, role_ids: [role1.id, role2.id] } }
@@ -140,7 +140,7 @@
expect(group.members.first.roles.count).to eq 2
end
- context 'with an existing membership' do
+ context "with an existing membership" do
let!(:member_group) do
create(:member,
project:,
@@ -148,7 +148,7 @@
roles: [role1])
end
- it 'edits a membership' do
+ it "edits a membership" do
expect(group.members.count).to eq 1
expect(group.members.first.roles.count).to eq 1
@@ -164,7 +164,7 @@
expect(group.members.first.roles.count).to eq 2
end
- it 'can destroy the membership' do
+ it "can destroy the membership" do
delete :destroy_membership, params: { id: group.id, membership_id: group.members.first.id }
expect(group.reload.members.count).to eq 0
end
@@ -172,38 +172,38 @@
end
end
- context 'as regular user' do
+ context "as regular user" do
let(:user) { create(:user) }
let(:current_user) { user }
- it 'forbids index' do
+ it "forbids index" do
get :index
expect(response).not_to be_successful
expect(response.status).to eq 403
end
- it 'shows' do
+ it "shows" do
get :show, params: { id: group.id }
expect(response).to be_successful
- expect(response).to render_template 'show'
+ expect(response).to render_template "show"
end
- it 'forbids new' do
+ it "forbids new" do
get :new
expect(response).not_to be_successful
expect(response.status).to eq 403
end
- it 'forbids create' do
+ it "forbids create" do
expect do
- post :create, params: { group: { lastname: 'New group' } }
+ post :create, params: { group: { lastname: "New group" } }
end.not_to(change(Group, :count))
expect(response).not_to be_successful
expect(response.status).to eq 403
end
- it 'forbids edit' do
+ it "forbids edit" do
get :edit, params: { id: group.id }
expect(response).not_to be_successful
diff --git a/spec/controllers/homescreen_controller_spec.rb b/spec/controllers/homescreen_controller_spec.rb
index 10486c02a9f3..2d1b8eabfad0 100644
--- a/spec/controllers/homescreen_controller_spec.rb
+++ b/spec/controllers/homescreen_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe HomescreenController do
before do
@@ -44,91 +44,91 @@
let(:show_welcome) { false }
- shared_examples 'renders blocks' do
- it 'renders a response' do
+ shared_examples "renders blocks" do
+ it "renders a response" do
expect(response.status).to eq(200)
end
- describe 'with rendered views' do
+ describe "with rendered views" do
render_views
- it 'renders the given blocks' do
+ it "renders the given blocks" do
shown.each do |block|
expect(response).to render_template(partial: "homescreen/blocks/_#{block}")
end
end
- it 'does not render the other blocks' do
+ it "does not render the other blocks" do
(all_blocks - shown).each do |block|
expect(response).not_to render_template(partial: "homescreen/blocks/_#{block}")
end
end
- it 'does not render news when empty' do
- expect(response).not_to render_template(partial: 'homescreen/blocks/_news')
+ it "does not render news when empty" do
+ expect(response).not_to render_template(partial: "homescreen/blocks/_news")
end
- it 'shows the news when available' do
+ it "shows the news when available" do
expect(News).to receive(:latest).with(any_args)
.and_return(build_stubbed_list(:news, 5, created_at: Time.now))
get :index
- expect(response).to render_template(partial: 'homescreen/blocks/_news')
+ expect(response).to render_template(partial: "homescreen/blocks/_news")
end
- it 'does not render the welcome block' do
- expect(response).not_to render_template(partial: 'homescreen/blocks/_welcome')
+ it "does not render the welcome block" do
+ expect(response).not_to render_template(partial: "homescreen/blocks/_welcome")
end
- context 'with enabled announcement' do
+ context "with enabled announcement" do
let!(:announcement) { create(:active_announcement) }
- it 'renders the announcement' do
- expect(response).to render_template(partial: 'announcements/_show')
+ it "renders the announcement" do
+ expect(response).to render_template(partial: "announcements/_show")
end
end
- context 'with enabled welcome block' do
+ context "with enabled welcome block" do
before do
- allow(Setting).to receive(:welcome_text).and_return('h1. foobar')
- allow(Setting).to receive(:welcome_title).and_return('Woohoo!')
+ allow(Setting).to receive(:welcome_text).and_return("h1. foobar")
+ allow(Setting).to receive(:welcome_title).and_return("Woohoo!")
get :index
end
let(:show_welcome) { true }
- it 'renders the block' do
- expect(response).to render_template(partial: 'homescreen/blocks/_welcome')
+ it "renders the block" do
+ expect(response).to render_template(partial: "homescreen/blocks/_welcome")
end
- it 'renders the text' do
+ it "renders the text" do
expect(response.body).to have_css('[data-test-selector="op-widget-box--header"]',
- text: 'Woohoo!')
+ text: "Woohoo!")
end
end
end
end
- context 'with admin' do
+ context "with admin" do
let(:user) { build(:admin) }
- it_behaves_like 'renders blocks' do
+ it_behaves_like "renders blocks" do
let(:shown) { all_blocks }
end
end
- context 'regular user' do
+ context "regular user" do
let(:user) { build(:user) }
- it_behaves_like 'renders blocks' do
+ it_behaves_like "renders blocks" do
let(:shown) { all_blocks - %w(administration users) }
end
end
- context 'anonymous user' do
+ context "anonymous user" do
let(:user) { User.anonymous }
- it_behaves_like 'renders blocks' do
+ it_behaves_like "renders blocks" do
let(:shown) { all_blocks - %w(administration users my_account) }
end
end
diff --git a/spec/controllers/journals_controller_spec.rb b/spec/controllers/journals_controller_spec.rb
index a2c86a3968fd..1c9ebf665f94 100644
--- a/spec/controllers/journals_controller_spec.rb
+++ b/spec/controllers/journals_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe JournalsController do
shared_let(:project) { create(:project_with_types) }
@@ -39,26 +39,26 @@
params:
end
- describe 'GET diff' do
+ describe "GET diff" do
render_views
- context 'for work package description' do
+ context "for work package description" do
shared_let(:work_package) do
create(:work_package, type: project.types.first,
author: user,
project:,
- description: '')
+ description: "")
end
- let(:params) { { id: work_package.last_journal.id.to_s, field: :description, format: 'js' } }
+ let(:params) { { id: work_package.last_journal.id.to_s, field: :description, format: "js" } }
before do
- work_package.update_attribute :description, 'description'
+ work_package.update_attribute :description, "description"
end
- describe 'with a user having :view_work_package permission' do
+ describe "with a user having :view_work_package permission" do
it { expect(response).to have_http_status(:ok) }
- it 'presents the diff correctly' do
+ it "presents the diff correctly" do
expect(response.body.strip).to eq(
"
" \
"\n " \
@@ -70,7 +70,7 @@
end
end
- describe 'with a user not having the :view_work_package permission' do
+ describe "with a user not having the :view_work_package permission" do
before do
RolePermission.delete_all
end
@@ -79,17 +79,17 @@
end
end
- context 'for project description' do
- let(:params) { { id: project.last_journal.id.to_s, field: :description, format: 'js' } }
+ context "for project description" do
+ let(:params) { { id: project.last_journal.id.to_s, field: :description, format: "js" } }
before do
- project.update_attribute :description, 'description'
+ project.update_attribute :description, "description"
end
- describe 'with a user being member of the project' do
+ describe "with a user being member of the project" do
it { expect(response).to have_http_status(:ok) }
- it 'presents the diff correctly' do
+ it "presents the diff correctly" do
expect(response.body.strip).to eq(
"
" \
"\n " \
@@ -101,7 +101,7 @@
end
end
- describe 'with a user not being member of the project' do
+ describe "with a user not being member of the project" do
before do
Member.delete_all
end
@@ -111,13 +111,13 @@
describe 'when "Work Package Tracking" module is disabled' do
before do
- project.enabled_module_names -= ['work_package_tracking']
+ project.enabled_module_names -= ["work_package_tracking"]
end
it { expect(response).to have_http_status(:ok) }
end
- describe 'when project is archived' do
+ describe "when project is archived" do
before do
project.update(active: false)
end
@@ -126,28 +126,28 @@
end
end
- context 'for another field than description' do
+ context "for another field than description" do
shared_let(:work_package) do
create(:work_package, type: project.types.first,
author: user,
project:)
end
- let(:params) { { id: work_package.last_journal.id.to_s, field: :another_field, format: 'js' } }
+ let(:params) { { id: work_package.last_journal.id.to_s, field: :another_field, format: "js" } }
it { expect(response).to have_http_status(:not_found) }
end
- context 'for other types, like forum message' do
+ context "for other types, like forum message" do
shared_let(:forum) { create(:forum, project:) }
- shared_let(:message) { create(:message, forum:, content: 'initial content') }
+ shared_let(:message) { create(:message, forum:, content: "initial content") }
- let(:params) { { id: message.last_journal.id.to_s, field: :description, format: 'js' } }
+ let(:params) { { id: message.last_journal.id.to_s, field: :description, format: "js" } }
before do
- message.update_attribute :content, 'initial content updated'
+ message.update_attribute :content, "initial content updated"
end
- describe 'even with a user having all permissions' do
+ describe "even with a user having all permissions" do
before do
user.update(admin: true)
end
diff --git a/spec/controllers/ldap_auth_sources_controller_spec.rb b/spec/controllers/ldap_auth_sources_controller_spec.rb
index 2bf8f9262985..51def5ec42d5 100644
--- a/spec/controllers/ldap_auth_sources_controller_spec.rb
+++ b/spec/controllers/ldap_auth_sources_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe LdapAuthSourcesController do
let(:current_user) { create(:admin) }
@@ -36,7 +36,7 @@
allow(User).to receive(:current).and_return current_user
end
- describe 'new' do
+ describe "new" do
before do
get :new
end
@@ -45,13 +45,13 @@
it { is_expected.to respond_with :success }
it { is_expected.to render_template :new }
- it 'initializes a new LdapAuthSource' do
+ it "initializes a new LdapAuthSource" do
expect(assigns(:ldap_auth_source).class).to eq LdapAuthSource
expect(assigns(:ldap_auth_source)).to be_new_record
end
end
- describe 'index' do
+ describe "index" do
before do
get :index
end
@@ -60,9 +60,9 @@
it { is_expected.to render_template :index }
end
- describe 'create' do
+ describe "create" do
before do
- post :create, params: { ldap_auth_source: { name: 'Test', host: 'example.com', attr_login: 'foo' } }
+ post :create, params: { ldap_auth_source: { name: "Test", host: "example.com", attr_login: "foo" } }
end
it { is_expected.to respond_with :redirect }
@@ -70,8 +70,8 @@
it { is_expected.to set_flash.to /success/i }
end
- describe 'edit' do
- let(:ldap) { create(:ldap_auth_source, name: 'TestEdit') }
+ describe "edit" do
+ let(:ldap) { create(:ldap_auth_source, name: "TestEdit") }
before do
get :edit, params: { id: ldap.id }
@@ -82,11 +82,11 @@
it { is_expected.to render_template :edit }
end
- describe 'update' do
- let(:ldap) { create(:ldap_auth_source, name: 'TestEdit') }
+ describe "update" do
+ let(:ldap) { create(:ldap_auth_source, name: "TestEdit") }
before do
- post :update, params: { id: ldap.id, ldap_auth_source: { name: 'TestUpdate' } }
+ post :update, params: { id: ldap.id, ldap_auth_source: { name: "TestUpdate" } }
end
it { is_expected.to respond_with :redirect }
@@ -94,10 +94,10 @@
it { is_expected.to set_flash.to /update/i }
end
- describe 'destroy' do
- let(:ldap) { create(:ldap_auth_source, name: 'TestEdit') }
+ describe "destroy" do
+ let(:ldap) { create(:ldap_auth_source, name: "TestEdit") }
- context 'without users' do
+ context "without users" do
before do
post :destroy, params: { id: ldap.id }
end
@@ -107,8 +107,8 @@
it { is_expected.to set_flash.to /deletion/i }
end
- context 'with users' do
- let!(:ldap) { create(:ldap_auth_source, name: 'TestEdit') }
+ context "with users" do
+ let!(:ldap) { create(:ldap_auth_source, name: "TestEdit") }
let!(:user) { create(:user, ldap_auth_source: ldap) }
before do
@@ -117,48 +117,48 @@
it { is_expected.to respond_with :redirect }
- it 'does not destroy the LdapAuthSource' do
+ it "does not destroy the LdapAuthSource" do
expect(LdapAuthSource.find(ldap.id)).not_to be_nil
end
end
end
- context 'with password login disabled' do
+ context "with password login disabled" do
before do
allow(OpenProject::Configuration).to receive(:disable_password_login?).and_return(true)
end
- it 'cannot find index' do
+ it "cannot find index" do
get :index
expect(response).to have_http_status :not_found
end
- it 'cannot find new' do
+ it "cannot find new" do
get :new
expect(response).to have_http_status :not_found
end
- it 'cannot find create' do
- post :create, params: { ldap_auth_source: { name: 'Test' } }
+ it "cannot find create" do
+ post :create, params: { ldap_auth_source: { name: "Test" } }
expect(response).to have_http_status :not_found
end
- it 'cannot find edit' do
+ it "cannot find edit" do
get :edit, params: { id: 42 }
expect(response).to have_http_status :not_found
end
- it 'cannot find update' do
- post :update, params: { id: 42, ldap_auth_source: { name: 'TestUpdate' } }
+ it "cannot find update" do
+ post :update, params: { id: 42, ldap_auth_source: { name: "TestUpdate" } }
expect(response).to have_http_status :not_found
end
- it 'cannot find destroy' do
+ it "cannot find destroy" do
post :destroy, params: { id: 42 }
expect(response).to have_http_status :not_found
diff --git a/spec/controllers/messages_controller_spec.rb b/spec/controllers/messages_controller_spec.rb
index ed13eef02ec3..7c86587787a6 100644
--- a/spec/controllers/messages_controller_spec.rb
+++ b/spec/controllers/messages_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe MessagesController, with_settings: { journal_aggregation_time_minutes: 0 } do
let(:user) { create(:user) }
@@ -43,30 +43,30 @@
project:)
end
- let(:filename) { 'testfile.txt' }
- let(:file) { File.open(Rails.root.join('spec/fixtures/files', filename)) }
+ let(:filename) { "testfile.txt" }
+ let(:file) { File.open(Rails.root.join("spec/fixtures/files", filename)) }
before { allow(User).to receive(:current).and_return user }
- describe '#show' do
- context 'with a public project' do
+ describe "#show" do
+ context "with a public project" do
let(:user) { User.anonymous }
let(:project) { create(:public_project) }
let!(:message) { create(:message, forum:) }
- context 'when login_required', with_settings: { login_required: true } do
- it 'redirects to login' do
+ context "when login_required", with_settings: { login_required: true } do
+ it "redirects to login" do
get :show, params: { project_id: project.id, id: message.id }
expect(response).to redirect_to signin_path(back_url: topic_url(message.id))
end
end
- context 'when not login_required', with_settings: { login_required: false } do
- it 'renders the show template' do
+ context "when not login_required", with_settings: { login_required: false } do
+ it "renders the show template" do
get :show, params: { project_id: project.id, id: message.id }
expect(response).to be_successful
- expect(response).to render_template 'messages/show'
+ expect(response).to render_template "messages/show"
expect(assigns(:topic)).to be_present
expect(assigns(:forum)).to be_present
expect(assigns(:project)).to be_present
@@ -75,7 +75,7 @@
end
end
- describe '#update' do
+ describe "#update" do
let(:message) { create(:message, forum:) }
let(:other_forum) { create(:forum, project:) }
@@ -85,39 +85,39 @@
message: { forum_id: other_forum } }
end
- it 'allows for changing the board' do
+ it "allows for changing the board" do
expect(message.reload.forum).to eq(other_forum)
end
- context 'attachment upload' do
+ context "attachment upload" do
let!(:message) { create(:message) }
let(:attachment_id) { "attachments_#{message.attachments.first.id}" }
# Attachment is already uploaded
let(:attachment) { create(:attachment, container: nil, author: user) }
let(:params) do
{ id: message.id,
- attachments: { '0' => { 'id' => attachment.id } } }
+ attachments: { "0" => { "id" => attachment.id } } }
end
- describe 'add' do
+ describe "add" do
before do
allow_any_instance_of(Message).to receive(:editable_by?).and_return(true)
end
- context 'journal' do
+ context "journal" do
before do
put(:update, params:)
message.reload
end
- describe '#key' do
+ describe "#key" do
subject { message.journals.last.details }
it { is_expected.to have_key attachment_id }
end
- describe '#value' do
+ describe "#value" do
subject { message.journals.last.details[attachment_id].last }
it { is_expected.to eq(attachment.filename) }
@@ -126,7 +126,7 @@
end
end
- describe '#remove' do
+ describe "#remove" do
let!(:attachment) do
create(:attachment,
container: message,
@@ -146,16 +146,16 @@
message.reload
end
- context 'journal' do
+ context "journal" do
let(:attachment_id) { "attachments_#{attachment.id}" }
- describe '#key' do
+ describe "#key" do
subject { message.journals.last.details }
it { is_expected.to have_key attachment_id }
end
- describe '#value' do
+ describe "#value" do
subject { message.journals.last.details[attachment_id].first }
it { is_expected.to eq(filename) }
@@ -164,26 +164,26 @@
end
end
- describe 'quote' do
- let(:message) { create(:message, content: 'foo', subject: 'subject', forum:) }
+ describe "quote" do
+ let(:message) { create(:message, content: "foo", subject: "subject", forum:) }
- context 'when allowed' do
+ context "when allowed" do
let(:user) { create(:admin) }
before do
login_as user
end
- it 'renders the content as json' do
+ it "renders the content as json" do
get :quote, params: { forum_id: forum.id, id: message.id }, format: :json
expect(response).to be_successful
expect(response.body).to eq '{"subject":"RE: subject","content":" wrote:\n\u003e foo\n\n"}'
end
- it 'escapes HTML in quoted message author' do
- user.firstname = 'Hello'
- user.lastname = 'world'
+ it "escapes HTML in quoted message author" do
+ user.firstname = "Hello"
+ user.lastname = "world"
user.save! validate: false
message.update!(author: user)
diff --git a/spec/controllers/my_controller_spec.rb b/spec/controllers/my_controller_spec.rb
index 004a5a49a352..c5cfc3781c42 100644
--- a/spec/controllers/my_controller_spec.rb
+++ b/spec/controllers/my_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe MyController do
let(:user) { create(:user) }
@@ -35,92 +35,92 @@
login_as(user)
end
- describe 'password change' do
- describe '#password' do
+ describe "password change" do
+ describe "#password" do
before do
get :password
end
- it 'renders the password template' do
- assert_template 'password'
+ it "renders the password template" do
+ assert_template "password"
assert_response :success
end
end
- describe 'with disabled password login' do
+ describe "with disabled password login" do
before do
allow(OpenProject::Configuration).to receive(:disable_password_login?).and_return(true)
post :change_password
end
- it 'is not found' do
+ it "is not found" do
expect(response.status).to eq 404
end
end
- describe 'with wrong confirmation' do
+ describe "with wrong confirmation" do
before do
post :change_password,
params: {
- password: 'adminADMIN!',
- new_password: 'adminADMIN!New',
- new_password_confirmation: 'adminADMIN!Other'
+ password: "adminADMIN!",
+ new_password: "adminADMIN!New",
+ new_password_confirmation: "adminADMIN!Other"
}
end
- it 'shows an error message' do
+ it "shows an error message" do
assert_response :success
- assert_template 'password'
+ assert_template "password"
expect(user.errors.attribute_names).to eq([:password_confirmation])
expect(user.errors.map(&:message).flatten)
.to contain_exactly("Password confirmation does not match password.")
end
end
- describe 'with wrong password' do
+ describe "with wrong password" do
render_views
before do
@current_password = user.current_password.id
post :change_password,
params: {
- password: 'wrongpassword',
- new_password: 'adminADMIN!New',
- new_password_confirmation: 'adminADMIN!New'
+ password: "wrongpassword",
+ new_password: "adminADMIN!New",
+ new_password_confirmation: "adminADMIN!New"
}
end
- it 'shows an error message' do
+ it "shows an error message" do
assert_response :success
- assert_template 'password'
- expect(flash[:error]).to eq('Wrong password')
+ assert_template "password"
+ expect(flash[:error]).to eq("Wrong password")
end
- it 'does not change the password' do
+ it "does not change the password" do
expect(user.current_password.id).to eq(@current_password)
end
end
- describe 'with good password and good confirmation' do
+ describe "with good password and good confirmation" do
before do
post :change_password,
params: {
- password: 'adminADMIN!',
- new_password: 'adminADMIN!New',
- new_password_confirmation: 'adminADMIN!New'
+ password: "adminADMIN!",
+ new_password: "adminADMIN!New",
+ new_password_confirmation: "adminADMIN!New"
}
end
- it 'redirects to the my password page' do
- expect(response).to redirect_to('/my/password')
+ it "redirects to the my password page" do
+ expect(response).to redirect_to("/my/password")
end
- it 'allows the user to login with the new password' do
- assert User.try_to_login(user.login, 'adminADMIN!New')
+ it "allows the user to login with the new password" do
+ assert User.try_to_login(user.login, "adminADMIN!New")
end
end
end
- describe 'account' do
+ describe "account" do
let(:custom_field) { create(:user_custom_field, :text) }
before do
@@ -130,69 +130,69 @@
end
end
- it 'responds with success' do
+ it "responds with success" do
expect(response).to be_successful
end
- it 'renders the account template' do
- expect(response).to render_template 'account'
+ it "renders the account template" do
+ expect(response).to render_template "account"
end
- it 'assigns @user' do
+ it "assigns @user" do
expect(assigns(:user)).to eq(user)
end
- context 'with render_views' do
+ context "with render_views" do
render_views
- it 'renders editable custom fields' do
+ it "renders editable custom fields" do
expect(response.body).to have_content(custom_field.name)
end
it "renders the 'Change password' menu entry" do
- expect(response.body).to have_css('#menu-sidebar li a', text: 'Change password')
+ expect(response.body).to have_css("#menu-sidebar li a", text: "Change password")
end
end
end
- describe 'settings' do
- describe 'PATCH' do
- let(:language) { 'en' }
+ describe "settings" do
+ describe "PATCH" do
+ let(:language) { "en" }
before do
as_logged_in_user user do
- user.pref.comments_sorting = 'desc'
+ user.pref.comments_sorting = "desc"
user.pref.auto_hide_popups = true
patch :update_settings, params: { user: { language: }, pref: { auto_hide_popups: 0 } }
end
end
- it 'updates the settings appropriately', :aggregate_failures do
+ it "updates the settings appropriately", :aggregate_failures do
expect(assigns(:user).language).to eq language
- expect(assigns(:user).pref.comments_sorting).to eql 'desc'
+ expect(assigns(:user).pref.comments_sorting).to eql "desc"
expect(assigns(:user).pref.auto_hide_popups?).to be_falsey
expect(request.path).to eq(my_settings_path)
expect(flash[:notice]).to eql I18n.t(:notice_account_updated)
end
- context 'when user is invalid' do
+ context "when user is invalid" do
let(:user) do
create(:user).tap do |u|
- u.update_column(:mail, 'something invalid')
+ u.update_column(:mail, "something invalid")
end
end
- it 'shows a flash error' do
- expect(flash[:error]).to include 'Email is not a valid email address.'
+ it "shows a flash error" do
+ expect(flash[:error]).to include "Email is not a valid email address."
expect(request.path).to eq(my_settings_path)
end
end
- context 'when changing language' do
- let(:language) { 'de' }
+ context "when changing language" do
+ let(:language) { "de" }
- it 'shows a flash message translated in the selected language' do
+ it "shows a flash message translated in the selected language" do
expect(assigns(:user).language).to eq(language)
expect(flash[:notice]).to eq(I18n.t(:notice_account_updated, locale: language))
end
@@ -200,8 +200,8 @@
end
end
- describe 'settings:auto_hide_popups' do
- context 'with render_views' do
+ describe "settings:auto_hide_popups" do
+ context "with render_views" do
before do
as_logged_in_user user do
get :settings
@@ -209,23 +209,23 @@
end
render_views
- it 'renders auto hide popups checkbox' do
- expect(response.body).to have_css('#my_account_form #pref_auto_hide_popups')
+ it "renders auto hide popups checkbox" do
+ expect(response.body).to have_css("#my_account_form #pref_auto_hide_popups")
end
end
- context 'PATCH' do
+ context "PATCH" do
before do
as_logged_in_user user do
user.pref.auto_hide_popups = false
- patch :update_settings, params: { user: { language: 'en' } }
+ patch :update_settings, params: { user: { language: "en" } }
end
end
end
end
- describe 'account with disabled password login' do
+ describe "account with disabled password login" do
before do
allow(OpenProject::Configuration).to receive(:disable_password_login?).and_return(true)
as_logged_in_user user do
@@ -236,13 +236,13 @@
render_views
it "does not render 'Change password' menu entry" do
- expect(response.body).to have_no_css('#menu-sidebar li a', text: 'Change password')
+ expect(response.body).to have_no_css("#menu-sidebar li a", text: "Change password")
end
end
- describe 'access_tokens' do
- describe 'rss' do
- it 'creates a key' do
+ describe "access_tokens" do
+ describe "rss" do
+ it "creates a key" do
expect(user.rss_token).to be_nil
post :generate_rss_key
@@ -253,10 +253,10 @@
expect(response).to redirect_to action: :access_token
end
- context 'with existing key' do
+ context "with existing key" do
let!(:key) { Token::RSS.create user: }
- it 'replaces the key' do
+ it "replaces the key" do
expect(user.rss_token).to eq(key)
post :generate_rss_key
@@ -272,9 +272,9 @@
end
end
- describe 'api' do
- context 'with no existing key' do
- it 'creates a key' do
+ describe "api" do
+ context "with no existing key" do
+ it "creates a key" do
expect(user.api_token).to be_nil
post :generate_api_key
@@ -288,10 +288,10 @@
end
end
- context 'with existing key' do
+ context "with existing key" do
let!(:key) { Token::API.create user: }
- it 'replaces the key' do
+ it "replaces the key" do
expect(user.reload.api_token).to eq(key)
post :generate_api_key
@@ -307,14 +307,14 @@
end
end
- describe 'ical' do
+ describe "ical" do
# unlike with the other tokens, creating new ical tokens is not done in this context
# ical tokens are generated whenever the user requests a new ical url
# a user can have N ical tokens
#
# in this context a specific ical token of a user should be reverted
# this invalidates the previously generated ical url
- context 'with existing keys' do
+ context "with existing keys" do
let(:user) { create(:user) }
let(:project) { create(:project) }
let(:query) { create(:query, project:) }
@@ -323,7 +323,7 @@
let!(:another_ical_token_for_query) { create(:ical_token, user:, query:, name: "Some Other Token Name") }
let!(:ical_token_for_another_query) { create(:ical_token, user:, query: another_query, name: "Some Token Name") }
- it 'revoke specific ical tokens' do
+ it "revoke specific ical tokens" do
expect(user.ical_tokens).to contain_exactly(
ical_token_for_query, another_ical_token_for_query, ical_token_for_another_query
)
@@ -346,7 +346,7 @@
end
end
- describe 'file storage' do
+ describe "file storage" do
let(:client) { create(:oauth_client, integration: create(:nextcloud_storage)) }
let(:token) { create(:oauth_client_token, oauth_client: client, scope: nil, user:, expires_in: 3_600) }
@@ -354,12 +354,12 @@
before { token }
- it 'list the tokens' do
+ it "list the tokens" do
get :access_token
expect(response.body).to have_css("#storage-oauth-token-#{token.id}")
end
- it 'can remove the token' do
+ it "can remove the token" do
expect do
delete :delete_storage_token, params: { id: token.id }
end.to change(OAuthClientToken, :count).by(-1)
diff --git a/spec/controllers/news/comments_controller_spec.rb b/spec/controllers/news/comments_controller_spec.rb
index d3ac2672d6b2..06dcfafc53bc 100644
--- a/spec/controllers/news/comments_controller_spec.rb
+++ b/spec/controllers/news/comments_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe News::CommentsController do
render_views
@@ -38,28 +38,28 @@
allow(User).to receive(:current).and_return user
end
- describe '#create' do
- it 'assigns a comment to the news item and redirects to the news page' do
- post :create, params: { news_id: news.id, comment: { comments: 'This is a test comment' } }
+ describe "#create" do
+ it "assigns a comment to the news item and redirects to the news page" do
+ post :create, params: { news_id: news.id, comment: { comments: "This is a test comment" } }
expect(response).to redirect_to news_path(news)
latest_comment = news.comments.reorder(created_at: :desc).first
expect(latest_comment).not_to be_nil
- expect(latest_comment.comments).to eq 'This is a test comment'
+ expect(latest_comment.comments).to eq "This is a test comment"
expect(latest_comment.author).to eq user
end
it "doesn't create a comment when it is invalid" do
expect do
- post :create, params: { news_id: news.id, comment: { comments: '' } }
+ post :create, params: { news_id: news.id, comment: { comments: "" } }
expect(response).to redirect_to news_path(news)
end.not_to change { Comment.count }
end
end
- describe '#destroy' do
- it 'deletes the comment and redirects to the news page' do
+ describe "#destroy" do
+ it "deletes the comment and redirects to the news page" do
comment = create(:comment, commented: news)
expect do
diff --git a/spec/controllers/news_controller_spec.rb b/spec/controllers/news_controller_spec.rb
index f0ea7a49c2f9..daebacc36056 100644
--- a/spec/controllers/news_controller_spec.rb
+++ b/spec/controllers/news_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe NewsController do
render_views
@@ -43,80 +43,80 @@
allow(User).to receive(:current).and_return user
end
- describe '#index' do
- it 'renders index' do
+ describe "#index" do
+ it "renders index" do
get :index
expect(response).to be_successful
- expect(response).to render_template 'index'
+ expect(response).to render_template "index"
expect(assigns(:project)).to be_nil
expect(assigns(:newss)).not_to be_nil
end
- it 'renders index with project' do
+ it "renders index with project" do
get :index, params: { project_id: project.id }
expect(response).to be_successful
- expect(response).to render_template 'index'
+ expect(response).to render_template "index"
expect(assigns(:newss)).not_to be_nil
end
end
- describe '#show' do
- it 'renders show' do
+ describe "#show" do
+ it "renders show" do
get :show, params: { id: news.id }
expect(response).to be_successful
- expect(response).to render_template 'show'
+ expect(response).to render_template "show"
- expect(response.body).to have_css('h2', text: news.title)
+ expect(response.body).to have_css("h2", text: news.title)
end
- it 'renders show with slug' do
+ it "renders show with slug" do
get :show, params: { id: "#{news.id}-some-news-title" }
expect(response).to be_successful
- expect(response).to render_template 'show'
+ expect(response).to render_template "show"
- expect(response.body).to have_css('h2', text: news.title)
+ expect(response.body).to have_css("h2", text: news.title)
end
- it 'renders error if news item is not found' do
+ it "renders error if news item is not found" do
get :show, params: { id: -1 }
expect(response).to be_not_found
end
end
- describe '#new' do
- it 'renders new' do
+ describe "#new" do
+ it "renders new" do
get :new, params: { project_id: project.id }
expect(response).to be_successful
- expect(response).to render_template 'new'
+ expect(response).to render_template "new"
end
end
- describe '#create' do
- context 'with news_added notifications' do
- it 'persists a news item' do
+ describe "#create" do
+ context "with news_added notifications" do
+ it "persists a news item" do
become_member(project, user)
post :create,
params: {
project_id: project.id,
news: {
- title: 'NewsControllerTest',
- description: 'This is the description',
- summary: ''
+ title: "NewsControllerTest",
+ description: "This is the description",
+ summary: ""
}
}
expect(response).to redirect_to project_news_index_path(project)
- news = News.find_by!(title: 'NewsControllerTest')
+ news = News.find_by!(title: "NewsControllerTest")
expect(news).not_to be_nil
- expect(news.description).to eq 'This is the description'
+ expect(news.description).to eq "This is the description"
expect(news.author).to eq user
expect(news.project).to eq project
end
@@ -127,43 +127,43 @@
params: {
project_id: project.id,
news: {
- title: '',
- description: 'This is the description',
- summary: ''
+ title: "",
+ description: "This is the description",
+ summary: ""
}
}
expect(response).to be_successful
- expect(response).to render_template 'new'
+ expect(response).to render_template "new"
expect(assigns(:news)).not_to be_nil
expect(assigns(:news)).to be_new_record
- expect(response.body).to have_css('div.op-toast.-error', text: /1 error/)
+ expect(response.body).to have_css("div.op-toast.-error", text: /1 error/)
end
end
- describe '#edit' do
- it 'renders edit' do
+ describe "#edit" do
+ it "renders edit" do
get :edit, params: { id: news.id }
expect(response).to be_successful
- expect(response).to render_template 'edit'
+ expect(response).to render_template "edit"
end
end
- describe '#update' do
- it 'updates the news element' do
+ describe "#update" do
+ it "updates the news element" do
put :update,
- params: { id: news.id, news: { description: 'Description changed by test_post_edit' } }
+ params: { id: news.id, news: { description: "Description changed by test_post_edit" } }
expect(response).to redirect_to news_path(news)
news.reload
- expect(news.description).to eq 'Description changed by test_post_edit'
+ expect(news.description).to eq "Description changed by test_post_edit"
end
end
- describe '#destroy' do
- it 'deletes the news element and redirects to the news overview page' do
+ describe "#destroy" do
+ it "deletes the news element and redirects to the news overview page" do
delete :destroy, params: { id: news.id }
expect(response).to redirect_to project_news_index_path(news.project)
diff --git a/spec/controllers/oauth/applications_controller_spec.rb b/spec/controllers/oauth/applications_controller_spec.rb
index 6677683cf0c7..5ab1af33d4a8 100644
--- a/spec/controllers/oauth/applications_controller_spec.rb
+++ b/spec/controllers/oauth/applications_controller_spec.rb
@@ -26,21 +26,21 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'work_package'
+require "spec_helper"
+require "work_package"
RSpec.describe OAuth::ApplicationsController do
let(:user) { build_stubbed(:admin) }
- let(:application_stub) { build_stubbed(:oauth_application, id: 1, secret: 'foo') }
+ let(:application_stub) { build_stubbed(:oauth_application, id: 1, secret: "foo") }
before do
login_as user
end
- context 'not logged as admin' do
+ context "not logged as admin" do
let(:user) { build_stubbed(:user) }
- it 'does not grant access' do
+ it "does not grant access" do
get :index
expect(response.response_code).to eq 403
@@ -61,7 +61,7 @@
end
end
- describe '#new' do
+ describe "#new" do
it do
get :new
expect(response.status).to be 200
@@ -69,58 +69,58 @@
end
end
- describe '#edit' do
+ describe "#edit" do
before do
allow(Doorkeeper::Application)
.to receive(:find)
- .with('1')
+ .with("1")
.and_return(application_stub)
end
it do
- get :edit, params: { id: 1, application: { name: 'foo' } }
+ get :edit, params: { id: 1, application: { name: "foo" } }
expect(response.status).to be 200
expect(response).to render_template :edit
end
end
- describe '#create' do
+ describe "#create" do
before do
allow(Doorkeeper::Application)
.to receive(:new)
.and_return(application_stub)
expect(application_stub).to receive(:attributes=)
expect(application_stub).to receive(:save).and_return(true)
- expect(application_stub).to receive(:plaintext_secret).and_return('secret!')
+ expect(application_stub).to receive(:plaintext_secret).and_return("secret!")
end
it do
- post :create, params: { application: { name: 'foo' } }
+ post :create, params: { application: { name: "foo" } }
expect(response).to redirect_to action: :show, id: application_stub.id
end
end
- describe '#update' do
+ describe "#update" do
before do
allow(Doorkeeper::Application)
.to receive(:find)
- .with('1')
+ .with("1")
.and_return(application_stub)
expect(application_stub).to receive(:attributes=)
expect(application_stub).to receive(:save).and_return(true)
end
it do
- patch :update, params: { id: 1, application: { name: 'foo' } }
+ patch :update, params: { id: 1, application: { name: "foo" } }
expect(response).to redirect_to action: :index
end
end
- describe '#destroy' do
+ describe "#destroy" do
before do
allow(Doorkeeper::Application)
.to receive(:find)
- .with('1')
+ .with("1")
.and_return(application_stub)
expect(application_stub).to receive(:destroy).and_return(true)
end
diff --git a/spec/controllers/oauth/grants_controller_spec.rb b/spec/controllers/oauth/grants_controller_spec.rb
index 4a280584febd..2ad78d320223 100644
--- a/spec/controllers/oauth/grants_controller_spec.rb
+++ b/spec/controllers/oauth/grants_controller_spec.rb
@@ -26,27 +26,27 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'work_package'
+require "spec_helper"
+require "work_package"
RSpec.describe OAuth::GrantsController do
let(:user) { build_stubbed(:user) }
- let(:application_stub) { instance_double(Doorkeeper::Application, name: 'Foo', id: 1) }
+ let(:application_stub) { instance_double(Doorkeeper::Application, name: "Foo", id: 1) }
before do
login_as user
end
- describe '#revoke_application' do
- context 'when not found' do
- it 'renders 404' do
+ describe "#revoke_application" do
+ context "when not found" do
+ it "renders 404" do
post :revoke_application, params: { application_id: 1234 }
expect(flash[:notice]).to be_nil
expect(response.response_code).to eq 404
end
end
- context 'when found' do
+ context "when found" do
before do
allow(controller)
.to receive(:find_application)
@@ -55,8 +55,8 @@
it do
post :revoke_application, params: { application_id: 1 }
- expect(flash[:notice]).to include 'Foo'
- expect(response).to redirect_to controller: '/my', action: :access_token
+ expect(flash[:notice]).to include "Foo"
+ expect(response).to redirect_to controller: "/my", action: :access_token
end
end
end
diff --git a/spec/controllers/placeholder_users/memberships_controller_spec.rb b/spec/controllers/placeholder_users/memberships_controller_spec.rb
index 05dda05320f4..b4bf36edf6e6 100644
--- a/spec/controllers/placeholder_users/memberships_controller_spec.rb
+++ b/spec/controllers/placeholder_users/memberships_controller_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'work_package'
+require "spec_helper"
+require "work_package"
RSpec.describe PlaceholderUsers::MembershipsController do
shared_let(:placeholder_user) { create(:placeholder_user) }
@@ -35,8 +35,8 @@
shared_let(:project) { create(:project) }
shared_let(:role) { create(:project_role) }
- shared_examples 'update memberships flow' do
- it 'works' do
+ shared_examples "update memberships flow" do
+ it "works" do
# i.e. it should successfully add a placeholder user to a project's members
post :create,
params: {
@@ -47,10 +47,10 @@
}
}
- expect(response).to redirect_to(controller: '/placeholder_users',
- action: 'edit',
+ expect(response).to redirect_to(controller: "/placeholder_users",
+ action: "edit",
id: placeholder_user.id,
- tab: 'memberships')
+ tab: "memberships")
is_member = placeholder_user.reload.memberships.any? do |m|
m.project_id == project.id && m.role_ids.include?(role.id)
@@ -59,9 +59,9 @@
end
end
- shared_examples 'update memberships forbidden flow' do
- describe 'POST create' do
- it 'returns an error' do
+ shared_examples "update memberships forbidden flow" do
+ describe "POST create" do
+ it "returns an error" do
post :create, params: {
placeholder_user_id: placeholder_user.id,
membership: {
@@ -74,8 +74,8 @@
end
end
- describe 'PUT update' do
- it 'returns an error' do
+ describe "PUT update" do
+ it "returns an error" do
put :update, params: {
placeholder_user_id: placeholder_user.id,
id: 1234
@@ -85,8 +85,8 @@
end
end
- describe 'DELETE destroy' do
- it 'returns an error' do
+ describe "DELETE destroy" do
+ it "returns an error" do
delete :destroy, params: {
placeholder_user_id: placeholder_user.id,
id: 1234
@@ -97,27 +97,27 @@
end
end
- context 'as admin' do
+ context "as admin" do
current_user { create(:admin) }
- it_behaves_like 'update memberships flow'
+ it_behaves_like "update memberships flow"
end
- context 'as user with global permission and manage_members' do
+ context "as user with global permission and manage_members" do
current_user do
create(:user,
member_with_permissions: { project => %i[manage_members] },
global_permissions: %i[manage_placeholder_user])
end
- it_behaves_like 'update memberships flow'
+ it_behaves_like "update memberships flow"
end
- context 'as user with global permission but not project permission' do
+ context "as user with global permission but not project permission" do
current_user { create(:user, global_permissions: %i[manage_placeholder_user]) }
- describe 'POST create' do
- it 'redirects but fails to create' do
+ describe "POST create" do
+ it "redirects but fails to create" do
post :create, params: {
placeholder_user_id: placeholder_user.id,
membership: {
@@ -131,12 +131,12 @@
end
end
- context 'with a membership in another project that is invisible' do
+ context "with a membership in another project that is invisible" do
shared_let(:project2) { create(:project) }
shared_let(:membership) { create(:member, principal: placeholder_user, project: project2, roles: [role]) }
- describe 'PUT update' do
- it 'returns an error' do
+ describe "PUT update" do
+ it "returns an error" do
put :update, params: {
placeholder_user_id: placeholder_user.id,
id: membership.id
@@ -146,8 +146,8 @@
end
end
- describe 'DELETE destroy' do
- it 'returns an error' do
+ describe "DELETE destroy" do
+ it "returns an error" do
delete :destroy, params: {
placeholder_user_id: placeholder_user.id,
id: membership.id
@@ -159,9 +159,9 @@
end
end
- context 'as user without global permission' do
+ context "as user without global permission" do
current_user { create(:user) }
- it_behaves_like 'update memberships forbidden flow'
+ it_behaves_like "update memberships forbidden flow"
end
end
diff --git a/spec/controllers/placeholder_users_controller_spec.rb b/spec/controllers/placeholder_users_controller_spec.rb
index 43b01dbc41d3..401464a45a11 100644
--- a/spec/controllers/placeholder_users_controller_spec.rb
+++ b/spec/controllers/placeholder_users_controller_spec.rb
@@ -26,58 +26,58 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'work_package'
+require "spec_helper"
+require "work_package"
RSpec.describe PlaceholderUsersController do
shared_let(:placeholder_user) { create(:placeholder_user) }
- shared_examples 'do not allow non-admins' do
- it 'responds with unauthorized status' do
+ shared_examples "do not allow non-admins" do
+ it "responds with unauthorized status" do
expect(response).not_to be_successful
expect(response.status).to eq 403
end
end
- shared_examples 'renders the show template' do
- it 'renders the show template' do
+ shared_examples "renders the show template" do
+ it "renders the show template" do
get :show, params: { id: placeholder_user.id }
expect(response).to be_successful
- expect(response).to render_template 'placeholder_users/show'
+ expect(response).to render_template "placeholder_users/show"
expect(assigns(:placeholder_user)).to be_present
expect(assigns(:memberships)).to be_empty
end
end
- shared_examples 'authorized flows' do
- describe 'GET new' do
- it 'renders the new template' do
+ shared_examples "authorized flows" do
+ describe "GET new" do
+ it "renders the new template" do
get :new
expect(response).to be_successful
- expect(response).to render_template 'placeholder_users/new'
+ expect(response).to render_template "placeholder_users/new"
expect(assigns(:placeholder_user)).to be_present
end
end
- describe 'GET index' do
- it 'renders the index template' do
+ describe "GET index" do
+ it "renders the index template" do
get :index
expect(response).to be_successful
- expect(response).to render_template 'placeholder_users/index'
+ expect(response).to render_template "placeholder_users/index"
expect(assigns(:placeholder_users)).to be_present
expect(assigns(:groups)).not_to be_present
end
end
- describe 'GET show' do
- it_behaves_like 'renders the show template'
+ describe "GET show" do
+ it_behaves_like "renders the show template"
end
- describe 'GET edit' do
- it 'renders the show template' do
+ describe "GET edit" do
+ it "renders the show template" do
get :edit, params: { id: placeholder_user.id }
expect(response).to be_successful
expect(response).to render_template "placeholder_users/edit"
@@ -87,11 +87,11 @@
end
end
- describe 'POST create' do
+ describe "POST create" do
let(:params) do
{
placeholder_user: {
- name: 'UX Developer'
+ name: "UX Developer"
}
}
end
@@ -100,8 +100,8 @@
post :create, params:
end
- context 'without ee' do
- it 'returns with an error' do
+ context "without ee" do
+ it "returns with an error" do
expect { post :create, params: }.not_to change { PlaceholderUser.count }
expect(response).to be_successful
@@ -110,73 +110,73 @@
end
end
- context 'with ee', with_ee: %i[placeholder_users] do
- it 'is assigned their new values' do
+ context "with ee", with_ee: %i[placeholder_users] do
+ it "is assigned their new values" do
user_from_db = PlaceholderUser.last
- expect(user_from_db.name).to eq('UX Developer')
+ expect(user_from_db.name).to eq("UX Developer")
end
- it 'shows a success notice' do
+ it "shows a success notice" do
expect(flash[:notice]).to eql(I18n.t(:notice_successful_create))
end
- it 'does not send an email' do
+ it "does not send an email" do
expect(ActionMailer::Base.deliveries.empty?).to be_truthy
end
- context 'when user chose to directly create the next placeholder user' do
+ context "when user chose to directly create the next placeholder user" do
let(:params) do
{
placeholder_user: {
- name: 'UX Developer'
+ name: "UX Developer"
},
continue: true
}
end
- it 'redirects to the new page' do
+ it "redirects to the new page" do
expect(response).to redirect_to(new_placeholder_user_url)
end
end
- context 'when user chose to NOT directly create the next placeholder user' do
+ context "when user chose to NOT directly create the next placeholder user" do
let(:params) do
{
placeholder_user: {
- name: 'UX Developer'
+ name: "UX Developer"
}
}
end
- it 'redirects to the edit page' do
+ it "redirects to the edit page" do
user_from_db = PlaceholderUser.last
expect(response).to redirect_to(edit_placeholder_user_url(user_from_db))
end
end
- context 'invalid params' do
+ context "invalid params" do
let(:params) do
{
placeholder_user: {
- name: 'x' * 300 # Name is too long
+ name: "x" * 300 # Name is too long
}
}
end
- it 'renders the edit form with a validation error message' do
- expect(assigns(:placeholder_user).errors.messages[:name].first).to include('is too long')
- expect(response).to render_template 'placeholder_users/new'
+ it "renders the edit form with a validation error message" do
+ expect(assigns(:placeholder_user).errors.messages[:name].first).to include("is too long")
+ expect(response).to render_template "placeholder_users/new"
end
end
end
end
- describe 'PUT update' do
+ describe "PUT update" do
let(:params) do
{
id: placeholder_user.id,
placeholder_user: {
- name: 'UX Guru'
+ name: "UX Guru"
}
}
end
@@ -185,53 +185,53 @@
put :update, params:
end
- it 'redirects to the edit page' do
+ it "redirects to the edit page" do
expect(response).to redirect_to(edit_placeholder_user_url(placeholder_user))
end
- it 'is assigned their new values' do
+ it "is assigned their new values" do
user_from_db = PlaceholderUser.find(placeholder_user.id)
- expect(user_from_db.name).to eq('UX Guru')
+ expect(user_from_db.name).to eq("UX Guru")
end
- it 'does not send an email' do
+ it "does not send an email" do
expect(ActionMailer::Base.deliveries.empty?).to be_truthy
end
- context 'invalid params' do
+ context "invalid params" do
let(:params) do
{
id: placeholder_user.id,
placeholder_user: {
- name: 'x' * 300 # Name is too long
+ name: "x" * 300 # Name is too long
}
}
end
- it 'renders the edit form with a validation error message' do
- expect(assigns(:placeholder_user).errors.messages[:name].first).to include('is too long')
- expect(response).to render_template 'placeholder_users/edit'
+ it "renders the edit form with a validation error message" do
+ expect(assigns(:placeholder_user).errors.messages[:name].first).to include("is too long")
+ expect(response).to render_template "placeholder_users/edit"
end
end
end
- describe 'GET deletion_info' do
+ describe "GET deletion_info" do
before do
get :deletion_info, params: { id: placeholder_user.id }
end
- it 'renders the deletion info response' do
+ it "renders the deletion info response" do
expect(response).to be_successful
- expect(response).to render_template 'placeholder_users/deletion_info'
+ expect(response).to render_template "placeholder_users/deletion_info"
end
end
- describe 'POST destroy' do
+ describe "POST destroy" do
before do
delete :destroy, params: { id: placeholder_user.id }
end
- it 'triggers the deletion' do
+ it "triggers the deletion" do
expect(response).to redirect_to action: :index
expect(flash[:info]).to include I18n.t(:notice_deletion_scheduled)
@@ -241,53 +241,53 @@
end
end
- context 'as an admin' do
+ context "as an admin" do
current_user { create(:admin) }
- it_behaves_like 'authorized flows'
+ it_behaves_like "authorized flows"
end
- context 'as a user with global permission' do
+ context "as a user with global permission" do
current_user { create(:user, global_permissions: %i[manage_placeholder_user]) }
- it_behaves_like 'authorized flows'
+ it_behaves_like "authorized flows"
end
- context 'as an unauthorized user' do
+ context "as an unauthorized user" do
current_user { create(:user) }
- describe 'GET new' do
+ describe "GET new" do
before do
get :new
end
- it_behaves_like 'do not allow non-admins'
+ it_behaves_like "do not allow non-admins"
end
- describe 'GET index' do
+ describe "GET index" do
before do
get :index
end
- it_behaves_like 'do not allow non-admins'
+ it_behaves_like "do not allow non-admins"
end
- describe 'GET show' do
- it_behaves_like 'renders the show template'
+ describe "GET show" do
+ it_behaves_like "renders the show template"
end
- describe 'GET edit' do
+ describe "GET edit" do
before do
get :edit, params: { id: placeholder_user.id }
end
- it_behaves_like 'do not allow non-admins'
+ it_behaves_like "do not allow non-admins"
end
- describe 'POST create' do
+ describe "POST create" do
let(:params) do
{
placeholder_user: {
- name: 'UX Developer'
+ name: "UX Developer"
}
}
end
@@ -296,15 +296,15 @@
post :create, params:
end
- it_behaves_like 'do not allow non-admins'
+ it_behaves_like "do not allow non-admins"
end
- describe 'PUT update' do
+ describe "PUT update" do
let(:params) do
{
id: placeholder_user.id,
placeholder_user: {
- name: 'UX Guru'
+ name: "UX Guru"
}
}
end
@@ -313,27 +313,27 @@
put :update, params:
end
- it_behaves_like 'do not allow non-admins'
+ it_behaves_like "do not allow non-admins"
end
- describe 'GET deletion_info' do
+ describe "GET deletion_info" do
before do
get :deletion_info, params: { id: placeholder_user.id }
end
- it_behaves_like 'do not allow non-admins'
+ it_behaves_like "do not allow non-admins"
end
- describe 'POST destroy' do
+ describe "POST destroy" do
before do
delete :destroy, params: { id: placeholder_user.id }
end
- it_behaves_like 'do not allow non-admins'
+ it_behaves_like "do not allow non-admins"
end
end
- context 'as a user that may not delete the placeholder' do
+ context "as a user that may not delete the placeholder" do
current_user { create(:user) }
before do
@@ -341,23 +341,23 @@
.to receive(:deletion_allowed?).and_return false
end
- describe 'GET deletion_info' do
+ describe "GET deletion_info" do
before do
get :deletion_info, params: { id: placeholder_user.id }
end
- it 'responds with unauthorized status' do
+ it "responds with unauthorized status" do
expect(response).not_to be_successful
expect(response.status).to eq 403
end
end
- describe 'POST destroy' do
+ describe "POST destroy" do
before do
delete :destroy, params: { id: placeholder_user.id }
end
- it 'responds with unauthorized status' do
+ it "responds with unauthorized status" do
expect(response).not_to be_successful
expect(response.status).to eq 403
end
diff --git a/spec/controllers/projects/identifier_controller_spec.rb b/spec/controllers/projects/identifier_controller_spec.rb
index 9737d06daa49..de3fe73828a1 100644
--- a/spec/controllers/projects/identifier_controller_spec.rb
+++ b/spec/controllers/projects/identifier_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'rails_helper'
+require "rails_helper"
RSpec.describe Projects::IdentifierController do
let(:project) { create(:project) }
@@ -34,22 +34,22 @@
current_user { create(:admin) }
render_views
- describe 'update' do
- it 'sets the project identifier to the provided value' do
- put :update, params: { project_id: project.id, project: { identifier: 'new-identifier' } }
+ describe "update" do
+ it "sets the project identifier to the provided value" do
+ put :update, params: { project_id: project.id, project: { identifier: "new-identifier" } }
# Upon success, the user is redirected to the general project settings page
expect(response).to have_http_status(:redirect)
- expect(project.reload.identifier).to eq('new-identifier')
+ expect(project.reload.identifier).to eq("new-identifier")
end
- context 'with an invalid identifier' do
- it 'does not change the project identifier and correctly renders the view' do
+ context "with an invalid identifier" do
+ it "does not change the project identifier and correctly renders the view" do
previous_identifier = project.identifier
- put :update, params: { project_id: project.id, project: { identifier: 'bad identifier' } }
+ put :update, params: { project_id: project.id, project: { identifier: "bad identifier" } }
expect(response).to have_http_status(:ok)
- expect(response.body).to include('Identifier is invalid')
+ expect(response.body).to include("Identifier is invalid")
expect(project.reload.identifier).to eq(previous_identifier)
end
end
diff --git a/spec/controllers/projects_controller_spec.rb b/spec/controllers/projects_controller_spec.rb
index 7e8da4e84cd4..ec6ae981a623 100644
--- a/spec/controllers/projects_controller_spec.rb
+++ b/spec/controllers/projects_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe ProjectsController do
shared_let(:admin) { create(:admin) }
@@ -38,14 +38,14 @@
login_as admin
end
- describe '#new' do
+ describe "#new" do
it "renders 'new'" do
- get 'new'
+ get "new"
expect(response).to be_successful
- expect(response).to render_template 'new'
+ expect(response).to render_template "new"
end
- context 'by non-admin user with add_project permission' do
+ context "by non-admin user with add_project permission" do
let(:non_member_user) { create(:user) }
before do
@@ -53,40 +53,40 @@
login_as non_member_user
end
- it 'accepts get' do
+ it "accepts get" do
get :new
expect(response).to be_successful
- expect(response).to render_template 'new'
+ expect(response).to render_template "new"
end
end
end
- describe 'index.html' do
- shared_let(:project_a) { create(:project, name: 'Project A', public: false, active: true) }
- shared_let(:project_b) { create(:project, name: 'Project B', public: false, active: true) }
- shared_let(:project_c) { create(:project, name: 'Project C', public: true, active: true) }
- shared_let(:project_d) { create(:project, name: 'Project D', public: true, active: false) }
+ describe "index.html" do
+ shared_let(:project_a) { create(:project, name: "Project A", public: false, active: true) }
+ shared_let(:project_b) { create(:project, name: "Project B", public: false, active: true) }
+ shared_let(:project_c) { create(:project, name: "Project C", public: true, active: true) }
+ shared_let(:project_d) { create(:project, name: "Project D", public: true, active: false) }
before do
ProjectRole.anonymous
ProjectRole.non_member
login_as(user)
- get 'index'
+ get "index"
end
- shared_examples_for 'successful index' do
- it 'is success' do
+ shared_examples_for "successful index" do
+ it "is success" do
expect(response).to be_successful
end
- it 'renders the index template' do
- expect(response).to render_template 'index'
+ it "renders the index template" do
+ expect(response).to render_template "index"
end
end
end
- describe '#destroy' do
+ describe "#destroy" do
render_views
let(:project) { build_stubbed(:project) }
@@ -105,20 +105,20 @@
.and_return(deletion_service)
end
- context 'when service call succeeds' do
+ context "when service call succeeds" do
let(:success) { true }
- it 'prints success' do
+ it "prints success" do
request
expect(response).to be_redirect
expect(flash[:notice]).to be_present
end
end
- context 'when service call fails' do
+ context "when service call fails" do
let(:success) { false }
- it 'prints fail' do
+ it "prints fail" do
request
expect(response).to be_redirect
expect(flash[:error]).to be_present
@@ -126,28 +126,28 @@
end
end
- describe 'with an existing project' do
- let(:project) { create(:project, identifier: 'blog') }
+ describe "with an existing project" do
+ let(:project) { create(:project, identifier: "blog") }
- it 'gets destroy info' do
+ it "gets destroy info" do
get :destroy_info, params: { id: project.id }
expect(response).to be_successful
- expect(response).to render_template 'destroy_info'
+ expect(response).to render_template "destroy_info"
expect { project.reload }.not_to raise_error
end
end
- describe '#copy' do
- let(:project) { create(:project, identifier: 'blog') }
+ describe "#copy" do
+ let(:project) { create(:project, identifier: "blog") }
it "renders 'copy'" do
- get 'copy', params: { id: project.id }
+ get "copy", params: { id: project.id }
expect(response).to be_successful
- expect(response).to render_template 'copy'
+ expect(response).to render_template "copy"
end
- context 'as non authorized user' do
+ context "as non authorized user" do
let(:user) { build_stubbed(:user) }
before do
@@ -155,7 +155,7 @@
end
it "shows an error" do
- get 'copy', params: { id: project.id }
+ get "copy", params: { id: project.id }
expect(response.status).to eq 403
end
end
diff --git a/spec/controllers/projects_settings_menu_controller_spec.rb b/spec/controllers/projects_settings_menu_controller_spec.rb
index 380e4acc2e5e..9dbc944a742c 100644
--- a/spec/controllers/projects_settings_menu_controller_spec.rb
+++ b/spec/controllers/projects_settings_menu_controller_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe Projects::Settings::ModulesController, 'menu' do
+RSpec.describe Projects::Settings::ModulesController, "menu" do
let(:current_user) { build_stubbed(:user) }
let(:project) do
@@ -43,84 +43,84 @@
login_as(current_user)
end
- shared_examples_for 'renders the modules show page' do
- it 'renders show' do
- get('show', params:)
+ shared_examples_for "renders the modules show page" do
+ it "renders show" do
+ get("show", params:)
expect(response).to be_successful
- expect(response).to render_template 'projects/settings/modules/show'
+ expect(response).to render_template "projects/settings/modules/show"
end
end
- shared_examples_for 'has selector' do |selector|
+ shared_examples_for "has selector" do |selector|
render_views
it do
- get('show', params:)
+ get("show", params:)
expect(response.body).to have_selector selector
end
end
- shared_examples_for 'has no selector' do |selector|
+ shared_examples_for "has no selector" do |selector|
render_views
it do
- get('show', params:)
+ get("show", params:)
expect(response.body).to have_no_selector selector
end
end
- describe 'show' do
- describe 'without wiki' do
+ describe "show" do
+ describe "without wiki" do
before do
project.wiki.destroy
project.reload
end
- it_behaves_like 'renders the modules show page'
+ it_behaves_like "renders the modules show page"
- it_behaves_like 'has no selector', '#main-menu a.wiki-wiki-menu-item'
+ it_behaves_like "has no selector", "#main-menu a.wiki-wiki-menu-item"
end
- describe 'with wiki' do
- describe 'without custom wiki menu items' do
- it_behaves_like 'has selector', '#main-menu a.wiki-wiki-menu-item'
+ describe "with wiki" do
+ describe "without custom wiki menu items" do
+ it_behaves_like "has selector", "#main-menu a.wiki-wiki-menu-item"
end
- describe 'with custom wiki menu item' do
+ describe "with custom wiki menu item" do
before do
main_item = create(:wiki_menu_item,
navigatable_id: project.wiki.id,
- name: 'example',
- title: 'Example Title')
+ name: "example",
+ title: "Example Title")
create(:wiki_menu_item,
navigatable_id: project.wiki.id,
- name: 'sub',
- title: 'Sub Title',
+ name: "sub",
+ title: "Sub Title",
parent_id: main_item.id)
end
- it_behaves_like 'renders the modules show page'
+ it_behaves_like "renders the modules show page"
- it_behaves_like 'has selector', '#main-menu a.wiki-example-menu-item'
+ it_behaves_like "has selector", "#main-menu a.wiki-example-menu-item"
- it_behaves_like 'has selector', '#main-menu a.wiki-sub-menu-item'
+ it_behaves_like "has selector", "#main-menu a.wiki-sub-menu-item"
end
end
- describe 'with activated activity module' do
+ describe "with activated activity module" do
let(:enabled_modules) { %w[activity] }
- it_behaves_like 'renders the modules show page'
+ it_behaves_like "renders the modules show page"
- it_behaves_like 'has selector', '#main-menu a.activity-menu-item'
+ it_behaves_like "has selector", "#main-menu a.activity-menu-item"
end
- describe 'without activated activity module' do
- it_behaves_like 'renders the modules show page'
+ describe "without activated activity module" do
+ it_behaves_like "renders the modules show page"
- it_behaves_like 'has no selector', '#main-menu a.activity-menu-item'
+ it_behaves_like "has no selector", "#main-menu a.activity-menu-item"
end
end
end
diff --git a/spec/controllers/queries/params_parser_spec.rb b/spec/controllers/queries/params_parser_spec.rb
index a4fcae942e0c..49fb4569d533 100644
--- a/spec/controllers/queries/params_parser_spec.rb
+++ b/spec/controllers/queries/params_parser_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Queries::ParamsParser, type: :model do
let(:params) do
@@ -37,65 +37,65 @@
subject { described_class.parse(params.with_indifferent_access) }
- describe '.parse' do
- context 'without any params' do
- it 'returns an empty array' do
+ describe ".parse" do
+ context "without any params" do
+ it "returns an empty array" do
expect(subject)
.to be_empty
end
end
- context 'with a single filter with a single value' do
+ context "with a single filter with a single value" do
let(:params) do
{
filters: "active = t"
}
end
- it 'returns the parsed filter' do
+ it "returns the parsed filter" do
expect(subject[:filters])
- .to contain_exactly({ attribute: 'active', operator: '=', values: ['t'] })
+ .to contain_exactly({ attribute: "active", operator: "=", values: ["t"] })
end
end
- context 'with a single filter with multiple values having single quotes' do
+ context "with a single filter with multiple values having single quotes" do
let(:params) do
{
filters: "active = ['t', 'f']"
}
end
- it 'returns the parsed filter' do
+ it "returns the parsed filter" do
expect(subject[:filters])
- .to contain_exactly({ attribute: 'active', operator: '=', values: %w[t f] })
+ .to contain_exactly({ attribute: "active", operator: "=", values: %w[t f] })
end
end
- context 'with a single filter with multiple values having double quotes' do
+ context "with a single filter with multiple values having double quotes" do
let(:params) do
{
filters: "active = [\"t\", \"f\"]"
}
end
- it 'returns the parsed filter' do
+ it "returns the parsed filter" do
expect(subject[:filters])
- .to contain_exactly({ attribute: 'active', operator: '=', values: %w[t f] })
+ .to contain_exactly({ attribute: "active", operator: "=", values: %w[t f] })
end
end
- context 'with a single filter with a single value with , and &' do
+ context "with a single filter with a single value with , and &" do
let(:params) do
{
- filters: 'active = something, or another thing & something else'
+ filters: "active = something, or another thing & something else"
}
end
- it 'returns the parsed filter' do
+ it "returns the parsed filter" do
# This returns invalid filters but they will then be marked as invalid
expect(subject[:filters])
- .to contain_exactly({ attribute: 'active', operator: '=', values: ["something, or another thing "] },
- { attribute: 'something', operator: 'else', values: [''] })
+ .to contain_exactly({ attribute: "active", operator: "=", values: ["something, or another thing "] },
+ { attribute: "something", operator: "else", values: [""] })
end
end
@@ -106,165 +106,165 @@
}
end
- it 'returns the parsed filter' do
+ it "returns the parsed filter" do
expect(subject[:filters])
- .to contain_exactly({ attribute: 'active', operator: '=', values: ["something, or another thing \" something else"] })
+ .to contain_exactly({ attribute: "active", operator: "=", values: ["something, or another thing \" something else"] })
end
end
- context 'with a single filter with a single value with \' (escaped)' do
+ context "with a single filter with a single value with ' (escaped)" do
let(:params) do
{
filters: "active = 'something, or another thing \\' something else'"
}
end
- it 'returns the parsed filter' do
+ it "returns the parsed filter" do
expect(subject[:filters])
- .to contain_exactly({ attribute: 'active', operator: '=', values: ["something, or another thing ' something else"] })
+ .to contain_exactly({ attribute: "active", operator: "=", values: ["something, or another thing ' something else"] })
end
end
- context 'with a single filter with no value' do
+ context "with a single filter with no value" do
let(:params) do
{
- filters: 'cf_512 !* '
+ filters: "cf_512 !* "
}
end
- it 'returns the parsed filter' do
+ it "returns the parsed filter" do
expect(subject[:filters])
- .to contain_exactly({ attribute: 'cf_512', operator: '!*', values: [''] })
+ .to contain_exactly({ attribute: "cf_512", operator: "!*", values: [""] })
end
end
- context 'with multiple filters with the first having no value' do
+ context "with multiple filters with the first having no value" do
let(:params) do
{
filters: "active !* & id = \"1\""
}
end
- it 'returns the parsed filter' do
+ it "returns the parsed filter" do
expect(subject[:filters])
- .to contain_exactly({ attribute: 'active', operator: '!*', values: [] },
- { attribute: 'id', operator: '=', values: ["1"] })
+ .to contain_exactly({ attribute: "active", operator: "!*", values: [] },
+ { attribute: "id", operator: "=", values: ["1"] })
end
end
- context 'with multiple filters with ampersand as a filter value' do
+ context "with multiple filters with ampersand as a filter value" do
let(:params) do
{
filters: "active = \"t\" & name_and_identifier ~ \"abc & def\""
}
end
- it 'returns the parsed filter' do
+ it "returns the parsed filter" do
expect(subject[:filters])
- .to contain_exactly({ attribute: 'active', operator: '=', values: ["t"] },
- { attribute: 'name_and_identifier', operator: '~', values: ["abc & def"] })
+ .to contain_exactly({ attribute: "active", operator: "=", values: ["t"] },
+ { attribute: "name_and_identifier", operator: "~", values: ["abc & def"] })
end
end
- context 'with a corrupt filter only having a key' do
+ context "with a corrupt filter only having a key" do
let(:params) do
{
filters: "active"
}
end
- it 'returns the parsed filter' do
+ it "returns the parsed filter" do
expect(subject[:filters])
- .to contain_exactly({ attribute: 'active', operator: '', values: [""] })
+ .to contain_exactly({ attribute: "active", operator: "", values: [""] })
end
end
- context 'with a corrupt filter having opening braces but no closing ones' do
+ context "with a corrupt filter having opening braces but no closing ones" do
let(:params) do
{
filters: "active = [\"t\", \"f\""
}
end
- it 'returns the parsed filter' do
+ it "returns the parsed filter" do
expect(subject[:filters])
- .to contain_exactly({ attribute: 'active', operator: '=', values: %w[t f] })
+ .to contain_exactly({ attribute: "active", operator: "=", values: %w[t f] })
end
end
- context 'with a corrupt filter having opening double quotes but no closing ones' do
+ context "with a corrupt filter having opening double quotes but no closing ones" do
let(:params) do
{
filters: 'active = "t'
}
end
- it 'returns the parsed filter' do
+ it "returns the parsed filter" do
expect(subject[:filters])
- .to contain_exactly({ attribute: 'active', operator: '=', values: %w[t] })
+ .to contain_exactly({ attribute: "active", operator: "=", values: %w[t] })
end
end
- context 'with a corrupt filter having opening single quotes but no closing ones' do
+ context "with a corrupt filter having opening single quotes but no closing ones" do
let(:params) do
{
filters: "active = 't"
}
end
- it 'returns the parsed filter' do
+ it "returns the parsed filter" do
expect(subject[:filters])
- .to contain_exactly({ attribute: 'active', operator: '=', values: %w[t] })
+ .to contain_exactly({ attribute: "active", operator: "=", values: %w[t] })
end
end
- context 'with sortBy with a single value' do
+ context "with sortBy with a single value" do
let(:params) do
{
sortBy: JSON.dump([%w[name asc]])
}
end
- it 'returns the parsed filter' do
+ it "returns the parsed filter" do
expect(subject[:orders])
- .to eql [{ attribute: 'name', direction: 'asc' }]
+ .to eql [{ attribute: "name", direction: "asc" }]
end
end
- context 'with sortBy with a multiple value' do
+ context "with sortBy with a multiple value" do
let(:params) do
{
sortBy: JSON.dump([%w[name asc], %w[created_at desc]])
}
end
- it 'returns the parsed filter' do
+ it "returns the parsed filter" do
expect(subject[:orders])
- .to eql [{ attribute: 'name', direction: 'asc' }, { attribute: 'created_at', direction: 'desc' }]
+ .to eql [{ attribute: "name", direction: "asc" }, { attribute: "created_at", direction: "desc" }]
end
end
- context 'with an invalid sortBy' do
+ context "with an invalid sortBy" do
let(:params) do
{
sortBy: "[sjfkdsjfkd}"
}
end
- it 'returns an invalid sort order' do
+ it "returns an invalid sort order" do
expect(subject[:orders])
- .to eql [{ attribute: 'invalid', direction: 'asc' }]
+ .to eql [{ attribute: "invalid", direction: "asc" }]
end
end
- context 'with multiple columns' do
+ context "with multiple columns" do
let(:params) do
{
columns: "name cf_1 project_status"
}
end
- it 'returns an invalid sort order' do
+ it "returns an invalid sort order" do
expect(subject[:selects])
.to eql %w[name cf_1 project_status]
end
diff --git a/spec/controllers/repositories_controller_spec.rb b/spec/controllers/repositories_controller_spec.rb
index 2961d05f479a..5f05009126f1 100644
--- a/spec/controllers/repositories_controller_spec.rb
+++ b/spec/controllers/repositories_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe RepositoriesController do
let(:project) do
@@ -38,16 +38,16 @@
create(:user, member_with_roles: { project => role })
end
let(:role) { create(:project_role, permissions: []) }
- let (:url) { 'file:///tmp/something/does/not/exist.svn' }
+ let (:url) { "file:///tmp/something/does/not/exist.svn" }
let(:repository) do
- allow(Setting).to receive(:enabled_scm).and_return(['subversion'])
+ allow(Setting).to receive(:enabled_scm).and_return(["subversion"])
repo = build_stubbed(:repository_subversion,
- scm_type: 'local',
+ scm_type: "local",
url:,
project:)
- allow(repo).to receive(:default_branch).and_return('master')
- allow(repo).to receive(:branches).and_return(['master'])
+ allow(repo).to receive(:default_branch).and_return("master")
+ allow(repo).to receive(:branches).and_return(["master"])
allow(repo).to receive(:save).and_return(true)
repo
@@ -58,7 +58,7 @@
allow(project).to receive(:repository).and_return(repository)
end
- describe 'manages the repository' do
+ describe "manages the repository" do
let(:role) { create(:project_role, permissions: [:manage_repository]) }
before do
@@ -66,45 +66,45 @@
allow(controller).to receive(:authorize).and_return(true)
end
- context 'with #destroy' do
+ context "with #destroy" do
before do
allow(repository).to receive(:destroy).and_return(true)
delete :destroy, params: { project_id: project.id }, xhr: true
end
- it 'redirects to settings' do
+ it "redirects to settings" do
expect(response).to redirect_to project_settings_repository_path(project.identifier)
end
end
- context 'with #update' do
+ context "with #update" do
before do
put :update, params: { project_id: project.id }, xhr: true
end
- it 'redirects to settings' do
+ it "redirects to settings" do
expect(response).to redirect_to project_settings_repository_path(project.identifier)
end
end
- context 'with #create' do
+ context "with #create" do
before do
post :create,
params: {
project_id: project.id,
- scm_vendor: 'subversion',
- scm_type: 'local',
- url: 'file:///tmp/repo.svn/'
+ scm_vendor: "subversion",
+ scm_type: "local",
+ url: "file:///tmp/repo.svn/"
}
end
- it 'redirects to settings' do
+ it "redirects to settings" do
expect(response).to redirect_to project_settings_repository_path(project.identifier)
end
end
end
- describe 'with empty repository' do
+ describe "with empty repository" do
let(:role) { create(:project_role, permissions: [:browse_repository]) }
before do
@@ -113,25 +113,25 @@
.and_raise(OpenProject::SCM::Exceptions::SCMEmpty)
end
- context 'with #show' do
+ context "with #show" do
before do
get :show, params: { project_id: project.identifier }
end
- it 'renders an empty warning view' do
- expect(response).to render_template 'repositories/empty'
- expect(response.code).to eq('200')
+ it "renders an empty warning view" do
+ expect(response).to render_template "repositories/empty"
+ expect(response.code).to eq("200")
end
end
- context 'with #show and checkout' do
+ context "with #show and checkout" do
render_views
let(:checkout_hash) do
{
- 'subversion' => { 'enabled' => '1',
- 'text' => 'foo',
- 'base_url' => 'http://localhost' }
+ "subversion" => { "enabled" => "1",
+ "text" => "foo",
+ "base_url" => "http://localhost" }
}
end
@@ -140,15 +140,15 @@
get :show, params: { project_id: project.identifier }
end
- it 'renders an empty warning view' do
- expect(response).to render_template 'repositories/empty'
- expect(response).to render_template partial: 'repositories/_checkout_instructions'
- expect(response.code).to eq('200')
+ it "renders an empty warning view" do
+ expect(response).to render_template "repositories/empty"
+ expect(response).to render_template partial: "repositories/_checkout_instructions"
+ expect(response.code).to eq("200")
end
end
end
- describe 'with subversion repository' do
+ describe "with subversion repository" do
with_subversion_repository do |repo_dir|
let(:root_url) { repo_dir }
let(:url) { "file://#{root_url}" }
@@ -157,96 +157,96 @@
create(:repository_subversion, project:, url:, root_url: url)
end
- describe 'commits per author graph' do
+ describe "commits per author graph" do
before do
- get :graph, params: { project_id: project.identifier, graph: 'commits_per_author' }
+ get :graph, params: { project_id: project.identifier, graph: "commits_per_author" }
end
- context 'requested by an authorized user' do
+ context "requested by an authorized user" do
let(:role) do
create(:project_role, permissions: %i[browse_repository
view_commit_author_statistics])
end
- it 'is successful' do
+ it "is successful" do
expect(response).to be_successful
end
- it 'has the right content type' do
- expect(response.content_type).to eq('image/svg+xml')
+ it "has the right content type" do
+ expect(response.content_type).to eq("image/svg+xml")
end
end
- context 'requested by an unauthorized user' do
+ context "requested by an unauthorized user" do
let(:role) { create(:project_role, permissions: [:browse_repository]) }
- it 'returns 403' do
- expect(response.code).to eq('403')
+ it "returns 403" do
+ expect(response.code).to eq("403")
end
end
end
- describe 'committers' do
+ describe "committers" do
let(:role) { create(:project_role, permissions: [:manage_repository]) }
- describe '#get' do
+ describe "#get" do
before do
get :committers, params: { project_id: project.id }
end
- it 'is successful' do
+ it "is successful" do
expect(response).to be_successful
- expect(response).to render_template 'repositories/committers'
+ expect(response).to render_template "repositories/committers"
end
end
- describe '#post' do
+ describe "#post" do
before do
repository.fetch_changesets
- post :committers, params: { project_id: project.id, committers: { '0' => ['oliver', user.id] },
- commit: 'Update' }
+ post :committers, params: { project_id: project.id, committers: { "0" => ["oliver", user.id] },
+ commit: "Update" }
end
- it 'is successful' do
+ it "is successful" do
expect(response).to redirect_to committers_project_repository_path(project)
- expect(repository.committers).to include(['oliver', user.id])
+ expect(repository.committers).to include(["oliver", user.id])
end
end
end
- describe 'stats' do
+ describe "stats" do
before do
get :stats, params: { project_id: project.identifier }
end
- describe 'requested by a user with view_commit_author_statistics permission' do
+ describe "requested by a user with view_commit_author_statistics permission" do
let(:role) do
create(:project_role, permissions: %i[browse_repository
view_commit_author_statistics])
end
- it 'show the commits per author graph' do
+ it "show the commits per author graph" do
expect(assigns(:show_commits_per_author)).to be(true)
end
end
- describe 'requested by a user without view_commit_author_statistics permission' do
+ describe "requested by a user without view_commit_author_statistics permission" do
let(:role) { create(:project_role, permissions: [:browse_repository]) }
- it 'does not show the commits per author graph' do
+ it "does not show the commits per author graph" do
expect(assigns(:show_commits_per_author)).to be(false)
end
end
end
- shared_examples 'renders the repository title' do |active_breadcrumb|
+ shared_examples "renders the repository title" do |active_breadcrumb|
it do
expect(response).to be_successful
- expect(response.body).to have_css('.repository-breadcrumbs', text: active_breadcrumb)
+ expect(response.body).to have_css(".repository-breadcrumbs", text: active_breadcrumb)
end
end
- describe 'show' do
+ describe "show" do
render_views
let(:role) { create(:project_role, permissions: [:browse_repository]) }
@@ -254,20 +254,20 @@
get :show, params: { project_id: project.identifier, repo_path: path }
end
- context 'with brackets' do
- let(:path) { 'subversion_test/[folder_with_brackets]' }
+ context "with brackets" do
+ let(:path) { "subversion_test/[folder_with_brackets]" }
- it_behaves_like 'renders the repository title', '[folder_with_brackets]'
+ it_behaves_like "renders the repository title", "[folder_with_brackets]"
end
- context 'with unicode' do
- let(:path) { 'Föbar/äm/Sägepütz!%5D§' }
+ context "with unicode" do
+ let(:path) { "Föbar/äm/Sägepütz!%5D§" }
- it_behaves_like 'renders the repository title', 'Sägepütz!%5D§'
+ it_behaves_like "renders the repository title", "Sägepütz!%5D§"
end
end
- describe 'changes' do
+ describe "changes" do
render_views
let(:role) { create(:project_role, permissions: [:browse_repository]) }
@@ -276,57 +276,57 @@
expect(response).to be_successful
end
- context 'with brackets' do
- let(:path) { 'subversion_test/[folder_with_brackets]' }
+ context "with brackets" do
+ let(:path) { "subversion_test/[folder_with_brackets]" }
- it_behaves_like 'renders the repository title', '[folder_with_brackets]'
+ it_behaves_like "renders the repository title", "[folder_with_brackets]"
end
- context 'with unicode' do
- let(:path) { 'Föbar/äm' }
+ context "with unicode" do
+ let(:path) { "Föbar/äm" }
- it_behaves_like 'renders the repository title', 'äm'
+ it_behaves_like "renders the repository title", "äm"
end
end
- describe 'checkout path' do
+ describe "checkout path" do
render_views
let(:role) { create(:project_role, permissions: [:browse_repository]) }
let(:checkout_hash) do
{
- 'subversion' => { 'enabled' => '1',
- 'text' => 'foo',
- 'base_url' => 'http://localhost' }
+ "subversion" => { "enabled" => "1",
+ "text" => "foo",
+ "base_url" => "http://localhost" }
}
end
before do
allow(Setting).to receive(:repository_checkout_data).and_return(checkout_hash)
- get :show, params: { project_id: project.identifier, repo_path: 'subversion_test' }
+ get :show, params: { project_id: project.identifier, repo_path: "subversion_test" }
end
- it 'renders an empty warning view' do
+ it "renders an empty warning view" do
expected_path = "http://localhost/#{project.identifier}/subversion_test"
- expect(response.code).to eq('200')
- expect(response).to render_template partial: 'repositories/_checkout_instructions'
+ expect(response.code).to eq("200")
+ expect(response).to render_template partial: "repositories/_checkout_instructions"
expect(response.body).to have_css("#repository-checkout-url[value='#{expected_path}']")
end
end
end
end
- describe 'when not being logged in' do
+ describe "when not being logged in" do
let(:anonymous) { build_stubbed(:anonymous) }
before do
login_as(anonymous)
end
- describe '#show' do
- it 'redirects to login while preserving the path' do
- params = { repo_path: 'aDir/within/aDir', rev: '42', project_id: project.id }
+ describe "#show" do
+ it "redirects to login while preserving the path" do
+ params = { repo_path: "aDir/within/aDir", rev: "42", project_id: project.id }
get(:show, params:)
expect(response)
diff --git a/spec/controllers/roles_controller_spec.rb b/spec/controllers/roles_controller_spec.rb
index b0ed566a7809..ef52683f50d2 100644
--- a/spec/controllers/roles_controller_spec.rb
+++ b/spec/controllers/roles_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe RolesController do
let(:user) do
@@ -35,28 +35,28 @@
let(:params) do
{
role: {
- name: 'A role name',
- permissions: ['add_work_packages', 'edit_work_packages', 'log_own_time', ''],
- assignable: '0'
+ name: "A role name",
+ permissions: ["add_work_packages", "edit_work_packages", "log_own_time", ""],
+ assignable: "0"
},
- copy_workflow_from: '5'
+ copy_workflow_from: "5"
}
end
current_user { user }
- describe '#create' do
- let(:new_role) { double('role double') }
+ describe "#create" do
+ let(:new_role) { double("role double") }
let(:service_call) { ServiceResult.success(result: new_role) }
let(:create_params) do
cp = ActionController::Parameters.new(params[:role])
- .merge(global_role: nil, copy_workflow_from: '5')
+ .merge(global_role: nil, copy_workflow_from: "5")
cp.permit!
cp
end
let(:create_service) do
- service_double = double('create service')
+ service_double = double("create service")
expect(Roles::CreateService)
.to receive(:new)
@@ -75,89 +75,89 @@
post :create, params:
end
- context 'success' do
- context 'for a member role' do
- it 'redirects to roles#index' do
+ context "success" do
+ context "for a member role" do
+ it "redirects to roles#index" do
expect(response)
.to redirect_to(roles_path)
end
- it 'has a flash message' do
+ it "has a flash message" do
expect(flash[:notice])
.to eql I18n.t(:notice_successful_create)
end
end
- context 'for a global role' do
+ context "for a global role" do
let(:params) do
{
role: {
- name: 'A role name',
- permissions: ['add_work_packages', 'edit_work_packages', 'log_time', ''],
- assignable: '0'
+ name: "A role name",
+ permissions: ["add_work_packages", "edit_work_packages", "log_time", ""],
+ assignable: "0"
},
- global_role: '1',
- copy_workflow_from: '5'
+ global_role: "1",
+ copy_workflow_from: "5"
}
end
let(:create_params) do
cp = ActionController::Parameters.new(params[:role])
- .merge(global_role: '1', copy_workflow_from: '5')
+ .merge(global_role: "1", copy_workflow_from: "5")
cp.permit!
cp
end
- it 'redirects to roles#index' do
+ it "redirects to roles#index" do
expect(response)
.to redirect_to(roles_path)
end
- it 'has a flash message' do
+ it "has a flash message" do
expect(flash[:notice])
.to eql I18n.t(:notice_successful_create)
end
end
end
- context 'failure' do
+ context "failure" do
let(:service_call) { ServiceResult.failure(result: new_role) }
- it 'returns a 200 OK' do
+ it "returns a 200 OK" do
expect(response)
.to have_http_status(:ok)
end
- it 'renders the new template' do
+ it "renders the new template" do
expect(response)
- .to render_template('roles/new')
+ .to render_template("roles/new")
end
- it 'has the service call assigned' do
+ it "has the service call assigned" do
expect(assigns[:call])
.to eql service_call
end
- it 'has the role assigned' do
+ it "has the role assigned" do
expect(assigns[:role])
.to eql new_role
end
end
end
- describe '#update' do
+ describe "#update" do
let(:params) do
{
id: role.id,
role: {
- name: 'A role name',
- permissions: ['add_work_packages', 'edit_work_packages', 'log_time', ''],
- assignable: '0'
+ name: "A role name",
+ permissions: ["add_work_packages", "edit_work_packages", "log_time", ""],
+ assignable: "0"
}
}
end
let(:role) do
- double('role double', id: 6).tap do |d|
+ double("role double", id: 6).tap do |d|
allow(Role)
.to receive(:find)
.with(d.id.to_s)
@@ -172,7 +172,7 @@
cp
end
let(:update_service) do
- service_double = double('update service')
+ service_double = double("update service")
expect(Roles::UpdateService)
.to receive(:new)
@@ -191,60 +191,60 @@
put :update, params:
end
- context 'success' do
- it 'redirects to roles#index' do
+ context "success" do
+ it "redirects to roles#index" do
expect(response)
.to redirect_to(roles_path)
end
- it 'has a flash message' do
+ it "has a flash message" do
expect(flash[:notice])
.to eql I18n.t(:notice_successful_update)
end
end
- context 'failure' do
+ context "failure" do
let(:service_call) { ServiceResult.failure(result: role) }
- it 'returns a 200 OK' do
+ it "returns a 200 OK" do
expect(response)
.to have_http_status(:ok)
end
- it 'renders the edit template' do
+ it "renders the edit template" do
expect(response)
- .to render_template('roles/edit')
+ .to render_template("roles/edit")
end
- it 'has the service call assigned' do
+ it "has the service call assigned" do
expect(assigns[:call])
.to eql service_call
end
- it 'has the role assigned' do
+ it "has the role assigned" do
expect(assigns[:role])
.to eql role
end
end
end
- describe '#bulk_update' do
+ describe "#bulk_update" do
let(:params) do
{
- permissions: { '0' => '', '1' => ['edit_work_packages'], '3' => %w(add_work_packages delete_work_packages) }
+ permissions: { "0" => "", "1" => ["edit_work_packages"], "3" => %w(add_work_packages delete_work_packages) }
}
end
let(:role0) do
- double('role double', id: 0)
+ double("role double", id: 0)
end
let(:role1) do
- double('role double', id: 1)
+ double("role double", id: 1)
end
let(:role2) do
- double('role double', id: 2)
+ double("role double", id: 2)
end
let(:role3) do
- double('role double', id: 3)
+ double("role double", id: 3)
end
let(:roles) do
[role0, role1, role2, role3]
@@ -264,7 +264,7 @@
{ permissions: [] }
end
let(:update_service0) do
- service_double = double('update service')
+ service_double = double("update service")
expect(Roles::UpdateService)
.to receive(:new)
@@ -277,10 +277,10 @@
.and_return(service_call0)
end
let(:update_params1) do
- { permissions: params[:permissions]['1'] }
+ { permissions: params[:permissions]["1"] }
end
let(:update_service1) do
- service_double = double('update service')
+ service_double = double("update service")
expect(Roles::UpdateService)
.to receive(:new)
@@ -296,7 +296,7 @@
{ permissions: [] }
end
let(:update_service2) do
- service_double = double('update service')
+ service_double = double("update service")
expect(Roles::UpdateService)
.to receive(:new)
@@ -309,10 +309,10 @@
.and_return(service_call2)
end
let(:update_params3) do
- { permissions: params[:permissions]['3'] }
+ { permissions: params[:permissions]["3"] }
end
let(:update_service3) do
- service_double = double('update service')
+ service_double = double("update service")
expect(Roles::UpdateService)
.to receive(:new)
@@ -334,51 +334,51 @@
put :bulk_update, params:
end
- context 'success' do
- it 'redirects to roles#index' do
+ context "success" do
+ it "redirects to roles#index" do
expect(response)
.to redirect_to(roles_path)
end
- it 'has a flash message' do
+ it "has a flash message" do
expect(flash[:notice])
.to eql I18n.t(:notice_successful_update)
end
end
- context 'failure' do
+ context "failure" do
let(:service_call2) { ServiceResult.failure(result: role2) }
- it 'returns a 200 OK' do
+ it "returns a 200 OK" do
expect(response)
.to have_http_status(:ok)
end
- it 'renders the report template' do
+ it "renders the report template" do
expect(response)
- .to render_template('roles/report')
+ .to render_template("roles/report")
end
- it 'has the service call assigned' do
+ it "has the service call assigned" do
expect(assigns[:calls])
.to contain_exactly(service_call0, service_call1, service_call2, service_call3)
end
- it 'has the roles assigned' do
+ it "has the roles assigned" do
expect(assigns[:roles])
.to match_array roles
end
end
end
- describe '#destroy' do
+ describe "#destroy" do
let(:role) { create(:project_role) }
let(:params) { { id: role.id } }
subject { delete(:destroy, params:) }
- context 'with the role not in use' do
- it 'redirects and destroyes the role' do
+ context "with the role not in use" do
+ it "redirects and destroyes the role" do
allow_any_instance_of(Role).to receive(:permissions).and_return([:read_files])
role
expect(Role.count).to eq(1)
@@ -393,8 +393,8 @@
end
end
- context 'with the role in use' do
- it 'redirects with a flash error' do
+ context "with the role in use" do
+ it "redirects with a flash error" do
allow_any_instance_of(Role).to receive(:deletable?).and_return(false)
role
expect(Role.count).to eq(1)
@@ -410,7 +410,7 @@
end
end
- describe '#report' do
+ describe "#report" do
let!(:stub_roles_scope) do
allow(controller)
.to receive(:roles_scope)
@@ -424,22 +424,22 @@
delete :report
end
- it 'is successful' do
+ it "is successful" do
expect(response)
.to have_http_status :ok
end
- it 'renders the template' do
+ it "renders the template" do
expect(response)
.to render_template :report
end
- it 'assigns permissions' do
+ it "assigns permissions" do
expect(assigns(:permissions))
.to match OpenProject::AccessControl.permissions.reject(&:public?)
end
- it 'assigns roles' do
+ it "assigns roles" do
expect(assigns(:roles))
.to match roles
end
diff --git a/spec/controllers/search_controller_spec.rb b/spec/controllers/search_controller_spec.rb
index 84b81c44a538..a3623afb008e 100644
--- a/spec/controllers/search_controller_spec.rb
+++ b/spec/controllers/search_controller_spec.rb
@@ -26,22 +26,22 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe SearchController do
shared_let(:project) do
create(:project,
- name: 'eCookbook')
+ name: "eCookbook")
end
shared_let(:other_project) do
create(:project,
- name: 'Other project')
+ name: "Other project")
end
shared_let(:subproject) do
create(:project,
- name: 'Child project',
+ name: "Child project",
parent: project)
end
@@ -61,69 +61,69 @@
shared_let(:work_package_1) do
create(:work_package,
- subject: 'This is a test issue',
+ subject: "This is a test issue",
project:)
end
shared_let(:work_package_2) do
create(:work_package,
- subject: 'Issue test 2',
+ subject: "Issue test 2",
project:,
status: create(:closed_status))
end
shared_let(:work_package_3) do
create(:work_package,
- subject: 'Issue test 3',
+ subject: "Issue test 3",
project: subproject)
end
shared_let(:work_package_4) do
create(:work_package,
- subject: 'Issue test 4',
+ subject: "Issue test 4",
project: other_project)
end
- shared_examples_for 'successful search' do
+ shared_examples_for "successful search" do
it { expect(response).to be_successful }
- it { expect(response).to render_template('index') }
+ it { expect(response).to render_template("index") }
end
before { allow(User).to receive(:current).and_return user }
- describe 'project search' do
- context 'without a search parameter' do
+ describe "project search" do
+ context "without a search parameter" do
before { get :index }
- it_behaves_like 'successful search'
+ it_behaves_like "successful search"
end
- context 'search parameter' do
- context 'is a search string' do
+ context "search parameter" do
+ context "is a search string" do
before do
- get :index, params: { q: 'cook' }
+ get :index, params: { q: "cook" }
end
- it_behaves_like 'successful search'
+ it_behaves_like "successful search"
end
end
end
- describe 'scoped project search' do
+ describe "scoped project search" do
before { get :index, params: { project_id: project.id } }
- it_behaves_like 'successful search'
+ it_behaves_like "successful search"
it { expect(assigns(:project).id).to be(project.id) }
end
- describe 'searching in all modules' do
- context 'when searching in all projects' do
- before { get :index, params: { q: 'issue', scope: 'all' } }
+ describe "searching in all modules" do
+ context "when searching in all projects" do
+ before { get :index, params: { q: "issue", scope: "all" } }
- it_behaves_like 'successful search'
+ it_behaves_like "successful search"
- describe '#result' do
+ describe "#result" do
it { expect(assigns(:results).count).to be(4) }
it { expect(assigns(:results)).to include(work_package_1) }
it { expect(assigns(:results)).to include(work_package_2) }
@@ -132,34 +132,34 @@
it { expect(assigns(:results)).not_to include(work_package_4) }
end
- describe '#results_count' do
+ describe "#results_count" do
it { expect(assigns(:results_count)).to be_a(Hash) }
- it { expect(assigns(:results_count)['work_packages']).to be(3) }
+ it { expect(assigns(:results_count)["work_packages"]).to be(3) }
end
end
- context 'when searching in all projects with an untransliterable character' do
+ context "when searching in all projects with an untransliterable character" do
before do
- work_package_1.update_column(:subject, 'Something 会议 something')
- get :index, params: { q: '会议', scope: 'all' }
+ work_package_1.update_column(:subject, "Something 会议 something")
+ get :index, params: { q: "会议", scope: "all" }
end
- it_behaves_like 'successful search'
+ it_behaves_like "successful search"
- it 'returns the result', :aggregate_failures do
+ it "returns the result", :aggregate_failures do
expect(assigns(:results).count).to be(1)
expect(assigns(:results)).to include(work_package_1)
expect(assigns(:results_count)).to be_a(Hash)
- expect(assigns(:results_count)['work_packages']).to be(1)
+ expect(assigns(:results_count)["work_packages"]).to be(1)
end
end
- context 'when searching in project and its subprojects' do
- before { get :index, params: { q: 'issue', project_id: project.id, scope: 'subprojects' } }
+ context "when searching in project and its subprojects" do
+ before { get :index, params: { q: "issue", project_id: project.id, scope: "subprojects" } }
- it_behaves_like 'successful search'
+ it_behaves_like "successful search"
- describe '#result' do
+ describe "#result" do
it { expect(assigns(:results).count).to be(4) }
it { expect(assigns(:results)).to include(work_package_1) }
it { expect(assigns(:results)).to include(work_package_2) }
@@ -169,12 +169,12 @@
end
end
- context 'when searching in project without its subprojects' do
- before { get :index, params: { q: 'issue', project_id: project.id, scope: 'current_project' } }
+ context "when searching in project without its subprojects" do
+ before { get :index, params: { q: "issue", project_id: project.id, scope: "current_project" } }
- it_behaves_like 'successful search'
+ it_behaves_like "successful search"
- describe '#result' do
+ describe "#result" do
it { expect(assigns(:results).count).to be(3) }
it { expect(assigns(:results)).to include(work_package_1) }
it { expect(assigns(:results)).to include(work_package_2) }
@@ -184,25 +184,25 @@
end
end
- context 'when searching for a note' do
+ context "when searching for a note" do
let!(:note_1) do
create(:work_package_journal,
journable_id: work_package_1.id,
- notes: 'Test note 1',
+ notes: "Test note 1",
version: 2)
end
let!(:note_2) do
create(:work_package_journal,
journable_id: work_package_1.id,
- notes: 'Special note 2',
+ notes: "Special note 2",
version: 3)
end
before do
- get :index, params: { q: 'note' }
+ get :index, params: { q: "note" }
end
- describe 'second note predecessor' do
+ describe "second note predecessor" do
subject { note_2.send :predecessor }
it { is_expected.to eq note_1 }
@@ -210,43 +210,43 @@
it { expect(subject.data).not_to be_nil }
end
- it_behaves_like 'successful search'
+ it_behaves_like "successful search"
- describe '#result' do
+ describe "#result" do
it { expect(assigns(:results).count).to be 1 }
it { expect(assigns(:results)).to include work_package_1 }
- it { expect(assigns(:tokens)).to include 'note' }
+ it { expect(assigns(:tokens)).to include "note" }
end
end
end
- describe 'helper methods' do
- describe '#scan_query_tokens' do
+ describe "helper methods" do
+ describe "#scan_query_tokens" do
subject { @controller.send(:scan_query_tokens, query) }
- context 'with one token' do
- let(:query) { 'word' }
+ context "with one token" do
+ let(:query) { "word" }
it { is_expected.to eq %w(word) }
- context 'with double quotes' do
+ context "with double quotes" do
let(:query) { '"hello world"' }
- it { is_expected.to eq ['hello world'] }
+ it { is_expected.to eq ["hello world"] }
end
end
- context 'with multiple tokens' do
- let(:query) { 'hello world something-hyphenated' }
+ context "with multiple tokens" do
+ let(:query) { "hello world something-hyphenated" }
it { is_expected.to eq %w(hello world something-hyphenated) }
- context 'with double quotes' do
+ context "with double quotes" do
let(:query) { 'hello "fallen world" something-hyphenated' }
- it { is_expected.to eq ['hello', 'fallen world', 'something-hyphenated'] }
+ it { is_expected.to eq ["hello", "fallen world", "something-hyphenated"] }
end
end
end
diff --git a/spec/controllers/statuses_controller_spec.rb b/spec/controllers/statuses_controller_spec.rb
index 6b6b6667e424..ee13fa27b90e 100644
--- a/spec/controllers/statuses_controller_spec.rb
+++ b/spec/controllers/statuses_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe StatusesController do
shared_let(:user) { create(:admin) }
@@ -34,7 +34,7 @@
before { login_as(user) }
- shared_examples_for 'response' do
+ shared_examples_for "response" do
subject { response }
it { is_expected.to be_successful }
@@ -42,7 +42,7 @@
it { is_expected.to render_template(template) }
end
- shared_examples_for 'redirect' do
+ shared_examples_for "redirect" do
subject { response }
it { is_expected.to be_redirect }
@@ -50,45 +50,45 @@
it { is_expected.to redirect_to(action: :index) }
end
- shared_examples_for 'statuses' do
+ shared_examples_for "statuses" do
subject { Status.find_by(name:) }
it { is_expected.not_to be_nil }
end
- describe '#index' do
- let(:template) { 'index' }
+ describe "#index" do
+ let(:template) { "index" }
before { get :index }
- it_behaves_like 'response'
+ it_behaves_like "response"
end
- describe '#new' do
- let(:template) { 'new' }
+ describe "#new" do
+ let(:template) { "new" }
before { get :new }
- it_behaves_like 'response'
+ it_behaves_like "response"
end
- describe '#create' do
- let(:name) { 'New Status' }
+ describe "#create" do
+ let(:name) { "New Status" }
before do
post :create,
params: { status: { name: } }
end
- it_behaves_like 'statuses'
+ it_behaves_like "statuses"
- it_behaves_like 'redirect'
+ it_behaves_like "redirect"
end
- describe '#edit' do
- let(:template) { 'edit' }
+ describe "#edit" do
+ let(:template) { "edit" }
- context 'default' do
+ context "default" do
let!(:status_default) do
create(:status,
is_default: true)
@@ -99,41 +99,41 @@
params: { id: status_default.id }
end
- it_behaves_like 'response'
+ it_behaves_like "response"
- describe '#view' do
+ describe "#view" do
render_views
it do
- assert_select 'p',
+ assert_select "p",
{ content: Status.human_attribute_name(:is_default) },
false
end
end
end
- context 'no_default' do
+ context "no_default" do
before do
status
get :edit, params: { id: status.id }
end
- it_behaves_like 'response'
+ it_behaves_like "response"
- describe '#view' do
+ describe "#view" do
render_views
it do
- assert_select 'div',
+ assert_select "div",
content: Status.human_attribute_name(:is_default)
end
end
end
end
- describe '#update' do
- let(:name) { 'Renamed Status' }
+ describe "#update" do
+ let(:name) { "Renamed Status" }
before do
status
@@ -145,21 +145,21 @@
}
end
- it_behaves_like 'statuses'
+ it_behaves_like "statuses"
- it_behaves_like 'redirect'
+ it_behaves_like "redirect"
end
- describe '#destroy' do
+ describe "#destroy" do
let(:name) { status.name }
- shared_examples_for 'destroyed' do
+ shared_examples_for "destroyed" do
subject { Status.find_by(name:) }
it { is_expected.to be_nil }
end
- context 'unused' do
+ context "unused" do
before do
delete :destroy, params: { id: status.id }
end
@@ -168,12 +168,12 @@
Status.delete_all
end
- it_behaves_like 'destroyed'
+ it_behaves_like "destroyed"
- it_behaves_like 'redirect'
+ it_behaves_like "redirect"
end
- context 'used' do
+ context "used" do
let(:work_package) do
create(:work_package,
status:)
@@ -185,12 +185,12 @@
delete :destroy, params: { id: status.id }
end
- it_behaves_like 'statuses'
+ it_behaves_like "statuses"
- it_behaves_like 'redirect'
+ it_behaves_like "redirect"
end
- context 'default' do
+ context "default" do
let!(:status_default) do
create(:status,
is_default: true)
@@ -200,39 +200,39 @@
delete :destroy, params: { id: status_default.id }
end
- it_behaves_like 'statuses'
+ it_behaves_like "statuses"
- it_behaves_like 'redirect'
+ it_behaves_like "redirect"
- it 'shows the right flash message' do
- expect(flash[:error]).to eq(I18n.t('error_unable_delete_default_status'))
+ it "shows the right flash message" do
+ expect(flash[:error]).to eq(I18n.t("error_unable_delete_default_status"))
end
end
end
- describe '#update_work_package_done_ratio' do
+ describe "#update_work_package_done_ratio" do
context "with 'work_package_done_ratio' using 'field'" do
before do
- allow(Setting).to receive(:work_package_done_ratio).and_return 'field'
+ allow(Setting).to receive(:work_package_done_ratio).and_return "field"
post :update_work_package_done_ratio
end
- it { is_expected.to set_flash[:error].to(I18n.t('error_work_package_done_ratios_not_updated')) }
+ it { is_expected.to set_flash[:error].to(I18n.t("error_work_package_done_ratios_not_updated")) }
- it_behaves_like 'redirect'
+ it_behaves_like "redirect"
end
context "with 'work_package_done_ratio' using 'status'" do
before do
- allow(Setting).to receive(:work_package_done_ratio).and_return 'status'
+ allow(Setting).to receive(:work_package_done_ratio).and_return "status"
post :update_work_package_done_ratio
end
- it { is_expected.to set_flash[:notice].to(I18n.t('notice_work_package_done_ratios_updated')) }
+ it { is_expected.to set_flash[:notice].to(I18n.t("notice_work_package_done_ratios_updated")) }
- it_behaves_like 'redirect'
+ it_behaves_like "redirect"
end
end
end
diff --git a/spec/controllers/sys_controller_spec.rb b/spec/controllers/sys_controller_spec.rb
index 47bbff6619eb..a9c8aeb003b4 100644
--- a/spec/controllers/sys_controller_spec.rb
+++ b/spec/controllers/sys_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe SysController, with_settings: { sys_api_enabled: true } do
let(:commit_role) do
@@ -34,15 +34,15 @@
end
let(:browse_role) { create(:project_role, permissions: [:browse_repository]) }
let(:guest_role) { create(:project_role, permissions: []) }
- let(:valid_user_password) { 'Top Secret Password' }
+ let(:valid_user_password) { "Top Secret Password" }
let(:valid_user) do
create(:user,
- login: 'johndoe',
+ login: "johndoe",
password: valid_user_password,
password_confirmation: valid_user_password)
end
- let(:api_key) { '12345678' }
+ let(:api_key) { "12345678" }
let(:public) { false }
let(:project) { create(:project, public:) }
@@ -61,132 +61,132 @@
RequestStore.clear!
end
- describe 'svn' do
+ describe "svn" do
let!(:repository) { create(:repository_subversion, project:) }
- describe 'repo_auth' do
- context 'for valid login, but no access to repo_auth' do
+ describe "repo_auth" do
+ context "for valid login, but no access to repo_auth" do
before do
- request.env['HTTP_AUTHORIZATION'] =
+ request.env["HTTP_AUTHORIZATION"] =
ActionController::HttpAuthentication::Basic.encode_credentials(
valid_user.login,
valid_user_password
)
- post 'repo_auth', params: { key: api_key,
- repository: 'without-access',
- method: 'GET' }
+ post "repo_auth", params: { key: api_key,
+ repository: "without-access",
+ method: "GET" }
end
- it 'responds 403 not allowed' do
- expect(response.code).to eq('403')
- expect(response.body).to eq('Not allowed')
+ it "responds 403 not allowed" do
+ expect(response.code).to eq("403")
+ expect(response.body).to eq("Not allowed")
end
end
- context 'for valid login and user has read permission (role reporter) for project' do
+ context "for valid login and user has read permission (role reporter) for project" do
before do
create(:member,
user: valid_user,
roles: [browse_role],
project:)
- request.env['HTTP_AUTHORIZATION'] =
+ request.env["HTTP_AUTHORIZATION"] =
ActionController::HttpAuthentication::Basic.encode_credentials(
valid_user.login,
valid_user_password
)
end
- it 'responds 200 okay dokay for GET' do
- post 'repo_auth', params: { key: api_key,
+ it "responds 200 okay dokay for GET" do
+ post "repo_auth", params: { key: api_key,
repository: project.identifier,
- method: 'GET' }
+ method: "GET" }
- expect(response.code).to eq('200')
+ expect(response.code).to eq("200")
end
- it 'responds 403 not allowed for POST' do
- post 'repo_auth', params: { key: api_key,
+ it "responds 403 not allowed for POST" do
+ post "repo_auth", params: { key: api_key,
repository: project.identifier,
- method: 'POST' }
+ method: "POST" }
- expect(response.code).to eq('403')
+ expect(response.code).to eq("403")
end
end
- context 'for valid login and user has rw permission (role developer) for project' do
+ context "for valid login and user has rw permission (role developer) for project" do
before do
create(:member,
user: valid_user,
roles: [commit_role],
project:)
valid_user.save
- request.env['HTTP_AUTHORIZATION'] =
+ request.env["HTTP_AUTHORIZATION"] =
ActionController::HttpAuthentication::Basic.encode_credentials(
valid_user.login,
valid_user_password
)
end
- it 'responds 200 okay dokay for GET' do
- post 'repo_auth', params: { key: api_key,
+ it "responds 200 okay dokay for GET" do
+ post "repo_auth", params: { key: api_key,
repository: project.identifier,
- method: 'GET' }
+ method: "GET" }
- expect(response.code).to eq('200')
+ expect(response.code).to eq("200")
end
- it 'responds 200 okay dokay for POST' do
- post 'repo_auth', params: { key: api_key,
+ it "responds 200 okay dokay for POST" do
+ post "repo_auth", params: { key: api_key,
repository: project.identifier,
- method: 'POST' }
+ method: "POST" }
- expect(response.code).to eq('200')
+ expect(response.code).to eq("200")
end
end
- context 'for invalid login and user has role manager for project' do
+ context "for invalid login and user has role manager for project" do
before do
create(:member,
user: valid_user,
roles: [commit_role],
project:)
- request.env['HTTP_AUTHORIZATION'] =
+ request.env["HTTP_AUTHORIZATION"] =
ActionController::HttpAuthentication::Basic.encode_credentials(
valid_user.login,
- valid_user_password + 'made invalid'
+ valid_user_password + "made invalid"
)
- post 'repo_auth', params: { key: api_key,
+ post "repo_auth", params: { key: api_key,
repository: project.identifier,
- method: 'GET' }
+ method: "GET" }
end
- it 'responds 401 auth required' do
- expect(response.code).to eq('401')
+ it "responds 401 auth required" do
+ expect(response.code).to eq("401")
end
end
- context 'for valid login and user is not member for project' do
+ context "for valid login and user is not member for project" do
before do
- request.env['HTTP_AUTHORIZATION'] =
+ request.env["HTTP_AUTHORIZATION"] =
ActionController::HttpAuthentication::Basic.encode_credentials(
valid_user.login,
valid_user_password
)
- post 'repo_auth', params: { key: api_key,
+ post "repo_auth", params: { key: api_key,
repository: project.identifier,
- method: 'GET' }
+ method: "GET" }
end
- it 'responds 403 not allowed' do
- expect(response.code).to eq('403')
+ it "responds 403 not allowed" do
+ expect(response.code).to eq("403")
end
end
- context 'for valid login and project is public' do
+ context "for valid login and project is public" do
let(:public) { true }
before do
@@ -196,134 +196,134 @@
roles: [browse_role],
project: random_project)
- request.env['HTTP_AUTHORIZATION'] =
+ request.env["HTTP_AUTHORIZATION"] =
ActionController::HttpAuthentication::Basic.encode_credentials(
valid_user.login,
valid_user_password
)
- post 'repo_auth', params: { key: api_key,
+ post "repo_auth", params: { key: api_key,
repository: project.identifier,
- method: 'GET' }
+ method: "GET" }
end
- it 'responds 200 OK' do
- expect(response.code).to eq('200')
+ it "responds 200 OK" do
+ expect(response.code).to eq("200")
end
end
- context 'for invalid credentials' do
+ context "for invalid credentials" do
before do
- post 'repo_auth', params: { key: api_key,
- repository: 'any-repo',
- method: 'GET' }
+ post "repo_auth", params: { key: api_key,
+ repository: "any-repo",
+ method: "GET" }
end
- it 'responds 401 auth required' do
- expect(response.code).to eq('401')
- expect(response.body).to eq('Authorization required')
+ it "responds 401 auth required" do
+ expect(response.code).to eq("401")
+ expect(response.body).to eq("Authorization required")
end
end
- context 'for invalid api key' do
- it 'responds 403 for valid username/password' do
- request.env['HTTP_AUTHORIZATION'] =
+ context "for invalid api key" do
+ it "responds 403 for valid username/password" do
+ request.env["HTTP_AUTHORIZATION"] =
ActionController::HttpAuthentication::Basic.encode_credentials(
valid_user.login,
valid_user_password
)
- post 'repo_auth', params: { key: 'not_the_api_key',
- repository: 'any-repo',
- method: 'GET' }
+ post "repo_auth", params: { key: "not_the_api_key",
+ repository: "any-repo",
+ method: "GET" }
- expect(response.code).to eq('403')
+ expect(response.code).to eq("403")
expect(response.body)
- .to eq('Access denied. Repository management WS is disabled or key is invalid.')
+ .to eq("Access denied. Repository management WS is disabled or key is invalid.")
end
- it 'responds 403 for invalid username/password' do
- request.env['HTTP_AUTHORIZATION'] =
+ it "responds 403 for invalid username/password" do
+ request.env["HTTP_AUTHORIZATION"] =
ActionController::HttpAuthentication::Basic.encode_credentials(
- 'invalid',
- 'invalid'
+ "invalid",
+ "invalid"
)
- post 'repo_auth', params: { key: 'not_the_api_key',
- repository: 'any-repo',
- method: 'GET' }
+ post "repo_auth", params: { key: "not_the_api_key",
+ repository: "any-repo",
+ method: "GET" }
- expect(response.code).to eq('403')
+ expect(response.code).to eq("403")
expect(response.body)
- .to eq('Access denied. Repository management WS is disabled or key is invalid.')
+ .to eq("Access denied. Repository management WS is disabled or key is invalid.")
end
end
end
end
- describe 'git' do
+ describe "git" do
let!(:repository) { create(:repository_git, project:) }
- describe 'repo_auth' do
- context 'for valid login, but no access to repo_auth' do
+ describe "repo_auth" do
+ context "for valid login, but no access to repo_auth" do
before do
- request.env['HTTP_AUTHORIZATION'] =
+ request.env["HTTP_AUTHORIZATION"] =
ActionController::HttpAuthentication::Basic.encode_credentials(
valid_user.login,
valid_user_password
)
- post 'repo_auth', params: { key: api_key,
- repository: 'without-access',
- method: 'GET',
- git_smart_http: '1',
- uri: '/git',
- location: '/git' }
+ post "repo_auth", params: { key: api_key,
+ repository: "without-access",
+ method: "GET",
+ git_smart_http: "1",
+ uri: "/git",
+ location: "/git" }
end
- it 'responds 403 not allowed' do
- expect(response.code).to eq('403')
- expect(response.body).to eq('Not allowed')
+ it "responds 403 not allowed" do
+ expect(response.code).to eq("403")
+ expect(response.body).to eq("Not allowed")
end
end
- context 'for valid login and user has read permission (role reporter) for project' do
+ context "for valid login and user has read permission (role reporter) for project" do
before do
create(:member,
user: valid_user,
roles: [browse_role],
project:)
- request.env['HTTP_AUTHORIZATION'] =
+ request.env["HTTP_AUTHORIZATION"] =
ActionController::HttpAuthentication::Basic.encode_credentials(
valid_user.login,
valid_user_password
)
end
- it 'responds 200 okay dokay for read-only access' do
- post 'repo_auth', params: { key: api_key,
+ it "responds 200 okay dokay for read-only access" do
+ post "repo_auth", params: { key: api_key,
repository: project.identifier,
- method: 'GET',
- git_smart_http: '1',
- uri: '/git',
- location: '/git' }
+ method: "GET",
+ git_smart_http: "1",
+ uri: "/git",
+ location: "/git" }
- expect(response.code).to eq('200')
+ expect(response.code).to eq("200")
end
- it 'responds 403 not allowed for write (push)' do
- post 'repo_auth', params: { key: api_key,
+ it "responds 403 not allowed for write (push)" do
+ post "repo_auth", params: { key: api_key,
repository: project.identifier,
- method: 'POST',
- git_smart_http: '1',
+ method: "POST",
+ git_smart_http: "1",
uri: "/git/#{project.identifier}/git-receive-pack",
- location: '/git' }
+ location: "/git" }
- expect(response.code).to eq('403')
+ expect(response.code).to eq("403")
end
end
- context 'for valid login and user has rw permission (role developer) for project' do
+ context "for valid login and user has rw permission (role developer) for project" do
before do
create(:member,
user: valid_user,
@@ -331,85 +331,85 @@
project:)
valid_user.save
- request.env['HTTP_AUTHORIZATION'] =
+ request.env["HTTP_AUTHORIZATION"] =
ActionController::HttpAuthentication::Basic.encode_credentials(
valid_user.login,
valid_user_password
)
end
- it 'responds 200 okay dokay for GET' do
- post 'repo_auth', params: { key: api_key,
+ it "responds 200 okay dokay for GET" do
+ post "repo_auth", params: { key: api_key,
repository: project.identifier,
- method: 'GET',
- git_smart_http: '1',
- uri: '/git',
- location: '/git' }
+ method: "GET",
+ git_smart_http: "1",
+ uri: "/git",
+ location: "/git" }
- expect(response.code).to eq('200')
+ expect(response.code).to eq("200")
end
- it 'responds 200 okay dokay for POST' do
- post 'repo_auth', params: { key: api_key,
+ it "responds 200 okay dokay for POST" do
+ post "repo_auth", params: { key: api_key,
repository: project.identifier,
- method: 'POST',
- git_smart_http: '1',
+ method: "POST",
+ git_smart_http: "1",
uri: "/git/#{project.identifier}/git-receive-pack",
- location: '/git' }
+ location: "/git" }
- expect(response.code).to eq('200')
+ expect(response.code).to eq("200")
end
end
- context 'for invalid login and user has role manager for project' do
+ context "for invalid login and user has role manager for project" do
before do
create(:member,
user: valid_user,
roles: [commit_role],
project:)
- request.env['HTTP_AUTHORIZATION'] =
+ request.env["HTTP_AUTHORIZATION"] =
ActionController::HttpAuthentication::Basic.encode_credentials(
valid_user.login,
- valid_user_password + 'made invalid'
+ valid_user_password + "made invalid"
)
- post 'repo_auth', params: { key: api_key,
+ post "repo_auth", params: { key: api_key,
repository: project.identifier,
- method: 'GET',
- git_smart_http: '1',
- uri: '/git',
- location: '/git' }
+ method: "GET",
+ git_smart_http: "1",
+ uri: "/git",
+ location: "/git" }
end
- it 'responds 401 auth required' do
- expect(response.code).to eq('401')
+ it "responds 401 auth required" do
+ expect(response.code).to eq("401")
end
end
- context 'for valid login and user is not member for project' do
+ context "for valid login and user is not member for project" do
before do
project = create(:project, public: false)
- request.env['HTTP_AUTHORIZATION'] =
+ request.env["HTTP_AUTHORIZATION"] =
ActionController::HttpAuthentication::Basic.encode_credentials(
valid_user.login,
valid_user_password
)
- post 'repo_auth', params: { key: api_key,
+ post "repo_auth", params: { key: api_key,
repository: project.identifier,
- method: 'GET',
- git_smart_http: '1',
- uri: '/git',
- location: '/git' }
+ method: "GET",
+ git_smart_http: "1",
+ uri: "/git",
+ location: "/git" }
end
- it 'responds 403 not allowed' do
- expect(response.code).to eq('403')
+ it "responds 403 not allowed" do
+ expect(response.code).to eq("403")
end
end
- context 'for valid login and project is public' do
+ context "for valid login and project is public" do
let(:public) { true }
before do
@@ -419,117 +419,117 @@
roles: [browse_role],
project: random_project)
- request.env['HTTP_AUTHORIZATION'] =
+ request.env["HTTP_AUTHORIZATION"] =
ActionController::HttpAuthentication::Basic.encode_credentials(
valid_user.login,
valid_user_password
)
- post 'repo_auth', params: { key: api_key,
+ post "repo_auth", params: { key: api_key,
repository: project.identifier,
- method: 'GET',
- git_smart_http: '1',
- uri: '/git',
- location: '/git' }
+ method: "GET",
+ git_smart_http: "1",
+ uri: "/git",
+ location: "/git" }
end
- it 'responds 200 OK' do
- expect(response.code).to eq('200')
+ it "responds 200 OK" do
+ expect(response.code).to eq("200")
end
end
- context 'for invalid credentials' do
+ context "for invalid credentials" do
before do
- post 'repo_auth', params: { key: api_key,
- repository: 'any-repo',
- method: 'GET',
- git_smart_http: '1',
- uri: '/git',
- location: '/git' }
+ post "repo_auth", params: { key: api_key,
+ repository: "any-repo",
+ method: "GET",
+ git_smart_http: "1",
+ uri: "/git",
+ location: "/git" }
end
- it 'responds 401 auth required' do
- expect(response.code).to eq('401')
- expect(response.body).to eq('Authorization required')
+ it "responds 401 auth required" do
+ expect(response.code).to eq("401")
+ expect(response.body).to eq("Authorization required")
end
end
- context 'for invalid api key' do
- it 'responds 403 for valid username/password' do
- request.env['HTTP_AUTHORIZATION'] =
+ context "for invalid api key" do
+ it "responds 403 for valid username/password" do
+ request.env["HTTP_AUTHORIZATION"] =
ActionController::HttpAuthentication::Basic.encode_credentials(
valid_user.login,
valid_user_password
)
- post 'repo_auth', params: { key: 'not_the_api_key',
- repository: 'any-repo',
- method: 'GET',
- git_smart_http: '1',
- uri: '/git',
- location: '/git' }
+ post "repo_auth", params: { key: "not_the_api_key",
+ repository: "any-repo",
+ method: "GET",
+ git_smart_http: "1",
+ uri: "/git",
+ location: "/git" }
- expect(response.code).to eq('403')
+ expect(response.code).to eq("403")
expect(response.body)
- .to eq('Access denied. Repository management WS is disabled or key is invalid.')
+ .to eq("Access denied. Repository management WS is disabled or key is invalid.")
end
- it 'responds 403 for invalid username/password' do
- request.env['HTTP_AUTHORIZATION'] =
+ it "responds 403 for invalid username/password" do
+ request.env["HTTP_AUTHORIZATION"] =
ActionController::HttpAuthentication::Basic.encode_credentials(
- 'invalid',
- 'invalid'
+ "invalid",
+ "invalid"
)
- post 'repo_auth', params: { key: 'not_the_api_key',
- repository: 'any-repo',
- method: 'GET',
- git_smart_http: '1',
- uri: '/git',
- location: '/git' }
+ post "repo_auth", params: { key: "not_the_api_key",
+ repository: "any-repo",
+ method: "GET",
+ git_smart_http: "1",
+ uri: "/git",
+ location: "/git" }
- expect(response.code).to eq('403')
+ expect(response.code).to eq("403")
expect(response.body)
- .to eq('Access denied. Repository management WS is disabled or key is invalid.')
+ .to eq("Access denied. Repository management WS is disabled or key is invalid.")
end
end
end
end
- describe '#cached_user_login' do
+ describe "#cached_user_login" do
let(:cache_key) do
OpenProject::RepositoryAuthentication::CACHE_PREFIX +
Digest::SHA1.hexdigest("#{valid_user.login}#{valid_user_password}")
end
let(:cache_expiry) { OpenProject::RepositoryAuthentication::CACHE_EXPIRES_AFTER }
- it 'calls user_login only once when called twice' do
+ it "calls user_login only once when called twice" do
expect(controller).to receive(:user_login).once.and_return(valid_user)
2.times { controller.send(:cached_user_login, valid_user.login, valid_user_password) }
end
- it 'returns the same as user_login for valid creds' do
+ it "returns the same as user_login for valid creds" do
expect(controller.send(:cached_user_login, valid_user.login, valid_user_password))
.to eq(controller.send(:user_login, valid_user.login, valid_user_password))
end
- it 'returns the same as user_login for invalid creds' do
- expect(controller.send(:cached_user_login, 'invalid', 'invalid'))
- .to eq(controller.send(:user_login, 'invalid', 'invalid'))
+ it "returns the same as user_login for invalid creds" do
+ expect(controller.send(:cached_user_login, "invalid", "invalid"))
+ .to eq(controller.send(:user_login, "invalid", "invalid"))
end
- it 'uses cache' do
+ it "uses cache" do
allow(Rails.cache).to receive(:fetch).and_call_original
expect(Rails.cache).to receive(:fetch).with(cache_key, expires_in: cache_expiry)
.and_return(Marshal.dump(valid_user.id.to_s))
controller.send(:cached_user_login, valid_user.login, valid_user_password)
end
- describe 'with caching disabled' do
+ describe "with caching disabled" do
before do
allow(Setting).to receive(:repository_authentication_caching_enabled?).and_return(false)
end
- it 'does not use a cache' do
+ it "does not use a cache" do
allow(Rails.cache).to receive(:fetch).and_wrap_original do |m, *args, &block|
expect(args.first).not_to eq(cache_key)
m.call(*args, &block)
@@ -539,28 +539,28 @@
end
end
- describe 'update_required_storage' do
+ describe "update_required_storage" do
let(:force) { nil }
let(:apikey) { Setting.sys_api_key }
let(:last_updated) { nil }
def request_storage
- get 'update_required_storage', params: { key: apikey,
+ get "update_required_storage", params: { key: apikey,
id:,
force: }
end
- context 'missing project' do
+ context "missing project" do
let(:id) { 1234 }
- it 'returns 404' do
+ it "returns 404" do
request_storage
- expect(response.code).to eq('404')
- expect(response.body).to include('Could not find project #1234')
+ expect(response.code).to eq("404")
+ expect(response.body).to include("Could not find project #1234")
end
end
- context 'available project, but missing repository' do
+ context "available project, but missing repository" do
let(:project) { build_stubbed(:project) }
let(:id) { project.id }
@@ -569,13 +569,13 @@ def request_storage
request_storage
end
- it 'returns 404' do
- expect(response.code).to eq('404')
+ it "returns 404" do
+ expect(response.code).to eq("404")
expect(response.body).to include("Project ##{project.id} does not have a repository.")
end
end
- context 'stubbed repository' do
+ context "stubbed repository" do
let(:project) { build_stubbed(:project) }
let(:id) { project.id }
let(:repository) do
@@ -590,29 +590,29 @@ def request_storage
request_storage
end
- context 'local non-existing repository' do
- let(:root_url) { '/tmp/does/not/exist/svn/foo.svn' }
+ context "local non-existing repository" do
+ let(:root_url) { "/tmp/does/not/exist/svn/foo.svn" }
let(:url) { "file://#{root_url}" }
- it 'does not have storage available' do
+ it "does not have storage available" do
expect(repository.scm.storage_available?).to be false
- expect(response.code).to eq('400')
+ expect(response.code).to eq("400")
end
end
- context 'remote stubbed repository' do
- let(:root_url) { '' }
- let(:url) { 'https://foo.example.org/svn/bar' }
+ context "remote stubbed repository" do
+ let(:root_url) { "" }
+ let(:url) { "https://foo.example.org/svn/bar" }
- it 'has no storage available' do
+ it "has no storage available" do
request_storage
expect(repository.scm.storage_available?).to be false
- expect(response.code).to eq('400')
+ expect(response.code).to eq("400")
end
end
end
- context 'local existing repository' do
+ context "local existing repository" do
with_subversion_repository do |repo_dir|
let(:root_url) { repo_dir }
let(:url) { "file://#{root_url}" }
@@ -629,17 +629,17 @@ def request_storage
allow(repository).to receive(:storage_updated_at).and_return(last_updated)
end
- it 'has storage available' do
+ it "has storage available" do
expect(repository.scm.storage_available?).to be true
end
- context 'storage never updated before' do
- it 'updates the storage' do
+ context "storage never updated before" do
+ it "updates the storage" do
expect(repository.required_storage_bytes).to eq 0
request_storage
- expect(response.code).to eq('200')
- expect(response.body).to include('Updated: true')
+ expect(response.code).to eq("200")
+ expect(response.body).to include("Updated: true")
perform_enqueued_jobs
@@ -648,29 +648,29 @@ def request_storage
end
end
- context 'outdated storage' do
+ context "outdated storage" do
let(:last_updated) { 2.days.ago }
- it 'updates the storage' do
+ it "updates the storage" do
expect(SCM::StorageUpdaterJob).to receive(:perform_later)
request_storage
end
end
- context 'valid storage time' do
+ context "valid storage time" do
let(:last_updated) { 10.minutes.ago }
- it 'does not update to storage' do
+ it "does not update to storage" do
expect(SCM::StorageUpdaterJob).not_to receive(:perform_later)
request_storage
end
end
- context 'valid storage time and force' do
- let(:force) { '1' }
+ context "valid storage time and force" do
+ let(:force) { "1" }
let(:last_updated) { 10.minutes.ago }
- it 'does update to storage' do
+ it "does update to storage" do
expect(SCM::StorageUpdaterJob).to receive(:perform_later)
request_storage
end
@@ -680,43 +680,43 @@ def request_storage
end
end
- describe '#projects' do
+ describe "#projects" do
before do
- request.env['HTTP_AUTHORIZATION'] =
+ request.env["HTTP_AUTHORIZATION"] =
ActionController::HttpAuthentication::Basic.encode_credentials(
valid_user.login,
valid_user_password
)
- get 'projects', params: { key: api_key }
+ get "projects", params: { key: api_key }
end
- it 'is successful' do
+ it "is successful" do
expect(response)
.to have_http_status(:ok)
end
- it 'returns an xml with the projects having a repository' do
+ it "returns an xml with the projects having a repository" do
expect(response.content_type)
- .to eql 'application/xml; charset=utf-8'
+ .to eql "application/xml; charset=utf-8"
- expect(Nokogiri::XML::Document.parse(response.body).xpath('//projects[1]//id').text)
+ expect(Nokogiri::XML::Document.parse(response.body).xpath("//projects[1]//id").text)
.to eql repository_project.id.to_s
end
- context 'when disabled', with_settings: { sys_api_enabled?: false } do
- it 'is 403 forbidden' do
+ context "when disabled", with_settings: { sys_api_enabled?: false } do
+ it "is 403 forbidden" do
expect(response)
.to have_http_status(:forbidden)
end
end
end
- describe '#fetch_changesets' do
+ describe "#fetch_changesets" do
let(:params) { { id: repository_project.identifier } }
before do
- request.env['HTTP_AUTHORIZATION'] =
+ request.env["HTTP_AUTHORIZATION"] =
ActionController::HttpAuthentication::Basic.encode_credentials(
valid_user.login,
valid_user_password
@@ -724,36 +724,36 @@ def request_storage
allow_any_instance_of(Repository::Subversion).to receive(:fetch_changesets).and_return(true)
- get 'fetch_changesets', params: params.merge({ key: api_key })
+ get "fetch_changesets", params: params.merge({ key: api_key })
end
- context 'with a project identifier' do
- it 'is successful' do
+ context "with a project identifier" do
+ it "is successful" do
expect(response)
.to have_http_status(:ok)
end
end
- context 'without a project identifier' do
+ context "without a project identifier" do
let(:params) { {} }
- it 'is successful' do
+ it "is successful" do
expect(response)
.to have_http_status(:ok)
end
end
- context 'for an unknown project' do
+ context "for an unknown project" do
let(:params) { { id: 0 } }
- it 'returns 404' do
+ it "returns 404" do
expect(response)
.to have_http_status(:not_found)
end
end
- context 'when disabled', with_settings: { sys_api_enabled?: false } do
- it 'is 403 forbidden' do
+ context "when disabled", with_settings: { sys_api_enabled?: false } do
+ it "is 403 forbidden" do
expect(response)
.to have_http_status(:forbidden)
end
diff --git a/spec/controllers/types_controller_spec.rb b/spec/controllers/types_controller_spec.rb
index 89121aae9f30..88e8a5f7e736 100644
--- a/spec/controllers/types_controller_spec.rb
+++ b/spec/controllers/types_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe TypesController do
let(:project) do
@@ -35,105 +35,105 @@
end
let(:custom_field_1) do
create(:work_package_custom_field,
- field_format: 'string',
+ field_format: "string",
is_for_all: true)
end
let(:custom_field_2) { create(:work_package_custom_field) }
let(:status_0) { create(:status) }
let(:status_1) { create(:status) }
- context 'with an unauthorized account' do
+ context "with an unauthorized account" do
let(:current_user) { create(:user) }
before do
allow(User).to receive(:current).and_return(current_user)
end
- describe 'GET index' do
- describe 'the access should be restricted' do
- before { get 'index' }
+ describe "GET index" do
+ describe "the access should be restricted" do
+ before { get "index" }
it { expect(response.status).to eq(403) }
end
end
- describe 'GET new' do
- describe 'the access should be restricted' do
- before { get 'new' }
+ describe "GET new" do
+ describe "the access should be restricted" do
+ before { get "new" }
it { expect(response.status).to eq(403) }
end
end
- describe 'GET edit' do
- describe 'the access should be restricted' do
- before { get 'edit', params: { id: '123' } }
+ describe "GET edit" do
+ describe "the access should be restricted" do
+ before { get "edit", params: { id: "123" } }
it { expect(response.status).to eq(403) }
end
end
- describe 'POST create' do
- describe 'the access should be restricted' do
- before { post 'create' }
+ describe "POST create" do
+ describe "the access should be restricted" do
+ before { post "create" }
it { expect(response.status).to eq(403) }
end
end
- describe 'DELETE destroy' do
- describe 'the access should be restricted' do
- before { delete 'destroy', params: { id: '123' } }
+ describe "DELETE destroy" do
+ describe "the access should be restricted" do
+ before { delete "destroy", params: { id: "123" } }
it { expect(response.status).to eq(403) }
end
end
- describe 'POST update' do
- describe 'the access should be restricted' do
- before { post 'update', params: { id: '123' } }
+ describe "POST update" do
+ describe "the access should be restricted" do
+ before { post "update", params: { id: "123" } }
it { expect(response.status).to eq(403) }
end
end
- describe 'POST move' do
- describe 'the access should be restricted' do
- before { post 'move', params: { id: '123' } }
+ describe "POST move" do
+ describe "the access should be restricted" do
+ before { post "move", params: { id: "123" } }
it { expect(response.status).to eq(403) }
end
end
end
- context 'with an authorized account' do
+ context "with an authorized account" do
let(:current_user) { create(:admin) }
before do
allow(User).to receive(:current).and_return(current_user)
end
- describe 'GET index' do
- before { get 'index' }
+ describe "GET index" do
+ before { get "index" }
it { expect(response).to be_successful }
- it { expect(response).to render_template 'index' }
+ it { expect(response).to render_template "index" }
end
- describe 'GET new' do
- before { get 'new' }
+ describe "GET new" do
+ before { get "new" }
it { expect(response).to be_successful }
- it { expect(response).to render_template 'new' }
+ it { expect(response).to render_template "new" }
end
- describe 'POST create' do
- describe 'WITH valid params' do
+ describe "POST create" do
+ describe "WITH valid params" do
let(:params) do
- { 'type' => { name: 'New type',
- project_ids: { '1' => project.id },
- custom_field_ids: { '1' => custom_field_1.id,
- '2' => custom_field_2.id } } }
+ { "type" => { name: "New type",
+ project_ids: { "1" => project.id },
+ custom_field_ids: { "1" => custom_field_1.id,
+ "2" => custom_field_2.id } } }
end
before do
@@ -143,18 +143,18 @@
it { expect(response).to be_redirect }
it do
- type = Type.find_by(name: 'New type')
- expect(response).to redirect_to(action: 'edit', tab: 'settings', id: type.id)
+ type = Type.find_by(name: "New type")
+ expect(response).to redirect_to(action: "edit", tab: "settings", id: type.id)
end
end
- describe 'WITH an empty name' do
+ describe "WITH an empty name" do
render_views
let(:params) do
- { 'type' => { name: '',
- project_ids: { '1' => project.id },
- custom_field_ids: { '1' => custom_field_1.id,
- '2' => custom_field_2.id } } }
+ { "type" => { name: "",
+ project_ids: { "1" => project.id },
+ custom_field_ids: { "1" => custom_field_1.id,
+ "2" => custom_field_2.id } } }
end
before do
@@ -163,13 +163,13 @@
it { expect(response.status).to eq(200) }
- it 'shows an error message' do
+ it "shows an error message" do
expect(response.body).to have_content("Name can't be blank")
end
end
- describe 'WITH workflow copy' do
- let!(:existing_type) { create(:type, name: 'Existing type') }
+ describe "WITH workflow copy" do
+ let!(:existing_type) { create(:type, name: "Existing type") }
let!(:workflow) do
create(:workflow,
old_status: status_0,
@@ -178,10 +178,10 @@
end
let(:params) do
- { 'type' => { name: 'New type',
- project_ids: { '1' => project.id },
- custom_field_ids: { '1' => custom_field_1.id, '2' => custom_field_2.id } },
- 'copy_workflow_from' => existing_type.id }
+ { "type" => { name: "New type",
+ project_ids: { "1" => project.id },
+ custom_field_ids: { "1" => custom_field_1.id, "2" => custom_field_2.id } },
+ "copy_workflow_from" => existing_type.id }
end
before do
@@ -191,70 +191,70 @@
it { expect(response).to be_redirect }
it do
- type = Type.find_by(name: 'New type')
- expect(response).to redirect_to(action: 'edit', tab: 'settings', id: type.id)
+ type = Type.find_by(name: "New type")
+ expect(response).to redirect_to(action: "edit", tab: "settings", id: type.id)
end
- it 'has the copied workflows' do
- expect(Type.find_by(name: 'New type')
+ it "has the copied workflows" do
+ expect(Type.find_by(name: "New type")
.workflows.count).to eq(existing_type.workflows.count)
end
end
end
- describe 'GET edit settings' do
+ describe "GET edit settings" do
render_views
let(:type) do
- create(:type, name: 'My type',
+ create(:type, name: "My type",
is_milestone: true,
projects: [project])
end
before do
- get 'edit', params: { id: type.id, tab: :settings }
+ get "edit", params: { id: type.id, tab: :settings }
end
it { expect(response).to be_successful }
- it { expect(response).to render_template 'edit' }
- it { expect(response).to render_template 'types/form/_settings' }
+ it { expect(response).to render_template "edit" }
+ it { expect(response).to render_template "types/form/_settings" }
it { expect(response.body).to have_css "input[@name='type[name]'][@value='My type']" }
it { expect(response.body).to have_css "input[@name='type[is_milestone]'][@value='1'][@checked='checked']" }
end
- describe 'GET edit projects' do
+ describe "GET edit projects" do
render_views
let(:type) do
- create(:type, name: 'My type',
+ create(:type, name: "My type",
is_milestone: true,
projects: [project])
end
before do
- get 'edit', params: { id: type.id, tab: :projects }
+ get "edit", params: { id: type.id, tab: :projects }
end
it { expect(response).to be_successful }
- it { expect(response).to render_template 'edit' }
- it { expect(response).to render_template 'types/form/_projects' }
+ it { expect(response).to render_template "edit" }
+ it { expect(response).to render_template "types/form/_projects" }
it {
expect(response.body).to have_css "input[@name='type[project_ids][]'][@value='#{project.id}'][@checked='checked']"
}
end
- describe 'POST update' do
+ describe "POST update" do
let(:project2) { create(:project) }
let(:type) do
- create(:type, name: 'My type',
+ create(:type, name: "My type",
is_milestone: true,
projects: [project, project2])
end
- describe 'WITH type rename' do
+ describe "WITH type rename" do
let(:params) do
- { 'id' => type.id,
- 'type' => { name: 'My type renamed' },
- 'tab' => "settings" }
+ { "id" => type.id,
+ "type" => { name: "My type renamed" },
+ "tab" => "settings" }
end
before do
@@ -269,16 +269,16 @@
)
end
- it 'is renamed' do
- expect(Type.find_by(name: 'My type renamed').id).to eq(type.id)
+ it "is renamed" do
+ expect(Type.find_by(name: "My type renamed").id).to eq(type.id)
end
end
- describe 'WITH projects removed' do
+ describe "WITH projects removed" do
let(:params) do
- { 'id' => type.id,
- 'type' => { project_ids: [''] },
- 'tab' => "projects" }
+ { "id" => type.id,
+ "type" => { project_ids: [""] },
+ "tab" => "projects" }
end
before do
@@ -293,17 +293,17 @@
)
end
- it 'has no projects assigned' do
- expect(Type.find_by(name: 'My type').projects.count).to eq(0)
+ it "has no projects assigned" do
+ expect(Type.find_by(name: "My type").projects.count).to eq(0)
end
end
end
- describe 'POST move' do
- context 'with a successful update' do
- let!(:type) { create(:type, name: 'My type', position: '1') }
- let!(:type2) { create(:type, name: 'My type 2', position: '2') }
- let(:params) { { 'id' => type.id, 'type' => { move_to: 'lower' } } }
+ describe "POST move" do
+ context "with a successful update" do
+ let!(:type) { create(:type, name: "My type", position: "1") }
+ let!(:type2) { create(:type, name: "My type 2", position: "2") }
+ let(:params) { { "id" => type.id, "type" => { move_to: "lower" } } }
before do
post :move, params:
@@ -312,15 +312,15 @@
it { expect(response).to be_redirect }
it { expect(response).to redirect_to(types_path) }
- it 'has the position updated' do
- expect(Type.find_by(name: 'My type').position).to eq(2)
+ it "has the position updated" do
+ expect(Type.find_by(name: "My type").position).to eq(2)
end
end
- context 'with a failed update' do
- let!(:type) { create(:type, name: 'My type', position: '1') }
- let!(:type2) { create(:type, name: 'My type 2', position: '2') }
- let(:params) { { 'id' => type.id, 'type' => { move_to: 'lower' } } }
+ context "with a failed update" do
+ let!(:type) { create(:type, name: "My type", position: "1") }
+ let!(:type2) { create(:type, name: "My type 2", position: "2") }
+ let(:params) { { "id" => type.id, "type" => { move_to: "lower" } } }
before do
allow(Type).to receive(:find).and_return(type)
@@ -330,25 +330,25 @@
end
it { expect(response).not_to be_redirect }
- it { expect(response).to render_template('edit') }
+ it { expect(response).to render_template("edit") }
- it 'has an unsuccessful move flash' do
+ it "has an unsuccessful move flash" do
expect(flash[:error]).to eq(I18n.t(:error_type_could_not_be_saved))
end
it "doesn't update the position" do
- expect(Type.find_by(name: 'My type').position).to eq(1)
+ expect(Type.find_by(name: "My type").position).to eq(1)
end
end
end
- describe 'DELETE destroy' do
- let(:type) { create(:type, name: 'My type') }
- let(:type2) { create(:type, name: 'My type 2', projects: [project]) }
- let(:type3) { create(:type, name: 'My type 3', is_standard: true) }
+ describe "DELETE destroy" do
+ let(:type) { create(:type, name: "My type") }
+ let(:type2) { create(:type, name: "My type 2", projects: [project]) }
+ let(:type3) { create(:type, name: "My type 3", is_standard: true) }
- describe 'successful destroy' do
- let(:params) { { 'id' => type.id } }
+ describe "successful destroy" do
+ let(:params) { { "id" => type.id } }
before do
delete :destroy, params:
@@ -357,16 +357,16 @@
it { expect(response).to be_redirect }
it { expect(response).to redirect_to(types_path) }
- it 'has a successful destroy flash' do
+ it "has a successful destroy flash" do
expect(flash[:notice]).to eq(I18n.t(:notice_successful_delete))
end
- it 'is not present in the database' do
- expect(Type.find_by(name: 'My type')).to be_nil
+ it "is not present in the database" do
+ expect(Type.find_by(name: "My type")).to be_nil
end
end
- describe 'destroy type in use should fail' do
+ describe "destroy type in use should fail" do
let(:archived_project) do
create(:project,
:archived,
@@ -379,14 +379,14 @@
type: type2,
project: archived_project)
end
- let(:params) { { 'id' => type2.id } }
+ let(:params) { { "id" => type2.id } }
let(:error_message) do
archived_projects_urls = described_class
.helpers
.archived_projects_urls_for([archived_project])
[
- I18n.t(:'error_can_not_delete_type.explanation'),
+ I18n.t(:"error_can_not_delete_type.explanation"),
I18n.t(:error_can_not_delete_in_use_archived_work_packages, archived_projects_urls:)
]
end
@@ -398,17 +398,17 @@
it { expect(response).to be_redirect }
it { expect(response).to redirect_to(types_path) }
- it 'shows an error message' do
+ it "shows an error message" do
expect(sanitize_string(flash[:error])).to eq(sanitize_string(error_message))
end
- it 'is present in the database' do
- expect(Type.find_by(name: 'My type 2').id).to eq(type2.id)
+ it "is present in the database" do
+ expect(Type.find_by(name: "My type 2").id).to eq(type2.id)
end
end
- describe 'destroy standard type should fail' do
- let(:params) { { 'id' => type3.id } }
+ describe "destroy standard type should fail" do
+ let(:params) { { "id" => type3.id } }
before { delete :destroy, params: }
diff --git a/spec/controllers/users/memberships_controller_spec.rb b/spec/controllers/users/memberships_controller_spec.rb
index 8f43cff22f94..90e2ec87dd0b 100644
--- a/spec/controllers/users/memberships_controller_spec.rb
+++ b/spec/controllers/users/memberships_controller_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'work_package'
+require "spec_helper"
+require "work_package"
RSpec.describe Users::MembershipsController do
shared_let(:admin) { create(:admin) }
@@ -35,11 +35,11 @@
let(:user) { create(:user) }
let(:anonymous) { create(:anonymous) }
- describe 'update memberships' do
+ describe "update memberships" do
let(:project) { create(:project) }
let(:role) { create(:project_role) }
- it 'works' do
+ it "works" do
# i.e. it should successfully add a user to a project's members
as_logged_in_user admin do
post :create,
@@ -52,7 +52,7 @@
}
end
- expect(response).to redirect_to(controller: '/users', action: 'edit', id: user.id, tab: 'memberships')
+ expect(response).to redirect_to(controller: "/users", action: "edit", id: user.id, tab: "memberships")
is_member = user.reload.memberships.any? do |m|
m.project_id == project.id && m.role_ids.include?(role.id)
diff --git a/spec/controllers/users_controller_spec.rb b/spec/controllers/users_controller_spec.rb
index f211f357f61f..9c590f3b7aad 100644
--- a/spec/controllers/users_controller_spec.rb
+++ b/spec/controllers/users_controller_spec.rb
@@ -26,22 +26,22 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'work_package'
+require "spec_helper"
+require "work_package"
RSpec.describe UsersController do
shared_let(:admin) { create(:admin) }
shared_let(:anonymous) { User.anonymous }
- shared_let(:user_password) { 'bob!' * 4 }
+ shared_let(:user_password) { "bob!" * 4 }
shared_let(:user) do
create(:user,
- login: 'bob',
+ login: "bob",
password: user_password,
password_confirmation: user_password)
end
- describe 'GET new' do
+ describe "GET new" do
context "without user limit reached" do
before do
as_logged_in_user admin do
@@ -49,17 +49,17 @@
end
end
- it 'is success' do
+ it "is success" do
expect(response)
.to have_http_status(:ok)
end
- it 'renders the template' do
+ it "renders the template" do
expect(response)
- .to have_rendered('new')
+ .to have_rendered("new")
end
- it 'have a user object initialized' do
+ it "have a user object initialized" do
expect(assigns(:user))
.to be_a(User)
end
@@ -106,10 +106,10 @@
end
end
- describe 'GET deletion_info' do
- let(:params) { { 'id' => user.id.to_s } }
+ describe "GET deletion_info" do
+ let(:params) { { "id" => user.id.to_s } }
- context 'when the current user is the requested user' do
+ context "when the current user is the requested user" do
current_user { user }
context "when the setting users_deletable_by_self is set to true",
@@ -120,11 +120,11 @@
it { expect(response).to have_http_status(:success) }
- it 'assigns @user to requested user' do
+ it "assigns @user to requested user" do
expect(assigns(:user)).to eq(user)
end
- it { expect(response).to render_template('deletion_info') }
+ it { expect(response).to render_template("deletion_info") }
end
context "when the setting users_deletable_by_self is set to false",
@@ -137,7 +137,7 @@
end
end
- context 'when the current user is the anonymous user' do
+ context "when the current user is the anonymous user" do
current_user { anonymous }
before do
@@ -145,10 +145,10 @@
end
it {
- expect(response).to redirect_to(controller: 'account',
- action: 'login',
- back_url: controller.url_for(controller: 'users',
- action: 'deletion_info'))
+ expect(response).to redirect_to(controller: "account",
+ action: "login",
+ back_url: controller.url_for(controller: "users",
+ action: "deletion_info"))
}
end
@@ -163,11 +163,11 @@
it { expect(response).to have_http_status(:success) }
- it 'assigns @user to requested user' do
+ it "assigns @user to requested user" do
expect(assigns(:user)).to eq(user)
end
- it { expect(response).to render_template('deletion_info') }
+ it { expect(response).to render_template("deletion_info") }
end
context "when the setting users_deletable_by_admins is set to false",
@@ -181,10 +181,10 @@
end
end
- describe 'POST resend_invitation' do
+ describe "POST resend_invitation" do
let(:invited_user) { create(:invited_user) }
- context 'without admin rights' do
+ context "without admin rights" do
let(:normal_user) { create(:user) }
before do
@@ -193,12 +193,12 @@
end
end
- it 'returns 403 forbidden' do
+ it "returns 403 forbidden" do
expect(response.status).to eq 403
end
end
- context 'with admin rights' do
+ context "with admin rights" do
before do
expect(ActionMailer::Base.deliveries).to be_empty
@@ -209,51 +209,51 @@
end
end
- it 'redirects back to the edit user page' do
+ it "redirects back to the edit user page" do
expect(response).to redirect_to edit_user_path(invited_user)
end
- it 'sends another activation email' do
+ it "sends another activation email" do
mail = ActionMailer::Base.deliveries.first.body.parts.first.body.to_s
token = Token::Invitation.find_by user_id: invited_user.id
- expect(mail).to include 'activate your account'
+ expect(mail).to include "activate your account"
expect(mail).to include token.value
end
end
end
- describe 'GET edit' do
+ describe "GET edit" do
before do
as_logged_in_user admin do
get :edit, params: { id: user.id }
end
end
- it 'is success' do
+ it "is success" do
expect(response)
.to have_http_status(:ok)
end
- it 'renders the template' do
+ it "renders the template" do
expect(response)
- .to have_rendered('edit')
+ .to have_rendered("edit")
end
- it 'have a user object initialized' do
+ it "have a user object initialized" do
expect(assigns(:user))
.to eql user
end
end
- describe 'POST destroy' do
- let(:base_params) { { 'id' => user.id.to_s, back_url: my_account_path } }
+ describe "POST destroy" do
+ let(:base_params) { { "id" => user.id.to_s, back_url: my_account_path } }
before do
disable_flash_sweep
end
- context 'when the password confirmation is missing' do
+ context "when the password confirmation is missing" do
before do
allow(Setting).to receive(:users_deletable_by_self?).and_return(true)
@@ -263,18 +263,18 @@
end
it do
- expect(response).to redirect_to(controller: 'my', action: 'account')
+ expect(response).to redirect_to(controller: "my", action: "account")
end
it { expect(flash[:error]).to eq(I18n.t(:notice_password_confirmation_failed)) }
end
- context 'when password confirmation is present' do
+ context "when password confirmation is present" do
let(:params) do
base_params.merge(_password_confirmation: user_password)
end
- context 'when the current user is the requested one' do
+ context "when the current user is the requested one" do
current_user { user }
context "when the setting users_deletable_by_self is set to true",
@@ -284,13 +284,13 @@
end
it do
- expect(response).to redirect_to(controller: 'account', action: 'login')
+ expect(response).to redirect_to(controller: "account", action: "login")
end
- it { expect(flash[:notice]).to eq(I18n.t('account.deletion_pending')) }
+ it { expect(flash[:notice]).to eq(I18n.t("account.deletion_pending")) }
end
- context 'when the setting users_deletable_by_self is set to false',
+ context "when the setting users_deletable_by_self is set to false",
with_settings: { users_deletable_by_self: false } do
before do
post :destroy, params:
@@ -300,10 +300,10 @@
end
end
- context 'when the current user is the anonymous user' do
+ context "when the current user is the anonymous user" do
current_user { anonymous }
- context 'even when the setting login_required is set to false and users_deletable_by_self is set to true',
+ context "even when the setting login_required is set to false and users_deletable_by_self is set to true",
with_settings: { login_required: false, users_deletable_by_self: true } do
before do
post :destroy, params: params.merge(id: anonymous.id.to_s)
@@ -314,7 +314,7 @@
end
end
- context 'when the current user is the admin' do
+ context "when the current user is the admin" do
current_user { admin }
context "when the given password does NOT match and the setting users_deletable_by_admins is set to true",
@@ -323,8 +323,8 @@
post :destroy, params:
end
- it 'redirects with error' do
- expect(response).to redirect_to(controller: 'my', action: 'account')
+ it "redirects with error" do
+ expect(response).to redirect_to(controller: "my", action: "account")
expect(flash[:notice]).to be_nil
expect(flash[:error]).to eq(I18n.t(:notice_password_confirmation_failed))
end
@@ -333,14 +333,14 @@
context "when the given password does match and the setting users_deletable_by_admins is set to true",
with_settings: { users_deletable_by_admins: true } do
before do
- post :destroy, params: params.merge(_password_confirmation: 'adminADMIN!')
+ post :destroy, params: params.merge(_password_confirmation: "adminADMIN!")
end
it do
- expect(response).to redirect_to(controller: 'users', action: 'index')
+ expect(response).to redirect_to(controller: "users", action: "index")
end
- it { expect(flash[:notice]).to eq(I18n.t('account.deletion_pending')) }
+ it { expect(flash[:notice]).to eq(I18n.t("account.deletion_pending")) }
end
context "when the setting users_deletable_by_admins is set to false",
@@ -355,7 +355,7 @@
end
end
- describe '#change_status_info' do
+ describe "#change_status_info" do
let!(:registered_user) do
create(:user, status: User.statuses[:registered])
end
@@ -370,52 +370,52 @@
end
end
- shared_examples 'valid status info' do
- it 'renders the status info' do
+ shared_examples "valid status info" do
+ it "renders the status info" do
expect(response).to be_successful
- expect(response).to render_template 'users/change_status_info'
+ expect(response).to render_template "users/change_status_info"
expect(assigns(:user)).to eq(registered_user)
expect(assigns(:status_change)).to eq(change_action)
end
end
- describe 'with valid activate' do
+ describe "with valid activate" do
let(:change_action) { :activate }
- it_behaves_like 'valid status info'
+ it_behaves_like "valid status info"
end
- describe 'with valid unlock' do
+ describe "with valid unlock" do
let(:change_action) { :unlock }
- it_behaves_like 'valid status info'
+ it_behaves_like "valid status info"
end
- describe 'with valid lock' do
+ describe "with valid lock" do
let(:change_action) { :lock }
- it_behaves_like 'valid status info'
+ it_behaves_like "valid status info"
end
- describe 'bogus status' do
+ describe "bogus status" do
let(:change_action) { :wtf }
- it 'renders 400' do
+ it "renders 400" do
expect(response.status).to eq(400)
- expect(response).not_to render_template 'users/change_status_info'
+ expect(response).not_to render_template "users/change_status_info"
end
end
end
- describe '#change_status',
+ describe "#change_status",
with_settings: {
available_languages: %w[en de],
bcc_recipients: 1
} do
- describe 'WHEN activating a registered user' do
+ describe "WHEN activating a registered user" do
let!(:registered_user) do
create(:user, status: User.statuses[:registered],
- language: 'de')
+ language: "de")
end
let(:user_limit_reached) { false }
@@ -428,22 +428,22 @@
params: {
id: registered_user.id,
user: { status: User.statuses[:active] },
- activate: '1'
+ activate: "1"
}
end
end
- it 'activates the user' do
+ it "activates the user" do
assert registered_user.reload.active?
end
- it 'sends an email to the correct user in the correct language' do
+ it "sends an email to the correct user in the correct language" do
perform_enqueued_jobs
mail = ActionMailer::Base.deliveries.last
expect(mail).not_to be_nil
expect([registered_user.mail]).to eq(mail.to)
mail.parts.each do |part|
- expect(part.body.encoded).to include(I18n.t(:notice_account_activated, locale: 'de'))
+ expect(part.body.encoded).to include(I18n.t(:notice_account_activated, locale: "de"))
end
end
@@ -461,7 +461,7 @@
end
end
- describe 'GET #index' do
+ describe "GET #index" do
let(:params) { {} }
before do
@@ -470,45 +470,45 @@
end
end
- it 'to be success' do
+ it "to be success" do
expect(response)
.to have_http_status(:ok)
end
- it 'renders the index' do
+ it "renders the index" do
expect(response)
- .to have_rendered('index')
+ .to have_rendered("index")
end
- it 'assigns users' do
+ it "assigns users" do
expect(assigns(:users))
.to contain_exactly(user, admin)
end
- context 'with a name filter' do
+ context "with a name filter" do
let(:params) { { name: user.firstname } }
- it 'assigns users' do
+ it "assigns users" do
expect(assigns(:users))
.to contain_exactly(user)
end
end
- context 'with a group filter' do
+ context "with a group filter" do
let(:group) { create(:group, members: [user]) }
let(:params) do
{ group_id: group.id }
end
- it 'assigns users' do
+ it "assigns users" do
expect(assigns(:users))
.to contain_exactly(user)
end
end
end
- describe 'session lifetime' do
+ describe "session lifetime" do
# TODO move this section to a proper place because we test a
# before_action from the application controller
@@ -517,120 +517,120 @@
User.current = nil
end
- shared_examples_for 'index action with disabled session lifetime or inactivity not exceeded' do
+ shared_examples_for "index action with disabled session lifetime or inactivity not exceeded" do
it "doesn't logout the user and renders the index action" do
expect(User.current).to eq(admin)
- expect(response).to render_template 'index'
+ expect(response).to render_template "index"
end
end
- shared_examples_for 'index action with enabled session lifetime and inactivity exceeded' do
- it 'logs out the user and redirects with a warning that he has been locked out' do
- expect(response.redirect_url).to eq(signin_url + '?back_url=' + CGI::escape(@controller.url_for(controller: 'users',
- action: 'index')))
+ shared_examples_for "index action with enabled session lifetime and inactivity exceeded" do
+ it "logs out the user and redirects with a warning that he has been locked out" do
+ expect(response.redirect_url).to eq(signin_url + "?back_url=" + CGI::escape(@controller.url_for(controller: "users",
+ action: "index")))
expect(User.current).not_to eq(admin)
expect(flash[:warning]).to eq(I18n.t(:notice_forced_logout, ttl_time: Setting.session_ttl))
end
end
- context 'disabled' do
+ context "disabled" do
before do
allow(Setting).to receive(:session_ttl_enabled?).and_return(false)
@controller.send(:logged_user=, admin)
get :index
end
- it_behaves_like 'index action with disabled session lifetime or inactivity not exceeded'
+ it_behaves_like "index action with disabled session lifetime or inactivity not exceeded"
end
- context 'enabled' do
+ context "enabled" do
before do
allow(Setting).to receive(:session_ttl_enabled?).and_return(true)
- allow(Setting).to receive(:session_ttl).and_return('120')
+ allow(Setting).to receive(:session_ttl).and_return("120")
@controller.send(:logged_user=, admin)
end
- context 'before 120 min of inactivity' do
+ context "before 120 min of inactivity" do
before do
session[:updated_at] = Time.now - 1.hour
get :index
end
- it_behaves_like 'index action with disabled session lifetime or inactivity not exceeded'
+ it_behaves_like "index action with disabled session lifetime or inactivity not exceeded"
end
- context 'after 120 min of inactivity' do
+ context "after 120 min of inactivity" do
before do
session[:updated_at] = Time.now - 3.hours
get :index
end
- it_behaves_like 'index action with enabled session lifetime and inactivity exceeded'
+ it_behaves_like "index action with enabled session lifetime and inactivity exceeded"
end
- context 'without last activity time in the session' do
+ context "without last activity time in the session" do
before do
- allow(Setting).to receive(:session_ttl).and_return('60')
+ allow(Setting).to receive(:session_ttl).and_return("60")
session[:updated_at] = nil
get :index
end
- it_behaves_like 'index action with enabled session lifetime and inactivity exceeded'
+ it_behaves_like "index action with enabled session lifetime and inactivity exceeded"
end
- context 'with ttl = 0' do
+ context "with ttl = 0" do
before do
- allow(Setting).to receive(:session_ttl).and_return('0')
+ allow(Setting).to receive(:session_ttl).and_return("0")
session[:updated_at] = Time.now - 1.hour
get :index
end
- it_behaves_like 'index action with disabled session lifetime or inactivity not exceeded'
+ it_behaves_like "index action with disabled session lifetime or inactivity not exceeded"
end
- context 'with ttl < 0' do
+ context "with ttl < 0" do
before do
- allow(Setting).to receive(:session_ttl).and_return('-60')
+ allow(Setting).to receive(:session_ttl).and_return("-60")
session[:updated_at] = Time.now - 1.hour
get :index
end
- it_behaves_like 'index action with disabled session lifetime or inactivity not exceeded'
+ it_behaves_like "index action with disabled session lifetime or inactivity not exceeded"
end
- context 'with ttl < 5 > 0' do
+ context "with ttl < 5 > 0" do
before do
- allow(Setting).to receive(:session_ttl).and_return('4')
+ allow(Setting).to receive(:session_ttl).and_return("4")
session[:updated_at] = Time.now - 1.hour
get :index
end
- it_behaves_like 'index action with disabled session lifetime or inactivity not exceeded'
+ it_behaves_like "index action with disabled session lifetime or inactivity not exceeded"
end
end
end
- describe 'PATCH #update' do
+ describe "PATCH #update" do
shared_let(:user_with_manage_user_global_permission) do
- create(:user, login: 'human-resources', global_permissions: [:manage_user])
+ create(:user, login: "human-resources", global_permissions: [:manage_user])
end
- shared_let(:some_user) { create(:user, firstname: 'User being updated') }
- shared_let(:some_admin) { create(:admin, firstname: 'Admin being updated') }
+ shared_let(:some_user) { create(:user, firstname: "User being updated") }
+ shared_let(:some_admin) { create(:admin, firstname: "Admin being updated") }
- context 'when updating fields as an admin' do
+ context "when updating fields as an admin" do
current_user { admin }
let(:params) do
{
id: some_user.id,
user: {
- firstname: 'Changed',
- login: 'changed_login',
+ firstname: "Changed",
+ login: "changed_login",
force_password_change: true
},
pref: {
- hide_mail: '1',
- comments_sorting: 'desc'
+ hide_mail: "1",
+ comments_sorting: "desc"
}
}
end
@@ -641,69 +641,69 @@
end
end
- it 'redirects to the edit page' do
+ it "redirects to the edit page" do
expect(response).to render_template :edit
end
- it 'is assigned their new values' do
+ it "is assigned their new values" do
some_user_from_db = User.find(some_user.id)
- expect(some_user_from_db.firstname).to eq('Changed')
- expect(some_user_from_db.login).to eq('changed_login')
+ expect(some_user_from_db.firstname).to eq("Changed")
+ expect(some_user_from_db.login).to eq("changed_login")
expect(some_user_from_db.force_password_change).to be(true)
expect(some_user_from_db.pref[:hide_mail]).to be_truthy
- expect(some_user_from_db.pref[:comments_sorting]).to eq('desc')
+ expect(some_user_from_db.pref[:comments_sorting]).to eq("desc")
end
- it 'sends no mail' do
+ it "sends no mail" do
expect(ActionMailer::Base.deliveries).to be_empty
end
- context 'when updating the password' do
+ context "when updating the password" do
let(:params) do
{
id: some_user.id,
- user: { password: 'newpassPASS!',
- password_confirmation: 'newpassPASS!' },
- send_information: '1'
+ user: { password: "newpassPASS!",
+ password_confirmation: "newpassPASS!" },
+ send_information: "1"
}
end
- it 'sends an email to the user with the password in it' do
+ it "sends an email to the user with the password in it" do
mail = ActionMailer::Base.deliveries.last
expect(mail.to)
.to contain_exactly(some_user.mail)
expect(mail.body.encoded)
- .to include('newpassPASS!')
+ .to include("newpassPASS!")
end
end
- context 'with invalid params' do
+ context "with invalid params" do
let(:params) do
{
id: some_user.id,
user: {
- firstname: ''
+ firstname: ""
}
}
end
- it 'is success' do
+ it "is success" do
expect(response)
.to have_http_status(:ok)
end
- it 'renders the edit template with errors' do
+ it "renders the edit template with errors" do
expect(response)
- .to have_rendered('edit')
+ .to have_rendered("edit")
expect(assigns(:user).errors.first)
.to have_attributes(attribute: :firstname, type: :blank)
end
end
end
- shared_examples 'it can update field' do |field:, value:, edited_user:, current_user:|
+ shared_examples "it can update field" do |field:, value:, edited_user:, current_user:|
it "can change field #{field} " \
"of #{edited_user.to_s.humanize(capitalize: false)} " \
"as #{current_user.to_s.humanize(capitalize: false)}" do
@@ -720,7 +720,7 @@
end
end
- shared_examples 'it cannot update field' do |field:, value:, edited_user:, current_user:|
+ shared_examples "it cannot update field" do |field:, value:, edited_user:, current_user:|
it "cannot change field #{field} " \
"of #{edited_user.to_s.humanize(capitalize: false)} " \
"as #{current_user.to_s.humanize(capitalize: false)}" do
@@ -738,122 +738,122 @@
end
# admin field
- include_examples 'it can update field',
+ include_examples "it can update field",
field: :admin,
value: true,
edited_user: :some_user,
current_user: :admin
- include_examples 'it can update field',
+ include_examples "it can update field",
field: :admin,
value: false,
edited_user: :some_admin,
current_user: :admin
- include_examples 'it cannot update field',
+ include_examples "it cannot update field",
field: :admin,
value: true,
edited_user: :some_user,
current_user: :user
- include_examples 'it cannot update field',
+ include_examples "it cannot update field",
field: :admin,
value: true,
edited_user: :some_user,
current_user: :user_with_manage_user_global_permission
# email field
- include_examples 'it can update field',
+ include_examples "it can update field",
field: :mail,
- value: 'another_email@example.com',
+ value: "another_email@example.com",
edited_user: :some_user,
current_user: :admin
- include_examples 'it can update field',
+ include_examples "it can update field",
field: :mail,
- value: 'another_email@example.com',
+ value: "another_email@example.com",
edited_user: :some_admin,
current_user: :admin
- include_examples 'it can update field',
+ include_examples "it can update field",
field: :mail,
- value: 'another_email@example.com',
+ value: "another_email@example.com",
edited_user: :some_user,
current_user: :user_with_manage_user_global_permission
- include_examples 'it cannot update field',
+ include_examples "it cannot update field",
field: :mail,
- value: 'another_email@example.com',
+ value: "another_email@example.com",
edited_user: :some_admin,
current_user: :user_with_manage_user_global_permission
- include_examples 'it cannot update field',
+ include_examples "it cannot update field",
field: :mail,
- value: 'another_email@example.com',
+ value: "another_email@example.com",
edited_user: :some_user,
current_user: :user
- context 'with external authentication' do
- let(:some_user) { create(:user, identity_url: 'some:identity') }
+ context "with external authentication" do
+ let(:some_user) { create(:user, identity_url: "some:identity") }
before do
as_logged_in_user(admin) do
- put :update, params: { id: some_user.id, user: { force_password_change: 'true' } }
+ put :update, params: { id: some_user.id, user: { force_password_change: "true" } }
end
some_user.reload
end
- it 'ignores setting force_password_change' do
+ it "ignores setting force_password_change" do
expect(some_user.force_password_change).to be(false)
end
end
- context 'with ldap auth source' do
+ context "with ldap auth source" do
let(:ldap_auth_source) { create(:ldap_auth_source) }
- it 'switching to internal authentication on a password change' do
+ it "switching to internal authentication on a password change" do
some_user.ldap_auth_source = ldap_auth_source
as_logged_in_user admin do
put :update,
params: {
id: some_user.id,
- user: { ldap_auth_source_id: '', password: 'newpassPASS!',
- password_confirmation: 'newpassPASS!' }
+ user: { ldap_auth_source_id: "", password: "newpassPASS!",
+ password_confirmation: "newpassPASS!" }
}
end
expect(some_user.reload.ldap_auth_source).to be_nil
- expect(some_user.check_password?('newpassPASS!')).to be true
+ expect(some_user.check_password?("newpassPASS!")).to be true
end
end
- context 'with disabled_password_choice',
+ context "with disabled_password_choice",
with_config: { disable_password_choice: true } do
- it 'ignores password parameters and leaves the password unchanged' do
+ it "ignores password parameters and leaves the password unchanged" do
as_logged_in_user(admin) do
put :update,
params: {
id: user.id,
- user: { password: 'changedpass!', password_confirmation: 'changedpass!' }
+ user: { password: "changedpass!", password_confirmation: "changedpass!" }
}
end
- expect(user.reload.check_password?('changedpass!')).to be false
+ expect(user.reload.check_password?("changedpass!")).to be false
end
end
end
- describe 'Anonymous should not be able to create a user' do
- it 'redirects to the login page' do
+ describe "Anonymous should not be able to create a user" do
+ it "redirects to the login page" do
post :create,
params: {
user: {
- login: 'psmith',
- firstname: 'Paul',
- lastname: 'Smith'
+ login: "psmith",
+ firstname: "Paul",
+ lastname: "Smith"
},
- password: 'psmithPSMITH09',
- password_confirmation: 'psmithPSMITH09'
+ password: "psmithPSMITH09",
+ password_confirmation: "psmithPSMITH09"
}
- expect(response).to redirect_to '/login?back_url=http%3A%2F%2Ftest.host%2Fusers'
+ expect(response).to redirect_to "/login?back_url=http%3A%2F%2Ftest.host%2Fusers"
end
end
- describe 'GET #show' do
- describe 'general' do
+ describe "GET #show" do
+ describe "general" do
let(:current_user) { user }
let(:params) { { id: user.id } }
let(:action) { :show }
@@ -864,73 +864,73 @@
end
end
- it 'responds with success', :aggregate_failures do
+ it "responds with success", :aggregate_failures do
expect(response).to be_successful
- expect(response).to render_template 'show'
+ expect(response).to render_template "show"
expect(assigns(:user)).to eq(user)
end
context 'when requesting special value "me"' do
- let(:params) { { id: 'me' } }
+ let(:params) { { id: "me" } }
- it 'responds with success', :aggregate_failures do
+ it "responds with success", :aggregate_failures do
expect(response).to be_successful
- expect(response).to render_template 'show'
+ expect(response).to render_template "show"
expect(assigns(:user)).to eq(user)
end
end
- context 'when not being logged in' do
+ context "when not being logged in" do
let(:current_user) { User.anonymous }
- context 'when login_required', with_settings: { login_required: true } do
- it 'redirects to login' do
+ context "when login_required", with_settings: { login_required: true } do
+ it "redirects to login" do
expect(response).to redirect_to signin_path(back_url: user_url(user.id))
end
end
- context 'when not login_required', with_settings: { login_required: false } do
- it 'responds with 404' do
+ context "when not login_required", with_settings: { login_required: false } do
+ it "responds with 404" do
expect(response)
.to have_http_status(:not_found)
end
end
context 'when requesting special value "me"' do
- let(:params) { { id: 'me' } }
+ let(:params) { { id: "me" } }
- it 'redirects to login', :aggregate_failures do
- expect(response).to redirect_to signin_url(back_url: user_url('me'))
+ it "redirects to login", :aggregate_failures do
+ expect(response).to redirect_to signin_url(back_url: user_url("me"))
end
end
end
- context 'when the user is locked for an admin' do
+ context "when the user is locked for an admin" do
let(:current_user) do
user.locked!
admin
end
- it 'responds with 200' do
+ it "responds with 200" do
expect(response)
.to have_http_status(:ok)
end
end
- context 'when the user is locked for an non admin' do
+ context "when the user is locked for an non admin" do
let(:current_user) do
user.locked!
create(:user)
end
- it 'responds with 200' do
+ it "responds with 200" do
expect(response)
.to have_http_status(:not_found)
end
end
end
- describe 'for user with Activity' do
+ describe "for user with Activity" do
render_views
let(:work_package) do
@@ -974,26 +974,26 @@
get :show, params: { id: user.id }
end
- it 'includes the number of reported work packages' do
+ it "includes the number of reported work packages" do
label = Regexp.escape(I18n.t(:label_reported_work_packages))
- expect(response.body).to have_css('p', text: /#{label}.*42/)
+ expect(response.body).to have_css("p", text: /#{label}.*42/)
end
end
end
- describe 'POST #create' do
+ describe "POST #create" do
current_user { admin }
let(:params) do
{
user: {
- firstname: 'John',
- lastname: 'Doe',
- login: 'jdoe',
- password: 'adminADMIN!',
- password_confirmation: 'adminADMIN!',
- mail: 'jdoe@gmail.com'
+ firstname: "John",
+ lastname: "Doe",
+ login: "jdoe",
+ password: "adminADMIN!",
+ password_confirmation: "adminADMIN!",
+ mail: "jdoe@gmail.com"
},
pref: {}
}
@@ -1005,17 +1005,17 @@
end
end
- it 'is successful' do
+ it "is successful" do
expect(response)
.to redirect_to edit_user_path(User.newest.first)
end
- it 'creates the user with the provided params' do
+ it "creates the user with the provided params" do
expect(User.newest.first.attributes.with_indifferent_access.slice(:firstname, :lastname, :login, :mail))
.to eql params[:user].with_indifferent_access.slice(:firstname, :lastname, :login, :mail)
end
- it 'sends an activation mail' do
+ it "sends an activation mail" do
mail = ActionMailer::Base.deliveries.last
expect(mail.to)
@@ -1029,12 +1029,12 @@
assert(mail.body.encoded =~ activation_link)
end
- context 'with invalid parameters' do
- let(:params) { { user: { login: 'jdoe' } } }
+ context "with invalid parameters" do
+ let(:params) { { user: { login: "jdoe" } } }
- it 'renders new' do
+ it "renders new" do
expect(response)
- .to render_template 'new'
+ .to render_template "new"
end
end
end
diff --git a/spec/controllers/versions_controller_spec.rb b/spec/controllers/versions_controller_spec.rb
index 1746c43ea993..38ae203668d3 100644
--- a/spec/controllers/versions_controller_spec.rb
+++ b/spec/controllers/versions_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe VersionsController do
let(:user) { create(:admin) }
@@ -35,7 +35,7 @@
let(:version2) { create(:version, project:) }
let(:version3) { create(:version, project:, effective_date: (Date.today - 14.days)) }
- describe '#index' do
+ describe "#index" do
render_views
before do
@@ -44,31 +44,31 @@
version3
end
- context 'without additional params' do
+ context "without additional params" do
before do
login_as(user)
get :index, params: { project_id: project.id }
end
it { expect(response).to be_successful }
- it { expect(response).to render_template('index') }
+ it { expect(response).to render_template("index") }
subject { assigns(:versions) }
- it 'shows Version with no date set' do
+ it "shows Version with no date set" do
expect(subject.include?(version1)).to be_truthy
end
- it 'shows Version with date set' do
+ it "shows Version with date set" do
expect(subject.include?(version2)).to be_truthy
end
- it 'not shows Completed version' do
+ it "not shows Completed version" do
expect(subject.include?(version3)).to be_falsey
end
end
- context 'with showing selected types' do
+ context "with showing selected types" do
let(:type_a) { create(:type) }
let(:type_b) { create(:type) }
@@ -84,13 +84,13 @@
login_as(user)
end
- describe 'with all types' do
+ describe "with all types" do
before do
- get :index, params: { project_id: project, completed: '1' }
+ get :index, params: { project_id: project, completed: "1" }
end
it { expect(response).to be_successful }
- it { expect(response).to render_template('index') }
+ it { expect(response).to render_template("index") }
it "shows all work packages" do
issues_by_version = assigns(:wps_by_version)
@@ -101,13 +101,13 @@
end
end
- describe 'with selected types' do
+ describe "with selected types" do
before do
- get :index, params: { project_id: project, completed: '1', type_ids: [type_b.id] }
+ get :index, params: { project_id: project, completed: "1", type_ids: [type_b.id] }
end
it { expect(response).to be_successful }
- it { expect(response).to render_template('index') }
+ it { expect(response).to render_template("index") }
it "shows only work packages of the selected type" do
issues_by_version = assigns(:wps_by_version)
@@ -119,31 +119,31 @@
end
end
- context 'with showing completed versions' do
+ context "with showing completed versions" do
before do
login_as(user)
- get :index, params: { project_id: project, completed: '1' }
+ get :index, params: { project_id: project, completed: "1" }
end
it { expect(response).to be_successful }
- it { expect(response).to render_template('index') }
+ it { expect(response).to render_template("index") }
subject { assigns(:versions) }
- it 'shows Version with no date set' do
+ it "shows Version with no date set" do
expect(subject.include?(version1)).to be_truthy
end
- it 'shows Version with date set' do
+ it "shows Version with date set" do
expect(subject.include?(version2)).to be_truthy
end
- it 'not shows Completed version' do
+ it "not shows Completed version" do
expect(subject.include?(version3)).to be_truthy
end
end
- describe 'Sub Project Versions' do
+ describe "Sub Project Versions" do
let!(:sub_project) { create(:public_project, parent_id: project.id) }
let!(:sub_project_version) { create(:version, project: sub_project) }
@@ -155,19 +155,19 @@
subject { assigns(:versions) }
- shared_examples 'is successful' do
+ shared_examples "is successful" do
it { expect(response).to be_successful }
- it { expect(response).to render_template('index') }
+ it { expect(response).to render_template("index") }
end
- shared_examples 'shows versions with and without a date set' do
+ shared_examples "shows versions with and without a date set" do
it do
expect(subject).to include(version1, version2)
end
end
shared_examples "shows sub project's' version" do
- it 'sets @with_subprojects to true' do
+ it "sets @with_subprojects to true" do
expect(assigns(:with_subprojects)).to be_truthy
end
@@ -177,7 +177,7 @@
end
shared_examples "does not show sub project's versions" do
- it 'sets @with_subprojects to false' do
+ it "sets @with_subprojects to false" do
expect(assigns(:with_subprojects)).to be_falsey
end
@@ -186,40 +186,40 @@
end
end
- context 'when with_subprojects param is set to 1' do
+ context "when with_subprojects param is set to 1" do
let(:params) { { project_id: project.id, with_subprojects: 1 } }
- include_examples 'is successful'
+ include_examples "is successful"
include_examples "shows sub project's' version"
end
- context 'when with_subprojects param is set to 0' do
+ context "when with_subprojects param is set to 0" do
let(:params) { { project_id: project.id, with_subprojects: 0 } }
- include_examples 'is successful'
+ include_examples "is successful"
include_examples "does not show sub project's versions"
end
- context 'with sub projects included by default',
+ context "with sub projects included by default",
with_settings: { display_subprojects_work_packages: true } do
- context 'and with_subprojects is not a param' do
+ context "and with_subprojects is not a param" do
let(:params) { { project_id: project.id } }
- include_examples 'is successful'
+ include_examples "is successful"
include_examples "shows sub project's' version"
end
- context 'and with_subprojects is set to 0' do
+ context "and with_subprojects is set to 0" do
let(:params) { { project_id: project.id, with_subprojects: 0 } }
- include_examples 'is successful'
+ include_examples "is successful"
include_examples "does not show sub project's versions"
end
end
end
end
- describe '#show' do
+ describe "#show" do
render_views
before do
@@ -229,42 +229,42 @@
end
it { expect(response).to be_successful }
- it { expect(response).to render_template('show') }
- it { assert_select 'h2', content: version2.name }
+ it { expect(response).to render_template("show") }
+ it { assert_select "h2", content: version2.name }
subject { assigns(:version) }
it { is_expected.to eq(version2) }
end
- describe '#new' do
+ describe "#new" do
# This spec is here because at one point the `new` action was requiring
# the `version` key in params, so visiting it without one failed.
- it 'renders correctly' do
+ it "renders correctly" do
login_as(user)
get :new, params: { project_id: project.id }
expect(response.status).to eq(200)
end
end
- describe '#create' do
- context 'with valid attributes' do
+ describe "#create" do
+ context "with valid attributes" do
before do
login_as(user)
- post :create, params: { project_id: project.id, version: { name: 'test_add_version' } }
+ post :create, params: { project_id: project.id, version: { name: "test_add_version" } }
end
it { expect(response).to redirect_to(project_settings_versions_path(project)) }
- it 'generates the new version' do
- version = Version.find_by(name: 'test_add_version')
+ it "generates the new version" do
+ version = Version.find_by(name: "test_add_version")
expect(version).not_to be_nil
expect(version.project).to eq(project)
end
end
end
- describe '#edit' do
+ describe "#edit" do
render_views
before do
@@ -273,33 +273,33 @@
get :edit, params: { id: version2.id }
end
- context 'when resource is found' do
+ context "when resource is found" do
it { expect(response).to be_successful }
- it { expect(response).to render_template('edit') }
+ it { expect(response).to render_template("edit") }
end
end
- describe '#close_completed' do
+ describe "#close_completed" do
before do
login_as(user)
- version1.update_attribute :status, 'open'
- version2.update_attribute :status, 'open'
- version3.update_attribute :status, 'open'
+ version1.update_attribute :status, "open"
+ version2.update_attribute :status, "open"
+ version3.update_attribute :status, "open"
put :close_completed, params: { project_id: project.id }
end
it { expect(response).to redirect_to(project_settings_versions_path(project)) }
- it { expect(Version.find_by(status: 'closed')).to eq(version3) }
+ it { expect(Version.find_by(status: "closed")).to eq(version3) }
end
- describe '#update' do
- context 'with valid params' do
+ describe "#update" do
+ context "with valid params" do
let(:params) do
{
id: version1.id,
version: {
- name: 'New version name',
- effective_date: Date.today.strftime('%Y-%m-%d')
+ name: "New version name",
+ effective_date: Date.today.strftime("%Y-%m-%d")
}
}
end
@@ -310,7 +310,7 @@
end
it { expect(response).to redirect_to(project_settings_versions_path(project)) }
- it { expect(Version.find_by(name: 'New version name')).to eq(version1) }
+ it { expect(Version.find_by(name: "New version name")).to eq(version1) }
it { expect(version1.reload.effective_date).to eq(Date.today) }
end
@@ -321,8 +321,8 @@
patch :update,
params: {
id: version1.id,
- version: { name: 'New version name',
- effective_date: Date.today.strftime('%Y-%m-%d') },
+ version: { name: "New version name",
+ effective_date: Date.today.strftime("%Y-%m-%d") },
back_url: home_path
}
end
@@ -330,31 +330,31 @@
it { expect(response).to redirect_to(home_path) }
end
- context 'with invalid params' do
+ context "with invalid params" do
before do
login_as(user)
patch :update,
params: {
id: version1.id,
- version: { name: '',
- effective_date: Date.today.strftime('%Y-%m-%d') }
+ version: { name: "",
+ effective_date: Date.today.strftime("%Y-%m-%d") }
}
end
it { expect(response).to be_successful }
- it { expect(response).to render_template('edit') }
+ it { expect(response).to render_template("edit") }
it { expect(assigns(:version).errors.symbols_for(:name)).to contain_exactly(:blank) }
end
end
- describe '#destroy' do
+ describe "#destroy" do
before do
login_as(user)
@deleted = version3.id
delete :destroy, params: { id: @deleted }
end
- it 'redirects to projects versions and the version is deleted' do
+ it "redirects to projects versions and the version is deleted" do
expect(response).to redirect_to(project_settings_versions_path(project))
expect { Version.find(@deleted) }.to raise_error ActiveRecord::RecordNotFound
end
diff --git a/spec/controllers/wiki_controller_spec.rb b/spec/controllers/wiki_controller_spec.rb
index 43ece7d6c8c7..9adb49497620 100644
--- a/spec/controllers/wiki_controller_spec.rb
+++ b/spec/controllers/wiki_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WikiController do
shared_let(:admin) { create(:admin) }
@@ -37,45 +37,45 @@
shared_let(:wiki) { project.wiki }
shared_let(:existing_page) do
- create(:wiki_page, wiki_id: project.wiki.id, title: 'ExistingPage', author: admin)
+ create(:wiki_page, wiki_id: project.wiki.id, title: "ExistingPage", author: admin)
end
- describe 'actions' do
+ describe "actions" do
before do
allow(controller).to receive(:set_localization)
end
current_user { admin }
- describe 'index' do
+ describe "index" do
before do
get :index, params: { project_id: project.identifier }
end
- it 'is successful' do
+ it "is successful" do
expect(response)
.to have_http_status(:ok)
end
- it 'renders the index template' do
+ it "renders the index template" do
expect(response)
.to render_template(:index)
end
- it 'assigns pages' do
+ it "assigns pages" do
expect(assigns[:pages])
.to eq project.wiki.pages
end
end
shared_examples_for "a 'new' action" do
- it 'assigns @project to the current project' do
+ it "assigns @project to the current project" do
get_page
expect(assigns[:project]).to eq(project)
end
- it 'assigns @page to a newly created wiki page' do
+ it "assigns @page to a newly created wiki page" do
get_page
expect(assigns[:page]).to be_new_record
@@ -83,38 +83,38 @@
expect(assigns[:page].wiki).to eq(project.wiki)
end
- it 'renders the new action' do
+ it "renders the new action" do
get_page
- expect(response).to render_template 'new'
+ expect(response).to render_template "new"
end
end
- describe 'new' do
- let(:get_page) { get 'new', params: { project_id: project } }
+ describe "new" do
+ let(:get_page) { get "new", params: { project_id: project } }
it_behaves_like "a 'new' action"
end
- describe 'new_child' do
- let(:get_page) { get 'new_child', params: { project_id: project, id: existing_page.title } }
+ describe "new_child" do
+ let(:get_page) { get "new_child", params: { project_id: project, id: existing_page.title } }
it_behaves_like "a 'new' action"
- it 'sets the parent page for the new page' do
+ it "sets the parent page for the new page" do
get_page
expect(assigns[:page].parent).to eq(existing_page)
end
- it 'renders 404 if used with an unknown page title' do
- get 'new_child', params: { project_id: project, id: 'foobar' }
+ it "renders 404 if used with an unknown page title" do
+ get "new_child", params: { project_id: project, id: "foobar" }
expect(response.status).to eq(404) # not found
end
end
- describe 'show' do
+ describe "show" do
let(:permissions) { %w[view_wiki_pages] }
let(:user) { create(:user, member_with_permissions: { project => permissions }) }
@@ -124,40 +124,40 @@
get_page
end
- context 'when querying for an existing page' do
+ context "when querying for an existing page" do
let(:get_page) { get :show, params: { project_id: project, id: existing_page.title } }
- it 'is a success' do
+ it "is a success" do
expect(response)
.to have_http_status(:ok)
end
- it 'renders the show template' do
+ it "renders the show template" do
expect(response)
.to render_template(:show)
end
- it 'assigns the page' do
+ it "assigns the page" do
expect(assigns[:page])
.to eql existing_page
end
end
- context 'when querying for the wiki root page with edit permissions' do
- let(:get_page) { get :show, params: { project_id: project, id: 'wiki' } }
+ context "when querying for the wiki root page with edit permissions" do
+ let(:get_page) { get :show, params: { project_id: project, id: "wiki" } }
let(:permissions) { %w[view_wiki_pages edit_wiki_pages] }
- it 'is a success' do
+ it "is a success" do
expect(response)
.to have_http_status(:ok)
end
- it 'renders the new template' do
+ it "renders the new template" do
expect(response)
.to render_template(:new)
end
- it 'assigns a new page that is unpersisted' do
+ it "assigns a new page that is unpersisted" do
expect(assigns[:page])
.to be_a WikiPages::AtVersion
@@ -166,21 +166,21 @@
end
end
- context 'when querying for an unexisting page with edit permissions' do
- let(:get_page) { get :show, params: { project_id: project, id: 'new_page' } }
+ context "when querying for an unexisting page with edit permissions" do
+ let(:get_page) { get :show, params: { project_id: project, id: "new_page" } }
let(:permissions) { %w[view_wiki_pages edit_wiki_pages] }
- it 'is a success' do
+ it "is a success" do
expect(response)
.to have_http_status(:ok)
end
- it 'renders the new template' do
+ it "renders the new template" do
expect(response)
.to render_template(:new)
end
- it 'assigns a new page that is unpersisted' do
+ it "assigns a new page that is unpersisted" do
expect(assigns[:page])
.to be_a WikiPages::AtVersion
@@ -189,52 +189,52 @@
end
end
- context 'when querying for no specific page' do
+ context "when querying for no specific page" do
let(:get_page) do
project.wiki.update_column(:start_page, existing_page.title)
get :show, params: { project_id: project }
end
- it 'is a success' do
+ it "is a success" do
expect(response)
.to have_http_status(:ok)
end
- it 'renders the show template' do
+ it "renders the show template" do
expect(response)
.to render_template(:show)
end
- it 'assigns the wiki start page' do
+ it "assigns the wiki start page" do
expect(assigns[:page])
.to eql existing_page
end
end
- context 'when querying for the wiki root page without edit permissions' do
- let(:get_page) { get :show, params: { project_id: project, id: 'wiki' } }
+ context "when querying for the wiki root page without edit permissions" do
+ let(:get_page) { get :show, params: { project_id: project, id: "wiki" } }
- it 'redirects to index' do
+ it "redirects to index" do
expect(response).to redirect_to action: :index
end
- it 'shows a flash info' do
- expect(flash[:info]).to include I18n.t('wiki.page_not_editable_index')
+ it "shows a flash info" do
+ expect(flash[:info]).to include I18n.t("wiki.page_not_editable_index")
end
end
- context 'when querying for a non existing page without edit permissions' do
- let(:get_page) { get :show, params: { project_id: project, id: 'new_page' } }
+ context "when querying for a non existing page without edit permissions" do
+ let(:get_page) { get :show, params: { project_id: project, id: "new_page" } }
- it 'returns 404' do
+ it "returns 404" do
expect(response)
.to have_http_status(:not_found)
end
end
end
- describe 'edit' do
+ describe "edit" do
let(:permissions) { %i[view_wiki_pages edit_wiki_pages] }
let(:params) do
@@ -250,22 +250,22 @@
get :edit, params:, flash:
end
- context 'with an existing wiki page' do
+ context "with an existing wiki page" do
let(:params) do
{ project_id: project, id: existing_page.title }
end
- it 'is sucessful' do
+ it "is sucessful" do
expect(response)
.to have_http_status(:ok)
end
- it 'renders the edit template' do
+ it "renders the edit template" do
expect(response)
.to render_template :edit
end
- it 'assigns the page' do
+ it "assigns the page" do
expect(assigns[:page])
.to eq existing_page
@@ -274,36 +274,36 @@
end
end
- context 'with an existing wiki page that is protected' do
+ context "with an existing wiki page that is protected" do
let(:params) do
existing_page.update_column(:protected, true)
{ project_id: project, id: existing_page.title }
end
- it 'is forbiddend' do
+ it "is forbiddend" do
expect(response)
.to have_http_status(:forbidden)
end
end
- context 'with an existing wiki page that is protected and having the necessary permission' do
+ context "with an existing wiki page that is protected and having the necessary permission" do
let(:permissions) do
existing_page.update_column(:protected, true)
%i[view_wiki_pages edit_wiki_pages protect_wiki_pages]
end
- it 'is sucessful' do
+ it "is sucessful" do
expect(response)
.to have_http_status(:ok)
end
- it 'renders the edit template' do
+ it "renders the edit template" do
expect(response)
.to render_template :edit
end
- it 'assigns the page' do
+ it "assigns the page" do
expect(assigns[:page])
.to eq existing_page
@@ -312,23 +312,23 @@
end
end
- context 'with a related wiki page in the flash and a non existing wiki page' do
+ context "with a related wiki page in the flash and a non existing wiki page" do
let(:flash) { { _related_wiki_page_id: 1234 } }
let(:params) do
- { project_id: project, id: 'foobar' }
+ { project_id: project, id: "foobar" }
end
- it 'is sucessful' do
+ it "is sucessful" do
expect(response)
.to have_http_status(:ok)
end
- it 'renders the edit template' do
+ it "renders the edit template" do
expect(response)
.to render_template :edit
end
- it 'assigns @page to a new wiki page with the parent id set' do
+ it "assigns @page to a new wiki page with the parent id set" do
expect(assigns[:page])
.to be_a WikiPages::AtVersion
@@ -341,99 +341,99 @@
end
end
- describe 'create' do
- describe 'successful action' do
- it 'redirects to the show action' do
- post 'create',
+ describe "create" do
+ describe "successful action" do
+ it "redirects to the show action" do
+ post "create",
params: {
project_id: project,
- page: { text: 'h1. abc', title: 'abc' }
+ page: { text: "h1. abc", title: "abc" }
}
- expect(response).to redirect_to action: 'show', project_id: project, id: 'abc'
+ expect(response).to redirect_to action: "show", project_id: project, id: "abc"
end
- it 'saves a new WikiPage with proper content' do
- post 'create',
+ it "saves a new WikiPage with proper content" do
+ post "create",
params: {
project_id: project,
- page: { text: 'h1. abc', title: 'abc' }
+ page: { text: "h1. abc", title: "abc" }
}
- page = project.wiki.pages.find_by title: 'abc'
+ page = project.wiki.pages.find_by title: "abc"
expect(page).not_to be_nil
- expect(page.text).to eq('h1. abc')
+ expect(page.text).to eq("h1. abc")
end
end
- describe 'unsuccessful action' do
+ describe "unsuccessful action" do
it 'renders "wiki/new"' do
- post 'create',
+ post "create",
params: {
project_id: project,
- page: { text: 'h1. abc', title: '' }
+ page: { text: "h1. abc", title: "" }
}
- expect(response).to render_template('new')
+ expect(response).to render_template("new")
end
- it 'assigns project to work with new template' do
- post 'create',
+ it "assigns project to work with new template" do
+ post "create",
params: {
project_id: project,
- page: { text: 'h1. abc', title: '' }
+ page: { text: "h1. abc", title: "" }
}
expect(assigns[:project]).to eq(project)
end
- it 'assigns wiki to work with new template' do
- post 'create',
+ it "assigns wiki to work with new template" do
+ post "create",
params: {
project_id: project,
- page: { text: 'h1. abc', title: '' }
+ page: { text: "h1. abc", title: "" }
}
expect(assigns[:wiki]).to eq(project.wiki)
expect(assigns[:wiki]).not_to be_new_record
end
- it 'assigns page to work with new template' do
- post 'create',
+ it "assigns page to work with new template" do
+ post "create",
params: {
project_id: project,
- page: { text: 'h1. abc', title: '' }
+ page: { text: "h1. abc", title: "" }
}
expect(assigns[:page]).to be_new_record
expect(assigns[:page].wiki.project).to eq(project)
- expect(assigns[:page].title).to eq('')
- expect(assigns[:page].text).to eq('h1. abc')
+ expect(assigns[:page].title).to eq("")
+ expect(assigns[:page].text).to eq("h1. abc")
expect(assigns[:page]).not_to be_valid
end
end
end
- describe 'update' do
- context 'when the page is locked' do
+ describe "update" do
+ context "when the page is locked" do
before do
existing_page.update!(protected: true)
end
- it 'redirects to the show action' do
- post 'update',
+ it "redirects to the show action" do
+ post "update",
params: {
project_id: project,
id: existing_page.title,
- page: { text: 'h1. abc', title: 'foobar' }
+ page: { text: "h1. abc", title: "foobar" }
}
- expect(response).to redirect_to action: 'show', project_id: project, id: 'foobar'
+ expect(response).to redirect_to action: "show", project_id: project, id: "foobar"
end
end
end
- describe 'destroy' do
+ describe "destroy" do
shared_let(:parent_page) { create(:wiki_page, wiki:) }
shared_let(:child_page) { create(:wiki_page, wiki:, parent: parent_page) }
@@ -449,13 +449,13 @@
response
end
- context 'when it is not the only wiki page' do
- it 'redirects to wiki#index' do
+ context "when it is not the only wiki page" do
+ it "redirects to wiki#index" do
expect(subject)
- .to redirect_to action: 'index', project_id: project, id: redirect_page_after_destroy
+ .to redirect_to action: "index", project_id: project, id: redirect_page_after_destroy
end
- it 'destroys the page' do
+ it "destroys the page" do
expect { subject }
.to change { WikiPage.where(id: existing_page.id).count }
.from(1)
@@ -463,17 +463,17 @@
end
end
- context 'when it is the only wiki page' do
+ context "when it is the only wiki page" do
before do
WikiPage.where.not(id: existing_page.id).delete_all
end
- it 'redirects to projects#show' do
+ it "redirects to projects#show" do
expect(subject)
.to redirect_to project_path(project)
end
- it 'destroys the page' do
+ it "destroys the page" do
expect { subject }
.to change { WikiPage.where(id: existing_page.id).count }
.from(1)
@@ -481,17 +481,17 @@
end
end
- context 'when destroying a child' do
+ context "when destroying a child" do
let(:params) do
{ project_id: project, id: child_page }
end
- it 'redirects to wiki#index' do
+ it "redirects to wiki#index" do
expect(subject)
- .to redirect_to action: 'index', project_id: project, id: redirect_page_after_destroy
+ .to redirect_to action: "index", project_id: project, id: redirect_page_after_destroy
end
- it 'destroys the page' do
+ it "destroys the page" do
expect { subject }
.to change { WikiPage.where(id: child_page.id).count }
.from(1)
@@ -499,40 +499,40 @@
end
end
- context 'when destroying a parent without specifying todo' do
+ context "when destroying a parent without specifying todo" do
let(:params) do
{ project_id: project, id: parent_page }
end
- it 'responds with success' do
+ it "responds with success" do
expect(subject)
.to have_http_status(:ok)
end
- it 'destroys the page' do
+ it "destroys the page" do
expect { subject }
.not_to change(WikiPage, :count)
end
end
- context 'when destroying a parent with nullify' do
+ context "when destroying a parent with nullify" do
let(:params) do
- { project_id: project, id: parent_page, todo: 'nullify' }
+ { project_id: project, id: parent_page, todo: "nullify" }
end
- it 'redirects to wiki#index' do
+ it "redirects to wiki#index" do
expect(subject)
- .to redirect_to action: 'index', project_id: project, id: redirect_page_after_destroy
+ .to redirect_to action: "index", project_id: project, id: redirect_page_after_destroy
end
- it 'destroys the page' do
+ it "destroys the page" do
expect { subject }
.to change { WikiPage.where(id: parent_page.id).count }
.from(1)
.to(0)
end
- it 'sets the parent_id of the child to nil' do
+ it "sets the parent_id of the child to nil" do
subject
expect(child_page.parent_id)
@@ -540,17 +540,17 @@
end
end
- context 'when destroying a parent with todo = destroy' do
+ context "when destroying a parent with todo = destroy" do
let(:params) do
- { project_id: project, id: parent_page, todo: 'destroy' }
+ { project_id: project, id: parent_page, todo: "destroy" }
end
- it 'redirects to wiki#index' do
+ it "redirects to wiki#index" do
expect(subject)
- .to redirect_to action: 'index', project_id: project, id: redirect_page_after_destroy
+ .to redirect_to action: "index", project_id: project, id: redirect_page_after_destroy
end
- it 'destroys the page' do
+ it "destroys the page" do
expect { subject }
.to change { WikiPage.where(id: [parent_page, child_page]).count }
.from(2)
@@ -558,24 +558,24 @@
end
end
- context 'when destroying a parent with reassign' do
+ context "when destroying a parent with reassign" do
let(:params) do
- { project_id: project, id: parent_page, todo: 'reassign', reassign_to_id: existing_page.id }
+ { project_id: project, id: parent_page, todo: "reassign", reassign_to_id: existing_page.id }
end
- it 'redirects to wiki#index' do
+ it "redirects to wiki#index" do
expect(subject)
- .to redirect_to action: 'index', project_id: project, id: redirect_page_after_destroy
+ .to redirect_to action: "index", project_id: project, id: redirect_page_after_destroy
end
- it 'destroys the page' do
+ it "destroys the page" do
expect { subject }
.to change { WikiPage.where(id: parent_page).count }
.from(1)
.to(0)
end
- it 'sets the parent_id of the child to the specified page' do
+ it "sets the parent_id of the child to the specified page" do
subject
expect(child_page.parent_id)
@@ -584,7 +584,7 @@
end
end
- describe 'rename' do
+ describe "rename" do
shared_let(:parent_page) { create(:wiki_page, wiki:) }
shared_let(:child_page) { create(:wiki_page, wiki:, parent: parent_page) }
@@ -606,45 +606,45 @@
response
end
- context 'when getting for a page' do
- it 'is success' do
+ context "when getting for a page" do
+ it "is success" do
expect(subject)
.to have_http_status(:ok)
end
- it 'renders the template' do
+ it "renders the template" do
expect(subject)
.to render_template :rename
end
end
- context 'when getting for a child page' do
+ context "when getting for a child page" do
let(:params) do
{ project_id: project, id: child_page.title }
end
- it 'is success' do
+ it "is success" do
expect(subject)
.to have_http_status(:ok)
end
- it 'renders the template' do
+ it "renders the template" do
expect(subject)
.to render_template :rename
end
end
- context 'when getting for a page without permissions' do
+ context "when getting for a page without permissions" do
let(:permissions) { %i[view_wiki_pages] }
- it 'is forbidden' do
+ it "is forbidden" do
expect(subject)
.to have_http_status(:forbidden)
end
end
- context 'when patching with redirect' do
- let(:new_title) { 'The new page title' }
+ context "when patching with redirect" do
+ let(:new_title) { "The new page title" }
let!(:old_title) { existing_page.title }
let(:params) do
@@ -662,19 +662,19 @@
patch :rename, params:
end
- it 'redirects to the show page with the altered name' do
+ it "redirects to the show page with the altered name" do
expect(subject)
- .to redirect_to action: 'show', project_id: project.identifier, id: 'the-new-page-title'
+ .to redirect_to action: "show", project_id: project.identifier, id: "the-new-page-title"
end
- it 'renames the page' do
+ it "renames the page" do
subject
expect(existing_page.reload.title)
.to eql new_title
end
- it 'finds the page by the old name' do
+ it "finds the page by the old name" do
subject
expect(wiki.find_page(old_title))
@@ -682,8 +682,8 @@
end
end
- context 'when patching without redirect' do
- let(:new_title) { 'The new page title' }
+ context "when patching without redirect" do
+ let(:new_title) { "The new page title" }
let!(:old_title) { existing_page.title }
let(:params) do
@@ -692,7 +692,7 @@
id: existing_page.title,
page: {
title: new_title,
- redirect_existing_links: '0'
+ redirect_existing_links: "0"
}
}
end
@@ -701,19 +701,19 @@
patch :rename, params:
end
- it 'redirects to the show page with the altered name' do
+ it "redirects to the show page with the altered name" do
expect(subject)
- .to redirect_to action: 'show', project_id: project.identifier, id: 'the-new-page-title'
+ .to redirect_to action: "show", project_id: project.identifier, id: "the-new-page-title"
end
- it 'renames the page' do
+ it "renames the page" do
subject
expect(existing_page.reload.title)
.to eql new_title
end
- it 'does not find the page by the old name' do
+ it "does not find the page by the old name" do
subject
expect(wiki.find_page(old_title))
@@ -722,10 +722,10 @@
end
end
- describe 'diffs' do
+ describe "diffs" do
let!(:journal_from) { existing_page.journals.last }
let!(:journal_to) do
- existing_page.text = 'new_text'
+ existing_page.text = "new_text"
existing_page.save
existing_page.journals.reload.last
@@ -754,17 +754,17 @@
response
end
- it 'is success' do
+ it "is success" do
expect(subject)
.to have_http_status(:ok)
end
- it 'renders the template' do
+ it "renders the template" do
expect(subject)
.to render_template :diff
end
- it 'assigns html_diff' do
+ it "assigns html_diff" do
subject
expect(assigns[:html_diff])
@@ -772,10 +772,10 @@
end
end
- describe 'annotates' do
+ describe "annotates" do
let!(:journal_from) { existing_page.journals.last }
let!(:journal_to) do
- existing_page.text = 'new_text'
+ existing_page.text = "new_text"
existing_page.save
existing_page.journals.reload.last
@@ -799,18 +799,18 @@
response
end
- it 'is success' do
+ it "is success" do
expect(subject)
.to have_http_status(:ok)
end
- it 'renders the template' do
+ it "renders the template" do
expect(subject)
.to render_template :annotate
end
end
- describe 'export' do
+ describe "export" do
let(:permissions) { %i[view_wiki_pages export_wiki_pages] }
current_user { create(:user, member_with_permissions: { project => permissions }) }
@@ -819,36 +819,36 @@
get :export, params: { project_id: project.identifier }
end
- it 'is successful' do
+ it "is successful" do
expect(response)
.to have_http_status(:ok)
end
- it 'assigns pages' do
+ it "assigns pages" do
expect(assigns[:pages])
.to eq project.wiki.pages
end
- it 'is an html response' do
+ it "is an html response" do
expect(response.content_type)
- .to eq 'text/html'
+ .to eq "text/html"
end
- context 'for an unauthorized user' do
+ context "for an unauthorized user" do
let(:permissions) { %i[view_wiki_pages] }
- it 'prevents access' do
+ it "prevents access" do
expect(response)
.to have_http_status(:forbidden)
end
end
end
- describe 'protect' do
+ describe "protect" do
let(:permissions) { %i[view_wiki_pages protect_wiki_pages] }
let(:params) do
- { project_id: project, id: existing_page.title, protected: '1' }
+ { project_id: project, id: existing_page.title, protected: "1" }
end
let(:request) do
@@ -862,21 +862,21 @@
response
end
- context 'with an existing wiki page' do
- it 'set the protected property of the page' do
+ context "with an existing wiki page" do
+ it "set the protected property of the page" do
expect { subject }
.to change { existing_page.reload.protected? }
.from(false)
.to(true)
end
- it 'redirects to the show page' do
+ it "redirects to the show page" do
expect(subject)
- .to redirect_to action: 'show', project_id: project.identifier, id: existing_page.title.downcase
+ .to redirect_to action: "show", project_id: project.identifier, id: existing_page.title.downcase
end
end
- context 'with an existing wiki page that is protected' do
+ context "with an existing wiki page that is protected" do
let(:permissions) do
existing_page.update_column :protected, true
@@ -884,40 +884,40 @@
end
let(:params) do
- { project_id: project, id: existing_page.title, protected: '0' }
+ { project_id: project, id: existing_page.title, protected: "0" }
end
- it 'set the protected property of the page' do
+ it "set the protected property of the page" do
expect { subject }
.to change { existing_page.reload.protected? }
.from(true)
.to(false)
end
- it 'redirects to the show page' do
+ it "redirects to the show page" do
expect(subject)
- .to redirect_to action: 'show', project_id: project.identifier, id: existing_page.title.downcase
+ .to redirect_to action: "show", project_id: project.identifier, id: existing_page.title.downcase
end
end
- context 'with an existing wiki page but missing permissions' do
+ context "with an existing wiki page but missing permissions" do
let(:permissions) do
%i[view_wiki_pages]
end
- it 'does not change the protected property of the page' do
+ it "does not change the protected property of the page" do
expect { subject }
.not_to change { existing_page.reload.protected? }
end
- it 'return forbidden' do
+ it "return forbidden" do
expect(subject)
.to have_http_status(:forbidden)
end
end
end
- describe 'history' do
+ describe "history" do
let(:permissions) { %i[view_wiki_edits] }
current_user { create(:user, member_with_permissions: { project => permissions }) }
@@ -926,27 +926,27 @@
get :history, params: { project_id: project.identifier, id: existing_page.title }
end
- it 'is successful' do
+ it "is successful" do
expect(response)
.to have_http_status(:ok)
end
- it 'renders the template' do
+ it "renders the template" do
expect(response)
.to render_template :history
end
- it 'assigns versions' do
+ it "assigns versions" do
expect(assigns[:versions])
.to eq existing_page.journals
end
- context 'for a non existing page' do
+ context "for a non existing page" do
before do
- get :history, params: { project_id: project.identifier, id: 'bogus' }
+ get :history, params: { project_id: project.identifier, id: "bogus" }
end
- it 'states not found' do
+ it "states not found" do
expect(response)
.to have_http_status(:not_found)
end
@@ -954,7 +954,7 @@
end
end
- describe 'view related stuff' do
+ describe "view related stuff" do
render_views
shared_let(:project) do
@@ -965,19 +965,19 @@
let!(:page_with_content) do
create(:wiki_page,
wiki_id: project.wiki.id,
- title: 'PagewithContent',
+ title: "PagewithContent",
author_id: admin.id)
end
let!(:page_default) do
create(:wiki_page,
wiki_id: project.wiki.id,
- title: 'Wiki',
+ title: "Wiki",
author_id: admin.id)
end
let!(:unrelated_page) do
create(:wiki_page,
wiki_id: project.wiki.id,
- title: 'UnrelatedPage',
+ title: "UnrelatedPage",
author_id: admin.id)
end
@@ -1002,27 +1002,27 @@
current_user { admin }
- describe '- main menu links' do
+ describe "- main menu links" do
before do
@main_menu_item_for_page_with_content = create(:wiki_menu_item,
navigatable_id: project.wiki.id,
- title: 'Item for Page with Content',
+ title: "Item for Page with Content",
name: page_with_content.slug)
@main_menu_item_for_new_wiki_page = create(:wiki_menu_item,
navigatable_id: project.wiki.id,
- title: 'Item for new WikiPage',
- name: 'new-wiki-page')
+ title: "Item for new WikiPage",
+ name: "new-wiki-page")
@other_menu_item = create(:wiki_menu_item,
navigatable_id: project.wiki.id,
- title: 'Item for other page',
+ title: "Item for other page",
name: unrelated_page.slug)
end
- shared_examples_for 'all wiki menu items' do
- it 'is inactive, when an unrelated page is shown' do
- get 'show', params: { id: unrelated_page.slug, project_id: project.id }
+ shared_examples_for "all wiki menu items" do
+ it "is inactive, when an unrelated page is shown" do
+ get "show", params: { id: unrelated_page.slug, project_id: project.id }
expect(response).to be_successful
@@ -1031,17 +1031,17 @@
end
it "is inactive, when another wiki menu item's page is shown" do
- get 'show', params: { id: @other_wiki_menu_item.name, project_id: project.id }
+ get "show", params: { id: @other_wiki_menu_item.name, project_id: project.id }
expect(response).to be_successful
- expect(response.body).to have_css('.main-menu--children a.selected', count: 0)
+ expect(response.body).to have_css(".main-menu--children a.selected", count: 0)
assert_select "#main-menu a.#{@wiki_menu_item.menu_identifier}-menu-item"
assert_select "#main-menu a.#{@wiki_menu_item.menu_identifier}-menu-item.selected", false
end
- it 'is active, when the given wiki menu item is shown' do
- get 'show', params: { id: @wiki_menu_item.name, project_id: project.id }
+ it "is active, when the given wiki menu item is shown" do
+ get "show", params: { id: @wiki_menu_item.name, project_id: project.id }
expect(response).to be_successful
@@ -1049,130 +1049,130 @@
end
end
- shared_examples_for 'all existing wiki menu items' do
+ shared_examples_for "all existing wiki menu items" do
# TODO: Add tests for new and toc options within menu item
- it 'is active on parents item, when new page is shown' do
- get 'new_child', params: { id: @wiki_menu_item.name, project_id: project.identifier }
+ it "is active on parents item, when new page is shown" do
+ get "new_child", params: { id: @wiki_menu_item.name, project_id: project.identifier }
expect(response).to be_successful
assert_select "#main-menu a.#{@wiki_menu_item.menu_identifier}-menu-item.selected"
end
- it 'is active, when a toc page is shown' do
- get 'index', params: { id: @wiki_menu_item.name, project_id: project.id }
+ it "is active, when a toc page is shown" do
+ get "index", params: { id: @wiki_menu_item.name, project_id: project.id }
expect(response).to be_successful
- assert_select '#content h2', text: 'Table of Contents'
+ assert_select "#content h2", text: "Table of Contents"
assert_select "#main-menu a.#{@wiki_menu_item.menu_identifier}-menu-item.selected"
end
end
- shared_examples_for 'all wiki menu items with child pages' do
- it 'is active, when the given wiki menu item is an ancestor of the shown page' do
- get 'show', params: { id: child_page.slug, project_id: project.id }
+ shared_examples_for "all wiki menu items with child pages" do
+ it "is active, when the given wiki menu item is an ancestor of the shown page" do
+ get "show", params: { id: child_page.slug, project_id: project.id }
expect(response).to be_successful
- expect(response.body).to have_css('#main-menu a.selected', count: 1)
+ expect(response.body).to have_css("#main-menu a.selected", count: 1)
assert_select "#main-menu a.#{@wiki_menu_item.menu_identifier}-menu-item.selected"
end
end
- describe '- wiki menu item pointing to a saved wiki page' do
+ describe "- wiki menu item pointing to a saved wiki page" do
before do
@wiki_menu_item = @main_menu_item_for_page_with_content
@other_wiki_menu_item = @other_menu_item
end
- it_behaves_like 'all wiki menu items'
- it_behaves_like 'all existing wiki menu items'
- it_behaves_like 'all wiki menu items with child pages'
+ it_behaves_like "all wiki menu items"
+ it_behaves_like "all existing wiki menu items"
+ it_behaves_like "all wiki menu items with child pages"
end
- describe '- wiki menu item pointing to a new wiki page' do
+ describe "- wiki menu item pointing to a new wiki page" do
before do
@wiki_menu_item = @main_menu_item_for_new_wiki_page
@other_wiki_menu_item = @other_menu_item
end
- it_behaves_like 'all wiki menu items'
+ it_behaves_like "all wiki menu items"
end
- describe '- wiki_menu_item containing special chars only' do
+ describe "- wiki_menu_item containing special chars only" do
before do
@wiki_menu_item = create(:wiki_menu_item,
navigatable_id: project.wiki.id,
- title: '?',
- name: 'help')
+ title: "?",
+ name: "help")
@other_wiki_menu_item = @other_menu_item
end
- it_behaves_like 'all wiki menu items'
+ it_behaves_like "all wiki menu items"
end
end
- describe '- wiki sidebar' do
- describe 'configure menu items link' do
- describe 'on a show page' do
- describe 'being authorized to configure menu items' do
- it 'is visible' do
- get 'show', params: { project_id: project.id }
+ describe "- wiki sidebar" do
+ describe "configure menu items link" do
+ describe "on a show page" do
+ describe "being authorized to configure menu items" do
+ it "is visible" do
+ get "show", params: { project_id: project.id }
expect(response).to be_successful
- assert_select '#content a', 'Configure menu item'
+ assert_select "#content a", "Configure menu item"
end
end
- describe 'being unauthorized to configure menu items' do
+ describe "being unauthorized to configure menu items" do
before do
allow(User).to receive(:current).and_return @anon
end
- it 'is invisible' do
- get 'show', params: { project_id: project.id }
+ it "is invisible" do
+ get "show", params: { project_id: project.id }
expect(response).to be_successful
- assert_select '#content a', text: 'Configure menu item', count: 0
+ assert_select "#content a", text: "Configure menu item", count: 0
end
end
end
end
- describe 'new child page link' do
- describe 'on an index page' do
- describe 'being authorized to edit wiki pages' do
- it 'is invisible' do
- get 'index', params: { project_id: project.id }
+ describe "new child page link" do
+ describe "on an index page" do
+ describe "being authorized to edit wiki pages" do
+ it "is invisible" do
+ get "index", params: { project_id: project.id }
expect(response).to be_successful
- assert_select '#content a', text: 'Wiki page', count: 0
+ assert_select "#content a", text: "Wiki page", count: 0
end
end
- describe 'being unauthorized to edit wiki pages' do
+ describe "being unauthorized to edit wiki pages" do
before do
allow(User).to receive(:current).and_return @anon
end
- it 'is invisible' do
- get 'index', params: { project_id: project.id }
+ it "is invisible" do
+ get "index", params: { project_id: project.id }
expect(response).to be_successful
- assert_select '#content a', text: 'Wiki page', count: 0
+ assert_select "#content a", text: "Wiki page", count: 0
end
end
end
- describe 'on a wiki page' do
- describe 'being authorized to edit wiki pages' do
- describe 'with a wiki page present' do
- it 'is visible' do
- get 'show',
+ describe "on a wiki page" do
+ describe "being authorized to edit wiki pages" do
+ describe "with a wiki page present" do
+ it "is visible" do
+ get "show",
params: { id: page_with_content.title, project_id: project.identifier }
expect(response).to be_successful
@@ -1182,62 +1182,62 @@
path = new_child_project_wiki_path(project_id: project, id: page_with_content.slug)
- assert_select "#content a[href='#{path}']", 'Wiki page'
+ assert_select "#content a[href='#{path}']", "Wiki page"
end
end
- describe 'with no wiki page present' do
- it 'is invisible' do
- get 'show', params: { id: 'i-am-a-ghostpage', project_id: project.identifier }
+ describe "with no wiki page present" do
+ it "is invisible" do
+ get "show", params: { id: "i-am-a-ghostpage", project_id: project.identifier }
expect(response).to be_successful
assert_select "#content a[href='#{new_child_project_wiki_path(project_id: project, id: 'i-am-a-ghostpage')}']",
- text: 'Wiki page', count: 0
+ text: "Wiki page", count: 0
end
end
end
- describe 'being unauthorized to edit wiki pages' do
+ describe "being unauthorized to edit wiki pages" do
before do
allow(User).to receive(:current).and_return @anon
end
- it 'is invisible' do
- get 'show', params: { id: page_with_content.title, project_id: project.identifier }
+ it "is invisible" do
+ get "show", params: { id: page_with_content.title, project_id: project.identifier }
expect(response).to be_successful
- assert_select '#content a', text: 'Wiki page', count: 0
+ assert_select "#content a", text: "Wiki page", count: 0
end
end
end
end
- describe 'new page link' do
- describe 'on a show page' do
- describe 'being authorized to edit wiki pages' do
- it 'is visible' do
- get 'show', params: { project_id: project.id }
+ describe "new page link" do
+ describe "on a show page" do
+ describe "being authorized to edit wiki pages" do
+ it "is visible" do
+ get "show", params: { project_id: project.id }
expect(response).to be_successful
assert_select ".toolbar-items a[href='#{new_child_project_wiki_path(project_id: project, id: 'wiki')}']",
- 'Wiki page'
+ "Wiki page"
end
end
- describe 'being unauthorized to edit wiki pages' do
+ describe "being unauthorized to edit wiki pages" do
before do
allow(User).to receive(:current).and_return @anon
end
- it 'is invisible' do
- get 'show', params: { project_id: project.id }
+ it "is invisible" do
+ get "show", params: { project_id: project.id }
expect(response).to be_successful
- assert_select '.toolbar-items a', text: 'Wiki page', count: 0
+ assert_select ".toolbar-items a", text: "Wiki page", count: 0
end
end
end
diff --git a/spec/controllers/wiki_menu_authentication_spec.rb b/spec/controllers/wiki_menu_authentication_spec.rb
index 5d33ff2a7ef9..f67dc5b33bcc 100644
--- a/spec/controllers/wiki_menu_authentication_spec.rb
+++ b/spec/controllers/wiki_menu_authentication_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WikiMenuItemsController do
before do
@@ -42,25 +42,25 @@
@params[:id] = page.title
end
- describe 'w/ valid auth' do
- it 'renders the edit action' do
+ describe "w/ valid auth" do
+ it "renders the edit action" do
admin_user = create(:admin)
allow(User).to receive(:current).and_return admin_user
- permission_role = create(:project_role, name: 'accessgranted', permissions: [:manage_wiki_menu])
+ permission_role = create(:project_role, name: "accessgranted", permissions: [:manage_wiki_menu])
member = create(:member, principal: admin_user, user: admin_user, project: @project, roles: [permission_role])
- get 'edit', params: @params
+ get "edit", params: @params
expect(response).to be_successful
end
end
- describe 'w/o valid auth' do
- it 'be forbidden' do
+ describe "w/o valid auth" do
+ it "be forbidden" do
allow(User).to receive(:current).and_return create(:user)
- get 'edit', params: @params
+ get "edit", params: @params
expect(response.status).to eq(403) # forbidden
end
diff --git a/spec/controllers/wiki_menu_items_controller_spec.rb b/spec/controllers/wiki_menu_items_controller_spec.rb
index 9ebf004b18fb..507185359dbe 100644
--- a/spec/controllers/wiki_menu_items_controller_spec.rb
+++ b/spec/controllers/wiki_menu_items_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WikiMenuItemsController do
let(:current_user) { create(:admin) }
@@ -45,7 +45,7 @@
allow(User).to receive(:current).and_return current_user
end
- describe '#edit' do
+ describe "#edit" do
# more wiki pages with menu items
let(:another_wiki_page) { create(:wiki_page, wiki:) } # second wiki page with two child pages
let!(:another_wiki_page_top_level_wiki_menu_item) do
@@ -63,19 +63,19 @@
let(:grand_child_page) { create(:wiki_page, parent: child_page, wiki:) }
let!(:grand_child_page_wiki_menu_item) { create(:wiki_menu_item, wiki:, name: grand_child_page.slug) }
- context 'when no parent wiki menu item has been configured yet' do
- context 'and it is a child page' do
+ context "when no parent wiki menu item has been configured yet" do
+ context "and it is a child page" do
before { get :edit, params: { project_id: project.id, id: child_page.slug } }
subject { response }
- it 'preselects the wiki menu item of the parent page as parent wiki menu item option' do
- expect(assigns['selected_parent_menu_item_id']).to eq(another_wiki_page_top_level_wiki_menu_item.id)
+ it "preselects the wiki menu item of the parent page as parent wiki menu item option" do
+ expect(assigns["selected_parent_menu_item_id"]).to eq(another_wiki_page_top_level_wiki_menu_item.id)
# see FIXME in menu_helper.rb
end
end
- context 'and it is a grand child page the parent of which is not a main item' do
+ context "and it is a grand child page the parent of which is not a main item" do
before do
# ensure the parent page of grand_child_page is not a main item
child_page_wiki_menu_item.tap { |page| page.parent = top_level_wiki_menu_item }.save
@@ -84,38 +84,38 @@
subject { response }
- it 'preselects the wiki menu item of the grand parent page as parent wiki menu item option' do
- expect(assigns['selected_parent_menu_item_id']).to eq(another_wiki_page_top_level_wiki_menu_item.id)
+ it "preselects the wiki menu item of the grand parent page as parent wiki menu item option" do
+ expect(assigns["selected_parent_menu_item_id"]).to eq(another_wiki_page_top_level_wiki_menu_item.id)
end
end
end
- context 'when a parent wiki menu item has already been configured' do
+ context "when a parent wiki menu item has already been configured" do
before { get :edit, params: { project_id: project.id, id: another_child_page.slug } }
subject { response }
- it 'preselects the parent wiki menu item that is already assigned' do
- expect(assigns['selected_parent_menu_item_id']).to eq(top_level_wiki_menu_item.id)
+ it "preselects the parent wiki menu item that is already assigned" do
+ expect(assigns["selected_parent_menu_item_id"]).to eq(top_level_wiki_menu_item.id)
end
end
end
- shared_context 'when there is one more wiki page with a child page' do
+ shared_context "when there is one more wiki page with a child page" do
let!(:child_page) { create(:wiki_page, parent: wiki_page, wiki:) }
let!(:another_wiki_page) { create(:wiki_page, wiki:) } # second wiki page with two child pages
let!(:another_child_page) { create(:wiki_page, parent: another_wiki_page, wiki:) }
end
- describe '#select_main_menu_item' do
- include_context 'when there is one more wiki page with a child page'
+ describe "#select_main_menu_item" do
+ include_context "when there is one more wiki page with a child page"
before { get :select_main_menu_item, params: { project_id: project, id: wiki_page.id } }
- subject { assigns['possible_wiki_pages'] }
+ subject { assigns["possible_wiki_pages"] }
- context 'when selecting a new wiki page to replace the current main menu item' do
+ context "when selecting a new wiki page to replace the current main menu item" do
it { is_expected.to include wiki_page }
it { is_expected.to include child_page }
it { is_expected.to include another_wiki_page }
@@ -123,10 +123,10 @@
end
end
- describe '#replace_main_menu_item' do
- include_context 'when there is one more wiki page with a child page'
+ describe "#replace_main_menu_item" do
+ include_context "when there is one more wiki page with a child page"
- context 'when another wiki page is selected for replacement' do
+ context "when another wiki page is selected for replacement" do
let(:selected_page) { child_page }
let(:new_menu_item) { selected_page.menu_item }
@@ -139,21 +139,21 @@
}
end
- it 'destroys the current wiki menu item' do
+ it "destroys the current wiki menu item" do
expect(wiki_page.menu_item).to be_nil
end
- it 'creates a new main menu item for the selected wiki page' do
+ it "creates a new main menu item for the selected wiki page" do
expect(selected_page.menu_item).to be_present
expect(selected_page.menu_item.parent).to be_nil
end
- it 'transfers the menu item options to the selected wiki page' do
+ it "transfers the menu item options to the selected wiki page" do
expect(new_menu_item.options).to eq(index_page: true, new_wiki_page: true)
end
end
- context 'when its own wiki page is selected for replacement' do
+ context "when its own wiki page is selected for replacement" do
let!(:wiki_menu_item) { wiki_page.menu_item }
before do
@@ -165,7 +165,7 @@
}
end
- it 'does not destroy the wiki menu item' do
+ it "does not destroy the wiki menu item" do
expect(wiki_menu_item.reload).to be_present
end
end
diff --git a/spec/controllers/work_packages/auto_completes_controller_spec.rb b/spec/controllers/work_packages/auto_completes_controller_spec.rb
index 4d6c2b0037ce..e1eafd6ab8c2 100644
--- a/spec/controllers/work_packages/auto_completes_controller_spec.rb
+++ b/spec/controllers/work_packages/auto_completes_controller_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WorkPackages::AutoCompletesController do
let(:user) { create(:user) }
@@ -49,13 +49,13 @@
let(:work_package_2) do
create(:work_package,
- subject: 'Error when updating a recipe',
+ subject: "Error when updating a recipe",
project:)
end
let(:work_package_3) do
create(:work_package,
- subject: 'Lorem ipsum',
+ subject: "Lorem ipsum",
project:)
end
@@ -69,37 +69,37 @@
work_package_3
end
- shared_examples_for 'successful response' do
+ shared_examples_for "successful response" do
subject { response }
it { is_expected.to be_successful }
end
- shared_examples_for 'contains expected values' do
+ shared_examples_for "contains expected values" do
subject { assigns(:work_packages) }
it { is_expected.to include(*expected_values) }
end
- describe '#work_packages' do
- describe 'search is case insensitive' do
+ describe "#work_packages" do
+ describe "search is case insensitive" do
let(:expected_values) { [work_package_1, work_package_2] }
before do
get :index,
params: {
project_id: project.id,
- q: 'ReCiPe'
+ q: "ReCiPe"
},
format: :json
end
- it_behaves_like 'successful response'
+ it_behaves_like "successful response"
- it_behaves_like 'contains expected values'
+ it_behaves_like "contains expected values"
end
- describe 'returns work package for given id' do
+ describe "returns work package for given id" do
let(:expected_values) { work_package_1 }
before do
@@ -111,12 +111,12 @@
format: :json
end
- it_behaves_like 'successful response'
+ it_behaves_like "successful response"
- it_behaves_like 'contains expected values'
+ it_behaves_like "contains expected values"
end
- describe 'returns work package for given id' do
+ describe "returns work package for given id" do
# this relies on all expected work packages to have ids that contain the given string
# we do not want to have work_package_3 so we take it's id + 1 to create a string
# we are sure to not be part of work_package_3's id.
@@ -156,11 +156,11 @@
format: :json
end
- it_behaves_like 'successful response'
+ it_behaves_like "successful response"
- it_behaves_like 'contains expected values'
+ it_behaves_like "contains expected values"
- context 'uniq' do
+ context "uniq" do
let(:assigned) { assigns(:work_packages) }
subject { assigned.size }
@@ -169,7 +169,7 @@
end
end
- describe 'returns work package for given id' do
+ describe "returns work package for given id" do
render_views
let(:work_package_4) do
create(:work_package,
@@ -187,15 +187,15 @@
format: :json
end
- it_behaves_like 'successful response'
- it_behaves_like 'contains expected values'
+ it_behaves_like "successful response"
+ it_behaves_like "contains expected values"
- it 'escapes html' do
- expect(response.body).not_to include ''
]
end
@@ -87,25 +87,25 @@
visit project_wiki_path(project, :wiki)
# Set value
- find('.ck-content').base.send_keys(wiki_body)
- click_button 'Save'
+ find(".ck-content").base.send_keys(wiki_body)
+ click_button "Save"
- expect(page).to have_css('.title-container h2', text: 'Wiki')
- expect(page).to have_css('a.wiki-page', count: 5)
+ expect(page).to have_css(".title-container h2", text: "Wiki")
+ expect(page).to have_css("a.wiki-page", count: 5)
end
- it 'shows renders correct links' do
+ it "shows renders correct links" do
expected_titles.each_with_index do |title, i|
visit project_wiki_path(project, :wiki)
- expect(page).to have_css('div.wiki-content')
- target_link = all('div.wiki-content a.wiki-page')[i]
+ expect(page).to have_css("div.wiki-content")
+ target_link = all("div.wiki-content a.wiki-page")[i]
expect(target_link.text).to eq(title)
expect(target_link[:href]).to match("/wiki/#{expected_slugs[i]}")
target_link.click
- expect(page).to have_css('.title-container h2', text: title)
+ expect(page).to have_css(".title-container h2", text: title)
end
end
end
diff --git a/spec/features/work_package_show_spec.rb b/spec/features/work_package_show_spec.rb
index 88336e5d2545..c6bfa27491f5 100644
--- a/spec/features/work_package_show_spec.rb
+++ b/spec/features/work_package_show_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package show page', :selenium do
+RSpec.describe "Work package show page", :selenium do
let(:user) { create(:admin) }
let(:project) { create(:project) }
let(:work_package) do
@@ -43,7 +43,7 @@
work_package.save!
end
- it 'all different angular based work package views', :js do
+ it "all different angular based work package views", :js do
wp_page = Pages::FullWorkPackage.new(work_package)
wp_page.visit!
diff --git a/spec/features/work_packages/attribute_help_texts_spec.rb b/spec/features/work_packages/attribute_help_texts_spec.rb
index 383cdb20719a..253082a3dad3 100644
--- a/spec/features/work_packages/attribute_help_texts_spec.rb
+++ b/spec/features/work_packages/attribute_help_texts_spec.rb
@@ -26,16 +26,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package attribute help texts', :js do
+RSpec.describe "Work package attribute help texts", :js do
let(:project) { create(:project) }
let(:work_package) { create(:work_package, project:) }
let(:instance) do
create(:work_package_help_text,
attribute_name: :status,
- help_text: 'Some **help text** for status.')
+ help_text: "Some **help text** for status.")
end
let(:modal) { Components::AttributeHelpTextModal.new(instance) }
@@ -50,30 +50,30 @@
wp_page.ensure_page_loaded
end
- shared_examples 'allows to view help texts' do
- it 'shows an indicator for whatever help text exists' do
+ shared_examples "allows to view help texts" do
+ it "shows an indicator for whatever help text exists" do
expect(page).to have_css('.work-package--single-view [data-qa-help-text-for="status"]')
# Open help text modal
modal.open!
- expect(modal.modal_container).to have_css('strong', text: 'help text')
+ expect(modal.modal_container).to have_css("strong", text: "help text")
modal.expect_edit(editable: user.allowed_globally?(:edit_attribute_help_texts))
modal.close!
end
end
- describe 'as admin' do
+ describe "as admin" do
let(:user) { create(:admin) }
- it_behaves_like 'allows to view help texts'
+ it_behaves_like "allows to view help texts"
end
- describe 'as regular user' do
+ describe "as regular user" do
let(:user) do
create(:user, member_with_permissions: { project => [:view_work_packages] })
end
- it_behaves_like 'allows to view help texts'
+ it_behaves_like "allows to view help texts"
end
end
diff --git a/spec/features/work_packages/bulk/copy_work_package_spec.rb b/spec/features/work_packages/bulk/copy_work_package_spec.rb
index 668fe743005e..d9ffe06b2f4c 100644
--- a/spec/features/work_packages/bulk/copy_work_package_spec.rb
+++ b/spec/features/work_packages/bulk/copy_work_package_spec.rb
@@ -1,26 +1,26 @@
-require 'spec_helper'
-require 'features/page_objects/notification'
-require 'support/components/autocompleter/ng_select_autocomplete_helpers'
+require "spec_helper"
+require "features/page_objects/notification"
+require "support/components/autocompleter/ng_select_autocomplete_helpers"
-RSpec.describe 'Copy work packages through Rails view', :js, :with_cuprite do
+RSpec.describe "Copy work packages through Rails view", :js, :with_cuprite do
include Components::Autocompleter::NgSelectAutocompleteHelpers
- shared_let(:type) { create(:type, name: 'Bug') }
- shared_let(:type2) { create(:type, name: 'Risk') }
+ shared_let(:type) { create(:type, name: "Bug") }
+ shared_let(:type2) { create(:type, name: "Risk") }
- shared_let(:project) { create(:project, name: 'Source', types: [type, type2]) }
- shared_let(:project2) { create(:project, name: 'Target', types: [type, type2]) }
+ shared_let(:project) { create(:project, name: "Source", types: [type, type2]) }
+ shared_let(:project2) { create(:project, name: "Target", types: [type, type2]) }
shared_let(:dev) do
create(:user,
- firstname: 'Dev',
- lastname: 'Guy',
+ firstname: "Dev",
+ lastname: "Guy",
member_with_permissions: { project => %i[view_work_packages work_package_assigned] })
end
shared_let(:mover) do
create(:user,
- firstname: 'Manager',
- lastname: 'Guy',
+ firstname: "Manager",
+ lastname: "Guy",
member_with_permissions: {
project => %i[view_work_packages copy_work_packages move_work_packages manage_subtasks assign_versions
add_work_packages],
@@ -54,42 +54,42 @@
wp_table.expect_work_package_listed work_package, work_package2
end
- describe 'copying work packages' do
+ describe "copying work packages" do
before do
# Select all work packages
- find('body').send_keys [:control, 'a']
+ find("body").send_keys [:control, "a"]
end
- context 'with permission' do
+ context "with permission" do
let(:current_user) { mover }
let(:wp_table_target) { Pages::WorkPackagesTable.new(project2) }
before do
wp_table.expect_work_package_count 2
context_menu.open_for work_package
- context_menu.choose 'Bulk copy'
+ context_menu.choose "Bulk copy"
- expect(page).to have_css('#new_project_id') # rubocop:disable RSpec/ExpectInHook
+ expect(page).to have_css("#new_project_id") # rubocop:disable RSpec/ExpectInHook
wait_for_network_idle
expect_page_reload do
- select_autocomplete page.find_test_selector('new_project_id'),
+ select_autocomplete page.find_test_selector("new_project_id"),
query: project2.name,
select_text: project2.name,
- results_selector: 'body'
+ results_selector: "body"
end
wait_for_network_idle # wait for the change of target project to finish updating the page
end
- it 'sets the version on copy and leaves a note' do
- select version.name, from: 'version_id'
- notes.set_markdown 'A note on copy'
- click_on 'Copy and follow'
+ it "sets the version on copy and leaves a note" do
+ select version.name, from: "version_id"
+ notes.set_markdown "A note on copy"
+ click_on "Copy and follow"
wp_table_target.expect_current_path
wp_table_target.expect_work_package_count 2
- expect(page).to have_css('#projects-menu', text: 'Target')
+ expect(page).to have_css("#projects-menu", text: "Target")
# Should not move the sources
work_package2.reload
@@ -99,17 +99,17 @@
copied_wps = WorkPackage.last(2)
expect(copied_wps.map(&:project_id).uniq).to eq([project2.id])
expect(copied_wps.map(&:version_id).uniq).to eq([version.id])
- expect(copied_wps.map { |wp| wp.journals.last.notes }.uniq).to eq(['A note on copy'])
+ expect(copied_wps.map { |wp| wp.journals.last.notes }.uniq).to eq(["A note on copy"])
end
- context 'when the limit to move in the frontend is 1',
+ context "when the limit to move in the frontend is 1",
with_settings: { work_packages_bulk_request_limit: 1 } do
- it 'copies them in the background and shows a status page' do
- select version.name, from: 'version_id'
- notes.set_markdown 'A note on copy'
- click_on 'Copy and follow'
+ it "copies them in the background and shows a status page" do
+ select version.name, from: "version_id"
+ notes.set_markdown "A note on copy"
+ click_on "Copy and follow"
- expect(page).to have_text 'The job has been queued and will be processed shortly.'
+ expect(page).to have_text "The job has been queued and will be processed shortly."
perform_enqueued_jobs
@@ -118,7 +118,7 @@
end
end
- context 'with a work package having a child' do
+ context "with a work package having a child" do
let!(:child) do
create(:work_package,
author: dev,
@@ -138,26 +138,26 @@
wp_table.visit!
expect_angular_frontend_initialized
wp_table.expect_work_package_listed work_package, work_package2, child
- find('body').send_keys [:control, 'a']
+ find("body").send_keys [:control, "a"]
wp_table.expect_work_package_count 3
context_menu.open_for work_package
- context_menu.choose 'Bulk copy'
+ context_menu.choose "Bulk copy"
- expect(page).to have_css('#new_project_id') # rubocop:disable RSpec/ExpectInHook
+ expect(page).to have_css("#new_project_id") # rubocop:disable RSpec/ExpectInHook
expect_page_reload do
- select_autocomplete page.find_test_selector('new_project_id'),
+ select_autocomplete page.find_test_selector("new_project_id"),
query: project2.name,
select_text: project2.name,
- results_selector: 'body'
+ results_selector: "body"
end
sleep(1) # wait for the change of target project to finish updating the page
end
- it 'copies WPs with parent/child hierarchy and relations maintained' do
- click_on 'Copy and follow'
+ it "copies WPs with parent/child hierarchy and relations maintained" do
+ click_on "Copy and follow"
wp_table_target.expect_current_path
- expect(page).to have_css('#projects-menu', text: 'Target')
+ expect(page).to have_css("#projects-menu", text: "Target")
# Should not move the sources
expect(work_package.reload.project_id).to eq(project.id)
@@ -185,7 +185,7 @@
end
end
- context 'when the target project does not have the type' do
+ context "when the target project does not have the type" do
let!(:child) do
create(:work_package,
author: dev,
@@ -198,55 +198,55 @@
project2.types = [type2]
end
- it 'fails, informing of the reasons' do
- click_on 'Copy and follow'
+ it "fails, informing of the reasons" do
+ click_on "Copy and follow"
expect(page)
.to have_css(
- '.op-toast.-error',
- text: I18n.t('work_packages.bulk.none_could_be_saved', total: 3)
+ ".op-toast.-error",
+ text: I18n.t("work_packages.bulk.none_could_be_saved", total: 3)
)
expect(page)
.to have_css(
- '.op-toast.-error',
- text: I18n.t('work_packages.bulk.selected_because_descendants', total: 3, selected: 2)
+ ".op-toast.-error",
+ text: I18n.t("work_packages.bulk.selected_because_descendants", total: 3, selected: 2)
)
expect(page)
.to have_css(
- '.op-toast.-error',
+ ".op-toast.-error",
text: "#{work_package.id}: Type #{I18n.t('activerecord.errors.messages.inclusion')}"
)
expect(page)
.to have_css(
- '.op-toast.-error',
+ ".op-toast.-error",
text: "#{work_package2.id}: Type #{I18n.t('activerecord.errors.messages.inclusion')}"
)
expect(page)
.to have_css(
- '.op-toast.-error',
+ ".op-toast.-error",
text: "#{child.id} (descendant of selected): Type #{I18n.t('activerecord.errors.messages.inclusion')}"
)
end
- context 'when the limit to move in the frontend is 0',
+ context "when the limit to move in the frontend is 0",
with_settings: { work_packages_bulk_request_limit: 0 } do
- it 'shows the errors properly in the frontend' do
- click_on 'Copy and follow'
+ it "shows the errors properly in the frontend" do
+ click_on "Copy and follow"
- expect(page).to have_text 'The job has been queued and will be processed shortly.'
+ expect(page).to have_text "The job has been queued and will be processed shortly."
perform_enqueued_jobs
- expect(page).to have_text 'The work packages could not be copied.', wait: 10
+ expect(page).to have_text "The work packages could not be copied.", wait: 10
- expect(page).to have_text I18n.t('work_packages.bulk.none_could_be_saved', total: 3)
+ expect(page).to have_text I18n.t("work_packages.bulk.none_could_be_saved", total: 3)
expect(page)
- .to have_text I18n.t('work_packages.bulk.selected_because_descendants', total: 3, selected: 2)
+ .to have_text I18n.t("work_packages.bulk.selected_because_descendants", total: 3, selected: 2)
expect(page)
.to have_text "#{work_package.id}: Type #{I18n.t('activerecord.errors.messages.inclusion')}"
@@ -261,27 +261,27 @@
end
end
- context 'without permission' do
+ context "without permission" do
let(:current_user) { dev }
- it 'does not allow to copy' do
+ it "does not allow to copy" do
context_menu.open_for work_package
- context_menu.expect_no_options 'Bulk copy'
+ context_menu.expect_no_options "Bulk copy"
end
end
end
- describe 'copying work package to clipboard' do
+ describe "copying work package to clipboard" do
let(:current_user) { dev }
let(:wp_table_target) { Pages::WorkPackagesTable.new(project2) }
before do
wp_table.expect_work_package_count 2
context_menu.open_for work_package
- context_menu.choose 'Copy link to clipboard'
+ context_menu.choose "Copy link to clipboard"
end
- it 'successfully copies the short url of the work package' do
+ it "successfully copies the short url of the work package" do
# We cannot access the navigator.clipboard from a headless browser.
# This test makes sure the copy to clipboard logic is working,
# regardless of the browser permissions.
@@ -289,7 +289,7 @@
end
end
- describe 'unsetting the assignee as the current assignee is not a member in the project' do
+ describe "unsetting the assignee as the current assignee is not a member in the project" do
let(:work_packages) { [work_package] }
let(:current_user) { mover }
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
@@ -299,30 +299,30 @@
work_package.save
end
- it 'copies the work package' do
+ it "copies the work package" do
context_menu.open_for work_package
- context_menu.choose 'Copy to other project'
+ context_menu.choose "Copy to other project"
# On work packages move page
expect_page_reload do
- select_autocomplete page.find_test_selector('new_project_id'),
+ select_autocomplete page.find_test_selector("new_project_id"),
query: project2.name,
select_text: project2.name,
- results_selector: 'body'
+ results_selector: "body"
end
wait_for_network_idle # wait for page reload after selecting the target project
- select 'nobody', from: 'Assignee'
+ select "nobody", from: "Assignee"
- click_on 'Copy and follow'
+ click_on "Copy and follow"
expect(page)
- .to have_css('.op-toast.-success',
+ .to have_css(".op-toast.-success",
text: I18n.t(:notice_successful_create))
wp_page = Pages::FullWorkPackage.new(WorkPackage.last)
- wp_page.expect_attributes assignee: '-'
+ wp_page.expect_attributes assignee: "-"
end
end
end
diff --git a/spec/features/work_packages/bulk/move_work_package_spec.rb b/spec/features/work_packages/bulk/move_work_package_spec.rb
index 21dd70e0ccf2..43f3b35bf9d8 100644
--- a/spec/features/work_packages/bulk/move_work_package_spec.rb
+++ b/spec/features/work_packages/bulk/move_work_package_spec.rb
@@ -1,8 +1,8 @@
-require 'spec_helper'
-require 'features/page_objects/notification'
-require 'support/components/autocompleter/ng_select_autocomplete_helpers'
+require "spec_helper"
+require "features/page_objects/notification"
+require "support/components/autocompleter/ng_select_autocomplete_helpers"
-RSpec.describe 'Moving a work package through Rails view', :js do
+RSpec.describe "Moving a work package through Rails view", :js do
include Components::Autocompleter::NgSelectAutocompleteHelpers
let(:dev_role) do
@@ -15,22 +15,22 @@
end
let(:dev) do
create(:user,
- firstname: 'Dev',
- lastname: 'Guy',
+ firstname: "Dev",
+ lastname: "Guy",
member_with_roles: { project => dev_role })
end
let(:mover) do
create(:admin,
- firstname: 'Manager',
- lastname: 'Guy',
+ firstname: "Manager",
+ lastname: "Guy",
member_with_roles: { project => mover_role })
end
- let(:type) { create(:type, name: 'Bug') }
- let(:type2) { create(:type, name: 'Risk') }
+ let(:type) { create(:type, name: "Bug") }
+ let(:type2) { create(:type, name: "Risk") }
- let!(:project) { create(:project, name: 'Source', types: [type, type2]) }
- let!(:project2) { create(:project, name: 'Target', types: [type, type2]) }
+ let!(:project) { create(:project, name: "Source", types: [type, type2]) }
+ let!(:project2) { create(:project, name: "Target", types: [type, type2]) }
let(:work_package) do
create(:work_package,
@@ -62,7 +62,7 @@
expect_angular_frontend_initialized
end
- describe 'moving a work package and its children' do
+ describe "moving a work package and its children" do
let(:work_packages) { [work_package, child_wp] }
let(:child_wp) do
create(:work_package,
@@ -73,19 +73,19 @@
status:)
end
- context 'with permission' do
+ context "with permission" do
before do
expect(child_wp.project_id).to eq(project.id)
context_menu.open_for work_package
- context_menu.choose 'Change project'
+ context_menu.choose "Change project"
# On work packages move page
- expect(page).to have_css('#new_project_id')
- select_autocomplete page.find_test_selector('new_project_id'),
- query: 'Target',
- select_text: 'Target',
- results_selector: 'body'
+ expect(page).to have_css("#new_project_id")
+ select_autocomplete page.find_test_selector("new_project_id"),
+ query: "Target",
+ select_text: "Target",
+ results_selector: "body"
if using_cuprite?
wait_for_network_idle
else
@@ -93,14 +93,14 @@
end
end
- context 'when the limit to move in the frontend is 1',
+ context "when the limit to move in the frontend is 1",
with_settings: { work_packages_bulk_request_limit: 1 } do
- it 'copies them in the background and shows a status page', :with_cuprite do
- click_on 'Move and follow'
+ it "copies them in the background and shows a status page", :with_cuprite do
+ click_on "Move and follow"
wait_for_reload
- page.find_test_selector('job-status--header')
+ page.find_test_selector("job-status--header")
- expect(page).to have_text 'The job has been queued and will be processed shortly.'
+ expect(page).to have_text "The job has been queued and will be processed shortly."
perform_enqueued_jobs
@@ -108,29 +108,29 @@
expect(work_package.project_id).to eq(project2.id)
expect(page).to have_current_path "/projects/#{project2.identifier}/work_packages/#{work_package.id}/activity"
- page.find_by_id('projects-menu', text: 'Target')
+ page.find_by_id("projects-menu", text: "Target")
end
end
- it 'moves parent and child wp to a new project', :with_cuprite do
- click_on 'Move and follow'
+ it "moves parent and child wp to a new project", :with_cuprite do
+ click_on "Move and follow"
wait_for_reload
- page.find('.inline-edit--container.subject', text: work_package.subject)
- page.find_by_id('projects-menu', text: 'Target')
+ page.find(".inline-edit--container.subject", text: work_package.subject)
+ page.find_by_id("projects-menu", text: "Target")
# Should move its children
child_wp.reload
expect(child_wp.project_id).to eq(project2.id)
end
- context 'when the target project does not have the type' do
- let!(:project2) { create(:project, name: 'Target', types: [type2]) }
+ context "when the target project does not have the type" do
+ let!(:project2) { create(:project, name: "Target", types: [type2]) }
- it 'does moves the work package and changes the type', :with_cuprite do
- click_on 'Move and follow'
+ it "does moves the work package and changes the type", :with_cuprite do
+ click_on "Move and follow"
wait_for_reload
- page.find('.inline-edit--container.subject', text: work_package.subject)
- page.find_by_id('projects-menu', text: 'Target')
+ page.find(".inline-edit--container.subject", text: work_package.subject)
+ page.find_by_id("projects-menu", text: "Target")
# Should NOT have moved
child_wp.reload
@@ -142,24 +142,24 @@
end
end
- context 'when the target project has a type with a required field' do
+ context "when the target project has a type with a required field" do
let(:required_cf) { create(:integer_wp_custom_field, is_required: true) }
- let(:type2) { create(:type, name: 'Risk', custom_fields: [required_cf]) }
- let!(:project2) { create(:project, name: 'Target', types: [type2], work_package_custom_fields: [required_cf]) }
+ let(:type2) { create(:type, name: "Risk", custom_fields: [required_cf]) }
+ let!(:project2) { create(:project, name: "Target", types: [type2], work_package_custom_fields: [required_cf]) }
- it 'does not moves the work package when the required field is missing' do
+ it "does not moves the work package when the required field is missing" do
select "Risk", from: "Type"
expect(page).to have_field(required_cf.name)
# Clicking move and follow might be broken due to the location.href
# in the refresh-on-form-changes component
retry_block do
- click_on 'Move and follow'
+ click_on "Move and follow"
end
expect(page)
- .to have_css('.op-toast.-error',
- text: I18n.t(:'work_packages.bulk.none_could_be_saved',
+ .to have_css(".op-toast.-error",
+ text: I18n.t(:"work_packages.bulk.none_could_be_saved",
total: 1))
child_wp.reload
work_package.reload
@@ -169,17 +169,17 @@
expect(child_wp.type_id).to eq(type.id)
end
- it 'does moves the work package when the required field is set' do
+ it "does moves the work package when the required field is set" do
select "Risk", from: "Type"
- fill_in required_cf.name, with: '1'
+ fill_in required_cf.name, with: "1"
# Clicking move and follow might be broken due to the location.href
# in the refresh-on-form-changes component
retry_block do
- click_on 'Move and follow'
+ click_on "Move and follow"
end
- expect(page).to have_css('.op-toast.-success')
+ expect(page).to have_css(".op-toast.-success")
child_wp.reload
work_package.reload
@@ -191,51 +191,51 @@
end
end
- context 'without permission' do
+ context "without permission" do
let(:current_user) { dev }
- it 'does not allow to move' do
+ it "does not allow to move" do
context_menu.open_for work_package
- context_menu.expect_no_options 'Change project'
+ context_menu.expect_no_options "Change project"
end
end
end
- describe 'moving an unmovable (e.g. readonly status) and a movable work package', with_ee: %i[readonly_work_packages] do
+ describe "moving an unmovable (e.g. readonly status) and a movable work package", with_ee: %i[readonly_work_packages] do
let(:work_packages) { [work_package, work_package2] }
let(:work_package2_status) { create(:status, is_readonly: true) }
before do
loading_indicator_saveguard
# Select all work packages
- find('body').send_keys [:control, 'a']
+ find("body").send_keys [:control, "a"]
context_menu.open_for work_package2
- context_menu.choose 'Bulk change of project'
+ context_menu.choose "Bulk change of project"
# On work packages move page
- select_autocomplete page.find_test_selector('new_project_id'),
+ select_autocomplete page.find_test_selector("new_project_id"),
query: project2.name,
select_text: project2.name,
- results_selector: 'body'
- click_on 'Move and follow'
+ results_selector: "body"
+ click_on "Move and follow"
end
- it 'displays an error message explaining which work package could not be moved and why' do
+ it "displays an error message explaining which work package could not be moved and why" do
expect(page)
- .to have_css('.op-toast.-error',
- text: I18n.t('work_packages.bulk.could_not_be_saved'),
+ .to have_css(".op-toast.-error",
+ text: I18n.t("work_packages.bulk.could_not_be_saved"),
wait: 10)
expect(page)
.to have_css(
- '.op-toast.-error',
+ ".op-toast.-error",
text: "#{work_package2.id}: Project #{I18n.t('activerecord.errors.messages.error_readonly')}"
)
expect(page)
- .to have_css('.op-toast.-error',
- text: I18n.t('work_packages.bulk.x_out_of_y_could_be_saved',
+ .to have_css(".op-toast.-error",
+ text: I18n.t("work_packages.bulk.x_out_of_y_could_be_saved",
failing: 1,
total: 2,
success: 1))
diff --git a/spec/features/work_packages/bulk/update_work_package_spec.rb b/spec/features/work_packages/bulk/update_work_package_spec.rb
index 7f07d525b897..6689aff8ae9f 100644
--- a/spec/features/work_packages/bulk/update_work_package_spec.rb
+++ b/spec/features/work_packages/bulk/update_work_package_spec.rb
@@ -1,19 +1,19 @@
-require 'spec_helper'
-require 'features/page_objects/notification'
+require "spec_helper"
+require "features/page_objects/notification"
-RSpec.describe 'Bulk update work packages through Rails view', :js, :with_cuprite do
- shared_let(:type) { create(:type, name: 'Bug') }
- shared_let(:project) { create(:project, name: 'Source', types: [type]) }
+RSpec.describe "Bulk update work packages through Rails view", :js, :with_cuprite do
+ shared_let(:type) { create(:type, name: "Bug") }
+ shared_let(:project) { create(:project, name: "Source", types: [type]) }
shared_let(:status) { create(:status) }
shared_let(:custom_field) do
create(:string_wp_custom_field,
- name: 'Text CF',
+ name: "Text CF",
types: [type],
projects: [project])
end
shared_let(:custom_field_removed) do
create(:string_wp_custom_field,
- name: 'Text CF Removed',
+ name: "Text CF Removed",
types: [type],
projects: [project])
end
@@ -27,14 +27,14 @@
end
shared_let(:dev) do
create(:user,
- firstname: 'Dev',
- lastname: 'Guy',
+ firstname: "Dev",
+ lastname: "Guy",
member_with_roles: { project => dev_role })
end
shared_let(:mover) do
create(:admin,
- firstname: 'Manager',
- lastname: 'Guy',
+ firstname: "Manager",
+ lastname: "Guy",
member_with_roles: { project => mover_role })
end
@@ -75,22 +75,22 @@
wp_table.expect_work_package_listed work_package, work_package2
# Select all work packages
- find('body').send_keys [:control, 'a']
+ find("body").send_keys [:control, "a"]
end
- context 'with permission' do
+ context "with permission" do
let(:current_user) { mover }
before do
context_menu.open_for work_package
- context_menu.choose 'Bulk edit'
+ context_menu.choose "Bulk edit"
- notes.set_markdown('The typed note')
+ notes.set_markdown("The typed note")
end
- it 'sets status and leaves a note' do
- select status2.name, from: 'work_package_status_id'
- click_on 'Submit'
+ it "sets status and leaves a note" do
+ select status2.name, from: "work_package_status_id"
+ click_on "Submit"
expect_angular_frontend_initialized
wp_table.expect_work_package_count 2
@@ -100,32 +100,32 @@
.to eq([status2.id])
expect([work_package.journals.last.notes, work_package2.journals.last.notes].uniq)
- .to eq(['The typed note'])
+ .to eq(["The typed note"])
end
- context 'when making an error in the form' do
+ context "when making an error in the form" do
let(:work_package2_status) { create(:status) } # without creating a workflow
- it 'does not update the work packages' do
- select status2.name, from: 'work_package_status_id'
- fill_in 'Parent', with: '-1'
- click_on 'Submit'
+ it "does not update the work packages" do
+ select status2.name, from: "work_package_status_id"
+ fill_in "Parent", with: "-1"
+ click_on "Submit"
expect(page)
.to have_css(
- '.op-toast.-error',
- text: I18n.t('work_packages.bulk.none_could_be_saved', total: 2)
+ ".op-toast.-error",
+ text: I18n.t("work_packages.bulk.none_could_be_saved", total: 2)
)
expect(page)
.to have_css(
- '.op-toast.-error',
+ ".op-toast.-error",
text: "#{work_package.id}: Parent #{I18n.t('activerecord.errors.messages.does_not_exist')}"
)
expect(page)
.to have_css(
- '.op-toast.-error',
+ ".op-toast.-error",
text: <<~MSG.squish
#{work_package2.id}:
Parent #{I18n.t('activerecord.errors.messages.does_not_exist')}
@@ -141,27 +141,27 @@
end
end
- describe 'custom fields' do
- context 'when editing custom field of work packages with a readonly status (regression#44673)' do
+ describe "custom fields" do
+ context "when editing custom field of work packages with a readonly status (regression#44673)" do
let(:work_package2_status) { create(:status, :readonly) }
- context 'with enterprise', with_ee: %i[readonly_work_packages] do
- it 'does not update the work packages' do
+ context "with enterprise", with_ee: %i[readonly_work_packages] do
+ it "does not update the work packages" do
expect(work_package.send(custom_field.attribute_getter)).to be_nil
expect(work_package2.send(custom_field.attribute_getter)).to be_nil
- fill_in custom_field.name, with: 'Custom field text'
- click_on 'Submit'
+ fill_in custom_field.name, with: "Custom field text"
+ click_on "Submit"
expect(page)
.to have_css(
- '.op-toast.-error',
- text: I18n.t('work_packages.bulk.x_out_of_y_could_be_saved', total: 2, failing: 1, success: 1)
+ ".op-toast.-error",
+ text: I18n.t("work_packages.bulk.x_out_of_y_could_be_saved", total: 2, failing: 1, success: 1)
)
expect(page)
.to have_css(
- '.op-toast.-error',
+ ".op-toast.-error",
text: <<~MSG.squish
#{work_package2.id}:
#{custom_field.name} #{I18n.t('activerecord.errors.messages.error_readonly')}
@@ -174,60 +174,60 @@
work_package2.reload
expect(work_package.send(custom_field.attribute_getter))
- .to eq('Custom field text')
+ .to eq("Custom field text")
expect(work_package2.send(custom_field.attribute_getter))
.to be_nil
end
end
- context 'without enterprise', with_ee: false do
- it 'ignores the readonly status and updates the work packages' do
+ context "without enterprise", with_ee: false do
+ it "ignores the readonly status and updates the work packages" do
expect(work_package.send(custom_field.attribute_getter)).to be_nil
expect(work_package2.send(custom_field.attribute_getter)).to be_nil
- fill_in custom_field.name, with: 'Custom field text'
- click_on 'Submit'
+ fill_in custom_field.name, with: "Custom field text"
+ click_on "Submit"
- expect(page).to have_css('.op-toast.-success', text: I18n.t(:notice_successful_update))
+ expect(page).to have_css(".op-toast.-success", text: I18n.t(:notice_successful_update))
# Should update 2 work package custom fields
work_package.reload
work_package2.reload
expect(work_package.send(custom_field.attribute_getter))
- .to eq('Custom field text')
+ .to eq("Custom field text")
expect(work_package2.send(custom_field.attribute_getter))
- .to eq('Custom field text')
+ .to eq("Custom field text")
end
end
end
- describe 'unsetting values for different fields' do
+ describe "unsetting values for different fields" do
let(:boolean_cf) do
create(:boolean_wp_custom_field,
- name: 'Bool CF',
+ name: "Bool CF",
types: [type],
projects: [project])
end
let(:required_boolean_cf) do
create(:boolean_wp_custom_field,
- name: 'Required Bool CF',
+ name: "Required Bool CF",
types: [type],
projects: [project],
is_required: true)
end
let(:list_cf) do
create(:list_wp_custom_field,
- name: 'List CF',
+ name: "List CF",
types: [type],
projects: [project],
possible_values: %w[A B C])
end
let(:required_list_cf) do
create(:list_wp_custom_field,
- name: 'Required List CF',
+ name: "Required List CF",
types: [type],
projects: [project],
possible_values: %w[A B C],
@@ -235,20 +235,20 @@
end
let(:multi_list_cf) do
create(:list_wp_custom_field, :multi_list,
- name: 'Multi select List CF',
+ name: "Multi select List CF",
types: [type],
projects: [project],
possible_values: %w[A B C])
end
let(:user_cf) do
create(:user_wp_custom_field,
- name: 'User CF',
+ name: "User CF",
types: [type],
projects: [project])
end
let(:multi_user_cf) do
create(:user_wp_custom_field, :multi_user,
- name: 'Multi user CF',
+ name: "Multi user CF",
types: [type],
projects: [project])
end
@@ -274,33 +274,33 @@
wait_for_reload
end
- it 'clears the chosen values' do
+ it "clears the chosen values" do
# Required fields should not have a 'none' option
- expect(page).to have_no_select(required_boolean_cf.name, with_options: ['none'])
- expect(page).to have_no_select(required_list_cf.name, with_options: ['none'])
+ expect(page).to have_no_select(required_boolean_cf.name, with_options: ["none"])
+ expect(page).to have_no_select(required_list_cf.name, with_options: ["none"])
# Unset any non-required fields
- select 'none', from: boolean_cf.name
- select 'none', from: list_cf.name
- select 'none', from: multi_list_cf.name
- select 'nobody', from: user_cf.name
- select 'nobody', from: multi_user_cf.name
+ select "none", from: boolean_cf.name
+ select "none", from: list_cf.name
+ select "none", from: multi_list_cf.name
+ select "nobody", from: user_cf.name
+ select "nobody", from: multi_user_cf.name
- click_on 'Submit'
+ click_on "Submit"
expect_angular_frontend_initialized
wp_table.expect_work_package_count 2
# It clears all the values except the required fields
expect(work_package.reload.custom_field_values.pluck(:value).compact)
- .to eq(['f', required_list_cf.custom_options.find_by(value: "B").id.to_s])
+ .to eq(["f", required_list_cf.custom_options.find_by(value: "B").id.to_s])
expect(work_package2.reload.custom_field_values.pluck(:value).compact)
- .to eq(['f', required_list_cf.custom_options.find_by(value: "B").id.to_s])
+ .to eq(["f", required_list_cf.custom_options.find_by(value: "B").id.to_s])
end
end
- context 'when custom fields are removed from types' do
- it 'does not display them on the form' do
+ context "when custom fields are removed from types" do
+ it "does not display them on the form" do
expect(page).to have_field custom_field_removed.name
custom_field_removed.types = []
@@ -314,12 +314,12 @@
end
end
- context 'without permission' do
+ context "without permission" do
let(:current_user) { dev }
- it 'does not allow to copy' do
+ it "does not allow to copy" do
context_menu.open_for work_package
- context_menu.expect_no_options 'Bulk edit'
+ context_menu.expect_no_options "Bulk edit"
end
end
end
diff --git a/spec/features/work_packages/cancel_editing_spec.rb b/spec/features/work_packages/cancel_editing_spec.rb
index 038d1cd36944..8a16f99f4e11 100644
--- a/spec/features/work_packages/cancel_editing_spec.rb
+++ b/spec/features/work_packages/cancel_editing_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Cancel editing work package', :js do
+RSpec.describe "Cancel editing work package", :js do
let(:user) { create(:admin) }
let(:project) { create(:project) }
let(:work_package) { create(:work_package, project:) }
@@ -53,22 +53,22 @@
def expect_active_edit(path)
visit path
expect_angular_frontend_initialized
- expect(page).to have_css('#wp-new-inline-edit--field-subject', wait: 10)
+ expect(page).to have_css("#wp-new-inline-edit--field-subject", wait: 10)
end
def expect_subject(val)
- subject = page.find_by_id('wp-new-inline-edit--field-subject')
+ subject = page.find_by_id("wp-new-inline-edit--field-subject")
expect(subject.value).to eq(val)
end
def move_to_home_page(alert: true)
- find('.op-logo--link').click
+ find(".op-logo--link").click
page.driver.browser.switch_to.alert.accept if alert
- expect(page).to have_css('#projects-menu', text: 'Select a project')
+ expect(page).to have_css("#projects-menu", text: "Select a project")
end
- it 'does not show an alert when moving to other pages' do
+ it "does not show an alert when moving to other pages" do
# This used to show an alert until browsers dropped support
# for `onbeforeunload`.
#
@@ -84,7 +84,7 @@ def move_to_home_page(alert: true)
end
end
- it 'shows an alert when moving to other states' do
+ it "shows an alert when moving to other states" do
expect_active_edit(new_split_work_packages_path)
loading_indicator_saveguard
wp_table.expect_work_package_listed(work_package2)
@@ -92,11 +92,11 @@ def move_to_home_page(alert: true)
wp_table.open_split_view(work_package2)
page.driver.browser.switch_to.alert.dismiss
- expect(page).to have_css('#wp-new-inline-edit--field-subject')
+ expect(page).to have_css("#wp-new-inline-edit--field-subject")
expect(wp_page).not_to have_alert_dialog
end
- it 'shows an alert when moving to other states while editing a single attribute (Regression #25135)' do
+ it "shows an alert when moving to other states while editing a single attribute (Regression #25135)" do
wp_table.visit!
wp_table.expect_work_package_listed(work_package, work_package2)
@@ -119,45 +119,45 @@ def move_to_home_page(alert: true)
version.expect_inactive!
end
- it 'cancels the editing when clicking the button' do
+ it "cancels the editing when clicking the button" do
paths.each do |path|
expect_active_edit(path)
- find_by_id('work-packages--edit-actions-cancel').click
+ find_by_id("work-packages--edit-actions-cancel").click
expect(wp_page).not_to have_alert_dialog
end
end
- it 'allows to move from split to full screen in edit mode' do
+ it "allows to move from split to full screen in edit mode" do
# Start creating on split view
expect_active_edit(new_split_work_packages_path)
- find_by_id('wp-new-inline-edit--field-subject').set 'foobar'
+ find_by_id("wp-new-inline-edit--field-subject").set "foobar"
# Expect editing works when moving to full screen
- find('.work-packages-show-view-button').click
+ find(".work-packages-show-view-button").click
expect(wp_page).not_to have_alert_dialog
- expect(page).to have_css('#wp-new-inline-edit--field-subject')
- expect_subject('foobar')
+ expect(page).to have_css("#wp-new-inline-edit--field-subject")
+ expect_subject("foobar")
# Moving back also works
- page.execute_script('window.history.back()')
+ page.execute_script("window.history.back()")
expect(wp_page).not_to have_alert_dialog
- expect(page).to have_css('#wp-new-inline-edit--field-subject')
- expect_subject('foobar')
+ expect(page).to have_css("#wp-new-inline-edit--field-subject")
+ expect_subject("foobar")
# Cancel edition
- find_by_id('work-packages--edit-actions-cancel').click
+ find_by_id("work-packages--edit-actions-cancel").click
expect(wp_page).not_to have_alert_dialog
# Visiting another page does not create alert
- find('.op-logo--link').click
+ find(".op-logo--link").click
expect(wp_page).not_to have_alert_dialog
end
- it 'correctly cancels setting the back route (Regression #30714)' do
+ it "correctly cancels setting the back route (Regression #30714)" do
wp_page = Pages::FullWorkPackage.new work_package
wp_page.visit!
wp_page.ensure_page_loaded
@@ -165,7 +165,7 @@ def move_to_home_page(alert: true)
# Edit description in full view
description = wp_page.edit_field :description
description.activate!
- description.click_and_type_slowly 'foobar'
+ description.click_and_type_slowly "foobar"
# Try to move back to list, expect warning
wp_page.go_back
@@ -180,12 +180,12 @@ def move_to_home_page(alert: true)
wp_table.expect_work_package_listed(work_package, work_package2)
end
- context 'when user does not want to be warned' do
+ context "when user does not want to be warned" do
before do
create(:user_preference, user:, others: { warn_on_leaving_unsaved: false })
end
- it 'does not alert when moving anywhere' do
+ it "does not alert when moving anywhere" do
# Moving to angular states
expect_active_edit(new_split_work_packages_path)
wp_table.expect_work_package_listed(work_package2)
@@ -193,8 +193,8 @@ def move_to_home_page(alert: true)
wp_table.open_split_view(work_package2)
expect(wp_page).not_to have_alert_dialog
- expect(page).to have_no_css('#wp-new-inline-edit--field-subject')
- expect(page).to have_css('.work-packages--details--subject', text: work_package2.subject)
+ expect(page).to have_no_css("#wp-new-inline-edit--field-subject")
+ expect(page).to have_css(".work-packages--details--subject", text: work_package2.subject)
# Moving somewhere else
expect_active_edit(new_split_work_packages_path)
diff --git a/spec/features/work_packages/copy_spec.rb b/spec/features/work_packages/copy_spec.rb
index 53ccc792d3ba..4073eccc4c73 100644
--- a/spec/features/work_packages/copy_spec.rb
+++ b/spec/features/work_packages/copy_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package copy', :js, :selenium do
+RSpec.describe "Work package copy", :js, :selenium do
let(:user) do
create(:user,
member_with_roles: { project => create_role })
@@ -63,20 +63,20 @@
let(:role) { build(:project_role, permissions: %i[view_work_packages work_package_assigned]) }
let(:assignee) do
create(:user,
- firstname: 'An',
- lastname: 'assignee',
+ firstname: "An",
+ lastname: "assignee",
member_with_roles: { project => role })
end
let(:responsible) do
create(:user,
- firstname: 'The',
- lastname: 'responsible',
+ firstname: "The",
+ lastname: "responsible",
member_with_roles: { project => role })
end
let(:author) do
create(:user,
- firstname: 'The',
- lastname: 'author',
+ firstname: "The",
+ lastname: "author",
member_with_roles: { project => role })
end
let(:version) do
@@ -90,21 +90,21 @@
work_flow.save!
end
- it 'on fullscreen page' do
+ it "on fullscreen page" do
original_work_package_page = Pages::FullWorkPackage.new(original_work_package, project)
to_copy_work_package_page = original_work_package_page.visit_copy!
to_copy_work_package_page.expect_current_path
to_copy_work_package_page.expect_fully_loaded
- to_copy_work_package_page.update_attributes Description: 'Copied WP Description'
+ to_copy_work_package_page.update_attributes Description: "Copied WP Description"
to_copy_work_package_page.save!
- expect(page).to have_css('.op-toast--content',
- text: I18n.t('js.notice_successful_create'),
+ expect(page).to have_css(".op-toast--content",
+ text: I18n.t("js.notice_successful_create"),
wait: 20)
- copied_work_package = WorkPackage.order(created_at: 'desc').first
+ copied_work_package = WorkPackage.order(created_at: "desc").first
expect(copied_work_package).not_to eql original_work_package
@@ -112,7 +112,7 @@
work_package_page.ensure_page_loaded
work_package_page.expect_attributes Subject: original_work_package.subject,
- Description: 'Copied WP Description',
+ Description: "Copied WP Description",
Version: original_work_package.version,
Priority: original_work_package.priority,
Assignee: original_work_package.assigned_to.name,
@@ -123,41 +123,41 @@
work_package_page.visit_tab! :relations
expect_angular_frontend_initialized
- expect(page).to have_css('.relation-group--header', text: 'RELATED TO', wait: 20)
- expect(page).to have_test_selector('op-relation--row-subject', text: original_work_package.subject)
+ expect(page).to have_css(".relation-group--header", text: "RELATED TO", wait: 20)
+ expect(page).to have_test_selector("op-relation--row-subject", text: original_work_package.subject)
end
- describe 'when source work package has an attachment' do
- it 'still allows copying through menu (Regression #30518)' do
+ describe "when source work package has an attachment" do
+ it "still allows copying through menu (Regression #30518)" do
wp_page = Pages::FullWorkPackage.new(original_work_package, project)
wp_page.visit!
wp_page.ensure_page_loaded
# Go to add cost entry page
- find('#action-show-more-dropdown-menu .button').click
- find('.menu-item', text: 'Copy', exact_text: true).click
+ find("#action-show-more-dropdown-menu .button").click
+ find(".menu-item", text: "Copy", exact_text: true).click
to_copy_work_package_page = Pages::FullWorkPackageCreate.new(original_work_package:)
- to_copy_work_package_page.update_attributes Description: 'Copied WP Description'
+ to_copy_work_package_page.update_attributes Description: "Copied WP Description"
to_copy_work_package_page.save!
- to_copy_work_package_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_create')
+ to_copy_work_package_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_create")
end
end
- it 'on split screen page' do
+ it "on split screen page" do
original_work_package_page = Pages::SplitWorkPackage.new(original_work_package, project)
to_copy_work_package_page = original_work_package_page.visit_copy!
to_copy_work_package_page.expect_current_path
to_copy_work_package_page.expect_fully_loaded
- to_copy_work_package_page.update_attributes Description: 'Copied WP Description'
+ to_copy_work_package_page.update_attributes Description: "Copied WP Description"
to_copy_work_package_page.save!
- find('.op-toast--content', text: I18n.t('js.notice_successful_create'), wait: 20)
+ find(".op-toast--content", text: I18n.t("js.notice_successful_create"), wait: 20)
- copied_work_package = WorkPackage.order(created_at: 'desc').first
+ copied_work_package = WorkPackage.order(created_at: "desc").first
expect(copied_work_package).not_to eql original_work_package
@@ -165,7 +165,7 @@
work_package_page.ensure_page_loaded
work_package_page.expect_attributes Subject: original_work_package.subject,
- Description: 'Copied WP Description',
+ Description: "Copied WP Description",
Version: original_work_package.version,
Priority: original_work_package.priority,
Assignee: original_work_package.assigned_to,
@@ -174,9 +174,9 @@
work_package_page.expect_activity user, number: 1
work_package_page.expect_current_path
- work_package_page.visit_tab!('relations')
+ work_package_page.visit_tab!("relations")
expect_angular_frontend_initialized
- expect(page).to have_css('.relation-group--header', text: 'RELATED TO', wait: 20)
- expect(page).to have_test_selector('op-relation--row-subject', text: original_work_package.subject)
+ expect(page).to have_css(".relation-group--header", text: "RELATED TO", wait: 20)
+ expect(page).to have_test_selector("op-relation--row-subject", text: original_work_package.subject)
end
end
diff --git a/spec/features/work_packages/custom_actions/custom_actions_me_value_spec.rb b/spec/features/work_packages/custom_actions/custom_actions_me_value_spec.rb
index f6dcd7ea364e..6f1938bf9be5 100644
--- a/spec/features/work_packages/custom_actions/custom_actions_me_value_spec.rb
+++ b/spec/features/work_packages/custom_actions/custom_actions_me_value_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Custom actions me value', :js, :with_cuprite, with_ee: %i[custom_actions] do
+RSpec.describe "Custom actions me value", :js, :with_cuprite, with_ee: %i[custom_actions] do
shared_let(:admin) { create(:admin) }
let(:permissions) { %i(view_work_packages edit_work_packages) }
@@ -37,7 +37,7 @@
create(:user, member_with_roles: { project => role })
end
let(:type) { create(:type_task) }
- let(:project) { create(:project, types: [type], name: 'This project') }
+ let(:project) { create(:project, types: [type], name: "This project") }
let!(:custom_field) { create(:user_wp_custom_field, types: [type], projects: [project]) }
let!(:work_package) do
create(:work_package,
@@ -47,7 +47,7 @@
let(:wp_page) { Pages::FullWorkPackage.new(work_package) }
let(:default_priority) do
- create(:default_priority, name: 'Normal')
+ create(:default_priority, name: "Normal")
end
let(:index_ca_page) { Pages::Admin::CustomActions::Index.new }
@@ -55,26 +55,26 @@
login_as(admin)
end
- it 'can assign user custom field to self' do
+ it "can assign user custom field to self" do
# create custom action 'Unassign'
index_ca_page.visit!
new_ca_page = index_ca_page.new
- new_ca_page.set_name('Set CF to me')
- new_ca_page.add_action(custom_field.name, I18n.t('custom_actions.actions.assigned_to.executing_user_value'))
+ new_ca_page.set_name("Set CF to me")
+ new_ca_page.add_action(custom_field.name, I18n.t("custom_actions.actions.assigned_to.executing_user_value"))
new_ca_page.create
assign = CustomAction.last
expect(assign.actions.length).to eq(1)
expect(assign.conditions.length).to eq(0)
- expect(assign.actions.first.values).to eq(['current_user'])
+ expect(assign.actions.first.values).to eq(["current_user"])
login_as user
wp_page.visit!
- wp_page.expect_custom_action('Set CF to me')
- wp_page.click_custom_action('Set CF to me')
+ wp_page.expect_custom_action("Set CF to me")
+ wp_page.click_custom_action("Set CF to me")
wp_page.expect_attributes "customField#{custom_field.id}": user.name
end
end
diff --git a/spec/features/work_packages/custom_actions/custom_actions_spec.rb b/spec/features/work_packages/custom_actions/custom_actions_spec.rb
index d2690c01f2b4..f3f40b859dab 100644
--- a/spec/features/work_packages/custom_actions/custom_actions_spec.rb
+++ b/spec/features/work_packages/custom_actions/custom_actions_spec.rb
@@ -26,27 +26,27 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Custom actions', :js, :with_cuprite,
+RSpec.describe "Custom actions", :js, :with_cuprite,
with_ee: %i[custom_actions] do
shared_let(:admin) { create(:admin) }
shared_let(:permissions) { %i(view_work_packages edit_work_packages move_work_packages work_package_assigned) }
shared_let(:role) { create(:project_role, permissions:) }
shared_let(:other_role) { create(:project_role, permissions:) }
- shared_let(:project) { create(:project, name: 'This project') }
- shared_let(:other_project) { create(:project, name: 'Other project') }
+ shared_let(:project) { create(:project, name: "This project") }
+ shared_let(:other_project) { create(:project, name: "Other project") }
shared_let(:user) do
create(:user,
- firstname: 'A',
- lastname: 'User',
+ firstname: "A",
+ lastname: "User",
member_with_roles: { project => [role], other_project => [role] })
end
shared_let(:other_member_user) do
create(:user,
- firstname: 'Other member',
- lastname: 'User',
+ firstname: "Other member",
+ lastname: "User",
member_with_roles: { project => role })
end
@@ -60,21 +60,21 @@
let(:wp_page) { Pages::FullWorkPackage.new(work_package) }
let(:default_priority) do
- create(:default_priority, name: 'Normal')
+ create(:default_priority, name: "Normal")
end
let!(:immediate_priority) do
create(:issue_priority,
- name: 'At once',
+ name: "At once",
position: IssuePriority.maximum(:position) + 1)
end
let(:default_status) do
- create(:default_status, name: 'Default status')
+ create(:default_status, name: "Default status")
end
let(:closed_status) do
- create(:closed_status, name: 'Closed')
+ create(:closed_status, name: "Closed")
end
let(:rejected_status) do
- create(:closed_status, name: 'Rejected')
+ create(:closed_status, name: "Rejected")
end
let(:other_type) do
type = create(:type)
@@ -134,21 +134,21 @@
login_as admin
end
- it 'viewing workflow buttons' do
+ it "viewing workflow buttons" do
# create custom action 'Unassign'
index_ca_page.visit!
new_ca_page = index_ca_page.new
- new_ca_page.set_name('Unassign')
- new_ca_page.set_description('Removes the assignee')
- new_ca_page.add_action('Assignee', '-')
- new_ca_page.expect_action('assigned_to', nil)
+ new_ca_page.set_name("Unassign")
+ new_ca_page.set_description("Removes the assignee")
+ new_ca_page.add_action("Assignee", "-")
+ new_ca_page.expect_action("assigned_to", nil)
new_ca_page.create
index_ca_page.expect_current_path
- index_ca_page.expect_listed('Unassign')
+ index_ca_page.expect_listed("Unassign")
unassign = CustomAction.last
expect(unassign.actions.length).to eq(1)
@@ -158,22 +158,22 @@
new_ca_page = index_ca_page.new
- new_ca_page.set_name('Close')
+ new_ca_page.set_name("Close")
- new_ca_page.add_action('Status', 'Close')
- new_ca_page.expect_action('status', closed_status.id)
+ new_ca_page.add_action("Status", "Close")
+ new_ca_page.expect_action("status", closed_status.id)
- new_ca_page.set_condition('Role', role.name)
+ new_ca_page.set_condition("Role", role.name)
new_ca_page.expect_selected_option role.name
- new_ca_page.set_condition('Status', [default_status.name, rejected_status.name])
+ new_ca_page.set_condition("Status", [default_status.name, rejected_status.name])
new_ca_page.expect_selected_option default_status.name
new_ca_page.expect_selected_option rejected_status.name
new_ca_page.create
index_ca_page.expect_current_path
- index_ca_page.expect_listed('Unassign', 'Close')
+ index_ca_page.expect_listed("Unassign", "Close")
close = CustomAction.last
expect(close.actions.length).to eq(1)
@@ -182,22 +182,22 @@
# create custom action 'Escalate'
new_ca_page = index_ca_page.new
- new_ca_page.set_name('Escalate')
- new_ca_page.add_action('Priority', immediate_priority.name)
- new_ca_page.expect_action('priority', immediate_priority.id)
+ new_ca_page.set_name("Escalate")
+ new_ca_page.add_action("Priority", immediate_priority.name)
+ new_ca_page.expect_action("priority", immediate_priority.id)
- new_ca_page.add_action('Notify', other_member_user.name)
+ new_ca_page.add_action("Notify", other_member_user.name)
new_ca_page.expect_selected_option other_member_user.name
new_ca_page.add_action(list_custom_field.name, selected_list_custom_field_options.map(&:name))
- new_ca_page.expect_selected_option 'A'
- new_ca_page.expect_selected_option 'G'
+ new_ca_page.expect_selected_option "A"
+ new_ca_page.expect_selected_option "G"
new_ca_page.create
index_ca_page.expect_current_path
- index_ca_page.expect_listed('Unassign', 'Close', 'Escalate')
+ index_ca_page.expect_listed("Unassign", "Close", "Escalate")
escalate = CustomAction.last
expect(escalate.actions.length).to eq(3)
@@ -207,28 +207,28 @@
new_ca_page = index_ca_page.new
- new_ca_page.set_name('Reset')
+ new_ca_page.set_name("Reset")
- new_ca_page.add_action('Priority', default_priority.name)
- new_ca_page.expect_action('priority', default_priority.id)
+ new_ca_page.add_action("Priority", default_priority.name)
+ new_ca_page.expect_action("priority", default_priority.id)
- new_ca_page.add_action('Status', default_status.name)
- new_ca_page.expect_action('status', default_status.id)
+ new_ca_page.add_action("Status", default_status.name)
+ new_ca_page.expect_action("status", default_status.id)
- new_ca_page.add_action('Assignee', user.name)
- new_ca_page.expect_action('assigned_to', user.id)
+ new_ca_page.add_action("Assignee", user.name)
+ new_ca_page.expect_action("assigned_to", user.id)
# This custom field is not applicable
- new_ca_page.add_action(int_custom_field.name, '1')
- new_ca_page.expect_action(int_custom_field.attribute_name, '1')
+ new_ca_page.add_action(int_custom_field.name, "1")
+ new_ca_page.expect_action(int_custom_field.attribute_name, "1")
- new_ca_page.set_condition('Status', closed_status.name)
+ new_ca_page.set_condition("Status", closed_status.name)
new_ca_page.expect_selected_option closed_status.name
new_ca_page.create
index_ca_page.expect_current_path
- index_ca_page.expect_listed('Unassign', 'Close', 'Escalate', 'Reset')
+ index_ca_page.expect_listed("Unassign", "Close", "Escalate", "Reset")
reset = CustomAction.last
expect(reset.actions.length).to eq(4)
@@ -238,17 +238,17 @@
new_ca_page = index_ca_page.new
- new_ca_page.set_name('Other roles action')
+ new_ca_page.set_name("Other roles action")
- new_ca_page.add_action('Status', default_status.name)
- new_ca_page.expect_action('status', default_status.id)
+ new_ca_page.add_action("Status", default_status.name)
+ new_ca_page.expect_action("status", default_status.id)
- new_ca_page.set_condition('Role', other_role.name)
+ new_ca_page.set_condition("Role", other_role.name)
new_ca_page.expect_selected_option other_role.name
new_ca_page.create
index_ca_page.expect_current_path
- index_ca_page.expect_listed('Unassign', 'Close', 'Escalate', 'Reset', 'Other roles action')
+ index_ca_page.expect_listed("Unassign", "Close", "Escalate", "Reset", "Other roles action")
other_roles_action = CustomAction.last
expect(other_roles_action.actions.length).to eq(1)
@@ -259,36 +259,36 @@
new_ca_page = index_ca_page.new
retry_block do
- new_ca_page.set_name('Move project')
+ new_ca_page.set_name("Move project")
# Add date custom action which has a different admin layout
ignore_ferrum_javascript_error do
- select date_custom_field.name, from: 'Add action'
+ select date_custom_field.name, from: "Add action"
end
ignore_ferrum_javascript_error do
- select 'on', from: date_custom_field.name
+ select "on", from: date_custom_field.name
end
date = (Date.current + 5.days)
find("#custom_action_actions_custom_field_#{date_custom_field.id}_visible").click
- datepicker = Components::Datepicker.new 'body'
+ datepicker = Components::Datepicker.new "body"
datepicker.set_date date
- new_ca_page.add_action('Type', other_type.name)
- new_ca_page.expect_action('type', other_type.id)
+ new_ca_page.add_action("Type", other_type.name)
+ new_ca_page.expect_action("type", other_type.id)
- new_ca_page.add_action('Project', other_project.name)
- new_ca_page.expect_action('project', other_project.id)
+ new_ca_page.add_action("Project", other_project.name)
+ new_ca_page.expect_action("project", other_project.id)
- new_ca_page.set_condition('Project', project.name)
+ new_ca_page.set_condition("Project", project.name)
new_ca_page.expect_selected_option project.name
end
new_ca_page.create
index_ca_page.expect_current_path
- index_ca_page.expect_listed('Unassign', 'Close', 'Escalate', 'Reset', 'Other roles action', 'Move project')
+ index_ca_page.expect_listed("Unassign", "Close", "Escalate", "Reset", "Other roles action", "Move project")
move_project = CustomAction.last
expect(move_project.actions.length).to eq(3)
@@ -299,50 +299,50 @@
wp_page.visit!
- wp_page.expect_custom_action('Unassign')
- wp_page.expect_custom_action('Close')
- wp_page.expect_custom_action('Escalate')
- wp_page.expect_custom_action('Move project')
- wp_page.expect_no_custom_action('Reset')
- wp_page.expect_no_custom_action('Other roles action')
- wp_page.expect_custom_action_order('Unassign', 'Close', 'Escalate', 'Move project')
+ wp_page.expect_custom_action("Unassign")
+ wp_page.expect_custom_action("Close")
+ wp_page.expect_custom_action("Escalate")
+ wp_page.expect_custom_action("Move project")
+ wp_page.expect_no_custom_action("Reset")
+ wp_page.expect_no_custom_action("Other roles action")
+ wp_page.expect_custom_action_order("Unassign", "Close", "Escalate", "Move project")
- within('.custom-actions') do
+ within(".custom-actions") do
# When hovering over the button, the description is displayed
- button = find('.custom-action--button', text: 'Unassign')
- expect(button['title'])
- .to eql 'Removes the assignee'
+ button = find(".custom-action--button", text: "Unassign")
+ expect(button["title"])
+ .to eql "Removes the assignee"
end
- wp_page.click_custom_action('Unassign')
- wp_page.expect_attributes assignee: '-'
- within '.work-package-details-activities-list' do
+ wp_page.click_custom_action("Unassign")
+ wp_page.expect_attributes assignee: "-"
+ within ".work-package-details-activities-list" do
expect(page)
- .to have_css('.op-user-activity .op-user-activity--user-name',
+ .to have_css(".op-user-activity .op-user-activity--user-name",
text: user.name,
wait: 10)
end
- wp_page.click_custom_action('Escalate')
+ wp_page.click_custom_action("Escalate")
wp_page.expect_attributes priority: immediate_priority.name,
status: default_status.name,
- assignee: '-',
+ assignee: "-",
"customField#{list_custom_field.id}" => selected_list_custom_field_options.map(&:name).join("\n")
- within '.work-package-details-activities-list' do
+ within ".work-package-details-activities-list" do
expect(page)
- .to have_css('.op-user-activity a.user-mention',
+ .to have_css(".op-user-activity a.user-mention",
text: other_member_user.name,
wait: 10)
end
- wp_page.click_custom_action('Close')
+ wp_page.click_custom_action("Close")
wp_page.expect_attributes status: closed_status.name,
priority: immediate_priority.name
- wp_page.expect_custom_action('Reset')
- wp_page.expect_no_custom_action('Close')
+ wp_page.expect_custom_action("Reset")
+ wp_page.expect_no_custom_action("Close")
- wp_page.click_custom_action('Reset')
+ wp_page.click_custom_action("Reset")
wp_page.expect_attributes priority: default_priority.name,
status: default_status.name,
@@ -354,130 +354,130 @@
index_ca_page.visit!
- edit_ca_page = index_ca_page.edit('Reset')
+ edit_ca_page = index_ca_page.edit("Reset")
retry_block do
- edit_ca_page.set_name 'Reject'
- edit_ca_page.remove_action 'Priority'
- edit_ca_page.set_action 'Assignee', '-'
- edit_ca_page.expect_action 'assigned_to', nil
+ edit_ca_page.set_name "Reject"
+ edit_ca_page.remove_action "Priority"
+ edit_ca_page.set_action "Assignee", "-"
+ edit_ca_page.expect_action "assigned_to", nil
- edit_ca_page.set_action 'Status', rejected_status.name
- edit_ca_page.expect_action 'status', rejected_status.id
+ edit_ca_page.set_action "Status", rejected_status.name
+ edit_ca_page.expect_action "status", rejected_status.id
- edit_ca_page.set_condition 'Status', default_status.name
+ edit_ca_page.set_condition "Status", default_status.name
edit_ca_page.expect_selected_option default_status.name
end
edit_ca_page.save
index_ca_page.expect_current_path
- index_ca_page.expect_listed('Unassign', 'Close', 'Escalate', 'Reject')
+ index_ca_page.expect_listed("Unassign", "Close", "Escalate", "Reject")
- reset = CustomAction.find_by(name: 'Reject')
+ reset = CustomAction.find_by(name: "Reject")
expect(reset.actions.length).to eq(3)
expect(reset.conditions.length).to eq(1)
- index_ca_page.move_top 'Move project'
- index_ca_page.move_bottom 'Escalate'
- index_ca_page.move_up 'Close'
- index_ca_page.move_down 'Unassign'
+ index_ca_page.move_top "Move project"
+ index_ca_page.move_bottom "Escalate"
+ index_ca_page.move_up "Close"
+ index_ca_page.move_down "Unassign"
# Check the altered button
login_as(user)
wp_page.visit!
- wp_page.expect_custom_action('Unassign')
- wp_page.expect_custom_action('Close')
- wp_page.expect_custom_action('Escalate')
- wp_page.expect_custom_action('Move project')
- wp_page.expect_custom_action('Reject')
- wp_page.expect_no_custom_action('Reset')
- wp_page.expect_custom_action_order('Move project', 'Close', 'Reject', 'Unassign', 'Escalate')
+ wp_page.expect_custom_action("Unassign")
+ wp_page.expect_custom_action("Close")
+ wp_page.expect_custom_action("Escalate")
+ wp_page.expect_custom_action("Move project")
+ wp_page.expect_custom_action("Reject")
+ wp_page.expect_no_custom_action("Reset")
+ wp_page.expect_custom_action_order("Move project", "Close", "Reject", "Unassign", "Escalate")
- wp_page.click_custom_action('Reject')
- wp_page.expect_attributes assignee: '-',
+ wp_page.click_custom_action("Reject")
+ wp_page.expect_attributes assignee: "-",
status: rejected_status.name,
priority: default_priority.name
- wp_page.expect_custom_action('Close')
- wp_page.expect_no_custom_action('Reject')
+ wp_page.expect_custom_action("Close")
+ wp_page.expect_no_custom_action("Reject")
# Delete 'Reject' from list of actions
login_as(admin)
index_ca_page.visit!
- index_ca_page.delete('Unassign')
+ index_ca_page.delete("Unassign")
index_ca_page.expect_current_path
- index_ca_page.expect_listed('Close', 'Escalate', 'Reject')
+ index_ca_page.expect_listed("Close", "Escalate", "Reject")
login_as(user)
wp_page.visit!
- wp_page.expect_no_custom_action('Unassign')
- wp_page.expect_custom_action('Close')
- wp_page.expect_custom_action('Escalate')
- wp_page.expect_no_custom_action('Reject')
+ wp_page.expect_no_custom_action("Unassign")
+ wp_page.expect_custom_action("Close")
+ wp_page.expect_custom_action("Escalate")
+ wp_page.expect_no_custom_action("Reject")
# Move project
- wp_page.click_custom_action('Move project')
+ wp_page.click_custom_action("Move project")
- wp_page.expect_attributes assignee: '-',
+ wp_page.expect_attributes assignee: "-",
status: rejected_status.name,
type: other_type.name.upcase,
- "customField#{date_custom_field.id}" => (Date.today + 5.days).strftime('%m/%d/%Y')
+ "customField#{date_custom_field.id}" => (Date.today + 5.days).strftime("%m/%d/%Y")
expect(page)
- .to have_content(I18n.t('js.project.click_to_switch_to_project', projectname: other_project.name))
+ .to have_content(I18n.t("js.project.click_to_switch_to_project", projectname: other_project.name))
## Bump the lockVersion and by that force a conflict.
work_package.reload.touch
- wp_page.click_custom_action('Escalate', expect_success: false)
+ wp_page.click_custom_action("Escalate", expect_success: false)
- wp_page.expect_toast type: :error, message: I18n.t('api_v3.errors.code_409')
+ wp_page.expect_toast type: :error, message: I18n.t("api_v3.errors.code_409")
end
- it 'editing a current date custom action (Regression #30949)' do
+ it "editing a current date custom action (Regression #30949)" do
# create custom action 'Unassign'
index_ca_page.visit!
new_ca_page = index_ca_page.new
- new_ca_page.set_name('Current date')
- new_ca_page.set_description('Sets the current date')
- new_ca_page.add_action('Date', 'Current date')
+ new_ca_page.set_name("Current date")
+ new_ca_page.set_description("Sets the current date")
+ new_ca_page.add_action("Date", "Current date")
new_ca_page.create
index_ca_page.expect_current_path
- index_ca_page.expect_listed('Current date')
+ index_ca_page.expect_listed("Current date")
date_action = CustomAction.last
expect(date_action.actions.length).to eq(1)
expect(date_action.conditions.length).to eq(0)
- edit_page = index_ca_page.edit('Current date')
- expect(page).to have_select('custom_action_actions_date', selected: 'Current date')
+ edit_page = index_ca_page.edit("Current date")
+ expect(page).to have_select("custom_action_actions_date", selected: "Current date")
end
- it 'disables the custom action button and editing other fields when submiting the custom action' do
+ it "disables the custom action button and editing other fields when submiting the custom action" do
# create custom action 'Unassign'
index_ca_page.visit!
new_ca_page = index_ca_page.new
- new_ca_page.set_name('Unassign')
- new_ca_page.set_description('Removes the assignee')
- new_ca_page.add_action('Assignee', '-')
- new_ca_page.expect_action('assigned_to', nil)
+ new_ca_page.set_name("Unassign")
+ new_ca_page.set_description("Removes the assignee")
+ new_ca_page.add_action("Assignee", "-")
+ new_ca_page.expect_action("assigned_to", nil)
new_ca_page.create
index_ca_page.expect_current_path
- index_ca_page.expect_listed('Unassign')
+ index_ca_page.expect_listed("Unassign")
unassign = CustomAction.last
expect(unassign.actions.length).to eq(1)
@@ -491,17 +491,17 @@
# Stop sending ajax requests in order to test disabled fields upon submit
wp_page.disable_ajax_requests
- wp_page.click_custom_action('Unassign', expect_success: false)
- wp_page.expect_custom_action_disabled('Unassign')
+ wp_page.click_custom_action("Unassign", expect_success: false)
+ wp_page.expect_custom_action_disabled("Unassign")
find('[data-field-name="estimatedTime"]').click
expect(page).to have_css("#wp-#{work_package.id}-inline-edit--field-estimatedTime[disabled]")
end
- context 'with baseline enabled' do
+ context "with baseline enabled" do
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
let(:query) do
create(:query,
- name: 'Timestamps Query',
+ name: "Timestamps Query",
project:,
user:,
timestamps: ["P-1d", "PT0S"])
@@ -510,17 +510,17 @@
before do
create(:custom_action,
actions: [CustomActions::Actions::AssignedTo.new(value: nil)],
- name: 'Unassign')
+ name: "Unassign")
end
- it 'executes the custom action (Regression#49588)' do
+ it "executes the custom action (Regression#49588)" do
login_as(user)
wp_table.visit_query(query)
wp_page = wp_table.open_full_screen_by_link(work_package)
wp_page.ensure_page_loaded
- wp_page.click_custom_action('Unassign', expect_success: true)
+ wp_page.click_custom_action("Unassign", expect_success: true)
end
end
end
diff --git a/spec/features/work_packages/datepicker/datepicker_follows_relation_spec.rb b/spec/features/work_packages/datepicker/datepicker_follows_relation_spec.rb
index b8d4a3ceb300..7c9c182c9d08 100644
--- a/spec/features/work_packages/datepicker/datepicker_follows_relation_spec.rb
+++ b/spec/features/work_packages/datepicker/datepicker_follows_relation_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'support/edit_fields/edit_field'
+require "spec_helper"
+require "support/edit_fields/edit_field"
-RSpec.describe 'Datepicker logic on follow relationships', :js, :with_cuprite,
- with_settings: { date_format: '%Y-%m-%d' } do
+RSpec.describe "Datepicker logic on follow relationships", :js, :with_cuprite,
+ with_settings: { date_format: "%Y-%m-%d" } do
shared_let(:user) { create(:admin) }
shared_let(:type) { create(:type_bug) }
@@ -39,15 +39,15 @@
shared_let(:predecessor) do
create(:work_package,
type:, project:,
- start_date: Date.parse('2024-02-01'),
- due_date: Date.parse('2024-02-05'))
+ start_date: Date.parse("2024-02-01"),
+ due_date: Date.parse("2024-02-05"))
end
let(:work_packages_page) { Pages::FullWorkPackage.new(follower) }
let(:datepicker) { date_field.datepicker }
- shared_examples 'keeps the minimum date from the predecessor when toggling NWD' do
- it 'keeps the minimum dates disabled' do
+ shared_examples "keeps the minimum date from the predecessor when toggling NWD" do
+ it "keeps the minimum dates disabled" do
login_as(user)
work_packages_page.visit!
@@ -61,37 +61,37 @@
datepicker.expect_ignore_non_working_days false
datepicker.expect_scheduling_mode false
- datepicker.show_date '2024-02-05'
- datepicker.expect_disabled Date.parse('2024-02-05')
- datepicker.expect_disabled Date.parse('2024-02-04')
- datepicker.expect_disabled Date.parse('2024-02-03')
- datepicker.expect_disabled Date.parse('2024-02-02')
- datepicker.expect_disabled Date.parse('2024-02-01')
+ datepicker.show_date "2024-02-05"
+ datepicker.expect_disabled Date.parse("2024-02-05")
+ datepicker.expect_disabled Date.parse("2024-02-04")
+ datepicker.expect_disabled Date.parse("2024-02-03")
+ datepicker.expect_disabled Date.parse("2024-02-02")
+ datepicker.expect_disabled Date.parse("2024-02-01")
datepicker.toggle_ignore_non_working_days
datepicker.expect_ignore_non_working_days true
- datepicker.show_date '2024-02-05'
- datepicker.expect_disabled Date.parse('2024-02-05')
- datepicker.expect_disabled Date.parse('2024-02-04')
- datepicker.expect_disabled Date.parse('2024-02-03')
- datepicker.expect_disabled Date.parse('2024-02-02')
- datepicker.expect_disabled Date.parse('2024-02-01')
+ datepicker.show_date "2024-02-05"
+ datepicker.expect_disabled Date.parse("2024-02-05")
+ datepicker.expect_disabled Date.parse("2024-02-04")
+ datepicker.expect_disabled Date.parse("2024-02-03")
+ datepicker.expect_disabled Date.parse("2024-02-02")
+ datepicker.expect_disabled Date.parse("2024-02-01")
end
end
- context 'if the follower is a task' do
+ context "if the follower is a task" do
let!(:follower) { create(:work_package, type:, project:) }
let!(:relation) { create(:follows_relation, from: follower, to: predecessor) }
let(:date_field) { work_packages_page.edit_field(:combinedDate) }
- it_behaves_like 'keeps the minimum date from the predecessor when toggling NWD'
+ it_behaves_like "keeps the minimum date from the predecessor when toggling NWD"
end
- context 'if the follower is a milestone' do
+ context "if the follower is a milestone" do
let!(:follower) { create(:work_package, type: milestone_type, project:) }
let!(:relation) { create(:follows_relation, from: follower, to: predecessor) }
let(:date_field) { work_packages_page.edit_field(:date) }
- it_behaves_like 'keeps the minimum date from the predecessor when toggling NWD'
+ it_behaves_like "keeps the minimum date from the predecessor when toggling NWD"
end
end
diff --git a/spec/features/work_packages/datepicker/datepicker_logic_spec.rb b/spec/features/work_packages/datepicker/datepicker_logic_spec.rb
index 469c3c9ad10f..e4d4cecbf412 100644
--- a/spec/features/work_packages/datepicker/datepicker_logic_spec.rb
+++ b/spec/features/work_packages/datepicker/datepicker_logic_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'support/edit_fields/edit_field'
+require "spec_helper"
+require "support/edit_fields/edit_field"
-RSpec.describe 'Datepicker modal logic test cases (WP #43539)', :js, :with_cuprite, with_settings: { date_format: '%Y-%m-%d' } do
+RSpec.describe "Datepicker modal logic test cases (WP #43539)", :js, :with_cuprite, with_settings: { date_format: "%Y-%m-%d" } do
shared_let(:user) { create(:admin) }
shared_let(:type_bug) { create(:type_bug) }
@@ -55,7 +55,7 @@
def apply_and_expect_saved(attributes)
date_field.save!
- work_packages_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_update')
+ work_packages_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_update")
work_package.reload
@@ -78,33 +78,33 @@ def apply_and_expect_saved(attributes)
datepicker.expect_visible
end
- context 'when only start_date set, updating duration (scenario 1)' do
+ context "when only start_date set, updating duration (scenario 1)" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-08'),
+ start_date: Date.parse("2021-02-08"),
due_date: nil,
duration: nil
}
end
- it 'sets finish date' do
- datepicker.expect_start_date '2021-02-08'
- datepicker.expect_due_date ''
- datepicker.expect_duration ''
+ it "sets finish date" do
+ datepicker.expect_start_date "2021-02-08"
+ datepicker.expect_due_date ""
+ datepicker.expect_duration ""
datepicker.set_duration 10
- datepicker.expect_start_date '2021-02-08'
- datepicker.expect_due_date '2021-02-19'
+ datepicker.expect_start_date "2021-02-08"
+ datepicker.expect_due_date "2021-02-19"
datepicker.expect_duration 10
apply_and_expect_saved duration: 10,
- start_date: Date.parse('2021-02-08'),
- due_date: Date.parse('2021-02-19')
+ start_date: Date.parse("2021-02-08"),
+ due_date: Date.parse("2021-02-19")
end
end
- describe 'when no values set, updating duration (scenario 2)' do
+ describe "when no values set, updating duration (scenario 2)" do
let(:current_attributes) do
{
start_date: nil,
@@ -113,15 +113,15 @@ def apply_and_expect_saved(attributes)
}
end
- it 'sets only the duration' do
- datepicker.expect_start_date ''
- datepicker.expect_due_date ''
- datepicker.expect_duration ''
+ it "sets only the duration" do
+ datepicker.expect_start_date ""
+ datepicker.expect_due_date ""
+ datepicker.expect_duration ""
datepicker.set_duration 10
- datepicker.expect_start_date ''
- datepicker.expect_due_date ''
+ datepicker.expect_start_date ""
+ datepicker.expect_due_date ""
datepicker.expect_duration 10
apply_and_expect_saved duration: 10,
@@ -130,238 +130,238 @@ def apply_and_expect_saved(attributes)
end
end
- describe 'when only due date set, updating duration (scenario 3)' do
+ describe "when only due date set, updating duration (scenario 3)" do
let(:current_attributes) do
{
start_date: nil,
- due_date: Date.parse('2021-02-19'),
+ due_date: Date.parse("2021-02-19"),
duration: nil
}
end
- it 'sets the start date' do
- datepicker.expect_start_date ''
- datepicker.expect_due_date '2021-02-19'
- datepicker.expect_duration ''
+ it "sets the start date" do
+ datepicker.expect_start_date ""
+ datepicker.expect_due_date "2021-02-19"
+ datepicker.expect_duration ""
datepicker.set_duration 10
- datepicker.expect_start_date '2021-02-08'
- datepicker.expect_due_date '2021-02-19'
+ datepicker.expect_start_date "2021-02-08"
+ datepicker.expect_due_date "2021-02-19"
datepicker.expect_duration 10
apply_and_expect_saved duration: 10,
- start_date: Date.parse('2021-02-08'),
- due_date: Date.parse('2021-02-19')
+ start_date: Date.parse("2021-02-08"),
+ due_date: Date.parse("2021-02-19")
end
end
- describe 'when all values set, increasing duration (scenario 4)' do
+ describe "when all values set, increasing duration (scenario 4)" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-08'),
- due_date: Date.parse('2021-02-19'),
+ start_date: Date.parse("2021-02-08"),
+ due_date: Date.parse("2021-02-19"),
duration: 10
}
end
- it 'updates the finish date to a later date' do
- datepicker.expect_start_date '2021-02-08'
- datepicker.expect_due_date '2021-02-19'
+ it "updates the finish date to a later date" do
+ datepicker.expect_start_date "2021-02-08"
+ datepicker.expect_due_date "2021-02-19"
datepicker.expect_duration 10
datepicker.set_duration 11
- datepicker.expect_start_date '2021-02-08'
- datepicker.expect_due_date '2021-02-22'
+ datepicker.expect_start_date "2021-02-08"
+ datepicker.expect_due_date "2021-02-22"
datepicker.expect_duration 11
apply_and_expect_saved duration: 11,
- start_date: Date.parse('2021-02-08'),
- due_date: Date.parse('2021-02-22')
+ start_date: Date.parse("2021-02-08"),
+ due_date: Date.parse("2021-02-22")
end
end
- describe 'when all values set, reducing duration (scenario 5)' do
+ describe "when all values set, reducing duration (scenario 5)" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-08'),
- due_date: Date.parse('2021-02-22'),
+ start_date: Date.parse("2021-02-08"),
+ due_date: Date.parse("2021-02-22"),
duration: 11
}
end
- it 'updates the finish date to an earlier date' do
- datepicker.expect_start_date '2021-02-08'
- datepicker.expect_due_date '2021-02-22'
+ it "updates the finish date to an earlier date" do
+ datepicker.expect_start_date "2021-02-08"
+ datepicker.expect_due_date "2021-02-22"
datepicker.expect_duration 11
datepicker.set_duration 10
- datepicker.expect_start_date '2021-02-08'
- datepicker.expect_due_date '2021-02-19'
+ datepicker.expect_start_date "2021-02-08"
+ datepicker.expect_due_date "2021-02-19"
datepicker.expect_duration 10
apply_and_expect_saved duration: 10,
- start_date: Date.parse('2021-02-08'),
- due_date: Date.parse('2021-02-19')
+ start_date: Date.parse("2021-02-08"),
+ due_date: Date.parse("2021-02-19")
end
end
- describe 'when all values set, removing duration (scenario 6)' do
+ describe "when all values set, removing duration (scenario 6)" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-09'),
- due_date: Date.parse('2021-02-12'),
+ start_date: Date.parse("2021-02-09"),
+ due_date: Date.parse("2021-02-12"),
duration: 3
}
end
- it 'also unsets the due date' do
- datepicker.expect_start_date '2021-02-09'
- datepicker.expect_due_date '2021-02-12'
+ it "also unsets the due date" do
+ datepicker.expect_start_date "2021-02-09"
+ datepicker.expect_due_date "2021-02-12"
datepicker.expect_duration 3
datepicker.clear_duration
- datepicker.expect_start_date '2021-02-09'
- datepicker.expect_due_date ''
+ datepicker.expect_start_date "2021-02-09"
+ datepicker.expect_due_date ""
datepicker.expect_duration nil
end
end
- describe 'when all values set, removing duration through icon (scenario 6a)' do
+ describe "when all values set, removing duration through icon (scenario 6a)" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-09'),
- due_date: Date.parse('2021-02-12'),
+ start_date: Date.parse("2021-02-09"),
+ due_date: Date.parse("2021-02-12"),
duration: 3
}
end
- it 'also unsets the due date' do
- datepicker.expect_start_date '2021-02-09'
- datepicker.expect_due_date '2021-02-12'
+ it "also unsets the due date" do
+ datepicker.expect_start_date "2021-02-09"
+ datepicker.expect_due_date "2021-02-12"
datepicker.expect_duration 3
datepicker.clear_duration_with_icon
- datepicker.expect_start_date '2021-02-09'
- datepicker.expect_due_date ''
+ datepicker.expect_start_date "2021-02-09"
+ datepicker.expect_due_date ""
datepicker.expect_duration nil
end
end
- describe 'when all values set, removing duration and setting it again' do
+ describe "when all values set, removing duration and setting it again" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-09'),
- due_date: Date.parse('2021-02-12'),
+ start_date: Date.parse("2021-02-09"),
+ due_date: Date.parse("2021-02-12"),
duration: 3
}
end
- it 'allows re-deriving duration' do
- datepicker.expect_start_date '2021-02-09'
- datepicker.expect_due_date '2021-02-12'
+ it "allows re-deriving duration" do
+ datepicker.expect_start_date "2021-02-09"
+ datepicker.expect_due_date "2021-02-12"
datepicker.expect_duration 3
datepicker.clear_duration_with_icon
- datepicker.expect_start_date '2021-02-09'
- datepicker.expect_due_date ''
+ datepicker.expect_start_date "2021-02-09"
+ datepicker.expect_due_date ""
datepicker.expect_duration nil
# Now select a date
datepicker.select_day 5
- datepicker.expect_start_date '2021-02-05'
- datepicker.expect_due_date '2021-02-09'
+ datepicker.expect_start_date "2021-02-05"
+ datepicker.expect_due_date "2021-02-09"
datepicker.expect_duration 3
datepicker.clear_duration_with_icon
- datepicker.expect_start_date '2021-02-05'
- datepicker.expect_due_date ''
+ datepicker.expect_start_date "2021-02-05"
+ datepicker.expect_due_date ""
datepicker.expect_duration nil
datepicker.select_day 8
- datepicker.expect_start_date '2021-02-05'
- datepicker.expect_due_date '2021-02-08'
+ datepicker.expect_start_date "2021-02-05"
+ datepicker.expect_due_date "2021-02-08"
datepicker.expect_duration 2
end
end
- describe 'when all values set, changing start date in calendar (scenario 7)' do
+ describe "when all values set, changing start date in calendar (scenario 7)" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-08'),
- due_date: Date.parse('2021-02-11'),
+ start_date: Date.parse("2021-02-08"),
+ due_date: Date.parse("2021-02-11"),
duration: 4
}
end
- it 'adjusts the duration' do
- datepicker.expect_start_date '2021-02-08'
- datepicker.expect_due_date '2021-02-11'
+ it "adjusts the duration" do
+ datepicker.expect_start_date "2021-02-08"
+ datepicker.expect_due_date "2021-02-11"
datepicker.expect_duration 4
- datepicker.set_start_date '2021-02-09'
+ datepicker.set_start_date "2021-02-09"
- datepicker.expect_start_date '2021-02-09'
- datepicker.expect_due_date '2021-02-11'
+ datepicker.expect_start_date "2021-02-09"
+ datepicker.expect_due_date "2021-02-11"
datepicker.expect_duration 3
end
end
# Same as scenario 7, with error state in the middle
- describe 'when all values set, setting the start date to invalid value, then to a valid value' do
+ describe "when all values set, setting the start date to invalid value, then to a valid value" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-08'),
- due_date: Date.parse('2021-02-11'),
+ start_date: Date.parse("2021-02-08"),
+ due_date: Date.parse("2021-02-11"),
duration: 4
}
end
- it 'adjusts the duration' do
- datepicker.expect_start_date '2021-02-08'
- datepicker.expect_due_date '2021-02-11'
+ it "adjusts the duration" do
+ datepicker.expect_start_date "2021-02-08"
+ datepicker.expect_due_date "2021-02-11"
datepicker.expect_duration 4
# simulate someone deleting some chars to type a new date
- datepicker.set_start_date '2021-02-'
- datepicker.set_start_date '2021-02-09'
+ datepicker.set_start_date "2021-02-"
+ datepicker.set_start_date "2021-02-09"
- datepicker.expect_start_date '2021-02-09'
- datepicker.expect_due_date '2021-02-11'
+ datepicker.expect_start_date "2021-02-09"
+ datepicker.expect_due_date "2021-02-11"
datepicker.expect_duration 3
end
end
- describe 'when all values set, changing due date (scenario 8)' do
+ describe "when all values set, changing due date (scenario 8)" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-09'),
- due_date: Date.parse('2021-02-12'),
+ start_date: Date.parse("2021-02-09"),
+ due_date: Date.parse("2021-02-12"),
duration: 4
}
end
- it 'adjusts the duration' do
- datepicker.expect_start_date '2021-02-09'
- datepicker.expect_due_date '2021-02-12'
+ it "adjusts the duration" do
+ datepicker.expect_start_date "2021-02-09"
+ datepicker.expect_due_date "2021-02-12"
datepicker.expect_duration 4
- datepicker.set_due_date '2021-02-11'
+ datepicker.set_due_date "2021-02-11"
- datepicker.expect_start_date '2021-02-09'
- datepicker.expect_due_date '2021-02-11'
+ datepicker.expect_start_date "2021-02-09"
+ datepicker.expect_due_date "2021-02-11"
datepicker.expect_duration 3
end
end
- describe 'when only duration set, setting finish date (scenario 9)' do
+ describe "when only duration set, setting finish date (scenario 9)" do
let(:current_attributes) do
{
start_date: nil,
@@ -370,86 +370,86 @@ def apply_and_expect_saved(attributes)
}
end
- it 'derives the start date' do
- datepicker.expect_start_date ''
- datepicker.expect_due_date ''
+ it "derives the start date" do
+ datepicker.expect_start_date ""
+ datepicker.expect_due_date ""
datepicker.expect_duration 4
- datepicker.set_due_date '2021-02-12'
+ datepicker.set_due_date "2021-02-12"
- datepicker.expect_start_date '2021-02-09'
- datepicker.expect_due_date '2021-02-12'
+ datepicker.expect_start_date "2021-02-09"
+ datepicker.expect_due_date "2021-02-12"
datepicker.expect_duration 4
end
end
- describe 'when only due date set, setting start date (scenario 10)' do
+ describe "when only due date set, setting start date (scenario 10)" do
let(:current_attributes) do
{
start_date: nil,
- due_date: Date.parse('2021-02-11'),
+ due_date: Date.parse("2021-02-11"),
duration: nil
}
end
- it 'derives the duration' do
- datepicker.expect_start_date ''
- datepicker.expect_due_date '2021-02-11'
- datepicker.expect_duration ''
+ it "derives the duration" do
+ datepicker.expect_start_date ""
+ datepicker.expect_due_date "2021-02-11"
+ datepicker.expect_duration ""
- datepicker.set_start_date '2021-02-09'
+ datepicker.set_start_date "2021-02-09"
- datepicker.expect_start_date '2021-02-09'
- datepicker.expect_due_date '2021-02-11'
+ datepicker.expect_start_date "2021-02-09"
+ datepicker.expect_due_date "2021-02-11"
datepicker.expect_duration 3
end
end
- describe 'when all values set, changing the start date to the future in the picker (Scenario 13)' do
+ describe "when all values set, changing the start date to the future in the picker (Scenario 13)" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-09'),
- due_date: Date.parse('2021-02-11'),
+ start_date: Date.parse("2021-02-09"),
+ due_date: Date.parse("2021-02-11"),
duration: 3
}
end
- it 'unsets the other two values' do
- datepicker.expect_start_date '2021-02-09'
- datepicker.expect_due_date '2021-02-11'
+ it "unsets the other two values" do
+ datepicker.expect_start_date "2021-02-09"
+ datepicker.expect_due_date "2021-02-11"
datepicker.expect_duration 3
- datepicker.set_start_date '2021-03-03'
+ datepicker.set_start_date "2021-03-03"
- datepicker.expect_start_date '2021-03-03'
- datepicker.expect_due_date ''
- datepicker.expect_duration ''
+ datepicker.expect_start_date "2021-03-03"
+ datepicker.expect_due_date ""
+ datepicker.expect_duration ""
end
end
- describe 'when only finish date set, changing the start date to the future in the picker (Scenario 13 variation)' do
+ describe "when only finish date set, changing the start date to the future in the picker (Scenario 13 variation)" do
let(:current_attributes) do
{
start_date: nil,
- due_date: Date.parse('2021-02-11'),
+ due_date: Date.parse("2021-02-11"),
duration: nil
}
end
- it 'unsets the finish date' do
- datepicker.expect_start_date ''
- datepicker.expect_due_date '2021-02-11'
- datepicker.expect_duration ''
+ it "unsets the finish date" do
+ datepicker.expect_start_date ""
+ datepicker.expect_due_date "2021-02-11"
+ datepicker.expect_duration ""
- datepicker.set_start_date '2021-03-03'
+ datepicker.set_start_date "2021-03-03"
- datepicker.expect_start_date '2021-03-03'
- datepicker.expect_due_date ''
- datepicker.expect_duration ''
+ datepicker.expect_start_date "2021-03-03"
+ datepicker.expect_due_date ""
+ datepicker.expect_duration ""
end
end
- describe 'when only start date set, changing the finish date to the past with today (Scenario 13a)' do
+ describe "when only start date set, changing the finish date to the past with today (Scenario 13a)" do
let(:current_attributes) do
{
start_date: 2.days.from_now,
@@ -459,19 +459,19 @@ def apply_and_expect_saved(attributes)
}
end
- it 'unsets the other two values' do
+ it "unsets the other two values" do
datepicker.expect_start_date 2.days.from_now.to_date.iso8601
- datepicker.expect_due_date ''
+ datepicker.expect_due_date ""
datepicker.set_today :due
- datepicker.expect_start_date ''
+ datepicker.expect_start_date ""
datepicker.expect_due_date Time.zone.today.iso8601
- datepicker.expect_duration ''
+ datepicker.expect_duration ""
end
end
- describe 'when all values set, changing the finish date to the past with today (Scenario 13a)' do
+ describe "when all values set, changing the finish date to the past with today (Scenario 13a)" do
let(:current_attributes) do
{
start_date: 2.days.from_now,
@@ -480,396 +480,396 @@ def apply_and_expect_saved(attributes)
}
end
- it 'unsets the other two values' do
+ it "unsets the other two values" do
datepicker.expect_start_date 2.days.from_now.to_date.iso8601
datepicker.expect_due_date 3.days.from_now.to_date.iso8601
datepicker.set_today :due
- datepicker.expect_start_date ''
+ datepicker.expect_start_date ""
datepicker.expect_due_date Time.zone.today.iso8601
- datepicker.expect_duration ''
+ datepicker.expect_duration ""
end
end
- describe 'when all values set, changing the start date to the past in the picker (Scenario 14)' do
+ describe "when all values set, changing the start date to the past in the picker (Scenario 14)" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-09'),
- due_date: Date.parse('2021-02-11'),
+ start_date: Date.parse("2021-02-09"),
+ due_date: Date.parse("2021-02-11"),
duration: 3
}
end
- it 'conserves the duration and updates the finish date' do
- datepicker.expect_start_date '2021-02-09'
- datepicker.expect_due_date '2021-02-11'
+ it "conserves the duration and updates the finish date" do
+ datepicker.expect_start_date "2021-02-09"
+ datepicker.expect_due_date "2021-02-11"
datepicker.expect_duration 3
- datepicker.set_start_date '2021-02-03'
+ datepicker.set_start_date "2021-02-03"
- datepicker.expect_start_date '2021-02-03'
- datepicker.expect_due_date '2021-02-05'
+ datepicker.expect_start_date "2021-02-03"
+ datepicker.expect_due_date "2021-02-05"
datepicker.expect_duration 3
end
end
- describe 'when all values set, changing include NWD to true (Scenario 15)' do
+ describe "when all values set, changing include NWD to true (Scenario 15)" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-11'),
- due_date: Date.parse('2021-02-16'),
+ start_date: Date.parse("2021-02-11"),
+ due_date: Date.parse("2021-02-16"),
duration: 4
}
end
- it 'conserves the duration and updates the finish date' do
- datepicker.expect_start_date '2021-02-11'
- datepicker.expect_due_date '2021-02-16'
+ it "conserves the duration and updates the finish date" do
+ datepicker.expect_start_date "2021-02-11"
+ datepicker.expect_due_date "2021-02-16"
datepicker.expect_duration 4
datepicker.toggle_ignore_non_working_days
- datepicker.expect_start_date '2021-02-11'
- datepicker.expect_due_date '2021-02-14'
+ datepicker.expect_start_date "2021-02-11"
+ datepicker.expect_due_date "2021-02-14"
datepicker.expect_duration 4
end
end
- describe 'when all values set and include NWD true, changing include NWD to false (Scenario 16)' do
+ describe "when all values set and include NWD true, changing include NWD to false (Scenario 16)" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-11'),
- due_date: Date.parse('2021-02-14'),
+ start_date: Date.parse("2021-02-11"),
+ due_date: Date.parse("2021-02-14"),
duration: 4,
ignore_non_working_days: true
}
end
- it 'conserves the duration and updates the finish date' do
- datepicker.expect_start_date '2021-02-11'
- datepicker.expect_due_date '2021-02-14'
+ it "conserves the duration and updates the finish date" do
+ datepicker.expect_start_date "2021-02-11"
+ datepicker.expect_due_date "2021-02-14"
datepicker.expect_duration 4
datepicker.expect_ignore_non_working_days true
datepicker.toggle_ignore_non_working_days
datepicker.expect_ignore_non_working_days false
- datepicker.expect_start_date '2021-02-11'
- datepicker.expect_due_date '2021-02-16'
+ datepicker.expect_start_date "2021-02-11"
+ datepicker.expect_due_date "2021-02-16"
datepicker.expect_duration 4
end
end
- describe 'when all values set and include NWD true, changing include NWD to false (Scenario 17)' do
+ describe "when all values set and include NWD true, changing include NWD to false (Scenario 17)" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-13'),
- due_date: Date.parse('2021-02-14'),
+ start_date: Date.parse("2021-02-13"),
+ due_date: Date.parse("2021-02-14"),
duration: 2,
ignore_non_working_days: true
}
end
- it 'shifts the start date to soonest working day, and updates finish date to conserve duration' do
- datepicker.expect_start_date '2021-02-13'
- datepicker.expect_due_date '2021-02-14'
+ it "shifts the start date to soonest working day, and updates finish date to conserve duration" do
+ datepicker.expect_start_date "2021-02-13"
+ datepicker.expect_due_date "2021-02-14"
datepicker.expect_duration 2
datepicker.expect_ignore_non_working_days true
datepicker.toggle_ignore_non_working_days
datepicker.expect_ignore_non_working_days false
- datepicker.expect_start_date '2021-02-15'
- datepicker.expect_due_date '2021-02-16'
+ datepicker.expect_start_date "2021-02-15"
+ datepicker.expect_due_date "2021-02-16"
datepicker.expect_duration 2
end
end
- describe 'when all values set and include NWD true, changing include NWD to false (Scenario 18)' do
+ describe "when all values set and include NWD true, changing include NWD to false (Scenario 18)" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-13'),
- due_date: Date.parse('2021-02-23'),
+ start_date: Date.parse("2021-02-13"),
+ due_date: Date.parse("2021-02-23"),
duration: 11,
ignore_non_working_days: true
}
end
- it 'shifts the start date to soonest working day, and updates finish date to conserve duration' do
- datepicker.expect_start_date '2021-02-13'
- datepicker.expect_due_date '2021-02-23'
+ it "shifts the start date to soonest working day, and updates finish date to conserve duration" do
+ datepicker.expect_start_date "2021-02-13"
+ datepicker.expect_due_date "2021-02-23"
datepicker.expect_duration 11
datepicker.expect_ignore_non_working_days true
datepicker.toggle_ignore_non_working_days
datepicker.expect_ignore_non_working_days false
- datepicker.expect_start_date '2021-02-15'
- datepicker.expect_due_date '2021-03-01'
+ datepicker.expect_start_date "2021-02-15"
+ datepicker.expect_due_date "2021-03-01"
datepicker.expect_duration 11
apply_and_expect_saved duration: 11,
- start_date: Date.parse('2021-02-15'),
- due_date: Date.parse('2021-03-01'),
+ start_date: Date.parse("2021-02-15"),
+ due_date: Date.parse("2021-03-01"),
ignore_non_working_days: false
end
end
- describe 'when only start date set and include NWD true, changing include NWD to false (Scenario 19)' do
+ describe "when only start date set and include NWD true, changing include NWD to false (Scenario 19)" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-13'),
+ start_date: Date.parse("2021-02-13"),
due_date: nil,
duration: nil,
ignore_non_working_days: true
}
end
- it 'shifts the start date to soonest working day' do
- datepicker.expect_start_date '2021-02-13'
- datepicker.expect_due_date ''
- datepicker.expect_duration ''
+ it "shifts the start date to soonest working day" do
+ datepicker.expect_start_date "2021-02-13"
+ datepicker.expect_due_date ""
+ datepicker.expect_duration ""
datepicker.expect_ignore_non_working_days true
datepicker.toggle_ignore_non_working_days
datepicker.expect_ignore_non_working_days false
- datepicker.expect_start_date '2021-02-15'
- datepicker.expect_due_date ''
- datepicker.expect_duration ''
+ datepicker.expect_start_date "2021-02-15"
+ datepicker.expect_due_date ""
+ datepicker.expect_duration ""
apply_and_expect_saved duration: nil,
- start_date: Date.parse('2021-02-15'),
+ start_date: Date.parse("2021-02-15"),
due_date: nil,
ignore_non_working_days: false
end
end
- describe 'when only finish date set and include NWD true, changing include NWD to false (Scenario 20)' do
+ describe "when only finish date set and include NWD true, changing include NWD to false (Scenario 20)" do
let(:current_attributes) do
{
start_date: nil,
- due_date: Date.parse('2021-02-21'),
+ due_date: Date.parse("2021-02-21"),
duration: nil,
ignore_non_working_days: true
}
end
- it 'shifts the finish date to soonest working day' do
- datepicker.expect_start_date ''
- datepicker.expect_due_date '2021-02-21'
- datepicker.expect_duration ''
+ it "shifts the finish date to soonest working day" do
+ datepicker.expect_start_date ""
+ datepicker.expect_due_date "2021-02-21"
+ datepicker.expect_duration ""
datepicker.expect_ignore_non_working_days true
datepicker.toggle_ignore_non_working_days
datepicker.expect_ignore_non_working_days false
- datepicker.expect_start_date ''
- datepicker.expect_due_date '2021-02-22'
- datepicker.expect_duration ''
+ datepicker.expect_start_date ""
+ datepicker.expect_due_date "2021-02-22"
+ datepicker.expect_duration ""
apply_and_expect_saved duration: nil,
start_date: nil,
- due_date: Date.parse('2021-02-22'),
+ due_date: Date.parse("2021-02-22"),
ignore_non_working_days: false
end
end
- describe 'When all values set, clear the start date (Scenario 21a)' do
+ describe "When all values set, clear the start date (Scenario 21a)" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-20'),
- due_date: Date.parse('2021-02-21'),
+ start_date: Date.parse("2021-02-20"),
+ due_date: Date.parse("2021-02-21"),
duration: 1,
ignore_non_working_days: true
}
end
- it 'also removes duration, but keeps finish date' do
- datepicker.expect_start_date '2021-02-20'
- datepicker.expect_due_date '2021-02-21'
+ it "also removes duration, but keeps finish date" do
+ datepicker.expect_start_date "2021-02-20"
+ datepicker.expect_due_date "2021-02-21"
datepicker.expect_duration 1
datepicker.expect_ignore_non_working_days true
- datepicker.set_start_date ''
- datepicker.expect_duration ''
- datepicker.expect_due_date '2021-02-21'
+ datepicker.set_start_date ""
+ datepicker.expect_duration ""
+ datepicker.expect_due_date "2021-02-21"
apply_and_expect_saved duration: nil,
start_date: nil,
- due_date: Date.parse('2021-02-21'),
+ due_date: Date.parse("2021-02-21"),
ignore_non_working_days: true
end
end
- describe 'When all values set, clear the due date (Scenario 21b)' do
+ describe "When all values set, clear the due date (Scenario 21b)" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-20'),
- due_date: Date.parse('2021-02-21'),
+ start_date: Date.parse("2021-02-20"),
+ due_date: Date.parse("2021-02-21"),
duration: 1,
ignore_non_working_days: true
}
end
- it 'also removes duration, but keeps start date' do
- datepicker.expect_start_date '2021-02-20'
- datepicker.expect_due_date '2021-02-21'
+ it "also removes duration, but keeps start date" do
+ datepicker.expect_start_date "2021-02-20"
+ datepicker.expect_due_date "2021-02-21"
datepicker.expect_duration 1
datepicker.expect_ignore_non_working_days true
- datepicker.set_due_date ''
- datepicker.expect_duration ''
- datepicker.expect_start_date '2021-02-20'
+ datepicker.set_due_date ""
+ datepicker.expect_duration ""
+ datepicker.expect_start_date "2021-02-20"
apply_and_expect_saved duration: nil,
- start_date: Date.parse('2021-02-20'),
+ start_date: Date.parse("2021-02-20"),
due_date: nil,
ignore_non_working_days: true
end
end
- describe 'When only start date set, duration in focus, select earlier date (Scenario 22a)' do
+ describe "When only start date set, duration in focus, select earlier date (Scenario 22a)" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-18'),
+ start_date: Date.parse("2021-02-18"),
due_date: nil,
duration: nil,
ignore_non_working_days: true
}
end
- it 'sets start date to selected value, finish date to start date' do
- datepicker.expect_start_date '2021-02-18'
- datepicker.expect_due_date ''
- datepicker.expect_duration ''
+ it "sets start date to selected value, finish date to start date" do
+ datepicker.expect_start_date "2021-02-18"
+ datepicker.expect_due_date ""
+ datepicker.expect_duration ""
datepicker.focus_duration
datepicker.expect_duration_highlighted
datepicker.select_day 17
- datepicker.expect_start_date '2021-02-17'
- datepicker.expect_due_date '2021-02-18'
+ datepicker.expect_start_date "2021-02-17"
+ datepicker.expect_due_date "2021-02-18"
datepicker.expect_duration 2
datepicker.expect_start_highlighted
apply_and_expect_saved duration: 2,
- start_date: Date.parse('2021-02-17'),
- due_date: Date.parse('2021-02-18'),
+ start_date: Date.parse("2021-02-17"),
+ due_date: Date.parse("2021-02-18"),
ignore_non_working_days: true
end
end
- describe 'When only start date set, duration in focus, select later date (Scenario 22b)' do
+ describe "When only start date set, duration in focus, select later date (Scenario 22b)" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-18'),
+ start_date: Date.parse("2021-02-18"),
due_date: nil,
duration: nil,
ignore_non_working_days: true
}
end
- it 'sets finish date to selected date' do
- datepicker.expect_start_date '2021-02-18'
- datepicker.expect_due_date ''
- datepicker.expect_duration ''
+ it "sets finish date to selected date" do
+ datepicker.expect_start_date "2021-02-18"
+ datepicker.expect_due_date ""
+ datepicker.expect_duration ""
datepicker.focus_duration
datepicker.expect_duration_highlighted
datepicker.select_day 19
- datepicker.expect_start_date '2021-02-18'
- datepicker.expect_due_date '2021-02-19'
+ datepicker.expect_start_date "2021-02-18"
+ datepicker.expect_due_date "2021-02-19"
datepicker.expect_duration 2
datepicker.expect_start_highlighted
apply_and_expect_saved duration: 2,
- start_date: Date.parse('2021-02-18'),
- due_date: Date.parse('2021-02-19'),
+ start_date: Date.parse("2021-02-18"),
+ due_date: Date.parse("2021-02-19"),
ignore_non_working_days: true
end
end
- describe 'When only due date set, duration in focus, select later date (Scenario 23a)' do
+ describe "When only due date set, duration in focus, select later date (Scenario 23a)" do
let(:current_attributes) do
{
start_date: nil,
- due_date: Date.parse('2021-02-18'),
+ due_date: Date.parse("2021-02-18"),
duration: nil,
ignore_non_working_days: true
}
end
- it 'sets due date to selected value, start to finish date, focus on start' do
- datepicker.expect_start_date ''
- datepicker.expect_due_date '2021-02-18'
- datepicker.expect_duration ''
+ it "sets due date to selected value, start to finish date, focus on start" do
+ datepicker.expect_start_date ""
+ datepicker.expect_due_date "2021-02-18"
+ datepicker.expect_duration ""
datepicker.focus_duration
datepicker.expect_duration_highlighted
datepicker.select_day 19
- datepicker.expect_start_date '2021-02-18'
- datepicker.expect_due_date '2021-02-19'
+ datepicker.expect_start_date "2021-02-18"
+ datepicker.expect_due_date "2021-02-19"
datepicker.expect_duration 2
datepicker.expect_start_highlighted
apply_and_expect_saved duration: 2,
- start_date: Date.parse('2021-02-18'),
- due_date: Date.parse('2021-02-19'),
+ start_date: Date.parse("2021-02-18"),
+ due_date: Date.parse("2021-02-19"),
ignore_non_working_days: true
end
end
- describe 'When only due date set, duration in focus, select earlier date (Scenario 23b)' do
+ describe "When only due date set, duration in focus, select earlier date (Scenario 23b)" do
let(:current_attributes) do
{
start_date: nil,
- due_date: Date.parse('2021-02-18'),
+ due_date: Date.parse("2021-02-18"),
duration: nil,
ignore_non_working_days: true
}
end
- it 'sets start date to selected date' do
- datepicker.expect_start_date ''
- datepicker.expect_due_date '2021-02-18'
- datepicker.expect_duration ''
+ it "sets start date to selected date" do
+ datepicker.expect_start_date ""
+ datepicker.expect_due_date "2021-02-18"
+ datepicker.expect_duration ""
datepicker.focus_duration
datepicker.expect_duration_highlighted
datepicker.select_day 17
- datepicker.expect_start_date '2021-02-17'
- datepicker.expect_due_date '2021-02-18'
+ datepicker.expect_start_date "2021-02-17"
+ datepicker.expect_due_date "2021-02-18"
datepicker.expect_duration 2
datepicker.expect_start_highlighted
apply_and_expect_saved duration: 2,
- start_date: Date.parse('2021-02-17'),
- due_date: Date.parse('2021-02-18'),
+ start_date: Date.parse("2021-02-17"),
+ due_date: Date.parse("2021-02-18"),
ignore_non_working_days: true
end
end
- describe 'when all values set and duration highlighted, selecting date in datepicker' do
+ describe "when all values set and duration highlighted, selecting date in datepicker" do
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-08'),
- due_date: Date.parse('2021-02-11'),
+ start_date: Date.parse("2021-02-08"),
+ due_date: Date.parse("2021-02-11"),
duration: 4
}
end
- it 'sets start to the selected value, keeps finish date' do
- datepicker.expect_start_date '2021-02-08'
- datepicker.expect_due_date '2021-02-11'
+ it "sets start to the selected value, keeps finish date" do
+ datepicker.expect_start_date "2021-02-08"
+ datepicker.expect_due_date "2021-02-11"
datepicker.expect_duration 4
# Focus duration
@@ -879,25 +879,25 @@ def apply_and_expect_saved(attributes)
# Select date in datepicker
datepicker.select_day 5
- datepicker.expect_start_date '2021-02-05'
- datepicker.expect_due_date '2021-02-10'
+ datepicker.expect_start_date "2021-02-05"
+ datepicker.expect_due_date "2021-02-10"
datepicker.expect_duration 4
# Focus is on start date
datepicker.expect_due_highlighted
datepicker.select_day 15
- datepicker.expect_start_date '2021-02-05'
- datepicker.expect_due_date '2021-02-15'
+ datepicker.expect_start_date "2021-02-05"
+ datepicker.expect_due_date "2021-02-15"
datepicker.expect_duration 7
apply_and_expect_saved duration: 7,
- start_date: Date.parse('2021-02-05'),
- due_date: Date.parse('2021-02-15')
+ start_date: Date.parse("2021-02-05"),
+ due_date: Date.parse("2021-02-15")
end
end
- describe 'when all values set and duration highlighted, selecting dates in datepicker' do
+ describe "when all values set and duration highlighted, selecting dates in datepicker" do
let(:current_attributes) do
{
start_date: nil,
@@ -906,98 +906,98 @@ def apply_and_expect_saved(attributes)
}
end
- it 'sets start to the selected value, moves to finish date' do
- datepicker.expect_start_date ''
- datepicker.expect_due_date ''
- datepicker.expect_duration ''
+ it "sets start to the selected value, moves to finish date" do
+ datepicker.expect_start_date ""
+ datepicker.expect_due_date ""
+ datepicker.expect_duration ""
# Focus duration
datepicker.duration_field.click
datepicker.expect_duration_highlighted
# Select date in datepicker
- datepicker.set_start_date Date.parse('2021-02-05')
+ datepicker.set_start_date Date.parse("2021-02-05")
- datepicker.expect_start_date '2021-02-05'
+ datepicker.expect_start_date "2021-02-05"
datepicker.expect_due_highlighted
- datepicker.expect_due_date ''
- datepicker.expect_duration ''
+ datepicker.expect_due_date ""
+ datepicker.expect_duration ""
datepicker.select_day 9
- datepicker.expect_start_date '2021-02-05'
- datepicker.expect_due_date '2021-02-09'
+ datepicker.expect_start_date "2021-02-05"
+ datepicker.expect_due_date "2021-02-09"
datepicker.expect_duration 3
apply_and_expect_saved duration: 3,
- start_date: Date.parse('2021-02-05'),
- due_date: Date.parse('2021-02-09')
+ start_date: Date.parse("2021-02-05"),
+ due_date: Date.parse("2021-02-09")
end
end
- context 'when setting ignore NWD to true for a milestone' do
+ context "when setting ignore NWD to true for a milestone" do
let(:date_attribute) { :date }
let(:work_package) { milestone_wp }
let(:current_attributes) do
{
- start_date: '2022-06-20',
- due_date: '2022-06-20',
+ start_date: "2022-06-20",
+ due_date: "2022-06-20",
ignore_non_working_days: false
}
end
- it 'allows to persist that value (Regression #43932)' do
- datepicker.expect_milestone_date '2022-06-20'
+ it "allows to persist that value (Regression #43932)" do
+ datepicker.expect_milestone_date "2022-06-20"
datepicker.expect_ignore_non_working_days false
datepicker.toggle_ignore_non_working_days
datepicker.expect_ignore_non_working_days true
- datepicker.expect_milestone_date '2022-06-20'
+ datepicker.expect_milestone_date "2022-06-20"
# Set date to sunday
- datepicker.set_milestone_date '2022-06-19'
- apply_and_expect_saved start_date: Date.parse('2022-06-19'),
- due_date: Date.parse('2022-06-19'),
+ datepicker.set_milestone_date "2022-06-19"
+ apply_and_expect_saved start_date: Date.parse("2022-06-19"),
+ due_date: Date.parse("2022-06-19"),
ignore_non_working_days: true
end
end
- context 'when setting scheduleManually to true for a milestone' do
+ context "when setting scheduleManually to true for a milestone" do
let(:date_attribute) { :date }
let(:work_package) { milestone_wp }
let(:current_attributes) do
{
- start_date: '2022-06-20',
- due_date: '2022-06-20',
+ start_date: "2022-06-20",
+ due_date: "2022-06-20",
schedule_manually: false
}
end
- it 'allows to persist that value (Regression #46721)' do
- datepicker.expect_milestone_date '2022-06-20'
+ it "allows to persist that value (Regression #46721)" do
+ datepicker.expect_milestone_date "2022-06-20"
datepicker.expect_scheduling_mode false
datepicker.toggle_scheduling_mode
datepicker.expect_scheduling_mode true
- datepicker.expect_milestone_date '2022-06-20'
+ datepicker.expect_milestone_date "2022-06-20"
- apply_and_expect_saved start_date: Date.parse('2022-06-20'),
- due_date: Date.parse('2022-06-20'),
+ apply_and_expect_saved start_date: Date.parse("2022-06-20"),
+ due_date: Date.parse("2022-06-20"),
schedule_manually: true
date_field.activate!
date_field.expect_active!
datepicker.expect_visible
- datepicker.expect_milestone_date '2022-06-20'
+ datepicker.expect_milestone_date "2022-06-20"
datepicker.expect_scheduling_mode true
end
end
- context 'when setting start and due date through today links' do
+ context "when setting start and due date through today links" do
let(:current_attributes) do
{
start_date: nil,
@@ -1007,20 +1007,20 @@ def apply_and_expect_saved(attributes)
}
end
- it 'allows to persist that value (Regression #44140)' do
- datepicker.expect_start_date ''
- datepicker.expect_due_date ''
- datepicker.expect_duration ''
+ it "allows to persist that value (Regression #44140)" do
+ datepicker.expect_start_date ""
+ datepicker.expect_due_date ""
+ datepicker.expect_duration ""
today = Time.zone.today
today_str = today.iso8601
# Setting start will set active to due
- datepicker.set_today 'start'
+ datepicker.set_today "start"
datepicker.expect_start_date today_str
datepicker.expect_due_highlighted
- datepicker.set_today 'due'
+ datepicker.set_today "due"
datepicker.expect_due_date today_str
datepicker.expect_start_highlighted
@@ -1032,32 +1032,32 @@ def apply_and_expect_saved(attributes)
end
end
- context 'when the user locale has a custom digit map' do
+ context "when the user locale has a custom digit map" do
let(:current_user) { create(:admin, language: :ar) }
let(:current_attributes) do
{
- start_date: Date.parse('2021-02-08'),
+ start_date: Date.parse("2021-02-08"),
due_date: nil,
duration: nil
}
end
- it 'still renders the traditional Arabic numbers without errors' do
+ it "still renders the traditional Arabic numbers without errors" do
work_packages_page.expect_no_toaster(type: :error, message: "is not a valid date.")
- datepicker.expect_start_date '2021-02-08'
- datepicker.expect_due_date ''
- datepicker.expect_duration ''
+ datepicker.expect_start_date "2021-02-08"
+ datepicker.expect_due_date ""
+ datepicker.expect_duration ""
datepicker.set_duration 10
- datepicker.expect_start_date '2021-02-08'
- datepicker.expect_due_date '2021-02-19'
+ datepicker.expect_start_date "2021-02-08"
+ datepicker.expect_due_date "2021-02-19"
datepicker.expect_duration 10
apply_and_expect_saved duration: 10,
- start_date: Date.parse('2021-02-08'),
- due_date: Date.parse('2021-02-19')
+ start_date: Date.parse("2021-02-08"),
+ due_date: Date.parse("2021-02-19")
end
end
end
diff --git a/spec/features/work_packages/datepicker/datepicker_non_working_day_spec.rb b/spec/features/work_packages/datepicker/datepicker_non_working_day_spec.rb
index a5e34ae11ebe..939287fcba12 100644
--- a/spec/features/work_packages/datepicker/datepicker_non_working_day_spec.rb
+++ b/spec/features/work_packages/datepicker/datepicker_non_working_day_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'support/edit_fields/edit_field'
+require "spec_helper"
+require "support/edit_fields/edit_field"
-RSpec.describe 'Datepicker modal individual non working days (WP #44453)', :js,
- with_settings: { date_format: '%Y-%m-%d' } do
+RSpec.describe "Datepicker modal individual non working days (WP #44453)", :js,
+ with_settings: { date_format: "%Y-%m-%d" } do
shared_let(:user) { create(:admin) }
shared_let(:project) { create(:project) }
@@ -51,12 +51,12 @@
date: Time.zone.today.end_of_year.next_occurring(:tuesday))
end
- shared_examples 'shows individual non working days' do
+ shared_examples "shows individual non working days" do
let(:work_packages_page) { Pages::FullWorkPackage.new(work_package, project) }
let(:date_field) { work_packages_page.edit_field(date_attribute) }
let(:datepicker) { date_field.datepicker }
- it 'loads and shows individual non working days when navigating' do
+ it "loads and shows individual non working days when navigating" do
login_as user
work_packages_page.visit!
@@ -76,17 +76,17 @@
end
end
- context 'for multi date work package' do
+ context "for multi date work package" do
let(:work_package) { bug_wp }
let(:date_attribute) { :combinedDate }
- it_behaves_like 'shows individual non working days'
+ it_behaves_like "shows individual non working days"
end
- context 'for milestone work package' do
+ context "for milestone work package" do
let(:work_package) { milestone_wp }
let(:date_attribute) { :date }
- it_behaves_like 'shows individual non working days'
+ it_behaves_like "shows individual non working days"
end
end
diff --git a/spec/features/work_packages/datepicker/datepicker_parent_spec.rb b/spec/features/work_packages/datepicker/datepicker_parent_spec.rb
index 1aa18d14b625..7d9d9c3494fe 100644
--- a/spec/features/work_packages/datepicker/datepicker_parent_spec.rb
+++ b/spec/features/work_packages/datepicker/datepicker_parent_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'support/edit_fields/edit_field'
+require "spec_helper"
+require "support/edit_fields/edit_field"
-RSpec.describe 'Datepicker logic on parents', :js, with_settings: { date_format: '%Y-%m-%d' } do
+RSpec.describe "Datepicker logic on parents", :js, with_settings: { date_format: "%Y-%m-%d" } do
shared_let(:user) { create(:admin) }
# assume sat+sun are non working days
@@ -62,16 +62,16 @@
datepicker.expect_visible
end
- context 'with the child having set dates' do
+ context "with the child having set dates" do
let(:child_attributes) do
{
- start_date: '2021-02-01',
- due_date: '2021-02-02',
+ start_date: "2021-02-01",
+ due_date: "2021-02-02",
ignore_non_working_days: true
}
end
- it 'disables the non working days options' do
+ it "disables the non working days options" do
datepicker.expect_ignore_non_working_days_disabled
datepicker.expect_scheduling_mode false
diff --git a/spec/features/work_packages/details/closed_status_and_version_spec.rb b/spec/features/work_packages/details/closed_status_and_version_spec.rb
index 46293fc9c65e..6f3bef669265 100644
--- a/spec/features/work_packages/details/closed_status_and_version_spec.rb
+++ b/spec/features/work_packages/details/closed_status_and_version_spec.rb
@@ -1,12 +1,12 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Closed status and version in full view', :js do
+RSpec.describe "Closed status and version in full view", :js do
let(:type) { create(:type) }
let(:status) { create(:closed_status) }
let(:project) { create(:project, types: [type]) }
- let(:version) { create(:version, status: 'closed', project:) }
+ let(:version) { create(:version, status: "closed", project:) }
let(:work_package) { create(:work_package, project:, status:, version:) }
let(:wp_page) { Pages::FullWorkPackage.new(work_package, project) }
@@ -17,13 +17,13 @@
wp_page.visit!
end
- it 'shows a warning when trying to edit status' do
+ it "shows a warning when trying to edit status" do
# Should be initially editable (due to non specific schema)
status = page.find("#{test_selector('op-wp-status-button')} button:not([disabled])")
status.click
wp_page.expect_and_dismiss_toaster type: :error,
- message: I18n.t('js.work_packages.message_work_package_status_blocked')
+ message: I18n.t("js.work_packages.message_work_package_status_blocked")
expect(page).to have_css("#{test_selector('op-wp-status-button')} button[disabled]")
end
diff --git a/spec/features/work_packages/details/context_menu_spec.rb b/spec/features/work_packages/details/context_menu_spec.rb
index 54cab9a7b520..1620d50c1afc 100644
--- a/spec/features/work_packages/details/context_menu_spec.rb
+++ b/spec/features/work_packages/details/context_menu_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package single context menu', :js do
+RSpec.describe "Work package single context menu", :js do
let(:user) { create(:admin) }
let(:work_package) { create(:work_package) }
@@ -9,18 +9,18 @@
before do
login_as(user)
wp_view.visit!
- find('#action-show-more-dropdown-menu .button').click
+ find("#action-show-more-dropdown-menu .button").click
end
- it 'sets the correct copy project link' do
- find('.menu-item', text: 'Copy to other project', exact_text: true).click
- expect(page).to have_css('h2', text: I18n.t(:button_copy))
- expect(page).to have_css('a.work_package', text: "##{work_package.id}")
+ it "sets the correct copy project link" do
+ find(".menu-item", text: "Copy to other project", exact_text: true).click
+ expect(page).to have_css("h2", text: I18n.t(:button_copy))
+ expect(page).to have_css("a.work_package", text: "##{work_package.id}")
expect(page).to have_current_path /work_packages\/move\/new\?copy=true&ids\[\]=#{work_package.id}/
end
- it 'successfully copies the short url of the work package' do
- find('.menu-item', text: 'Copy link to clipboard', exact_text: true).click
+ it "successfully copies the short url of the work package" do
+ find(".menu-item", text: "Copy link to clipboard", exact_text: true).click
# We cannot access the navigator.clipboard from a headless browser.
# This test makes sure the copy to clipboard logic is working,
diff --git a/spec/features/work_packages/details/custom_fields/custom_field_spec.rb b/spec/features/work_packages/details/custom_fields/custom_field_spec.rb
index 5ce3fc766c47..7443dc0953b3 100644
--- a/spec/features/work_packages/details/custom_fields/custom_field_spec.rb
+++ b/spec/features/work_packages/details/custom_fields/custom_field_spec.rb
@@ -1,8 +1,8 @@
-require 'spec_helper'
-require 'features/work_packages/work_packages_page'
-require 'features/work_packages/details/inplace_editor/shared_examples'
+require "spec_helper"
+require "features/work_packages/work_packages_page"
+require "features/work_packages/details/inplace_editor/shared_examples"
-RSpec.describe 'custom field inplace editor', :js do
+RSpec.describe "custom field inplace editor", :js do
let(:user) { create(:admin) }
let(:type) { create(:type_standard, custom_fields:) }
let(:project) do
@@ -33,19 +33,19 @@ def expect_update(value, update_args)
wp_field = update_args.delete(:field) { field }
wp_field.set_value value
- wp_field.submit_by_enter if wp_field.field_type == 'input'
+ wp_field.submit_by_enter if wp_field.field_type == "input"
wp_page.expect_toast(**update_args)
wp_page.dismiss_toaster!
end
- describe 'long text' do
+ describe "long text" do
let(:custom_field) do
- create(:issue_custom_field, :text, name: 'LongText')
+ create(:issue_custom_field, :text, name: "LongText")
end
let(:field) { TextEditorField.new wp_page, property_name }
- let(:initial_custom_values) { { custom_field.id => 'foo' } }
+ let(:initial_custom_values) { { custom_field.id => "foo" } }
- it 'can cancel through the button only' do
+ it "can cancel through the button only" do
# Activate the field
field.activate!
@@ -58,11 +58,11 @@ def expect_update(value, update_args)
field.expect_inactive!
end
- it_behaves_like 'a workpackage autocomplete field'
- it_behaves_like 'not a principal autocomplete field'
+ it_behaves_like "a workpackage autocomplete field"
+ it_behaves_like "not a principal autocomplete field"
end
- describe 'custom field lists' do
+ describe "custom field lists" do
let(:custom_field1) do
create(:list_wp_custom_field,
is_required: false,
@@ -77,12 +77,12 @@ def expect_update(value, update_args)
let(:custom_fields) { [custom_field1, custom_field2] }
let(:field1) do
f = wp_page.custom_edit_field(custom_field1)
- f.field_type = 'create-autocompleter'
+ f.field_type = "create-autocompleter"
f
end
let(:field2) do
f = wp_page.custom_edit_field(custom_field2)
- f.field_type = 'create-autocompleter'
+ f.field_type = "create-autocompleter"
f
end
let(:initial_custom_values) { {} }
@@ -91,98 +91,98 @@ def custom_value(value)
CustomOption.find_by(value:).try(:id)
end
- it 'properly updates both values' do
+ it "properly updates both values" do
field1.activate!
- expect_update 'bar',
- message: I18n.t('js.notice_successful_update'),
+ expect_update "bar",
+ message: I18n.t("js.notice_successful_update"),
field: field1
field2.activate!
- expect_update 'Y',
- message: I18n.t('js.notice_successful_update'),
+ expect_update "Y",
+ message: I18n.t("js.notice_successful_update"),
field: field2
- wp_page.expect_attributes "customField#{custom_field1.id}": 'bar',
- "customField#{custom_field2.id}": 'Y'
+ wp_page.expect_attributes "customField#{custom_field1.id}": "bar",
+ "customField#{custom_field2.id}": "Y"
field1.activate!
- expect(field1.input_element).to have_text 'bar'
+ expect(field1.input_element).to have_text "bar"
field1.cancel_by_escape
field2.activate!
- expect(field2.input_element).to have_text 'Y'
+ expect(field2.input_element).to have_text "Y"
- expect_update 'X',
- message: I18n.t('js.notice_successful_update'),
+ expect_update "X",
+ message: I18n.t("js.notice_successful_update"),
field: field2
- wp_page.expect_attributes "customField#{custom_field1.id}": 'bar',
- "customField#{custom_field2.id}": 'X'
+ wp_page.expect_attributes "customField#{custom_field1.id}": "bar",
+ "customField#{custom_field2.id}": "X"
end
end
- describe 'integer type' do
+ describe "integer type" do
let(:custom_field) do
- create(:issue_custom_field, :integer, args.merge(name: 'MyNumber'))
+ create(:issue_custom_field, :integer, args.merge(name: "MyNumber"))
end
let(:initial_custom_values) { { custom_field.id => 123 } }
- context 'with length restrictions' do
+ context "with length restrictions" do
let(:args) do
{ min_length: 2, max_length: 5 }
end
- it 'renders errors for invalid entries' do
+ it "renders errors for invalid entries" do
field.activate!
# exceeding max length
- expect_update '123456',
+ expect_update "123456",
type: :error,
- message: 'MyNumber is too long (maximum is 5 characters).'
+ message: "MyNumber is too long (maximum is 5 characters)."
# below min length
- expect_update '1',
+ expect_update "1",
type: :error,
- message: 'MyNumber is too short (minimum is 2 characters).'
+ message: "MyNumber is too short (minimum is 2 characters)."
# Correct value
- expect_update '9999',
- message: I18n.t('js.notice_successful_update')
- wp_page.expect_attributes property_name => '9999'
+ expect_update "9999",
+ message: I18n.t("js.notice_successful_update")
+ wp_page.expect_attributes property_name => "9999"
end
end
- context 'with no restrictions' do
+ context "with no restrictions" do
let(:args) { {} }
- it 'renders errors for invalid entries' do
+ it "renders errors for invalid entries" do
# Valid input
field.activate!
- expect_update '9999999999',
- message: I18n.t('js.notice_successful_update')
- wp_page.expect_attributes property_name => '9999999999'
+ expect_update "9999999999",
+ message: I18n.t("js.notice_successful_update")
+ wp_page.expect_attributes property_name => "9999999999"
# Remove value
field.activate!
- expect_update '',
- message: I18n.t('js.notice_successful_update')
- wp_page.expect_attributes property_name => '-'
+ expect_update "",
+ message: I18n.t("js.notice_successful_update")
+ wp_page.expect_attributes property_name => "-"
# Zero value
field.activate_edition
- expect_update '0',
- message: I18n.t('js.notice_successful_update')
- wp_page.expect_attributes property_name => '0'
+ expect_update "0",
+ message: I18n.t("js.notice_successful_update")
+ wp_page.expect_attributes property_name => "0"
end
end
- context 'when required' do
+ context "when required" do
let(:args) { { is_required: true } }
- it 'renders errors for invalid entries' do
+ it "renders errors for invalid entries" do
# Invalid input (non-digit)
field.activate!
- field.set_value ''
+ field.set_value ""
field.expect_invalid
field.save!
@@ -193,43 +193,43 @@ def custom_value(value)
end
end
- describe 'float type' do
+ describe "float type" do
let(:custom_field) do
- create(:float_wp_custom_field, args.merge(name: 'MyFloat'))
+ create(:float_wp_custom_field, args.merge(name: "MyFloat"))
end
let(:args) { {} }
let(:initial_custom_values) { { custom_field.id => 123.50 } }
- context 'with zero value' do
- let(:user) { create(:admin, language: 'en') }
+ context "with zero value" do
+ let(:user) { create(:admin, language: "en") }
let(:initial_custom_values) { { custom_field.id => 0 } }
- it 'displays the zero (Regression #37157)' do
- field.expect_state_text '0'
+ it "displays the zero (Regression #37157)" do
+ field.expect_state_text "0"
end
end
- context 'with english locale' do
- let(:user) { create(:admin, language: 'en') }
+ context "with english locale" do
+ let(:user) { create(:admin, language: "en") }
- it 'displays the float with english locale and allows editing' do
- field.expect_state_text '123.5'
- field.update '10000.55'
- field.expect_state_text '10,000.55'
+ it "displays the float with english locale and allows editing" do
+ field.expect_state_text "123.5"
+ field.update "10000.55"
+ field.expect_state_text "10,000.55"
work_package.reload
expect(work_package.custom_value_for(custom_field.id).typed_value).to eq 10000.55
end
end
- context 'with german locale',
+ context "with german locale",
driver: :firefox_de do
- let(:user) { create(:admin, language: 'de') }
+ let(:user) { create(:admin, language: "de") }
- it 'displays the float with german locale and allows editing' do
- field.expect_state_text '123,5'
- field.update '10000,55'
- field.expect_state_text '10.000,55'
+ it "displays the float with german locale and allows editing" do
+ field.expect_state_text "123,5"
+ field.update "10000,55"
+ field.expect_state_text "10.000,55"
work_package.reload
expect(work_package.custom_value_for(custom_field.id).typed_value).to eq 10000.55
diff --git a/spec/features/work_packages/details/date_editor_spec.rb b/spec/features/work_packages/details/date_editor_spec.rb
index b0556bad4ffc..fddcd03c5d20 100644
--- a/spec/features/work_packages/details/date_editor_spec.rb
+++ b/spec/features/work_packages/details/date_editor_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/page_objects/notification'
-require 'features/work_packages/details/inplace_editor/shared_examples'
-require 'features/work_packages/shared_contexts'
-require 'support/edit_fields/edit_field'
-require 'features/work_packages/work_packages_page'
-
-RSpec.describe 'date inplace editor', :js, :selenium, with_settings: { date_format: '%Y-%m-%d' } do
+require "spec_helper"
+require "features/page_objects/notification"
+require "features/work_packages/details/inplace_editor/shared_examples"
+require "features/work_packages/shared_contexts"
+require "support/edit_fields/edit_field"
+require "features/work_packages/work_packages_page"
+
+RSpec.describe "date inplace editor", :js, :selenium, with_settings: { date_format: "%Y-%m-%d" } do
shared_let(:project) { create(:project_with_types, public: true) }
shared_let(:user) { create(:admin) }
shared_let(:type) { project.types.first }
@@ -49,7 +49,7 @@
)
end
- let(:work_package) { create(:work_package, project:, start_date: Date.parse('2016-01-02'), duration: nil) }
+ let(:work_package) { create(:work_package, project:, start_date: Date.parse("2016-01-02"), duration: nil) }
let(:work_packages_page) { Pages::FullWorkPackage.new(work_package, project) }
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
@@ -66,28 +66,28 @@
work_packages_page.ensure_page_loaded
end
- it 'can directly set the due date when only a start date is set' do
+ it "can directly set the due date when only a start date is set" do
start_date.activate!
start_date.expect_active!
- start_date.datepicker.expect_year '2016'
- start_date.datepicker.expect_month 'January'
- start_date.datepicker.select_day '25'
+ start_date.datepicker.expect_year "2016"
+ start_date.datepicker.expect_month "January"
+ start_date.datepicker.select_day "25"
- start_date.datepicker.expect_start_date '2016-01-02'
- start_date.datepicker.expect_due_date '2016-01-25'
+ start_date.datepicker.expect_start_date "2016-01-02"
+ start_date.datepicker.expect_due_date "2016-01-25"
start_date.datepicker.expect_duration 24
start_date.save!
start_date.expect_inactive!
- start_date.expect_state_text '2016-01-02 - 2016-01-25'
+ start_date.expect_state_text "2016-01-02 - 2016-01-25"
end
it 'can set "today" as a date via the provided link' do
start_date.activate!
start_date.expect_active!
- start_date.datepicker.expect_start_date '2016-01-02'
+ start_date.datepicker.expect_start_date "2016-01-02"
start_date.datepicker.expect_year work_package.start_date.year
start_date.datepicker.expect_month work_package.start_date.strftime("%B")
start_date.datepicker.expect_day work_package.start_date.day
@@ -104,84 +104,84 @@
start_date.expect_state_text "#{Time.zone.today.strftime('%Y-%m-%d')} - no finish date"
end
- context 'with start and end date set' do
+ context "with start and end date set" do
let(:work_package) do
create(:work_package,
project:,
- start_date: Date.parse('2016-01-02'),
- due_date: Date.parse('2016-01-25'))
+ start_date: Date.parse("2016-01-02"),
+ due_date: Date.parse("2016-01-25"))
end
- it 'selecting a date before the current start date will move the finish date' do
+ it "selecting a date before the current start date will move the finish date" do
start_date.activate!
start_date.expect_active!
- start_date.datepicker.expect_year '2016'
- start_date.datepicker.expect_month 'January'
- start_date.datepicker.select_day '1'
+ start_date.datepicker.expect_year "2016"
+ start_date.datepicker.expect_month "January"
+ start_date.datepicker.select_day "1"
- start_date.datepicker.expect_start_date '2016-01-01'
- start_date.datepicker.expect_due_date '2016-01-24'
+ start_date.datepicker.expect_start_date "2016-01-01"
+ start_date.datepicker.expect_due_date "2016-01-24"
start_date.datepicker.expect_duration 24
start_date.save!
start_date.expect_inactive!
- start_date.expect_state_text '2016-01-01 - 2016-01-24'
+ start_date.expect_state_text "2016-01-01 - 2016-01-24"
end
- it 'selecting a date in between changes the date that is currently in focus' do
+ it "selecting a date in between changes the date that is currently in focus" do
start_date.activate!
start_date.expect_active!
- start_date.datepicker.expect_year '2016'
- start_date.datepicker.expect_month 'January'
- start_date.datepicker.select_day '3'
+ start_date.datepicker.expect_year "2016"
+ start_date.datepicker.expect_month "January"
+ start_date.datepicker.select_day "3"
- start_date.datepicker.expect_start_date '2016-01-03'
+ start_date.datepicker.expect_start_date "2016-01-03"
# Since the focus shifts automatically, we can directly click again to modify the end date
- start_date.datepicker.select_day '21'
+ start_date.datepicker.select_day "21"
- start_date.datepicker.expect_due_date '2016-01-21'
+ start_date.datepicker.expect_due_date "2016-01-21"
start_date.datepicker.expect_duration 19
start_date.save!
start_date.expect_inactive!
- start_date.expect_state_text '2016-01-03 - 2016-01-21'
+ start_date.expect_state_text "2016-01-03 - 2016-01-21"
end
- it 'selecting a date after the current finish date will change either start or finish depending on the focus' do
+ it "selecting a date after the current finish date will change either start or finish depending on the focus" do
start_date.activate!
start_date.expect_active!
- start_date.datepicker.expect_year '2016'
- start_date.datepicker.expect_month 'January'
+ start_date.datepicker.expect_year "2016"
+ start_date.datepicker.expect_month "January"
# Focus the end date field
start_date.activate_due_date_within_modal
- start_date.datepicker.set_due_date '2016-03-01'
+ start_date.datepicker.set_due_date "2016-03-01"
# Since the end date is focused, the date will become the new end date
start_date.save!
start_date.expect_inactive!
- start_date.expect_state_text '2016-01-02 - 2016-03-01'
+ start_date.expect_state_text "2016-01-02 - 2016-03-01"
# Activating again and now changing the start date to something after the current end date
start_date.activate!
start_date.expect_active!
- start_date.datepicker.expect_year '2016'
- start_date.datepicker.expect_month 'January'
- start_date.datepicker.set_start_date '2016-04-01'
+ start_date.datepicker.expect_year "2016"
+ start_date.datepicker.expect_month "January"
+ start_date.datepicker.set_start_date "2016-04-01"
# This will set the new start and unset the end date
start_date.save!
start_date.expect_inactive!
- start_date.expect_state_text '2016-04-01 - no finish date'
+ start_date.expect_state_text "2016-04-01 - no finish date"
end
end
- context 'with the start date empty' do
+ context "with the start date empty" do
let(:work_package) { create(:work_package, project:, start_date: nil, duration: nil) }
it 'can set "today" as a date via the provided link' do
@@ -203,7 +203,7 @@
end
end
- it 'can set start and due date to the same day' do
+ it "can set start and due date to the same day" do
start_date.activate!
start_date.expect_active!
@@ -226,10 +226,10 @@
start_date.save!
start_date.expect_inactive!
- start_date.expect_state_text Time.zone.today.strftime('%Y-%m-%d')
+ start_date.expect_state_text Time.zone.today.strftime("%Y-%m-%d")
end
- it 'can set a negative duration which gets transformed (Regression #44219)' do
+ it "can set a negative duration which gets transformed (Regression #44219)" do
start_date.activate!
start_date.expect_active!
@@ -240,7 +240,7 @@
start_date.datepicker.expect_duration 128
end
- it 'saves the date when clearing and then confirming' do
+ it "saves the date when clearing and then confirming" do
start_date.activate!
start_date.input_element.click
@@ -250,35 +250,35 @@
sleep 1
start_date.save!
- work_packages_page.expect_and_dismiss_toaster message: 'Successful update.'
+ work_packages_page.expect_and_dismiss_toaster message: "Successful update."
start_date.expect_inactive!
- start_date.expect_state_text 'no start date'
+ start_date.expect_state_text "no start date"
work_package.reload
expect(work_package.start_date).to be_nil
end
- it 'closes the date picker when moving away' do
+ it "closes the date picker when moving away" do
wp_table.visit!
wp_table.open_full_screen_by_doubleclick work_package
start_date.activate!
start_date.expect_active!
- page.execute_script('window.history.back()')
+ page.execute_script("window.history.back()")
work_packages_page.accept_alert_dialog! if work_packages_page.has_alert_dialog?
# Ensure no modal survives
- expect(page).to have_no_css('.spot-modal')
+ expect(page).to have_no_css(".spot-modal")
end
- context 'with a date custom field' do
+ context "with a date custom field" do
let(:cf_field) { EditField.new page, date_cf.attribute_name(:camel_case) }
let(:datepicker) { Components::BasicDatepicker.new }
let(:create_page) { Pages::FullWorkPackageCreate.new(project:) }
- it 'can handle creating a CF date' do
+ it "can handle creating a CF date" do
create_page.visit!
type_field = create_page.edit_field(:type)
@@ -297,15 +297,15 @@
# Open date picker
cf_field.input_element.click
datepicker.set_date Time.zone.today
- create_page.edit_field(:subject).set_value 'My subject!'
+ create_page.edit_field(:subject).set_value "My subject!"
create_page.save!
- create_page.expect_and_dismiss_toaster message: 'Successful creation'
+ create_page.expect_and_dismiss_toaster message: "Successful creation"
wp = WorkPackage.last
expect(wp.custom_value_for(date_cf.id).value).to eq Time.zone.today.iso8601
end
- it 'can set the date via the in-place editing' do
+ it "can set the date via the in-place editing" do
datepicker.expect_not_visible
cf_field.activate!
@@ -313,13 +313,13 @@
datepicker.set_date Time.zone.today
- create_page.expect_and_dismiss_toaster message: 'Successful update.'
+ create_page.expect_and_dismiss_toaster message: "Successful update."
cf_field.expect_inactive!
- cf_field.expect_state_text Time.zone.today.strftime('%Y-%m-%d')
+ cf_field.expect_state_text Time.zone.today.strftime("%Y-%m-%d")
end
end
- context 'with the work package having no relations whatsoever' do
+ context "with the work package having no relations whatsoever" do
let!(:work_package) { create(:work_package, project:) }
before do
@@ -327,19 +327,19 @@
start_date.expect_active!
end
- it 'does not show a banner with or without manual scheduling' do
- expect(page).not_to have_test_selector('op-modal-banner-warning')
- expect(page).not_to have_test_selector('op-modal-banner-info')
+ it "does not show a banner with or without manual scheduling" do
+ expect(page).not_to have_test_selector("op-modal-banner-warning")
+ expect(page).not_to have_test_selector("op-modal-banner-info")
# When toggling manually scheduled
start_date.toggle_scheduling_mode
- expect(page).not_to have_test_selector('op-modal-banner-warning')
- expect(page).not_to have_test_selector('op-modal-banner-info')
+ expect(page).not_to have_test_selector("op-modal-banner-warning")
+ expect(page).not_to have_test_selector("op-modal-banner-info")
end
end
- context 'with the work package being the last in the hierarchy' do
+ context "with the work package being the last in the hierarchy" do
let!(:parent) { create(:work_package, project:, schedule_manually:, start_date: 1.day.ago, due_date: 5.days.from_now) }
let!(:work_package) { create(:work_package, project:, schedule_manually:, parent:) }
@@ -348,12 +348,12 @@
start_date.expect_active!
end
- context 'when work package is manually scheduled' do
+ context "when work package is manually scheduled" do
let(:schedule_manually) { true }
- it 'shows a banner that the relations are ignored' do
+ it "shows a banner that the relations are ignored" do
expect(page).to have_css("#{test_selector('op-modal-banner-warning')} span",
- text: 'Manual scheduling enabled, all relations ignored.',
+ text: "Manual scheduling enabled, all relations ignored.",
wait: 5)
# When toggling manually scheduled
@@ -362,9 +362,9 @@
# Expect new banner info
expect(page)
.to have_css("#{test_selector('op-modal-banner-warning')} span",
- text: 'Changing these dates will affect dates of related work packages.')
+ text: "Changing these dates will affect dates of related work packages.")
- new_window = window_opened_by { click_on 'Show relations' }
+ new_window = window_opened_by { click_on "Show relations" }
switch_to_window new_window
wp_table.expect_work_package_listed parent
@@ -375,25 +375,25 @@
end
end
- context 'when work package is not manually scheduled' do
+ context "when work package is not manually scheduled" do
let(:schedule_manually) { false }
- it 'shows a banner that the start date is limited' do
+ it "shows a banner that the start date is limited" do
expect(page)
.to have_css("#{test_selector('op-modal-banner-warning')} span",
- text: 'Changing these dates will affect dates of related work packages.',
+ text: "Changing these dates will affect dates of related work packages.",
wait: 5)
# When toggling manually scheduled
start_date.toggle_scheduling_mode
expect(page).to have_css("#{test_selector('op-modal-banner-warning')} span",
- text: 'Manual scheduling enabled, all relations ignored.')
+ text: "Manual scheduling enabled, all relations ignored.")
end
end
end
- context 'with the work package being a parent' do
+ context "with the work package being a parent" do
let!(:child) { create(:work_package, project:, start_date: 1.day.ago, due_date: 5.days.from_now) }
let!(:work_package) do
wp = create(:work_package, project:, schedule_manually:)
@@ -406,21 +406,21 @@
start_date.expect_active!
end
- context 'when parent is manually scheduled' do
+ context "when parent is manually scheduled" do
let(:schedule_manually) { true }
- it 'shows a banner that the relations are ignored' do
+ it "shows a banner that the relations are ignored" do
expect(page).to have_css("#{test_selector('op-modal-banner-warning')} span",
- text: 'Manual scheduling enabled, all relations ignored.')
+ text: "Manual scheduling enabled, all relations ignored.")
# When toggling manually scheduled
start_date.toggle_scheduling_mode
# Expect banner to switch
expect(page).to have_css("#{test_selector('op-modal-banner-info')} span",
- text: 'Automatically scheduled. Dates are derived from relations.')
+ text: "Automatically scheduled. Dates are derived from relations.")
- new_window = window_opened_by { click_on 'Show relations' }
+ new_window = window_opened_by { click_on "Show relations" }
switch_to_window new_window
wp_table.expect_work_package_listed child
@@ -429,39 +429,39 @@
end
end
- context 'when parent is not manually scheduled' do
+ context "when parent is not manually scheduled" do
let(:schedule_manually) { false }
- it 'shows a banner that the dates are not editable' do
+ it "shows a banner that the dates are not editable" do
expect(page).to have_css("#{test_selector('op-modal-banner-info')} span",
- text: 'Automatically scheduled. Dates are derived from relations.')
+ text: "Automatically scheduled. Dates are derived from relations.")
# When toggling manually scheduled
start_date.toggle_scheduling_mode
expect(page).to have_css("#{test_selector('op-modal-banner-warning')} span",
- text: 'Manual scheduling enabled, all relations ignored.')
+ text: "Manual scheduling enabled, all relations ignored.")
- new_window = window_opened_by { click_on 'Show relations' }
+ new_window = window_opened_by { click_on "Show relations" }
switch_to_window new_window
wp_table.expect_work_package_listed child
wp_timeline.expect_timeline!
end
- context 'when parent is not manually scheduled, child has workdays only set' do
+ context "when parent is not manually scheduled, child has workdays only set" do
let(:schedule_manually) { false }
let!(:child) do
create(:work_package,
project:,
ignore_non_working_days: false,
- start_date: Date.parse('2022-09-27'),
- due_date: Date.parse('2022-09-29'))
+ start_date: Date.parse("2022-09-27"),
+ due_date: Date.parse("2022-09-29"))
end
- it 'allows switching to manual scheduling to set the ignore NWD (Regression #43933)' do
+ it "allows switching to manual scheduling to set the ignore NWD (Regression #43933)" do
expect(page).to have_css("#{test_selector('op-modal-banner-info')} span",
- text: 'Automatically scheduled. Dates are derived from relations.')
+ text: "Automatically scheduled. Dates are derived from relations.")
# Expect "Working days only" to be checked
datepicker.expect_ignore_non_working_days_disabled
@@ -474,7 +474,7 @@
datepicker.expect_ignore_non_working_days true
expect(page).to have_css("#{test_selector('op-modal-banner-warning')} span",
- text: 'Manual scheduling enabled, all relations ignored.')
+ text: "Manual scheduling enabled, all relations ignored.")
# Reset when disabled
start_date.toggle_scheduling_mode
@@ -482,13 +482,13 @@
datepicker.expect_ignore_non_working_days false, disabled: true
expect(page).to have_css("#{test_selector('op-modal-banner-info')} span",
- text: 'Automatically scheduled. Dates are derived from relations.')
+ text: "Automatically scheduled. Dates are derived from relations.")
end
end
end
end
- context 'with the work package having a precedes relation' do
+ context "with the work package having a precedes relation" do
let!(:work_package) { create(:work_package, project:, schedule_manually:) }
let!(:preceding) { create(:work_package, project:, start_date: 10.days.ago, due_date: 5.days.ago) }
@@ -504,21 +504,21 @@
start_date.expect_active!
end
- context 'when work package is manually scheduled' do
+ context "when work package is manually scheduled" do
let(:schedule_manually) { true }
- it 'shows a banner that the relations are ignored' do
+ it "shows a banner that the relations are ignored" do
expect(page).to have_css("#{test_selector('op-modal-banner-warning')} span",
- text: 'Manual scheduling enabled, all relations ignored.')
+ text: "Manual scheduling enabled, all relations ignored.")
# When toggling manually scheduled
start_date.toggle_scheduling_mode
# Expect new banner info
expect(page).to have_css("#{test_selector('op-modal-banner-info')} span",
- text: 'Available start and finish dates are limited by relations.')
+ text: "Available start and finish dates are limited by relations.")
- new_window = window_opened_by { click_on 'Show relations' }
+ new_window = window_opened_by { click_on "Show relations" }
switch_to_window new_window
wp_table.expect_work_package_listed preceding
@@ -527,23 +527,23 @@
end
end
- context 'when work package is not manually scheduled' do
+ context "when work package is not manually scheduled" do
let(:schedule_manually) { false }
- it 'shows a banner that the start date is limited' do
+ it "shows a banner that the start date is limited" do
expect(page).to have_css("#{test_selector('op-modal-banner-info')} span",
- text: 'Available start and finish dates are limited by relations.')
+ text: "Available start and finish dates are limited by relations.")
# When toggling manually scheduled
start_date.toggle_scheduling_mode
expect(page).to have_css("#{test_selector('op-modal-banner-warning')} span",
- text: 'Manual scheduling enabled, all relations ignored.')
+ text: "Manual scheduling enabled, all relations ignored.")
end
end
end
- context 'with the work package having a follows relation' do
+ context "with the work package having a follows relation" do
let!(:work_package) { create(:work_package, project:, schedule_manually:) }
let!(:following) { create(:work_package, project:, start_date: 5.days.from_now, due_date: 10.days.from_now) }
@@ -559,21 +559,21 @@
start_date.expect_active!
end
- context 'when work package is manually scheduled' do
+ context "when work package is manually scheduled" do
let(:schedule_manually) { true }
- it 'shows a banner that the relations are ignored' do
+ it "shows a banner that the relations are ignored" do
expect(page).to have_css("#{test_selector('op-modal-banner-warning')} span",
- text: 'Manual scheduling enabled, all relations ignored.')
+ text: "Manual scheduling enabled, all relations ignored.")
# When toggling manually scheduled
start_date.toggle_scheduling_mode
expect(page)
.to have_css("#{test_selector('op-modal-banner-warning')} span",
- text: 'Changing these dates will affect dates of related work packages.')
+ text: "Changing these dates will affect dates of related work packages.")
- new_window = window_opened_by { click_on 'Show relations' }
+ new_window = window_opened_by { click_on "Show relations" }
switch_to_window new_window
wp_table.expect_work_package_listed following
@@ -582,41 +582,41 @@
end
end
- context 'when work package is not manually scheduled' do
+ context "when work package is not manually scheduled" do
let(:schedule_manually) { false }
- it 'shows a banner that the start date is limited' do
+ it "shows a banner that the start date is limited" do
expect(page)
.to have_css("#{test_selector('op-modal-banner-warning')} span",
- text: 'Changing these dates will affect dates of related work packages.')
+ text: "Changing these dates will affect dates of related work packages.")
# When toggling manually scheduled
start_date.toggle_scheduling_mode
expect(page).to have_css("#{test_selector('op-modal-banner-warning')} span",
- text: 'Manual scheduling enabled, all relations ignored.')
+ text: "Manual scheduling enabled, all relations ignored.")
end
end
end
- context 'with a negative time zone', driver: :chrome_new_york_time_zone do
- it 'can normally select the dates via datepicker (regression #43562)' do
+ context "with a negative time zone", driver: :chrome_new_york_time_zone do
+ it "can normally select the dates via datepicker (regression #43562)" do
start_date.activate!
start_date.expect_active!
- start_date.datepicker.expect_year '2016'
- start_date.datepicker.expect_month 'January'
- start_date.datepicker.select_day '25'
+ start_date.datepicker.expect_year "2016"
+ start_date.datepicker.expect_month "January"
+ start_date.datepicker.select_day "25"
sleep 2
- start_date.datepicker.expect_year '2016'
- start_date.datepicker.expect_month 'January'
- start_date.datepicker.expect_day '25'
+ start_date.datepicker.expect_year "2016"
+ start_date.datepicker.expect_month "January"
+ start_date.datepicker.expect_day "25"
start_date.save!
start_date.expect_inactive!
- start_date.expect_state_text '2016-01-02 - 2016-01-25'
+ start_date.expect_state_text "2016-01-02 - 2016-01-25"
end
end
end
diff --git a/spec/features/work_packages/details/details_refreshing_spec.rb b/spec/features/work_packages/details/details_refreshing_spec.rb
index 729316f6ffaf..df950bfbcab9 100644
--- a/spec/features/work_packages/details/details_refreshing_spec.rb
+++ b/spec/features/work_packages/details/details_refreshing_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/work_packages/work_packages_page'
+require "spec_helper"
+require "features/work_packages/work_packages_page"
-RSpec.describe 'Work package table refreshing due to split view', :js, :with_cuprite do
+RSpec.describe "Work package table refreshing due to split view", :js, :with_cuprite do
let(:project) { create(:project_with_types) }
let!(:work_package) { create(:work_package, project:) }
let(:wp_split) { Pages::SplitWorkPackage.new work_package }
@@ -41,13 +41,13 @@
wp_split.visit!
end
- it 'toggles the watch state' do
+ it "toggles the watch state" do
wp_split.ensure_page_loaded
wp_split.edit_field(:subject).expect_text work_package.subject
wp_table.expect_work_package_listed work_package
page.within wp_table.row(work_package) do
- expect(page).to have_css('.wp-table--drag-and-drop-handle.icon-drag-handle', visible: :all)
+ expect(page).to have_css(".wp-table--drag-and-drop-handle.icon-drag-handle", visible: :all)
end
end
end
diff --git a/spec/features/work_packages/details/details_toolbar_spec.rb b/spec/features/work_packages/details/details_toolbar_spec.rb
index 48b9ed001fa9..0c88255ccb2b 100644
--- a/spec/features/work_packages/details/details_toolbar_spec.rb
+++ b/spec/features/work_packages/details/details_toolbar_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/work_packages/work_packages_page'
+require "spec_helper"
+require "features/work_packages/work_packages_page"
-RSpec.describe 'Work package details toolbar', :js, :selenium do
+RSpec.describe "Work package details toolbar", :js, :selenium do
let(:project) { create(:project_with_types, public: true) }
let!(:work_package) { create(:work_package, project:) }
let(:work_packages_page) { WorkPackagesPage.new(project) }
- describe 'toggle watch state' do
+ describe "toggle watch state" do
let(:user) { create(:admin) }
before do
@@ -42,17 +42,17 @@
work_packages_page.visit_index(work_package)
end
- it 'toggles the watch state' do
+ it "toggles the watch state" do
expect(work_package.watcher_users).not_to include(user)
- expect(page).to have_css('.work-packages--details-toolbar button', text: 'Watch')
- within '.work-packages--details-toolbar' do
- click_button 'Watch'
+ expect(page).to have_css(".work-packages--details-toolbar button", text: "Watch")
+ within ".work-packages--details-toolbar" do
+ click_button "Watch"
end
- expect(page).to have_css('.work-packages--details-toolbar button', text: 'Unwatch')
+ expect(page).to have_css(".work-packages--details-toolbar button", text: "Unwatch")
expect(work_package.reload.watcher_users).to include(user)
- expect(page).to have_css('.work-packages--details-toolbar button', text: 'Unwatch')
+ expect(page).to have_css(".work-packages--details-toolbar button", text: "Unwatch")
end
end
end
diff --git a/spec/features/work_packages/details/inplace_editor/shared_examples.rb b/spec/features/work_packages/details/inplace_editor/shared_examples.rb
index 1b7c1a9e7ade..510bbf5e22d9 100644
--- a/spec/features/work_packages/details/inplace_editor/shared_examples.rb
+++ b/spec/features/work_packages/details/inplace_editor/shared_examples.rb
@@ -1,12 +1,12 @@
-RSpec.shared_examples 'as an accessible inplace editor' do
- it 'triggers edit mode on click' do
+RSpec.shared_examples "as an accessible inplace editor" do
+ it "triggers edit mode on click" do
scroll_to_element(field.display_element)
field.activate_edition
expect(field).to be_editing
field.cancel_by_escape
end
- it 'triggers edit mode on RETURN key' do
+ it "triggers edit mode on RETURN key" do
scroll_to_element(field.display_element)
field.display_element.native.send_keys(:return)
@@ -14,43 +14,43 @@
field.cancel_by_escape
end
- it 'is focusable' do
+ it "is focusable" do
scroll_to_element(field.display_element)
- tab_index = field.display_element['tabindex']
+ tab_index = field.display_element["tabindex"]
expect(tab_index).not_to be_nil
- expect(tab_index).not_to eq('-1')
+ expect(tab_index).not_to eq("-1")
end
end
-RSpec.shared_examples 'as an auth aware field' do
- context 'when is editable' do
- it_behaves_like 'as an accessible inplace editor'
+RSpec.shared_examples "as an auth aware field" do
+ context "when is editable" do
+ it_behaves_like "as an accessible inplace editor"
end
- context 'when user is authorized' do
- it 'is editable' do
+ context "when user is authorized" do
+ it "is editable" do
expect(field).to be_editable
end
end
- context 'when user is not authorized' do
+ context "when user is not authorized" do
let(:user) do
create(:user, member_with_permissions: { project => %i(view_work_packages) })
end
- it 'is not editable' do
+ it "is not editable" do
expect(field).not_to be_editable
end
end
end
-RSpec.shared_context 'as a single validation point' do
+RSpec.shared_context "as a single validation point" do
let(:other_field) { EditField.new page, :type }
before do
other_field.activate_edition
field.activate_edition
- field.input_element.set ''
+ field.input_element.set ""
field.submit_by_enter
end
@@ -60,10 +60,10 @@
end
end
-RSpec.shared_context 'as a required field' do
+RSpec.shared_context "as a required field" do
before do
field.activate_edition
- field.input_element.set ''
+ field.input_element.set ""
field.submit_by_enter
end
@@ -72,69 +72,69 @@
end
end
-RSpec.shared_examples 'a cancellable field' do
- shared_examples 'cancelling properly' do
- it 'reverts to read state and keeps its focus' do
+RSpec.shared_examples "a cancellable field" do
+ shared_examples "cancelling properly" do
+ it "reverts to read state and keeps its focus" do
expect(field).not_to be_editing
field.expect_state_text(work_package.send(property_name))
- active_class_name = page.evaluate_script('document.activeElement.className')
+ active_class_name = page.evaluate_script("document.activeElement.className")
expect(active_class_name).to include(field.display_selector[1..])
end
end
- context 'for escape' do
+ context "for escape" do
before do
field.activate!
sleep 1
field.cancel_by_escape
end
- it_behaves_like 'cancelling properly'
+ it_behaves_like "cancelling properly"
end
end
-RSpec.shared_examples 'a workpackage autocomplete field' do
- let!(:wp2) { create(:work_package, project:, subject: 'AutoFoo') }
+RSpec.shared_examples "a workpackage autocomplete field" do
+ let!(:wp2) { create(:work_package, project:, subject: "AutoFoo") }
- it 'autocompletes the other work package' do
+ it "autocompletes the other work package" do
field.activate!
field.clear
field.type(" ##{wp2.id}")
- expect(page).to have_css('.mention-list-item', text: wp2.to_s.strip)
+ expect(page).to have_css(".mention-list-item", text: wp2.to_s.strip)
end
end
-RSpec.shared_examples 'a principal autocomplete field' do
+RSpec.shared_examples "a principal autocomplete field" do
let(:role) { create(:project_role, permissions: %i[view_work_packages edit_work_packages]) }
let!(:user) do
create(:user,
member_with_roles: { project => role },
- firstname: 'John')
+ firstname: "John")
end
let!(:mentioned_user) do
create(:user,
member_with_roles: { project => role },
- firstname: 'Laura',
- lastname: 'Foobar')
+ firstname: "Laura",
+ lastname: "Foobar")
end
let!(:mentioned_group) do
- create(:group, lastname: 'Laudators', member_with_roles: { project => role })
+ create(:group, lastname: "Laudators", member_with_roles: { project => role })
end
- shared_examples 'principal autocomplete on field' do
+ shared_examples "principal autocomplete on field" do
before do
wp_page.visit!
wp_page.ensure_page_loaded
end
- it 'autocompletes links to user profiles' do
+ it "autocompletes links to user profiles" do
field.activate!
field.clear with_backspace: true
field.input_element.send_keys(" @lau")
- expect(page).to have_css('.mention-list-item', text: mentioned_user.name)
- expect(page).to have_css('.mention-list-item', text: mentioned_group.name)
- expect(page).to have_no_css('.mention-list-item', text: user.name)
+ expect(page).to have_css(".mention-list-item", text: mentioned_user.name)
+ expect(page).to have_css(".mention-list-item", text: mentioned_group.name)
+ expect(page).to have_no_css(".mention-list-item", text: user.name)
# Close the autocompleter
field.input_element.send_keys :escape
@@ -142,67 +142,67 @@
sleep 2
- field.ckeditor.type_slowly '@Laura'
- expect(page).to have_css('.mention-list-item', text: mentioned_user.name)
- expect(page).to have_no_css('.mention-list-item', text: mentioned_group.name)
- expect(page).to have_no_css('.mention-list-item', text: user.name)
+ field.ckeditor.type_slowly "@Laura"
+ expect(page).to have_css(".mention-list-item", text: mentioned_user.name)
+ expect(page).to have_no_css(".mention-list-item", text: mentioned_group.name)
+ expect(page).to have_no_css(".mention-list-item", text: user.name)
end
end
- context 'with the project page' do
+ context "with the project page" do
let(:wp_page) { Pages::SplitWorkPackage.new(work_package, project) }
- it_behaves_like 'principal autocomplete on field'
+ it_behaves_like "principal autocomplete on field"
end
- context 'without the project page' do
+ context "without the project page" do
let(:wp_page) { Pages::SplitWorkPackage.new(work_package) }
- it_behaves_like 'principal autocomplete on field'
+ it_behaves_like "principal autocomplete on field"
end
end
-RSpec.shared_examples 'not a principal autocomplete field' do
+RSpec.shared_examples "not a principal autocomplete field" do
let(:role) { create(:project_role, permissions: %i[view_work_packages edit_work_packages]) }
let!(:user) do
create(:user,
member_with_roles: { project => role },
- firstname: 'John')
+ firstname: "John")
end
let!(:mentioned_user) do
create(:user,
member_with_roles: { project => role },
- firstname: 'Laura',
- lastname: 'Foobar')
+ firstname: "Laura",
+ lastname: "Foobar")
end
let!(:mentioned_group) do
- create(:group, lastname: 'Laudators', member_with_roles: { project => role })
+ create(:group, lastname: "Laudators", member_with_roles: { project => role })
end
- shared_examples 'not principal autocomplete on field' do
+ shared_examples "not principal autocomplete on field" do
before do
wp_page.visit!
wp_page.ensure_page_loaded
end
- it 'does not autocompletes links to user profiles' do
+ it "does not autocompletes links to user profiles" do
field.activate!
field.clear with_backspace: true
field.input_element.send_keys(" @lau")
sleep 2
- expect(page).to have_no_css('.mention-list-item')
+ expect(page).to have_no_css(".mention-list-item")
end
end
- context 'with the project page' do
+ context "with the project page" do
let(:wp_page) { Pages::SplitWorkPackage.new(work_package, project) }
- it_behaves_like 'not principal autocomplete on field'
+ it_behaves_like "not principal autocomplete on field"
end
- context 'without the project page' do
+ context "without the project page" do
let(:wp_page) { Pages::SplitWorkPackage.new(work_package) }
- it_behaves_like 'not principal autocomplete on field'
+ it_behaves_like "not principal autocomplete on field"
end
end
diff --git a/spec/features/work_packages/details/inplace_editor/subject_editor_spec.rb b/spec/features/work_packages/details/inplace_editor/subject_editor_spec.rb
index 32788c9d7d27..e3cb1a6d0741 100644
--- a/spec/features/work_packages/details/inplace_editor/subject_editor_spec.rb
+++ b/spec/features/work_packages/details/inplace_editor/subject_editor_spec.rb
@@ -1,14 +1,14 @@
-require 'spec_helper'
-require 'features/page_objects/notification'
-require 'features/work_packages/details/inplace_editor/shared_examples'
-require 'features/work_packages/shared_contexts'
-require 'support/edit_fields/edit_field'
-require 'features/work_packages/work_packages_page'
-
-RSpec.describe 'subject inplace editor', :js, :selenium do
+require "spec_helper"
+require "features/page_objects/notification"
+require "features/work_packages/details/inplace_editor/shared_examples"
+require "features/work_packages/shared_contexts"
+require "support/edit_fields/edit_field"
+require "features/work_packages/work_packages_page"
+
+RSpec.describe "subject inplace editor", :js, :selenium do
let(:project) { create(:project_with_types, public: true) }
let(:property_name) { :subject }
- let(:property_title) { 'Subject' }
+ let(:property_title) { "Subject" }
let(:work_package) { create(:work_package, project:) }
let(:user) { create(:admin) }
let(:work_packages_page) { Pages::SplitWorkPackage.new(work_package, project) }
@@ -22,33 +22,33 @@
work_packages_page.ensure_page_loaded
end
- context 'as a read state' do
- it 'has correct content' do
+ context "as a read state" do
+ it "has correct content" do
field.expect_state_text(work_package.send(property_name))
end
end
- it_behaves_like 'as an auth aware field'
- it_behaves_like 'a cancellable field'
- it_behaves_like 'as a single validation point'
- it_behaves_like 'as a required field'
+ it_behaves_like "as an auth aware field"
+ it_behaves_like "a cancellable field"
+ it_behaves_like "as a single validation point"
+ it_behaves_like "as a required field"
- context 'as an edit state' do
+ context "as an edit state" do
before do
field.activate_edition
end
- it 'renders a text input' do
+ it "renders a text input" do
expect(field.input_element).to be_visible
- expect(field.input_element['type']).to eq 'text'
+ expect(field.input_element["type"]).to eq "text"
end
- it 'has a correct value for the input' do
+ it "has a correct value for the input" do
expect(field.input_element[:value]).to eq work_package.subject
end
- it 'displays an error when too long' do
- too_long = '*' * 256
+ it "displays an error when too long" do
+ too_long = "*" * 256
field.set_value too_long
field.submit_by_enter
@@ -56,34 +56,34 @@
field.expect_active!
expect(field.input_element.value).to eq(too_long)
- notification.expect_error('Subject is too long (maximum is 255 characters)')
+ notification.expect_error("Subject is too long (maximum is 255 characters)")
end
- context 'when save' do
+ context "when save" do
before do
- field.input_element.set 'Aloha'
+ field.input_element.set "Aloha"
end
# safeguard
- include_context 'ensure wp details pane update done' do
+ include_context "ensure wp details pane update done" do
let(:update_user) { user }
end
- it 'saves the value on ENTER' do
+ it "saves the value on ENTER" do
field.submit_by_enter
- field.expect_state_text('Aloha')
+ field.expect_state_text("Aloha")
end
end
end
- context 'with conflicting modification' do
- it 'shows a conflict when modified elsewhere' do
- work_package.subject = 'Some other subject!'
+ context "with conflicting modification" do
+ it "shows a conflict when modified elsewhere" do
+ work_package.subject = "Some other subject!"
work_package.save!
field.display_element.click
- notification.expect_error(I18n.t('api_v3.errors.code_409'))
+ notification.expect_error(I18n.t("api_v3.errors.code_409"))
end
end
end
diff --git a/spec/features/work_packages/details/inplace_editor/version_editor_spec.rb b/spec/features/work_packages/details/inplace_editor/version_editor_spec.rb
index 120d461958fa..1d3fac2cd741 100644
--- a/spec/features/work_packages/details/inplace_editor/version_editor_spec.rb
+++ b/spec/features/work_packages/details/inplace_editor/version_editor_spec.rb
@@ -1,39 +1,39 @@
-require 'spec_helper'
-require 'features/work_packages/details/inplace_editor/shared_examples'
-require 'features/work_packages/shared_contexts'
-require 'support/edit_fields/edit_field'
-require 'features/work_packages/work_packages_page'
+require "spec_helper"
+require "features/work_packages/details/inplace_editor/shared_examples"
+require "features/work_packages/shared_contexts"
+require "support/edit_fields/edit_field"
+require "features/work_packages/work_packages_page"
-RSpec.describe 'subject inplace editor', :js, :selenium do
- let(:project) { create(:project_with_types, name: 'Root', public: true) }
- let(:subproject1) { create(:project_with_types, name: 'Child', parent: project) }
- let(:subproject2) { create(:project_with_types, name: 'Aunt', parent: project) }
+RSpec.describe "subject inplace editor", :js, :selenium do
+ let(:project) { create(:project_with_types, name: "Root", public: true) }
+ let(:subproject1) { create(:project_with_types, name: "Child", parent: project) }
+ let(:subproject2) { create(:project_with_types, name: "Aunt", parent: project) }
let!(:version) do
create(:version,
- name: '1. First version',
- status: 'open',
- sharing: 'tree',
- start_date: '2019-02-02',
- effective_date: '2019-02-03',
+ name: "1. First version",
+ status: "open",
+ sharing: "tree",
+ start_date: "2019-02-02",
+ effective_date: "2019-02-03",
project:)
end
let!(:version2) do
create(:version,
- status: 'open',
- sharing: 'tree',
- name: '2. Second version',
- start_date: '2020-02-02',
- effective_date: '2020-02-03',
+ status: "open",
+ sharing: "tree",
+ name: "2. Second version",
+ start_date: "2020-02-02",
+ effective_date: "2020-02-03",
project: subproject1)
end
let!(:version3) do
create(:version,
- status: 'open',
- sharing: 'tree',
+ status: "open",
+ sharing: "tree",
start_date: nil,
effective_date: nil,
- name: '3. Third version',
+ name: "3. Third version",
project: subproject2)
end
@@ -50,60 +50,60 @@
let(:permissions) { %i[view_work_packages edit_work_packages assign_versions] }
let(:work_package_page) { Pages::FullWorkPackage.new(work_package) }
- context 'with manage permissions' do
+ context "with manage permissions" do
before do
login_as(user)
end
- it 'renders hierarchical versions' do
+ it "renders hierarchical versions" do
work_package_page.visit!
work_package_page.ensure_page_loaded
field = work_package_page.work_package_field(:version)
field.activate!
- expect(page).to have_css('.ng-option-label', text: '-')
- expect(page).to have_css('.ng-option-label', text: version3.name)
- expect(page).to have_css('.ng-option-label', text: version2.name)
- expect(page).to have_css('.ng-option-label', text: version.name)
+ expect(page).to have_css(".ng-option-label", text: "-")
+ expect(page).to have_css(".ng-option-label", text: version3.name)
+ expect(page).to have_css(".ng-option-label", text: version2.name)
+ expect(page).to have_css(".ng-option-label", text: version.name)
# Expect the order to be descending by version date
- labels = page.all('.ng-option-label').map { |el| el.text.strip }
- expect(labels).to eq ['-', version.name, version2.name, version3.name]
+ labels = page.all(".ng-option-label").map { |el| el.text.strip }
+ expect(labels).to eq ["-", version.name, version2.name, version3.name]
- page.find('.ng-option-label', text: version3.name).select_option
+ page.find(".ng-option-label", text: version3.name).select_option
field.expect_state_text(version3.name)
end
- it 'allows creating versions from within the WP view' do
+ it "allows creating versions from within the WP view" do
work_package_page.visit!
work_package_page.ensure_page_loaded
field = work_package_page.work_package_field(:version)
field.activate!
- field.set_new_value 'Super cool new release'
- field.expect_state_text 'Super cool new release'
+ field.set_new_value "Super cool new release"
+ field.expect_state_text "Super cool new release"
visit project_settings_versions_path(project)
- expect(page).to have_content 'Super cool new release'
+ expect(page).to have_content "Super cool new release"
end
end
- context 'without the permission to manage versions' do
+ context "without the permission to manage versions" do
before do
login_as(second_user)
end
- it 'does not allow creating versions from within the WP view' do
+ it "does not allow creating versions from within the WP view" do
work_package_page.visit!
work_package_page.ensure_page_loaded
field = work_package_page.work_package_field(:version)
field.activate!
- field.input_element.find('input').set 'Version that does not exist'
- expect(page).to have_no_css('.ng-option', text: 'Create: Version that does not exist')
+ field.input_element.find("input").set "Version that does not exist"
+ expect(page).to have_no_css(".ng-option", text: "Create: Version that does not exist")
end
end
end
diff --git a/spec/features/work_packages/details/markdown/activity_comments_spec.rb b/spec/features/work_packages/details/markdown/activity_comments_spec.rb
index 64a72b3c82ab..06ba11d9d6ec 100644
--- a/spec/features/work_packages/details/markdown/activity_comments_spec.rb
+++ b/spec/features/work_packages/details/markdown/activity_comments_spec.rb
@@ -1,9 +1,9 @@
-require 'spec_helper'
+require "spec_helper"
-require 'features/work_packages/shared_contexts'
-require 'features/work_packages/details/inplace_editor/shared_examples'
+require "features/work_packages/shared_contexts"
+require "features/work_packages/details/inplace_editor/shared_examples"
-RSpec.describe 'activity comments', :js do
+RSpec.describe "activity comments", :js do
let(:project) { create(:project, public: true) }
let!(:work_package) do
create(:work_package,
@@ -11,20 +11,20 @@
journal_notes: initial_comment)
end
let(:wp_page) { Pages::SplitWorkPackage.new(work_package, project) }
- let(:selector) { '.work-packages--activity--add-comment' }
+ let(:selector) { ".work-packages--activity--add-comment" }
let(:comment_field) do
TextEditorField.new wp_page,
- 'comment',
+ "comment",
selector:
end
- let(:initial_comment) { 'the first comment in this WP' }
+ let(:initial_comment) { "the first comment in this WP" }
before do
login_as(current_user)
allow(current_user.pref).to receive(:warn_on_leaving_unsaved?).and_return(false)
end
- context 'with permission' do
+ context "with permission" do
let(:current_user) { create(:admin) }
before do
@@ -32,169 +32,169 @@
wp_page.ensure_page_loaded
end
- context 'in edit state' do
+ context "in edit state" do
before do
comment_field.activate!
end
- describe 'submitting comment' do
- it 'does not submit with enter' do
- comment_field.click_and_type_slowly 'this is a comment'
+ describe "submitting comment" do
+ it "does not submit with enter" do
+ comment_field.click_and_type_slowly "this is a comment"
comment_field.submit_by_enter
- expect(page).to have_no_css('.user-comment .message', text: 'this is a comment')
+ expect(page).to have_no_css(".user-comment .message", text: "this is a comment")
end
- it 'submits with click' do
- comment_field.click_and_type_slowly 'this is a comment!1'
+ it "submits with click" do
+ comment_field.click_and_type_slowly "this is a comment!1"
comment_field.submit_by_click
- wp_page.expect_comment text: 'this is a comment!1'
+ wp_page.expect_comment text: "this is a comment!1"
end
- it 'submits comments repeatedly' do
- comment_field.click_and_type_slowly 'this is my first comment!1'
+ it "submits comments repeatedly" do
+ comment_field.click_and_type_slowly "this is my first comment!1"
comment_field.submit_by_click
- expect(page).to have_css('.user-comment > .message', count: 2)
- wp_page.expect_comment text: 'this is my first comment!1'
+ expect(page).to have_css(".user-comment > .message", count: 2)
+ wp_page.expect_comment text: "this is my first comment!1"
expect(comment_field.editing?).to be false
comment_field.activate!
expect(comment_field.editing?).to be true
- comment_field.click_and_type_slowly 'this is my second comment!1'
+ comment_field.click_and_type_slowly "this is my second comment!1"
comment_field.submit_by_click
- expect(page).to have_css('.user-comment > .message', count: 3)
- wp_page.expect_comment text: 'this is my second comment!1'
+ expect(page).to have_css(".user-comment > .message", count: 3)
+ wp_page.expect_comment text: "this is my second comment!1"
expect(comment_field.editing?).to be false
comment_field.activate!
expect(comment_field.editing?).to be true
- comment_field.click_and_type_slowly 'this is my third comment!1'
+ comment_field.click_and_type_slowly "this is my third comment!1"
comment_field.submit_by_click
# Only shows three most recent
- expect(page).to have_css('.user-comment > .message', count: 3)
- wp_page.expect_comment text: 'this is my third comment!1'
+ expect(page).to have_css(".user-comment > .message", count: 3)
+ wp_page.expect_comment text: "this is my third comment!1"
- wp_page.switch_to_tab tab: 'Activity'
+ wp_page.switch_to_tab tab: "Activity"
# Now showing all comments
- expect(page).to have_css('.user-comment > .message', count: 4, wait: 10)
+ expect(page).to have_css(".user-comment > .message", count: 4, wait: 10)
expect(comment_field.editing?).to be false
comment_field.activate!
expect(comment_field.editing?).to be true
- comment_field.click_and_type_slowly 'this is my fifth comment!1'
+ comment_field.click_and_type_slowly "this is my fifth comment!1"
comment_field.submit_by_click
- expect(page).to have_css('.user-comment > .message', count: 4)
- wp_page.expect_comment text: 'this is my fifth comment!1'
+ expect(page).to have_css(".user-comment > .message", count: 4)
+ wp_page.expect_comment text: "this is my fifth comment!1"
# Expect no activity details
- expect(page).to have_no_css('.work-package-details-activities-messages li')
+ expect(page).to have_no_css(".work-package-details-activities-messages li")
end
end
- describe 'cancel comment' do
+ describe "cancel comment" do
it do
expect(comment_field.editing?).to be true
- comment_field.input_element.set 'this is a comment'
+ comment_field.input_element.set "this is a comment"
# Escape should NOT cancel the editing
comment_field.cancel_by_escape
expect(comment_field.editing?).to be true
- expect(page).to have_no_css('.user-comment .message', text: 'this is a comment')
+ expect(page).to have_no_css(".user-comment .message", text: "this is a comment")
# Click should cancel the editing
comment_field.cancel_by_click
expect(comment_field.editing?).to be false
- expect(page).to have_no_css('.user-comment .message', text: 'this is a comment')
+ expect(page).to have_no_css(".user-comment .message", text: "this is a comment")
end
end
- describe 'autocomplete' do
- describe 'work packages' do
- let!(:wp2) { create(:work_package, project:, subject: 'AutoFoo') }
+ describe "autocomplete" do
+ describe "work packages" do
+ let!(:wp2) { create(:work_package, project:, subject: "AutoFoo") }
- it 'can move to the work package by click (Regression #30928)' do
+ it "can move to the work package by click (Regression #30928)" do
comment_field.input_element.send_keys("##{wp2.id}")
- expect(page).to have_css('.mention-list-item', text: wp2.to_s.strip)
+ expect(page).to have_css(".mention-list-item", text: wp2.to_s.strip)
comment_field.submit_by_click
- page.find('#activity-2 a.issue', text: wp2.id).click
+ page.find("#activity-2 a.issue", text: wp2.id).click
other_wp_page = Pages::FullWorkPackage.new wp2
other_wp_page.ensure_page_loaded
- other_wp_page.edit_field(:subject).expect_text 'AutoFoo'
+ other_wp_page.edit_field(:subject).expect_text "AutoFoo"
end
end
- describe 'users' do
- it_behaves_like 'a principal autocomplete field' do
+ describe "users" do
+ it_behaves_like "a principal autocomplete field" do
let(:field) { comment_field }
end
end
end
- describe 'with an existing comment' do
- it 'allows to edit an existing comment' do
+ describe "with an existing comment" do
+ it "allows to edit an existing comment" do
# Insert new text, need to do this separately.''
- ['Comment with', ' ', '*', '*', 'bold text', '*', '*', ' ', 'in it'].each do |key|
+ ["Comment with", " ", "*", "*", "bold text", "*", "*", " ", "in it"].each do |key|
comment_field.input_element.send_keys key
end
comment_field.submit_by_click
- wp_page.expect_comment text: 'Comment with bold text in it'
- wp_page.expect_comment text: 'bold text', subselector: 'strong'
+ wp_page.expect_comment text: "Comment with bold text in it"
+ wp_page.expect_comment text: "bold text", subselector: "strong"
# Hover the new activity
- activity = page.find_by_id('activity-2')
+ activity = page.find_by_id("activity-2")
page.driver.browser.action.move_to(activity.native).perform
# Check the edit textarea
- edit_button = activity.find('.icon-edit')
+ edit_button = activity.find(".icon-edit")
scroll_to_element(edit_button)
edit_button.click
edit = TextEditorField.new wp_page,
- 'comment',
- selector: '.user-comment--form'
+ "comment",
+ selector: ".user-comment--form"
# Insert new text, need to do this separately.
edit.input_element.click
- [:enter, 'Comment with', ' ', '_', 'italic text', '_', ' ', 'in it'].each do |key|
+ [:enter, "Comment with", " ", "_", "italic text", "_", " ", "in it"].each do |key|
edit.input_element.send_keys key
end
edit.submit_by_click
- wp_page.expect_comment text: 'Comment with italic text in it'
- wp_page.expect_comment text: 'italic text', subselector: 'em'
+ wp_page.expect_comment text: "Comment with italic text in it"
+ wp_page.expect_comment text: "italic text", subselector: "em"
end
end
end
- describe 'quoting' do
- it 'can quote a previous comment' do
- expect(page).to have_css('.user-comment .message',
+ describe "quoting" do
+ it "can quote a previous comment" do
+ expect(page).to have_css(".user-comment .message",
text: initial_comment)
# Hover comment
- quoted = page.find('.user-comment > .message')
+ quoted = page.find(".user-comment > .message")
scroll_to_element(quoted)
quoted.hover
# Quote this comment
- page.find('.comments-icons .icon-quote').click
+ page.find(".comments-icons .icon-quote").click
expect(comment_field.editing?).to be true
# Add our comment
- expect(comment_field.input_element).to have_css('blockquote')
+ expect(comment_field.input_element).to have_css("blockquote")
quote = comment_field.input_element[:innerHTML]
expect(quote).to eq '
Anonymous wrote:
the first comment in this WP
'
@@ -204,32 +204,32 @@
comment_field.ckeditor.click_and_type_slowly :enter
# Insert new text, need to do this separately.
- comment_field.ckeditor.click_and_type_slowly :return, 'this is ', '*', '*', 'a bold', '*', '*', ' remark'
+ comment_field.ckeditor.click_and_type_slowly :return, "this is ", "*", "*", "a bold", "*", "*", " remark"
comment_field.submit_by_click
# Scroll to the activity
- scroll_to_element(page.find_by_id('activity-2'))
+ scroll_to_element(page.find_by_id("activity-2"))
- wp_page.expect_comment text: 'this is a bold remark'
+ wp_page.expect_comment text: "this is a bold remark"
wp_page.expect_comment count: 2
- wp_page.expect_comment subselector: 'blockquote'
- wp_page.expect_comment subselector: 'strong', text: 'a bold'
+ wp_page.expect_comment subselector: "blockquote"
+ wp_page.expect_comment subselector: "strong", text: "a bold"
end
end
- describe 'referencing another work package' do
+ describe "referencing another work package" do
let!(:work_package2) { create(:work_package, project:, type: create(:type)) }
- it 'can reference another work package with all methods' do
+ it "can reference another work package with all methods" do
comment_field.activate!
# Insert a new reference using the autocompleter
comment_field.input_element.send_keys "Single ##{work_package2.id}"
expect(page)
- .to have_css('.mention-list-item', text: "#{work_package2.type.name} ##{work_package2.id}:")
+ .to have_css(".mention-list-item", text: "#{work_package2.type.name} ##{work_package2.id}:")
- find('.mention-list-item', text: "#{work_package2.type.name} ##{work_package2.id}:").click
+ find(".mention-list-item", text: "#{work_package2.type.name} ##{work_package2.id}:").click
# Insert new text, need to do this separately.
# No autocompleter used this time.
@@ -246,17 +246,17 @@
comment_field.submit_by_click
wp_page.expect_comment text: "Single ##{work_package2.id}"
- expect(page).to have_css('.user-comment opce-macro-wp-quickinfo', count: 2)
- expect(page).to have_css('.user-comment .work-package--quickinfo.preview-trigger', count: 2)
+ expect(page).to have_css(".user-comment opce-macro-wp-quickinfo", count: 2)
+ expect(page).to have_css(".user-comment .work-package--quickinfo.preview-trigger", count: 2)
end
end
- it 'can move away to another tab, keeping the draft comment' do
+ it "can move away to another tab, keeping the draft comment" do
comment_field.activate!
comment_field.input_element.send_keys "I'm typing an important message here ..."
wp_page.switch_to_tab tab: :files
- expect(page).to have_test_selector('op-tab-content--tab-section')
+ expect(page).to have_test_selector("op-tab-content--tab-section")
wp_page.switch_to_tab tab: :activity
@@ -273,7 +273,7 @@
# Has removed the draft now
wp_page.switch_to_tab tab: :files
- expect(page).to have_test_selector('op-tab-content--tab-section')
+ expect(page).to have_test_selector("op-tab-content--tab-section")
wp_page.switch_to_tab tab: :activity
comment_field.expect_inactive!
@@ -283,7 +283,7 @@
end
end
- context 'with no permission' do
+ context "with no permission" do
let(:role) { create(:project_role, permissions: %i(view_work_packages)) }
let(:current_user) { create(:user, member_with_roles: { project => role }) }
@@ -292,7 +292,7 @@
wp_page.ensure_page_loaded
end
- it 'does not show the field' do
+ it "does not show the field" do
expect(page).to have_no_selector(selector, visible: true)
end
end
diff --git a/spec/features/work_packages/details/markdown/description_editor_spec.rb b/spec/features/work_packages/details/markdown/description_editor_spec.rb
index b05ba27261ad..087ad71411c6 100644
--- a/spec/features/work_packages/details/markdown/description_editor_spec.rb
+++ b/spec/features/work_packages/details/markdown/description_editor_spec.rb
@@ -26,17 +26,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/work_packages/details/inplace_editor/shared_examples'
-require 'features/work_packages/shared_contexts'
-require 'support/edit_fields/edit_field'
-require 'features/work_packages/work_packages_page'
+require "spec_helper"
+require "features/work_packages/details/inplace_editor/shared_examples"
+require "features/work_packages/shared_contexts"
+require "support/edit_fields/edit_field"
+require "features/work_packages/work_packages_page"
-RSpec.describe 'description inplace editor', :js, :selenium do
+RSpec.describe "description inplace editor", :js, :selenium do
let(:project) { create(:project_with_types, public: true) }
let(:property_name) { :description }
- let(:property_title) { 'Description' }
- let(:description_text) { 'Ima description' }
+ let(:property_title) { "Description" }
+ let(:description_text) { "Ima description" }
let!(:work_package) do
create(
:work_package,
@@ -45,7 +45,7 @@
)
end
let(:user) { create(:admin) }
- let(:field) { TextEditorField.new wp_page, 'description' }
+ let(:field) { TextEditorField.new wp_page, "description" }
let(:wp_page) { Pages::SplitWorkPackage.new(work_package, project) }
before do
@@ -55,8 +55,8 @@
wp_page.ensure_page_loaded
end
- context 'with permission' do
- it 'allows editing description field' do
+ context "with permission" do
+ it "allows editing description field" do
field.expect_state_text(description_text)
# Regression test #24033
@@ -90,49 +90,49 @@
field.set_value "Edit to be saved by keyboard"
field.submit_by_enter
- wp_page.expect_toast message: I18n.t('js.notice_successful_update')
- field.expect_state_text 'Edit to be saved by keyboard'
+ wp_page.expect_toast message: I18n.t("js.notice_successful_update")
+ field.expect_state_text "Edit to be saved by keyboard"
end
end
- context 'when is empty' do
- let(:description_text) { '' }
+ context "when is empty" do
+ let(:description_text) { "" }
- it 'renders a placeholder' do
- field.expect_state_text 'Description: Click to edit...'
+ it "renders a placeholder" do
+ field.expect_state_text "Description: Click to edit..."
field.activate!
# An empty description is also allowed
field.expect_save_button(enabled: true)
- field.set_value 'A new hope ...'
+ field.set_value "A new hope ..."
field.expect_save_button(enabled: true)
field.submit_by_click
- wp_page.expect_toast message: I18n.t('js.notice_successful_update')
- field.expect_state_text 'A new hope ...'
+ wp_page.expect_toast message: I18n.t("js.notice_successful_update")
+ field.expect_state_text "A new hope ..."
end
end
- context 'with no permission' do
+ context "with no permission" do
let(:role) { create(:project_role, permissions: %i(view_work_packages)) }
let(:user) { create(:user, member_with_roles: { project => role }) }
- it 'does not show the field' do
- expect(page).to have_no_css('.inline-edit--display-field.description.-editable')
+ it "does not show the field" do
+ expect(page).to have_no_css(".inline-edit--display-field.description.-editable")
field.display_element.click
field.expect_inactive!
end
- context 'when is empty' do
- let(:description_text) { '' }
+ context "when is empty" do
+ let(:description_text) { "" }
- it 'renders a placeholder' do
- field.expect_state_text ''
+ it "renders a placeholder" do
+ field.expect_state_text ""
end
end
end
- it_behaves_like 'a workpackage autocomplete field'
- it_behaves_like 'a principal autocomplete field'
+ it_behaves_like "a workpackage autocomplete field"
+ it_behaves_like "a principal autocomplete field"
end
diff --git a/spec/features/work_packages/details/milestones_spec.rb b/spec/features/work_packages/details/milestones_spec.rb
index 4439aa6cd57e..c50de5a0a4ea 100644
--- a/spec/features/work_packages/details/milestones_spec.rb
+++ b/spec/features/work_packages/details/milestones_spec.rb
@@ -1,24 +1,24 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Milestones full screen v iew', :js do
+RSpec.describe "Milestones full screen v iew", :js do
let(:type) { create(:type, is_milestone: true) }
let(:project) { create(:project, types: [type]) }
let!(:work_package) do
create(:work_package,
project:,
type:,
- subject: 'Foobar')
+ subject: "Foobar")
end
let(:wp_page) { Pages::FullWorkPackage.new(work_package, project) }
- let(:button) { find('.add-work-package', wait: 5) }
+ let(:button) { find(".add-work-package", wait: 5) }
before do
login_as(user)
wp_page.visit!
end
- context 'user has :add_work_packages permission' do
+ context "user has :add_work_packages permission" do
let(:user) do
create(:user, member_with_roles: { project => role })
end
@@ -27,15 +27,15 @@
%i[view_work_packages add_work_packages]
end
- it 'shows the button as enabled' do
+ it "shows the button as enabled" do
expect(button).not_to be_disabled
button.click
- expect(page).to have_css('.menu-item', text: type.name.upcase)
+ expect(page).to have_css(".menu-item", text: type.name.upcase)
end
end
- context 'user has :view_work_packages permission only' do
+ context "user has :view_work_packages permission only" do
let(:user) do
create(:user, member_with_roles: { project => role })
end
@@ -44,8 +44,8 @@
%i[view_work_packages]
end
- it 'shows the button as correctly disabled' do
- expect(button['disabled']).to be_truthy
+ it "shows the button as correctly disabled" do
+ expect(button["disabled"]).to be_truthy
end
end
end
diff --git a/spec/features/work_packages/details/query_groups/relation_query_group_spec.rb b/spec/features/work_packages/details/query_groups/relation_query_group_spec.rb
index 92d4ec3046ed..b41c7c052f28 100644
--- a/spec/features/work_packages/details/query_groups/relation_query_group_spec.rb
+++ b/spec/features/work_packages/details/query_groups/relation_query_group_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package with relation query group', :js, :selenium do
- include_context 'ng-select-autocomplete helpers'
+RSpec.describe "Work package with relation query group", :js, :selenium do
+ include_context "ng-select-autocomplete helpers"
let(:user) { create(:admin) }
let(:project) { create(:project, types: [type]) }
@@ -60,8 +60,8 @@
let(:full_wp) { Pages::FullWorkPackage.new(work_package) }
let(:relations) { Components::WorkPackages::Relations.new(work_package) }
let(:tabs) { Components::WorkPackages::Tabs.new(work_package) }
- let(:relations_tab) { find('.op-tab-row--link', text: 'RELATIONS') }
- let(:embedded_table) { Pages::EmbeddedWorkPackagesTable.new(first('wp-single-view .work-packages-embedded-view--container')) }
+ let(:relations_tab) { find(".op-tab-row--link", text: "RELATIONS") }
+ let(:embedded_table) { Pages::EmbeddedWorkPackagesTable.new(first("wp-single-view .work-packages-embedded-view--container")) }
let(:visit) { true }
@@ -80,14 +80,14 @@
end
end
- context 'children table' do
- it 'creates and removes across all tables' do
+ context "children table" do
+ it "creates and removes across all tables" do
embedded_table.expect_work_package_count 1
relations_tab.click
relations.expect_child(related_work_package)
# Create new work package within embedded table
- embedded_table.table_container.find("button", text: I18n.t('js.relation_buttons.add_new_child')).click
+ embedded_table.table_container.find("button", text: I18n.t("js.relation_buttons.add_new_child")).click
subject_field = embedded_table.edit_field(nil, :subject)
subject_field.expect_active!
subject_field.set_value("Fresh WP\n")
@@ -107,7 +107,7 @@
end
end
- describe 'follower table with project filters' do
+ describe "follower table with project filters" do
let(:visit) { false }
let!(:project2) { create(:project, types: [type]) }
let!(:project3) { create(:project, types: [type]) }
@@ -123,17 +123,17 @@
let(:type) do
create(:type_with_relation_query_group, relation_filter: relation_type)
end
- let(:query_text) { 'Embedded Table for follows'.upcase }
+ let(:query_text) { "Embedded Table for follows".upcase }
before do
query = type.attribute_groups.last.query
- query.add_filter('project_id', '=', [project2.id, project3.id])
+ query.add_filter("project_id", "=", [project2.id, project3.id])
# User has no permission to save, avoid creating another user to allow it
query.save!(validate: false)
type.save!
end
- context 'with a user who has permission in one project' do
+ context "with a user who has permission in one project" do
let(:role) { create(:project_role, permissions:) }
let(:permissions) { %i[view_work_packages add_work_packages edit_work_packages manage_work_package_relations] }
let(:user) do
@@ -146,24 +146,24 @@
member.save!
end
- it 'can load the query and inline create' do
+ it "can load the query and inline create" do
full_wp.visit!
full_wp.ensure_page_loaded
- expect(page).to have_css('.attributes-group--header-text', text: query_text, wait: 20)
+ expect(page).to have_css(".attributes-group--header-text", text: query_text, wait: 20)
embedded_table.expect_work_package_listed related_work_package
embedded_table.click_inline_create
subject_field = embedded_table.edit_field(nil, :subject)
subject_field.expect_active!
- subject_field.set_value 'Another subject'
+ subject_field.set_value "Another subject"
subject_field.save!
- embedded_table.expect_work_package_subject 'Another subject'
+ embedded_table.expect_work_package_subject "Another subject"
end
end
- context 'with a user who has no permission in any project' do
+ context "with a user who has no permission in any project" do
let(:role) { create(:project_role, permissions:) }
let(:permissions) { [:view_work_packages] }
let(:user) do
@@ -171,18 +171,18 @@
member_with_roles: { project => role })
end
- it 'hides that group automatically without showing an error' do
+ it "hides that group automatically without showing an error" do
full_wp.visit!
full_wp.ensure_page_loaded
# Will first try to load the query, and then hide it.
- expect(page).to have_no_css('.attributes-group--header-text', text: query_text, wait: 20)
- expect(page).to have_no_css('.work-packages-embedded-view--container .op-toast.-error')
+ expect(page).to have_no_css(".attributes-group--header-text", text: query_text, wait: 20)
+ expect(page).to have_no_css(".work-packages-embedded-view--container .op-toast.-error")
end
end
end
- context 'follower table' do
+ context "follower table" do
let(:relation_type) { :follows }
let(:relation_target) { work_package }
let!(:independent_work_package) do
@@ -196,23 +196,23 @@
relations.expect_relation(related_work_package)
end
- it 'creates and removes across all tables' do
- embedded_table.table_container.find('button', text: I18n.t('js.relation_buttons.create_new')).click
+ it "creates and removes across all tables" do
+ embedded_table.table_container.find("button", text: I18n.t("js.relation_buttons.create_new")).click
subject_field = embedded_table.edit_field(nil, :subject)
subject_field.expect_active!
subject_field.set_value("Fresh WP\n")
- expect(embedded_table.table_container).to have_text('Fresh WP', wait: 10)
- relations.expect_relation_by_text('Fresh WP')
+ expect(embedded_table.table_container).to have_text("Fresh WP", wait: 10)
+ relations.expect_relation_by_text("Fresh WP")
end
- it 'add existing, remove it, add it from relations tab, remove from relations tab' do
- embedded_table.table_container.find('button', text: I18n.t('js.relation_buttons.add_existing')).click
- embedded_table.table_container.find('.wp-relations-create--form', wait: 10)
+ it "add existing, remove it, add it from relations tab, remove from relations tab" do
+ embedded_table.table_container.find("button", text: I18n.t("js.relation_buttons.add_existing")).click
+ embedded_table.table_container.find(".wp-relations-create--form", wait: 10)
autocomplete = page.find_test_selector("wp-relations-autocomplete")
select_autocomplete autocomplete,
- results_selector: '.ng-dropdown-panel-items',
+ results_selector: ".ng-dropdown-panel-items",
query: independent_work_package.subject,
select_text: independent_work_package.subject
@@ -239,9 +239,9 @@
# Check that deletion of relations still work after a page reload
full_wp.visit!
- relations_tab = find('.op-tab-row--link', text: 'RELATIONS')
+ relations_tab = find(".op-tab-row--link", text: "RELATIONS")
relations = Components::WorkPackages::Relations.new(work_package)
- embedded_table = Pages::EmbeddedWorkPackagesTable.new(first('wp-single-view .work-packages-embedded-view--container'))
+ embedded_table = Pages::EmbeddedWorkPackagesTable.new(first("wp-single-view .work-packages-embedded-view--container"))
embedded_table.table_container.find(".wp-row-#{independent_work_package.id}-table").hover
embedded_table.table_container.find("#{row} .wp-table-action--unlink").click
diff --git a/spec/features/work_packages/details/relations/hierarchy_custom_fields_spec.rb b/spec/features/work_packages/details/relations/hierarchy_custom_fields_spec.rb
index cae9d3d05c8d..025152922fa7 100644
--- a/spec/features/work_packages/details/relations/hierarchy_custom_fields_spec.rb
+++ b/spec/features/work_packages/details/relations/hierarchy_custom_fields_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'creating a child directly after the wp itself was created', :js do
+RSpec.describe "creating a child directly after the wp itself was created", :js do
let(:user) { create(:admin) }
let(:project) { create(:project, types: [type]) }
let(:wp_page) { Pages::FullWorkPackageCreate.new }
@@ -38,10 +38,10 @@
let(:type) { create(:type, custom_fields: [custom_field]) }
let(:custom_field) do
create(:work_package_custom_field,
- field_format: 'int',
+ field_format: "int",
is_for_all: true)
end
- let(:relations_tab) { find('.op-tab-row--link', text: 'RELATIONS') }
+ let(:relations_tab) { find(".op-tab-row--link", text: "RELATIONS") }
before do
login_as user
@@ -50,28 +50,28 @@
loading_indicator_saveguard
end
- it 'keeps its custom field values (regression #29511, #29446)' do
+ it "keeps its custom field values (regression #29511, #29446)" do
# Set subject
subject = wp_page.edit_field :subject
- subject.set_value 'My subject'
+ subject.set_value "My subject"
# Set CF
cf = wp_page.edit_field custom_field.attribute_name(:camel_case)
- cf.set_value '42'
+ cf.set_value "42"
# Save WP
wp_page.save!
- wp_page.expect_and_dismiss_toaster(message: 'Successful creation.')
+ wp_page.expect_and_dismiss_toaster(message: "Successful creation.")
# Add child
scroll_to_and_click relations_tab
- find_test_selector('op-wp-inline-create').click
- fill_in 'wp-new-inline-edit--field-subject', with: 'A child WP'
- find_by_id('wp-new-inline-edit--field-subject').native.send_keys(:return)
+ find_test_selector("op-wp-inline-create").click
+ fill_in "wp-new-inline-edit--field-subject", with: "A child WP"
+ find_by_id("wp-new-inline-edit--field-subject").native.send_keys(:return)
# Expect CF value to be still visible
- wp_page.expect_and_dismiss_toaster(message: 'Successful creation.')
- expect(wp_page).to have_test_selector('tab-count', text: "(1)")
- wp_page.expect_attributes "customField#{custom_field.id}": '42'
+ wp_page.expect_and_dismiss_toaster(message: "Successful creation.")
+ expect(wp_page).to have_test_selector("tab-count", text: "(1)")
+ wp_page.expect_attributes "customField#{custom_field.id}": "42"
end
end
diff --git a/spec/features/work_packages/details/relations/hierarchy_milestone_spec.rb b/spec/features/work_packages/details/relations/hierarchy_milestone_spec.rb
index 325771c868b5..952c7c371ec9 100644
--- a/spec/features/work_packages/details/relations/hierarchy_milestone_spec.rb
+++ b/spec/features/work_packages/details/relations/hierarchy_milestone_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'work package hierarchies for milestones', :js, :selenium do
+RSpec.describe "work package hierarchies for milestones", :js, :selenium do
let(:user) { create(:admin) }
let(:type) { create(:type, is_milestone: true) }
let(:project) { create(:project, types: [type]) }
@@ -37,22 +37,22 @@
let(:tabs) { Components::WorkPackages::Tabs.new(work_package) }
let(:wp_page) { Pages::FullWorkPackage.new(work_package) }
- let(:relations_tab) { find('.op-tab-row--link_selected', text: 'RELATIONS') }
+ let(:relations_tab) { find(".op-tab-row--link_selected", text: "RELATIONS") }
let(:visit) { true }
before do
login_as user
- wp_page.visit_tab!('relations')
+ wp_page.visit_tab!("relations")
expect_angular_frontend_initialized
wp_page.expect_subject
loading_indicator_saveguard
end
- it 'does not provide links to add children or existing children (Regression #28745)' do
- within('.wp-relations--children') do
- expect(page).to have_no_text('Add existing child')
- expect(page).to have_no_text('Create new child')
- expect(page).to have_no_css('wp-inline-create--add-link')
+ it "does not provide links to add children or existing children (Regression #28745)" do
+ within(".wp-relations--children") do
+ expect(page).to have_no_text("Add existing child")
+ expect(page).to have_no_text("Create new child")
+ expect(page).to have_no_css("wp-inline-create--add-link")
end
end
end
diff --git a/spec/features/work_packages/details/relations/hierarchy_spec.rb b/spec/features/work_packages/details/relations/hierarchy_spec.rb
index b4f0ccf80405..d22a198d1875 100644
--- a/spec/features/work_packages/details/relations/hierarchy_spec.rb
+++ b/spec/features/work_packages/details/relations/hierarchy_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.shared_examples 'work package relations tab', :js, :selenium do
- include_context 'ng-select-autocomplete helpers'
+RSpec.shared_examples "work package relations tab", :js, :selenium do
+ include_context "ng-select-autocomplete helpers"
let(:user) { create(:admin) }
@@ -38,7 +38,7 @@
let(:relations) { Components::WorkPackages::Relations.new(work_package) }
let(:tabs) { Components::WorkPackages::Tabs.new(work_package) }
- let(:relations_tab) { find('.op-tab-row--link_selected', text: 'RELATIONS') }
+ let(:relations_tab) { find(".op-tab-row--link_selected", text: "RELATIONS") }
let(:visit) { true }
@@ -51,18 +51,18 @@
end
def visit_relations
- wp_page.visit_tab!('relations')
+ wp_page.visit_tab!("relations")
expect_angular_frontend_initialized
wp_page.expect_subject
loading_indicator_saveguard
end
- describe 'as admin' do
- let!(:parent) { create(:work_package, project:, subject: 'Parent WP') }
- let!(:child) { create(:work_package, project:, subject: 'Child WP') }
- let!(:child2) { create(:work_package, project:, subject: 'Another child WP') }
+ describe "as admin" do
+ let!(:parent) { create(:work_package, project:, subject: "Parent WP") }
+ let!(:child) { create(:work_package, project:, subject: "Child WP") }
+ let!(:child2) { create(:work_package, project:, subject: "Another child WP") }
- it 'allows to manage hierarchy' do
+ it "allows to manage hierarchy" do
# Add parent
relations.add_parent(parent.id, parent)
relations.expect_parent(parent)
@@ -85,11 +85,11 @@ def visit_relations
tabs.expect_counter(relations_tab, 2)
end
- context 'when switching to custom field with required CF' do
+ context "when switching to custom field with required CF" do
let(:custom_field) do
create(
:work_package_custom_field,
- field_format: 'string',
+ field_format: "string",
default_value: nil,
is_required: true,
is_for_all: true
@@ -106,36 +106,36 @@ def visit_relations
custom_field
end
- it 'shows the required field when switching' do
- relations.inline_create_child 'my new child'
+ it "shows the required field when switching" do
+ relations.inline_create_child "my new child"
table = relations.children_table
- table.expect_work_package_subject 'my new child'
- wp = WorkPackage.find_by!(subject: 'my new child')
+ table.expect_work_package_subject "my new child"
+ wp = WorkPackage.find_by!(subject: "my new child")
type_field = table.edit_field(wp, :type)
type_field.activate!
type_field.set_value type2.name
wp_page.expect_toast message: "#{custom_field.name} can't be blank.",
- type: 'error'
+ type: "error"
cf_field = wp_page.edit_field(custom_field.attribute_name(:camel_case))
cf_field.expect_active!
- cf_field.expect_value('')
+ cf_field.expect_value("")
- cf_field.set_value 'my value'
+ cf_field.set_value "my value"
cf_field.save!
wp_page.expect_toast message: "Successful update.",
- type: 'success'
+ type: "success"
wp.reload
- expect(wp.custom_value_for(custom_field).value).to eq 'my value'
+ expect(wp.custom_value_for(custom_field).value).to eq "my value"
end
end
- describe 'inline create' do
+ describe "inline create" do
let!(:status) { create(:status, is_default: true) }
let!(:priority) { create(:priority, is_default: true) }
let(:type_bug) { create(:type_bug) }
@@ -143,11 +143,11 @@ def visit_relations
create(:project, types: [type_bug])
end
- it 'can inline-create children' do
- relations.inline_create_child 'my new child'
+ it "can inline-create children" do
+ relations.inline_create_child "my new child"
table = relations.children_table
- table.expect_work_package_subject 'my new child'
+ table.expect_work_package_subject "my new child"
work_package.reload
expect(work_package.children.count).to eq(1)
@@ -157,7 +157,7 @@ def visit_relations
end
end
- describe 'relation group-by toggler' do
+ describe "relation group-by toggler" do
let(:project) { create(:project, types: [type1, type2]) }
let(:type1) { create(:type) }
let(:type2) { create(:type) }
@@ -178,18 +178,18 @@ def visit_relations
relation_type: Relation::TYPE_RELATES)
end
- let(:toggle_btn_selector) { '#wp-relation-group-by-toggle' }
+ let(:toggle_btn_selector) { "#wp-relation-group-by-toggle" }
let(:visit) { false }
before do
visit_relations
- wp_page.visit_tab!('relations')
+ wp_page.visit_tab!("relations")
wp_page.expect_subject
loading_indicator_saveguard
end
- describe 'with limited permissions' do
+ describe "with limited permissions" do
let(:permissions) { %i(view_work_packages) }
let(:user_role) do
create(:project_role, permissions:)
@@ -200,41 +200,41 @@ def visit_relations
member_with_roles: { project => user_role })
end
- context 'as view-only user, with parent set' do
- let!(:parent) { create(:work_package, project:, subject: 'Parent WP') }
- let!(:work_package) { create(:work_package, parent:, project:, subject: 'Child WP') }
+ context "as view-only user, with parent set" do
+ let!(:parent) { create(:work_package, project:, subject: "Parent WP") }
+ let!(:work_package) { create(:work_package, parent:, project:, subject: "Child WP") }
- it 'shows no links to create relations' do
+ it "shows no links to create relations" do
# No create buttons should exist
- expect(page).to have_no_css('.wp-relations-create-button')
+ expect(page).to have_no_css(".wp-relations-create-button")
# Test for add relation
- expect(page).to have_no_css('#relation--add-relation')
+ expect(page).to have_no_css("#relation--add-relation")
# Test for add parent
- expect(page).to have_no_css('.wp-relation--parent-change')
+ expect(page).to have_no_css(".wp-relation--parent-change")
# Test for add children
- expect(page).to have_no_css('#hierarchy--add-existing-child')
- expect(page).to have_no_css('#hierarchy--add-new-child')
+ expect(page).to have_no_css("#hierarchy--add-existing-child")
+ expect(page).to have_no_css("#hierarchy--add-new-child")
# But it should show the linked parent
- expect(page).to have_test_selector('op-wp-breadcrumb-parent', text: parent.subject)
+ expect(page).to have_test_selector("op-wp-breadcrumb-parent", text: parent.subject)
# And it should count the two relations
tabs.expect_counter(relations_tab, 2)
end
end
- context 'with manage_subtasks permissions' do
+ context "with manage_subtasks permissions" do
let(:permissions) { %i(view_work_packages manage_subtasks) }
- let!(:parent) { create(:work_package, project:, subject: 'Parent WP') }
- let!(:child) { create(:work_package, project:, subject: 'Child WP') }
+ let!(:parent) { create(:work_package, project:, subject: "Parent WP") }
+ let!(:child) { create(:work_package, project:, subject: "Child WP") }
- it 'is able to link parent and children' do
+ it "is able to link parent and children" do
# Add parent
relations.add_parent(parent.id, parent)
- wp_page.expect_and_dismiss_toaster(message: 'Successful update.')
+ wp_page.expect_and_dismiss_toaster(message: "Successful update.")
relations.expect_parent(parent)
##
@@ -242,7 +242,7 @@ def visit_relations
relations.open_children_autocompleter
relations.add_existing_child(child)
- wp_page.expect_and_dismiss_toaster(message: 'Successful update.')
+ wp_page.expect_and_dismiss_toaster(message: "Successful update.")
relations.expect_child(child)
# Expect counter to add up child to the existing relations
@@ -250,7 +250,7 @@ def visit_relations
# Remove parent
relations.remove_parent
- wp_page.expect_and_dismiss_toaster(message: 'Successful update.')
+ wp_page.expect_and_dismiss_toaster(message: "Successful update.")
relations.expect_no_parent
# Remove child
@@ -266,14 +266,14 @@ def visit_relations
end
end
-RSpec.context 'Split screen' do
+RSpec.context "Split screen" do
let(:wp_page) { Pages::SplitWorkPackage.new(work_package) }
- it_behaves_like 'work package relations tab'
+ it_behaves_like "work package relations tab"
end
-RSpec.context 'Full screen' do
+RSpec.context "Full screen" do
let(:wp_page) { Pages::FullWorkPackage.new(work_package) }
- it_behaves_like 'work package relations tab'
+ it_behaves_like "work package relations tab"
end
diff --git a/spec/features/work_packages/details/relations/relations_spec.rb b/spec/features/work_packages/details/relations/relations_spec.rb
index 74e8ec108171..18456037b309 100644
--- a/spec/features/work_packages/details/relations/relations_spec.rb
+++ b/spec/features/work_packages/details/relations/relations_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package relations tab', :js, :selenium do
- include_context 'ng-select-autocomplete helpers'
+RSpec.describe "Work package relations tab", :js, :selenium do
+ include_context "ng-select-autocomplete helpers"
let(:user) { create(:admin) }
@@ -40,7 +40,7 @@
let(:relations) { Components::WorkPackages::Relations.new(work_package) }
let(:tabs) { Components::WorkPackages::Tabs.new(work_package) }
- let(:relations_tab) { find('.op-tab-row--link_selected', text: 'RELATIONS') }
+ let(:relations_tab) { find(".op-tab-row--link_selected", text: "RELATIONS") }
let(:visit) { true }
@@ -53,13 +53,13 @@
end
def visit_relations
- work_packages_page.visit_tab!('relations')
+ work_packages_page.visit_tab!("relations")
expect_angular_frontend_initialized
work_packages_page.expect_subject
loading_indicator_saveguard
end
- describe 'relation group-by toggler' do
+ describe "relation group-by toggler" do
let(:project) { create(:project, types: [type1, type2]) }
let(:type1) { create(:type) }
let(:type2) { create(:type) }
@@ -80,73 +80,73 @@ def visit_relations
relation_type: Relation::TYPE_RELATES)
end
- let(:toggle_btn_selector) { '#wp-relation-group-by-toggle' }
+ let(:toggle_btn_selector) { "#wp-relation-group-by-toggle" }
let(:visit) { false }
before do
visit_relations
- work_packages_page.visit_tab!('relations')
+ work_packages_page.visit_tab!("relations")
work_packages_page.expect_subject
loading_indicator_saveguard
- scroll_to_element find('.detail-panel--relations')
+ scroll_to_element find(".detail-panel--relations")
end
- it 'allows to toggle how relations are grouped' do
+ it "allows to toggle how relations are grouped" do
# Expect to be grouped by relation type by default
expect(page).to have_selector(toggle_btn_selector,
- text: 'Group by work package type', wait: 20)
+ text: "Group by work package type", wait: 20)
- expect(page).to have_css('.relation-group--header', text: 'FOLLOWS')
- expect(page).to have_css('.relation-group--header', text: 'RELATED TO')
+ expect(page).to have_css(".relation-group--header", text: "FOLLOWS")
+ expect(page).to have_css(".relation-group--header", text: "RELATED TO")
- expect(page).to have_css('.relation-row--type', text: type1.name.upcase)
- expect(page).to have_css('.relation-row--type', text: type2.name.upcase)
+ expect(page).to have_css(".relation-row--type", text: type1.name.upcase)
+ expect(page).to have_css(".relation-row--type", text: type2.name.upcase)
find(toggle_btn_selector).click
- expect(page).to have_selector(toggle_btn_selector, text: 'Group by relation type', wait: 10)
+ expect(page).to have_selector(toggle_btn_selector, text: "Group by relation type", wait: 10)
- expect(page).to have_css('.relation-group--header', text: type1.name.upcase)
- expect(page).to have_css('.relation-group--header', text: type2.name.upcase)
+ expect(page).to have_css(".relation-group--header", text: type1.name.upcase)
+ expect(page).to have_css(".relation-group--header", text: type2.name.upcase)
- expect(page).to have_css('.relation-row--type', text: 'Follows')
- expect(page).to have_css('.relation-row--type', text: 'Related To')
+ expect(page).to have_css(".relation-row--type", text: "Follows")
+ expect(page).to have_css(".relation-row--type", text: "Related To")
end
- it 'allows to edit relation types when toggled' do
+ it "allows to edit relation types when toggled" do
find(toggle_btn_selector).click
- expect(page).to have_selector(toggle_btn_selector, text: 'Group by relation type', wait: 20)
+ expect(page).to have_selector(toggle_btn_selector, text: "Group by relation type", wait: 20)
# Expect current to be follows and other one related
- expect(page).to have_css('.relation-row--type', text: 'Follows')
- expect(page).to have_css('.relation-row--type', text: 'Related To')
+ expect(page).to have_css(".relation-row--type", text: "Follows")
+ expect(page).to have_css(".relation-row--type", text: "Related To")
# edit to blocks
- relations.edit_relation_type(to1, to_type: 'Blocks')
+ relations.edit_relation_type(to1, to_type: "Blocks")
# the other one should not be altered
- expect(page).to have_css('.relation-row--type', text: 'Blocks')
- expect(page).to have_css('.relation-row--type', text: 'Related To')
+ expect(page).to have_css(".relation-row--type", text: "Blocks")
+ expect(page).to have_css(".relation-row--type", text: "Related To")
updated_relation = Relation.find(relation1.id)
- expect(updated_relation.relation_type).to eq('blocks')
+ expect(updated_relation.relation_type).to eq("blocks")
expect(updated_relation.from_id).to eq(work_package.id)
expect(updated_relation.to_id).to eq(to1.id)
- relations.edit_relation_type(to1, to_type: 'Blocked by')
+ relations.edit_relation_type(to1, to_type: "Blocked by")
- expect(page).to have_css('.relation-row--type', text: 'Blocked by')
- expect(page).to have_css('.relation-row--type', text: 'Related To')
+ expect(page).to have_css(".relation-row--type", text: "Blocked by")
+ expect(page).to have_css(".relation-row--type", text: "Related To")
updated_relation = Relation.find(relation1.id)
- expect(updated_relation.relation_type).to eq('blocks')
+ expect(updated_relation.relation_type).to eq("blocks")
expect(updated_relation.from_id).to eq(to1.id)
expect(updated_relation.to_id).to eq(work_package.id)
end
end
- describe 'with limited permissions' do
+ describe "with limited permissions" do
let(:permissions) { %i(view_work_packages) }
let(:user_role) do
create(:project_role, permissions:)
@@ -157,33 +157,33 @@ def visit_relations
member_with_roles: { project => user_role })
end
- context 'as view-only user, with parent set' do
+ context "as view-only user, with parent set" do
let(:work_package) { create(:work_package, project:) }
- it 'shows no links to create relations' do
+ it "shows no links to create relations" do
# No create buttons should exist
- expect(page).to have_no_css('.wp-relations-create-button')
+ expect(page).to have_no_css(".wp-relations-create-button")
# Test for add relation
- expect(page).to have_no_css('#relation--add-relation')
+ expect(page).to have_no_css("#relation--add-relation")
end
end
- context 'with relations permissions' do
+ context "with relations permissions" do
let(:permissions) do
%i(view_work_packages add_work_packages manage_subtasks manage_work_package_relations)
end
let!(:relatable) { create(:work_package, project:) }
- it 'allows to manage relations' do
- relations.add_relation(type: 'follows', to: relatable)
+ it "allows to manage relations" do
+ relations.add_relation(type: "follows", to: relatable)
# Relations counter badge should increase number of relations
tabs.expect_counter(relations_tab, 1)
relations.remove_relation(relatable)
- expect(page).to have_no_css('.relation-group--header', text: 'FOLLOWS')
+ expect(page).to have_no_css(".relation-group--header", text: "FOLLOWS")
# If there are no relations, the counter badge should not be displayed
tabs.expect_no_counter(relations_tab)
@@ -192,30 +192,30 @@ def visit_relations
expect(work_package.relations).to be_empty
end
- it 'allows to move between split and full view (Regression #24194)' do
- relations.add_relation(type: 'follows', to: relatable)
+ it "allows to move between split and full view (Regression #24194)" do
+ relations.add_relation(type: "follows", to: relatable)
# Relations counter should increase
tabs.expect_counter(relations_tab, 1)
# Switch to full view
- find('.work-packages--details-fullscreen-icon').click
+ find(".work-packages--details-fullscreen-icon").click
# Expect to have row
relations.hover_action(relatable, :delete)
- expect(page).to have_no_css('.relation-group--header', text: 'FOLLOWS')
- expect(page).to have_no_css('.wp-relations--subject-field', text: relatable.subject)
+ expect(page).to have_no_css(".relation-group--header", text: "FOLLOWS")
+ expect(page).to have_no_css(".wp-relations--subject-field", text: relatable.subject)
# Back to split view
- page.execute_script('window.history.back()')
+ page.execute_script("window.history.back()")
work_packages_page.expect_subject
- expect(page).to have_no_css('.relation-group--header', text: 'FOLLOWS')
- expect(page).to have_no_css('.wp-relations--subject-field', text: relatable.subject)
+ expect(page).to have_no_css(".relation-group--header", text: "FOLLOWS")
+ expect(page).to have_no_css(".wp-relations--subject-field", text: relatable.subject)
end
- it 'follows the relation links (Regression #26794)' do
- relations.add_relation(type: 'follows', to: relatable)
+ it "follows the relation links (Regression #26794)" do
+ relations.add_relation(type: "follows", to: relatable)
relations.click_relation(relatable)
subject = full_wp.edit_field(:subject)
@@ -226,54 +226,54 @@ def visit_relations
subject.expect_state_text work_package.subject
end
- it 'allows to change relation descriptions' do
- relations.add_relation(type: 'follows', to: relatable)
+ it "allows to change relation descriptions" do
+ relations.add_relation(type: "follows", to: relatable)
## Toggle description
relations.hover_action(relatable, :info)
# Open textarea
created_row = relations.find_row(relatable)
- created_row.find('.wp-relation--description-read-value.-placeholder',
- text: I18n.t('js.placeholders.relation_description')).click
+ created_row.find(".wp-relation--description-read-value.-placeholder",
+ text: I18n.t("js.placeholders.relation_description")).click
- expect(page).to have_focus_on('.wp-relation--description-textarea')
- textarea = created_row.find('.wp-relation--description-textarea')
- textarea.set 'my description!'
+ expect(page).to have_focus_on(".wp-relation--description-textarea")
+ textarea = created_row.find(".wp-relation--description-textarea")
+ textarea.set "my description!"
# Save description
- created_row.find('.inplace-edit--control--save').click
+ created_row.find(".inplace-edit--control--save").click
loading_indicator_saveguard
# Wait for the relations table to be present
sleep 2
- expect(page).to have_test_selector('op-relation--row-subject')
+ expect(page).to have_test_selector("op-relation--row-subject")
- scroll_to_element find('.detail-panel--relations')
+ scroll_to_element find(".detail-panel--relations")
## Toggle description again
retry_block do
relations.hover_action(relatable, :info)
created_row = relations.find_row(relatable)
- find '.wp-relation--description-read-value'
+ find ".wp-relation--description-read-value"
end
- created_row.find('.wp-relation--description-read-value',
- text: 'my description!').click
+ created_row.find(".wp-relation--description-read-value",
+ text: "my description!").click
# Cancel edition
- created_row.find('.inplace-edit--control--cancel').click
- created_row.find('.wp-relation--description-read-value',
- text: 'my description!').click
+ created_row.find(".inplace-edit--control--cancel").click
+ created_row.find(".wp-relation--description-read-value",
+ text: "my description!").click
relation = work_package.relations.first
- expect(relation.description).to eq('my description!')
+ expect(relation.description).to eq("my description!")
# Toggle to close
relations.hover_action(relatable, :info)
- expect(created_row).to have_no_css('.wp-relation--description-read-value')
+ expect(created_row).to have_no_css(".wp-relation--description-read-value")
end
end
end
diff --git a/spec/features/work_packages/details/workdays_spec.rb b/spec/features/work_packages/details/workdays_spec.rb
index c736a72345ec..e6f30bce626b 100644
--- a/spec/features/work_packages/details/workdays_spec.rb
+++ b/spec/features/work_packages/details/workdays_spec.rb
@@ -26,16 +26,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/page_objects/notification'
-require 'features/work_packages/details/inplace_editor/shared_examples'
-require 'features/work_packages/shared_contexts'
-require 'support/edit_fields/edit_field'
-require 'features/work_packages/work_packages_page'
+require "spec_helper"
+require "features/page_objects/notification"
+require "features/work_packages/details/inplace_editor/shared_examples"
+require "features/work_packages/shared_contexts"
+require "support/edit_fields/edit_field"
+require "features/work_packages/work_packages_page"
-RSpec.describe 'Work packages datepicker workdays', :js, with_settings: { date_format: '%Y-%m-%d' } do
+RSpec.describe "Work packages datepicker workdays", :js, with_settings: { date_format: "%Y-%m-%d" } do
shared_let(:project) { create(:project_with_types, public: true) }
- shared_let(:work_package) { create(:work_package, project:, start_date: Date.parse('2022-01-01')) }
+ shared_let(:work_package) { create(:work_package, project:, start_date: Date.parse("2022-01-01")) }
shared_let(:user) { create(:admin) }
shared_let(:work_packages_page) { Pages::FullWorkPackage.new(work_package, project) }
@@ -51,21 +51,21 @@
combined_date.expect_active!
end
- context 'with default work days' do
+ context "with default work days" do
shared_let(:working_days) { week_with_saturday_and_sunday_as_weekend }
- it 'shows them as disabled' do
- expect(page).to have_css('.dayContainer', count: 2)
+ it "shows them as disabled" do
+ expect(page).to have_css(".dayContainer", count: 2)
weekend_days = %w[1 2 8 9 15 16 22 23 29 30].map(&:to_i)
weekend_days.each do |weekend_day|
- expect(page).to have_css('.dayContainer:first-of-type .flatpickr-day.flatpickr-non-working-day',
+ expect(page).to have_css(".dayContainer:first-of-type .flatpickr-day.flatpickr-non-working-day",
text: weekend_day,
exact_text: true)
end
((1..31).to_a - weekend_days).each do |workday|
- expect(page).to have_css('.dayContainer:first-of-type .flatpickr-day:not(.flatpickr-non-working-day)',
+ expect(page).to have_css(".dayContainer:first-of-type .flatpickr-day:not(.flatpickr-non-working-day)",
text: workday,
exact_text: true)
end
diff --git a/spec/features/work_packages/display_fields/date_field_display_spec.rb b/spec/features/work_packages/display_fields/date_field_display_spec.rb
index 3cbcae25ee2b..5d08592694f1 100644
--- a/spec/features/work_packages/display_fields/date_field_display_spec.rb
+++ b/spec/features/work_packages/display_fields/date_field_display_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Show the date of a Work Package', :js do
+RSpec.describe "Show the date of a Work Package", :js do
let(:project) { create(:project) }
let(:admin) { create(:admin) }
let(:work_package) do
@@ -52,22 +52,22 @@
new_status: closed_status)
end
- context 'with an overdue date' do
+ context "with an overdue date" do
before do
login_as(admin)
wp_page.visit!
end
- it 'is highlighted only if the WP status is open (#33457)' do
+ it "is highlighted only if the WP status is open (#33457)" do
# Highlighted with an open status
- expect(page).to have_css('.inline-edit--display-field.combinedDate .__hl_date_overdue')
+ expect(page).to have_css(".inline-edit--display-field.combinedDate .__hl_date_overdue")
# Change status to closed
status_field = WorkPackageStatusField.new(page)
status_field.update(closed_status.name)
# Not highlighted with a closed status
- expect(page).to have_no_css('.inline-edit--display-field.combinedDate .__hl_date_overdue')
+ expect(page).to have_no_css(".inline-edit--display-field.combinedDate .__hl_date_overdue")
end
end
end
diff --git a/spec/features/work_packages/display_fields/estimated_hours_display_spec.rb b/spec/features/work_packages/display_fields/estimated_hours_display_spec.rb
index c67d9a50703f..3b571e999586 100644
--- a/spec/features/work_packages/display_fields/estimated_hours_display_spec.rb
+++ b/spec/features/work_packages/display_fields/estimated_hours_display_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Estimated hours display', :js do
+RSpec.describe "Estimated hours display", :js do
shared_let(:project) { create(:project) }
shared_let(:user) { create(:admin) }
shared_let(:wiki_page) { create(:wiki_page, wiki: project.wiki) }
@@ -58,8 +58,8 @@
login_as(user)
end
- shared_examples 'estimated time display' do |expected_text:|
- it 'work package index' do
+ shared_examples "estimated time display" do |expected_text:|
+ it "work package index" do
wp_table.visit_query query
wp_table.expect_work_package_listed child
@@ -68,19 +68,19 @@
)
end
- it 'work package details' do
+ it "work package details" do
visit work_package_path(parent.id)
expect(page).to have_content("Work\n#{expected_text}")
end
- it 'wiki page workPackageValue:id:estimatedTime macro' do
+ it "wiki page workPackageValue:id:estimatedTime macro" do
visit edit_project_wiki_path(project, wiki_page.id)
editor.set_markdown("workPackageValue:#{parent.id}:estimatedTime")
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_css('.wiki-content', text: expected_text)
+ expect(page).to have_css(".wiki-content", text: expected_text)
end
end
@@ -91,7 +91,7 @@
child | 3h |
TABLE
- include_examples 'estimated time display', expected_text: '1 h·Σ 4 h'
+ include_examples "estimated time display", expected_text: "1 h·Σ 4 h"
end
context "with just work" do
@@ -101,7 +101,7 @@
child | 0h |
TABLE
- include_examples 'estimated time display', expected_text: '1 h'
+ include_examples "estimated time display", expected_text: "1 h"
end
context "with just derived work with (parent work 0 h)" do
@@ -111,7 +111,7 @@
child | 3h |
TABLE
- include_examples 'estimated time display', expected_text: '0 h·Σ 3 h'
+ include_examples "estimated time display", expected_text: "0 h·Σ 3 h"
end
context "with just derived work (parent work unset)" do
@@ -121,7 +121,7 @@
child | 3h |
TABLE
- include_examples 'estimated time display', expected_text: '-·Σ 3 h'
+ include_examples "estimated time display", expected_text: "-·Σ 3 h"
end
context "with neither work nor derived work (both 0 h)" do
@@ -131,7 +131,7 @@
child | 0h |
TABLE
- include_examples 'estimated time display', expected_text: '0 h'
+ include_examples "estimated time display", expected_text: "0 h"
end
context "with neither work nor derived work (both unset)" do
@@ -141,10 +141,10 @@
child | |
TABLE
- include_examples 'estimated time display', expected_text: '-'
+ include_examples "estimated time display", expected_text: "-"
end
- describe 'link to detailed view' do
+ describe "link to detailed view" do
let_work_packages(<<~TABLE)
hierarchy | work |
parent | 5h |
@@ -158,7 +158,7 @@
# Run UpdateAncestorsService on the grand child to update the whole hierarchy derived values
let(:initiator_work_package) { grand_child21 }
- it 'displays a link to a detailed view explaining work calculation' do
+ it "displays a link to a detailed view explaining work calculation" do
wp_table.visit_query query
# parent
@@ -169,29 +169,29 @@
expect(page).to have_link("Σ 15 h")
end
- context 'when clicking the link of a top parent' do
+ context "when clicking the link of a top parent" do
before do
visit work_package_path(parent)
end
- it 'shows a work package table with a parent filter to list the direct children' do
+ it "shows a work package table with a parent filter to list the direct children" do
click_on("Σ 20 h")
wp_table.expect_work_package_count(4)
wp_table.expect_work_package_listed(parent, child1, child2, child3)
within(:table) do
- expect(page).to have_columnheader('Work')
- expect(page).to have_columnheader('Remaining work')
+ expect(page).to have_columnheader("Work")
+ expect(page).to have_columnheader("Remaining work")
end
end
end
- context 'when clicking the link of an intermediate parent' do
+ context "when clicking the link of an intermediate parent" do
before do
visit work_package_path(child2)
end
- it 'shows also all ancestors in the work package table' do
+ it "shows also all ancestors in the work package table" do
expect(page).to have_content("Work\n3 h·Σ 15 h")
click_on("Σ 15 h")
diff --git a/spec/features/work_packages/display_fields/spent_time_display_spec.rb b/spec/features/work_packages/display_fields/spent_time_display_spec.rb
index 06aa0c026b49..ed7da8592b33 100644
--- a/spec/features/work_packages/display_fields/spent_time_display_spec.rb
+++ b/spec/features/work_packages/display_fields/spent_time_display_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Logging time within the work package view', :js do
+RSpec.describe "Logging time within the work package view", :js do
shared_let(:project) { create(:project) }
shared_let(:admin) { create(:admin) }
shared_let(:work_package) { create(:work_package, project:) }
@@ -36,7 +36,7 @@
let(:user) { admin }
- let(:spent_time_field) { SpentTimeEditField.new(page, 'spentTime') }
+ let(:spent_time_field) { SpentTimeEditField.new(page, "spentTime") }
let(:wp_page) { Pages::FullWorkPackage.new(work_package, project) }
@@ -46,12 +46,12 @@ def log_time_via_modal(user_field_visible: true, log_for_user: nil, date: Time.z
time_logging_modal.is_visible true
# the fields are visible
- time_logging_modal.has_field_with_value 'spent_on', Time.zone.today.strftime("%Y-%m-%d")
- time_logging_modal.shows_field 'work_package', false
- time_logging_modal.shows_field 'user', user_field_visible
+ time_logging_modal.has_field_with_value "spent_on", Time.zone.today.strftime("%Y-%m-%d")
+ time_logging_modal.shows_field "work_package", false
+ time_logging_modal.shows_field "user", user_field_visible
# Update the fields
- time_logging_modal.update_field 'activity', activity.name
+ time_logging_modal.update_field "activity", activity.name
Components::BasicDatepicker.update_field(
"##{time_logging_modal.field_identifier('spent_on')}",
@@ -59,17 +59,17 @@ def log_time_via_modal(user_field_visible: true, log_for_user: nil, date: Time.z
)
if log_for_user
- time_logging_modal.update_field 'user', log_for_user.name
+ time_logging_modal.update_field "user", log_for_user.name
elsif user_field_visible
- expect(page).to have_css('.ng-value-label', text: user.name)
+ expect(page).to have_css(".ng-value-label", text: user.name)
end
# a click on save creates a time entry
time_logging_modal.perform_action I18n.t(:button_save)
- wp_page.expect_and_dismiss_toaster message: I18n.t('js.notice_successful_create')
+ wp_page.expect_and_dismiss_toaster message: I18n.t("js.notice_successful_create")
end
- context 'as an admin' do
+ context "as an admin" do
before do
login_as(user)
wp_page.visit!
@@ -77,7 +77,7 @@ def log_time_via_modal(user_field_visible: true, log_for_user: nil, date: Time.z
spent_time_field.time_log_icon_visible true
end
- it 'shows a logging button within the display field and can log time via a modal' do
+ it "shows a logging button within the display field and can log time via a modal" do
# click on button opens modal
spent_time_field.open_time_log_modal
expect do
@@ -85,7 +85,7 @@ def log_time_via_modal(user_field_visible: true, log_for_user: nil, date: Time.z
end.to change(TimeEntry, :count).by(1)
# the value is updated automatically
- spent_time_field.expect_display_value '1 h'
+ spent_time_field.expect_display_value "1 h"
TimeEntry.last.tap do |te|
expect(te.work_package).to eq(work_package)
@@ -97,22 +97,22 @@ def log_time_via_modal(user_field_visible: true, log_for_user: nil, date: Time.z
end
end
- context 'with another user in the project' do
+ context "with another user in the project" do
let!(:other_user) do
create(:user,
- firstname: 'Loggable',
- lastname: 'User',
+ firstname: "Loggable",
+ lastname: "User",
member_with_permissions: { project => %i[view_work_packages edit_work_packages work_package_assigned] })
end
- it 'can log time for that user' do
+ it "can log time for that user" do
# click on button opens modal
spent_time_field.open_time_log_modal
log_time_via_modal log_for_user: other_user
# the value is updated automatically
- spent_time_field.expect_display_value '1 h'
+ spent_time_field.expect_display_value "1 h"
time_entry = TimeEntry.last
expect(time_entry.user).to eq other_user
@@ -120,37 +120,37 @@ def log_time_via_modal(user_field_visible: true, log_for_user: nil, date: Time.z
end
end
- it 'the context menu entry to log time leads to the modal' do
+ it "the context menu entry to log time leads to the modal" do
# click on context menu opens the modal
- find('#action-show-more-dropdown-menu .button').click
- find('.menu-item', text: 'Log time').click
+ find("#action-show-more-dropdown-menu .button").click
+ find(".menu-item", text: "Log time").click
log_time_via_modal
# the value is updated automatically
- spent_time_field.expect_display_value '1 h'
+ spent_time_field.expect_display_value "1 h"
end
- context 'with a user with non-one unit numbers', with_settings: { available_languages: %w[en ja] } do
- let(:user) { create(:admin, language: 'ja') }
+ context "with a user with non-one unit numbers", with_settings: { available_languages: %w[en ja] } do
+ let(:user) { create(:admin, language: "ja") }
before do
- I18n.locale = 'ja'
+ I18n.locale = "ja"
end
- it 'shows the correct number (Regression #36269)' do
+ it "shows the correct number (Regression #36269)" do
# click on button opens modal
spent_time_field.open_time_log_modal
log_time_via_modal
# the value is updated automatically
- spent_time_field.expect_display_value '1 h'
+ spent_time_field.expect_display_value "1 h"
end
end
end
- context 'as a user who cannot log time' do
+ context "as a user who cannot log time" do
let(:user) do
create(:user,
member_with_permissions: { project => %i[view_time_entries view_work_packages edit_work_packages] })
@@ -162,13 +162,13 @@ def log_time_via_modal(user_field_visible: true, log_for_user: nil, date: Time.z
loading_indicator_saveguard
end
- it 'shows no logging button within the display field' do
+ it "shows no logging button within the display field" do
spent_time_field.time_log_icon_visible false
- spent_time_field.expect_display_value '0 h'
+ spent_time_field.expect_display_value "0 h"
end
end
- context 'as a user who can only log own time' do
+ context "as a user who can only log own time" do
let(:user) do
create(:user,
member_with_permissions: { project => %i[view_time_entries view_work_packages log_own_time] })
@@ -180,7 +180,7 @@ def log_time_via_modal(user_field_visible: true, log_for_user: nil, date: Time.z
loading_indicator_saveguard
end
- it 'can log its own time' do
+ it "can log its own time" do
spent_time_field.time_log_icon_visible true
# click on button opens modal
spent_time_field.open_time_log_modal
@@ -188,14 +188,14 @@ def log_time_via_modal(user_field_visible: true, log_for_user: nil, date: Time.z
log_time_via_modal user_field_visible: false
# the value is updated automatically
- spent_time_field.expect_display_value '1 h'
+ spent_time_field.expect_display_value "1 h"
end
end
- context 'when in the table' do
+ context "when in the table" do
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
let(:second_work_package) { create(:work_package, project:) }
- let(:query) { create(:public_query, project:, column_names: ['subject', 'spent_hours']) }
+ let(:query) { create(:public_query, project:, column_names: ["subject", "spent_hours"]) }
before do
work_package
@@ -206,15 +206,15 @@ def log_time_via_modal(user_field_visible: true, log_for_user: nil, date: Time.z
loading_indicator_saveguard
end
- it 'shows no logging button within the display field' do
+ it "shows no logging button within the display field" do
wp_table.expect_work_package_listed work_package, second_work_package
- find('tr:nth-of-type(1) .wp-table--cell-td.spentTime .icon-time').click
+ find("tr:nth-of-type(1) .wp-table--cell-td.spentTime .icon-time").click
log_time_via_modal
- expect(page).to have_css('tr:nth-of-type(1) .wp-table--cell-td.spentTime', text: '1 h')
- expect(page).to have_css('tr:nth-of-type(2) .wp-table--cell-td.spentTime', text: '0 h')
+ expect(page).to have_css("tr:nth-of-type(1) .wp-table--cell-td.spentTime", text: "1 h")
+ expect(page).to have_css("tr:nth-of-type(2) .wp-table--cell-td.spentTime", text: "0 h")
end
end
end
diff --git a/spec/features/work_packages/display_representations/switch_display_representations_on_mobile_spec.rb b/spec/features/work_packages/display_representations/switch_display_representations_on_mobile_spec.rb
index 12c5fd59a2fb..caf09abd1c88 100644
--- a/spec/features/work_packages/display_representations/switch_display_representations_on_mobile_spec.rb
+++ b/spec/features/work_packages/display_representations/switch_display_representations_on_mobile_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Switching work package view on mobile', :js do
+RSpec.describe "Switching work package view on mobile", :js do
let(:user) { create(:admin) }
let(:project) { create(:project) }
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
@@ -53,21 +53,21 @@
wp_table.expect_work_package_listed wp_1, wp_2
end
- context 'switching to mobile card view' do
- include_context 'with mobile screen size'
+ context "switching to mobile card view" do
+ include_context "with mobile screen size"
- it 'can switch the representation automatically on mobile after a refresh' do
+ it "can switch the representation automatically on mobile after a refresh" do
# It shows the elements as cards
cards.expect_work_package_listed wp_1, wp_2
# A single click leads to the full view
cards.select_work_package(wp_1)
- expect(page).to have_css('.work-packages--details--subject',
+ expect(page).to have_css(".work-packages--details--subject",
text: wp_1.subject)
- page.find('.work-packages-back-button').click
+ page.find(".work-packages-back-button").click
# The query is however unchanged
- expect(page).to have_no_css('.editable-toolbar-title--save')
+ expect(page).to have_no_css(".editable-toolbar-title--save")
url = URI.parse(page.current_url).query
expect(url).not_to match(/query_props=.+/)
diff --git a/spec/features/work_packages/edit_on_assign_version_permission_spec.rb b/spec/features/work_packages/edit_on_assign_version_permission_spec.rb
index a4937cd633dd..b02566b81d2b 100644
--- a/spec/features/work_packages/edit_on_assign_version_permission_spec.rb
+++ b/spec/features/work_packages/edit_on_assign_version_permission_spec.rb
@@ -1,17 +1,17 @@
-require 'spec_helper'
-require 'features/page_objects/notification'
+require "spec_helper"
+require "features/page_objects/notification"
-RSpec.describe 'edit work package', :js do
+RSpec.describe "edit work package", :js do
let(:current_user) do
create(:user,
- firstname: 'Dev',
- lastname: 'Guy',
+ firstname: "Dev",
+ lastname: "Guy",
member_with_permissions: { project => permissions })
end
let(:permissions) { %i[view_work_packages assign_versions] }
let(:cf_all) do
- create(:work_package_custom_field, is_for_all: true, field_format: 'text')
+ create(:work_package_custom_field, is_for_all: true, field_format: "text")
end
let(:type) { create(:type, custom_fields: [cf_all]) }
@@ -39,23 +39,23 @@ def visit!
visit!
end
- context 'as a user having only the assign_versions permission' do
- it 'can only change the version' do
+ context "as a user having only the assign_versions permission" do
+ it "can only change the version" do
wp_page.update_attributes version: version.name
- wp_page.expect_toast(message: 'Successful update')
+ wp_page.expect_toast(message: "Successful update")
wp_page.expect_attributes version: version.name
- subject_field = wp_page.work_package_field('subject')
+ subject_field = wp_page.work_package_field("subject")
subject_field.expect_read_only
end
end
- context 'as a user having only the edit_work_packages permission' do
+ context "as a user having only the edit_work_packages permission" do
let(:permissions) { %i[view_work_packages edit_work_packages] }
- it 'can not change the version' do
- version_field = wp_page.work_package_field('version')
+ it "can not change the version" do
+ version_field = wp_page.work_package_field("version")
version_field.expect_read_only
end
end
diff --git a/spec/features/work_packages/edit_on_change_work_package_status_permission_spec.rb b/spec/features/work_packages/edit_on_change_work_package_status_permission_spec.rb
index 194f8c9e6b04..cd0b86a91857 100644
--- a/spec/features/work_packages/edit_on_change_work_package_status_permission_spec.rb
+++ b/spec/features/work_packages/edit_on_change_work_package_status_permission_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/page_objects/notification'
+require "spec_helper"
+require "features/page_objects/notification"
-RSpec.describe 'edit work package', :js do
+RSpec.describe "edit work package", :js do
let(:current_user) do
create(:user,
- firstname: 'Dev',
- lastname: 'Guy',
+ firstname: "Dev",
+ lastname: "Guy",
member_with_roles: { project => role })
end
let(:permissions) { %i[view_work_packages change_work_package_status] }
@@ -41,8 +41,8 @@
let(:type) { create(:type) }
let(:project) { create(:project, types: [type]) }
- let(:status_new) { create(:status, name: 'New') }
- let(:status_done) { create(:status, name: 'Done') }
+ let(:status_new) { create(:status, name: "New") }
+ let(:status_done) { create(:status, name: "Done") }
let(:workflow) do
create(:workflow,
type_id: type.id,
@@ -69,29 +69,29 @@
wp_page.ensure_page_loaded
end
- context 'as a user having only the change_work_package_status permission' do
- it 'can only change the status' do
+ context "as a user having only the change_work_package_status permission" do
+ it "can only change the status" do
status_field = wp_page.edit_field :status
status_field.expect_state_text status_new.name
status_field.update status_done.name
- wp_page.expect_toast(message: 'Successful update')
+ wp_page.expect_toast(message: "Successful update")
status_field.expect_state_text status_done.name
- subject_field = wp_page.work_package_field('subject')
+ subject_field = wp_page.work_package_field("subject")
subject_field.expect_read_only
end
end
- context 'as a user having only the edit_work_packages permission' do
+ context "as a user having only the edit_work_packages permission" do
let(:permissions) { %i[view_work_packages edit_work_packages] }
- it 'can change the status' do
+ it "can change the status" do
status_field = wp_page.edit_field :status
status_field.expect_state_text status_new.name
status_field.update status_done.name
- wp_page.expect_toast(message: 'Successful update')
+ wp_page.expect_toast(message: "Successful update")
status_field.expect_state_text status_done.name
end
end
diff --git a/spec/features/work_packages/edit_work_package_spec.rb b/spec/features/work_packages/edit_work_package_spec.rb
index c8201d945a82..16b6d8fc2176 100644
--- a/spec/features/work_packages/edit_work_package_spec.rb
+++ b/spec/features/work_packages/edit_work_package_spec.rb
@@ -1,7 +1,7 @@
-require 'spec_helper'
-require 'features/page_objects/notification'
+require "spec_helper"
+require "features/page_objects/notification"
-RSpec.describe 'edit work package', :js do
+RSpec.describe "edit work package", :js do
let(:dev_role) do
create(:project_role,
permissions: %i[view_work_packages
@@ -9,8 +9,8 @@
end
let(:dev) do
create(:user,
- firstname: 'Dev',
- lastname: 'Guy',
+ firstname: "Dev",
+ lastname: "Guy",
member_with_roles: { project => dev_role })
end
let(:manager_role) do
@@ -21,8 +21,8 @@
end
let(:manager) do
create(:admin,
- firstname: 'Manager',
- lastname: 'Guy',
+ firstname: "Manager",
+ lastname: "Guy",
member_with_roles: { project => manager_role })
end
let(:placeholder_user) do
@@ -31,15 +31,15 @@
end
let(:cf_all) do
- create(:work_package_custom_field, is_for_all: true, field_format: 'text')
+ create(:work_package_custom_field, is_for_all: true, field_format: "text")
end
let(:cf_tp1) do
- create(:work_package_custom_field, is_for_all: true, field_format: 'text')
+ create(:work_package_custom_field, is_for_all: true, field_format: "text")
end
let(:cf_tp2) do
- create(:work_package_custom_field, is_for_all: true, field_format: 'text')
+ create(:work_package_custom_field, is_for_all: true, field_format: "text")
end
let(:type) { create(:type, custom_fields: [cf_all, cf_tp1]) }
@@ -55,7 +55,7 @@
end
let(:status) { work_package.status }
- let(:new_subject) { 'Some other subject' }
+ let(:new_subject) { "Some other subject" }
let(:wp_page) { Pages::FullWorkPackage.new(work_package) }
let(:priority2) { create(:priority) }
let(:status2) { create(:status) }
@@ -90,12 +90,12 @@ def visit!
end
end
- context 'as an admin without roles' do
+ context "as an admin without roles" do
let(:visit_before) { false }
let(:work_package) { create(:work_package, project:, type: type2) }
let(:admin) { create(:admin) }
- it 'can still use the manager role' do
+ it "can still use the manager role" do
# A role must still exist
workflow
login_as admin
@@ -108,7 +108,7 @@ def visit!
end
end
- context 'with progress' do
+ context "with progress" do
let(:visit_before) { false }
before do
@@ -116,36 +116,36 @@ def visit!
visit!
end
- it 'does not hide empty % Complete while it is being edited' do
+ it "does not hide empty % Complete while it is being edited" do
field = wp_page.work_package_field(:percentageDone)
- field.update('0', save: false, expect_failure: true)
+ field.update("0", save: false, expect_failure: true)
expect(page).to have_text("% Complete")
end
end
- it 'allows updating and seeing the results' do
- wp_page.update_attributes subject: 'a new subject',
+ it "allows updating and seeing the results" do
+ wp_page.update_attributes subject: "a new subject",
type: type2.name,
- combinedDate: ['2013-03-04', '2013-03-20'],
+ combinedDate: ["2013-03-04", "2013-03-20"],
responsible: manager.name,
assignee: manager.name,
- estimatedTime: '5',
+ estimatedTime: "5",
priority: priority2.name,
version: version.name,
category: category.name,
- percentageDone: '30',
+ percentageDone: "30",
status: status2.name,
- description: 'a new description'
+ description: "a new description"
wp_page.expect_attributes type: type2.name.upcase,
responsible: manager.name,
assignee: manager.name,
- combinedDate: '03/04/2013 - 03/20/2013',
- estimatedTime: '5',
- percentageDone: '30%',
- subject: 'a new subject',
- description: 'a new description',
+ combinedDate: "03/04/2013 - 03/20/2013",
+ estimatedTime: "5",
+ percentageDone: "30%",
+ subject: "a new subject",
+ description: "a new description",
priority: priority2.name,
status: status2.name,
version: version.name,
@@ -154,7 +154,7 @@ def visit!
wp_page.expect_activity_message("Status changed from #{status.name} to #{status2.name}")
end
- it 'correctly assigns and un-assigns users' do
+ it "correctly assigns and un-assigns users" do
wp_page.update_attributes assignee: manager.name
wp_page.expect_attributes assignee: manager.name
wp_page.expect_activity_message("Assignee set to #{manager.name}")
@@ -162,23 +162,23 @@ def visit!
field = wp_page.edit_field :assignee
field.unset_value
- wp_page.expect_attributes assignee: '-'
+ wp_page.expect_attributes assignee: "-"
wp_page.visit!
# Another (empty) journal should exist now
- expect(page).to have_css('.op-user-activity--user-name',
+ expect(page).to have_css(".op-user-activity--user-name",
text: work_package.journals.last.user.name,
wait: 10,
count: 2)
- wp_page.expect_attributes assignee: '-'
+ wp_page.expect_attributes assignee: "-"
work_package.reload
expect(work_package.assigned_to).to be_nil
end
- it 'allows selecting placeholder users for assignee and responsible' do
+ it "allows selecting placeholder users for assignee and responsible" do
wp_page.update_attributes assignee: placeholder_user.name,
responsible: placeholder_user.name
@@ -189,11 +189,11 @@ def visit!
wp_page.expect_activity_message("Accountable set to #{placeholder_user.name}")
end
- context 'switching to custom field with required CF' do
+ context "switching to custom field with required CF" do
let(:custom_field) do
create(
:work_package_custom_field,
- field_format: 'string',
+ field_format: "string",
default_value: nil,
is_required: true,
is_for_all: true
@@ -201,81 +201,81 @@ def visit!
end
let!(:type2) { create(:type, custom_fields: [custom_field]) }
- it 'shows the required field when switching' do
+ it "shows the required field when switching" do
type_field = wp_page.edit_field(:type)
type_field.activate!
type_field.set_value type2.name
wp_page.expect_toast message: "#{custom_field.name} can't be blank.",
- type: 'error'
+ type: "error"
cf_field = wp_page.edit_field(custom_field.attribute_name(:camel_case))
cf_field.expect_active!
- cf_field.expect_value('')
+ cf_field.expect_value("")
end
end
- it 'allows the user to add a comment to a work package' do
+ it "allows the user to add a comment to a work package" do
wp_page.ensure_page_loaded
wp_page.trigger_edit_comment
- wp_page.update_comment 'hallo welt'
+ wp_page.update_comment "hallo welt"
wp_page.save_comment
- wp_page.expect_toast(message: 'The comment was successfully added.')
- wp_page.expect_comment text: 'hallo welt'
+ wp_page.expect_toast(message: "The comment was successfully added.")
+ wp_page.expect_comment text: "hallo welt"
end
- it 'updates the presented custom fields based on the selected type' do
+ it "updates the presented custom fields based on the selected type" do
wp_page.ensure_page_loaded
- wp_page.expect_attributes "customField#{cf_all.id}" => '',
- "customField#{cf_tp1.id}" => ''
+ wp_page.expect_attributes "customField#{cf_all.id}" => "",
+ "customField#{cf_tp1.id}" => ""
wp_page.expect_attribute_hidden "customField#{cf_tp2.id}"
- wp_page.update_attributes "customField#{cf_all.id}" => 'bird is the word',
- 'type' => type2.name
+ wp_page.update_attributes "customField#{cf_all.id}" => "bird is the word",
+ "type" => type2.name
- wp_page.expect_attributes "customField#{cf_all.id}" => 'bird is the word',
- "customField#{cf_tp2.id}" => ''
+ wp_page.expect_attributes "customField#{cf_all.id}" => "bird is the word",
+ "customField#{cf_tp2.id}" => ""
wp_page.expect_attribute_hidden "customField#{cf_tp1.id}"
end
- it 'shows an error if a subject is entered which is too long' do
- too_long = ('Too long. Can you feel it? ' * 10).strip
+ it "shows an error if a subject is entered which is too long" do
+ too_long = ("Too long. Can you feel it? " * 10).strip
wp_page.ensure_page_loaded
field = wp_page.work_package_field(:subject)
field.update(too_long, expect_failure: true)
- wp_page.expect_toast message: 'Subject is too long (maximum is 255 characters)',
- type: 'error'
+ wp_page.expect_toast message: "Subject is too long (maximum is 255 characters)",
+ type: "error"
end
- context 'submitting' do
+ context "submitting" do
let(:subject_field) { wp_page.edit_field(:subject) }
before do
subject_field.activate!
- subject_field.set_value 'My new subject!'
+ subject_field.set_value "My new subject!"
end
- it 'submits the edit mode when pressing enter' do
+ it "submits the edit mode when pressing enter" do
subject_field.input_element.send_keys(:return)
- wp_page.expect_toast(message: 'Successful update')
+ wp_page.expect_toast(message: "Successful update")
subject_field.expect_inactive!
- subject_field.expect_state_text 'My new subject!'
+ subject_field.expect_state_text "My new subject!"
end
- it 'submits the edit mode when changing the focus' do
+ it "submits the edit mode when changing the focus" do
page.find("body").click
- wp_page.expect_toast(message: 'Successful update')
+ wp_page.expect_toast(message: "Successful update")
subject_field.expect_inactive!
- subject_field.expect_state_text 'My new subject!'
+ subject_field.expect_state_text "My new subject!"
end
end
end
diff --git a/spec/features/work_packages/export_spec.rb b/spec/features/work_packages/export_spec.rb
index 4bf509cebc78..4644baf1ff5b 100644
--- a/spec/features/work_packages/export_spec.rb
+++ b/spec/features/work_packages/export_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/work_packages/work_packages_page'
+require "spec_helper"
+require "features/work_packages/work_packages_page"
-RSpec.describe 'work package export' do
+RSpec.describe "work package export" do
let(:project) { create(:project_with_types, types: [type_a, type_b]) }
- let(:export_type) { 'CSV' }
+ let(:export_type) { "CSV" }
let(:current_user) { create(:admin) }
let(:type_a) { create(:type, name: "Type A") }
@@ -65,15 +65,15 @@
def export!(expect_success = true)
work_packages_page.ensure_loaded
- settings_menu.open_and_choose 'Export'
+ settings_menu.open_and_choose "Export"
click_on export_type
# Expect to get a response regarding queuing
- expect(page).to have_content I18n.t('js.job_status.generic_messages.in_queue'),
+ expect(page).to have_content I18n.t("js.job_status.generic_messages.in_queue"),
wait: 10
# Expect title
- expect(page).to have_test_selector 'job-status--header', text: I18n.t('export.your_work_packages_export')
+ expect(page).to have_test_selector "job-status--header", text: I18n.t("export.your_work_packages_export")
begin
perform_enqueued_jobs
@@ -90,15 +90,15 @@ def export!(expect_success = true)
DownloadList.clear
end
- context 'CSV export' do
- context 'with default filter' do
+ context "CSV export" do
+ context "with default filter" do
before do
work_packages_page.visit_index
filters.expect_filter_count 1
filters.open
end
- it 'shows all work packages with the default filters', :js do
+ it "shows all work packages with the default filters", :js do
export!
expect(subject).to have_text(wp1.description)
@@ -110,8 +110,8 @@ def export!(expect_success = true)
expect(subject.scan(/Type (A|B)/).flatten).to eq %w(A A B A)
end
- it 'shows all work packages grouped by', :js do
- group_by.enable_via_menu 'Type'
+ it "shows all work packages grouped by", :js do
+ group_by.enable_via_menu "Type"
wp_table.expect_work_package_listed(wp1)
wp_table.expect_work_package_listed(wp2)
@@ -129,8 +129,8 @@ def export!(expect_success = true)
expect(subject.scan(/Type (A|B)/).flatten).to eq %w(A A A B)
end
- it 'shows only the work package with the right progress if filtered this way', :js do
- filters.add_filter_by '% Complete', 'is', ['25'], 'percentageDone'
+ it "shows only the work package with the right progress if filtered this way", :js do
+ filters.add_filter_by "% Complete", "is", ["25"], "percentageDone"
sleep 1
loading_indicator_saveguard
@@ -145,8 +145,8 @@ def export!(expect_success = true)
expect(subject).to have_no_text(wp3.description)
end
- it 'shows only work packages of the filtered type', :js do
- filters.add_filter_by 'Type', 'is (OR)', wp3.type.name
+ it "shows only work packages of the filtered type", :js do
+ filters.add_filter_by "Type", "is (OR)", wp3.type.name
expect(page).to have_no_content(wp2.description) # safeguard
@@ -159,17 +159,17 @@ def export!(expect_success = true)
expect(subject).to have_text(wp3.description)
end
- it 'exports selected columns', :js do
- columns.add '% Complete'
+ it "exports selected columns", :js do
+ columns.add "% Complete"
export!
- expect(subject).to have_text('% Complete')
- expect(subject).to have_text('25')
+ expect(subject).to have_text("% Complete")
+ expect(subject).to have_text("25")
end
end
- describe 'with a manually sorted query', :js do
+ describe "with a manually sorted query", :js do
let(:query) do
create(:query,
user: current_user,
@@ -182,20 +182,20 @@ def export!(expect_success = true)
OrderedWorkPackage.create(query:, work_package: wp2, position: 2)
OrderedWorkPackage.create(query:, work_package: wp3, position: 3)
- query.add_filter('manual_sort', 'ow', [])
- query.sort_criteria = [[:manual_sorting, 'asc']]
+ query.add_filter("manual_sort", "ow", [])
+ query.sort_criteria = [[:manual_sorting, "asc"]]
query.save!
end
- it 'returns the correct number of work packages' do
+ it "returns the correct number of work packages" do
wp_table.visit_query query
wp_table.expect_work_package_listed(wp1, wp2, wp3, wp4)
wp_table.expect_work_package_order(wp4, wp1, wp2, wp3)
export!
- expect(page).to have_css('.job-status--modal .icon-checkmark', wait: 10)
- expect(page).to have_content('The export has completed successfully.')
+ expect(page).to have_css(".job-status--modal .icon-checkmark", wait: 10)
+ expect(page).to have_content("The export has completed successfully.")
expect(subject).to have_text(wp1.description)
expect(subject).to have_text(wp2.description)
@@ -208,17 +208,17 @@ def export!(expect_success = true)
end
end
- context 'PDF export', :js do
- let(:export_type) { I18n.t('export.format.pdf_overview_table') }
+ context "PDF export", :js do
+ let(:export_type) { I18n.t("export.format.pdf_overview_table") }
let(:query) do
create(:query,
user: current_user,
project:)
end
- context 'with many columns' do
+ context "with many columns" do
before do
- query.column_names = query.displayable_columns.map { |c| c.name.to_s } - ['bcf_thumbnail']
+ query.column_names = query.displayable_columns.map { |c| c.name.to_s } - ["bcf_thumbnail"]
query.save!
# Despite attempts to provoke the error by having a lot of columns, the pdf
@@ -228,7 +228,7 @@ def export!(expect_success = true)
.and_raise(I18n.t(:error_pdf_export_too_many_columns))
end
- it 'returns the error' do
+ it "returns the error" do
wp_table.visit_query query
export!(false)
@@ -241,18 +241,18 @@ def export!(expect_success = true)
# Atom exports are not downloaded. In fact, it is not even a download but rather
# a feed one can follow.
- context 'Atom export', :js do
- let(:export_type) { 'Atom' }
+ context "Atom export", :js do
+ let(:export_type) { "Atom" }
- context 'with default filter' do
+ context "with default filter" do
before do
work_packages_page.visit_index
filters.expect_filter_count 1
filters.open
end
- it 'shows an xml with work packages' do
- settings_menu.open_and_choose 'Export'
+ it "shows an xml with work packages" do
+ settings_menu.open_and_choose "Export"
# The feed is opened in a new tab
new_window = window_opened_by { click_on export_type }
diff --git a/spec/features/work_packages/highlighting_spec.rb b/spec/features/work_packages/highlighting_spec.rb
index 52702c1a539e..67c9af0644df 100644
--- a/spec/features/work_packages/highlighting_spec.rb
+++ b/spec/features/work_packages/highlighting_spec.rb
@@ -1,16 +1,16 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work Package highlighting fields', :js,
+RSpec.describe "Work Package highlighting fields", :js,
with_ee: %i[conditional_highlighting] do
let(:user) { create(:admin) }
let(:project) { create(:project) }
- let(:status1) { create(:status, color: create(:color, hexcode: '#FF0000')) } # rgba(255, 0, 0, 1)
- let(:status2) { create(:status, color: create(:color, hexcode: '#F0F0F0')) } # rgba(240, 240, 240, 1)
+ let(:status1) { create(:status, color: create(:color, hexcode: "#FF0000")) } # rgba(255, 0, 0, 1)
+ let(:status2) { create(:status, color: create(:color, hexcode: "#F0F0F0")) } # rgba(240, 240, 240, 1)
let(:priority1) do
- create(:issue_priority, color: create(:color, hexcode: '#123456'))
+ create(:issue_priority, color: create(:color, hexcode: "#123456"))
end
let(:priority_no_color) { create(:issue_priority, color: nil) }
@@ -18,7 +18,7 @@
create(:work_package,
project:,
status: status1,
- subject: 'B',
+ subject: "B",
due_date: (Date.today - 1.day),
priority: priority1)
end
@@ -27,7 +27,7 @@
create(:work_package,
project:,
status: status2,
- subject: 'A',
+ subject: "A",
due_date: Date.today,
priority: priority_no_color)
end
@@ -57,7 +57,7 @@
wp_table.expect_work_package_listed wp_1, wp_2
end
- it 'provides highlighting through css classes' do
+ it "provides highlighting through css classes" do
# Default inline highlight
wp1_row = wp_table.row(wp_1)
wp2_row = wp_table.row(wp_2)
@@ -65,26 +65,26 @@
## Status
expect(SelectorHelpers.get_pseudo_class_property(page,
wp1_row.find('[class^="__hl_inline_status_"]'),
- ':before',
- "background-color")).to eq('rgb(255, 0, 0)')
+ ":before",
+ "background-color")).to eq("rgb(255, 0, 0)")
expect(SelectorHelpers.get_pseudo_class_property(page,
wp2_row.find('[class^="__hl_inline_status_"]'),
- ':before',
- "background-color")).to eq('rgb(240, 240, 240)')
+ ":before",
+ "background-color")).to eq("rgb(240, 240, 240)")
## Priority
expect(SelectorHelpers.get_pseudo_class_property(page,
wp1_row.find('[class^="__hl_inline_priority_"]'),
- ':before',
- "background-color")).to eq('rgb(18, 52, 86)')
+ ":before",
+ "background-color")).to eq("rgb(18, 52, 86)")
expect(SelectorHelpers.get_pseudo_class_property(page,
wp2_row.find('[class^="__hl_inline_priority_"]'),
- ':before',
- "background-color")).to eq('rgba(0, 0, 0, 0)')
+ ":before",
+ "background-color")).to eq("rgba(0, 0, 0, 0)")
## Overdue
- expect(wp1_row).to have_css('.__hl_date_overdue')
- expect(wp2_row).to have_css('.__hl_date_due_today')
+ expect(wp1_row).to have_css(".__hl_date_overdue")
+ expect(wp2_row).to have_css(".__hl_date_due_today")
# Highlight only one attribute
highlighting.switch_inline_attribute_highlight "Priority"
@@ -95,12 +95,12 @@
## Priority should have a dot
expect(SelectorHelpers.get_pseudo_class_property(page,
wp1_row.find('[class^="__hl_inline_priority_"]'),
- ':before',
- "background-color")).to eq('rgb(18, 52, 86)')
+ ":before",
+ "background-color")).to eq("rgb(18, 52, 86)")
expect(SelectorHelpers.get_pseudo_class_property(page,
wp2_row.find('[class^="__hl_inline_priority_"]'),
- ':before',
- "background-color")).to eq('rgba(0, 0, 0, 0)')
+ ":before",
+ "background-color")).to eq("rgba(0, 0, 0, 0)")
## Status should not have a dot
expect(wp1_row).to have_no_css('.status [class^="__hl_inline_"]')
@@ -110,29 +110,29 @@
wp1_row = wp_table.row(wp_1)
expect(SelectorHelpers.get_pseudo_class_property(page,
wp1_row.find('[class^="__hl_inline_priority_"]'),
- ':before',
- "background-color")).to eq('rgb(18, 52, 86)')
+ ":before",
+ "background-color")).to eq("rgb(18, 52, 86)")
expect(SelectorHelpers.get_pseudo_class_property(page,
wp1_row.find('[class^="__hl_inline_status_"]'),
- ':before',
- "background-color")).to eq('rgb(255, 0, 0)')
+ ":before",
+ "background-color")).to eq("rgb(255, 0, 0)")
# Highlight entire row by status
- highlighting.switch_entire_row_highlight 'Status'
+ highlighting.switch_entire_row_highlight "Status"
expect(page).to have_css("#{wp_table.row_selector(wp_1)}.__hl_background_status_#{status1.id}")
expect(page).to have_css("#{wp_table.row_selector(wp_2)}.__hl_background_status_#{status2.id}")
# Unselect all rows to ensure we get the correct background
- find('body').send_keys [:control, 'd']
+ find("body").send_keys [:control, "d"]
wp1_row = wp_table.row(wp_1)
wp2_row = wp_table.row(wp_2)
- expect(wp1_row.native.css_value('background-color')).to eq('rgba(255, 0, 0, 1)')
- expect(wp2_row.native.css_value('background-color')).to eq('rgba(240, 240, 240, 1)')
+ expect(wp1_row.native.css_value("background-color")).to eq("rgba(255, 0, 0, 1)")
+ expect(wp2_row.native.css_value("background-color")).to eq("rgba(240, 240, 240, 1)")
# Save query
wp_table.save
- wp_table.expect_and_dismiss_toaster message: 'Successful update.'
+ wp_table.expect_and_dismiss_toaster message: "Successful update."
query.reload
expect(query.highlighting_mode).to eq(:status)
@@ -142,17 +142,17 @@
expect(page).to have_no_css('[class*="__hl_date"]')
# Highlight entire row by priority
- highlighting.switch_entire_row_highlight 'Priority'
+ highlighting.switch_entire_row_highlight "Priority"
expect(page).to have_css("#{wp_table.row_selector(wp_1)}.__hl_background_priority_#{priority1.id}")
expect(page).to have_css("#{wp_table.row_selector(wp_2)}.__hl_background_priority_#{priority_no_color.id}")
# Remove selection from table row
- find('body').send_keys [:control, 'd']
+ find("body").send_keys [:control, "d"]
wp1_row = wp_table.row(wp_1)
wp2_row = wp_table.row(wp_2)
- expect(wp1_row.native.css_value('background-color')).to eq('rgba(18, 52, 86, 1)')
- expect(wp2_row.native.css_value('background-color')).to eq('rgba(0, 0, 0, 0)')
+ expect(wp1_row.native.css_value("background-color")).to eq("rgba(18, 52, 86, 1)")
+ expect(wp2_row.native.css_value("background-color")).to eq("rgba(0, 0, 0, 0)")
# Highlighting is kept even after a hard reload (Regression #30217)
page.driver.refresh
@@ -164,7 +164,7 @@
# Save query
wp_table.save
- wp_table.expect_and_dismiss_toaster message: 'Successful update.'
+ wp_table.expect_and_dismiss_toaster message: "Successful update."
query.reload
expect(query.highlighting_mode).to eq(:priority)
@@ -174,7 +174,7 @@
expect(page).to have_no_css('[class*="__hl_date"]')
# No highlighting
- highlighting.switch_highlighting_mode 'No highlighting'
+ highlighting.switch_highlighting_mode "No highlighting"
expect(page).to have_no_css('[class*="__hl_background"]')
expect(page).to have_no_css('[class*="__hl_background_status"]')
expect(page).to have_no_css('[class*="__hl_background_priority"]')
@@ -182,7 +182,7 @@
# Save query
wp_table.save
- wp_table.expect_and_dismiss_toaster message: 'Successful update.'
+ wp_table.expect_and_dismiss_toaster message: "Successful update."
query.reload
expect(query.highlighting_mode).to eq(:none)
@@ -194,25 +194,25 @@
expect(page).to have_css(".__hl_inline_priority_#{priority1.id}")
end
- it 'correctly parses custom selected inline attributes', :with_cuprite do
+ it "correctly parses custom selected inline attributes", :with_cuprite do
# Highlight only one attribute
highlighting.switch_inline_attribute_highlight "Priority"
# Regression test, resort table
- sort_by.sort_via_header 'Subject'
+ sort_by.sort_via_header "Subject"
wp_table.expect_work_package_order wp_2, wp_1
# Regression test, resort table
- sort_by.sort_via_header 'Subject', descending: true
+ sort_by.sort_via_header "Subject", descending: true
wp_table.expect_work_package_order wp_1, wp_2
end
- it 'does not set query_props when switching in view (Regression #32118)' do
+ it "does not set query_props when switching in view (Regression #32118)" do
prio_wp1 = wp_table.edit_field(wp_1, :priority)
prio_wp1.update priority_no_color.name
prio_wp1.expect_state_text priority_no_color.name
- wp_table.expect_and_dismiss_toaster message: 'Successful update.'
+ wp_table.expect_and_dismiss_toaster message: "Successful update."
wp_1.reload
expect(wp_1.priority).to eq priority_no_color
diff --git a/spec/features/work_packages/index_sums_spec.rb b/spec/features/work_packages/index_sums_spec.rb
index ee9097e4027b..5c894d85da34 100644
--- a/spec/features/work_packages/index_sums_spec.rb
+++ b/spec/features/work_packages/index_sums_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package index sums', :js do
+RSpec.describe "Work package index sums", :js do
shared_let(:type_bug) { create(:type_bug) }
shared_let(:type_task) { create(:type_task) }
- shared_let(:status_new) { create(:status, name: 'New') }
- shared_let(:status_in_progress) { create(:status, name: 'In progress') }
+ shared_let(:status_new) { create(:status, name: "New") }
+ shared_let(:status_in_progress) { create(:status, name: "In progress") }
shared_let(:project) { create(:project, types: [type_bug, type_task]) }
let(:user) do
@@ -96,7 +96,7 @@
end
# unit costs
let(:cost_type) do
- type = create(:cost_type, name: 'Translations')
+ type = create(:cost_type, name: "Translations")
create(:cost_rate,
cost_type: type,
rate: 3.00)
@@ -119,24 +119,24 @@
current_user { user }
- it 'calculates sums correctly' do
+ it "calculates sums correctly" do
visit project_work_packages_path(project)
wp_table.expect_work_package_listed work_package1, work_package2
# Add work column
- columns.add 'Work'
+ columns.add "Work"
# Add remaining work column
- columns.add 'Remaining work'
+ columns.add "Remaining work"
# Add int cf column
columns.add int_cf.name
# Add float cf column
columns.add float_cf.name
# Add labor costs column
- columns.add 'Labor costs'
+ columns.add "Labor costs"
# Add unit costs column
- columns.add 'Unit costs'
+ columns.add "Unit costs"
# Add overall costs column
- columns.add 'Overall costs'
+ columns.add "Overall costs"
# Trigger action from action menu dropdown
modal.set_display_sums enable: true
@@ -145,79 +145,79 @@
# Expect the total sums row
within(:row, "Total sum") do |row|
- expect(row).to have_css('.estimatedTime', text: '25 h')
- expect(row).to have_css('.remainingTime', text: '12.5 h')
- expect(row).to have_css(".#{int_cf.attribute_name(:camel_case)}", text: '12')
- expect(row).to have_css(".#{float_cf.attribute_name(:camel_case)}", text: '13.2')
- expect(row).to have_css('.laborCosts', text: '15.00 EUR')
- expect(row).to have_css('.materialCosts', text: '7.50 EUR') # Unit costs
- expect(row).to have_css('.overallCosts', text: '22.50 EUR')
+ expect(row).to have_css(".estimatedTime", text: "25 h")
+ expect(row).to have_css(".remainingTime", text: "12.5 h")
+ expect(row).to have_css(".#{int_cf.attribute_name(:camel_case)}", text: "12")
+ expect(row).to have_css(".#{float_cf.attribute_name(:camel_case)}", text: "13.2")
+ expect(row).to have_css(".laborCosts", text: "15.00 EUR")
+ expect(row).to have_css(".materialCosts", text: "7.50 EUR") # Unit costs
+ expect(row).to have_css(".overallCosts", text: "22.50 EUR")
end
# Update the sum
wp_table.edit_field(work_package1, :estimatedTime)
- .update '20'
+ .update "20"
wp_table.edit_field(work_package1, :remainingTime)
- .update '12'
+ .update "12"
within(:row, "Total sum") do |row|
- expect(row).to have_css('.estimatedTime', text: '35 h')
- expect(row).to have_css('.remainingTime', text: '19.5 h')
- expect(row).to have_css(".#{int_cf.attribute_name(:camel_case)}", text: '12')
- expect(row).to have_css(".#{float_cf.attribute_name(:camel_case)}", text: '13.2')
- expect(row).to have_css('.laborCosts', text: '15.00 EUR')
- expect(row).to have_css('.materialCosts', text: '7.50 EUR') # Unit costs
- expect(row).to have_css('.overallCosts', text: '22.50 EUR')
+ expect(row).to have_css(".estimatedTime", text: "35 h")
+ expect(row).to have_css(".remainingTime", text: "19.5 h")
+ expect(row).to have_css(".#{int_cf.attribute_name(:camel_case)}", text: "12")
+ expect(row).to have_css(".#{float_cf.attribute_name(:camel_case)}", text: "13.2")
+ expect(row).to have_css(".laborCosts", text: "15.00 EUR")
+ expect(row).to have_css(".materialCosts", text: "7.50 EUR") # Unit costs
+ expect(row).to have_css(".overallCosts", text: "22.50 EUR")
end
# Enable groups
- group_by.enable_via_menu 'Status'
+ group_by.enable_via_menu "Status"
# Expect to have three sums rows now
- expect(page).to have_row('Sum', count: 2)
- expect(page).to have_row('Total sum', count: 1)
+ expect(page).to have_row("Sum", count: 2)
+ expect(page).to have_row("Total sum", count: 1)
- first_sum_row, second_sum_row = *find_all(:row, 'Sum')
+ first_sum_row, second_sum_row = *find_all(:row, "Sum")
# First status row
- expect(first_sum_row).to have_css('.estimatedTime', text: '20 h')
- expect(first_sum_row).to have_css('.remainingTime', text: '12 h')
- expect(first_sum_row).to have_css(".#{int_cf.attribute_name(:camel_case)}", text: '5')
- expect(first_sum_row).to have_css(".#{float_cf.attribute_name(:camel_case)}", text: '5.5')
- expect(first_sum_row).to have_css('.laborCosts', text: '15.00 EUR')
- expect(first_sum_row).to have_css('.materialCosts', text: '7.50 EUR') # Unit costs
- expect(first_sum_row).to have_css('.overallCosts', text: '22.50 EUR')
+ expect(first_sum_row).to have_css(".estimatedTime", text: "20 h")
+ expect(first_sum_row).to have_css(".remainingTime", text: "12 h")
+ expect(first_sum_row).to have_css(".#{int_cf.attribute_name(:camel_case)}", text: "5")
+ expect(first_sum_row).to have_css(".#{float_cf.attribute_name(:camel_case)}", text: "5.5")
+ expect(first_sum_row).to have_css(".laborCosts", text: "15.00 EUR")
+ expect(first_sum_row).to have_css(".materialCosts", text: "7.50 EUR") # Unit costs
+ expect(first_sum_row).to have_css(".overallCosts", text: "22.50 EUR")
# Second status row
- expect(second_sum_row).to have_css('.estimatedTime', text: '15 h')
- expect(second_sum_row).to have_css('.remainingTime', text: '7.5 h')
- expect(second_sum_row).to have_css(".#{int_cf.attribute_name(:camel_case)}", text: '7')
- expect(second_sum_row).to have_css(".#{float_cf.attribute_name(:camel_case)}", text: '7.7')
- expect(second_sum_row).to have_css('.laborCosts', text: '', exact_text: true)
- expect(second_sum_row).to have_css('.materialCosts', text: '', exact_text: true) # Unit costs
- expect(second_sum_row).to have_css('.overallCosts', text: '', exact_text: true)
+ expect(second_sum_row).to have_css(".estimatedTime", text: "15 h")
+ expect(second_sum_row).to have_css(".remainingTime", text: "7.5 h")
+ expect(second_sum_row).to have_css(".#{int_cf.attribute_name(:camel_case)}", text: "7")
+ expect(second_sum_row).to have_css(".#{float_cf.attribute_name(:camel_case)}", text: "7.7")
+ expect(second_sum_row).to have_css(".laborCosts", text: "", exact_text: true)
+ expect(second_sum_row).to have_css(".materialCosts", text: "", exact_text: true) # Unit costs
+ expect(second_sum_row).to have_css(".overallCosts", text: "", exact_text: true)
# Total sums row is unchanged
within(:row, "Total sum") do |row|
- expect(row).to have_css('.estimatedTime', text: '35 h')
- expect(row).to have_css('.remainingTime', text: '19.5 h')
- expect(row).to have_css(".#{int_cf.attribute_name(:camel_case)}", text: '12')
- expect(row).to have_css(".#{float_cf.attribute_name(:camel_case)}", text: '13.2')
- expect(row).to have_css('.laborCosts', text: '15.00 EUR')
- expect(row).to have_css('.materialCosts', text: '7.50 EUR') # Unit costs
- expect(row).to have_css('.overallCosts', text: '22.50 EUR')
+ expect(row).to have_css(".estimatedTime", text: "35 h")
+ expect(row).to have_css(".remainingTime", text: "19.5 h")
+ expect(row).to have_css(".#{int_cf.attribute_name(:camel_case)}", text: "12")
+ expect(row).to have_css(".#{float_cf.attribute_name(:camel_case)}", text: "13.2")
+ expect(row).to have_css(".laborCosts", text: "15.00 EUR")
+ expect(row).to have_css(".materialCosts", text: "7.50 EUR") # Unit costs
+ expect(row).to have_css(".overallCosts", text: "22.50 EUR")
end
# Collapsing groups will also hide the sums row
- page.find('.expander.icon-minus2', match: :first).click
+ page.find(".expander.icon-minus2", match: :first).click
sleep 1
- page.find('.expander.icon-minus2', match: :first).click
+ page.find(".expander.icon-minus2", match: :first).click
# Expect to have only the final sums
- expect(page).not_to have_row('Sum')
- expect(page).to have_row('Total sum')
+ expect(page).not_to have_row("Sum")
+ expect(page).to have_row("Total sum")
end
- context 'when filtering' do
+ context "when filtering" do
let!(:work_package3) do
create(:work_package,
project:,
@@ -258,7 +258,7 @@
user:)
end
- it 'calculates sums correctly' do
+ it "calculates sums correctly" do
query = create(:query,
project:,
user:,
@@ -271,74 +271,74 @@
# Expect the total sums row without filtering
within(:row, "Total sum") do |row|
- expect(row).to have_css('.estimatedTime', text: '50 h')
- expect(row).to have_css('.remainingTime', text: '25 h')
- expect(row).to have_css(".#{int_cf.attribute_name(:camel_case)}", text: '24')
- expect(row).to have_css(".#{float_cf.attribute_name(:camel_case)}", text: '26.4')
- expect(row).to have_css('.laborCosts', text: '40.00 EUR')
- expect(row).to have_css('.materialCosts', text: '18.00 EUR') # Unit costs
- expect(row).to have_css('.overallCosts', text: '58.00 EUR')
+ expect(row).to have_css(".estimatedTime", text: "50 h")
+ expect(row).to have_css(".remainingTime", text: "25 h")
+ expect(row).to have_css(".#{int_cf.attribute_name(:camel_case)}", text: "24")
+ expect(row).to have_css(".#{float_cf.attribute_name(:camel_case)}", text: "26.4")
+ expect(row).to have_css(".laborCosts", text: "40.00 EUR")
+ expect(row).to have_css(".materialCosts", text: "18.00 EUR") # Unit costs
+ expect(row).to have_css(".overallCosts", text: "58.00 EUR")
end
# Filter
filters.open
- filters.add_filter_by('Type', 'is (OR)', type_task.name)
+ filters.add_filter_by("Type", "is (OR)", type_task.name)
puts Capybara::Screenshot.screenshot_and_save_page
# Expect 2 work packages shown
- expect(page).to have_row('WorkPackage', count: 2) # works because the subject name includes "WorkPackage"
+ expect(page).to have_row("WorkPackage", count: 2) # works because the subject name includes "WorkPackage"
# Expect the total sums row to have changed
within(:row, "Total sum") do |row|
- expect(row).to have_css('.estimatedTime', text: '30 h')
- expect(row).to have_css('.remainingTime', text: '15 h')
- expect(row).to have_css(".#{int_cf.attribute_name(:camel_case)}", text: '14')
- expect(row).to have_css(".#{float_cf.attribute_name(:camel_case)}", text: '15.4')
- expect(row).to have_css('.laborCosts', text: '', exact_text: true)
- expect(row).to have_css('.materialCosts', text: '', exact_text: true) # Unit costs
- expect(row).to have_css('.overallCosts', text: '', exact_text: true)
+ expect(row).to have_css(".estimatedTime", text: "30 h")
+ expect(row).to have_css(".remainingTime", text: "15 h")
+ expect(row).to have_css(".#{int_cf.attribute_name(:camel_case)}", text: "14")
+ expect(row).to have_css(".#{float_cf.attribute_name(:camel_case)}", text: "15.4")
+ expect(row).to have_css(".laborCosts", text: "", exact_text: true)
+ expect(row).to have_css(".materialCosts", text: "", exact_text: true) # Unit costs
+ expect(row).to have_css(".overallCosts", text: "", exact_text: true)
end
# Filter by status open
- filters.remove_filter('type')
- filters.remove_filter('status')
- filters.add_filter_by('Status', 'is (OR)', status_new.name)
+ filters.remove_filter("type")
+ filters.remove_filter("status")
+ filters.add_filter_by("Status", "is (OR)", status_new.name)
# Enable groups by type
- group_by.enable_via_menu 'Type'
+ group_by.enable_via_menu "Type"
# Expect to have three sums rows now
- expect(page).to have_row('Sum', count: 2)
- expect(page).to have_row('Total sum', count: 1)
+ expect(page).to have_row("Sum", count: 2)
+ expect(page).to have_row("Total sum", count: 1)
- first_sum_row, second_sum_row = *find_all(:row, 'Sum')
+ first_sum_row, second_sum_row = *find_all(:row, "Sum")
# First status row
- expect(first_sum_row).to have_css('.estimatedTime', text: '10 h')
- expect(first_sum_row).to have_css('.remainingTime', text: '5 h')
- expect(first_sum_row).to have_css(".#{int_cf.attribute_name(:camel_case)}", text: '5')
- expect(first_sum_row).to have_css(".#{float_cf.attribute_name(:camel_case)}", text: '5.5')
- expect(first_sum_row).to have_css('.laborCosts', text: '15.00 EUR')
- expect(first_sum_row).to have_css('.materialCosts', text: '7.50 EUR') # Unit costs
- expect(first_sum_row).to have_css('.overallCosts', text: '22.50 EUR')
+ expect(first_sum_row).to have_css(".estimatedTime", text: "10 h")
+ expect(first_sum_row).to have_css(".remainingTime", text: "5 h")
+ expect(first_sum_row).to have_css(".#{int_cf.attribute_name(:camel_case)}", text: "5")
+ expect(first_sum_row).to have_css(".#{float_cf.attribute_name(:camel_case)}", text: "5.5")
+ expect(first_sum_row).to have_css(".laborCosts", text: "15.00 EUR")
+ expect(first_sum_row).to have_css(".materialCosts", text: "7.50 EUR") # Unit costs
+ expect(first_sum_row).to have_css(".overallCosts", text: "22.50 EUR")
# Second status row
- expect(second_sum_row).to have_css('.estimatedTime', text: '15 h')
- expect(second_sum_row).to have_css('.remainingTime', text: '7.5 h')
- expect(second_sum_row).to have_css(".#{int_cf.attribute_name(:camel_case)}", text: '7')
- expect(second_sum_row).to have_css(".#{float_cf.attribute_name(:camel_case)}", text: '7.7')
- expect(second_sum_row).to have_css('.laborCosts', text: '', exact_text: true)
- expect(second_sum_row).to have_css('.materialCosts', text: '', exact_text: true) # Unit costs
- expect(second_sum_row).to have_css('.overallCosts', text: '', exact_text: true)
+ expect(second_sum_row).to have_css(".estimatedTime", text: "15 h")
+ expect(second_sum_row).to have_css(".remainingTime", text: "7.5 h")
+ expect(second_sum_row).to have_css(".#{int_cf.attribute_name(:camel_case)}", text: "7")
+ expect(second_sum_row).to have_css(".#{float_cf.attribute_name(:camel_case)}", text: "7.7")
+ expect(second_sum_row).to have_css(".laborCosts", text: "", exact_text: true)
+ expect(second_sum_row).to have_css(".materialCosts", text: "", exact_text: true) # Unit costs
+ expect(second_sum_row).to have_css(".overallCosts", text: "", exact_text: true)
# Total sum
within(:row, "Total sum") do |row|
- expect(row).to have_css('.estimatedTime', text: '25 h')
- expect(row).to have_css('.remainingTime', text: '12.5 h')
- expect(row).to have_css(".#{int_cf.attribute_name(:camel_case)}", text: '12')
- expect(row).to have_css(".#{float_cf.attribute_name(:camel_case)}", text: '13.2')
- expect(row).to have_css('.laborCosts', text: '15.00 EUR')
- expect(row).to have_css('.materialCosts', text: '7.50 EUR') # Unit costs
- expect(row).to have_css('.overallCosts', text: '22.50 EUR')
+ expect(row).to have_css(".estimatedTime", text: "25 h")
+ expect(row).to have_css(".remainingTime", text: "12.5 h")
+ expect(row).to have_css(".#{int_cf.attribute_name(:camel_case)}", text: "12")
+ expect(row).to have_css(".#{float_cf.attribute_name(:camel_case)}", text: "13.2")
+ expect(row).to have_css(".laborCosts", text: "15.00 EUR")
+ expect(row).to have_css(".materialCosts", text: "7.50 EUR") # Unit costs
+ expect(row).to have_css(".overallCosts", text: "22.50 EUR")
end
end
end
diff --git a/spec/features/work_packages/navigation_spec.rb b/spec/features/work_packages/navigation_spec.rb
index a5d04cc97547..059d7e3cae51 100644
--- a/spec/features/work_packages/navigation_spec.rb
+++ b/spec/features/work_packages/navigation_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package navigation', :js, :selenium do
+RSpec.describe "Work package navigation", :js, :selenium do
let(:user) { create(:admin) }
- let(:project) { create(:project, name: 'Some project', enabled_module_names: [:work_package_tracking]) }
+ let(:project) { create(:project, name: "Some project", enabled_module_names: [:work_package_tracking]) }
let(:work_package) { build(:work_package, project:) }
let(:global_html_title) { Components::HtmlTitle.new }
let(:project_html_title) { Components::HtmlTitle.new project }
@@ -54,7 +54,7 @@
login_as(user)
end
- it 'all different angular based work package views' do
+ it "all different angular based work package views" do
work_package.save!
# deep link global work package index
@@ -62,7 +62,7 @@
global_work_packages.visit!
global_work_packages.expect_work_package_listed(work_package)
- global_html_title.expect_first_segment 'All open'
+ global_html_title.expect_first_segment "All open"
# open details pane for work package
@@ -97,17 +97,17 @@
project_work_packages.visit!
project_work_packages.expect_work_package_listed(work_package)
- project_html_title.expect_first_segment 'All open'
+ project_html_title.expect_first_segment "All open"
# Visit query with project wp
project_work_packages.visit_query query
project_work_packages.expect_work_package_listed(work_package)
- project_html_title.expect_first_segment 'My fancy query'
+ project_html_title.expect_first_segment "My fancy query"
# Go back to work packages without query
- page.execute_script('window.history.back()')
+ page.execute_script("window.history.back()")
project_work_packages.expect_work_package_listed(work_package)
- project_html_title.expect_first_segment 'All open'
+ project_html_title.expect_first_segment "All open"
# open project work package details pane
@@ -121,12 +121,12 @@
full_work_package = split_project_work_package.switch_to_fullscreen
full_work_package.expect_subject
- expect(page).to have_current_path project_work_package_path(project, work_package, 'activity')
+ expect(page).to have_current_path project_work_package_path(project, work_package, "activity")
project_html_title.expect_first_segment wp_title_segment
# Switch tabs
full_work_package.switch_to_tab tab: :relations
- expect(page).to have_current_path project_work_package_path(project, work_package, 'relations')
+ expect(page).to have_current_path project_work_package_path(project, work_package, "relations")
project_html_title.expect_first_segment wp_title_segment
# Back to split screen using the button
@@ -145,66 +145,66 @@
full_work_package.ensure_page_loaded
end
- it 'loading an unknown work package ID' do
- visit '/work_packages/999999999'
+ it "loading an unknown work package ID" do
+ visit "/work_packages/999999999"
page404 = Pages::Page.new
page404.expect_toast type: :error, message: I18n.t(:notice_file_not_found)
visit "/projects/#{project.identifier}/work_packages/999999999"
- page404.expect_and_dismiss_toaster type: :error, message: I18n.t('api_v3.errors.not_found.work_package')
+ page404.expect_and_dismiss_toaster type: :error, message: I18n.t("api_v3.errors.not_found.work_package")
end
# Regression #29994
- it 'access the work package views directly from a non-angular view' do
+ it "access the work package views directly from a non-angular view" do
visit project_path(project)
- find('#main-menu-work-packages ~ .toggler').click
- expect(page).to have_css('.op-view-select--search-results')
- find('.op-sidemenu--item-action', text: query.name).click
+ find("#main-menu-work-packages ~ .toggler").click
+ expect(page).to have_css(".op-view-select--search-results")
+ find(".op-sidemenu--item-action", text: query.name).click
- expect(page).to have_no_css('.title-container', text: 'Overview')
- expect(page).to have_field('editable-toolbar-title', with: query.name)
+ expect(page).to have_no_css(".title-container", text: "Overview")
+ expect(page).to have_field("editable-toolbar-title", with: query.name)
end
- it 'double clicking search result row (Regression #30247)' do
- work_package.subject = 'Foobar'
+ it "double clicking search result row (Regression #30247)" do
+ work_package.subject = "Foobar"
work_package.save!
- visit search_path(q: 'Foo', work_packages: 1, scope: :all)
+ visit search_path(q: "Foo", work_packages: 1, scope: :all)
- table = Pages::EmbeddedWorkPackagesTable.new page.find_by_id('content')
+ table = Pages::EmbeddedWorkPackagesTable.new page.find_by_id("content")
table.expect_work_package_listed work_package
full_page = table.open_full_screen_by_doubleclick work_package
full_page.ensure_page_loaded
end
- it 'double clicking my page (Regression #30343)' do
+ it "double clicking my page (Regression #30343)" do
work_package.author = user
- work_package.subject = 'Foobar'
+ work_package.subject = "Foobar"
work_package.save!
visit my_page_path
- page.find('.wp-table--cell-td.id a', text: work_package.id).click
+ page.find(".wp-table--cell-td.id a", text: work_package.id).click
full_page = Pages::FullWorkPackage.new work_package, work_package.project
full_page.ensure_page_loaded
end
- describe 'moving back to filtered list after change' do
- let!(:work_package) { create(:work_package, project:, subject: 'foo') }
+ describe "moving back to filtered list after change" do
+ let!(:work_package) { create(:work_package, project:, subject: "foo") }
let!(:query) do
query = build(:query, user:, project:)
query.column_names = %w(id subject)
query.name = "My fancy query"
- query.add_filter('subject', '~', ['foo'])
+ query.add_filter("subject", "~", ["foo"])
query.save!
query
end
- it 'filters out the work package' do
+ it "filters out the work package" do
wp_table = Pages::WorkPackagesTable.new project
wp_table.visit!
@@ -213,9 +213,9 @@
full_view.ensure_page_loaded
subject = full_view.edit_field :subject
- subject.update 'bar'
+ subject.update "bar"
- full_view.expect_and_dismiss_toaster message: 'Successful update.'
+ full_view.expect_and_dismiss_toaster message: "Successful update."
# Go back to list
full_view.go_back
@@ -224,13 +224,13 @@
end
end
- context 'with work package with an attachment' do
- let!(:attachment) { build(:attachment, filename: 'attachment-first.pdf') }
+ context "with work package with an attachment" do
+ let!(:attachment) { build(:attachment, filename: "attachment-first.pdf") }
let!(:wp_with_attachment) do
- create(:work_package, subject: 'WP attachment A', project:, attachments: [attachment])
+ create(:work_package, subject: "WP attachment A", project:, attachments: [attachment])
end
- it 'shows it when navigating from table to single view' do
+ it "shows it when navigating from table to single view" do
wp_table = Pages::WorkPackagesTable.new project
wp_table.visit!
@@ -238,16 +238,16 @@
full_view = wp_table.open_full_screen_by_link wp_with_attachment
full_view.ensure_page_loaded
- full_view.switch_to_tab(tab: 'FILES')
+ full_view.switch_to_tab(tab: "FILES")
expect(page)
- .to have_test_selector('op-files-tab--file-list-item-title', text: 'attachment-first.pdf', wait: 10)
+ .to have_test_selector("op-files-tab--file-list-item-title", text: "attachment-first.pdf", wait: 10)
end
end
- context 'when visiting a query that will lead to a query validation error' do
+ context "when visiting a query that will lead to a query validation error" do
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
- it 'outputs a correct error message (Regression #39880)' do
+ it "outputs a correct error message (Regression #39880)" do
url_query =
"query_id=%7B%22%7B%22&query_props=%7B%22c%22%3A%5B%22id%22%2C%22subject" \
"%22%2C%22type%22%2C%22status%22%2C%22assignee%22%2C%22updatedAt%22%5D%2C" \
@@ -258,8 +258,8 @@
visit "/projects/#{project.identifier}/work_packages?#{url_query}"
- wp_table.expect_toast message: 'Your view is erroneous and could not be processed.', type: :error
- expect(page).to have_css 'li', text: 'Bad request: id is invalid'
+ wp_table.expect_toast message: "Your view is erroneous and could not be processed.", type: :error
+ expect(page).to have_css "li", text: "Bad request: id is invalid"
end
end
end
diff --git a/spec/features/work_packages/new/attributes_from_filter_spec.rb b/spec/features/work_packages/new/attributes_from_filter_spec.rb
index cb5de138a92a..b4b11875d198 100644
--- a/spec/features/work_packages/new/attributes_from_filter_spec.rb
+++ b/spec/features/work_packages/new/attributes_from_filter_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package create uses attributes from filters', :js, :selenium do
+RSpec.describe "Work package create uses attributes from filters", :js, :selenium do
let(:user) { create(:admin) }
let(:type_bug) { create(:type_bug) }
let(:type_task) { create(:type_task) }
@@ -50,13 +50,13 @@
query.add_filter(*filter)
end
- query.column_names = ['id', 'subject', 'type', 'assigned_to', 'status']
+ query.column_names = ["id", "subject", "type", "assigned_to", "status"]
query.save!
end
end
let(:filters) do
- [['type_id', '=', [type_task.id]]]
+ [["type_id", "=", [type_task.id]]]
end
before do
@@ -65,7 +65,7 @@
wp_table.expect_no_work_package_listed
end
- context 'with a multi-value custom field' do
+ context "with a multi-value custom field" do
let(:type_task) { create(:type_task, custom_fields: [custom_field]) }
let!(:project) do
create(:project,
@@ -86,42 +86,42 @@
end
let(:filters) do
- [['type_id', '=', [type_task.id]],
- [custom_field.column_name, '=', [custom_field.custom_options.detect { |o| o.value == 'A' }.id]]]
+ [["type_id", "=", [type_task.id]],
+ [custom_field.column_name, "=", [custom_field.custom_options.detect { |o| o.value == "A" }.id]]]
end
- it 'allows to save with a single value (Regression test #27833)' do
+ it "allows to save with a single value (Regression test #27833)" do
split_page = wp_table.create_wp_by_button type_task
subject = split_page.edit_field(:subject)
subject.expect_active!
- subject.set_value 'Foobar!'
+ subject.set_value "Foobar!"
split_page.save!
wp_table.expect_and_dismiss_toaster(
- message: 'Successful creation. Click here to open this work package in fullscreen view.'
+ message: "Successful creation. Click here to open this work package in fullscreen view."
)
wp = WorkPackage.last
- expect(wp.subject).to eq 'Foobar!'
+ expect(wp.subject).to eq "Foobar!"
expect(wp.send(custom_field.attribute_getter)).to eq %w(A)
expect(wp.type_id).to eq type_task.id
end
end
- context 'with assignee filter' do
+ context "with assignee filter" do
let!(:assignee) do
create(:user,
- firstname: 'An',
- lastname: 'assignee',
+ firstname: "An",
+ lastname: "assignee",
member_with_roles: { project => role })
end
let(:filters) do
- [['type_id', '=', [type_task.id]],
- ['assigned_to_id', '=', [assignee.id]]]
+ [["type_id", "=", [type_task.id]],
+ ["assigned_to_id", "=", [assignee.id]]]
end
- it 'uses the assignee filter in inline-create and split view' do
+ it "uses the assignee filter in inline-create and split view" do
wp_table.click_inline_create
subject_field = wp_table.edit_field(nil, :subject)
@@ -136,16 +136,16 @@
assignee_field.expect_state_text type_task.name.upcase
# Save the WP
- subject_field.set_value 'Foobar!'
+ subject_field.set_value "Foobar!"
subject_field.submit_by_enter
wp_table.expect_toast(
- message: 'Successful creation. Click here to open this work package in fullscreen view.'
+ message: "Successful creation. Click here to open this work package in fullscreen view."
)
wp_table.dismiss_toaster!
wp = WorkPackage.last
- expect(wp.subject).to eq 'Foobar!'
+ expect(wp.subject).to eq "Foobar!"
expect(wp.assigned_to_id).to eq assignee.id
expect(wp.type_id).to eq type_task.id
@@ -155,7 +155,7 @@
# Subject
subject_field = split_view_create.edit_field :subject
subject_field.expect_active!
- subject_field.set_value 'Split Foobar!'
+ subject_field.set_value "Split Foobar!"
# Type field IS NOT synced
type_field = split_view_create.edit_field :type
@@ -163,28 +163,28 @@
# Assignee is synced
assignee_field = split_view_create.edit_field :assignee
- expect(assignee_field.input_element.find('.ng-value-label').text).to eql('An assignee')
+ expect(assignee_field.input_element.find(".ng-value-label").text).to eql("An assignee")
- within '.work-packages--edit-actions' do
- click_button 'Save'
+ within ".work-packages--edit-actions" do
+ click_button "Save"
end
- wp_table.expect_toast(message: 'Successful creation.')
+ wp_table.expect_toast(message: "Successful creation.")
wp = WorkPackage.last
- expect(wp.subject).to eq 'Split Foobar!'
+ expect(wp.subject).to eq "Split Foobar!"
expect(wp.assigned_to_id).to eq assignee.id
expect(wp.type_id).to eq type_bug.id
end
end
- context 'with status filter' do
+ context "with status filter" do
let(:closed_status) { create(:closed_status, workflow_for_type: type_bug) }
let(:filters) do
- [['status_id', '=', [closed_status.id]]]
+ [["status_id", "=", [closed_status.id]]]
end
- it 'uses the status filter in inline-create and split view' do
+ it "uses the status filter in inline-create and split view" do
# When the chosen type ( type_task ) does not have a workflow for the status (closed_status)
# of the filter, it uses the default status instead (Regression #36719)
wp_table.click_inline_create
@@ -199,16 +199,16 @@
# Save the WP
subject_field = wp_table.edit_field(nil, :subject)
- subject_field.set_value 'Foobar!'
+ subject_field.set_value "Foobar!"
subject_field.submit_by_enter
wp_table.expect_toast(
- message: 'Successful creation. Click here to open this work package in fullscreen view.'
+ message: "Successful creation. Click here to open this work package in fullscreen view."
)
wp_table.dismiss_toaster!
wp = WorkPackage.last
- expect(wp.subject).to eq 'Foobar!'
+ expect(wp.subject).to eq "Foobar!"
expect(wp.type_id).to eq type_task.id
expect(wp.status_id).to eq default_status.id
@@ -220,7 +220,7 @@
subject_field = split_view_create.edit_field :subject
subject_field.expect_active!
- subject_field.set_value 'Split Foobar!'
+ subject_field.set_value "Split Foobar!"
# Type field IS NOT synced
type_field = split_view_create.edit_field :type
@@ -230,14 +230,14 @@
status_field = split_view_create.edit_field :status
status_field.expect_display_value(closed_status.name.humanize)
- within '.work-packages--edit-actions' do
- click_button 'Save'
+ within ".work-packages--edit-actions" do
+ click_button "Save"
end
- wp_table.expect_toast(message: 'Successful creation.')
+ wp_table.expect_toast(message: "Successful creation.")
wp = WorkPackage.last
- expect(wp.subject).to eq 'Split Foobar!'
+ expect(wp.subject).to eq "Split Foobar!"
expect(wp.type_id).to eq type_bug.id
expect(wp.status_id).to eq closed_status.id
@@ -251,7 +251,7 @@
subject_field = split_view_create.edit_field :subject
subject_field.expect_active!
- subject_field.set_value 'Split Foobar!'
+ subject_field.set_value "Split Foobar!"
# Type field IS NOT synced
type_field = split_view_create.edit_field :type
@@ -261,14 +261,14 @@
status_field = split_view_create.edit_field :status
status_field.expect_display_value(default_status.name.humanize)
- within '.work-packages--edit-actions' do
- click_button 'Save'
+ within ".work-packages--edit-actions" do
+ click_button "Save"
end
- wp_table.expect_toast(message: 'Successful creation.')
+ wp_table.expect_toast(message: "Successful creation.")
wp = WorkPackage.last
- expect(wp.subject).to eq 'Split Foobar!'
+ expect(wp.subject).to eq "Split Foobar!"
expect(wp.type_id).to eq type_task.id
expect(wp.status_id).to eq default_status.id
end
diff --git a/spec/features/work_packages/new/new_work_package_datepicker_spec.rb b/spec/features/work_packages/new/new_work_package_datepicker_spec.rb
index 023798ee13da..7cabade98d1f 100644
--- a/spec/features/work_packages/new/new_work_package_datepicker_spec.rb
+++ b/spec/features/work_packages/new/new_work_package_datepicker_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/page_objects/notification'
-require 'features/work_packages/details/inplace_editor/shared_examples'
-require 'features/work_packages/shared_contexts'
-require 'support/edit_fields/edit_field'
-require 'features/work_packages/work_packages_page'
+require "spec_helper"
+require "features/page_objects/notification"
+require "features/work_packages/details/inplace_editor/shared_examples"
+require "features/work_packages/shared_contexts"
+require "support/edit_fields/edit_field"
+require "features/work_packages/work_packages_page"
-RSpec.describe 'New work package datepicker',
- :js, :with_cuprite, with_settings: { date_format: '%Y-%m-%d' } do
+RSpec.describe "New work package datepicker",
+ :js, :with_cuprite, with_settings: { date_format: "%Y-%m-%d" } do
let(:project) { create(:project_with_types, public: true) }
let(:user) { create(:admin) }
@@ -48,7 +48,7 @@
wait_for_reload
end
- it 'can open and select the datepicker' do
+ it "can open and select the datepicker" do
date_field.input_element.click
date_field.toggle_ignore_non_working_days
diff --git a/spec/features/work_packages/new/new_work_package_spec.rb b/spec/features/work_packages/new/new_work_package_spec.rb
index 2f705a3c2b25..f3cb6eda8511 100644
--- a/spec/features/work_packages/new/new_work_package_spec.rb
+++ b/spec/features/work_packages/new/new_work_package_spec.rb
@@ -1,9 +1,9 @@
-require 'spec_helper'
-require 'support/edit_fields/edit_field'
-require 'features/work_packages/work_packages_page'
-require 'features/page_objects/notification'
+require "spec_helper"
+require "support/edit_fields/edit_field"
+require "features/work_packages/work_packages_page"
+require "features/page_objects/notification"
-RSpec.describe 'new work package', :js, :with_cuprite do
+RSpec.describe "new work package", :js, :with_cuprite do
shared_let(:status) { create(:status, is_default: true) }
shared_let(:priority) { create(:priority, is_default: true) }
shared_let(:type_task) { create(:type_task) }
@@ -21,8 +21,8 @@
let(:work_packages_page) { WorkPackagesPage.new(project) }
- let(:subject) { 'My subject' }
- let(:description) { 'A description of the newly-created work package.' }
+ let(:subject) { "My subject" }
+ let(:description) { "A description of the newly-created work package." }
let(:subject_field) { wp_page.edit_field :subject }
let(:description_field) { wp_page.edit_field :description }
@@ -36,10 +36,10 @@ def disable_leaving_unsaved_warning
end
def save_work_package!(expect_success = true)
- scroll_to_and_click find_by_id('work-packages--edit-actions-save')
+ scroll_to_and_click find_by_id("work-packages--edit-actions-save")
if expect_success
- toaster.expect_success('Successful creation.')
+ toaster.expect_success("Successful creation.")
end
end
@@ -53,7 +53,7 @@ def click_create_work_package_button(type)
def create_work_package(type, *)
click_create_work_package_button(type)
- expect(page).to have_focus_on('#wp-new-inline-edit--field-subject')
+ expect(page).to have_focus_on("#wp-new-inline-edit--field-subject")
wp_page.subject_field.set(subject)
wait_for_network_idle
@@ -81,21 +81,21 @@ def create_work_package_globally(type, project_name)
login_as(user)
end
- shared_examples 'work package creation workflow' do
+ shared_examples "work package creation workflow" do
before do
create_method.call(type_task, project.name)
expect(page).to have_selector(safeguard_selector, wait: 10)
end
- it 'creates a subsequent work package' do
+ it "creates a subsequent work package" do
wp_page.subject_field.set(subject)
save_work_package!
# safeguards
wp_page.dismiss_toaster!
wp_page.expect_no_toaster(
- message: 'Successful creation. Click here to open this work package in fullscreen view.'
+ message: "Successful creation. Click here to open this work package in fullscreen view."
)
subject_field.expect_state_text(subject)
@@ -107,7 +107,7 @@ def create_work_package_globally(type, project_name)
type_field.expect_state_text /#{type_bug.name}/i
end
- it 'saves the work package with enter' do
+ it "saves the work package with enter" do
subject_field = wp_page.subject_field
subject_field.set(subject)
subject_field.send_keys(:enter)
@@ -115,20 +115,20 @@ def create_work_package_globally(type, project_name)
# safeguards
wp_page.dismiss_toaster!
wp_page.expect_no_toaster(
- message: 'Successful creation. Click here to open this work package in fullscreen view.'
+ message: "Successful creation. Click here to open this work package in fullscreen view."
)
wp_page.edit_field(:subject).expect_text(subject)
end
- context 'with missing values' do
- it 'shows an error when subject is missing' do
+ context "with missing values" do
+ it "shows an error when subject is missing" do
description_field.set_value(description)
# Need to send keys to emulate change
subject_field = wp_page.subject_field
- subject_field.set('')
- subject_field.send_keys('a')
+ subject_field.set("")
+ subject_field.send_keys("a")
subject_field.send_keys(:backspace)
save_work_package!(false)
@@ -136,20 +136,20 @@ def create_work_package_globally(type, project_name)
end
end
- context 'with subject set' do
- it 'creates a basic work package' do
+ context "with subject set" do
+ it "creates a basic work package" do
description_field = wp_page.edit_field :description
description_field.set_value description
save_work_package!
- expect(page).to have_css('.op-work-package-tabs')
+ expect(page).to have_css(".op-work-package-tabs")
subject_field.expect_state_text(subject)
description_field = wp_page.edit_field :description
description_field.expect_state_text(description)
end
- it 'can switch types and keep attributes' do
+ it "can switch types and keep attributes" do
wp_page.subject_field.set(subject)
type_field.activate!
type_field.openSelectField
@@ -161,11 +161,11 @@ def create_work_package_globally(type, project_name)
wp_page.expect_attributes type: type_bug.name.upcase
end
- context 'custom fields' do
+ context "custom fields" do
let(:custom_field1) do
create(
:work_package_custom_field,
- field_format: 'string',
+ field_format: "string",
is_required: true,
is_for_all: true
)
@@ -173,7 +173,7 @@ def create_work_package_globally(type, project_name)
let(:custom_field2) do
create(
:work_package_custom_field,
- field_format: 'list',
+ field_format: "list",
possible_values: %w(foo bar xyz),
is_required: false,
is_for_all: true
@@ -197,25 +197,25 @@ def create_work_package_globally(type, project_name)
expect(page).to have_css(".#{custom_fields.last.attribute_name(:camel_case)} ng-select")
cf = wp_page.edit_field custom_fields.last.attribute_name(:camel_case)
- cf.field_type = 'create-autocompleter'
+ cf.field_type = "create-autocompleter"
cf.openSelectField
- cf.set_value 'foo'
+ cf.set_value "foo"
save_work_package!(false)
toaster.expect_error("#{custom_field1.name} can't be blank.")
- cf1.set 'Custom field content'
+ cf1.set "Custom field content"
save_work_package!(true)
- wp_page.expect_attributes "customField#{custom_field1.id}" => 'Custom field content',
- "customField#{custom_field2.id}" => 'foo'
+ wp_page.expect_attributes "customField#{custom_field1.id}" => "Custom field content",
+ "customField#{custom_field2.id}" => "foo"
end
end
end
end
- context 'project split screen' do
- let(:safeguard_selector) { '.work-packages--details-content.-create-mode' }
+ context "project split screen" do
+ let(:safeguard_selector) { ".work-packages--details-content.-create-mode" }
let(:wp_page) { Pages::SplitWorkPackage.new(WorkPackage.new) }
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
@@ -223,38 +223,38 @@ def create_work_package_globally(type, project_name)
wp_table.visit!
end
- it_behaves_like 'work package creation workflow' do
+ it_behaves_like "work package creation workflow" do
let(:create_method) { method(:create_work_package) }
end
- it 'allows to go to the full page through the toaster (Regression #37555)' do
+ it "allows to go to the full page through the toaster (Regression #37555)" do
create_work_package(type_task)
save_work_package!
- wp_page.expect_toast message: 'Successful creation. Click here to open this work package in fullscreen view.'
- page.find('.op-toast--target-link', text: 'Click here to open this work package in fullscreen view.').click
+ wp_page.expect_toast message: "Successful creation. Click here to open this work package in fullscreen view."
+ page.find(".op-toast--target-link", text: "Click here to open this work package in fullscreen view.").click
full_page = Pages::FullWorkPackage.new(WorkPackage.last)
full_page.ensure_page_loaded
full_page.expect_subject
end
- it 'reloads the table and selects the new work package' do
- expect(page).to have_no_css('.wp--row')
+ it "reloads the table and selects the new work package" do
+ expect(page).to have_no_css(".wp--row")
create_work_package(type_task)
expect(page).to have_selector(safeguard_selector, wait: 10)
- wp_page.subject_field.set('new work package')
+ wp_page.subject_field.set("new work package")
save_work_package!
wp_page.dismiss_toaster!
- expect(page).to have_css('.wp--row.-checked')
+ expect(page).to have_css(".wp--row.-checked")
# Editing the subject after creation
# Fix for WP #23879
new_wp = WorkPackage.last
- new_subject = 'new subject'
+ new_subject = "new subject"
table_subject = wp_table.edit_field(new_wp, :subject)
table_subject.activate!
table_subject.set_value new_subject
@@ -262,7 +262,7 @@ def create_work_package_globally(type, project_name)
table_subject.expect_state_text new_subject
wp_page.expect_toast(
- message: 'Successful update. Click here to open this work package in fullscreen view.'
+ message: "Successful update. Click here to open this work package in fullscreen view."
)
new_wp.reload
@@ -274,8 +274,8 @@ def create_work_package_globally(type, project_name)
end
end
- context 'full screen' do
- let(:safeguard_selector) { '.work-package--new-state' }
+ context "full screen" do
+ let(:safeguard_selector) { ".work-package--new-state" }
let(:existing_wp) { create(:work_package, type: type_bug, project:) }
let(:wp_page) { Pages::FullWorkPackage.new(existing_wp) }
@@ -284,12 +284,12 @@ def create_work_package_globally(type, project_name)
wp_page.ensure_page_loaded
end
- it 'displays chosen date attribute for milestone type (#44701)' do
+ it "displays chosen date attribute for milestone type (#44701)" do
click_create_work_package_button(type_milestone)
date_field = wp_page.edit_field(:date)
- date_field.expect_value(I18n.t('js.label_no_date'))
+ date_field.expect_value(I18n.t("js.label_no_date"))
# Set date
date_field.click_to_open_datepicker
@@ -301,13 +301,13 @@ def create_work_package_globally(type, project_name)
date_field.expect_value date
end
- it_behaves_like 'work package creation workflow' do
+ it_behaves_like "work package creation workflow" do
let(:create_method) { method(:create_work_package) }
end
end
- context 'global split screen' do
- let(:safeguard_selector) { '.work-packages--details-content.-create-mode' }
+ context "global split screen" do
+ let(:safeguard_selector) { ".work-packages--details-content.-create-mode" }
let(:wp_page) { Pages::SplitWorkPackage.new(WorkPackage.new) }
let(:wp_table) { Pages::WorkPackagesTable.new(nil) }
@@ -315,38 +315,38 @@ def create_work_package_globally(type, project_name)
wp_table.visit!
end
- it_behaves_like 'work package creation workflow' do
+ it_behaves_like "work package creation workflow" do
let(:create_method) { method(:create_work_package_globally) }
end
- it 'can stop and re-create with correct selection (Regression #30216)' do
+ it "can stop and re-create with correct selection (Regression #30216)" do
create_work_package_globally(type_bug, project.name)
- click_on 'Cancel'
+ click_on "Cancel"
wp_page.click_create_wp_button type_bug
- expect(page).to have_no_css('.ng-value', text: project.name)
+ expect(page).to have_no_css(".ng-value", text: project.name)
project_field.openSelectField
project_field.set_value project.name
- click_on 'Cancel'
+ click_on "Cancel"
end
- it 'sets a default date that is readable (Regression #34291)' do
+ it "sets a default date that is readable (Regression #34291)" do
create_work_package_globally(type_bug, project.name)
date_field = wp_page.edit_field(:combinedDate)
date_field.expect_value("no start date - no finish date")
- click_on 'Cancel'
+ click_on "Cancel"
end
- it 'can save the work package with an assignee (Regression #32887)' do
+ it "can save the work package with an assignee (Regression #32887)" do
create_work_package_globally(type_task, project.name)
expect(page).to have_selector(safeguard_selector, wait: 10)
- wp_page.subject_field.set('new work package')
+ wp_page.subject_field.set("new work package")
save_work_package!
wp_page.dismiss_toaster!
@@ -355,7 +355,7 @@ def create_work_package_globally(type, project_name)
expect(wp.assigned_to).to eq user
end
- it 'resets the dates when opening the datepicker and cancelling (Regression #44152)' do
+ it "resets the dates when opening the datepicker and cancelling (Regression #44152)" do
create_work_package_globally(type_task, project.name)
expect(page).to have_selector(safeguard_selector, wait: 10)
@@ -372,26 +372,26 @@ def create_work_package_globally(type, project_name)
# Cancel
date_field.cancel_by_click
- date_field.expect_value 'no start date - no finish date'
+ date_field.expect_value "no start date - no finish date"
end
- context 'with a project without type_bug' do
+ context "with a project without type_bug" do
let!(:project_without_bug) do
- create(:project, name: 'Unrelated project', types: [type_task])
+ create(:project, name: "Unrelated project", types: [type_task])
end
- it 'does not show that value in the project drop down' do
+ it "does not show that value in the project drop down" do
create_work_package_globally(type_bug, project.name)
project_field.openSelectField
- expect(page).to have_css('.ng-dropdown-panel .ng-option', text: project.name)
- expect(page).to have_no_css('.ng-dropdown-panel .ng-option', text: project_without_bug.name)
+ expect(page).to have_css(".ng-dropdown-panel .ng-option", text: project.name)
+ expect(page).to have_no_css(".ng-dropdown-panel .ng-option", text: project_without_bug.name)
end
end
end
- context 'as a user with no permissions' do
+ context "as a user with no permissions" do
let(:role) { create(:project_role, permissions: %i(view_work_packages)) }
let(:user) { create(:user, member_with_roles: { project => role }) }
let(:wp_page) { Pages::Page.new }
@@ -405,15 +405,15 @@ def create_work_package_globally(type, project_name)
]
end
- it 'shows a 403 error on creation paths' do
+ it "shows a 403 error on creation paths" do
paths.each do |path|
visit path
- wp_page.expect_toast(type: :error, message: I18n.t('api_v3.errors.code_403'))
+ wp_page.expect_toast(type: :error, message: I18n.t("api_v3.errors.code_403"))
end
end
end
- context 'as a user with add_work_packages permission, but not edit_work_packages permission (Regression 28580)' do
+ context "as a user with add_work_packages permission, but not edit_work_packages permission (Regression 28580)" do
let(:role) { create(:project_role, permissions: %i(view_work_packages add_work_packages)) }
let(:user) { create(:user, member_with_roles: { project => role }) }
let(:wp_page) { Pages::FullWorkPackageCreate.new }
@@ -422,15 +422,15 @@ def create_work_package_globally(type, project_name)
visit new_project_work_packages_path(project)
end
- it 'can create the work package, but not update it after saving' do
+ it "can create the work package, but not update it after saving" do
type_field.activate!
type_field.set_value type_bug.name
# wait after the type change
sleep(0.2)
- subject_field.update('new work package', save: true)
+ subject_field.update("new work package", save: true)
wp_page.expect_and_dismiss_toaster(
- message: 'Successful creation.'
+ message: "Successful creation."
)
subject_field.expect_read_only
@@ -439,7 +439,7 @@ def create_work_package_globally(type, project_name)
end
end
- context 'an anonymous user is prompted to login' do
+ context "an anonymous user is prompted to login" do
let(:user) { create(:anonymous) }
let(:wp_page) { Pages::Page.new }
@@ -452,7 +452,7 @@ def create_work_package_globally(type, project_name)
]
end
- it 'shows a 403 error on creation paths' do
+ it "shows a 403 error on creation paths" do
paths.each do |path|
visit path
expect(wp_page.current_url).to match /#{signin_path}\?back_url=/
@@ -460,7 +460,7 @@ def create_work_package_globally(type, project_name)
end
end
- context 'creating child work packages' do
+ context "creating child work packages" do
let!(:parent) do
create(:work_package,
project:,
@@ -474,64 +474,64 @@ def create_work_package_globally(type, project_name)
let(:wp_page) { Pages::FullWorkPackage.new(parent) }
let(:wp_page_create) { Pages::FullWorkPackageCreate.new(project:) }
- it 'from within the table' do
+ it "from within the table" do
work_packages_page.visit_index
context_menu.open_for(parent)
- context_menu.choose('Create new child')
+ context_menu.choose("Create new child")
# The dates are taken over from the parent by default
date_field = split_create_page.edit_field(:combinedDate)
date_field.expect_value("#{parent.start_date} - #{parent.due_date}")
date_field.click_to_open_datepicker
- date_field.update ['', parent.due_date]
+ date_field.update ["", parent.due_date]
subject = split_create_page.edit_field(:subject)
- subject.set_value 'Child'
+ subject.set_value "Child"
split_create_page.save!
- split_create_page.expect_and_dismiss_toaster(message: I18n.t('js.notice_successful_create'))
+ split_create_page.expect_and_dismiss_toaster(message: I18n.t("js.notice_successful_create"))
split_create_page.expect_attributes(combinedDate: "no start date - #{parent.due_date.strftime('%m/%d/%Y')}")
- expect(split_create_page).to have_test_selector('op-wp-breadcrumb', text: "Parent:\n#{parent.subject}")
+ expect(split_create_page).to have_test_selector("op-wp-breadcrumb", text: "Parent:\n#{parent.subject}")
end
- it 'can navigate to the fullscreen page (Regression #49565)' do
+ it "can navigate to the fullscreen page (Regression #49565)" do
work_packages_page.visit_index
context_menu.open_for(parent)
- context_menu.choose('Create new child')
+ context_menu.choose("Create new child")
subject_field = split_create_page.edit_field(:subject)
- subject_field.set_value 'My subtask'
+ subject_field.set_value "My subtask"
- find('.work-packages-show-view-button').click
+ find(".work-packages-show-view-button").click
expect(split_create_page).not_to have_alert_dialog
subject_field = wp_page_create.edit_field(:subject)
- subject_field.expect_value 'My subtask'
+ subject_field.expect_value "My subtask"
end
- it 'from the relations tab' do
- wp_page.visit_tab!('relations')
+ it "from the relations tab" do
+ wp_page.visit_tab!("relations")
- click_button('Create new child')
+ click_button("Create new child")
subject = EditField.new wp_page, :subject
- subject.set_value 'Child'
+ subject.set_value "Child"
subject.submit_by_enter
- wp_page.expect_and_dismiss_toaster(message: I18n.t('js.notice_successful_create'))
+ wp_page.expect_and_dismiss_toaster(message: I18n.t("js.notice_successful_create"))
# Move to the newly created child
wp_page.find("wp-children-query tbody.results-tbody tr").double_click
wp_page.expect_attributes(combinedDate: "#{parent.start_date.strftime('%m/%d/%Y')} - #{parent.due_date.strftime('%m/%d/%Y')}")
- expect(wp_page).to have_test_selector('op-wp-breadcrumb', text: "Parent:\n#{parent.subject}")
+ expect(wp_page).to have_test_selector("op-wp-breadcrumb", text: "Parent:\n#{parent.subject}")
end
end
end
diff --git a/spec/features/work_packages/new/work_package_default_description_spec.rb b/spec/features/work_packages/new/work_package_default_description_spec.rb
index 3d3305b4098b..d905d29feb8f 100644
--- a/spec/features/work_packages/new/work_package_default_description_spec.rb
+++ b/spec/features/work_packages/new/work_package_default_description_spec.rb
@@ -1,9 +1,9 @@
-require 'spec_helper'
-require 'support/edit_fields/edit_field'
-require 'features/work_packages/work_packages_page'
-require 'features/page_objects/notification'
+require "spec_helper"
+require "support/edit_fields/edit_field"
+require "features/work_packages/work_packages_page"
+require "features/page_objects/notification"
-RSpec.describe 'new work package', :js do
+RSpec.describe "new work package", :js do
let(:type_task) { create(:type_task, description: "# New Task template\n\nHello there") }
let(:type_feature) { create(:type_feature, description: "", is_default: true) }
let(:type_bug) { create(:type_bug, description: "# New Bug template\n\nGeneral Kenobi") }
@@ -26,31 +26,31 @@
# Changes in the description shall not be overridden.
def change_type_and_expect_description(set_project: false)
if !set_project
- expect(page).to have_css('.inline-edit--container.type', text: type_feature.name)
+ expect(page).to have_css(".inline-edit--container.type", text: type_feature.name)
end
- expect(page).to have_css('.inline-edit--container.description', text: '')
+ expect(page).to have_css(".inline-edit--container.description", text: "")
type_field.openSelectField
type_field.set_value type_task
- expect(page).to have_css('.inline-edit--container.description h1', text: 'New Task template')
+ expect(page).to have_css(".inline-edit--container.description h1", text: "New Task template")
type_field.openSelectField
type_field.set_value type_bug
- expect(page).to have_css('.inline-edit--container.description h1', text: 'New Bug template')
+ expect(page).to have_css(".inline-edit--container.description h1", text: "New Bug template")
- description_field.set_value 'Something different than the default.'
+ description_field.set_value "Something different than the default."
sleep 0.1
type_field.openSelectField
type_field.set_value type_task
- expect(page).to have_css('.inline-edit--container.description', text: 'Something different than the default.')
+ expect(page).to have_css(".inline-edit--container.description", text: "Something different than the default.")
sleep 0.1
type_field.openSelectField
type_field.set_value type_bug
- expect(page).to have_css('.inline-edit--container.description', text: 'Something different than the default.')
+ expect(page).to have_css(".inline-edit--container.description", text: "Something different than the default.")
if set_project
project_field.openSelectField
@@ -58,38 +58,38 @@ def change_type_and_expect_description(set_project: false)
sleep 1
end
- scroll_to_and_click find_by_id('work-packages--edit-actions-save')
- wp_page.expect_toast message: 'Successful creation.'
+ scroll_to_and_click find_by_id("work-packages--edit-actions-save")
+ wp_page.expect_toast message: "Successful creation."
- expect(page).to have_css('.inline-edit--display-field.description', text: 'Something different than the default.')
+ expect(page).to have_css(".inline-edit--display-field.description", text: "Something different than the default.")
end
before do
login_as(user)
end
- describe 'global work package create' do
- it 'shows the template after selection of project and type' do
- visit '/work_packages/new'
+ describe "global work package create" do
+ it "shows the template after selection of project and type" do
+ visit "/work_packages/new"
wp_page.expect_fully_loaded
- subject_field.set_value 'Foobar!'
+ subject_field.set_value "Foobar!"
change_type_and_expect_description set_project: true
end
end
- describe 'project work package create' do
+ describe "project work package create" do
let(:wp_table) { Pages::WorkPackagesTable.new project }
let(:wp_page) { Pages::SplitWorkPackageCreate.new project: }
- it 'shows the template after selection of project and type' do
+ it "shows the template after selection of project and type" do
wp_table.visit!
wp_table.create_wp_by_button type_feature
wp_page.expect_fully_loaded
- subject_field.set_value 'Foobar!'
+ subject_field.set_value "Foobar!"
type_field.activate!
diff --git a/spec/features/work_packages/pagination_spec.rb b/spec/features/work_packages/pagination_spec.rb
index d326276c4702..3d5babd12b21 100644
--- a/spec/features/work_packages/pagination_spec.rb
+++ b/spec/features/work_packages/pagination_spec.rb
@@ -26,66 +26,66 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package pagination', :js do
+RSpec.describe "Work package pagination", :js do
shared_let(:admin) { create(:admin) }
let(:project) do
- create(:project, name: 'project1', identifier: 'project1')
+ create(:project, name: "project1", identifier: "project1")
end
- shared_examples_for 'paginated work package list' do
+ shared_examples_for "paginated work package list" do
let!(:work_package_1) { create(:work_package, project:) }
let!(:work_package_2) { create(:work_package, project:) }
before do
login_as(admin)
- allow(Setting).to receive(:per_page_options).and_return '1, 50, 100'
+ allow(Setting).to receive(:per_page_options).and_return "1, 50, 100"
visit path
expect(page).to have_current_path(expected_path, ignore_query: true)
end
it do
- expect(page).to have_content('All open')
+ expect(page).to have_content("All open")
- within('.work-packages-partitioned-query-space--container') do
+ within(".work-packages-partitioned-query-space--container") do
expect(page).to have_content(work_package_1.subject)
expect(page).to have_no_content(work_package_2.subject)
end
- within('.op-pagination--pages') do
- find('.op-pagination--item button', text: '2').click
+ within(".op-pagination--pages") do
+ find(".op-pagination--item button", text: "2").click
end
- within('.work-packages-partitioned-query-space--container') do
+ within(".work-packages-partitioned-query-space--container") do
expect(page).to have_content(work_package_2.subject)
expect(page).to have_no_content(work_package_1.subject)
end
- within('.op-pagination--options') do
- find('.op-pagination--item button', text: '50').click
+ within(".op-pagination--options") do
+ find(".op-pagination--item button", text: "50").click
end
- within('.work-packages-partitioned-query-space--container') do
+ within(".work-packages-partitioned-query-space--container") do
expect(page).to have_content(work_package_1.subject)
expect(page).to have_content(work_package_2.subject)
end
end
end
- context 'with project scope' do
- it_behaves_like 'paginated work package list' do
+ context "with project scope" do
+ it_behaves_like "paginated work package list" do
let(:path) { project_work_packages_path(project) }
- let(:expected_path) { '/projects/project1/work_packages' }
+ let(:expected_path) { "/projects/project1/work_packages" }
end
end
- context 'globally' do
- it_behaves_like 'paginated work package list' do
+ context "globally" do
+ it_behaves_like "paginated work package list" do
let(:path) { work_packages_path }
- let(:expected_path) { '/work_packages' }
+ let(:expected_path) { "/work_packages" }
end
end
end
diff --git a/spec/features/work_packages/project_include/project_include_shared_examples.rb b/spec/features/work_packages/project_include/project_include_shared_examples.rb
index 436c8d691759..83086bac17c4 100644
--- a/spec/features/work_packages/project_include/project_include_shared_examples.rb
+++ b/spec/features/work_packages/project_include/project_include_shared_examples.rb
@@ -26,43 +26,43 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.shared_examples 'has a project include dropdown', :js, type: :feature do
+RSpec.shared_examples "has a project include dropdown", :js, type: :feature do
let(:dropdown) { Components::ProjectIncludeComponent.new }
shared_let(:project) do
- create(:project, name: 'Parent', enabled_module_names: enabled_modules)
+ create(:project, name: "Parent", enabled_module_names: enabled_modules)
end
shared_let(:sub_project) do
- create(:project, name: 'Direct Child', parent: project, enabled_module_names: enabled_modules)
+ create(:project, name: "Direct Child", parent: project, enabled_module_names: enabled_modules)
end
# The user will not receive a membership in this project
# which is why it is invisible to the user.
shared_let(:sub_sub_project_invisible) do
- create(:project, name: 'Invisible Grandchild', parent: sub_project, enabled_module_names: enabled_modules)
+ create(:project, name: "Invisible Grandchild", parent: sub_project, enabled_module_names: enabled_modules)
end
shared_let(:sub_sub_sub_project) do
- create(:project, name: 'Direct grand Grandchild', parent: sub_sub_project_invisible, enabled_module_names: enabled_modules)
+ create(:project, name: "Direct grand Grandchild", parent: sub_sub_project_invisible, enabled_module_names: enabled_modules)
end
shared_let(:other_project) do
- create(:project, name: 'Other project', enabled_module_names: enabled_modules)
+ create(:project, name: "Other project", enabled_module_names: enabled_modules)
end
shared_let(:other_sub_project) do
- create(:project, name: 'Other Child', parent: other_project, enabled_module_names: enabled_modules)
+ create(:project, name: "Other Child", parent: other_project, enabled_module_names: enabled_modules)
end
shared_let(:other_sub_sub_project) do
- create(:project, name: 'First other sub sub child', parent: other_sub_project, enabled_module_names: enabled_modules)
+ create(:project, name: "First other sub sub child", parent: other_sub_project, enabled_module_names: enabled_modules)
end
shared_let(:another_sub_sub_project) do
- create(:project, name: 'Second other sub sub child', parent: other_sub_project, enabled_module_names: enabled_modules)
+ create(:project, name: "Second other sub sub child", parent: other_sub_project, enabled_module_names: enabled_modules)
end
shared_let(:user) do
@@ -80,8 +80,8 @@
shared_let(:other_user) do
create(:user,
- firstname: 'Other',
- lastname: 'User',
+ firstname: "Other",
+ lastname: "User",
member_with_permissions: {
project => permissions,
sub_project => permissions,
@@ -136,7 +136,7 @@
assigned_to: other_user,
start_date: Time.zone.today,
due_date: Time.zone.today + 2.days,
- subject: 'A task for the other user')
+ subject: "A task for the other user")
end
shared_let(:other_other_task) do
@@ -146,7 +146,7 @@
assigned_to: other_user,
start_date: Time.zone.today - 2.days,
due_date: Time.zone.today + 4.days,
- subject: 'A task for the other user in other-project')
+ subject: "A task for the other user in other-project")
end
before do
@@ -170,7 +170,7 @@
work_package_view.visit!
end
- it 'can add and remove projects' do
+ it "can add and remove projects" do
dropdown.expect_count 1
dropdown.toggle!
dropdown.expect_open
@@ -214,14 +214,14 @@
dropdown.expect_checkbox(sub_project.id)
dropdown.expect_checkbox(sub_sub_sub_project.id)
- dropdown.click_button 'Apply'
+ dropdown.click_button "Apply"
dropdown.expect_closed
dropdown.expect_count 2
dropdown.toggle!
dropdown.toggle_checkbox(sub_sub_sub_project.id)
- dropdown.click_button 'Apply'
+ dropdown.click_button "Apply"
dropdown.expect_closed
dropdown.expect_count 3
@@ -253,12 +253,12 @@
dropdown.toggle_checkbox(sub_sub_sub_project.id)
- dropdown.click_button 'Apply'
+ dropdown.click_button "Apply"
dropdown.expect_closed
dropdown.expect_count 2
end
- it 'can clear the selection' do
+ it "can clear the selection" do
dropdown.expect_count 1
dropdown.toggle!
dropdown.expect_open
@@ -275,13 +275,13 @@
dropdown.expect_checkbox(sub_project.id, true)
dropdown.expect_checkbox(sub_sub_sub_project.id, true)
- dropdown.click_button 'Apply'
+ dropdown.click_button "Apply"
dropdown.expect_closed
dropdown.expect_count 2
dropdown.toggle!
- dropdown.click_button 'Clear selection'
+ dropdown.click_button "Clear selection"
dropdown.expect_checkbox(other_project.id)
dropdown.expect_checkbox(other_sub_project.id)
@@ -304,13 +304,13 @@
dropdown.expect_checkbox(sub_project.id)
dropdown.expect_checkbox(sub_sub_sub_project.id, true)
- dropdown.click_button 'Apply'
+ dropdown.click_button "Apply"
dropdown.expect_closed
dropdown.expect_count 3
dropdown.toggle!
- dropdown.click_button 'Clear selection'
+ dropdown.click_button "Clear selection"
dropdown.expect_checkbox(other_project.id)
dropdown.expect_checkbox(other_sub_project.id)
@@ -320,12 +320,12 @@
dropdown.expect_checkbox(sub_project.id)
dropdown.expect_checkbox(sub_sub_sub_project.id)
- dropdown.click_button 'Apply'
+ dropdown.click_button "Apply"
dropdown.expect_closed
dropdown.expect_count 1
end
- it 'filter projects in the list' do
+ it "filter projects in the list" do
dropdown.expect_count 1
dropdown.toggle!
dropdown.expect_open
@@ -355,7 +355,7 @@
end
retry_block do
- dropdown.search ''
+ dropdown.search ""
dropdown.expect_checkbox(other_project.id)
dropdown.expect_checkbox(other_sub_project.id)
@@ -428,7 +428,7 @@
end
retry_block do
- dropdown.search ''
+ dropdown.search ""
dropdown.expect_checkbox(other_project.id, true)
dropdown.expect_no_checkbox(other_sub_project.id)
@@ -452,11 +452,11 @@
end
end
- it 'keeps working even when there are no results (regression #42908)' do
+ it "keeps working even when there are no results (regression #42908)" do
dropdown.expect_count 1
dropdown.toggle!
dropdown.expect_open
- dropdown.search 'Nonexistent'
+ dropdown.search "Nonexistent"
expect(page).to have_no_css("[data-test-selector='op-project-include--loading']")
end
end
diff --git a/spec/features/work_packages/remaining_time_spec.rb b/spec/features/work_packages/remaining_time_spec.rb
index 033a030f5ec0..2ba7212cfbce 100644
--- a/spec/features/work_packages/remaining_time_spec.rb
+++ b/spec/features/work_packages/remaining_time_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work packages remaining time', :js, :with_cuprite do
+RSpec.describe "Work packages remaining time", :js, :with_cuprite do
shared_current_user { create(:admin) }
shared_let(:project) do
create(:project,
@@ -40,21 +40,21 @@
author: current_user)
end
- it 'can set and edit the remaining time in hours (Regression #43549)' do
+ it "can set and edit the remaining time in hours (Regression #43549)" do
wp_page = Pages::FullWorkPackage.new(work_package)
wp_page.visit!
wp_page.expect_subject
- wp_page.expect_attributes remainingTime: '-'
+ wp_page.expect_attributes remainingTime: "-"
- wp_page.update_attributes remainingTime: '125' # rubocop:disable Rails/ActiveRecordAliases
- wp_page.expect_attributes remainingTime: '125 h'
+ wp_page.update_attributes remainingTime: "125" # rubocop:disable Rails/ActiveRecordAliases
+ wp_page.expect_attributes remainingTime: "125 h"
work_package.reload
expect(work_package.remaining_hours).to eq 125.0
end
- it 'displays the remaining time sum properly in hours (Regression #43833)' do
+ it "displays the remaining time sum properly in hours (Regression #43833)" do
wp_table_page = Pages::WorkPackagesTable.new(project)
query_props = JSON.dump({
@@ -63,11 +63,11 @@
})
wp_table_page.visit_with_params("query_props=#{query_props}")
- wp_table_page.expect_work_package_with_attributes work_package, remainingTime: '-'
+ wp_table_page.expect_work_package_with_attributes work_package, remainingTime: "-"
- wp_table_page.update_work_package_attributes work_package, remainingTime: '125'
- wp_table_page.expect_work_package_with_attributes work_package, remainingTime: '125 h'
- wp_table_page.expect_sums_row_with_attributes remainingTime: '125 h'
+ wp_table_page.update_work_package_attributes work_package, remainingTime: "125"
+ wp_table_page.expect_work_package_with_attributes work_package, remainingTime: "125 h"
+ wp_table_page.expect_sums_row_with_attributes remainingTime: "125 h"
work_package.reload
expect(work_package.remaining_hours).to eq 125.0
diff --git a/spec/features/work_packages/reports_spec.rb b/spec/features/work_packages/reports_spec.rb
index 86c82b9f3ac7..676f3e7b7b70 100644
--- a/spec/features/work_packages/reports_spec.rb
+++ b/spec/features/work_packages/reports_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'work package reports', :js do
+RSpec.describe "work package reports", :js do
let(:project) { create(:project_with_types, types: [type_a]) }
let(:user) { create(:user, member_with_permissions: { project => %i(view_work_packages) }) }
let(:type_a) do
- create(:type_with_workflow, name: 'Type A').tap do |t|
+ create(:type_with_workflow, name: "Type A").tap do |t|
t.statuses.last.update_attribute(:is_closed, true)
end
end
@@ -47,73 +47,73 @@
login_as(user)
end
- it 'allows navigating to the reports page and drilling down' do
+ it "allows navigating to the reports page and drilling down" do
wp_table_page.visit!
- within '.main-menu--children' do
- click_on 'Summary'
+ within ".main-menu--children" do
+ click_on "Summary"
end
expect(page)
- .to have_content 'TYPE'
+ .to have_content "TYPE"
expect(page)
- .to have_content 'PRIORITY'
+ .to have_content "PRIORITY"
expect(page)
- .to have_content 'ASSIGNEE'
+ .to have_content "ASSIGNEE"
expect(page)
- .to have_content 'ACCOUNTABLE'
+ .to have_content "ACCOUNTABLE"
expect(page)
- .to have_css 'thead th:nth-of-type(2)', text: type_a.statuses.first.name.upcase
+ .to have_css "thead th:nth-of-type(2)", text: type_a.statuses.first.name.upcase
expect(page)
- .to have_css 'thead th:nth-of-type(3)', text: type_a.statuses.last.name.upcase
+ .to have_css "thead th:nth-of-type(3)", text: type_a.statuses.last.name.upcase
expect(page)
- .to have_css 'tbody tr:nth-of-type(1) td:nth-of-type(1)', text: type_a.name
+ .to have_css "tbody tr:nth-of-type(1) td:nth-of-type(1)", text: type_a.name
expect(page)
- .to have_css 'tbody tr:nth-of-type(1) td:nth-of-type(2)', text: 1
+ .to have_css "tbody tr:nth-of-type(1) td:nth-of-type(2)", text: 1
expect(page)
- .to have_css 'tbody tr:nth-of-type(1) td:nth-of-type(3)', text: 1
+ .to have_css "tbody tr:nth-of-type(1) td:nth-of-type(3)", text: 1
expect(page)
- .to have_css 'tbody tr:nth-of-type(1) td:nth-of-type(4)', text: 1
+ .to have_css "tbody tr:nth-of-type(1) td:nth-of-type(4)", text: 1
expect(page)
- .to have_css 'tbody tr:nth-of-type(1) td:nth-of-type(5)', text: 1
+ .to have_css "tbody tr:nth-of-type(1) td:nth-of-type(5)", text: 1
expect(page)
- .to have_css 'tbody tr:nth-of-type(1) td:nth-of-type(6)', text: 2
+ .to have_css "tbody tr:nth-of-type(1) td:nth-of-type(6)", text: 2
# Clicking on the further analyze link will lead to a page focusing on type
- click_link 'Further analyze: Type'
+ click_link "Further analyze: Type"
expect(page)
- .to have_content 'TYPE'
+ .to have_content "TYPE"
expect(page)
- .to have_no_content 'PRIORITY'
+ .to have_no_content "PRIORITY"
expect(page)
- .to have_no_content 'ASSIGNEE'
+ .to have_no_content "ASSIGNEE"
expect(page)
- .to have_no_content 'ACCOUNTABLE'
+ .to have_no_content "ACCOUNTABLE"
expect(page)
- .to have_css 'thead th:nth-of-type(2)', text: type_a.statuses.first.name.upcase
+ .to have_css "thead th:nth-of-type(2)", text: type_a.statuses.first.name.upcase
expect(page)
- .to have_css 'thead th:nth-of-type(3)', text: type_a.statuses.last.name.upcase
+ .to have_css "thead th:nth-of-type(3)", text: type_a.statuses.last.name.upcase
expect(page)
- .to have_css 'tbody tr:nth-of-type(1) td:nth-of-type(1)', text: type_a.name
+ .to have_css "tbody tr:nth-of-type(1) td:nth-of-type(1)", text: type_a.name
expect(page)
- .to have_css 'tbody tr:nth-of-type(1) td:nth-of-type(2)', text: 1
+ .to have_css "tbody tr:nth-of-type(1) td:nth-of-type(2)", text: 1
expect(page)
- .to have_css 'tbody tr:nth-of-type(1) td:nth-of-type(3)', text: 1
+ .to have_css "tbody tr:nth-of-type(1) td:nth-of-type(3)", text: 1
expect(page)
- .to have_css 'tbody tr:nth-of-type(1) td:nth-of-type(4)', text: 1
+ .to have_css "tbody tr:nth-of-type(1) td:nth-of-type(4)", text: 1
expect(page)
- .to have_css 'tbody tr:nth-of-type(1) td:nth-of-type(5)', text: 1
+ .to have_css "tbody tr:nth-of-type(1) td:nth-of-type(5)", text: 1
expect(page)
- .to have_css 'tbody tr:nth-of-type(1) td:nth-of-type(6)', text: 2
+ .to have_css "tbody tr:nth-of-type(1) td:nth-of-type(6)", text: 2
# Clicking on a number in the table will lead to the wp list filtered by the type
- within 'tbody tr:first-of-type td:nth-of-type(2)' do
- click_link '1'
+ within "tbody tr:first-of-type td:nth-of-type(2)" do
+ click_link "1"
end
wp_table_page.expect_work_package_listed(wp1)
diff --git a/spec/features/work_packages/scheduling/scheduling_mode_spec.rb b/spec/features/work_packages/scheduling/scheduling_mode_spec.rb
index e1712597c00c..55365b76792a 100644
--- a/spec/features/work_packages/scheduling/scheduling_mode_spec.rb
+++ b/spec/features/work_packages/scheduling/scheduling_mode_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/page_objects/notification'
-require 'features/work_packages/details/inplace_editor/shared_examples'
-require 'features/work_packages/shared_contexts'
-require 'support/edit_fields/edit_field'
-require 'features/work_packages/work_packages_page'
-
-RSpec.describe 'scheduling mode', :js do
+require "spec_helper"
+require "features/page_objects/notification"
+require "features/work_packages/details/inplace_editor/shared_examples"
+require "features/work_packages/shared_contexts"
+require "support/edit_fields/edit_field"
+require "features/work_packages/work_packages_page"
+
+RSpec.describe "scheduling mode", :js do
let(:project) { create(:project_with_types, public: true) }
# Constructing a work package graph that looks like this:
#
@@ -52,36 +52,36 @@
let!(:wp) do
create(:work_package,
project:,
- start_date: Date.parse('2016-01-01'),
- due_date: Date.parse('2016-01-05'),
+ start_date: Date.parse("2016-01-01"),
+ due_date: Date.parse("2016-01-05"),
parent: wp_parent)
end
let!(:wp_parent) do
create(:work_package,
project:,
- start_date: Date.parse('2016-01-01'),
- due_date: Date.parse('2016-01-05'))
+ start_date: Date.parse("2016-01-01"),
+ due_date: Date.parse("2016-01-05"))
end
let!(:wp_child) do
create(:work_package,
project:,
- start_date: Date.parse('2016-01-01'),
- due_date: Date.parse('2016-01-05'),
+ start_date: Date.parse("2016-01-01"),
+ due_date: Date.parse("2016-01-05"),
parent: wp)
end
let!(:wp_pre) do
create(:work_package,
project:,
- start_date: Date.parse('2015-12-15'),
- due_date: Date.parse('2015-12-31')).tap do |pre|
+ start_date: Date.parse("2015-12-15"),
+ due_date: Date.parse("2015-12-31")).tap do |pre|
create(:follows_relation, from: wp, to: pre)
end
end
let!(:wp_suc) do
create(:work_package,
project:,
- start_date: Date.parse('2016-01-06'),
- due_date: Date.parse('2016-01-10'),
+ start_date: Date.parse("2016-01-06"),
+ due_date: Date.parse("2016-01-10"),
parent: wp_suc_parent).tap do |suc|
create(:follows_relation, from: suc, to: wp)
end
@@ -89,14 +89,14 @@
let!(:wp_suc_parent) do
create(:work_package,
project:,
- start_date: Date.parse('2016-01-06'),
- due_date: Date.parse('2016-01-10'))
+ start_date: Date.parse("2016-01-06"),
+ due_date: Date.parse("2016-01-10"))
end
let!(:wp_suc_child) do
create(:work_package,
project:,
- start_date: Date.parse('2016-01-06'),
- due_date: Date.parse('2016-01-10'),
+ start_date: Date.parse("2016-01-06"),
+ due_date: Date.parse("2016-01-10"),
parent: wp_suc)
end
let(:work_packages_page) { Pages::SplitWorkPackage.new(wp, project) }
@@ -116,7 +116,7 @@ def expect_dates(work_package, start_date, due_date)
work_packages_page.ensure_page_loaded
end
- it 'can toggle the scheduling mode through the date modal' do
+ it "can toggle the scheduling mode through the date modal" do
expect(wp.schedule_manually).to be_falsey
# Editing the start/due dates of a parent work package is possible if the
@@ -128,29 +128,29 @@ def expect_dates(work_package, start_date, due_date)
combined_field.expect_duration 6
combined_field.save!
- work_packages_page.expect_and_dismiss_toaster message: 'Successful update.'
+ work_packages_page.expect_and_dismiss_toaster message: "Successful update."
# Changing the scheduling mode is journalized
work_packages_page.expect_activity_message("Manual scheduling activated")
- expect_dates(wp, '2016-01-05', '2016-01-10')
+ expect_dates(wp, "2016-01-05", "2016-01-10")
expect(wp.schedule_manually).to be_truthy
# is not moved because it is a child
- expect_dates(wp_child, '2016-01-01', '2016-01-05')
+ expect_dates(wp_child, "2016-01-01", "2016-01-05")
# The due date is moved backwards because its child was moved
# but the start date remains unchanged as its grandchild stays put.
- expect_dates(wp_parent, '2016-01-01', '2016-01-10')
+ expect_dates(wp_parent, "2016-01-01", "2016-01-10")
# is moved forward because of the follows relationship
- expect_dates(wp_suc, '2016-01-11', '2016-01-15')
+ expect_dates(wp_suc, "2016-01-11", "2016-01-15")
# is moved forward because it is the parent of the successor
- expect_dates(wp_suc_parent, '2016-01-11', '2016-01-15')
+ expect_dates(wp_suc_parent, "2016-01-11", "2016-01-15")
# is moved forward as the whole hierarchy is moved forward
- expect_dates(wp_suc_child, '2016-01-11', '2016-01-15')
+ expect_dates(wp_suc_child, "2016-01-11", "2016-01-15")
# Switching back to automatic scheduling will lead to the work package
# and all work packages that are dependent to be rescheduled again.
@@ -159,27 +159,27 @@ def expect_dates(work_package, start_date, due_date)
combined_field.toggle_scheduling_mode
combined_field.save!
- work_packages_page.expect_and_dismiss_toaster message: 'Successful update.'
+ work_packages_page.expect_and_dismiss_toaster message: "Successful update."
# Moved backward again as the child determines the dates again
- expect_dates(wp, '2016-01-01', '2016-01-05')
+ expect_dates(wp, "2016-01-01", "2016-01-05")
expect(wp.schedule_manually).to be_falsey
# Had not been moved in the first place
- expect_dates(wp_child, '2016-01-01', '2016-01-05')
+ expect_dates(wp_child, "2016-01-01", "2016-01-05")
# As the child now again takes up the same time interval as the grandchild,
# the interval is shortened again.
- expect_dates(wp_parent, '2016-01-01', '2016-01-05')
+ expect_dates(wp_parent, "2016-01-01", "2016-01-05")
# does not move backwards, as it just increases the gap between wp and wp_suc
- expect_dates(wp_suc, '2016-01-11', '2016-01-15')
+ expect_dates(wp_suc, "2016-01-11", "2016-01-15")
# does not move backwards either
- expect_dates(wp_suc_parent, '2016-01-11', '2016-01-15')
+ expect_dates(wp_suc_parent, "2016-01-11", "2016-01-15")
# does not move backwards either because its parent did not move
- expect_dates(wp_suc_child, '2016-01-11', '2016-01-15')
+ expect_dates(wp_suc_child, "2016-01-11", "2016-01-15")
# Switching back to manual scheduling but this time backward will lead to the work package
# and all work packages that are dependent to be rescheduled again.
@@ -196,26 +196,26 @@ def expect_dates(work_package, start_date, due_date)
combined_field.expect_duration 12
combined_field.save!
- work_packages_page.expect_and_dismiss_toaster message: 'Successful update.'
+ work_packages_page.expect_and_dismiss_toaster message: "Successful update."
- expect_dates(wp, '2015-12-20', '2015-12-31')
+ expect_dates(wp, "2015-12-20", "2015-12-31")
expect(wp.schedule_manually).to be_truthy
# is not moved because it is a child
- expect_dates(wp_child, '2016-01-01', '2016-01-05')
+ expect_dates(wp_child, "2016-01-01", "2016-01-05")
# The start date is moved forward because its child was moved
# but the due date remains unchanged as its grandchild stays put.
- expect_dates(wp_parent, '2015-12-20', '2016-01-05')
+ expect_dates(wp_parent, "2015-12-20", "2016-01-05")
# does not move backwards, as it just increases the gap between wp and wp_suc
- expect_dates(wp_suc, '2016-01-11', '2016-01-15')
+ expect_dates(wp_suc, "2016-01-11", "2016-01-15")
# does not move backwards either
- expect_dates(wp_suc_parent, '2016-01-11', '2016-01-15')
+ expect_dates(wp_suc_parent, "2016-01-11", "2016-01-15")
# does not move backwards either because its parent did not move
- expect_dates(wp_suc_child, '2016-01-11', '2016-01-15')
+ expect_dates(wp_suc_child, "2016-01-11", "2016-01-15")
# Switching back to automatic scheduling will lead to the work package
# and all work packages that are dependent to be rescheduled again to
@@ -225,26 +225,26 @@ def expect_dates(work_package, start_date, due_date)
combined_field.toggle_scheduling_mode
combined_field.save!
- work_packages_page.expect_and_dismiss_toaster message: 'Successful update.'
+ work_packages_page.expect_and_dismiss_toaster message: "Successful update."
# Moved backwards again as the child determines the dates again
- expect_dates(wp, '2016-01-01', '2016-01-05')
+ expect_dates(wp, "2016-01-01", "2016-01-05")
expect(wp.schedule_manually).to be_falsey
# Had not been moved in the first place
- expect_dates(wp_child, '2016-01-01', '2016-01-05')
+ expect_dates(wp_child, "2016-01-01", "2016-01-05")
# As the child now again takes up the same time interval as the grandchild,
# the interval is shortened again.
- expect_dates(wp_parent, '2016-01-01', '2016-01-05')
+ expect_dates(wp_parent, "2016-01-01", "2016-01-05")
# does not move
- expect_dates(wp_suc, '2016-01-11', '2016-01-15')
+ expect_dates(wp_suc, "2016-01-11", "2016-01-15")
# does not move either
- expect_dates(wp_suc_parent, '2016-01-11', '2016-01-15')
+ expect_dates(wp_suc_parent, "2016-01-11", "2016-01-15")
# does not move either because its parent did not move
- expect_dates(wp_suc_child, '2016-01-11', '2016-01-15')
+ expect_dates(wp_suc_child, "2016-01-11", "2016-01-15")
end
end
diff --git a/spec/features/work_packages/select/select_query_spec.rb b/spec/features/work_packages/select/select_query_spec.rb
index aacfe9d38943..202d1dcaa52f 100644
--- a/spec/features/work_packages/select/select_query_spec.rb
+++ b/spec/features/work_packages/select/select_query_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/work_packages/work_packages_page'
+require "spec_helper"
+require "features/work_packages/work_packages_page"
-RSpec.describe 'Query selection' do
- let(:project) { create(:project, identifier: 'test_project', public: false) }
+RSpec.describe "Query selection" do
+ let(:project) { create(:project, identifier: "test_project", public: false) }
let(:role) { create(:project_role, permissions: [:view_work_packages]) }
let(:current_user) do
create(:user, member_with_roles: { project => role })
@@ -43,8 +43,8 @@
let(:query) do
build(:query, project:, public: true).tap do |query|
query.filters.clear
- query.add_filter('assigned_to_id', '=', ['me'])
- query.add_filter('done_ratio', '>=', [10])
+ query.add_filter("assigned_to_id", "=", ["me"])
+ query.add_filter("done_ratio", ">=", [10])
query.save!
create(:view_work_packages_table,
query:)
@@ -61,35 +61,35 @@
login_as(current_user)
end
- context 'default view, without a query selected' do
+ context "default view, without a query selected" do
before do
work_packages_page.visit_index
filters.open
end
- it 'shows the default (status) filter', :js do
+ it "shows the default (status) filter", :js do
filters.expect_filter_count 1
- filters.expect_filter_by 'Status', 'open', nil
+ filters.expect_filter_by "Status", "open", nil
end
end
- context 'when a query is selected' do
+ context "when a query is selected" do
before do
query
work_packages_page.select_query query
end
- it 'shows the saved filters', :js do
+ it "shows the saved filters", :js do
filters.open
- filters.expect_filter_by 'Assignee', 'is (OR)', ['me']
- filters.expect_filter_by 'Percent Complete', '>=', ['10'], 'percentageDone'
+ filters.expect_filter_by "Assignee", "is (OR)", ["me"]
+ filters.expect_filter_by "Percent Complete", ">=", ["10"], "percentageDone"
- expect(page).to have_css("#{test_selector('wp-filter-button')} .badge", text: '2')
+ expect(page).to have_css("#{test_selector('wp-filter-button')} .badge", text: "2")
end
end
- context 'when the selected query is changed' do
+ context "when the selected query is changed" do
let(:query2) do
create(:query_with_view_work_packages_table,
project:,
@@ -103,10 +103,10 @@
work_packages_page.select_query query
end
- it 'updates the page upon query switching', :js do
+ it "updates the page upon query switching", :js do
wp_page.expect_title query.name, editable: false
- find('.op-sidemenu--item-action', text: query2.name).click
+ find(".op-sidemenu--item-action", text: query2.name).click
end
end
end
diff --git a/spec/features/work_packages/select/select_work_package_row_spec.rb b/spec/features/work_packages/select/select_work_package_row_spec.rb
index 1be14e379003..054bcebac989 100644
--- a/spec/features/work_packages/select/select_work_package_row_spec.rb
+++ b/spec/features/work_packages/select/select_work_package_row_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Select work package row', :js, :selenium do
+RSpec.describe "Select work package row", :js, :selenium do
let(:user) { create(:admin) }
let(:project) { create(:project) }
let(:work_package_1) { create(:work_package, project:) }
@@ -36,7 +36,7 @@
let(:work_package_3) { create(:work_package, project:) }
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
- include_context 'work package table helpers'
+ include_context "work package table helpers"
before do
login_as(user)
@@ -103,18 +103,18 @@ def check_row_selection_state(row_index, state = true)
end
def check_all
- find('body').send_keys [:control, 'a']
+ find("body").send_keys [:control, "a"]
expect_row_checked(1, 2, 3)
- expect(page).to have_no_css '#work-package-context-menu'
+ expect(page).to have_no_css "#work-package-context-menu"
end
def uncheck_all
- find('body').send_keys [:control, 'd']
+ find("body").send_keys [:control, "d"]
expect_row_unchecked(1, 2, 3)
- expect(page).to have_no_css '#work-package-context-menu'
+ expect(page).to have_no_css "#work-package-context-menu"
end
- it 'handles selection flows' do
+ it "handles selection flows" do
###
# Keyboard shortcuts
###
@@ -198,30 +198,30 @@ def uncheck_all
expect_row_unchecked(2)
end
- describe 'opening work package full screen view' do
+ describe "opening work package full screen view" do
before do
wp_table.open_full_screen_by_doubleclick(work_package_1)
end
it do
- expect(page).to have_css('.work-packages--details--subject',
+ expect(page).to have_css(".work-packages--details--subject",
text: work_package_1.subject)
end
end
- describe 'opening last selected work package' do
+ describe "opening last selected work package" do
before do
select_work_package_row(2)
expect_row_checked(2)
end
it do
- find_by_id('work-packages-details-view-button').click
+ find_by_id("work-packages-details-view-button").click
split_wp = Pages::SplitWorkPackage.new(work_package_2)
split_wp.expect_attributes Subject: work_package_2.subject
- find_by_id('work-packages-details-view-button').click
- expect(page).to have_no_css('.work-packages--details')
+ find_by_id("work-packages-details-view-button").click
+ expect(page).to have_no_css(".work-packages--details")
end
end
end
diff --git a/spec/features/work_packages/share/access_spec.rb b/spec/features/work_packages/share/access_spec.rb
index 19ae9b24db20..a93e3c727feb 100644
--- a/spec/features/work_packages/share/access_spec.rb
+++ b/spec/features/work_packages/share/access_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Shared Work Package Access',
+RSpec.describe "Shared Work Package Access",
:js, :with_cuprite,
with_ee: %i[work_package_sharing] do
shared_let(:project) { create(:project_with_types) }
- shared_let(:work_package) { create(:work_package, project:, journal_notes: 'Hello!') }
+ shared_let(:work_package) { create(:work_package, project:, journal_notes: "Hello!") }
shared_let(:sharer) { create(:admin) }
- shared_let(:shared_with_user) { create(:user, firstname: 'Mean', lastname: 'Turkey') }
+ shared_let(:shared_with_user) { create(:user, firstname: "Mean", lastname: "Turkey") }
shared_let(:viewer_role) { create(:view_work_package_role) }
shared_let(:commenter_role) { create(:comment_work_package_role) }
@@ -47,8 +47,8 @@
let(:work_packages_page) { Pages::WorkPackagesTable.new(project) }
let(:work_package_page) { Pages::FullWorkPackage.new(work_package) }
let(:share_modal) { Components::WorkPackages::ShareModal.new(work_package) }
- let(:add_comment_button_selector) { '.work-packages--activity--add-comment' }
- let(:attach_files_button_selector) { 'op-attachments--upload-button' }
+ let(:add_comment_button_selector) { ".work-packages--activity--add-comment" }
+ let(:attach_files_button_selector) { "op-attachments--upload-button" }
specify "'View' role share access" do
using_session "sharer" do
@@ -59,17 +59,17 @@
work_package_page.click_share_button
share_modal.expect_open
- share_modal.invite_user!(shared_with_user, 'View')
+ share_modal.invite_user!(shared_with_user, "View")
share_modal.close
# Shared-with users with the "View" role CAN'T become assignees
assignee_field = work_package_page.edit_field(:assignee)
assignee_field.activate!
- results = assignee_field.autocomplete('Mean Turkey', select: false)
+ results = assignee_field.autocomplete("Mean Turkey", select: false)
wait_for_network_idle
expect(results)
- .to have_no_css('.ng-option', text: 'Mean Turkey', wait: 0)
+ .to have_no_css(".ng-option", text: "Mean Turkey", wait: 0)
assignee_field.cancel_by_escape
end
@@ -90,7 +90,7 @@
#
# Work Package is now visible
project_page.within_sidebar do
- click_link(I18n.t('label_work_package_plural'))
+ click_link(I18n.t("label_work_package_plural"))
end
work_packages_page.expect_work_package_listed(work_package)
work_package_page.visit!
@@ -113,8 +113,8 @@
end
# And so is viewing and uploading attachments
- work_package_page.switch_to_tab(tab: 'Files')
- work_package_page.expect_tab('Files')
+ work_package_page.switch_to_tab(tab: "Files")
+ work_package_page.expect_tab("Files")
work_package_page.within_active_tab do
expect(page)
.not_to have_test_selector(attach_files_button_selector)
@@ -131,7 +131,7 @@
work_package_page.click_share_button
share_modal.expect_open
- share_modal.invite_user!(shared_with_user, 'Comment')
+ share_modal.invite_user!(shared_with_user, "Comment")
share_modal.close
# TODO: This is currently expected failing behavior.
@@ -164,7 +164,7 @@
#
# Work Package is now visible
project_page.within_sidebar do
- click_link(I18n.t('label_work_package_plural'))
+ click_link(I18n.t("label_work_package_plural"))
end
work_packages_page.expect_work_package_listed(work_package)
work_package_page.visit!
@@ -180,7 +180,7 @@
end
# Spent time is visible and loggable
- SpentTimeEditField.new(page, 'spentTime')
+ SpentTimeEditField.new(page, "spentTime")
.time_log_icon_visible(true)
work_package_page.ensure_page_loaded # waits for activity section to be ready
@@ -191,8 +191,8 @@
end
# Attachments are uploadable
- work_package_page.switch_to_tab(tab: 'Files')
- work_package_page.expect_tab('Files')
+ work_package_page.switch_to_tab(tab: "Files")
+ work_package_page.expect_tab("Files")
work_package_page.within_active_tab do
expect(page)
.to have_test_selector(attach_files_button_selector)
@@ -209,7 +209,7 @@
work_package_page.click_share_button
share_modal.expect_open
- share_modal.invite_user!(shared_with_user, 'Edit')
+ share_modal.invite_user!(shared_with_user, "Edit")
share_modal.close
@@ -243,7 +243,7 @@
#
# Work Package is now visible
project_page.within_sidebar do
- click_link(I18n.t('label_work_package_plural'))
+ click_link(I18n.t("label_work_package_plural"))
end
work_packages_page.expect_work_package_listed(work_package)
work_package_page.visit!
@@ -264,7 +264,7 @@
end
# Spent time is visible and loggable
- SpentTimeEditField.new(page, 'spentTime')
+ SpentTimeEditField.new(page, "spentTime")
.time_log_icon_visible(true)
work_package_page.ensure_page_loaded # waits for activity section to be ready
@@ -275,8 +275,8 @@
end
# Attachments are uploadable
- work_package_page.switch_to_tab(tab: 'Files')
- work_package_page.expect_tab('Files')
+ work_package_page.switch_to_tab(tab: "Files")
+ work_package_page.expect_tab("Files")
work_package_page.within_active_tab do
expect(page)
.to have_test_selector(attach_files_button_selector)
diff --git a/spec/features/work_packages/share/bulk_sharing_spec.rb b/spec/features/work_packages/share/bulk_sharing_spec.rb
index 71e241f4a223..d57b066274d8 100644
--- a/spec/features/work_packages/share/bulk_sharing_spec.rb
+++ b/spec/features/work_packages/share/bulk_sharing_spec.rb
@@ -28,9 +28,9 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work Packages', 'Bulk Sharing',
+RSpec.describe "Work Packages", "Bulk Sharing",
:js, :with_cuprite,
with_ee: %i[work_package_sharing] do
shared_let(:view_work_package_role) { create(:view_work_package_role) }
@@ -48,16 +48,16 @@
view_shared_work_packages])
end
- shared_let(:sharer) { create(:user, firstname: 'Sharer', lastname: 'User') }
- shared_let(:viewer) { create(:user, firstname: 'Viewer', lastname: 'User') }
+ shared_let(:sharer) { create(:user, firstname: "Sharer", lastname: "User") }
+ shared_let(:viewer) { create(:user, firstname: "Viewer", lastname: "User") }
shared_let(:project) do
create(:project, members: { sharer => [sharer_role], viewer => [viewer_role] })
end
- shared_let(:dinesh) { create(:user, firstname: 'Dinesh', lastname: 'Chugtai') }
- shared_let(:gilfoyle) { create(:user, firstname: 'Bertram', lastname: 'Gilfoyle') }
- shared_let(:richard) { create(:user, firstname: 'Richard', lastname: 'Hendricks') }
+ shared_let(:dinesh) { create(:user, firstname: "Dinesh", lastname: "Chugtai") }
+ shared_let(:gilfoyle) { create(:user, firstname: "Bertram", lastname: "Gilfoyle") }
+ shared_let(:richard) { create(:user, firstname: "Richard", lastname: "Hendricks") }
shared_let(:work_package) do
create(:work_package, project:) do |wp|
@@ -70,10 +70,10 @@
let(:work_package_page) { Pages::FullWorkPackage.new(work_package) }
let(:share_modal) { Components::WorkPackages::ShareModal.new(work_package) }
- context 'when having share permission' do
+ context "when having share permission" do
current_user { sharer }
- it 'allows administrating shares in bulk' do
+ it "allows administrating shares in bulk" do
work_package_page.visit!
work_package_page.click_share_button
@@ -92,7 +92,7 @@
share_modal.expect_select_all_untoggled
# Available now
share_modal.expect_bulk_actions_available
- share_modal.expect_bulk_update_label('View')
+ share_modal.expect_bulk_update_label("View")
# Toggling all selects all
share_modal.toggle_select_all
@@ -100,7 +100,7 @@
share_modal.expect_selected_count_of(3)
share_modal.expect_select_all_toggled
share_modal.expect_bulk_actions_available
- share_modal.expect_bulk_update_label('Mixed')
+ share_modal.expect_bulk_update_label("Mixed")
# Deselecting one individually
share_modal.deselect_shares(richard)
@@ -108,7 +108,7 @@
share_modal.expect_selected_count_of(2)
share_modal.expect_select_all_untoggled
share_modal.expect_bulk_actions_available
- share_modal.expect_bulk_update_label('Mixed')
+ share_modal.expect_bulk_update_label("Mixed")
# Re-selecting the missing share
share_modal.select_shares(richard)
@@ -116,7 +116,7 @@
share_modal.expect_selected_count_of(3)
share_modal.expect_select_all_toggled
share_modal.expect_bulk_actions_available
- share_modal.expect_bulk_update_label('Mixed')
+ share_modal.expect_bulk_update_label("Mixed")
# De-selecting all
share_modal.toggle_select_all
@@ -133,7 +133,7 @@
share_modal.expect_select_all_toggled
# Available again
share_modal.expect_bulk_actions_available
- share_modal.expect_bulk_update_label('Mixed')
+ share_modal.expect_bulk_update_label("Mixed")
# De-selecting all individually
share_modal.deselect_shares(richard, dinesh, gilfoyle)
@@ -147,7 +147,7 @@
share_modal.select_shares(richard, dinesh)
share_modal.expect_selected_count_of(2)
share_modal.expect_select_all_untoggled
- share_modal.expect_bulk_update_label('Mixed')
+ share_modal.expect_bulk_update_label("Mixed")
share_modal.remove_user(gilfoyle)
share_modal.expect_not_shared_with(gilfoyle)
@@ -155,35 +155,35 @@
share_modal.expect_selected(richard, dinesh)
share_modal.expect_selected_count_of(2)
share_modal.expect_select_all_toggled
- share_modal.expect_bulk_update_label('Mixed')
+ share_modal.expect_bulk_update_label("Mixed")
- share_modal.invite_user(gilfoyle, 'Comment')
+ share_modal.invite_user(gilfoyle, "Comment")
share_modal.expect_shared_with(gilfoyle)
share_modal.expect_selected(richard, dinesh)
share_modal.expect_selected_count_of(2)
share_modal.expect_select_all_untoggled
- share_modal.expect_bulk_update_label('Mixed')
+ share_modal.expect_bulk_update_label("Mixed")
end
aggregate_failures "Preserving selected states when performing individual updates" do
- share_modal.change_role(gilfoyle, 'View')
- share_modal.expect_shared_with(gilfoyle, 'View')
+ share_modal.change_role(gilfoyle, "View")
+ share_modal.expect_shared_with(gilfoyle, "View")
share_modal.expect_selected(richard, dinesh)
share_modal.expect_selected_count_of(2)
share_modal.expect_select_all_untoggled
- share_modal.expect_bulk_update_label('Mixed')
+ share_modal.expect_bulk_update_label("Mixed")
share_modal.toggle_select_all
share_modal.expect_selected_count_of(3)
share_modal.expect_select_all_toggled
- share_modal.expect_bulk_update_label('Mixed')
+ share_modal.expect_bulk_update_label("Mixed")
- share_modal.change_role(gilfoyle, 'Edit')
- share_modal.expect_shared_with(gilfoyle, 'Edit')
+ share_modal.change_role(gilfoyle, "Edit")
+ share_modal.expect_shared_with(gilfoyle, "Edit")
share_modal.expect_selected_count_of(3)
share_modal.expect_select_all_toggled
- share_modal.expect_bulk_update_label('Mixed')
+ share_modal.expect_bulk_update_label("Mixed")
end
# Reset
@@ -212,37 +212,37 @@
end
# Re-populate
- share_modal.invite_user(richard, 'View')
+ share_modal.invite_user(richard, "View")
share_modal.expect_shared_with(richard)
- share_modal.invite_user(dinesh, 'Comment')
+ share_modal.invite_user(dinesh, "Comment")
share_modal.expect_shared_with(dinesh)
- aggregate_failures 'Bulk updating' do
+ aggregate_failures "Bulk updating" do
share_modal.select_shares(richard)
share_modal.expect_selected(richard)
share_modal.expect_selected_count_of(1)
- share_modal.expect_bulk_update_label('View')
+ share_modal.expect_bulk_update_label("View")
- share_modal.bulk_update('Edit')
+ share_modal.bulk_update("Edit")
- share_modal.expect_shared_with(richard, 'Edit')
- share_modal.expect_shared_with(dinesh, 'Comment')
+ share_modal.expect_shared_with(richard, "Edit")
+ share_modal.expect_shared_with(dinesh, "Comment")
share_modal.expect_selected(richard)
share_modal.expect_selected_count_of(1)
- share_modal.expect_bulk_update_label('Edit')
+ share_modal.expect_bulk_update_label("Edit")
share_modal.select_shares(richard, dinesh)
share_modal.expect_selected(richard, dinesh)
share_modal.expect_selected_count_of(2)
- share_modal.expect_bulk_update_label('Mixed')
+ share_modal.expect_bulk_update_label("Mixed")
- share_modal.bulk_update('View')
+ share_modal.bulk_update("View")
- share_modal.expect_shared_with(richard, 'View')
- share_modal.expect_shared_with(dinesh, 'View')
+ share_modal.expect_shared_with(richard, "View")
+ share_modal.expect_shared_with(dinesh, "View")
share_modal.expect_selected(richard, dinesh)
share_modal.expect_selected_count_of(2)
- share_modal.expect_bulk_update_label('View')
+ share_modal.expect_bulk_update_label("View")
share_modal.toggle_select_all
share_modal.expect_deselected(richard, dinesh)
@@ -273,8 +273,8 @@
share_modal.expect_select_all_not_available
share_modal.expect_bulk_actions_not_available
- share_modal.invite_user(richard, 'View')
- share_modal.expect_shared_with(richard, 'View')
+ share_modal.invite_user(richard, "View")
+ share_modal.expect_shared_with(richard, "View")
share_modal.expect_shared_count_of(2)
share_modal.expect_select_all_available
@@ -282,10 +282,10 @@
end
end
- context 'without share permission' do
+ context "without share permission" do
current_user { viewer }
- it 'does not allow bulk sharing' do
+ it "does not allow bulk sharing" do
work_package_page.visit!
work_package_page.click_share_button
diff --git a/spec/features/work_packages/share/enterprise_restriction_spec.rb b/spec/features/work_packages/share/enterprise_restriction_spec.rb
index 31afb836d9f2..8bede4e0c1b6 100644
--- a/spec/features/work_packages/share/enterprise_restriction_spec.rb
+++ b/spec/features/work_packages/share/enterprise_restriction_spec.rb
@@ -28,9 +28,9 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'rails_helper'
+require "rails_helper"
-RSpec.describe 'Work Package Sharing Enterprise Restriction', :js, :with_cuprite do
+RSpec.describe "Work Package Sharing Enterprise Restriction", :js, :with_cuprite do
shared_let(:view_work_package_role) { create(:view_work_package_role) }
shared_let(:comment_work_package_role) { create(:comment_work_package_role) }
shared_let(:edit_work_package_role) { create(:edit_work_package_role) }
@@ -41,7 +41,7 @@
share_work_packages])
end
- shared_let(:sharer) { create(:user, firstname: 'Sharer', lastname: 'User') }
+ shared_let(:sharer) { create(:user, firstname: "Sharer", lastname: "User") }
shared_let(:project) { create(:project, members: { sharer => [sharer_role] }) }
shared_let(:work_package) { create(:work_package, project:) }
@@ -58,14 +58,14 @@
share_modal.expect_open
end
- context 'without an enterprise token' do
- it 'renders an upsale banner' do
+ context "without an enterprise token" do
+ it "renders an upsale banner" do
share_modal.expect_upsale_banner
end
end
- context 'with an enterprise token', with_ee: %i[work_package_sharing] do
- it 'renders the share modal' do
+ context "with an enterprise token", with_ee: %i[work_package_sharing] do
+ it "renders the share modal" do
share_modal.expect_blankslate
end
end
diff --git a/spec/features/work_packages/share/filter_spec.rb b/spec/features/work_packages/share/filter_spec.rb
index 4dadacce50c2..c6e7e81e6a12 100644
--- a/spec/features/work_packages/share/filter_spec.rb
+++ b/spec/features/work_packages/share/filter_spec.rb
@@ -28,19 +28,19 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package sharing',
+RSpec.describe "Work package sharing",
:js, :with_cuprite,
with_ee: %i[work_package_sharing] do
shared_let(:view_work_package_role) { create(:view_work_package_role) }
shared_let(:comment_work_package_role) { create(:comment_work_package_role) }
shared_let(:edit_work_package_role) { create(:edit_work_package_role) }
- shared_let(:project_user) { create(:user, firstname: 'Anton') }
- shared_let(:project_user2) { create(:user, firstname: 'Bertha') }
- shared_let(:inherited_project_user) { create(:user, firstname: 'Caesar') }
- shared_let(:non_project_user) { create(:user, firstname: 'Dora') }
+ shared_let(:project_user) { create(:user, firstname: "Anton") }
+ shared_let(:project_user2) { create(:user, firstname: "Bertha") }
+ shared_let(:inherited_project_user) { create(:user, firstname: "Caesar") }
+ shared_let(:non_project_user) { create(:user, firstname: "Dora") }
shared_let(:shared_project_group) { create(:group, members: [project_user, inherited_project_user]) }
shared_let(:shared_non_project_group) { create(:group, members: [project_user2, non_project_user]) }
@@ -73,35 +73,35 @@
let(:work_package_page) { Pages::FullWorkPackage.new(work_package) }
let(:share_modal) { Components::WorkPackages::ShareModal.new(work_package) }
- current_user { create(:admin, firstname: 'Signed in', lastname: 'User') }
+ current_user { create(:admin, firstname: "Signed in", lastname: "User") }
- context 'when having share permission' do
+ context "when having share permission" do
before do
work_package_page.visit!
work_package_page.click_share_button
end
- it 'allows to filter for the type' do
+ it "allows to filter for the type" do
share_modal.expect_open
share_modal.expect_shared_count_of(6)
# Filter for: project members (users only)
- share_modal.filter('type', I18n.t('work_package.sharing.filter.project_member'))
+ share_modal.filter("type", I18n.t("work_package.sharing.filter.project_member"))
share_modal.expect_shared_count_of(3)
- share_modal.expect_shared_with(project_user, 'View')
- share_modal.expect_shared_with(project_user2, 'Comment')
+ share_modal.expect_shared_with(project_user, "View")
+ share_modal.expect_shared_with(project_user2, "Comment")
# The non-project user is listed because it is part of the project group and thus the membership is inherited.
- share_modal.expect_shared_with(inherited_project_user, 'Edit')
+ share_modal.expect_shared_with(inherited_project_user, "Edit")
share_modal.expect_not_shared_with(non_project_user)
share_modal.expect_not_shared_with(shared_project_group)
share_modal.expect_not_shared_with(shared_non_project_group)
# Filter for: non-project members (users only)
- share_modal.filter('type', I18n.t('work_package.sharing.filter.not_project_member'))
+ share_modal.filter("type", I18n.t("work_package.sharing.filter.not_project_member"))
share_modal.expect_shared_count_of(1)
- share_modal.expect_shared_with(non_project_user, 'Edit')
+ share_modal.expect_shared_with(non_project_user, "Edit")
share_modal.expect_not_shared_with(inherited_project_user)
share_modal.expect_not_shared_with(project_user)
share_modal.expect_not_shared_with(project_user2)
@@ -109,10 +109,10 @@
share_modal.expect_not_shared_with(shared_non_project_group)
# Filter for: project members (groups only)
- share_modal.filter('type', I18n.t('work_package.sharing.filter.project_group'))
+ share_modal.filter("type", I18n.t("work_package.sharing.filter.project_group"))
share_modal.expect_shared_count_of(1)
- share_modal.expect_shared_with(shared_project_group, 'Edit')
+ share_modal.expect_shared_with(shared_project_group, "Edit")
share_modal.expect_not_shared_with(project_user)
share_modal.expect_not_shared_with(project_user2)
share_modal.expect_not_shared_with(inherited_project_user)
@@ -120,10 +120,10 @@
share_modal.expect_not_shared_with(shared_non_project_group)
# Filter for: non-project members (groups only)
- share_modal.filter('type', I18n.t('work_package.sharing.filter.not_project_group'))
+ share_modal.filter("type", I18n.t("work_package.sharing.filter.not_project_group"))
share_modal.expect_shared_count_of(1)
- share_modal.expect_shared_with(shared_non_project_group, 'View')
+ share_modal.expect_shared_with(shared_non_project_group, "View")
share_modal.expect_not_shared_with(project_user)
share_modal.expect_not_shared_with(project_user2)
share_modal.expect_not_shared_with(inherited_project_user)
@@ -131,48 +131,48 @@
share_modal.expect_not_shared_with(shared_project_group)
# Clicking again on the filter will reset it
- share_modal.filter('type', I18n.t('work_package.sharing.filter.not_project_group'))
+ share_modal.filter("type", I18n.t("work_package.sharing.filter.not_project_group"))
share_modal.expect_shared_count_of(6)
- share_modal.expect_shared_with(project_user, 'View')
- share_modal.expect_shared_with(project_user2, 'Comment')
- share_modal.expect_shared_with(inherited_project_user, 'Edit')
- share_modal.expect_shared_with(non_project_user, 'Edit')
- share_modal.expect_shared_with(shared_project_group, 'Edit')
- share_modal.expect_shared_with(shared_non_project_group, 'View')
+ share_modal.expect_shared_with(project_user, "View")
+ share_modal.expect_shared_with(project_user2, "Comment")
+ share_modal.expect_shared_with(inherited_project_user, "Edit")
+ share_modal.expect_shared_with(non_project_user, "Edit")
+ share_modal.expect_shared_with(shared_project_group, "Edit")
+ share_modal.expect_shared_with(shared_non_project_group, "View")
end
- it 'allows to filter for the role' do
+ it "allows to filter for the role" do
share_modal.expect_open
share_modal.expect_shared_count_of(6)
# Filter for: all principals with Edit permission
- share_modal.filter('role', I18n.t('work_package.sharing.permissions.edit'))
+ share_modal.filter("role", I18n.t("work_package.sharing.permissions.edit"))
share_modal.expect_shared_count_of(3)
- share_modal.expect_shared_with(inherited_project_user, 'Edit')
- share_modal.expect_shared_with(non_project_user, 'Edit')
- share_modal.expect_shared_with(shared_project_group, 'Edit')
+ share_modal.expect_shared_with(inherited_project_user, "Edit")
+ share_modal.expect_shared_with(non_project_user, "Edit")
+ share_modal.expect_shared_with(shared_project_group, "Edit")
share_modal.expect_not_shared_with(project_user)
share_modal.expect_not_shared_with(project_user2)
share_modal.expect_not_shared_with(shared_non_project_group)
# Filter for: all principals with View permission
- share_modal.filter('role', I18n.t('work_package.sharing.permissions.view'))
+ share_modal.filter("role", I18n.t("work_package.sharing.permissions.view"))
share_modal.expect_shared_count_of(2)
- share_modal.expect_shared_with(project_user, 'View')
- share_modal.expect_shared_with(shared_non_project_group, 'View')
+ share_modal.expect_shared_with(project_user, "View")
+ share_modal.expect_shared_with(shared_non_project_group, "View")
share_modal.expect_not_shared_with(project_user2)
share_modal.expect_not_shared_with(inherited_project_user)
share_modal.expect_not_shared_with(non_project_user)
share_modal.expect_not_shared_with(shared_project_group)
# Filter for: all principals with Comment permission
- share_modal.filter('role', I18n.t('work_package.sharing.permissions.comment'))
+ share_modal.filter("role", I18n.t("work_package.sharing.permissions.comment"))
share_modal.expect_shared_count_of(1)
- share_modal.expect_shared_with(project_user2, 'Comment')
+ share_modal.expect_shared_with(project_user2, "Comment")
share_modal.expect_not_shared_with(project_user)
share_modal.expect_not_shared_with(inherited_project_user)
share_modal.expect_not_shared_with(non_project_user)
@@ -180,29 +180,29 @@
share_modal.expect_not_shared_with(shared_non_project_group)
# Clicking again on the filter will reset it
- share_modal.filter('role', I18n.t('work_package.sharing.permissions.comment'))
+ share_modal.filter("role", I18n.t("work_package.sharing.permissions.comment"))
share_modal.expect_shared_count_of(6)
- share_modal.expect_shared_with(project_user, 'View')
- share_modal.expect_shared_with(project_user2, 'Comment')
- share_modal.expect_shared_with(inherited_project_user, 'Edit')
- share_modal.expect_shared_with(non_project_user, 'Edit')
- share_modal.expect_shared_with(shared_project_group, 'Edit')
- share_modal.expect_shared_with(shared_non_project_group, 'View')
+ share_modal.expect_shared_with(project_user, "View")
+ share_modal.expect_shared_with(project_user2, "Comment")
+ share_modal.expect_shared_with(inherited_project_user, "Edit")
+ share_modal.expect_shared_with(non_project_user, "Edit")
+ share_modal.expect_shared_with(shared_project_group, "Edit")
+ share_modal.expect_shared_with(shared_non_project_group, "View")
end
- it 'allows to filter for role and type at the same time' do
+ it "allows to filter for role and type at the same time" do
share_modal.expect_open
share_modal.expect_shared_count_of(6)
# Filter for: all principals with View permission
# role: view
# type: none
- share_modal.filter('role', I18n.t('work_package.sharing.permissions.view'))
+ share_modal.filter("role", I18n.t("work_package.sharing.permissions.view"))
share_modal.expect_shared_count_of(2)
- share_modal.expect_shared_with(project_user, 'View')
- share_modal.expect_shared_with(shared_non_project_group, 'View')
+ share_modal.expect_shared_with(project_user, "View")
+ share_modal.expect_shared_with(shared_non_project_group, "View")
share_modal.expect_not_shared_with(project_user2)
share_modal.expect_not_shared_with(inherited_project_user)
share_modal.expect_not_shared_with(non_project_user)
@@ -211,10 +211,10 @@
# Additional filter for: project members (users only)
# role: view
# type: project members (users only)
- share_modal.filter('type', I18n.t('work_package.sharing.filter.project_member'))
+ share_modal.filter("type", I18n.t("work_package.sharing.filter.project_member"))
share_modal.expect_shared_count_of(1)
- share_modal.expect_shared_with(project_user, 'View')
+ share_modal.expect_shared_with(project_user, "View")
share_modal.expect_not_shared_with(project_user2)
share_modal.expect_not_shared_with(inherited_project_user)
share_modal.expect_not_shared_with(non_project_user)
@@ -224,10 +224,10 @@
# Change type filter to: project members (groups only)
# role: view
# type: non-project members (groups only)
- share_modal.filter('type', I18n.t('work_package.sharing.filter.not_project_group'))
+ share_modal.filter("type", I18n.t("work_package.sharing.filter.not_project_group"))
share_modal.expect_shared_count_of(1)
- share_modal.expect_shared_with(shared_non_project_group, 'View')
+ share_modal.expect_shared_with(shared_non_project_group, "View")
share_modal.expect_not_shared_with(project_user)
share_modal.expect_not_shared_with(project_user2)
share_modal.expect_not_shared_with(inherited_project_user)
@@ -237,10 +237,10 @@
# Reset role filter
# role: none
# type: non-project members (groups only)
- share_modal.filter('role', I18n.t('work_package.sharing.permissions.view'))
+ share_modal.filter("role", I18n.t("work_package.sharing.permissions.view"))
share_modal.expect_shared_count_of(1)
- share_modal.expect_shared_with(shared_non_project_group, 'View')
+ share_modal.expect_shared_with(shared_non_project_group, "View")
share_modal.expect_not_shared_with(project_user)
share_modal.expect_not_shared_with(project_user2)
share_modal.expect_not_shared_with(inherited_project_user)
@@ -250,22 +250,22 @@
# Reset type filter
# role: none
# type: none
- share_modal.filter('type', I18n.t('work_package.sharing.filter.not_project_group'))
+ share_modal.filter("type", I18n.t("work_package.sharing.filter.not_project_group"))
share_modal.expect_shared_count_of(6)
- share_modal.expect_shared_with(project_user, 'View')
- share_modal.expect_shared_with(project_user2, 'Comment')
- share_modal.expect_shared_with(inherited_project_user, 'Edit')
- share_modal.expect_shared_with(non_project_user, 'Edit')
- share_modal.expect_shared_with(shared_project_group, 'Edit')
- share_modal.expect_shared_with(shared_non_project_group, 'View')
+ share_modal.expect_shared_with(project_user, "View")
+ share_modal.expect_shared_with(project_user2, "Comment")
+ share_modal.expect_shared_with(inherited_project_user, "Edit")
+ share_modal.expect_shared_with(non_project_user, "Edit")
+ share_modal.expect_shared_with(shared_project_group, "Edit")
+ share_modal.expect_shared_with(shared_non_project_group, "View")
end
- context 'and there are no matching results for my filter' do
+ context "and there are no matching results for my filter" do
it 'does not check the "toggle all" checkbox' do
share_modal.expect_open
- share_modal.filter('type', I18n.t('work_package.sharing.filter.not_project_member'))
- share_modal.filter('role', I18n.t('work_package.sharing.permissions.view'))
+ share_modal.filter("type", I18n.t("work_package.sharing.filter.not_project_member"))
+ share_modal.filter("role", I18n.t("work_package.sharing.permissions.view"))
share_modal.expect_empty_search_blankslate
share_modal.expect_shared_count_of(0)
@@ -273,14 +273,14 @@
end
end
- it 'only displays shares that match the current set of applied filters' do
+ it "only displays shares that match the current set of applied filters" do
share_modal.expect_open
share_modal.toggle_select_all
share_modal.bulk_update("View")
share_modal.toggle_select_all
- share_modal.filter('role', "View")
+ share_modal.filter("role", "View")
share_modal.expect_shared_with(project_user)
share_modal.expect_shared_with(project_user2)
@@ -290,7 +290,7 @@
share_modal.expect_shared_with(shared_non_project_group)
share_modal.change_role(project_user, "Comment")
- share_modal.filter('role', "Comment")
+ share_modal.filter("role", "Comment")
share_modal.expect_shared_with(project_user, "Comment")
share_modal.expect_not_shared_with(project_user2)
share_modal.expect_not_shared_with(inherited_project_user)
@@ -298,22 +298,22 @@
share_modal.expect_not_shared_with(shared_project_group)
share_modal.expect_not_shared_with(shared_non_project_group)
- share_modal.filter('role', "Edit")
+ share_modal.filter("role", "Edit")
share_modal.expect_empty_search_blankslate
end
- context 'when filtering for a specific role' do
+ context "when filtering for a specific role" do
before do
share_modal.expect_open
- share_modal.filter('role', "View")
+ share_modal.filter("role", "View")
end
- context 'and a share from the filtered list is subsequently updated' do
+ context "and a share from the filtered list is subsequently updated" do
before do
share_modal.change_role(project_user, "Comment")
end
- it 'removes the updated share from the list' do
+ it "removes the updated share from the list" do
share_modal.expect_not_shared_with(project_user)
end
end
diff --git a/spec/features/work_packages/share/multi_invite_spec.rb b/spec/features/work_packages/share/multi_invite_spec.rb
index 588a0cd8a88b..0b6f77f1e687 100644
--- a/spec/features/work_packages/share/multi_invite_spec.rb
+++ b/spec/features/work_packages/share/multi_invite_spec.rb
@@ -28,18 +28,18 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package sharing',
+RSpec.describe "Work package sharing",
:js, :with_cuprite,
with_ee: %i[work_package_sharing] do
shared_let(:view_work_package_role) { create(:view_work_package_role) }
shared_let(:comment_work_package_role) { create(:comment_work_package_role) }
shared_let(:edit_work_package_role) { create(:edit_work_package_role) }
- shared_let(:not_shared_yet_with_user) { create(:user, firstname: 'Not shared Yet', lastname: 'User') }
- shared_let(:another_not_shared_yet_with_user) { create(:user, firstname: 'Another not yet shared', lastname: 'User') }
- shared_let(:richard) { create(:user, firstname: 'Richard', lastname: 'Hendricks') }
+ shared_let(:not_shared_yet_with_user) { create(:user, firstname: "Not shared Yet", lastname: "User") }
+ shared_let(:another_not_shared_yet_with_user) { create(:user, firstname: "Another not yet shared", lastname: "User") }
+ shared_let(:richard) { create(:user, firstname: "Richard", lastname: "Hendricks") }
shared_let(:not_shared_yet_with_group) { create(:group, members: [richard]) }
shared_let(:empty_group) { create(:group, members: []) }
@@ -64,7 +64,7 @@
let(:work_package_page) { Pages::FullWorkPackage.new(work_package) }
let(:share_modal) { Components::WorkPackages::ShareModal.new(work_package) }
- current_user { create(:user, firstname: 'Signed in', lastname: 'User') }
+ current_user { create(:user, firstname: "Signed in", lastname: "User") }
def shared_principals
Principal.where(id: Member.of_work_package(work_package).select(:user_id))
@@ -74,8 +74,8 @@ def inherited_member_roles(group:)
MemberRole.where(inherited_from: MemberRole.where(member_id: group.memberships))
end
- context 'when having share permission' do
- it 'allows seeing and administrating sharing' do
+ context "when having share permission" do
+ it "allows seeing and administrating sharing" do
work_package_page.visit!
# Clicking on the share button opens a modal which lists all of the users a work package
@@ -87,12 +87,12 @@ def inherited_member_roles(group:)
share_modal.expect_shared_count_of(1)
# Inviting multiple users at once
- share_modal.invite_users([not_shared_yet_with_user, another_not_shared_yet_with_user], 'Edit')
+ share_modal.invite_users([not_shared_yet_with_user, another_not_shared_yet_with_user], "Edit")
share_modal.expect_shared_count_of(3)
- share_modal.expect_shared_with(not_shared_yet_with_user, 'Edit', position: 1)
- share_modal.expect_shared_with(another_not_shared_yet_with_user, 'Edit', position: 2)
+ share_modal.expect_shared_with(not_shared_yet_with_user, "Edit", position: 1)
+ share_modal.expect_shared_with(another_not_shared_yet_with_user, "Edit", position: 2)
# They can be removed again
share_modal.remove_user(not_shared_yet_with_user)
@@ -103,12 +103,12 @@ def inherited_member_roles(group:)
share_modal.expect_shared_count_of(1)
# Groups can be added simultaneously as well
- share_modal.invite_users([not_shared_yet_with_group, empty_group], 'Comment')
+ share_modal.invite_users([not_shared_yet_with_group, empty_group], "Comment")
share_modal.expect_shared_count_of(3)
- share_modal.expect_shared_with(not_shared_yet_with_group, 'Comment', position: 1)
- share_modal.expect_shared_with(empty_group, 'Comment', position: 2)
+ share_modal.expect_shared_with(not_shared_yet_with_group, "Comment", position: 1)
+ share_modal.expect_shared_with(empty_group, "Comment", position: 2)
# They can be removed again
share_modal.remove_user(not_shared_yet_with_group)
@@ -118,12 +118,12 @@ def inherited_member_roles(group:)
share_modal.expect_shared_count_of(1)
# We can also mix
- share_modal.invite_users([not_shared_yet_with_user, empty_group], 'View')
+ share_modal.invite_users([not_shared_yet_with_user, empty_group], "View")
share_modal.expect_shared_count_of(3)
- share_modal.expect_shared_with(not_shared_yet_with_user, 'View', position: 1)
- share_modal.expect_shared_with(empty_group, 'View', position: 2)
+ share_modal.expect_shared_with(not_shared_yet_with_user, "View", position: 1)
+ share_modal.expect_shared_with(empty_group, "View", position: 2)
# They can be removed again
share_modal.remove_user(not_shared_yet_with_user)
@@ -138,7 +138,7 @@ def inherited_member_roles(group:)
aggregate_failures "Re-opening the modal after changes performed" do
# This user preserved
- share_modal.expect_shared_with(richard, 'Edit', position: 1)
+ share_modal.expect_shared_with(richard, "Edit", position: 1)
# The users have been removed
share_modal.expect_not_shared_with(not_shared_yet_with_user)
@@ -153,7 +153,7 @@ def inherited_member_roles(group:)
end
end
- context 'when starting with no shares yet' do
+ context "when starting with no shares yet" do
let(:work_package) { create(:work_package, project:) }
let(:global_manager_user) { create(:user, global_permissions: %i[manage_user create_user]) }
let(:current_user) { global_manager_user }
@@ -163,18 +163,18 @@ def inherited_member_roles(group:)
work_package_page.click_share_button
end
- it 'allows adding multiple users and updates the modal correctly' do
+ it "allows adding multiple users and updates the modal correctly" do
share_modal.expect_open
share_modal.expect_blankslate
- share_modal.invite_users([not_shared_yet_with_user, another_not_shared_yet_with_user], 'Edit')
+ share_modal.invite_users([not_shared_yet_with_user, another_not_shared_yet_with_user], "Edit")
share_modal.expect_shared_count_of(2)
# Due to the exception of starting from a blankslate, the whole modal is re-rendered.
# Thus the principals are sorted alphabetically, and not by the time there were added
- share_modal.expect_shared_with(not_shared_yet_with_user, 'Edit', position: 2)
- share_modal.expect_shared_with(another_not_shared_yet_with_user, 'Edit', position: 1)
+ share_modal.expect_shared_with(not_shared_yet_with_user, "Edit", position: 2)
+ share_modal.expect_shared_with(another_not_shared_yet_with_user, "Edit", position: 1)
# They can be removed again
share_modal.remove_user(not_shared_yet_with_user)
@@ -186,11 +186,11 @@ def inherited_member_roles(group:)
end
end
- context 'when having global invite permission' do
+ context "when having global invite permission" do
let(:global_manager_user) { create(:user, global_permissions: %i[manage_user create_user]) }
let(:current_user) { global_manager_user }
- it 'allows creating multiple users at once' do
+ it "allows creating multiple users at once" do
work_package_page.visit!
work_package_page.click_share_button
@@ -198,7 +198,7 @@ def inherited_member_roles(group:)
share_modal.expect_shared_count_of(1)
# Invite two users that does not exist yet
- share_modal.invite_users(['hello@world.de', 'aloha@world.de'], 'Comment')
+ share_modal.invite_users(["hello@world.de", "aloha@world.de"], "Comment")
# New user is shown in the list of shares
share_modal.expect_shared_count_of(3)
@@ -206,20 +206,20 @@ def inherited_member_roles(group:)
# New user is created
new_users = User.last(2)
- share_modal.expect_shared_with(new_users[0], 'Comment', position: 1)
- share_modal.expect_shared_with(new_users[1], 'Comment', position: 2)
+ share_modal.expect_shared_with(new_users[0], "Comment", position: 1)
+ share_modal.expect_shared_with(new_users[1], "Comment", position: 2)
# The new users can be interacted with
- share_modal.change_role(new_users[0], 'View')
- share_modal.expect_shared_with(new_users[0], 'View', position: 1)
- share_modal.change_role(new_users[1], 'View')
- share_modal.expect_shared_with(new_users[1], 'View', position: 2)
+ share_modal.change_role(new_users[0], "View")
+ share_modal.expect_shared_with(new_users[0], "View", position: 1)
+ share_modal.change_role(new_users[1], "View")
+ share_modal.expect_shared_with(new_users[1], "View", position: 2)
share_modal.expect_shared_count_of(3)
# The new users can be updated simultaneously
- share_modal.invite_user(new_users, 'Edit')
- share_modal.expect_shared_with(new_users[0], 'Edit', position: 1)
- share_modal.expect_shared_with(new_users[1], 'Edit', position: 2)
+ share_modal.invite_user(new_users, "Edit")
+ share_modal.expect_shared_with(new_users[0], "Edit", position: 1)
+ share_modal.expect_shared_with(new_users[1], "Edit", position: 2)
share_modal.expect_shared_count_of(3)
# The new users can be deleted
@@ -230,7 +230,7 @@ def inherited_member_roles(group:)
share_modal.expect_shared_count_of(1)
end
- it 'allows sharing with an existing user and creating a new one at the same time' do
+ it "allows sharing with an existing user and creating a new one at the same time" do
work_package_page.visit!
work_package_page.click_share_button
@@ -241,9 +241,9 @@ def inherited_member_roles(group:)
share_modal.select_existing_user not_shared_yet_with_user
share_modal.select_not_existing_user_option "hello@world.de"
- share_modal.select_invite_role('View')
+ share_modal.select_invite_role("View")
within share_modal.modal_element do
- click_button 'Share'
+ click_button "Share"
end
# Two users are added
@@ -252,11 +252,11 @@ def inherited_member_roles(group:)
# New user is created
new_user = User.last
- share_modal.expect_shared_with(not_shared_yet_with_user, 'View', position: 1)
- share_modal.expect_shared_with(new_user, 'View', position: 2)
+ share_modal.expect_shared_with(not_shared_yet_with_user, "View", position: 1)
+ share_modal.expect_shared_with(new_user, "View", position: 2)
end
- context 'and an instance user limit' do
+ context "and an instance user limit" do
before do
allow(OpenProject::Enterprise).to receive_messages(
user_limit: 10,
@@ -264,7 +264,7 @@ def inherited_member_roles(group:)
)
end
- it 'shows a warning as soon as you reach the user limit' do
+ it "shows a warning as soon as you reach the user limit" do
work_package_page.visit!
work_package_page.click_share_button
diff --git a/spec/features/work_packages/share/notification_spec.rb b/spec/features/work_packages/share/notification_spec.rb
index adc4fd1ddfc9..dc5b39342181 100644
--- a/spec/features/work_packages/share/notification_spec.rb
+++ b/spec/features/work_packages/share/notification_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe "Notifications sent on shared work packages",
:js,
@@ -62,7 +62,7 @@
let(:center) { Pages::Notifications::Center.new }
let(:side_menu) { Components::Notifications::Sidemenu.new }
- describe 'notification for being mentioned' do
+ describe "notification for being mentioned" do
before do
# The notifications need to be created as a different user
# as they are otherwise swallowed to avoid self notification.
@@ -76,7 +76,7 @@
end
end
- it 'mentioned user receives a notification' do
+ it "mentioned user receives a notification" do
login_as(recipient)
visit home_path
@@ -88,13 +88,13 @@
center.expect_work_package_item notification_mentioned
- side_menu.click_item 'Mentioned'
+ side_menu.click_item "Mentioned"
side_menu.finished_loading
center.expect_work_package_item notification_mentioned
end
end
- describe 'notification for being shared with' do
+ describe "notification for being shared with" do
before do
# The notifications need to be created as a different user
# as they are otherwise swallowed to avoid self notification.
@@ -108,7 +108,7 @@
end
end
- it 'shared with user receives notification' do
+ it "shared with user receives notification" do
login_as(recipient)
visit home_path
@@ -120,7 +120,7 @@
center.expect_work_package_item notification_shared
- side_menu.click_item 'Shared'
+ side_menu.click_item "Shared"
side_menu.finished_loading
center.expect_work_package_item notification_shared
end
diff --git a/spec/features/work_packages/share/share_account_activation_spec.rb b/spec/features/work_packages/share/share_account_activation_spec.rb
index 16f53666892e..abbadf5e2041 100644
--- a/spec/features/work_packages/share/share_account_activation_spec.rb
+++ b/spec/features/work_packages/share/share_account_activation_spec.rb
@@ -28,13 +28,13 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package sharing invited users',
+RSpec.describe "Work package sharing invited users",
:js, :with_cuprite,
with_ee: %i[work_package_sharing] do
shared_let(:view_work_package_role) { create(:view_work_package_role) }
- shared_let(:editor) { create(:admin, firstname: 'Mr.', lastname: 'Sharer') }
+ shared_let(:editor) { create(:admin, firstname: "Mr.", lastname: "Sharer") }
shared_let(:sharer_role) do
create(:project_role,
@@ -54,16 +54,16 @@
let(:work_package_page) { Pages::FullWorkPackage.new(work_package) }
let(:share_modal) { Components::WorkPackages::ShareModal.new(work_package) }
- it 'allows to invite and activate the account' do
- login_with(editor.login, 'adminADMIN!')
- expect(page).to have_current_path '/my/page'
+ it "allows to invite and activate the account" do
+ login_with(editor.login, "adminADMIN!")
+ expect(page).to have_current_path "/my/page"
work_package_page.visit!
work_package_page.click_share_button
share_modal.expect_open
# Invite a user that does not exist yet
- share_modal.invite_user('foobar@example.com', 'View')
+ share_modal.invite_user("foobar@example.com", "View")
# New user is shown in the list of shares
share_modal.expect_shared_count_of(1)
@@ -76,23 +76,23 @@
user = token.user
expect(token).to be_present
expect(user).to be_invited
- expect(user.mail).to eq 'foobar@example.com'
+ expect(user.mail).to eq "foobar@example.com"
expect(link).to include token.value
# Can log in and register the first time
visit signout_path
visit link
- expect(page).to have_text 'Create a new account'
+ expect(page).to have_text "Create a new account"
password = SecureRandom.hex(16)
- fill_in 'Password', with: password
- fill_in 'Confirmation', with: password
+ fill_in "Password", with: password
+ fill_in "Confirmation", with: password
- click_button 'Create'
+ click_button "Create"
- expect(page).to have_text 'Welcome, your account has been activated. You are logged in now.'
- expect(page).to have_current_path project_work_package_path(project, work_package.id, 'activity')
+ expect(page).to have_text "Welcome, your account has been activated. You are logged in now."
+ expect(page).to have_current_path project_work_package_path(project, work_package.id, "activity")
expect(page).to have_text work_package.subject
expect(user.reload).to be_active
@@ -101,10 +101,10 @@
visit signout_path
visit link
- expect(page).to have_text 'Sign in'
- login_with 'foobar@example.com', password, visit_signin_path: false
+ expect(page).to have_text "Sign in"
+ login_with "foobar@example.com", password, visit_signin_path: false
- expect(page).to have_current_path project_work_package_path(project, work_package.id, 'activity')
+ expect(page).to have_current_path project_work_package_path(project, work_package.id, "activity")
expect(page).to have_text work_package.subject
end
end
diff --git a/spec/features/work_packages/share/share_spec.rb b/spec/features/work_packages/share/share_spec.rb
index 68e6797c63d5..33d4fbc47b7b 100644
--- a/spec/features/work_packages/share/share_spec.rb
+++ b/spec/features/work_packages/share/share_spec.rb
@@ -28,25 +28,25 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package sharing',
+RSpec.describe "Work package sharing",
:js, :with_cuprite,
with_ee: %i[work_package_sharing] do
shared_let(:view_work_package_role) { create(:view_work_package_role) }
shared_let(:comment_work_package_role) { create(:comment_work_package_role) }
shared_let(:edit_work_package_role) { create(:edit_work_package_role) }
- shared_let(:view_user) { create(:user, firstname: 'View', lastname: 'User') }
- shared_let(:comment_user) { create(:user, firstname: 'Comment', lastname: 'User') }
- shared_let(:edit_user) { create(:user, firstname: 'Edit', lastname: 'User') }
- shared_let(:non_shared_project_user) { create(:user, firstname: 'Non Shared Project', lastname: 'User') }
- shared_let(:shared_project_user) { create(:user, firstname: 'Shared Project', lastname: 'User') }
- shared_let(:not_shared_yet_with_user) { create(:user, firstname: 'Not shared Yet', lastname: 'User') }
+ shared_let(:view_user) { create(:user, firstname: "View", lastname: "User") }
+ shared_let(:comment_user) { create(:user, firstname: "Comment", lastname: "User") }
+ shared_let(:edit_user) { create(:user, firstname: "Edit", lastname: "User") }
+ shared_let(:non_shared_project_user) { create(:user, firstname: "Non Shared Project", lastname: "User") }
+ shared_let(:shared_project_user) { create(:user, firstname: "Shared Project", lastname: "User") }
+ shared_let(:not_shared_yet_with_user) { create(:user, firstname: "Not shared Yet", lastname: "User") }
- shared_let(:richard) { create(:user, firstname: 'Richard', lastname: 'Hendricks') }
- shared_let(:dinesh) { create(:user, firstname: 'Dinesh', lastname: 'Chugtai') }
- shared_let(:gilfoyle) { create(:user, firstname: 'Bertram', lastname: 'Gilfoyle') }
+ shared_let(:richard) { create(:user, firstname: "Richard", lastname: "Hendricks") }
+ shared_let(:dinesh) { create(:user, firstname: "Dinesh", lastname: "Chugtai") }
+ shared_let(:gilfoyle) { create(:user, firstname: "Bertram", lastname: "Gilfoyle") }
shared_let(:not_shared_yet_with_group) { create(:group, members: [richard, dinesh, gilfoyle]) }
let(:project) do
@@ -81,7 +81,7 @@
let(:columns) { Components::WorkPackages::Columns.new }
let(:wp_modal) { Components::WorkPackages::TableConfigurationModal.new }
- current_user { create(:user, firstname: 'Signed in', lastname: 'User') }
+ current_user { create(:user, firstname: "Signed in", lastname: "User") }
def shared_principals
Principal.where(id: Member.of_work_package(work_package).select(:user_id))
@@ -91,8 +91,8 @@ def inherited_member_roles(group:)
MemberRole.where(inherited_from: MemberRole.where(member_id: group.memberships))
end
- context 'when having share permission' do
- it 'allows seeing and administrating sharing' do
+ context "when having share permission" do
+ it "allows seeing and administrating sharing" do
work_package_page.visit!
# Clicking on the share button opens a modal which lists all of the users a work package
@@ -102,14 +102,14 @@ def inherited_member_roles(group:)
work_package_page.click_share_button
aggregate_failures "Initial shares list" do
- share_modal.expect_title(I18n.t('js.work_packages.sharing.title'))
- share_modal.expect_shared_with(comment_user, 'Comment', position: 1)
- share_modal.expect_shared_with(dinesh, 'Edit', position: 2)
- share_modal.expect_shared_with(edit_user, 'Edit', position: 3)
- share_modal.expect_shared_with(shared_project_user, 'Edit', position: 4)
+ share_modal.expect_title(I18n.t("js.work_packages.sharing.title"))
+ share_modal.expect_shared_with(comment_user, "Comment", position: 1)
+ share_modal.expect_shared_with(dinesh, "Edit", position: 2)
+ share_modal.expect_shared_with(edit_user, "Edit", position: 3)
+ share_modal.expect_shared_with(shared_project_user, "Edit", position: 4)
# The current users share is also displayed but not editable
share_modal.expect_shared_with(current_user, position: 5, editable: false)
- share_modal.expect_shared_with(view_user, 'View', position: 6)
+ share_modal.expect_shared_with(view_user, "View", position: 6)
share_modal.expect_not_shared_with(non_shared_project_user)
share_modal.expect_not_shared_with(not_shared_yet_with_user)
@@ -119,9 +119,9 @@ def inherited_member_roles(group:)
aggregate_failures "Inviting a user for the first time" do
# Inviting a user will lead to that user being prepended to the list together with the rest of the shared with users.
- share_modal.invite_user(not_shared_yet_with_user, 'View')
+ share_modal.invite_user(not_shared_yet_with_user, "View")
- share_modal.expect_shared_with(not_shared_yet_with_user, 'View', position: 1)
+ share_modal.expect_shared_with(not_shared_yet_with_user, "View", position: 1)
share_modal.expect_shared_count_of(7)
end
@@ -134,8 +134,8 @@ def inherited_member_roles(group:)
aggregate_failures "Re-inviting a user" do
# Adding a user multiple times will lead to the user's role being updated.
- share_modal.invite_user(not_shared_yet_with_user, 'Edit')
- share_modal.expect_shared_with(not_shared_yet_with_user, 'Edit', position: 1)
+ share_modal.invite_user(not_shared_yet_with_user, "Edit")
+ share_modal.expect_shared_with(not_shared_yet_with_user, "Edit", position: 1)
share_modal.expect_shared_count_of(6)
# Sent out email only on first share and not again when updating.
@@ -145,8 +145,8 @@ def inherited_member_roles(group:)
aggregate_failures "Updating a share" do
# Updating the share
- share_modal.change_role(not_shared_yet_with_user, 'Comment')
- share_modal.expect_shared_with(not_shared_yet_with_user, 'Comment', position: 1)
+ share_modal.change_role(not_shared_yet_with_user, "Comment")
+ share_modal.expect_shared_with(not_shared_yet_with_user, "Comment", position: 1)
share_modal.expect_shared_count_of(6)
# Sent out email only on first share and not again when updating so the
@@ -158,11 +158,11 @@ def inherited_member_roles(group:)
aggregate_failures "Inviting a group" do
# Inviting a group propagates the membership to the group's users. However, these propagated
# memberships are not expected to be visible.
- share_modal.invite_group(not_shared_yet_with_group, 'View')
- share_modal.expect_shared_with(not_shared_yet_with_group, 'View', position: 1)
+ share_modal.invite_group(not_shared_yet_with_group, "View")
+ share_modal.expect_shared_with(not_shared_yet_with_group, "View", position: 1)
# This user has a share independent of the group's share. Hence, that Role prevails
- share_modal.expect_shared_with(dinesh, 'Edit')
+ share_modal.expect_shared_with(dinesh, "Edit")
share_modal.expect_not_shared_with(richard)
share_modal.expect_not_shared_with(gilfoyle)
@@ -183,8 +183,8 @@ def inherited_member_roles(group:)
aggregate_failures "Inviting a group member with its own independent role" do
# Inviting a group user to a Work Package independently of the the group displays
# said user in the shares list
- share_modal.invite_user(gilfoyle, 'Comment')
- share_modal.expect_shared_with(gilfoyle, 'Comment', position: 1)
+ share_modal.invite_user(gilfoyle, "Comment")
+ share_modal.expect_shared_with(gilfoyle, "Comment", position: 1)
share_modal.expect_shared_count_of(8)
perform_enqueued_jobs
@@ -196,10 +196,10 @@ def inherited_member_roles(group:)
aggregate_failures "Updating a group's share" do
# Updating a group's share role also propagates to the inherited member roles of
# its users
- share_modal.change_role(not_shared_yet_with_group, 'Comment')
+ share_modal.change_role(not_shared_yet_with_group, "Comment")
wait_for_network_idle
- share_modal.expect_shared_with(not_shared_yet_with_group, 'Comment')
+ share_modal.expect_shared_with(not_shared_yet_with_group, "Comment")
share_modal.expect_shared_count_of(8)
expect(inherited_member_roles(group: not_shared_yet_with_group))
.to all(have_attributes(role: comment_work_package_role))
@@ -217,8 +217,8 @@ def inherited_member_roles(group:)
share_modal.expect_not_shared_with(not_shared_yet_with_group)
share_modal.expect_not_shared_with(richard)
- share_modal.expect_shared_with(dinesh, 'Edit')
- share_modal.expect_shared_with(gilfoyle, 'Comment')
+ share_modal.expect_shared_with(dinesh, "Edit")
+ share_modal.expect_shared_with(gilfoyle, "Comment")
share_modal.expect_shared_count_of(7)
expect(inherited_member_roles(group: not_shared_yet_with_group))
.to be_empty
@@ -235,16 +235,16 @@ def inherited_member_roles(group:)
aggregate_failures "Re-opening the modal after changes performed" do
# This user preserved its group independent share
- share_modal.expect_shared_with(gilfoyle, 'Comment', position: 1)
- share_modal.expect_shared_with(comment_user, 'Comment', position: 2)
+ share_modal.expect_shared_with(gilfoyle, "Comment", position: 1)
+ share_modal.expect_shared_with(comment_user, "Comment", position: 2)
# This user preserved its group independent share
- share_modal.expect_shared_with(dinesh, 'Edit', position: 3)
+ share_modal.expect_shared_with(dinesh, "Edit", position: 3)
# This user's role was updated
- share_modal.expect_shared_with(not_shared_yet_with_user, 'Comment', position: 4)
+ share_modal.expect_shared_with(not_shared_yet_with_user, "Comment", position: 4)
# These users were not changed
- share_modal.expect_shared_with(shared_project_user, 'Edit', position: 5)
+ share_modal.expect_shared_with(shared_project_user, "Edit", position: 5)
share_modal.expect_shared_with(current_user, position: 6, editable: false)
- share_modal.expect_shared_with(view_user, 'View', position: 7)
+ share_modal.expect_shared_with(view_user, "View", position: 7)
# This group's share was revoked
share_modal.expect_not_shared_with(not_shared_yet_with_group)
@@ -260,54 +260,54 @@ def inherited_member_roles(group:)
visit project_members_path(project)
- aggregate_failures 'Observing the shared members with view permission' do
- members_page.click_menu_item 'View'
+ aggregate_failures "Observing the shared members with view permission" do
+ members_page.click_menu_item "View"
expect(members_page).to have_user view_user.name
members_page.in_user_row(view_user) do
- expect(page).to have_text '1 work package'
+ expect(page).to have_text "1 work package"
end
expect(members_page).not_to have_user gilfoyle.name
expect(members_page).not_to have_user comment_user.name
expect(members_page).not_to have_user dinesh.name
end
- aggregate_failures 'Observing the shared members with comment permission' do
- members_page.click_menu_item 'Comment'
+ aggregate_failures "Observing the shared members with comment permission" do
+ members_page.click_menu_item "Comment"
expect(members_page).to have_user gilfoyle.name
members_page.in_user_row(gilfoyle) do
- expect(page).to have_text '1 work package'
+ expect(page).to have_text "1 work package"
end
expect(members_page).to have_user comment_user.name
expect(members_page).not_to have_user view_user.name
expect(members_page).not_to have_user dinesh.name
end
- aggregate_failures 'Observing the shared members with edit permission' do
- members_page.click_menu_item 'Edit'
+ aggregate_failures "Observing the shared members with edit permission" do
+ members_page.click_menu_item "Edit"
expect(members_page).to have_user dinesh.name
expect(members_page).not_to have_user gilfoyle.name
expect(members_page).not_to have_user comment_user.name
expect(members_page).not_to have_user view_user.name
end
- aggregate_failures 'Showing the shared users in the table' do
+ aggregate_failures "Showing the shared users in the table" do
wp_table.visit!
wp_modal.open!
- wp_modal.switch_to 'Columns'
+ wp_modal.switch_to "Columns"
columns.assume_opened
columns.uncheck_all save_changes: false
- columns.add 'ID', save_changes: false
- columns.add 'Subject', save_changes: false
- columns.add 'Shared with', save_changes: false
+ columns.add "ID", save_changes: false
+ columns.add "Subject", save_changes: false
+ columns.add "Shared with", save_changes: false
columns.apply
wp_row = wp_table.row(work_package)
- expect(wp_row).to have_css('.wp-table--cell-td.sharedWithUsers .badge', text: '7')
- wp_row.find('.wp-table--cell-td.sharedWithUsers .badge').click
+ expect(wp_row).to have_css(".wp-table--cell-td.sharedWithUsers .badge", text: "7")
+ wp_row.find(".wp-table--cell-td.sharedWithUsers .badge").click
- share_modal.expect_title(I18n.t('js.work_packages.sharing.title'))
+ share_modal.expect_title(I18n.t("js.work_packages.sharing.title"))
share_modal.expect_shared_count_of(7)
end
end
@@ -320,20 +320,20 @@ def inherited_member_roles(group:)
share_modal.click_share
share_modal.expect_select_a_user_hint
- share_modal.invite_user(not_shared_yet_with_user, 'View')
+ share_modal.invite_user(not_shared_yet_with_user, "View")
share_modal.expect_shared_with(not_shared_yet_with_user, position: 1)
share_modal.expect_no_select_a_user_hint
end
end
- context 'when lacking share permission but having the viewing permission' do
+ context "when lacking share permission but having the viewing permission" do
let(:sharer_role) do
create(:project_role,
permissions: %i(view_work_packages
view_shared_work_packages))
end
- it 'allows seeing shares but not editing' do
+ it "allows seeing shares but not editing" do
work_package_page.visit!
# Clicking on the share button opens a modal which lists all of the users a work package
@@ -383,42 +383,42 @@ def inherited_member_roles(group:)
it_behaves_like "'Share' button is not rendered"
end
- context 'when having global invite permission' do
+ context "when having global invite permission" do
let(:global_manager_user) { create(:user, global_permissions: %i[manage_user create_user]) }
let(:current_user) { global_manager_user }
- let(:locked_user) { create(:user, mail: 'holly@openproject.com', status: :locked) }
+ let(:locked_user) { create(:user, mail: "holly@openproject.com", status: :locked) }
before do
work_package_page.visit!
work_package_page.click_share_button
end
- it 'allows inviting and directly sharing with a user who is not part of the instance yet' do
+ it "allows inviting and directly sharing with a user who is not part of the instance yet" do
share_modal.expect_open
share_modal.expect_shared_count_of(6)
# Invite a user that does not exist yet
- share_modal.invite_user('hello@world.de', 'View')
+ share_modal.invite_user("hello@world.de", "View")
# New user is shown in the list of shares
share_modal.expect_shared_count_of(7)
# New user is created
new_user = User.last
- share_modal.expect_shared_with(new_user, 'View', position: 1)
+ share_modal.expect_shared_with(new_user, "View", position: 1)
perform_enqueued_jobs
# Only one combined email for create and share should be send out
expect(ActionMailer::Base.deliveries.size).to eq(1)
# The new user can be interacted with
- share_modal.change_role(new_user, 'Comment')
- share_modal.expect_shared_with(new_user, 'Comment', position: 1)
+ share_modal.change_role(new_user, "Comment")
+ share_modal.expect_shared_with(new_user, "Comment", position: 1)
share_modal.expect_shared_count_of(7)
# The new user can be updated
- share_modal.invite_user(new_user, 'Edit')
- share_modal.expect_shared_with(new_user, 'Edit', position: 1)
+ share_modal.invite_user(new_user, "Edit")
+ share_modal.expect_shared_with(new_user, "Edit", position: 1)
share_modal.expect_shared_count_of(7)
# The invite can be resent
@@ -434,7 +434,7 @@ def inherited_member_roles(group:)
share_modal.expect_shared_count_of(6)
end
- it 'shows an error message when inviting an existing locked user' do
+ it "shows an error message when inviting an existing locked user" do
share_modal.expect_open
share_modal.expect_shared_count_of(6)
@@ -446,7 +446,7 @@ def inherited_member_roles(group:)
share_modal.expect_no_ng_option("", locked_user.name, results_selector: "body")
# Invite the email address
- share_modal.invite_user(locked_user.mail, 'View')
+ share_modal.invite_user(locked_user.mail, "View")
# The number of shared people has not changed, but an error message is shown
share_modal.expect_shared_count_of(6)
@@ -454,8 +454,8 @@ def inherited_member_roles(group:)
end
end
- context 'when lacking global invite permission' do
- it 'does not allow creating a user who is not part of the instance yet' do
+ context "when lacking global invite permission" do
+ it "does not allow creating a user who is not part of the instance yet" do
work_package_page.visit!
work_package_page.click_share_button
@@ -463,7 +463,7 @@ def inherited_member_roles(group:)
share_modal.expect_shared_count_of(6)
# Search for a user that does not exist
- share_modal.search_user('hello@world.de')
+ share_modal.search_user("hello@world.de")
# There is no option to directly create and share the WP for the unknown email address
share_modal.expect_no_ng_option("", 'Send invite to"hello@world.de"', results_selector: "body")
diff --git a/spec/features/work_packages/shared_contexts.rb b/spec/features/work_packages/shared_contexts.rb
index d9e8a4bb2db1..6ebb643a2552 100644
--- a/spec/features/work_packages/shared_contexts.rb
+++ b/spec/features/work_packages/shared_contexts.rb
@@ -28,7 +28,7 @@
# Ensure the page is completely loaded before the spec is run.
# The status filter is loaded very late in the page setup.
-RSpec.shared_context 'ensure wp details pane update done' do
+RSpec.shared_context "ensure wp details pane update done" do
after do
unless update_user
raise "Expect to have a let called 'update_user' defining which user \
@@ -37,7 +37,7 @@
# safeguard to ensure all backend queries
# have been answered before starting a new spec
- expect(page).to have_css('.op-user-activity--user-name',
+ expect(page).to have_css(".op-user-activity--user-name",
text: update_user.name)
end
end
diff --git a/spec/features/work_packages/sorting/manual_sorting_spec.rb b/spec/features/work_packages/sorting/manual_sorting_spec.rb
index 385c9c17d6dd..e871dddf1126 100644
--- a/spec/features/work_packages/sorting/manual_sorting_spec.rb
+++ b/spec/features/work_packages/sorting/manual_sorting_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/work_packages/work_packages_page'
+require "spec_helper"
+require "features/work_packages/work_packages_page"
-RSpec.describe 'Manual sorting of WP table', :js do
+RSpec.describe "Manual sorting of WP table", :js do
let(:user) { create(:admin) }
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
@@ -37,11 +37,11 @@
let(:type_bug) { create(:type_bug) }
let(:project) { create(:project, types: [type_task, type_bug], enabled_module_names: %i[work_package_tracking gantt]) }
let(:work_package1) do
- create(:work_package, subject: 'WP1', project:, type: type_task, created_at: Time.zone.now)
+ create(:work_package, subject: "WP1", project:, type: type_task, created_at: Time.zone.now)
end
let(:work_package2) do
create(:work_package,
- subject: 'WP2',
+ subject: "WP2",
project:,
parent: work_package1,
type: type_task,
@@ -49,7 +49,7 @@
end
let(:work_package3) do
create(:work_package,
- subject: 'WP3',
+ subject: "WP3",
project:,
parent: work_package2,
type: type_bug,
@@ -57,7 +57,7 @@
end
let(:work_package4) do
create(:work_package,
- subject: 'WP4',
+ subject: "WP4",
project:,
parent: work_package3,
type: type_bug,
@@ -89,7 +89,7 @@ def expect_query_order(query, expected)
work_package4
end
- describe 'hierarchy mode' do
+ describe "hierarchy mode" do
before do
wp_table.visit!
@@ -99,18 +99,18 @@ def expect_query_order(query, expected)
hierarchies.expect_leaf_at(work_package4)
end
- it 'maintains the order and automatically saves the query' do
+ it "maintains the order and automatically saves the query" do
wp_table.drag_and_drop_work_package from: 3, to: 1
loading_indicator_saveguard
hierarchies.expect_hierarchy_at(work_package1, work_package2)
hierarchies.expect_leaf_at(work_package4, work_package3)
- wp_table.expect_and_dismiss_toaster message: 'Successful creation.'
+ wp_table.expect_and_dismiss_toaster message: "Successful creation."
query = nil
retry_block do
query = Query.last
- raise "Query was not yet saved." unless query.name == 'New manually sorted query'
+ raise "Query was not yet saved." unless query.name == "New manually sorted query"
end
# Expect sorted 1 and 2, the rest is not positioned
@@ -121,7 +121,7 @@ def expect_query_order(query, expected)
pagination.expect_no_per_page_options
end
- it 'can drag an element into a hierarchy' do
+ it "can drag an element into a hierarchy" do
# Move up the hierarchy
wp_table.drag_and_drop_work_package from: 3, to: 1
loading_indicator_saveguard
@@ -134,7 +134,7 @@ def expect_query_order(query, expected)
hierarchies.expect_leaf_at(work_package3, work_package4)
end
- it 'can drag an element completely out of the hierarchy' do
+ it "can drag an element completely out of the hierarchy" do
# Move up the hierarchy
wp_table.drag_and_drop_work_package from: 3, to: 0
loading_indicator_saveguard
@@ -153,12 +153,12 @@ def expect_query_order(query, expected)
wp_page.expect_no_parent
end
- context 'when dragging an element partly out of the hierarchy' do
+ context "when dragging an element partly out of the hierarchy" do
let(:work_package5) do
- create(:work_package, subject: 'WP5', project:, parent: work_package1)
+ create(:work_package, subject: "WP5", project:, parent: work_package1)
end
let(:work_package6) do
- create(:work_package, subject: 'WP6', project:, parent: work_package1)
+ create(:work_package, subject: "WP6", project:, parent: work_package1)
end
before do
@@ -179,7 +179,7 @@ def expect_query_order(query, expected)
hierarchies.expect_leaf_at(work_package3, work_package4, work_package5, work_package6)
end
- it 'move below a sibling of my parent' do
+ it "move below a sibling of my parent" do
wp_table.drag_and_drop_work_package from: 3, to: 5
loading_indicator_saveguard
@@ -195,46 +195,46 @@ def expect_query_order(query, expected)
end
end
- describe 'group mode' do
- describe 'group by type' do
+ describe "group mode" do
+ describe "group by type" do
let(:group_by) { Components::WorkPackages::GroupBy.new }
before do
wp_table.visit!
- group_by.enable_via_menu 'Type'
+ group_by.enable_via_menu "Type"
- wp_table.save_as 'Type query'
- wp_table.expect_and_dismiss_toaster message: 'Successful creation.'
+ wp_table.save_as "Type query"
+ wp_table.expect_and_dismiss_toaster message: "Successful creation."
end
- it 'updates the work packages appropriately' do
- expect(page).to have_css('.group--value', text: 'Task (2)')
- expect(page).to have_css('.group--value', text: 'Bug (2)')
+ it "updates the work packages appropriately" do
+ expect(page).to have_css(".group--value", text: "Task (2)")
+ expect(page).to have_css(".group--value", text: "Bug (2)")
wp_table.drag_and_drop_work_package from: 0, to: 3
- expect(page).to have_css('.group--value', text: 'Task (1)')
- expect(page).to have_css('.group--value', text: 'Bug (3)')
+ expect(page).to have_css(".group--value", text: "Task (1)")
+ expect(page).to have_css(".group--value", text: "Bug (3)")
end
- it 'dragging item with parent does not result in an error (Regression #30832)' do
- expect(page).to have_css('.group--value', text: 'Task (2)')
- expect(page).to have_css('.group--value', text: 'Bug (2)')
+ it "dragging item with parent does not result in an error (Regression #30832)" do
+ expect(page).to have_css(".group--value", text: "Task (2)")
+ expect(page).to have_css(".group--value", text: "Bug (2)")
wp_table.drag_and_drop_work_package from: 1, to: 3
- expect(page).to have_css('.group--value', text: 'Task (1)')
- expect(page).to have_css('.group--value', text: 'Bug (3)')
+ expect(page).to have_css(".group--value", text: "Task (1)")
+ expect(page).to have_css(".group--value", text: "Bug (3)")
- expect(page).to have_no_css '.op-toast.error'
+ expect(page).to have_no_css ".op-toast.error"
end
end
end
- describe 'with a saved query and positions increasing from zero' do
+ describe "with a saved query and positions increasing from zero" do
let(:query) do
create(:query, user:, project:, show_hierarchies: false).tap do |q|
- q.sort_criteria = [[:manual_sorting, 'asc']]
+ q.sort_criteria = [[:manual_sorting, "asc"]]
q.save!
end
end
@@ -248,7 +248,7 @@ def expect_query_order(query, expected)
OrderedWorkPackage.create(query:, work_package: work_package4, position: 3)
end
- it 'can inline create a work package and it is positioned to the bottom (Regression #31078)' do
+ it "can inline create a work package and it is positioned to the bottom (Regression #31078)" do
wp_table.visit_query query
wp_table.expect_work_package_order work_package1, work_package2, work_package3, work_package4
@@ -257,17 +257,17 @@ def expect_query_order(query, expected)
subject_field.expect_active!
# Save the WP
- subject_field.set_value 'Foobar!'
+ subject_field.set_value "Foobar!"
subject_field.submit_by_enter
wp_table.expect_and_dismiss_toaster(
- message: 'Successful creation. Click here to open this work package in fullscreen view.'
+ message: "Successful creation. Click here to open this work package in fullscreen view."
)
- wp_table.expect_work_package_subject 'Foobar!'
+ wp_table.expect_work_package_subject "Foobar!"
inline_created = WorkPackage.last
- expect(inline_created.subject).to eq 'Foobar!'
+ expect(inline_created.subject).to eq "Foobar!"
# Wait until the order was saved, this might take a few moments
retry_block do
@@ -288,15 +288,15 @@ def expect_query_order(query, expected)
end
end
- describe 'with a saved query that is NOT manually sorted' do
+ describe "with a saved query that is NOT manually sorted" do
let(:query) do
create(:query, user:, project:, show_hierarchies: false).tap do |q|
- q.sort_criteria = [[:id, 'asc']]
+ q.sort_criteria = [[:id, "asc"]]
q.save!
end
end
- it 'can drag and drop and will save the query' do
+ it "can drag and drop and will save the query" do
wp_table.visit_query query
wp_table.expect_work_package_order work_package1, work_package2, work_package3, work_package4
@@ -304,12 +304,12 @@ def expect_query_order(query, expected)
wp_table.expect_work_package_order work_package1, work_package3, work_package2, work_package4
- wp_table.expect_and_dismiss_toaster message: 'Successful update.'
+ wp_table.expect_and_dismiss_toaster message: "Successful update."
retry_block do
query.reload
- if query.sort_criteria != [['manual_sorting', 'asc']]
+ if query.sort_criteria != [["manual_sorting", "asc"]]
raise "Expected sort_criteria to be updated to manual_sorting, was #{query.sort_criteria.inspect}"
end
end
@@ -319,22 +319,22 @@ def expect_query_order(query, expected)
end
end
- describe 'flat mode' do
+ describe "flat mode" do
before do
wp_table.visit!
hierarchies.disable_via_header
wp_table.expect_work_package_order work_package1, work_package2, work_package3, work_package4
end
- it 'can sort table rows via DragNDrop' do
+ it "can sort table rows via DragNDrop" do
wp_table.drag_and_drop_work_package from: 1, to: 3
wp_table.expect_work_package_order work_package1, work_package3, work_package2, work_package4
- wp_table.expect_and_dismiss_toaster message: 'Successful creation.'
+ wp_table.expect_and_dismiss_toaster message: "Successful creation."
query = Query.last
- expect(query.name).to eq 'New manually sorted query'
+ expect(query.name).to eq "New manually sorted query"
expect_query_order(query, [work_package1.id, work_package3.id, work_package2.id])
@@ -343,11 +343,11 @@ def expect_query_order(query, expected)
expect_query_order(query, [work_package3.id, work_package1.id, work_package2.id])
end
- it 'saves the changed order in a previously saved query' do
- wp_table.save_as 'Manual sorted query'
+ it "saves the changed order in a previously saved query" do
+ wp_table.save_as "Manual sorted query"
sort_by.open_modal
- sort_by.update_sorting_mode 'manual'
+ sort_by.update_sorting_mode "manual"
sort_by.apply_changes
wp_table.drag_and_drop_work_package from: 1, to: 3
@@ -355,34 +355,34 @@ def expect_query_order(query, expected)
wp_table.expect_work_package_order work_package1, work_package3, work_package2, work_package4
query = Query.last
- expect(query.name).to eq 'Manual sorted query'
+ expect(query.name).to eq "Manual sorted query"
expect_query_order(query, [work_package1.id, work_package3.id, work_package2.id])
pagination.expect_range(1, 4, 4)
pagination.expect_no_per_page_options
end
- it 'does not loose the current order when switching to manual sorting' do
+ it "does not loose the current order when switching to manual sorting" do
# Sort by creation date
- sort_by.update_criteria 'Created on'
+ sort_by.update_criteria "Created on"
wp_table.expect_work_package_order work_package4, work_package3, work_package2, work_package1
# Enable manual sorting
sort_by.open_modal
- sort_by.update_sorting_mode 'manual'
+ sort_by.update_sorting_mode "manual"
sort_by.apply_changes
# Expect same order
wp_table.expect_work_package_order work_package4, work_package3, work_package2, work_package1
end
- it 'shows a warning when switching from manual to automatic sorting' do
+ it "shows a warning when switching from manual to automatic sorting" do
wp_table.drag_and_drop_work_package from: 1, to: 3
wp_table.expect_work_package_order work_package1, work_package3, work_package2, work_package4
# Try to sort by creation date
- sort_by.sort_via_header 'Subject'
+ sort_by.sort_via_header "Subject"
# Shows a warning
dialog.expect_open
@@ -390,20 +390,20 @@ def expect_query_order(query, expected)
wp_table.expect_work_package_order work_package1, work_package2, work_package3, work_package4
end
- context 'when view is gantt chart' do
+ context "when view is gantt chart" do
let(:wp_timeline) { Pages::WorkPackagesTimeline.new(project) }
let!(:query_tl) do
query = build(:query_with_view_gantt, user:, project:)
query.filters.clear
query.timeline_visible = true
- query.name = 'Query with Timeline'
+ query.name = "Query with Timeline"
query.save!
query
end
- it 'reloads after drop' do
+ it "reloads after drop" do
wp_timeline.visit_query(query_tl)
wp_timeline.expect_timeline!
wp_timeline.expect_row_count(4)
diff --git a/spec/features/work_packages/sorting/table_sorting_spec.rb b/spec/features/work_packages/sorting/table_sorting_spec.rb
index 231ae2130966..811c44c784cb 100644
--- a/spec/features/work_packages/sorting/table_sorting_spec.rb
+++ b/spec/features/work_packages/sorting/table_sorting_spec.rb
@@ -26,16 +26,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/work_packages/work_packages_page'
+require "spec_helper"
+require "features/work_packages/work_packages_page"
-RSpec.describe 'Select work package row', :js do
+RSpec.describe "Select work package row", :js do
let(:user) { create(:admin) }
let(:project) { create(:project) }
let(:work_packages_page) { WorkPackagesPage.new(project) }
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
- describe 'sorting by version' do
+ describe "sorting by version" do
let(:work_package_1) do
create(:work_package, project:)
end
@@ -45,11 +45,11 @@
let(:version_1) do
create(:version, project:,
- name: 'aaa_version')
+ name: "aaa_version")
end
let(:version_2) do
create(:version, project:,
- name: 'zzz_version')
+ name: "zzz_version")
end
let(:columns) { Components::WorkPackages::Columns.new }
let(:sort_by) { Components::WorkPackages::SortBy.new }
@@ -63,23 +63,23 @@
work_packages_page.visit_index
end
- include_context 'work package table helpers'
+ include_context "work package table helpers"
- context 'sorting by version' do
+ context "sorting by version" do
before do
work_package_1.update_attribute(:version_id, version_2.id)
work_package_2.update_attribute(:version_id, version_1.id)
end
- it 'sorts by version although version is not selected as a column' do
+ it "sorts by version although version is not selected as a column" do
sort_by.open_modal
- sort_by.update_nth_criteria(0, 'Version')
+ sort_by.update_nth_criteria(0, "Version")
expect_work_packages_to_be_in_order([work_package_1, work_package_2])
end
end
end
- describe 'sorting modal' do
+ describe "sorting modal" do
let(:sort_by) { Components::WorkPackages::SortBy.new }
before do
@@ -87,22 +87,22 @@
wp_table.visit!
end
- it 'provides the default sortation and allows using the value at another level (Regression WP#26792)' do
+ it "provides the default sortation and allows using the value at another level (Regression WP#26792)" do
# Expect current criteria
- sort_by.expect_criteria(['-', 'asc'])
+ sort_by.expect_criteria(["-", "asc"])
# Expect we can change the criteria and reuse that value
sort_by.open_modal
- sort_by.update_nth_criteria(0, 'Type', descending: true)
- sort_by.update_nth_criteria(0, 'ID', descending: true)
- sort_by.update_nth_criteria(1, 'Type')
+ sort_by.update_nth_criteria(0, "Type", descending: true)
+ sort_by.update_nth_criteria(0, "ID", descending: true)
+ sort_by.update_nth_criteria(1, "Type")
sort_by.apply_changes
- sort_by.expect_criteria(['ID', 'desc'], ['Type', 'asc'])
+ sort_by.expect_criteria(["ID", "desc"], ["Type", "asc"])
end
end
- describe 'parent sorting' do
+ describe "parent sorting" do
let(:sort_by) { Components::WorkPackages::SortBy.new }
let(:parent) do
@@ -136,7 +136,7 @@
end
before do
- allow(Setting).to receive(:per_page_options).and_return '4'
+ allow(Setting).to receive(:per_page_options).and_return "4"
parent
child1
@@ -149,7 +149,7 @@
wp_table.visit!
end
- it 'default sortation (id) does not order depth first (Reverted in #29122)' do
+ it "default sortation (id) does not order depth first (Reverted in #29122)" do
wp_table.expect_work_package_listed parent, child1, grand_child1, child2
wp_table.expect_work_package_order parent.id, child1.id, grand_child1.id, child2
end
diff --git a/spec/features/work_packages/switching_to_project_from_work_package_spec.rb b/spec/features/work_packages/switching_to_project_from_work_package_spec.rb
index 55d4f8be5775..3d773a97fd2b 100644
--- a/spec/features/work_packages/switching_to_project_from_work_package_spec.rb
+++ b/spec/features/work_packages/switching_to_project_from_work_package_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Switching to project from work package', :js do
+RSpec.describe "Switching to project from work package", :js do
let(:user) { create(:admin) }
let(:project) { create(:project) }
@@ -14,7 +14,7 @@
work_package
end
- it 'allows to switch to the project the work package belongs to' do
+ it "allows to switch to the project the work package belongs to" do
wp_table.visit!
wp_table.expect_work_package_listed work_package
@@ -22,8 +22,8 @@
wp_table.open_full_screen_by_link work_package
# Follow link to project
- expect(page).to have_css('.attributes-group.-project-context')
- link = find('.attributes-group.-project-context .project-context--switch-link')
+ expect(page).to have_css(".attributes-group.-project-context")
+ link = find(".attributes-group.-project-context .project-context--switch-link")
expect(link[:href]).to include(project_path(project.id))
link.click
diff --git a/spec/features/work_packages/table/baseline/baseline_invisible_project_spec.rb b/spec/features/work_packages/table/baseline/baseline_invisible_project_spec.rb
index 7dc636fa7c26..8397afa62695 100644
--- a/spec/features/work_packages/table/baseline/baseline_invisible_project_spec.rb
+++ b/spec/features/work_packages/table/baseline/baseline_invisible_project_spec.rb
@@ -26,18 +26,18 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'baseline with a work package moved to an invisible project', :js,
- with_settings: { date_format: '%Y-%m-%d' } do
+RSpec.describe "baseline with a work package moved to an invisible project", :js,
+ with_settings: { date_format: "%Y-%m-%d" } do
shared_let(:type_bug) { create(:type_bug) }
shared_let(:visible_project) { create(:project, types: [type_bug]) }
shared_let(:private_project) { create(:project, types: [type_bug]) }
shared_let(:user) do
create(:user,
- firstname: 'Itsa',
- lastname: 'Me',
+ firstname: "Itsa",
+ lastname: "Me",
member_with_permissions: { visible_project => %i[view_work_packages edit_work_packages work_package_assigned
assign_versions] })
end
@@ -49,16 +49,16 @@
type: type_bug,
assigned_to: user,
responsible: user,
- subject: 'WP in public project',
- start_date: '2023-05-01',
- due_date: '2023-05-02')
+ subject: "WP in public project",
+ start_date: "2023-05-01",
+ due_date: "2023-05-02")
end
Timecop.travel(1.hour.ago) do
WorkPackages::UpdateService
.new(user: User.system, model: wp)
.call(
- subject: 'Moved to private project',
+ subject: "Moved to private project",
project: private_project
)
.on_failure { |result| raise result.message }
@@ -68,7 +68,7 @@
shared_let(:query) do
query = create(:query,
- name: 'Global query changes since yesterday',
+ name: "Global query changes since yesterday",
project: nil,
user:)
@@ -85,17 +85,17 @@
current_user { user }
- describe 'with EE active', with_ee: %i[baseline_comparison] do
- it 'shows the item with all values removed' do
+ describe "with EE active", with_ee: %i[baseline_comparison] do
+ it "shows the item with all values removed" do
wp_table.visit_query(query)
baseline.expect_active
baseline.expect_removed wp_bug
baseline.expect_changed_attributes wp_bug,
- subject: ['WP in public project', ''],
- startDate: ['2023-05-01', ''],
- dueDate: ['2023-05-02', '']
+ subject: ["WP in public project", ""],
+ startDate: ["2023-05-01", ""],
+ dueDate: ["2023-05-02", ""]
end
end
end
diff --git a/spec/features/work_packages/table/baseline/baseline_query_spec.rb b/spec/features/work_packages/table/baseline/baseline_query_spec.rb
index 9a984223e318..f20307e4207d 100644
--- a/spec/features/work_packages/table/baseline/baseline_query_spec.rb
+++ b/spec/features/work_packages/table/baseline/baseline_query_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'baseline query saving',
+RSpec.describe "baseline query saving",
:js,
:with_cuprite,
with_ee: %i[baseline_comparison],
- with_settings: { date_format: '%Y-%m-%d' } do
+ with_settings: { date_format: "%Y-%m-%d" } do
shared_let(:project) { create(:project) }
shared_let(:work_package) { create(:work_package, project:) }
@@ -43,7 +43,7 @@
shared_let(:berlin_user) do
create(:user,
- preferences: { time_zone: 'Europe/Berlin' },
+ preferences: { time_zone: "Europe/Berlin" },
member_with_permissions: { project => %i[view_work_packages save_queries manage_public_queries] })
end
@@ -56,7 +56,7 @@
shared_let(:tokyo_user) do
create(:user,
- preferences: { time_zone: 'Asia/Tokyo' },
+ preferences: { time_zone: "Asia/Tokyo" },
member_with_permissions: { project => %i[view_work_packages save_queries manage_public_queries] })
end
# always 9 as Japan does not observe daylight saving time
@@ -66,7 +66,7 @@
# always "UTC+9"
shared_let(:tokyo_utc_offset) { "UTC+#{tokyo_hours_offset}" }
- it 'shows a warning when an incompatible filter is used' do
+ it "shows a warning when an incompatible filter is used" do
login_as berlin_user
wp_table.visit!
@@ -74,30 +74,30 @@
baseline.expect_no_legends
baseline_modal.toggle_drop_modal
baseline_modal.expect_open
- baseline_modal.expect_selected '-'
+ baseline_modal.expect_selected "-"
- baseline_modal.select_filter 'yesterday'
- baseline_modal.set_time '09:00'
+ baseline_modal.select_filter "yesterday"
+ baseline_modal.set_time "09:00"
baseline_modal.expect_offset berlin_utc_offset
baseline_modal.apply
loading_indicator_saveguard
filters.open
- filters.add_filter_by('Watcher', 'is (OR)', 'me')
+ filters.add_filter_by("Watcher", "is (OR)", "me")
loading_indicator_saveguard
expect(page).to have_css(
- '.op-toast.-warning',
- text: 'Baseline mode is on but some of your active filters are not included in the comparison.'
+ ".op-toast.-warning",
+ text: "Baseline mode is on but some of your active filters are not included in the comparison."
)
- page.within('#filter_watcher') do
- expect(page).to have_test_selector('query-filter-baseline-incompatible')
+ page.within("#filter_watcher") do
+ expect(page).to have_test_selector("query-filter-baseline-incompatible")
end
end
- it 'can configure and save baseline queries' do
+ it "can configure and save baseline queries" do
login_as berlin_user
wp_table.visit!
@@ -105,10 +105,10 @@
baseline.expect_no_legends
baseline_modal.toggle_drop_modal
baseline_modal.expect_open
- baseline_modal.expect_selected '-'
+ baseline_modal.expect_selected "-"
- baseline_modal.select_filter 'yesterday'
- baseline_modal.set_time '09:00'
+ baseline_modal.select_filter "yesterday"
+ baseline_modal.set_time "09:00"
baseline_modal.expect_offset berlin_utc_offset
baseline_modal.apply
@@ -116,20 +116,20 @@
baseline_modal.toggle_drop_modal
baseline_modal.expect_open
- baseline_modal.expect_selected 'yesterday'
+ baseline_modal.expect_selected "yesterday"
baseline_modal.toggle_drop_modal
baseline_modal.expect_closed
baseline.expect_legends
baseline.expect_legend_text "Changes since yesterday (#{Date.yesterday.iso8601} 9:00 AM #{berlin_utc_offset})"
- expect(page).to have_css(".op-baseline-legends--details-added", text: 'Now meets filter criteria (1)')
- expect(page).to have_css(".op-baseline-legends--details-removed", text: 'No longer meets filter criteria (0)')
- expect(page).to have_css(".op-baseline-legends--details-changed", text: 'Maintained with changes (0)')
+ expect(page).to have_css(".op-baseline-legends--details-added", text: "Now meets filter criteria (1)")
+ expect(page).to have_css(".op-baseline-legends--details-removed", text: "No longer meets filter criteria (0)")
+ expect(page).to have_css(".op-baseline-legends--details-changed", text: "Maintained with changes (0)")
- wp_table.save_as 'Baseline query'
- wp_table.expect_and_dismiss_toaster(message: 'Successful creation.')
+ wp_table.save_as "Baseline query"
+ wp_table.expect_and_dismiss_toaster(message: "Successful creation.")
- query = retry_block { Query.find_by! name: 'Baseline query' }
- expect(query.timestamps.map(&:to_s)).to eq ["oneDayAgo@09:00#{berlin_time_offset}", 'PT0S']
+ query = retry_block { Query.find_by! name: "Baseline query" }
+ expect(query.timestamps.map(&:to_s)).to eq ["oneDayAgo@09:00#{berlin_time_offset}", "PT0S"]
query.update! public: true
login_as tokyo_user
@@ -142,41 +142,41 @@
baseline_modal.expect_closed
baseline_modal.toggle_drop_modal
baseline_modal.expect_open
- baseline_modal.expect_selected 'yesterday'
- baseline_modal.expect_selected_time '09:00'
+ baseline_modal.expect_selected "yesterday"
+ baseline_modal.expect_selected_time "09:00"
baseline_modal.expect_offset berlin_utc_offset
- baseline_modal.select_filter '-'
+ baseline_modal.select_filter "-"
- baseline_modal.select_filter 'yesterday'
+ baseline_modal.select_filter "yesterday"
baseline_modal.expect_offset tokyo_utc_offset
- baseline_modal.select_filter '-'
+ baseline_modal.select_filter "-"
baseline_modal.apply
baseline.expect_no_legends
loading_indicator_saveguard
wp_table.save
- wp_table.expect_and_dismiss_toaster(message: 'Successful update.')
+ wp_table.expect_and_dismiss_toaster(message: "Successful update.")
query.reload
- expect(query.timestamps).to eq ['PT0S']
+ expect(query.timestamps).to eq ["PT0S"]
baseline_modal.expect_closed
baseline_modal.toggle_drop_modal
baseline_modal.expect_open
- baseline_modal.select_filter 'a specific date'
+ baseline_modal.select_filter "a specific date"
baseline_modal.expect_offset tokyo_utc_offset
- baseline_modal.set_time '06:00'
- baseline_modal.set_date '2023-05-20'
+ baseline_modal.set_time "06:00"
+ baseline_modal.set_date "2023-05-20"
baseline_modal.apply
loading_indicator_saveguard
wp_table.save
- wp_table.expect_and_dismiss_toaster(message: 'Successful update.')
+ wp_table.expect_and_dismiss_toaster(message: "Successful update.")
query.reload
- expect(query.timestamps.map(&:to_s)).to eq ['2023-05-20T06:00+09:00', 'PT0S']
+ expect(query.timestamps.map(&:to_s)).to eq ["2023-05-20T06:00+09:00", "PT0S"]
login_as berlin_user
wp_table.visit_query query
@@ -186,11 +186,11 @@
baseline_modal.expect_closed
baseline_modal.toggle_drop_modal
baseline_modal.expect_open
- baseline_modal.expect_selected 'a specific date'
- baseline_modal.expect_selected_time '06:00'
- baseline_modal.expect_offset 'UTC+9'
+ baseline_modal.expect_selected "a specific date"
+ baseline_modal.expect_selected_time "06:00"
+ baseline_modal.expect_offset "UTC+9"
baseline_modal.expect_time_help_text "In your local time: 2023-05-19 11:00 PM"
- baseline_modal.select_filter 'between two specific dates'
+ baseline_modal.select_filter "between two specific dates"
# TODO: on the 2023-05-19, utc offset is +2 hours. But when current date is
# outside of DST (from November to February for instance), then on time
@@ -198,17 +198,17 @@
# would be better to change the offset depending on the selected date: here
# UTC+2 offset should be used so that 8:00 is really 8:00 in Berlin on this
# date, and not 9:00 (because 8:00 UTC+1 is 9:00 UTC+2).
- baseline_modal.set_between_dates from: '2023-05-19',
- to: '2023-05-25',
- from_time: '08:00',
- to_time: '20:00'
+ baseline_modal.set_between_dates from: "2023-05-19",
+ to: "2023-05-25",
+ from_time: "08:00",
+ to_time: "20:00"
baseline_modal.apply
loading_indicator_saveguard
wp_table.save
- wp_table.expect_and_dismiss_toaster(message: 'Successful update.')
+ wp_table.expect_and_dismiss_toaster(message: "Successful update.")
query.reload
expect(query.timestamps.map(&:to_s)).to eq ["2023-05-19T08:00#{berlin_time_offset}", "2023-05-25T20:00#{berlin_time_offset}"]
@@ -224,11 +224,11 @@
baseline_modal.expect_closed
baseline_modal.toggle_drop_modal
baseline_modal.expect_open
- baseline_modal.expect_selected 'between two specific dates'
- baseline_modal.expect_between_dates from: '2023-05-19',
- to: '2023-05-25',
- from_time: '08:00',
- to_time: '20:00'
+ baseline_modal.expect_selected "between two specific dates"
+ baseline_modal.expect_between_dates from: "2023-05-19",
+ to: "2023-05-25",
+ from_time: "08:00",
+ to_time: "20:00"
baseline_modal.expect_offset berlin_utc_offset, count: 2
end
diff --git a/spec/features/work_packages/table/baseline/baseline_rendering_spec.rb b/spec/features/work_packages/table/baseline/baseline_rendering_spec.rb
index 402fe968728c..fb851d6bd95d 100644
--- a/spec/features/work_packages/table/baseline/baseline_rendering_spec.rb
+++ b/spec/features/work_packages/table/baseline/baseline_rendering_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'baseline rendering',
+RSpec.describe "baseline rendering",
:js,
:with_cuprite,
- with_settings: { date_format: '%Y-%m-%d' } do
+ with_settings: { date_format: "%Y-%m-%d" } do
shared_let(:list_wp_custom_field) { create(:list_wp_custom_field) }
shared_let(:multi_list_wp_custom_field) { create(:list_wp_custom_field, multi_value: true) }
shared_let(:version_wp_custom_field) { create(:version_wp_custom_field) }
@@ -67,35 +67,35 @@
end
shared_let(:user) do
create(:admin,
- firstname: 'Itsa',
- lastname: 'Me',
+ firstname: "Itsa",
+ lastname: "Me",
member_with_permissions: { project => %i[view_work_packages edit_work_packages work_package_assigned
assign_versions] })
end
shared_let(:assignee) do
create(:user,
- firstname: 'Assigned',
- lastname: 'User',
+ firstname: "Assigned",
+ lastname: "User",
member_with_permissions: { project => %i[view_work_packages edit_work_packages work_package_assigned] })
end
shared_let(:default_priority) do
- create(:issue_priority, name: 'Default', is_default: true)
+ create(:issue_priority, name: "Default", is_default: true)
end
shared_let(:high_priority) do
- create(:issue_priority, name: 'High priority')
+ create(:issue_priority, name: "High priority")
end
- shared_let(:version_a) { create(:version, project:, name: 'Version A') }
- shared_let(:version_b) { create(:version, project:, name: 'Version B') }
+ shared_let(:version_a) { create(:version, project:, name: "Version A") }
+ shared_let(:version_b) { create(:version, project:, name: "Version B") }
shared_let(:wp_bug) do
create(:work_package,
project:,
type: type_bug,
- subject: 'A bug',
+ subject: "A bug",
created_at: 5.days.ago,
updated_at: 5.days.ago)
end
@@ -104,7 +104,7 @@
create(:work_package,
project:,
type: type_task,
- subject: 'A task',
+ subject: "A task",
created_at: 5.days.ago,
updated_at: 5.days.ago)
@@ -119,16 +119,16 @@
responsible: assignee,
priority: default_priority,
version: version_a,
- subject: 'Old subject',
- start_date: '2023-05-01',
- due_date: '2023-05-02')
+ subject: "Old subject",
+ start_date: "2023-05-01",
+ due_date: "2023-05-02")
end
Timecop.travel(1.day.ago) do
WorkPackages::UpdateService
.new(user:, model: wp)
.call(
- subject: 'New subject',
+ subject: "New subject",
start_date: Time.zone.today - 1.day,
due_date: Time.zone.today,
assigned_to: user,
@@ -160,7 +160,7 @@
shared_let(:wp_task_was_bug) do
wp = Timecop.travel(5.days.ago) do
- create(:work_package, project:, type: type_bug, subject: 'Bug changed to Task')
+ create(:work_package, project:, type: type_bug, subject: "Bug changed to Task")
end
Timecop.travel(1.day.ago) do
@@ -174,7 +174,7 @@
shared_let(:wp_bug_was_task) do
wp = Timecop.travel(5.days.ago) do
- create(:work_package, project:, type: type_task, subject: 'Task changed to Bug')
+ create(:work_package, project:, type: type_task, subject: "Task changed to Bug")
end
Timecop.travel(1.day.ago) do
@@ -191,7 +191,7 @@
create(:work_package,
project:,
type: type_milestone,
- subject: 'Milestone 1',
+ subject: "Milestone 1",
start_date: Time.zone.today,
due_date: Time.zone.today)
end
@@ -206,7 +206,7 @@
shared_let(:initial_custom_values) do
{
int_wp_custom_field.id => 1,
- string_wp_custom_field.id => 'this is a string',
+ string_wp_custom_field.id => "this is a string",
bool_wp_custom_field.id => true,
float_wp_custom_field.id => nil,
date_wp_custom_field.id => Date.yesterday,
@@ -220,7 +220,7 @@
shared_let(:changed_custom_values) do
{
"custom_field_#{int_wp_custom_field.id}": nil,
- "custom_field_#{string_wp_custom_field.id}": 'this is a changed string',
+ "custom_field_#{string_wp_custom_field.id}": "this is a changed string",
"custom_field_#{bool_wp_custom_field.id}": false,
"custom_field_#{float_wp_custom_field.id}": 3.7,
"custom_field_#{date_wp_custom_field.id}": Time.zone.today,
@@ -241,7 +241,7 @@
:skip_validations,
project:,
type: type_task,
- subject: 'A task with CFs',
+ subject: "A task with CFs",
custom_values: initial_custom_values)
end
end
@@ -255,12 +255,12 @@
shared_let(:query) do
query = create(:query,
- name: 'Timestamps Query',
+ name: "Timestamps Query",
project:,
user:)
query.timestamps = ["P-2d", "PT0S"]
- query.add_filter('type_id', '=', [type_task.id, type_milestone.id])
+ query.add_filter("type_id", "=", [type_task.id, type_milestone.id])
query.column_names =
%w[id subject status type start_date due_date version priority assigned_to responsible] +
CustomField.all.pluck(:id).map { |id| "cf_#{id}" }
@@ -276,8 +276,8 @@
current_user { user }
- describe 'with EE', with_ee: %i[baseline_comparison] do
- it 'does show changes' do
+ describe "with EE", with_ee: %i[baseline_comparison] do
+ it "does show changes" do
wp_table.visit_query(query)
wp_table.expect_work_package_listed wp_task, wp_task_changed, wp_task_was_bug, wp_bug_was_task,
wp_task_assigned, wp_milestone_date_changed
@@ -298,16 +298,16 @@
type: %w[TASK BUG]
baseline.expect_changed_attributes wp_task_changed,
- subject: ['Old subject', 'New subject'],
- startDate: ['2023-05-01', (today - 2.days).iso8601],
- dueDate: ['2023-05-02', (today - 1.day).iso8601],
- version: ['Version A', 'Version B'],
- priority: ['Default', 'High priority'],
- assignee: ['Assigned User', 'Itsa Me'],
- responsible: ['Assigned User', 'Itsa Me']
+ subject: ["Old subject", "New subject"],
+ startDate: ["2023-05-01", (today - 2.days).iso8601],
+ dueDate: ["2023-05-02", (today - 1.day).iso8601],
+ version: ["Version A", "Version B"],
+ priority: ["Default", "High priority"],
+ assignee: ["Assigned User", "Itsa Me"],
+ responsible: ["Assigned User", "Itsa Me"]
baseline.expect_changed_attributes wp_task_assigned,
- assignee: ['-', 'Itsa Me']
+ assignee: ["-", "Itsa Me"]
baseline.expect_changed_attributes wp_milestone_date_changed,
startDate: [
@@ -326,20 +326,20 @@
baseline.expect_changed_attributes wp_task_cf,
"customField#{int_wp_custom_field.id}": [
- '1',
- '-'
+ "1",
+ "-"
],
"customField#{string_wp_custom_field.id}": [
- 'this is a string',
- 'this is a changed string'
+ "this is a string",
+ "this is a changed string"
],
"customField#{bool_wp_custom_field.id}": [
- 'yes',
- 'no'
+ "yes",
+ "no"
],
"customField#{float_wp_custom_field.id}": [
- '-',
- '3.7'
+ "-",
+ "3.7"
],
"customField#{date_wp_custom_field.id}": [
Date.yesterday.iso8601,
@@ -354,12 +354,12 @@
"A, B"
],
"customField#{user_wp_custom_field.id}": [
- 'Assigned User',
- '-'
+ "Assigned User",
+ "-"
],
"customField#{version_wp_custom_field.id}": [
- 'Version A',
- 'Version B'
+ "Version A",
+ "Version B"
]
# Shows changes even if columns not showing
@@ -367,68 +367,68 @@
query.save!
wp_table.visit_query(query)
- baseline.expect_icon wp_milestone_date_changed, 'changed'
+ baseline.expect_icon wp_milestone_date_changed, "changed"
end
- shared_examples_for 'selecting a builtin view' do
- let(:builtin_view_name) { 'All open' }
+ shared_examples_for "selecting a builtin view" do
+ let(:builtin_view_name) { "All open" }
before do
- within '#main-menu' do
+ within "#main-menu" do
click_link builtin_view_name
end
end
- it 'does not show changes or render baseline details' do
+ it "does not show changes or render baseline details" do
wp_table.expect_title builtin_view_name
baseline.expect_inactive
baseline.expect_no_legends
baseline_modal.toggle_drop_modal
- baseline_modal.expect_selected '-'
+ baseline_modal.expect_selected "-"
end
end
- context 'when a baseline filter is set' do
+ context "when a baseline filter is set" do
before do
wp_table.visit!
wait_for_reload # Ensure page is fully loaded
baseline_modal.toggle_drop_modal
- baseline_modal.select_filter 'yesterday'
+ baseline_modal.select_filter "yesterday"
baseline_modal.apply
wait_for_reload # Ensure page is fully loaded
end
- context 'and the query is saved' do
+ context "and the query is saved" do
before do
- wp_table.save_as('My Baseline Query', by_title: true)
+ wp_table.save_as("My Baseline Query", by_title: true)
end
- it_behaves_like 'selecting a builtin view'
+ it_behaves_like "selecting a builtin view"
end
- context 'and the query is not saved' do
- it_behaves_like 'selecting a builtin view'
+ context "and the query is not saved" do
+ it_behaves_like "selecting a builtin view"
end
end
end
- describe 'without EE', with_ee: false do
- it 'disabled options' do
+ describe "without EE", with_ee: false do
+ it "disabled options" do
wp_table.visit_query(query)
baseline_modal.expect_closed
baseline_modal.toggle_drop_modal
baseline_modal.expect_open
expect(page).to have_css(".op-baseline--enterprise-title")
# only yesterday is selectable
- page.select('a specific date', from: 'op-baseline-filter')
- expect(page).to have_no_select('op-baseline-filter', selected: 'a specific date')
+ page.select("a specific date", from: "op-baseline-filter")
+ expect(page).to have_no_select("op-baseline-filter", selected: "a specific date")
- page.select('yesterday', from: 'op-baseline-filter')
- expect(page).to have_select('op-baseline-filter', selected: 'yesterday')
+ page.select("yesterday", from: "op-baseline-filter")
+ expect(page).to have_select("op-baseline-filter", selected: "yesterday")
end
end
end
diff --git a/spec/features/work_packages/table/configuration_modal/column_spec.rb b/spec/features/work_packages/table/configuration_modal/column_spec.rb
index 50538dcab351..51d272727f7d 100644
--- a/spec/features/work_packages/table/configuration_modal/column_spec.rb
+++ b/spec/features/work_packages/table/configuration_modal/column_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work Package table configuration modal columns spec', :js do
+RSpec.describe "Work Package table configuration modal columns spec", :js do
let(:user) { create(:admin) }
let(:project) { create(:project) }
@@ -22,31 +22,31 @@
login_as(user)
wp_table.visit_query query
wp_table.expect_work_package_listed work_package
- expect(page).to have_css('.wp-table--table-header', text: 'ID')
- expect(page).to have_css('.wp-table--table-header', text: 'SUBJECT')
+ expect(page).to have_css(".wp-table--table-header", text: "ID")
+ expect(page).to have_css(".wp-table--table-header", text: "SUBJECT")
end
- shared_examples 'add and remove columns' do
+ shared_examples "add and remove columns" do
it do
columns.open_modal
- columns.expect_checked 'ID'
- columns.expect_checked 'Subject'
+ columns.expect_checked "ID"
+ columns.expect_checked "Subject"
- columns.remove 'Subject', save_changes: false
- columns.add 'Project', save_changes: true
- columns.expect_column_available 'Subject'
- columns.expect_column_not_available 'Project'
+ columns.remove "Subject", save_changes: false
+ columns.add "Project", save_changes: true
+ columns.expect_column_available "Subject"
+ columns.expect_column_not_available "Project"
- expect(page).to have_css('.wp-table--table-header', text: 'ID')
- expect(page).to have_css('.wp-table--table-header', text: 'PROJECT')
- expect(page).to have_no_css('.wp-table--table-header', text: 'SUBJECT')
+ expect(page).to have_css(".wp-table--table-header", text: "ID")
+ expect(page).to have_css(".wp-table--table-header", text: "PROJECT")
+ expect(page).to have_no_css(".wp-table--table-header", text: "SUBJECT")
end
end
- context 'When seeing the table' do
- it_behaves_like 'add and remove columns'
+ context "When seeing the table" do
+ it_behaves_like "add and remove columns"
- context 'with three columns', driver: :firefox_de do
+ context "with three columns", driver: :firefox_de do
let!(:query) do
query = build(:query, user:, project:)
query.column_names = %w[id project subject]
@@ -55,15 +55,15 @@
query
end
- it 'can reorder columns' do
+ it "can reorder columns" do
columns.open_modal
- columns.expect_checked 'ID'
- columns.expect_checked 'Project'
- columns.expect_checked 'Subject'
+ columns.expect_checked "ID"
+ columns.expect_checked "Project"
+ columns.expect_checked "Subject"
# Drag subject left of project
- subject_column = columns.column_item('Subject').find('span')
- project_column = columns.column_item('Project').find('span')
+ subject_column = columns.column_item("Subject").find("span")
+ project_column = columns.column_item("Project").find("span")
page
.driver
@@ -76,11 +76,11 @@
sleep 1
columns.apply
- expect(page).to have_css('.wp-table--table-header', text: 'ID')
- expect(page).to have_css('.wp-table--table-header', text: 'PROJECT')
- expect(page).to have_css('.wp-table--table-header', text: 'SUBJECT')
+ expect(page).to have_css(".wp-table--table-header", text: "ID")
+ expect(page).to have_css(".wp-table--table-header", text: "PROJECT")
+ expect(page).to have_css(".wp-table--table-header", text: "SUBJECT")
- names = all('.wp-table--table-header').map(&:text)
+ names = all(".wp-table--table-header").map(&:text)
# Depending on what browser is used, subject column may be first or second
# it doesn't matter for the outcome of this test
expect(names).to eq(%w[SUBJECT ID PROJECT]).or(eq(%w[ID SUBJECT PROJECT]))
diff --git a/spec/features/work_packages/table/configuration_modal/filter_spec.rb b/spec/features/work_packages/table/configuration_modal/filter_spec.rb
index 27694868bd28..7e58c08409dc 100644
--- a/spec/features/work_packages/table/configuration_modal/filter_spec.rb
+++ b/spec/features/work_packages/table/configuration_modal/filter_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work Package table configuration modal filters spec', :js do
+RSpec.describe "Work Package table configuration modal filters spec", :js do
let(:user) { create(:admin) }
let(:project) { create(:project) }
@@ -12,7 +12,7 @@
let!(:query) do
query = build(:query, user:, project:)
- query.column_names = ['subject', 'done_ratio']
+ query.column_names = ["subject", "done_ratio"]
query.save!
query
@@ -22,7 +22,7 @@
login_as(user)
end
- context 'by version in project' do
+ context "by version in project" do
let(:version) { create(:version, project:) }
let(:work_package_with_version) { create(:work_package, project:, version:) }
let(:work_package_without_version) { create(:work_package, project:) }
@@ -34,22 +34,22 @@
wp_table.visit!
end
- it 'allows filtering, saving, retrieving and altering the saved filter' do
+ it "allows filtering, saving, retrieving and altering the saved filter" do
wp_table.expect_work_package_listed work_package_with_version, work_package_without_version
filters.open
filters.expect_filter_count 2
- filters.add_filter_by('Version', 'is (OR)', version.name)
+ filters.add_filter_by("Version", "is (OR)", version.name)
filters.save
wp_table.expect_work_package_listed work_package_with_version
wp_table.ensure_work_package_not_listed! work_package_without_version
- wp_table.save_as('Some query name')
+ wp_table.save_as("Some query name")
filters.open
filters.expect_filter_count 3
- filters.remove_filter 'version'
+ filters.remove_filter "version"
filters.save
loading_indicator_saveguard
diff --git a/spec/features/work_packages/table/configuration_modal/table_configuration_modal_spec.rb b/spec/features/work_packages/table/configuration_modal/table_configuration_modal_spec.rb
index 2cf00353f1a6..2e48119623c0 100644
--- a/spec/features/work_packages/table/configuration_modal/table_configuration_modal_spec.rb
+++ b/spec/features/work_packages/table/configuration_modal/table_configuration_modal_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work Package table configuration modal', :js do
+RSpec.describe "Work Package table configuration modal", :js do
let(:user) { create(:admin) }
let(:project) { create(:project) }
@@ -11,7 +11,7 @@
let!(:query) do
query = build(:query, user:, project:)
- query.column_names = ['subject', 'done_ratio']
+ query.column_names = ["subject", "done_ratio"]
query.save!
query
@@ -24,14 +24,14 @@
wp_table.expect_work_package_listed wp_1
end
- it 'focuses on the columns tab when opened through header' do
+ it "focuses on the columns tab when opened through header" do
# Open header dropdown
- find('.work-package-table--container th #subject').click
+ find(".work-package-table--container th #subject").click
# Open insert columns entry
- find('#column-context-menu .menu-item', text: 'Insert columns').click
+ find("#column-context-menu .menu-item", text: "Insert columns").click
# Expect active tab is columns
- expect(page).to have_css('.op-tab-row--link_selected', text: 'COLUMNS')
+ expect(page).to have_css(".op-tab-row--link_selected", text: "COLUMNS")
end
end
diff --git a/spec/features/work_packages/table/context_menu/context_menu_shared_examples.rb b/spec/features/work_packages/table/context_menu/context_menu_shared_examples.rb
index 3503e0025235..f09dfbb757db 100644
--- a/spec/features/work_packages/table/context_menu/context_menu_shared_examples.rb
+++ b/spec/features/work_packages/table/context_menu/context_menu_shared_examples.rb
@@ -1,92 +1,92 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.shared_examples_for 'provides a single WP context menu' do
- let(:open_context_menu) { raise 'needs to be defined' }
+RSpec.shared_examples_for "provides a single WP context menu" do
+ let(:open_context_menu) { raise "needs to be defined" }
let(:destroy_modal) { Components::WorkPackages::DestroyModal.new }
let(:time_logging_modal) { Components::TimeLoggingModal.new }
let(:wp_timeline) { Pages::WorkPackagesTimeline.new(work_package.project) }
- it 'provides a context menu' do
+ it "provides a context menu" do
# Open detail pane
open_context_menu.call
- menu.choose('Open details view')
+ menu.choose("Open details view")
split_page = Pages::SplitWorkPackage.new(work_package, work_package.project)
split_page.expect_attributes Subject: work_package.subject
# Open full view
open_context_menu.call
- menu.choose('Open fullscreen view')
- expect(page).to have_css('.work-packages--show-view .inline-edit--container.subject',
+ menu.choose("Open fullscreen view")
+ expect(page).to have_css(".work-packages--show-view .inline-edit--container.subject",
text: work_package.subject)
# Open log time
open_context_menu.call
- menu.choose('Log time')
+ menu.choose("Log time")
time_logging_modal.is_visible true
time_logging_modal.work_package_is_missing false
- time_logging_modal.perform_action 'Cancel'
+ time_logging_modal.perform_action "Cancel"
# Open Move
open_context_menu.call
- menu.choose('Change project')
- expect(page).to have_css('h2', text: I18n.t(:button_move))
- expect(page).to have_css('a.work_package', text: "##{work_package.id}")
+ menu.choose("Change project")
+ expect(page).to have_css("h2", text: I18n.t(:button_move))
+ expect(page).to have_css("a.work_package", text: "##{work_package.id}")
# Open Copy
open_context_menu.call
- menu.choose('Copy')
+ menu.choose("Copy")
# Split view open in copy state
expect(page)
- .to have_css('.wp-new-top-row',
+ .to have_css(".wp-new-top-row",
text: "#{work_package.status.name.capitalize}\n#{work_package.type.name.upcase}")
- expect(page).to have_field('wp-new-inline-edit--field-subject', with: work_package.subject)
+ expect(page).to have_field("wp-new-inline-edit--field-subject", with: work_package.subject)
# Open Delete
open_context_menu.call
- menu.choose('Delete')
+ menu.choose("Delete")
destroy_modal.expect_listed(work_package)
destroy_modal.cancel_deletion
# Open create new child
open_context_menu.call
- menu.choose('Create new child')
- expect(page).to have_css('.inline-edit--container.subject input')
+ menu.choose("Create new child")
+ expect(page).to have_css(".inline-edit--container.subject input")
expect(current_url).to match(/.*\/create_new\?.*(&)*parent_id=#{work_package.id}/)
- find_by_id('work-packages--edit-actions-cancel').click
- expect(page).to have_no_css('.inline-edit--container.subject input')
+ find_by_id("work-packages--edit-actions-cancel").click
+ expect(page).to have_no_css(".inline-edit--container.subject input")
# Timeline actions only shown when open
wp_timeline.expect_timeline!(open: false)
open_context_menu.call
- menu.expect_no_options 'Add predecessor', 'Add follower, Show relations'
+ menu.expect_no_options "Add predecessor", "Add follower, Show relations"
# Copy to other project
open_context_menu.call
- menu.choose('Copy to other project')
- expect(page).to have_css('h2', text: I18n.t(:button_copy))
- expect(page).to have_css('a.work_package', text: "##{work_package.id}")
+ menu.choose("Copy to other project")
+ expect(page).to have_css("h2", text: I18n.t(:button_copy))
+ expect(page).to have_css("a.work_package", text: "##{work_package.id}")
end
- describe 'creating work packages' do
+ describe "creating work packages" do
let!(:priority) { create(:issue_priority, is_default: true) }
let!(:status) { create(:default_status) }
- it 'can create a new child from the context menu (Regression #33329)' do
+ it "can create a new child from the context menu (Regression #33329)" do
open_context_menu.call
- menu.choose('Create new child')
- expect(page).to have_css('.inline-edit--container.subject input')
+ menu.choose("Create new child")
+ expect(page).to have_css(".inline-edit--container.subject input")
expect(current_url).to match(/.*\/create_new\?.*(&)*parent_id=#{work_package.id}/)
split_view = Pages::SplitWorkPackageCreate.new project: work_package.project
subject = split_view.edit_field(:subject)
- subject.set_value 'Child task'
+ subject.set_value "Child task"
# Wait a bit for the split view to be fully initialized
sleep 1
subject.submit_by_enter
- split_view.expect_and_dismiss_toaster message: 'Successful creation.'
+ split_view.expect_and_dismiss_toaster message: "Successful creation."
expect(page).to have_css('[data-test-selector="op-wp-breadcrumb"]', text: "Parent:\n#{work_package.subject}")
wp = WorkPackage.last
expect(wp.parent).to eq work_package
diff --git a/spec/features/work_packages/table/context_menu/context_menu_spec.rb b/spec/features/work_packages/table/context_menu/context_menu_spec.rb
index 39845bd9e298..e919047e0981 100644
--- a/spec/features/work_packages/table/context_menu/context_menu_spec.rb
+++ b/spec/features/work_packages/table/context_menu/context_menu_spec.rb
@@ -1,7 +1,7 @@
-require 'spec_helper'
-require_relative 'context_menu_shared_examples'
+require "spec_helper"
+require_relative "context_menu_shared_examples"
-RSpec.describe 'Work package table context menu',
+RSpec.describe "Work package table context menu",
:js,
:with_cuprite do
shared_let(:user) { create(:admin) }
@@ -16,7 +16,7 @@
query = build(:query_with_view_gantt, user:, project:)
query.filters.clear
query.timeline_visible = true
- query.name = 'Query with Timeline'
+ query.name = "Query with Timeline"
query.save!
@@ -28,8 +28,8 @@
work_package
end
- context 'when in the table' do
- it_behaves_like 'provides a single WP context menu' do
+ context "when in the table" do
+ it_behaves_like "provides a single WP context menu" do
let(:open_context_menu) do
-> {
# Go to table
@@ -43,10 +43,10 @@
}
end
- context 'for multiple selected WPs' do
+ context "for multiple selected WPs" do
let!(:work_package2) { create(:work_package, project: work_package.project) }
- it 'provides a context menu with a subset of the available menu items' do
+ it "provides a context menu with a subset of the available menu items" do
# Go to table
wp_table.visit!
@@ -55,17 +55,17 @@
wp_table.expect_work_package_listed(work_package2)
# Select all WPs
- find('body').send_keys [:control, 'a']
+ find("body").send_keys [:control, "a"]
menu.open_for(work_package)
- menu.expect_options 'Open details view', 'Open fullscreen view',
- 'Bulk edit', 'Bulk copy', 'Bulk change of project', 'Bulk delete'
+ menu.expect_options "Open details view", "Open fullscreen view",
+ "Bulk edit", "Bulk copy", "Bulk change of project", "Bulk delete"
end
end
end
- context 'when in Gantt' do
- it 'provides a context menu with timeline options' do
+ context "when in Gantt" do
+ it "provides a context menu with timeline options" do
wp_timeline.visit_query(query_tl)
loading_indicator_saveguard
wp_timeline.expect_work_package_listed(work_package)
@@ -74,11 +74,11 @@
# Open context menu
menu.expect_closed
menu.open_for(work_package)
- menu.expect_options 'Open details view', 'Open fullscreen view', 'Add predecessor', 'Add follower', 'Show relations'
- menu.expect_no_options 'Log time'
+ menu.expect_options "Open details view", "Open fullscreen view", "Add predecessor", "Add follower", "Show relations"
+ menu.expect_no_options "Log time"
# Show relations tab when selecting show-relations from menu
- menu.choose('Show relations')
+ menu.choose("Show relations")
expect(page).to have_current_path /details\/#{work_package.id}\/relations/
end
end
diff --git a/spec/features/work_packages/table/delete_work_packages_spec.rb b/spec/features/work_packages/table/delete_work_packages_spec.rb
index 4eef1626ce62..42ce18edbd1e 100644
--- a/spec/features/work_packages/table/delete_work_packages_spec.rb
+++ b/spec/features/work_packages/table/delete_work_packages_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Delete work package', :js do
+RSpec.describe "Delete work package", :js do
let(:user) { create(:admin) }
let(:context_menu) { Components::WorkPackages::ContextMenu.new }
let(:destroy_modal) { Components::WorkPackages::DestroyModal.new }
@@ -37,8 +37,8 @@
login_as(user)
end
- shared_examples 'close split view' do
- describe 'when deleting a work package that is opened in the split view' do
+ shared_examples "close split view" do
+ describe "when deleting a work package that is opened in the split view" do
before do
work_package
@@ -46,7 +46,7 @@
split_view.ensure_page_loaded
context_menu.open_for(work_package)
- context_menu.choose('Delete')
+ context_menu.choose("Delete")
destroy_modal.expect_listed(work_package)
destroy_modal.confirm_deletion
@@ -54,35 +54,35 @@
loading_indicator_saveguard
end
- it 'closes the split view' do
+ it "closes the split view" do
split_view.expect_closed
wp_table.expect_current_path
end
end
end
- describe 'deleting multiple work packages in the table' do
+ describe "deleting multiple work packages in the table" do
let!(:wp1) { create(:work_package) }
let!(:wp2) { create(:work_package) }
let!(:wp_child) { create(:work_package, parent: wp1) }
let(:wp_table) { Pages::WorkPackagesTable.new }
- it 'shows deletion for all selected work packages' do
+ it "shows deletion for all selected work packages" do
wp_table.visit!
wp_table.expect_work_package_listed wp1, wp2, wp_child
- find('body').send_keys [:control, 'a']
+ find("body").send_keys [:control, "a"]
context_menu.open_for(wp1)
- context_menu.choose('Bulk delete')
+ context_menu.choose("Bulk delete")
destroy_modal.expect_listed(wp1, wp2, wp_child)
destroy_modal.cancel_deletion
wp_table.expect_work_package_listed wp1, wp2, wp_child
context_menu.open_for(wp1)
- context_menu.choose('Bulk delete')
+ context_menu.choose("Bulk delete")
destroy_modal.confirm_children_deletion
destroy_modal.confirm_deletion
@@ -91,20 +91,20 @@
end
end
- describe 'when deleting it outside a project context' do
+ describe "when deleting it outside a project context" do
let(:work_package) { create(:work_package) }
let(:split_view) { Pages::SplitWorkPackage.new(work_package) }
let(:wp_table) { Pages::WorkPackagesTable.new }
- it_behaves_like 'close split view'
+ it_behaves_like "close split view"
end
- describe 'when deleting it within a project context' do
+ describe "when deleting it within a project context" do
let(:project) { create(:project) }
let(:work_package) { create(:work_package, project:) }
let(:split_view) { Pages::SplitWorkPackage.new(work_package, project.identifier) }
let(:wp_table) { Pages::WorkPackagesTable.new(project.identifier) }
- it_behaves_like 'close split view'
+ it_behaves_like "close split view"
end
end
diff --git a/spec/features/work_packages/table/duration_field_spec.rb b/spec/features/work_packages/table/duration_field_spec.rb
index 81dbb374c80a..38fc4268b96a 100644
--- a/spec/features/work_packages/table/duration_field_spec.rb
+++ b/spec/features/work_packages/table/duration_field_spec.rb
@@ -1,11 +1,11 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Duration field in the work package table', :js do
+RSpec.describe "Duration field in the work package table", :js do
shared_let(:current_user) { create(:admin) }
shared_let(:work_package) do
next_monday = Time.zone.today.beginning_of_week.next_occurring(:monday)
create(:work_package,
- subject: 'moved',
+ subject: "moved",
author: current_user,
start_date: next_monday,
due_date: next_monday.next_occurring(:thursday))
@@ -32,12 +32,12 @@
wp_table.expect_work_package_listed work_package
end
- it 'shows the duration as days and opens the datepicker on click' do
- duration.expect_state_text '4 days'
+ it "shows the duration as days and opens the datepicker on click" do
+ duration.expect_state_text "4 days"
duration.activate!
date_field.expect_duration_highlighted
expect(page).to have_focus_on("#{test_selector('op-datepicker-modal--duration-field')} input[name='duration']")
- expect(page).to have_field('duration', with: '4', wait: 10)
+ expect(page).to have_field("duration", with: "4", wait: 10)
end
end
diff --git a/spec/features/work_packages/table/edit_work_packages_spec.rb b/spec/features/work_packages/table/edit_work_packages_spec.rb
index 72c409906413..6b49032e6fb3 100644
--- a/spec/features/work_packages/table/edit_work_packages_spec.rb
+++ b/spec/features/work_packages/table/edit_work_packages_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Inline editing work packages', :js do
+RSpec.describe "Inline editing work packages", :js do
let(:manager_role) do
create(:project_role,
permissions: %i[view_work_packages
@@ -8,8 +8,8 @@
end
let(:manager) do
create(:user,
- firstname: 'Manager',
- lastname: 'Guy',
+ firstname: "Manager",
+ lastname: "Guy",
member_with_roles: { project => manager_role })
end
let(:type) { create(:type) }
@@ -22,7 +22,7 @@
project:,
type:,
status: status1,
- subject: 'Foobar')
+ subject: "Foobar")
end
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
@@ -41,7 +41,7 @@
login_as(manager)
end
- context 'simple work package' do
+ context "simple work package" do
before do
work_package
workflow
@@ -50,35 +50,35 @@
wp_table.expect_work_package_listed(work_package)
end
- it 'allows updating and seeing the results' do
+ it "allows updating and seeing the results" do
subject_field = wp_table.edit_field(work_package, :subject)
- subject_field.expect_text('Foobar')
+ subject_field.expect_text("Foobar")
subject_field.activate!
- subject_field.set_value('New subject!')
+ subject_field.set_value("New subject!")
expect(WorkPackages::UpdateService).to receive(:new).and_call_original
subject_field.save!
- subject_field.expect_text('New subject!')
+ subject_field.expect_text("New subject!")
wp_table.expect_toast(
- message: 'Successful update. Click here to open this work package in fullscreen view.'
+ message: "Successful update. Click here to open this work package in fullscreen view."
)
work_package.reload
- expect(work_package.subject).to eq('New subject!')
+ expect(work_package.subject).to eq("New subject!")
end
- it 'allows to subsequently edit multiple fields' do
+ it "allows to subsequently edit multiple fields" do
subject_field = wp_table.edit_field(work_package, :subject)
status_field = wp_table.edit_field(work_package, :status)
subject_field.activate!
- subject_field.set_value('Other subject!')
+ subject_field.set_value("Other subject!")
subject_field.save!
- wp_table.expect_and_dismiss_toaster(message: 'Successful update')
+ wp_table.expect_and_dismiss_toaster(message: "Successful update")
status_field.activate!
status_field.set_value(status2.name)
@@ -86,36 +86,36 @@
subject_field.expect_inactive!
status_field.expect_inactive!
- subject_field.expect_text('Other subject!')
+ subject_field.expect_text("Other subject!")
status_field.expect_text(status2.name)
- wp_table.expect_and_dismiss_toaster(message: 'Successful update')
+ wp_table.expect_and_dismiss_toaster(message: "Successful update")
work_package.reload
- expect(work_package.subject).to eq('Other subject!')
+ expect(work_package.subject).to eq("Other subject!")
expect(work_package.status.id).to eq(status2.id)
end
- it 'provides error handling' do
+ it "provides error handling" do
subject_field = wp_table.edit_field(work_package, :subject)
- subject_field.expect_text('Foobar')
+ subject_field.expect_text("Foobar")
subject_field.activate!
- subject_field.set_value('')
+ subject_field.set_value("")
subject_field.expect_invalid
subject_field.save!
- expect(work_package.reload.subject).to eq 'Foobar'
+ expect(work_package.reload.subject).to eq "Foobar"
end
end
- context 'custom field' do
+ context "custom field" do
let!(:custom_fields) do
fields = [
create(
:work_package_custom_field,
- field_format: 'list',
+ field_format: "list",
possible_values: %w(foo bar xyz),
is_required: false,
is_for_all: false,
@@ -124,7 +124,7 @@
),
create(
:work_package_custom_field,
- field_format: 'string',
+ field_format: "string",
is_required: false,
is_for_all: false,
types: [type],
@@ -138,7 +138,7 @@
let(:project) { create(:project, types: [type]) }
let!(:work_package) do
create(:work_package,
- subject: 'Foobar',
+ subject: "Foobar",
status: status1,
type:,
project:)
@@ -155,12 +155,12 @@
wp_table.expect_work_package_listed(work_package)
end
- it 'opens required custom fields when not set' do
+ it "opens required custom fields when not set" do
subject_field = wp_table.edit_field(work_package, :subject)
- subject_field.expect_text('Foobar')
+ subject_field.expect_text("Foobar")
subject_field.activate!
- subject_field.set_value('New subject!')
+ subject_field.set_value("New subject!")
subject_field.save!
# Should raise two errors
@@ -171,28 +171,28 @@
message: "#{cf_list_name} can't be blank.\n#{cf_text_name} can't be blank."
)
- expect(page).to have_css('th a', text: cf_list_name.upcase)
- expect(page).to have_css('th a', text: cf_text_name.upcase)
- expect(wp_table.row(work_package)).to have_css('.wp-table--cell-container.-error', count: 2)
+ expect(page).to have_css("th a", text: cf_list_name.upcase)
+ expect(page).to have_css("th a", text: cf_text_name.upcase)
+ expect(wp_table.row(work_package)).to have_css(".wp-table--cell-container.-error", count: 2)
cf_text = wp_table.edit_field(work_package, custom_fields.last.attribute_name(:camel_case))
- cf_text.update('my custom text', expect_failure: true)
+ cf_text.update("my custom text", expect_failure: true)
cf_list = wp_table.edit_field(work_package, custom_fields.first.attribute_name(:camel_case))
- cf_list.field_type = 'create-autocompleter'
+ cf_list.field_type = "create-autocompleter"
cf_list.openSelectField
- cf_list.set_value('bar')
+ cf_list.set_value("bar")
cf_text.expect_inactive!
cf_list.expect_inactive!
wp_table.expect_toast(
- message: 'Successful update. Click here to open this work package in fullscreen view.'
+ message: "Successful update. Click here to open this work package in fullscreen view."
)
work_package.reload
- expect(work_package.send(custom_fields.first.attribute_getter)).to eq('bar')
- expect(work_package.send(custom_fields.last.attribute_getter)).to eq('my custom text')
+ expect(work_package.send(custom_fields.first.attribute_getter)).to eq("bar")
+ expect(work_package.send(custom_fields.last.attribute_getter)).to eq("my custom text")
# Saveguard to let the background update complete
wp_table.visit!
diff --git a/spec/features/work_packages/table/empty_filters_spec.rb b/spec/features/work_packages/table/empty_filters_spec.rb
index 8053a2766181..cb9a70163369 100644
--- a/spec/features/work_packages/table/empty_filters_spec.rb
+++ b/spec/features/work_packages/table/empty_filters_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Empty query filters', :js do
+RSpec.describe "Empty query filters", :js do
let(:user) { create(:admin) }
let(:work_package) { create(:work_package) }
let(:wp_table) { Pages::WorkPackagesTable.new }
@@ -14,7 +14,7 @@
end
# Tests for regression #23739
- it 'allows to delete the last query filter' do
+ it "allows to delete the last query filter" do
# Open filter menu
filters.expect_filter_count(1)
filters.open
diff --git a/spec/features/work_packages/table/group_by/group_by_boolean_spec.rb b/spec/features/work_packages/table/group_by/group_by_boolean_spec.rb
index bea6f49e021e..881cace61ab1 100644
--- a/spec/features/work_packages/table/group_by/group_by_boolean_spec.rb
+++ b/spec/features/work_packages/table/group_by/group_by_boolean_spec.rb
@@ -1,10 +1,10 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work Package group by boolean field', :js do
+RSpec.describe "Work Package group by boolean field", :js do
let(:user) { create(:admin) }
let(:project) { create(:project, types: [type], work_package_custom_fields: [bool_cf]) }
- let(:bool_cf) { create(:boolean_wp_custom_field, name: 'booleanField', types: [type]) }
+ let(:bool_cf) { create(:boolean_wp_custom_field, name: "booleanField", types: [type]) }
let(:type) { create(:type) }
let!(:wp1) { create(:work_package, project:, type:) }
@@ -20,15 +20,15 @@
wp_table.expect_work_package_listed wp1, wp2, wp3
end
- it 'shows group headers for groups by bool cf (regression test #34904)' do
+ it "shows group headers for groups by bool cf (regression test #34904)" do
# Group by category
- group_by.enable_via_menu 'booleanField'
+ group_by.enable_via_menu "booleanField"
loading_indicator_saveguard
# Expect table to be grouped
group_by.expect_number_of_groups 3
- group_by.expect_grouped_by_value '-', 1
- group_by.expect_grouped_by_value 'true', 1
- group_by.expect_grouped_by_value 'false', 1
+ group_by.expect_grouped_by_value "-", 1
+ group_by.expect_grouped_by_value "true", 1
+ group_by.expect_grouped_by_value "false", 1
end
end
diff --git a/spec/features/work_packages/table/group_by/group_by_progress_spec.rb b/spec/features/work_packages/table/group_by/group_by_progress_spec.rb
index 9fdbe3a8e908..fdf97f538e20 100644
--- a/spec/features/work_packages/table/group_by/group_by_progress_spec.rb
+++ b/spec/features/work_packages/table/group_by/group_by_progress_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work Package group by progress', :js do
+RSpec.describe "Work Package group by progress", :js do
let(:user) { create(:admin) }
let(:project) { create(:project) }
@@ -15,7 +15,7 @@
let!(:query) do
query = build(:query, user:, project:)
- query.column_names = ['subject', 'done_ratio']
+ query.column_names = ["subject", "done_ratio"]
query.save!
query
@@ -28,39 +28,39 @@
wp_table.expect_work_package_listed wp_1, wp_2, wp_3, wp_4
end
- it 'shows group headers for group by progress (regression test #26717)' do
+ it "shows group headers for group by progress (regression test #26717)" do
# Group by category
- group_by.enable_via_menu '% Complete'
+ group_by.enable_via_menu "% Complete"
# Expect table to be grouped as WP created above
group_by.expect_number_of_groups 3
- group_by.expect_grouped_by_value '0%', 1
- group_by.expect_grouped_by_value '10%', 2
- group_by.expect_grouped_by_value '50%', 1
+ group_by.expect_grouped_by_value "0%", 1
+ group_by.expect_grouped_by_value "10%", 2
+ group_by.expect_grouped_by_value "50%", 1
# Update category of wp_none
cat = wp_table.edit_field(wp_1, :percentageDone)
- cat.update '50'
+ cat.update "50"
loading_indicator_saveguard
# Expect changed groups
group_by.expect_number_of_groups 2
- group_by.expect_grouped_by_value '10%', 2
- group_by.expect_grouped_by_value '50%', 2
+ group_by.expect_grouped_by_value "10%", 2
+ group_by.expect_grouped_by_value "50%", 2
end
- context 'with grouped query' do
+ context "with grouped query" do
let!(:query) do
query = build(:query, user:, project:)
- query.column_names = ['subject', 'done_ratio']
- query.group_by = 'done_ratio'
+ query.column_names = ["subject", "done_ratio"]
+ query.group_by = "done_ratio"
query.save!
query
end
- it 'keeps the disabled group by when reloading (Regression WP#26778)' do
+ it "keeps the disabled group by when reloading (Regression WP#26778)" do
# Expect table to be grouped as WP created above
group_by.expect_number_of_groups 3
@@ -73,7 +73,7 @@
# But query has not been changed
query.reload
- expect(query.group_by).to eq 'done_ratio'
+ expect(query.group_by).to eq "done_ratio"
end
end
end
diff --git a/spec/features/work_packages/table/group_by/group_by_spec.rb b/spec/features/work_packages/table/group_by/group_by_spec.rb
index b9b0fb6cbb01..7eff288e4f81 100644
--- a/spec/features/work_packages/table/group_by/group_by_spec.rb
+++ b/spec/features/work_packages/table/group_by/group_by_spec.rb
@@ -28,9 +28,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work Package group by progress', :js do
+RSpec.describe "Work Package group by progress", :js do
let(:user) { create(:admin) }
let(:project) { create(:project) }
let(:group_by) { Components::WorkPackages::GroupBy.new }
@@ -49,6 +49,6 @@
# Expect table to be grouped into 1 group
group_by.expect_number_of_groups 1
- group_by.expect_grouped_by_value '0%', 3
+ group_by.expect_grouped_by_value "0%", 3
end
end
diff --git a/spec/features/work_packages/table/group_by/group_headers_spec.rb b/spec/features/work_packages/table/group_by/group_headers_spec.rb
index 37e32290854c..b215e7a89565 100644
--- a/spec/features/work_packages/table/group_by/group_headers_spec.rb
+++ b/spec/features/work_packages/table/group_by/group_headers_spec.rb
@@ -1,11 +1,11 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work Package table group headers', :js do
+RSpec.describe "Work Package table group headers", :js do
let(:user) { create(:admin) }
let(:project) { create(:project) }
- let(:category) { create(:category, project:, name: 'Foo') }
- let(:category2) { create(:category, project:, name: 'Bar') }
+ let(:category) { create(:category, project:, name: "Foo") }
+ let(:category2) { create(:category, project:, name: "Bar") }
let!(:wp_cat1) { create(:work_package, project:, category:) }
let!(:wp_cat2) { create(:work_package, project:, category: category2) }
@@ -15,7 +15,7 @@
let!(:query) do
query = build(:query, user:, project:)
- query.column_names = ['subject', 'category']
+ query.column_names = ["subject", "category"]
query.show_hierarchies = false
query.save!
@@ -31,26 +31,26 @@
wp_table.expect_work_package_listed(wp_none)
end
- it 'shows group headers for group by category' do
+ it "shows group headers for group by category" do
# Group by category
- group_by.enable_via_menu 'Category'
+ group_by.enable_via_menu "Category"
# Expect table to be grouped as WP created above
group_by.expect_number_of_groups 3
- group_by.expect_grouped_by_value 'Foo', 1
- group_by.expect_grouped_by_value 'Bar', 1
- group_by.expect_grouped_by_value '-', 1
+ group_by.expect_grouped_by_value "Foo", 1
+ group_by.expect_grouped_by_value "Bar", 1
+ group_by.expect_grouped_by_value "-", 1
# Update category of wp_none
cat = wp_table.edit_field(wp_none, :category)
cat.activate!
- cat.set_value 'Foo'
+ cat.set_value "Foo"
loading_indicator_saveguard
# Expect changed groups
group_by.expect_number_of_groups 2
- group_by.expect_grouped_by_value 'Foo', 2
- group_by.expect_grouped_by_value 'Bar', 1
+ group_by.expect_grouped_by_value "Foo", 2
+ group_by.expect_grouped_by_value "Bar", 1
end
end
diff --git a/spec/features/work_packages/table/hierarchy/hierarchy_indent_spec.rb b/spec/features/work_packages/table/hierarchy/hierarchy_indent_spec.rb
index 50e7bfc931fb..aef59c3dd233 100644
--- a/spec/features/work_packages/table/hierarchy/hierarchy_indent_spec.rb
+++ b/spec/features/work_packages/table/hierarchy/hierarchy_indent_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work Package table hierarchy and sorting', :js, :with_cuprite do
+RSpec.describe "Work Package table hierarchy and sorting", :js, :with_cuprite do
shared_let(:project) { create(:project) }
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
@@ -10,33 +10,33 @@
shared_let(:wp_root) do
create(:work_package,
project:,
- subject: 'Parent')
+ subject: "Parent")
end
shared_let(:wp_child1) do
create(:work_package,
project:,
parent: wp_root,
- subject: 'WP child 1')
+ subject: "WP child 1")
end
shared_let(:wp_child2) do
create(:work_package,
project:,
parent: wp_root,
- subject: 'WP child 2')
+ subject: "WP child 2")
end
shared_let(:wp_child3) do
create(:work_package,
project:,
parent: wp_root,
- subject: 'WP child 3')
+ subject: "WP child 3")
end
shared_current_user { create(:admin) }
- it 'can indent hierarchies' do
+ it "can indent hierarchies" do
wp_table.visit!
wp_table.expect_work_package_listed(wp_root, wp_child1, wp_child2, wp_child3)
hierarchy.expect_hierarchy_at(wp_root)
@@ -51,7 +51,7 @@
# Indent last child
hierarchy.indent! wp_child3
- wp_table.expect_and_dismiss_toaster message: 'Successful update.'
+ wp_table.expect_and_dismiss_toaster message: "Successful update."
hierarchy.expect_hierarchy_at(wp_root, wp_child2)
hierarchy.expect_leaf_at(wp_child1, wp_child3)
@@ -69,33 +69,33 @@
expect(wp_child3.parent).to eq(wp_child2)
end
- it 'can edit a work package, then indent, and then edit again (Regression #30994)' do
+ it "can edit a work package, then indent, and then edit again (Regression #30994)" do
wp_table.visit!
wp_table.expect_work_package_listed(wp_root, wp_child1, wp_child2, wp_child3)
hierarchy.expect_hierarchy_at(wp_root)
hierarchy.expect_leaf_at(wp_child1, wp_child2, wp_child3)
subject = wp_table.edit_field(wp_child3, :subject)
- subject.update 'First edit'
+ subject.update "First edit"
wait_for_network_idle
- wp_table.expect_and_dismiss_toaster message: 'Successful update.'
+ wp_table.expect_and_dismiss_toaster message: "Successful update."
# Indent last child
hierarchy.indent! wp_child3
wait_for_network_idle
- wp_table.expect_and_dismiss_toaster message: 'Successful update.'
+ wp_table.expect_and_dismiss_toaster message: "Successful update."
# Expect changed
hierarchy.expect_hierarchy_at(wp_root, wp_child2)
hierarchy.expect_leaf_at(wp_child1, wp_child3)
subject = wp_table.edit_field(wp_child3, :subject)
- subject.update 'Second edit'
+ subject.update "Second edit"
wait_for_network_idle
- wp_table.expect_and_dismiss_toaster message: 'Successful update.'
+ wp_table.expect_and_dismiss_toaster message: "Successful update."
wp_child3.reload
- expect(wp_child3.subject).to eq 'Second edit'
+ expect(wp_child3.subject).to eq "Second edit"
expect(wp_child3.parent).to eq wp_child2
end
end
diff --git a/spec/features/work_packages/table/hierarchy/hierarchy_parent_below_spec.rb b/spec/features/work_packages/table/hierarchy/hierarchy_parent_below_spec.rb
index cfacef7ab2fd..75ff409c095e 100644
--- a/spec/features/work_packages/table/hierarchy/hierarchy_parent_below_spec.rb
+++ b/spec/features/work_packages/table/hierarchy/hierarchy_parent_below_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work Package table hierarchy parent below', :js do
+RSpec.describe "Work Package table hierarchy parent below", :js do
let(:user) { create(:admin) }
let(:type_bug) { create(:type_bug) }
let(:type_task) { create(:type_task) }
@@ -33,17 +33,17 @@
# .. V Parent
# .... Child
# V Grandparent
- describe 'grand-parent sorted below child, parent invisible' do
+ describe "grand-parent sorted below child, parent invisible" do
let(:child) { create(:work_package, project:, type: type_task) }
let(:parent) { create(:work_package, project:, type: type_bug) }
let(:grandparent) { create(:work_package, project:, type: type_task) }
let(:query) do
query = build(:query, user:, project:)
- query.column_names = ['id', 'subject', 'type']
+ query.column_names = ["id", "subject", "type"]
query.sort_criteria = [%w(id asc)]
query.filters.clear
- query.add_filter('type_id', '=', [type_task.id])
+ query.add_filter("type_id", "=", [type_task.id])
query.show_hierarchies = true
query.save!
@@ -61,7 +61,7 @@
query
end
- it 'shows hierarchy correctly' do
+ it "shows hierarchy correctly" do
wp_table.visit_query query
wp_table.expect_work_package_listed(child, parent, grandparent)
@@ -93,11 +93,11 @@
end
end
- describe 'grand-parent of 2+ children visible anywhere on the page, but parent is not (Regression #29652)' do
- let(:child) { create(:work_package, subject: 'AA Child WP', project:, type: type_task) }
- let(:child2) { create(:work_package, subject: 'BB Child WP', project:, type: type_task) }
- let(:parent) { create(:work_package, subject: 'ZZ Parent WP', project:, type: type_task) }
- let(:grandparent) { create(:work_package, subject: 'Grandparent', project:, type: type_task) }
+ describe "grand-parent of 2+ children visible anywhere on the page, but parent is not (Regression #29652)" do
+ let(:child) { create(:work_package, subject: "AA Child WP", project:, type: type_task) }
+ let(:child2) { create(:work_package, subject: "BB Child WP", project:, type: type_task) }
+ let(:parent) { create(:work_package, subject: "ZZ Parent WP", project:, type: type_task) }
+ let(:grandparent) { create(:work_package, subject: "Grandparent", project:, type: type_task) }
let(:query) do
query = build(:query, user:, project:)
@@ -118,20 +118,20 @@
child2.update(parent_id: parent.id)
parent.update(parent_id: grandparent.id)
- allow(Setting).to receive(:per_page_options).and_return '3'
+ allow(Setting).to receive(:per_page_options).and_return "3"
query
end
- it 'shows hierarchy correctly' do
+ it "shows hierarchy correctly" do
wp_table.visit_query query
wp_table.expect_work_package_listed(child, child2, parent, grandparent)
# Expect pagination to be correct
- expect(page).to have_css('.op-pagination--item_current', text: '3')
+ expect(page).to have_css(".op-pagination--item_current", text: "3")
# Expect count to be correct (one additional parent shown)
- expect(page).to have_css('.wp--row', count: 4)
+ expect(page).to have_css(".wp--row", count: 4)
# Double order result from regression
wp_table.expect_work_package_order(grandparent.id, parent.id, child.id, child2.id)
@@ -142,9 +142,9 @@
end
end
- describe 'An arrow is beside parent name' do
- let(:child) { create(:work_package, subject: 'AA Child WP', project:, parent:) }
- let(:parent) { create(:work_package, subject: 'ZZ Parent WP', project:) }
+ describe "An arrow is beside parent name" do
+ let(:child) { create(:work_package, subject: "AA Child WP", project:, parent:) }
+ let(:parent) { create(:work_package, subject: "ZZ Parent WP", project:) }
let(:relations) { Components::WorkPackages::Relations.new(parent) }
before do
@@ -155,14 +155,14 @@
wp_table.visit!
wp_table.expect_work_package_listed(child, parent)
- expect(page).to have_css('.wp-table--hierarchy-indicator-icon')
+ expect(page).to have_css(".wp-table--hierarchy-indicator-icon")
split_page = wp_table.open_split_view(parent)
split_page.visit_tab!("relations")
relations.remove_child(child)
loading_indicator_saveguard
- expect(page).to have_no_css('.wp-table--hierarchy-indicator-icon')
+ expect(page).to have_no_css(".wp-table--hierarchy-indicator-icon")
end
end
end
diff --git a/spec/features/work_packages/table/hierarchy/hierarchy_sorting_spec.rb b/spec/features/work_packages/table/hierarchy/hierarchy_sorting_spec.rb
index 705b0fb5a6b4..a36c81e3e81c 100644
--- a/spec/features/work_packages/table/hierarchy/hierarchy_sorting_spec.rb
+++ b/spec/features/work_packages/table/hierarchy/hierarchy_sorting_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work Package table hierarchy and sorting', :js do
+RSpec.describe "Work Package table hierarchy and sorting", :js do
let(:user) { create(:admin) }
let(:project) { create(:project) }
@@ -11,7 +11,7 @@
let!(:wp_root) do
create(:work_package,
project:,
- subject: 'Parent',
+ subject: "Parent",
start_date: 10.days.ago,
due_date: Date.current)
end
@@ -20,7 +20,7 @@
create(:work_package,
project:,
parent: wp_root,
- subject: 'Child at end',
+ subject: "Child at end",
start_date: 2.days.ago,
due_date: Date.current)
end
@@ -29,7 +29,7 @@
create(:work_package,
project:,
parent: wp_root,
- subject: 'Middle child',
+ subject: "Middle child",
start_date: 5.days.ago,
due_date: 3.days.ago)
end
@@ -38,7 +38,7 @@
create(:work_package,
project:,
parent: wp_root,
- subject: 'Child at beginning',
+ subject: "Child at beginning",
start_date: 10.days.ago,
due_date: 9.days.ago)
end
@@ -47,7 +47,7 @@
login_as(user)
end
- it 'can show hierarchies and sort by start_date' do
+ it "can show hierarchies and sort by start_date" do
wp_table.visit!
wp_table.expect_work_package_listed(wp_root, wp_child1, wp_child2, wp_child3)
hierarchy.expect_hierarchy_at(wp_root)
@@ -57,7 +57,7 @@
wp_table.expect_work_package_order wp_root, wp_child1, wp_child2, wp_child3
# Enable sort by start date
- sort_by.update_criteria ['Start date', 'asc']
+ sort_by.update_criteria ["Start date", "asc"]
loading_indicator_saveguard
# Hierarchy still exists
diff --git a/spec/features/work_packages/table/hierarchy/hierarchy_spec.rb b/spec/features/work_packages/table/hierarchy/hierarchy_spec.rb
index d1e3a8d0b35a..04bd7c2b2306 100644
--- a/spec/features/work_packages/table/hierarchy/hierarchy_spec.rb
+++ b/spec/features/work_packages/table/hierarchy/hierarchy_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work Package table hierarchy', :js do
+RSpec.describe "Work Package table hierarchy", :js do
let(:user) { create(:admin) }
let(:project) { create(:project) }
@@ -11,8 +11,8 @@
login_as(user)
end
- describe 'hierarchies in same project' do
- let(:category) { create(:category, project:, name: 'Foo') }
+ describe "hierarchies in same project" do
+ let(:category) { create(:category, project:, name: "Foo") }
let!(:wp_root) { create(:work_package, project:) }
let!(:wp_inter) { create(:work_package, project:, parent: wp_root) }
@@ -21,16 +21,16 @@
let!(:query) do
query = build(:query, user:, project:)
- query.column_names = ['subject', 'category']
+ query.column_names = ["subject", "category"]
query.filters.clear
- query.add_filter('category_id', '=', [category.id])
+ query.add_filter("category_id", "=", [category.id])
query.show_hierarchies = true
query.save!
query
end
- it 'shows hierarchy correctly' do
+ it "shows hierarchy correctly" do
wp_table.visit!
wp_table.expect_work_package_listed(wp_root, wp_inter, wp_leaf, wp_other)
@@ -57,9 +57,9 @@
# Editing is possible while retaining hierarchy
hierarchy.enable_hierarchy
subject = wp_table.edit_field wp_inter, :subject
- subject.update 'New subject'
+ subject.update "New subject"
- wp_table.expect_toast message: 'Successful update.'
+ wp_table.expect_toast message: "Successful update."
wp_table.dismiss_toaster!
hierarchy.expect_hierarchy_at(wp_root, wp_inter)
@@ -88,13 +88,13 @@
end
end
- describe 'with a cross project hierarchy' do
+ describe "with a cross project hierarchy" do
let(:project2) { create(:project) }
let!(:wp_root) { create(:work_package, project:) }
let!(:wp_inter) { create(:work_package, project: project2, parent: wp_root) }
let(:global_table) { Pages::WorkPackagesTable.new }
- it 'shows the hierarchy indicator only when the rows are both shown' do
+ it "shows the hierarchy indicator only when the rows are both shown" do
wp_table.visit!
wp_table.expect_work_package_listed(wp_root)
wp_table.ensure_work_package_not_listed!(wp_inter)
@@ -108,23 +108,23 @@
end
end
- describe 'flat table such that the parent appears below the child' do
+ describe "flat table such that the parent appears below the child" do
let!(:wp_root) { create(:work_package, project:) }
let!(:wp_inter) { create(:work_package, project:, parent: wp_root) }
let!(:wp_leaf) { create(:work_package, project:, parent: wp_inter) }
let!(:query) do
query = build(:query, user:, project:)
- query.column_names = ['subject', 'category']
+ query.column_names = ["subject", "category"]
query.filters.clear
query.show_hierarchies = false
- query.sort_criteria = [['id', 'asc']]
+ query.sort_criteria = [["id", "asc"]]
query.save!
query
end
- it 'removes the parent from the flow in hierarchy mode, moving it above' do
+ it "removes the parent from the flow in hierarchy mode, moving it above" do
# Hierarchy disabled, expect wp_inter before wp_root
wp_table.visit_query query
wp_table.expect_work_package_listed(wp_inter, wp_root, wp_leaf)
@@ -136,7 +136,7 @@
hierarchy.enable_hierarchy
# Should not be marked as additional row (grey)
- expect(page).to have_no_css('.wp-table--hierarchy-aditional-row')
+ expect(page).to have_no_css(".wp-table--hierarchy-aditional-row")
hierarchy.expect_hierarchy_at(wp_root, wp_inter)
hierarchy.expect_leaf_at(wp_leaf)
@@ -154,25 +154,25 @@
end
end
- describe 'sorting by assignee' do
- include_context 'work package table helpers'
+ describe "sorting by assignee" do
+ include_context "work package table helpers"
let(:root_assigned) do
- create(:work_package, subject: 'root_assigned', project:, assigned_to: user)
+ create(:work_package, subject: "root_assigned", project:, assigned_to: user)
end
let(:inter_assigned) do
- create(:work_package, subject: 'inter_assigned', project:, assigned_to: user, parent: root_assigned)
+ create(:work_package, subject: "inter_assigned", project:, assigned_to: user, parent: root_assigned)
end
let(:inter) do
- create(:work_package, subject: 'inter', project:, parent: root_assigned)
+ create(:work_package, subject: "inter", project:, parent: root_assigned)
end
let(:leaf_assigned) do
- create(:work_package, subject: 'leaf_assigned', project:, assigned_to: user, parent: inter)
+ create(:work_package, subject: "leaf_assigned", project:, assigned_to: user, parent: inter)
end
let(:leaf) do
- create(:work_package, subject: 'leaf', project:, parent: inter)
+ create(:work_package, subject: "leaf", project:, parent: inter)
end
let(:root) do
- create(:work_package, subject: 'root', project:)
+ create(:work_package, subject: "root", project:)
end
let(:user) do
@@ -185,9 +185,9 @@
let!(:query) do
query = build(:query, user:, project:)
- query.column_names = ['id', 'subject', 'assigned_to']
+ query.column_names = ["id", "subject", "assigned_to"]
query.filters.clear
- query.sort_criteria = [['assigned_to', 'asc'], ['id', 'asc']]
+ query.sort_criteria = [["assigned_to", "asc"], ["id", "asc"]]
query.show_hierarchies = false
query.save!
@@ -205,7 +205,7 @@
leaf_assigned
end
- it 'shows the respective order' do
+ it "shows the respective order" do
wp_table.visit_query query
wp_table.expect_work_package_listed(leaf, inter, root)
wp_table.expect_work_package_listed(leaf_assigned, inter_assigned, root_assigned)
@@ -250,7 +250,7 @@
hierarchy.toggle_row(root_assigned)
# Sort descending
- sort_by.update_criteria(['Assignee', { descending: true }])
+ sort_by.update_criteria(["Assignee", { descending: true }])
loading_indicator_saveguard
wp_table.expect_work_package_listed(root, root_assigned)
diff --git a/spec/features/work_packages/table/hierarchy/hierarchy_vs_grouping_spec.rb b/spec/features/work_packages/table/hierarchy/hierarchy_vs_grouping_spec.rb
index 9e2f4f2a0e32..252976d4107a 100644
--- a/spec/features/work_packages/table/hierarchy/hierarchy_vs_grouping_spec.rb
+++ b/spec/features/work_packages/table/hierarchy/hierarchy_vs_grouping_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work Package table hierarchy vs grouping', :js do
+RSpec.describe "Work Package table hierarchy vs grouping", :js do
let(:user) { create(:admin) }
let(:project) { create(:project) }
@@ -40,25 +40,25 @@
login_as(user)
end
- it 'is mutually exclusive' do
+ it "is mutually exclusive" do
wp_table.visit!
hierarchy.expect_mode_enabled
- group_by.enable_via_header('Type')
+ group_by.enable_via_header("Type")
hierarchy.expect_mode_disabled
hierarchy.enable_via_menu
- group_by.expect_not_grouped_by('Type')
+ group_by.expect_not_grouped_by("Type")
- group_by.enable_via_menu('Type')
+ group_by.enable_via_menu("Type")
hierarchy.expect_mode_disabled
hierarchy.enable_via_header
- group_by.expect_not_grouped_by('Type')
+ group_by.expect_not_grouped_by("Type")
end
end
diff --git a/spec/features/work_packages/table/hierarchy/parent_column_spec.rb b/spec/features/work_packages/table/hierarchy/parent_column_spec.rb
index e4bf762a997d..a29da2d2bb0c 100644
--- a/spec/features/work_packages/table/hierarchy/parent_column_spec.rb
+++ b/spec/features/work_packages/table/hierarchy/parent_column_spec.rb
@@ -1,13 +1,13 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work Package table parent column', :js do
+RSpec.describe "Work Package table parent column", :js do
let(:user) { create(:admin) }
let!(:parent) { create(:work_package, project:) }
let!(:child) { create(:work_package, project:, parent:) }
let!(:other_wp) { create(:work_package, project:) }
let!(:query) do
query = build(:query, user:, project:)
- query.column_names = ['subject', 'parent']
+ query.column_names = ["subject", "parent"]
query.filters.clear
query.show_hierarchies = false
@@ -22,28 +22,28 @@
login_as(user)
end
- it 'shows parent columns correctly (Regression #26951)' do
+ it "shows parent columns correctly (Regression #26951)" do
wp_table.visit_query query
wp_table.expect_work_package_listed(parent, child)
# Hierarchy mode is enabled by default
page.within(".wp-row-#{parent.id}") do
- expect(page).to have_css('td.parent', text: '-')
+ expect(page).to have_css("td.parent", text: "-")
end
page.within(".wp-row-#{child.id}") do
- expect(page).to have_css('td.parent', text: "##{parent.id}")
+ expect(page).to have_css("td.parent", text: "##{parent.id}")
end
end
- it 'can edit the parent work package (Regression #43647)' do
+ it "can edit the parent work package (Regression #43647)" do
wp_table.visit_query query
wp_table.expect_work_package_listed(parent, child)
parent_field = wp_table.edit_field(child, :parent)
parent_field.update other_wp.subject
- wp_table.expect_and_dismiss_toaster message: 'Successful update.'
+ wp_table.expect_and_dismiss_toaster message: "Successful update."
child.reload
expect(child.parent).to eq other_wp
diff --git a/spec/features/work_packages/table/inline_create/create_work_packages_spec.rb b/spec/features/work_packages/table/inline_create/create_work_packages_spec.rb
index 8450cc93b072..4bcbd45d2a71 100644
--- a/spec/features/work_packages/table/inline_create/create_work_packages_spec.rb
+++ b/spec/features/work_packages/table/inline_create/create_work_packages_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'inline create work package', :js do
+RSpec.describe "inline create work package", :js do
let(:type) { create(:type) }
let(:types) { [type] }
@@ -28,67 +28,67 @@
login_as user
end
- shared_examples 'inline create work package' do
- context 'when user may create work packages' do
- it 'allows to create work packages' do
+ shared_examples "inline create work package" do
+ context "when user may create work packages" do
+ it "allows to create work packages" do
wp_table.expect_work_package_listed(existing_wp)
wp_table.click_inline_create
- expect(page).to have_css('.wp--row', count: 2)
- expect(page).to have_css('.wp-inline-create-row')
- expect(page).to have_focus_on('#wp-new-inline-edit--field-subject')
+ expect(page).to have_css(".wp--row", count: 2)
+ expect(page).to have_css(".wp-inline-create-row")
+ expect(page).to have_focus_on("#wp-new-inline-edit--field-subject")
# Expect subject to be activated
subject_field = wp_table.edit_field(nil, :subject)
subject_field.expect_active!
- subject_field.set_value 'Some subject'
+ subject_field.set_value "Some subject"
subject_field.save!
# Callback for adjustments
callback.call
wp_table.expect_toast(
- message: 'Successful creation. Click here to open this work package in fullscreen view.'
+ message: "Successful creation. Click here to open this work package in fullscreen view."
)
# Expect new create row to exist
- expect(page).to have_css('.wp--row', count: 2)
- expect(page).to have_button(exact_text: 'Create new work package')
+ expect(page).to have_css(".wp--row", count: 2)
+ expect(page).to have_button(exact_text: "Create new work package")
wp_table.click_inline_create
subject_field = wp_table.edit_field(nil, :subject)
subject_field.expect_active!
- subject_field.set_value 'Another subject'
+ subject_field.set_value "Another subject"
subject_field.save!
# Callback for adjustments
callback.call
- expect(page).to have_css('.wp--row .subject', text: 'Some subject')
- expect(page).to have_css('.wp--row .subject', text: 'Another subject')
+ expect(page).to have_css(".wp--row .subject", text: "Some subject")
+ expect(page).to have_css(".wp--row .subject", text: "Another subject")
# safeguards
wp_table.dismiss_toaster!
wp_table.expect_no_toaster(
- message: 'Successful update. Click here to open this work package in fullscreen view.'
+ message: "Successful update. Click here to open this work package in fullscreen view."
)
# Expect no inline create open
- expect(page).to have_no_css('.wp-inline-create-row')
+ expect(page).to have_no_css(".wp-inline-create-row")
end
end
- context 'when user may not create work packages' do
+ context "when user may not create work packages" do
let(:permissions) { [:view_work_packages] }
- it 'renders the work package, but no create row' do
+ it "renders the work package, but no create row" do
wp_table.expect_work_package_listed(existing_wp)
- expect(page).to have_no_button(exact_text: 'Create new work package')
+ expect(page).to have_no_button(exact_text: "Create new work package")
end
end
- context 'when having filtered by custom field and switching to that type' do
+ context "when having filtered by custom field and switching to that type" do
let(:cf_list) do
create(:list_wp_custom_field, is_for_all: true, is_filter: true)
end
@@ -98,10 +98,10 @@
let(:cf_type) { create(:type, custom_fields: [cf_list]) }
let(:columns) { Components::WorkPackages::Columns.new }
- it 'applies the filter value for the custom field' do
+ it "applies the filter value for the custom field" do
wp_table.visit!
filters.open
- filters.add_filter_by cf_list.name, 'is (OR)', cf_list.custom_options.second.name, cf_accessor_frontend
+ filters.add_filter_by cf_list.name, "is (OR)", cf_list.custom_options.second.name, cf_accessor_frontend
sleep(0.3)
@@ -118,16 +118,16 @@
wp_table.expect_toast(
type: :error,
- message: 'Subject can\'t be blank.'
+ message: "Subject can't be blank."
)
subject_field = wp_table.edit_field(nil, :subject)
subject_field.expect_active!
- subject_field.set_value 'Some subject'
+ subject_field.set_value "Some subject"
subject_field.save!
wp_table.expect_toast(
- message: 'Successful creation. Click here to open this work package in fullscreen view.'
+ message: "Successful creation. Click here to open this work package in fullscreen view."
)
created_wp = WorkPackage.last
@@ -138,14 +138,14 @@
end
end
- describe 'global create' do
+ describe "global create" do
let(:wp_table) { Pages::WorkPackagesTable.new }
before do
wp_table.visit!
end
- it_behaves_like 'inline create work package' do
+ it_behaves_like "inline create work package" do
let(:callback) do
-> {
# Set project which will also select the type (first one in the selected project)
@@ -159,20 +159,20 @@
end
end
- describe 'project context create' do
+ describe "project context create" do
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
before do
wp_table.visit!
end
- it_behaves_like 'inline create work package' do
+ it_behaves_like "inline create work package" do
let(:callback) do
-> {}
end
end
- context 'when user has permissions in other project' do
+ context "when user has permissions in other project" do
let(:permissions) { [:view_work_packages] }
let(:project2) { create(:project) }
@@ -188,10 +188,10 @@
roles: [role2])
end
- it 'renders the work packages, but no create' do
+ it "renders the work packages, but no create" do
wp_table.expect_work_package_listed(existing_wp)
- expect(page).to have_no_button(exact_text: 'Create new work package')
- expect(page).to have_css('.add-work-package[disabled]')
+ expect(page).to have_no_button(exact_text: "Create new work package")
+ expect(page).to have_css(".add-work-package[disabled]")
end
end
end
diff --git a/spec/features/work_packages/table/inline_create/inline_create_refresh_spec.rb b/spec/features/work_packages/table/inline_create/inline_create_refresh_spec.rb
index 84cbcd892863..9d362f9a59a0 100644
--- a/spec/features/work_packages/table/inline_create/inline_create_refresh_spec.rb
+++ b/spec/features/work_packages/table/inline_create/inline_create_refresh_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Refreshing in inline-create row', :flaky, :js do
+RSpec.describe "Refreshing in inline-create row", :flaky, :js do
let(:user) { create(:admin) }
let(:project) { create(:project) }
@@ -10,7 +10,7 @@
let!(:query) do
query = build(:query, user:, project:)
- query.column_names = ['subject', 'category']
+ query.column_names = ["subject", "category"]
query.filters.clear
query.save!
@@ -22,17 +22,17 @@
wp_table.visit_query(query)
end
- it 'correctly updates the set of active columns' do
- expect(page).to have_css('.wp--row', count: 0)
+ it "correctly updates the set of active columns" do
+ expect(page).to have_css(".wp--row", count: 0)
wp_table.click_inline_create
- expect(page).to have_css('.wp--row', count: 1)
+ expect(page).to have_css(".wp--row", count: 1)
- expect(page).to have_css('.wp-inline-create-row')
- expect(page).to have_css('.wp-inline-create-row .wp-table--cell-td.subject')
- expect(page).to have_css('.wp-inline-create-row .wp-table--cell-td.category')
+ expect(page).to have_css(".wp-inline-create-row")
+ expect(page).to have_css(".wp-inline-create-row .wp-table--cell-td.subject")
+ expect(page).to have_css(".wp-inline-create-row .wp-table--cell-td.category")
- columns.add '% Complete'
- expect(page).to have_css('.wp-inline-create-row .wp-table--cell-td.wp-table--cell-td.percentageDone')
+ columns.add "% Complete"
+ expect(page).to have_css(".wp-inline-create-row .wp-table--cell-td.wp-table--cell-td.percentageDone")
end
end
diff --git a/spec/features/work_packages/table/inline_create/parallel_creation_spec.rb b/spec/features/work_packages/table/inline_create/parallel_creation_spec.rb
index 0e9b73355720..aa26dda79bc5 100644
--- a/spec/features/work_packages/table/inline_create/parallel_creation_spec.rb
+++ b/spec/features/work_packages/table/inline_create/parallel_creation_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Parallel work package creation spec', :js do
+RSpec.describe "Parallel work package creation spec", :js do
let(:type) { project.types.first }
let(:permissions) { %i(view_work_packages add_work_packages edit_work_packages) }
@@ -35,39 +35,39 @@ def new_work_package_in_both(subject, description)
# Create in split screen
split = wp_table.create_wp_by_button type
- description_field = TextEditorField.new split, 'description'
+ description_field = TextEditorField.new split, "description"
description_field.expect_active!
description_field.set_value description
end
- it 'with a new work package in split and inline create, both are saved' do
+ it "with a new work package in split and inline create, both are saved" do
# Expect table to be empty
wp_table.visit!
wp_table.expect_no_work_package_listed
# Open split screen and inline create
- new_work_package_in_both 'Some subject', 'My description!'
+ new_work_package_in_both "Some subject", "My description!"
# Save in inline create
- expect(page).to have_css('.wp-inline-create-row')
- expect(page).to have_css('.wp--row', count: 1)
+ expect(page).to have_css(".wp-inline-create-row")
+ expect(page).to have_css(".wp--row", count: 1)
subject_field = wp_table.edit_field(nil, :subject)
subject_field.save!
# There should be one row, and no open inline create row
- expect(page).to have_css('.wp--row', count: 1)
- expect(page).to have_no_css('.wp-inline-create-row')
+ expect(page).to have_css(".wp--row", count: 1)
+ expect(page).to have_no_css(".wp-inline-create-row")
wp_table.expect_toast(
- message: 'Successful creation. Click here to open this work package in fullscreen view.'
+ message: "Successful creation. Click here to open this work package in fullscreen view."
)
wp_table.dismiss_toaster!
# Get the last work package
wp1 = WorkPackage.last
- expect(wp1.subject).to eq 'Some subject'
- expect(wp1.description).to eq 'My description!'
+ expect(wp1.subject).to eq "Some subject"
+ expect(wp1.description).to eq "My description!"
wp_table.expect_work_package_listed wp1
@@ -75,31 +75,31 @@ def new_work_package_in_both(subject, description)
created_split = Pages::SplitWorkPackage.new wp1, project
subject_field = created_split.edit_field :subject
subject_field.expect_inactive!
- subject_field.expect_state_text 'Some subject'
+ subject_field.expect_state_text "Some subject"
# Open split screen and inline create
- new_work_package_in_both 'New subject', 'New description'
+ new_work_package_in_both "New subject", "New description"
# Inline create still open
- expect(page).to have_css('.wp-inline-create-row')
+ expect(page).to have_css(".wp-inline-create-row")
# Save in split screen
new_split = Pages::SplitWorkPackageCreate.new(project:)
subject_field = new_split.edit_field :subject
subject_field.expect_active!
- subject_field.expect_value 'New subject'
+ subject_field.expect_value "New subject"
subject_field.save!
wp_table.expect_toast(
- message: 'Successful creation.'
+ message: "Successful creation."
)
wp_table.dismiss_toaster!
- expect(page).to have_css('.wp--row', count: 2)
- expect(page).to have_no_css('.wp-inline-create-row')
+ expect(page).to have_css(".wp--row", count: 2)
+ expect(page).to have_no_css(".wp-inline-create-row")
# Get the last work package
wp2 = WorkPackage.last
- expect(wp2.subject).to eq 'New subject'
- expect(wp2.description).to eq 'New description'
+ expect(wp2.subject).to eq "New subject"
+ expect(wp2.description).to eq "New description"
end
end
diff --git a/spec/features/work_packages/table/invalid_query_spec.rb b/spec/features/work_packages/table/invalid_query_spec.rb
index c95955c7a3e7..abb7c49432f9 100644
--- a/spec/features/work_packages/table/invalid_query_spec.rb
+++ b/spec/features/work_packages/table/invalid_query_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Invalid query spec', :js do
+RSpec.describe "Invalid query spec", :js do
let(:user) { create(:admin) }
let(:project) { create(:project) }
@@ -26,9 +26,9 @@
project:,
user:)
- query.add_filter('assigned_to_id', '=', [99999])
- query.columns << 'cf_0815'
- query.group_by = 'cf_0815'
+ query.add_filter("assigned_to_id", "=", [99999])
+ query.columns << "cf_0815"
+ query.group_by = "cf_0815"
query.sort_criteria = [%w(cf_0815 desc)]
query.save(validate: false)
create(:view_work_packages_table, query:)
@@ -57,55 +57,55 @@
work_package_assigned
end
- it 'handles invalid queries' do
+ it "handles invalid queries" do
# should load a faulty query and also the drop down
wp_table.visit_query(invalid_query)
filters.open
filters.expect_filter_count 1
- filters.expect_no_filter_by('Assignee')
- filters.expect_filter_by('Status', 'open', nil)
+ filters.expect_no_filter_by("Assignee")
+ filters.expect_filter_by("Status", "open", nil)
wp_table.expect_no_toaster(type: :error,
- message: I18n.t('js.work_packages.faulty_query.description'))
+ message: I18n.t("js.work_packages.faulty_query.description"))
wp_table.expect_work_package_listed work_package_assigned
wp_table.expect_query_in_select_dropdown(invalid_query.name)
- Capybara.current_session.driver.execute_script('window.localStorage.clear()')
+ Capybara.current_session.driver.execute_script("window.localStorage.clear()")
# should not load with faulty parameters but can be fixed
- filter_props = [{ n: 'assignee', o: '=', v: ['999999'] },
- { n: 'status', o: '=', v: [status.id.to_s, status2.id.to_s] }]
+ filter_props = [{ n: "assignee", o: "=", v: ["999999"] },
+ { n: "status", o: "=", v: [status.id.to_s, status2.id.to_s] }]
column_props = %w(id subject customField0815)
invalid_props = JSON.dump({ f: filter_props,
c: column_props,
- g: 'customField0815',
- t: 'customField0815:desc' })
+ g: "customField0815",
+ t: "customField0815:desc" })
wp_table.visit_with_params("query_id=#{valid_query.id}&query_props=#{invalid_props}")
wp_table.expect_toast(type: :error,
- message: I18n.t('js.work_packages.faulty_query.description'))
+ message: I18n.t("js.work_packages.faulty_query.description"))
wp_table.dismiss_toaster!
wp_table.expect_no_work_package_listed
filters.expect_filter_count 2
filters.open
- filters.expect_filter_by('Assignee', 'is (OR)', :placeholder)
- filters.expect_filter_by('Status', 'is (OR)', [status.name, status2.name])
+ filters.expect_filter_by("Assignee", "is (OR)", :placeholder)
+ filters.expect_filter_by("Status", "is (OR)", [status.name, status2.name])
- group_by.enable_via_menu('Assignee')
+ group_by.enable_via_menu("Assignee")
sleep(0.3)
- filters.set_filter('Assignee', 'is (OR)', user.name)
+ filters.set_filter("Assignee", "is (OR)", user.name)
sleep(0.3)
wp_table.expect_work_package_listed work_package_assigned
wp_table.save
- wp_table.expect_toast(message: I18n.t('js.notice_successful_update'))
+ wp_table.expect_toast(message: I18n.t("js.notice_successful_update"))
end
end
diff --git a/spec/features/work_packages/table/milestones_spec.rb b/spec/features/work_packages/table/milestones_spec.rb
index 702a42791ba1..2b74d9a7c9b5 100644
--- a/spec/features/work_packages/table/milestones_spec.rb
+++ b/spec/features/work_packages/table/milestones_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Inline editing milestones', :js do
+RSpec.describe "Inline editing milestones", :js do
let(:user) { create(:admin) }
let(:type) { create(:type, is_milestone: true) }
@@ -9,7 +9,7 @@
create(:work_package,
project:,
type:,
- subject: 'Foobar')
+ subject: "Foobar")
end
let!(:wp_table) { Pages::WorkPackagesTable.new(project) }
@@ -30,7 +30,7 @@
wp_table.expect_work_package_listed work_package
end
- it 'mapping for start and finish date in the table (regression #26044)' do
+ it "mapping for start and finish date in the table (regression #26044)" do
start_date = wp_table.edit_field(work_package, :startDate)
due_date = wp_table.edit_field(work_package, :dueDate)
@@ -48,14 +48,14 @@
start_date.expect_inactive!
due_date.expect_inactive!
- start_date.update '2017-08-07'
+ start_date.update "2017-08-07"
start_date.expect_inactive!
- start_date.expect_state_text '08/07/2017'
- due_date.expect_state_text '08/07/2017'
+ start_date.expect_state_text "08/07/2017"
+ due_date.expect_state_text "08/07/2017"
work_package.reload
expect work_package.milestone?
- expect(work_package.start_date.iso8601).to eq('2017-08-07')
- expect(work_package.due_date.iso8601).to eq('2017-08-07')
+ expect(work_package.start_date.iso8601).to eq("2017-08-07")
+ expect(work_package.due_date.iso8601).to eq("2017-08-07")
end
end
diff --git a/spec/features/work_packages/table/queries/assignee_filter_spec.rb b/spec/features/work_packages/table/queries/assignee_filter_spec.rb
index 547f7d34fc4f..ad0d73c314d4 100644
--- a/spec/features/work_packages/table/queries/assignee_filter_spec.rb
+++ b/spec/features/work_packages/table/queries/assignee_filter_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package filtering by assignee', :js do
+RSpec.describe "Work package filtering by assignee", :js do
let(:project) { create(:project) }
let(:invisible_project) { create(:project) }
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
@@ -36,14 +36,14 @@
let(:role) { create(:project_role, permissions: %i[view_work_packages save_queries]) }
let(:other_user) do
create(:user,
- firstname: 'Other',
- lastname: 'User',
+ firstname: "Other",
+ lastname: "User",
member_with_roles: { project => role })
end
let(:invisible_user) do
create(:user,
- firstname: 'Invisible',
- lastname: 'User',
+ firstname: "Invisible",
+ lastname: "User",
member_with_roles: { invisible_project => role })
end
let(:placeholder_user) do
@@ -65,21 +65,21 @@
create(:user, member_with_roles: { project => role })
end
- it 'shows the work package matching the assigned to filter' do
+ it "shows the work package matching the assigned to filter" do
wp_table.visit!
wp_table.expect_work_package_listed(work_package_user_assignee, work_package_placeholder_user_assignee)
filters.open
- filters.expect_missing_filter_value_by('Assignee', 'is (OR)', [invisible_user.name])
+ filters.expect_missing_filter_value_by("Assignee", "is (OR)", [invisible_user.name])
- filters.add_filter_by('Assignee', 'is (OR)', [other_user.name])
+ filters.add_filter_by("Assignee", "is (OR)", [other_user.name])
wp_table.ensure_work_package_not_listed!(work_package_placeholder_user_assignee)
wp_table.expect_work_package_listed(work_package_user_assignee)
- wp_table.save_as('Subject query')
+ wp_table.save_as("Subject query")
- wp_table.expect_and_dismiss_toaster(message: 'Successful creation.')
+ wp_table.expect_and_dismiss_toaster(message: "Successful creation.")
# Revisit query
wp_table.visit_query Query.last
@@ -87,9 +87,9 @@
wp_table.expect_work_package_listed(work_package_user_assignee)
filters.open
- filters.expect_filter_by('Assignee', 'is (OR)', [other_user.name])
- filters.remove_filter 'assignee'
- filters.add_filter_by('Assignee', 'is (OR)', [placeholder_user.name])
+ filters.expect_filter_by("Assignee", "is (OR)", [other_user.name])
+ filters.remove_filter "assignee"
+ filters.add_filter_by("Assignee", "is (OR)", [placeholder_user.name])
wp_table.ensure_work_package_not_listed!(work_package_user_assignee)
wp_table.expect_work_package_listed(work_package_placeholder_user_assignee)
diff --git a/spec/features/work_packages/table/queries/assignees_role_filter_spec.rb b/spec/features/work_packages/table/queries/assignees_role_filter_spec.rb
index 2f2cb0bd95b1..216722916e72 100644
--- a/spec/features/work_packages/table/queries/assignees_role_filter_spec.rb
+++ b/spec/features/work_packages/table/queries/assignees_role_filter_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe "Work package filtering by assignee's role", :js, :with_cuprite do
shared_let(:project) { create(:project) }
@@ -45,8 +45,8 @@
shared_let(:other_user) do
create(:user,
- firstname: 'Other',
- lastname: 'User',
+ firstname: "Other",
+ lastname: "User",
member_with_roles: { project => project_role, work_package_user_assignee => visible_work_package_role })
end
@@ -75,11 +75,11 @@
filters.open
# It does not show builtin roles such as Anonymous and NonMember or roles that don't allow the user to become an assignee
filters.expect_missing_filter_value_by("Assignee's role",
- 'is (OR)',
+ "is (OR)",
(builtin_roles + non_assignable_roles),
- 'assignedToRole')
+ "assignedToRole")
- filters.add_filter_by("Assignee's role", 'is (OR)', assignable_roles, 'assignedToRole')
+ filters.add_filter_by("Assignee's role", "is (OR)", assignable_roles, "assignedToRole")
filters.expect_filter_count("2")
@@ -93,8 +93,8 @@
sleep 1
- wp_table.save_as('Subject query', by_title: true)
- wp_table.expect_and_dismiss_toaster(message: 'Successful creation.')
+ wp_table.save_as("Subject query", by_title: true)
+ wp_table.expect_and_dismiss_toaster(message: "Successful creation.")
# Revisit query
wp_table.visit_query Query.last
@@ -103,9 +103,9 @@
filters.open
# Do not show the already selected roles in the autocomplete dropdown
- filters.expect_missing_autocomplete_value('assignedToRole', assignable_roles)
+ filters.expect_missing_autocomplete_value("assignedToRole", assignable_roles)
# Ensure that all assigned roles are shown in the filter
- filters.expect_filter_by("Assignee's role", 'is (OR)', assignable_roles, 'assignedToRole')
+ filters.expect_filter_by("Assignee's role", "is (OR)", assignable_roles, "assignedToRole")
end
end
diff --git a/spec/features/work_packages/table/queries/bool_cf_filter_spec.rb b/spec/features/work_packages/table/queries/bool_cf_filter_spec.rb
index 246b34a378fe..d5827945c2c4 100644
--- a/spec/features/work_packages/table/queries/bool_cf_filter_spec.rb
+++ b/spec/features/work_packages/table/queries/bool_cf_filter_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package filtering by bool custom field', :js do
+RSpec.describe "Work package filtering by bool custom field", :js do
let(:project) { create(:project) }
let(:type) { project.types.first }
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
@@ -74,7 +74,7 @@
member_with_permissions: { project => %i[view_work_packages save_queries] })
end
- it 'shows the work package matching the bool cf filter' do
+ it "shows the work package matching the bool cf filter" do
wp_table.visit!
wp_table.expect_work_package_listed(work_package_true, work_package_false, work_package_without, work_package_other_type)
@@ -86,9 +86,9 @@
wp_table.ensure_work_package_not_listed!(work_package_false, work_package_without, work_package_other_type)
wp_table.expect_work_package_listed(work_package_true)
- wp_table.save_as('Saved query')
+ wp_table.save_as("Saved query")
- wp_table.expect_and_dismiss_toaster(message: 'Successful creation.')
+ wp_table.expect_and_dismiss_toaster(message: "Successful creation.")
# Revisit query
wp_table.visit_query Query.last
diff --git a/spec/features/work_packages/table/queries/date_is_empty_filter_spec.rb b/spec/features/work_packages/table/queries/date_is_empty_filter_spec.rb
index af506d41aae5..f48f5791ae75 100644
--- a/spec/features/work_packages/table/queries/date_is_empty_filter_spec.rb
+++ b/spec/features/work_packages/table/queries/date_is_empty_filter_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe 'Filter by date with "is empty"', :js, :with_cuprite do
let(:user) { create(:admin) }
@@ -62,7 +62,7 @@
let(:custom_field_date) do
create(:date_wp_custom_field,
- name: 'Date CF',
+ name: "Date CF",
is_filter: true,
searchable: true) do |custom_field|
project.work_package_custom_fields << custom_field
@@ -79,7 +79,7 @@ def remove_default
wp_table.expect_work_package_listed work_package_without_dates, work_package_with_start_date, work_package_with_custom_date
filters.open
- filters.remove_filter('status')
+ filters.remove_filter("status")
end
before do
@@ -93,19 +93,19 @@ def remove_default
wp_table.visit!
end
- it 'works as intended for regular fields' do
+ it "works as intended for regular fields" do
remove_default
- filters.add_filter_by('Start date', 'is empty', nil, 'startDate')
+ filters.add_filter_by("Start date", "is empty", nil, "startDate")
wp_table.expect_work_package_listed work_package_without_dates
wp_table.ensure_work_package_not_listed! work_package_with_start_date
end
- it 'works as intended for custom fields' do
+ it "works as intended for custom fields" do
remove_default
- filters.add_filter_by('Date CF', 'is empty', nil, "customField#{custom_field_date.id}")
+ filters.add_filter_by("Date CF", "is empty", nil, "customField#{custom_field_date.id}")
wp_table.expect_work_package_listed work_package_without_dates
wp_table.ensure_work_package_not_listed! work_package_with_custom_date
diff --git a/spec/features/work_packages/table/queries/default_queries_spec.rb b/spec/features/work_packages/table/queries/default_queries_spec.rb
index f2e3053bf8e6..a8a04348ce4b 100644
--- a/spec/features/work_packages/table/queries/default_queries_spec.rb
+++ b/spec/features/work_packages/table/queries/default_queries_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Default work package queries', :js do
+RSpec.describe "Default work package queries", :js do
create_shared_association_defaults_for_work_package_factory
shared_let(:user) { create(:admin) }
@@ -36,21 +36,21 @@
let(:wp_table) { Pages::WorkPackagesTable.new(project_with_types) }
- describe 'Overdue' do
- let!(:work_package) { create(:work_package, subject: 'Not overdue', due_date: 5.days.from_now) }
- let!(:due_today_work_package) { create(:work_package, subject: 'Not overdue', due_date: Time.zone.today) }
- let!(:overdue_work_package_1_day_ago) { create(:work_package, subject: 'Overdue 1 day ago', due_date: 1.day.ago) }
- let!(:overdue_work_package_2_days_ago) { create(:work_package, subject: 'Overdue 2 days ago', due_date: 2.days.ago) }
+ describe "Overdue" do
+ let!(:work_package) { create(:work_package, subject: "Not overdue", due_date: 5.days.from_now) }
+ let!(:due_today_work_package) { create(:work_package, subject: "Not overdue", due_date: Time.zone.today) }
+ let!(:overdue_work_package_1_day_ago) { create(:work_package, subject: "Overdue 1 day ago", due_date: 1.day.ago) }
+ let!(:overdue_work_package_2_days_ago) { create(:work_package, subject: "Overdue 2 days ago", due_date: 2.days.ago) }
let!(:closed_status) { create(:closed_status) }
- let!(:closed_work_package) { create(:work_package, subject: 'Closed', status: closed_status, due_date: 10.days.ago) }
+ let!(:closed_work_package) { create(:work_package, subject: "Closed", status: closed_status, due_date: 10.days.ago) }
- it 'shows the overdue work package' do
+ it "shows the overdue work package" do
wp_table.visit!
wp_table.expect_work_package_listed work_package, due_today_work_package, overdue_work_package_1_day_ago,
overdue_work_package_2_days_ago
- click_link 'Overdue', wait: 10
+ click_link "Overdue", wait: 10
wp_table.expect_work_package_listed overdue_work_package_1_day_ago, overdue_work_package_2_days_ago
wp_table.ensure_work_package_not_listed! closed_work_package, work_package, due_today_work_package
diff --git a/spec/features/work_packages/table/queries/filter_pagination_spec.rb b/spec/features/work_packages/table/queries/filter_pagination_spec.rb
index 124acc8f64a3..54b34bc954d3 100644
--- a/spec/features/work_packages/table/queries/filter_pagination_spec.rb
+++ b/spec/features/work_packages/table/queries/filter_pagination_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/work_packages/work_packages_page'
+require "spec_helper"
+require "features/work_packages/work_packages_page"
-RSpec.describe 'Filter updates pagination', :js do
+RSpec.describe "Filter updates pagination", :js do
let(:user) do
create(:user,
member_with_permissions: { project => %i[view_work_packages] })
@@ -44,7 +44,7 @@
let(:work_package_2) { create(:work_package, project:) }
before do
- allow(Setting).to receive(:per_page_options).and_return '1'
+ allow(Setting).to receive(:per_page_options).and_return "1"
work_package_1
work_package_2
@@ -53,34 +53,34 @@
wp_table.visit!
end
- it 'resets page to 1 if changing filter' do
+ it "resets page to 1 if changing filter" do
wp_table.expect_work_package_listed work_package_1
wp_table.ensure_work_package_not_listed! work_package_2
# Expect pagination to be correct
- expect(page).to have_css('.op-pagination--item_current', text: '1')
+ expect(page).to have_css(".op-pagination--item_current", text: "1")
# Go to second page
- within('.op-pagination--pages') do
- find('.op-pagination--item button', text: '2').click
+ within(".op-pagination--pages") do
+ find(".op-pagination--item button", text: "2").click
end
wp_table.expect_work_package_listed work_package_2
wp_table.ensure_work_package_not_listed! work_package_1
# Expect pagination to be correct
- expect(page).to have_css('.op-pagination--item_current', text: '2')
+ expect(page).to have_css(".op-pagination--item_current", text: "2")
# Change filter to assigned to
filters.expect_filter_count 1
filters.open
- filters.add_filter_by 'Assignee', 'is (OR)', user.name
+ filters.add_filter_by "Assignee", "is (OR)", user.name
filters.expect_filter_count 2
wp_table.expect_work_package_listed work_package_1
wp_table.ensure_work_package_not_listed! work_package_2
# Expect pagination to be back to 1
- expect(page).to have_css('.op-pagination--range', text: '1 - 1/1')
+ expect(page).to have_css(".op-pagination--range", text: "1 - 1/1")
end
end
diff --git a/spec/features/work_packages/table/queries/filter_spec.rb b/spec/features/work_packages/table/queries/filter_spec.rb
index 22c0155c451d..5627aadac993 100644
--- a/spec/features/work_packages/table/queries/filter_spec.rb
+++ b/spec/features/work_packages/table/queries/filter_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'filter work packages', :js do
- shared_let(:user) { create(:admin, preferences: { time_zone: 'Etc/UTC' }) }
+RSpec.describe "filter work packages", :js do
+ shared_let(:user) { create(:admin, preferences: { time_zone: "Etc/UTC" }) }
shared_let(:watcher) { create(:user) }
shared_let(:role) { create(:existing_project_role, permissions: [:view_work_packages]) }
shared_let(:project) { create(:project, members: { watcher => role }) }
@@ -38,7 +38,7 @@
current_user { user }
- context 'by watchers' do
+ context "by watchers" do
let(:work_package_with_watcher) do
wp = build(:work_package, project:)
wp.add_watcher watcher
@@ -56,11 +56,11 @@
end
# Regression test for bug #24114 (broken watcher filter)
- it 'onlies filter work packages by watcher' do
+ it "onlies filter work packages by watcher" do
filters.open
loading_indicator_saveguard
- filters.add_filter_by 'Watcher', 'is (OR)', watcher.name
+ filters.add_filter_by "Watcher", "is (OR)", watcher.name
loading_indicator_saveguard
wp_table.expect_work_package_listed work_package_with_watcher
@@ -68,12 +68,12 @@
end
end
- context 'by version in project' do
+ context "by version in project" do
let(:version) { create(:version, project:) }
let(:work_package_with_version) do
- create(:work_package, project:, subject: 'With version', version:)
+ create(:work_package, project:, subject: "With version", version:)
end
- let(:work_package_without_version) { create(:work_package, subject: 'Without version', project:) }
+ let(:work_package_without_version) { create(:work_package, subject: "Without version", project:) }
before do
work_package_with_version
@@ -82,18 +82,18 @@
wp_table.visit!
end
- it 'allows filtering, saving, retrieving and altering the saved filter' do
+ it "allows filtering, saving, retrieving and altering the saved filter" do
filters.open
- filters.add_filter_by('Version', 'is (OR)', version.name)
+ filters.add_filter_by("Version", "is (OR)", version.name)
loading_indicator_saveguard
wp_table.expect_work_package_listed work_package_with_version
wp_table.ensure_work_package_not_listed! work_package_without_version
- wp_table.save_as('Some query name')
+ wp_table.save_as("Some query name")
- filters.remove_filter 'version'
+ filters.remove_filter "version"
loading_indicator_saveguard
wp_table.expect_work_package_listed work_package_with_version, work_package_without_version
@@ -108,9 +108,9 @@
filters.open
- filters.expect_filter_by('Version', 'is (OR)', version.name)
+ filters.expect_filter_by("Version", "is (OR)", version.name)
- filters.set_operator 'Version', 'is not'
+ filters.set_operator "Version", "is not"
loading_indicator_saveguard
wp_table.expect_work_package_listed work_package_without_version
@@ -118,13 +118,13 @@
end
end
- context 'when filtering by status in project' do
- let(:status) { create(:status, name: 'Open status') }
- let(:closed_status) { create(:closed_status, name: 'Closed status') }
+ context "when filtering by status in project" do
+ let(:status) { create(:status, name: "Open status") }
+ let(:closed_status) { create(:closed_status, name: "Closed status") }
let(:work_package_with_status) do
- create(:work_package, project:, subject: 'With open status', status:)
+ create(:work_package, project:, subject: "With open status", status:)
end
- let(:work_package_without_status) { create(:work_package, subject: 'With closed status', project:, status: closed_status) }
+ let(:work_package_without_status) { create(:work_package, subject: "With closed status", project:, status: closed_status) }
before do
work_package_with_status
@@ -133,12 +133,12 @@
wp_table.visit!
end
- it 'allows filtering and matching the selected value' do
+ it "allows filtering and matching the selected value" do
filters.open
filters.remove_filter :status
filters.expect_no_filter_by :status
- filters.add_filter_by('Status', 'is (OR)', status.name)
+ filters.add_filter_by("Status", "is (OR)", status.name)
loading_indicator_saveguard
wp_table.expect_work_package_listed work_package_with_status
@@ -146,12 +146,12 @@
filters.open_autocompleter :status
- expect(page).to have_css('.ng-option', text: closed_status.name)
- expect(page).to have_no_css('.ng-option', text: status.name)
+ expect(page).to have_css(".ng-option", text: closed_status.name)
+ expect(page).to have_no_css(".ng-option", text: status.name)
end
end
- context 'by finish date outside of a project' do
+ context "by finish date outside of a project" do
let(:work_package_with_due_date) { create(:work_package, project:, due_date: Date.current) }
let(:work_package_without_due_date) { create(:work_package, project:, due_date: 5.days.from_now) }
let(:wp_table) { Pages::WorkPackagesTable.new }
@@ -163,21 +163,21 @@
wp_table.visit!
end
- it 'allows filtering, saving and retrieving and altering the saved filter' do
+ it "allows filtering, saving and retrieving and altering the saved filter" do
filters.open
- filters.add_filter_by('Finish date',
- 'between',
- [1.day.ago.strftime('%Y-%m-%d'), Date.current.strftime('%Y-%m-%d')],
- 'dueDate')
+ filters.add_filter_by("Finish date",
+ "between",
+ [1.day.ago.strftime("%Y-%m-%d"), Date.current.strftime("%Y-%m-%d")],
+ "dueDate")
loading_indicator_saveguard
wp_table.expect_work_package_listed work_package_with_due_date
wp_table.ensure_work_package_not_listed! work_package_without_due_date
- wp_table.save_as('Some query name')
+ wp_table.save_as("Some query name")
- filters.remove_filter 'dueDate'
+ filters.remove_filter "dueDate"
loading_indicator_saveguard
wp_table.expect_work_package_listed work_package_with_due_date, work_package_without_due_date
@@ -192,12 +192,12 @@
filters.open
- filters.expect_filter_by('Finish date',
- 'between',
- [1.day.ago.strftime('%Y-%m-%d'), Date.current.strftime('%Y-%m-%d')],
- 'dueDate')
+ filters.expect_filter_by("Finish date",
+ "between",
+ [1.day.ago.strftime("%Y-%m-%d"), Date.current.strftime("%Y-%m-%d")],
+ "dueDate")
- filters.set_filter 'Finish date', 'in more than', '1', 'dueDate'
+ filters.set_filter "Finish date", "in more than", "1", "dueDate"
loading_indicator_saveguard
wp_table.expect_work_package_listed work_package_without_due_date
@@ -205,7 +205,7 @@
end
end
- context 'by list cf inside a project' do
+ context "by list cf inside a project" do
let(:type) do
type = create(:type)
@@ -245,13 +245,13 @@
wp_table.visit!
end
- it 'allows filtering, saving and retrieving the saved filter' do
+ it "allows filtering, saving and retrieving the saved filter" do
# Wait for form to load
filters.expect_loaded
filters.open
filters.add_filter_by(list_cf.name,
- 'is not',
+ "is not",
list_cf.custom_options.last.value,
list_cf.attribute_name(:camel_case))
@@ -262,9 +262,9 @@
# Do not display already selected values in the autocompleter (Regression #46249)
filters.open_autocompleter list_cf.attribute_name(:camel_case)
- expect(page).to have_no_css('.ng-option', text: list_cf.custom_options.last.value)
+ expect(page).to have_no_css(".ng-option", text: list_cf.custom_options.last.value)
- wp_table.save_as('Some query name')
+ wp_table.save_as("Some query name")
filters.remove_filter list_cf.attribute_name(:camel_case)
@@ -282,13 +282,13 @@
filters.open
filters.expect_filter_by(list_cf.name,
- 'is not',
+ "is not",
list_cf.custom_options.last.value,
"customField#{list_cf.id}")
end
end
- context 'by string cf inside a project with url-query relevant chars' do
+ context "by string cf inside a project with url-query relevant chars" do
let(:type) do
type = create(:type)
@@ -299,14 +299,14 @@
let(:work_package_plus) do
wp = create(:work_package, project:, type:)
- wp.send(string_cf.attribute_setter, 'G+H')
+ wp.send(string_cf.attribute_setter, "G+H")
wp.save!
wp
end
let(:work_package_and) do
wp = create(:work_package, project:, type:)
- wp.send(string_cf.attribute_setter, 'A&B')
+ wp.send(string_cf.attribute_setter, "A&B")
wp.save!
wp
end
@@ -328,21 +328,21 @@
wp_table.visit!
end
- it 'allows filtering, saving and retrieving the saved filter' do
+ it "allows filtering, saving and retrieving the saved filter" do
# Wait for form to load
filters.expect_loaded
filters.open
filters.add_filter_by(string_cf.name,
- 'is',
- ['G+H'],
+ "is",
+ ["G+H"],
string_cf.attribute_name(:camel_case))
loading_indicator_saveguard
wp_table.expect_work_package_listed work_package_plus
wp_table.ensure_work_package_not_listed! work_package_and
- wp_table.save_as('Some query name')
+ wp_table.save_as("Some query name")
filters.remove_filter string_cf.attribute_name(:camel_case)
@@ -360,13 +360,13 @@
filters.open
filters.expect_filter_by(string_cf.name,
- 'is',
- ['G+H'],
+ "is",
+ ["G+H"],
"customField#{string_cf.id}")
filters.set_filter(string_cf,
- 'is',
- ['A&B'],
+ "is",
+ ["A&B"],
string_cf.attribute_name(:camel_case))
loading_indicator_saveguard
@@ -375,104 +375,104 @@
end
end
- context 'by attachment content' do
- let(:attachment_a) { build(:attachment, filename: 'attachment-first.pdf') }
- let(:attachment_b) { build(:attachment, filename: 'attachment-second.pdf') }
+ context "by attachment content" do
+ let(:attachment_a) { build(:attachment, filename: "attachment-first.pdf") }
+ let(:attachment_b) { build(:attachment, filename: "attachment-second.pdf") }
let(:wp_with_attachment_a) do
- create(:work_package, subject: 'WP attachment A', project:, attachments: [attachment_a])
+ create(:work_package, subject: "WP attachment A", project:, attachments: [attachment_a])
end
let(:wp_with_attachment_b) do
- create(:work_package, subject: 'WP attachment B', project:, attachments: [attachment_b])
+ create(:work_package, subject: "WP attachment B", project:, attachments: [attachment_b])
end
- let(:wp_without_attachment) { create(:work_package, subject: 'WP no attachment', project:) }
+ let(:wp_without_attachment) { create(:work_package, subject: "WP no attachment", project:) }
let(:wp_table) { Pages::WorkPackagesTable.new }
before do
- allow_any_instance_of(Plaintext::Resolver).to receive(:text).and_return('I am the first text $1.99.')
+ allow_any_instance_of(Plaintext::Resolver).to receive(:text).and_return("I am the first text $1.99.")
wp_with_attachment_a
Attachments::ExtractFulltextJob.perform_now(attachment_a.id)
- allow_any_instance_of(Plaintext::Resolver).to receive(:text).and_return('I am the second text.')
+ allow_any_instance_of(Plaintext::Resolver).to receive(:text).and_return("I am the second text.")
wp_with_attachment_b
Attachments::ExtractFulltextJob.perform_now(attachment_b.id)
wp_without_attachment
end
- context 'with full text search capabilities' do
+ context "with full text search capabilities" do
before do
skip("Database does not support full text search.") unless OpenProject::Database::allows_tsv?
end
- it 'allows filtering and retrieving and altering the saved filter' do
+ it "allows filtering and retrieving and altering the saved filter" do
wp_table.visit!
wp_table.expect_work_package_listed wp_with_attachment_a, wp_with_attachment_b
filters.open
# content contains with multiple hits
- filters.add_filter_by('Attachment content',
- 'contains',
- ['text'],
- 'attachmentContent')
+ filters.add_filter_by("Attachment content",
+ "contains",
+ ["text"],
+ "attachmentContent")
loading_indicator_saveguard
wp_table.expect_work_package_listed wp_with_attachment_a, wp_with_attachment_b
wp_table.ensure_work_package_not_listed! wp_without_attachment
# content contains single hit with numbers
- filters.remove_filter 'attachmentContent'
+ filters.remove_filter "attachmentContent"
- filters.add_filter_by('Attachment content',
- 'contains',
- ['first 1.99'],
- 'attachmentContent')
+ filters.add_filter_by("Attachment content",
+ "contains",
+ ["first 1.99"],
+ "attachmentContent")
loading_indicator_saveguard
wp_table.expect_work_package_listed wp_with_attachment_a
wp_table.ensure_work_package_not_listed! wp_without_attachment, wp_with_attachment_b
- filters.remove_filter 'attachmentContent'
+ filters.remove_filter "attachmentContent"
# content does not contain
- filters.add_filter_by('Attachment content',
- 'doesn\'t contain',
- ['first'],
- 'attachmentContent')
+ filters.add_filter_by("Attachment content",
+ "doesn't contain",
+ ["first"],
+ "attachmentContent")
loading_indicator_saveguard
wp_table.expect_work_package_listed wp_with_attachment_b, wp_without_attachment
wp_table.ensure_work_package_not_listed! wp_with_attachment_a
- filters.remove_filter 'attachmentContent'
+ filters.remove_filter "attachmentContent"
# ignores special characters
- filters.add_filter_by('Attachment content',
- 'contains',
- ['! first:* \')'],
- 'attachmentContent')
+ filters.add_filter_by("Attachment content",
+ "contains",
+ ["! first:* ')"],
+ "attachmentContent")
loading_indicator_saveguard
wp_table.expect_work_package_listed wp_with_attachment_a
wp_table.ensure_work_package_not_listed! wp_without_attachment, wp_with_attachment_b
- filters.remove_filter 'attachmentContent'
+ filters.remove_filter "attachmentContent"
# file name contains
- filters.add_filter_by('Attachment file name',
- 'contains',
- ['first'],
- 'attachmentFileName')
+ filters.add_filter_by("Attachment file name",
+ "contains",
+ ["first"],
+ "attachmentFileName")
loading_indicator_saveguard
wp_table.expect_work_package_listed wp_with_attachment_a
wp_table.ensure_work_package_not_listed! wp_without_attachment, wp_with_attachment_b
- filters.remove_filter 'attachmentFileName'
+ filters.remove_filter "attachmentFileName"
# file name does not contain
- filters.add_filter_by('Attachment file name',
- 'doesn\'t contain',
- ['first'],
- 'attachmentFileName')
+ filters.add_filter_by("Attachment file name",
+ "doesn't contain",
+ ["first"],
+ "attachmentFileName")
loading_indicator_saveguard
wp_table.expect_work_package_listed wp_with_attachment_b
@@ -481,50 +481,50 @@
end
end
- context 'DB does not offer TSVector support' do
+ context "DB does not offer TSVector support" do
before do
allow(OpenProject::Database).to receive(:allows_tsv?).and_return(false)
end
it "does not offer attachment filters" do
- expect(page).to have_no_select 'add_filter_select', with_options: ['Attachment content', 'Attachment file name']
+ expect(page).to have_no_select "add_filter_select", with_options: ["Attachment content", "Attachment file name"]
end
end
- describe 'datetime filters' do
+ describe "datetime filters" do
shared_let(:wp_updated_today) do
create(:work_package,
- subject: 'Created today',
+ subject: "Created today",
project:,
created_at: Time.current.change(hour: 12),
updated_at: Time.current.change(hour: 12))
end
shared_let(:wp_updated_3d_ago) do
create(:work_package,
- subject: 'Created 3d ago',
+ subject: "Created 3d ago",
project:,
created_at: 3.days.ago,
updated_at: 3.days.ago)
end
shared_let(:wp_updated_5d_ago) do
create(:work_package,
- subject: 'Created 5d ago',
+ subject: "Created 5d ago",
project:,
created_at: 5.days.ago,
updated_at: 5.days.ago)
end
- it 'filters on date by created_at (Regression #28459)' do
+ it "filters on date by created_at (Regression #28459)" do
wp_table.visit!
loading_indicator_saveguard
wp_table.expect_work_package_listed wp_updated_today, wp_updated_3d_ago, wp_updated_5d_ago
filters.open
- filters.add_filter_by 'Created on',
- 'on',
+ filters.add_filter_by "Created on",
+ "on",
[Date.current.iso8601],
- 'createdAt'
+ "createdAt"
loading_indicator_saveguard
@@ -532,17 +532,17 @@
wp_table.ensure_work_package_not_listed! wp_updated_3d_ago, wp_updated_5d_ago
end
- it 'filters on date by updated_at' do
+ it "filters on date by updated_at" do
wp_table.visit!
loading_indicator_saveguard
wp_table.expect_work_package_listed wp_updated_today, wp_updated_3d_ago, wp_updated_5d_ago
filters.open
- filters.add_filter_by 'Updated',
- 'on',
+ filters.add_filter_by "Updated",
+ "on",
[Date.current.iso8601],
- 'updatedAt'
+ "updatedAt"
loading_indicator_saveguard
@@ -550,17 +550,17 @@
wp_table.ensure_work_package_not_listed! wp_updated_3d_ago, wp_updated_5d_ago
end
- it 'filters between date by updated_at', :with_cuprite do
+ it "filters between date by updated_at", :with_cuprite do
wp_table.visit!
loading_indicator_saveguard
wp_table.expect_work_package_listed wp_updated_today, wp_updated_3d_ago, wp_updated_5d_ago
filters.open
- filters.add_filter_by 'Updated',
- 'between',
+ filters.add_filter_by "Updated",
+ "between",
[4.days.ago.to_date.iso8601, 2.days.ago.to_date.iso8601],
- 'updatedAt'
+ "updatedAt"
wait_for_reload
loading_indicator_saveguard
@@ -568,15 +568,15 @@
wp_table.expect_work_package_listed wp_updated_3d_ago
wp_table.ensure_work_package_not_listed! wp_updated_today, wp_updated_5d_ago
- wp_table.save_as('Some query name')
+ wp_table.save_as("Some query name")
- filters.remove_filter 'updatedAt'
+ filters.remove_filter "updatedAt"
wait_for_reload
loading_indicator_saveguard
wp_table.expect_work_package_listed wp_updated_today, wp_updated_3d_ago, wp_updated_5d_ago
- last_query = Query.where(name: 'Some query name').first
+ last_query = Query.where(name: "Some query name").first
date_filter = last_query.filters.last
# The frontend sends the date as a datetime string in utc where both bounds have the local offset deduced
@@ -594,45 +594,45 @@
filters.open
- filters.expect_filter_by 'Updated on',
- 'between',
+ filters.expect_filter_by "Updated on",
+ "between",
[4.days.ago.to_date.iso8601, 2.days.ago.to_date.iso8601],
- 'updatedAt'
+ "updatedAt"
end
- it 'filters between date by updated_at (lower boundary only)' do
+ it "filters between date by updated_at (lower boundary only)" do
wp_table.visit!
loading_indicator_saveguard
wp_table.expect_work_package_listed wp_updated_today, wp_updated_3d_ago, wp_updated_5d_ago
filters.open
- filters.add_filter_by 'Updated',
- 'between',
+ filters.add_filter_by "Updated",
+ "between",
[3.days.ago.to_date.iso8601],
- 'updatedAt'
+ "updatedAt"
loading_indicator_saveguard
wp_table.expect_work_package_listed wp_updated_3d_ago, wp_updated_today
wp_table.ensure_work_package_not_listed! wp_updated_5d_ago
- wp_table.save_as('Some query name')
+ wp_table.save_as("Some query name")
- filters.remove_filter 'updatedAt'
+ filters.remove_filter "updatedAt"
loading_indicator_saveguard
wp_table.expect_work_package_listed wp_updated_today, wp_updated_5d_ago
- filters.add_filter_by 'Updated',
- 'between',
+ filters.add_filter_by "Updated",
+ "between",
[6.days.ago.to_date.iso8601],
- 'updatedAt'
+ "updatedAt"
loading_indicator_saveguard
wp_table.expect_work_package_listed wp_updated_today, wp_updated_3d_ago, wp_updated_5d_ago
- last_query = Query.where(name: 'Some query name').first
+ last_query = Query.where(name: "Some query name").first
date_filter = last_query.filters.last
expect(date_filter.values)
.to eq [3.days.ago.utc.beginning_of_day.iso8601]
@@ -645,48 +645,48 @@
filters.open
- filters.expect_filter_by 'Updated on',
- 'between',
- [3.days.ago.to_date.iso8601, ''],
- 'updatedAt'
+ filters.expect_filter_by "Updated on",
+ "between",
+ [3.days.ago.to_date.iso8601, ""],
+ "updatedAt"
end
- it 'filters between date by updated_at (upper boundary only)' do
+ it "filters between date by updated_at (upper boundary only)" do
wp_table.visit!
loading_indicator_saveguard
wp_table.expect_work_package_listed wp_updated_today, wp_updated_3d_ago, wp_updated_5d_ago
filters.open
- filters.add_filter_by 'Updated',
- 'between',
+ filters.add_filter_by "Updated",
+ "between",
[nil, 4.days.ago.to_date.iso8601],
- 'updatedAt'
+ "updatedAt"
loading_indicator_saveguard
wp_table.expect_work_package_listed wp_updated_5d_ago
wp_table.ensure_work_package_not_listed! wp_updated_3d_ago, wp_updated_today
- wp_table.save_as('Some query name')
+ wp_table.save_as("Some query name")
- filters.remove_filter 'updatedAt'
+ filters.remove_filter "updatedAt"
loading_indicator_saveguard
wp_table.expect_work_package_listed wp_updated_today, wp_updated_3d_ago, wp_updated_5d_ago
- filters.add_filter_by 'Updated',
- 'between',
+ filters.add_filter_by "Updated",
+ "between",
[nil, 6.days.ago.to_date.iso8601],
- 'updatedAt'
+ "updatedAt"
loading_indicator_saveguard
wp_table.ensure_work_package_not_listed! wp_updated_5d_ago, wp_updated_3d_ago, wp_updated_today
- last_query = Query.where(name: 'Some query name').first
+ last_query = Query.where(name: "Some query name").first
date_filter = last_query.filters.last
expect(date_filter.values)
- .to eq ['', 4.days.ago.utc.end_of_day.iso8601]
+ .to eq ["", 4.days.ago.utc.end_of_day.iso8601]
wp_table.visit_query(last_query)
@@ -696,40 +696,40 @@
filters.open
- filters.expect_filter_by 'Updated on',
- 'between',
- ['', 4.days.ago.to_date.iso8601],
- 'updatedAt'
+ filters.expect_filter_by "Updated on",
+ "between",
+ ["", 4.days.ago.to_date.iso8601],
+ "updatedAt"
end
end
- describe 'keep the filter attribute order (Regression #33136)' do
- let(:version1) { create(:version, project:, name: 'Version 1', id: 1) }
- let(:version2) { create(:version, project:, name: 'Version 2', id: 2) }
+ describe "keep the filter attribute order (Regression #33136)" do
+ let(:version1) { create(:version, project:, name: "Version 1", id: 1) }
+ let(:version2) { create(:version, project:, name: "Version 2", id: 2) }
it do
wp_table.visit!
loading_indicator_saveguard
filters.open
- filters.add_filter_by 'Version', 'is (OR)', [version2.name, version1.name]
+ filters.add_filter_by "Version", "is (OR)", [version2.name, version1.name]
loading_indicator_saveguard
sleep(3)
- filters.expect_filter_by 'Version', 'is (OR)', [version1.name]
- filters.expect_filter_by 'Version', 'is (OR)', [version2.name]
+ filters.expect_filter_by "Version", "is (OR)", [version1.name]
+ filters.expect_filter_by "Version", "is (OR)", [version2.name]
# Order should stay unchanged
- filters.expect_filter_order('Version', [version2.name, version1.name])
+ filters.expect_filter_order("Version", [version2.name, version1.name])
end
end
- describe 'add parent WP filter' do
- let(:wp_parent) { create(:work_package, project:, subject: 'project') }
- let(:wp_child1) { create(:work_package, project:, subject: 'child 1', parent: wp_parent) }
- let(:wp_child2) { create(:work_package, project:, subject: 'child 2', parent: wp_parent) }
- let(:wp_default) { create(:work_package, project:, subject: 'default') }
+ describe "add parent WP filter" do
+ let(:wp_parent) { create(:work_package, project:, subject: "project") }
+ let(:wp_child1) { create(:work_package, project:, subject: "child 1", parent: wp_parent) }
+ let(:wp_child2) { create(:work_package, project:, subject: "child 2", parent: wp_parent) }
+ let(:wp_default) { create(:work_package, project:, subject: "default") }
it do
wp_parent
@@ -740,7 +740,7 @@
loading_indicator_saveguard
filters.expect_loaded
filters.open
- filters.add_filter_by 'Parent', 'is (OR)', [wp_parent.subject]
+ filters.add_filter_by "Parent", "is (OR)", [wp_parent.subject]
loading_indicator_saveguard
# It should show the children of the selected parent
diff --git a/spec/features/work_packages/table/queries/id_filter_spec.rb b/spec/features/work_packages/table/queries/id_filter_spec.rb
index ad5681f0c910..9700543ab4f1 100644
--- a/spec/features/work_packages/table/queries/id_filter_spec.rb
+++ b/spec/features/work_packages/table/queries/id_filter_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package filtering by id', :js do
+RSpec.describe "Work package filtering by id", :js do
let(:project) { create(:project) }
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
let(:filters) { Components::WorkPackages::Filters.new }
@@ -52,16 +52,16 @@
wp_table.expect_work_package_listed(work_package, other_work_package)
filters.open
- filters.add_filter_by('ID', 'is (OR)', [work_package.subject])
+ filters.add_filter_by("ID", "is (OR)", [work_package.subject])
end
- it 'shows the work package matching the id filter' do
+ it "shows the work package matching the id filter" do
wp_table.ensure_work_package_not_listed!(other_work_package)
wp_table.expect_work_package_listed(work_package)
- wp_table.save_as('Id query')
+ wp_table.save_as("Id query")
- wp_table.expect_and_dismiss_toaster(message: 'Successful creation.')
+ wp_table.expect_and_dismiss_toaster(message: "Successful creation.")
# Revisit query
wp_table.visit_query Query.last
@@ -69,23 +69,23 @@
wp_table.expect_work_package_listed(work_package)
filters.open
- filters.expect_filter_by('ID', 'is (OR)', ["##{work_package.id} #{work_package.subject}"])
- filters.remove_filter 'id'
- filters.add_filter_by('ID', 'is not', [work_package.subject, other_work_package.subject])
+ filters.expect_filter_by("ID", "is (OR)", ["##{work_package.id} #{work_package.subject}"])
+ filters.remove_filter "id"
+ filters.add_filter_by("ID", "is not", [work_package.subject, other_work_package.subject])
wp_table.expect_no_work_package_listed
- filters.remove_filter 'id'
- filters.add_filter_by('ID', 'is (OR)', [work_package.id.to_s])
- filters.expect_filter_by('ID', 'is (OR)', ["##{work_package.id} #{work_package.subject}"])
+ filters.remove_filter "id"
+ filters.add_filter_by("ID", "is (OR)", [work_package.id.to_s])
+ filters.expect_filter_by("ID", "is (OR)", ["##{work_package.id} #{work_package.subject}"])
wp_table.expect_work_package_listed(work_package)
end
- it 'can still inline create a new work package (regression #41667)' do
+ it "can still inline create a new work package (regression #41667)" do
wp_table.click_inline_create
- expect(page).to have_css('.wp--row', count: 2)
+ expect(page).to have_css(".wp--row", count: 2)
- expect(page).to have_css('.wp-inline-create-row')
+ expect(page).to have_css(".wp-inline-create-row")
end
end
diff --git a/spec/features/work_packages/table/queries/me_filter_spec.rb b/spec/features/work_packages/table/queries/me_filter_spec.rb
index 4bf194817541..d6f3a5f732c3 100644
--- a/spec/features/work_packages/table/queries/me_filter_spec.rb
+++ b/spec/features/work_packages/table/queries/me_filter_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'filter me value', :js do
+RSpec.describe "filter me value", :js do
let(:status) { create(:default_status) }
let!(:priority) { create(:default_priority) }
let(:project) do
@@ -49,33 +49,33 @@
end
let!(:role_anonymous) { create(:anonymous_role, permissions: [:view_work_packages]) }
- describe 'assignee' do
+ describe "assignee" do
let(:wp_admin) { create(:work_package, status:, project:, assigned_to: admin) }
let(:wp_user) { create(:work_package, status:, project:, assigned_to: user) }
- context 'as anonymous', with_settings: { login_required?: false } do
+ context "as anonymous", with_settings: { login_required?: false } do
current_user { User.anonymous }
let(:assignee_query) do
query = create(:query,
- name: 'Assignee Query',
+ name: "Assignee Query",
project:,
user:)
- query.add_filter('assigned_to_id', '=', ['me'])
+ query.add_filter("assigned_to_id", "=", ["me"])
query.save!(validate: false)
query
end
- it 'shows an error visiting a query with a me value' do
+ it "shows an error visiting a query with a me value" do
wp_table.visit_query assignee_query
wp_table.expect_toast(type: :error,
- message: I18n.t('js.work_packages.faulty_query.description'))
+ message: I18n.t("js.work_packages.faulty_query.description"))
end
end
- context 'logged in' do
+ context "logged in" do
current_user { admin }
before do
@@ -83,26 +83,26 @@
wp_user
end
- it 'shows the one work package filtering for myself' do
+ it "shows the one work package filtering for myself" do
wp_table.visit!
wp_table.expect_work_package_listed(wp_admin, wp_user)
# Add and save query with me filter
filters.open
- filters.remove_filter 'status'
- filters.add_filter_by('Assignee', 'is (OR)', 'me')
+ filters.remove_filter "status"
+ filters.add_filter_by("Assignee", "is (OR)", "me")
wp_table.ensure_work_package_not_listed!(wp_user)
wp_table.expect_work_package_listed(wp_admin)
- wp_table.save_as('Me query')
+ wp_table.save_as("Me query")
loading_indicator_saveguard
# Expect correct while saving
- wp_table.expect_title 'Me query'
+ wp_table.expect_title "Me query"
query = Query.last
- expect(query.filters.first.values).to eq ['me']
- filters.expect_filter_by('Assignee', 'is (OR)', 'me')
+ expect(query.filters.first.values).to eq ["me"]
+ filters.expect_filter_by("Assignee", "is (OR)", "me")
# Revisit query
wp_table.visit_query query
@@ -110,7 +110,7 @@
wp_table.expect_work_package_listed(wp_admin)
filters.open
- filters.expect_filter_by('Assignee', 'is (OR)', 'me')
+ filters.expect_filter_by("Assignee", "is (OR)", "me")
# Expect new work packages receive assignee
split_screen = wp_table.create_wp_by_button wp_user.type
@@ -119,10 +119,10 @@
sleep 2
subject = split_screen.edit_field :subject
- subject.set_value 'foobar'
+ subject.set_value "foobar"
subject.submit_by_enter
- split_screen.expect_and_dismiss_toaster message: 'Successful creation.'
+ split_screen.expect_and_dismiss_toaster message: "Successful creation."
wp = WorkPackage.last
expect(wp.assigned_to_id).to eq(admin.id)
@@ -130,11 +130,11 @@
end
end
- describe 'custom_field of type user' do
+ describe "custom_field of type user" do
let(:custom_field) do
create(
:user_wp_custom_field,
- name: 'CF user',
+ name: "CF user",
is_required: false
)
end
@@ -163,14 +163,14 @@
custom_field_values: { custom_field.id => user.id })
end
- context 'as anonymous', with_settings: { login_required?: false } do
+ context "as anonymous", with_settings: { login_required?: false } do
let(:assignee_query) do
query = create(:query,
- name: 'CF user Query',
+ name: "CF user Query",
project:,
user:)
- query.add_filter(cf_accessor, '=', ['me'])
+ query.add_filter(cf_accessor, "=", ["me"])
query.save!(validate: false)
query
@@ -178,14 +178,14 @@
current_user { User.anonymous }
- it 'shows an error visiting a query with a me value' do
+ it "shows an error visiting a query with a me value" do
wp_table.visit_query assignee_query
wp_table.expect_toast(type: :error,
- message: I18n.t('js.work_packages.faulty_query.description'))
+ message: I18n.t("js.work_packages.faulty_query.description"))
end
end
- context 'logged in' do
+ context "logged in" do
current_user { admin }
before do
@@ -193,26 +193,26 @@
wp_user
end
- it 'shows the one work package filtering for myself' do
+ it "shows the one work package filtering for myself" do
wp_table.visit!
wp_table.expect_work_package_listed(wp_admin, wp_user)
# Add and save query with me filter
filters.open
- filters.remove_filter 'status'
- filters.add_filter_by('CF user', 'is (OR)', 'me', cf_accessor_frontend)
+ filters.remove_filter "status"
+ filters.add_filter_by("CF user", "is (OR)", "me", cf_accessor_frontend)
wp_table.ensure_work_package_not_listed!(wp_user)
wp_table.expect_work_package_listed(wp_admin)
- wp_table.save_as('Me query')
+ wp_table.save_as("Me query")
loading_indicator_saveguard
# Expect correct while saving
- wp_table.expect_title 'Me query'
+ wp_table.expect_title "Me query"
query = Query.last
- expect(query.filters.first.values).to eq ['me']
- filters.expect_filter_by('CF user', 'is (OR)', 'me', cf_accessor_frontend)
+ expect(query.filters.first.values).to eq ["me"]
+ filters.expect_filter_by("CF user", "is (OR)", "me", cf_accessor_frontend)
# Revisit query
wp_table.visit_query query
@@ -220,7 +220,7 @@
wp_table.expect_work_package_listed(wp_admin)
filters.open
- filters.expect_filter_by('CF user', 'is (OR)', 'me', cf_accessor_frontend)
+ filters.expect_filter_by("CF user", "is (OR)", "me", cf_accessor_frontend)
end
end
end
diff --git a/spec/features/work_packages/table/queries/mobile_date_filter_spec.rb b/spec/features/work_packages/table/queries/mobile_date_filter_spec.rb
index 9d44493d1c24..f713d338d13a 100644
--- a/spec/features/work_packages/table/queries/mobile_date_filter_spec.rb
+++ b/spec/features/work_packages/table/queries/mobile_date_filter_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'mobile date filter work packages', :js, :with_cuprite do
+RSpec.describe "mobile date filter work packages", :js, :with_cuprite do
shared_let(:user) { create(:admin) }
shared_let(:project) { create(:project) }
shared_let(:wp_table) { Pages::WorkPackagesTable.new(project) }
@@ -39,20 +39,20 @@
current_user { user }
- include_context 'with mobile screen size'
+ include_context "with mobile screen size"
before do
wp_table.visit!
end
- context 'when filtering between finish date' do
- it 'allows filtering, saving and retrieving and altering the saved filter' do
+ context "when filtering between finish date" do
+ it "allows filtering, saving and retrieving and altering the saved filter" do
filters.open
- filters.add_filter('Finish date')
- filters.set_operator('Finish date', 'between', 'dueDate')
+ filters.add_filter("Finish date")
+ filters.set_operator("Finish date", "between", "dueDate")
- start_field = find_test_selector('op-basic-range-date-picker-start')
- end_field = find_test_selector('op-basic-range-date-picker-end')
+ start_field = find_test_selector("op-basic-range-date-picker-start")
+ end_field = find_test_selector("op-basic-range-date-picker-end")
clear_input_field_contents(start_field)
clear_input_field_contents(end_field)
@@ -69,8 +69,8 @@
wp_cards.expect_work_package_listed work_package_with_due_date
wp_cards.expect_work_package_not_listed work_package_without_due_date
- wp_table.save_as('Some query name')
- wp_table.expect_and_dismiss_toaster(message: 'Successful creation.')
+ wp_table.save_as("Some query name")
+ wp_table.expect_and_dismiss_toaster(message: "Successful creation.")
last_query = Query.last
date_filter = last_query.filters.last
@@ -78,14 +78,14 @@
end
end
- context 'when filtering on finish date' do
- it 'allows filtering, saving and retrieving and altering the saved filter' do
+ context "when filtering on finish date" do
+ it "allows filtering, saving and retrieving and altering the saved filter" do
filters.open
- filters.add_filter('Finish date')
- filters.set_operator('Finish date', 'on', 'dueDate')
+ filters.add_filter("Finish date")
+ filters.set_operator("Finish date", "on", "dueDate")
- date_field = find_field 'values-dueDate'
- expect(date_field['type']).to eq 'date'
+ date_field = find_field "values-dueDate"
+ expect(date_field["type"]).to eq "date"
clear_input_field_contents(date_field)
date_field.set Date.current
@@ -97,8 +97,8 @@
wp_cards.expect_work_package_listed work_package_with_due_date
wp_cards.expect_work_package_not_listed work_package_without_due_date
- wp_table.save_as('Some query name')
- wp_table.expect_and_dismiss_toaster(message: 'Successful creation.')
+ wp_table.save_as("Some query name")
+ wp_table.expect_and_dismiss_toaster(message: "Successful creation.")
last_query = Query.last
date_filter = last_query.filters.last
diff --git a/spec/features/work_packages/table/queries/query_history_spec.rb b/spec/features/work_packages/table/queries/query_history_spec.rb
index 68aca098eac1..43eb03f071f9 100644
--- a/spec/features/work_packages/table/queries/query_history_spec.rb
+++ b/spec/features/work_packages/table/queries/query_history_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Going back and forth through the browser history', :js do
+RSpec.describe "Going back and forth through the browser history", :js do
let(:user) do
create(:user, member_with_roles: { project => role })
end
@@ -63,22 +63,22 @@
end
let(:assignee_query) do
query = create(:query,
- name: 'Assignee Query',
+ name: "Assignee Query",
project:,
user:)
- query.add_filter('assigned_to_id', '=', [user.id])
+ query.add_filter("assigned_to_id", "=", [user.id])
query.save!
query
end
let(:version_query) do
query = create(:query,
- name: 'Version Query',
+ name: "Version Query",
project:,
user:)
- query.add_filter('version_id', '=', [version.id])
+ query.add_filter("version_id", "=", [version.id])
query.save!
query
@@ -97,9 +97,9 @@
version_query
end
- it 'updates the filters and query results on history back and forth', retry: 1 do
+ it "updates the filters and query results on history back and forth", retry: 1 do
wp_table.visit!
- wp_table.expect_title('All open', editable: true)
+ wp_table.expect_title("All open", editable: true)
wp_table.visit_query(assignee_query)
wp_table.expect_title(assignee_query.name)
@@ -110,58 +110,58 @@
wp_table.expect_work_package_listed work_package_3
filters.open
- filters.add_filter_by('Assignee', 'is (OR)', user.name)
+ filters.add_filter_by("Assignee", "is (OR)", user.name)
filters.expect_filter_count 3
wp_table.expect_no_work_package_listed
- page.execute_script('window.history.back()')
+ page.execute_script("window.history.back()")
wp_table.expect_title(version_query.name)
wp_table.expect_work_package_listed work_package_3
filters.expect_filter_count 2
- filters.expect_filter_by('Status', 'open', nil)
- filters.expect_filter_by('Version', 'is (OR)', version.name)
+ filters.expect_filter_by("Status", "open", nil)
+ filters.expect_filter_by("Version", "is (OR)", version.name)
- page.execute_script('window.history.back()')
+ page.execute_script("window.history.back()")
wp_table.expect_title(assignee_query.name)
wp_table.expect_work_package_listed work_package_2
filters.open
- filters.expect_filter_by('Status', 'open', nil)
- filters.expect_filter_by('Assignee', 'is (OR)', user.name)
+ filters.expect_filter_by("Status", "open", nil)
+ filters.expect_filter_by("Assignee", "is (OR)", user.name)
- page.execute_script('window.history.back()')
+ page.execute_script("window.history.back()")
- wp_table.expect_title('All open', editable: true)
+ wp_table.expect_title("All open", editable: true)
wp_table.expect_work_package_listed work_package_1
wp_table.expect_work_package_listed work_package_2
wp_table.expect_work_package_listed work_package_3
filters.open
- filters.expect_filter_by('Status', 'open', nil)
+ filters.expect_filter_by("Status", "open", nil)
- page.execute_script('window.history.forward()')
+ page.execute_script("window.history.forward()")
wp_table.expect_title(assignee_query.name)
wp_table.expect_work_package_listed work_package_2
filters.open
- filters.expect_filter_by('Status', 'open', nil)
- filters.expect_filter_by('Assignee', 'is (OR)', user.name)
+ filters.expect_filter_by("Status", "open", nil)
+ filters.expect_filter_by("Assignee", "is (OR)", user.name)
- page.execute_script('window.history.forward()')
+ page.execute_script("window.history.forward()")
wp_table.expect_title(version_query.name)
wp_table.expect_work_package_listed work_package_3
filters.open
- filters.expect_filter_by('Status', 'open', nil)
- filters.expect_filter_by('Version', 'is (OR)', version.name)
+ filters.expect_filter_by("Status", "open", nil)
+ filters.expect_filter_by("Version", "is (OR)", version.name)
- page.execute_script('window.history.forward()')
+ page.execute_script("window.history.forward()")
wp_table.expect_title(version_query.name)
wp_table.expect_no_work_package_listed
filters.open
- filters.expect_filter_by('Status', 'open', nil)
- filters.expect_filter_by('Version', 'is (OR)', version.name)
- filters.expect_filter_by('Assignee', 'is (OR)', user.name)
+ filters.expect_filter_by("Status", "open", nil)
+ filters.expect_filter_by("Version", "is (OR)", version.name)
+ filters.expect_filter_by("Assignee", "is (OR)", user.name)
end
end
diff --git a/spec/features/work_packages/table/queries/query_menu_refresh_spec.rb b/spec/features/work_packages/table/queries/query_menu_refresh_spec.rb
index 628cb1680b7b..bccccfa2ad80 100644
--- a/spec/features/work_packages/table/queries/query_menu_refresh_spec.rb
+++ b/spec/features/work_packages/table/queries/query_menu_refresh_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Refreshing query menu item', :js do
+RSpec.describe "Refreshing query menu item", :js do
let(:user) { create(:admin) }
let(:project) { create(:project) }
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
@@ -42,17 +42,17 @@
wp_table.visit!
end
- it 'allows refreshing the current query (Bug #26921)' do
+ it "allows refreshing the current query (Bug #26921)" do
wp_table.expect_work_package_listed work_package
# Instantiate lazy let here
wp_table.ensure_work_package_not_listed! other_work_package
- wp_table.save_as('Some query name')
+ wp_table.save_as("Some query name")
# Publish query
- wp_table.click_setting_item I18n.t('js.toolbar.settings.visibility_settings')
- find_by_id('show-in-menu').set true
- find('.button', text: 'Save').click
+ wp_table.click_setting_item I18n.t("js.toolbar.settings.visibility_settings")
+ find_by_id("show-in-menu").set true
+ find(".button", text: "Save").click
last_query = Query.last
url = URI.parse(page.current_url).query
diff --git a/spec/features/work_packages/table/queries/query_menu_spec.rb b/spec/features/work_packages/table/queries/query_menu_spec.rb
index 32c64a99b021..542f6da8d910 100644
--- a/spec/features/work_packages/table/queries/query_menu_spec.rb
+++ b/spec/features/work_packages/table/queries/query_menu_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Query menu item', :js do
+RSpec.describe "Query menu item", :js do
let(:project) { create(:project) }
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
let(:filters) { Components::WorkPackages::Filters.new }
@@ -36,36 +36,36 @@
current_user { create(:admin) }
- context 'when visiting the global work packages page' do
+ context "when visiting the global work packages page" do
let(:wp_table) { Pages::WorkPackagesTable.new }
let(:project) { nil }
let!(:global_public_view) do
create(:view,
- query: create(:query, project: nil, public: true, name: 'Global public'))
+ query: create(:query, project: nil, public: true, name: "Global public"))
end
let!(:global_my_view) do
create(:view,
- query: create(:query, project: nil, public: false, user: current_user, name: 'Global my view'))
+ query: create(:query, project: nil, public: false, user: current_user, name: "Global my view"))
end
let!(:global_other_view) do
create(:view,
- query: create(:query, project: nil, public: false, user: create(:user), name: 'Other user query'))
+ query: create(:query, project: nil, public: false, user: create(:user), name: "Other user query"))
end
let!(:project_view) do
create(:view,
- query: create(:query, project: create(:project), name: 'Project query'))
+ query: create(:query, project: create(:project), name: "Project query"))
end
- it 'shows the query menu with queries stored for the global page' do
+ it "shows the query menu with queries stored for the global page" do
wp_table.visit!
- expect(page).to have_css('.op-view-select--search-results')
- expect(page).to have_css('.op-sidemenu--item-action', wait: 20, minimum: 1)
+ expect(page).to have_css(".op-view-select--search-results")
+ expect(page).to have_css(".op-sidemenu--item-action", wait: 20, minimum: 1)
- within '.op-sidebar' do
+ within ".op-sidebar" do
expect(page)
.to have_content(global_my_view.query.name, wait: 10)
expect(page)
@@ -78,7 +78,7 @@
end
end
- context 'when filtering by version in project' do
+ context "when filtering by version in project" do
let(:version) { create(:version, project:) }
let(:work_package_with_version) { create(:work_package, project:, version:) }
let(:work_package_without_version) { create(:work_package, project:) }
@@ -90,46 +90,46 @@
wp_table.visit!
end
- it 'allows to save query as name with sharing options (Regression #27915)' do
+ it "allows to save query as name with sharing options (Regression #27915)" do
# Publish query
- wp_table.click_setting_item 'Save as'
+ wp_table.click_setting_item "Save as"
- fill_in 'save-query-name', with: 'Some query name'
- find_by_id('show-in-menu').set true
- find_by_id('show-public').set true
+ fill_in "save-query-name", with: "Some query name"
+ find_by_id("show-in-menu").set true
+ find_by_id("show-public").set true
- find('.button', text: 'Save').click
+ find(".button", text: "Save").click
- expect(page).to have_css('.op-sidemenu--item-action', text: 'Some query name', wait: 20)
+ expect(page).to have_css(".op-sidemenu--item-action", text: "Some query name", wait: 20)
last_query = Query.last
expect(last_query.public).to be_truthy
end
- it 'only saves a single query when saving through the title input (Regression #31095)' do
+ it "only saves a single query when saving through the title input (Regression #31095)" do
filters.open
- filters.remove_filter('status')
+ filters.remove_filter("status")
filters.expect_filter_count 0
query_title.expect_changed
query_title.input_field.click
- query_title.rename 'My special query!123'
+ query_title.rename "My special query!123"
- query_title.expect_title 'My special query!123'
- expect(page).to have_css('.op-sidemenu--item-action', text: 'My special query!123', wait: 20, count: 1)
+ query_title.expect_title "My special query!123"
+ expect(page).to have_css(".op-sidemenu--item-action", text: "My special query!123", wait: 20, count: 1)
end
- it 'allows filtering, saving, retrieving and altering the saved filter (Regression #25372)' do
+ it "allows filtering, saving, retrieving and altering the saved filter (Regression #25372)" do
filters.open
- filters.add_filter_by('Version', 'is (OR)', version.name)
+ filters.add_filter_by("Version", "is (OR)", version.name)
wp_table.expect_work_package_listed work_package_with_version
wp_table.ensure_work_package_not_listed! work_package_without_version
- wp_table.save_as('Some query name')
+ wp_table.save_as("Some query name")
- filters.remove_filter 'version'
+ filters.remove_filter "version"
filters.expect_filter_count 1
wp_table.expect_work_package_listed work_package_with_version, work_package_without_version
@@ -139,27 +139,27 @@
expect(URI.parse(page.current_url).query).to include("query_id=#{last_query.id}&query_props=")
# Publish query
- wp_table.click_setting_item I18n.t('js.label_visibility_settings')
- find_by_id('show-in-menu').set true
- find('.button', text: 'Save').click
+ wp_table.click_setting_item I18n.t("js.label_visibility_settings")
+ find_by_id("show-in-menu").set true
+ find(".button", text: "Save").click
wp_table.visit!
loading_indicator_saveguard
filters.open
- filters.remove_filter 'status'
+ filters.remove_filter "status"
filters.expect_filter_count 0
wp_table.expect_work_package_listed work_package_with_version, work_package_without_version
# Locate query
- query_item = page.find(".op-sidemenu--item-action", text: 'Some query name')
+ query_item = page.find(".op-sidemenu--item-action", text: "Some query name")
query_item.click
# Overrides the query_props
retry_block do
# Run in retry block because page.current_url is not synchronized
- raise 'query_props should not be in URL path' if page.current_url.include?('query_props')
+ raise "query_props should not be in URL path" if page.current_url.include?("query_props")
end
wp_table.expect_work_package_listed work_package_with_version
@@ -167,24 +167,24 @@
filters.expect_filter_count 2
filters.open
- filters.expect_filter_by('Version', 'is (OR)', version.name)
+ filters.expect_filter_by("Version", "is (OR)", version.name)
# Removing the filter and returning to query restores it
- filters.remove_filter 'version'
+ filters.remove_filter "version"
filters.expect_filter_count 1
- expect(page.current_url).to include('query_props')
+ expect(page.current_url).to include("query_props")
- query_item = page.find(".op-sidemenu--item-action", text: 'Some query name')
+ query_item = page.find(".op-sidemenu--item-action", text: "Some query name")
query_item.click
retry_block do
# Run in retry block because page.current_url is not synchronized
- raise 'query_props should not be in URL path' if page.current_url.include?('query_props')
+ raise "query_props should not be in URL path" if page.current_url.include?("query_props")
end
filters.expect_filter_count 2
filters.open
- filters.expect_filter_by('Version', 'is (OR)', version.name)
+ filters.expect_filter_by("Version", "is (OR)", version.name)
end
end
end
diff --git a/spec/features/work_packages/table/queries/query_name_inline_edit_spec.rb b/spec/features/work_packages/table/queries/query_name_inline_edit_spec.rb
index 0a6494aa5ca3..095d2e47754e 100644
--- a/spec/features/work_packages/table/queries/query_name_inline_edit_spec.rb
+++ b/spec/features/work_packages/table/queries/query_name_inline_edit_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Query name inline edit', :js do
+RSpec.describe "Query name inline edit", :js do
let(:user) do
create(:user, member_with_roles: { project => role })
end
@@ -49,11 +49,11 @@
let(:assignee_query) do
query = create(:query,
- name: 'Assignee Query',
+ name: "Assignee Query",
project:,
user:)
- query.add_filter('assigned_to_id', '=', [user.id])
+ query.add_filter("assigned_to_id", "=", [user.id])
query.save!
query
@@ -71,7 +71,7 @@
wp_table.visit_query assignee_query
end
- it 'allows renaming the query and shows changed state' do
+ it "allows renaming the query and shows changed state" do
wp_table.expect_work_package_listed work_package
query_title.expect_not_changed
@@ -90,7 +90,7 @@
# TODO: The notification should actually not be shown at all since no update
# has taken place
- wp_table.expect_and_dismiss_toaster message: 'Successful update.'
+ wp_table.expect_and_dismiss_toaster message: "Successful update."
assignee_query.reload
expect(assignee_query.filters.count).to eq(1)
@@ -101,35 +101,35 @@
expect(url).not_to match(/query_props=.+/)
# Rename query
- query_title.rename 'Not my assignee query'
- wp_table.expect_and_dismiss_toaster message: 'Successful update.'
+ query_title.rename "Not my assignee query"
+ wp_table.expect_and_dismiss_toaster message: "Successful update."
assignee_query.reload
- expect(assignee_query.name).to eq 'Not my assignee query'
+ expect(assignee_query.name).to eq "Not my assignee query"
# Rename query through context menu
- wp_table.click_setting_item 'Rename view'
+ wp_table.click_setting_item "Rename view"
- expect(page).to have_focus_on('.editable-toolbar-title--input')
- page.driver.browser.switch_to.active_element.send_keys('Some other name')
+ expect(page).to have_focus_on(".editable-toolbar-title--input")
+ page.driver.browser.switch_to.active_element.send_keys("Some other name")
page.driver.browser.switch_to.active_element.send_keys(:return)
- wp_table.expect_and_dismiss_toaster message: 'Successful update.'
+ wp_table.expect_and_dismiss_toaster message: "Successful update."
assignee_query.reload
- expect(assignee_query.name).to eq 'Some other name'
+ expect(assignee_query.name).to eq "Some other name"
end
- it 'shows the save icon when changing the columns (Regression #32835)' do
+ it "shows the save icon when changing the columns (Regression #32835)" do
wp_table.expect_work_package_listed work_package
query_title.expect_not_changed
modal.open!
- modal.switch_to 'Columns'
+ modal.switch_to "Columns"
columns.assume_opened
columns.uncheck_all save_changes: false
- columns.add 'Subject', save_changes: true
+ columns.add "Subject", save_changes: true
query_title.expect_changed
end
diff --git a/spec/features/work_packages/table/queries/responsible_filter_spec.rb b/spec/features/work_packages/table/queries/responsible_filter_spec.rb
index 8f2b2b46f923..2e620d6806e1 100644
--- a/spec/features/work_packages/table/queries/responsible_filter_spec.rb
+++ b/spec/features/work_packages/table/queries/responsible_filter_spec.rb
@@ -26,17 +26,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package filtering by responsible', :js do
+RSpec.describe "Work package filtering by responsible", :js do
let(:project) { create(:project) }
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
let(:filters) { Components::WorkPackages::Filters.new }
let(:role) { create(:project_role, permissions: %i[view_work_packages save_queries]) }
let(:other_user) do
create(:user,
- firstname: 'Other',
- lastname: 'User',
+ firstname: "Other",
+ lastname: "User",
member_with_roles: { project => role })
end
let(:placeholder_user) do
@@ -59,19 +59,19 @@
create(:user, member_with_roles: { project => role })
end
- it 'shows the work package matching the responsible filter' do
+ it "shows the work package matching the responsible filter" do
wp_table.visit!
wp_table.expect_work_package_listed(work_package_user_responsible, work_package_placeholder_user_responsible)
filters.open
- filters.add_filter_by('Accountable', 'is (OR)', [other_user.name], 'responsible')
+ filters.add_filter_by("Accountable", "is (OR)", [other_user.name], "responsible")
wp_table.ensure_work_package_not_listed!(work_package_placeholder_user_responsible)
wp_table.expect_work_package_listed(work_package_user_responsible)
- wp_table.save_as('Responsible query')
+ wp_table.save_as("Responsible query")
- wp_table.expect_and_dismiss_toaster(message: 'Successful creation.')
+ wp_table.expect_and_dismiss_toaster(message: "Successful creation.")
# Revisit query
wp_table.visit_query Query.last
@@ -79,9 +79,9 @@
wp_table.expect_work_package_listed(work_package_user_responsible)
filters.open
- filters.expect_filter_by('Accountable', 'is (OR)', [other_user.name], 'responsible')
- filters.remove_filter 'responsible'
- filters.add_filter_by('Accountable', 'is (OR)', [placeholder_user.name], 'responsible')
+ filters.expect_filter_by("Accountable", "is (OR)", [other_user.name], "responsible")
+ filters.remove_filter "responsible"
+ filters.add_filter_by("Accountable", "is (OR)", [placeholder_user.name], "responsible")
wp_table.ensure_work_package_not_listed!(work_package_user_responsible)
wp_table.expect_work_package_listed(work_package_placeholder_user_responsible)
diff --git a/spec/features/work_packages/table/queries/shared_with_user_filter_spec.rb b/spec/features/work_packages/table/queries/shared_with_user_filter_spec.rb
index 19a24079fa70..92bf7c46d68a 100644
--- a/spec/features/work_packages/table/queries/shared_with_user_filter_spec.rb
+++ b/spec/features/work_packages/table/queries/shared_with_user_filter_spec.rb
@@ -28,10 +28,10 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package filtering',
- 'by shared with user',
+RSpec.describe "Work package filtering",
+ "by shared with user",
:js,
:with_cuprite do
shared_let(:visible_project) do
@@ -58,26 +58,26 @@
shared_let(:user_with_sufficient_permissions) do
create(:user,
- firstname: 'Bruce',
- lastname: 'Wayne',
+ firstname: "Bruce",
+ lastname: "Wayne",
member_with_roles: { visible_project => project_role_with_sufficient_permissions })
end
shared_let(:user_with_insufficient_permissions) do
create(:user,
- firstname: 'Alfred',
- lastname: 'Pennyworth',
+ firstname: "Alfred",
+ lastname: "Pennyworth",
member_with_roles: { visible_project => project_role_with_insufficient_permissions })
end
shared_let(:user_with_shared_work_package) do
create(:user,
- firstname: 'Clark',
- lastname: 'Kent',
+ firstname: "Clark",
+ lastname: "Kent",
member_with_roles: { visible_project => project_role_with_insufficient_permissions })
end
shared_let(:invisible_user) do
create(:user,
- firstname: 'Salvatore',
- lastname: 'Maroni',
+ firstname: "Salvatore",
+ lastname: "Maroni",
member_with_roles: { invisible_project => project_role_with_insufficient_permissions })
end
@@ -102,32 +102,32 @@
context 'when I have sufficient permissions for the "Shared with user" filter' do
current_user { user_with_sufficient_permissions }
- it 'filters work packages by their shared status' do
+ it "filters work packages by their shared status" do
wp_table.visit!
wp_table.expect_work_package_listed(shared_work_package, non_shared_work_package)
filters.open
aggregate_failures "Members of a Project I'm not a member of are invisible" do
- filters.expect_missing_filter_value_by('Shared with user',
- 'is (OR)',
+ filters.expect_missing_filter_value_by("Shared with user",
+ "is (OR)",
[invisible_user.name],
- 'sharedWithUser')
+ "sharedWithUser")
end
- aggregate_failures 'operator filtering' do
- filters.add_filter_by('Shared with user',
- 'is (OR)',
+ aggregate_failures "operator filtering" do
+ filters.add_filter_by("Shared with user",
+ "is (OR)",
[user_with_shared_work_package.name],
- 'sharedWithUser')
+ "sharedWithUser")
wp_table.ensure_work_package_not_listed!(non_shared_work_package)
wp_table.expect_work_package_listed(shared_work_package)
end
- aggregate_failures 'Filters persist on saved query' do
- wp_table.save_as('Non shared work packages')
+ aggregate_failures "Filters persist on saved query" do
+ wp_table.save_as("Non shared work packages")
- wp_table.expect_and_dismiss_toaster(message: 'Successful creation.')
+ wp_table.expect_and_dismiss_toaster(message: "Successful creation.")
wp_table.visit_query Query.last
wp_table.ensure_work_package_not_listed!(non_shared_work_package)
@@ -143,7 +143,7 @@
wp_table.visit!
wp_table.expect_work_package_listed(shared_work_package, non_shared_work_package)
filters.open
- filters.expect_missing_filter('Shared with user')
+ filters.expect_missing_filter("Shared with user")
end
end
end
diff --git a/spec/features/work_packages/table/queries/subject_filter_spec.rb b/spec/features/work_packages/table/queries/subject_filter_spec.rb
index d752c73be0ab..15eebdf062ca 100644
--- a/spec/features/work_packages/table/queries/subject_filter_spec.rb
+++ b/spec/features/work_packages/table/queries/subject_filter_spec.rb
@@ -26,41 +26,41 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package filtering by subject', :js do
+RSpec.describe "Work package filtering by subject", :js do
let(:project) { create(:project, public: true) }
let(:admin) { create(:admin) }
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
let(:filters) { Components::WorkPackages::Filters.new }
- let!(:wp_match) { create(:work_package, project:, subject: 'R#1234 Foobar') }
- let!(:wp_nomatch) { create(:work_package, project:, subject: 'R!1234 Foobar') }
+ let!(:wp_match) { create(:work_package, project:, subject: "R#1234 Foobar") }
+ let!(:wp_nomatch) { create(:work_package, project:, subject: "R!1234 Foobar") }
before do
login_as admin
end
- it 'shows the one work package filtering for myself' do
+ it "shows the one work package filtering for myself" do
wp_table.visit!
wp_table.expect_work_package_listed(wp_match, wp_nomatch)
# Add and save query with me filter
filters.open
- filters.remove_filter 'status'
- filters.add_filter_by('Subject', 'contains', ['R#'])
+ filters.remove_filter "status"
+ filters.add_filter_by("Subject", "contains", ["R#"])
wp_table.ensure_work_package_not_listed!(wp_nomatch)
wp_table.expect_work_package_listed(wp_match)
- wp_table.save_as('Subject query')
+ wp_table.save_as("Subject query")
loading_indicator_saveguard
# Expect correct while saving
- wp_table.expect_title 'Subject query'
+ wp_table.expect_title "Subject query"
query = Query.last
- expect(query.filters.first.values).to eq ['R#']
- filters.expect_filter_by('Subject', 'contains', ['R#'])
+ expect(query.filters.first.values).to eq ["R#"]
+ filters.expect_filter_by("Subject", "contains", ["R#"])
# Revisit query
wp_table.visit_query query
@@ -68,6 +68,6 @@
wp_table.expect_work_package_listed(wp_match)
filters.open
- filters.expect_filter_by('Subject', 'contains', ['R#'])
+ filters.expect_filter_by("Subject", "contains", ["R#"])
end
end
diff --git a/spec/features/work_packages/table/queries/summary_spec.rb b/spec/features/work_packages/table/queries/summary_spec.rb
index 861f64f13a47..56bcbd4ac446 100644
--- a/spec/features/work_packages/table/queries/summary_spec.rb
+++ b/spec/features/work_packages/table/queries/summary_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/work_packages/work_packages_page'
+require "spec_helper"
+require "features/work_packages/work_packages_page"
-RSpec.describe 'Work package query summary item', :js do
- let(:project) { create(:project, identifier: 'test_project', public: false) }
+RSpec.describe "Work package query summary item", :js do
+ let(:project) { create(:project, identifier: "test_project", public: false) }
let(:role) { create(:project_role, permissions: [:view_work_packages]) }
let(:work_package) { create(:work_package, project:) }
let(:wp_page) { Pages::WorkPackagesTable.new project }
@@ -43,9 +43,9 @@
wp_page.visit!
end
- it 'allows users to visit the summary page' do
- find('.op-sidemenu--item-action', text: 'Summary', wait: 10).click
- expect(page).to have_css('h2', text: 'Summary')
- expect(page).to have_css('td', text: work_package.type.name)
+ it "allows users to visit the summary page" do
+ find(".op-sidemenu--item-action", text: "Summary", wait: 10).click
+ expect(page).to have_css("h2", text: "Summary")
+ expect(page).to have_css("td", text: work_package.type.name)
end
end
diff --git a/spec/features/work_packages/table/queries/user_cf_filter_spec.rb b/spec/features/work_packages/table/queries/user_cf_filter_spec.rb
index d974c5ab2637..494544d4367a 100644
--- a/spec/features/work_packages/table/queries/user_cf_filter_spec.rb
+++ b/spec/features/work_packages/table/queries/user_cf_filter_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work package filtering by user custom field', :js do
+RSpec.describe "Work package filtering by user custom field", :js do
let(:project) { create(:project) }
let(:type) { project.types.first }
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
@@ -42,8 +42,8 @@
let(:role) { create(:project_role, permissions: %i[view_work_packages save_queries]) }
let!(:other_user) do
create(:user,
- firstname: 'Other',
- lastname: 'User',
+ firstname: "Other",
+ lastname: "User",
member_with_roles: { project => role })
end
let!(:placeholder_user) do
@@ -84,7 +84,7 @@
create(:user, member_with_roles: { project => role })
end
- it 'shows the work package matching the user cf filter' do
+ it "shows the work package matching the user cf filter" do
wp_table.visit!
wp_table.expect_work_package_listed(work_package_user, work_package_placeholder, work_package_group)
@@ -92,14 +92,14 @@
# Filtering by user
- filters.add_filter_by(user_cf.name, 'is (OR)', [other_user.name], user_cf.attribute_name(:camel_case))
+ filters.add_filter_by(user_cf.name, "is (OR)", [other_user.name], user_cf.attribute_name(:camel_case))
wp_table.ensure_work_package_not_listed!(work_package_placeholder, work_package_group)
wp_table.expect_work_package_listed(work_package_user)
- wp_table.save_as('Saved query')
+ wp_table.save_as("Saved query")
- wp_table.expect_and_dismiss_toaster(message: 'Successful creation.')
+ wp_table.expect_and_dismiss_toaster(message: "Successful creation.")
# Revisit query
wp_table.visit_query Query.last
@@ -107,12 +107,12 @@
wp_table.expect_work_package_listed(work_package_user)
filters.open
- filters.expect_filter_by(user_cf.name, 'is (OR)', [other_user.name], "customField#{user_cf.id}")
+ filters.expect_filter_by(user_cf.name, "is (OR)", [other_user.name], "customField#{user_cf.id}")
# Filtering by placeholder
filters.remove_filter user_cf.attribute_name(:camel_case)
- filters.add_filter_by(user_cf.name, 'is (OR)', [placeholder_user.name], user_cf.attribute_name(:camel_case))
+ filters.add_filter_by(user_cf.name, "is (OR)", [placeholder_user.name], user_cf.attribute_name(:camel_case))
wp_table.ensure_work_package_not_listed!(work_package_user, work_package_group)
wp_table.expect_work_package_listed(work_package_placeholder)
@@ -120,7 +120,7 @@
# Filtering by group
filters.remove_filter user_cf.attribute_name(:camel_case)
- filters.add_filter_by(user_cf.name, 'is (OR)', [group.name], user_cf.attribute_name(:camel_case))
+ filters.add_filter_by(user_cf.name, "is (OR)", [group.name], user_cf.attribute_name(:camel_case))
wp_table.ensure_work_package_not_listed!(work_package_user, work_package_placeholder)
wp_table.expect_work_package_listed(work_package_group)
diff --git a/spec/features/work_packages/table/queries/version_cf_filter_spec.rb b/spec/features/work_packages/table/queries/version_cf_filter_spec.rb
index 939560142d79..027ee07e9820 100644
--- a/spec/features/work_packages/table/queries/version_cf_filter_spec.rb
+++ b/spec/features/work_packages/table/queries/version_cf_filter_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
# This is not strictly version CF specific, but targets regression #53198.
-RSpec.describe 'Work package filtering by version custom field', :js do
+RSpec.describe "Work package filtering by version custom field", :js do
let!(:project) { create(:project) }
let!(:type) { project.types.first }
let!(:version_cf1) do
@@ -50,8 +50,8 @@
projects: [project]
)
end
- let!(:version_1) { create(:version, project:, name: 'Version 1') }
- let!(:version_2) { create(:version, project:, name: 'Version 2') }
+ let!(:version_1) { create(:version, project:, name: "Version 1") }
+ let!(:version_2) { create(:version, project:, name: "Version 2") }
let(:role) { create(:project_role, permissions: %i[view_work_packages save_queries]) }
@@ -101,14 +101,14 @@
# Filtering by cf1 "is (AND)"
- filters.add_filter_by(version_cf1.name, 'is (AND)', [version_1.name], version_cf1.attribute_name(:camel_case))
+ filters.add_filter_by(version_cf1.name, "is (AND)", [version_1.name], version_cf1.attribute_name(:camel_case))
wp_table.expect_work_package_listed(work_package_1_1, work_package_mix)
wp_table.ensure_work_package_not_listed!(work_package_2_1)
# Filtering by multiple cf1 values (nothing matches)
filters.remove_filter version_cf1.attribute_name(:camel_case)
- filters.add_filter_by(version_cf1.name, 'is (AND)', [version_1.name, version_2.name], version_cf1.attribute_name(:camel_case))
+ filters.add_filter_by(version_cf1.name, "is (AND)", [version_1.name, version_2.name], version_cf1.attribute_name(:camel_case))
wp_table.ensure_work_package_not_listed!(work_package_2_1, work_package_1_1, work_package_mix)
end
@@ -120,7 +120,7 @@
filters.open
# Filtering by cf1 "is not"
- filters.add_filter_by(version_cf2.name, 'is not', [version_1.name], version_cf2.attribute_name(:camel_case))
+ filters.add_filter_by(version_cf2.name, "is not", [version_1.name], version_cf2.attribute_name(:camel_case))
wp_table.expect_work_package_listed(work_package_mix, work_package_1_1)
wp_table.ensure_work_package_not_listed!(work_package_2_1)
diff --git a/spec/features/work_packages/table/relations_spec.rb b/spec/features/work_packages/table/relations_spec.rb
index eb071852840f..09cfa53da44b 100644
--- a/spec/features/work_packages/table/relations_spec.rb
+++ b/spec/features/work_packages/table/relations_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work Package table relations', :js, with_ee: %i[work_package_query_relation_columns] do
+RSpec.describe "Work Package table relations", :js, with_ee: %i[work_package_query_relation_columns] do
let(:user) { create(:admin) }
let(:type) { create(:type) }
@@ -29,7 +29,7 @@
end
let!(:query) do
query = build(:query, user:, project:)
- query.column_names = ['subject']
+ query.column_names = ["subject"]
query.filters.clear
query.save!
@@ -37,14 +37,14 @@
end
let(:type_column_id) { "relationsToType#{type.id}" }
- let(:type_column_follows) { 'relationsOfTypeFollows' }
+ let(:type_column_follows) { "relationsOfTypeFollows" }
before do
login_as(user)
end
- describe 'with relation columns allowed by the enterprise token' do
- it 'displays expandable relation columns' do
+ describe "with relation columns allowed by the enterprise token" do
+ it "displays expandable relation columns" do
# Now visiting the query for category
wp_table.visit_query(query)
wp_table.expect_work_package_listed(wp_from, wp_to, wp_to2)
@@ -56,8 +56,8 @@
wp_from_to = wp_table.row(wp_to)
# Expect count for wp_from in both columns to be one
- expect(wp_from_row).to have_css(".#{type_column_id} .wp-table--relation-count", text: '2')
- expect(wp_from_row).to have_css(".#{type_column_follows} .wp-table--relation-count", text: '2')
+ expect(wp_from_row).to have_css(".#{type_column_id} .wp-table--relation-count", text: "2")
+ expect(wp_from_row).to have_css(".#{type_column_follows} .wp-table--relation-count", text: "2")
# Expect count for wp_to in both columns to be not rendered
expect(wp_from_to).to have_no_css(".#{type_column_id} .wp-table--relation-count")
@@ -67,7 +67,7 @@
wp_from_row.find(".#{type_column_id} .wp-table--relation-indicator").click
expect(page).to have_css(".__relations-expanded-from-#{wp_from.id}", count: 2)
related_row = page.first(".__relations-expanded-from-#{wp_from.id}")
- expect(related_row).to have_css('td.wp-table--relation-cell-td', text: "Precedes")
+ expect(related_row).to have_css("td.wp-table--relation-cell-td", text: "Precedes")
# Collapse
wp_from_row.find(".#{type_column_id} .wp-table--relation-indicator").click
@@ -77,16 +77,16 @@
wp_from_row.find(".#{type_column_follows} .wp-table--relation-indicator").click
expect(page).to have_css(".__relations-expanded-from-#{wp_from.id}", count: 2)
related_row = page.first(".__relations-expanded-from-#{wp_from.id}")
- expect(related_row).to have_css('.wp-table--relation-cell-td', text: wp_to.type)
+ expect(related_row).to have_css(".wp-table--relation-cell-td", text: wp_to.type)
end
end
- describe 'with relation columns disallowed by the enterprise token', with_ee: false do
- it 'has no relation columns available for selection' do
+ describe "with relation columns disallowed by the enterprise token", with_ee: false do
+ it "has no relation columns available for selection" do
# Now visiting the query for category
wp_table.visit_query(query)
- columns.expect_column_not_available 'follows relations'
+ columns.expect_column_not_available "follows relations"
columns.expect_column_not_available "Relations to #{type.name}"
end
end
diff --git a/spec/features/work_packages/table/scheduling/manual_scheduling_spec.rb b/spec/features/work_packages/table/scheduling/manual_scheduling_spec.rb
index 0e190e3806f9..206306393551 100644
--- a/spec/features/work_packages/table/scheduling/manual_scheduling_spec.rb
+++ b/spec/features/work_packages/table/scheduling/manual_scheduling_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Manual scheduling', :js do
+RSpec.describe "Manual scheduling", :js do
let(:project) { create(:project, types: [type]) }
let(:type) { create(:type) }
@@ -10,7 +10,7 @@
create(:work_package,
project:,
type:,
- subject: 'Parent')
+ subject: "Parent")
end
let!(:child) do
@@ -18,7 +18,7 @@
project:,
parent:,
type:,
- subject: 'Child')
+ subject: "Child")
end
let!(:wp_table) { Pages::WorkPackagesTable.new(project) }
@@ -39,10 +39,10 @@
wp_table.expect_work_package_listed parent, child
end
- context 'with a user allowed to edit dates' do
+ context "with a user allowed to edit dates" do
let(:role) { create(:project_role, permissions: %i[view_work_packages edit_work_packages]) }
- it 'allows to edit start and due date multiple times switching between scheduling modes' do
+ it "allows to edit start and due date multiple times switching between scheduling modes" do
start_date = wp_table.edit_field(parent, :startDate)
due_date = wp_table.edit_field(parent, :dueDate)
@@ -57,8 +57,8 @@
start_date.within_modal do
expect(page).to have_css('input[name="startDate"][disabled]')
expect(page).to have_css('input[name="endDate"][disabled]')
- expect(page).to have_css("#{test_selector('op-datepicker-modal--action')}:not([disabled])", text: 'Cancel')
- expect(page).to have_css("#{test_selector('op-datepicker-modal--action')}:not([disabled])", text: 'Save')
+ expect(page).to have_css("#{test_selector('op-datepicker-modal--action')}:not([disabled])", text: "Cancel")
+ expect(page).to have_css("#{test_selector('op-datepicker-modal--action')}:not([disabled])", text: "Save")
end
start_date.toggle_scheduling_mode
@@ -67,8 +67,8 @@
start_date.within_modal do
expect(page).to have_css('input[name="startDate"]:not([disabled])')
expect(page).to have_css('input[name="endDate"]:not([disabled])')
- expect(page).to have_css("#{test_selector('op-datepicker-modal--action')}:not([disabled])", text: 'Cancel')
- expect(page).to have_css("#{test_selector('op-datepicker-modal--action')}:not([disabled])", text: 'Save')
+ expect(page).to have_css("#{test_selector('op-datepicker-modal--action')}:not([disabled])", text: "Cancel")
+ expect(page).to have_css("#{test_selector('op-datepicker-modal--action')}:not([disabled])", text: "Save")
end
start_date.cancel_by_click
@@ -89,10 +89,10 @@
# Expect not editable
start_date.within_modal do
- expect(page).to have_css('input[name=startDate][disabled]')
- expect(page).to have_css('input[name=endDate][disabled]')
- expect(page).to have_css("#{test_selector('op-datepicker-modal--action')}:not([disabled])", text: 'Cancel')
- expect(page).to have_css("#{test_selector('op-datepicker-modal--action')}:not([disabled])", text: 'Save')
+ expect(page).to have_css("input[name=startDate][disabled]")
+ expect(page).to have_css("input[name=endDate][disabled]")
+ expect(page).to have_css("#{test_selector('op-datepicker-modal--action')}:not([disabled])", text: "Cancel")
+ expect(page).to have_css("#{test_selector('op-datepicker-modal--action')}:not([disabled])", text: "Save")
end
start_date.toggle_scheduling_mode
@@ -100,25 +100,25 @@
# Expect not editable
start_date.within_modal do
- fill_in 'startDate', with: '2020-07-20'
- fill_in 'endDate', with: '2020-07-25'
+ fill_in "startDate", with: "2020-07-20"
+ fill_in "endDate", with: "2020-07-25"
end
# Wait for the debounce to be done
sleep 1
start_date.save!
- start_date.expect_state_text '07/20/2020'
- due_date.expect_state_text '07/25/2020'
+ start_date.expect_state_text "07/20/2020"
+ due_date.expect_state_text "07/25/2020"
parent.reload
expect(parent).to be_schedule_manually
- expect(parent.start_date.iso8601).to eq('2020-07-20')
- expect(parent.due_date.iso8601).to eq('2020-07-25')
+ expect(parent.start_date.iso8601).to eq("2020-07-20")
+ expect(parent.due_date.iso8601).to eq("2020-07-25")
end
end
- context 'with a user allowed to view only' do
+ context "with a user allowed to view only" do
let(:role) { create(:project_role, permissions: %i[view_work_packages]) }
end
end
diff --git a/spec/features/work_packages/table/switch_types_spec.rb b/spec/features/work_packages/table/switch_types_spec.rb
index 7299e1af63cf..e565ae3ccbeb 100644
--- a/spec/features/work_packages/table/switch_types_spec.rb
+++ b/spec/features/work_packages/table/switch_types_spec.rb
@@ -1,14 +1,14 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Switching types in work package table', :js do
+RSpec.describe "Switching types in work package table", :js do
let(:user) { create(:admin) }
- describe 'switching to required CF' do
+ describe "switching to required CF" do
let(:cf_req_text) do
create(
:work_package_custom_field,
- field_format: 'string',
- name: 'Required CF',
+ field_format: "string",
+ name: "Required CF",
is_required: true,
is_for_all: false
)
@@ -16,7 +16,7 @@
let(:cf_text) do
create(
:work_package_custom_field,
- field_format: 'string',
+ field_format: "string",
is_required: false,
is_for_all: false
)
@@ -34,7 +34,7 @@
end
let(:work_package) do
create(:work_package,
- subject: 'Foobar',
+ subject: "Foobar",
type: type_task,
project:)
end
@@ -42,7 +42,7 @@
let(:query) do
query = build(:query, user:, project:)
- query.column_names = ['id', 'subject', 'type', cf_text.column_name]
+ query.column_names = ["id", "subject", "type", cf_text.column_name]
query.save!
query
@@ -71,16 +71,16 @@ def req_text_field
wp_table.expect_work_package_listed(work_package)
end
- it 'switches the types correctly' do
+ it "switches the types correctly" do
expect(text_field).to be_editable
# Set non-required CF
text_field.activate!
- text_field.set_value 'Foobar'
+ text_field.set_value "Foobar"
text_field.save!
wp_table.expect_and_dismiss_toaster(
- message: 'Successful update. Click here to open this work package in fullscreen view.'
+ message: "Successful update. Click here to open this work package in fullscreen view."
)
# Switch type
@@ -94,11 +94,11 @@ def req_text_field
# Required CF requires activation
req_text_field.activate!
- req_text_field.set_value 'Required'
+ req_text_field.set_value "Required"
req_text_field.save!
wp_table.expect_and_dismiss_toaster(
- message: 'Successful update. Click here to open this work package in fullscreen view.'
+ message: "Successful update. Click here to open this work package in fullscreen view."
)
expect { text_field.display_element }.to raise_error(Capybara::ElementNotFound)
@@ -107,14 +107,14 @@ def req_text_field
type_field.set_value type_task.name
wp_table.expect_and_dismiss_toaster(
- message: 'Successful update. Click here to open this work package in fullscreen view.'
+ message: "Successful update. Click here to open this work package in fullscreen view."
)
expect(page).to have_no_css "#{req_text_field.selector} #{req_text_field.display_selector}"
expect { req_text_field.display_element }.to raise_error(Capybara::ElementNotFound)
end
- it 'can switch back from an open required CF (Regression test #28099)' do
+ it "can switch back from an open required CF (Regression test #28099)" do
# Switch type
type_field.activate!
type_field.set_value type_bug.name
@@ -133,17 +133,17 @@ def req_text_field
type_field.set_value type_task.name
wp_table.expect_and_dismiss_toaster(
- message: 'Successful update. Click here to open this work package in fullscreen view.'
+ message: "Successful update. Click here to open this work package in fullscreen view."
)
end
- context 'switching to single view' do
+ context "switching to single view" do
let(:wp_split) { wp_table.open_split_view(work_package) }
let(:type_field) { wp_split.edit_field(:type) }
let(:text_field) { wp_split.edit_field(cf_text.attribute_name(:camel_case)) }
let(:req_text_field) { wp_split.edit_field(cf_req_text.attribute_name(:camel_case)) }
- it 'allows editing and cancelling the new required fields' do
+ it "allows editing and cancelling the new required fields" do
wp_split
# Switch type
@@ -161,25 +161,25 @@ def req_text_field
# Cancel edition now
SeleniumHubWaiter.wait
req_text_field.cancel_by_escape
- req_text_field.expect_state_text '-'
+ req_text_field.expect_state_text "-"
# Set the value now
- req_text_field.update 'foobar'
+ req_text_field.update "foobar"
wp_table.expect_and_dismiss_toaster(
- message: 'Successful update. Click here to open this work package in fullscreen view.'
+ message: "Successful update. Click here to open this work package in fullscreen view."
)
- req_text_field.expect_state_text 'foobar'
+ req_text_field.expect_state_text "foobar"
end
end
end
- describe 'switching to required bool CF with default value' do
+ describe "switching to required bool CF with default value" do
let(:cf_req_bool) do
create(
:work_package_custom_field,
- field_format: 'bool',
+ field_format: "bool",
is_required: true,
default_value: false
)
@@ -197,7 +197,7 @@ def req_text_field
end
let(:work_package) do
create(:work_package,
- subject: 'Foobar',
+ subject: "Foobar",
type: type_task,
project:)
end
@@ -210,11 +210,11 @@ def req_text_field
wp_page.ensure_page_loaded
end
- it 'can switch to the bug type without errors' do
+ it "can switch to the bug type without errors" do
type_field.expect_state_text type_task.name.upcase
type_field.update type_bug.name
- wp_page.expect_and_dismiss_toaster message: 'Successful update.'
+ wp_page.expect_and_dismiss_toaster message: "Successful update."
type_field.expect_state_text type_bug.name.upcase
@@ -224,7 +224,7 @@ def req_text_field
end
end
- describe 'switching to list CF' do
+ describe "switching to list CF" do
let!(:wp_page) { Pages::FullWorkPackageCreate.new }
let!(:type_with_cf) { create(:type_task, custom_fields: [custom_field]) }
let!(:type) { create(:type_bug) }
@@ -264,7 +264,7 @@ def req_text_field
let(:cf_edit_field) do
field = wp_page.edit_field custom_field.attribute_name(:camel_case)
- field.field_type = 'create-autocompleter'
+ field.field_type = "create-autocompleter"
field
end
@@ -277,10 +277,10 @@ def req_text_field
SeleniumHubWaiter.wait
end
- it 'can switch to the type with CF list' do
+ it "can switch to the type with CF list" do
# Set subject
subject = wp_page.edit_field :subject
- subject.set_value 'My subject'
+ subject.set_value "My subject"
# Switch type
type_field = wp_page.edit_field :type
@@ -297,11 +297,11 @@ def req_text_field
wp_page.save!
wp_page.expect_toast(
- message: 'Successful creation.'
+ message: "Successful creation."
)
new_wp = WorkPackage.last
- expect(new_wp.subject).to eq('My subject')
+ expect(new_wp.subject).to eq("My subject")
expect(new_wp.type_id).to eq(type_with_cf.id)
expect(new_wp.custom_value_for(custom_field.id).map(&:typed_value)).to match_array(%w(pineapple mushrooms))
end
diff --git a/spec/features/work_packages/table/work_packages_table_project_include_spec.rb b/spec/features/work_packages/table/work_packages_table_project_include_spec.rb
index 9a7f79725644..8d34bf2d826a 100644
--- a/spec/features/work_packages/table/work_packages_table_project_include_spec.rb
+++ b/spec/features/work_packages/table/work_packages_table_project_include_spec.rb
@@ -26,25 +26,25 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require_relative '../project_include/project_include_shared_examples'
+require "spec_helper"
+require_relative "../project_include/project_include_shared_examples"
-RSpec.describe 'Work package project include', :js do
+RSpec.describe "Work package project include", :js do
shared_let(:enabled_modules) { %w[work_package_tracking] }
shared_let(:status) { create(:default_status) }
shared_let(:priority) { create(:default_priority) }
shared_let(:permissions) { %i[view_work_packages edit_work_packages add_work_packages save_queries manage_public_queries] }
- it_behaves_like 'has a project include dropdown' do
+ it_behaves_like "has a project include dropdown" do
shared_let(:work_package_view) { Pages::WorkPackagesTable.new(project) }
- it 'correctly filters work packages by project' do
+ it "correctly filters work packages by project" do
dropdown.expect_count 1
# Make sure the filter gets set once
dropdown.toggle!
dropdown.expect_open
- dropdown.click_button 'Apply'
+ dropdown.click_button "Apply"
dropdown.expect_closed
work_package_view.expect_work_package_listed(task, other_task, sub_bug, sub_sub_bug)
@@ -52,7 +52,7 @@
dropdown.toggle!
dropdown.toggle_checkbox(sub_sub_sub_project.id)
- dropdown.click_button 'Apply'
+ dropdown.click_button "Apply"
dropdown.expect_count 1
work_package_view.expect_work_package_listed(task, other_task, sub_sub_bug, sub_bug)
@@ -60,7 +60,7 @@
dropdown.toggle!
dropdown.toggle_checkbox(other_project.id)
- dropdown.click_button 'Apply'
+ dropdown.click_button "Apply"
dropdown.expect_count 2
work_package_view.expect_work_package_listed(task, other_task, sub_sub_bug, sub_bug, other_other_task)
@@ -70,14 +70,14 @@
work_package_view.expect_work_package_listed(task, other_task, sub_bug, sub_sub_bug, other_other_task)
end
- it 'creates new work packages in the host project of the work package view (regression #42271)' do
+ it "creates new work packages in the host project of the work package view (regression #42271)" do
dropdown.expect_count 1
# Make sure the filter gets set once
dropdown.toggle!
dropdown.expect_open
dropdown.toggle_checkbox(other_sub_sub_project.id)
- dropdown.click_button 'Apply'
+ dropdown.click_button "Apply"
dropdown.expect_count 2
work_package_view.click_inline_create
@@ -85,14 +85,14 @@
subject_field.expect_active!
# Save the WP
- subject_field.set_value 'Foobar!'
+ subject_field.set_value "Foobar!"
subject_field.submit_by_enter
work_package_view.expect_and_dismiss_toaster(
- message: 'Successful creation. Click here to open this work package in fullscreen view.'
+ message: "Successful creation. Click here to open this work package in fullscreen view."
)
- work_package_view.expect_work_package_subject 'Foobar!'
+ work_package_view.expect_work_package_subject "Foobar!"
inline_created = WorkPackage.last
expect(inline_created.project).to eq(project)
diff --git a/spec/features/work_packages/tabs/activity_notifications_spec.rb b/spec/features/work_packages/tabs/activity_notifications_spec.rb
index 6b2152384430..80b45c45c492 100644
--- a/spec/features/work_packages/tabs/activity_notifications_spec.rb
+++ b/spec/features/work_packages/tabs/activity_notifications_spec.rb
@@ -1,23 +1,23 @@
-require 'spec_helper'
+require "spec_helper"
-require 'features/work_packages/work_packages_page'
-require 'support/edit_fields/edit_field'
+require "features/work_packages/work_packages_page"
+require "support/edit_fields/edit_field"
-RSpec.describe 'Activity tab notifications', :js, :selenium do
+RSpec.describe "Activity tab notifications", :js, :selenium do
shared_let(:project) { create(:project_with_types, public: true) }
shared_let(:work_package) do
create(:work_package,
project:,
journals: {
6.days.ago => {},
- 5.days.ago => { notes: 'First comment on this wp.' },
- 4.days.ago => { notes: 'Second comment on this wp.' },
- 3.days.ago => { notes: 'Third comment on this wp.' }
+ 5.days.ago => { notes: "First comment on this wp." },
+ 4.days.ago => { notes: "Second comment on this wp." },
+ 3.days.ago => { notes: "Third comment on this wp." }
})
end
shared_let(:admin) { create(:admin) }
- shared_examples_for 'when there are notifications for the work package' do
+ shared_examples_for "when there are notifications for the work package" do
shared_let(:notification) do
create(:notification,
recipient: admin,
@@ -25,79 +25,79 @@
resource: work_package,
journal: work_package.journals.last)
end
- it 'shows a notification bubble with the right number' do
- expect(page).to have_test_selector('tab-counter-Activity', text: '1')
+ it "shows a notification bubble with the right number" do
+ expect(page).to have_test_selector("tab-counter-Activity", text: "1")
end
- it 'shows a notification icon next to activities that have an unread notification' do
- expect(page).to have_test_selector('user-activity-bubble', count: 1)
+ it "shows a notification icon next to activities that have an unread notification" do
+ expect(page).to have_test_selector("user-activity-bubble", count: 1)
expect(page).to have_css("[data-qa-activity-number='4'] #{test_selector('user-activity-bubble')}")
end
- it 'shows a button to mark the notifications as read' do
- expect(page).to have_test_selector('mark-notification-read-button')
+ it "shows a button to mark the notifications as read" do
+ expect(page).to have_test_selector("mark-notification-read-button")
# A click marks the notification as read ...
- page.find_test_selector('mark-notification-read-button').click
+ page.find_test_selector("mark-notification-read-button").click
# ... and updates the view accordingly
- expect(page).not_to have_test_selector('mark-notification-read-button')
- expect(page).not_to have_test_selector('tab-counter-Activity')
- expect(page).not_to have_test_selector('user-activity-bubble')
+ expect(page).not_to have_test_selector("mark-notification-read-button")
+ expect(page).not_to have_test_selector("tab-counter-Activity")
+ expect(page).not_to have_test_selector("user-activity-bubble")
end
end
- shared_examples_for 'when there are no notifications for the work package' do
- it 'shows no notification bubble' do
- expect(page).not_to have_test_selector('tab-counter-Activity')
+ shared_examples_for "when there are no notifications for the work package" do
+ it "shows no notification bubble" do
+ expect(page).not_to have_test_selector("tab-counter-Activity")
end
- it 'does not show any notification icons next to activities' do
- expect(page).not_to have_test_selector('user-activity-bubble')
+ it "does not show any notification icons next to activities" do
+ expect(page).not_to have_test_selector("user-activity-bubble")
end
- it 'shows no button to mark the notifications as read' do
- expect(page).not_to have_test_selector('mark-notification-read-button')
+ it "shows no button to mark the notifications as read" do
+ expect(page).not_to have_test_selector("mark-notification-read-button")
end
end
- context 'when on full view' do
+ context "when on full view" do
shared_let(:full_view) { Pages::FullWorkPackage.new(work_package, project) }
before do
login_as(admin)
- full_view.visit_tab! 'activity'
+ full_view.visit_tab! "activity"
end
- it_behaves_like 'when there are notifications for the work package'
+ it_behaves_like "when there are notifications for the work package"
- it_behaves_like 'when there are no notifications for the work package'
+ it_behaves_like "when there are no notifications for the work package"
end
- context 'when on split view' do
+ context "when on split view" do
shared_let(:split_view) { Pages::SplitWorkPackage.new(work_package, project) }
before do
login_as(admin)
- split_view.visit_tab! 'activity'
+ split_view.visit_tab! "activity"
end
- it_behaves_like 'when there are notifications for the work package'
+ it_behaves_like "when there are notifications for the work package"
- it_behaves_like 'when there are no notifications for the work package'
+ it_behaves_like "when there are no notifications for the work package"
end
- context 'when visiting as an anonymous user', with_settings: { login_required?: false } do
+ context "when visiting as an anonymous user", with_settings: { login_required?: false } do
let(:full_view) { Pages::FullWorkPackage.new(work_package, project) }
let!(:anonymous_role) do
create(:anonymous_role, permissions: [:view_work_packages])
end
- it 'does not show an error' do
- full_view.visit_tab! 'activity'
+ it "does not show an error" do
+ full_view.visit_tab! "activity"
full_view.ensure_page_loaded
- full_view.expect_no_toaster type: :error, message: 'Http failure response for'
+ full_view.expect_no_toaster type: :error, message: "Http failure response for"
full_view.expect_no_toaster
end
end
diff --git a/spec/features/work_packages/tabs/activity_revisions_spec.rb b/spec/features/work_packages/tabs/activity_revisions_spec.rb
index 065fce237595..62a5da663f8e 100644
--- a/spec/features/work_packages/tabs/activity_revisions_spec.rb
+++ b/spec/features/work_packages/tabs/activity_revisions_spec.rb
@@ -1,9 +1,9 @@
-require 'spec_helper'
+require "spec_helper"
-require 'features/work_packages/work_packages_page'
-require 'support/edit_fields/edit_field'
+require "features/work_packages/work_packages_page"
+require "support/edit_fields/edit_field"
-RSpec.describe 'Activity tab', :js, :with_cuprite do
+RSpec.describe "Activity tab", :js, :with_cuprite do
let(:project) { create(:project_with_types, public: true) }
let(:creation_time) { 5.days.ago }
@@ -18,13 +18,13 @@
subject: initial_subject,
journals: {
creation_time => { notes: initial_comment },
- subject_change_time => { subject: 'New subject', description: 'Some not so long description.' },
- comment_time => { notes: 'A comment by a different user', user: create(:admin) }
+ subject_change_time => { subject: "New subject", description: "Some not so long description." },
+ comment_time => { notes: "A comment by a different user", user: create(:admin) }
})
end
- let(:initial_subject) { 'My Subject' }
- let(:initial_comment) { 'First comment on this wp.' }
+ let(:initial_subject) { "My Subject" }
+ let(:initial_comment) { "First comment on this wp." }
let(:comments_in_reverse) { false }
let(:activity_tab) { Components::WorkPackages::Activities.new(work_package) }
@@ -43,10 +43,10 @@
repo.save!
changeset = build(:changeset,
- comments: 'A comment on a changeset',
+ comments: "A comment on a changeset",
committed_on: revision_time,
repository: repo,
- committer: 'cool@person.org')
+ committer: "cool@person.org")
work_package.changesets << changeset
@@ -57,12 +57,12 @@
before do
allow(user.pref).to receive(:warn_on_leaving_unsaved?).and_return(false)
- allow(user.pref).to receive(:comments_sorting).and_return(comments_in_reverse ? 'desc' : 'asc')
+ allow(user.pref).to receive(:comments_sorting).and_return(comments_in_reverse ? "desc" : "asc")
allow(user.pref).to receive(:comments_in_reverse_order?).and_return(comments_in_reverse)
end
- shared_examples 'shows activities in order' do
- it 'shows activities in ascending order' do
+ shared_examples "shows activities in order" do
+ it "shows activities in ascending order" do
activities.each_with_index do |activity, idx|
actual_index =
if comments_in_reverse
@@ -86,15 +86,15 @@
activity = page.find("#activity-#{idx + 1}")
if activity.is_a?(Journal) && activity.id != subject_change_journal.id
- expect(activity).to have_css('.user', text: activity.user.name)
- expect(activity).to have_css('.user-comment > .message', text: activity.notes, visible: :all)
+ expect(activity).to have_css(".user", text: activity.user.name)
+ expect(activity).to have_css(".user-comment > .message", text: activity.notes, visible: :all)
elsif activity.is_a?(Changeset)
- expect(activity).to have_css('.user', text: User.find(activity.user_id).name)
- expect(activity).to have_css('.user-comment > .message', text: activity.notes, visible: :all)
+ expect(activity).to have_css(".user", text: User.find(activity.user_id).name)
+ expect(activity).to have_css(".user-comment > .message", text: activity.notes, visible: :all)
elsif activity == subject_change_journal
- expect(activity).to have_css('.work-package-details-activities-messages .message',
+ expect(activity).to have_css(".work-package-details-activities-messages .message",
count: 2)
- expect(activity).to have_css('.message',
+ expect(activity).to have_css(".message",
text: "Subject changed from #{initial_subject} " \
"to #{activity.data.subject}")
end
@@ -102,13 +102,13 @@
end
end
- shared_examples 'activity tab' do
+ shared_examples "activity tab" do
before do
- work_package_page.visit_tab! 'activity'
+ work_package_page.visit_tab! "activity"
work_package_page.ensure_page_loaded
end
- context 'with permission' do
+ context "with permission" do
let(:role) do
create(:project_role, permissions: %i[view_work_packages
view_changesets
@@ -122,63 +122,63 @@
[creation_journal, subject_change_journal, revision, comment_journal]
end
- context 'with ascending comments' do
+ context "with ascending comments" do
let(:comments_in_reverse) { false }
- it_behaves_like 'shows activities in order'
+ it_behaves_like "shows activities in order"
end
- context 'with reversed comments' do
+ context "with reversed comments" do
let(:comments_in_reverse) { true }
- it_behaves_like 'shows activities in order'
+ it_behaves_like "shows activities in order"
end
- it 'can toggle between activities and comments-only' do
- expect(page).to have_css('.work-package-details-activities-activity-contents', count: 4)
- expect(page).to have_css('.user-comment > .message', text: comment_journal.notes)
+ it "can toggle between activities and comments-only" do
+ expect(page).to have_css(".work-package-details-activities-activity-contents", count: 4)
+ expect(page).to have_css(".user-comment > .message", text: comment_journal.notes)
# Show only comments
- find('.activity-comments--toggler').click
+ find(".activity-comments--toggler").click
# It should remove the middle
- expect(page).to have_css('.work-package-details-activities-activity-contents', count: 2)
- expect(page).to have_css('.user-comment > .message', text: initial_comment)
- expect(page).to have_css('.user-comment > .message', text: comment_journal.notes)
+ expect(page).to have_css(".work-package-details-activities-activity-contents", count: 2)
+ expect(page).to have_css(".user-comment > .message", text: initial_comment)
+ expect(page).to have_css(".user-comment > .message", text: comment_journal.notes)
# Show all again
- find('.activity-comments--toggler').click
- expect(page).to have_css('.work-package-details-activities-activity-contents', count: 4)
+ find(".activity-comments--toggler").click
+ expect(page).to have_css(".work-package-details-activities-activity-contents", count: 4)
end
- it 'can quote a previous comment' do
- activity_tab.hover_action('1', :quote)
+ it "can quote a previous comment" do
+ activity_tab.hover_action("1", :quote)
field = TextEditorField.new work_package_page,
- 'comment',
- selector: '.work-packages--activity--add-comment'
+ "comment",
+ selector: ".work-packages--activity--add-comment"
expect(field.editing?).to be true
# Add our comment
- editor = find('.ck-content')
- expect(editor).to have_css('blockquote', text: initial_comment)
+ editor = find(".ck-content")
+ expect(editor).to have_css("blockquote", text: initial_comment)
editor.base.send_keys "\nthis is some remark under a quote"
field.submit_by_click
- expect(page).to have_css('.user-comment > .message', count: 3)
- expect(page).to have_css('.user-comment > .message blockquote')
+ expect(page).to have_css(".user-comment > .message", count: 3)
+ expect(page).to have_css(".user-comment > .message blockquote")
end
- it 'can reference a changeset (Regression #30415)' do
- work_package_page.visit_tab! 'activity'
+ it "can reference a changeset (Regression #30415)" do
+ work_package_page.visit_tab! "activity"
work_package_page.ensure_page_loaded
- expect(page).to have_css('.user-comment > .message', text: initial_comment)
+ expect(page).to have_css(".user-comment > .message", text: initial_comment)
comment_field = TextEditorField.new work_package_page,
- 'comment',
- selector: '.work-packages--activity--add-comment'
+ "comment",
+ selector: ".work-packages--activity--add-comment"
comment_field.activate!
comment_field.click_and_type_slowly "References r#{revision.revision}"
@@ -188,7 +188,7 @@
end
end
- context 'with no permission' do
+ context "with no permission" do
let(:role) do
create(:project_role, permissions: [:view_work_packages])
end
@@ -200,27 +200,27 @@
[creation_journal, subject_change_journal, comment_journal]
end
- context 'with ascending comments' do
+ context "with ascending comments" do
let(:comments_in_reverse) { false }
- it_behaves_like 'shows activities in order'
+ it_behaves_like "shows activities in order"
end
- it 'shows the activities, but does not allow commenting' do
- expect(page).to have_no_css('.work-packages--activity--add-comment', visible: :visible)
+ it "shows the activities, but does not allow commenting" do
+ expect(page).to have_no_css(".work-packages--activity--add-comment", visible: :visible)
end
end
end
- context 'when on the split screen' do
+ context "when on the split screen" do
let(:work_package_page) { Pages::SplitWorkPackage.new(work_package, project) }
- it_behaves_like 'activity tab'
+ it_behaves_like "activity tab"
end
- context 'when on the full screen' do
+ context "when on the full screen" do
let(:work_package_page) { Pages::FullWorkPackage.new(work_package) }
- it_behaves_like 'activity tab'
+ it_behaves_like "activity tab"
end
end
diff --git a/spec/features/work_packages/tabs/activity_tab_spec.rb b/spec/features/work_packages/tabs/activity_tab_spec.rb
index a56ad88a847f..71a7144745d6 100644
--- a/spec/features/work_packages/tabs/activity_tab_spec.rb
+++ b/spec/features/work_packages/tabs/activity_tab_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-require 'features/work_packages/work_packages_page'
-require 'support/edit_fields/edit_field'
+require "features/work_packages/work_packages_page"
+require "support/edit_fields/edit_field"
-RSpec.describe 'Activity tab', :js, :with_cuprite do
+RSpec.describe "Activity tab", :js, :with_cuprite do
let(:project) do
create(:project_with_types,
types: [type_with_cf],
@@ -57,8 +57,8 @@
subject: initial_subject,
journals: {
creation_time => { notes: initial_comment },
- subject_change_time => { subject: 'New subject', description: 'Some not so long description.' },
- comment_time => { notes: 'A comment by a different user', user: create(:admin) }
+ subject_change_time => { subject: "New subject", description: "Some not so long description." },
+ comment_time => { notes: "A comment by a different user", user: create(:admin) }
}).tap do |wp|
Journal::CustomizableJournal.create!(journal: wp.journals[1],
custom_field_id: string_cf.id,
@@ -66,8 +66,8 @@
end
end
- let(:initial_subject) { 'My Subject' }
- let(:initial_comment) { 'First comment on this wp.' }
+ let(:initial_subject) { "My Subject" }
+ let(:initial_comment) { "First comment on this wp." }
let(:comments_in_reverse) { false }
let(:activity_tab) { Components::WorkPackages::Activities.new(work_package) }
@@ -81,18 +81,18 @@
before do
allow(user.pref).to receive(:warn_on_leaving_unsaved?).and_return(false)
- allow(user.pref).to receive(:comments_sorting).and_return(comments_in_reverse ? 'desc' : 'asc')
+ allow(user.pref).to receive(:comments_sorting).and_return(comments_in_reverse ? "desc" : "asc")
allow(user.pref).to receive(:comments_in_reverse_order?).and_return(comments_in_reverse)
end
- shared_examples 'shows activities in order' do
+ shared_examples "shows activities in order" do
let(:journals) do
journals = [creation_journal, subject_change_journal, comment_journal]
journals
end
- it 'shows activities in ascending order' do
+ it "shows activities in ascending order" do
journals.each_with_index do |journal, idx|
actual_index =
if comments_in_reverse
@@ -110,14 +110,14 @@
activity = page.find("#activity-#{idx + 1}")
if journal.id != subject_change_journal.id
- expect(activity).to have_css('.op-user-activity--user-line', text: journal.user.name)
- expect(activity).to have_css('.user-comment > .message', text: journal.notes, visible: :all)
+ expect(activity).to have_css(".op-user-activity--user-line", text: journal.user.name)
+ expect(activity).to have_css(".user-comment > .message", text: journal.notes, visible: :all)
end
if activity == subject_change_journal
- expect(activity).to have_css('.work-package-details-activities-messages .message',
+ expect(activity).to have_css(".work-package-details-activities-messages .message",
count: 2)
- expect(activity).to have_css('.message',
+ expect(activity).to have_css(".message",
text: "Subject changed from #{initial_subject} " \
"to #{journal.data.subject}")
end
@@ -125,15 +125,15 @@
end
end
- shared_examples 'activity tab' do
+ shared_examples "activity tab" do
before do
- work_package_page.visit_tab! 'activity'
+ work_package_page.visit_tab! "activity"
work_package_page.ensure_page_loaded
- expect(page).to have_css('.user-comment > .message',
+ expect(page).to have_css(".user-comment > .message",
text: initial_comment)
end
- context 'with permission' do
+ context "with permission" do
let(:role) do
create(:project_role, permissions: %i[view_work_packages add_work_package_notes])
end
@@ -142,51 +142,51 @@
member_with_roles: { project => role })
end
- context 'with ascending comments' do
+ context "with ascending comments" do
let(:comments_in_reverse) { false }
- it_behaves_like 'shows activities in order'
+ it_behaves_like "shows activities in order"
end
- context 'with reversed comments' do
+ context "with reversed comments" do
let(:comments_in_reverse) { true }
- it_behaves_like 'shows activities in order'
+ it_behaves_like "shows activities in order"
end
- it 'can deep link to an activity' do
+ it "can deep link to an activity" do
visit "/work_packages/#{work_package.id}/activity#activity-#{comment_journal.id}"
work_package_page.ensure_page_loaded
- expect(page).to have_css('.user-comment > .message',
+ expect(page).to have_css(".user-comment > .message",
text: initial_comment)
expect(page.current_url).to match /\/work_packages\/#{work_package.id}\/activity#activity-#{comment_journal.id}/
end
- it 'can toggle between activities and comments-only' do
- expect(page).to have_css('.work-package-details-activities-activity-contents', count: 3)
- expect(page).to have_css('.user-comment > .message', text: comment_journal.notes)
+ it "can toggle between activities and comments-only" do
+ expect(page).to have_css(".work-package-details-activities-activity-contents", count: 3)
+ expect(page).to have_css(".user-comment > .message", text: comment_journal.notes)
# Show only comments
- find('.activity-comments--toggler').click
+ find(".activity-comments--toggler").click
# It should remove the middle
- expect(page).to have_css('.work-package-details-activities-activity-contents', count: 2)
- expect(page).to have_css('.user-comment > .message', text: initial_comment)
- expect(page).to have_css('.user-comment > .message', text: comment_journal.notes)
+ expect(page).to have_css(".work-package-details-activities-activity-contents", count: 2)
+ expect(page).to have_css(".user-comment > .message", text: initial_comment)
+ expect(page).to have_css(".user-comment > .message", text: comment_journal.notes)
# Show all again
- find('.activity-comments--toggler').click
- expect(page).to have_css('.work-package-details-activities-activity-contents', count: 3)
+ find(".activity-comments--toggler").click
+ expect(page).to have_css(".work-package-details-activities-activity-contents", count: 3)
end
- it 'can quote a previous comment' do
- activity_tab.hover_action('1', :quote)
+ it "can quote a previous comment" do
+ activity_tab.hover_action("1", :quote)
field = TextEditorField.new work_package_page,
- 'comment',
- selector: '.work-packages--activity--add-comment'
+ "comment",
+ selector: ".work-packages--activity--add-comment"
field.expect_active!
@@ -196,21 +196,21 @@
field.input_element.base.send_keys "\nthis is some remark under a quote"
field.submit_by_click
- expect(page).to have_css('.user-comment > .message', count: 3)
- expect(page).to have_css('.user-comment > .message blockquote')
+ expect(page).to have_css(".user-comment > .message", count: 3)
+ expect(page).to have_css(".user-comment > .message blockquote")
end
- it 'can render checkboxes as part of the activity' do
+ it "can render checkboxes as part of the activity" do
task_list = page.all('[data-qa-activity-number="2"] ul.op-uc-list_task-list li.op-uc-list--item')
expect(task_list.size).to eq(2)
- expect(task_list[0]).to have_text('Task 1')
+ expect(task_list[0]).to have_text("Task 1")
expect(task_list[0]).to have_checked_field(disabled: true)
- expect(task_list[1]).to have_text('Task 2')
+ expect(task_list[1]).to have_text("Task 2")
expect(task_list[1]).to have_unchecked_field(disabled: true)
end
end
- context 'with no permission' do
+ context "with no permission" do
let(:role) do
create(:project_role, permissions: [:view_work_packages])
end
@@ -219,21 +219,21 @@
member_with_roles: { project => role })
end
- it 'shows the activities, but does not allow commenting' do
- expect(page).to have_no_css('.work-packages--activity--add-comment', visible: :visible)
+ it "shows the activities, but does not allow commenting" do
+ expect(page).to have_no_css(".work-packages--activity--add-comment", visible: :visible)
end
end
end
- context 'if on split screen' do
+ context "if on split screen" do
let(:work_package_page) { Pages::SplitWorkPackage.new(work_package, project) }
- it_behaves_like 'activity tab'
+ it_behaves_like "activity tab"
end
- context 'if on full screen' do
+ context "if on full screen" do
let(:work_package_page) { Pages::FullWorkPackage.new(work_package) }
- it_behaves_like 'activity tab'
+ it_behaves_like "activity tab"
end
end
diff --git a/spec/features/work_packages/tabs/keep_tab_spec.rb b/spec/features/work_packages/tabs/keep_tab_spec.rb
index d30cd8d60df2..20daf6e7c148 100644
--- a/spec/features/work_packages/tabs/keep_tab_spec.rb
+++ b/spec/features/work_packages/tabs/keep_tab_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Keep current details tab', :js, :selenium do
+RSpec.describe "Keep current details tab", :js, :selenium do
let(:user) { create(:admin) }
let(:project) { create(:project) }
let!(:wp1) { create(:work_package, project:) }
@@ -42,7 +42,7 @@
wp_table.visit!
end
- it 'Remembers the tab while navigating the page' do
+ it "Remembers the tab while navigating the page" do
wp_table.expect_work_package_listed(wp1)
wp_table.expect_work_package_listed(wp2)
@@ -64,7 +64,7 @@
wp_full = wp_split1.switch_to_fullscreen
wp_full.expect_tab :activity
- page.execute_script('window.history.back()')
+ page.execute_script("window.history.back()")
wp_split1.expect_tab :activity
# Assert that overview tab is mapped to activity in show
diff --git a/spec/features/work_packages/tabs/watcher_tab_spec.rb b/spec/features/work_packages/tabs/watcher_tab_spec.rb
index cfb1aa0e6894..91a93e617c22 100644
--- a/spec/features/work_packages/tabs/watcher_tab_spec.rb
+++ b/spec/features/work_packages/tabs/watcher_tab_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Watcher tab', :js, :selenium do
+RSpec.describe "Watcher tab", :js, :selenium do
include Components::Autocompleter::NgSelectAutocompleteHelpers
let(:project) { create(:project) }
@@ -15,117 +15,117 @@
add_work_package_watchers)
end
- let(:watch_button) { find_by_id 'watch-button' }
- let(:watchers_tab) { find('.op-tab-row--link_selected', text: 'WATCHERS') }
+ let(:watch_button) { find_by_id "watch-button" }
+ let(:watchers_tab) { find(".op-tab-row--link_selected", text: "WATCHERS") }
def expect_button_is_watching
- title = I18n.t('js.label_unwatch_work_package')
+ title = I18n.t("js.label_unwatch_work_package")
expect(page).to have_css("#unwatch-button[title='#{title}']", wait: 10)
- expect(page).to have_css('#unwatch-button .button--icon.icon-watched', wait: 10)
+ expect(page).to have_css("#unwatch-button .button--icon.icon-watched", wait: 10)
end
def expect_button_is_not_watching
- title = I18n.t('js.label_watch_work_package')
+ title = I18n.t("js.label_watch_work_package")
expect(page).to have_css("#watch-button[title='#{title}']")
- expect(page).to have_css('#watch-button .button--icon.icon-unwatched')
+ expect(page).to have_css("#watch-button .button--icon.icon-unwatched")
end
- shared_examples 'watch and unwatch with button' do
- it 'watching the WP modifies the watcher list' do
+ shared_examples "watch and unwatch with button" do
+ it "watching the WP modifies the watcher list" do
# Expect WP watch button is in not-watched state
expect_button_is_not_watching
- expect(page).not_to have_test_selector('op-wp-watcher-name')
+ expect(page).not_to have_test_selector("op-wp-watcher-name")
watch_button.click
# Expect WP watch button causes watcher list to add user
expect_button_is_watching
- expect(page).to have_test_selector('op-wp-watcher-name', count: 1, text: user.name)
+ expect(page).to have_test_selector("op-wp-watcher-name", count: 1, text: user.name)
# Expect WP unwatch button causes watcher list to remove user
watch_button.click
expect_button_is_not_watching
- expect(page).not_to have_test_selector('op-wp-watcher-name')
+ expect(page).not_to have_test_selector("op-wp-watcher-name")
end
end
- shared_examples 'watchers tab' do
+ shared_examples "watchers tab" do
before do
login_as(user)
wp_page.visit_tab! :watchers
expect_angular_frontend_initialized
- expect(page).to have_css('.op-tab-row--link_selected', text: 'WATCHERS')
+ expect(page).to have_css(".op-tab-row--link_selected", text: "WATCHERS")
end
- it 'modifying the watcher list modifies the watch button' do
+ it "modifying the watcher list modifies the watch button" do
# Add user as watcher
- autocomplete = find('.wp-watcher--autocomplete ng-select')
+ autocomplete = find(".wp-watcher--autocomplete ng-select")
select_autocomplete autocomplete,
query: user.firstname,
select_text: user.name,
- results_selector: 'body'
+ results_selector: "body"
# Expect the addition of the user to toggle WP watch button
- expect(page).to have_test_selector('op-wp-watcher-name', count: 1, text: user.name)
+ expect(page).to have_test_selector("op-wp-watcher-name", count: 1, text: user.name)
expect_button_is_watching
# Expect watchers counter to increase
tabs.expect_counter(watchers_tab, 1)
# Remove watcher from list
- page.find_test_selector('op-wp-watcher-name', text: user.name).hover
- page.find('.form--selected-value--remover').click
+ page.find_test_selector("op-wp-watcher-name", text: user.name).hover
+ page.find(".form--selected-value--remover").click
# Watchers counter should not be displayed
tabs.expect_no_counter(watchers_tab)
# Expect the removal of the user to toggle WP watch button
- expect(page).not_to have_test_selector('op-wp-watcher-name')
+ expect(page).not_to have_test_selector("op-wp-watcher-name")
expect_button_is_not_watching
end
- context 'with a user with arbitrary characters' do
+ context "with a user with arbitrary characters" do
let!(:html_user) do
create(:user,
:skip_validations,
- firstname: 'foo',
+ firstname: "foo",
member_with_roles: { project => role })
end
- it 'escapes the user name' do
- autocomplete = find('.wp-watcher--autocomplete ng-select')
+ it "escapes the user name" do
+ autocomplete = find(".wp-watcher--autocomplete ng-select")
target_dropdown = search_autocomplete autocomplete,
- query: 'foo',
- results_selector: 'body'
+ query: "foo",
+ results_selector: "body"
expect(target_dropdown).to have_css(".ng-option", text: html_user.firstname)
expect(target_dropdown).to have_no_css(".ng-option em")
end
end
- context 'with all permissions' do
- it_behaves_like 'watch and unwatch with button'
+ context "with all permissions" do
+ it_behaves_like "watch and unwatch with button"
end
- context 'without watchers permission' do
+ context "without watchers permission" do
let(:permissions) { %i(view_work_packages view_work_package_watchers) }
- it_behaves_like 'watch and unwatch with button'
+ it_behaves_like "watch and unwatch with button"
end
end
- context 'split screen' do
+ context "split screen" do
let(:wp_page) { Pages::SplitWorkPackage.new(work_package) }
- it_behaves_like 'watchers tab'
+ it_behaves_like "watchers tab"
end
- context 'full screen' do
+ context "full screen" do
let(:wp_page) { Pages::FullWorkPackage.new(work_package) }
- it_behaves_like 'watchers tab'
+ it_behaves_like "watchers tab"
end
- context 'when the work package has a watcher' do
+ context "when the work package has a watcher" do
let(:watchers) { create(:watcher, watchable: work_package, user:) }
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
@@ -136,14 +136,14 @@ def expect_button_is_not_watching
wp_table.expect_work_package_listed work_package
end
- it 'shows the number of watchers [#33685]' do
+ it "shows the number of watchers [#33685]" do
wp_table.open_full_screen_by_doubleclick(work_package)
- expect(page).to have_test_selector('tab-count', text: "(1)")
+ expect(page).to have_test_selector("tab-count", text: "(1)")
end
end
- context 'with a placeholder user in the project' do
- let!(:placeholder) { create(:placeholder_user, name: 'PLACEHOLDER') }
+ context "with a placeholder user in the project" do
+ let!(:placeholder) { create(:placeholder_user, name: "PLACEHOLDER") }
let(:wp_page) { Pages::FullWorkPackage.new(work_package) }
before do
@@ -151,11 +151,11 @@ def expect_button_is_not_watching
wp_page.visit_tab! :watchers
end
- it 'does not show the placeholder user as an option' do
- autocomplete = find('.wp-watcher--autocomplete ng-select')
+ it "does not show the placeholder user as an option" do
+ autocomplete = find(".wp-watcher--autocomplete ng-select")
target_dropdown = search_autocomplete autocomplete,
- query: '',
- results_selector: 'body'
+ query: "",
+ results_selector: "body"
expect(target_dropdown).to have_css(".ng-option", text: user.name)
expect(target_dropdown).to have_no_css(".ng-option", text: placeholder.name)
diff --git a/spec/features/work_packages/update_ancestors_spec.rb b/spec/features/work_packages/update_ancestors_spec.rb
index b888af574ffa..cbb4932a5823 100644
--- a/spec/features/work_packages/update_ancestors_spec.rb
+++ b/spec/features/work_packages/update_ancestors_spec.rb
@@ -28,13 +28,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Update ancestors', :js, :with_cuprite do
+RSpec.describe "Update ancestors", :js, :with_cuprite do
shared_let(:user) { create(:admin) }
shared_let(:priority) { create(:default_priority) }
- shared_let(:new_status) { create(:default_status, name: 'New') }
- shared_let(:closed_status) { create(:closed_status, name: 'Closed') }
+ shared_let(:new_status) { create(:default_status, name: "New") }
+ shared_let(:closed_status) { create(:closed_status, name: "Closed") }
shared_let(:type) { create(:type_task) }
shared_let(:project_role) { create(:project_role) }
shared_let(:project) { create(:project, types: [type]) }
@@ -63,14 +63,14 @@
shared_let(:parent) do
create(:work_package,
- subject: 'parent',
+ subject: "parent",
estimated_hours: 2,
remaining_hours: 1)
end
shared_let(:child) do
create(:work_package,
parent:,
- subject: 'child',
+ subject: "child",
estimated_hours: 6,
remaining_hours: 3,
done_ratio: 50)
@@ -78,7 +78,7 @@
shared_let(:second_child) do
create(:work_package,
parent:,
- subject: 'second child',
+ subject: "second child",
estimated_hours: 3,
remaining_hours: 3,
done_ratio: 0)
@@ -101,7 +101,7 @@
wp_table.visit_query query
end
- context 'when changing a child work and remaining work values', retry: 2 do
+ context "when changing a child work and remaining work values", retry: 2 do
it "updates the derived parent work, remaining work, and % complete values" do
expect do
wp_table.update_work_package_attributes(child, estimatedTime: child.estimated_hours + 1)
@@ -115,8 +115,8 @@
end
end
- context 'when changing a child % complete value' do
- it 'updates the derived parent % complete value' do
+ context "when changing a child % complete value" do
+ it "updates the derived parent % complete value" do
expect do
wp_table.update_work_package_attributes(child, percentageDone: 100)
parent.reload
@@ -124,17 +124,17 @@
end
end
- context 'when setting a child status to closed' do
- it 'considers child % complete to be 100% and updates the derived parent % complete value accordingly' do
+ context "when setting a child status to closed" do
+ it "considers child % complete to be 100% and updates the derived parent % complete value accordingly" do
expect do
- wp_table.update_work_package_attributes(child, status: 'Closed')
+ wp_table.update_work_package_attributes(child, status: "Closed")
parent.reload
end.to change(parent, :derived_done_ratio).to(67) # 6h at 100% and 3h at 0% => 67% complete for 9h
end
end
- context 'when deleting a child' do
- it 'updates the derived parent work, remaining work, and % complete values' do
+ context "when deleting a child" do
+ it "updates the derived parent work, remaining work, and % complete values" do
context_menu = wp_table.open_context_menu_for(second_child)
context_menu.choose_delete_and_confirm_deletion
@@ -145,15 +145,15 @@
end
end
- context 'when adding a new child' do
- it 'updates the derived parent work, remaining work, and % complete values' do
+ context "when adding a new child" do
+ it "updates the derived parent work, remaining work, and % complete values" do
context_menu = wp_table.open_context_menu_for(parent)
- context_menu.choose(I18n.t('js.relation_buttons.add_new_child'))
+ context_menu.choose(I18n.t("js.relation_buttons.add_new_child"))
split_view_create = Pages::SplitWorkPackageCreate.new(project:)
- split_view_create.set_attributes({ subject: 'new child', estimatedTime: 1, remainingTime: 3 })
+ split_view_create.set_attributes({ subject: "new child", estimatedTime: 1, remainingTime: 3 })
split_view_create.save!
- split_view_create.expect_and_dismiss_toaster message: 'Successful creation'
+ split_view_create.expect_and_dismiss_toaster message: "Successful creation"
parent.reload
new_child = WorkPackage.last
@@ -165,11 +165,11 @@
end
end
- context 'when outdenting and indenting hierarchy of a child' do
- it 'updates the parent work and remaining work values' do
+ context "when outdenting and indenting hierarchy of a child" do
+ it "updates the parent work and remaining work values" do
context_menu = wp_table.open_context_menu_for(second_child)
- context_menu.choose(I18n.t('js.relation_buttons.hierarchy_outdent'))
- wp_table.expect_and_dismiss_toaster message: 'Successful update'
+ context_menu.choose(I18n.t("js.relation_buttons.hierarchy_outdent"))
+ wp_table.expect_and_dismiss_toaster message: "Successful update"
parent.reload
expect(parent.derived_estimated_hours).to eq([parent, child].pluck(:estimated_hours).sum)
@@ -177,8 +177,8 @@
expect(parent.derived_done_ratio).to eq(child.done_ratio)
context_menu = wp_table.open_context_menu_for(second_child)
- context_menu.choose(I18n.t('js.relation_buttons.hierarchy_indent'))
- wp_table.expect_and_dismiss_toaster message: 'Successful update'
+ context_menu.choose(I18n.t("js.relation_buttons.hierarchy_indent"))
+ wp_table.expect_and_dismiss_toaster message: "Successful update"
parent.reload
expect(parent.derived_estimated_hours).to eq([parent, child, second_child].pluck(:estimated_hours).sum)
diff --git a/spec/features/work_packages/work_package_index_spec.rb b/spec/features/work_packages/work_package_index_spec.rb
index bb4523db326d..14f9bd54160c 100644
--- a/spec/features/work_packages/work_package_index_spec.rb
+++ b/spec/features/work_packages/work_package_index_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Work Packages', 'index view', :js, :with_cuprite do
+RSpec.describe "Work Packages", "index view", :js, :with_cuprite do
let(:user) { create(:admin) }
let(:project) { create(:project, enabled_module_names: %w[work_package_tracking]) }
let(:wp_table) { Pages::WorkPackagesTable.new(project) }
@@ -37,42 +37,42 @@
login_as(user)
end
- context 'within a global context' do
+ context "within a global context" do
before do
visit root_path
end
- it 'is reachable by clicking the global menu item' do
- within('#main-menu') do
- click_link 'Work packages'
+ it "is reachable by clicking the global menu item" do
+ within("#main-menu") do
+ click_link "Work packages"
end
expect(page).to have_current_path(work_packages_path)
- within('#content') do
- wp_table.expect_title('All open', editable: true)
- expect(page).to have_content('No work packages to display')
+ within("#content") do
+ wp_table.expect_title("All open", editable: true)
+ expect(page).to have_content("No work packages to display")
end
end
end
- context 'within a project-specific context' do
- it 'is reachable by clicking the sidebar menu item' do
+ context "within a project-specific context" do
+ it "is reachable by clicking the sidebar menu item" do
visit project_path(project)
- within('#content') do
- expect(page).to have_content('Overview')
+ within("#content") do
+ expect(page).to have_content("Overview")
end
- within('#main-menu') do
- click_link 'Work packages'
+ within("#main-menu") do
+ click_link "Work packages"
end
expect(page).to have_current_path(project_work_packages_path(project))
- within('#content') do
- wp_table.expect_title('All open', editable: true)
- expect(page).to have_content('No work packages to display')
+ within("#content") do
+ wp_table.expect_title("All open", editable: true)
+ expect(page).to have_content("No work packages to display")
end
end
end
diff --git a/spec/features/work_packages/work_package_workflow_form_spec.rb b/spec/features/work_packages/work_package_workflow_form_spec.rb
index 7fa55e6d1743..ccf8f18a0eb2 100644
--- a/spec/features/work_packages/work_package_workflow_form_spec.rb
+++ b/spec/features/work_packages/work_package_workflow_form_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'features/page_objects/notification'
+require "spec_helper"
+require "features/page_objects/notification"
-RSpec.describe 'Work package transitive status workflows', :js do
+RSpec.describe "Work package transitive status workflows", :js do
let(:dev_role) do
create(:project_role,
permissions: %i[view_work_packages
@@ -37,8 +37,8 @@
end
let(:dev) do
create(:user,
- firstname: 'Dev',
- lastname: 'Guy',
+ firstname: "Dev",
+ lastname: "Guy",
member_with_roles: { project => dev_role })
end
@@ -89,7 +89,7 @@
##
# Regression test for #24129
- it 'allows to move to the final status as defined in the workflow' do
+ it "allows to move to the final status as defined in the workflow" do
wp_page.update_attributes status: status_intermediate.name
wp_page.expect_attributes status: status_intermediate.name
diff --git a/spec/features/work_packages/work_packages_page.rb b/spec/features/work_packages/work_packages_page.rb
index ad379239792c..6e2271455448 100644
--- a/spec/features/work_packages/work_packages_page.rb
+++ b/spec/features/work_packages/work_packages_page.rb
@@ -55,24 +55,24 @@ def visit_edit(id)
end
def visit_calendar
- visit index_path + '/calendar'
+ visit index_path + "/calendar"
end
def open_settings!
- click_on 'work-packages-settings-button'
+ click_on "work-packages-settings-button"
end
def click_work_packages_menu_item
- find('#main-menu .work-packages').click
+ find("#main-menu .work-packages").click
end
def click_toolbar_button(button)
close_toasters
- find('.toolbar-container', wait: 5).click_button button
+ find(".toolbar-container", wait: 5).click_button button
end
def close_toasters
- page.all(:css, '.op-toast--close').each(&:click)
+ page.all(:css, ".op-toast--close").each(&:click)
end
def select_query(query)
@@ -83,9 +83,9 @@ def select_query(query)
def find_subject_field(text = nil)
if text
- find_by_id('inplace-edit--write-value--subject', text:)
+ find_by_id("inplace-edit--write-value--subject", text:)
else
- find_by_id('inplace-edit--write-value--subject')
+ find_by_id("inplace-edit--write-value--subject")
end
end
@@ -107,7 +107,7 @@ def query_path(query)
def ensure_index_page_loaded
if Capybara.current_driver == Capybara.javascript_driver
- expect(page).to have_css('.work-packages--filters-optional-container.-loaded', visible: :all, wait: 20)
+ expect(page).to have_css(".work-packages--filters-optional-container.-loaded", visible: :all, wait: 20)
end
end
end
diff --git a/spec/features/work_packages/zen_mode_spec.rb b/spec/features/work_packages/zen_mode_spec.rb
index 99a02e65e5d4..3fc223e22dca 100644
--- a/spec/features/work_packages/zen_mode_spec.rb
+++ b/spec/features/work_packages/zen_mode_spec.rb
@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Zen mode', :js do
+RSpec.describe "Zen mode", :js do
let(:dev_role) do
create(:project_role,
permissions: %i[view_work_packages
@@ -8,8 +8,8 @@
end
let(:dev) do
create(:user,
- firstname: 'Dev',
- lastname: 'Guy',
+ firstname: "Dev",
+ lastname: "Guy",
member_with_roles: { project => dev_role })
end
@@ -34,13 +34,13 @@
wp_page.ensure_page_loaded
end
- it 'hides menus' do
+ it "hides menus" do
wp_page.expect_no_zen_mode
- wp_page.page.find_by_id('work-packages-zen-mode-toggle-button').click
+ wp_page.page.find_by_id("work-packages-zen-mode-toggle-button").click
wp_page.expect_zen_mode
wp_page.go_back
wp_page.expect_zen_mode
- wp_page.page.find_by_id('work-packages-zen-mode-toggle-button').click
+ wp_page.page.find_by_id("work-packages-zen-mode-toggle-button").click
wp_page.expect_no_zen_mode
end
end
diff --git a/spec/features/workflows/copy_spec.rb b/spec/features/workflows/copy_spec.rb
index 848ff35900a0..38a3fc072be4 100644
--- a/spec/features/workflows/copy_spec.rb
+++ b/spec/features/workflows/copy_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Workflow copy' do
+RSpec.describe "Workflow copy" do
let(:role) { create(:project_role) }
let(:type) { create(:type) }
let(:admin) { create(:admin) }
@@ -45,16 +45,16 @@
current_user { admin }
before do
- visit url_for(controller: '/workflows', action: :copy)
+ visit url_for(controller: "/workflows", action: :copy)
end
- it 'shows existing types and roles' do
+ it "shows existing types and roles" do
select(role.name, from: :source_role_id)
- within('#source_role_id') do
+ within("#source_role_id") do
expect(page).to have_content(role.name)
expect(page).to have_content("--- #{I18n.t(:actionview_instancetag_blank_option)} ---")
end
- within('#source_type_id') do
+ within("#source_type_id") do
expect(page).to have_content(type.name)
expect(page).to have_content("--- #{I18n.t(:actionview_instancetag_blank_option)} ---")
end
diff --git a/spec/features/workflows/missing_for_sharing_wp_spec.rb b/spec/features/workflows/missing_for_sharing_wp_spec.rb
index 0af19fb1e91c..242f36d729b9 100644
--- a/spec/features/workflows/missing_for_sharing_wp_spec.rb
+++ b/spec/features/workflows/missing_for_sharing_wp_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Configuring the workflow for work package sharing',
+RSpec.describe "Configuring the workflow for work package sharing",
with_config: { show_warning_bars: true },
with_ee: %i[work_package_sharing] do
let!(:role) { create(:project_role) }
@@ -52,9 +52,9 @@
visit home_url
end
- it 'shows a warning until a workflow is configured for the work package edit role' do
+ it "shows a warning until a workflow is configured for the work package edit role" do
# There is a warning bar at the bottom informing of the missing workflow
- within '.warning-bar--item' do
+ within ".warning-bar--item" do
expect(page)
.to have_content("No workflow is configured for the '#{work_package_role.name}' role. " \
"Without a workflow, the shared with user cannot alter the status of the work package.")
@@ -63,16 +63,16 @@
end
# On the copy workflow form, select the already existing workflow for copying
- select type.name, from: 'source_type_id'
- select role.name, from: 'source_role_id'
- select type.name, from: 'target_type_ids'
- select work_package_role.name, from: 'target_role_ids'
+ select type.name, from: "source_type_id"
+ select role.name, from: "source_role_id"
+ select type.name, from: "target_type_ids"
+ select work_package_role.name, from: "target_role_ids"
- click_button 'Copy'
+ click_button "Copy"
# Copying succeeds which results in the edit role having a workflow and the warning disappearing.
expect(page)
- .to have_content 'Successful update'
+ .to have_content "Successful update"
expect(Workflow.where(role_id: work_package_role.id,
type_id: type.id,
@@ -82,6 +82,6 @@
assignee: false).count).to eq(1)
expect(page)
- .to have_no_css('.warning-bar--item')
+ .to have_no_css(".warning-bar--item")
end
end
diff --git a/spec/features/wysiwyg/bold_behavior_spec.rb b/spec/features/wysiwyg/bold_behavior_spec.rb
index 21ce519e9dea..1f4021a44acf 100644
--- a/spec/features/wysiwyg/bold_behavior_spec.rb
+++ b/spec/features/wysiwyg/bold_behavior_spec.rb
@@ -26,45 +26,45 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Wysiwyg bold behavior', :js, :with_cuprite do
+RSpec.describe "Wysiwyg bold behavior", :js, :with_cuprite do
current_user { create(:admin) }
let(:project) { create(:project, enabled_module_names: %w[wiki]) }
let(:editor) { Components::WysiwygEditor.new }
def mac_osx?
- RUBY_PLATFORM.include?('darwin')
+ RUBY_PLATFORM.include?("darwin")
end
def bold_keystroke
if mac_osx?
- [:meta, 'b']
+ [:meta, "b"]
else
- [:ctrl, 'b']
+ [:ctrl, "b"]
end
end
- describe 'in wikis' do
- describe 'creating a wiki page' do
+ describe "in wikis" do
+ describe "creating a wiki page" do
before do
visit project_wiki_path(project, :wiki)
end
- it 'can insert strong formatting with nbsp' do
- editor.click_and_type_slowly 'some text ', bold_keystroke, 'with bold'
+ it "can insert strong formatting with nbsp" do
+ editor.click_and_type_slowly "some text ", bold_keystroke, "with bold"
# Save wiki page
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_css('.op-toast.-success')
+ expect(page).to have_css(".op-toast.-success")
- within('#content') do
- expect(page).to have_css('p') { |node|
- node.text.include?('some text') && node.text.include?('with bold')
+ within("#content") do
+ expect(page).to have_css("p") { |node|
+ node.text.include?("some text") && node.text.include?("with bold")
}
- expect(page).to have_css('strong', text: 'with bold')
+ expect(page).to have_css("strong", text: "with bold")
end
end
end
diff --git a/spec/features/wysiwyg/custom_css_classes_spec.rb b/spec/features/wysiwyg/custom_css_classes_spec.rb
index 3b94f2db08ca..8108bce93e92 100644
--- a/spec/features/wysiwyg/custom_css_classes_spec.rb
+++ b/spec/features/wysiwyg/custom_css_classes_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Wysiwyg paragraphs in lists behavior (Regression #28765)', :js do
+RSpec.describe "Wysiwyg paragraphs in lists behavior (Regression #28765)", :js do
let(:user) { create(:admin) }
let(:project) { create(:project, enabled_module_names: %w[wiki]) }
let(:editor) { Components::WysiwygEditor.new }
@@ -114,61 +114,61 @@
visit edit_project_wiki_path(project, wiki_page.slug)
end
- it 'custom classes are placed correctly' do
+ it "custom classes are placed correctly" do
editor.in_editor do |_container, editable|
- expect(editable).to have_css('p.op-uc-p', count: 6)
- expect(editable).to have_css('h1.op-uc-h1', count: 1)
- expect(editable).to have_css('h2.op-uc-h2', count: 1)
- expect(editable).to have_css('h3.op-uc-h3', count: 1)
- expect(editable).to have_css('h4.op-uc-h4', count: 1)
- expect(editable).to have_css('h5.op-uc-h5', count: 1)
- expect(editable).to have_css('blockquote.op-uc-blockquote', count: 1)
- expect(editable).to have_css('figure.op-uc-figure', count: 1)
- expect(editable).to have_css('figure.op-uc-figure.op-uc-figure_align-center table.op-uc-table', count: 1)
- expect(editable).to have_css('table.op-uc-table thead.op-uc-table--head', count: 1)
- expect(editable).to have_css('table.op-uc-table tr.op-uc-table--row', count: 2)
- expect(editable).to have_css('table.op-uc-table td.op-uc-table--cell', count: 2)
- expect(editable).to have_css('table.op-uc-table th.op-uc-table--cell.op-uc-table--cell_head', count: 4)
- expect(editable).to have_css('ul.op-uc-list', count: 2)
- expect(editable).to have_css('ol.op-uc-list', count: 1)
- expect(editable).to have_css('ul.op-uc-list_task-list', count: 1)
- expect(editable).to have_css('ul.op-uc-list li.op-uc-list--item', count: 2)
- expect(editable).to have_css('ol.op-uc-list li.op-uc-list--item', count: 1)
- expect(editable).to have_css('ul.op-uc-list.op-uc-list_task-list li.op-uc-list--item', count: 1)
- expect(editable).to have_css('pre.op-uc-code-block', count: 1)
- expect(editable).to have_css('code.op-uc-code', count: 1)
- expect(editable).to have_css('a.op-uc-link', count: 1)
- expect(editable).to have_css('div.op-uc-placeholder', count: 3)
- expect(editable).to have_css('span.op-uc-placeholder', count: 1)
+ expect(editable).to have_css("p.op-uc-p", count: 6)
+ expect(editable).to have_css("h1.op-uc-h1", count: 1)
+ expect(editable).to have_css("h2.op-uc-h2", count: 1)
+ expect(editable).to have_css("h3.op-uc-h3", count: 1)
+ expect(editable).to have_css("h4.op-uc-h4", count: 1)
+ expect(editable).to have_css("h5.op-uc-h5", count: 1)
+ expect(editable).to have_css("blockquote.op-uc-blockquote", count: 1)
+ expect(editable).to have_css("figure.op-uc-figure", count: 1)
+ expect(editable).to have_css("figure.op-uc-figure.op-uc-figure_align-center table.op-uc-table", count: 1)
+ expect(editable).to have_css("table.op-uc-table thead.op-uc-table--head", count: 1)
+ expect(editable).to have_css("table.op-uc-table tr.op-uc-table--row", count: 2)
+ expect(editable).to have_css("table.op-uc-table td.op-uc-table--cell", count: 2)
+ expect(editable).to have_css("table.op-uc-table th.op-uc-table--cell.op-uc-table--cell_head", count: 4)
+ expect(editable).to have_css("ul.op-uc-list", count: 2)
+ expect(editable).to have_css("ol.op-uc-list", count: 1)
+ expect(editable).to have_css("ul.op-uc-list_task-list", count: 1)
+ expect(editable).to have_css("ul.op-uc-list li.op-uc-list--item", count: 2)
+ expect(editable).to have_css("ol.op-uc-list li.op-uc-list--item", count: 1)
+ expect(editable).to have_css("ul.op-uc-list.op-uc-list_task-list li.op-uc-list--item", count: 1)
+ expect(editable).to have_css("pre.op-uc-code-block", count: 1)
+ expect(editable).to have_css("code.op-uc-code", count: 1)
+ expect(editable).to have_css("a.op-uc-link", count: 1)
+ expect(editable).to have_css("div.op-uc-placeholder", count: 3)
+ expect(editable).to have_css("span.op-uc-placeholder", count: 1)
end
end
- it 'custom align classes are placed correctly' do
+ it "custom align classes are placed correctly" do
editor.in_editor do |container, editable|
# strangely, we need visible: :all here
- editor.click_toolbar_button 'Insert table'
+ editor.click_toolbar_button "Insert table"
# 2x2
- container.find('.ck-insert-table-dropdown-grid-box:nth-of-type(12)').click
+ container.find(".ck-insert-table-dropdown-grid-box:nth-of-type(12)").click
sleep(0.1)
# There are already multiple tables on the page.
# To avoid mixing them up, we need to select the appropriate one
- table = container.find('.op-uc-figure:first-of-type .op-uc-table')
+ table = container.find(".op-uc-figure:first-of-type .op-uc-table")
- editor.align_table_by_label(editor, table, 'Align table to the left')
+ editor.align_table_by_label(editor, table, "Align table to the left")
# Table figure should now has the proper alignment class
- expect(editable).to have_css('figure.op-uc-figure_align-start')
+ expect(editable).to have_css("figure.op-uc-figure_align-start")
- editor.align_table_by_label(editor, table, 'Align table to the right')
+ editor.align_table_by_label(editor, table, "Align table to the right")
# Table figure should now has the proper alignment class
- expect(editable).to have_css('figure.op-uc-figure_align-end')
+ expect(editable).to have_css("figure.op-uc-figure_align-end")
- editor.align_table_by_label(editor, table, 'Center table')
+ editor.align_table_by_label(editor, table, "Center table")
# Table figure should now has the proper alignment class
- expect(editable).to have_css('figure.op-uc-figure_align-center')
+ expect(editable).to have_css("figure.op-uc-figure_align-center")
end
end
end
diff --git a/spec/features/wysiwyg/html_encoding_spec.rb b/spec/features/wysiwyg/html_encoding_spec.rb
index 26c1786d9ec4..4fd85a110314 100644
--- a/spec/features/wysiwyg/html_encoding_spec.rb
+++ b/spec/features/wysiwyg/html_encoding_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Wysiwyg escaping HTML entities (Regression #28906)', :js do
+RSpec.describe "Wysiwyg escaping HTML entities (Regression #28906)", :js do
let(:user) { create(:admin) }
let(:project) { create(:project, enabled_module_names: %w[wiki]) }
let(:editor) { Components::WysiwygEditor.new }
@@ -38,31 +38,31 @@
visit project_wiki_path(project, :wiki)
end
- it 'shows the list correctly' do
+ it "shows the list correctly" do
editor.in_editor do |_, editable|
editor.click_and_type_slowly '',
:enter,
'\foo\'
- expect(editable).to have_no_css('node')
- expect(editable).to have_no_css('u')
+ expect(editable).to have_no_css("node")
+ expect(editable).to have_no_css("u")
end
# Save wiki page
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_css('.op-toast.-success')
+ expect(page).to have_css(".op-toast.-success")
- within('#content') do
- expect(page).to have_css('p', text: '')
- expect(page).to have_no_css('u')
- expect(page).to have_no_css('node')
+ within("#content") do
+ expect(page).to have_css("p", text: '')
+ expect(page).to have_no_css("u")
+ expect(page).to have_no_css("node")
end
text = WikiPage.last.text
expect(text).to include "<node foo="bar" />"
expect(text).to include "\\\\<u>foo\\\\</u>"
- expect(text).not_to include ''
- expect(text).not_to include ''
+ expect(text).not_to include ""
+ expect(text).not_to include ""
end
end
diff --git a/spec/features/wysiwyg/linking_spec.rb b/spec/features/wysiwyg/linking_spec.rb
index 4d8265091e88..277a5d4ef2c2 100644
--- a/spec/features/wysiwyg/linking_spec.rb
+++ b/spec/features/wysiwyg/linking_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Wysiwyg linking', :js do
+RSpec.describe "Wysiwyg linking", :js do
let(:user) { create(:admin) }
let(:project) { create(:project, enabled_module_names: %w[wiki work_package_tracking]) }
let(:editor) { Components::WysiwygEditor.new }
@@ -37,19 +37,19 @@
login_as(user)
end
- describe 'creating a wiki page' do
+ describe "creating a wiki page" do
before do
visit project_wiki_path(project, :wiki)
end
- it 'can create links with spaces (Regression #29742)' do
+ it "can create links with spaces (Regression #29742)" do
# single hash autocomplete
- editor.insert_link 'http://example.org/link with spaces'
+ editor.insert_link "http://example.org/link with spaces"
# Save wiki page
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_css('.op-toast.-success')
+ expect(page).to have_css(".op-toast.-success")
wiki_page = project.wiki.pages.first.reload
diff --git a/spec/features/wysiwyg/macros/attribute_macros_spec.rb b/spec/features/wysiwyg/macros/attribute_macros_spec.rb
index 0a054b9f4e57..5bb7d11c4fe9 100644
--- a/spec/features/wysiwyg/macros/attribute_macros_spec.rb
+++ b/spec/features/wysiwyg/macros/attribute_macros_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Wysiwyg attribute macros', :js do
+RSpec.describe "Wysiwyg attribute macros", :js do
shared_let(:admin) { create(:admin) }
let(:user) { admin }
- let!(:project) { create(:project, identifier: 'some-project', enabled_module_names: %w[wiki work_package_tracking]) }
+ let!(:project) { create(:project, identifier: "some-project", enabled_module_names: %w[wiki work_package_tracking]) }
let!(:work_package) { create(:work_package, subject: "Foo Bar", project:) }
let(:editor) { Components::WysiwygEditor.new }
@@ -68,41 +68,41 @@
login_as(user)
end
- describe 'creating a wiki page' do
+ describe "creating a wiki page" do
before do
visit project_wiki_path(project, :wiki)
end
- it 'can add and save multiple code blocks (Regression #28350)' do
+ it "can add and save multiple code blocks (Regression #28350)" do
editor.in_editor do |container,|
editor.set_markdown markdown
expect(container).to have_table
end
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_css('.op-toast.-success')
+ expect(page).to have_css(".op-toast.-success")
# Expect output widget
- within('#content') do
- expect(page).to have_css('td', text: 'Subject')
- expect(page).to have_css('td', text: 'Foo Bar')
- expect(page).to have_css('td', text: 'Identifier')
- expect(page).to have_css('td', text: 'some-project')
-
- expect(page).to have_css('td', text: 'invalid subject Cannot expand macro: Requested resource could not be found')
- expect(page).to have_css('td', text: 'invalid project Cannot expand macro: Requested resource could not be found')
+ within("#content") do
+ expect(page).to have_css("td", text: "Subject")
+ expect(page).to have_css("td", text: "Foo Bar")
+ expect(page).to have_css("td", text: "Identifier")
+ expect(page).to have_css("td", text: "some-project")
+
+ expect(page).to have_css("td", text: "invalid subject Cannot expand macro: Requested resource could not be found")
+ expect(page).to have_css("td", text: "invalid project Cannot expand macro: Requested resource could not be found")
end
# Edit page again
- click_on 'Edit'
+ click_on "Edit"
editor.in_editor do |container,|
- expect(container).to have_css('tbody td', count: 6)
+ expect(container).to have_css("tbody td", count: 6)
end
end
- context 'with a multi-select CF' do
+ context "with a multi-select CF" do
let!(:type) { create(:type, projects: [project]) }
let!(:custom_field) do
create(
@@ -126,18 +126,18 @@
wp
end
- it 'expands all custom values (Regression #45538)' do
+ it "expands all custom values (Regression #45538)" do
editor.in_editor do |container,|
editor.set_markdown 'workPackageValue:"Foo Bar":Ingredients'
- expect(container).to have_text 'workPackageValue'
+ expect(container).to have_text "workPackageValue"
end
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_css('.op-toast.-success')
+ expect(page).to have_css(".op-toast.-success")
- within('#content') do
- expect(page).to have_css('.custom-option', count: 6)
+ within("#content") do
+ expect(page).to have_css(".custom-option", count: 6)
end
end
end
diff --git a/spec/features/wysiwyg/macros/child_pages_spec.rb b/spec/features/wysiwyg/macros/child_pages_spec.rb
index e3b0fcc56fdd..6aa740e07b79 100644
--- a/spec/features/wysiwyg/macros/child_pages_spec.rb
+++ b/spec/features/wysiwyg/macros/child_pages_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Wysiwyg child pages spec', :js do
+RSpec.describe "Wysiwyg child pages spec", :js do
let(:project) do
create(:project,
enabled_module_names: %w[wiki])
@@ -41,20 +41,20 @@
let(:wiki_page) do
create(:wiki_page,
- title: 'Test',
- text: '# My page')
+ title: "Test",
+ text: "# My page")
end
let(:parent_page) do
create(:wiki_page,
- title: 'Parent page',
- text: '# parent page')
+ title: "Parent page",
+ text: "# parent page")
end
let(:child_page) do
create(:wiki_page,
- title: 'Child page',
- text: '# child page')
+ title: "Child page",
+ text: "# child page")
end
before do
@@ -69,92 +69,92 @@
login_as(user)
end
- describe 'in wikis' do
- describe 'creating a wiki page' do
+ describe "in wikis" do
+ describe "creating a wiki page" do
before do
visit edit_project_wiki_path(project, :test)
end
- it 'can add and edit an child pages widget' do
+ it "can add and edit an child pages widget" do
editor.in_editor do |_container, editable|
- expect(editable).to have_css('h1', text: 'My page')
+ expect(editable).to have_css("h1", text: "My page")
- editor.insert_macro 'Links to child pages'
+ editor.insert_macro "Links to child pages"
# Find widget, click to show toolbar
- placeholder = find('.op-uc-placeholder', text: 'Links to child pages')
+ placeholder = find(".op-uc-placeholder", text: "Links to child pages")
# Placeholder states `this page` and no `Include parent`
- expect(placeholder).to have_text('this page')
- expect(placeholder).to have_no_text('Include parent')
+ expect(placeholder).to have_text("this page")
+ expect(placeholder).to have_no_text("Include parent")
# Edit widget and cancel again
placeholder.click
- page.find('.ck-balloon-panel .ck-button', visible: :all, text: 'Edit').click
- expect(page).to have_css('.spot-modal')
- expect(page).to have_field('selected-page', with: '')
- find('.spot-modal--cancel-button').click
+ page.find(".ck-balloon-panel .ck-button", visible: :all, text: "Edit").click
+ expect(page).to have_css(".spot-modal")
+ expect(page).to have_field("selected-page", with: "")
+ find(".spot-modal--cancel-button").click
# Edit widget and save
placeholder.click
- page.find('.ck-balloon-panel .ck-button', visible: :all, text: 'Edit').click
- expect(page).to have_css('.spot-modal')
- fill_in 'selected-page', with: 'parent-page'
+ page.find(".ck-balloon-panel .ck-button", visible: :all, text: "Edit").click
+ expect(page).to have_css(".spot-modal")
+ fill_in "selected-page", with: "parent-page"
# Save widget
- find('.spot-modal--submit-button').click
+ find(".spot-modal--submit-button").click
# Placeholder states `parent-page` and no `Include parent`
- expect(placeholder).to have_text('parent-page')
- expect(placeholder).to have_no_text('Include parent')
+ expect(placeholder).to have_text("parent-page")
+ expect(placeholder).to have_no_text("Include parent")
end
# Save wiki page
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_css('.op-toast.-success')
+ expect(page).to have_css(".op-toast.-success")
- within('#content') do
- expect(page).to have_css('.pages-hierarchy')
- expect(page).to have_css('.pages-hierarchy', text: 'Child page')
- expect(page).to have_no_css('.pages-hierarchy', text: 'Parent page')
- expect(page).to have_css('h1', text: 'My page')
+ within("#content") do
+ expect(page).to have_css(".pages-hierarchy")
+ expect(page).to have_css(".pages-hierarchy", text: "Child page")
+ expect(page).to have_no_css(".pages-hierarchy", text: "Parent page")
+ expect(page).to have_css("h1", text: "My page")
SeleniumHubWaiter.wait
- find('.toolbar .icon-edit').click
+ find(".toolbar .icon-edit").click
end
editor.in_editor do |_container, _editable|
# Find widget, click to show toolbar
- placeholder = find('.op-uc-placeholder', text: 'Links to child pages')
+ placeholder = find(".op-uc-placeholder", text: "Links to child pages")
# Edit widget and save
placeholder.click
- page.find('.ck-balloon-panel .ck-button', visible: :all, text: 'Edit').click
- expect(page).to have_css('.spot-modal')
- page.check 'include-parent'
+ page.find(".ck-balloon-panel .ck-button", visible: :all, text: "Edit").click
+ expect(page).to have_css(".spot-modal")
+ page.check "include-parent"
# Save widget
- find('.spot-modal--submit-button').click
+ find(".spot-modal--submit-button").click
# Placeholder states `parent-page` and `Include parent`
- expect(placeholder).to have_text('parent-page')
- expect(placeholder).to have_text('Include parent')
+ expect(placeholder).to have_text("parent-page")
+ expect(placeholder).to have_text("Include parent")
end
# Save wiki page
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_css('.op-toast.-success')
+ expect(page).to have_css(".op-toast.-success")
- within('#content') do
- expect(page).to have_css('.pages-hierarchy')
- expect(page).to have_css('.pages-hierarchy', text: 'Child page')
- expect(page).to have_css('.pages-hierarchy', text: 'Parent page')
- expect(page).to have_css('h1', text: 'My page')
+ within("#content") do
+ expect(page).to have_css(".pages-hierarchy")
+ expect(page).to have_css(".pages-hierarchy", text: "Child page")
+ expect(page).to have_css(".pages-hierarchy", text: "Parent page")
+ expect(page).to have_css("h1", text: "My page")
SeleniumHubWaiter.wait
- find('.toolbar .icon-edit').click
+ find(".toolbar .icon-edit").click
end
end
end
diff --git a/spec/features/wysiwyg/macros/code_block_macro_spec.rb b/spec/features/wysiwyg/macros/code_block_macro_spec.rb
index 3decdad4dbd2..0f7383f75d4b 100644
--- a/spec/features/wysiwyg/macros/code_block_macro_spec.rb
+++ b/spec/features/wysiwyg/macros/code_block_macro_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Wysiwyg code block macro', :js do
+RSpec.describe "Wysiwyg code block macro", :js do
shared_let(:admin) { create(:admin) }
let(:user) { admin }
let(:project) { create(:project, enabled_module_names: %w[wiki]) }
@@ -54,72 +54,72 @@ def foobar
login_as(user)
end
- describe 'in wikis' do
- describe 'creating a wiki page' do
+ describe "in wikis" do
+ describe "creating a wiki page" do
before do
visit project_wiki_path(project, :wiki)
end
- it 'can add and save multiple code blocks (Regression #28350)' do
+ it "can add and save multiple code blocks (Regression #28350)" do
editor.in_editor do |container,|
editor.set_markdown expected
# Expect first macro saved to editor
- expect(container).to have_css('.op-uc-code-block', text: snippet)
- expect(container).to have_css('.op-uc-code-block--language', text: 'ruby')
+ expect(container).to have_css(".op-uc-code-block", text: snippet)
+ expect(container).to have_css(".op-uc-code-block--language", text: "ruby")
editor.set_markdown "#{expected}\n#{expected}"
- expect(container).to have_css('.op-uc-code-block', text: snippet, count: 2)
- expect(container).to have_css('.op-uc-code-block--language', text: 'ruby', count: 2)
+ expect(container).to have_css(".op-uc-code-block", text: snippet, count: 2)
+ expect(container).to have_css(".op-uc-code-block--language", text: "ruby", count: 2)
end
- click_on 'Save'
- expect(page).to have_css('.op-toast.-success')
+ click_on "Save"
+ expect(page).to have_css(".op-toast.-success")
# Expect output widget
- within('#content') do
- expect(page).to have_css('pre.highlight-ruby', count: 2)
+ within("#content") do
+ expect(page).to have_css("pre.highlight-ruby", count: 2)
end
SeleniumHubWaiter.wait
# Edit page again, expect widget
- click_on 'Edit'
+ click_on "Edit"
# SeleniumHubWaiter.wait
editor.in_editor do |container,|
- expect(container).to have_css('.op-uc-code-block', text: snippet, count: 2)
- expect(container).to have_css('.op-uc-code-block--language', text: 'ruby', count: 2)
+ expect(container).to have_css(".op-uc-code-block", text: snippet, count: 2)
+ expect(container).to have_css(".op-uc-code-block--language", text: "ruby", count: 2)
end
end
- it 'respects the inserted whitespace' do
+ it "respects the inserted whitespace" do
editor.in_editor do |container,|
- editor.click_toolbar_button 'Insert code snippet'
+ editor.click_toolbar_button "Insert code snippet"
- expect(page).to have_css('.spot-modal')
+ expect(page).to have_css(".spot-modal")
# CM wraps an accessor to the editor instance on the outer container
- cm = page.find('.CodeMirror')
- page.execute_script('arguments[0].CodeMirror.setValue(arguments[1]);', cm.native, 'asdf')
- find('.spot-modal--submit-button').click
+ cm = page.find(".CodeMirror")
+ page.execute_script("arguments[0].CodeMirror.setValue(arguments[1]);", cm.native, "asdf")
+ find(".spot-modal--submit-button").click
- expect(container).to have_css('.op-uc-code-block', text: 'asdf')
+ expect(container).to have_css(".op-uc-code-block", text: "asdf")
- click_on 'Save'
- expect(page).to have_css('.op-toast.-success')
+ click_on "Save"
+ expect(page).to have_css(".op-toast.-success")
wp = WikiPage.last
expect(wp.text.gsub("\r\n", "\n")).to eq("```text\nasdf\n```")
SeleniumHubWaiter.wait
- click_on 'Edit'
+ click_on "Edit"
editor.in_editor do |container,|
- expect(container).to have_css('.op-uc-code-block', text: 'asdf')
+ expect(container).to have_css(".op-uc-code-block", text: "asdf")
end
- click_on 'Save'
- expect(page).to have_css('.op-toast.-success')
+ click_on "Save"
+ expect(page).to have_css(".op-toast.-success")
wp.reload
# Regression added two newlines before fence here
@@ -127,58 +127,58 @@ def foobar
end
end
- it 'can add and edit a code block widget' do
+ it "can add and edit a code block widget" do
editor.in_editor do |container,|
- editor.click_toolbar_button 'Insert code snippet'
+ editor.click_toolbar_button "Insert code snippet"
- expect(page).to have_css('.spot-modal')
+ expect(page).to have_css(".spot-modal")
# CM wraps an accessor to the editor instance on the outer container
- cm = page.find('.CodeMirror')
- page.execute_script('arguments[0].CodeMirror.setValue(arguments[1]);', cm.native, snippet)
+ cm = page.find(".CodeMirror")
+ page.execute_script("arguments[0].CodeMirror.setValue(arguments[1]);", cm.native, snippet)
- fill_in 'selected-language', with: 'ruby'
+ fill_in "selected-language", with: "ruby"
# Expect some highlighting classes
- expect(page).to have_css('.cm-keyword', text: 'def')
- expect(page).to have_css('.cm-def', text: 'foobar')
+ expect(page).to have_css(".cm-keyword", text: "def")
+ expect(page).to have_css(".cm-def", text: "foobar")
- find('.spot-modal--submit-button').click
+ find(".spot-modal--submit-button").click
# Expect macro saved to editor
- expect(container).to have_css('.op-uc-code-block', text: snippet)
- expect(container).to have_css('.op-uc-code-block--language', text: 'ruby')
+ expect(container).to have_css(".op-uc-code-block", text: snippet)
+ expect(container).to have_css(".op-uc-code-block--language", text: "ruby")
end
# Save wiki page
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_css('.op-toast.-success')
+ expect(page).to have_css(".op-toast.-success")
- wiki_page = project.wiki.find_page('wiki')
+ wiki_page = project.wiki.find_page("wiki")
text = wiki_page.text.gsub(/\r\n?/, "\n")
expect(text.strip).to eq(expected.strip)
# Expect output widget
- within('#content') do
- expect(page).to have_css('pre.highlight-ruby')
+ within("#content") do
+ expect(page).to have_css("pre.highlight-ruby")
end
# Edit page again, expect widget
SeleniumHubWaiter.wait
- click_on 'Edit'
+ click_on "Edit"
editor.in_editor do |container,|
- expect(container).to have_css('.op-uc-code-block', text: snippet)
- expect(container).to have_css('.op-uc-code-block--language', text: 'ruby')
+ expect(container).to have_css(".op-uc-code-block", text: snippet)
+ expect(container).to have_css(".op-uc-code-block--language", text: "ruby")
- widget = container.find('.op-uc-code-block')
+ widget = container.find(".op-uc-code-block")
page.driver.browser.action.double_click(widget.native).perform
- expect(page).to have_css('.spot-modal')
+ expect(page).to have_css(".spot-modal")
- expect(page).to have_css('.op-uc-code-block--language', text: 'ruby')
- expect(page).to have_css('.cm-keyword', text: 'def')
- expect(page).to have_css('.cm-def', text: 'foobar')
+ expect(page).to have_css(".op-uc-code-block--language", text: "ruby")
+ expect(page).to have_css(".cm-keyword", text: "def")
+ expect(page).to have_css(".cm-def", text: "foobar")
end
end
end
diff --git a/spec/features/wysiwyg/macros/embedded_tables_spec.rb b/spec/features/wysiwyg/macros/embedded_tables_spec.rb
index f02d503dad44..8408db12c87b 100644
--- a/spec/features/wysiwyg/macros/embedded_tables_spec.rb
+++ b/spec/features/wysiwyg/macros/embedded_tables_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Wysiwyg embedded work package tables', :js do
+RSpec.describe "Wysiwyg embedded work package tables", :js do
shared_let(:admin) { create(:admin) }
shared_let(:type_task) { create(:type_task) }
shared_let(:type_bug) { create(:type_bug) }
@@ -49,49 +49,49 @@
login_as(user)
end
- describe 'in wikis' do
- describe 'creating a wiki page' do
+ describe "in wikis" do
+ describe "creating a wiki page" do
before do
visit project_wiki_path(project, :wiki)
end
- it 'can add and edit an embedded table widget' do
+ it "can add and edit an embedded table widget" do
editor.in_editor do |_container, editable|
- editor.insert_macro 'Embed work package table'
+ editor.insert_macro "Embed work package table"
modal.expect_open
- modal.switch_to 'Filters'
+ modal.switch_to "Filters"
filters.expect_filter_count 2
- filters.add_filter_by('Type', 'is (OR)', type_task.name)
+ filters.add_filter_by("Type", "is (OR)", type_task.name)
- modal.switch_to 'Columns'
+ modal.switch_to "Columns"
columns.assume_opened
columns.uncheck_all save_changes: false
- columns.add 'ID', save_changes: false
- columns.add 'Subject', save_changes: false
- columns.add 'Type', save_changes: false
- columns.expect_checked 'ID'
- columns.expect_checked 'Subject'
- columns.expect_checked 'Type'
+ columns.add "ID", save_changes: false
+ columns.add "Subject", save_changes: false
+ columns.add "Type", save_changes: false
+ columns.expect_checked "ID"
+ columns.expect_checked "Subject"
+ columns.expect_checked "Type"
# Save widget
modal.save
# Find widget, click to show toolbar
- macro = editable.find('.ck-widget.op-uc-placeholder')
+ macro = editable.find(".ck-widget.op-uc-placeholder")
macro.click
# Edit widget again
- page.find('.ck-balloon-panel .ck-button', visible: :all, text: 'Edit').click
+ page.find(".ck-balloon-panel .ck-button", visible: :all, text: "Edit").click
modal.expect_open
- modal.switch_to 'Filters'
+ modal.switch_to "Filters"
filters.expect_filter_count 3
- modal.switch_to 'Columns'
+ modal.switch_to "Columns"
columns.assume_opened
- columns.expect_checked 'ID'
- columns.expect_checked 'Subject'
- columns.expect_checked 'Type'
+ columns.expect_checked "ID"
+ columns.expect_checked "Subject"
+ columns.expect_checked "Type"
modal.cancel
# Expect we can preview the table within ckeditor-augmented-textarea
@@ -103,11 +103,11 @@
end
# Save wiki page
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_css('.op-toast.-success')
+ expect(page).to have_css(".op-toast.-success")
- embedded_table = Pages::EmbeddedWorkPackagesTable.new find('.wiki-content')
+ embedded_table = Pages::EmbeddedWorkPackagesTable.new find(".wiki-content")
embedded_table.expect_work_package_listed wp_task
embedded_table.ensure_work_package_not_listed! wp_bug
@@ -116,57 +116,57 @@
full_view.ensure_page_loaded
end
- context 'with a subproject that gets deleted' do
+ context "with a subproject that gets deleted" do
let!(:subproject) do
create(:project, parent: project, enabled_module_names: %w[wiki])
end
- it 'can still edit the embedded table widget' do
+ it "can still edit the embedded table widget" do
editor.in_editor do |_container, editable|
- editor.insert_macro 'Embed work package table'
+ editor.insert_macro "Embed work package table"
modal.expect_open
- modal.switch_to 'Filters'
+ modal.switch_to "Filters"
filters.expect_filter_count 2
- filters.add_filter_by('Including subproject', 'is (OR)', subproject.name, 'subprojectId')
+ filters.add_filter_by("Including subproject", "is (OR)", subproject.name, "subprojectId")
# Save widget
modal.save
# Find widget, click to show toolbar
- macro = editable.find('.ck-widget.op-uc-placeholder')
+ macro = editable.find(".ck-widget.op-uc-placeholder")
macro.click
end
# Save wiki page
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_css('.op-toast.-success')
+ expect(page).to have_css(".op-toast.-success")
# Embedded queries
wikipage = project.wiki.pages.last
- expect(wikipage.text).to include('subprojectId')
+ expect(wikipage.text).to include("subprojectId")
# Delete the project
subproject.destroy!
- click_on 'Edit'
+ click_on "Edit"
# Find widget, click to show toolbar
editor.in_editor do |_container, editable|
- macro = editable.find('.ck-widget.op-uc-placeholder')
+ macro = editable.find(".ck-widget.op-uc-placeholder")
macro.click
end
# Edit widget again
- page.find('.ck-balloon-panel .ck-button', visible: :all, text: 'Edit').click
+ page.find(".ck-balloon-panel .ck-button", visible: :all, text: "Edit").click
modal.expect_open
- modal.switch_to 'Filters'
+ modal.switch_to "Filters"
# Subproject filter is gone
filters.expect_filter_count 2
- expect(page).to have_no_text 'Subproject'
+ expect(page).to have_no_text "Subproject"
end
end
end
diff --git a/spec/features/wysiwyg/macros/quicklink_macros_spec.rb b/spec/features/wysiwyg/macros/quicklink_macros_spec.rb
index 58919f33de3e..a9b4d44cae72 100644
--- a/spec/features/wysiwyg/macros/quicklink_macros_spec.rb
+++ b/spec/features/wysiwyg/macros/quicklink_macros_spec.rb
@@ -26,16 +26,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Wysiwyg work package quicklink macros', :js do
+RSpec.describe "Wysiwyg work package quicklink macros", :js do
shared_let(:user) { create(:admin) }
shared_let(:project) { create(:project_with_types) }
let(:work_package) do
create(:work_package,
subject: "My subject",
- start_date: Date.parse('2020-01-01'),
- due_date: Date.parse('2020-02-01'))
+ start_date: Date.parse("2020-01-01"),
+ due_date: Date.parse("2020-02-01"))
end
let(:editor) { Components::WysiwygEditor.new }
@@ -46,72 +46,72 @@
visit project_wiki_path(project, :wiki)
end
- it 'renders work package quicklink macro # with id linking to work package' do
+ it "renders work package quicklink macro # with id linking to work package" do
editor.set_markdown "##{work_package.id}"
- click_on 'Save'
+ click_on "Save"
# Expect output widget
- within('#content') do
+ within("#content") do
expect(page).to have_link("##{work_package.id}")
- expect(page).to have_no_css('.work-package--quickinfo.preview-trigger')
+ expect(page).to have_no_css(".work-package--quickinfo.preview-trigger")
end
# Edit page again
- click_on 'Edit'
+ click_on "Edit"
editor.in_editor do |container,|
- expect(container).to have_css('p', text: "##{work_package.id}")
+ expect(container).to have_css("p", text: "##{work_package.id}")
end
end
- it 'renders work package quicklink macro ## with id link, subject and type' do
+ it "renders work package quicklink macro ## with id link, subject and type" do
editor.set_markdown "###{work_package.id}"
- click_on 'Save'
+ click_on "Save"
# Expect output widget
- within('#content') do
+ within("#content") do
expected_macro_text = "#{work_package.type.name.upcase} ##{work_package.id}: My subject"
- expect(page).to have_css('opce-macro-wp-quickinfo', text: expected_macro_text)
- expect(page).to have_css('span', text: work_package.type.name.upcase)
- expect(page).to have_css('.work-package--quickinfo.preview-trigger', text: "##{work_package.id}")
- expect(page).to have_css('span', text: 'My subject')
+ expect(page).to have_css("opce-macro-wp-quickinfo", text: expected_macro_text)
+ expect(page).to have_css("span", text: work_package.type.name.upcase)
+ expect(page).to have_css(".work-package--quickinfo.preview-trigger", text: "##{work_package.id}")
+ expect(page).to have_css("span", text: "My subject")
end
# Edit page again
- click_on 'Edit'
+ click_on "Edit"
editor.in_editor do |container,|
- expect(container).to have_css('p', text: "###{work_package.id}")
+ expect(container).to have_css("p", text: "###{work_package.id}")
end
end
- it 'renders work package quicklink macro ### with id link, subject, type, status, and dates' do
+ it "renders work package quicklink macro ### with id link, subject, type, status, and dates" do
editor.set_markdown "####{work_package.id}"
- click_on 'Save'
+ click_on "Save"
# Expect output widget
- within('#content') do
+ within("#content") do
expected_macro_text = "#{work_package.status.name}#{work_package.type.name.upcase} " \
"##{work_package.id}: My subject (01/01/2020 - 02/01/2020)"
- expect(page).to have_css('opce-macro-wp-quickinfo', text: expected_macro_text)
- expect(page).to have_css('span', text: work_package.status.name)
- expect(page).to have_css('span', text: work_package.type.name.upcase)
- expect(page).to have_css('.work-package--quickinfo.preview-trigger', text: "##{work_package.id}")
- expect(page).to have_css('span', text: 'My subject')
+ expect(page).to have_css("opce-macro-wp-quickinfo", text: expected_macro_text)
+ expect(page).to have_css("span", text: work_package.status.name)
+ expect(page).to have_css("span", text: work_package.type.name.upcase)
+ expect(page).to have_css(".work-package--quickinfo.preview-trigger", text: "##{work_package.id}")
+ expect(page).to have_css("span", text: "My subject")
# Dates are being rendered in two nested spans
- expect(page).to have_css('span', text: '01/01/2020', count: 2)
- expect(page).to have_css('span', text: '02/01/2020', count: 2)
+ expect(page).to have_css("span", text: "01/01/2020", count: 2)
+ expect(page).to have_css("span", text: "02/01/2020", count: 2)
end
# Edit page again
- click_on 'Edit'
+ click_on "Edit"
editor.in_editor do |container,|
- expect(container).to have_css('p', text: "####{work_package.id}")
+ expect(container).to have_css("p", text: "####{work_package.id}")
end
end
- it 'displays dates with work package detailed link macro only if a date is present' do
+ it "displays dates with work package detailed link macro only if a date is present" do
wp_no_dates =
create(:work_package,
subject: "No dates",
@@ -120,24 +120,24 @@
wp_start_date_only =
create(:work_package,
subject: "Start date only",
- start_date: Date.parse('2020-01-01'),
+ start_date: Date.parse("2020-01-01"),
due_date: nil)
wp_end_date_only =
create(:work_package,
subject: "End date only",
start_date: nil,
- due_date: Date.parse('2020-12-31'))
+ due_date: Date.parse("2020-12-31"))
wp_both_dates =
create(:work_package,
subject: "Both dates",
- start_date: Date.parse('2020-01-01'),
- due_date: Date.parse('2020-12-31'))
+ start_date: Date.parse("2020-01-01"),
+ due_date: Date.parse("2020-12-31"))
wp_milestone_with_date =
create(:work_package,
:is_milestone,
subject: "Milestone with date",
- start_date: Date.parse('2020-01-01'),
- due_date: Date.parse('2020-01-01'))
+ start_date: Date.parse("2020-01-01"),
+ due_date: Date.parse("2020-01-01"))
wp_milestone_without_date =
create(:work_package,
:is_milestone,
@@ -159,15 +159,15 @@
####{wp_milestone_without_date.id}
MD
- click_on 'Save'
+ click_on "Save"
- within('#content') do
- expect(page).to have_css('opce-macro-wp-quickinfo', text: /No dates$/)
- expect(page).to have_css('opce-macro-wp-quickinfo', text: 'Start date only (01/01/2020 - no finish date)')
- expect(page).to have_css('opce-macro-wp-quickinfo', text: 'End date only (no start date - 12/31/2020)')
- expect(page).to have_css('opce-macro-wp-quickinfo', text: 'Both dates (01/01/2020 - 12/31/2020)')
- expect(page).to have_css('opce-macro-wp-quickinfo', text: 'Milestone with date (01/01/2020)')
- expect(page).to have_css('opce-macro-wp-quickinfo', text: /Milestone without date$/)
+ within("#content") do
+ expect(page).to have_css("opce-macro-wp-quickinfo", text: /No dates$/)
+ expect(page).to have_css("opce-macro-wp-quickinfo", text: "Start date only (01/01/2020 - no finish date)")
+ expect(page).to have_css("opce-macro-wp-quickinfo", text: "End date only (no start date - 12/31/2020)")
+ expect(page).to have_css("opce-macro-wp-quickinfo", text: "Both dates (01/01/2020 - 12/31/2020)")
+ expect(page).to have_css("opce-macro-wp-quickinfo", text: "Milestone with date (01/01/2020)")
+ expect(page).to have_css("opce-macro-wp-quickinfo", text: /Milestone without date$/)
end
end
end
diff --git a/spec/features/wysiwyg/macros/work_package_button_spec.rb b/spec/features/wysiwyg/macros/work_package_button_spec.rb
index d8d601041d76..a57249f675e6 100644
--- a/spec/features/wysiwyg/macros/work_package_button_spec.rb
+++ b/spec/features/wysiwyg/macros/work_package_button_spec.rb
@@ -26,18 +26,18 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Wysiwyg work package button spec', :js do
+RSpec.describe "Wysiwyg work package button spec", :js do
shared_let(:admin) { create(:admin) }
let(:user) { admin }
- let!(:type) { create(:type, name: 'MyTaskName') }
+ let!(:type) { create(:type, name: "MyTaskName") }
let(:project) do
create(:valid_project,
- identifier: 'my-project',
+ identifier: "my-project",
enabled_module_names: %w[wiki work_package_tracking],
- name: 'My project name',
+ name: "My project name",
types: [type])
end
@@ -47,47 +47,47 @@
login_as(user)
end
- describe 'in wikis' do
- describe 'creating a wiki page' do
+ describe "in wikis" do
+ describe "creating a wiki page" do
before do
visit project_wiki_path(project, :wiki)
end
- it 'can add and edit an embedded table widget' do
+ it "can add and edit an embedded table widget" do
editor.in_editor do |_container, editable|
- editor.insert_macro 'Insert create work package button'
+ editor.insert_macro "Insert create work package button"
- expect(page).to have_css('.spot-modal')
- select 'MyTaskName', from: 'selected-type'
+ expect(page).to have_css(".spot-modal")
+ select "MyTaskName", from: "selected-type"
# Cancel editing
- find('.spot-modal--cancel-button').click
- expect(editable).to have_no_css('.macro.-create_work_package_link')
+ find(".spot-modal--cancel-button").click
+ expect(editable).to have_no_css(".macro.-create_work_package_link")
- editor.insert_macro 'Insert create work package button'
- select 'MyTaskName', from: 'selected-type'
- check 'button_style'
+ editor.insert_macro "Insert create work package button"
+ select "MyTaskName", from: "selected-type"
+ check "button_style"
# Save widget
- find('.spot-modal--submit-button').click
+ find(".spot-modal--submit-button").click
# Find widget, click to show toolbar
- modal = find('.button.op-uc-placeholder', text: 'Create work package')
+ modal = find(".button.op-uc-placeholder", text: "Create work package")
# Edit widget again
modal.click
- page.find('.ck-balloon-panel .ck-button', visible: :all, text: 'Edit').click
- expect(page).to have_checked_field('wp_button_macro_style')
- expect(page).to have_select('selected-type', selected: 'MyTaskName')
- find('.spot-modal--cancel-button').click
+ page.find(".ck-balloon-panel .ck-button", visible: :all, text: "Edit").click
+ expect(page).to have_checked_field("wp_button_macro_style")
+ expect(page).to have_select("selected-type", selected: "MyTaskName")
+ find(".spot-modal--cancel-button").click
end
# Save wiki page
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_css('.op-toast.-success')
+ expect(page).to have_css(".op-toast.-success")
- within('#content') do
+ within("#content") do
expect(page).to have_css("a[href=\"/projects/my-project/work_packages/new?type=#{type.id}\"]")
end
end
diff --git a/spec/features/wysiwyg/mentions_spec.rb b/spec/features/wysiwyg/mentions_spec.rb
index 4836f3617c04..e202759fd8e0 100644
--- a/spec/features/wysiwyg/mentions_spec.rb
+++ b/spec/features/wysiwyg/mentions_spec.rb
@@ -26,17 +26,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Wysiwyg work package mentions',
+RSpec.describe "Wysiwyg work package mentions",
:js,
:with_cuprite do
let!(:user) do
- create(:admin, firstname: 'MeMyself', lastname: 'AndI',
+ create(:admin, firstname: "MeMyself", lastname: "AndI",
member_with_permissions: { project => %i[view_work_packages edit_work_packages] })
end
let!(:user2) do
- create(:user, firstname: 'Foo', lastname: 'Bar',
+ create(:user, firstname: "Foo", lastname: "Bar",
member_with_permissions: { project => %i[view_work_packages edit_work_packages] })
end
let!(:edit_work_package_role) { create(:edit_work_package_role) }
@@ -44,19 +44,19 @@
let!(:view_work_package_role) { create(:view_work_package_role) }
let!(:work_package_editor) do
- create(:user, firstname: 'Bertram', lastname: 'Gilfoyle',
+ create(:user, firstname: "Bertram", lastname: "Gilfoyle",
member_with_roles: { work_package => edit_work_package_role })
end
let!(:work_package_commenter) do
- create(:user, firstname: 'Dinesh', lastname: 'Chugtai',
+ create(:user, firstname: "Dinesh", lastname: "Chugtai",
member_with_roles: { work_package => comment_work_package_role })
end
let!(:work_package_viewer) do
- create(:user, firstname: 'Richard', lastname: 'Hendricks',
+ create(:user, firstname: "Richard", lastname: "Hendricks",
member_with_roles: { work_package => view_work_package_role })
end
- let!(:group) { create(:group, firstname: 'Foogroup', lastname: 'Foogroup') }
+ let!(:group) { create(:group, firstname: "Foogroup", lastname: "Foogroup") }
let!(:group_role) { create(:project_role) }
let!(:group_member) do
create(:member,
@@ -67,17 +67,17 @@
let(:project) { create(:project, enabled_module_names: %w[work_package_tracking]) }
let!(:work_package) do
User.execute_as user do
- create(:work_package, subject: 'Foobar', project:)
+ create(:work_package, subject: "Foobar", project:)
end
end
let(:wp_page) { Pages::FullWorkPackage.new work_package, project }
let(:editor) { Components::WysiwygEditor.new }
- let(:selector) { '.work-packages--activity--add-comment' }
+ let(:selector) { ".work-packages--activity--add-comment" }
let(:comment_field) do
TextEditorField.new wp_page,
- 'comment',
+ "comment",
selector:
end
@@ -88,45 +88,45 @@
expect_angular_frontend_initialized
end
- it 'can autocomplete users, groups and emojis' do
+ it "can autocomplete users, groups and emojis" do
# Mentioning a user works
comment_field.activate!
comment_field.clear with_backspace: true
comment_field.input_element.send_keys("@Foo")
- expect(page).to have_css('.mention-list-item', text: user2.name)
- expect(page).to have_css('.mention-list-item', text: group.name)
+ expect(page).to have_css(".mention-list-item", text: user2.name)
+ expect(page).to have_css(".mention-list-item", text: group.name)
- page.find('.mention-list-item', text: user2.name).click
+ page.find(".mention-list-item", text: user2.name).click
expect(page)
- .to have_css('a.mention', text: '@Foo Bar')
+ .to have_css("a.mention", text: "@Foo Bar")
comment_field.submit_by_click if comment_field.active?
wp_page.expect_and_dismiss_toaster message: "The comment was successfully added."
expect(page)
- .to have_css('a.user-mention', text: 'Foo Bar')
+ .to have_css("a.user-mention", text: "Foo Bar")
# Mentioning myself works
comment_field.activate!
comment_field.clear with_backspace: true
comment_field.input_element.send_keys("@MeMyself")
- expect(page).to have_css('.mention-list-item', text: user.name)
+ expect(page).to have_css(".mention-list-item", text: user.name)
- page.find('.mention-list-item', text: user.name).click
+ page.find(".mention-list-item", text: user.name).click
expect(page)
- .to have_css('a.mention', text: '@MeMyself AndI')
+ .to have_css("a.mention", text: "@MeMyself AndI")
comment_field.submit_by_click if comment_field.active?
wp_page.expect_and_dismiss_toaster message: "The comment was successfully added."
expect(page)
- .to have_css('a.user-mention', text: 'MeMyself AndI')
+ .to have_css("a.user-mention", text: "MeMyself AndI")
# Mentioning a work package editor or commenter works
#
@@ -137,12 +137,12 @@
comment_field.input_element.send_keys("@Bertram Gilfoyle")
page.find(".mention-list-item", text: work_package_editor.name).click
expect(page)
- .to have_css('a.mention', text: "@Bertram Gilfoyle")
+ .to have_css("a.mention", text: "@Bertram Gilfoyle")
comment_field.submit_by_click if comment_field.active?
wp_page.expect_and_dismiss_toaster message: "The comment was successfully added."
expect(page)
- .to have_css('a.user-mention', text: 'Bertram Gilfoyle')
+ .to have_css("a.user-mention", text: "Bertram Gilfoyle")
#
# Commenter
#
@@ -151,12 +151,12 @@
comment_field.input_element.send_keys("@Dinesh Chugtai")
page.find(".mention-list-item", text: work_package_commenter.name).click
expect(page)
- .to have_css('a.mention', text: "@Dinesh Chugtai")
+ .to have_css("a.mention", text: "@Dinesh Chugtai")
comment_field.submit_by_click if comment_field.active?
wp_page.expect_and_dismiss_toaster message: "The comment was successfully added."
expect(page)
- .to have_css('a.user-mention', text: 'Dinesh Chugtai')
+ .to have_css("a.user-mention", text: "Dinesh Chugtai")
# Work Package viewers aren't mentionable
comment_field.activate!
@@ -171,41 +171,41 @@
comment_field.activate!
comment_field.clear with_backspace: true
comment_field.input_element.send_keys(" @Foo")
- expect(page).to have_css('.mention-list-item', text: user2.name)
- expect(page).to have_css('.mention-list-item', text: group.name)
+ expect(page).to have_css(".mention-list-item", text: user2.name)
+ expect(page).to have_css(".mention-list-item", text: group.name)
- page.find('.mention-list-item', text: group.name).click
+ page.find(".mention-list-item", text: group.name).click
expect(page)
- .to have_css('a.mention', text: '@Foogroup')
+ .to have_css("a.mention", text: "@Foogroup")
comment_field.submit_by_click if comment_field.active?
wp_page.expect_and_dismiss_toaster message: "The comment was successfully added."
expect(page)
- .to have_css('a.user-mention', text: 'Foogroup')
+ .to have_css("a.user-mention", text: "Foogroup")
# The mention is still displayed as such when reentering the comment field
- find('#activity-1 .op-user-activity')
+ find("#activity-1 .op-user-activity")
.hover
- within('#activity-1') do
+ within("#activity-1") do
click_button("Edit this comment")
end
expect(page)
- .to have_css('a.mention', text: '@Foo Bar')
+ .to have_css("a.mention", text: "@Foo Bar")
# Mentioning an emoji works
comment_field.activate!
comment_field.clear with_backspace: true
comment_field.input_element.send_keys(":thumbs")
- expect(page).to have_css('.mention-list-item', text: '👍 thumbs_up')
- expect(page).to have_css('.mention-list-item', text: '👎 thumbs_down')
+ expect(page).to have_css(".mention-list-item", text: "👍 thumbs_up")
+ expect(page).to have_css(".mention-list-item", text: "👎 thumbs_down")
- page.find('.mention-list-item', text: '👍 thumbs_up').click
+ page.find(".mention-list-item", text: "👍 thumbs_up").click
- expect(page).to have_css('span', text: '👍')
+ expect(page).to have_css("span", text: "👍")
end
end
diff --git a/spec/features/wysiwyg/paragraphs_in_lists_spec.rb b/spec/features/wysiwyg/paragraphs_in_lists_spec.rb
index d808753f6aa6..94024dfa181d 100644
--- a/spec/features/wysiwyg/paragraphs_in_lists_spec.rb
+++ b/spec/features/wysiwyg/paragraphs_in_lists_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Wysiwyg paragraphs in lists behavior (Regression #28765)', :js do
+RSpec.describe "Wysiwyg paragraphs in lists behavior (Regression #28765)", :js do
let(:user) { create(:admin) }
let(:project) { create(:project, enabled_module_names: %w[wiki]) }
let(:editor) { Components::WysiwygEditor.new }
@@ -57,10 +57,10 @@
visit edit_project_wiki_path(project, wiki_page.slug)
end
- it 'shows the list correctly' do
+ it "shows the list correctly" do
editor.in_editor do |_container, editable|
- expect(editable).to have_css('ol li', count: 3)
- expect(editable).to have_no_css('ol li p')
+ expect(editable).to have_css("ol li", count: 3)
+ expect(editable).to have_no_css("ol li p")
end
end
end
diff --git a/spec/features/wysiwyg/tables_spec.rb b/spec/features/wysiwyg/tables_spec.rb
index 1dd848d0af61..8f927d97dff6 100644
--- a/spec/features/wysiwyg/tables_spec.rb
+++ b/spec/features/wysiwyg/tables_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Wysiwyg tables', :js do
+RSpec.describe "Wysiwyg tables", :js do
shared_let(:admin) { create(:admin) }
let(:user) { admin }
@@ -39,21 +39,21 @@
login_as(user)
end
- describe 'in wikis' do
- describe 'creating a wiki page' do
+ describe "in wikis" do
+ describe "creating a wiki page" do
before do
visit project_wiki_path(project, :wiki)
end
- it 'can add tables without headers' do
+ it "can add tables without headers" do
editor.in_editor do |container, editable|
# strangely, we need visible: :all here
- container.find('.ck-button', visible: :all, text: 'Insert table').click
+ container.find(".ck-button", visible: :all, text: "Insert table").click
# 2x2
- container.find('.ck-insert-table-dropdown-grid-box:nth-of-type(12)').click
+ container.find(".ck-insert-table-dropdown-grid-box:nth-of-type(12)").click
# Edit table
- tds = editable.all('.op-uc-table .op-uc-table--cell')
+ tds = editable.all(".op-uc-table .op-uc-table--cell")
expect(tds.length).to eq(4)
values = %w(h1 h&2 c1 c&2)
@@ -65,26 +65,26 @@
end
# Save wiki page
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_css('.op-toast.-success')
+ expect(page).to have_css(".op-toast.-success")
- within('#content') do
- expect(page).to have_css('table td', text: 'h1')
- expect(page).to have_css('table td', text: 'h&2')
- expect(page).to have_css('table td', text: 'c1')
- expect(page).to have_css('table td', text: 'c&2')
+ within("#content") do
+ expect(page).to have_css("table td", text: "h1")
+ expect(page).to have_css("table td", text: "h&2")
+ expect(page).to have_css("table td", text: "c1")
+ expect(page).to have_css("table td", text: "c&2")
end
end
- it 'can add tables with headers' do
+ it "can add tables with headers" do
editor.in_editor do |container, editable|
- editor.click_toolbar_button 'Insert table'
+ editor.click_toolbar_button "Insert table"
# 2x2
- container.find('.ck-insert-table-dropdown-grid-box:nth-of-type(12)').click
+ container.find(".ck-insert-table-dropdown-grid-box:nth-of-type(12)").click
# Edit table
- tds = editable.all('.op-uc-table .op-uc-table--cell')
+ tds = editable.all(".op-uc-table .op-uc-table--cell")
values = %w(h1 h2 a)
expect(tds.length).to eq(4)
@@ -99,55 +99,55 @@
tds.first.send_keys :tab
# Click row toolbar
- editor.click_hover_toolbar_button 'Row'
+ editor.click_hover_toolbar_button "Row"
# Enable header row
- header_button = find('.ck-switchbutton', text: 'Header row')
- header_button.find('.ck-button__toggle').click
+ header_button = find(".ck-switchbutton", text: "Header row")
+ header_button.find(".ck-button__toggle").click
# Table should now have header
- expect(editable).to have_css('th', count: 2)
- expect(editable).to have_css('td', count: 2)
- expect(editable).to have_css('th', text: 'h1')
- expect(editable).to have_css('th', text: 'h2')
- expect(editable).to have_css('td', text: 'a')
+ expect(editable).to have_css("th", count: 2)
+ expect(editable).to have_css("td", count: 2)
+ expect(editable).to have_css("th", text: "h1")
+ expect(editable).to have_css("th", text: "h2")
+ expect(editable).to have_css("td", text: "a")
end
# Save wiki page
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_css('.op-toast.-success')
+ expect(page).to have_css(".op-toast.-success")
- within('#content') do
- expect(page).to have_css('table th', text: 'h1')
- expect(page).to have_css('table th', text: 'h2')
- expect(page).to have_css('table td', count: 2)
- expect(page).to have_css('td', text: 'a')
+ within("#content") do
+ expect(page).to have_css("table th", text: "h1")
+ expect(page).to have_css("table th", text: "h2")
+ expect(page).to have_css("table td", count: 2)
+ expect(page).to have_css("td", text: "a")
end
SeleniumHubWaiter.wait
# Edit again
- click_on 'Edit'
+ click_on "Edit"
editor.in_editor do |_container, editable|
# Table should still have header
- expect(editable).to have_css('th', count: 2)
- expect(editable).to have_css('td', count: 2)
- expect(editable).to have_css('th', text: 'h1')
- expect(editable).to have_css('th', text: 'h2')
- expect(editable).to have_css('td', text: 'a')
+ expect(editable).to have_css("th", count: 2)
+ expect(editable).to have_css("td", count: 2)
+ expect(editable).to have_css("th", text: "h1")
+ expect(editable).to have_css("th", text: "h2")
+ expect(editable).to have_css("td", text: "a")
end
end
- it 'can add styled tables' do
+ it "can add styled tables" do
editor.in_editor do |container, editable|
# strangely, we need visible: :all here
- editor.click_toolbar_button 'Insert table'
+ editor.click_toolbar_button "Insert table"
# 2x2
- container.find('.ck-insert-table-dropdown-grid-box:nth-of-type(12)').click
+ container.find(".ck-insert-table-dropdown-grid-box:nth-of-type(12)").click
# Edit table
- tds = editable.all('.op-uc-table .op-uc-table--cell')
+ tds = editable.all(".op-uc-table .op-uc-table--cell")
expect(tds.length).to eq(4)
values = %w(h1 h2 a)
@@ -161,16 +161,16 @@
tds.first.click
# Click row toolbar
- editor.click_hover_toolbar_button 'Cell properties'
+ editor.click_hover_toolbar_button "Cell properties"
# Enable header row
- expect(page).to have_css('.ck-input-color input', count: 2)
+ expect(page).to have_css(".ck-input-color input", count: 2)
# Pick the latter one, it's the background color
- page.all('.ck-input-color input').last.set '#123456'
+ page.all(".ck-input-color input").last.set "#123456"
# Set vertical center / horizontal top
- editor.click_hover_toolbar_button 'Align cell text to the center'
- editor.click_hover_toolbar_button 'Align cell text to the top'
- find('.ck-button-save').click
+ editor.click_hover_toolbar_button "Align cell text to the center"
+ editor.click_hover_toolbar_button "Align cell text to the top"
+ find(".ck-button-save").click
# Table should now have header
expect(editable).to have_css('td[style*="background-color:#123456"]')
@@ -179,11 +179,11 @@
end
# Save wiki page
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_css('.op-toast.-success')
+ expect(page).to have_css(".op-toast.-success")
- within('#content') do
+ within("#content") do
expect(page).to have_css('td[style*="background-color:#123456"]')
expect(page).to have_css('td[style*="text-align:center"]')
expect(page).to have_css('td[style*="vertical-align:top"]')
@@ -191,33 +191,33 @@
SeleniumHubWaiter.wait
# Edit again
- click_on 'Edit'
+ click_on "Edit"
editor.in_editor do |_container, editable|
expect(editable).to have_css('td[style*="background-color:#123456"]')
# Change table styles
- tds = editable.all('.op-uc-table .op-uc-table--cell')
+ tds = editable.all(".op-uc-table .op-uc-table--cell")
# For some reason, the entire table is still selected so use tab to move to the next cell
tds[0].click
tds[0].send_keys :tab
- editor.click_hover_toolbar_button 'Table properties'
+ editor.click_hover_toolbar_button "Table properties"
# Set style to dotted
- page.find('.ck-table-form__border-style').click
- page.find('.ck-button_with-text', text: 'Dotted').click
- page.find('.ck-table-form__border-row .ck-input-color').set 'black'
- page.find('.ck-table-form__border-width .ck-input-text').set '10px'
+ page.find(".ck-table-form__border-style").click
+ page.find(".ck-button_with-text", text: "Dotted").click
+ page.find(".ck-table-form__border-row .ck-input-color").set "black"
+ page.find(".ck-table-form__border-width .ck-input-text").set "10px"
# background
- page.find('.ck-table-properties-form__background .ck-input-text').set 'red'
+ page.find(".ck-table-properties-form__background .ck-input-text").set "red"
# width, height
- page.find('.ck-table-form__dimensions-row__width .ck-input-text').set '500px'
- page.find('.ck-table-form__dimensions-row__height .ck-input-text').set '500px'
- find('.ck-button-save').click
+ page.find(".ck-table-form__dimensions-row__width .ck-input-text").set "500px"
+ page.find(".ck-table-form__dimensions-row__height .ck-input-text").set "500px"
+ find(".ck-button-save").click
# table height and width is set on figure
expect(editable).to have_css('figure[style*="width:500px"]')
@@ -230,11 +230,11 @@
end
# Save wiki page
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_css('.op-toast.-success')
+ expect(page).to have_css(".op-toast.-success")
- within('#content') do
+ within("#content") do
# table height and width is set on figure
expect(page).to have_css('figure[style*="width:500px"]')
expect(page).to have_css('figure[style*="height:500px"]')
@@ -246,7 +246,7 @@
end
# Edit again
- click_on 'Edit'
+ click_on "Edit"
# Expect all previous changes to be there
editor.in_editor do |_container, editable|
@@ -263,15 +263,15 @@
end
end
- it 'can restrict table cell width' do
+ it "can restrict table cell width" do
editor.in_editor do |container, editable|
# strangely, we need visible: :all here
- editor.click_toolbar_button 'Insert table'
+ editor.click_toolbar_button "Insert table"
# 2x2
- container.find('.ck-insert-table-dropdown-grid-box:nth-of-type(12)').click
+ container.find(".ck-insert-table-dropdown-grid-box:nth-of-type(12)").click
# Edit table
- tds = editable.all('.op-uc-table .op-uc-table--cell')
+ tds = editable.all(".op-uc-table .op-uc-table--cell")
expect(tds.length).to eq(4)
values = %w(h1 h2 a)
@@ -285,27 +285,27 @@
tds.first.click
# Click row toolbar
- editor.click_hover_toolbar_button 'Cell properties'
+ editor.click_hover_toolbar_button "Cell properties"
# Enable header row
- find('.ck-table-form__dimensions-row__width input').set '250px'
- find('.ck-button-save').click
+ find(".ck-table-form__dimensions-row__width input").set "250px"
+ find(".ck-button-save").click
expect(editable).to have_css('td[style*="width:250px"]')
end
# Save wiki page
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_css('.op-toast.-success')
+ expect(page).to have_css(".op-toast.-success")
- within('#content') do
+ within("#content") do
expect(page).to have_css('td[style*="width:250px"]')
end
SeleniumHubWaiter.wait
# Edit again
- click_on 'Edit'
+ click_on "Edit"
editor.in_editor do |_container, editable|
expect(editable).to have_css('td[style*="width:250px"]')
@@ -313,10 +313,10 @@
end
end
- describe 'editing a wiki page with tables' do
+ describe "editing a wiki page with tables" do
let(:wiki_page) do
page = build(:wiki_page,
- title: 'Wiki page with titles')
+ title: "Wiki page with titles")
page.text = <<~MARKDOWN
## This is markdown!
@@ -351,31 +351,31 @@
visit project_wiki_path(project, wiki_page.slug)
end
- it 'can show the table with header' do
- within('#content') do
- expect(page).to have_css('h2', text: 'This is markdown')
+ it "can show the table with header" do
+ within("#content") do
+ expect(page).to have_css("h2", text: "This is markdown")
- expect(page).to have_css('table thead th', text: 'A')
- expect(page).to have_css('table thead th', text: 'B')
- expect(page).to have_css('table td', text: 'c1')
- expect(page).to have_css('table td', text: 'c2')
- expect(page).to have_css('table td', text: 'c3')
- expect(page).to have_css('table td', text: 'c4')
+ expect(page).to have_css("table thead th", text: "A")
+ expect(page).to have_css("table thead th", text: "B")
+ expect(page).to have_css("table td", text: "c1")
+ expect(page).to have_css("table td", text: "c2")
+ expect(page).to have_css("table td", text: "c3")
+ expect(page).to have_css("table td", text: "c4")
end
# Edit the table
- click_on 'Edit'
+ click_on "Edit"
# Expect wysiwyg to render table
editor.in_editor do |_, editable|
- expect(editable).to have_css('h2', text: 'This is markdown')
-
- expect(editable).to have_css('table thead th', text: 'A')
- expect(editable).to have_css('table thead th', text: 'B')
- expect(editable).to have_css('table td', text: 'c1')
- expect(editable).to have_css('table td', text: 'c2')
- expect(editable).to have_css('table td', text: 'c3')
- expect(editable).to have_css('table td', text: 'c4')
+ expect(editable).to have_css("h2", text: "This is markdown")
+
+ expect(editable).to have_css("table thead th", text: "A")
+ expect(editable).to have_css("table thead th", text: "B")
+ expect(editable).to have_css("table td", text: "c1")
+ expect(editable).to have_css("table td", text: "c2")
+ expect(editable).to have_css("table td", text: "c3")
+ expect(editable).to have_css("table td", text: "c4")
end
end
end
diff --git a/spec/features/wysiwyg/ui_localization_spec.rb b/spec/features/wysiwyg/ui_localization_spec.rb
index 1c0756ad0e72..f6ede3559ce1 100644
--- a/spec/features/wysiwyg/ui_localization_spec.rb
+++ b/spec/features/wysiwyg/ui_localization_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'WYSIWYG UI localization', :js do
+RSpec.describe "WYSIWYG UI localization", :js do
let(:user) { create(:admin, language:) }
let(:project) { create(:project, enabled_module_names: %w[wiki]) }
let(:editor) { Components::WysiwygEditor.new }
@@ -52,19 +52,19 @@
visit edit_project_wiki_path(project, wiki_page.slug)
end
- context 'with german locale' do
+ context "with german locale" do
let(:language) { :de }
- it 'renders the UI in German' do
- expect(page).to have_css('.ck-button__label', text: 'Absatz')
+ it "renders the UI in German" do
+ expect(page).to have_css(".ck-button__label", text: "Absatz")
end
end
- context 'with english locale' do
+ context "with english locale" do
let(:language) { :en }
- it 'renders the UI in English' do
- expect(page).to have_css('.ck-button__label', text: 'Paragraph')
+ it "renders the UI in English" do
+ expect(page).to have_css(".ck-button__label", text: "Paragraph")
end
end
end
diff --git a/spec/features/wysiwyg/work_package_linking_spec.rb b/spec/features/wysiwyg/work_package_linking_spec.rb
index 97bbc66084df..fbd2f3f133de 100644
--- a/spec/features/wysiwyg/work_package_linking_spec.rb
+++ b/spec/features/wysiwyg/work_package_linking_spec.rb
@@ -26,37 +26,37 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Wysiwyg work package linking', :js do
+RSpec.describe "Wysiwyg work package linking", :js do
let(:user) { create(:admin) }
let(:project) { create(:project, enabled_module_names: %w[wiki work_package_tracking]) }
- let(:work_package) { create(:work_package, subject: 'Foobar', project:) }
+ let(:work_package) { create(:work_package, subject: "Foobar", project:) }
let(:editor) { Components::WysiwygEditor.new }
before do
login_as(user)
end
- describe 'creating a wiki page' do
+ describe "creating a wiki page" do
before do
visit project_wiki_path(project, :wiki)
end
- it 'can reference work packages' do
+ it "can reference work packages" do
# single hash autocomplete
editor.click_and_type_slowly "##{work_package.id}"
editor.click_autocomplete work_package.subject
- expect(editor.editor_element).to have_css('a.mention', text: "##{work_package.id}")
+ expect(editor.editor_element).to have_css("a.mention", text: "##{work_package.id}")
# Save wiki page
- click_on 'Save'
+ click_on "Save"
- expect(page).to have_css('.op-toast.-success')
+ expect(page).to have_css(".op-toast.-success")
- within('#content') do
- expect(page).to have_css('a.issue', count: 1)
+ within("#content") do
+ expect(page).to have_css("a.issue", count: 1)
end
end
end
diff --git a/spec/helpers/additional_url_helper_spec.rb b/spec/helpers/additional_url_helper_spec.rb
index 3106ed0e7d0b..8fe015d39c5a 100644
--- a/spec/helpers/additional_url_helper_spec.rb
+++ b/spec/helpers/additional_url_helper_spec.rb
@@ -26,21 +26,21 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe AdditionalUrlHelpers do
- describe '#configurable_home_url' do
+ describe "#configurable_home_url" do
subject { helper.send :configurable_home_url }
- context 'when home_url is defined', with_settings: { home_url: 'https://example.com/foo/bar' } do
- it 'outputs that' do
- expect(subject).to eq 'https://example.com/foo/bar'
+ context "when home_url is defined", with_settings: { home_url: "https://example.com/foo/bar" } do
+ it "outputs that" do
+ expect(subject).to eq "https://example.com/foo/bar"
end
end
- context 'when home_url is not defined', with_settings: { home_url: nil } do
- it 'falls back to the default' do
- expect(subject).to eq 'http://test.host/'
+ context "when home_url is not defined", with_settings: { home_url: nil } do
+ it "falls back to the default" do
+ expect(subject).to eq "http://test.host/"
end
end
end
diff --git a/spec/helpers/angular_helper_spec.rb b/spec/helpers/angular_helper_spec.rb
index ae0127ccf993..44df8dd34468 100644
--- a/spec/helpers/angular_helper_spec.rb
+++ b/spec/helpers/angular_helper_spec.rb
@@ -26,32 +26,32 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe AngularHelper do
- let(:tag_name) { 'op-test' }
+ let(:tag_name) { "op-test" }
let(:options) do
{
- class: 'op-classname',
+ class: "op-classname",
inputs:,
data:
}
end
let(:data) do
{
- 'test-selector': 'foo'
+ "test-selector": "foo"
}
end
subject { helper.angular_component_tag tag_name, options }
- describe 'inputs transformations' do
+ describe "inputs transformations" do
let(:inputs) do
{
- key: 'value',
+ key: "value",
number: 1,
anArray: [1, 2, 3],
- someRandomObject: { complex: true, foo: 'bar' }
+ someRandomObject: { complex: true, foo: "bar" }
}
end
@@ -68,7 +68,7 @@
HTML
end
- it 'converts the inputs' do
+ it "converts the inputs" do
expect(subject).to be_html_eql(expected)
end
end
diff --git a/spec/helpers/application_helper_spec.rb b/spec/helpers/application_helper_spec.rb
index 60661df54c3d..a0aff1dc44e0 100644
--- a/spec/helpers/application_helper_spec.rb
+++ b/spec/helpers/application_helper_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe ApplicationHelper do
- describe '.link_to_if_authorized' do
+ describe ".link_to_if_authorized" do
let(:project) { create(:valid_project) }
let(:project_member) do
create(:user,
@@ -43,15 +43,15 @@
type: project.types.first)
end
- context 'if user is authorized' do
+ context "if user is authorized" do
before do
expect(self).to receive(:authorize_for).and_return(true)
- @response = link_to_if_authorized('link_content', {
- controller: 'work_packages',
- action: 'show',
+ @response = link_to_if_authorized("link_content", {
+ controller: "work_packages",
+ action: "show",
id: issue
},
- class: 'fancy_css_class')
+ class: "fancy_css_class")
end
subject { @response }
@@ -61,15 +61,15 @@
it { is_expected.to match /fancy_css_class/ }
end
- context 'if user is unauthorized' do
+ context "if user is unauthorized" do
before do
expect(self).to receive(:authorize_for).and_return(false)
- @response = link_to_if_authorized('link_content', {
- controller: 'work_packages',
- action: 'show',
+ @response = link_to_if_authorized("link_content", {
+ controller: "work_packages",
+ action: "show",
id: issue
},
- class: 'fancy_css_class')
+ class: "fancy_css_class")
end
subject { @response }
@@ -77,12 +77,12 @@
it { is_expected.to be_nil }
end
- context 'allow using the :controller and :action for the target link' do
+ context "allow using the :controller and :action for the target link" do
before do
expect(self).to receive(:authorize_for).and_return(true)
- @response = link_to_if_authorized('By controller/action',
- controller: 'work_packages',
- action: 'show',
+ @response = link_to_if_authorized("By controller/action",
+ controller: "work_packages",
+ action: "show",
id: issue.id)
end
@@ -92,10 +92,10 @@
end
end
- describe 'other_formats_links' do
- context 'link given' do
+ describe "other_formats_links" do
+ context "link given" do
before do
- @links = other_formats_links { |f| f.link_to 'Atom', url: { controller: :projects, action: :index } }
+ @links = other_formats_links { |f| f.link_to "Atom", url: { controller: :projects, action: :index } }
end
it {
@@ -103,29 +103,29 @@
}
end
- context 'link given but disabled' do
+ context "link given but disabled" do
before do
allow(Setting).to receive(:feeds_enabled?).and_return(false)
- @links = other_formats_links { |f| f.link_to 'Atom', url: { controller: :projects, action: :index } }
+ @links = other_formats_links { |f| f.link_to "Atom", url: { controller: :projects, action: :index } }
end
it { expect(@links).to be_nil }
end
end
- describe 'time_tag' do
+ describe "time_tag" do
around do |example|
I18n.with_locale(:en) { example.run }
end
subject { time_tag(time) }
- context 'with project' do
+ context "with project" do
before do
@project = build(:project)
end
- context 'right now' do
+ context "right now" do
let(:time) { Time.now }
it { is_expected.to match /^Hello', lastname: 'world')
+ describe ".authoring_at" do
+ it "escapes html from author name" do
+ created = "2023-06-02"
+ author = build(:user, firstname: "Hello", lastname: "world")
author.save! validate: false
expect(authoring_at(created, author))
.to eq("Added by <b>Hello</b> world at 2023-06-02")
end
end
- describe '.all_lang_options_for_select' do
+ describe ".all_lang_options_for_select" do
it 'has all languages translated ("English" should appear only once)' do
impostor_locales =
all_lang_options_for_select
- .reject { |_lang, locale| locale == 'en' }
+ .reject { |_lang, locale| locale == "en" }
.select { |lang, _locale| lang == "English" }
.map { |_lang, locale| locale }
expect(impostor_locales.count).to eq(0), <<~ERR
@@ -202,7 +202,7 @@
ERR
end
- it 'has distinct languages translation' do
+ it "has distinct languages translation" do
duplicate_langs =
all_lang_options_for_select
.map { |lang, _locale| lang }
diff --git a/spec/helpers/archived_projects_helper_spec.rb b/spec/helpers/archived_projects_helper_spec.rb
index a11256ffceae..f799ae256e98 100644
--- a/spec/helpers/archived_projects_helper_spec.rb
+++ b/spec/helpers/archived_projects_helper_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe ArchivedProjectsHelper do
- describe '#archived_projects_urls_for' do
+ describe "#archived_projects_urls_for" do
subject { helper.archived_projects_urls_for([archived_project, other_archived_project]) }
shared_let(:archived_project) { create(:project, :archived) }
@@ -43,7 +43,7 @@
"{\"name_and_identifier\":{\"operator\":\"=\",\"values\":[\"#{other_archived_project.name}\"]}}]"
end
- it 'returns a comma-separated list of anchor tags for each archived project' do
+ it "returns a comma-separated list of anchor tags for each archived project" do
expect(subject)
.to eq(
"" \
diff --git a/spec/helpers/custom_styles_helper_spec.rb b/spec/helpers/custom_styles_helper_spec.rb
index f9a5d5a25754..4ed937c4dcf3 100644
--- a/spec/helpers/custom_styles_helper_spec.rb
+++ b/spec/helpers/custom_styles_helper_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe CustomStylesHelper do
let(:current_theme) { nil }
@@ -37,45 +37,45 @@
allow(OpenProject::Configuration).to receive(:bim?).and_return(bim_edition?)
end
- describe '.apply_custom_styles?' do
+ describe ".apply_custom_styles?" do
subject { helper.apply_custom_styles? }
- context 'no CustomStyle present' do
- it 'is falsey' do
+ context "no CustomStyle present" do
+ it "is falsey" do
expect(subject).to be_falsey
end
end
- context 'CustomStyle present' do
+ context "CustomStyle present" do
let(:current_theme) { build_stubbed(:custom_style) }
- context 'without EE', with_ee: false do
- context 'no BIM edition' do
- it 'is falsey' do
+ context "without EE", with_ee: false do
+ context "no BIM edition" do
+ it "is falsey" do
expect(subject).to be_falsey
end
end
- context 'BIM edition' do
+ context "BIM edition" do
let(:bim_edition?) { true }
- it 'is truthy' do
+ it "is truthy" do
expect(subject).to be_truthy
end
end
end
- context 'with EE', with_ee: %i[define_custom_style] do
- context 'no BIM edition' do
- it 'is truthy' do
+ context "with EE", with_ee: %i[define_custom_style] do
+ context "no BIM edition" do
+ it "is truthy" do
expect(subject).to be_truthy
end
end
- context 'BIM edition' do
+ context "BIM edition" do
let(:bim_edition?) { true }
- it 'is truthy' do
+ it "is truthy" do
expect(subject).to be_truthy
end
end
@@ -83,14 +83,14 @@
end
end
- shared_examples('apply when ee present') do
- context 'no CustomStyle present' do
- it 'is falsey' do
+ shared_examples("apply when ee present") do
+ context "no CustomStyle present" do
+ it "is falsey" do
expect(subject).to be_falsey
end
end
- context 'CustomStyle present' do
+ context "CustomStyle present" do
let(:current_theme) { build_stubbed(:custom_style) }
before do
@@ -98,29 +98,29 @@
allow(current_theme).to receive(:touch_icon).and_return(true)
end
- context 'without EE', with_ee: false do
- it 'is falsey' do
+ context "without EE", with_ee: false do
+ it "is falsey" do
expect(subject).to be_falsey
end
end
- context 'with EE', with_ee: %i[define_custom_style] do
- it 'is truthy' do
+ context "with EE", with_ee: %i[define_custom_style] do
+ it "is truthy" do
expect(subject).to be_truthy
end
end
end
end
- describe '.apply_custom_favicon?' do
+ describe ".apply_custom_favicon?" do
subject { helper.apply_custom_favicon? }
- it_behaves_like 'apply when ee present'
+ it_behaves_like "apply when ee present"
end
- describe '.apply_custom_touch_icon?' do
+ describe ".apply_custom_touch_icon?" do
subject { helper.apply_custom_touch_icon? }
- it_behaves_like 'apply when ee present'
+ it_behaves_like "apply when ee present"
end
end
diff --git a/spec/helpers/error_message_helper_spec.rb b/spec/helpers/error_message_helper_spec.rb
index 27f5ba39649e..fc4eb7043db1 100644
--- a/spec/helpers/error_message_helper_spec.rb
+++ b/spec/helpers/error_message_helper_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe ErrorMessageHelper do
let(:model) { WikiPage.new }
@@ -35,55 +35,55 @@ def escape_html(array)
array.map { CGI.escapeHTML _1 }
end
- shared_examples 'error messages rendering' do
- context 'when no errors' do
- it { expect(rendered).to eq('') }
+ shared_examples "error messages rendering" do
+ context "when no errors" do
+ it { expect(rendered).to eq("") }
end
- context 'with one field error' do
+ context "with one field error" do
before do
errors.add(:title, :blank)
end
- it { expect(rendered).to include(t('activerecord.errors.template.header', model: 'Wiki page', count: 1)) }
- it { expect(rendered).to include(t('errors.header_invalid_fields', count: 1)) }
+ it { expect(rendered).to include(t("activerecord.errors.template.header", model: "Wiki page", count: 1)) }
+ it { expect(rendered).to include(t("errors.header_invalid_fields", count: 1)) }
it { expect(rendered).to include(*escape_html(errors.full_messages)) }
end
- context 'with two field errors' do
+ context "with two field errors" do
before do
errors.add(:title, :blank)
errors.add(:author, :blank)
end
- it { expect(rendered).to include(t('activerecord.errors.template.header', model: 'Wiki page', count: 2)) }
- it { expect(rendered).to include(t('errors.header_invalid_fields', count: 2)) }
+ it { expect(rendered).to include(t("activerecord.errors.template.header", model: "Wiki page", count: 2)) }
+ it { expect(rendered).to include(t("errors.header_invalid_fields", count: 2)) }
it { expect(rendered).to include(*escape_html(errors.full_messages)) }
end
- context 'with one base error' do
+ context "with one base error" do
before do
errors.add(:base, :error_unauthorized)
end
- it { expect(rendered).to include(t('activerecord.errors.template.header', model: 'Wiki page', count: 1)) }
- it { expect(rendered).not_to include(t('errors.header_invalid_fields', count: 1)) }
- it { expect(rendered).not_to include(t('errors.header_additional_invalid_fields', count: 1)) }
+ it { expect(rendered).to include(t("activerecord.errors.template.header", model: "Wiki page", count: 1)) }
+ it { expect(rendered).not_to include(t("errors.header_invalid_fields", count: 1)) }
+ it { expect(rendered).not_to include(t("errors.header_additional_invalid_fields", count: 1)) }
it { expect(rendered).to include(*escape_html(errors.full_messages)) }
end
- context 'with one base error and one field error' do
+ context "with one base error and one field error" do
before do
errors.add(:base, :error_unauthorized)
errors.add(:title, :blank)
end
- it { expect(rendered).to include(t('activerecord.errors.template.header', model: 'Wiki page', count: 2)) }
- it { expect(rendered).to include(t('errors.header_additional_invalid_fields', count: 1)) }
+ it { expect(rendered).to include(t("activerecord.errors.template.header", model: "Wiki page", count: 2)) }
+ it { expect(rendered).to include(t("errors.header_additional_invalid_fields", count: 1)) }
it { expect(rendered).to include(*escape_html(errors.full_messages)) }
end
- context 'with two base errors and two field errors' do
+ context "with two base errors and two field errors" do
before do
errors.add(:base, :error_unauthorized)
errors.add(:title, :blank)
@@ -91,29 +91,29 @@ def escape_html(array)
errors.add(:author, :blank)
end
- it { expect(rendered).to include(t('activerecord.errors.template.header', model: 'Wiki page', count: 4)) }
- it { expect(rendered).to include(t('errors.header_additional_invalid_fields', count: 2)) }
+ it { expect(rendered).to include(t("activerecord.errors.template.header", model: "Wiki page", count: 4)) }
+ it { expect(rendered).to include(t("errors.header_additional_invalid_fields", count: 2)) }
it { expect(rendered).to include(*escape_html(errors.full_messages)) }
end
end
- describe '#error_messages_for' do
+ describe "#error_messages_for" do
let(:errors) { model.errors }
subject(:rendered) { helper.error_messages_for(model) }
- it 'accesses the model from instance variables if a name is given' do
+ it "accesses the model from instance variables if a name is given" do
helper.instance_variable_set(:@wiki_page, model)
model.errors.add(:base, :error_conflict)
- expect(helper.error_messages_for('wiki_page')).to include(*escape_html(errors.full_messages))
+ expect(helper.error_messages_for("wiki_page")).to include(*escape_html(errors.full_messages))
end
- it 'renders nothing if there is no instance variable with the given name' do
+ it "renders nothing if there is no instance variable with the given name" do
helper.instance_variable_set(:@wiki_page, model)
model.errors.add(:base, :error_conflict)
- expect(helper.error_messages_for('work_package')).to be_nil
+ expect(helper.error_messages_for("work_package")).to be_nil
end
- include_examples 'error messages rendering'
+ include_examples "error messages rendering"
end
end
diff --git a/spec/helpers/frontend_asset_helper_spec.rb b/spec/helpers/frontend_asset_helper_spec.rb
index d38d20346658..0ac08a05ff76 100644
--- a/spec/helpers/frontend_asset_helper_spec.rb
+++ b/spec/helpers/frontend_asset_helper_spec.rb
@@ -26,46 +26,46 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe FrontendAssetHelper do
- describe '#include_frontend_assets' do
- context 'when in development or test',
- with_env: { 'OPENPROJECT_DISABLE_DEV_ASSET_PROXY' => '' } do
+ describe "#include_frontend_assets" do
+ context "when in development or test",
+ with_env: { "OPENPROJECT_DISABLE_DEV_ASSET_PROXY" => "" } do
before do
allow(Rails.env).to receive(:production?).and_return(false)
end
- it 'returns the proxied frontend server' do
+ it "returns the proxied frontend server" do
expect(helper.include_frontend_assets).to match(%r{script src="http://localhost:4200/assets/frontend/main(.*).js"})
end
end
- context 'when in production' do
+ context "when in production" do
before do
allow(Rails.env).to receive(:production?).and_return(true)
end
- it 'returns the path to the asset' do
+ it "returns the path to the asset" do
expect(helper.include_frontend_assets).to match(%r{script src="/assets/frontend/main(.*).js"})
end
- context 'when using relative_url_root' do
+ context "when using relative_url_root" do
before do
controller.config.relative_url_root = "/openproject"
end
- it 'prepends it to the asset path' do
+ it "prepends it to the asset path" do
expect(helper.include_frontend_assets).to match(%r{script src="/openproject/assets/frontend/main(.*).js"})
end
end
- context 'when using relative_url_root ending with a slash' do
+ context "when using relative_url_root ending with a slash" do
before do
controller.config.relative_url_root = "/openproject/"
end
- it 'prepends it to the asset path only once (bug #41428)' do
+ it "prepends it to the asset path only once (bug #41428)" do
expect(helper.include_frontend_assets).to match(%r{script src="/openproject/assets/frontend/main(.*).js"})
end
end
diff --git a/spec/helpers/hook_helper_spec.rb b/spec/helpers/hook_helper_spec.rb
index e7966cf54e75..c0ac787826f7 100644
--- a/spec/helpers/hook_helper_spec.rb
+++ b/spec/helpers/hook_helper_spec.rb
@@ -25,11 +25,11 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe HookHelper do
- describe '#call_hook' do
- context 'when called within a controller' do
+ describe "#call_hook" do
+ context "when called within a controller" do
let(:test_hook_controller_class) do
# Also tests that the application controller has the model included
Class.new(ApplicationController)
@@ -49,7 +49,7 @@
instance_double(ActionDispatch::Request)
end
- it 'adds to the context' do
+ it "adds to the context" do
allow(OpenProject::Hook)
.to receive(:call_hook)
@@ -64,7 +64,7 @@
end
end
- context 'when called within a view' do
+ context "when called within a view" do
let(:test_hook_view_class) do
# Also tests that the application controller has the model included
Class.new(ActionView::Base) do
@@ -73,7 +73,7 @@
end
let(:instance) do
test_hook_view_class
- .new(ActionView::LookupContext.new(Rails.root.join('app/views')), {}, nil)
+ .new(ActionView::LookupContext.new(Rails.root.join("app/views")), {}, nil)
.tap do |inst|
inst.instance_variable_set(:@project, project)
allow(inst)
@@ -94,7 +94,7 @@
instance_double(ApplicationController)
end
- it 'adds to the context' do
+ it "adds to the context" do
# mimics having two different classes registered for the hook
allow(OpenProject::Hook)
.to receive(:call_hook)
diff --git a/spec/helpers/individual_principal_hooks_helper_spec.rb b/spec/helpers/individual_principal_hooks_helper_spec.rb
index 8130da348177..6c268d76441b 100644
--- a/spec/helpers/individual_principal_hooks_helper_spec.rb
+++ b/spec/helpers/individual_principal_hooks_helper_spec.rb
@@ -26,28 +26,28 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe IndividualPrincipalHooksHelper do
let(:user) { build(:user) }
let(:placeholder_user) { build(:placeholder_user) }
- describe '#individual_principal_key' do
- it 'returns the class name in underscore format' do
+ describe "#individual_principal_key" do
+ it "returns the class name in underscore format" do
expect(helper.individual_principal_key(user)).to be(:user)
expect(helper.individual_principal_key(placeholder_user)).to be(:placeholder_user)
end
end
- describe '#call_individual_principals_memberships_hook' do
+ describe "#call_individual_principals_memberships_hook" do
before do
allow(helper)
.to receive(:call_hook)
end
- context 'with user and without context' do
- it 'call call_hook with the correct arguments' do
- helper.call_individual_principals_memberships_hook(user, 'foo')
+ context "with user and without context" do
+ it "call call_hook with the correct arguments" do
+ helper.call_individual_principals_memberships_hook(user, "foo")
expect(helper)
.to have_received(:call_hook)
@@ -56,9 +56,9 @@
end
end
- context 'with placeholder user and without context' do
- it 'call call_hook with the correct arguments' do
- helper.call_individual_principals_memberships_hook(placeholder_user, 'foo')
+ context "with placeholder user and without context" do
+ it "call call_hook with the correct arguments" do
+ helper.call_individual_principals_memberships_hook(placeholder_user, "foo")
expect(helper)
.to have_received(:call_hook)
@@ -67,15 +67,15 @@
end
end
- context 'with user and with context' do
- it 'call call_hook with the correct arguments' do
- helper.call_individual_principals_memberships_hook(user, 'foo', yay: 'yo')
+ context "with user and with context" do
+ it "call call_hook with the correct arguments" do
+ helper.call_individual_principals_memberships_hook(user, "foo", yay: "yo")
expect(helper)
.to have_received(:call_hook)
.with(:view_users_memberships_table_foo,
user:,
- yay: 'yo')
+ yay: "yo")
end
end
end
diff --git a/spec/helpers/journals_helper_spec.rb b/spec/helpers/journals_helper_spec.rb
index 1a5d20b46fae..8dd35375916f 100644
--- a/spec/helpers/journals_helper_spec.rb
+++ b/spec/helpers/journals_helper_spec.rb
@@ -28,16 +28,16 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe JournalsHelper do
- describe 'back_to_activity_page_url' do
+ describe "back_to_activity_page_url" do
{
- 'all' => 'http://test.host/activities',
- 'projects/some-identifier' => 'http://test.host/projects/some-identifier/activities',
- 'unsupported_gizmo' => nil,
- 'users/5' => 'http://test.host/users/5',
- 'work_packages/42' => 'http://test.host/work_packages/42',
+ "all" => "http://test.host/activities",
+ "projects/some-identifier" => "http://test.host/projects/some-identifier/activities",
+ "unsupported_gizmo" => nil,
+ "users/5" => "http://test.host/users/5",
+ "work_packages/42" => "http://test.host/work_packages/42",
nil => nil
}.each do |activity_page, expected_url|
context "when activity page is #{activity_page.inspect}" do
diff --git a/spec/helpers/no_results_helper_spec.rb b/spec/helpers/no_results_helper_spec.rb
index e26b8f230400..9def7d0d2549 100644
--- a/spec/helpers/no_results_helper_spec.rb
+++ b/spec/helpers/no_results_helper_spec.rb
@@ -26,36 +26,36 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe NoResultsHelper do
before do
- allow(helper).to receive(:t).with('.no_results_title_text', cascade: true).and_return("Nothing here!")
- allow(helper).to receive(:t).with('.no_results_content_text').and_return("Add some foo")
+ allow(helper).to receive(:t).with(".no_results_title_text", cascade: true).and_return("Nothing here!")
+ allow(helper).to receive(:t).with(".no_results_content_text").and_return("Add some foo")
end
- describe '#no_results_box' do
+ describe "#no_results_box" do
it "contains the just the title" do
- expect(helper.no_results_box).to have_content 'Nothing here!'
- expect(helper.no_results_box).to have_no_link 'Add some foo'
+ expect(helper.no_results_box).to have_content "Nothing here!"
+ expect(helper.no_results_box).to have_no_link "Add some foo"
end
it "contains the title and content link" do
no_results_box = helper.no_results_box(action_url: root_path,
display_action: true)
- expect(no_results_box).to have_content 'Nothing here!'
- expect(no_results_box).to have_link 'Add some foo', href: '/'
+ expect(no_results_box).to have_content "Nothing here!"
+ expect(no_results_box).to have_link "Add some foo", href: "/"
end
- it 'contains title and content_link with custom text' do
+ it "contains title and content_link with custom text" do
no_results_box = helper.no_results_box(action_url: root_path,
display_action: true,
- custom_title: 'This is a different title about foo',
- custom_action_text: 'Link to nowhere')
+ custom_title: "This is a different title about foo",
+ custom_action_text: "Link to nowhere")
- expect(no_results_box).to have_content 'This is a different title about foo'
- expect(no_results_box).to have_link 'Link to nowhere', href: '/'
+ expect(no_results_box).to have_content "This is a different title about foo"
+ expect(no_results_box).to have_link "Link to nowhere", href: "/"
end
end
end
diff --git a/spec/helpers/pagination_helper_spec.rb b/spec/helpers/pagination_helper_spec.rb
index 718e06fc454f..211a598597bc 100644
--- a/spec/helpers/pagination_helper_spec.rb
+++ b/spec/helpers/pagination_helper_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe PaginationHelper do
let(:paginator) do
@@ -45,7 +45,7 @@
paginator
end
- describe '#pagination_links_full' do
+ describe "#pagination_links_full" do
let(:per_page) { 10 }
let(:total_entries) { 55 }
let(:offset) { 1 }
@@ -59,25 +59,25 @@
allow(helper)
.to receive(:params)
- .and_return(ActionController::Parameters.new(controller: 'work_packages', action: 'index'))
+ .and_return(ActionController::Parameters.new(controller: "work_packages", action: "index"))
allow(helper)
.to receive(:url_options)
- .and_return(url_options.merge(controller: 'work_packages', action: 'index'))
+ .and_return(url_options.merge(controller: "work_packages", action: "index"))
end
it "is inside a 'pagination' div" do
- expect(pagination).to have_css('div.op-pagination')
+ expect(pagination).to have_css("div.op-pagination")
end
- it 'has a next_page reference' do
- expect(pagination).to have_css('.op-pagination--item_next')
+ it "has a next_page reference" do
+ expect(pagination).to have_css(".op-pagination--item_next")
end
- it 'does not have a previous_page reference' do
- expect(pagination).to have_no_css('.op-pagination--item_prev')
+ it "does not have a previous_page reference" do
+ expect(pagination).to have_no_css(".op-pagination--item_prev")
end
- it 'has links to every page except the current one' do
+ it "has links to every page except the current one" do
(1..(total_entries / per_page)).each do |i|
next if i == current_page
@@ -86,23 +86,23 @@
end
end
- it 'does not have a link to the current page' do
- expect(pagination).to have_no_css('a', text: Regexp.new("^#{current_page}$"))
+ it "does not have a link to the current page" do
+ expect(pagination).to have_no_css("a", text: Regexp.new("^#{current_page}$"))
end
- it 'has an element for the current page' do
- expect(pagination).to have_css('.op-pagination--item_current',
+ it "has an element for the current page" do
+ expect(pagination).to have_css(".op-pagination--item_current",
text: Regexp.new("^#{current_page}$"))
end
- it 'shows the range of the entries displayed' do
+ it "shows the range of the entries displayed" do
range = "(#{(current_page * per_page) - per_page + 1} - " +
"#{current_page * per_page}/#{total_entries})"
- expect(pagination).to have_css('.op-pagination--range', text: range)
+ expect(pagination).to have_css(".op-pagination--range", text: range)
end
- it 'has different urls if the params are specified as options' do
- params = { controller: 'work_packages', action: 'index' }
+ it "has different urls if the params are specified as options" do
+ params = { controller: "work_packages", action: "index" }
pagination = helper.pagination_links_full(paginator, params:)
@@ -115,74 +115,74 @@
end
end
- it 'shows the available per page options' do
+ it "shows the available per page options" do
allow(Setting)
.to receive(:per_page_options)
.and_return("#{per_page},#{per_page * 10}")
- expect(pagination).to have_css('.op-pagination--options')
+ expect(pagination).to have_css(".op-pagination--options")
- expect(pagination).to have_css('.op-pagination--options .op-pagination--item_current', text: per_page)
+ expect(pagination).to have_css(".op-pagination--options .op-pagination--item_current", text: per_page)
path = work_packages_path(page: current_page, per_page: Setting.per_page_options_array.last)
expect(pagination).to have_css(".op-pagination--options a[href='#{path}']")
end
- describe 'WHEN the first page is the current' do
+ describe "WHEN the first page is the current" do
let(:current_page) { 1 }
- it 'deactivates the previous page link' do
- expect(pagination).to have_no_css('.op-pagination--item_prev')
+ it "deactivates the previous page link" do
+ expect(pagination).to have_no_css(".op-pagination--item_prev")
end
- it 'has a link to the next page' do
+ it "has a link to the next page" do
path = work_packages_path(page: current_page + 1)
expect(pagination).to have_css(".op-pagination--item_next a[href='#{path}']")
end
end
- describe 'WHEN the last page is the current' do
+ describe "WHEN the last page is the current" do
let(:current_page) { (total_entries / per_page) + 1 }
- it 'deactivates the next page link' do
- expect(pagination).to have_no_css('.op-pagination--item_next')
+ it "deactivates the next page link" do
+ expect(pagination).to have_no_css(".op-pagination--item_next")
end
- it 'has a link to the previous page' do
+ it "has a link to the previous page" do
path = work_packages_path(page: current_page - 1)
expect(pagination).to have_css(".op-pagination--item_prev a[href='#{path}']")
end
end
- describe 'WHEN the paginated object is empty' do
+ describe "WHEN the paginated object is empty" do
let(:total_entries) { 0 }
- it 'shows no pages' do
- expect(pagination).to have_no_css('.op-pagination--items .op-pagination--item')
+ it "shows no pages" do
+ expect(pagination).to have_no_css(".op-pagination--items .op-pagination--item")
end
- it 'shows no pagination' do
- expect(pagination).to have_no_css('.op-pagination')
+ it "shows no pagination" do
+ expect(pagination).to have_no_css(".op-pagination")
end
end
end
- describe '#page_param' do
- it 'returns page if provided and sensible' do
+ describe "#page_param" do
+ it "returns page if provided and sensible" do
page = 2
expect(page_param(page:)).to eq(page)
end
- it 'returns default page 1 if page provided but useless' do
+ it "returns default page 1 if page provided but useless" do
page = 0
expect(page_param(page:)).to eq(1)
end
- context 'with multiples per_page',
- with_settings: { per_page_options: '5,10,15' } do
- it 'calculates page from offset and limit if page is not provided' do
+ context "with multiples per_page",
+ with_settings: { per_page_options: "5,10,15" } do
+ it "calculates page from offset and limit if page is not provided" do
# need to change settings as only multiples of per_page
# are allowed for limit
offset = 55
@@ -192,7 +192,7 @@
end
end
- it 'ignores offset and limit if page is provided' do
+ it "ignores offset and limit if page is provided" do
offset = 55
limit = 10
page = 7
@@ -200,30 +200,30 @@
expect(page_param(offset:, limit:, page:)).to eq(page)
end
- context 'faulty settings',
- with_settings: { per_page_options: '-1,2,3' } do
- it 'does not break if limit is bogus (also faulty settings)' do
+ context "faulty settings",
+ with_settings: { per_page_options: "-1,2,3" } do
+ it "does not break if limit is bogus (also faulty settings)" do
offset = 55
- limit = 'lorem'
+ limit = "lorem"
expect(page_param(offset:, limit:)).to eq(28)
end
end
- it 'returns 1 if nothing is provided' do
+ it "returns 1 if nothing is provided" do
expect(page_param({})).to eq(1)
end
end
- describe '#per_page_param',
- with_settings: { per_page_options: '1,2,3' } do
- it 'returns per_page if provided and one of the values stored in the settings' do
+ describe "#per_page_param",
+ with_settings: { per_page_options: "1,2,3" } do
+ it "returns per_page if provided and one of the values stored in the settings" do
per_page = 2
expect(per_page_param(per_page:)).to eq(per_page)
end
- it 'returns per_page if provided and store it in the session' do
+ it "returns per_page if provided and store it in the session" do
session[:per_page] = 3
per_page = 2
@@ -231,39 +231,39 @@
expect(session[:per_page]).to eq(2)
end
- it 'should take the smallest value stored in the settings ' +
- 'if provided per_page param is not one of the configured' do
+ it "should take the smallest value stored in the settings " +
+ "if provided per_page param is not one of the configured" do
per_page = 4
expect(per_page_param(per_page:)).to eq(1)
end
- it 'prefers the value stored in the session if it is valid according to the settings' do
+ it "prefers the value stored in the session if it is valid according to the settings" do
session[:per_page] = 2
expect(per_page_param(per_page: 3)).to eq(session[:per_page])
end
- it 'ignores the value stored in the session if it is not valid according to the settings' do
+ it "ignores the value stored in the session if it is not valid according to the settings" do
session[:per_page] = 4
expect(per_page_param(per_page: 3)).to eq(3)
end
- it 'uses limit synonymously to per_page' do
+ it "uses limit synonymously to per_page" do
limit = 2
expect(per_page_param(limit:)).to eq(limit)
end
- it 'prefers per_page over limit' do
+ it "prefers per_page over limit" do
limit = 2
per_page = 3
expect(per_page_param(limit:, per_page:)).to eq(per_page)
end
- it 'stores the value in the session' do
+ it "stores the value in the session" do
limit = 2
per_page_param(limit:)
diff --git a/spec/helpers/projects_helper_spec.rb b/spec/helpers/projects_helper_spec.rb
index 0bb6537acf12..7b5636d71aef 100644
--- a/spec/helpers/projects_helper_spec.rb
+++ b/spec/helpers/projects_helper_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe ProjectsHelper do
include ApplicationHelper
@@ -47,53 +47,53 @@
.and_return(query_instance)
end
- describe '#short_project_description' do
+ describe "#short_project_description" do
let(:project) { build_stubbed(:project, description: "#{'Abcd ' * 5}\n" * 11) }
- it 'returns shortened description' do
+ it "returns shortened description" do
expect(helper.short_project_description(project))
.to eql("#{("#{'Abcd ' * 5}\n" * 10)[0..-2]}...")
end
end
- describe '#projects_columns_options' do
+ describe "#projects_columns_options" do
before do
project_selects
end
- it 'returns the columns options' do
+ it "returns the columns options" do
expect(helper.projects_columns_options)
.to eql([
- { name: 'Description', id: :description },
- { name: 'Name', id: :name },
- { name: 'Status', id: :project_status }
+ { name: "Description", id: :description },
+ { name: "Name", id: :name },
+ { name: "Status", id: :project_status }
])
end
end
- describe '#selected_project_columns_options', with_settings: { enabled_projects_columns: %w[name description] } do
+ describe "#selected_project_columns_options", with_settings: { enabled_projects_columns: %w[name description] } do
before do
project_selects
end
- it 'returns the columns options currently persisted in the setting (in that order)' do
+ it "returns the columns options currently persisted in the setting (in that order)" do
expect(helper.selected_projects_columns_options)
.to eql([
- { name: 'Name', id: :name },
- { name: 'Description', id: :description }
+ { name: "Name", id: :name },
+ { name: "Description", id: :description }
])
end
end
- describe '#protected_project_columns_options' do
+ describe "#protected_project_columns_options" do
before do
project_selects
end
- it 'returns the columns options currently persisted in the setting (in that order)' do
+ it "returns the columns options currently persisted in the setting (in that order)" do
expect(helper.protected_projects_columns_options)
.to eql([
- { name: 'Name', id: :name }
+ { name: "Name", id: :name }
])
end
end
diff --git a/spec/helpers/removed_js_helpers_helper_spec.rb b/spec/helpers/removed_js_helpers_helper_spec.rb
index 4644f9282ec8..270cf090ae73 100644
--- a/spec/helpers/removed_js_helpers_helper_spec.rb
+++ b/spec/helpers/removed_js_helpers_helper_spec.rb
@@ -26,24 +26,24 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe RemovedJsHelpersHelper do
include RemovedJsHelpersHelper
- describe 'link_to_function' do
- it 'returns a valid link' do
- allow(SecureRandom).to receive(:uuid).and_return 'uuid'
+ describe "link_to_function" do
+ it "returns a valid link" do
+ allow(SecureRandom).to receive(:uuid).and_return "uuid"
expect(self).to receive(:content_for).with(:additional_js_dom_ready)
- expect(link_to_function('blubs', nil))
+ expect(link_to_function("blubs", nil))
.to be_html_eql %{
blubs
}
end
- it 'adds the provided method to the onclick handler' do
+ it "adds the provided method to the onclick handler" do
expect(self).to receive(:content_for).with(:additional_js_dom_ready)
- expect(link_to_function('blubs', 'doTheMagic(now)', id: :foo))
+ expect(link_to_function("blubs", "doTheMagic(now)", id: :foo))
.to be_html_eql %{
blubs
}
diff --git a/spec/helpers/search_helper_spec.rb b/spec/helpers/search_helper_spec.rb
index da48346fda98..2c52aa6b73ff 100644
--- a/spec/helpers/search_helper_spec.rb
+++ b/spec/helpers/search_helper_spec.rb
@@ -26,37 +26,37 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'search/index' do
+RSpec.describe "search/index" do
let(:project) { create(:project) }
- let(:scope) { 'foobar' }
+ let(:scope) { "foobar" }
before do
allow(helper).to receive(:params).and_return(
- q: 'foobar',
- all_words: '1',
+ q: "foobar",
+ all_words: "1",
scope:
)
assign(:project, project)
end
- describe '#highlight_tokens' do
+ describe "#highlight_tokens" do
let(:maximum_length) { 1300 }
subject(:highlighted_title) { helper.highlight_tokens title, tokens }
- context 'with single token' do
+ context "with single token" do
let(:tokens) { %w(token) }
- let(:title) { 'This is a token.' }
+ let(:title) { "This is a token." }
let(:expected_title) { 'This is a token.' }
it { is_expected.to eq expected_title }
end
- context 'with multiple tokens' do
+ context "with multiple tokens" do
let(:tokens) { %w(token another) }
- let(:title) { 'This is a token and another token.' }
+ let(:title) { "This is a token and another token." }
let(:expected_title) do
<<~TITLE.squish
This is a token
@@ -68,19 +68,19 @@
it { is_expected.to eq expected_title }
end
- context 'with huge content' do
+ context "with huge content" do
let(:tokens) { %w(token) }
let(:title) { "#{'1234567890' * 100} token " * 100 }
let(:highlighted_token) { 'token' }
it { expect(highlighted_title).to include highlighted_token }
- it 'does not exceed maximum length' do
+ it "does not exceed maximum length" do
expect(highlighted_title.length).to be <= maximum_length
end
end
- context 'with multibyte title' do
+ context "with multibyte title" do
let(:tokens) { %w(token) }
let(:title) { "#{'й' * 200} token #{'й' * 200}" }
let(:expected_title) do
@@ -91,7 +91,7 @@
end
end
- describe '#highlight_tokens_in_event' do
+ describe "#highlight_tokens_in_event" do
let(:journal_notes) { "Journals notes" }
let(:event_description) { "The description of the event" }
let(:attachment_fulltext) { "The fulltext of the attachment" }
@@ -118,58 +118,58 @@
end
end
- context 'with the token in the journal notes' do
+ context "with the token in the journal notes" do
let(:tokens) { %w(journals) }
- it 'shows the text in the notes' do
+ it "shows the text in the notes" do
expect(helper.highlight_tokens_in_event(event, tokens))
.to eql 'Journals notes'
end
end
- context 'with the token in the description' do
+ context "with the token in the description" do
let(:tokens) { %w(description) }
- it 'shows the text in the description' do
+ it "shows the text in the description" do
expect(helper.highlight_tokens_in_event(event, tokens))
.to eql 'The description of the event'
end
end
- context 'with the token in the description and empty journal notes' do
+ context "with the token in the description and empty journal notes" do
let(:tokens) { %w(description) }
let(:journal_notes) { "" }
- it 'shows the text in the description' do
+ it "shows the text in the description" do
expect(helper.highlight_tokens_in_event(event, tokens))
.to eql 'The description of the event'
end
end
- context 'with the token in the attachment text' do
+ context "with the token in the attachment text" do
let(:tokens) { %w(fulltext) }
- it 'shows the text in the fulltext' do
+ it "shows the text in the fulltext" do
expect(helper.highlight_tokens_in_event(event, tokens))
.to eql 'The fulltext of the attachment'
end
end
- context 'with the token in the attachment filename' do
+ context "with the token in the attachment filename" do
let(:tokens) { %w(filename) }
- it 'shows the text in the fulltext' do
+ it "shows the text in the fulltext" do
expect(helper.highlight_tokens_in_event(event, tokens))
.to eql 'attachment_filename.txt'
end
end
- context 'with the token in neither' do
+ context "with the token in neither" do
let(:tokens) { %w(bogus) }
- it 'shows the description (without highlight)' do
+ it "shows the description (without highlight)" do
expect(helper.highlight_tokens_in_event(event, tokens))
- .to eql 'The description of the event'
+ .to eql "The description of the event"
end
end
end
diff --git a/spec/helpers/security_badge_helper_spec.rb b/spec/helpers/security_badge_helper_spec.rb
index 9b53f468acd4..05c6c8443f23 100644
--- a/spec/helpers/security_badge_helper_spec.rb
+++ b/spec/helpers/security_badge_helper_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe SecurityBadgeHelper do
- describe '#security_badge_url' do
+ describe "#security_badge_url" do
before do
# can't use with_settings since Setting.installation_uuid has a custom implementation
- allow(Setting).to receive(:installation_uuid).and_return 'abcd1234'
+ allow(Setting).to receive(:installation_uuid).and_return "abcd1234"
end
it "generates a URL with the release API path and the details of the installation" do
diff --git a/spec/helpers/settings_helper_spec.rb b/spec/helpers/settings_helper_spec.rb
index d9f4f24d4484..96a9d04c47e0 100644
--- a/spec/helpers/settings_helper_spec.rb
+++ b/spec/helpers/settings_helper_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'ostruct'
+require "spec_helper"
+require "ostruct"
RSpec.describe SettingsHelper do
include Capybara::RSpecMatchers
- let(:options) { { class: 'custom-class' } }
+ let(:options) { { class: "custom-class" } }
before do
allow(Setting)
@@ -40,145 +40,145 @@
.and_return true
allow(I18n).to receive(:t).and_call_original
- allow(I18n).to receive(:t).with('setting_field_a').and_return('Field A')
- allow(I18n).to receive(:t).with('setting_field_b').and_return('Field B')
- allow(I18n).to receive(:t).with('setting_field').and_return('Field')
+ allow(I18n).to receive(:t).with("setting_field_a").and_return("Field A")
+ allow(I18n).to receive(:t).with("setting_field_b").and_return("Field B")
+ allow(I18n).to receive(:t).with("setting_field").and_return("Field")
end
- shared_examples_for 'field disabled if non writable' do
- context 'when the setting is writable' do
- it 'is enabled' do
+ shared_examples_for "field disabled if non writable" do
+ context "when the setting is writable" do
+ it "is enabled" do
expect(output)
- .to have_field 'settings_host_name', disabled: false
+ .to have_field "settings_host_name", disabled: false
end
end
- context 'when the setting isn`t writable' do
+ context "when the setting isn`t writable" do
before do
allow(Setting)
.to receive(:host_name_writable?)
.and_return false
end
- it 'is disabled' do
+ it "is disabled" do
expect(output)
- .to have_field 'settings_host_name', disabled: true
+ .to have_field "settings_host_name", disabled: true
end
end
end
- describe '#setting_select' do
+ describe "#setting_select" do
subject(:output) do
- helper.setting_select :host_name, [['Popsickle', '1'], ['Jello', '2'], ['Ice Cream', '3']], options
+ helper.setting_select :host_name, [["Popsickle", "1"], ["Jello", "2"], ["Ice Cream", "3"]], options
end
before do
- allow(Setting).to receive(:host_name).and_return('2')
+ allow(Setting).to receive(:host_name).and_return("2")
end
- it_behaves_like 'labelled by default'
- it_behaves_like 'wrapped in field-container by default'
- it_behaves_like 'wrapped in container', 'select-container'
- it_behaves_like 'field disabled if non writable'
+ it_behaves_like "labelled by default"
+ it_behaves_like "wrapped in field-container by default"
+ it_behaves_like "wrapped in container", "select-container"
+ it_behaves_like "field disabled if non writable"
- it 'outputs element' do
- expect(output).to have_css 'select.form--select > option', count: 3
- expect(output).to have_select 'settings_host_name', selected: 'Jello'
+ it "outputs element" do
+ expect(output).to have_css "select.form--select > option", count: 3
+ expect(output).to have_select "settings_host_name", selected: "Jello"
end
end
- describe '#setting_multiselect' do
+ describe "#setting_multiselect" do
subject(:output) do
- helper.setting_multiselect :host_name, [['Popsickle', '1'], ['Jello', '2'], ['Ice Cream', '3']], options
+ helper.setting_multiselect :host_name, [["Popsickle", "1"], ["Jello", "2"], ["Ice Cream", "3"]], options
end
before do
- allow(Setting).to receive(:host_name).at_least(:once).and_return('1')
+ allow(Setting).to receive(:host_name).at_least(:once).and_return("1")
end
- it_behaves_like 'wrapped in container' do
+ it_behaves_like "wrapped in container" do
let(:container_count) { 3 }
end
- it 'has checkboxes wrapped in checkbox-container' do
- expect(output).to have_css 'span.form--check-box-container', count: 3
+ it "has checkboxes wrapped in checkbox-container" do
+ expect(output).to have_css "span.form--check-box-container", count: 3
end
- it 'has three labels' do
- expect(output).to have_css 'label.form--label-with-check-box', count: 3
+ it "has three labels" do
+ expect(output).to have_css "label.form--label-with-check-box", count: 3
end
- it 'outputs element' do
+ it "outputs element" do
expect(output).to have_css 'input[type="checkbox"].form--check-box', count: 3
end
- context 'when the setting isn`t writable' do
+ context "when the setting isn`t writable" do
before do
allow(Setting)
.to receive(:host_name_writable?)
.and_return false
end
- it 'is disabled and has no hidden field' do
+ it "is disabled and has no hidden field" do
expect(output).to have_no_css 'input[type="hidden"][value=""]', visible: :all
expect(output).to have_css 'input[type="checkbox"][disabled="disabled"].form--check-box', count: 3
end
end
end
- describe '#settings_matrix' do
+ describe "#settings_matrix" do
subject(:output) do
settings = %i[host_name protocol]
choices = [
{
- caption: 'Popsickle',
- value: '1'
+ caption: "Popsickle",
+ value: "1"
},
{
- caption: 'Jello',
- value: '2'
+ caption: "Jello",
+ value: "2"
},
{
- caption: 'Ice Cream',
- value: '3'
+ caption: "Ice Cream",
+ value: "3"
},
{
- value: 'Quarkspeise'
+ value: "Quarkspeise"
}
]
helper.settings_matrix settings, choices
end
before do
- allow(Setting).to receive(:host_name).at_least(:once).and_return('2')
- allow(Setting).to receive(:protocol).at_least(:once).and_return('3')
+ allow(Setting).to receive(:host_name).at_least(:once).and_return("2")
+ allow(Setting).to receive(:protocol).at_least(:once).and_return("3")
allow(Setting).to receive_messages(
host_name_writable?: true,
protocol_writable?: true
)
end
- it_behaves_like 'not wrapped in container'
+ it_behaves_like "not wrapped in container"
- it 'is structured as a table' do
- expect(output).to have_css 'table.form--matrix'
+ it "is structured as a table" do
+ expect(output).to have_css "table.form--matrix"
end
- it 'has table headers' do
- expect(output).to have_css 'thead th.form--matrix-header-cell', count: 3
+ it "has table headers" do
+ expect(output).to have_css "thead th.form--matrix-header-cell", count: 3
end
- it 'has three table rows' do
- expect(output).to have_css 'tbody > tr.form--matrix-row', count: 4
+ it "has three table rows" do
+ expect(output).to have_css "tbody > tr.form--matrix-row", count: 4
end
- it 'has cells with text labels' do
+ it "has cells with text labels" do
expect(output).to be_html_eql(%{
Popsickle
- }).at_path('tr:first-child > td:first-child')
+ }).at_path("tr:first-child > td:first-child")
end
- it 'has cells with styled checkboxes' do
+ it "has cells with styled checkboxes" do
expect(output).to be_html_eql(%{
- }).at_path('tr.form--matrix-row:last-child > td:nth-of-type(2)')
+ }).at_path("tr.form--matrix-row:last-child > td:nth-of-type(2)")
end
- it 'has the correct fields checked' do
- expect(output).to have_checked_field 'host_name_2'
- expect(output).to have_checked_field 'protocol_3'
+ it "has the correct fields checked" do
+ expect(output).to have_checked_field "host_name_2"
+ expect(output).to have_checked_field "protocol_3"
end
- context 'when the setting isn`t writable' do
+ context "when the setting isn`t writable" do
before do
allow(Setting)
.to receive(:host_name_writable?)
.and_return false
end
- it 'is disabled' do
+ it "is disabled" do
expect(output).to be_html_eql(%{
- }).at_path('tr.form--matrix-row:first-child > td:nth-of-type(2)')
+ }).at_path("tr.form--matrix-row:first-child > td:nth-of-type(2)")
end
end
end
- describe '#setting_text_field' do
+ describe "#setting_text_field" do
subject(:output) do
helper.setting_text_field :host_name, options
end
before do
- allow(Setting).to receive(:host_name).and_return('important value')
+ allow(Setting).to receive(:host_name).and_return("important value")
end
- it_behaves_like 'labelled by default'
- it_behaves_like 'wrapped in field-container by default'
- it_behaves_like 'wrapped in container', 'text-field-container'
- it_behaves_like 'field disabled if non writable'
+ it_behaves_like "labelled by default"
+ it_behaves_like "wrapped in field-container by default"
+ it_behaves_like "wrapped in container", "text-field-container"
+ it_behaves_like "field disabled if non writable"
- it 'outputs element' do
+ it "outputs element" do
expect(output).to be_html_eql(%{
- }).at_path('input')
+ }).at_path("input")
end
end
- describe '#setting_text_area' do
+ describe "#setting_text_area" do
subject(:output) do
helper.setting_text_area :host_name, options
end
before do
- allow(Setting).to receive(:host_name).and_return('important text')
+ allow(Setting).to receive(:host_name).and_return("important text")
end
- it_behaves_like 'labelled by default'
- it_behaves_like 'wrapped in field-container by default'
- it_behaves_like 'wrapped in container', 'text-area-container'
- it_behaves_like 'field disabled if non writable'
+ it_behaves_like "labelled by default"
+ it_behaves_like "wrapped in field-container by default"
+ it_behaves_like "wrapped in container", "text-area-container"
+ it_behaves_like "field disabled if non writable"
- it 'outputs element' do
+ it "outputs element" do
expect(output).to be_html_eql(%{
- }).at_path('textarea')
+ }).at_path("textarea")
end
end
- describe '#setting_check_box' do
+ describe "#setting_check_box" do
subject(:output) do
helper.setting_check_box :host_name, options
end
- context 'when setting is true' do
+ context "when setting is true" do
before do
allow(Setting).to receive(:host_name?).and_return(true)
end
- it_behaves_like 'labelled by default'
- it_behaves_like 'wrapped in field-container by default'
- it_behaves_like 'wrapped in container', 'check-box-container'
- it_behaves_like 'field disabled if non writable'
+ it_behaves_like "labelled by default"
+ it_behaves_like "wrapped in field-container by default"
+ it_behaves_like "wrapped in container", "check-box-container"
+ it_behaves_like "field disabled if non writable"
- it 'outputs element' do
+ it "outputs element" do
expect(output).to have_css 'input[type="hidden"][value=0]', visible: :hidden
expect(output).to have_css 'input[type="checkbox"].custom-class.form--check-box'
- expect(output).to have_checked_field 'settings_host_name'
+ expect(output).to have_checked_field "settings_host_name"
end
- context 'when the setting isn`t writable' do
+ context "when the setting isn`t writable" do
before do
allow(Setting)
.to receive(:host_name_writable?)
.and_return false
end
- it 'does not output a hidden field' do
+ it "does not output a hidden field" do
expect(output).to have_no_css 'input[type="hidden"][value=0]', visible: :hidden
end
end
end
- context 'when setting is false' do
+ context "when setting is false" do
before do
allow(Setting).to receive(:host_name?).and_return(false)
end
- it_behaves_like 'labelled by default'
- it_behaves_like 'wrapped in field-container by default'
- it_behaves_like 'wrapped in container', 'check-box-container'
- it_behaves_like 'field disabled if non writable'
+ it_behaves_like "labelled by default"
+ it_behaves_like "wrapped in field-container by default"
+ it_behaves_like "wrapped in container", "check-box-container"
+ it_behaves_like "field disabled if non writable"
- it 'outputs element' do
+ it "outputs element" do
expect(output).to have_css 'input[type="hidden"][value=0]', visible: :hidden
expect(output).to have_css 'input[type="checkbox"].custom-class.form--check-box'
- expect(output).to have_unchecked_field 'settings_host_name'
+ expect(output).to have_unchecked_field "settings_host_name"
end
- context 'when the setting isn`t writable' do
+ context "when the setting isn`t writable" do
before do
allow(Setting)
.to receive(:host_name_writable?)
.and_return false
end
- it 'does not output a hidden field' do
+ it "does not output a hidden field" do
expect(output).to have_no_css 'input[type="hidden"][value=0]', visible: :hidden
end
end
end
end
- describe '#setting_time_field' do
+ describe "#setting_time_field" do
subject(:output) do
helper.setting_time_field :host_name, options
end
before do
- allow(Setting).to receive(:host_name).and_return('16:00')
+ allow(Setting).to receive(:host_name).and_return("16:00")
end
- it_behaves_like 'labelled by default'
- it_behaves_like 'wrapped in field-container by default'
- it_behaves_like 'wrapped in container', 'text-field-container'
+ it_behaves_like "labelled by default"
+ it_behaves_like "wrapped in field-container by default"
+ it_behaves_like "wrapped in container", "text-field-container"
- it 'outputs element' do
+ it "outputs element" do
expect(output).to be_html_eql(%{
- }).at_path('input')
+ }).at_path("input")
end
end
- describe '#setting_label' do
+ describe "#setting_label" do
subject(:output) do
helper.setting_label :host_name
end
- it_behaves_like 'labelled'
- it_behaves_like 'not wrapped in container'
+ it_behaves_like "labelled"
+ it_behaves_like "not wrapped in container"
end
end
diff --git a/spec/helpers/sort_helper_spec.rb b/spec/helpers/sort_helper_spec.rb
index d6cd9a256199..374782219614 100644
--- a/spec/helpers/sort_helper_spec.rb
+++ b/spec/helpers/sort_helper_spec.rb
@@ -26,107 +26,107 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe SortHelper do
- describe '#sort_init/#sort_update/#sort_clause' do
+ describe "#sort_init/#sort_update/#sort_clause" do
# Needed to mimic being included in a controller
- def controller_name; 'foo'; end
+ def controller_name; "foo"; end
- def action_name; 'bar'; end
+ def action_name; "bar"; end
before do
- sort_init 'attr1', 'desc'
+ sort_init "attr1", "desc"
end
- context 'with arrays' do
+ context "with arrays" do
before do
sort_update(%w[attr1 attr2])
end
- it 'returns the first attr in descending order' do
+ it "returns the first attr in descending order" do
expect(sort_clause)
- .to eql 'attr1 DESC'
+ .to eql "attr1 DESC"
end
end
- context 'with hashes' do
+ context "with hashes" do
before do
- sort_update('attr1' => 'table1.attr1', 'attr2' => 'table2.attr2')
+ sort_update("attr1" => "table1.attr1", "attr2" => "table2.attr2")
end
- it 'returns the first attr in descending order with the table name prefixed' do
+ it "returns the first attr in descending order with the table name prefixed" do
expect(sort_clause)
- .to eql 'table1.attr1 DESC'
+ .to eql "table1.attr1 DESC"
end
end
- context 'with hashes sorting by multiple values' do
+ context "with hashes sorting by multiple values" do
before do
- sort_update('attr1' => %w[table1.attr1 table1.attr2], 'attr2' => 'table2.attr2')
+ sort_update("attr1" => %w[table1.attr1 table1.attr2], "attr2" => "table2.attr2")
end
- it 'returns the first attr in descending order' do
+ it "returns the first attr in descending order" do
expect(sort_clause)
- .to eql 'table1.attr1 DESC, table1.attr2 DESC'
+ .to eql "table1.attr1 DESC, table1.attr2 DESC"
end
end
end
- describe '#sort_init/#sort_update/params/session' do
+ describe "#sort_init/#sort_update/params/session" do
# Needed to mimic being included in a controller
- def controller_name; 'foo'; end
+ def controller_name; "foo"; end
- def action_name; 'bar'; end
+ def action_name; "bar"; end
def params; { sort: sort_param }; end
def session; @session ||= {}; end
before do
- sort_init 'attr1', 'desc'
- sort_update('attr1' => %w[table1.attr1 table1.attr2], 'attr2' => 'table2.attr2')
+ sort_init "attr1", "desc"
+ sort_update("attr1" => %w[table1.attr1 table1.attr2], "attr2" => "table2.attr2")
end
- context 'with valid sort params' do
- let(:sort_param) { 'attr1,attr2:desc' }
+ context "with valid sort params" do
+ let(:sort_param) { "attr1,attr2:desc" }
- it 'persists the order in the session' do
- expect(session['foo_bar_sort'])
- .to eql 'attr1,attr2:desc'
+ it "persists the order in the session" do
+ expect(session["foo_bar_sort"])
+ .to eql "attr1,attr2:desc"
end
end
- context 'with invalid sort key' do
- let(:sort_param) { 'invalid_key' }
+ context "with invalid sort key" do
+ let(:sort_param) { "invalid_key" }
- it 'keeps the default sort in the session' do
- expect(session['foo_bar_sort'])
- .to eql 'attr1:desc'
+ it "keeps the default sort in the session" do
+ expect(session["foo_bar_sort"])
+ .to eql "attr1:desc"
end
end
- context 'with invalid sort direction' do
- let(:sort_param) { 'attr1:blubs,attr2' }
+ context "with invalid sort direction" do
+ let(:sort_param) { "attr1:blubs,attr2" }
- it 'falls back to the default sort order in the session' do
- expect(session['foo_bar_sort'])
- .to eql 'attr1,attr2'
+ it "falls back to the default sort order in the session" do
+ expect(session["foo_bar_sort"])
+ .to eql "attr1,attr2"
end
end
end
- describe '#sort_header_tag' do
+ describe "#sort_header_tag" do
let(:output) do
- helper.sort_header_tag('id')
+ helper.sort_header_tag("id")
end
- let(:sort_key) { '' }
+ let(:sort_key) { "" }
let(:sort_asc) { true }
let(:sort_criteria) do
instance_double(SortHelper::SortCriteria,
first_key: sort_key,
first_asc?: sort_asc,
- to_param: 'sort_criteria_params').as_null_object
+ to_param: "sort_criteria_params").as_null_object
end
before do
@@ -136,10 +136,10 @@ def session; @session ||= {}; end
# fake having called '/work_packages'
allow(helper)
.to receive(:url_options)
- .and_return(url_options.merge(controller: 'work_packages', action: 'index'))
+ .and_return(url_options.merge(controller: "work_packages", action: "index"))
end
- it 'renders a th with a sort link' do
+ it "renders a th with a sort link" do
expect(output).to be_html_eql(%{
@@ -154,10 +154,10 @@ def session; @session ||= {}; end
})
end
- context 'when sorting by the column' do
- let(:sort_key) { 'id' }
+ context "when sorting by the column" do
+ let(:sort_key) { "id" }
- it 'adds the sort class' do
+ it "adds the sort class" do
expect(output).to be_html_eql(%{
@@ -173,11 +173,11 @@ def session; @session ||= {}; end
end
end
- context 'when sorting desc by the column' do
- let(:sort_key) { 'id' }
+ context "when sorting desc by the column" do
+ let(:sort_key) { "id" }
let(:sort_asc) { false }
- it 'adds the sort class' do
+ it "adds the sort class" do
expect(output).to be_html_eql(%{
diff --git a/spec/helpers/tabs_helper_spec.rb b/spec/helpers/tabs_helper_spec.rb
index 587f40d6b8a7..72bca4a238dc 100644
--- a/spec/helpers/tabs_helper_spec.rb
+++ b/spec/helpers/tabs_helper_spec.rb
@@ -26,26 +26,26 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe TabsHelper do
include described_class
let(:given_tab) do
- { name: 'avatar',
- partial: 'avatars/users/avatar_tab',
+ { name: "avatar",
+ partial: "avatars/users/avatar_tab",
path: ->(params) { edit_user_path(params[:user], tab: :avatar) },
label: :label_avatar }
end
let(:expected_tab) do
- { name: 'avatar',
- partial: 'avatars/users/avatar_tab',
- path: '/users/2/edit/avatar',
+ { name: "avatar",
+ partial: "avatars/users/avatar_tab",
+ path: "/users/2/edit/avatar",
label: :label_avatar }
end
- describe 'render_extensible_tabs' do
+ describe "render_extensible_tabs" do
let(:current_user) { build(:user) }
let(:user) { build(:user, id: 2) }
diff --git a/spec/helpers/text_formatting_helper_spec.rb b/spec/helpers/text_formatting_helper_spec.rb
index c1f7fa78fbfb..6026a2cc8935 100644
--- a/spec/helpers/text_formatting_helper_spec.rb
+++ b/spec/helpers/text_formatting_helper_spec.rb
@@ -26,40 +26,40 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe TextFormattingHelper do
- describe '#preview_context' do
- context 'for a News' do
+ describe "#preview_context" do
+ context "for a News" do
let(:news) { build_stubbed(:news) }
- it 'returns the v3 path' do
+ it "returns the v3 path" do
expect(helper.preview_context(news))
.to eql "/api/v3/news/#{news.id}"
end
end
- context 'for a Message' do
+ context "for a Message" do
let(:message) { build_stubbed(:message) }
- it 'returns the v3 path' do
+ it "returns the v3 path" do
expect(helper.preview_context(message))
.to eql "/api/v3/posts/#{message.id}"
end
end
- context 'for a WikiPage' do
+ context "for a WikiPage" do
let(:wiki_page) { build_stubbed(:wiki_page) }
- it 'returns the v3 path' do
+ it "returns the v3 path" do
expect(helper.preview_context(wiki_page))
.to eql "/api/v3/wiki_pages/#{wiki_page.id}"
end
end
end
- describe 'truncate_formatted_text' do
- context 'with a long text' do
+ describe "truncate_formatted_text" do
+ context "with a long text" do
let(:text) do
<<~TEXT.squish
Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam
@@ -70,7 +70,7 @@
TEXT
end
- context 'without specifying a length' do
+ context "without specifying a length" do
let(:text_html) do
<<~TEXT.squish
Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam
@@ -78,13 +78,13 @@
TEXT
end
- it 'truncates given text at 120 chars' do
+ it "truncates given text at 120 chars" do
expect(truncate_formatted_text(text))
.to be_html_eql(text_html)
end
end
- context 'when specifying a length' do
+ context "when specifying a length" do
let(:text_html) do
<<~TEXT.squish
Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam
@@ -94,49 +94,49 @@
TEXT
end
- it 'truncates given text at the specified length' do
+ it "truncates given text at the specified length" do
expect(truncate_formatted_text(text, length: 250))
.to be_html_eql(text_html)
end
end
end
- context 'with newline characters' do
+ context "with newline characters" do
let(:text) do
"Lorem ipsum dolor sit \namet, consetetur sadipscing elitr, sed diam nonumy eirmod\n tempor invidunt"
end
let(:text_html) do
- 'Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt'
+ "Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt"
end
- it 'replaces escaped line breaks with html line breaks and should be html_safe' do
+ it "replaces escaped line breaks with html line breaks and should be html_safe" do
expect(truncate_formatted_text(text))
.to be_html_eql(text_html)
end
- it 'is html_safe' do
+ it "is html_safe" do
expect(truncate_formatted_text(text))
.to be_html_safe
end
- context 'when specifying not to replace newlines' do
- it 'returns the text unaltered' do
+ context "when specifying not to replace newlines" do
+ it "returns the text unaltered" do
expect(truncate_formatted_text(text, replace_newlines: false))
.to be_html_eql(text)
end
- it 'is html_safe' do
+ it "is html_safe" do
expect(truncate_formatted_text(text, replace_newlines: false))
.to be_html_safe
end
end
end
- context 'with potentially harmful code' do
- it 'escapes' do
+ context "with potentially harmful code" do
+ it "escapes" do
text = "Lorem ipsum dolor tempor invidunt"
expect(truncate_formatted_text(text))
- .to include('<script>alert(\'pwnd\');</script>')
+ .to include("<script>alert('pwnd');</script>")
end
end
end
diff --git a/spec/helpers/toolbar_helper_spec.rb b/spec/helpers/toolbar_helper_spec.rb
index 300f7966bbe7..7939896b4eb9 100644
--- a/spec/helpers/toolbar_helper_spec.rb
+++ b/spec/helpers/toolbar_helper_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe ToolbarHelper do
- describe '.toolbar' do
- it 'creates a default toolbar' do
- result = toolbar title: 'Title'
+ describe ".toolbar" do
+ it "creates a default toolbar" do
+ result = toolbar title: "Title"
expect(result).to be_html_eql %{
@@ -44,8 +44,8 @@
}
end
- it 'is able to add a subtitle' do
- result = toolbar title: 'Title', subtitle: 'lorem'
+ it "is able to add a subtitle" do
+ result = toolbar title: "Title", subtitle: "lorem"
expect(result).to be_html_eql %{
@@ -59,8 +59,8 @@
}
end
- it 'is able to add a link_to' do
- result = toolbar title: 'Title', link_to: link_to('foobar', user_path('1234'))
+ it "is able to add a link_to" do
+ result = toolbar title: "Title", link_to: link_to("foobar", user_path("1234"))
expect(result).to be_html_eql %{
@@ -73,7 +73,7 @@
}
end
- it 'escapes the title' do
+ it "escapes the title" do
result = toolbar title: ''
expect(result).to be_html_eql %{
@@ -87,10 +87,10 @@
}
end
- it 'includes capsulate html' do
- result = toolbar title: 'Title' do
+ it "includes capsulate html" do
+ result = toolbar title: "Title" do
content_tag :li do
- content_tag :p, 'paragraph', data: { number: 2 }
+ content_tag :p, "paragraph", data: { number: 2 }
end
end
expect(result).to be_html_eql %{
@@ -110,10 +110,10 @@
end
end
- describe '.breadcrumb_toolbar' do
- it 'escapes properly' do
+ describe ".breadcrumb_toolbar" do
+ it "escapes properly" do
result = breadcrumb_toolbar '',
- link_to('foobar', user_path('1234'))
+ link_to("foobar", user_path("1234"))
expect(result).to be_html_eql %{
diff --git a/spec/helpers/types_helper_spec.rb b/spec/helpers/types_helper_spec.rb
index 45b1d3fcc120..4a573aa1c7c2 100644
--- a/spec/helpers/types_helper_spec.rb
+++ b/spec/helpers/types_helper_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe TypesHelper do
let(:type) { build_stubbed(:type) }
@@ -43,17 +43,17 @@
before do
allow(type)
.to receive(:attribute_groups)
- .and_return [Type::AttributeGroup.new(type, 'group one', ["assignee"])]
+ .and_return [Type::AttributeGroup.new(type, "group one", ["assignee"])]
end
- it 'contains Hashes ordered by key :translation' do
+ it "contains Hashes ordered by key :translation" do
# The first left over attribute should currently be "date"
expect(subject.first[:translation]).to be_present
expect(subject.first[:translation] <= subject.second[:translation]).to be_truthy
end
# The "assignee" is in "group one". It should not appear in :inactives.
- it 'does not contain attributes that do not exist anymore' do
+ it "does not contain attributes that do not exist anymore" do
expect(subject.pluck(:key)).not_to include "assignee"
end
end
@@ -64,10 +64,10 @@
before do
allow(type)
.to receive(:attribute_groups)
- .and_return [Type::AttributeGroup.new(type, 'group one', ["date"])]
+ .and_return [Type::AttributeGroup.new(type, "group one", ["date"])]
end
- it 'has a proper structure' do
+ it "has a proper structure" do
# The group's name/key
expect(subject.first[:name]).to eq "group one"
diff --git a/spec/helpers/users_helper_spec.rb b/spec/helpers/users_helper_spec.rb
index c33030d5b18b..c3bbe4c972e5 100644
--- a/spec/helpers/users_helper_spec.rb
+++ b/spec/helpers/users_helper_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe UsersHelper do
def build_user(status, blocked)
@@ -39,20 +39,20 @@ def build_user(status, blocked)
end
end
- describe 'full_user_status' do
+ describe "full_user_status" do
test_cases = {
- [:active, false] => I18n.t('user.active'),
- [:active, true] => I18n.t('user.blocked_num_failed_logins',
+ [:active, false] => I18n.t("user.active"),
+ [:active, true] => I18n.t("user.blocked_num_failed_logins",
count: 3),
- [:locked, false] => I18n.t('user.locked'),
- [:locked, true] => I18n.t('user.status_user_and_brute_force',
- user: I18n.t('user.locked'),
- brute_force: I18n.t('user.blocked_num_failed_logins',
+ [:locked, false] => I18n.t("user.locked"),
+ [:locked, true] => I18n.t("user.status_user_and_brute_force",
+ user: I18n.t("user.locked"),
+ brute_force: I18n.t("user.blocked_num_failed_logins",
count: 3)),
- [:registered, false] => I18n.t('user.registered'),
- [:registered, true] => I18n.t('user.status_user_and_brute_force',
- user: I18n.t('user.registered'),
- brute_force: I18n.t('user.blocked_num_failed_logins',
+ [:registered, false] => I18n.t("user.registered"),
+ [:registered, true] => I18n.t("user.status_user_and_brute_force",
+ user: I18n.t("user.registered"),
+ brute_force: I18n.t("user.blocked_num_failed_logins",
count: 3))
}
@@ -71,7 +71,7 @@ def build_user(status, blocked)
end
end
- describe 'change_user_status_buttons' do
+ describe "change_user_status_buttons" do
test_cases = {
[:active, false] => :lock,
[:locked, false] => :unlock,
@@ -92,61 +92,61 @@ def build_user(status, blocked)
expect(buttons).to include(expectation)
end
- it 'contains a single button' do
- expect(buttons.scan('#{test_project.name} - #{version.name}")
end
- it 'generates a link within a project' do
+ it "generates a link within a project" do
@project = test_project
expect(link_to_version(version))
.to be_html_eql("#{version.name}")
@@ -84,20 +84,20 @@
end
end
- describe '#link_to_version_id' do
- it 'generates an escaped id' do
+ describe "#link_to_version_id" do
+ it "generates an escaped id" do
expect(link_to_version_id(version))
.to eql("version-#{ERB::Util.url_encode(version.name)}")
end
end
end
- describe '#version_options_for_select' do
- it 'generates nothing without a version' do
+ describe "#version_options_for_select" do
+ it "generates nothing without a version" do
expect(version_options_for_select([])).to be_empty
end
- it 'generates an option tag' do
+ it "generates an option tag" do
expect(version_options_for_select([],
version)).to eq("")
end
diff --git a/spec/helpers/wiki_pages/at_version_spec.rb b/spec/helpers/wiki_pages/at_version_spec.rb
index 87fbe1d42c82..4b8eaf1224fa 100644
--- a/spec/helpers/wiki_pages/at_version_spec.rb
+++ b/spec/helpers/wiki_pages/at_version_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WikiPages::AtVersion do
let(:wiki_page) do
@@ -74,435 +74,435 @@
version)
end
- describe '#author' do
- context 'without a version' do
+ describe "#author" do
+ context "without a version" do
let(:version) { nil }
- it 'is the most recent journal`s user' do
+ it "is the most recent journal`s user" do
expect(page_at_version.author)
.to eq second_journal_user
end
end
- context 'with the version set to the first one' do
+ context "with the version set to the first one" do
let(:version) { 1 }
- it 'is the first journal`s user' do
+ it "is the first journal`s user" do
expect(page_at_version.author)
.to eq first_journal_user
end
end
- context 'with the version set to the last one' do
+ context "with the version set to the last one" do
let(:version) { 2 }
- it 'is the last journal`s user' do
+ it "is the last journal`s user" do
expect(page_at_version.author)
.to eq second_journal_user
end
end
- context 'with the version being larger then the current one' do
+ context "with the version being larger then the current one" do
let(:version) { 3 }
- it 'is the last journal`s user' do
+ it "is the last journal`s user" do
expect(page_at_version.author)
.to eq second_journal_user
end
end
- context 'with the version being less then 1' do
+ context "with the version being less then 1" do
let(:version) { 0 }
- it 'is nil' do
+ it "is nil" do
expect(page_at_version.author)
.to be_nil
end
end
- context 'with the version being less then 0' do
+ context "with the version being less then 0" do
let(:version) { -1 }
- it 'is nil' do
+ it "is nil" do
expect(page_at_version.author)
.to be_nil
end
end
end
- describe '#journals' do
- context 'without a version' do
+ describe "#journals" do
+ context "without a version" do
let(:version) { nil }
- it 'is the full set of journals' do
+ it "is the full set of journals" do
expect(page_at_version.journals)
.to contain_exactly(first_journal, second_journal)
end
end
- context 'with the version set to the first one' do
+ context "with the version set to the first one" do
let(:version) { 1 }
- it 'is only the first journal' do
+ it "is only the first journal" do
expect(page_at_version.journals)
.to contain_exactly(first_journal)
end
end
- context 'with the version set to the last one' do
+ context "with the version set to the last one" do
let(:version) { 2 }
- it 'is the full set of journals' do
+ it "is the full set of journals" do
expect(page_at_version.journals)
.to contain_exactly(first_journal, second_journal)
end
end
- context 'with the version being larger then the current one' do
+ context "with the version being larger then the current one" do
let(:version) { 3 }
- it 'is the full set of journals' do
+ it "is the full set of journals" do
expect(page_at_version.journals)
.to contain_exactly(first_journal, second_journal)
end
end
- context 'with the version being less then 1' do
+ context "with the version being less then 1" do
let(:version) { 0 }
- it 'is empty' do
+ it "is empty" do
expect(page_at_version.journals)
.to be_empty
end
end
end
- describe '#lock_version' do
- context 'without a version' do
+ describe "#lock_version" do
+ context "without a version" do
let(:version) { nil }
- it 'is the page`s lock_version' do
+ it "is the page`s lock_version" do
expect(page_at_version.lock_version)
.to eq wiki_page.lock_version
end
end
- context 'with the version set to the first one' do
+ context "with the version set to the first one" do
let(:version) { 1 }
- it 'is the page`s lock_version' do
+ it "is the page`s lock_version" do
expect(page_at_version.lock_version)
.to eq wiki_page.lock_version
end
end
- context 'with the version set to the last one' do
+ context "with the version set to the last one" do
let(:version) { 2 }
- it 'is the page`s lock_version' do
+ it "is the page`s lock_version" do
expect(page_at_version.lock_version)
.to eq wiki_page.lock_version
end
end
- context 'with the version being larger then the current one' do
+ context "with the version being larger then the current one" do
let(:version) { 3 }
- it 'is the page`s lock_version' do
+ it "is the page`s lock_version" do
expect(page_at_version.lock_version)
.to eq wiki_page.lock_version
end
end
- context 'with the version being less then 1' do
+ context "with the version being less then 1" do
let(:version) { 0 }
- it 'is the page`s lock_version' do
+ it "is the page`s lock_version" do
expect(page_at_version.lock_version)
.to eq wiki_page.lock_version
end
end
end
- describe '#updated_at' do
- context 'without a version' do
+ describe "#updated_at" do
+ context "without a version" do
let(:version) { nil }
- it 'is the last journals`s updated_at' do
+ it "is the last journals`s updated_at" do
expect(page_at_version.updated_at)
.to eq second_journal.updated_at
end
end
- context 'with the version set to the first one' do
+ context "with the version set to the first one" do
let(:version) { 1 }
- it 'is the first journals`s updated_at' do
+ it "is the first journals`s updated_at" do
expect(page_at_version.updated_at)
.to eq first_journal.updated_at
end
end
- context 'with the version set to the last one' do
+ context "with the version set to the last one" do
let(:version) { 2 }
- it 'is the last journals`s updated_at' do
+ it "is the last journals`s updated_at" do
expect(page_at_version.updated_at)
.to eq second_journal.updated_at
end
end
- context 'with the version being larger then the current one' do
+ context "with the version being larger then the current one" do
let(:version) { 3 }
- it 'is the last journals`s updated_at' do
+ it "is the last journals`s updated_at" do
expect(page_at_version.updated_at)
.to eq second_journal.updated_at
end
end
- context 'with the version being less then 1' do
+ context "with the version being less then 1" do
let(:version) { 0 }
- it 'is nil' do
+ it "is nil" do
expect(page_at_version.updated_at)
.to be_nil
end
end
end
- describe '#version' do
- context 'without a version' do
+ describe "#version" do
+ context "without a version" do
let(:version) { nil }
- it 'is the wiki_page`s version' do
+ it "is the wiki_page`s version" do
expect(page_at_version.version)
.to eq wiki_page.version
end
end
- context 'with the version provided' do
+ context "with the version provided" do
let(:version) { 1 }
- it 'is the provided version' do
+ it "is the provided version" do
expect(page_at_version.version)
.to eq version
end
end
- context 'with the version being larger then the current one' do
+ context "with the version being larger then the current one" do
let(:version) { 3 }
- it 'is the highest possible version' do
+ it "is the highest possible version" do
expect(page_at_version.version)
.to eq 2
end
end
- context 'with the version being 0' do
+ context "with the version being 0" do
let(:version) { 0 }
- it 'is 0' do
+ it "is 0" do
expect(page_at_version.version)
.to eq 0
end
end
- context 'with the version being less then 0' do
+ context "with the version being less then 0" do
let(:version) { -1 }
- it 'is 0' do
+ it "is 0" do
expect(page_at_version.version)
.to eq 0
end
end
end
- describe '#latest_version' do
- context 'without a version' do
+ describe "#latest_version" do
+ context "without a version" do
let(:version) { nil }
- it 'is the wiki_page`s version' do
+ it "is the wiki_page`s version" do
expect(page_at_version.latest_version)
.to eq wiki_page.version
end
end
- context 'with the version provided' do
+ context "with the version provided" do
let(:version) { 1 }
- it 'is the wiki_page`s version' do
+ it "is the wiki_page`s version" do
expect(page_at_version.latest_version)
.to eq wiki_page.version
end
end
end
- describe '#text' do
- context 'without a version' do
+ describe "#text" do
+ context "without a version" do
let(:version) { nil }
- it 'is the last journals`s version' do
+ it "is the last journals`s version" do
expect(page_at_version.text)
.to eq second_journal_text
end
end
- context 'with the version set to the first one' do
+ context "with the version set to the first one" do
let(:version) { 1 }
- it 'is the first journals`s text' do
+ it "is the first journals`s text" do
expect(page_at_version.text)
.to eq first_journal_text
end
end
- context 'with the version set to the last one' do
+ context "with the version set to the last one" do
let(:version) { 2 }
- it 'is the last journals`s text' do
+ it "is the last journals`s text" do
expect(page_at_version.text)
.to eq second_journal_text
end
end
- context 'with the version being larger then the current one' do
+ context "with the version being larger then the current one" do
let(:version) { 3 }
- it 'is the last journals`s text' do
+ it "is the last journals`s text" do
expect(page_at_version.text)
.to eq second_journal_text
end
end
- context 'with the version being less then 1' do
+ context "with the version being less then 1" do
let(:version) { 0 }
- it 'is the wiki pages`s text' do
+ it "is the wiki pages`s text" do
expect(page_at_version.text)
.to eq wiki_page.text
end
end
end
- describe '#readonly?' do
- context 'without a version' do
+ describe "#readonly?" do
+ context "without a version" do
let(:version) { nil }
- it 'is false' do
+ it "is false" do
expect(page_at_version)
.not_to be_readonly
end
end
- context 'with the version set to the first one' do
+ context "with the version set to the first one" do
let(:version) { 1 }
- it 'is true' do
+ it "is true" do
expect(page_at_version)
.to be_readonly
end
end
- context 'with the version set to the last one' do
+ context "with the version set to the last one" do
let(:version) { 2 }
- it 'is false' do
+ it "is false" do
expect(page_at_version)
.not_to be_readonly
end
end
- context 'with the version being larger then the current one' do
+ context "with the version being larger then the current one" do
let(:version) { 3 }
- it 'is false' do
+ it "is false" do
expect(page_at_version)
.not_to be_readonly
end
end
- context 'with the version being less then 1' do
+ context "with the version being less then 1" do
let(:version) { 0 }
- it 'is true' do
+ it "is true" do
expect(page_at_version)
.to be_readonly
end
end
end
- describe '#current_version?' do
- context 'without a version' do
+ describe "#current_version?" do
+ context "without a version" do
let(:version) { nil }
- it 'is true' do
+ it "is true" do
expect(page_at_version)
.to be_current_version
end
end
- context 'with the version set to the first one' do
+ context "with the version set to the first one" do
let(:version) { 1 }
- it 'is true' do
+ it "is true" do
expect(page_at_version)
.not_to be_current_version
end
end
- context 'with the version set to the last one' do
+ context "with the version set to the last one" do
let(:version) { 2 }
- it 'is true' do
+ it "is true" do
expect(page_at_version)
.to be_current_version
end
end
- context 'with the version being larger then the current one' do
+ context "with the version being larger then the current one" do
let(:version) { 3 }
- it 'is true' do
+ it "is true" do
expect(page_at_version)
.to be_current_version
end
end
- context 'with the version being less then 1' do
+ context "with the version being less then 1" do
let(:version) { 0 }
- it 'is true' do
+ it "is true" do
expect(page_at_version)
.not_to be_current_version
end
end
end
- describe '#object' do
- context 'without a version' do
+ describe "#object" do
+ context "without a version" do
let(:version) { nil }
- it 'returns the wiki page' do
+ it "returns the wiki page" do
expect(page_at_version.object)
.to eq wiki_page
end
end
- context 'with a version' do
+ context "with a version" do
let(:version) { 1 }
- it 'returns the wiki page' do
+ it "returns the wiki page" do
expect(page_at_version.object)
.to eq wiki_page
end
end
end
- describe '#respond_to?' do
+ describe "#respond_to?" do
let(:version) { 1 }
- it 'returns false for #to_model' do
+ it "returns false for #to_model" do
expect(page_at_version)
.not_to respond_to(:to_model)
end
diff --git a/spec/helpers/work_packages_helper_spec.rb b/spec/helpers/work_packages_helper_spec.rb
index d663053f31ec..13cf3d236110 100644
--- a/spec/helpers/work_packages_helper_spec.rb
+++ b/spec/helpers/work_packages_helper_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe WorkPackagesHelper do
let(:stub_work_package) { build_stubbed(:work_package, type: stub_type) }
@@ -36,40 +36,40 @@
let(:open_status) { build_stubbed(:status, is_closed: false) }
let(:closed_status) { build_stubbed(:status, is_closed: true) }
- describe '#link_to_work_package' do
+ describe "#link_to_work_package" do
before do
stub_work_package.status = open_status
end
- describe 'without parameters' do
- it 'returns a link to the work package with type and id as the text if type is set' do
+ describe "without parameters" do
+ it "returns a link to the work package with type and id as the text if type is set" do
link_text = Regexp.new("^#{stub_type.name} ##{stub_work_package.id}$")
expect(helper.link_to_work_package(stub_work_package)).to have_css(
"a[href='#{work_package_path(stub_work_package)}']", text: link_text
)
end
- it 'additionally returns the subject' do
+ it "additionally returns the subject" do
text = Regexp.new("#{stub_work_package.subject}$")
expect(helper.link_to_work_package(stub_work_package)).to have_text(text)
end
- it 'prepends an invisible closed information if the work package is closed' do
+ it "prepends an invisible closed information if the work package is closed" do
stub_work_package.status = closed_status
- expect(helper.link_to_work_package(stub_work_package)).to have_css('a span.hidden-for-sighted', text: 'closed')
+ expect(helper.link_to_work_package(stub_work_package)).to have_css("a span.hidden-for-sighted", text: "closed")
end
- it 'omits the invisible closed information if told so even though the work package is closed' do
+ it "omits the invisible closed information if told so even though the work package is closed" do
stub_work_package.status = closed_status
expect(helper.link_to_work_package(stub_work_package, no_hidden: true))
- .to have_no_css('a span.hidden-for-sighted', text: 'closed')
+ .to have_no_css("a span.hidden-for-sighted", text: "closed")
end
end
- describe 'with the all_link option provided' do
- it 'returns a link to the work package with the type, id, and subject as the text' do
+ describe "with the all_link option provided" do
+ it "returns a link to the work package with the type, id, and subject as the text" do
link_text = Regexp.new("^#{stub_type} ##{stub_work_package.id}: #{stub_work_package.subject}$")
expect(helper.link_to_work_package(stub_work_package,
all_link: true)).to have_css(
@@ -78,30 +78,30 @@
end
end
- describe 'when truncating' do
- it 'truncates the subject if the subject is longer than the specified amount' do
- stub_work_package.subject = '12345678'
+ describe "when truncating" do
+ it "truncates the subject if the subject is longer than the specified amount" do
+ stub_work_package.subject = "12345678"
- text = Regexp.new('1234...$')
+ text = Regexp.new("1234...$")
expect(helper.link_to_work_package(stub_work_package, truncate: 7)).to have_text(text)
end
- it 'does not truncate the subject if the subject is shorter than the specified amount' do
- stub_work_package.subject = '1234567'
+ it "does not truncate the subject if the subject is shorter than the specified amount" do
+ stub_work_package.subject = "1234567"
- text = Regexp.new('1234567$')
+ text = Regexp.new("1234567$")
expect(helper.link_to_work_package(stub_work_package, truncate: 7)).to have_text(text)
end
end
- describe 'when omitting the subject' do
- it 'omits the subject' do
+ describe "when omitting the subject" do
+ it "omits the subject" do
expect(helper.link_to_work_package(stub_work_package, subject: false)).to have_no_text(stub_work_package.subject)
end
end
- describe 'when omitting the type' do
- it 'omits the type' do
+ describe "when omitting the type" do
+ it "omits the type" do
link_text = Regexp.new("^##{stub_work_package.id}$")
expect(helper.link_to_work_package(stub_work_package,
type: false)).to have_css("a[href='#{work_package_path(stub_work_package)}']",
@@ -109,37 +109,37 @@
end
end
- describe 'with a project' do
+ describe "with a project" do
let(:text) { Regexp.new("^#{stub_project.name} -") }
before do
stub_work_package.project = stub_project
end
- it 'prepends the project if parameter set to true' do
+ it "prepends the project if parameter set to true" do
expect(helper.link_to_work_package(stub_work_package, project: true)).to have_text(text)
end
- it 'does not include the project name if the parameter is missing/false' do
+ it "does not include the project name if the parameter is missing/false" do
expect(helper.link_to_work_package(stub_work_package)).to have_no_text(text)
end
end
- describe 'when only wanting the id' do
- it 'returns a link with the id as text only' do
+ describe "when only wanting the id" do
+ it "returns a link with the id as text only" do
link_text = Regexp.new("^##{stub_work_package.id}$")
expect(helper.link_to_work_package(stub_work_package,
id_only: true)).to have_css("a[href='#{work_package_path(stub_work_package)}']",
text: link_text)
end
- it 'does not have the subject as text' do
+ it "does not have the subject as text" do
expect(helper.link_to_work_package(stub_work_package, id_only: true)).to have_no_text(stub_work_package.subject)
end
end
- describe 'when only wanting the subject' do
- it 'returns a link with the subject as text' do
+ describe "when only wanting the subject" do
+ it "returns a link with the subject as text" do
link_text = Regexp.new("^#{stub_work_package.subject}$")
expect(helper.link_to_work_package(stub_work_package,
subject_only: true)).to have_css(
@@ -148,8 +148,8 @@
end
end
- describe 'with the status displayed' do
- it 'returns a link with the status name contained in the text' do
+ describe "with the status displayed" do
+ it "returns a link with the status name contained in the text" do
link_text = Regexp.new("^#{stub_type.name} ##{stub_work_package.id} #{stub_work_package.status}$")
expect(helper.link_to_work_package(stub_work_package,
status: true)).to have_css("a[href='#{work_package_path(stub_work_package)}']",
@@ -158,7 +158,7 @@
end
end
- describe '#work_package_css_classes' do
+ describe "#work_package_css_classes" do
let(:statuses) { (1..5).map { |_i| build_stubbed(:status) } }
let(:priority) { build_stubbed(:priority, is_default: true) }
let(:status) { statuses[0] }
@@ -168,142 +168,142 @@
priority:)
end
- it 'always has the work_package class' do
- expect(helper.work_package_css_classes(stub_work_package)).to include('work_package')
+ it "always has the work_package class" do
+ expect(helper.work_package_css_classes(stub_work_package)).to include("work_package")
end
it "returns the position of the work_package's status" do
stub_work_package.status = open_status
allow(open_status).to receive(:position).and_return(5)
- expect(helper.work_package_css_classes(stub_work_package)).to include('status-5')
+ expect(helper.work_package_css_classes(stub_work_package)).to include("status-5")
end
it "returns the position of the work_package's priority" do
allow(priority).to receive(:position).and_return(5)
- expect(helper.work_package_css_classes(stub_work_package)).to include('priority-5')
+ expect(helper.work_package_css_classes(stub_work_package)).to include("priority-5")
end
- it 'has a closed class if the work_package is closed' do
+ it "has a closed class if the work_package is closed" do
allow(stub_work_package).to receive(:closed?).and_return(true)
- expect(helper.work_package_css_classes(stub_work_package)).to include('closed')
+ expect(helper.work_package_css_classes(stub_work_package)).to include("closed")
end
- it 'has no closed class if the work_package is not closed' do
+ it "has no closed class if the work_package is not closed" do
allow(stub_work_package).to receive(:closed?).and_return(false)
- expect(helper.work_package_css_classes(stub_work_package)).not_to include('closed')
+ expect(helper.work_package_css_classes(stub_work_package)).not_to include("closed")
end
- it 'has an overdue class if the work_package is overdue' do
+ it "has an overdue class if the work_package is overdue" do
allow(stub_work_package).to receive(:overdue?).and_return(true)
- expect(helper.work_package_css_classes(stub_work_package)).to include('overdue')
+ expect(helper.work_package_css_classes(stub_work_package)).to include("overdue")
end
- it 'has an overdue class if the work_package is not overdue' do
+ it "has an overdue class if the work_package is not overdue" do
allow(stub_work_package).to receive(:overdue?).and_return(false)
- expect(helper.work_package_css_classes(stub_work_package)).not_to include('overdue')
+ expect(helper.work_package_css_classes(stub_work_package)).not_to include("overdue")
end
- it 'has a child class if the work_package is a child' do
+ it "has a child class if the work_package is a child" do
allow(stub_work_package).to receive(:child?).and_return(true)
- expect(helper.work_package_css_classes(stub_work_package)).to include('child')
+ expect(helper.work_package_css_classes(stub_work_package)).to include("child")
end
- it 'has no child class if the work_package is not a child' do
+ it "has no child class if the work_package is not a child" do
allow(stub_work_package).to receive(:child?).and_return(false)
- expect(helper.work_package_css_classes(stub_work_package)).not_to include('child')
+ expect(helper.work_package_css_classes(stub_work_package)).not_to include("child")
end
- it 'has a parent class if the work_package is a parent' do
+ it "has a parent class if the work_package is a parent" do
allow(stub_work_package).to receive(:leaf?).and_return(false)
- expect(helper.work_package_css_classes(stub_work_package)).to include('parent')
+ expect(helper.work_package_css_classes(stub_work_package)).to include("parent")
end
- it 'has no parent class if the work_package is not a parent' do
+ it "has no parent class if the work_package is not a parent" do
allow(stub_work_package).to receive(:leaf?).and_return(true)
- expect(helper.work_package_css_classes(stub_work_package)).not_to include('parent')
+ expect(helper.work_package_css_classes(stub_work_package)).not_to include("parent")
end
- it 'has a created-by-me class if the work_package is a created by the current user' do
- stub_user = double('user', logged?: true, id: 5)
+ it "has a created-by-me class if the work_package is a created by the current user" do
+ stub_user = double("user", logged?: true, id: 5)
allow(User).to receive(:current).and_return(stub_user)
allow(stub_work_package).to receive(:author_id).and_return(5)
- expect(helper.work_package_css_classes(stub_work_package)).to include('created-by-me')
+ expect(helper.work_package_css_classes(stub_work_package)).to include("created-by-me")
end
- it 'has no created-by-me class if the work_package is not created by the current user' do
- stub_user = double('user', logged?: true, id: 5)
+ it "has no created-by-me class if the work_package is not created by the current user" do
+ stub_user = double("user", logged?: true, id: 5)
allow(User).to receive(:current).and_return(stub_user)
allow(stub_work_package).to receive(:author_id).and_return(4)
- expect(helper.work_package_css_classes(stub_work_package)).not_to include('created-by-me')
+ expect(helper.work_package_css_classes(stub_work_package)).not_to include("created-by-me")
end
- it 'has a created-by-me class if the work_package is the current user is not logged in' do
- expect(helper.work_package_css_classes(stub_work_package)).not_to include('created-by-me')
+ it "has a created-by-me class if the work_package is the current user is not logged in" do
+ expect(helper.work_package_css_classes(stub_work_package)).not_to include("created-by-me")
end
- it 'has a assigned-to-me class if the work_package is a created by the current user' do
- stub_user = double('user', logged?: true, id: 5)
+ it "has a assigned-to-me class if the work_package is a created by the current user" do
+ stub_user = double("user", logged?: true, id: 5)
allow(User).to receive(:current).and_return(stub_user)
allow(stub_work_package).to receive(:assigned_to_id).and_return(5)
- expect(helper.work_package_css_classes(stub_work_package)).to include('assigned-to-me')
+ expect(helper.work_package_css_classes(stub_work_package)).to include("assigned-to-me")
end
- it 'has no assigned-to-me class if the work_package is not created by the current user' do
- stub_user = double('user', logged?: true, id: 5)
+ it "has no assigned-to-me class if the work_package is not created by the current user" do
+ stub_user = double("user", logged?: true, id: 5)
allow(User).to receive(:current).and_return(stub_user)
allow(stub_work_package).to receive(:assigned_to_id).and_return(4)
- expect(helper.work_package_css_classes(stub_work_package)).not_to include('assigned-to-me')
+ expect(helper.work_package_css_classes(stub_work_package)).not_to include("assigned-to-me")
end
- it 'has no assigned-to-me class if the work_package is the current user is not logged in' do
- expect(helper.work_package_css_classes(stub_work_package)).not_to include('assigned-to-me')
+ it "has no assigned-to-me class if the work_package is the current user is not logged in" do
+ expect(helper.work_package_css_classes(stub_work_package)).not_to include("assigned-to-me")
end
end
- describe '#work_packages_columns_options' do
- it 'returns the columns options' do
+ describe "#work_packages_columns_options" do
+ it "returns the columns options" do
expect(helper.work_packages_columns_options)
.to include(
- { name: 'Type', id: 'type' },
- { name: 'Subject', id: 'subject' },
- { name: 'Status', id: 'status' }
+ { name: "Type", id: "type" },
+ { name: "Subject", id: "subject" },
+ { name: "Status", id: "status" }
)
end
end
- describe '#selected_project_columns_options',
+ describe "#selected_project_columns_options",
with_settings: { work_package_list_default_columns: %w[id subject type status] } do
- it 'returns the columns options currently persisted in the setting (in that order)' do
+ it "returns the columns options currently persisted in the setting (in that order)" do
expect(helper.selected_work_packages_columns_options)
.to eql([
- { name: 'ID', id: 'id' },
- { name: 'Subject', id: 'subject' },
- { name: 'Type', id: 'type' },
- { name: 'Status', id: 'status' }
+ { name: "ID", id: "id" },
+ { name: "Subject", id: "subject" },
+ { name: "Type", id: "type" },
+ { name: "Status", id: "status" }
])
end
end
- describe '#protected_project_columns_options' do
- it 'returns the columns options currently persisted in the setting (in that order)' do
+ describe "#protected_project_columns_options" do
+ it "returns the columns options currently persisted in the setting (in that order)" do
expect(helper.protected_work_packages_columns_options)
.to eql([
- { name: 'ID', id: 'id' },
- { name: 'Subject', id: 'subject' }
+ { name: "ID", id: "id" },
+ { name: "Subject", id: "subject" }
])
end
end
diff --git a/spec/jobs/attachments/virus_rescan_job_spec.rb b/spec/jobs/attachments/virus_rescan_job_spec.rb
index 27bd0c36920f..7d32f941a5d5 100644
--- a/spec/jobs/attachments/virus_rescan_job_spec.rb
+++ b/spec/jobs/attachments/virus_rescan_job_spec.rb
@@ -1,4 +1,4 @@
-require 'rails_helper'
+require "rails_helper"
RSpec.describe Attachments::VirusRescanJob,
with_ee: %i[virus_scanning],
@@ -15,8 +15,8 @@
allow(ClamAV::Client).to receive(:new).and_return(client_double)
end
- describe '#perform' do
- let(:response) { ClamAV::SuccessResponse.new('wat') }
+ describe "#perform" do
+ let(:response) { ClamAV::SuccessResponse.new("wat") }
before do
allow(client_double)
@@ -24,7 +24,7 @@
.and_return(response)
end
- it 'updates the attachments' do
+ it "updates the attachments" do
subject
expect(attachment1.reload).to be_status_uploaded
diff --git a/spec/jobs/attachments/virus_scan_job_spec.rb b/spec/jobs/attachments/virus_scan_job_spec.rb
index 5439ec64275d..ec1584197502 100644
--- a/spec/jobs/attachments/virus_scan_job_spec.rb
+++ b/spec/jobs/attachments/virus_scan_job_spec.rb
@@ -1,4 +1,4 @@
-require 'rails_helper'
+require "rails_helper"
RSpec.describe Attachments::VirusScanJob,
with_ee: %i[virus_scanning],
@@ -14,35 +14,35 @@
allow(ClamAV::Client).to receive(:new).and_return(client_double)
end
- describe '#perform when disabled', with_settings: { antivirus_scan_mode: :disabled } do
- it 'does not scan the attachment' do
+ describe "#perform when disabled", with_settings: { antivirus_scan_mode: :disabled } do
+ it "does not scan the attachment" do
subject
expect(ClamAV::Client).not_to have_received(:new)
end
end
- context 'when status is not uploaded' do
+ context "when status is not uploaded" do
let(:attachment_status) { :prepared }
- it 'does not scan the attachment' do
+ it "does not scan the attachment" do
subject
expect(ClamAV::Client).not_to have_received(:new)
end
end
- describe '#perform' do
+ describe "#perform" do
before do
allow(client_double)
.to receive(:execute).with(instance_of(ClamAV::Commands::InstreamCommand))
.and_return(response)
end
- context 'when no virus is found' do
- let(:response) { ClamAV::SuccessResponse.new('wat') }
+ context "when no virus is found" do
+ let(:response) { ClamAV::SuccessResponse.new("wat") }
- it 'updates the file status' do
+ it "updates the file status" do
allow(attachment).to receive(:update!)
subject
@@ -51,10 +51,10 @@
end
end
- context 'when error occurs in clamav' do
- let(:response) { ClamAV::ErrorResponse.new('Oh noes') }
+ context "when error occurs in clamav" do
+ let(:response) { ClamAV::ErrorResponse.new("Oh noes") }
- it 'does nothing to the file' do
+ it "does nothing to the file" do
allow(attachment).to receive(:update!)
expect { subject }.not_to raise_error
@@ -63,11 +63,11 @@
end
end
- context 'when virus is found' do
- let(:response) { ClamAV::VirusResponse.new('wat', 'Eicar-Test-Signature') }
+ context "when virus is found" do
+ let(:response) { ClamAV::VirusResponse.new("wat", "Eicar-Test-Signature") }
- context 'when action is quarantine', with_settings: { antivirus_scan_action: :quarantine } do
- it 'quarantines the file' do
+ context "when action is quarantine", with_settings: { antivirus_scan_action: :quarantine } do
+ it "quarantines the file" do
allow(attachment).to receive(:update!)
allow(Journals::CreateService).to receive(:new).and_return(journal_service_double)
allow(journal_service_double).to receive(:call)
@@ -80,8 +80,8 @@
end
end
- context 'when action is delete', with_settings: { antivirus_scan_action: :delete } do
- it 'deletes the file' do
+ context "when action is delete", with_settings: { antivirus_scan_action: :delete } do
+ it "deletes the file" do
allow(attachment).to receive(:destroy!)
allow(Journals::CreateService).to receive(:new).and_return(journal_service_double)
allow(journal_service_double).to receive(:call)
diff --git a/spec/lib/acts_as_journalized/journable_differ_spec.rb b/spec/lib/acts_as_journalized/journable_differ_spec.rb
index fb93bb9d6a98..f1572ee21b8f 100644
--- a/spec/lib/acts_as_journalized/journable_differ_spec.rb
+++ b/spec/lib/acts_as_journalized/journable_differ_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe Acts::Journalized::JournableDiffer do
- describe '.changes' do
- context 'when the objects are work packages' do
+ describe ".changes" do
+ context "when the objects are work packages" do
let(:original) do
build_stubbed(:work_package,
- subject: 'The original work package title',
+ subject: "The original work package title",
description: "The description\n",
assigned_to_id: nil,
schedule_manually: false,
@@ -42,7 +42,7 @@
end
let(:changed) do
build_stubbed(:work_package,
- subject: 'The changed work package title',
+ subject: "The changed work package title",
description: "The description\r\n",
priority: original.priority,
type: original.type,
@@ -52,7 +52,7 @@
estimated_hours: nil)
end
- it 'returns the changes' do
+ it "returns the changes" do
expect(described_class.changes(original, changed))
.to eql("subject" => [original.subject, changed.subject],
"author_id" => [original.author_id, changed.author_id],
@@ -63,10 +63,10 @@
end
end
- context 'when the objects are WorkPackageJournal' do
+ context "when the objects are WorkPackageJournal" do
let(:original) do
build_stubbed(:journal_work_package_journal,
- subject: 'The original work package title',
+ subject: "The original work package title",
description: nil,
priority_id: 5,
type_id: 89,
@@ -78,8 +78,8 @@
end
let(:changed) do
build_stubbed(:journal_work_package_journal,
- subject: 'The changed work package title',
- description: '',
+ subject: "The changed work package title",
+ description: "",
priority_id: original.priority_id,
type_id: original.type_id,
project_id: original.project_id,
@@ -89,7 +89,7 @@
estimated_hours: 1)
end
- it 'returns the changes' do
+ it "returns the changes" do
# The description field changes from nil to '', but we want filter those transitions out,
# hence the expected hash does not contain the description related change.
expect(described_class.changes(original, changed))
@@ -102,8 +102,8 @@
end
end
- describe '.association_changes' do
- context 'when the objects are work packages' do
+ describe ".association_changes" do
+ context "when the objects are work packages" do
let(:original) do
build(:work_package,
custom_values: [
@@ -122,8 +122,8 @@
])
end
- it 'returns the changes' do
- params = [original, changed, 'custom_values', 'custom_field', :custom_field_id, :value]
+ it "returns the changes" do
+ params = [original, changed, "custom_values", "custom_field", :custom_field_id, :value]
expect(described_class.association_changes(*params))
.to eql(
"custom_field_1" => ["1", ""],
diff --git a/spec/lib/acts_as_journalized/journal_formatter_cache_spec.rb b/spec/lib/acts_as_journalized/journal_formatter_cache_spec.rb
index 3bb168d06d35..3b4ea91e01cd 100644
--- a/spec/lib/acts_as_journalized/journal_formatter_cache_spec.rb
+++ b/spec/lib/acts_as_journalized/journal_formatter_cache_spec.rb
@@ -26,33 +26,33 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe JournalFormatterCache do
subject(:cache) { described_class.new }
- describe '#fetch' do
- it 'caches and returns the value returned by the block on cache miss' do
- expect(cache.fetch(User, 3) { 'user_3' }).to eq('user_3')
- expect(cache.fetch('Answer', 42) { 'Life Universe Everything' }).to eq('Life Universe Everything')
+ describe "#fetch" do
+ it "caches and returns the value returned by the block on cache miss" do
+ expect(cache.fetch(User, 3) { "user_3" }).to eq("user_3")
+ expect(cache.fetch("Answer", 42) { "Life Universe Everything" }).to eq("Life Universe Everything")
end
- it 'returns nil on cache miss if no block is given' do
+ it "returns nil on cache miss if no block is given" do
expect(cache.fetch(User, 3)).to be_nil
expect(cache.fetch(User, 17)).to be_nil
end
- it 'returns the cached value on cache hit' do
- cache.fetch(User, 3) { 'user_3' }
+ it "returns the cached value on cache hit" do
+ cache.fetch(User, 3) { "user_3" }
- expect(cache.fetch(User, 3)).to eq('user_3')
- expect(cache.fetch(User, 3) { 'another value' }).to eq('user_3')
+ expect(cache.fetch(User, 3)).to eq("user_3")
+ expect(cache.fetch(User, 3) { "another value" }).to eq("user_3")
expect(cache.fetch(Project, 62)).to be_nil
- cache.fetch(Project, 62) { 'project_62' }
- expect(cache.fetch(Project, 62)).to eq('project_62')
- cache.fetch(Project, 62) { 'another value' }
- expect(cache.fetch(Project, 62)).to eq('project_62')
+ cache.fetch(Project, 62) { "project_62" }
+ expect(cache.fetch(Project, 62)).to eq("project_62")
+ cache.fetch(Project, 62) { "another value" }
+ expect(cache.fetch(Project, 62)).to eq("project_62")
end
end
end
diff --git a/spec/lib/acts_as_journalized/journaled_spec.rb b/spec/lib/acts_as_journalized/journaled_spec.rb
index 60ec4f5d07a9..c25d902ea64d 100644
--- a/spec/lib/acts_as_journalized/journaled_spec.rb
+++ b/spec/lib/acts_as_journalized/journaled_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Journalized Objects' do
- describe 'journal_editable_by?' do
- context 'when the journable is a work package' do
+RSpec.describe "Journalized Objects" do
+ describe "journal_editable_by?" do
+ context "when the journable is a work package" do
let!(:user) { create(:user, member_with_permissions: { project => [] }) }
let!(:project) { create(:project_with_types) }
let!(:work_package) do
@@ -38,7 +38,7 @@
type: project.types.first,
author: user,
project:,
- description: '')
+ description: "")
end
subject { work_package.journal_editable_by?(work_package.journals.first, user) }
diff --git a/spec/lib/acts_as_list/acts_as_list_patch_spec.rb b/spec/lib/acts_as_list/acts_as_list_patch_spec.rb
index 48b4b9e942e4..64cccc59b4ac 100644
--- a/spec/lib/acts_as_list/acts_as_list_patch_spec.rb
+++ b/spec/lib/acts_as_list/acts_as_list_patch_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe 'Models acting as list (acts_as_list)' do
- it 'includes the patch' do
+RSpec.describe "Models acting as list (acts_as_list)" do
+ it "includes the patch" do
expect(ActiveRecord::Acts::List::InstanceMethods.included_modules).to include(OpenProject::Patches::ActsAsList)
end
- describe '#move_to=' do
+ describe "#move_to=" do
let(:includer) do
class ActsAsListPatchIncluder
include OpenProject::Patches::ActsAsList
@@ -42,28 +42,28 @@ class ActsAsListPatchIncluder
ActsAsListPatchIncluder.new
end
- it 'moves to top when wanting to move highest' do
+ it "moves to top when wanting to move highest" do
expect(includer).to receive :move_to_top
- includer.move_to = 'highest'
+ includer.move_to = "highest"
end
- it 'moves to bottom when wanting to move lowest' do
+ it "moves to bottom when wanting to move lowest" do
expect(includer).to receive :move_to_bottom
- includer.move_to = 'lowest'
+ includer.move_to = "lowest"
end
- it 'moves higher when wanting to move higher' do
+ it "moves higher when wanting to move higher" do
expect(includer).to receive :move_higher
- includer.move_to = 'higher'
+ includer.move_to = "higher"
end
- it 'moves lower when wanting to move lower' do
+ it "moves lower when wanting to move lower" do
expect(includer).to receive :move_lower
- includer.move_to = 'lower'
+ includer.move_to = "lower"
end
end
end
diff --git a/spec/lib/acts_as_watchable/lib/acts_as_watchable/routes_spec.rb b/spec/lib/acts_as_watchable/lib/acts_as_watchable/routes_spec.rb
index a831a7cb2303..c089a1b3be9c 100644
--- a/spec/lib/acts_as_watchable/lib/acts_as_watchable/routes_spec.rb
+++ b/spec/lib/acts_as_watchable/lib/acts_as_watchable/routes_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::Acts::Watchable::Routes do
let(:request) do
@@ -37,38 +37,38 @@ def path_parameters
end.new(type, id)
end
- describe 'matches?' do
- shared_examples_for 'watched model' do
- describe 'for a valid id string' do
- let(:id) { '1' }
+ describe "matches?" do
+ shared_examples_for "watched model" do
+ describe "for a valid id string" do
+ let(:id) { "1" }
- it 'is true' do
+ it "is true" do
expect(OpenProject::Acts::Watchable::Routes.matches?(request)).to be_truthy
end
end
- describe 'for an invalid id string' do
- let(:id) { 'schmu' }
+ describe "for an invalid id string" do
+ let(:id) { "schmu" }
- it 'is false' do
+ it "is false" do
expect(OpenProject::Acts::Watchable::Routes.matches?(request)).to be_falsey
end
end
end
- ['work_packages', 'news', 'forums', 'messages', 'wikis', 'wiki_pages'].each do |type|
+ ["work_packages", "news", "forums", "messages", "wikis", "wiki_pages"].each do |type|
describe "routing #{type} watches" do
let(:type) { type }
- it_behaves_like 'watched model'
+ it_behaves_like "watched model"
end
end
- describe 'for a non watched model' do
- let(:type) { 'schmu' }
- let(:id) { '4' }
+ describe "for a non watched model" do
+ let(:type) { "schmu" }
+ let(:id) { "4" }
- it 'is false' do
+ it "is false" do
expect(OpenProject::Acts::Watchable::Routes.matches?(request)).to be_falsey
end
end
diff --git a/spec/lib/api/contracts/model_contract_spec.rb b/spec/lib/api/contracts/model_contract_spec.rb
index 5fb6e803b5ef..7b7e165e8854 100644
--- a/spec/lib/api/contracts/model_contract_spec.rb
+++ b/spec/lib/api/contracts/model_contract_spec.rb
@@ -25,11 +25,11 @@
#
# See COPYRIGHT and LICENSE files for more details.
-require 'spec_helper'
+require "spec_helper"
RSpec.describe ModelContract do
let(:model) do
- double('The model',
+ double("The model",
child_attribute: nil,
grand_child_attribute: nil,
overwritten_attribute: nil,
@@ -41,7 +41,7 @@
errors: ActiveModel::Errors.new(nil))
end
- context 'with child and grand_child' do
+ context "with child and grand_child" do
let(:child_contract_class) do
Class.new(ModelContract) do
attr_accessor :child_value
@@ -71,30 +71,30 @@
grand_child_contract.child_value = 0
end
- describe 'child' do
- it 'collects its own writable attributes' do
- expect(child_contract.writable_attributes).to include('child_attribute',
- 'overwritten_attribute')
+ describe "child" do
+ it "collects its own writable attributes" do
+ expect(child_contract.writable_attributes).to include("child_attribute",
+ "overwritten_attribute")
end
- it 'collects its own attribute validations' do
+ it "collects its own attribute validations" do
child_contract.validate
expect(child_contract.child_value).to eq(1)
end
end
- describe 'grand_child' do
- it 'considers its ancestor writable attributes' do
- expect(grand_child_contract.writable_attributes).to include('child_attribute',
- 'overwritten_attribute',
- 'grand_child_attribute')
+ describe "grand_child" do
+ it "considers its ancestor writable attributes" do
+ expect(grand_child_contract.writable_attributes).to include("child_attribute",
+ "overwritten_attribute",
+ "grand_child_attribute")
end
- it 'does not contain the same attribute twice, but also has the _id variant' do
+ it "does not contain the same attribute twice, but also has the _id variant" do
expect(grand_child_contract.writable_attributes.count).to eq(6)
end
- it 'executes all the validations' do
+ it "executes all the validations" do
grand_child_contract.validate
expect(grand_child_contract.child_value).to eq(1)
expect(grand_child_contract.grand_child_value).to eq(2)
@@ -102,7 +102,7 @@
end
end
- describe 'valid?' do
+ describe "valid?" do
let(:model_contract_class) do
Class.new(ModelContract) do
attribute :custom_field1
@@ -111,49 +111,49 @@
end
let(:model_contract) { model_contract_class.new(model, nil) }
- context 'when the model extends no plugins' do
+ context "when the model extends no plugins" do
before do
allow(model).to receive(:changed).and_return([:custom_field1])
end
- it 'adds an error to the custom field attribute' do
+ it "adds an error to the custom field attribute" do
model_contract.valid?
expect(model_contract.errors.symbols_for(:custom_field1))
.to include(:error_readonly)
end
end
- context 'when the model extends the acts_as_customizable plugin' do
+ context "when the model extends the acts_as_customizable plugin" do
before do
allow(model).to receive(:changed_with_custom_fields).and_return([:custom_field1])
end
- it 'adds an error to the custom field attribute' do
+ it "adds an error to the custom field attribute" do
model_contract.valid?
expect(model_contract.errors.symbols_for(:custom_field1))
.to include(:error_readonly)
end
end
- context 'when the model extends the OpenProject::ChangedBySystem module' do
+ context "when the model extends the OpenProject::ChangedBySystem module" do
before do
allow(model).to receive(:changed_by_user).and_return([:custom_field1])
end
- it 'adds an error to the custom field attribute' do
+ it "adds an error to the custom field attribute" do
model_contract.valid?
expect(model_contract.errors.symbols_for(:custom_field1))
.to include(:error_readonly)
end
end
- context 'when the model extends both modules' do
+ context "when the model extends both modules" do
before do
allow(model).to receive(:changed_by_user).and_return([:custom_field1])
allow(model).to receive(:changed_with_custom_fields).and_return([:no_allowed])
end
- it 'adds an error to the custom field attribute from the OpenProject::ChangedBySystem module' do
+ it "adds an error to the custom field attribute from the OpenProject::ChangedBySystem module" do
model_contract.valid?
expect(model_contract.errors.symbols_for(:custom_field1))
.to include(:error_readonly)
diff --git a/spec/lib/api/decorators/aggregation_group_spec.rb b/spec/lib/api/decorators/aggregation_group_spec.rb
index 617d9d628fee..c3fafba02c08 100644
--- a/spec/lib/api/decorators/aggregation_group_spec.rb
+++ b/spec/lib/api/decorators/aggregation_group_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::Decorators::AggregationGroup do
let(:query) do
@@ -35,19 +35,19 @@
query
end
- let(:group_key) { OpenStruct.new name: 'ABC' }
+ let(:group_key) { OpenStruct.new name: "ABC" }
let(:count) { 5 }
let(:current_user) { build_stubbed(:user) }
subject { described_class.new(group_key, count, query:, current_user:).to_json }
- context 'with an empty array key' do
+ context "with an empty array key" do
let(:group_key) { [] }
- it 'has an empty value' do
+ it "has an empty value" do
expect(subject)
.to be_json_eql(nil.to_json)
- .at_path('value')
+ .at_path("value")
end
end
end
diff --git a/spec/lib/api/decorators/formattable_spec.rb b/spec/lib/api/decorators/formattable_spec.rb
index afad398937e5..118df4df5557 100644
--- a/spec/lib/api/decorators/formattable_spec.rb
+++ b/spec/lib/api/decorators/formattable_spec.rb
@@ -26,31 +26,31 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::Decorators::Formattable do
- let(:represented) { 'A **raw** string!' }
+ let(:represented) { "A **raw** string!" }
subject { described_class.new(represented).to_json }
- it 'indicates its format' do
- expect(subject).to be_json_eql('markdown'.to_json).at_path('format')
+ it "indicates its format" do
+ expect(subject).to be_json_eql("markdown".to_json).at_path("format")
end
- it 'contains the raw string' do
- expect(subject).to be_json_eql(represented.to_json).at_path('raw')
+ it "contains the raw string" do
+ expect(subject).to be_json_eql(represented.to_json).at_path("raw")
end
- it 'contains the formatted string' do
- expect(subject).to be_json_eql('
A raw string!
'.to_json).at_path('html')
+ it "contains the formatted string" do
+ expect(subject).to be_json_eql('
A raw string!
'.to_json).at_path("html")
end
- context 'when passing an object context' do
+ context "when passing an object context" do
let(:object) { build_stubbed(:work_package) }
subject { described_class.new(represented, object:) }
- it 'passes that to format_text' do
+ it "passes that to format_text" do
# rubocop:disable RSpec/SubjectStub RSpec/MessageSpies
expect(subject)
.to receive(:format_text).with(anything, format: :markdown, object:)
@@ -58,28 +58,28 @@
# rubocop:enable RSpec/SubjectStub RSpec/MessageSpies
expect(subject.to_json)
- .to be_json_eql('
A raw string!
'.to_json).at_path('html')
+ .to be_json_eql('
A raw string!
'.to_json).at_path("html")
end
end
- context 'when format specified explicitly' do
+ context "when format specified explicitly" do
subject { described_class.new(represented, plain: true).to_json }
- it 'indicates the explicit format' do
- expect(subject).to be_json_eql('plain'.to_json).at_path('format')
+ it "indicates the explicit format" do
+ expect(subject).to be_json_eql("plain".to_json).at_path("format")
end
- it 'formats using the explicit format' do
- expect(subject).to be_json_eql('
A **raw** string!
'.to_json).at_path('html')
+ it "formats using the explicit format" do
+ expect(subject).to be_json_eql("
A **raw** string!
".to_json).at_path("html")
end
end
- context 'when passing a nil object as input' do
+ context "when passing a nil object as input" do
let(:represented) { nil }
- it 'still outputs a string as per the specification' do
- expect(subject).to be_json_eql(''.to_json).at_path('raw')
- expect(subject).to be_json_eql(''.to_json).at_path('html')
+ it "still outputs a string as per the specification" do
+ expect(subject).to be_json_eql("".to_json).at_path("raw")
+ expect(subject).to be_json_eql("".to_json).at_path("html")
end
end
end
diff --git a/spec/lib/api/decorators/link_object_spec.rb b/spec/lib/api/decorators/link_object_spec.rb
index fa891e70ed3f..5851d8bbeea9 100644
--- a/spec/lib/api/decorators/link_object_spec.rb
+++ b/spec/lib/api/decorators/link_object_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::Decorators::LinkObject do
include API::V3::Utilities::PathHelper
let(:represented) { API::ParserStruct.new }
- context 'minimal constructor call' do
+ context "minimal constructor call" do
let(:representer) { described_class.new(represented, property_name: :foo) }
before do
@@ -41,34 +41,34 @@
allow(api_v3_paths).to receive(:foo) { |id| "/api/v3/foos/#{id}" }
end
- describe 'generation' do
+ describe "generation" do
subject { representer.to_json }
- it { is_expected.to be_json_eql('/api/v3/foos/1'.to_json).at_path('href') }
+ it { is_expected.to be_json_eql("/api/v3/foos/1".to_json).at_path("href") }
end
- describe 'parsing' do
+ describe "parsing" do
subject { represented }
let(:parsed_hash) do
{
- 'href' => '/api/v3/foos/42'
+ "href" => "/api/v3/foos/42"
}
end
- it 'parses the id from the URL' do
+ it "parses the id from the URL" do
representer.from_hash parsed_hash
- expect(subject.foo_id).to eql('42')
+ expect(subject.foo_id).to eql("42")
end
- context 'wrong namespace' do
+ context "wrong namespace" do
let(:parsed_hash) do
{
- 'href' => '/api/v3/bars/42'
+ "href" => "/api/v3/bars/42"
}
end
- it 'throws an error' do
+ it "throws an error" do
expect { representer.from_hash parsed_hash }.to raise_error(
API::Errors::InvalidResourceLink
)
@@ -77,14 +77,14 @@
end
end
- context 'full constructor call' do
+ context "full constructor call" do
let(:representer) do
described_class.new(represented,
property_name: :foo,
path: :foo_path,
- namespace: 'fuhs',
+ namespace: "fuhs",
getter: :getter,
- setter: :'setter=')
+ setter: :"setter=")
end
before do
@@ -92,34 +92,34 @@
allow(api_v3_paths).to receive(:foo_path) { |id| "/api/v3/fuhs/#{id}" }
end
- describe 'generation' do
+ describe "generation" do
subject { representer.to_json }
- it { is_expected.to be_json_eql('/api/v3/fuhs/1'.to_json).at_path('href') }
+ it { is_expected.to be_json_eql("/api/v3/fuhs/1".to_json).at_path("href") }
end
- describe 'parsing' do
+ describe "parsing" do
subject { represented }
let(:parsed_hash) do
{
- 'href' => '/api/v3/fuhs/42'
+ "href" => "/api/v3/fuhs/42"
}
end
- it 'parses the id from the URL' do
+ it "parses the id from the URL" do
representer.from_hash parsed_hash
- expect(subject.setter).to eql('42')
+ expect(subject.setter).to eql("42")
end
- context 'wrong namespace' do
+ context "wrong namespace" do
let(:parsed_hash) do
{
- 'href' => '/api/v3/foos/42'
+ "href" => "/api/v3/foos/42"
}
end
- it 'throws an error' do
+ it "throws an error" do
expect { representer.from_hash parsed_hash }.to raise_error(
API::Errors::InvalidResourceLink
)
diff --git a/spec/lib/api/utilities/property_name_converter_spec.rb b/spec/lib/api/utilities/property_name_converter_spec.rb
index a085efdd57ae..62b23e12fbd7 100644
--- a/spec/lib/api/utilities/property_name_converter_spec.rb
+++ b/spec/lib/api/utilities/property_name_converter_spec.rb
@@ -26,160 +26,160 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::Utilities::PropertyNameConverter do
- describe '#from_ar_name' do
+ describe "#from_ar_name" do
let(:attribute_name) { :an_attribute }
subject { described_class.from_ar_name(attribute_name) }
- it 'stringifies attribute names' do
+ it "stringifies attribute names" do
expect(subject).to be_a(String)
end
- it 'camelizes attribute names' do
- expect(subject).to eql('anAttribute')
+ it "camelizes attribute names" do
+ expect(subject).to eql("anAttribute")
end
- context 'foreign keys' do
+ context "foreign keys" do
let(:attribute_name) { :thing_id }
- it 'eliminates the id suffix' do
- expect(subject).to eql('thing')
+ it "eliminates the id suffix" do
+ expect(subject).to eql("thing")
end
end
- context 'custom fields' do
+ context "custom fields" do
let(:attribute_name) { :cf_1337 }
- it 'converts short custom fields to their long form' do
- expect(subject).to eql('customField1337')
+ it "converts short custom fields to their long form" do
+ expect(subject).to eql("customField1337")
end
end
# N.B. not re-iterating all existing known replacements here. Just using a single example
# to verify that it is done at all
- context 'special replacements' do
+ context "special replacements" do
let(:attribute_name) { :assigned_to }
- it 'performs special replacements' do
- expect(subject).to eql('assignee')
+ it "performs special replacements" do
+ expect(subject).to eql("assignee")
end
- context 'foreign keys' do
+ context "foreign keys" do
let(:attribute_name) { :assigned_to_id }
- it 'sanitizes id-suffix before replacement lookup' do
- expect(subject).to eql('assignee')
+ it "sanitizes id-suffix before replacement lookup" do
+ expect(subject).to eql("assignee")
end
end
end
end
- describe '#to_ar_name' do
- let(:attribute_name) { 'anAttribute' }
+ describe "#to_ar_name" do
+ let(:attribute_name) { "anAttribute" }
let(:context) { build_stubbed(:work_package) }
subject { described_class.to_ar_name(attribute_name, context:) }
- it 'snake_cases attribute names' do
- expect(subject).to eql('an_attribute')
+ it "snake_cases attribute names" do
+ expect(subject).to eql("an_attribute")
end
- context 'foreign keys' do
- let(:attribute_name) { 'status' }
+ context "foreign keys" do
+ let(:attribute_name) { "status" }
- it 'does not add an id suffix by default' do
- expect(subject).to eql('status')
+ it "does not add an id suffix by default" do
+ expect(subject).to eql("status")
end
- context 'requesting ids via refer_to_ids' do
+ context "requesting ids via refer_to_ids" do
subject { described_class.to_ar_name(attribute_name, context:, refer_to_ids: true) }
- context 'for keys referring to a belongs_to association' do
- let(:attribute_name) { 'status' }
+ context "for keys referring to a belongs_to association" do
+ let(:attribute_name) { "status" }
- it 'adds an id suffix' do
- expect(subject).to eql('status_id')
+ it "adds an id suffix" do
+ expect(subject).to eql("status_id")
end
end
- context 'for keys referring to a has_many association' do
- let(:attribute_name) { 'watcher' }
+ context "for keys referring to a has_many association" do
+ let(:attribute_name) { "watcher" }
- it 'adds an id suffix' do
- expect(subject).to eql('watcher_ids')
+ it "adds an id suffix" do
+ expect(subject).to eql("watcher_ids")
end
end
- context 'for non-foreign keys' do
- let(:attribute_name) { 'subject' }
+ context "for non-foreign keys" do
+ let(:attribute_name) { "subject" }
- it 'does not add an id suffix' do
- expect(subject).to eql('subject')
+ it "does not add an id suffix" do
+ expect(subject).to eql("subject")
end
end
- context 'does not append an id to pluarlized attributes' do
- let(:attribute_name) { 'estimatedTime' }
+ context "does not append an id to pluarlized attributes" do
+ let(:attribute_name) { "estimatedTime" }
- it 'does not add an id suffix' do
- expect(subject).to eql('estimated_hours')
+ it "does not add an id suffix" do
+ expect(subject).to eql("estimated_hours")
end
end
end
end
- context 'custom fields' do
- let(:attribute_name) { 'customField1337' }
+ context "custom fields" do
+ let(:attribute_name) { "customField1337" }
- it 'converts long custom fields to their short form' do
- expect(subject).to eql('cf_1337')
+ it "converts long custom fields to their short form" do
+ expect(subject).to eql("cf_1337")
end
end
- context 'special replacements' do
- let(:attribute_name) { 'assignee' }
+ context "special replacements" do
+ let(:attribute_name) { "assignee" }
- it 'performs special replacements' do
- expect(subject).to eql('assigned_to')
+ it "performs special replacements" do
+ expect(subject).to eql("assigned_to")
end
- context 'foreign keys' do
- let(:attribute_name) { 'assignee' }
+ context "foreign keys" do
+ let(:attribute_name) { "assignee" }
subject { described_class.to_ar_name(attribute_name, context:, refer_to_ids: true) }
- it 'correctly appends the id suffix' do
- expect(subject).to eql('assigned_to_id')
+ it "correctly appends the id suffix" do
+ expect(subject).to eql("assigned_to_id")
end
end
- context 'inapropriate back-replacement' do
+ context "inapropriate back-replacement" do
# should not be translated back to updated_at, which is transformed for ar->api
- let(:attribute_name) { 'updatedAt' }
+ let(:attribute_name) { "updatedAt" }
- it 'is not performed' do
- expect(subject).to eql('updated_at')
+ it "is not performed" do
+ expect(subject).to eql("updated_at")
end
- context 'in an appropriate context' do
+ context "in an appropriate context" do
let(:context) { build_stubbed(:version) }
- it 'is performed' do
- expect(subject).to eql('updated_at')
+ it "is performed" do
+ expect(subject).to eql("updated_at")
end
end
end
- context 'inappropriate replacement as context does not respond to it with foreign key' do
- let(:attribute_name) { 'type' }
+ context "inappropriate replacement as context does not respond to it with foreign key" do
+ let(:attribute_name) { "type" }
subject { described_class.to_ar_name(attribute_name, context:, refer_to_ids: true) }
- it 'does not take the special replacement but appends the id suffix' do
- expect(subject).to eql('type_id')
+ it "does not take the special replacement but appends the id suffix" do
+ expect(subject).to eql("type_id")
end
end
end
diff --git a/spec/lib/api/utilities/resource_link_parser_spec.rb b/spec/lib/api/utilities/resource_link_parser_spec.rb
index cf7be9705d68..8fc87c3967de 100644
--- a/spec/lib/api/utilities/resource_link_parser_spec.rb
+++ b/spec/lib/api/utilities/resource_link_parser_spec.rb
@@ -26,130 +26,130 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::Utilities::ResourceLinkParser do
subject { described_class }
- describe '#parse' do
- shared_examples_for 'accepts resource link' do
- it 'parses the version' do
+ describe "#parse" do
+ shared_examples_for "accepts resource link" do
+ it "parses the version" do
expect(result[:version]).to eql(version)
end
- it 'parses the namespace' do
+ it "parses the namespace" do
expect(result[:namespace]).to eql(namespace)
end
- it 'parses the id' do
+ it "parses the id" do
expect(result[:id]).to eql(id)
end
end
- shared_examples_for 'rejects resource link' do
- it 'is nil' do
+ shared_examples_for "rejects resource link" do
+ it "is nil" do
expect(result).to be_nil
end
end
- describe 'generic resource links' do
- describe 'accepts a simple resource' do
- it_behaves_like 'accepts resource link' do
- let(:result) { subject.parse '/api/v3/statuses/12' }
- let(:version) { '3' }
- let(:namespace) { 'statuses' }
- let(:id) { '12' }
+ describe "generic resource links" do
+ describe "accepts a simple resource" do
+ it_behaves_like "accepts resource link" do
+ let(:result) { subject.parse "/api/v3/statuses/12" }
+ let(:version) { "3" }
+ let(:namespace) { "statuses" }
+ let(:id) { "12" }
end
end
- describe 'accepts a nested namespace resource' do
- it_behaves_like 'accepts resource link' do
- let(:result) { subject.parse '/api/v3/time_entries/activities/12' }
- let(:version) { '3' }
- let(:namespace) { 'time_entries/activities' }
- let(:id) { '12' }
+ describe "accepts a nested namespace resource" do
+ it_behaves_like "accepts resource link" do
+ let(:result) { subject.parse "/api/v3/time_entries/activities/12" }
+ let(:version) { "3" }
+ let(:namespace) { "time_entries/activities" }
+ let(:id) { "12" }
end
end
- describe 'rejects resources with empty id segment' do
- it_behaves_like 'rejects resource link' do
- let(:result) { subject.parse '/api/v3/statuses/' }
+ describe "rejects resources with empty id segment" do
+ it_behaves_like "rejects resource link" do
+ let(:result) { subject.parse "/api/v3/statuses/" }
end
end
- describe 'rejects resource with missing id segment' do
- it_behaves_like 'rejects resource link' do
- let(:result) { subject.parse '/api/v3/statuses' }
+ describe "rejects resource with missing id segment" do
+ it_behaves_like "rejects resource link" do
+ let(:result) { subject.parse "/api/v3/statuses" }
end
end
- describe 'rejects the api root' do
- it_behaves_like 'rejects resource link' do
- let(:result) { subject.parse '/api/v3/' }
+ describe "rejects the api root" do
+ it_behaves_like "rejects resource link" do
+ let(:result) { subject.parse "/api/v3/" }
end
end
- describe 'rejects nested resources' do
- it_behaves_like 'rejects resource link' do
- let(:result) { subject.parse '/api/v3/statuses/imaginary/' }
+ describe "rejects nested resources" do
+ it_behaves_like "rejects resource link" do
+ let(:result) { subject.parse "/api/v3/statuses/imaginary/" }
end
end
end
end
- describe '#parse_id' do
- it 'parses the id' do
- expect(subject.parse_id('/api/v3/statuses/14', property: 'foo')).to eql('14')
+ describe "#parse_id" do
+ it "parses the id" do
+ expect(subject.parse_id("/api/v3/statuses/14", property: "foo")).to eql("14")
end
- it 'parses the id with nested namespace' do
- expect(subject.parse_id('/api/v3/statuses/nested/14', property: 'foo')).to eql('14')
+ it "parses the id with nested namespace" do
+ expect(subject.parse_id("/api/v3/statuses/nested/14", property: "foo")).to eql("14")
end
- it 'parses a non decimal id with nested namespace' do
- expect(subject.parse_id('/api/v3/statuses/nested/=', property: 'foo')).to eql('=')
+ it "parses a non decimal id with nested namespace" do
+ expect(subject.parse_id("/api/v3/statuses/nested/=", property: "foo")).to eql("=")
end
- it 'accepts on matching version' do
+ it "accepts on matching version" do
expect do
- subject.parse_id('/api/v3/statuses/14', property: 'foo', expected_version: '3')
+ subject.parse_id("/api/v3/statuses/14", property: "foo", expected_version: "3")
end.not_to raise_error
end
- it 'accepts on matching version as integer' do
+ it "accepts on matching version as integer" do
expect do
- subject.parse_id('/api/v3/statuses/14', property: 'foo', expected_version: 3)
+ subject.parse_id("/api/v3/statuses/14", property: "foo", expected_version: 3)
end.not_to raise_error
end
- it 'accepts on matching namespace' do
+ it "accepts on matching namespace" do
expect do
- subject.parse_id('/api/v3/statuses/14', property: 'foo', expected_namespace: 'statuses')
+ subject.parse_id("/api/v3/statuses/14", property: "foo", expected_namespace: "statuses")
end.not_to raise_error
end
- it 'accepts on matching namespace as symbol' do
+ it "accepts on matching namespace as symbol" do
expect do
- subject.parse_id('/api/v3/statuses/14', property: 'foo', expected_namespace: :statuses)
+ subject.parse_id("/api/v3/statuses/14", property: "foo", expected_namespace: :statuses)
end.not_to raise_error
end
- it 'raises on version mismatch' do
+ it "raises on version mismatch" do
expect do
- subject.parse_id('/api/v4/statuses/14', property: 'foo', expected_version: '3')
+ subject.parse_id("/api/v4/statuses/14", property: "foo", expected_version: "3")
end.to raise_error(API::Errors::InvalidResourceLink)
end
- it 'raises on namespace mismatch' do
+ it "raises on namespace mismatch" do
expect do
- subject.parse_id('/api/v3/types/14', property: 'foo', expected_namespace: 'statuses')
+ subject.parse_id("/api/v3/types/14", property: "foo", expected_namespace: "statuses")
end.to raise_error(API::Errors::InvalidResourceLink)
end
- it 'contains the property name in exception messages' do
- property_name = 'My Property Name'
+ it "contains the property name in exception messages" do
+ property_name = "My Property Name"
expect do
- subject.parse_id('/api/v4/statuses/14', property: property_name, expected_version: '3')
+ subject.parse_id("/api/v4/statuses/14", property: property_name, expected_version: "3")
end.to raise_error(Regexp.compile(property_name))
end
end
diff --git a/spec/lib/api/utilities/url_props_parsing_helper_spec.rb b/spec/lib/api/utilities/url_props_parsing_helper_spec.rb
index 01961bf99237..6926688580c0 100644
--- a/spec/lib/api/utilities/url_props_parsing_helper_spec.rb
+++ b/spec/lib/api/utilities/url_props_parsing_helper_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::Utilities::UrlPropsParsingHelper do
let(:clazz) do
@@ -36,17 +36,17 @@
end
let(:subject) { clazz.new }
- describe '#maximum_page_size' do
- context 'when small values in per_page_options',
- with_settings: { per_page_options: '20,100', apiv3_max_page_size: 57 } do
- it 'uses the value from settings' do
+ describe "#maximum_page_size" do
+ context "when small values in per_page_options",
+ with_settings: { per_page_options: "20,100", apiv3_max_page_size: 57 } do
+ it "uses the value from settings" do
expect(subject.maximum_page_size).to eq(57)
end
end
- context 'when larger values in per_page_options',
- with_settings: { per_page_options: '20,100,1000', apiv3_max_page_size: 57 } do
- it 'uses that value' do
+ context "when larger values in per_page_options",
+ with_settings: { per_page_options: "20,100,1000", apiv3_max_page_size: 57 } do
+ it "uses that value" do
expect(subject.maximum_page_size).to eq(57)
end
end
diff --git a/spec/lib/api/v3/actions/action_sql_respresenter_rendering_spec.rb b/spec/lib/api/v3/actions/action_sql_respresenter_rendering_spec.rb
index 83593c8404d4..3d5248388317 100644
--- a/spec/lib/api/v3/actions/action_sql_respresenter_rendering_spec.rb
+++ b/spec/lib/api/v3/actions/action_sql_respresenter_rendering_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Actions::ActionSqlRepresenter, 'rendering' do
+RSpec.describe API::V3::Actions::ActionSqlRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
let(:scope) do
@@ -37,7 +37,7 @@
.limit(1)
end
let(:action_id) do
- 'memberships/create'
+ "memberships/create"
end
current_user do
@@ -48,13 +48,13 @@
API::V3::Utilities::SqlRepresenterWalker
.new(scope,
current_user:,
- url_query: { select: { 'id' => {}, '_type' => {}, 'self' => {} } })
+ url_query: { select: { "id" => {}, "_type" => {}, "self" => {} } })
.walk(API::V3::Actions::ActionSqlRepresenter)
.to_json
end
- context 'with a project action' do
- it 'renders as expected' do
+ context "with a project action" do
+ it "renders as expected" do
expect(json)
.to be_json_eql({
id: action_id,
diff --git a/spec/lib/api/v3/activities/activity_eager_loading_wrapper_spec.rb b/spec/lib/api/v3/activities/activity_eager_loading_wrapper_spec.rb
index dd77a9f4a29b..2bdd3ce9c36c 100644
--- a/spec/lib/api/v3/activities/activity_eager_loading_wrapper_spec.rb
+++ b/spec/lib/api/v3/activities/activity_eager_loading_wrapper_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Activities::ActivityEagerLoadingWrapper, with_settings: { journal_aggregation_time_minutes: 0 } do
shared_let(:user) { create(:user) }
@@ -34,8 +34,8 @@
shared_let(:work_package) { create(:work_package, project:, author: user) }
shared_let(:meeting) { create(:meeting, project:, author: user) }
- describe '.wrap' do
- it 'returns wrapped journals with relations eager loaded' do
+ describe ".wrap" do
+ it "returns wrapped journals with relations eager loaded" do
9.times { |i| work_package.update(subject: "Subject ##{i}") }
journals = Journal.for_work_package
@@ -50,59 +50,59 @@
end
end
- it 'can wrap Project journals' do
+ it "can wrap Project journals" do
expect(project.journals).to be_wrappable
end
- it 'can wrap Document journals' do
+ it "can wrap Document journals" do
document = create(:document, project:)
expect(document.journals).to be_wrappable
end
- it 'can wrap TimeEntry journals' do
+ it "can wrap TimeEntry journals" do
time_entry = create(:time_entry, project:, work_package:, user:)
expect(time_entry.journals).to be_wrappable
end
- it 'can wrap Meeting journals' do
+ it "can wrap Meeting journals" do
expect(meeting.journals).to be_wrappable
end
- it 'can wrap MeetingAgenda journals' do
+ it "can wrap MeetingAgenda journals" do
meeting_agenda = create(:meeting_agenda, meeting:)
expect(meeting_agenda.journals).to be_wrappable
end
- it 'can wrap MeetingMinutes journals' do
+ it "can wrap MeetingMinutes journals" do
meeting_minutes = create(:meeting_minutes, meeting:)
expect(meeting_minutes.journals).to be_wrappable
end
- it 'can wrap Budget journals' do
+ it "can wrap Budget journals" do
budget = create(:budget, project:, author: user)
expect(budget.journals).to be_wrappable
end
- it 'can wrap WorkPackage journals' do
+ it "can wrap WorkPackage journals" do
expect(work_package.journals).to be_wrappable
end
- it 'can wrap Changeset journals' do
+ it "can wrap Changeset journals" do
changeset = create(:changeset, repository: create(:repository_git, project:))
expect(changeset.journals).to be_wrappable
end
- it 'can wrap News journals' do
+ it "can wrap News journals" do
news = create(:news, project:, author: user)
expect(news.journals).to be_wrappable
end
- it 'can wrap WikiPage journals' do
+ it "can wrap WikiPage journals" do
wiki_content = create(:wiki_page, author: user)
expect(wiki_content.journals).to be_wrappable
end
- it 'can wrap Message journals' do
+ it "can wrap Message journals" do
message = create(:message, author: user)
expect(message.journals).to be_wrappable
end
diff --git a/spec/lib/api/v3/activities/activity_representer_rendering_spec.rb b/spec/lib/api/v3/activities/activity_representer_rendering_spec.rb
index 426d4e755b4b..419b88174ee8 100644
--- a/spec/lib/api/v3/activities/activity_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/activities/activity_representer_rendering_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Activities::ActivityRepresenter, 'rendering' do
+RSpec.describe API::V3::Activities::ActivityRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
let(:current_user) { build_stubbed(:user) }
@@ -56,87 +56,87 @@
subject(:generated) { representer.to_json }
- describe 'properties' do
- describe 'type' do
- context 'with notes' do
- let(:notes) { 'Some notes' }
+ describe "properties" do
+ describe "type" do
+ context "with notes" do
+ let(:notes) { "Some notes" }
- it_behaves_like 'property', :_type do
- let(:value) { 'Activity::Comment' }
+ it_behaves_like "property", :_type do
+ let(:value) { "Activity::Comment" }
end
end
- context 'with empty notes' do
- let(:notes) { '' }
+ context "with empty notes" do
+ let(:notes) { "" }
- it_behaves_like 'property', :_type do
- let(:value) { 'Activity' }
+ it_behaves_like "property", :_type do
+ let(:value) { "Activity" }
end
end
- context 'with empty notes and empty changes' do
- let(:notes) { '' }
+ context "with empty notes and empty changes" do
+ let(:notes) { "" }
let(:changes) { {} }
- it_behaves_like 'property', :_type do
- let(:value) { 'Activity::Comment' }
+ it_behaves_like "property", :_type do
+ let(:value) { "Activity::Comment" }
end
end
end
- describe 'id' do
- it_behaves_like 'property', :id do
+ describe "id" do
+ it_behaves_like "property", :id do
let(:value) { journal.id }
end
end
- describe 'createdAt' do
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ describe "createdAt" do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { journal.created_at }
- let(:json_path) { 'createdAt' }
+ let(:json_path) { "createdAt" }
end
end
- describe 'updatedAt' do
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ describe "updatedAt" do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { journal.updated_at }
- let(:json_path) { 'updatedAt' }
+ let(:json_path) { "updatedAt" }
end
end
- describe 'version' do
- it_behaves_like 'property', :version do
+ describe "version" do
+ it_behaves_like "property", :version do
let(:value) { journal.version }
end
end
- describe 'comment' do
- it_behaves_like 'API V3 formattable', 'comment' do
- let(:format) { 'markdown' }
+ describe "comment" do
+ it_behaves_like "API V3 formattable", "comment" do
+ let(:format) { "markdown" }
let(:raw) { journal.notes }
let(:html) { "
#{journal.notes}
" }
end
- context 'if having no change and notes' do
+ context "if having no change and notes" do
let(:notes) { "" }
let(:changes) { {} }
- it_behaves_like 'API V3 formattable', 'comment' do
- let(:format) { 'markdown' }
- let(:raw) { "_#{I18n.t(:'journals.changes_retracted')}_" }
- let(:html) { "
" }
end
end
end
- describe 'details' do
- it { is_expected.to have_json_path('details') }
+ describe "details" do
+ it { is_expected.to have_json_path("details") }
- it { is_expected.to have_json_size(journal.details.count).at_path('details') }
+ it { is_expected.to have_json_size(journal.details.count).at_path("details") }
- it 'renders all details as formattable' do
+ it "renders all details as formattable" do
(0..journal.details.count - 1).each do |x|
- expect(subject).to be_json_eql('custom'.to_json).at_path("details/#{x}/format")
+ expect(subject).to be_json_eql("custom".to_json).at_path("details/#{x}/format")
expect(subject).to have_json_path("details/#{x}/raw")
expect(subject).to have_json_path("details/#{x}/html")
end
@@ -144,43 +144,43 @@
end
end
- describe '_links' do
- describe 'self' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ describe "self" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.activity journal.id }
end
end
- describe 'workPackage' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'workPackage' }
+ describe "workPackage" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "workPackage" }
let(:href) { api_v3_paths.work_package work_package.id }
let(:title) { work_package.subject }
end
end
- describe 'user' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'user' }
+ describe "user" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "user" }
let(:href) { api_v3_paths.user other_user.id }
end
end
- describe 'update' do
- let(:link) { 'update' }
+ describe "update" do
+ let(:link) { "update" }
let(:href) { api_v3_paths.activity(journal.id) }
- it_behaves_like 'has an untitled link'
+ it_behaves_like "has an untitled link"
- context 'with a non own journal having edit_work_package_notes permission' do
- it_behaves_like 'has an untitled link'
+ context "with a non own journal having edit_work_package_notes permission" do
+ it_behaves_like "has an untitled link"
end
- context 'with a non own journal having only edit_own work_package_notes permission' do
+ context "with a non own journal having only edit_own work_package_notes permission" do
let(:permissions) { %i(edit_own_work_package_notes) }
- it_behaves_like 'has no link'
+ it_behaves_like "has no link"
end
end
end
diff --git a/spec/lib/api/v3/attachments/attachment_metadata_representer_spec.rb b/spec/lib/api/v3/attachments/attachment_metadata_representer_spec.rb
index e17c6b1b4e6b..c28a8a10d317 100644
--- a/spec/lib/api/v3/attachments/attachment_metadata_representer_spec.rb
+++ b/spec/lib/api/v3/attachments/attachment_metadata_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Attachments::AttachmentParsingRepresenter do
let(:current_user) { build_stubbed(:user) }
@@ -39,24 +39,24 @@
data.digest = original_digest
data
end
- let(:original_file_name) { 'a file name' }
- let(:original_description) { 'a description' }
- let(:original_content_type) { 'text/plain' }
+ let(:original_file_name) { "a file name" }
+ let(:original_description) { "a description" }
+ let(:original_content_type) { "text/plain" }
let(:original_file_size) { 42 }
let(:original_digest) { "0xFF" }
let(:representer) { described_class.new(metadata, current_user:) }
include API::V3::Utilities::PathHelper
- describe 'parsing' do
+ describe "parsing" do
let(:parsed_hash) do
{
- 'metadata' => {
- 'fileName' => 'the parsed name',
- 'description' => { 'raw' => 'the parsed description' },
- 'contentType' => 'text/html',
- 'fileSize' => 43,
- 'digest' => '0x00'
+ "metadata" => {
+ "fileName" => "the parsed name",
+ "description" => { "raw" => "the parsed description" },
+ "contentType" => "text/html",
+ "fileSize" => 43,
+ "digest" => "0x00"
}
}
end
@@ -67,10 +67,10 @@
representer.from_hash parsed_hash
end
- it { expect(subject.filename).to eql('the parsed name') }
- it { expect(subject.description).to eql('the parsed description') }
- it { expect(subject.content_type).to eql('text/html') }
+ it { expect(subject.filename).to eql("the parsed name") }
+ it { expect(subject.description).to eql("the parsed description") }
+ it { expect(subject.content_type).to eql("text/html") }
it { expect(subject.filesize).to be(43) }
- it { expect(subject.digest).to eql('0x00') }
+ it { expect(subject.digest).to eql("0x00") }
end
end
diff --git a/spec/lib/api/v3/attachments/attachment_representer_spec.rb b/spec/lib/api/v3/attachments/attachment_representer_spec.rb
index d21ac1c975ba..1e1ea67625c9 100644
--- a/spec/lib/api/v3/attachments/attachment_representer_spec.rb
+++ b/spec/lib/api/v3/attachments/attachment_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Attachments::AttachmentRepresenter do
include API::V3::Utilities::PathHelper
@@ -46,7 +46,7 @@
author:) do |attachment|
allow(attachment)
.to receive(:filename)
- .and_return('some_file_of_mine.txt')
+ .and_return("some_file_of_mine.txt")
end
end
@@ -62,73 +62,73 @@
subject { representer.to_json }
- it { is_expected.to be_json_eql('Attachment'.to_json).at_path('_type') }
- it { is_expected.to be_json_eql(attachment.id.to_json).at_path('id') }
- it { is_expected.to be_json_eql(attachment.filename.to_json).at_path('fileName') }
- it { is_expected.to be_json_eql(attachment.filesize.to_json).at_path('fileSize') }
- it { is_expected.to be_json_eql(attachment.content_type.to_json).at_path('contentType') }
- it { is_expected.to be_json_eql('uploaded'.to_json).at_path('status') }
+ it { is_expected.to be_json_eql("Attachment".to_json).at_path("_type") }
+ it { is_expected.to be_json_eql(attachment.id.to_json).at_path("id") }
+ it { is_expected.to be_json_eql(attachment.filename.to_json).at_path("fileName") }
+ it { is_expected.to be_json_eql(attachment.filesize.to_json).at_path("fileSize") }
+ it { is_expected.to be_json_eql(attachment.content_type.to_json).at_path("contentType") }
+ it { is_expected.to be_json_eql("uploaded".to_json).at_path("status") }
- it_behaves_like 'API V3 formattable', 'description' do
- let(:format) { 'plain' }
+ it_behaves_like "API V3 formattable", "description" do
+ let(:format) { "plain" }
let(:raw) { attachment.description }
end
- it_behaves_like 'API V3 digest' do
- let(:path) { 'digest' }
- let(:algorithm) { 'md5' }
+ it_behaves_like "API V3 digest" do
+ let(:path) { "digest" }
+ let(:algorithm) { "md5" }
let(:hash) { attachment.digest }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { attachment.created_at }
- let(:json_path) { 'createdAt' }
+ let(:json_path) { "createdAt" }
end
- describe '_links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.attachment(attachment.id) }
let(:title) { attachment.filename }
end
- context 'for a work package container' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'container' }
+ context "for a work package container" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "container" }
let(:href) { api_v3_paths.work_package(container.id) }
let(:title) { container.subject }
end
end
- context 'for a wiki page container' do
+ context "for a wiki page container" do
let(:container) { build_stubbed(:wiki_page) }
- it_behaves_like 'has a titled link' do
- let(:link) { 'container' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "container" }
let(:href) { api_v3_paths.wiki_page(container.id) }
let(:title) { container.title }
end
end
- context 'without a container' do
+ context "without a container" do
let(:container) { nil }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'container' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "container" }
let(:href) { nil }
end
end
- describe 'downloadLocation link' do
- context 'for a local attachment' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'downloadLocation' }
+ describe "downloadLocation link" do
+ context "for a local attachment" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "downloadLocation" }
let(:href) { api_v3_paths.attachment_content(attachment.id) }
end
end
- context 'for a remote attachment' do
- let(:external_url) { 'https://some.bogus/download/xyz' }
+ context "for a remote attachment" do
+ let(:external_url) { "https://some.bogus/download/xyz" }
before do
allow(attachment)
@@ -139,65 +139,65 @@
.and_return(external_url)
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'downloadLocation' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "downloadLocation" }
let(:href) { external_url }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'staticDownloadLocation' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "staticDownloadLocation" }
let(:href) { api_v3_paths.attachment_content(attachment.id) }
end
end
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'author' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "author" }
let(:href) { api_v3_paths.user(attachment.author.id) }
let(:title) { attachment.author.name }
end
- describe 'delete link' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'delete' }
+ describe "delete link" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "delete" }
let(:href) { api_v3_paths.attachment(attachment.id) }
end
- it 'has the DELETE method' do
- expect(subject).to be_json_eql('delete'.to_json).at_path('_links/delete/method')
+ it "has the DELETE method" do
+ expect(subject).to be_json_eql("delete".to_json).at_path("_links/delete/method")
end
- context 'user is not allowed to edit the container' do
+ context "user is not allowed to edit the container" do
let(:permissions) { all_permissions - [:edit_work_packages] }
- it_behaves_like 'has no link' do
- let(:link) { 'delete' }
+ it_behaves_like "has no link" do
+ let(:link) { "delete" }
end
end
- context 'attachment has no container' do
+ context "attachment has no container" do
let(:container) { nil }
- context 'user is the author' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'delete' }
+ context "user is the author" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "delete" }
let(:href) { api_v3_paths.attachment(attachment.id) }
end
end
- context 'user is not the author' do
+ context "user is not the author" do
let(:author) { build_stubbed(:user) }
- it_behaves_like 'has no link' do
- let(:link) { 'delete' }
+ it_behaves_like "has no link" do
+ let(:link) { "delete" }
end
end
end
end
end
- describe 'caching' do
- it 'is based on the representer\'s cache_key' do
+ describe "caching" do
+ it "is based on the representer's cache_key" do
expect(OpenProject::Cache)
.to receive(:fetch)
.with(representer.json_cache_key)
@@ -206,22 +206,22 @@
representer.to_json
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let!(:former_cache_key) { representer.json_cache_key }
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'Attachments', 'AttachmentRepresenter')
+ .to include("API", "V3", "Attachments", "AttachmentRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
I18n.with_locale(:fr) do
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
end
- it 'changes when the attachment is changed (has no update)' do
+ it "changes when the attachment is changed (has no update)" do
attachment.updated_at = Time.now + 10.seconds
expect(representer.json_cache_key)
diff --git a/spec/lib/api/v3/capabilities/capability_sql_representer_rendering_spec.rb b/spec/lib/api/v3/capabilities/capability_sql_representer_rendering_spec.rb
index 2d9ac6042af5..d6fd2bf1abf1 100644
--- a/spec/lib/api/v3/capabilities/capability_sql_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/capabilities/capability_sql_representer_rendering_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Capabilities::CapabilitySqlRepresenter, 'rendering' do
+RSpec.describe API::V3::Capabilities::CapabilitySqlRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
let(:scope) do
@@ -59,14 +59,14 @@
.new(
scope,
current_user:,
- url_query: { select: { 'id' => {}, '_type' => {}, 'self' => {}, 'action' => {}, 'context' => {}, 'principal' => {} } }
+ url_query: { select: { "id" => {}, "_type" => {}, "self" => {}, "action" => {}, "context" => {}, "principal" => {} } }
)
.walk(described_class)
.to_json
end
- context 'with a project and user' do
- it 'renders as expected' do
+ context "with a project and user" do
+ it "renders as expected" do
expect(json)
.to be_json_eql({
id: "activities/read/p#{context.id}-#{principal.id}",
@@ -91,13 +91,13 @@
end
end
- context 'with a project and group' do
+ context "with a project and group" do
let(:principal) do
create(:group,
member_with_permissions: { project => %i[view_members] })
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql({
id: "memberships/read/p#{context.id}-#{principal.id}",
@@ -122,7 +122,7 @@
end
end
- context 'with a global permission' do
+ context "with a global permission" do
let(:principal) do
create(:user,
global_permissions: %i[create_user],
@@ -130,7 +130,7 @@
end
let(:context) { nil }
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql({
id: "users/create/g-#{principal.id}",
@@ -138,7 +138,7 @@
_links: {
context: {
href: api_v3_paths.capabilities_contexts_global,
- title: 'Global'
+ title: "Global"
},
principal: {
href: api_v3_paths.user(principal.id),
diff --git a/spec/lib/api/v3/capabilities/contexts/global_representer_rendering_spec.rb b/spec/lib/api/v3/capabilities/contexts/global_representer_rendering_spec.rb
index e0c59992d58e..22c820e6c324 100644
--- a/spec/lib/api/v3/capabilities/contexts/global_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/capabilities/contexts/global_representer_rendering_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Capabilities::Contexts::GlobalRepresenter, 'rendering' do
+RSpec.describe API::V3::Capabilities::Contexts::GlobalRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
subject { representer.to_json }
@@ -40,22 +40,22 @@
embed_links: true)
end
- describe '_links' do
- describe 'self' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ describe "self" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.capabilities_contexts_global }
end
end
end
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'CapabilityContext' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "CapabilityContext" }
end
- it_behaves_like 'property', :id do
- let(:value) { 'global' }
+ it_behaves_like "property", :id do
+ let(:value) { "global" }
end
end
end
diff --git a/spec/lib/api/v3/categories/category_collection_representer_spec.rb b/spec/lib/api/v3/categories/category_collection_representer_spec.rb
index d3d891197aa3..0547487c75b1 100644
--- a/spec/lib/api/v3/categories/category_collection_representer_spec.rb
+++ b/spec/lib/api/v3/categories/category_collection_representer_spec.rb
@@ -26,19 +26,19 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Categories::CategoryCollectionRepresenter do
let(:categories) { build_list(:category, 3) }
let(:representer) do
described_class.new(categories,
- self_link: '/api/v3/projects/1/categories',
- current_user: double('current_user'))
+ self_link: "/api/v3/projects/1/categories",
+ current_user: double("current_user"))
end
- context 'generation' do
+ context "generation" do
subject(:collection) { representer.to_json }
- it_behaves_like 'unpaginated APIv3 collection', 3, 'projects/1/categories', 'Category'
+ it_behaves_like "unpaginated APIv3 collection", 3, "projects/1/categories", "Category"
end
end
diff --git a/spec/lib/api/v3/categories/category_representer_spec.rb b/spec/lib/api/v3/categories/category_representer_spec.rb
index 9582d7dda3ae..493d881b233a 100644
--- a/spec/lib/api/v3/categories/category_representer_spec.rb
+++ b/spec/lib/api/v3/categories/category_representer_spec.rb
@@ -26,67 +26,67 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Categories::CategoryRepresenter do
let(:category) { build_stubbed(:category) }
let(:user) { build(:user) }
- let(:representer) { described_class.new(category, current_user: double('current_user')) }
+ let(:representer) { described_class.new(category, current_user: double("current_user")) }
- context 'generation' do
+ context "generation" do
subject(:generated) { representer.to_json }
- shared_examples_for 'category has core values' do
- it { is_expected.to include_json('Category'.to_json).at_path('_type') }
+ shared_examples_for "category has core values" do
+ it { is_expected.to include_json("Category".to_json).at_path("_type") }
- it { is_expected.to have_json_type(Object).at_path('_links') }
+ it { is_expected.to have_json_type(Object).at_path("_links") }
- it 'links to self' do
- expect(subject).to have_json_path('_links/self/href')
+ it "links to self" do
+ expect(subject).to have_json_path("_links/self/href")
end
- it 'displays its name as title in self' do
- expect(subject).to have_json_path('_links/self/title')
+ it "displays its name as title in self" do
+ expect(subject).to have_json_path("_links/self/title")
end
- it 'links to its project' do
- expect(subject).to have_json_path('_links/project/href')
+ it "links to its project" do
+ expect(subject).to have_json_path("_links/project/href")
end
- it 'displays its project title' do
- expect(subject).to have_json_path('_links/project/title')
+ it "displays its project title" do
+ expect(subject).to have_json_path("_links/project/title")
end
- it { is_expected.to have_json_path('id') }
- it { is_expected.to have_json_path('name') }
+ it { is_expected.to have_json_path("id") }
+ it { is_expected.to have_json_path("name") }
end
- context 'default assignee not set' do
- it_behaves_like 'category has core values'
+ context "default assignee not set" do
+ it_behaves_like "category has core values"
- it 'does not link to an assignee' do
- expect(subject).not_to have_json_path('_links/defaultAssignee')
+ it "does not link to an assignee" do
+ expect(subject).not_to have_json_path("_links/defaultAssignee")
end
end
- context 'default assignee set' do
+ context "default assignee set" do
let(:category) do
build_stubbed(:category, assigned_to: user)
end
- it_behaves_like 'category has core values'
+ it_behaves_like "category has core values"
- it 'links to its default assignee' do
- expect(subject).to have_json_path('_links/defaultAssignee/href')
+ it "links to its default assignee" do
+ expect(subject).to have_json_path("_links/defaultAssignee/href")
end
- it 'displays the name of its default assignee' do
- expect(subject).to have_json_path('_links/defaultAssignee/title')
+ it "displays the name of its default assignee" do
+ expect(subject).to have_json_path("_links/defaultAssignee/title")
end
end
- describe 'caching' do
- it 'is based on the representer\'s cache_key' do
+ describe "caching" do
+ it "is based on the representer's cache_key" do
expect(OpenProject::Cache)
.to receive(:fetch)
.with(representer.json_cache_key)
@@ -95,7 +95,7 @@
representer.to_json
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let(:assigned_to) { build_stubbed(:user) }
let!(:former_cache_key) { representer.json_cache_key }
@@ -103,33 +103,33 @@
category.assigned_to = assigned_to
end
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'Categories', 'CategoryRepresenter')
+ .to include("API", "V3", "Categories", "CategoryRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
I18n.with_locale(:fr) do
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
end
- it 'changes when the category is updated' do
+ it "changes when the category is updated" do
category.updated_at = Time.now + 20.seconds
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
- it 'changes when the category\'s project is updated' do
+ it "changes when the category's project is updated" do
category.project.updated_at = Time.now + 20.seconds
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
- it 'changes when the category\'s assigned_to is updated' do
+ it "changes when the category's assigned_to is updated" do
category.assigned_to.updated_at = Time.now + 20.seconds
expect(representer.json_cache_key)
diff --git a/spec/lib/api/v3/configuration/configuration_representer_spec.rb b/spec/lib/api/v3/configuration/configuration_representer_spec.rb
index 28f8187bc750..1247a0d239c8 100644
--- a/spec/lib/api/v3/configuration/configuration_representer_spec.rb
+++ b/spec/lib/api/v3/configuration/configuration_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Configuration::ConfigurationRepresenter do
include API::V3::Utilities::PathHelper
@@ -46,223 +46,223 @@
subject { representer.to_json }
- describe '_links' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.configuration }
end
- describe 'userPreferences' do
- context 'if logged in' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'userPreferences' }
+ describe "userPreferences" do
+ context "if logged in" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "userPreferences" }
let(:href) { api_v3_paths.user_preferences(current_user.id) }
end
end
- context 'if not logged in' do
+ context "if not logged in" do
let(:current_user) { build_stubbed(:anonymous) }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'userPreferences' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "userPreferences" }
let(:href) { api_v3_paths.user_preferences(current_user.id) }
end
end
end
end
- describe 'properties' do
- it 'indicates its type' do
- expect(subject).to be_json_eql('Configuration'.to_json).at_path('_type')
+ describe "properties" do
+ it "indicates its type" do
+ expect(subject).to be_json_eql("Configuration".to_json).at_path("_type")
end
- it 'indicates maximumAttachmentFileSize in Bytes' do
- allow(Setting).to receive(:attachment_max_size).and_return('1024')
- expect(subject).to be_json_eql((1024 * 1024).to_json).at_path('maximumAttachmentFileSize')
+ it "indicates maximumAttachmentFileSize in Bytes" do
+ allow(Setting).to receive(:attachment_max_size).and_return("1024")
+ expect(subject).to be_json_eql((1024 * 1024).to_json).at_path("maximumAttachmentFileSize")
end
- it 'indicates perPageOptions as array of integers' do
- allow(Setting).to receive(:per_page_options).and_return('1, 50 , 100 ')
- expect(subject).to be_json_eql([1, 50, 100].to_json).at_path('perPageOptions')
+ it "indicates perPageOptions as array of integers" do
+ allow(Setting).to receive(:per_page_options).and_return("1, 50 , 100 ")
+ expect(subject).to be_json_eql([1, 50, 100].to_json).at_path("perPageOptions")
end
- describe 'timeFormat' do
- context 'with time format', with_settings: { time_format: '%I:%M %p' } do
- it 'indicates the timeFormat' do
+ describe "timeFormat" do
+ context "with time format", with_settings: { time_format: "%I:%M %p" } do
+ it "indicates the timeFormat" do
expect(subject)
- .to be_json_eql('hh:mm a'.to_json)
- .at_path('timeFormat')
+ .to be_json_eql("hh:mm a".to_json)
+ .at_path("timeFormat")
end
end
- context 'with time format', with_settings: { time_format: '%H:%M' } do
- it 'indicates the timeFormat' do
+ context "with time format", with_settings: { time_format: "%H:%M" } do
+ it "indicates the timeFormat" do
expect(subject)
- .to be_json_eql('HH:mm'.to_json)
- .at_path('timeFormat')
+ .to be_json_eql("HH:mm".to_json)
+ .at_path("timeFormat")
end
end
- context 'with a time format', with_settings: { time_format: '' } do
- it 'indicates the timeFormat' do
+ context "with a time format", with_settings: { time_format: "" } do
+ it "indicates the timeFormat" do
expect(subject)
.to be_json_eql(nil.to_json)
- .at_path('timeFormat')
+ .at_path("timeFormat")
end
end
end
- describe 'dateFormat' do
- context 'without a date format', with_settings: { date_format: '' } do
- it 'indicates the dateFormat' do
+ describe "dateFormat" do
+ context "without a date format", with_settings: { date_format: "" } do
+ it "indicates the dateFormat" do
expect(subject)
.to be_json_eql(nil.to_json)
- .at_path('dateFormat')
+ .at_path("dateFormat")
end
end
- context 'with date format (%Y-%m-%d)', with_settings: { date_format: '%Y-%m-%d' } do
- it 'indicates the dateFormat' do
+ context "with date format (%Y-%m-%d)", with_settings: { date_format: "%Y-%m-%d" } do
+ it "indicates the dateFormat" do
expect(subject)
- .to be_json_eql('YYYY-MM-DD'.to_json)
- .at_path('dateFormat')
+ .to be_json_eql("YYYY-MM-DD".to_json)
+ .at_path("dateFormat")
end
end
- context 'with date format (%d.%m.%Y)', with_settings: { date_format: '%d.%m.%Y' } do
- it 'indicates the dateFormat' do
+ context "with date format (%d.%m.%Y)", with_settings: { date_format: "%d.%m.%Y" } do
+ it "indicates the dateFormat" do
expect(subject)
- .to be_json_eql('DD.MM.YYYY'.to_json)
- .at_path('dateFormat')
+ .to be_json_eql("DD.MM.YYYY".to_json)
+ .at_path("dateFormat")
end
end
- context 'with date format (%d-%m-%Y)', with_settings: { date_format: '%d-%m-%Y' } do
- it 'indicates the dateFormat' do
+ context "with date format (%d-%m-%Y)", with_settings: { date_format: "%d-%m-%Y" } do
+ it "indicates the dateFormat" do
expect(subject)
- .to be_json_eql('DD-MM-YYYY'.to_json)
- .at_path('dateFormat')
+ .to be_json_eql("DD-MM-YYYY".to_json)
+ .at_path("dateFormat")
end
end
- context 'with date format (%m/%d/%Y)', with_settings: { date_format: '%m/%d/%Y' } do
- it 'indicates the dateFormat' do
+ context "with date format (%m/%d/%Y)", with_settings: { date_format: "%m/%d/%Y" } do
+ it "indicates the dateFormat" do
expect(subject)
- .to be_json_eql('MM/DD/YYYY'.to_json)
- .at_path('dateFormat')
+ .to be_json_eql("MM/DD/YYYY".to_json)
+ .at_path("dateFormat")
end
end
- context 'with date format (%d %b %Y)', with_settings: { date_format: '%d %b %Y' } do
- it 'indicates the dateFormat' do
+ context "with date format (%d %b %Y)", with_settings: { date_format: "%d %b %Y" } do
+ it "indicates the dateFormat" do
expect(subject)
- .to be_json_eql('DD MMM YYYY'.to_json)
- .at_path('dateFormat')
+ .to be_json_eql("DD MMM YYYY".to_json)
+ .at_path("dateFormat")
end
end
- context 'with date format (%d %B %Y)', with_settings: { date_format: '%d %B %Y' } do
- it 'indicates the dateFormat' do
+ context "with date format (%d %B %Y)", with_settings: { date_format: "%d %B %Y" } do
+ it "indicates the dateFormat" do
expect(subject)
- .to be_json_eql('DD MMMM YYYY'.to_json)
- .at_path('dateFormat')
+ .to be_json_eql("DD MMMM YYYY".to_json)
+ .at_path("dateFormat")
end
end
- context 'with date format (%b %d, %Y)', with_settings: { date_format: '%b %d, %Y' } do
- it 'indicates the dateFormat' do
+ context "with date format (%b %d, %Y)", with_settings: { date_format: "%b %d, %Y" } do
+ it "indicates the dateFormat" do
expect(subject)
- .to be_json_eql('MMM DD, YYYY'.to_json)
- .at_path('dateFormat')
+ .to be_json_eql("MMM DD, YYYY".to_json)
+ .at_path("dateFormat")
end
end
- context 'with date format (%B %d, %Y)', with_settings: { date_format: '%B %d, %Y' } do
- it 'indicates the dateFormat' do
+ context "with date format (%B %d, %Y)", with_settings: { date_format: "%B %d, %Y" } do
+ it "indicates the dateFormat" do
expect(subject)
- .to be_json_eql('MMMM DD, YYYY'.to_json)
- .at_path('dateFormat')
+ .to be_json_eql("MMMM DD, YYYY".to_json)
+ .at_path("dateFormat")
end
end
end
- describe 'user_default_timezone' do
- context 'without a setting', with_settings: { user_default_timezone: nil } do
- it 'is null' do
+ describe "user_default_timezone" do
+ context "without a setting", with_settings: { user_default_timezone: nil } do
+ it "is null" do
expect(subject)
.to be_json_eql(nil.to_json)
- .at_path('userDefaultTimezone')
+ .at_path("userDefaultTimezone")
end
end
- context 'with `Europe/Berlin` being set', with_settings: { user_default_timezone: 'Europe/Berlin' } do
- it 'indicates the dateFormat' do
+ context "with `Europe/Berlin` being set", with_settings: { user_default_timezone: "Europe/Berlin" } do
+ it "indicates the dateFormat" do
expect(subject)
- .to be_json_eql('Europe/Berlin'.to_json)
- .at_path('userDefaultTimezone')
+ .to be_json_eql("Europe/Berlin".to_json)
+ .at_path("userDefaultTimezone")
end
end
end
- describe 'startOfWeek' do
- context 'without a setting', with_settings: { start_of_week: '' } do
- it 'is null' do
+ describe "startOfWeek" do
+ context "without a setting", with_settings: { start_of_week: "" } do
+ it "is null" do
expect(subject)
.to be_json_eql(nil.to_json)
- .at_path('startOfWeek')
+ .at_path("startOfWeek")
end
end
- context 'with `Monday` being set', with_settings: { start_of_week: '1' } do
- it 'indicates the dateFormat' do
+ context "with `Monday` being set", with_settings: { start_of_week: "1" } do
+ it "indicates the dateFormat" do
expect(subject)
.to be_json_eql(1.to_json)
- .at_path('startOfWeek')
+ .at_path("startOfWeek")
end
end
end
- describe 'activeFeatureFlags' do
- context 'without any active flags' do
- it 'is an empty array' do
+ describe "activeFeatureFlags" do
+ context "without any active flags" do
+ it "is an empty array" do
expect(subject)
.to be_json_eql([].to_json)
- .at_path('activeFeatureFlags')
+ .at_path("activeFeatureFlags")
end
end
- context 'with active flags' do
+ context "with active flags" do
before do
allow(OpenProject::FeatureDecisions)
.to receive(:active)
.and_return(%w(the active_flags))
end
- it 'is an array of strings of those flags' do
+ it "is an array of strings of those flags" do
expect(subject)
.to be_json_eql(%w(the activeFlags).to_json)
- .at_path('activeFeatureFlags')
+ .at_path("activeFeatureFlags")
end
end
end
end
- describe '_embedded' do
- describe 'userPreferences' do
- context 'if embedding' do
+ describe "_embedded" do
+ describe "userPreferences" do
+ context "if embedding" do
let(:embed_links) { true }
- it 'embedds the user preferences' do
+ it "embedds the user preferences" do
expect(subject)
- .to be_json_eql('UserPreferences'.to_json)
- .at_path('_embedded/userPreferences/_type')
+ .to be_json_eql("UserPreferences".to_json)
+ .at_path("_embedded/userPreferences/_type")
end
end
- context 'if not embedding' do
- it 'embedds the user preferences' do
+ context "if not embedding" do
+ it "embedds the user preferences" do
expect(subject)
- .not_to have_json_path('_embedded/userPreferences/_type')
+ .not_to have_json_path("_embedded/userPreferences/_type")
end
end
end
diff --git a/spec/lib/api/v3/custom_actions/custom_action_execute_representer_parsing_spec.rb b/spec/lib/api/v3/custom_actions/custom_action_execute_representer_parsing_spec.rb
index 84e184531ffb..65bbd15b2142 100644
--- a/spec/lib/api/v3/custom_actions/custom_action_execute_representer_parsing_spec.rb
+++ b/spec/lib/api/v3/custom_actions/custom_action_execute_representer_parsing_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::CustomActions::CustomActionExecuteRepresenter, 'parsing' do
+RSpec.describe API::V3::CustomActions::CustomActionExecuteRepresenter, "parsing" do
include API::V3::Utilities::PathHelper
let(:struct) { OpenStruct.new }
@@ -49,32 +49,32 @@
struct
end
- context 'lockVersion' do
+ context "lockVersion" do
let(:payload) do
{
- 'lockVersion' => 1
+ "lockVersion" => 1
}
end
- it 'sets the lockVersion' do
+ it "sets the lockVersion" do
expect(subject.lock_version)
- .to eql payload['lockVersion']
+ .to eql payload["lockVersion"]
end
end
- context '_links' do
- context 'workPackage' do
+ context "_links" do
+ context "workPackage" do
let(:payload) do
{
- '_links' => {
- 'workPackage' => {
- 'href' => api_v3_paths.work_package(work_package.id)
+ "_links" => {
+ "workPackage" => {
+ "href" => api_v3_paths.work_package(work_package.id)
}
}
}
end
- it 'sets the work_package_id' do
+ it "sets the work_package_id" do
expect(subject.work_package_id)
.to eql work_package.id.to_s
end
diff --git a/spec/lib/api/v3/custom_actions/custom_action_representer_generation_spec.rb b/spec/lib/api/v3/custom_actions/custom_action_representer_generation_spec.rb
index 54377cd52365..e19d6bbc1caf 100644
--- a/spec/lib/api/v3/custom_actions/custom_action_representer_generation_spec.rb
+++ b/spec/lib/api/v3/custom_actions/custom_action_representer_generation_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::CustomActions::CustomActionRepresenter do
include API::V3::Utilities::PathHelper
@@ -40,38 +40,38 @@
subject { representer.to_json }
- context 'properties' do
- it 'has a _type property' do
+ context "properties" do
+ it "has a _type property" do
expect(subject)
- .to be_json_eql('CustomAction'.to_json)
- .at_path('_type')
+ .to be_json_eql("CustomAction".to_json)
+ .at_path("_type")
end
- it 'has a name property' do
+ it "has a name property" do
expect(subject)
.to be_json_eql(custom_action.name.to_json)
- .at_path('name')
+ .at_path("name")
end
- it 'has a description property' do
+ it "has a description property" do
expect(subject)
.to be_json_eql(custom_action.description.to_json)
- .at_path('description')
+ .at_path("description")
end
end
- context 'links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ context "links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.custom_action(custom_action.id) }
let(:title) { custom_action.name }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'executeImmediately' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "executeImmediately" }
let(:href) { api_v3_paths.custom_action_execute(custom_action.id) }
let(:title) { "Execute #{custom_action.name}" }
- let(:method) { 'post' }
+ let(:method) { "post" }
end
end
end
diff --git a/spec/lib/api/v3/custom_options/custom_option_representer_spec.rb b/spec/lib/api/v3/custom_options/custom_option_representer_spec.rb
index abacb10ed003..95a79f1601ad 100644
--- a/spec/lib/api/v3/custom_options/custom_option_representer_spec.rb
+++ b/spec/lib/api/v3/custom_options/custom_option_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::CustomOptions::CustomOptionRepresenter do
include API::V3::Utilities::PathHelper
@@ -40,25 +40,25 @@
subject { representer.to_json }
- describe 'generation' do
- describe '_links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "generation" do
+ describe "_links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.custom_option custom_option.id }
let(:title) { custom_option.to_s }
end
end
it 'has the type "CustomOption"' do
- expect(subject).to be_json_eql('CustomOption'.to_json).at_path('_type')
+ expect(subject).to be_json_eql("CustomOption".to_json).at_path("_type")
end
- it 'has an id' do
- expect(subject).to be_json_eql(custom_option.id.to_json).at_path('id')
+ it "has an id" do
+ expect(subject).to be_json_eql(custom_option.id.to_json).at_path("id")
end
- it 'has a value' do
- expect(subject).to be_json_eql(custom_option.to_s.to_json).at_path('value')
+ it "has a value" do
+ expect(subject).to be_json_eql(custom_option.to_s.to_json).at_path("value")
end
end
end
diff --git a/spec/lib/api/v3/days/day_collection_representer_spec.rb b/spec/lib/api/v3/days/day_collection_representer_spec.rb
index 6d58452985cd..b88184464472 100644
--- a/spec/lib/api/v3/days/day_collection_representer_spec.rb
+++ b/spec/lib/api/v3/days/day_collection_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Days::DayCollectionRepresenter do
let(:days) do
@@ -36,16 +36,16 @@
build(:day, date: Date.new(2022, 12, 29))
]
end
- let(:current_user) { instance_double(User, name: 'current_user') }
+ let(:current_user) { instance_double(User, name: "current_user") }
let(:representer) do
described_class.new(days,
- self_link: '/api/v3/self_link_untested',
+ self_link: "/api/v3/self_link_untested",
current_user:)
end
- describe '#to_json' do
+ describe "#to_json" do
subject(:collection) { representer.to_json }
- it_behaves_like 'unpaginated APIv3 collection', 3, 'self_link_untested', 'Day'
+ it_behaves_like "unpaginated APIv3 collection", 3, "self_link_untested", "Day"
end
end
diff --git a/spec/lib/api/v3/days/day_representer_spec.rb b/spec/lib/api/v3/days/day_representer_spec.rb
index b8e636c84670..ef1e86c6fb75 100644
--- a/spec/lib/api/v3/days/day_representer_spec.rb
+++ b/spec/lib/api/v3/days/day_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Days::DayRepresenter do
let(:working) { true }
@@ -35,106 +35,106 @@
Day.from_range(from: Date.new(2022, 12, 1), to: Date.new(2022, 12, 31))
.find(date.strftime("%Y%m%d").to_i)
end
- let(:current_user) { instance_double(User, name: 'current_user') }
+ let(:current_user) { instance_double(User, name: "current_user") }
let(:representer) { described_class.new(day, current_user:) }
subject(:generated) { representer.to_json }
before do
- set_week_days('tuesday', working:)
+ set_week_days("tuesday", working:)
end
- it 'has _type: Day' do
- expect(subject).to be_json_eql('Day'.to_json).at_path('_type')
+ it "has _type: Day" do
+ expect(subject).to be_json_eql("Day".to_json).at_path("_type")
end
- it 'has date property' do
- expect(subject).to have_json_type(String).at_path('date')
- expect(subject).to be_json_eql('2022-12-27'.to_json).at_path('date')
+ it "has date property" do
+ expect(subject).to have_json_type(String).at_path("date")
+ expect(subject).to be_json_eql("2022-12-27".to_json).at_path("date")
end
- it 'has name string property' do
- expect(subject).to have_json_type(String).at_path('name')
- expect(subject).to be_json_eql(day.name.to_json).at_path('name')
+ it "has name string property" do
+ expect(subject).to have_json_type(String).at_path("name")
+ expect(subject).to be_json_eql(day.name.to_json).at_path("name")
end
- it 'has working boolean property' do
- expect(subject).to have_json_type(TrueClass).at_path('working')
- expect(subject).to be_json_eql(day.working.to_json).at_path('working')
+ it "has working boolean property" do
+ expect(subject).to have_json_type(TrueClass).at_path("working")
+ expect(subject).to be_json_eql(day.working.to_json).at_path("working")
end
- describe '_links' do
- it 'is present' do
- expect(subject).to have_json_type(Object).at_path('_links')
+ describe "_links" do
+ it "is present" do
+ expect(subject).to have_json_type(Object).at_path("_links")
end
- describe 'self' do
- it 'links to this resource' do
+ describe "self" do
+ it "links to this resource" do
expected_json = {
- href: '/api/v3/days/2022-12-27',
- title: 'Tuesday'
+ href: "/api/v3/days/2022-12-27",
+ title: "Tuesday"
}.to_json
- expect(subject).to be_json_eql(expected_json).at_path('_links/self')
+ expect(subject).to be_json_eql(expected_json).at_path("_links/self")
end
end
- describe 'nonWorkingReasons' do
- context 'when the day has working true' do
- it { is_expected.not_to have_json_path('_links/nonWorkingReasons') }
+ describe "nonWorkingReasons" do
+ context "when the day has working true" do
+ it { is_expected.not_to have_json_path("_links/nonWorkingReasons") }
end
- context 'when day has working false' do
+ context "when day has working false" do
let(:working) { false }
- it 'links to the day resource' do
+ it "links to the day resource" do
expected_json = [{
- href: '/api/v3/days/week/2',
- title: 'Tuesday'
+ href: "/api/v3/days/week/2",
+ title: "Tuesday"
}].to_json
- expect(subject).to be_json_eql(expected_json).at_path('_links/nonWorkingReasons')
+ expect(subject).to be_json_eql(expected_json).at_path("_links/nonWorkingReasons")
end
end
- context 'when a non-working day is present' do
+ context "when a non-working day is present" do
let!(:non_working_day) { create(:non_working_day, date:) }
- it 'links to the non-working day resource' do
+ it "links to the non-working day resource" do
expected_json = [{
href: "/api/v3/days/non_working/2022-12-27",
title: non_working_day.name
}].to_json
- expect(subject).to be_json_eql(expected_json).at_path('_links/nonWorkingReasons')
+ expect(subject).to be_json_eql(expected_json).at_path("_links/nonWorkingReasons")
end
end
- context 'when the day has working false and a non-working day is present' do
+ context "when the day has working false and a non-working day is present" do
let(:working) { false }
let!(:non_working_day) { create(:non_working_day, date:) }
- it 'links to the day resource and to the non-working day resource' do
+ it "links to the day resource and to the non-working day resource" do
expected_json = [{
- href: '/api/v3/days/week/2',
- title: 'Tuesday'
+ href: "/api/v3/days/week/2",
+ title: "Tuesday"
}, {
href: "/api/v3/days/non_working/2022-12-27",
title: non_working_day.name
}].to_json
- expect(subject).to be_json_eql(expected_json).at_path('_links/nonWorkingReasons')
+ expect(subject).to be_json_eql(expected_json).at_path("_links/nonWorkingReasons")
end
end
end
- describe 'weekday' do
- it 'links to the weekday resource' do
+ describe "weekday" do
+ it "links to the weekday resource" do
expected_json = {
- href: '/api/v3/days/week/2',
- title: 'Tuesday'
+ href: "/api/v3/days/week/2",
+ title: "Tuesday"
}.to_json
- expect(subject).to be_json_eql(expected_json).at_path('_links/weekday')
+ expect(subject).to be_json_eql(expected_json).at_path("_links/weekday")
end
end
end
diff --git a/spec/lib/api/v3/days/non_working_day_collection_representer_spec.rb b/spec/lib/api/v3/days/non_working_day_collection_representer_spec.rb
index 39fd49e6afc7..88fa0f2f21e1 100644
--- a/spec/lib/api/v3/days/non_working_day_collection_representer_spec.rb
+++ b/spec/lib/api/v3/days/non_working_day_collection_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Days::NonWorkingDayCollectionRepresenter do
let(:non_working_days) do
@@ -36,16 +36,16 @@
build(:non_working_day, date: Date.new(2022, 12, 29))
]
end
- let(:current_user) { instance_double(User, name: 'current_user') }
+ let(:current_user) { instance_double(User, name: "current_user") }
let(:representer) do
described_class.new(non_working_days,
- self_link: '/api/v3/self_link_untested',
+ self_link: "/api/v3/self_link_untested",
current_user:)
end
- describe '#to_json' do
+ describe "#to_json" do
subject(:collection) { representer.to_json }
- it_behaves_like 'unpaginated APIv3 collection', 3, 'self_link_untested', 'NonWorkingDay'
+ it_behaves_like "unpaginated APIv3 collection", 3, "self_link_untested", "NonWorkingDay"
end
end
diff --git a/spec/lib/api/v3/days/non_working_day_representer_spec.rb b/spec/lib/api/v3/days/non_working_day_representer_spec.rb
index f82b6a3ccd36..aff701bfa27b 100644
--- a/spec/lib/api/v3/days/non_working_day_representer_spec.rb
+++ b/spec/lib/api/v3/days/non_working_day_representer_spec.rb
@@ -26,51 +26,51 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Days::NonWorkingDayRepresenter do
let(:non_working_day) { build_stubbed(:non_working_day, name: "Christmas day", date: Date.tomorrow) }
- let(:representer) { described_class.new(non_working_day, current_user: instance_double(User, name: 'current_user')) }
+ let(:representer) { described_class.new(non_working_day, current_user: instance_double(User, name: "current_user")) }
- describe '#to_json' do
+ describe "#to_json" do
subject(:generated) { representer.to_json }
- it_behaves_like 'property', :_type do
- let(:value) { 'NonWorkingDay' }
+ it_behaves_like "property", :_type do
+ let(:value) { "NonWorkingDay" }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { non_working_day.id }
end
- it_behaves_like 'property', :name do
+ it_behaves_like "property", :name do
let(:value) { non_working_day.name }
end
- it_behaves_like 'has ISO 8601 date only' do
+ it_behaves_like "has ISO 8601 date only" do
let(:date) { non_working_day.date }
- let(:json_path) { 'date' }
+ let(:json_path) { "date" }
end
- describe '_links' do
- it 'is present' do
- expect(subject).to have_json_type(Object).at_path('_links')
+ describe "_links" do
+ it "is present" do
+ expect(subject).to have_json_type(Object).at_path("_links")
end
- describe 'self' do
- it 'links to this resource' do
+ describe "self" do
+ it "links to this resource" do
expected_json = {
href: "/api/v3/days/non_working/#{non_working_day.date}",
title: non_working_day.name
}.to_json
- expect(subject).to be_json_eql(expected_json).at_path('_links/self')
+ expect(subject).to be_json_eql(expected_json).at_path("_links/self")
end
end
end
end
- describe 'caching' do
- it 'is based on the representer\'s json_cache_key' do
+ describe "caching" do
+ it "is based on the representer's json_cache_key" do
allow(OpenProject::Cache)
.to receive(:fetch)
.and_call_original
@@ -82,22 +82,22 @@
.with(representer.json_cache_key)
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let!(:former_cache_key) { representer.json_cache_key }
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'Days', 'NonWorkingDayRepresenter')
+ .to include("API", "V3", "Days", "NonWorkingDayRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
I18n.with_locale(:fr) do
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
end
- it 'changes when the non_working_day is updated' do
+ it "changes when the non_working_day is updated" do
non_working_day.updated_at = 20.seconds.from_now
expect(representer.json_cache_key)
diff --git a/spec/lib/api/v3/days/week_day_collection_representer_spec.rb b/spec/lib/api/v3/days/week_day_collection_representer_spec.rb
index 415b29039b68..fb4713cb77a4 100644
--- a/spec/lib/api/v3/days/week_day_collection_representer_spec.rb
+++ b/spec/lib/api/v3/days/week_day_collection_representer_spec.rb
@@ -26,19 +26,19 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Days::WeekDayCollectionRepresenter do
let(:week_days) { WeekDay.all }
let(:representer) do
described_class.new(week_days,
- self_link: '/api/v3/days/week',
- current_user: instance_double(User, name: 'current_user'))
+ self_link: "/api/v3/days/week",
+ current_user: instance_double(User, name: "current_user"))
end
- describe '#to_json' do
+ describe "#to_json" do
subject(:collection) { representer.to_json }
- it_behaves_like 'unpaginated APIv3 collection', 7, 'days/week', 'WeekDay'
+ it_behaves_like "unpaginated APIv3 collection", 7, "days/week", "WeekDay"
end
end
diff --git a/spec/lib/api/v3/days/week_day_representer_spec.rb b/spec/lib/api/v3/days/week_day_representer_spec.rb
index f3a02c3a960f..9b8b2392fe8f 100644
--- a/spec/lib/api/v3/days/week_day_representer_spec.rb
+++ b/spec/lib/api/v3/days/week_day_representer_spec.rb
@@ -26,53 +26,53 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Days::WeekDayRepresenter do
let(:week_day) { build(:week_day, day: 1) }
- let(:representer) { described_class.new(week_day, current_user: instance_double(User, name: 'current_user')) }
+ let(:representer) { described_class.new(week_day, current_user: instance_double(User, name: "current_user")) }
- describe '#to_json' do
+ describe "#to_json" do
subject(:generated) { representer.to_json }
- it 'has _type: WeekDay' do
- expect(subject).to be_json_eql('WeekDay'.to_json).at_path('_type')
+ it "has _type: WeekDay" do
+ expect(subject).to be_json_eql("WeekDay".to_json).at_path("_type")
end
- it 'has day integer property' do
- expect(subject).to have_json_type(Integer).at_path('day')
- expect(subject).to be_json_eql(week_day.day.to_json).at_path('day')
+ it "has day integer property" do
+ expect(subject).to have_json_type(Integer).at_path("day")
+ expect(subject).to be_json_eql(week_day.day.to_json).at_path("day")
end
- it 'has name string property' do
- expect(subject).to have_json_type(String).at_path('name')
- expect(subject).to be_json_eql(week_day.name.to_json).at_path('name')
+ it "has name string property" do
+ expect(subject).to have_json_type(String).at_path("name")
+ expect(subject).to be_json_eql(week_day.name.to_json).at_path("name")
end
- it 'has working boolean property' do
- expect(subject).to have_json_type(TrueClass).at_path('working')
- expect(subject).to be_json_eql(week_day.working.to_json).at_path('working')
+ it "has working boolean property" do
+ expect(subject).to have_json_type(TrueClass).at_path("working")
+ expect(subject).to be_json_eql(week_day.working.to_json).at_path("working")
end
- describe '_links' do
- it 'is present' do
- expect(subject).to have_json_type(Object).at_path('_links')
+ describe "_links" do
+ it "is present" do
+ expect(subject).to have_json_type(Object).at_path("_links")
end
- describe 'self' do
- it 'links to this resource' do
+ describe "self" do
+ it "links to this resource" do
expected_json = {
href: "/api/v3/days/week/#{week_day.day}",
title: week_day.name
}.to_json
- expect(subject).to be_json_eql(expected_json).at_path('_links/self')
+ expect(subject).to be_json_eql(expected_json).at_path("_links/self")
end
end
end
end
- describe 'caching' do
- it 'is based on the representer\'s json_cache_key' do
+ describe "caching" do
+ it "is based on the representer's json_cache_key" do
allow(OpenProject::Cache)
.to receive(:fetch)
.and_call_original
@@ -84,23 +84,23 @@
.with(representer.json_cache_key)
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let!(:former_cache_key) { representer.json_cache_key }
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'Days', 'WeekDayRepresenter')
+ .to include("API", "V3", "Days", "WeekDayRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
I18n.with_locale(:fr) do
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
end
- it 'changes when the Setting is updated' do
- set_week_days('tuesday')
+ it "changes when the Setting is updated" do
+ set_week_days("tuesday")
expect(representer.json_cache_key)
.not_to eql former_cache_key
diff --git a/spec/lib/api/v3/formatter/txt_charset_spec.rb b/spec/lib/api/v3/formatter/txt_charset_spec.rb
index 88eda06d68f1..92585460a903 100644
--- a/spec/lib/api/v3/formatter/txt_charset_spec.rb
+++ b/spec/lib/api/v3/formatter/txt_charset_spec.rb
@@ -26,26 +26,26 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Formatter::TxtCharset do
- let(:umlaut_object_ascii) { 'ümläutß'.force_encoding('ASCII-8BIT') }
- let(:umlaut_object_utf8) { umlaut_object_ascii.force_encoding('utf-8') }
+ let(:umlaut_object_ascii) { "ümläutß".force_encoding("ASCII-8BIT") }
+ let(:umlaut_object_utf8) { umlaut_object_ascii.force_encoding("utf-8") }
let(:env) { {} }
- describe '#call' do
- it 'returns the object (string) encoded in the charset defined in env' do
- env['CONTENT_TYPE'] = 'text/plain; charset=UTF-8'
+ describe "#call" do
+ it "returns the object (string) encoded in the charset defined in env" do
+ env["CONTENT_TYPE"] = "text/plain; charset=UTF-8"
expect(described_class.call(umlaut_object_ascii.dup, env)).to eql umlaut_object_utf8
end
- it 'returns the object (string) in default encoding if nothing defined in env' do
+ it "returns the object (string) in default encoding if nothing defined in env" do
expect(described_class.call(umlaut_object_ascii.dup, env)).to eql umlaut_object_utf8
end
- it 'returns the object (string) unchanged if invalid charset is provided in env' do
- env['CONTENT_TYPE'] = 'text/plain; charset=bogus'
+ it "returns the object (string) unchanged if invalid charset is provided in env" do
+ env["CONTENT_TYPE"] = "text/plain; charset=bogus"
expect(described_class.call(umlaut_object_ascii.dup, env)).to eql umlaut_object_ascii
end
diff --git a/spec/lib/api/v3/groups/group_collection_representer_spec.rb b/spec/lib/api/v3/groups/group_collection_representer_spec.rb
index 59d44e4e6b09..e561406c47e9 100644
--- a/spec/lib/api/v3/groups/group_collection_representer_spec.rb
+++ b/spec/lib/api/v3/groups/group_collection_representer_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Groups::GroupCollectionRepresenter do
- let(:self_base_link) { '/api/v3/groups' }
+ let(:self_base_link) { "/api/v3/groups" }
let(:groups) do
build_stubbed_list(:group, 3).tap do |groups|
allow(groups)
@@ -59,13 +59,13 @@
let(:page) { 1 }
let(:page_size) { 2 }
let(:actual_count) { 3 }
- let(:collection_inner_type) { 'Group' }
+ let(:collection_inner_type) { "Group" }
include API::V3::Utilities::PathHelper
- context 'generation' do
+ context "generation" do
subject(:collection) { representer.to_json }
- it_behaves_like 'offset-paginated APIv3 collection', 3, 'groups', 'Group'
+ it_behaves_like "offset-paginated APIv3 collection", 3, "groups", "Group"
end
end
diff --git a/spec/lib/api/v3/groups/group_representer_spec.rb b/spec/lib/api/v3/groups/group_representer_spec.rb
index 4e06090f7b24..6acb6102d7e6 100644
--- a/spec/lib/api/v3/groups/group_representer_spec.rb
+++ b/spec/lib/api/v3/groups/group_representer_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Groups::GroupRepresenter, 'rendering' do
+RSpec.describe API::V3::Groups::GroupRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
subject(:generated) { representer.to_json }
@@ -53,20 +53,20 @@
end
end
- describe '_links' do
- describe 'self' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ describe "self" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.group group.id }
let(:title) { group.name }
end
end
- describe 'members' do
- let(:link) { 'members' }
+ describe "members" do
+ let(:link) { "members" }
- context 'with the necessary permissions' do
- it_behaves_like 'has a link collection' do
+ context "with the necessary permissions" do
+ it_behaves_like "has a link collection" do
let(:hrefs) do
members.map do |member|
{
@@ -78,13 +78,13 @@
end
end
- context 'without the necessary permissions' do
+ context "without the necessary permissions" do
let(:permissions) { [] }
- it_behaves_like 'has no link'
+ it_behaves_like "has no link"
end
- context 'when first having the necessary permissions and then not (caching)' do
+ context "when first having the necessary permissions and then not (caching)" do
before do
representer.to_json
# here the json will have links, afterwards we change the permissions
@@ -92,104 +92,104 @@
mock_permissions_for(current_user, &:forbid_everything)
end
- it_behaves_like 'has no link'
+ it_behaves_like "has no link"
end
end
- describe 'updateImmediately' do
- let(:link) { 'updateImmediately' }
+ describe "updateImmediately" do
+ let(:link) { "updateImmediately" }
- context 'with the necessary permissions' do
+ context "with the necessary permissions" do
let(:current_user_admin) { true }
- it_behaves_like 'has an untitled link' do
+ it_behaves_like "has an untitled link" do
let(:href) { api_v3_paths.group group.id }
end
end
- context 'without the necessary permissions' do
+ context "without the necessary permissions" do
let(:current_user_admin) { false }
- it_behaves_like 'has no link'
+ it_behaves_like "has no link"
end
end
- describe 'delete' do
- let(:link) { 'delete' }
+ describe "delete" do
+ let(:link) { "delete" }
- context 'with the necessary permissions' do
+ context "with the necessary permissions" do
let(:current_user_admin) { true }
- it_behaves_like 'has an untitled link' do
+ it_behaves_like "has an untitled link" do
let(:href) { api_v3_paths.group group.id }
end
end
- context 'without the necessary permissions' do
+ context "without the necessary permissions" do
let(:current_user_admin) { false }
- it_behaves_like 'has no link'
+ it_behaves_like "has no link"
end
end
end
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'Group' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "Group" }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { group.id }
end
- it_behaves_like 'property', :name do
+ it_behaves_like "property", :name do
let(:value) { group.name }
end
- describe 'createdAt' do
- context 'without admin' do
- it 'hides the createdAt property' do
- expect(subject).not_to have_json_path('createdAt')
+ describe "createdAt" do
+ context "without admin" do
+ it "hides the createdAt property" do
+ expect(subject).not_to have_json_path("createdAt")
end
end
- context 'with an admin' do
+ context "with an admin" do
let(:current_user) { build_stubbed(:admin) }
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { group.created_at }
- let(:json_path) { 'createdAt' }
+ let(:json_path) { "createdAt" }
end
end
end
- describe 'updatedAt' do
- context 'without admin' do
- it 'hides the updatedAt property' do
- expect(subject).not_to have_json_path('updatedAt')
+ describe "updatedAt" do
+ context "without admin" do
+ it "hides the updatedAt property" do
+ expect(subject).not_to have_json_path("updatedAt")
end
end
- context 'with an admin' do
+ context "with an admin" do
let(:current_user) { build_stubbed(:admin) }
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { group.updated_at }
- let(:json_path) { 'updatedAt' }
+ let(:json_path) { "updatedAt" }
end
end
end
end
- describe '_embedded' do
- describe 'members' do
- let(:embedded_path) { '_embedded/members' }
+ describe "_embedded" do
+ describe "members" do
+ let(:embedded_path) { "_embedded/members" }
- context 'with the necessary permissions' do
- it 'has an array of users embedded' do
+ context "with the necessary permissions" do
+ it "has an array of users embedded" do
members.each_with_index do |user, index|
expect(subject)
- .to be_json_eql('User'.to_json)
+ .to be_json_eql("User".to_json)
.at_path("#{embedded_path}/#{index}/_type")
expect(subject)
@@ -199,10 +199,10 @@
end
end
- context 'without the necessary permissions' do
+ context "without the necessary permissions" do
let(:permissions) { [] }
- it 'has no members embedded' do
+ it "has no members embedded" do
expect(subject)
.not_to have_json_path embedded_path
end
@@ -210,10 +210,10 @@
end
end
- describe 'caching' do
+ describe "caching" do
let(:embed_links) { false }
- it 'is based on the representer\'s cache_key' do
+ it "is based on the representer's cache_key" do
expect(OpenProject::Cache)
.to receive(:fetch)
.with(representer.json_cache_key)
@@ -222,22 +222,22 @@
representer.to_json
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let!(:former_cache_key) { representer.json_cache_key }
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'Groups', 'GroupRepresenter')
+ .to include("API", "V3", "Groups", "GroupRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
I18n.with_locale(:fr) do
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
end
- it 'changes when the group is updated' do
+ it "changes when the group is updated" do
group.updated_at = Time.now + 20.seconds
expect(representer.json_cache_key)
diff --git a/spec/lib/api/v3/groups/group_sql_representer_rendering_spec.rb b/spec/lib/api/v3/groups/group_sql_representer_rendering_spec.rb
index 36667bc52db2..92e6aec80d3c 100644
--- a/spec/lib/api/v3/groups/group_sql_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/groups/group_sql_representer_rendering_spec.rb
@@ -24,9 +24,9 @@
#
# See COPYRIGHT and LICENSE files for more details.
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Groups::GroupSqlRepresenter, 'rendering' do
+RSpec.describe API::V3::Groups::GroupSqlRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
subject(:json) do
@@ -45,13 +45,13 @@
let(:group) { create(:group) }
- let(:select) { { '*' => {} } }
+ let(:select) { { "*" => {} } }
current_user do
create(:user)
end
- context 'when rendering all supported properties' do
+ context "when rendering all supported properties" do
let(:expected) do
{
_type: "Group",
@@ -66,7 +66,7 @@
}
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql(expected.to_json)
end
diff --git a/spec/lib/api/v3/help_texts/help_text_collection_representer_spec.rb b/spec/lib/api/v3/help_texts/help_text_collection_representer_spec.rb
index 0fc73248f65a..894594515edb 100644
--- a/spec/lib/api/v3/help_texts/help_text_collection_representer_spec.rb
+++ b/spec/lib/api/v3/help_texts/help_text_collection_representer_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::HelpTexts::HelpTextCollectionRepresenter do
let!(:help_texts) do
[
- build_stubbed(:work_package_help_text, attribute_name: 'id'),
- build_stubbed(:work_package_help_text, attribute_name: 'status')
+ build_stubbed(:work_package_help_text, attribute_name: "id"),
+ build_stubbed(:work_package_help_text, attribute_name: "status")
]
end
let(:representer) do
@@ -44,15 +44,15 @@
let(:user) { build_stubbed(:user) }
def self_link
- 'a link that is provided'
+ "a link that is provided"
end
- context 'generation' do
+ context "generation" do
subject(:collection) { representer.to_json }
- it_behaves_like 'unpaginated APIv3 collection',
+ it_behaves_like "unpaginated APIv3 collection",
2,
- 'a link that is provided',
- 'HelpText'
+ "a link that is provided",
+ "HelpText"
end
end
diff --git a/spec/lib/api/v3/help_texts/help_text_representer_spec.rb b/spec/lib/api/v3/help_texts/help_text_representer_spec.rb
index a2f5d7312b3b..3813f1a28825 100644
--- a/spec/lib/api/v3/help_texts/help_text_representer_spec.rb
+++ b/spec/lib/api/v3/help_texts/help_text_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::HelpTexts::HelpTextRepresenter do
include API::V3::Utilities::PathHelper
@@ -35,8 +35,8 @@
let(:help_text) do
build_stubbed(:work_package_help_text,
- attribute_name: 'status',
- help_text: 'This is a help text for **status** attribute.')
+ attribute_name: "status",
+ help_text: "This is a help text for **status** attribute.")
end
let(:representer) { described_class.new help_text, current_user: user }
@@ -65,14 +65,14 @@
"attribute" => "status",
"attributeCaption" => "Status",
"helpText" => {
- "format" => 'markdown',
- "raw" => 'This is a help text for **status** attribute.',
+ "format" => "markdown",
+ "raw" => "This is a help text for **status** attribute.",
"html" => '
This is a help text for status attribute.
'
}
}
end
- it 'serializes the relation correctly' do
+ it "serializes the relation correctly" do
data = JSON.parse representer.to_json
expect(data).to eq result
end
diff --git a/spec/lib/api/v3/memberships/membership_collection_representer_spec.rb b/spec/lib/api/v3/memberships/membership_collection_representer_spec.rb
index 988de06424ee..96799c7f6e65 100644
--- a/spec/lib/api/v3/memberships/membership_collection_representer_spec.rb
+++ b/spec/lib/api/v3/memberships/membership_collection_representer_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Memberships::MembershipCollectionRepresenter do
- let(:self_base_link) { '/api/v3/members' }
+ let(:self_base_link) { "/api/v3/members" }
let(:members) do
build_stubbed_list(:member, 3).tap do |members|
allow(members)
@@ -59,13 +59,13 @@
let(:page) { 1 }
let(:page_size) { 2 }
let(:actual_count) { 3 }
- let(:collection_inner_type) { 'Membership' }
+ let(:collection_inner_type) { "Membership" }
include API::V3::Utilities::PathHelper
- context 'generation' do
+ context "generation" do
subject(:collection) { representer.to_json }
- it_behaves_like 'offset-paginated APIv3 collection', 3, 'members', 'Membership'
+ it_behaves_like "offset-paginated APIv3 collection", 3, "members", "Membership"
end
end
diff --git a/spec/lib/api/v3/memberships/membership_payload_representer_spec.rb b/spec/lib/api/v3/memberships/membership_payload_representer_spec.rb
index 5cc8d17e0b58..417ddf586855 100644
--- a/spec/lib/api/v3/memberships/membership_payload_representer_spec.rb
+++ b/spec/lib/api/v3/memberships/membership_payload_representer_spec.rb
@@ -26,31 +26,31 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Memberships::MembershipPayloadRepresenter do
let(:membership) { build_stubbed(:member) }
current_user { build_stubbed(:user) }
- describe 'generation' do
+ describe "generation" do
subject(:json) { representer.to_json }
- describe '_meta' do
- describe 'notificationMessage' do
- let(:meta) { OpenStruct.new notifiation_message: 'Come to the dark side' }
+ describe "_meta" do
+ describe "notificationMessage" do
+ let(:meta) { OpenStruct.new notifiation_message: "Come to the dark side" }
let(:representer) do
described_class.create(membership,
meta:,
current_user:)
end
- it_behaves_like 'formattable property', :'_meta/notificationMessage' do
+ it_behaves_like "formattable property", :"_meta/notificationMessage" do
let(:value) { meta.notification_message }
end
end
- describe 'sendNotifications' do
+ describe "sendNotifications" do
let(:meta) { OpenStruct.new send_notifications: true }
let(:representer) do
described_class.create(membership,
@@ -58,14 +58,14 @@
current_user:)
end
- it_behaves_like 'property', :'_meta/sendNotifications' do
+ it_behaves_like "property", :"_meta/sendNotifications" do
let(:value) { true }
end
end
end
end
- describe 'parsing' do
+ describe "parsing" do
subject(:parsed) { representer.from_hash parsed_hash }
let(:representer) do
@@ -74,25 +74,25 @@
current_user:)
end
- describe '_meta' do
- context 'with meta set' do
+ describe "_meta" do
+ context "with meta set" do
let(:parsed_hash) do
{
- '_meta' => {
- 'notificationMessage' => {
- "raw" => 'Come to the dark side'
+ "_meta" => {
+ "notificationMessage" => {
+ "raw" => "Come to the dark side"
},
- 'sendNotifications' => true
+ "sendNotifications" => true
}
}
end
- it 'sets the parsed message' do
+ it "sets the parsed message" do
expect(parsed.meta.notification_message)
- .to eql 'Come to the dark side'
+ .to eql "Come to the dark side"
end
- it 'sets the notification sending configuration' do
+ it "sets the notification sending configuration" do
expect(parsed.meta.send_notifications)
.to be_truthy
end
diff --git a/spec/lib/api/v3/memberships/membership_representer_rendering_spec.rb b/spec/lib/api/v3/memberships/membership_representer_rendering_spec.rb
index 4b204f033986..7d99c8a882f0 100644
--- a/spec/lib/api/v3/memberships/membership_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/memberships/membership_representer_rendering_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Memberships::MembershipRepresenter, 'rendering' do
+RSpec.describe API::V3::Memberships::MembershipRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
let(:member) do
@@ -70,95 +70,95 @@
end
end
- describe '_links' do
- describe 'self' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ describe "self" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.membership member.id }
let(:title) { user.name }
end
end
- describe 'schema' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'schema' }
+ describe "schema" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "schema" }
let(:href) { api_v3_paths.membership_schema }
end
end
- describe 'to update' do
- context 'if manage members permissions are granted' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'update' }
+ describe "to update" do
+ context "if manage members permissions are granted" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "update" }
let(:href) { api_v3_paths.membership_form(member.id) }
end
end
- describe 'if manage members permissions are lacking' do
+ describe "if manage members permissions are lacking" do
let(:permissions) { [] }
- it_behaves_like 'has no link' do
- let(:link) { 'update' }
+ it_behaves_like "has no link" do
+ let(:link) { "update" }
end
end
end
- describe 'to updateImmediately' do
- context 'if manage members permissions are granted' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'updateImmediately' }
+ describe "to updateImmediately" do
+ context "if manage members permissions are granted" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "updateImmediately" }
let(:href) { api_v3_paths.membership(member.id) }
end
end
- describe 'if manage members permissions are lacking' do
+ describe "if manage members permissions are lacking" do
let(:permissions) { [] }
- it_behaves_like 'has no link' do
- let(:link) { 'updateImmediately' }
+ it_behaves_like "has no link" do
+ let(:link) { "updateImmediately" }
end
end
end
- describe 'project' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'project' }
+ describe "project" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "project" }
let(:href) { api_v3_paths.project(project.id) }
let(:title) { project.name }
end
- context 'for a global member' do
+ context "for a global member" do
let(:project) { nil }
- it_behaves_like 'has an empty link' do
- let(:link) { 'project' }
+ it_behaves_like "has an empty link" do
+ let(:link) { "project" }
end
end
end
- describe 'principal' do
- context 'for a user principal' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'principal' }
+ describe "principal" do
+ context "for a user principal" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "principal" }
let(:href) { api_v3_paths.user(user.id) }
let(:title) { user.name }
end
end
- context 'for a group principal' do
+ context "for a group principal" do
let(:principal) { group }
- it_behaves_like 'has a titled link' do
- let(:link) { 'principal' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "principal" }
let(:href) { api_v3_paths.group(group.id) }
let(:title) { group.name }
end
end
end
- describe 'roles' do
- it_behaves_like 'has a link collection' do
- let(:link) { 'roles' }
+ describe "roles" do
+ it_behaves_like "has a link collection" do
+ let(:link) { "roles" }
# excludes member_roles marked for destruction
# and duplicates
let(:hrefs) do
@@ -177,37 +177,37 @@
end
end
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'Membership' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "Membership" }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { member.id }
end
- describe 'createdAt' do
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ describe "createdAt" do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { member.created_at }
- let(:json_path) { 'createdAt' }
+ let(:json_path) { "createdAt" }
end
end
- describe 'updatedAt' do
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ describe "updatedAt" do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { member.updated_at }
- let(:json_path) { 'updatedAt' }
+ let(:json_path) { "updatedAt" }
end
end
end
- describe '_embedded' do
- describe 'project' do
- let(:embedded_path) { '_embedded/project' }
+ describe "_embedded" do
+ describe "project" do
+ let(:embedded_path) { "_embedded/project" }
- it 'has the project embedded' do
+ it "has the project embedded" do
expect(subject)
- .to be_json_eql('Project'.to_json)
+ .to be_json_eql("Project".to_json)
.at_path("#{embedded_path}/_type")
expect(subject)
@@ -215,23 +215,23 @@
.at_path("#{embedded_path}/name")
end
- context 'for a global member' do
+ context "for a global member" do
let(:project) { nil }
- it 'has no project embedded' do
+ it "has no project embedded" do
expect(subject)
.not_to have_json_path(embedded_path)
end
end
end
- describe 'principal' do
- let(:embedded_path) { '_embedded/principal' }
+ describe "principal" do
+ let(:embedded_path) { "_embedded/principal" }
- context 'for a user principal' do
- it 'has the user embedded' do
+ context "for a user principal" do
+ it "has the user embedded" do
expect(subject)
- .to be_json_eql('User'.to_json)
+ .to be_json_eql("User".to_json)
.at_path("#{embedded_path}/_type")
expect(subject)
@@ -240,12 +240,12 @@
end
end
- context 'for a group principal' do
+ context "for a group principal" do
let(:principal) { group }
- it 'has the group embedded' do
+ it "has the group embedded" do
expect(subject)
- .to be_json_eql('Group'.to_json)
+ .to be_json_eql("Group".to_json)
.at_path("#{embedded_path}/_type")
expect(subject)
@@ -255,12 +255,12 @@
end
end
- describe 'roles' do
- let(:embedded_path) { '_embedded/roles' }
+ describe "roles" do
+ let(:embedded_path) { "_embedded/roles" }
- it 'has an array of roles embedded that excludes member_roles marked for destruction' do
+ it "has an array of roles embedded that excludes member_roles marked for destruction" do
expect(subject)
- .to be_json_eql('Role'.to_json)
+ .to be_json_eql("Role".to_json)
.at_path("#{embedded_path}/0/_type")
expect(subject)
@@ -268,7 +268,7 @@
.at_path("#{embedded_path}/0/name")
expect(subject)
- .to be_json_eql('Role'.to_json)
+ .to be_json_eql("Role".to_json)
.at_path("#{embedded_path}/1/_type")
expect(subject)
diff --git a/spec/lib/api/v3/memberships/schemas/membership_schema_representer_spec.rb b/spec/lib/api/v3/memberships/schemas/membership_schema_representer_spec.rb
index 57f69470535b..29a724cf6116 100644
--- a/spec/lib/api/v3/memberships/schemas/membership_schema_representer_spec.rb
+++ b/spec/lib/api/v3/memberships/schemas/membership_schema_representer_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Memberships::Schemas::MembershipSchemaRepresenter do
include API::V3::Utilities::PathHelper
let(:current_user) { build_stubbed(:user) }
- let(:self_link) { '/a/self/link' }
+ let(:self_link) { "/a/self/link" }
let(:embedded) { true }
let(:new_record) { true }
let(:project) { build_stubbed(:project) }
@@ -69,89 +69,89 @@
current_user:)
end
- context 'generation' do
+ context "generation" do
subject(:generated) { representer.to_json }
- describe '_type' do
- it 'is indicated as Schema' do
- expect(subject).to be_json_eql('Schema'.to_json).at_path('_type')
+ describe "_type" do
+ it "is indicated as Schema" do
+ expect(subject).to be_json_eql("Schema".to_json).at_path("_type")
end
end
- describe 'id' do
- let(:path) { 'id' }
+ describe "id" do
+ let(:path) { "id" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Integer' }
- let(:name) { I18n.t('attributes.id') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Integer" }
+ let(:name) { I18n.t("attributes.id") }
let(:required) { true }
let(:writable) { false }
end
end
- describe 'createdAt' do
- let(:path) { 'createdAt' }
+ describe "createdAt" do
+ let(:path) { "createdAt" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'DateTime' }
- let(:name) { Member.human_attribute_name('created_at') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "DateTime" }
+ let(:name) { Member.human_attribute_name("created_at") }
let(:required) { true }
let(:writable) { false }
end
end
- describe 'updatedAt' do
- let(:path) { 'updatedAt' }
+ describe "updatedAt" do
+ let(:path) { "updatedAt" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'DateTime' }
- let(:name) { Member.human_attribute_name('updated_at') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "DateTime" }
+ let(:name) { Member.human_attribute_name("updated_at") }
let(:required) { true }
let(:writable) { false }
end
end
- describe 'notificationMessage' do
- let(:path) { 'notificationMessage' }
+ describe "notificationMessage" do
+ let(:path) { "notificationMessage" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Formattable' }
- let(:name) { I18n.t('label_message') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Formattable" }
+ let(:name) { I18n.t("label_message") }
let(:required) { false }
let(:writable) { true }
let(:location) { :_meta }
end
end
- describe 'project' do
- let(:path) { 'project' }
+ describe "project" do
+ let(:path) { "project" }
- context 'if having a new record' do
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Project' }
- let(:name) { Member.human_attribute_name('project') }
+ context "if having a new record" do
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Project" }
+ let(:name) { Member.human_attribute_name("project") }
let(:required) { false }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- context 'if embedding' do
+ context "if embedding" do
let(:embedded) { true }
- context 'if having no principal' do
- it_behaves_like 'links to allowed values via collection link' do
+ context "if having no principal" do
+ it_behaves_like "links to allowed values via collection link" do
let(:href) do
api_v3_paths.memberships_available_projects
end
end
end
- context 'if having a principal' do
+ context "if having a principal" do
let(:assigned_principal) { principal }
- it_behaves_like 'links to allowed values via collection link' do
+ it_behaves_like "links to allowed values via collection link" do
let(:href) do
- filters = [{ 'principal' => { 'operator' => '!', 'values' => [principal.id.to_s] } }]
+ filters = [{ "principal" => { "operator" => "!", "values" => [principal.id.to_s] } }]
api_v3_paths.path_for(:memberships_available_projects, filters:)
end
@@ -159,66 +159,66 @@
end
end
- context 'if not embedding' do
+ context "if not embedding" do
let(:embedded) { false }
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
end
end
- context 'if having a persisted record' do
+ context "if having a persisted record" do
let(:new_record) { false }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Project' }
- let(:name) { Version.human_attribute_name('project') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Project" }
+ let(:name) { Version.human_attribute_name("project") }
let(:required) { false }
let(:writable) { false }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- context 'if embedding' do
+ context "if embedding" do
let(:embedded) { true }
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
end
end
end
- describe 'principal' do
- let(:path) { 'principal' }
+ describe "principal" do
+ let(:path) { "principal" }
- context 'if having a new record' do
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Principal' }
- let(:name) { Version.human_attribute_name('principal') }
+ context "if having a new record" do
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Principal" }
+ let(:name) { Version.human_attribute_name("principal") }
let(:required) { true }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- context 'if embedding' do
+ context "if embedding" do
let(:embedded) { true }
- context 'if having no project' do
- it_behaves_like 'links to allowed values via collection link' do
+ context "if having no project" do
+ it_behaves_like "links to allowed values via collection link" do
let(:href) do
statuses = [Principal.statuses[:locked].to_s]
- filters = [{ 'status' => { 'operator' => '!', 'values' => statuses } }]
+ filters = [{ "status" => { "operator" => "!", "values" => statuses } }]
api_v3_paths.path_for(:principals, filters:)
end
end
end
- context 'if having a project' do
+ context "if having a project" do
let(:assigned_project) { project }
- it_behaves_like 'links to allowed values via collection link' do
+ it_behaves_like "links to allowed values via collection link" do
let(:href) do
statuses = [Principal.statuses[:locked].to_s]
- status_filter = { 'status' => { 'operator' => '!', 'values' => statuses } }
- member_filter = { 'member' => { 'operator' => '!', 'values' => [assigned_project.id.to_s] } }
+ status_filter = { "status" => { "operator" => "!", "values" => statuses } }
+ member_filter = { "member" => { "operator" => "!", "values" => [assigned_project.id.to_s] } }
filters = [status_filter, member_filter]
@@ -228,96 +228,96 @@
end
end
- context 'if not embedding' do
+ context "if not embedding" do
let(:embedded) { false }
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
end
end
- context 'if having a persisted record' do
+ context "if having a persisted record" do
let(:new_record) { false }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Principal' }
- let(:name) { Version.human_attribute_name('principal') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Principal" }
+ let(:name) { Version.human_attribute_name("principal") }
let(:required) { true }
let(:writable) { false }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- context 'if embedding' do
+ context "if embedding" do
let(:embedded) { true }
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
end
end
end
- describe 'roles' do
- let(:path) { 'roles' }
+ describe "roles" do
+ let(:path) { "roles" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { '[]Role' }
- let(:name) { Version.human_attribute_name('role') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "[]Role" }
+ let(:name) { Version.human_attribute_name("role") }
let(:required) { true }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- context 'if embedding' do
+ context "if embedding" do
let(:embedded) { true }
- context 'for a new record' do
- it_behaves_like 'links to allowed values via collection link' do
+ context "for a new record" do
+ it_behaves_like "links to allowed values via collection link" do
let(:href) do
api_v3_paths.path_for(:roles)
end
end
end
- context 'for a persisted record without project (global)' do
+ context "for a persisted record without project (global)" do
let(:assigned_project) { nil }
let(:new_record) { false }
- it_behaves_like 'links to allowed values via collection link' do
+ it_behaves_like "links to allowed values via collection link" do
let(:href) do
- api_v3_paths.path_for(:roles, filters: [{ unit: { operator: '=', values: ['system'] } }])
+ api_v3_paths.path_for(:roles, filters: [{ unit: { operator: "=", values: ["system"] } }])
end
end
end
- context 'for a persisted record with project (global)' do
+ context "for a persisted record with project (global)" do
let(:assigned_project) { project }
let(:new_record) { false }
- it_behaves_like 'links to allowed values via collection link' do
+ it_behaves_like "links to allowed values via collection link" do
let(:href) do
- api_v3_paths.path_for(:roles, filters: [{ unit: { operator: '=', values: ['project'] } }])
+ api_v3_paths.path_for(:roles, filters: [{ unit: { operator: "=", values: ["project"] } }])
end
end
end
end
- context 'if not embedding' do
+ context "if not embedding" do
let(:embedded) { false }
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
end
end
- context '_links' do
- describe 'self link' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ context "_links" do
+ describe "self link" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { self_link }
end
- context 'embedded in a form' do
+ context "embedded in a form" do
let(:self_link) { nil }
- it_behaves_like 'has no link' do
- let(:link) { 'self' }
+ it_behaves_like "has no link" do
+ let(:link) { "self" }
end
end
end
diff --git a/spec/lib/api/v3/news/news_representer_rendering_spec.rb b/spec/lib/api/v3/news/news_representer_rendering_spec.rb
index d8e4fbbf9c11..0a9ffe61eaee 100644
--- a/spec/lib/api/v3/news/news_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/news/news_representer_rendering_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::News::NewsRepresenter, 'rendering' do
+RSpec.describe API::V3::News::NewsRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
let(:news) do
@@ -46,71 +46,71 @@
subject { representer.to_json }
- describe '_links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.news news.id }
let(:title) { news.title }
end
- it_behaves_like 'has a titled link' do
+ it_behaves_like "has a titled link" do
let(:link) { :project }
let(:title) { project.name }
let(:href) { api_v3_paths.project project.id }
end
- it_behaves_like 'has a titled link' do
+ it_behaves_like "has a titled link" do
let(:link) { :author }
let(:title) { user.name }
let(:href) { api_v3_paths.user user.id }
end
end
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'News' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "News" }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { news.id }
end
- it_behaves_like 'property', :title do
+ it_behaves_like "property", :title do
let(:value) { news.title }
end
- it_behaves_like 'property', :summary do
+ it_behaves_like "property", :summary do
let(:value) { news.summary }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { news.created_at }
- let(:json_path) { 'createdAt' }
+ let(:json_path) { "createdAt" }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { news.updated_at }
- let(:json_path) { 'updatedAt' }
+ let(:json_path) { "updatedAt" }
end
- it_behaves_like 'API V3 formattable', 'description' do
- let(:format) { 'markdown' }
+ it_behaves_like "API V3 formattable", "description" do
+ let(:format) { "markdown" }
let(:raw) { news.description }
- let(:html) { '
' + news.description + '
' }
+ let(:html) { '
' + news.description + "
" }
end
end
- describe '_embedded' do
- it 'has project embedded' do
+ describe "_embedded" do
+ it "has project embedded" do
expect(subject)
.to be_json_eql(project.name.to_json)
- .at_path('_embedded/project/name')
+ .at_path("_embedded/project/name")
end
- it 'has author embedded' do
+ it "has author embedded" do
expect(subject)
.to be_json_eql(user.name.to_json)
- .at_path('_embedded/author/name')
+ .at_path("_embedded/author/name")
end
end
end
diff --git a/spec/lib/api/v3/notifications/notification_collection_representer_spec.rb b/spec/lib/api/v3/notifications/notification_collection_representer_spec.rb
index 2a536f958165..fc43ac6d866f 100644
--- a/spec/lib/api/v3/notifications/notification_collection_representer_spec.rb
+++ b/spec/lib/api/v3/notifications/notification_collection_representer_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Notifications::NotificationCollectionRepresenter do
- let(:self_base_link) { '/api/v3/notifications' }
+ let(:self_base_link) { "/api/v3/notifications" }
let(:user) { build_stubbed(:user) }
let(:notification_list) { build_stubbed_list(:notification, 3) }
let(:notifications) do
@@ -62,7 +62,7 @@
let(:page) { 1 }
let(:page_size) { 2 }
let(:actual_count) { 3 }
- let(:collection_inner_type) { 'Notification' }
+ let(:collection_inner_type) { "Notification" }
let(:groups) { nil }
include API::V3::Utilities::PathHelper
@@ -74,82 +74,82 @@
.and_return(notifications)
end
- describe 'generation' do
+ describe "generation" do
subject(:collection) { representer.to_json }
- it_behaves_like 'offset-paginated APIv3 collection', 3, 'notifications', 'Notification'
+ it_behaves_like "offset-paginated APIv3 collection", 3, "notifications", "Notification"
- context 'when passing groups' do
+ context "when passing groups" do
let(:groups) do
[
- { value: 'mentioned', count: 34 },
- { value: 'involved', count: 5 }
+ { value: "mentioned", count: 34 },
+ { value: "involved", count: 5 }
]
end
- it 'renders the groups object as json' do
- expect(subject).to be_json_eql(groups.to_json).at_path('groups')
+ it "renders the groups object as json" do
+ expect(subject).to be_json_eql(groups.to_json).at_path("groups")
end
end
- describe 'detailsSchema' do
- context 'when no date alert notifications are present' do
- it 'does not renders the detailsSchemas' do
- expect(subject).not_to have_json_path('_embedded/detailsSchemas')
+ describe "detailsSchema" do
+ context "when no date alert notifications are present" do
+ it "does not renders the detailsSchemas" do
+ expect(subject).not_to have_json_path("_embedded/detailsSchemas")
end
end
- shared_examples_for 'rendering detailsSchemas' do |reasons: [], expected_schemas: reasons|
+ shared_examples_for "rendering detailsSchemas" do |reasons: [], expected_schemas: reasons|
before do
reasons.each_with_index do |reason, idx|
notifications[idx].reason = reason
end
end
- it 'renders the required detailsSchemas' do
+ it "renders the required detailsSchemas" do
properties = expected_schemas.map do |reason|
API::V3::Notifications::PropertyFactory::PROPERTY_FOR_REASON[reason.to_sym]
end
details_schemas = API::V3::Values::Schemas::ValueSchemaFactory.all_for(properties)
- expect(subject).to be_json_eql(details_schemas.to_json).at_path('_embedded/detailsSchemas')
+ expect(subject).to be_json_eql(details_schemas.to_json).at_path("_embedded/detailsSchemas")
end
end
- context 'when a start date notification is present' do
- it_behaves_like 'rendering detailsSchemas', reasons: ['date_alert_start_date']
+ context "when a start date notification is present" do
+ it_behaves_like "rendering detailsSchemas", reasons: ["date_alert_start_date"]
end
- context 'when a due date notification is present' do
- it_behaves_like 'rendering detailsSchemas', reasons: ['date_alert_due_date']
+ context "when a due date notification is present" do
+ it_behaves_like "rendering detailsSchemas", reasons: ["date_alert_due_date"]
end
- context 'when a due date and a start date notification is present for a milestone work package' do
+ context "when a due date and a start date notification is present for a milestone work package" do
let(:notification_list) { build_stubbed_list(:notification, 3, :for_milestone) }
- it_behaves_like 'rendering detailsSchemas',
- reasons: ['date_alert_due_date', 'date_alert_start_date'],
- expected_schemas: ['date_alert_date']
+ it_behaves_like "rendering detailsSchemas",
+ reasons: ["date_alert_due_date", "date_alert_start_date"],
+ expected_schemas: ["date_alert_date"]
end
- context 'when both date alert notifications are present' do
- it_behaves_like 'rendering detailsSchemas', reasons: ['date_alert_start_date', 'date_alert_due_date']
+ context "when both date alert notifications are present" do
+ it_behaves_like "rendering detailsSchemas", reasons: ["date_alert_start_date", "date_alert_due_date"]
end
- context 'when a list of mixed date alerts are present' do
+ context "when a list of mixed date alerts are present" do
let(:notification_list) do
[
- build_stubbed(:notification, :for_milestone, reason: 'date_alert_start_date'),
- build_stubbed(:notification, reason: 'date_alert_start_date'),
- build_stubbed(:notification, :for_milestone, reason: 'date_alert_due_date'),
- build_stubbed(:notification, reason: 'date_alert_due_date')
+ build_stubbed(:notification, :for_milestone, reason: "date_alert_start_date"),
+ build_stubbed(:notification, reason: "date_alert_start_date"),
+ build_stubbed(:notification, :for_milestone, reason: "date_alert_due_date"),
+ build_stubbed(:notification, reason: "date_alert_due_date")
]
end
- it_behaves_like 'rendering detailsSchemas',
+ it_behaves_like "rendering detailsSchemas",
expected_schemas: [
- 'date_alert_date',
- 'date_alert_start_date',
- 'date_alert_due_date'
+ "date_alert_date",
+ "date_alert_start_date",
+ "date_alert_due_date"
]
end
end
diff --git a/spec/lib/api/v3/notifications/notification_representer_rendering_spec.rb b/spec/lib/api/v3/notifications/notification_representer_rendering_spec.rb
index c8aea67efe42..595e2e779bb1 100644
--- a/spec/lib/api/v3/notifications/notification_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/notifications/notification_representer_rendering_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Notifications::NotificationRepresenter, 'rendering' do
+RSpec.describe API::V3::Notifications::NotificationRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
subject(:generated) { representer.to_json }
@@ -59,56 +59,56 @@
let(:embed_links) { false }
let(:read_ian) { false }
- describe 'self link' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ describe "self link" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.notification notification.id }
end
end
- describe 'IAN read and unread links' do
- context 'when unread' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'readIAN' }
+ describe "IAN read and unread links" do
+ context "when unread" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "readIAN" }
let(:href) { api_v3_paths.notification_read_ian notification.id }
let(:method) { :post }
end
- it_behaves_like 'has no link' do
- let(:link) { 'unreadIAN' }
+ it_behaves_like "has no link" do
+ let(:link) { "unreadIAN" }
end
end
- context 'when read' do
+ context "when read" do
let(:read_ian) { true }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'unreadIAN' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "unreadIAN" }
let(:href) { api_v3_paths.notification_unread_ian notification.id }
let(:method) { :post }
end
- it_behaves_like 'has no link' do
- let(:link) { 'readIAN' }
+ it_behaves_like "has no link" do
+ let(:link) { "readIAN" }
end
end
end
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'Notification' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "Notification" }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { notification.id }
end
- describe 'reason' do
+ describe "reason" do
(Notification::REASONS.keys - %i[date_alert_start_date date_alert_due_date]).each do |notification_reason|
context "for a #{notification_reason} reason" do
let(:reason) { notification_reason }
- it_behaves_like 'property', :reason do
+ it_behaves_like "property", :reason do
let(:value) { notification_reason }
end
end
@@ -118,39 +118,39 @@
context "for a #{notification_reason} reason" do
let(:reason) { notification_reason }
- it_behaves_like 'property', :reason do
- let(:value) { 'dateAlert' }
+ it_behaves_like "property", :reason do
+ let(:value) { "dateAlert" }
end
end
end
end
- it_behaves_like 'datetime property', :createdAt do
+ it_behaves_like "datetime property", :createdAt do
let(:value) { notification.created_at }
end
- it_behaves_like 'datetime property', :updatedAt do
+ it_behaves_like "datetime property", :updatedAt do
let(:value) { notification.updated_at }
end
- it 'is expected to not have a message' do
- expect(subject).not_to have_json_path('message')
+ it "is expected to not have a message" do
+ expect(subject).not_to have_json_path("message")
end
end
- describe 'project' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'project' }
+ describe "project" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "project" }
let(:href) { api_v3_paths.project project.id }
let(:title) { project.name }
end
- context 'when embedding is true' do
+ context "when embedding is true" do
let(:embed_links) { true }
- it 'embeds the context' do
+ it "embeds the context" do
expect(generated)
- .to be_json_eql('Project'.to_json)
+ .to be_json_eql("Project".to_json)
.at_path("_embedded/project/_type")
expect(generated)
@@ -160,109 +160,109 @@
end
end
- describe 'resource polymorphic resource' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'resource' }
+ describe "resource polymorphic resource" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "resource" }
let(:title) { resource.subject }
let(:href) { api_v3_paths.work_package resource.id }
end
- context 'when embedding is true' do
+ context "when embedding is true" do
let(:embed_links) { true }
- it 'embeds the resource' do
+ it "embeds the resource" do
expect(generated)
- .to be_json_eql('WorkPackage'.to_json)
+ .to be_json_eql("WorkPackage".to_json)
.at_path("_embedded/resource/_type")
end
end
end
- describe 'actor' do
- context 'when not set' do
- it_behaves_like 'has no link' do
- let(:link) { 'actor' }
+ describe "actor" do
+ context "when not set" do
+ it_behaves_like "has no link" do
+ let(:link) { "actor" }
end
end
- context 'when set' do
+ context "when set" do
let(:actor) { create(:user) }
- it_behaves_like 'has a titled link' do
- let(:link) { 'actor' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "actor" }
let(:href) { api_v3_paths.user actor.id }
let(:title) { actor.name }
end
end
end
- describe 'journal' do
- context 'when not set' do
- it_behaves_like 'has no link' do
- let(:link) { 'activity' }
+ describe "journal" do
+ context "when not set" do
+ it_behaves_like "has no link" do
+ let(:link) { "activity" }
end
end
- context 'when set' do
+ context "when set" do
let(:journal) { build_stubbed(:work_package_journal) }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'activity' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "activity" }
let(:href) { api_v3_paths.activity journal.id }
end
- context 'when embedding is true' do
+ context "when embedding is true" do
let(:embed_links) { true }
- it 'embeds the resource' do
+ it "embeds the resource" do
expect(generated)
- .to be_json_eql('Activity'.to_json)
+ .to be_json_eql("Activity".to_json)
.at_path("_embedded/activity/_type")
end
end
end
end
- describe 'details' do
- shared_examples_for 'embeds a Values::Property for startDate' do
- it 'embeds a Values::Property' do
+ describe "details" do
+ shared_examples_for "embeds a Values::Property for startDate" do
+ it "embeds a Values::Property" do
expect(generated)
- .to be_json_eql('Values::Property'.to_json)
+ .to be_json_eql("Values::Property".to_json)
.at_path("_embedded/details/0/_type")
end
- it 'has a startDate value for the `property` property' do
+ it "has a startDate value for the `property` property" do
expect(generated)
- .to be_json_eql('startDate'.to_json)
+ .to be_json_eql("startDate".to_json)
.at_path("_embedded/details/0/property")
end
- it 'has a work_package`s start_date for the value' do
+ it "has a work_package`s start_date for the value" do
expect(generated)
.to be_json_eql(resource.start_date.to_json)
.at_path("_embedded/details/0/value")
end
end
- context 'for a dateAlert when embedding' do
+ context "for a dateAlert when embedding" do
let(:reason) { :date_alert_start_date }
let(:embed_links) { true }
- it_behaves_like 'embeds a Values::Property for startDate'
+ it_behaves_like "embeds a Values::Property for startDate"
end
- context 'for a dateAlert when not embedding' do
+ context "for a dateAlert when not embedding" do
let(:reason) { :date_alert_start_date }
let(:embed_links) { false }
- it_behaves_like 'embeds a Values::Property for startDate'
+ it_behaves_like "embeds a Values::Property for startDate"
end
- context 'for a mention when embedding' do
+ context "for a mention when embedding" do
let(:reason) { :mentioned }
let(:embed_links) { true }
- it 'has an empty details array' do
+ it "has an empty details array" do
expect(generated)
.to have_json_size(0)
.at_path("_embedded/details")
diff --git a/spec/lib/api/v3/notifications/property_factory_spec.rb b/spec/lib/api/v3/notifications/property_factory_spec.rb
index e8fe05ab5819..f76da0c16aed 100644
--- a/spec/lib/api/v3/notifications/property_factory_spec.rb
+++ b/spec/lib/api/v3/notifications/property_factory_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Notifications::PropertyFactory do
let(:traits) { [] }
@@ -38,21 +38,21 @@
reason:)
end
- describe '.details_for' do
- context 'for a date_alert_start_date notification' do
+ describe ".details_for" do
+ context "for a date_alert_start_date notification" do
let(:reason) { :date_alert_start_date }
- it 'returns one detail' do
+ it "returns one detail" do
expect(described_class.details_for(notification).size)
.to eq 1
end
- it 'returns an array of `Values::Property` representers' do
+ it "returns an array of `Values::Property` representers" do
expect(described_class.details_for(notification)[0])
.to be_a API::V3::Values::PropertyDateRepresenter
end
- it 'sets the represented property to :start_date' do
+ it "sets the represented property to :start_date" do
represented = described_class.details_for(notification)[0].represented
expect(represented)
.to be_a API::V3::Values::PropertyModel
@@ -61,20 +61,20 @@
end
end
- context 'for a date_alert_due_date notification' do
+ context "for a date_alert_due_date notification" do
let(:reason) { :date_alert_due_date }
- it 'returns one detail' do
+ it "returns one detail" do
expect(described_class.details_for(notification).size)
.to eq 1
end
- it 'returns an array of `Values::Property` representers' do
+ it "returns an array of `Values::Property` representers" do
expect(described_class.details_for(notification)[0])
.to be_a API::V3::Values::PropertyDateRepresenter
end
- it 'sets the represented property to :due_date' do
+ it "sets the represented property to :due_date" do
represented = described_class.details_for(notification)[0].represented
expect(represented)
.to be_a API::V3::Values::PropertyModel
@@ -83,21 +83,21 @@
end
end
- context 'for a date_alert_due_date notification with milestone work package' do
+ context "for a date_alert_due_date notification with milestone work package" do
let(:traits) { [:is_milestone] }
let(:reason) { :date_alert_due_date }
- it 'returns one detail' do
+ it "returns one detail" do
expect(described_class.details_for(notification).size)
.to eq 1
end
- it 'returns an array of `Values::Property` representers' do
+ it "returns an array of `Values::Property` representers" do
expect(described_class.details_for(notification)[0])
.to be_a API::V3::Values::PropertyDateRepresenter
end
- it 'sets the representer property to :date' do
+ it "sets the representer property to :date" do
represented = described_class.details_for(notification)[0].represented
expect(represented)
.to be_a API::V3::Values::PropertyModel
@@ -110,7 +110,7 @@
context "for a #{possible_reason} notification" do
let(:reason) { possible_reason }
- it 'is an empty array' do
+ it "is an empty array" do
expect(described_class.details_for(notification))
.to eq []
end
@@ -118,21 +118,21 @@
end
end
- describe '.schemas_for' do
- context 'for a date_alert_start_date notification' do
+ describe ".schemas_for" do
+ context "for a date_alert_start_date notification" do
let(:reason) { :date_alert_start_date }
- it 'returns one detail for the same type' do
+ it "returns one detail for the same type" do
expect(described_class.schemas_for([notification, notification]).size)
.to eq 1
end
- it 'returns an array of `Values::Schemas::PropertySchemaRepresenter` representers' do
+ it "returns an array of `Values::Schemas::PropertySchemaRepresenter` representers" do
expect(described_class.schemas_for([notification])[0])
.to be_a API::V3::Values::Schemas::PropertySchemaRepresenter
end
- it 'returns `Values::Schemas::Model` representer for Start Date' do
+ it "returns `Values::Schemas::Model` representer for Start Date" do
representer = described_class.schemas_for([notification])[0].represented
expect(representer)
.to be_a API::V3::Values::Schemas::Model
@@ -141,20 +141,20 @@
end
end
- context 'for a date_alert_due_date notification' do
+ context "for a date_alert_due_date notification" do
let(:reason) { :date_alert_due_date }
- it 'returns one detail for the same type' do
+ it "returns one detail for the same type" do
expect(described_class.schemas_for([notification, notification]).size)
.to eq 1
end
- it 'returns an array of `Values::Schemas::PropertySchemaRepresenter` representers' do
+ it "returns an array of `Values::Schemas::PropertySchemaRepresenter` representers" do
expect(described_class.schemas_for([notification])[0])
.to be_a API::V3::Values::Schemas::PropertySchemaRepresenter
end
- it 'returns `Values::Schemas::Model` representer for Finish date' do
+ it "returns `Values::Schemas::Model` representer for Finish date" do
representer = described_class.schemas_for([notification])[0].represented
expect(representer)
.to be_a API::V3::Values::Schemas::Model
@@ -163,21 +163,21 @@
end
end
- context 'for a date_alert_due_date notification with milestone work package' do
+ context "for a date_alert_due_date notification with milestone work package" do
let(:traits) { [:is_milestone] }
let(:reason) { :date_alert_due_date }
- it 'returns one detail for the same type' do
+ it "returns one detail for the same type" do
expect(described_class.schemas_for([notification, notification]).size)
.to eq 1
end
- it 'returns an array of `Values::Schemas::PropertySchemaRepresenter` representers' do
+ it "returns an array of `Values::Schemas::PropertySchemaRepresenter` representers" do
expect(described_class.schemas_for([notification])[0])
.to be_a API::V3::Values::Schemas::PropertySchemaRepresenter
end
- it 'returns `Values::Schemas::Model` representer for Date' do
+ it "returns `Values::Schemas::Model` representer for Date" do
representer = described_class.schemas_for([notification])[0].represented
expect(representer)
.to be_a API::V3::Values::Schemas::Model
@@ -186,7 +186,7 @@
end
end
- context 'for multiple notifications' do
+ context "for multiple notifications" do
let(:reason) { :date_alert_due_date }
let(:reason_start) { :date_alert_start_date }
@@ -213,17 +213,17 @@
]
end
- it 'returns two details for different types' do
+ it "returns two details for different types" do
expect(described_class.schemas_for(notifications).size)
.to eq 3
end
- it 'returns an array of `Values::Schemas::PropertySchemaRepresenter` representers' do
+ it "returns an array of `Values::Schemas::PropertySchemaRepresenter` representers" do
expect(described_class.schemas_for(notifications))
.to all be_a API::V3::Values::Schemas::PropertySchemaRepresenter
end
- it 'returns `Values::Schemas::Model` representer for Finish date' do
+ it "returns `Values::Schemas::Model` representer for Finish date" do
representers = described_class.schemas_for(notifications).map(&:represented)
expect(representers)
.to all be_a API::V3::Values::Schemas::Model
@@ -240,7 +240,7 @@
context "for a #{possible_reason} notification" do
let(:reason) { possible_reason }
- it 'is an empty array' do
+ it "is an empty array" do
expect(described_class.schemas_for([notification]))
.to eq []
end
@@ -248,29 +248,29 @@
end
end
- describe '.groups_for' do
- context 'with a date_alert_start_date notification' do
+ describe ".groups_for" do
+ context "with a date_alert_start_date notification" do
let(:group_values) { { "date_alert_start_date" => 1 } }
- it 'returns as a date alert' do
+ it "returns as a date alert" do
expect(described_class.groups_for(group_values))
.to eq({ "dateAlert" => 1 })
end
end
- context 'for a date_alert_due_date notification' do
+ context "for a date_alert_due_date notification" do
let(:group_values) { { "date_alert_due_date" => 1 } }
- it 'returns as a date alert' do
+ it "returns as a date alert" do
expect(described_class.groups_for(group_values))
.to eq({ "dateAlert" => 1 })
end
end
- context 'for multiple notifications' do
+ context "for multiple notifications" do
let(:group_values) { { "mentioned" => 1, "date_alert_due_date" => 2, "date_alert_start_date" => 1 } }
- it 'sums up date alerts' do
+ it "sums up date alerts" do
expect(described_class.groups_for(group_values))
.to eq({ "mentioned" => 1, "dateAlert" => 3 })
end
@@ -280,7 +280,7 @@
context "for a #{possible_reason} notification" do
let(:group_values) { { possible_reason => 1 } }
- it 'returns the unaltered reasons' do
+ it "returns the unaltered reasons" do
expect(described_class.groups_for(group_values))
.to eq group_values
end
diff --git a/spec/lib/api/v3/placeholder_users/placeholder_user_collection_representer_spec.rb b/spec/lib/api/v3/placeholder_users/placeholder_user_collection_representer_spec.rb
index 00809cddbc79..1273928ba530 100644
--- a/spec/lib/api/v3/placeholder_users/placeholder_user_collection_representer_spec.rb
+++ b/spec/lib/api/v3/placeholder_users/placeholder_user_collection_representer_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::PlaceholderUsers::PlaceholderUserCollectionRepresenter do
- let(:self_base_link) { '/api/v3/placeholder_users' }
- let(:collection_inner_type) { 'PlaceholderUser' }
+ let(:self_base_link) { "/api/v3/placeholder_users" }
+ let(:collection_inner_type) { "PlaceholderUser" }
let(:total) { 3 }
let(:page) { 1 }
let(:page_size) { 2 }
@@ -65,9 +65,9 @@
current_user:)
end
- context 'generation' do
+ context "generation" do
subject(:collection) { representer.to_json }
- it_behaves_like 'offset-paginated APIv3 collection'
+ it_behaves_like "offset-paginated APIv3 collection"
end
end
diff --git a/spec/lib/api/v3/placeholder_users/placeholder_user_representer_rendering_spec.rb b/spec/lib/api/v3/placeholder_users/placeholder_user_representer_rendering_spec.rb
index 030fa8d2c30c..5dfc16bd6291 100644
--- a/spec/lib/api/v3/placeholder_users/placeholder_user_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/placeholder_users/placeholder_user_representer_rendering_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::PlaceholderUsers::PlaceholderUserRepresenter, 'rendering' do
+RSpec.describe API::V3::PlaceholderUsers::PlaceholderUserRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
let(:placeholder_user) { build_stubbed(:placeholder_user) }
@@ -38,7 +38,7 @@
filters = [
{
principal: {
- operator: '=',
+ operator: "=",
values: [placeholder_user.id.to_s]
}
}
@@ -58,32 +58,32 @@
end
end
- describe '_links' do
- describe 'self' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ describe "self" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.placeholder_user placeholder_user.id }
let(:title) { placeholder_user.name }
end
end
- describe 'showUser' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'showUser' }
+ describe "showUser" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "showUser" }
let(:href) { "/placeholder_users/#{placeholder_user.id}" }
end
end
- describe 'delete' do
- it_behaves_like 'has no link' do
- let(:link) { 'delete' }
+ describe "delete" do
+ it_behaves_like "has no link" do
+ let(:link) { "delete" }
end
- context 'if user is allowed to manage' do
+ context "if user is allowed to manage" do
let(:global_permissions) { [:manage_placeholder_user] }
- it_behaves_like 'has a titled link' do
- let(:link) { 'delete' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "delete" }
let(:href) { "/api/v3/placeholder_users/#{placeholder_user.id}" }
let(:method) { :delete }
let(:title) { "Delete #{placeholder_user.name}" }
@@ -91,16 +91,16 @@
end
end
- describe 'updateImmediately' do
- it_behaves_like 'has no link' do
- let(:link) { 'updateImmediately' }
+ describe "updateImmediately" do
+ it_behaves_like "has no link" do
+ let(:link) { "updateImmediately" }
end
- context 'when user allowed to manage' do
+ context "when user allowed to manage" do
let(:global_permissions) { [:manage_placeholder_user] }
- it_behaves_like 'has a titled link' do
- let(:link) { 'updateImmediately' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "updateImmediately" }
let(:href) { "/api/v3/placeholder_users/#{placeholder_user.id}" }
let(:method) { :patch }
let(:title) { "Update #{placeholder_user.name}" }
@@ -108,26 +108,26 @@
end
end
- describe 'memberships' do
- it_behaves_like 'has no link' do
- let(:link) { 'memberships' }
+ describe "memberships" do
+ it_behaves_like "has no link" do
+ let(:link) { "memberships" }
end
- context 'if user is allowed to see members' do
+ context "if user is allowed to see members" do
let(:project_permissions) { [:view_members] }
- it_behaves_like 'has a titled link' do
- let(:link) { 'memberships' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "memberships" }
let(:href) { memberships_path }
let(:title) { I18n.t(:label_membership_plural) }
end
end
- context 'if user is allowed to manage members' do
+ context "if user is allowed to manage members" do
let(:project_permissions) { [:manage_members] }
- it_behaves_like 'has a titled link' do
- let(:link) { 'memberships' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "memberships" }
let(:href) { memberships_path }
let(:title) { I18n.t(:label_membership_plural) }
end
@@ -135,48 +135,48 @@
end
end
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'PlaceholderUser' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "PlaceholderUser" }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { placeholder_user.id }
end
- it_behaves_like 'property', :name do
+ it_behaves_like "property", :name do
let(:value) { placeholder_user.name }
end
- context 'as regular user' do
- it 'hides the updatedAt property' do
- expect(subject).not_to have_json_path('updatedAt')
+ context "as regular user" do
+ it "hides the updatedAt property" do
+ expect(subject).not_to have_json_path("updatedAt")
end
- it 'hides the createdAt property' do
- expect(subject).not_to have_json_path('createdAt')
+ it "hides the createdAt property" do
+ expect(subject).not_to have_json_path("createdAt")
end
end
- context 'if user is allowed to manage placeholder users' do
+ context "if user is allowed to manage placeholder users" do
let(:global_permissions) { [:manage_placeholder_user] }
- it_behaves_like 'property', :status do
- let(:value) { 'active' }
+ it_behaves_like "property", :status do
+ let(:value) { "active" }
end
- it_behaves_like 'datetime property', :createdAt do
+ it_behaves_like "datetime property", :createdAt do
let(:value) { placeholder_user.created_at }
end
- it_behaves_like 'datetime property', :updatedAt do
+ it_behaves_like "datetime property", :updatedAt do
let(:value) { placeholder_user.updated_at }
end
end
end
- describe 'caching' do
- it 'is based on the representer\'s cache_key' do
+ describe "caching" do
+ it "is based on the representer's cache_key" do
allow(OpenProject::Cache)
.to receive(:fetch)
.and_call_original
@@ -188,22 +188,22 @@
.with(representer.json_cache_key)
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let!(:former_cache_key) { representer.json_cache_key }
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'PlaceholderUsers', 'PlaceholderUserRepresenter')
+ .to include("API", "V3", "PlaceholderUsers", "PlaceholderUserRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
I18n.with_locale(:fr) do
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
end
- it 'changes when the placeholder is updated' do
+ it "changes when the placeholder is updated" do
placeholder_user.updated_at = 20.seconds.from_now
expect(representer.json_cache_key)
diff --git a/spec/lib/api/v3/placeholder_users/placeholder_user_sql_representer_rendering_spec.rb b/spec/lib/api/v3/placeholder_users/placeholder_user_sql_representer_rendering_spec.rb
index f09785c0ae90..8cd0f3f87c7b 100644
--- a/spec/lib/api/v3/placeholder_users/placeholder_user_sql_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/placeholder_users/placeholder_user_sql_representer_rendering_spec.rb
@@ -24,9 +24,9 @@
#
# See COPYRIGHT and LICENSE files for more details.
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::PlaceholderUsers::PlaceholderUserSqlRepresenter, 'rendering' do
+RSpec.describe API::V3::PlaceholderUsers::PlaceholderUserSqlRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
subject(:json) do
@@ -45,13 +45,13 @@
let(:placeholder_user) { create(:placeholder_user) }
- let(:select) { { '*' => {} } }
+ let(:select) { { "*" => {} } }
current_user do
create(:user)
end
- context 'when rendering all supported properties' do
+ context "when rendering all supported properties" do
let(:expected) do
{
_type: "PlaceholderUser",
@@ -66,7 +66,7 @@
}
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql(expected.to_json)
end
diff --git a/spec/lib/api/v3/posts/post_representer_rendering_spec.rb b/spec/lib/api/v3/posts/post_representer_rendering_spec.rb
index 3198e133ccc2..b3ede5e66a34 100644
--- a/spec/lib/api/v3/posts/post_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/posts/post_representer_rendering_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Posts::PostRepresenter, 'rendering' do
+RSpec.describe API::V3::Posts::PostRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
let(:message) do
@@ -48,24 +48,24 @@
subject { representer.to_json }
- describe '_links' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.post message.id }
end
- it_behaves_like 'has an untitled link' do
+ it_behaves_like "has an untitled link" do
let(:link) { :attachments }
let(:href) { api_v3_paths.attachments_by_post message.id }
end
- it_behaves_like 'has a titled link' do
+ it_behaves_like "has a titled link" do
let(:link) { :project }
let(:title) { project.name }
let(:href) { api_v3_paths.project project.id }
end
- it_behaves_like 'has an untitled action link' do
+ it_behaves_like "has an untitled action link" do
let(:link) { :addAttachment }
let(:href) { api_v3_paths.attachments_by_post message.id }
let(:method) { :post }
@@ -73,25 +73,25 @@
end
end
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'Post' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "Post" }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { message.id }
end
- it_behaves_like 'property', :subject do
+ it_behaves_like "property", :subject do
let(:value) { message.subject }
end
end
- describe '_embedded' do
- it 'has project embedded' do
+ describe "_embedded" do
+ it "has project embedded" do
expect(subject)
.to be_json_eql(project.name.to_json)
- .at_path('_embedded/project/name')
+ .at_path("_embedded/project/name")
end
end
end
diff --git a/spec/lib/api/v3/principals/principal_representer_factory_spec.rb b/spec/lib/api/v3/principals/principal_representer_factory_spec.rb
index 687088507bab..9211b1dd823e 100644
--- a/spec/lib/api/v3/principals/principal_representer_factory_spec.rb
+++ b/spec/lib/api/v3/principals/principal_representer_factory_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
class TestRepresenter < API::Decorators::Single
include ::API::Decorators::LinkedResource
@@ -44,191 +44,191 @@ class TestRepresenter < API::Decorators::Single
let(:placeholder) { build_stubbed(:placeholder_user) }
let(:deleted) { build_stubbed(:deleted_user) }
- describe '.create' do
+ describe ".create" do
subject { described_class.create principal, current_user: }
- context 'with a user' do
+ context "with a user" do
let(:principal) { user }
- it 'returns a user representer' do
+ it "returns a user representer" do
expect(subject).to be_a API::V3::Users::UserRepresenter
end
end
- context 'with a group' do
+ context "with a group" do
let(:principal) { group }
- it 'returns a group representer' do
+ it "returns a group representer" do
expect(subject).to be_a API::V3::Groups::GroupRepresenter
end
end
- context 'with a placeholder user' do
+ context "with a placeholder user" do
let(:principal) { placeholder }
- it 'returns a user representer' do
+ it "returns a user representer" do
expect(subject).to be_a API::V3::PlaceholderUsers::PlaceholderUserRepresenter
end
end
- context 'with a deleted user' do
+ context "with a deleted user" do
let(:principal) { deleted }
- it 'returns a user representer' do
+ it "returns a user representer" do
expect(subject).to be_a API::V3::Users::UserRepresenter
end
end
end
- describe '.create_link_lambda' do
+ describe ".create_link_lambda" do
subject(:link) do
TestRepresenter
.new(represented, current_user:)
- .instance_exec(&described_class.create_link_lambda('association'))
+ .instance_exec(&described_class.create_link_lambda("association"))
end
- context 'with a user' do
+ context "with a user" do
let(:principal) { user }
- it 'renders a link to the user' do
+ it "renders a link to the user" do
expect(link)
.to eql({ "href" => "/api/v3/users/5", "title" => principal.name })
end
end
- context 'with a group' do
+ context "with a group" do
let(:principal) { group }
- it 'renders a link to the group' do
+ it "renders a link to the group" do
expect(link)
.to eql({ "href" => "/api/v3/groups/5", "title" => principal.name })
end
end
- context 'with a placeholder user' do
+ context "with a placeholder user" do
let(:principal) { placeholder }
- it 'renders a link to the placeholder' do
+ it "renders a link to the placeholder" do
expect(link)
.to eql({ "href" => "/api/v3/placeholder_users/5", "title" => principal.name })
end
end
- context 'with a deleted user' do
+ context "with a deleted user" do
let(:principal) { deleted }
- it 'renders a link to the user (which is deleted)' do
+ it "renders a link to the user (which is deleted)" do
expect(link)
.to eql({ "href" => "/api/v3/users/5", "title" => principal.name })
end
end
end
- describe '.create_getter_lambda' do
+ describe ".create_getter_lambda" do
subject(:getter) do
TestRepresenter
.new(represented, current_user:, embed_links:)
- .instance_exec(&described_class.create_getter_lambda('association'))
+ .instance_exec(&described_class.create_getter_lambda("association"))
end
let(:embed_links) { true }
- context 'with a user' do
+ context "with a user" do
let(:principal) { user }
- it 'returns a user representer' do
+ it "returns a user representer" do
expect(getter)
.to be_a API::V3::Users::UserRepresenter
end
end
- context 'with a group' do
+ context "with a group" do
let(:principal) { group }
- it 'renders a group representer' do
+ it "renders a group representer" do
expect(getter)
.to be_a API::V3::Groups::GroupRepresenter
end
end
- context 'with a placeholder user' do
+ context "with a placeholder user" do
let(:principal) { placeholder }
- it 'renders a placeholder representer' do
+ it "renders a placeholder representer" do
expect(getter)
.to be_a API::V3::PlaceholderUsers::PlaceholderUserRepresenter
end
end
- context 'with a deleted user' do
+ context "with a deleted user" do
let(:principal) { deleted }
- it 'renders a user representer' do
+ it "renders a user representer" do
expect(getter)
.to be_a API::V3::Users::UserRepresenter
end
end
- context 'with nil' do
+ context "with nil" do
let(:principal) { nil }
- it 'return nil' do
+ it "return nil" do
expect(getter)
.to be_nil
end
end
- context 'without embedding links' do
+ context "without embedding links" do
let(:principal) { user }
let(:embed_links) { false }
- it 'returns a user representer' do
+ it "returns a user representer" do
expect(getter)
.to be_nil
end
end
end
- describe '.create_setter_lambda' do
+ describe ".create_setter_lambda" do
subject(:setter) do
TestRepresenter
.new(represented, current_user: nil)
- .instance_exec(fragment: { "href" => link }, &described_class.create_setter_lambda('association'))
+ .instance_exec(fragment: { "href" => link }, &described_class.create_setter_lambda("association"))
represented.association_id
end
- context 'with a user link' do
+ context "with a user link" do
let(:link) { "/api/v3/users/90" }
- it 'sets the association' do
+ it "sets the association" do
expect(setter)
.to eql("90")
end
end
- context 'with a group link' do
+ context "with a group link" do
let(:link) { "/api/v3/groups/90" }
- it 'sets the association' do
+ it "sets the association" do
expect(setter)
.to eql("90")
end
end
- context 'with a placeholder user link' do
+ context "with a placeholder user link" do
let(:link) { "/api/v3/placeholder_users/90" }
- it 'sets the association' do
+ it "sets the association" do
expect(setter)
.to eql("90")
end
end
- context 'with an invalid link' do
+ context "with an invalid link" do
let(:link) { "/api/v3/schum/90" }
- it 'raises an exception' do
+ it "raises an exception" do
expect { setter }
.to raise_error(API::Errors::InvalidResourceLink)
end
diff --git a/spec/lib/api/v3/principals/principal_sql_representer_rendering_spec.rb b/spec/lib/api/v3/principals/principal_sql_representer_rendering_spec.rb
index 8226277431be..db5c61498fc3 100644
--- a/spec/lib/api/v3/principals/principal_sql_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/principals/principal_sql_representer_rendering_spec.rb
@@ -24,9 +24,9 @@
#
# See COPYRIGHT and LICENSE files for more details.
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Principals::PrincipalSqlRepresenter, 'rendering' do
+RSpec.describe API::V3::Principals::PrincipalSqlRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
subject(:json) do
@@ -46,13 +46,13 @@
let(:group) { create(:group) }
let(:placeholder_user) { create(:placeholder_user) }
- let(:select) { { '*' => {} } }
+ let(:select) { { "*" => {} } }
current_user do
create(:user)
end
- context 'when rendering all supported properties for a group' do
+ context "when rendering all supported properties for a group" do
let(:rendered_principal) { group }
let(:expected) do
@@ -69,13 +69,13 @@
}
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql(expected.to_json)
end
end
- context 'when rendering all supported properties for a placeholder user' do
+ context "when rendering all supported properties for a placeholder user" do
let(:rendered_principal) { placeholder_user }
let(:expected) do
@@ -92,13 +92,13 @@
}
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql(expected.to_json)
end
end
- context 'when rendering all supported properties for a user' do
+ context "when rendering all supported properties for a user" do
let(:rendered_principal) { current_user }
let(:expected) do
@@ -117,15 +117,15 @@
}
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql(expected.to_json)
end
end
- context 'when rendering only the name property for a user' do
+ context "when rendering only the name property for a user" do
let(:rendered_principal) { current_user }
- let(:select) { { 'name' => {} } }
+ let(:select) { { "name" => {} } }
let(:expected) do
{
@@ -133,7 +133,7 @@
}
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql(expected.to_json)
end
diff --git a/spec/lib/api/v3/principals/principal_type_spec.rb b/spec/lib/api/v3/principals/principal_type_spec.rb
index 7d7ae6d44fad..63bf9df8639d 100644
--- a/spec/lib/api/v3/principals/principal_type_spec.rb
+++ b/spec/lib/api/v3/principals/principal_type_spec.rb
@@ -26,65 +26,65 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Principals::PrincipalType do
let(:principal) { nil }
subject { described_class.for(instance) }
- shared_examples 'returns api type' do |type|
+ shared_examples "returns api type" do |type|
it do
expect(subject).to eq type
end
end
- describe 'with a user' do
+ describe "with a user" do
let(:instance) { build_stubbed(:user) }
- it_behaves_like 'returns api type', :user
+ it_behaves_like "returns api type", :user
end
- describe 'with a user' do
+ describe "with a user" do
let(:instance) { build_stubbed(:user) }
- it_behaves_like 'returns api type', :user
+ it_behaves_like "returns api type", :user
end
- describe 'with a system user' do
+ describe "with a system user" do
let(:instance) { User.system }
- it_behaves_like 'returns api type', :user
+ it_behaves_like "returns api type", :user
end
- describe 'with a system user' do
+ describe "with a system user" do
let(:instance) { build_stubbed(:deleted_user) }
- it_behaves_like 'returns api type', :user
+ it_behaves_like "returns api type", :user
end
- describe 'with anonymous' do
+ describe "with anonymous" do
let(:instance) { User.anonymous }
- it_behaves_like 'returns api type', :user
+ it_behaves_like "returns api type", :user
end
- describe 'with a group' do
+ describe "with a group" do
let(:instance) { build_stubbed(:group) }
- it_behaves_like 'returns api type', :group
+ it_behaves_like "returns api type", :group
end
- describe 'with a placeholder' do
+ describe "with a placeholder" do
let(:instance) { build_stubbed(:placeholder_user) }
- it_behaves_like 'returns api type', :placeholder_user
+ it_behaves_like "returns api type", :placeholder_user
end
- describe 'with an invalid type' do
- let(:instance) { 'whatever' }
+ describe "with an invalid type" do
+ let(:instance) { "whatever" }
- it 'raises an exception' do
+ it "raises an exception" do
expect { subject }.to raise_error "undefined subclass for whatever"
end
end
diff --git a/spec/lib/api/v3/priorities/priority_collection_representer_spec.rb b/spec/lib/api/v3/priorities/priority_collection_representer_spec.rb
index ece191ff0b20..5e80364b71ae 100644
--- a/spec/lib/api/v3/priorities/priority_collection_representer_spec.rb
+++ b/spec/lib/api/v3/priorities/priority_collection_representer_spec.rb
@@ -26,17 +26,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Priorities::PriorityCollectionRepresenter do
let(:priorities) { build_list(:priority, 3) }
let(:representer) do
- described_class.new(priorities, self_link: '/api/v3/priorities', current_user: double('current_user'))
+ described_class.new(priorities, self_link: "/api/v3/priorities", current_user: double("current_user"))
end
- context 'generation' do
+ context "generation" do
subject(:collection) { representer.to_json }
- it_behaves_like 'unpaginated APIv3 collection', 3, 'priorities', 'Priority'
+ it_behaves_like "unpaginated APIv3 collection", 3, "priorities", "Priority"
end
end
diff --git a/spec/lib/api/v3/priorities/priority_representer_spec.rb b/spec/lib/api/v3/priorities/priority_representer_spec.rb
index 6a12b5fe4530..1eb10f035626 100644
--- a/spec/lib/api/v3/priorities/priority_representer_spec.rb
+++ b/spec/lib/api/v3/priorities/priority_representer_spec.rb
@@ -26,59 +26,59 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Priorities::PriorityRepresenter do
let(:priority) { build_stubbed(:priority) }
- let(:representer) { described_class.new(priority, current_user: double('current_user')) }
+ let(:representer) { described_class.new(priority, current_user: double("current_user")) }
include API::V3::Utilities::PathHelper
- context 'generation' do
+ context "generation" do
subject { representer.to_json }
- it 'indicates its type' do
- expect(subject).to include_json('Priority'.to_json).at_path('_type')
+ it "indicates its type" do
+ expect(subject).to include_json("Priority".to_json).at_path("_type")
end
- describe 'links' do
- it { is_expected.to have_json_type(Object).at_path('_links') }
+ describe "links" do
+ it { is_expected.to have_json_type(Object).at_path("_links") }
- it 'links to self' do
+ it "links to self" do
path = api_v3_paths.priority(priority.id)
- expect(subject).to be_json_eql(path.to_json).at_path('_links/self/href')
+ expect(subject).to be_json_eql(path.to_json).at_path("_links/self/href")
end
- it 'displays its name as title in self' do
- expect(subject).to be_json_eql(priority.name.to_json).at_path('_links/self/title')
+ it "displays its name as title in self" do
+ expect(subject).to be_json_eql(priority.name.to_json).at_path("_links/self/title")
end
end
- describe 'priority' do
- it 'has an id' do
- expect(subject).to be_json_eql(priority.id.to_json).at_path('id')
+ describe "priority" do
+ it "has an id" do
+ expect(subject).to be_json_eql(priority.id.to_json).at_path("id")
end
- it 'has a name' do
- expect(subject).to be_json_eql(priority.name.to_json).at_path('name')
+ it "has a name" do
+ expect(subject).to be_json_eql(priority.name.to_json).at_path("name")
end
- it 'has a position' do
- expect(subject).to be_json_eql(priority.position.to_json).at_path('position')
+ it "has a position" do
+ expect(subject).to be_json_eql(priority.position.to_json).at_path("position")
end
- it 'has a default flag' do
- expect(subject).to be_json_eql(priority.is_default.to_json).at_path('isDefault')
+ it "has a default flag" do
+ expect(subject).to be_json_eql(priority.is_default.to_json).at_path("isDefault")
end
- it 'has an active flag' do
- expect(subject).to be_json_eql(priority.active.to_json).at_path('isActive')
+ it "has an active flag" do
+ expect(subject).to be_json_eql(priority.active.to_json).at_path("isActive")
end
end
- describe 'caching' do
- it 'is based on the representer\'s cache_key' do
+ describe "caching" do
+ it "is based on the representer's cache_key" do
expect(OpenProject::Cache)
.to receive(:fetch)
.with(representer.json_cache_key)
@@ -87,22 +87,22 @@
representer.to_json
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let!(:former_cache_key) { representer.json_cache_key }
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'Priorities', 'PriorityRepresenter')
+ .to include("API", "V3", "Priorities", "PriorityRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
I18n.with_locale(:fr) do
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
end
- it 'changes when the priority is updated' do
+ it "changes when the priority is updated" do
priority.updated_at = Time.now + 20.seconds
expect(representer.json_cache_key)
diff --git a/spec/lib/api/v3/projects/copy/project_copy_payload_representer_spec.rb b/spec/lib/api/v3/projects/copy/project_copy_payload_representer_spec.rb
index c836e3881804..f3c6b32e9bf3 100644
--- a/spec/lib/api/v3/projects/copy/project_copy_payload_representer_spec.rb
+++ b/spec/lib/api/v3/projects/copy/project_copy_payload_representer_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Projects::Copy::ProjectCopyPayloadRepresenter do
shared_let(:current_user, reload: false) { build_stubbed(:user) }
shared_let(:project, reload: false) { build_stubbed(:project) }
- describe 'generation' do
+ describe "generation" do
let(:meta) { OpenStruct.new }
let(:representer) do
described_class.create(project,
@@ -42,8 +42,8 @@
subject { representer.to_json }
- it 'has a _meta property with the copy properties set to true by default but sendNotifications false by default' do
- expect(subject).to have_json_path '_meta'
+ it "has a _meta property with the copy properties set to true by default but sendNotifications false by default" do
+ expect(subject).to have_json_path "_meta"
Projects::CopyService.copyable_dependencies.each do |dep|
expect(subject)
@@ -56,10 +56,10 @@
.at_path("_meta/sendNotifications")
end
- context 'with the meta property containing which associations to copy' do
+ context "with the meta property containing which associations to copy" do
let(:meta) { OpenStruct.new only: %[work_packages wiki] }
- it 'renders only the selected dependencies as true' do
+ it "renders only the selected dependencies as true" do
Projects::CopyService.copyable_dependencies.each do |dep|
expect(subject)
.to be_json_eql(meta.only.include?(dep[:identifier].to_s).to_json)
@@ -68,10 +68,10 @@
end
end
- context 'with the meta property to send notifications disabled' do
+ context "with the meta property to send notifications disabled" do
let(:meta) { OpenStruct.new send_notifications: false }
- it 'renders only the selected dependencies as true' do
+ it "renders only the selected dependencies as true" do
expect(subject)
.to be_json_eql(false.to_json)
.at_path("_meta/sendNotifications")
@@ -79,7 +79,7 @@
end
end
- describe 'parsing' do
+ describe "parsing" do
let(:representer) do
described_class.create(OpenStruct.new(available_custom_fields: []),
meta: OpenStruct.new,
@@ -88,70 +88,70 @@
subject { representer.from_hash parsed_hash }
- context 'with meta set' do
+ context "with meta set" do
let(:parsed_hash) do
{
- 'name' => 'The copied project',
- '_meta' => {
- 'copyWorkPackages' => true,
- 'copyWiki' => true,
- 'sendNotifications' => false
+ "name" => "The copied project",
+ "_meta" => {
+ "copyWorkPackages" => true,
+ "copyWiki" => true,
+ "sendNotifications" => false
}
}
end
- it 'sets all of them to true' do
- expect(subject.name).to eq 'The copied project'
+ it "sets all of them to true" do
+ expect(subject.name).to eq "The copied project"
expected_names = Projects::CopyService.copyable_dependencies.pluck(:identifier)
expect(subject.meta.only).to match_array(expected_names)
expect(subject.meta.send_notifications).to be false
end
end
- context 'with one meta copy set to false' do
+ context "with one meta copy set to false" do
let(:parsed_hash) do
{
- 'name' => 'The copied project',
- '_meta' => {
- 'copyWorkPackages' => false
+ "name" => "The copied project",
+ "_meta" => {
+ "copyWorkPackages" => false
}
}
end
- it 'sets all others to true' do
- expect(subject.name).to eq 'The copied project'
+ it "sets all others to true" do
+ expect(subject.name).to eq "The copied project"
expected_names = Projects::CopyService.copyable_dependencies.pluck(:identifier)
expect(subject.meta.only).to match_array(expected_names - %w[work_packages])
end
end
- context 'with a mixture of meta copy set to false' do
+ context "with a mixture of meta copy set to false" do
let(:parsed_hash) do
{
- 'name' => 'The copied project',
- '_meta' => {
- 'copyWorkPackages' => false,
- 'copyWiki' => true
+ "name" => "The copied project",
+ "_meta" => {
+ "copyWorkPackages" => false,
+ "copyWiki" => true
}
}
end
- it 'still sets all of them to true except work packages' do
- expect(subject.name).to eq 'The copied project'
+ it "still sets all of them to true except work packages" do
+ expect(subject.name).to eq "The copied project"
expected_names = Projects::CopyService.copyable_dependencies.pluck(:identifier)
expect(subject.meta.only).to match_array(expected_names - %w[work_packages])
end
end
- context 'with meta unset' do
+ context "with meta unset" do
let(:parsed_hash) do
{
- 'name' => 'The copied project'
+ "name" => "The copied project"
}
end
- it 'does not set meta' do
- expect(subject.name).to eq 'The copied project'
+ it "does not set meta" do
+ expect(subject.name).to eq "The copied project"
expect(subject.meta).to be_nil
end
end
diff --git a/spec/lib/api/v3/projects/copy/project_copy_schema_representer_spec.rb b/spec/lib/api/v3/projects/copy/project_copy_schema_representer_spec.rb
index a35bbcaa61f0..2c3630d4e85c 100644
--- a/spec/lib/api/v3/projects/copy/project_copy_schema_representer_spec.rb
+++ b/spec/lib/api/v3/projects/copy/project_copy_schema_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Projects::Copy::ProjectCopySchemaRepresenter do
include API::V3::Utilities::PathHelper
@@ -37,41 +37,41 @@
shared_let(:representer, reload: false) do
described_class.create(contract,
- self_link: '/a/self/link',
+ self_link: "/a/self/link",
form_embedded: true,
current_user:)
end
shared_let(:subject, reload: false) { representer.to_json }
- describe '_type' do
- it 'is indicated as Schema' do
- expect(subject).to be_json_eql('Schema'.to_json).at_path('_type')
+ describe "_type" do
+ it "is indicated as Schema" do
+ expect(subject).to be_json_eql("Schema".to_json).at_path("_type")
end
end
- describe 'send_notifications' do
- it_behaves_like 'has basic schema properties' do
+ describe "send_notifications" do
+ it_behaves_like "has basic schema properties" do
let(:path) { "sendNotifications" }
- let(:type) { 'Boolean' }
+ let(:type) { "Boolean" }
let(:name) { I18n.t(:label_project_copy_notifications) }
let(:required) { false }
let(:has_default) { true }
let(:writable) { true }
- let(:location) { '_meta' }
+ let(:location) { "_meta" }
end
end
- describe 'copy properties' do
+ describe "copy properties" do
Projects::CopyService.copyable_dependencies.each do |dep|
- it_behaves_like 'has basic schema properties' do
+ it_behaves_like "has basic schema properties" do
let(:path) { "copy#{dep[:identifier].camelize}" }
- let(:type) { 'Boolean' }
+ let(:type) { "Boolean" }
let(:name) { dep[:name_source].call }
let(:required) { false }
let(:has_default) { true }
let(:writable) { true }
- let(:location) { '_meta' }
+ let(:location) { "_meta" }
let(:description) { "No objects of this type" }
end
end
diff --git a/spec/lib/api/v3/projects/project_collection_representer_spec.rb b/spec/lib/api/v3/projects/project_collection_representer_spec.rb
index 9ae04e4fbda8..f5853fe25b4f 100644
--- a/spec/lib/api/v3/projects/project_collection_representer_spec.rb
+++ b/spec/lib/api/v3/projects/project_collection_representer_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Projects::ProjectCollectionRepresenter do
shared_let(:projects) { create_list(:project, 3) }
- let(:self_base_link) { '/api/v3/projects' }
+ let(:self_base_link) { "/api/v3/projects" }
let(:current_user) { build(:user) }
let(:representer) do
described_class.new Project.all,
@@ -42,40 +42,40 @@
let(:page) { 1 }
let(:page_size) { 30 }
let(:actual_count) { 3 }
- let(:collection_inner_type) { 'Project' }
+ let(:collection_inner_type) { "Project" }
subject { representer.to_json }
- context 'generation' do
+ context "generation" do
subject(:collection) { representer.to_json }
- it_behaves_like 'offset-paginated APIv3 collection', 3, 'projects', 'Project'
+ it_behaves_like "offset-paginated APIv3 collection", 3, "projects", "Project"
end
- describe 'representation formats' do
- it_behaves_like 'has a link collection' do
- let(:link) { 'representations' }
+ describe "representation formats" do
+ it_behaves_like "has a link collection" do
+ let(:link) { "representations" }
let(:hrefs) do
[
{
- 'href' => '/projects.csv?offset=1&pageSize=30',
- 'identifier' => 'csv',
- 'type' => 'text/csv',
- 'title' => 'CSV'
+ "href" => "/projects.csv?offset=1&pageSize=30",
+ "identifier" => "csv",
+ "type" => "text/csv",
+ "title" => "CSV"
},
{
- 'href' => '/projects.xls?offset=1&pageSize=30',
- 'identifier' => 'xls',
- 'type' => 'application/vnd.ms-excel',
- 'title' => 'XLS'
+ "href" => "/projects.xls?offset=1&pageSize=30",
+ "identifier" => "xls",
+ "type" => "application/vnd.ms-excel",
+ "title" => "XLS"
}
]
end
end
end
- describe '.checked_permissions' do
- it 'lists add_work_packages and view_projects' do
+ describe ".checked_permissions" do
+ it "lists add_work_packages and view_projects" do
expect(described_class.checked_permissions).to contain_exactly(:add_work_packages, :view_project)
end
end
diff --git a/spec/lib/api/v3/projects/project_payload_representer_parsing_spec.rb b/spec/lib/api/v3/projects/project_payload_representer_parsing_spec.rb
index abe64f7ce7b9..991b78c688bd 100644
--- a/spec/lib/api/v3/projects/project_payload_representer_parsing_spec.rb
+++ b/spec/lib/api/v3/projects/project_payload_representer_parsing_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Projects::ProjectPayloadRepresenter, 'parsing' do
+RSpec.describe API::V3::Projects::ProjectPayloadRepresenter, "parsing" do
include API::V3::Utilities::PathHelper
let(:object) do
@@ -39,84 +39,84 @@
described_class.create(object, current_user: user)
end
- describe 'properties' do
- context 'for status' do
+ describe "properties" do
+ context "for status" do
let(:hash) do
{
- 'statusExplanation' => { 'raw' => 'status code explanation' },
- '_links' => {
- 'status' => {
- 'href' => api_v3_paths.project_status('on_track')
+ "statusExplanation" => { "raw" => "status code explanation" },
+ "_links" => {
+ "status" => {
+ "href" => api_v3_paths.project_status("on_track")
}
}
}
end
- it 'updates code' do
+ it "updates code" do
project = representer.from_hash(hash)
expect(project.status_code)
- .to eql('on_track')
+ .to eql("on_track")
expect(project.status_explanation)
- .to eql('status code explanation')
+ .to eql("status code explanation")
end
- context 'with code not provided' do
+ context "with code not provided" do
let(:hash) do
{
- 'statusExplanation' => { 'raw' => 'status code explanation' }
+ "statusExplanation" => { "raw" => "status code explanation" }
}
end
- it 'does not set code' do
+ it "does not set code" do
project = representer.from_hash(hash)
expect(project.status_code)
.to be_nil
end
- it 'updates explanation' do
+ it "updates explanation" do
project = representer.from_hash(hash)
expect(project.status_explanation)
- .to eql('status code explanation')
+ .to eql("status code explanation")
end
end
- context 'with explanation not provided' do
+ context "with explanation not provided" do
let(:hash) do
{
- '_links' => {
- 'status' => {
- 'href' => api_v3_paths.project_status('off_track')
+ "_links" => {
+ "status" => {
+ "href" => api_v3_paths.project_status("off_track")
}
}
}
end
- it 'does set code' do
+ it "does set code" do
project = representer.from_hash(hash)
expect(project.status_code)
- .to eql 'off_track'
+ .to eql "off_track"
end
- it 'does not set explanation' do
+ it "does not set explanation" do
project = representer.from_hash(hash)
expect(project.status_explanation)
.to be_nil
end
end
- context 'with null for a status' do
+ context "with null for a status" do
let(:hash) do
{
- '_links' => {
- 'status' => {
- 'href' => nil
+ "_links" => {
+ "status" => {
+ "href" => nil
}
}
}
end
- it 'does set status to nil' do
+ it "does set status to nil" do
project = representer.from_hash(hash)
expect(project)
@@ -131,20 +131,20 @@
end
end
- describe '_links' do
- context 'with a parent link' do
- context 'with the href being an url' do
+ describe "_links" do
+ context "with a parent link" do
+ context "with the href being an url" do
let(:hash) do
{
- '_links' => {
- 'parent' => {
- 'href' => api_v3_paths.project(5)
+ "_links" => {
+ "parent" => {
+ "href" => api_v3_paths.project(5)
}
}
}
end
- it 'sets the parent_id to the value' do
+ it "sets the parent_id to the value" do
project = representer.from_hash(hash)
expect(project[:parent_id])
@@ -152,18 +152,18 @@
end
end
- context 'with the href being nil' do
+ context "with the href being nil" do
let(:hash) do
{
- '_links' => {
- 'parent' => {
- 'href' => nil
+ "_links" => {
+ "parent" => {
+ "href" => nil
}
}
}
end
- it 'sets the parent_id to nil' do
+ it "sets the parent_id to nil" do
project = representer.from_hash(hash)
expect(project)
@@ -174,18 +174,18 @@
end
end
- context 'with the href being the hidden uri' do
+ context "with the href being the hidden uri" do
let(:hash) do
{
- '_links' => {
- 'parent' => {
- 'href' => API::V3::URN_UNDISCLOSED
+ "_links" => {
+ "parent" => {
+ "href" => API::V3::URN_UNDISCLOSED
}
}
}
end
- it 'omits the parent information' do
+ it "omits the parent information" do
project = representer.from_hash(hash)
expect(project)
diff --git a/spec/lib/api/v3/projects/project_representer_rendering_spec.rb b/spec/lib/api/v3/projects/project_representer_rendering_spec.rb
index a4b26c3a93ba..daa71e7ca66e 100644
--- a/spec/lib/api/v3/projects/project_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/projects/project_representer_rendering_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Projects::ProjectRepresenter, 'rendering' do
+RSpec.describe API::V3::Projects::ProjectRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
subject(:generated) { representer.to_json }
@@ -37,7 +37,7 @@
build_stubbed(:project,
:with_status,
parent: parent_project,
- description: 'some description').tap do |p|
+ description: "some description").tap do |p|
allow(p).to receive_messages(available_custom_fields: [int_custom_field, version_custom_field],
ancestors_from_root: ancestors)
@@ -56,7 +56,7 @@
let(:version_custom_field) { build_stubbed(:version_project_custom_field, visible: true) }
let(:int_custom_value) do
CustomValue.new(custom_field: int_custom_field,
- value: '1234',
+ value: "1234",
customized: nil)
end
let(:version) { build_stubbed(:version) }
@@ -89,60 +89,60 @@
end
end
- it { is_expected.to include_json('Project'.to_json).at_path('_type') }
+ it { is_expected.to include_json("Project".to_json).at_path("_type") }
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'Project' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "Project" }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { project.id }
end
- it_behaves_like 'property', :identifier do
+ it_behaves_like "property", :identifier do
let(:value) { project.identifier }
end
- it_behaves_like 'property', :name do
+ it_behaves_like "property", :name do
let(:value) { project.name }
end
- it_behaves_like 'property', :active do
+ it_behaves_like "property", :active do
let(:value) { project.active }
end
- it_behaves_like 'property', :public do
+ it_behaves_like "property", :public do
let(:value) { project.public }
end
- it_behaves_like 'formattable property', :description do
+ it_behaves_like "formattable property", :description do
let(:value) { project.description }
end
- it_behaves_like 'formattable property', 'statusExplanation' do
+ it_behaves_like "formattable property", "statusExplanation" do
let(:value) { project.status_explanation }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { project.created_at }
- let(:json_path) { 'createdAt' }
+ let(:json_path) { "createdAt" }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { project.updated_at }
- let(:json_path) { 'updatedAt' }
+ let(:json_path) { "updatedAt" }
end
- context 'when the user does not have the view_project permission' do
+ context "when the user does not have the view_project permission" do
let(:permissions) { [] }
- it_behaves_like 'no property', 'statusExplanation'
- it_behaves_like 'no property', :description
+ it_behaves_like "no property", "statusExplanation"
+ it_behaves_like "no property", :description
end
- describe 'int custom field' do
- context 'if the user is admin' do
+ describe "int custom field" do
+ context "if the user is admin" do
before do
allow(user)
.to receive(:admin?)
@@ -155,13 +155,13 @@
end
end
- context 'if the user is no admin' do
+ context "if the user is no admin" do
it "has no property for the int custom field" do
expect(subject).not_to have_json_path("customField#{int_custom_field.id}")
end
end
- context 'if the user is no admin and the field is visible' do
+ context "if the user is no admin and the field is visible" do
before do
int_custom_field.visible = true
end
@@ -172,7 +172,7 @@
end
end
- context 'if the user lacks the :view_project permission' do
+ context "if the user lacks the :view_project permission" do
let(:permissions) { [] }
before do
@@ -186,61 +186,61 @@
end
end
- describe '_links' do
- it { is_expected.to have_json_type(Object).at_path('_links') }
+ describe "_links" do
+ it { is_expected.to have_json_type(Object).at_path("_links") }
- it 'links to self' do
- expect(subject).to have_json_path('_links/self/href')
+ it "links to self" do
+ expect(subject).to have_json_path("_links/self/href")
end
- it 'has a title for link to self' do
- expect(subject).to have_json_path('_links/self/title')
+ it "has a title for link to self" do
+ expect(subject).to have_json_path("_links/self/title")
end
- describe 'create work packages' do
- context 'if user is allowed to create work packages' do
- it 'has the correct path for a create form' do
+ describe "create work packages" do
+ context "if user is allowed to create work packages" do
+ it "has the correct path for a create form" do
expect(subject).to be_json_eql(api_v3_paths.create_project_work_package_form(project.id).to_json)
- .at_path('_links/createWorkPackage/href')
+ .at_path("_links/createWorkPackage/href")
end
- it 'has the correct path to create a work package' do
+ it "has the correct path to create a work package" do
expect(subject).to be_json_eql(api_v3_paths.work_packages_by_project(project.id).to_json)
- .at_path('_links/createWorkPackageImmediately/href')
+ .at_path("_links/createWorkPackageImmediately/href")
end
end
- context 'if user is not allowed to create work packages' do
+ context "if user is not allowed to create work packages" do
let(:permissions) { [] }
- it_behaves_like 'has no link' do
- let(:link) { 'createWorkPackage' }
+ it_behaves_like "has no link" do
+ let(:link) { "createWorkPackage" }
end
- it_behaves_like 'has no link' do
- let(:link) { 'createWorkPackageImmediately' }
+ it_behaves_like "has no link" do
+ let(:link) { "createWorkPackageImmediately" }
end
end
end
- describe 'parent' do
- let(:link) { 'parent' }
+ describe "parent" do
+ let(:link) { "parent" }
- it_behaves_like 'has a titled link' do
+ it_behaves_like "has a titled link" do
let(:href) { api_v3_paths.project(parent_project.id) }
let(:title) { parent_project.name }
end
- context 'if lacking the permissions to see the parent' do
+ context "if lacking the permissions to see the parent" do
let(:parent_visible) { false }
- it_behaves_like 'has a titled link' do
+ it_behaves_like "has a titled link" do
let(:href) { API::V3::URN_UNDISCLOSED }
- let(:title) { I18n.t(:'api_v3.undisclosed.parent') }
+ let(:title) { I18n.t(:"api_v3.undisclosed.parent") }
end
end
- context 'if lacking the permissions to see the parent but being an admin (archived project)' do
+ context "if lacking the permissions to see the parent but being an admin (archived project)" do
let(:parent_visible) { false }
before do
@@ -249,24 +249,24 @@
.and_return(true)
end
- it_behaves_like 'has a titled link' do
+ it_behaves_like "has a titled link" do
let(:href) { api_v3_paths.project(parent_project.id) }
let(:title) { parent_project.name }
end
end
- context 'without a parent' do
+ context "without a parent" do
let(:parent_project) { nil }
let(:ancestors) { [] }
- it_behaves_like 'has an untitled link' do
+ it_behaves_like "has an untitled link" do
let(:href) { nil }
end
end
end
- describe 'ancestors' do
- let(:link) { 'ancestors' }
+ describe "ancestors" do
+ let(:link) { "ancestors" }
let(:grandparent_project) do
build_stubbed(:project).tap do |p|
allow(p)
@@ -283,7 +283,7 @@
end
let(:ancestors) { [root_project, grandparent_project, parent_project] }
- it_behaves_like 'has a link collection' do
+ it_behaves_like "has a link collection" do
let(:hrefs) do
[
{
@@ -302,10 +302,10 @@
end
end
- context 'if lacking the permissions to see the parent but being allowed to see the other ancestors' do
+ context "if lacking the permissions to see the parent but being allowed to see the other ancestors" do
let(:parent_visible) { false }
- it_behaves_like 'has a link collection' do
+ it_behaves_like "has a link collection" do
let(:hrefs) do
[
{
@@ -318,14 +318,14 @@
},
{
href: API::V3::URN_UNDISCLOSED,
- title: I18n.t(:'api_v3.undisclosed.ancestor')
+ title: I18n.t(:"api_v3.undisclosed.ancestor")
}
]
end
end
end
- context 'if lacking the permissions to see the parent but being an admin (archived project)' do
+ context "if lacking the permissions to see the parent but being an admin (archived project)" do
let(:parent_visible) { false }
before do
@@ -334,7 +334,7 @@
.and_return(true)
end
- it_behaves_like 'has a link collection' do
+ it_behaves_like "has a link collection" do
let(:hrefs) do
[
{
@@ -354,128 +354,128 @@
end
end
- context 'without an ancestor' do
+ context "without an ancestor" do
let(:parent_project) { nil }
let(:ancestors) { [] }
- it_behaves_like 'has an empty link collection'
+ it_behaves_like "has an empty link collection"
end
end
- describe 'status' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'status' }
+ describe "status" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "status" }
let(:status_code) { project.status_code }
let(:href) { api_v3_paths.project_status(status_code) }
let(:title) { I18n.t(:"activerecord.attributes.project.status_codes.#{status_code}") }
end
- context 'if the status_code is nil' do
+ context "if the status_code is nil" do
before { project.status_code = nil }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'status' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "status" }
let(:href) { nil }
end
end
- context 'if the user does not have the view_project permission' do
+ context "if the user does not have the view_project permission" do
let(:permissions) { [] }
- it_behaves_like 'has no link' do
- let(:link) { 'status' }
+ it_behaves_like "has no link" do
+ let(:link) { "status" }
end
end
end
- describe 'categories' do
- it 'has the correct link to its categories' do
+ describe "categories" do
+ it "has the correct link to its categories" do
expect(subject).to be_json_eql(api_v3_paths.categories_by_project(project.id).to_json)
- .at_path('_links/categories/href')
+ .at_path("_links/categories/href")
end
end
- describe 'versions' do
- context 'with only manage_versions permission' do
+ describe "versions" do
+ context "with only manage_versions permission" do
let(:permissions) { [:manage_versions] }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'versions' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "versions" }
let(:href) { api_v3_paths.versions_by_project(project.id) }
end
end
- context 'with only view_work_packages permission' do
+ context "with only view_work_packages permission" do
let(:permissions) { [:view_work_packages] }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'versions' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "versions" }
let(:href) { api_v3_paths.versions_by_project(project.id) }
end
end
- context 'without both permissions' do
+ context "without both permissions" do
let(:permissions) { [:add_work_packages] }
- it_behaves_like 'has no link' do
- let(:link) { 'versions' }
+ it_behaves_like "has no link" do
+ let(:link) { "versions" }
end
end
end
- describe 'types' do
- context 'for a user having the view_work_packages permission' do
+ describe "types" do
+ context "for a user having the view_work_packages permission" do
let(:permissions) { [:view_work_packages] }
- it 'links to the types active in the project' do
+ it "links to the types active in the project" do
expect(subject).to be_json_eql(api_v3_paths.types_by_project(project.id).to_json)
- .at_path('_links/types/href')
+ .at_path("_links/types/href")
end
- it 'links to the work packages in the project' do
+ it "links to the work packages in the project" do
expect(subject).to be_json_eql(api_v3_paths.work_packages_by_project(project.id).to_json)
- .at_path('_links/workPackages/href')
+ .at_path("_links/workPackages/href")
end
end
- context 'for a user having the manage_types permission' do
+ context "for a user having the manage_types permission" do
let(:permissions) { [:manage_types] }
- it 'links to the types active in the project' do
+ it "links to the types active in the project" do
expect(subject).to be_json_eql(api_v3_paths.types_by_project(project.id).to_json)
- .at_path('_links/types/href')
+ .at_path("_links/types/href")
end
end
- context 'for a user not having the necessary permissions' do
+ context "for a user not having the necessary permissions" do
let(:permission) { [] }
- it 'has no types link' do
- expect(subject).not_to have_json_path('_links/types/href')
+ it "has no types link" do
+ expect(subject).not_to have_json_path("_links/types/href")
end
- it 'has no work packages link' do
- expect(subject).not_to have_json_path('_links/workPackages/href')
+ it "has no work packages link" do
+ expect(subject).not_to have_json_path("_links/workPackages/href")
end
end
end
- describe 'memberships' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'memberships' }
+ describe "memberships" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "memberships" }
let(:href) { api_v3_paths.path_for(:memberships, filters: [{ project: { operator: "=", values: [project.id.to_s] } }]) }
end
- context 'without the view_members permission' do
+ context "without the view_members permission" do
let(:permissions) { [] }
- it_behaves_like 'has no link' do
- let(:link) { 'memberships' }
+ it_behaves_like "has no link" do
+ let(:link) { "memberships" }
end
end
end
- describe 'storages' do
+ describe "storages" do
let(:storage) { build_stubbed(:nextcloud_storage) }
let(:permissions) { %i[view_file_links] }
@@ -483,8 +483,8 @@
allow(project).to receive(:storages).and_return([storage])
end
- it_behaves_like 'has a link collection' do
- let(:link) { 'storages' }
+ it_behaves_like "has a link collection" do
+ let(:link) { "storages" }
let(:hrefs) do
[
{
@@ -495,17 +495,17 @@
end
end
- context 'if user has no permission to view file links' do
+ context "if user has no permission to view file links" do
let(:permissions) { [] }
- it_behaves_like 'has no link' do
- let(:link) { 'storages' }
+ it_behaves_like "has no link" do
+ let(:link) { "storages" }
end
end
end
- describe 'link custom field' do
- context 'if the user is admin and the field is invisible' do
+ describe "link custom field" do
+ context "if the user is admin and the field is invisible" do
before do
allow(user)
.to receive(:admin?)
@@ -514,13 +514,13 @@
version_custom_field.visible = false
end
- it 'links custom fields' do
+ it "links custom fields" do
expect(subject).to be_json_eql(api_v3_paths.version(version.id).to_json)
.at_path("_links/customField#{version_custom_field.id}/href")
end
end
- context 'if the user is no admin and the field is invisible' do
+ context "if the user is no admin and the field is invisible" do
before do
version_custom_field.visible = false
end
@@ -530,87 +530,87 @@
end
end
- context 'if the user is no admin and the field is visible' do
- it 'links custom fields' do
+ context "if the user is no admin and the field is visible" do
+ it "links custom fields" do
expect(subject).to be_json_eql(api_v3_paths.version(version.id).to_json)
.at_path("_links/customField#{version_custom_field.id}/href")
end
end
- context 'if the user lacks the :view_project permission' do
+ context "if the user lacks the :view_project permission" do
let(:permissions) { [] }
- it 'does not link the custom field' do
+ it "does not link the custom field" do
expect(subject).not_to have_json_path("links/customField#{version_custom_field.id}")
end
end
end
- describe 'update' do
- context 'for a user having the edit_project permission' do
+ describe "update" do
+ context "for a user having the edit_project permission" do
let(:permissions) { [:edit_project] }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'update' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "update" }
let(:href) { api_v3_paths.project_form project.id }
end
end
- context 'for a user lacking the edit_project permission' do
+ context "for a user lacking the edit_project permission" do
let(:permissions) { [] }
- it_behaves_like 'has no link' do
- let(:link) { 'update' }
+ it_behaves_like "has no link" do
+ let(:link) { "update" }
end
end
end
- describe 'updateImmediately' do
- context 'for a user having the edit_project permission' do
+ describe "updateImmediately" do
+ context "for a user having the edit_project permission" do
let(:permissions) { [:edit_project] }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'updateImmediately' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "updateImmediately" }
let(:href) { api_v3_paths.project project.id }
end
end
- context 'for a user lacking the edit_project permission' do
+ context "for a user lacking the edit_project permission" do
let(:permissions) { [] }
- it_behaves_like 'has no link' do
- let(:link) { 'updateImmediately' }
+ it_behaves_like "has no link" do
+ let(:link) { "updateImmediately" }
end
end
end
- describe 'delete' do
- context 'for a user being admin' do
+ describe "delete" do
+ context "for a user being admin" do
before do
allow(user)
.to receive(:admin?)
.and_return(true)
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'delete' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "delete" }
let(:href) { api_v3_paths.project project.id }
end
end
- context 'for a non admin user' do
+ context "for a non admin user" do
let(:permissions) { [] }
- it_behaves_like 'has no link' do
- let(:link) { 'delete' }
+ it_behaves_like "has no link" do
+ let(:link) { "delete" }
end
end
end
end
- describe '_embedded' do
- describe 'parent' do
- let(:embedded_path) { '_embedded/parent' }
+ describe "_embedded" do
+ describe "parent" do
+ let(:embedded_path) { "_embedded/parent" }
before do
allow(parent_project)
@@ -618,12 +618,12 @@
.and_return(parent_visible)
end
- context 'when the user is allowed to see the parent' do
+ context "when the user is allowed to see the parent" do
let(:parent_visible) { true }
- it 'has the parent embedded' do
+ it "has the parent embedded" do
expect(generated)
- .to be_json_eql('Project'.to_json)
+ .to be_json_eql("Project".to_json)
.at_path("#{embedded_path}/_type")
expect(generated)
@@ -632,22 +632,22 @@
end
end
- context 'when the user is forbidden to see the parent' do
+ context "when the user is forbidden to see the parent" do
let(:parent_visible) { false }
- it 'hides the parent' do
+ it "hides the parent" do
expect(generated)
.not_to have_json_path(embedded_path)
end
end
end
- describe 'status' do
- let(:embedded_path) { '_embedded/status' }
+ describe "status" do
+ let(:embedded_path) { "_embedded/status" }
- it 'has the status embedded' do
+ it "has the status embedded" do
expect(generated)
- .to be_json_eql('ProjectStatus'.to_json)
+ .to be_json_eql("ProjectStatus".to_json)
.at_path("#{embedded_path}/_type")
expect(generated)
@@ -655,19 +655,19 @@
.at_path("#{embedded_path}/name")
end
- context 'if the status_code is nil' do
+ context "if the status_code is nil" do
before { project.status_code = nil }
- it 'has no status embedded' do
+ it "has no status embedded" do
expect(generated)
.not_to have_json_path(embedded_path)
end
end
- context 'if the user does not have the view_project permission' do
+ context "if the user does not have the view_project permission" do
let(:permissions) { [] }
- it 'has no status embedded' do
+ it "has no status embedded" do
expect(generated)
.not_to have_json_path(embedded_path)
end
@@ -675,8 +675,8 @@
end
end
- describe 'caching' do
- it 'is based on the representer\'s cache_key' do
+ describe "caching" do
+ it "is based on the representer's cache_key" do
allow(OpenProject::Cache)
.to receive(:fetch)
.and_call_original
@@ -688,22 +688,22 @@
.with(representer.json_cache_key)
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let!(:former_cache_key) { representer.json_cache_key }
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'Projects', 'ProjectRepresenter')
+ .to include("API", "V3", "Projects", "ProjectRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
I18n.with_locale(:fr) do
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
end
- it 'changes when the project is updated' do
+ it "changes when the project is updated" do
project.updated_at = 20.seconds.from_now
expect(representer.json_cache_key)
@@ -712,8 +712,8 @@
end
end
- describe '.checked_permissions' do
- it 'lists add_work_packages and view_project' do
+ describe ".checked_permissions" do
+ it "lists add_work_packages and view_project" do
expect(described_class.checked_permissions).to contain_exactly(:add_work_packages, :view_project)
end
end
diff --git a/spec/lib/api/v3/projects/project_sql_collection_representer_rendering_spec.rb b/spec/lib/api/v3/projects/project_sql_collection_representer_rendering_spec.rb
index 4b7d9291e3d4..1ac8c65cb9e0 100644
--- a/spec/lib/api/v3/projects/project_sql_collection_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/projects/project_sql_collection_representer_rendering_spec.rb
@@ -24,16 +24,16 @@
#
# See COPYRIGHT and LICENSE files for more details.
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Projects::ProjectSqlCollectionRepresenter, 'rendering' do
+RSpec.describe API::V3::Projects::ProjectSqlCollectionRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
subject(:json) do
API::V3::Utilities::SqlRepresenterWalker
.new(scope,
current_user:,
- self_path: 'some_path',
+ self_path: "some_path",
url_query: { offset: 1, pageSize: 5, select: })
.walk(described_class)
.to_json
@@ -51,14 +51,14 @@
let(:role) { create(:project_role) }
let(:select) do
- { '*' => {}, 'elements' => { '*' => {} } }
+ { "*" => {}, "elements" => { "*" => {} } }
end
current_user do
create(:user, member_with_roles: { project => role })
end
- context 'when rendering everything' do
+ context "when rendering everything" do
let(:expected) do
{
_type: "Collection",
@@ -101,15 +101,15 @@
}.to_json
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql(expected)
end
end
- context 'when rendering only collection attributes' do
+ context "when rendering only collection attributes" do
let(:select) do
- { '*' => {} }
+ { "*" => {} }
end
let(:expected) do
@@ -135,19 +135,19 @@
}.to_json
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql(expected)
end
end
- context 'when not having a project to render' do
+ context "when not having a project to render" do
let(:scope) do
Project.none
end
let(:select) do
- { '*' => {} }
+ { "*" => {} }
end
let(:expected) do
@@ -173,7 +173,7 @@
}.to_json
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql(expected)
end
diff --git a/spec/lib/api/v3/projects/project_sql_representer_rendering_spec.rb b/spec/lib/api/v3/projects/project_sql_representer_rendering_spec.rb
index 28aa950af458..eb8539c8d16f 100644
--- a/spec/lib/api/v3/projects/project_sql_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/projects/project_sql_representer_rendering_spec.rb
@@ -24,9 +24,9 @@
#
# See COPYRIGHT and LICENSE files for more details.
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Projects::ProjectSqlRepresenter, 'rendering' do
+RSpec.describe API::V3::Projects::ProjectSqlRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
subject(:json) do
@@ -49,14 +49,14 @@
let(:role) { create(:project_role) }
- let(:select) { { '*' => {} } }
+ let(:select) { { "*" => {} } }
current_user do
create(:user, member_with_roles: { project => role })
end
- context 'when rendering all supported properties' do
- it 'renders as expected' do
+ context "when rendering all supported properties" do
+ it "renders as expected" do
expect(json)
.to be_json_eql(
{
@@ -78,7 +78,7 @@
end
end
- context 'with an ancestor' do
+ context "with an ancestor" do
let!(:parent) do
create(:project, members: { current_user => role }).tap do |parent|
project.parent = parent
@@ -93,9 +93,9 @@
end
end
- let(:select) { { 'ancestors' => {} } }
+ let(:select) { { "ancestors" => {} } }
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql(
{
@@ -116,7 +116,7 @@
end
end
- context 'with an ancestor the user does not have permission to see' do
+ context "with an ancestor the user does not have permission to see" do
let!(:parent) do
create(:project).tap do |parent|
project.parent = parent
@@ -131,9 +131,9 @@
end
end
- let(:select) { { 'ancestors' => {} } }
+ let(:select) { { "ancestors" => {} } }
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql(
{
@@ -145,7 +145,7 @@
},
{
href: API::V3::URN_UNDISCLOSED,
- title: I18n.t(:'api_v3.undisclosed.ancestor')
+ title: I18n.t(:"api_v3.undisclosed.ancestor")
}
]
}
@@ -153,8 +153,8 @@
)
end
- context 'with relative url root', with_config: { rails_relative_url_root: '/foobar' } do
- it 'renders correctly' do
+ context "with relative url root", with_config: { rails_relative_url_root: "/foobar" } do
+ it "renders correctly" do
expect(json)
.to be_json_eql(
{
@@ -166,7 +166,7 @@
},
{
href: API::V3::URN_UNDISCLOSED,
- title: I18n.t(:'api_v3.undisclosed.ancestor')
+ title: I18n.t(:"api_v3.undisclosed.ancestor")
}
]
}
@@ -175,12 +175,12 @@
end
end
- context 'when in a foreign language with single quotes in the translation hint text' do
+ context "when in a foreign language with single quotes in the translation hint text" do
before do
I18n.locale = :fr
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql(
{
@@ -192,7 +192,7 @@
},
{
href: API::V3::URN_UNDISCLOSED,
- title: I18n.t(:'api_v3.undisclosed.ancestor')
+ title: I18n.t(:"api_v3.undisclosed.ancestor")
}
]
}
@@ -202,7 +202,7 @@
end
end
- context 'with an archived ancestor but with the user being admin' do
+ context "with an archived ancestor but with the user being admin" do
let!(:parent) do
create(:project, active: false).tap do |parent|
project.parent = parent
@@ -217,13 +217,13 @@
end
end
- let(:select) { { 'ancestors' => {} } }
+ let(:select) { { "ancestors" => {} } }
current_user do
create(:admin)
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql(
{
diff --git a/spec/lib/api/v3/projects/schemas/project_schema_representer_spec.rb b/spec/lib/api/v3/projects/schemas/project_schema_representer_spec.rb
index 63ca1addd327..479c5cd24054 100644
--- a/spec/lib/api/v3/projects/schemas/project_schema_representer_spec.rb
+++ b/spec/lib/api/v3/projects/schemas/project_schema_representer_spec.rb
@@ -26,23 +26,23 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Projects::Schemas::ProjectSchemaRepresenter do
include API::V3::Utilities::PathHelper
let(:current_user) { build_stubbed(:user) }
- let(:self_link) { '/a/self/link' }
+ let(:self_link) { "/a/self/link" }
let(:embedded) { true }
let(:new_record) { true }
let(:model_id) { 1 }
let(:custom_field) do
build_stubbed(:integer_project_custom_field)
end
- let(:allowed_status) { ['some status'] }
+ let(:allowed_status) { ["some status"] }
let(:contract) do
- contract = double('contract')
- model = double('project')
+ contract = double("contract")
+ model = double("project")
allow(contract)
.to receive(:writable?) do |attribute|
@@ -91,236 +91,236 @@
end
end
- context 'generation' do
+ context "generation" do
subject(:generated) { representer.to_json }
- describe '_type' do
- it 'is indicated as Schema' do
- expect(subject).to be_json_eql('Schema'.to_json).at_path('_type')
+ describe "_type" do
+ it "is indicated as Schema" do
+ expect(subject).to be_json_eql("Schema".to_json).at_path("_type")
end
end
- describe 'id' do
- let(:path) { 'id' }
+ describe "id" do
+ let(:path) { "id" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Integer' }
- let(:name) { I18n.t('attributes.id') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Integer" }
+ let(:name) { I18n.t("attributes.id") }
let(:required) { true }
let(:writable) { false }
end
end
- describe 'name' do
- let(:path) { 'name' }
+ describe "name" do
+ let(:path) { "name" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'String' }
- let(:name) { I18n.t('attributes.name') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "String" }
+ let(:name) { I18n.t("attributes.name") }
let(:required) { true }
let(:writable) { true }
end
- it_behaves_like 'indicates length requirements' do
+ it_behaves_like "indicates length requirements" do
let(:min_length) { 1 }
let(:max_length) { 255 }
end
end
- describe 'identifier' do
- let(:path) { 'identifier' }
+ describe "identifier" do
+ let(:path) { "identifier" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'String' }
- let(:name) { I18n.t('activerecord.attributes.project.identifier') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "String" }
+ let(:name) { I18n.t("activerecord.attributes.project.identifier") }
let(:required) { true }
let(:has_default) { true }
let(:writable) { true }
end
- it_behaves_like 'indicates length requirements' do
+ it_behaves_like "indicates length requirements" do
let(:min_length) { 1 }
let(:max_length) { 100 }
end
end
- describe 'description' do
- let(:path) { 'description' }
+ describe "description" do
+ let(:path) { "description" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Formattable' }
- let(:name) { I18n.t('attributes.description') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Formattable" }
+ let(:name) { I18n.t("attributes.description") }
let(:required) { false }
let(:writable) { true }
end
end
- describe 'public' do
- let(:path) { 'public' }
+ describe "public" do
+ let(:path) { "public" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Boolean' }
- let(:name) { I18n.t('attributes.public') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Boolean" }
+ let(:name) { I18n.t("attributes.public") }
let(:required) { false }
let(:writable) { true }
end
end
- describe 'active' do
- let(:path) { 'active' }
+ describe "active" do
+ let(:path) { "active" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Boolean' }
- let(:name) { I18n.t('attributes.active') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Boolean" }
+ let(:name) { I18n.t("attributes.active") }
let(:required) { false }
let(:writable) { true }
end
end
- describe 'statusExplanation' do
- let(:path) { 'statusExplanation' }
+ describe "statusExplanation" do
+ let(:path) { "statusExplanation" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Formattable' }
- let(:name) { I18n.t('activerecord.attributes.project.status_explanation') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Formattable" }
+ let(:name) { I18n.t("activerecord.attributes.project.status_explanation") }
let(:required) { false }
let(:writable) { true }
end
end
- describe 'status' do
- let(:path) { 'status' }
+ describe "status" do
+ let(:path) { "status" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'ProjectStatus' }
- let(:name) { I18n.t('activerecord.attributes.project.status_code') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "ProjectStatus" }
+ let(:name) { I18n.t("activerecord.attributes.project.status_code") }
let(:required) { false }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- it_behaves_like 'links to allowed values directly' do
+ it_behaves_like "links to allowed values directly" do
let(:hrefs) { Project.status_codes.keys.map { |code| api_v3_paths.project_status code } }
end
end
- describe 'createdAt' do
- let(:path) { 'createdAt' }
+ describe "createdAt" do
+ let(:path) { "createdAt" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'DateTime' }
- let(:name) { I18n.t('attributes.created_at') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "DateTime" }
+ let(:name) { I18n.t("attributes.created_at") }
let(:required) { true }
let(:writable) { false }
end
end
- describe 'updatedAt' do
- let(:path) { 'updatedAt' }
+ describe "updatedAt" do
+ let(:path) { "updatedAt" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'DateTime' }
- let(:name) { I18n.t('attributes.updated_at') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "DateTime" }
+ let(:name) { I18n.t("attributes.updated_at") }
let(:required) { true }
let(:writable) { false }
end
end
- describe 'int custom field' do
+ describe "int custom field" do
let(:path) { "customField#{custom_field.id}" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Integer' }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Integer" }
let(:name) { custom_field.name }
let(:required) { false }
let(:writable) { false }
end
end
- describe 'parent' do
- let(:path) { 'parent' }
+ describe "parent" do
+ let(:path) { "parent" }
- context 'when having a new record' do
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Project' }
- let(:name) { Project.human_attribute_name('parent') }
+ context "when having a new record" do
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Project" }
+ let(:name) { Project.human_attribute_name("parent") }
let(:required) { false }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- context 'when embedding' do
+ context "when embedding" do
let(:embedded) { true }
- it_behaves_like 'links to allowed values via collection link' do
+ it_behaves_like "links to allowed values via collection link" do
let(:href) do
api_v3_paths.projects_available_parents
end
end
end
- context 'when not embedding' do
+ context "when not embedding" do
let(:embedded) { false }
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
end
- context 'when only having the add_subprojects permissions' do
+ context "when only having the add_subprojects permissions" do
let(:project_permissions) { %i[add_subprojects] }
let(:global_permissions) { [] }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Project' }
- let(:name) { Project.human_attribute_name('parent') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Project" }
+ let(:name) { Project.human_attribute_name("parent") }
# Required is different when the add_project permission is lacking
let(:required) { true }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
end
end
- context 'if having a persisted record' do
+ context "if having a persisted record" do
let(:new_record) { false }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Project' }
- let(:name) { Project.human_attribute_name('parent') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Project" }
+ let(:name) { Project.human_attribute_name("parent") }
let(:required) { false }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- context 'if embedding' do
+ context "if embedding" do
let(:embedded) { true }
- it_behaves_like 'links to allowed values via collection link' do
+ it_behaves_like "links to allowed values via collection link" do
let(:href) do
api_v3_paths.projects_available_parents + "?of=#{model_id}"
end
end
end
- context 'if not embedding' do
+ context "if not embedding" do
let(:embedded) { false }
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
end
end
end
- context '_links' do
- describe 'self link' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ context "_links" do
+ describe "self link" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { self_link }
end
- context 'embedded in a form' do
+ context "embedded in a form" do
let(:self_link) { nil }
- it_behaves_like 'has no link' do
- let(:link) { 'self' }
+ it_behaves_like "has no link" do
+ let(:link) { "self" }
end
end
end
diff --git a/spec/lib/api/v3/projects/statuses/status_representer_rendering_spec.rb b/spec/lib/api/v3/projects/statuses/status_representer_rendering_spec.rb
index e26e113cbe3c..aba2eda8824f 100644
--- a/spec/lib/api/v3/projects/statuses/status_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/projects/statuses/status_representer_rendering_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Projects::Statuses::StatusRepresenter, 'rendering' do
+RSpec.describe API::V3::Projects::Statuses::StatusRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
subject { representer.to_json }
@@ -40,26 +40,26 @@
current_user { build_stubbed(:user) }
- describe '_links' do
- describe 'self' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ describe "self" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.project_status status }
let(:title) { I18n.t(:"activerecord.attributes.project.status_codes.#{status}") }
end
end
end
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'ProjectStatus' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "ProjectStatus" }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { status }
end
- it_behaves_like 'property', :name do
+ it_behaves_like "property", :name do
let(:value) { I18n.t(:"activerecord.attributes.project.status_codes.#{status}") }
end
end
diff --git a/spec/lib/api/v3/queries/columns/query_property_column_representer_spec.rb b/spec/lib/api/v3/queries/columns/query_property_column_representer_spec.rb
index dc36c230099a..d161ec718d00 100644
--- a/spec/lib/api/v3/queries/columns/query_property_column_representer_spec.rb
+++ b/spec/lib/api/v3/queries/columns/query_property_column_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Columns::QueryPropertyColumnRepresenter do
include API::V3::Utilities::PathHelper
@@ -36,75 +36,75 @@
subject { representer.to_json }
- describe 'generation' do
- describe '_links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
- let(:href) { api_v3_paths.query_column 'status' }
- let(:title) { 'Status' }
+ describe "generation" do
+ describe "_links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
+ let(:href) { api_v3_paths.query_column "status" }
+ let(:title) { "Status" }
end
end
- it 'has _type QueryColumn::Property' do
+ it "has _type QueryColumn::Property" do
expect(subject)
- .to be_json_eql('QueryColumn::Property'.to_json)
- .at_path('_type')
+ .to be_json_eql("QueryColumn::Property".to_json)
+ .at_path("_type")
end
- it 'has id attribute' do
+ it "has id attribute" do
expect(subject)
- .to be_json_eql('status'.to_json)
- .at_path('id')
+ .to be_json_eql("status".to_json)
+ .at_path("id")
end
- it 'has name attribute' do
+ it "has name attribute" do
expect(subject)
- .to be_json_eql('Status'.to_json)
- .at_path('name')
+ .to be_json_eql("Status".to_json)
+ .at_path("name")
end
- context 'for a translated column' do
+ context "for a translated column" do
let(:column) { Query.available_columns.detect { |column| column.name == :assigned_to } }
- describe '_links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
- let(:href) { api_v3_paths.query_column 'assignee' }
- let(:title) { 'Assignee' }
+ describe "_links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
+ let(:href) { api_v3_paths.query_column "assignee" }
+ let(:title) { "Assignee" }
end
end
- it 'has id attribute' do
+ it "has id attribute" do
expect(subject)
- .to be_json_eql('assignee'.to_json)
- .at_path('id')
+ .to be_json_eql("assignee".to_json)
+ .at_path("id")
end
- it 'has name attribute' do
+ it "has name attribute" do
expect(subject)
- .to be_json_eql('Assignee'.to_json)
- .at_path('name')
+ .to be_json_eql("Assignee".to_json)
+ .at_path("name")
end
end
end
- describe 'caching' do
+ describe "caching" do
before do
# fill the cache
representer.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(representer)
.not_to receive(:to_hash)
representer.to_json
end
- it 'busts the cache on changes to the caption (cf rename)' do
+ it "busts the cache on changes to the caption (cf rename)" do
allow(column)
.to receive(:caption)
- .and_return('blubs')
+ .and_return("blubs")
expect(representer)
.to receive(:to_hash)
@@ -112,10 +112,10 @@
representer.to_json
end
- it 'busts the cache on changes to the name' do
+ it "busts the cache on changes to the name" do
allow(column)
.to receive(:name)
- .and_return('blubs')
+ .and_return("blubs")
expect(representer)
.to receive(:to_hash)
@@ -123,7 +123,7 @@
representer.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(representer)
.to receive(:to_hash)
diff --git a/spec/lib/api/v3/queries/columns/query_relation_of_type_column_representer_spec.rb b/spec/lib/api/v3/queries/columns/query_relation_of_type_column_representer_spec.rb
index 7b95b5fb444c..fc1f73b93961 100644
--- a/spec/lib/api/v3/queries/columns/query_relation_of_type_column_representer_spec.rb
+++ b/spec/lib/api/v3/queries/columns/query_relation_of_type_column_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Columns::QueryRelationOfTypeColumnRepresenter do
include API::V3::Utilities::PathHelper
@@ -37,57 +37,57 @@
subject { representer.to_json }
- describe 'generation' do
- describe '_links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "generation" do
+ describe "_links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.query_column "relationsOfType#{type[:sym].to_s.camelcase}" }
let(:title) { "#{I18n.t(type[:name]).capitalize} relations" }
end
end
- it 'has _type QueryColumn::RelationOfType' do
+ it "has _type QueryColumn::RelationOfType" do
expect(subject)
- .to be_json_eql('QueryColumn::RelationOfType'.to_json)
- .at_path('_type')
+ .to be_json_eql("QueryColumn::RelationOfType".to_json)
+ .at_path("_type")
end
- it 'has id attribute' do
+ it "has id attribute" do
expect(subject)
.to be_json_eql("relationsOfType#{type[:sym].to_s.camelcase}".to_json)
- .at_path('id')
+ .at_path("id")
end
- it 'has relationType attribute' do
+ it "has relationType attribute" do
expect(subject)
.to be_json_eql(type[:sym].to_json)
- .at_path('relationType')
+ .at_path("relationType")
end
- it 'has name attribute' do
+ it "has name attribute" do
expect(subject)
.to be_json_eql("#{I18n.t(type[:name]).capitalize} relations".to_json)
- .at_path('name')
+ .at_path("name")
end
end
- describe 'caching' do
+ describe "caching" do
before do
# fill the cache
representer.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(representer)
.not_to receive(:to_hash)
representer.to_json
end
- it 'busts the cache on changes to the name' do
+ it "busts the cache on changes to the name" do
allow(column)
.to receive(:name)
- .and_return('blubs')
+ .and_return("blubs")
expect(representer)
.to receive(:to_hash)
@@ -95,7 +95,7 @@
representer.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(representer)
.to receive(:to_hash)
diff --git a/spec/lib/api/v3/queries/columns/query_relation_to_type_column_representer_spec.rb b/spec/lib/api/v3/queries/columns/query_relation_to_type_column_representer_spec.rb
index 79d4af9e0b47..9f3a1c2cdd2a 100644
--- a/spec/lib/api/v3/queries/columns/query_relation_to_type_column_representer_spec.rb
+++ b/spec/lib/api/v3/queries/columns/query_relation_to_type_column_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Columns::QueryRelationToTypeColumnRepresenter do
include API::V3::Utilities::PathHelper
@@ -37,57 +37,57 @@
subject { representer.to_json }
- describe 'generation' do
- describe '_links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "generation" do
+ describe "_links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.query_column "relationsToType#{type.id}" }
let(:title) { "Relations to #{type.name}" }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'type' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "type" }
let(:href) { api_v3_paths.type type.id }
let(:title) { type.name }
end
end
- it 'has _type QueryColumn::RelationToType' do
+ it "has _type QueryColumn::RelationToType" do
expect(subject)
- .to be_json_eql('QueryColumn::RelationToType'.to_json)
- .at_path('_type')
+ .to be_json_eql("QueryColumn::RelationToType".to_json)
+ .at_path("_type")
end
- it 'has id attribute' do
+ it "has id attribute" do
expect(subject)
.to be_json_eql("relationsToType#{type.id}".to_json)
- .at_path('id')
+ .at_path("id")
end
- it 'has name attribute' do
+ it "has name attribute" do
expect(subject)
.to be_json_eql("Relations to #{type.name}".to_json)
- .at_path('name')
+ .at_path("name")
end
end
- describe 'caching' do
+ describe "caching" do
before do
# fill the cache
representer.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(representer)
.not_to receive(:to_hash)
representer.to_json
end
- it 'busts the cache on changes to the name' do
+ it "busts the cache on changes to the name" do
allow(column)
.to receive(:name)
- .and_return('blubs')
+ .and_return("blubs")
expect(representer)
.to receive(:to_hash)
@@ -95,10 +95,10 @@
representer.to_json
end
- it 'busts the cache on changes to the type' do
+ it "busts the cache on changes to the type" do
allow(type)
.to receive(:cache_key)
- .and_return('a_different_one')
+ .and_return("a_different_one")
expect(representer)
.to receive(:to_hash)
@@ -106,7 +106,7 @@
representer.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(representer)
.to receive(:to_hash)
diff --git a/spec/lib/api/v3/queries/filters/query_filter_instance_representer_spec.rb b/spec/lib/api/v3/queries/filters/query_filter_instance_representer_spec.rb
index c2e14c666612..29c186c01238 100644
--- a/spec/lib/api/v3/queries/filters/query_filter_instance_representer_spec.rb
+++ b/spec/lib/api/v3/queries/filters/query_filter_instance_representer_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Filters::QueryFilterInstanceRepresenter do
include API::V3::Utilities::PathHelper
- let(:operator) { '=' }
+ let(:operator) { "=" }
let(:values) { [status.id.to_s] }
let(:status) { build_stubbed(:status) }
@@ -52,25 +52,25 @@
.and_return([status])
end
- describe 'generation' do
+ describe "generation" do
subject { representer.to_json }
- describe '_links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'filter' }
- let(:href) { api_v3_paths.query_filter 'status' }
- let(:title) { 'Status' }
+ describe "_links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "filter" }
+ let(:href) { api_v3_paths.query_filter "status" }
+ let(:title) { "Status" }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'operator' }
- let(:href) { api_v3_paths.query_operator(CGI.escape('=')) }
- let(:title) { 'is (OR)' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "operator" }
+ let(:href) { api_v3_paths.query_operator(CGI.escape("=")) }
+ let(:title) { "is (OR)" }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'schema' }
- let(:href) { api_v3_paths.query_filter_instance_schema 'status' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "schema" }
+ let(:href) { api_v3_paths.query_filter_instance_schema "status" }
end
it "has a 'values' collection" do
@@ -81,7 +81,7 @@
expect(subject)
.to be_json_eql([expected].to_json)
- .at_path('_links/values')
+ .at_path("_links/values")
end
it "renders templated values as part of the 'values' collection" do
@@ -90,30 +90,30 @@
.and_return([Queries::Filters::TemplatedValue.new(Status)])
expected = {
- href: api_v3_paths.status('{id}'),
+ href: api_v3_paths.status("{id}"),
title: nil,
templated: true
}
expect(subject)
.to be_json_eql([expected].to_json)
- .at_path('_links/values')
+ .at_path("_links/values")
end
end
- it 'has _type StatusQueryFilter' do
+ it "has _type StatusQueryFilter" do
expect(subject)
- .to be_json_eql('StatusQueryFilter'.to_json)
- .at_path('_type')
+ .to be_json_eql("StatusQueryFilter".to_json)
+ .at_path("_type")
end
- it 'has name Status' do
+ it "has name Status" do
expect(subject)
- .to be_json_eql('Status'.to_json)
- .at_path('name')
+ .to be_json_eql("Status".to_json)
+ .at_path("name")
end
- context 'with an invalid value_objects' do
+ context "with an invalid value_objects" do
let(:filter) do
f = Queries::WorkPackages::Filter::AssignedToFilter.create!
f.operator = operator
@@ -121,7 +121,7 @@
f
end
- let(:values) { ['1'] }
+ let(:values) { ["1"] }
before do
allow(filter)
@@ -132,16 +132,16 @@
it "has a 'values' collection" do
expected = {
href: nil,
- title: 'Anonymous'
+ title: "Anonymous"
}
expect(subject)
.to be_json_eql([expected].to_json)
- .at_path('_links/values')
+ .at_path("_links/values")
end
end
- context 'with a subproject filter value_objects' do
+ context "with a subproject filter value_objects" do
shared_let(:admin) { create(:admin) }
let(:project) { create(:project) }
@@ -151,7 +151,7 @@
project.reload
f = Queries::WorkPackages::Filter::SubprojectFilter.create!(context: project)
- f.operator = '='
+ f.operator = "="
f.values = [subproject.id]
f
@@ -176,12 +176,12 @@
expect(subject)
.to be_json_eql([expected].to_json)
- .at_path('_links/values')
+ .at_path("_links/values")
end
end
- context 'with a non ar object filter' do
- let(:values) { ['lorem ipsum'] }
+ context "with a non ar object filter" do
+ let(:values) { ["lorem ipsum"] }
let(:filter) do
f = Queries::WorkPackages::Filter::SubjectFilter.create!
f.operator = operator
@@ -190,21 +190,21 @@
f
end
- describe '_links' do
- it 'has no values link' do
+ describe "_links" do
+ it "has no values link" do
expect(subject)
- .not_to have_json_path('_links/values')
+ .not_to have_json_path("_links/values")
end
end
it "has a 'values' array property" do
expect(subject)
.to be_json_eql(values.to_json)
- .at_path('values')
+ .at_path("values")
end
end
- context 'with a bool custom field filter' do
+ context "with a bool custom field filter" do
let(:bool_cf) { create(:boolean_wp_custom_field) }
let(:filter) do
Queries::WorkPackages::Filter::CustomFieldFilter.create!(name: bool_cf.column_name, operator:, values:)
@@ -216,7 +216,7 @@
it "has `true` for 'values'" do
expect(subject)
.to be_json_eql([true].to_json)
- .at_path('values')
+ .at_path("values")
end
end
@@ -226,17 +226,17 @@
it "has `true` for 'values'" do
expect(subject)
.to be_json_eql([false].to_json)
- .at_path('values')
+ .at_path("values")
end
end
context "with something as filter value" do
- let(:values) { ['blubs'] }
+ let(:values) { ["blubs"] }
it "has `true` for 'values'" do
expect(subject)
.to be_json_eql([false].to_json)
- .at_path('values')
+ .at_path("values")
end
end
end
diff --git a/spec/lib/api/v3/queries/filters/query_filter_representer_spec.rb b/spec/lib/api/v3/queries/filters/query_filter_representer_spec.rb
index 2f33b3857a40..da598c136af3 100644
--- a/spec/lib/api/v3/queries/filters/query_filter_representer_spec.rb
+++ b/spec/lib/api/v3/queries/filters/query_filter_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Filters::QueryFilterRepresenter do
include API::V3::Utilities::PathHelper
@@ -36,46 +36,46 @@
subject { representer.to_json }
- describe 'generation' do
- describe '_links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
- let(:href) { api_v3_paths.query_filter 'subject' }
- let(:title) { 'Subject' }
+ describe "generation" do
+ describe "_links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
+ let(:href) { api_v3_paths.query_filter "subject" }
+ let(:title) { "Subject" }
end
end
- it 'has _type QueryFilter' do
+ it "has _type QueryFilter" do
expect(subject)
- .to be_json_eql('QueryFilter'.to_json)
- .at_path('_type')
+ .to be_json_eql("QueryFilter".to_json)
+ .at_path("_type")
end
- it 'has id attribute' do
+ it "has id attribute" do
expect(subject)
- .to be_json_eql('subject'.to_json)
- .at_path('id')
+ .to be_json_eql("subject".to_json)
+ .at_path("id")
end
- context 'for a translated filter' do
+ context "for a translated filter" do
let(:filter) { Queries::WorkPackages::Filter::AssignedToFilter.create! }
- describe '_links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
- let(:href) { api_v3_paths.query_filter 'assignee' }
- let(:title) { 'Assignee' }
+ describe "_links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
+ let(:href) { api_v3_paths.query_filter "assignee" }
+ let(:title) { "Assignee" }
end
end
- it 'has id attribute' do
+ it "has id attribute" do
expect(subject)
- .to be_json_eql('assignee'.to_json)
- .at_path('id')
+ .to be_json_eql("assignee".to_json)
+ .at_path("id")
end
end
- context 'for a custom field filter' do
+ context "for a custom field filter" do
let(:custom_field) { build_stubbed(:list_wp_custom_field) }
let(:filter) do
Queries::WorkPackages::Filter::CustomFieldFilter.from_custom_field! custom_field:
@@ -90,18 +90,18 @@
filter
end
- describe '_links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.query_filter custom_field.attribute_name(:camel_case) }
let(:title) { custom_field.name }
end
end
- it 'has id attribute' do
+ it "has id attribute" do
expect(subject)
.to be_json_eql("customField#{custom_field.id}".to_json)
- .at_path('id')
+ .at_path("id")
end
end
end
diff --git a/spec/lib/api/v3/queries/group_bys/query_group_by_representer_spec.rb b/spec/lib/api/v3/queries/group_bys/query_group_by_representer_spec.rb
index 32e3c380c75f..215885558027 100644
--- a/spec/lib/api/v3/queries/group_bys/query_group_by_representer_spec.rb
+++ b/spec/lib/api/v3/queries/group_bys/query_group_by_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::GroupBys::QueryGroupByRepresenter do
include API::V3::Utilities::PathHelper
@@ -36,75 +36,75 @@
subject { representer.to_json }
- describe 'generation' do
- describe '_links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
- let(:href) { api_v3_paths.query_group_by 'status' }
- let(:title) { 'Status' }
+ describe "generation" do
+ describe "_links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
+ let(:href) { api_v3_paths.query_group_by "status" }
+ let(:title) { "Status" }
end
end
- it 'has _type QueryGroupBy' do
+ it "has _type QueryGroupBy" do
expect(subject)
- .to be_json_eql('QueryGroupBy'.to_json)
- .at_path('_type')
+ .to be_json_eql("QueryGroupBy".to_json)
+ .at_path("_type")
end
- it 'has id attribute' do
+ it "has id attribute" do
expect(subject)
- .to be_json_eql('status'.to_json)
- .at_path('id')
+ .to be_json_eql("status".to_json)
+ .at_path("id")
end
- it 'has name attribute' do
+ it "has name attribute" do
expect(subject)
- .to be_json_eql('Status'.to_json)
- .at_path('name')
+ .to be_json_eql("Status".to_json)
+ .at_path("name")
end
- context 'for a translated column' do
+ context "for a translated column" do
let(:column) { Query.available_columns.detect { |column| column.name == :assigned_to } }
- describe '_links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
- let(:href) { api_v3_paths.query_group_by 'assignee' }
- let(:title) { 'Assignee' }
+ describe "_links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
+ let(:href) { api_v3_paths.query_group_by "assignee" }
+ let(:title) { "Assignee" }
end
end
- it 'has id attribute' do
+ it "has id attribute" do
expect(subject)
- .to be_json_eql('assignee'.to_json)
- .at_path('id')
+ .to be_json_eql("assignee".to_json)
+ .at_path("id")
end
- it 'has name attribute' do
+ it "has name attribute" do
expect(subject)
- .to be_json_eql('Assignee'.to_json)
- .at_path('name')
+ .to be_json_eql("Assignee".to_json)
+ .at_path("name")
end
end
end
- describe 'caching' do
+ describe "caching" do
before do
# fill the cache
representer.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(representer)
.not_to receive(:to_hash)
representer.to_json
end
- it 'busts the cache on changes to the caption (cf rename)' do
+ it "busts the cache on changes to the caption (cf rename)" do
allow(column)
.to receive(:caption)
- .and_return('blubs')
+ .and_return("blubs")
expect(representer)
.to receive(:to_hash)
@@ -112,10 +112,10 @@
representer.to_json
end
- it 'busts the cache on changes to the name' do
+ it "busts the cache on changes to the name" do
allow(column)
.to receive(:name)
- .and_return('blubs')
+ .and_return("blubs")
expect(representer)
.to receive(:to_hash)
@@ -123,7 +123,7 @@
representer.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(representer)
.to receive(:to_hash)
diff --git a/spec/lib/api/v3/queries/ical_url/query_ical_url_representer_spec.rb b/spec/lib/api/v3/queries/ical_url/query_ical_url_representer_spec.rb
index 72325d3b249b..6d48d1c14039 100644
--- a/spec/lib/api/v3/queries/ical_url/query_ical_url_representer_spec.rb
+++ b/spec/lib/api/v3/queries/ical_url/query_ical_url_representer_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::ICalUrl::QueryICalUrlRepresenter do
include API::V3::Utilities::PathHelper
let(:query) { build_stubbed(:query) }
- let(:mocked_ical_url) { 'https://community.openproject.org/projects/3/calendars/46/ical?ical_token=66a44f91a18ad0355cfad77c319ef5ee2973291499fb8e44a220885f9124d2d2' }
+ let(:mocked_ical_url) { "https://community.openproject.org/projects/3/calendars/46/ical?ical_token=66a44f91a18ad0355cfad77c319ef5ee2973291499fb8e44a220885f9124d2d2" }
let(:data_to_be_represented) do
ical_url_data = Struct.new(:ical_url, :query)
ical_url_data.new(mocked_ical_url, query)
@@ -45,31 +45,31 @@
subject { representer.to_json }
- describe 'generation' do
- describe '_links' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ describe "generation" do
+ describe "_links" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.query_ical_url(query.id) }
let(:method) { "post" }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'query' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "query" }
let(:href) { api_v3_paths.query(query.id) }
let(:method) { "get" }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'icalUrl' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "icalUrl" }
let(:href) { mocked_ical_url }
let(:method) { "get" }
end
end
- it 'has _type QueryICalUrl' do
+ it "has _type QueryICalUrl" do
expect(subject)
- .to be_json_eql('QueryICalUrl'.to_json)
- .at_path('_type')
+ .to be_json_eql("QueryICalUrl".to_json)
+ .at_path("_type")
end
end
end
diff --git a/spec/lib/api/v3/queries/operators/query_operator_representer_spec.rb b/spec/lib/api/v3/queries/operators/query_operator_representer_spec.rb
index b23629cdbcc7..cbbf02241e63 100644
--- a/spec/lib/api/v3/queries/operators/query_operator_representer_spec.rb
+++ b/spec/lib/api/v3/queries/operators/query_operator_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Operators::QueryOperatorRepresenter do
include API::V3::Utilities::PathHelper
@@ -36,31 +36,31 @@
subject { representer.to_json }
- describe 'generation' do
- describe '_links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "generation" do
+ describe "_links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.query_operator operator.to_query }
let(:title) { I18n.t(:label_not_contains) }
end
end
- it 'has _type QueryOperator' do
+ it "has _type QueryOperator" do
expect(subject)
- .to be_json_eql('QueryOperator'.to_json)
- .at_path('_type')
+ .to be_json_eql("QueryOperator".to_json)
+ .at_path("_type")
end
- it 'has id attribute' do
+ it "has id attribute" do
expect(subject)
.to be_json_eql(operator.to_sym.to_json)
- .at_path('id')
+ .at_path("id")
end
- it 'has name attribute' do
+ it "has name attribute" do
expect(subject)
.to be_json_eql(I18n.t(:label_not_contains).to_json)
- .at_path('name')
+ .at_path("name")
end
end
end
diff --git a/spec/lib/api/v3/queries/queries_params_representer_spec.rb b/spec/lib/api/v3/queries/queries_params_representer_spec.rb
index b74d540df7a4..2e5bf88bed8b 100644
--- a/spec/lib/api/v3/queries/queries_params_representer_spec.rb
+++ b/spec/lib/api/v3/queries/queries_params_representer_spec.rb
@@ -26,27 +26,27 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::QueryParamsRepresenter do
let(:query) { build_stubbed(:query, **params) }
let(:instance) { described_class.new(query) }
- describe '#to_h' do
+ describe "#to_h" do
subject { instance.to_h }
- context 'with include_subprojects true' do
+ context "with include_subprojects true" do
let(:params) { { include_subprojects: true } }
- it 'transports that to the params (Regression #44248)' do
+ it "transports that to the params (Regression #44248)" do
expect(subject[:includeSubprojects]).to be true
end
end
- context 'with include_subprojects false' do
+ context "with include_subprojects false" do
let(:params) { { include_subprojects: false } }
- it 'transports that to the params' do
+ it "transports that to the params" do
expect(subject.keys).to include :includeSubprojects
expect(subject[:includeSubprojects]).to be false
end
diff --git a/spec/lib/api/v3/queries/query_representer_parsing_spec.rb b/spec/lib/api/v3/queries/query_representer_parsing_spec.rb
index 878b83cda865..833863160105 100644
--- a/spec/lib/api/v3/queries/query_representer_parsing_spec.rb
+++ b/spec/lib/api/v3/queries/query_representer_parsing_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Queries::QueryRepresenter, 'parsing' do
+RSpec.describe API::V3::Queries::QueryRepresenter, "parsing" do
include API::V3::Utilities::PathHelper
let(:query) { API::ParserStruct.new }
@@ -68,42 +68,42 @@
subject { representer.from_hash(request_body) }
- describe 'empty group_by (Regression #25606)' do
+ describe "empty group_by (Regression #25606)" do
before do
- query.group_by = 'project'
+ query.group_by = "project"
end
let(:request_body) do
{
- '_links' => {
- 'groupBy' => { 'href' => nil }
+ "_links" => {
+ "groupBy" => { "href" => nil }
}
}
end
- it 'unsets group_by' do
+ it "unsets group_by" do
expect(subject.group_by).to be_nil
end
end
- describe 'highlighted_attributes', with_ee: %i[conditional_highlighting] do
+ describe "highlighted_attributes", with_ee: %i[conditional_highlighting] do
let(:request_body) do
{
- '_links' => {
- 'highlightedAttributes' => [{ 'href' => "/api/v3/queries/columns/type" }]
+ "_links" => {
+ "highlightedAttributes" => [{ "href" => "/api/v3/queries/columns/type" }]
}
}
end
- it 'sets highlighted_attributes' do
+ it "sets highlighted_attributes" do
expect(subject.highlighted_attributes).to eq(%i{type})
end
end
- describe 'ordered work packages' do
+ describe "ordered work packages" do
let(:request_body) do
{
- 'orderedWorkPackages' => {
+ "orderedWorkPackages" => {
50 => 0,
38 => 1234,
102 => 81234123
@@ -111,18 +111,18 @@
}
end
- it 'sets ordered_work_packages' do
+ it "sets ordered_work_packages" do
expect(subject.ordered_work_packages)
.to eq({ "50" => 0, "38" => 1234, "102" => 81234123 })
end
end
- describe 'project' do
+ describe "project" do
let(:request_body) do
{
- '_links' => {
- 'project' => {
- 'href' => "/api/v3/projects/#{project_id}"
+ "_links" => {
+ "project" => {
+ "href" => "/api/v3/projects/#{project_id}"
}
}
}
@@ -141,44 +141,44 @@
.and_return(project.id)
end
- context 'for a number only id' do
+ context "for a number only id" do
let(:project_id) { project.id }
- it 'sets the project_id accordingly' do
+ it "sets the project_id accordingly" do
expect(subject.project_id)
.to eql project.id
end
end
- context 'for a text only id (identifier)' do
+ context "for a text only id (identifier)" do
let(:project_id) { project.identifier }
- it 'deduces the id for the project_id accordingly' do
+ it "deduces the id for the project_id accordingly" do
expect(subject.project_id)
.to eql project.id
end
end
- context 'for a text starting with numbers (identifier)' do
- let(:project) { build_stubbed(:project, identifier: '5555-numbered-identifier') }
+ context "for a text starting with numbers (identifier)" do
+ let(:project) { build_stubbed(:project, identifier: "5555-numbered-identifier") }
let(:project_id) { project.identifier }
- it 'deduces the id for the project_id accordingly' do
+ it "deduces the id for the project_id accordingly" do
expect(subject.project_id)
.to eql project.id
end
end
end
- describe 'timestamps' do
- let(:timestamp_params) { [1.week.ago.iso8601, 'lastWorkingDay@12:00', 'P0D'] }
+ describe "timestamps" do
+ let(:timestamp_params) { [1.week.ago.iso8601, "lastWorkingDay@12:00", "P0D"] }
let(:request_body) do
- { 'timestamps' => timestamp_params }
+ { "timestamps" => timestamp_params }
end
- it 'sets timestamps' do
+ it "sets timestamps" do
expect(subject.timestamps)
- .to eq([1.week.ago.iso8601, 'lastWorkingDay@12:00', 'P0D'])
+ .to eq([1.week.ago.iso8601, "lastWorkingDay@12:00", "P0D"])
end
end
end
diff --git a/spec/lib/api/v3/queries/query_representer_rendering_spec.rb b/spec/lib/api/v3/queries/query_representer_rendering_spec.rb
index bdf1f40037e5..0705103c9b11 100644
--- a/spec/lib/api/v3/queries/query_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/queries/query_representer_rendering_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::QueryRepresenter do
include API::V3::Utilities::PathHelper
@@ -75,47 +75,47 @@ def non_empty_to_query(hash)
else
value.to_query(key)
end
- end.sort! * '&'
+ end.sort! * "&"
end
subject { representer.to_json }
- describe '_links' do
- describe 'self' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ describe "self" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.query(query.id) }
let(:title) { query.name }
end
- context 'with params' do
+ context "with params" do
let(:representer) do
described_class.new(query, current_user: user, embed_links:,
params: { "filters" => "something", "id" => "234" })
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { "#{api_v3_paths.query(query.id)}?filters=something" }
let(:title) { query.name }
end
end
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'user' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "user" }
let(:href) { api_v3_paths.user query.user_id }
let(:title) { query.user.name }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'project' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "project" }
let(:href) { api_v3_paths.project query.project_id }
let(:title) { query.project.name }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'results' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "results" }
let(:href) do
params = {
offset: 1,
@@ -129,25 +129,25 @@ def non_empty_to_query(hash)
end
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'schema' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "schema" }
let(:href) { api_v3_paths.query_project_schema(project.identifier) }
end
- context 'when the query has no project' do
+ context "when the query has no project" do
let(:query) { build_stubbed(:query, project: nil) }
- it_behaves_like 'has an empty link' do
- let(:link) { 'project' }
+ it_behaves_like "has an empty link" do
+ let(:link) { "project" }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'schema' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "schema" }
let(:href) { api_v3_paths.query_schema }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'results' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "results" }
let(:href) do
params = {
offset: 1,
@@ -162,166 +162,166 @@ def non_empty_to_query(hash)
end
end
- describe 'update action link' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'update' }
+ describe "update action link" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "update" }
let(:href) { api_v3_paths.query_form(query.id) }
end
- context 'without a project' do
+ context "without a project" do
let(:query) { build_stubbed(:query, project: nil) }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'schema' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "schema" }
let(:href) { api_v3_paths.query_schema }
end
end
- context 'when unpersisted' do
+ context "when unpersisted" do
let(:query) { unpersisted_query }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'update' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "update" }
let(:href) { api_v3_paths.create_query_form }
end
end
- context 'when unpersisted outside a project' do
+ context "when unpersisted outside a project" do
let(:project) { nil }
let(:query) { unpersisted_query }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'update' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "update" }
let(:href) { api_v3_paths.create_query_form }
end
end
end
- describe 'delete action link' do
+ describe "delete action link" do
let(:permissions) { [:destroy] }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'delete' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "delete" }
let(:href) { api_v3_paths.query query.id }
end
- context 'when not persisted' do
+ context "when not persisted" do
let(:query) { unpersisted_query }
- it_behaves_like 'has no link' do
- let(:link) { 'delete' }
+ it_behaves_like "has no link" do
+ let(:link) { "delete" }
end
end
- context 'when not allowed to delete' do
+ context "when not allowed to delete" do
let(:permissions) { [] }
- it_behaves_like 'has no link' do
- let(:link) { 'delete' }
+ it_behaves_like "has no link" do
+ let(:link) { "delete" }
end
end
- context 'when no user is provided' do
+ context "when no user is provided" do
let(:user) { nil }
let(:embed_links) { false }
- it_behaves_like 'has no link' do
- let(:link) { 'delete' }
+ it_behaves_like "has no link" do
+ let(:link) { "delete" }
end
end
end
- describe 'updateImmediately action link' do
+ describe "updateImmediately action link" do
let(:permissions) { [:update] }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'updateImmediately' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "updateImmediately" }
let(:href) { api_v3_paths.query query.id }
end
- context 'when not persisted and lacking permission' do
+ context "when not persisted and lacking permission" do
let(:query) { unpersisted_query }
- it_behaves_like 'has no link' do
- let(:link) { 'updateImmediately' }
+ it_behaves_like "has no link" do
+ let(:link) { "updateImmediately" }
end
end
- context 'when not persisted and having permission' do
+ context "when not persisted and having permission" do
let(:permissions) { [:create] }
let(:query) { unpersisted_query }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'updateImmediately' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "updateImmediately" }
let(:href) { api_v3_paths.query query.id }
end
end
- context 'when not allowed to update' do
+ context "when not allowed to update" do
let(:permissions) { [] }
- it_behaves_like 'has no link' do
- let(:link) { 'updateImmediately' }
+ it_behaves_like "has no link" do
+ let(:link) { "updateImmediately" }
end
end
- context 'when no user is provided' do
+ context "when no user is provided" do
let(:user) { nil }
let(:embed_links) { false }
- it_behaves_like 'has no link' do
- let(:link) { 'updateImmediately' }
+ it_behaves_like "has no link" do
+ let(:link) { "updateImmediately" }
end
end
end
- describe 'updateOrderedWorkPackages action link' do
+ describe "updateOrderedWorkPackages action link" do
let(:permissions) { %i[update reorder_work_packages] }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'updateOrderedWorkPackages' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "updateOrderedWorkPackages" }
let(:href) { api_v3_paths.query_order query.id }
end
- context 'when not persisted and lacking permission' do
+ context "when not persisted and lacking permission" do
let(:query) { unpersisted_query }
- it_behaves_like 'has no link' do
- let(:link) { 'updateOrderedWorkPackages' }
+ it_behaves_like "has no link" do
+ let(:link) { "updateOrderedWorkPackages" }
end
end
- context 'when not persisted and having permission' do
+ context "when not persisted and having permission" do
let(:permissions) { [:create] }
let(:query) { unpersisted_query }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'updateOrderedWorkPackages' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "updateOrderedWorkPackages" }
let(:href) { api_v3_paths.query_order query.id }
end
end
- context 'when not allowed to update' do
+ context "when not allowed to update" do
let(:permissions) { [] }
- it_behaves_like 'has no link' do
- let(:link) { 'updateOrderedWorkPackages' }
+ it_behaves_like "has no link" do
+ let(:link) { "updateOrderedWorkPackages" }
end
end
- context 'when no user is provided' do
+ context "when no user is provided" do
let(:user) { nil }
let(:embed_links) { false }
- it_behaves_like 'has no link' do
- let(:link) { 'updateOrderedWorkPackages' }
+ it_behaves_like "has no link" do
+ let(:link) { "updateOrderedWorkPackages" }
end
end
end
- context 'with filter, sort, group by and pageSize' do
+ context "with filter, sort, group by and pageSize" do
let(:representer) do
described_class.new(query,
current_user: user)
@@ -329,8 +329,8 @@ def non_empty_to_query(hash)
let(:query) do
query = build_stubbed(:query, project:)
- query.add_filter('subject', '~', ['bogus'])
- query.group_by = 'author'
+ query.add_filter("subject", "~", ["bogus"])
+ query.group_by = "author"
query.sort_criteria = [%w[assigned_to asc], %w[type desc]]
query
@@ -340,24 +340,24 @@ def non_empty_to_query(hash)
params = {
offset: 1,
pageSize: Setting.per_page_options_array.first,
- filters: JSON::dump([{ subject: { operator: '~', values: ['bogus'] } }]),
+ filters: JSON::dump([{ subject: { operator: "~", values: ["bogus"] } }]),
showSums: false,
showHierarchies: false,
includeSubprojects: true,
- groupBy: 'author',
+ groupBy: "author",
sortBy: JSON::dump([%w[assignee asc], %w[type desc]])
}
api_v3_paths.work_packages_by_project(project.id) + "?#{params.to_query}"
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'results' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "results" }
let(:href) { expected_href }
end
end
- context 'with offset and page size' do
+ context "with offset and page size" do
let(:representer) do
described_class.new(query,
current_user: user,
@@ -377,31 +377,31 @@ def non_empty_to_query(hash)
api_v3_paths.work_packages_by_project(project.id) + "?#{non_empty_to_query(params)}"
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'results' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "results" }
let(:href) { expected_href }
end
end
- context 'without columns' do
+ context "without columns" do
let(:query) do
query = build_stubbed(:query, project:)
# need to write bogus here because the query
# will otherwise sport the default columns
- query.column_names = ['blubs']
+ query.column_names = ["blubs"]
query
end
- it 'has an empty columns array' do
+ it "has an empty columns array" do
expect(subject)
.to be_json_eql([].to_json)
- .at_path('_links/columns')
+ .at_path("_links/columns")
end
end
- context 'with columns' do
+ context "with columns" do
let(:query) do
query = build_stubbed(:query, project:)
@@ -410,85 +410,85 @@ def non_empty_to_query(hash)
query
end
- it 'has an array of columns' do
+ it "has an array of columns" do
status = {
- href: '/api/v3/queries/columns/status',
- title: 'Status'
+ href: "/api/v3/queries/columns/status",
+ title: "Status"
}
assignee = {
- href: '/api/v3/queries/columns/assignee',
- title: 'Assignee'
+ href: "/api/v3/queries/columns/assignee",
+ title: "Assignee"
}
subproject = {
- href: '/api/v3/queries/columns/updatedAt',
- title: 'Updated on'
+ href: "/api/v3/queries/columns/updatedAt",
+ title: "Updated on"
}
expected = [status, assignee, subproject]
expect(subject)
.to be_json_eql(expected.to_json)
- .at_path('_links/columns')
+ .at_path("_links/columns")
end
end
- context 'without group_by' do
- it_behaves_like 'has a titled link' do
+ context "without group_by" do
+ it_behaves_like "has a titled link" do
let(:href) { nil }
- let(:link) { 'groupBy' }
+ let(:link) { "groupBy" }
let(:title) { nil }
end
end
- context 'with group_by' do
+ context "with group_by" do
let(:query) do
query = build_stubbed(:query, project:)
- query.group_by = 'status'
+ query.group_by = "status"
query
end
- it_behaves_like 'has a titled link' do
- let(:href) { '/api/v3/queries/group_bys/status' }
- let(:link) { 'groupBy' }
- let(:title) { 'Status' }
+ it_behaves_like "has a titled link" do
+ let(:href) { "/api/v3/queries/group_bys/status" }
+ let(:link) { "groupBy" }
+ let(:title) { "Status" }
end
end
- context 'without sort_by' do
- it 'has an empty sortBy array' do
+ context "without sort_by" do
+ it "has an empty sortBy array" do
expect(subject)
.to be_json_eql([].to_json)
- .at_path('_links/sortBy')
+ .at_path("_links/sortBy")
end
end
- context 'with sort_by' do
+ context "with sort_by" do
let(:query) do
build_stubbed(:query,
sort_criteria: [%w[subject asc], %w[assigned_to desc]])
end
- it 'has an array of sortBy' do
+ it "has an array of sortBy" do
expected = [
{
- href: api_v3_paths.query_sort_by('subject', 'asc'),
- title: 'Subject (Ascending)'
+ href: api_v3_paths.query_sort_by("subject", "asc"),
+ title: "Subject (Ascending)"
},
{
- href: api_v3_paths.query_sort_by('assignee', 'desc'),
- title: 'Assignee (Descending)'
+ href: api_v3_paths.query_sort_by("assignee", "desc"),
+ title: "Assignee (Descending)"
}
]
expect(subject)
.to be_json_eql(expected.to_json)
- .at_path('_links/sortBy')
+ .at_path("_links/sortBy")
end
end
- context 'when not starred' do
+ context "when not starred" do
let(:permissions) { %i(star unstar) }
before do
@@ -497,27 +497,27 @@ def non_empty_to_query(hash)
.and_return(false)
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'star' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "star" }
let(:href) { api_v3_paths.query_star query.id }
end
- it 'has no unstar link' do
+ it "has no unstar link" do
expect(subject)
- .not_to have_json_path('_links/unstar')
+ .not_to have_json_path("_links/unstar")
end
- context 'when lacking permission' do
+ context "when lacking permission" do
let(:permissions) { [] }
- it 'has no star link' do
+ it "has no star link" do
expect(subject)
- .not_to have_json_path('_links/star')
+ .not_to have_json_path("_links/star")
end
end
end
- context 'when starred' do
+ context "when starred" do
let(:permissions) { %i(star unstar) }
before do
@@ -526,146 +526,146 @@ def non_empty_to_query(hash)
.and_return(true)
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'unstar' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "unstar" }
let(:href) { api_v3_paths.query_unstar query.id }
end
- it 'has no star link' do
+ it "has no star link" do
expect(subject)
- .not_to have_json_path('_links/star')
+ .not_to have_json_path("_links/star")
end
- context 'when lacking permission' do
+ context "when lacking permission" do
let(:permissions) { [] }
- it 'has no unstar link' do
+ it "has no unstar link" do
expect(subject)
- .not_to have_json_path('_links/unstar')
+ .not_to have_json_path("_links/unstar")
end
end
end
end
- describe 'ical url' do
- context 'when allowed to subscribe to ical' do
+ describe "ical url" do
+ context "when allowed to subscribe to ical" do
let(:permissions) { %i(share_via_ical) }
- context 'when icalendar sharing is enabled globally', with_settings: { ical_enabled: true } do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'icalUrl' }
+ context "when icalendar sharing is enabled globally", with_settings: { ical_enabled: true } do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "icalUrl" }
let(:href) { api_v3_paths.query_ical_url(query.id) }
end
end
- context 'when icalendar sharing is disabled globally', with_settings: { ical_enabled: false } do
- it 'has no icalUrl link' do
+ context "when icalendar sharing is disabled globally", with_settings: { ical_enabled: false } do
+ it "has no icalUrl link" do
expect(subject)
- .not_to have_json_path('_links/icalUrl')
+ .not_to have_json_path("_links/icalUrl")
end
end
end
- context 'when lacking permission' do
+ context "when lacking permission" do
let(:permissions) { [] }
- it 'has no icalUrl link' do
+ it "has no icalUrl link" do
expect(subject)
- .not_to have_json_path('_links/icalUrl')
+ .not_to have_json_path("_links/icalUrl")
end
end
end
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'Query' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "Query" }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { query.id }
end
- it_behaves_like 'property', :name do
+ it_behaves_like "property", :name do
let(:value) { query.name }
end
- it_behaves_like 'property', :sums do
+ it_behaves_like "property", :sums do
let(:value) { query.display_sums }
end
- it_behaves_like 'property', :timelineVisible do
+ it_behaves_like "property", :timelineVisible do
let(:value) { query.timeline_visible }
end
- it_behaves_like 'property', :timelineZoomLevel do
+ it_behaves_like "property", :timelineZoomLevel do
let(:value) { query.timeline_zoom_level }
end
- it_behaves_like 'property', :timelineLabels do
+ it_behaves_like "property", :timelineLabels do
let(:value) { query.timeline_labels }
end
- it_behaves_like 'property', :timestamps do
+ it_behaves_like "property", :timestamps do
let(:value) { query.timestamps }
end
- it_behaves_like 'property', :public do
+ it_behaves_like "property", :public do
let(:value) { query.public }
end
- describe 'hidden' do
- context 'with the query having a view' do
- it_behaves_like 'property', :hidden do
+ describe "hidden" do
+ context "with the query having a view" do
+ it_behaves_like "property", :hidden do
let(:value) { false }
end
end
- context 'without the query having a view' do
+ context "without the query having a view" do
let(:views) { [] }
- it_behaves_like 'property', :hidden do
+ it_behaves_like "property", :hidden do
let(:value) { true }
end
end
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { query.created_at }
- let(:json_path) { 'createdAt' }
+ let(:json_path) { "createdAt" }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { query.updated_at }
- let(:json_path) { 'updatedAt' }
+ let(:json_path) { "updatedAt" }
end
- describe 'highlighting' do
- context 'with EE', with_ee: %i[conditional_highlighting] do
+ describe "highlighting" do
+ context "with EE", with_ee: %i[conditional_highlighting] do
let :status do
{
- href: '/api/v3/queries/columns/status',
- title: 'Status'
+ href: "/api/v3/queries/columns/status",
+ title: "Status"
}
end
let :type do
{
- href: '/api/v3/queries/columns/type',
- title: 'Type'
+ href: "/api/v3/queries/columns/type",
+ title: "Type"
}
end
let :priority do
{
- href: '/api/v3/queries/columns/priority',
- title: 'Priority'
+ href: "/api/v3/queries/columns/priority",
+ title: "Priority"
}
end
let :due_date do
{
- href: '/api/v3/queries/columns/dueDate',
- title: 'Finish date'
+ href: "/api/v3/queries/columns/dueDate",
+ title: "Finish date"
}
end
@@ -681,25 +681,25 @@ def non_empty_to_query(hash)
[status, priority, due_date]
end
- it 'renders when the value is set' do
- query.highlighting_mode = 'status'
+ it "renders when the value is set" do
+ query.highlighting_mode = "status"
- expect(subject).to be_json_eql('status'.to_json).at_path('highlightingMode')
+ expect(subject).to be_json_eql("status".to_json).at_path("highlightingMode")
end
- it 'renders the default' do
+ it "renders the default" do
query.highlighting_mode = nil
query.highlighted_attributes = nil
- expect(subject).to be_json_eql('inline'.to_json).at_path('highlightingMode')
- expect(subject).not_to have_json_path('highlightedAttributes')
+ expect(subject).to be_json_eql("inline".to_json).at_path("highlightingMode")
+ expect(subject).not_to have_json_path("highlightedAttributes")
end
- it 'links an array of highlighted attributes' do
+ it "links an array of highlighted attributes" do
expect(subject)
- .to be_json_eql(highlighted_attributes.to_json).at_path('_links/highlightedAttributes')
+ .to be_json_eql(highlighted_attributes.to_json).at_path("_links/highlightedAttributes")
end
- it 'embeds selected inline attributes' do
+ it "embeds selected inline attributes" do
query.highlighted_attributes[0..0].each_with_index do |attr, index|
expect(subject)
.to be_json_eql("/api/v3/queries/columns/#{attr}".to_json)
@@ -708,43 +708,43 @@ def non_empty_to_query(hash)
end
end
- context 'without EE' do
- it 'renders when the value is set' do
- query.highlighting_mode = 'status'
+ context "without EE" do
+ it "renders when the value is set" do
+ query.highlighting_mode = "status"
- expect(subject).to be_json_eql('none'.to_json).at_path('highlightingMode')
+ expect(subject).to be_json_eql("none".to_json).at_path("highlightingMode")
end
- it 'renders none when not set' do
+ it "renders none when not set" do
query.highlighting_mode = nil
- expect(subject).to be_json_eql('none'.to_json).at_path('highlightingMode')
+ expect(subject).to be_json_eql("none".to_json).at_path("highlightingMode")
end
end
end
- describe 'showHierarchies' do
- it 'is true if query.show_hierarchies is true' do
+ describe "showHierarchies" do
+ it "is true if query.show_hierarchies is true" do
query.show_hierarchies = true
- expect(subject).to be_json_eql(true.to_json).at_path('showHierarchies')
+ expect(subject).to be_json_eql(true.to_json).at_path("showHierarchies")
end
- it 'is false if query.show_hierarchies is false' do
+ it "is false if query.show_hierarchies is false" do
query.show_hierarchies = false
- expect(subject).to be_json_eql(false.to_json).at_path('showHierarchies')
+ expect(subject).to be_json_eql(false.to_json).at_path("showHierarchies")
end
end
- describe 'with filters' do
+ describe "with filters" do
let(:query) do
query = build_stubbed(:query)
- query.add_filter('status_id', '=', [filter_status.id.to_s])
+ query.add_filter("status_id", "=", [filter_status.id.to_s])
allow(query.filters.last)
.to receive(:value_objects)
.and_return([filter_status])
- query.add_filter('assigned_to_id', '!', [filter_user.id.to_s])
+ query.add_filter("assigned_to_id", "!", [filter_user.id.to_s])
allow(query.filters.last)
.to receive(:value_objects)
.and_return([filter_user])
@@ -763,7 +763,7 @@ def non_empty_to_query(hash)
title: "Status"
},
operator: {
- href: api_v3_paths.query_operator(CGI.escape('=')),
+ href: api_v3_paths.query_operator(CGI.escape("=")),
title: "is (OR)"
},
values: [
@@ -773,7 +773,7 @@ def non_empty_to_query(hash)
}
],
schema: {
- href: api_v3_paths.query_filter_instance_schema('status')
+ href: api_v3_paths.query_filter_instance_schema("status")
}
}
}
@@ -788,7 +788,7 @@ def non_empty_to_query(hash)
title: "Assignee"
},
operator: {
- href: api_v3_paths.query_operator(CGI.escape('!')),
+ href: api_v3_paths.query_operator(CGI.escape("!")),
title: "is not"
},
values: [
@@ -798,37 +798,37 @@ def non_empty_to_query(hash)
}
],
schema: {
- href: api_v3_paths.query_filter_instance_schema('assignee')
+ href: api_v3_paths.query_filter_instance_schema("assignee")
}
}
}
end
- it 'renders the filters' do
+ it "renders the filters" do
expected = [expected_status, expected_assignee]
- expect(subject).to be_json_eql(expected.to_json).at_path('filters')
+ expect(subject).to be_json_eql(expected.to_json).at_path("filters")
end
end
- describe 'with sort criteria' do
+ describe "with sort criteria" do
let(:query) do
build_stubbed(:query,
sort_criteria: [%w[subject asc], %w[assigned_to desc]])
end
- it 'has the sort criteria embedded' do
+ it "has the sort criteria embedded" do
expect(subject)
- .to be_json_eql('/api/v3/queries/sort_bys/subject-asc'.to_json)
- .at_path('_embedded/sortBy/0/_links/self/href')
+ .to be_json_eql("/api/v3/queries/sort_bys/subject-asc".to_json)
+ .at_path("_embedded/sortBy/0/_links/self/href")
expect(subject)
- .to be_json_eql('/api/v3/queries/sort_bys/assignee-desc'.to_json)
- .at_path('_embedded/sortBy/1/_links/self/href')
+ .to be_json_eql("/api/v3/queries/sort_bys/assignee-desc".to_json)
+ .at_path("_embedded/sortBy/1/_links/self/href")
end
end
- describe 'with columns' do
+ describe "with columns" do
let(:query) do
query = build_stubbed(:query, project:)
@@ -837,52 +837,52 @@ def non_empty_to_query(hash)
query
end
- it 'has the columns embedded' do
+ it "has the columns embedded" do
expect(subject)
- .to be_json_eql('/api/v3/queries/columns/status'.to_json)
- .at_path('_embedded/columns/0/_links/self/href')
+ .to be_json_eql("/api/v3/queries/columns/status".to_json)
+ .at_path("_embedded/columns/0/_links/self/href")
end
- context 'when not embedding' do
+ context "when not embedding" do
let(:representer) do
described_class.new(query, current_user: user, embed_links: false)
end
- it 'has no columns embedded' do
+ it "has no columns embedded" do
expect(subject)
- .not_to have_json_path('_embedded/columns')
+ .not_to have_json_path("_embedded/columns")
end
end
end
- describe 'with group by' do
+ describe "with group by" do
let(:query) do
query = build_stubbed(:query, project:)
- query.group_by = 'status'
+ query.group_by = "status"
query
end
- it 'has the group by embedded' do
+ it "has the group by embedded" do
expect(subject)
- .to be_json_eql('/api/v3/queries/group_bys/status'.to_json)
- .at_path('_embedded/groupBy/_links/self/href')
+ .to be_json_eql("/api/v3/queries/group_bys/status".to_json)
+ .at_path("_embedded/groupBy/_links/self/href")
end
- context 'when not embedding' do
+ context "when not embedding" do
let(:representer) do
described_class.new(query, current_user: user, embed_links: false)
end
- it 'has no group bys embedded' do
+ it "has no group bys embedded" do
expect(subject)
- .not_to have_json_path('_embedded/groupBy')
+ .not_to have_json_path("_embedded/groupBy")
end
end
end
- describe 'when timeline is visible' do
+ describe "when timeline is visible" do
let(:query) do
build_stubbed(:query_with_view_gantt, project:).tap do |query|
query.timeline_visible = true
@@ -890,26 +890,26 @@ def non_empty_to_query(hash)
end
it do
- expect(subject).to be_json_eql('true').at_path('timelineVisible')
+ expect(subject).to be_json_eql("true").at_path("timelineVisible")
end
end
- describe 'when labels are overridden' do
+ describe "when labels are overridden" do
let(:query) do
build_stubbed(:query, project:).tap do |query|
query.timeline_labels = expected
end
end
let(:expected) do
- { 'left' => 'assignee', 'right' => 'status', 'farRight' => 'type' }
+ { "left" => "assignee", "right" => "status", "farRight" => "type" }
end
it do
- expect(subject).to be_json_eql(expected.to_json).at_path('timelineLabels')
+ expect(subject).to be_json_eql(expected.to_json).at_path("timelineLabels")
end
end
- describe 'when timeline zoom level is changed' do
+ describe "when timeline zoom level is changed" do
let(:query) do
build_stubbed(:query, project:).tap do |query|
query.timeline_zoom_level = :weeks
@@ -917,12 +917,12 @@ def non_empty_to_query(hash)
end
it do
- expect(subject).to be_json_eql('weeks'.to_json).at_path('timelineZoomLevel')
+ expect(subject).to be_json_eql("weeks".to_json).at_path("timelineZoomLevel")
end
end
end
- describe 'embedded results' do
+ describe "embedded results" do
let(:query) { build_stubbed(:query) }
let(:representer) do
described_class.new(query,
@@ -930,26 +930,26 @@ def non_empty_to_query(hash)
results: results_representer)
end
- context 'when results are provided' do
+ context "when results are provided" do
let(:results_representer) do
{
- _type: 'BogusResultType'
+ _type: "BogusResultType"
}
end
- it 'embeds the results' do
+ it "embeds the results" do
expect(subject)
- .to be_json_eql('BogusResultType'.to_json)
- .at_path('_embedded/results/_type')
+ .to be_json_eql("BogusResultType".to_json)
+ .at_path("_embedded/results/_type")
end
end
- context 'when no results are provided' do
+ context "when no results are provided" do
let(:results_representer) { nil }
- it 'does not embed the results' do
+ it "does not embed the results" do
expect(subject)
- .not_to have_json_path('_embedded/results')
+ .not_to have_json_path("_embedded/results")
end
end
end
diff --git a/spec/lib/api/v3/queries/schemas/blocks_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/blocks_filter_dependency_representer_spec.rb
index b825441b95bf..87bd0a0e1bdf 100644
--- a/spec/lib/api/v3/queries/schemas/blocks_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/blocks_filter_dependency_representer_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
5
RSpec.describe API::V3::Queries::Schemas::BlocksFilterDependencyRepresenter do
- it_behaves_like 'relation filter dependency' do
+ it_behaves_like "relation filter dependency" do
let(:filter) { Queries::WorkPackages::Filter::BlocksFilter.create!(context: query) }
end
end
diff --git a/spec/lib/api/v3/queries/schemas/boolean_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/boolean_filter_dependency_representer_spec.rb
index 6dc5d038299f..5295ccc783d8 100644
--- a/spec/lib/api/v3/queries/schemas/boolean_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/boolean_filter_dependency_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::BooleanFilterDependencyRepresenter do
include API::V3::Utilities::PathHelper
@@ -48,27 +48,27 @@
subject(:generated) { instance.to_json }
- context 'generation' do
- context 'properties' do
- describe 'values' do
- let(:path) { 'values' }
- let(:type) { '[1]Boolean' }
+ context "generation" do
+ context "properties" do
+ describe "values" do
+ let(:path) { "values" }
+ let(:type) { "[1]Boolean" }
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
before do
@@ -76,14 +76,14 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::NotEquals)
expect(instance)
@@ -92,7 +92,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
@@ -101,7 +101,7 @@
end
end
- it 'busts the cache on different form_embedded' do
+ it "busts the cache on different form_embedded" do
embedded_instance = described_class.new(filter,
operator,
form_embedded: !form_embedded)
diff --git a/spec/lib/api/v3/queries/schemas/category_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/category_filter_dependency_representer_spec.rb
index c164266535b9..9a22e57020a0 100644
--- a/spec/lib/api/v3/queries/schemas/category_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/category_filter_dependency_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::CategoryFilterDependencyRepresenter do
include API::V3::Utilities::PathHelper
@@ -44,40 +44,40 @@
subject(:generated) { instance.to_json }
- context 'generation' do
- context 'properties' do
- describe 'value' do
- let(:path) { 'values' }
- let(:type) { '[]Category' }
+ context "generation" do
+ context "properties" do
+ describe "value" do
+ let(:path) { "values" }
+ let(:type) { "[]Category" }
let(:href) { api_v3_paths.categories_by_project(project.identifier) }
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::All'" do
let(:operator) { Queries::Operators::All }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
context "for operator 'Queries::Operators::None'" do
let(:operator) { Queries::Operators::None }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
let(:other_project) { build_stubbed(:project) }
@@ -86,14 +86,14 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::NotEquals)
expect(instance)
@@ -102,7 +102,7 @@
instance.to_json
end
- it 'busts the cache on a different project' do
+ it "busts the cache on a different project" do
query.project = other_project
expect(instance)
@@ -111,7 +111,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
@@ -120,7 +120,7 @@
end
end
- it 'busts the cache on different form_embedded' do
+ it "busts the cache on different form_embedded" do
embedded_instance = described_class.new(filter,
operator,
form_embedded: !form_embedded)
diff --git a/spec/lib/api/v3/queries/schemas/custom_option_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/custom_option_filter_dependency_representer_spec.rb
index 6917a7f9d59f..f445fa224804 100644
--- a/spec/lib/api/v3/queries/schemas/custom_option_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/custom_option_filter_dependency_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::CustomOptionFilterDependencyRepresenter do
include API::V3::Utilities::PathHelper
@@ -56,11 +56,11 @@
subject(:generated) { instance.to_json }
- context 'generation' do
- context 'properties' do
- describe 'values' do
- let(:path) { 'values' }
- let(:type) { '[]CustomOption' }
+ context "generation" do
+ context "properties" do
+ describe "values" do
+ let(:path) { "values" }
+ let(:type) { "[]CustomOption" }
let(:hrefs) do
custom_field.custom_options.map do |value|
api_v3_paths.custom_option(value.id)
@@ -70,30 +70,30 @@
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed value link collection'
+ it_behaves_like "filter dependency with allowed value link collection"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed value link collection'
+ it_behaves_like "filter dependency with allowed value link collection"
end
context "for operator 'Queries::Operators::All'" do
let(:operator) { Queries::Operators::All }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
context "for operator 'Queries::Operators::None'" do
let(:operator) { Queries::Operators::None }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
before do
@@ -102,14 +102,14 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::NotEquals)
expect(instance)
@@ -118,10 +118,10 @@
instance.to_json
end
- it 'busts the cache on a different cache_key' do
+ it "busts the cache on a different cache_key" do
allow(custom_field)
.to receive(:cache_key)
- .and_return('something else')
+ .and_return("something else")
expect(instance)
.to receive(:to_hash)
@@ -129,7 +129,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
@@ -138,7 +138,7 @@
end
end
- it 'busts the cache on different form_embedded' do
+ it "busts the cache on different form_embedded" do
embedded_instance = described_class.new(filter,
operator,
form_embedded: !form_embedded)
diff --git a/spec/lib/api/v3/queries/schemas/date_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/date_filter_dependency_representer_spec.rb
index 76bfa366bab9..05c40684933d 100644
--- a/spec/lib/api/v3/queries/schemas/date_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/date_filter_dependency_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::DateFilterDependencyRepresenter do
include API::V3::Utilities::PathHelper
@@ -44,71 +44,71 @@
subject(:generated) { instance.to_json }
- context 'generation' do
- context 'properties' do
- describe 'values' do
- let(:path) { 'values' }
- let(:type) { '[1]Integer' }
+ context "generation" do
+ context "properties" do
+ describe "values" do
+ let(:path) { "values" }
+ let(:type) { "[1]Integer" }
context "for operator 'Queries::Operators::InLessThan'" do
let(:operator) { Queries::Operators::InLessThan }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::InMoreThan'" do
let(:operator) { Queries::Operators::InMoreThan }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::In'" do
let(:operator) { Queries::Operators::In }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::ThisWeek'" do
let(:operator) { Queries::Operators::ThisWeek }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
context "for operator 'Queries::Operators::LessThanAgo'" do
let(:operator) { Queries::Operators::LessThanAgo }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::MoreThanAgo'" do
let(:operator) { Queries::Operators::MoreThanAgo }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::Ago'" do
let(:operator) { Queries::Operators::Ago }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::OnDate'" do
let(:operator) { Queries::Operators::OnDate }
- let(:type) { '[1]Date' }
+ let(:type) { "[1]Date" }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::BetweenDate'" do
let(:operator) { Queries::Operators::BetweenDate }
- let(:type) { '[2]Date' }
+ let(:type) { "[2]Date" }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
let(:other_project) { build_stubbed(:project) }
@@ -117,14 +117,14 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::NotEquals)
expect(instance)
@@ -133,7 +133,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
@@ -142,7 +142,7 @@
end
end
- it 'busts the cache on different form_embedded' do
+ it "busts the cache on different form_embedded" do
embedded_instance = described_class.new(filter,
operator,
form_embedded: !form_embedded)
diff --git a/spec/lib/api/v3/queries/schemas/date_time_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/date_time_filter_dependency_representer_spec.rb
index e835c28adb57..21e539fdf53c 100644
--- a/spec/lib/api/v3/queries/schemas/date_time_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/date_time_filter_dependency_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::DateTimeFilterDependencyRepresenter do
include API::V3::Utilities::PathHelper
@@ -44,60 +44,60 @@
subject(:generated) { instance.to_json }
- context 'generation' do
- context 'properties' do
- describe 'values' do
- let(:path) { 'values' }
- let(:type) { '[1]Integer' }
+ context "generation" do
+ context "properties" do
+ describe "values" do
+ let(:path) { "values" }
+ let(:type) { "[1]Integer" }
context "for operator 'Queries::Operators::LessThanAgo" do
let(:operator) { Queries::Operators::LessThanAgo }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::MoreThanAgo'" do
let(:operator) { Queries::Operators::MoreThanAgo }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::Ago'" do
let(:operator) { Queries::Operators::Ago }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::Today'" do
let(:operator) { Queries::Operators::Today }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
context "for operator 'Queries::Operators::ThisWeek'" do
let(:operator) { Queries::Operators::ThisWeek }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
context "for operator 'Queries::Operators::OnDate'" do
let(:operator) { Queries::Operators::OnDateTime }
- let(:type) { '[1]DateTime' }
+ let(:type) { "[1]DateTime" }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::BetweenDate'" do
let(:operator) { Queries::Operators::BetweenDateTime }
- let(:type) { '[2]DateTime' }
+ let(:type) { "[2]DateTime" }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
let(:other_project) { build_stubbed(:project) }
@@ -106,14 +106,14 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::NotEquals)
expect(instance)
@@ -122,7 +122,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
@@ -131,7 +131,7 @@
end
end
- it 'busts the cache on different form_embedded' do
+ it "busts the cache on different form_embedded" do
embedded_instance = described_class.new(filter,
operator,
form_embedded: !form_embedded)
diff --git a/spec/lib/api/v3/queries/schemas/duplicated_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/duplicated_filter_dependency_representer_spec.rb
index f220b21b0764..cf097638dda3 100644
--- a/spec/lib/api/v3/queries/schemas/duplicated_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/duplicated_filter_dependency_representer_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
5
RSpec.describe API::V3::Queries::Schemas::DuplicatedFilterDependencyRepresenter do
- it_behaves_like 'relation filter dependency' do
+ it_behaves_like "relation filter dependency" do
let(:filter) { Queries::WorkPackages::Filter::DuplicatedFilter.create!(context: query) }
end
end
diff --git a/spec/lib/api/v3/queries/schemas/duplicates_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/duplicates_filter_dependency_representer_spec.rb
index 8d7e3f479501..b74b1b02444d 100644
--- a/spec/lib/api/v3/queries/schemas/duplicates_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/duplicates_filter_dependency_representer_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
5
RSpec.describe API::V3::Queries::Schemas::DuplicatesFilterDependencyRepresenter do
- it_behaves_like 'relation filter dependency' do
+ it_behaves_like "relation filter dependency" do
let(:filter) { Queries::WorkPackages::Filter::DuplicatesFilter.create!(context: query) }
end
end
diff --git a/spec/lib/api/v3/queries/schemas/filter_dependency_representer_factory_spec.rb b/spec/lib/api/v3/queries/schemas/filter_dependency_representer_factory_spec.rb
index 6a8d83d5ba55..d2988c54fb07 100644
--- a/spec/lib/api/v3/queries/schemas/filter_dependency_representer_factory_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/filter_dependency_representer_factory_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::FilterDependencyRepresenterFactory do
include API::V3::Utilities::PathHelper
@@ -34,284 +34,284 @@
let(:operator) { Queries::Operators::Equals }
let(:form_embedded) { true }
- describe '.create' do
+ describe ".create" do
subject { described_class.create(filter, operator, form_embedded:) }
- context 'assigned to filter' do
+ context "assigned to filter" do
let(:filter) { Queries::WorkPackages::Filter::AssignedToFilter.create! }
- it 'is a all principals with access to project dependency' do
+ it "is a all principals with access to project dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::ProjectMembersFilterDependencyRepresenter)
end
end
- context 'shared with user filter' do
+ context "shared with user filter" do
let(:filter) { Queries::WorkPackages::Filter::SharedWithUserFilter.create! }
- it 'is a all principals with access to project dependency' do
+ it "is a all principals with access to project dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::AccessToProjectFilterDependencyRepresenter)
end
end
- context 'responsible filter' do
+ context "responsible filter" do
let(:filter) { Queries::WorkPackages::Filter::ResponsibleFilter.create! }
- it 'is a project members dependency' do
+ it "is a project members dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::ProjectMembersFilterDependencyRepresenter)
end
end
- context 'author filter' do
+ context "author filter" do
let(:filter) { Queries::WorkPackages::Filter::AuthorFilter.create! }
- it 'is the user dependency' do
+ it "is the user dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::UserFilterDependencyRepresenter)
end
end
- context 'category filter' do
+ context "category filter" do
let(:filter) { Queries::WorkPackages::Filter::CategoryFilter.create! }
- it 'is the category dependency' do
+ it "is the category dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::CategoryFilterDependencyRepresenter)
end
end
- context 'created_at filter' do
+ context "created_at filter" do
let(:filter) { Queries::WorkPackages::Filter::CreatedAtFilter.create! }
- it 'is the date dependency' do
+ it "is the date dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::DateTimeFilterDependencyRepresenter)
end
end
- context 'custom_field filters' do
+ context "custom_field filters" do
let(:filter) do
Queries::WorkPackages::Filter::CustomFieldFilter.from_custom_field! custom_field:
end
- shared_examples_for 'includes the cf json_cache_key mixin' do
+ shared_examples_for "includes the cf json_cache_key mixin" do
it do
expect(subject.singleton_class.included_modules)
.to include(API::V3::Queries::Schemas::CustomFieldJsonCacheKeyMixin)
end
end
- context 'type int' do
+ context "type int" do
let(:custom_field) { build_stubbed(:integer_wp_custom_field) }
- it 'is the integer dependency' do
+ it "is the integer dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::IntegerFilterDependencyRepresenter)
end
- it_behaves_like 'includes the cf json_cache_key mixin'
+ it_behaves_like "includes the cf json_cache_key mixin"
end
- context 'type float' do
+ context "type float" do
let(:custom_field) { build_stubbed(:float_wp_custom_field) }
- it 'is the float dependency' do
+ it "is the float dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::FloatFilterDependencyRepresenter)
end
- it_behaves_like 'includes the cf json_cache_key mixin'
+ it_behaves_like "includes the cf json_cache_key mixin"
end
- context 'type text' do
+ context "type text" do
let(:custom_field) { build_stubbed(:text_wp_custom_field) }
- it 'is the text dependency' do
+ it "is the text dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::TextFilterDependencyRepresenter)
end
- it_behaves_like 'includes the cf json_cache_key mixin'
+ it_behaves_like "includes the cf json_cache_key mixin"
end
- context 'type list' do
+ context "type list" do
let(:custom_field) { build_stubbed(:list_wp_custom_field) }
- it 'is the custom option dependency' do
+ it "is the custom option dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::CustomOptionFilterDependencyRepresenter)
end
- it_behaves_like 'includes the cf json_cache_key mixin'
+ it_behaves_like "includes the cf json_cache_key mixin"
end
- context 'type user' do
+ context "type user" do
let(:custom_field) { build_stubbed(:user_wp_custom_field) }
- it 'is the user dependency' do
+ it "is the user dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::UserFilterDependencyRepresenter)
end
- it_behaves_like 'includes the cf json_cache_key mixin'
+ it_behaves_like "includes the cf json_cache_key mixin"
end
- context 'type version' do
+ context "type version" do
let(:custom_field) { build_stubbed(:version_wp_custom_field) }
- it 'is the version dependency' do
+ it "is the version dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::VersionFilterDependencyRepresenter)
end
- it_behaves_like 'includes the cf json_cache_key mixin'
+ it_behaves_like "includes the cf json_cache_key mixin"
end
- context 'type date' do
+ context "type date" do
let(:custom_field) { build_stubbed(:date_wp_custom_field) }
- it 'is the date dependency' do
+ it "is the date dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::DateFilterDependencyRepresenter)
end
- it_behaves_like 'includes the cf json_cache_key mixin'
+ it_behaves_like "includes the cf json_cache_key mixin"
end
- context 'type bool' do
+ context "type bool" do
let(:custom_field) { build_stubbed(:boolean_wp_custom_field) }
- it 'is the boolean filter dependency' do
+ it "is the boolean filter dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::BooleanFilterDependencyRepresenter)
end
- it_behaves_like 'includes the cf json_cache_key mixin'
+ it_behaves_like "includes the cf json_cache_key mixin"
end
- context 'type string' do
+ context "type string" do
let(:custom_field) { build_stubbed(:string_wp_custom_field) }
- it 'is the text dependency' do
+ it "is the text dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::TextFilterDependencyRepresenter)
end
- it_behaves_like 'includes the cf json_cache_key mixin'
+ it_behaves_like "includes the cf json_cache_key mixin"
end
end
- context 'done_ratio filter' do
+ context "done_ratio filter" do
let(:filter) { Queries::WorkPackages::Filter::DoneRatioFilter.create! }
- it 'is the integer dependency' do
+ it "is the integer dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::IntegerFilterDependencyRepresenter)
end
end
- context 'due_date filter' do
+ context "due_date filter" do
let(:filter) { Queries::WorkPackages::Filter::DueDateFilter.create! }
- it 'is the date dependency' do
+ it "is the date dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::DateFilterDependencyRepresenter)
end
end
- context 'estimated_hours filter' do
+ context "estimated_hours filter" do
let(:filter) { Queries::WorkPackages::Filter::EstimatedHoursFilter.create! }
- it 'is the integer dependency' do
+ it "is the integer dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::IntegerFilterDependencyRepresenter)
end
end
- context 'group filter' do
+ context "group filter" do
let(:filter) { Queries::WorkPackages::Filter::GroupFilter.create! }
- it 'is the group dependency' do
+ it "is the group dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::GroupFilterDependencyRepresenter)
end
end
- context 'id filter' do
+ context "id filter" do
let(:filter) { Queries::WorkPackages::Filter::IdFilter.create! }
- it 'is the id dependency' do
+ it "is the id dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::IdFilterDependencyRepresenter)
end
end
- context 'prioritiy filter' do
+ context "prioritiy filter" do
let(:filter) { Queries::WorkPackages::Filter::PriorityFilter.create! }
- it 'is the priority dependency' do
+ it "is the priority dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::PriorityFilterDependencyRepresenter)
end
end
- context 'project filter' do
+ context "project filter" do
let(:filter) { Queries::WorkPackages::Filter::ProjectFilter.create! }
- it 'is the project dependency' do
+ it "is the project dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::ProjectFilterDependencyRepresenter)
end
end
- context 'role filter' do
+ context "role filter" do
let(:filter) { Queries::WorkPackages::Filter::RoleFilter.create! }
- it 'is the role dependency' do
+ it "is the role dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::RoleFilterDependencyRepresenter)
end
end
- context 'start_date filter' do
+ context "start_date filter" do
let(:filter) { Queries::WorkPackages::Filter::StartDateFilter.create! }
- it 'is the date dependency' do
+ it "is the date dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::DateFilterDependencyRepresenter)
end
end
- context 'subject filter' do
+ context "subject filter" do
let(:filter) { Queries::WorkPackages::Filter::SubjectFilter.create! }
- it 'is the subject dependency' do
+ it "is the subject dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::TextFilterDependencyRepresenter)
end
end
- context 'status filter' do
+ context "status filter" do
let(:filter) { Queries::WorkPackages::Filter::StatusFilter.create! }
- it 'is a status dependency' do
+ it "is a status dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::StatusFilterDependencyRepresenter)
end
end
- context 'subproject filter' do
+ context "subproject filter" do
let(:filter) { Queries::WorkPackages::Filter::SubprojectFilter.create! }
- it 'is a subproject dependency' do
+ it "is a subproject dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::SubprojectFilterDependencyRepresenter)
end
end
- context 'type filter' do
+ context "type filter" do
let(:filter) { Queries::WorkPackages::Filter::TypeFilter.create! }
- it 'is a type dependency' do
+ it "is a type dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::TypeFilterDependencyRepresenter)
end
end
- context 'updated_at filter' do
+ context "updated_at filter" do
let(:filter) { Queries::WorkPackages::Filter::UpdatedAtFilter.create! }
- it 'is a type dependency' do
+ it "is a type dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::DateTimeFilterDependencyRepresenter)
end
end
- context 'version filter' do
+ context "version filter" do
let(:filter) { Queries::WorkPackages::Filter::VersionFilter.create! }
- it 'is a version dependency' do
+ it "is a version dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::VersionFilterDependencyRepresenter)
end
end
- context 'watcher filter' do
+ context "watcher filter" do
let(:filter) { Queries::WorkPackages::Filter::WatcherFilter.create! }
- it 'is a type dependency' do
+ it "is a type dependency" do
expect(subject).to be_a(API::V3::Queries::Schemas::UserFilterDependencyRepresenter)
end
end
diff --git a/spec/lib/api/v3/queries/schemas/float_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/float_filter_dependency_representer_spec.rb
index 7edf481c4da9..3f42fa9b18c2 100644
--- a/spec/lib/api/v3/queries/schemas/float_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/float_filter_dependency_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::FloatFilterDependencyRepresenter do
include API::V3::Utilities::PathHelper
@@ -48,51 +48,51 @@
subject(:generated) { instance.to_json }
- context 'generation' do
- context 'properties' do
- describe 'values' do
- let(:path) { 'values' }
- let(:type) { '[1]Float' }
+ context "generation" do
+ context "properties" do
+ describe "values" do
+ let(:path) { "values" }
+ let(:type) { "[1]Float" }
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::GreaterOrEqual'" do
let(:operator) { Queries::Operators::GreaterOrEqual }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::LessOrEqual'" do
let(:operator) { Queries::Operators::LessOrEqual }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::None'" do
let(:operator) { Queries::Operators::None }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
context "for operator 'Queries::Operators::All'" do
let(:operator) { Queries::Operators::All }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
let(:other_project) { build_stubbed(:project) }
@@ -101,14 +101,14 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::NotEquals)
expect(instance)
@@ -117,7 +117,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
@@ -126,7 +126,7 @@
end
end
- it 'busts the cache on different form_embedded' do
+ it "busts the cache on different form_embedded" do
embedded_instance = described_class.new(filter,
operator,
form_embedded: !form_embedded)
diff --git a/spec/lib/api/v3/queries/schemas/follows_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/follows_filter_dependency_representer_spec.rb
index 720c24fa9bcf..5327932369e1 100644
--- a/spec/lib/api/v3/queries/schemas/follows_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/follows_filter_dependency_representer_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::FollowsFilterDependencyRepresenter do
- it_behaves_like 'relation filter dependency' do
+ it_behaves_like "relation filter dependency" do
let(:filter) { Queries::WorkPackages::Filter::FollowsFilter.create!(context: query) }
end
end
diff --git a/spec/lib/api/v3/queries/schemas/group_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/group_filter_dependency_representer_spec.rb
index 7af11e7d00b7..7dd4c31689c2 100644
--- a/spec/lib/api/v3/queries/schemas/group_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/group_filter_dependency_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::GroupFilterDependencyRepresenter do
include API::V3::Utilities::PathHelper
@@ -44,11 +44,11 @@
subject(:generated) { instance.to_json }
- context 'generation' do
- context 'properties' do
- describe 'values' do
- let(:path) { 'values' }
- let(:type) { '[]User' }
+ context "generation" do
+ context "properties" do
+ describe "values" do
+ let(:path) { "values" }
+ let(:type) { "[]User" }
let(:href) do
"#{api_v3_paths.principals}?filters=#{CGI.escape(JSON.dump(filter_query))}&pageSize=-1"
end
@@ -56,57 +56,57 @@
context "for operator 'Queries::Operators::All'" do
let(:operator) { Queries::Operators::All }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
context "for operator 'Queries::Operators::None'" do
let(:operator) { Queries::Operators::None }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
- context 'within a project' do
+ context "within a project" do
let(:filter_query) do
- [{ type: { operator: '=', values: ['Group'] } },
- { member: { operator: '=', values: [project.id.to_s] } }]
+ [{ type: { operator: "=", values: ["Group"] } },
+ { member: { operator: "=", values: [project.id.to_s] } }]
end
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
end
- context 'global' do
+ context "global" do
let(:project) { nil }
let(:filter_query) do
- [{ type: { operator: '=', values: ['Group'] } },
- { member: { operator: '*', values: [] } }]
+ [{ type: { operator: "=", values: ["Group"] } },
+ { member: { operator: "*", values: [] } }]
end
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
end
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
let(:other_project) { build_stubbed(:project) }
@@ -115,14 +115,14 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::NotEquals)
expect(instance)
@@ -131,7 +131,7 @@
instance.to_json
end
- it 'busts the cache on a different project' do
+ it "busts the cache on a different project" do
query.project = other_project
expect(instance)
@@ -140,7 +140,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
@@ -149,7 +149,7 @@
end
end
- it 'busts the cache on different form_embedded' do
+ it "busts the cache on different form_embedded" do
embedded_instance = described_class.new(filter,
operator,
form_embedded: !form_embedded)
diff --git a/spec/lib/api/v3/queries/schemas/id_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/id_filter_dependency_representer_spec.rb
index 10a1fef20534..d81d3b697e5b 100644
--- a/spec/lib/api/v3/queries/schemas/id_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/id_filter_dependency_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::IdFilterDependencyRepresenter do
include API::V3::Utilities::PathHelper
@@ -44,49 +44,49 @@
subject(:generated) { instance.to_json }
- context 'generation' do
- context 'properties' do
- describe 'values' do
- context 'within project' do
- let(:path) { 'values' }
- let(:type) { '[]WorkPackage' }
+ context "generation" do
+ context "properties" do
+ describe "values" do
+ context "within project" do
+ let(:path) { "values" }
+ let(:type) { "[]WorkPackage" }
let(:href) { api_v3_paths.work_packages_by_project(project.id) }
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
end
- context 'outside of a project' do
+ context "outside of a project" do
let(:project) { nil }
- let(:path) { 'values' }
- let(:type) { '[]WorkPackage' }
+ let(:path) { "values" }
+ let(:type) { "[]WorkPackage" }
let(:href) { api_v3_paths.work_packages }
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
end
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
let(:other_project) { build_stubbed(:project) }
@@ -95,14 +95,14 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::NotEquals)
expect(instance)
@@ -111,7 +111,7 @@
instance.to_json
end
- it 'busts the cache on a different project' do
+ it "busts the cache on a different project" do
query.project = other_project
expect(instance)
@@ -120,7 +120,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
@@ -129,7 +129,7 @@
end
end
- it 'busts the cache on different form_embedded' do
+ it "busts the cache on different form_embedded" do
embedded_instance = described_class.new(filter,
operator,
form_embedded: !form_embedded)
diff --git a/spec/lib/api/v3/queries/schemas/includes_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/includes_filter_dependency_representer_spec.rb
index 6ceec260253d..72285207b7e7 100644
--- a/spec/lib/api/v3/queries/schemas/includes_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/includes_filter_dependency_representer_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
5
RSpec.describe API::V3::Queries::Schemas::IncludesFilterDependencyRepresenter do
- it_behaves_like 'relation filter dependency' do
+ it_behaves_like "relation filter dependency" do
let(:filter) { Queries::WorkPackages::Filter::IncludesFilter.create!(context: query) }
end
end
diff --git a/spec/lib/api/v3/queries/schemas/integer_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/integer_filter_dependency_representer_spec.rb
index 1e29748e9789..84e5150f4098 100644
--- a/spec/lib/api/v3/queries/schemas/integer_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/integer_filter_dependency_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::IntegerFilterDependencyRepresenter do
include API::V3::Utilities::PathHelper
@@ -44,51 +44,51 @@
subject(:generated) { instance.to_json }
- context 'generation' do
- context 'properties' do
- describe 'values' do
- let(:path) { 'values' }
- let(:type) { '[1]Integer' }
+ context "generation" do
+ context "properties" do
+ describe "values" do
+ let(:path) { "values" }
+ let(:type) { "[1]Integer" }
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::GreaterOrEqual'" do
let(:operator) { Queries::Operators::GreaterOrEqual }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::LessOrEqual'" do
let(:operator) { Queries::Operators::LessOrEqual }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::None'" do
let(:operator) { Queries::Operators::None }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
context "for operator 'Queries::Operators::All'" do
let(:operator) { Queries::Operators::All }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
before do
@@ -96,14 +96,14 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::NotEquals)
expect(instance)
@@ -112,7 +112,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
@@ -121,7 +121,7 @@
end
end
- it 'busts the cache on different form_embedded' do
+ it "busts the cache on different form_embedded" do
embedded_instance = described_class.new(filter,
operator,
form_embedded: !form_embedded)
diff --git a/spec/lib/api/v3/queries/schemas/parent_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/parent_filter_dependency_representer_spec.rb
index 4f33f22c68cc..4f0ac1f506c6 100644
--- a/spec/lib/api/v3/queries/schemas/parent_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/parent_filter_dependency_representer_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::ParentFilterDependencyRepresenter do
- it_behaves_like 'relation filter dependency' do
+ it_behaves_like "relation filter dependency" do
let(:filter) { Queries::WorkPackages::Filter::ParentFilter.create!(context: query) }
end
end
diff --git a/spec/lib/api/v3/queries/schemas/partof_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/partof_filter_dependency_representer_spec.rb
index c049852d4987..c91763412775 100644
--- a/spec/lib/api/v3/queries/schemas/partof_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/partof_filter_dependency_representer_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
5
RSpec.describe API::V3::Queries::Schemas::PartofFilterDependencyRepresenter do
- it_behaves_like 'relation filter dependency' do
+ it_behaves_like "relation filter dependency" do
let(:filter) { Queries::WorkPackages::Filter::PartofFilter.create!(context: query) }
end
end
diff --git a/spec/lib/api/v3/queries/schemas/precedes_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/precedes_filter_dependency_representer_spec.rb
index f4d32532b847..abf61587aaa4 100644
--- a/spec/lib/api/v3/queries/schemas/precedes_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/precedes_filter_dependency_representer_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
5
RSpec.describe API::V3::Queries::Schemas::PrecedesFilterDependencyRepresenter do
- it_behaves_like 'relation filter dependency' do
+ it_behaves_like "relation filter dependency" do
let(:filter) { Queries::WorkPackages::Filter::PrecedesFilter.create!(context: query) }
end
end
diff --git a/spec/lib/api/v3/queries/schemas/priority_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/priority_filter_dependency_representer_spec.rb
index 86c19ff5ef4d..ba8a23cfec08 100644
--- a/spec/lib/api/v3/queries/schemas/priority_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/priority_filter_dependency_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::PriorityFilterDependencyRepresenter do
include API::V3::Utilities::PathHelper
@@ -44,28 +44,28 @@
subject(:generated) { instance.to_json }
- context 'generation' do
- context 'properties' do
- describe 'values' do
- let(:path) { 'values' }
- let(:type) { '[]Priority' }
+ context "generation" do
+ context "properties" do
+ describe "values" do
+ let(:path) { "values" }
+ let(:type) { "[]Priority" }
let(:href) { api_v3_paths.priorities }
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
before do
@@ -73,14 +73,14 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::NotEquals)
expect(instance)
@@ -89,7 +89,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
@@ -98,7 +98,7 @@
end
end
- it 'busts the cache on different form_embedded' do
+ it "busts the cache on different form_embedded" do
embedded_instance = described_class.new(filter,
operator,
form_embedded: !form_embedded)
diff --git a/spec/lib/api/v3/queries/schemas/project_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/project_filter_dependency_representer_spec.rb
index 731c656a2067..c3f689d1d2cf 100644
--- a/spec/lib/api/v3/queries/schemas/project_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/project_filter_dependency_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::ProjectFilterDependencyRepresenter do
include API::V3::Utilities::PathHelper
@@ -42,10 +42,10 @@
subject(:generated) { instance.to_json }
- context 'with generation' do
- context 'for properties' do
- let(:path) { 'values' }
- let(:type) { '[]Project' }
+ context "with generation" do
+ context "for properties" do
+ let(:path) { "values" }
+ let(:type) { "[]Project" }
let(:filters) do
"?filters=%5B%7B%22active%22%3A%7B%22operator%22%3A%22%3D%22%2C%22values%22%3A%5B%22t%22%5D%7D%7D%5D&pageSize=-1"
end
@@ -54,29 +54,29 @@
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::All'" do
let(:operator) { Queries::Operators::All }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
context "for operator 'Queries::Operators::None'" do
let(:operator) { Queries::Operators::None }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
before do
@@ -84,7 +84,7 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
allow(instance)
.to receive(:to_hash)
@@ -94,7 +94,7 @@
.not_to have_received(:to_hash)
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::NotEquals)
allow(instance)
@@ -106,7 +106,7 @@
.to have_received(:to_hash)
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
allow(instance)
.to receive(:to_hash)
@@ -118,7 +118,7 @@
.to have_received(:to_hash)
end
- it 'busts the cache on different form_embedded' do
+ it "busts the cache on different form_embedded" do
embedded_instance = described_class.new(filter,
operator,
form_embedded: !form_embedded)
@@ -131,7 +131,7 @@
.to have_received(:to_hash)
end
- it 'busts the cache on different OpenProject::VERSION.product_version' do
+ it "busts the cache on different OpenProject::VERSION.product_version" do
allow(OpenProject::VERSION)
.to receive(:instance_variable_get)
.with(:@product_sha)
@@ -146,10 +146,10 @@
.to have_received(:to_hash)
end
- it 'busts the cache on different OpenProject::VERSION::ARRAY' do
+ it "busts the cache on different OpenProject::VERSION::ARRAY" do
new_version = OpenProject::VERSION::ARRAY
new_version[2] = -1
- stub_const('OpenProject::VERSION::ARRAY', new_version)
+ stub_const("OpenProject::VERSION::ARRAY", new_version)
allow(instance)
.to receive(:to_hash)
diff --git a/spec/lib/api/v3/queries/schemas/project_members_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/project_members_filter_dependency_representer_spec.rb
index 54067194243a..3d74e61aa6dc 100644
--- a/spec/lib/api/v3/queries/schemas/project_members_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/project_members_filter_dependency_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::ProjectMembersFilterDependencyRepresenter do
include API::V3::Utilities::PathHelper
@@ -44,11 +44,11 @@
subject(:generated) { instance.to_json }
- context 'generation' do
- context 'properties' do
- describe 'values' do
- let(:path) { 'values' }
- let(:type) { '[]User' }
+ context "generation" do
+ context "properties" do
+ describe "values" do
+ let(:path) { "values" }
+ let(:type) { "[]User" }
let(:href) do
"#{api_v3_paths.principals}?filters=#{CGI.escape(JSON.dump(filter_query))}&pageSize=-1"
end
@@ -56,57 +56,57 @@
context "for operator 'Queries::Operators::All'" do
let(:operator) { Queries::Operators::All }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
context "for operator 'Queries::Operators::None'" do
let(:operator) { Queries::Operators::None }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
- context 'within a project' do
+ context "within a project" do
let(:filter_query) do
- [{ status: { operator: '!', values: ['3'] } },
- { member: { operator: '=', values: [project.id.to_s] } }]
+ [{ status: { operator: "!", values: ["3"] } },
+ { member: { operator: "=", values: [project.id.to_s] } }]
end
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
end
- context 'global' do
+ context "global" do
let(:project) { nil }
let(:filter_query) do
- [{ status: { operator: '!', values: ['3'] } },
- { member: { operator: '*', values: [] } }]
+ [{ status: { operator: "!", values: ["3"] } },
+ { member: { operator: "*", values: [] } }]
end
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
end
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
let(:other_project) { build_stubbed(:project) }
@@ -115,14 +115,14 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::All)
expect(instance)
@@ -131,7 +131,7 @@
instance.to_json
end
- it 'busts the cache on a different project' do
+ it "busts the cache on a different project" do
query.project = other_project
expect(instance)
@@ -140,7 +140,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
@@ -149,7 +149,7 @@
end
end
- it 'busts the cache on different form_embedded' do
+ it "busts the cache on different form_embedded" do
embedded_instance = described_class.new(filter,
operator,
form_embedded: !form_embedded)
diff --git a/spec/lib/api/v3/queries/schemas/query_filter_instance_schema_representer_spec.rb b/spec/lib/api/v3/queries/schemas/query_filter_instance_schema_representer_spec.rb
index ebd7178f6ac1..7a1ff384ed62 100644
--- a/spec/lib/api/v3/queries/schemas/query_filter_instance_schema_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/query_filter_instance_schema_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::QueryFilterInstanceSchemaRepresenter do
include API::V3::Utilities::PathHelper
@@ -51,19 +51,19 @@
form_embedded:)
end
let(:form_embedded) { false }
- let(:self_link) { 'bogus_self_path' }
+ let(:self_link) { "bogus_self_path" }
let(:project) { nil }
let(:user) { build_stubbed(:user) }
let(:json_cacheable) { true }
- let(:json_cache_key) { 'some key' }
+ let(:json_cache_key) { "some key" }
let(:dependency) do
- double('dependency',
- to_hash: { lorem: 'ipsum' },
+ double("dependency",
+ to_hash: { lorem: "ipsum" },
json_cacheable?: json_cacheable,
json_cache_key:)
end
- context 'generation' do
+ context "generation" do
before do
filter.available_operators.each do |operator|
allow(API::V3::Queries::Schemas::FilterDependencyRepresenterFactory)
@@ -77,138 +77,138 @@
subject(:generated) { instance.to_json }
- context '_links' do
- describe 'self' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ context "_links" do
+ describe "self" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { self_link }
end
end
end
- context 'properties' do
- describe '_type' do
- it 'QueryFilterInstanceSchema' do
+ context "properties" do
+ describe "_type" do
+ it "QueryFilterInstanceSchema" do
expect(subject)
- .to be_json_eql('QueryFilterInstanceSchema'.to_json)
- .at_path('_type')
+ .to be_json_eql("QueryFilterInstanceSchema".to_json)
+ .at_path("_type")
end
end
- describe 'name' do
- let(:path) { 'name' }
+ describe "name" do
+ let(:path) { "name" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'String' }
- let(:name) { 'Name' }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "String" }
+ let(:name) { "Name" }
let(:required) { true }
let(:writable) { false }
let(:has_default) { true }
end
end
- describe 'filter' do
- let(:path) { 'filter' }
+ describe "filter" do
+ let(:path) { "filter" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'QueryFilter' }
- let(:name) { Query.human_attribute_name('filter') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "QueryFilter" }
+ let(:name) { Query.human_attribute_name("filter") }
let(:required) { true }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
- context 'when embedding' do
+ context "when embedding" do
let(:form_embedded) { true }
- it_behaves_like 'links to and embeds allowed values directly' do
- let(:hrefs) { [api_v3_paths.query_filter('status')] }
+ it_behaves_like "links to and embeds allowed values directly" do
+ let(:hrefs) { [api_v3_paths.query_filter("status")] }
end
- context 'with a custom field filter' do
+ context "with a custom field filter" do
let(:filter) { custom_field_filter }
- it_behaves_like 'links to and embeds allowed values directly' do
+ it_behaves_like "links to and embeds allowed values directly" do
let(:hrefs) { [api_v3_paths.query_filter(custom_field.attribute_name(:camel_case))] }
end
end
end
end
- describe 'operator' do
- let(:path) { 'operator' }
+ describe "operator" do
+ let(:path) { "operator" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'QueryOperator' }
- let(:name) { Query.human_attribute_name('operator') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "QueryOperator" }
+ let(:name) { Query.human_attribute_name("operator") }
let(:required) { true }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
- context 'when embedding' do
+ context "when embedding" do
let(:form_embedded) { true }
- it_behaves_like 'links to and embeds allowed values directly' do
+ it_behaves_like "links to and embeds allowed values directly" do
let(:hrefs) do
- [api_v3_paths.query_operator(CGI.escape('o')),
- api_v3_paths.query_operator(CGI.escape('=')),
- api_v3_paths.query_operator(CGI.escape('c')),
- api_v3_paths.query_operator(CGI.escape('!')),
- api_v3_paths.query_operator(CGI.escape('*'))]
+ [api_v3_paths.query_operator(CGI.escape("o")),
+ api_v3_paths.query_operator(CGI.escape("=")),
+ api_v3_paths.query_operator(CGI.escape("c")),
+ api_v3_paths.query_operator(CGI.escape("!")),
+ api_v3_paths.query_operator(CGI.escape("*"))]
end
end
end
end
- describe '_dependencies/0 (we only have one)' do
- describe '_type' do
- it 'is SchemaDependency' do
+ describe "_dependencies/0 (we only have one)" do
+ describe "_type" do
+ it "is SchemaDependency" do
expect(subject)
- .to be_json_eql('SchemaDependency'.to_json)
- .at_path('_dependencies/0/_type')
+ .to be_json_eql("SchemaDependency".to_json)
+ .at_path("_dependencies/0/_type")
end
end
- describe 'on' do
+ describe "on" do
it 'is "operator"' do
expect(subject)
- .to be_json_eql('operator'.to_json)
- .at_path('_dependencies/0/on')
+ .to be_json_eql("operator".to_json)
+ .at_path("_dependencies/0/on")
end
end
- describe 'dependencies' do
- it 'is the hash' do
+ describe "dependencies" do
+ it "is the hash" do
expected = {
- api_v3_paths.query_operator(CGI.escape('=')) => { lorem: "ipsum" },
- api_v3_paths.query_operator(CGI.escape('c')) => { lorem: "ipsum" },
- api_v3_paths.query_operator(CGI.escape('!')) => { lorem: "ipsum" },
- api_v3_paths.query_operator(CGI.escape('*')) => { lorem: "ipsum" },
- api_v3_paths.query_operator(CGI.escape('o')) => { lorem: "ipsum" }
+ api_v3_paths.query_operator(CGI.escape("=")) => { lorem: "ipsum" },
+ api_v3_paths.query_operator(CGI.escape("c")) => { lorem: "ipsum" },
+ api_v3_paths.query_operator(CGI.escape("!")) => { lorem: "ipsum" },
+ api_v3_paths.query_operator(CGI.escape("*")) => { lorem: "ipsum" },
+ api_v3_paths.query_operator(CGI.escape("o")) => { lorem: "ipsum" }
}
expect(subject)
.to be_json_eql(expected.to_json)
- .at_path('_dependencies/0/dependencies')
+ .at_path("_dependencies/0/dependencies")
end
- context 'when filter is a list filter' do
+ context "when filter is a list filter" do
let(:filter) { Queries::WorkPackages::Filter::AuthorFilter.create! }
- it 'is the hash' do
+ it "is the hash" do
expected = {
- api_v3_paths.query_operator(CGI.escape('=')) => { lorem: "ipsum" },
- api_v3_paths.query_operator(CGI.escape('!')) => { lorem: "ipsum" }
+ api_v3_paths.query_operator(CGI.escape("=")) => { lorem: "ipsum" },
+ api_v3_paths.query_operator(CGI.escape("!")) => { lorem: "ipsum" }
}
expect(subject)
.to be_json_eql(expected.to_json)
- .at_path('_dependencies/0/dependencies')
+ .at_path("_dependencies/0/dependencies")
end
end
end
@@ -216,7 +216,7 @@
end
end
- describe 'caching' do
+ describe "caching" do
before do
filter.available_operators.each do |operator|
allow(API::V3::Queries::Schemas::FilterDependencyRepresenterFactory)
@@ -229,17 +229,17 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- context 'with an uncacheable dependency' do
+ context "with an uncacheable dependency" do
let(:json_cacheable) { false }
- it 'is not cached' do
+ it "is not cached" do
expect(instance)
.to receive(:to_hash)
@@ -247,7 +247,7 @@
end
end
- it 'busts the cache on the form_embedded attribute' do
+ it "busts the cache on the form_embedded attribute" do
instance.form_embedded = !form_embedded
expect(instance)
@@ -256,10 +256,10 @@
instance.to_json
end
- it 'busts the cache on a different cache key from a dependency' do
+ it "busts the cache on a different cache key from a dependency" do
allow(dependency)
.to receive(:json_cache_key)
- .and_return(['and', 'now', 'to', 'something', 'completely', 'different'])
+ .and_return(["and", "now", "to", "something", "completely", "different"])
expect(instance)
.to receive(:to_hash)
@@ -267,7 +267,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
diff --git a/spec/lib/api/v3/queries/schemas/query_schema_representer_spec.rb b/spec/lib/api/v3/queries/schemas/query_schema_representer_spec.rb
index 68dae0b4adb3..1e574c4f860e 100644
--- a/spec/lib/api/v3/queries/schemas/query_schema_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/query_schema_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::QuerySchemaRepresenter do
include API::V3::Utilities::PathHelper
@@ -51,7 +51,7 @@
end
let(:form_embedded) { false }
- let(:self_link) { 'bogus_self_path' }
+ let(:self_link) { "bogus_self_path" }
let(:project) { nil }
let(:instance) { described_class.new(query, self_link:, current_user: user, form_embedded:) }
@@ -63,141 +63,141 @@
subject(:generated) { instance.to_json }
- shared_examples_for 'has a collection of allowed values' do
+ shared_examples_for "has a collection of allowed values" do
before do
allow(query).to receive(available_values_method).and_return(available_values)
end
- context 'when no values are allowed' do
+ context "when no values are allowed" do
let(:available_values) do
[]
end
- it_behaves_like 'links to and embeds allowed values directly' do
+ it_behaves_like "links to and embeds allowed values directly" do
let(:hrefs) { [] }
end
end
- context 'when values are allowed' do
- it_behaves_like 'links to and embeds allowed values directly' do
+ context "when values are allowed" do
+ it_behaves_like "links to and embeds allowed values directly" do
let(:hrefs) { expected_hrefs }
end
end
end
- context 'generation' do
- context '_links' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ context "generation" do
+ context "_links" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { self_link }
end
end
- context 'attributes' do
- describe '_type' do
- it 'is Schema' do
+ context "attributes" do
+ describe "_type" do
+ it "is Schema" do
expect(subject)
- .to be_json_eql('Schema'.to_json)
- .at_path('_type')
+ .to be_json_eql("Schema".to_json)
+ .at_path("_type")
end
end
- describe 'id' do
- let(:path) { 'id' }
+ describe "id" do
+ let(:path) { "id" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Integer' }
- let(:name) { Query.human_attribute_name('id') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Integer" }
+ let(:name) { Query.human_attribute_name("id") }
let(:required) { true }
let(:writable) { false }
end
end
- describe 'name' do
- let(:path) { 'name' }
+ describe "name" do
+ let(:path) { "name" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'String' }
- let(:name) { Query.human_attribute_name('name') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "String" }
+ let(:name) { Query.human_attribute_name("name") }
let(:required) { true }
let(:writable) { true }
end
- it_behaves_like 'indicates length requirements' do
+ it_behaves_like "indicates length requirements" do
let(:min_length) { 1 }
let(:max_length) { 255 }
end
end
- describe 'createdAt' do
- let(:path) { 'createdAt' }
+ describe "createdAt" do
+ let(:path) { "createdAt" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'DateTime' }
- let(:name) { Query.human_attribute_name('created_at') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "DateTime" }
+ let(:name) { Query.human_attribute_name("created_at") }
let(:required) { true }
let(:writable) { false }
end
end
- describe 'updatedAt' do
- let(:path) { 'updatedAt' }
+ describe "updatedAt" do
+ let(:path) { "updatedAt" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'DateTime' }
- let(:name) { Query.human_attribute_name('updated_at') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "DateTime" }
+ let(:name) { Query.human_attribute_name("updated_at") }
let(:required) { true }
let(:writable) { false }
end
end
- describe 'user' do
- let(:path) { 'user' }
+ describe "user" do
+ let(:path) { "user" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'User' }
- let(:name) { Query.human_attribute_name('user') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "User" }
+ let(:name) { Query.human_attribute_name("user") }
let(:required) { true }
let(:writable) { false }
let(:has_default) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
end
- describe 'project' do
- let(:path) { 'project' }
+ describe "project" do
+ let(:path) { "project" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Project' }
- let(:name) { Query.human_attribute_name('project') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Project" }
+ let(:name) { Query.human_attribute_name("project") }
let(:required) { false }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
- context 'when embedding' do
+ context "when embedding" do
let(:form_embedded) { true }
- it_behaves_like 'links to allowed values via collection link' do
+ it_behaves_like "links to allowed values via collection link" do
let(:href) { api_v3_paths.query_available_projects }
end
end
end
- describe 'public' do
- let(:path) { 'public' }
+ describe "public" do
+ let(:path) { "public" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Boolean' }
- let(:name) { Query.human_attribute_name('public') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Boolean" }
+ let(:name) { Query.human_attribute_name("public") }
let(:required) { false }
let(:writable) { false }
let(:has_default) { true }
end
- context 'when having the :manage_public_queries permission' do
+ context "when having the :manage_public_queries permission" do
let(:other_project) { build_stubbed(:project) }
before do
@@ -207,149 +207,149 @@
end
end
- it 'marks public as writable' do
+ it "marks public as writable" do
expect(subject)
.to be_json_eql(true)
- .at_path('public/writable')
+ .at_path("public/writable")
end
end
end
- describe 'hidden' do
- let(:path) { 'hidden' }
+ describe "hidden" do
+ let(:path) { "hidden" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Boolean' }
- let(:name) { Query.human_attribute_name('hidden') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Boolean" }
+ let(:name) { Query.human_attribute_name("hidden") }
let(:required) { true }
let(:writable) { true }
let(:has_default) { true }
end
end
- describe 'sums' do
- let(:path) { 'sums' }
+ describe "sums" do
+ let(:path) { "sums" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Boolean' }
- let(:name) { Query.human_attribute_name('sums') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Boolean" }
+ let(:name) { Query.human_attribute_name("sums") }
let(:required) { false }
let(:writable) { true }
let(:has_default) { true }
end
end
- describe 'timelineVisible' do
- let(:path) { 'timelineVisible' }
+ describe "timelineVisible" do
+ let(:path) { "timelineVisible" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Boolean' }
- let(:name) { Query.human_attribute_name('timeline_visible') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Boolean" }
+ let(:name) { Query.human_attribute_name("timeline_visible") }
let(:required) { false }
let(:writable) { true }
let(:has_default) { true }
end
end
- describe 'timelineZoomLevel' do
- let(:path) { 'timelineZoomLevel' }
+ describe "timelineZoomLevel" do
+ let(:path) { "timelineZoomLevel" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'String' }
- let(:name) { Query.human_attribute_name('timeline_zoom_level') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "String" }
+ let(:name) { Query.human_attribute_name("timeline_zoom_level") }
let(:required) { false }
let(:writable) { true }
let(:has_default) { true }
end
end
- describe 'timelineLabels' do
- let(:path) { 'timelineLabels' }
+ describe "timelineLabels" do
+ let(:path) { "timelineLabels" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'QueryTimelineLabels' }
- let(:name) { Query.human_attribute_name('timeline_labels') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "QueryTimelineLabels" }
+ let(:name) { Query.human_attribute_name("timeline_labels") }
let(:required) { false }
let(:writable) { true }
let(:has_default) { true }
end
end
- describe 'timestamps' do
- let(:path) { 'timestamps' }
+ describe "timestamps" do
+ let(:path) { "timestamps" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { '[]Timestamp' }
- let(:name) { Query.human_attribute_name('timestamps') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "[]Timestamp" }
+ let(:name) { Query.human_attribute_name("timestamps") }
let(:required) { false }
let(:writable) { true }
let(:has_default) { true }
end
end
- describe 'show hierarchies' do
- let(:path) { 'showHierarchies' }
+ describe "show hierarchies" do
+ let(:path) { "showHierarchies" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Boolean' }
- let(:name) { Query.human_attribute_name('show_hierarchies') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Boolean" }
+ let(:name) { Query.human_attribute_name("show_hierarchies") }
let(:required) { false }
let(:writable) { true }
let(:has_default) { true }
end
end
- describe 'starred' do
- let(:path) { 'starred' }
+ describe "starred" do
+ let(:path) { "starred" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Boolean' }
- let(:name) { Query.human_attribute_name('starred') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Boolean" }
+ let(:name) { Query.human_attribute_name("starred") }
let(:required) { false }
let(:writable) { false }
let(:has_default) { true }
end
end
- describe 'highlighting_mode' do
- let(:path) { 'highlightingMode' }
+ describe "highlighting_mode" do
+ let(:path) { "highlightingMode" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'String' }
- let(:name) { Query.human_attribute_name('highlighting_mode') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "String" }
+ let(:name) { Query.human_attribute_name("highlighting_mode") }
let(:required) { false }
let(:writable) { true }
let(:has_default) { true }
end
end
- describe 'display_representation' do
- let(:path) { 'displayRepresentation' }
+ describe "display_representation" do
+ let(:path) { "displayRepresentation" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'String' }
- let(:name) { Query.human_attribute_name('display_representation') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "String" }
+ let(:name) { Query.human_attribute_name("display_representation") }
let(:required) { false }
let(:writable) { true }
let(:has_default) { true }
end
end
- describe 'columns' do
- let(:path) { 'columns' }
+ describe "columns" do
+ let(:path) { "columns" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { '[]QueryColumn' }
- let(:name) { Query.human_attribute_name('columns') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "[]QueryColumn" }
+ let(:name) { Query.human_attribute_name("columns") }
let(:required) { false }
let(:writable) { true }
let(:has_default) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
- context 'when embedding' do
+ context "when embedding" do
let(:form_embedded) { true }
let(:type) { build_stubbed(:type) }
let(:available_values) do
@@ -365,19 +365,19 @@
end
let(:available_values_method) { :displayable_columns }
- it_behaves_like 'has a collection of allowed values' do
+ it_behaves_like "has a collection of allowed values" do
let(:expected_hrefs) do
available_values.map do |value|
api_v3_paths.query_column(value.name.to_s.camelcase(:lower))
end
end
- it 'has available columns of both types' do
+ it "has available columns of both types" do
types = JSON.parse(generated)
- .dig('columns',
- '_embedded',
- 'allowedValues')
- .map { |v| v['_type'] }
+ .dig("columns",
+ "_embedded",
+ "allowedValues")
+ .map { |v| v["_type"] }
.uniq
expect(types).to match_array(%w(QueryColumn::Property QueryColumn::RelationToType QueryColumn::RelationOfType))
@@ -386,21 +386,21 @@
end
end
- describe 'show highlighted_attributes' do
- let(:path) { 'highlightedAttributes' }
+ describe "show highlighted_attributes" do
+ let(:path) { "highlightedAttributes" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { '[]QueryColumn' }
- let(:name) { Query.human_attribute_name('highlighted_attributes') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "[]QueryColumn" }
+ let(:name) { Query.human_attribute_name("highlighted_attributes") }
let(:required) { false }
let(:writable) { true }
let(:has_default) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
- context 'when embedding' do
+ context "when embedding" do
let(:form_embedded) { true }
let(:type) { build_stubbed(:type) }
let(:available_values) do
@@ -409,7 +409,7 @@
end
let(:available_values_method) { :displayable_columns }
- it_behaves_like 'has a collection of allowed values' do
+ it_behaves_like "has a collection of allowed values" do
let(:expected_hrefs) do
available_values.map do |value|
api_v3_paths.query_column(value.name.to_s.camelcase(:lower))
@@ -419,34 +419,34 @@
end
end
- describe 'filters' do
- let(:path) { 'filters' }
+ describe "filters" do
+ let(:path) { "filters" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { '[]QueryFilterInstance' }
- let(:name) { Query.human_attribute_name('filters') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "[]QueryFilterInstance" }
+ let(:name) { Query.human_attribute_name("filters") }
let(:required) { false }
let(:writable) { true }
let(:has_default) { true }
end
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
- context 'when global query' do
+ context "when global query" do
let(:href) { api_v3_paths.query_filter_instance_schemas }
- it 'contains the link to the filter schemas' do
+ it "contains the link to the filter schemas" do
expect(subject)
.to be_json_eql(href.to_json)
.at_path("#{path}/_links/allowedValuesSchemas/href")
end
end
- context 'when project query' do
+ context "when project query" do
let(:project) { build_stubbed(:project) }
let(:href) { api_v3_paths.query_project_filter_instance_schemas(project.id) }
- it 'contains the link to the filter schemas' do
+ it "contains the link to the filter schemas" do
expect(subject)
.to be_json_eql(href.to_json)
.at_path("#{path}/_links/allowedValuesSchemas/href")
@@ -454,23 +454,23 @@
end
end
- describe 'groupBy' do
- let(:path) { 'groupBy' }
+ describe "groupBy" do
+ let(:path) { "groupBy" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { '[]QueryGroupBy' }
- let(:name) { Query.human_attribute_name('group_by') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "[]QueryGroupBy" }
+ let(:name) { Query.human_attribute_name("group_by") }
let(:required) { false }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
- context 'when embedding' do
+ context "when embedding" do
let(:form_embedded) { true }
- it_behaves_like 'has a collection of allowed values' do
+ it_behaves_like "has a collection of allowed values" do
let(:available_values) do
[Queries::WorkPackages::Selects::PropertySelect.new(:bogus1),
Queries::WorkPackages::Selects::PropertySelect.new(:bogus2),
@@ -486,24 +486,24 @@
end
end
- describe 'sortBy' do
- let(:path) { 'sortBy' }
+ describe "sortBy" do
+ let(:path) { "sortBy" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { '[]QuerySortBy' }
- let(:name) { Query.human_attribute_name('sort_by') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "[]QuerySortBy" }
+ let(:name) { Query.human_attribute_name("sort_by") }
let(:required) { false }
let(:writable) { true }
let(:has_default) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
- context 'when embedding' do
+ context "when embedding" do
let(:form_embedded) { true }
- it_behaves_like 'has a collection of allowed values' do
+ it_behaves_like "has a collection of allowed values" do
before do
allow(Query)
.to receive(:sortable_columns)
@@ -519,8 +519,8 @@
let(:expected_hrefs) do
expected = available_values.map do |value|
- [api_v3_paths.query_sort_by(value.name, 'asc'),
- api_v3_paths.query_sort_by(value.name, 'desc')]
+ [api_v3_paths.query_sort_by(value.name, "asc"),
+ api_v3_paths.query_sort_by(value.name, "desc")]
end
expected.flatten
@@ -529,37 +529,37 @@
end
end
- describe 'results' do
- let(:path) { 'results' }
+ describe "results" do
+ let(:path) { "results" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'WorkPackageCollection' }
- let(:name) { Query.human_attribute_name('results') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "WorkPackageCollection" }
+ let(:name) { Query.human_attribute_name("results") }
let(:required) { false }
let(:writable) { false }
end
end
end
- context '_embedded' do
- describe 'filtersSchemas' do
- let(:path) { '_embedded/filtersSchemas' }
+ context "_embedded" do
+ describe "filtersSchemas" do
+ let(:path) { "_embedded/filtersSchemas" }
- context 'when global query' do
+ context "when global query" do
let(:href) { api_v3_paths.query_filter_instance_schemas }
- it 'contains a collection of filter schemas' do
+ it "contains a collection of filter schemas" do
expect(subject)
.to be_json_eql(href.to_json)
.at_path("#{path}/_links/self/href")
end
end
- context 'when project query' do
+ context "when project query" do
let(:project) { build_stubbed(:project) }
let(:href) { api_v3_paths.query_project_filter_instance_schemas(project.id) }
- it 'contains a collection of filter schemas' do
+ it "contains a collection of filter schemas" do
expect(subject)
.to be_json_eql(href.to_json)
.at_path("#{path}/_links/self/href")
diff --git a/spec/lib/api/v3/queries/schemas/relates_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/relates_filter_dependency_representer_spec.rb
index 023f646e8d32..7d3bcb26f665 100644
--- a/spec/lib/api/v3/queries/schemas/relates_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/relates_filter_dependency_representer_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
5
RSpec.describe API::V3::Queries::Schemas::RelatesFilterDependencyRepresenter do
- it_behaves_like 'relation filter dependency' do
+ it_behaves_like "relation filter dependency" do
let(:filter) { Queries::WorkPackages::Filter::RelatesFilter.create!(context: query) }
end
end
diff --git a/spec/lib/api/v3/queries/schemas/required_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/required_filter_dependency_representer_spec.rb
index 9280a44e9f1e..3a473eac6128 100644
--- a/spec/lib/api/v3/queries/schemas/required_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/required_filter_dependency_representer_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
5
RSpec.describe API::V3::Queries::Schemas::RequiredFilterDependencyRepresenter do
- it_behaves_like 'relation filter dependency' do
+ it_behaves_like "relation filter dependency" do
let(:filter) { Queries::WorkPackages::Filter::RequiredFilter.create!(context: query) }
end
end
diff --git a/spec/lib/api/v3/queries/schemas/requires_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/requires_filter_dependency_representer_spec.rb
index e7d1806892e5..9e08d71afa50 100644
--- a/spec/lib/api/v3/queries/schemas/requires_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/requires_filter_dependency_representer_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
5
RSpec.describe API::V3::Queries::Schemas::RequiresFilterDependencyRepresenter do
- it_behaves_like 'relation filter dependency' do
+ it_behaves_like "relation filter dependency" do
let(:filter) { Queries::WorkPackages::Filter::RequiresFilter.create!(context: query) }
end
end
diff --git a/spec/lib/api/v3/queries/schemas/role_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/role_filter_dependency_representer_spec.rb
index 2cc7a8946045..5a001f0b9765 100644
--- a/spec/lib/api/v3/queries/schemas/role_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/role_filter_dependency_representer_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::RoleFilterDependencyRepresenter do
include API::V3::Utilities::PathHelper
@@ -44,15 +44,15 @@
subject(:generated) { instance.to_json }
- context 'generation' do
- context 'properties' do
- describe 'values' do
- let(:path) { 'values' }
- let(:type) { '[]Role' }
+ context "generation" do
+ context "properties" do
+ describe "values" do
+ let(:path) { "values" }
+ let(:type) { "[]Role" }
let(:filters) do
[
- allows_becoming_assignee: { operator: '=', values: ['t'] },
- grantable: { operator: '=', values: ['t'] }
+ allows_becoming_assignee: { operator: "=", values: ["t"] },
+ grantable: { operator: "=", values: ["t"] }
]
end
let(:filter_params) do
@@ -63,30 +63,30 @@
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::All'" do
let(:operator) { Queries::Operators::All }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
context "for operator 'Queries::Operators::None'" do
let(:operator) { Queries::Operators::None }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
before do
@@ -94,14 +94,14 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::NotEquals)
expect(instance)
@@ -110,7 +110,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
@@ -119,7 +119,7 @@
end
end
- it 'busts the cache on different form_embedded' do
+ it "busts the cache on different form_embedded" do
embedded_instance = described_class.new(filter,
operator,
form_embedded: !form_embedded)
diff --git a/spec/lib/api/v3/queries/schemas/status_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/status_filter_dependency_representer_spec.rb
index a443a06733f9..a6984d0c4832 100644
--- a/spec/lib/api/v3/queries/schemas/status_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/status_filter_dependency_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::StatusFilterDependencyRepresenter do
include API::V3::Utilities::PathHelper
@@ -42,46 +42,46 @@
subject(:generated) { instance.to_json }
- context 'generation' do
- context 'properties' do
- describe 'values' do
- let(:path) { 'values' }
- let(:type) { '[]Status' }
+ context "generation" do
+ context "properties" do
+ describe "values" do
+ let(:path) { "values" }
+ let(:type) { "[]Status" }
let(:href) { api_v3_paths.statuses }
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::OpenWorkPackages'" do
let(:operator) { Queries::Operators::OpenWorkPackages }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
context "for operator 'Queries::Operators::ClosedWorkPackages'" do
let(:operator) { Queries::Operators::ClosedWorkPackages }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
context "for operator 'Queries::Operators::All'" do
let(:operator) { Queries::Operators::All }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
before do
@@ -89,14 +89,14 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::NotEquals)
expect(instance)
@@ -105,7 +105,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
@@ -114,7 +114,7 @@
end
end
- it 'busts the cache on different form_embedded' do
+ it "busts the cache on different form_embedded" do
embedded_instance = described_class.new(filter,
operator,
form_embedded: !form_embedded)
diff --git a/spec/lib/api/v3/queries/schemas/subproject_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/subproject_filter_dependency_representer_spec.rb
index eff518d7c5a0..1bd3bd3d6505 100644
--- a/spec/lib/api/v3/queries/schemas/subproject_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/subproject_filter_dependency_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::SubprojectFilterDependencyRepresenter do
include API::V3::Utilities::PathHelper
@@ -44,13 +44,13 @@
subject(:generated) { instance.to_json }
- context 'generation' do
- context 'properties' do
- describe 'values' do
- let(:path) { 'values' }
- let(:type) { '[]Project' }
+ context "generation" do
+ context "properties" do
+ describe "values" do
+ let(:path) { "values" }
+ let(:type) { "[]Project" }
let(:filters_params) do
- [ancestor: { operator: '=', values: [project.id.to_s] }]
+ [ancestor: { operator: "=", values: [project.id.to_s] }]
end
let(:href) do
"#{api_v3_paths.projects}?filters=#{CGI.escape(JSON.dump(filters_params))}&pageSize=-1"
@@ -59,24 +59,24 @@
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::All'" do
let(:operator) { Queries::Operators::All }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
context "for operator 'Queries::Operators::None'" do
let(:operator) { Queries::Operators::None }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
let(:other_project) { build_stubbed(:project) }
@@ -85,14 +85,14 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::NotEquals)
expect(instance)
@@ -101,7 +101,7 @@
instance.to_json
end
- it 'busts the cache on a different project' do
+ it "busts the cache on a different project" do
query.project = other_project
expect(instance)
@@ -110,7 +110,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
@@ -119,7 +119,7 @@
end
end
- it 'does not use the project for caching if no project is provided and as such busts the cache' do
+ it "does not use the project for caching if no project is provided and as such busts the cache" do
query.project = nil
expect(instance)
@@ -128,7 +128,7 @@
instance.to_json
end
- it 'busts the cache on different form_embedded' do
+ it "busts the cache on different form_embedded" do
embedded_instance = described_class.new(filter,
operator,
form_embedded: !form_embedded)
diff --git a/spec/lib/api/v3/queries/schemas/text_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/text_filter_dependency_representer_spec.rb
index 6ec0b01ec2a6..a5ea0916ff89 100644
--- a/spec/lib/api/v3/queries/schemas/text_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/text_filter_dependency_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::TextFilterDependencyRepresenter do
include API::V3::Utilities::PathHelper
@@ -44,39 +44,39 @@
subject(:generated) { instance.to_json }
- context 'generation' do
- context 'properties' do
- describe 'values' do
- let(:path) { 'values' }
- let(:type) { '[1]String' }
+ context "generation" do
+ context "properties" do
+ describe "values" do
+ let(:path) { "values" }
+ let(:type) { "[1]String" }
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::Contains'" do
let(:operator) { Queries::Operators::Contains }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
context "for operator 'Queries::Operators::NotContains'" do
let(:operator) { Queries::Operators::NotContains }
- it_behaves_like 'filter dependency'
+ it_behaves_like "filter dependency"
end
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
before do
@@ -84,14 +84,14 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::NotEquals)
expect(instance)
@@ -100,7 +100,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
@@ -109,7 +109,7 @@
end
end
- it 'busts the cache on different form_embedded' do
+ it "busts the cache on different form_embedded" do
embedded_instance = described_class.new(filter,
operator,
form_embedded: !form_embedded)
diff --git a/spec/lib/api/v3/queries/schemas/type_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/type_filter_dependency_representer_spec.rb
index 797e7871fcbb..2543632bd7cf 100644
--- a/spec/lib/api/v3/queries/schemas/type_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/type_filter_dependency_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::TypeFilterDependencyRepresenter do
include API::V3::Utilities::PathHelper
@@ -44,13 +44,13 @@
subject(:generated) { instance.to_json }
- context 'generation' do
- context 'properties' do
- describe 'values' do
- let(:path) { 'values' }
- let(:type) { '[]Type' }
+ context "generation" do
+ context "properties" do
+ describe "values" do
+ let(:path) { "values" }
+ let(:type) { "[]Type" }
- context 'within project' do
+ context "within project" do
let(:href) do
api_v3_paths.types_by_project(project.id)
end
@@ -58,17 +58,17 @@
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
end
- context 'global' do
+ context "global" do
let(:project) { nil }
let(:href) do
api_v3_paths.types
@@ -77,19 +77,19 @@
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
end
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
let(:other_project) { build_stubbed(:project) }
@@ -98,14 +98,14 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::NotEquals)
expect(instance)
@@ -114,7 +114,7 @@
instance.to_json
end
- it 'busts the cache on a different project' do
+ it "busts the cache on a different project" do
query.project = other_project
expect(instance)
@@ -123,7 +123,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
@@ -132,7 +132,7 @@
end
end
- it 'busts the cache on different form_embedded' do
+ it "busts the cache on different form_embedded" do
embedded_instance = described_class.new(filter,
operator,
form_embedded: !form_embedded)
diff --git a/spec/lib/api/v3/queries/schemas/user_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/user_filter_dependency_representer_spec.rb
index 101585dd4ec2..ba9491e98416 100644
--- a/spec/lib/api/v3/queries/schemas/user_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/user_filter_dependency_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::UserFilterDependencyRepresenter do
include API::V3::Utilities::PathHelper
@@ -44,15 +44,15 @@
subject(:generated) { instance.to_json }
- context 'generation' do
- context 'properties' do
- describe 'values' do
- let(:path) { 'values' }
- let(:type) { '[]User' }
+ context "generation" do
+ context "properties" do
+ describe "values" do
+ let(:path) { "values" }
+ let(:type) { "[]User" }
let(:filter_query) do
- [{ type: { operator: '=', values: %w[User Group PlaceholderUser] } },
- { status: { operator: '!', values: ['3'] } },
- { member: { operator: '=', values: [project.id.to_s] } }]
+ [{ type: { operator: "=", values: %w[User Group PlaceholderUser] } },
+ { status: { operator: "!", values: ["3"] } },
+ { member: { operator: "=", values: [project.id.to_s] } }]
end
let(:href) do
"#{api_v3_paths.principals}?filters=#{CGI.escape(JSON.dump(filter_query))}&pageSize=-1"
@@ -61,38 +61,38 @@
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
- context 'global' do
+ context "global" do
let(:project) { nil }
let(:filter_query) do
- [{ type: { operator: '=', values: %w[User Group PlaceholderUser] } },
- { status: { operator: '!', values: ['3'] } }]
+ [{ type: { operator: "=", values: %w[User Group PlaceholderUser] } },
+ { status: { operator: "!", values: ["3"] } }]
end
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
end
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
let(:other_project) { build_stubbed(:project) }
@@ -101,14 +101,14 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::NotEquals)
expect(instance)
@@ -117,7 +117,7 @@
instance.to_json
end
- it 'busts the cache on a different project' do
+ it "busts the cache on a different project" do
query.project = other_project
expect(instance)
@@ -126,7 +126,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
@@ -135,7 +135,7 @@
end
end
- it 'busts the cache on different form_embedded' do
+ it "busts the cache on different form_embedded" do
embedded_instance = described_class.new(filter,
operator,
form_embedded: !form_embedded)
diff --git a/spec/lib/api/v3/queries/schemas/version_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/version_filter_dependency_representer_spec.rb
index cdd841bddf3f..23fae6304e9e 100644
--- a/spec/lib/api/v3/queries/schemas/version_filter_dependency_representer_spec.rb
+++ b/spec/lib/api/v3/queries/schemas/version_filter_dependency_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::Schemas::VersionFilterDependencyRepresenter do
include API::V3::Utilities::PathHelper
@@ -44,26 +44,26 @@
subject(:generated) { instance.to_json }
- context 'generation' do
- context 'properties' do
- describe 'values' do
- let(:path) { 'values' }
- let(:type) { '[]Version' }
+ context "generation" do
+ context "properties" do
+ describe "values" do
+ let(:path) { "values" }
+ let(:type) { "[]Version" }
let(:order) { "sortBy=#{CGI.escape(JSON.dump([%i(semver_name asc)]))}&pageSize=-1" }
context "for operator 'Queries::Operators::All'" do
let(:operator) { Queries::Operators::All }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
context "for operator 'Queries::Operators::None'" do
let(:operator) { Queries::Operators::None }
- it_behaves_like 'filter dependency empty'
+ it_behaves_like "filter dependency empty"
end
- context 'within project' do
+ context "within project" do
let(:href) do
"#{api_v3_paths.versions_by_project(project.id)}?#{order}"
end
@@ -71,20 +71,20 @@
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
end
- context 'global' do
+ context "global" do
let(:project) { nil }
let(:filter_params) do
- [{ sharing: { operator: '=', values: ['system'] } }]
+ [{ sharing: { operator: "=", values: ["system"] } }]
end
let(:href) do
"#{api_v3_paths.versions}?filters=#{CGI.escape(JSON.dump(filter_params))}&#{order}"
@@ -93,19 +93,19 @@
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
end
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
let(:other_project) { build_stubbed(:project) }
@@ -114,14 +114,14 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::NotEquals)
expect(instance)
@@ -130,7 +130,7 @@
instance.to_json
end
- it 'busts the cache on a different project' do
+ it "busts the cache on a different project" do
query.project = other_project
expect(instance)
@@ -139,7 +139,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
@@ -148,7 +148,7 @@
end
end
- it 'busts the cache on different form_embedded' do
+ it "busts the cache on different form_embedded" do
embedded_instance = described_class.new(filter,
operator,
form_embedded: !form_embedded)
diff --git a/spec/lib/api/v3/queries/sort_bys/query_sort_by_representer_spec.rb b/spec/lib/api/v3/queries/sort_bys/query_sort_by_representer_spec.rb
index 75376e8418ae..7354c0f2cd7b 100644
--- a/spec/lib/api/v3/queries/sort_bys/query_sort_by_representer_spec.rb
+++ b/spec/lib/api/v3/queries/sort_bys/query_sort_by_representer_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Queries::SortBys::QuerySortByRepresenter do
include API::V3::Utilities::PathHelper
- let(:column_name) { 'status' }
- let(:direction) { 'desc' }
+ let(:column_name) { "status" }
+ let(:direction) { "desc" }
let(:column) { Queries::WorkPackages::Selects::PropertySelect.new(column_name) }
let(:decorator) { API::V3::Queries::SortBys::SortByDecorator.new(column, direction) }
let(:representer) do
@@ -42,111 +42,111 @@
subject { representer.to_json }
- describe 'generation' do
- describe '_links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
- let(:href) { api_v3_paths.query_sort_by 'status', 'desc' }
- let(:title) { 'Status (Descending)' }
+ describe "generation" do
+ describe "_links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
+ let(:href) { api_v3_paths.query_sort_by "status", "desc" }
+ let(:title) { "Status (Descending)" }
end
end
- it 'has _type QuerySortBy' do
+ it "has _type QuerySortBy" do
expect(subject)
- .to be_json_eql('QuerySortBy'.to_json)
- .at_path('_type')
+ .to be_json_eql("QuerySortBy".to_json)
+ .at_path("_type")
end
- it 'has id attribute' do
+ it "has id attribute" do
expect(subject)
- .to be_json_eql('status-desc'.to_json)
- .at_path('id')
+ .to be_json_eql("status-desc".to_json)
+ .at_path("id")
end
- it 'has name attribute' do
+ it "has name attribute" do
expect(subject)
- .to be_json_eql('Status (Descending)'.to_json)
- .at_path('name')
+ .to be_json_eql("Status (Descending)".to_json)
+ .at_path("name")
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'column' }
- let(:href) { api_v3_paths.query_column 'status' }
- let(:title) { 'Status' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "column" }
+ let(:href) { api_v3_paths.query_column "status" }
+ let(:title) { "Status" }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'direction' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "direction" }
let(:href) { "urn:openproject-org:api:v3:queries:directions:#{direction}" }
- let(:title) { 'Descending' }
+ let(:title) { "Descending" }
end
- context 'when providing an unsupported sort direction' do
- let(:direction) { 'bogus' }
+ context "when providing an unsupported sort direction" do
+ let(:direction) { "bogus" }
- it 'raises error' do
+ it "raises error" do
expect { subject }.to raise_error(ArgumentError)
end
end
- context 'when sorting differently' do
- let(:direction) { 'asc' }
+ context "when sorting differently" do
+ let(:direction) { "asc" }
- it 'has id attribute' do
+ it "has id attribute" do
expect(subject)
- .to be_json_eql('status-asc'.to_json)
- .at_path('id')
+ .to be_json_eql("status-asc".to_json)
+ .at_path("id")
end
- it 'has name attribute' do
+ it "has name attribute" do
expect(subject)
- .to be_json_eql('Status (Ascending)'.to_json)
- .at_path('name')
+ .to be_json_eql("Status (Ascending)".to_json)
+ .at_path("name")
end
end
- context 'for a translated column' do
- let(:column_name) { 'assigned_to' }
+ context "for a translated column" do
+ let(:column_name) { "assigned_to" }
- describe '_links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
- let(:href) { api_v3_paths.query_sort_by 'assignee', 'desc' }
- let(:title) { 'Assignee (Descending)' }
+ describe "_links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
+ let(:href) { api_v3_paths.query_sort_by "assignee", "desc" }
+ let(:title) { "Assignee (Descending)" }
end
end
- it 'has id attribute' do
+ it "has id attribute" do
expect(subject)
- .to be_json_eql('assignee-desc'.to_json)
- .at_path('id')
+ .to be_json_eql("assignee-desc".to_json)
+ .at_path("id")
end
- it 'has name attribute' do
+ it "has name attribute" do
expect(subject)
- .to be_json_eql('Assignee (Descending)'.to_json)
- .at_path('name')
+ .to be_json_eql("Assignee (Descending)".to_json)
+ .at_path("name")
end
end
end
- describe 'caching' do
+ describe "caching" do
before do
# fill the cache
representer.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(representer)
.not_to receive(:to_hash)
representer.to_json
end
- it 'busts the cache on changes to the column_caption (cf rename)' do
+ it "busts the cache on changes to the column_caption (cf rename)" do
allow(decorator)
.to receive(:column_caption)
- .and_return('blubs')
+ .and_return("blubs")
expect(representer)
.to receive(:to_hash)
@@ -154,10 +154,10 @@
representer.to_json
end
- it 'busts the cache on a different direction' do
+ it "busts the cache on a different direction" do
allow(decorator)
.to receive(:direction_name)
- .and_return('asc')
+ .and_return("asc")
expect(representer)
.to receive(:to_hash)
@@ -165,7 +165,7 @@
representer.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(representer)
.to receive(:to_hash)
diff --git a/spec/lib/api/v3/relations/relation_collection_representer_spec.rb b/spec/lib/api/v3/relations/relation_collection_representer_spec.rb
index d9b5ddb46838..0c6ef534c7ff 100644
--- a/spec/lib/api/v3/relations/relation_collection_representer_spec.rb
+++ b/spec/lib/api/v3/relations/relation_collection_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Relations::RelationCollectionRepresenter do
let(:work_package) do
@@ -50,15 +50,15 @@
end
def self_link
- 'a link that is provided'
+ "a link that is provided"
end
- context 'generation' do
+ context "generation" do
subject(:collection) { representer.to_json }
- it_behaves_like 'unpaginated APIv3 collection',
+ it_behaves_like "unpaginated APIv3 collection",
3,
- 'a link that is provided',
- 'Relation'
+ "a link that is provided",
+ "Relation"
end
end
diff --git a/spec/lib/api/v3/relations/relation_paginated_collection_representer_spec.rb b/spec/lib/api/v3/relations/relation_paginated_collection_representer_spec.rb
index e238d9f606da..cc7788a3715e 100644
--- a/spec/lib/api/v3/relations/relation_paginated_collection_representer_spec.rb
+++ b/spec/lib/api/v3/relations/relation_paginated_collection_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Relations::RelationPaginatedCollectionRepresenter do
let(:work_package) do
@@ -66,10 +66,10 @@
let(:page) { 1 }
let(:page_size) { 20 }
let(:actual_count) { total }
- let(:self_base_link) { 'api/v3/relations' }
- let(:collection_inner_type) { 'Relation' }
+ let(:self_base_link) { "api/v3/relations" }
+ let(:collection_inner_type) { "Relation" }
subject(:collection) { representer.to_json }
- it_behaves_like 'offset-paginated APIv3 collection', 3, 'relations', 'Relation'
+ it_behaves_like "offset-paginated APIv3 collection", 3, "relations", "Relation"
end
diff --git a/spec/lib/api/v3/relations/relation_representer_spec.rb b/spec/lib/api/v3/relations/relation_representer_spec.rb
index c07b0ad68262..13f313fefb65 100644
--- a/spec/lib/api/v3/relations/relation_representer_spec.rb
+++ b/spec/lib/api/v3/relations/relation_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Relations::RelationRepresenter do
let(:user) { build_stubbed(:admin) }
@@ -83,13 +83,13 @@
}
end
- it 'serializes the relation correctly' do
+ it "serializes the relation correctly" do
data = JSON.parse representer.to_json
expect(data).to eq result
end
- it 'deserializes the relation correctly' do
+ it "deserializes the relation correctly" do
rep = API::V3::Relations::RelationRepresenter.new OpenStruct.new, current_user: user
rel = rep.from_json result.except(:id).to_json
diff --git a/spec/lib/api/v3/repositories/revision_representer_spec.rb b/spec/lib/api/v3/repositories/revision_representer_spec.rb
index 2478305b2736..772f956034f5 100644
--- a/spec/lib/api/v3/repositories/revision_representer_spec.rb
+++ b/spec/lib/api/v3/repositories/revision_representer_spec.rb
@@ -26,75 +26,75 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Repositories::RevisionRepresenter do
include API::V3::Utilities::PathHelper
- let(:representer) { described_class.new(revision, current_user: double('current_user')) }
+ let(:representer) { described_class.new(revision, current_user: double("current_user")) }
let(:project) { build(:project) }
let(:repository) { build(:repository_subversion, project:) }
let(:revision) do
build(:changeset,
id: 42,
- revision: '1234',
+ revision: "1234",
repository:,
comments: commit_message,
- committer: 'foo bar ',
+ committer: "foo bar ",
committed_on: DateTime.now)
end
- let(:commit_message) { 'Some commit message' }
+ let(:commit_message) { "Some commit message" }
- context 'generation' do
+ context "generation" do
subject(:generated) { representer.to_json }
- it { is_expected.to be_json_eql('Revision'.to_json).at_path('_type') }
+ it { is_expected.to be_json_eql("Revision".to_json).at_path("_type") }
- describe 'revision' do
- it { is_expected.to have_json_path('id') }
+ describe "revision" do
+ it { is_expected.to have_json_path("id") }
- it_behaves_like 'API V3 formattable', 'message' do
- let(:format) { 'plain' }
+ it_behaves_like "API V3 formattable", "message" do
+ let(:format) { "plain" }
let(:raw) { revision.comments }
- let(:html) { '
' + revision.comments + '
' }
+ let(:html) { "
" + revision.comments + "
" }
end
- describe 'identifier' do
- it { is_expected.to have_json_path('identifier') }
- it { is_expected.to be_json_eql('1234'.to_json).at_path('identifier') }
+ describe "identifier" do
+ it { is_expected.to have_json_path("identifier") }
+ it { is_expected.to be_json_eql("1234".to_json).at_path("identifier") }
end
- describe 'formattedIdentifier' do
+ describe "formattedIdentifier" do
before do
- allow(revision).to receive(:format_identifier).and_return('123')
+ allow(revision).to receive(:format_identifier).and_return("123")
end
- it { is_expected.to have_json_path('formattedIdentifier') }
- it { is_expected.to be_json_eql('123'.to_json).at_path('formattedIdentifier') }
+ it { is_expected.to have_json_path("formattedIdentifier") }
+ it { is_expected.to be_json_eql("123".to_json).at_path("formattedIdentifier") }
end
- describe 'createdAt' do
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ describe "createdAt" do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { revision.committed_on }
- let(:json_path) { 'createdAt' }
+ let(:json_path) { "createdAt" }
end
end
- describe 'authorName' do
- it { is_expected.to have_json_path('authorName') }
- it { is_expected.to be_json_eql('foo bar '.to_json).at_path('authorName') }
+ describe "authorName" do
+ it { is_expected.to have_json_path("authorName") }
+ it { is_expected.to be_json_eql("foo bar ".to_json).at_path("authorName") }
end
end
- context 'with referencing commit message' do
+ context "with referencing commit message" do
let(:work_package) { build_stubbed(:work_package, project:) }
let(:commit_message) { "Totally references ##{work_package.id}" }
let(:html_reference) do
id = work_package.id
- str = 'Totally references "
str << "##{id}"
@@ -103,42 +103,42 @@
before do
allow(User).to receive(:current).and_return(build_stubbed(:admin))
allow(WorkPackage)
- .to receive_message_chain('includes.references.find_by')
+ .to receive_message_chain("includes.references.find_by")
.and_return(work_package)
end
- it_behaves_like 'API V3 formattable', 'message' do
- let(:format) { 'plain' }
+ it_behaves_like "API V3 formattable", "message" do
+ let(:format) { "plain" }
let(:raw) { revision.comments }
- let(:html) { '
' + html_reference + '
' }
+ let(:html) { "
" + html_reference + "
" }
end
end
- describe 'author' do
- context 'with no linked user' do
- it_behaves_like 'has no link' do
- let(:link) { 'author' }
+ describe "author" do
+ context "with no linked user" do
+ it_behaves_like "has no link" do
+ let(:link) { "author" }
end
end
- context 'with linked user as author' do
+ context "with linked user as author" do
let(:user) { build(:user) }
before do
allow(revision).to receive(:user).and_return(user)
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'author' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "author" }
let(:href) { api_v3_paths.user(user.id) }
let(:title) { user.name }
end
end
end
- describe 'showRevision' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'showRevision' }
+ describe "showRevision" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "showRevision" }
let(:href) { api_v3_paths.show_revision(project.identifier, revision.identifier) }
end
end
diff --git a/spec/lib/api/v3/root_representer_spec.rb b/spec/lib/api/v3/root_representer_spec.rb
index 1a52832b825b..d389894c1eca 100644
--- a/spec/lib/api/v3/root_representer_spec.rb
+++ b/spec/lib/api/v3/root_representer_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::RootRepresenter do
include API::V3::Utilities::PathHelper
let(:user) { build_stubbed(:user) }
let(:representer) { described_class.new({}, current_user: user) }
- let(:app_title) { 'Foo Project' }
- let(:version) { 'The version is over 9000!' }
+ let(:app_title) { "Foo Project" }
+ let(:version) { "The version is over 9000!" }
let(:permissions) { [:view_members] }
before do
@@ -43,7 +43,7 @@
end
end
- context 'generation' do
+ context "generation" do
subject { representer.to_json }
before do
@@ -51,123 +51,123 @@
allow(OpenProject::VERSION).to receive(:to_semver).and_return version
end
- describe '_links' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.root }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'configuration' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "configuration" }
let(:href) { api_v3_paths.configuration }
end
- describe 'memberships' do
- context 'if having the view_members permission in any project' do
+ describe "memberships" do
+ context "if having the view_members permission in any project" do
let(:permissions) { [:view_members] }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'memberships' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "memberships" }
let(:href) { api_v3_paths.memberships }
end
end
- context 'if having the manage_members permission in any project' do
+ context "if having the manage_members permission in any project" do
let(:permissions) { [:manage_members] }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'memberships' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "memberships" }
let(:href) { api_v3_paths.memberships }
end
end
- context 'if lacking permissions' do
+ context "if lacking permissions" do
let(:permissions) { [] }
- it_behaves_like 'has no link' do
- let(:link) { 'members' }
+ it_behaves_like "has no link" do
+ let(:link) { "members" }
end
end
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'priorities' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "priorities" }
let(:href) { api_v3_paths.priorities }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'statuses' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "statuses" }
let(:href) { api_v3_paths.statuses }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'types' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "types" }
let(:href) { api_v3_paths.types }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'workPackages' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "workPackages" }
let(:href) { api_v3_paths.work_packages }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'user' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "user" }
let(:href) { api_v3_paths.user(user.id) }
let(:title) { user.name }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'userPreferences' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "userPreferences" }
let(:href) { api_v3_paths.user_preferences(user.id) }
end
- context 'anonymous user' do
+ context "anonymous user" do
let(:representer) { described_class.new({}, current_user: User.anonymous) }
- it_behaves_like 'has no link' do
- let(:link) { 'user' }
+ it_behaves_like "has no link" do
+ let(:link) { "user" }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'userPreferences' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "userPreferences" }
let(:href) { api_v3_paths.user_preferences(User.anonymous.id) }
end
end
end
- context 'attributes' do
- describe '_type' do
+ context "attributes" do
+ describe "_type" do
it 'is "Root"' do
expect(subject)
- .to be_json_eql('Root'.to_json)
- .at_path('_type')
+ .to be_json_eql("Root".to_json)
+ .at_path("_type")
end
end
- describe 'coreVersion' do
- context 'for a non admin user' do
- it 'has no coreVersion property' do
+ describe "coreVersion" do
+ context "for a non admin user" do
+ it "has no coreVersion property" do
expect(subject)
- .not_to have_json_path('coreVersion')
+ .not_to have_json_path("coreVersion")
end
end
- context 'for an admin user' do
+ context "for an admin user" do
let(:user) { build_stubbed(:admin) }
- it 'indicates the OpenProject version number' do
+ it "indicates the OpenProject version number" do
expect(subject)
.to be_json_eql(version.to_json)
- .at_path('coreVersion')
+ .at_path("coreVersion")
end
end
end
- describe 'instanceName' do
- it 'shows the name of the instance' do
+ describe "instanceName" do
+ it "shows the name of the instance" do
expect(subject)
.to be_json_eql(app_title.to_json)
- .at_path('instanceName')
+ .at_path("instanceName")
end
end
end
diff --git a/spec/lib/api/v3/shares/share_collection_representer_spec.rb b/spec/lib/api/v3/shares/share_collection_representer_spec.rb
index 76f425eef7b6..c4d4eb44b6e4 100644
--- a/spec/lib/api/v3/shares/share_collection_representer_spec.rb
+++ b/spec/lib/api/v3/shares/share_collection_representer_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Shares::ShareCollectionRepresenter do
- let(:self_base_link) { '/api/v3/shares' }
+ let(:self_base_link) { "/api/v3/shares" }
let(:members) do
build_stubbed_list(:work_package_member, 3).tap do |members|
allow(members).to receive(:limit).with(page_size).and_return(members)
@@ -49,13 +49,13 @@
let(:page) { 1 }
let(:page_size) { 2 }
let(:actual_count) { 3 }
- let(:collection_inner_type) { 'Share' }
+ let(:collection_inner_type) { "Share" }
include API::V3::Utilities::PathHelper
- context 'generation' do
+ context "generation" do
subject(:collection) { representer.to_json }
- it_behaves_like 'offset-paginated APIv3 collection', 3, 'shares', 'Share'
+ it_behaves_like "offset-paginated APIv3 collection", 3, "shares", "Share"
end
end
diff --git a/spec/lib/api/v3/shares/share_representer_rendering_spec.rb b/spec/lib/api/v3/shares/share_representer_rendering_spec.rb
index c3a9b578e033..f7703f0c1486 100644
--- a/spec/lib/api/v3/shares/share_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/shares/share_representer_rendering_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Shares::ShareRepresenter, 'rendering' do
+RSpec.describe API::V3::Shares::ShareRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
shared_let(:project) { create(:project_with_types) }
@@ -73,54 +73,54 @@
end
end
- describe '_links' do
- describe 'self' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ describe "self" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.share member.id }
let(:title) { user.name }
end
end
- describe 'entity' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'entity' }
+ describe "entity" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "entity" }
let(:href) { api_v3_paths.work_package(work_package.id) }
let(:title) { work_package.subject }
end
end
- describe 'project' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'project' }
+ describe "project" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "project" }
let(:href) { api_v3_paths.project(project.id) }
let(:title) { project.name }
end
end
- describe 'principal' do
- context 'for a user principal' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'principal' }
+ describe "principal" do
+ context "for a user principal" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "principal" }
let(:href) { api_v3_paths.user(user.id) }
let(:title) { user.name }
end
end
- context 'for a group principal' do
+ context "for a group principal" do
let(:principal) { group }
- it_behaves_like 'has a titled link' do
- let(:link) { 'principal' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "principal" }
let(:href) { api_v3_paths.group(group.id) }
let(:title) { group.name }
end
end
end
- describe 'roles' do
- it_behaves_like 'has a link collection' do
- let(:link) { 'roles' }
+ describe "roles" do
+ it_behaves_like "has a link collection" do
+ let(:link) { "roles" }
# excludes member_roles marked for destruction
# and duplicates
let(:hrefs) do
@@ -139,38 +139,38 @@
end
end
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'Share' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "Share" }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { member.id }
end
- describe 'createdAt' do
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ describe "createdAt" do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { member.created_at }
- let(:json_path) { 'createdAt' }
+ let(:json_path) { "createdAt" }
end
end
- describe 'updatedAt' do
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ describe "updatedAt" do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { member.updated_at }
- let(:json_path) { 'updatedAt' }
+ let(:json_path) { "updatedAt" }
end
end
end
- describe '_embedded' do
- describe 'entity' do
- let(:embedded_path) { '_embedded/entity' }
+ describe "_embedded" do
+ describe "entity" do
+ let(:embedded_path) { "_embedded/entity" }
- context 'for a work package' do
- it 'has the work package embedded' do
+ context "for a work package" do
+ it "has the work package embedded" do
expect(subject)
- .to be_json_eql('WorkPackage'.to_json)
+ .to be_json_eql("WorkPackage".to_json)
.at_path("#{embedded_path}/_type")
expect(subject)
@@ -184,12 +184,12 @@
end
end
- describe 'project' do
- let(:embedded_path) { '_embedded/project' }
+ describe "project" do
+ let(:embedded_path) { "_embedded/project" }
- it 'has the project embedded' do
+ it "has the project embedded" do
expect(subject)
- .to be_json_eql('Project'.to_json)
+ .to be_json_eql("Project".to_json)
.at_path("#{embedded_path}/_type")
expect(subject)
@@ -198,13 +198,13 @@
end
end
- describe 'principal' do
- let(:embedded_path) { '_embedded/principal' }
+ describe "principal" do
+ let(:embedded_path) { "_embedded/principal" }
- context 'for a user principal' do
- it 'has the user embedded' do
+ context "for a user principal" do
+ it "has the user embedded" do
expect(subject)
- .to be_json_eql('User'.to_json)
+ .to be_json_eql("User".to_json)
.at_path("#{embedded_path}/_type")
expect(subject)
@@ -213,12 +213,12 @@
end
end
- context 'for a group principal' do
+ context "for a group principal" do
let(:principal) { group }
- it 'has the group embedded' do
+ it "has the group embedded" do
expect(subject)
- .to be_json_eql('Group'.to_json)
+ .to be_json_eql("Group".to_json)
.at_path("#{embedded_path}/_type")
expect(subject)
@@ -228,12 +228,12 @@
end
end
- describe 'roles' do
- let(:embedded_path) { '_embedded/roles' }
+ describe "roles" do
+ let(:embedded_path) { "_embedded/roles" }
- it 'has an array of roles embedded that excludes member_roles marked for destruction' do
+ it "has an array of roles embedded that excludes member_roles marked for destruction" do
expect(subject)
- .to be_json_eql('Role'.to_json)
+ .to be_json_eql("Role".to_json)
.at_path("#{embedded_path}/0/_type")
expect(subject)
@@ -241,7 +241,7 @@
.at_path("#{embedded_path}/0/name")
expect(subject)
- .to be_json_eql('Role'.to_json)
+ .to be_json_eql("Role".to_json)
.at_path("#{embedded_path}/1/_type")
expect(subject)
diff --git a/spec/lib/api/v3/statuses/status_collection_representer_spec.rb b/spec/lib/api/v3/statuses/status_collection_representer_spec.rb
index c8e4a38d1083..cd02db3da391 100644
--- a/spec/lib/api/v3/statuses/status_collection_representer_spec.rb
+++ b/spec/lib/api/v3/statuses/status_collection_representer_spec.rb
@@ -26,19 +26,19 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Statuses::StatusCollectionRepresenter do
include API::V3::Utilities::PathHelper
let(:statuses) { build_list(:status, 3) }
let(:representer) do
- described_class.new(statuses, self_link: api_v3_paths.statuses, current_user: double('current_user'))
+ described_class.new(statuses, self_link: api_v3_paths.statuses, current_user: double("current_user"))
end
- context 'generation' do
+ context "generation" do
subject(:collection) { representer.to_json }
- it_behaves_like 'unpaginated APIv3 collection', 3, 'statuses', 'Status'
+ it_behaves_like "unpaginated APIv3 collection", 3, "statuses", "Status"
end
end
diff --git a/spec/lib/api/v3/statuses/status_representer_spec.rb b/spec/lib/api/v3/statuses/status_representer_spec.rb
index 8cb9c70fc7c2..799a822cc116 100644
--- a/spec/lib/api/v3/statuses/status_representer_spec.rb
+++ b/spec/lib/api/v3/statuses/status_representer_spec.rb
@@ -26,54 +26,54 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Statuses::StatusRepresenter do
let(:status) { build_stubbed(:status) }
- let(:representer) { described_class.new(status, current_user: double('current_user')) }
+ let(:representer) { described_class.new(status, current_user: double("current_user")) }
- context 'generation' do
+ context "generation" do
subject(:generated) { representer.to_json }
- it { is_expected.to include_json('Status'.to_json).at_path('_type') }
-
- describe 'status' do
- it { is_expected.to have_json_path('id') }
- it { is_expected.to have_json_path('name') }
- it { is_expected.to have_json_path('isClosed') }
- it { is_expected.to have_json_path('isDefault') }
- it { is_expected.to have_json_path('isReadonly') }
- it { is_expected.to have_json_path('position') }
- it { is_expected.to have_json_path('defaultDoneRatio') }
-
- describe 'values' do
- it { is_expected.to be_json_eql(status.id.to_json).at_path('id') }
- it { is_expected.to be_json_eql(status.name.to_json).at_path('name') }
- it { is_expected.to be_json_eql(status.is_closed.to_json).at_path('isClosed') }
- it { is_expected.to be_json_eql(status.is_default.to_json).at_path('isDefault') }
- it { is_expected.to be_json_eql(status.is_readonly.to_json).at_path('isReadonly') }
- it { is_expected.to be_json_eql(status.position.to_json).at_path('position') }
+ it { is_expected.to include_json("Status".to_json).at_path("_type") }
+
+ describe "status" do
+ it { is_expected.to have_json_path("id") }
+ it { is_expected.to have_json_path("name") }
+ it { is_expected.to have_json_path("isClosed") }
+ it { is_expected.to have_json_path("isDefault") }
+ it { is_expected.to have_json_path("isReadonly") }
+ it { is_expected.to have_json_path("position") }
+ it { is_expected.to have_json_path("defaultDoneRatio") }
+
+ describe "values" do
+ it { is_expected.to be_json_eql(status.id.to_json).at_path("id") }
+ it { is_expected.to be_json_eql(status.name.to_json).at_path("name") }
+ it { is_expected.to be_json_eql(status.is_closed.to_json).at_path("isClosed") }
+ it { is_expected.to be_json_eql(status.is_default.to_json).at_path("isDefault") }
+ it { is_expected.to be_json_eql(status.is_readonly.to_json).at_path("isReadonly") }
+ it { is_expected.to be_json_eql(status.position.to_json).at_path("position") }
it {
- expect(subject).to be_json_eql(status.default_done_ratio.to_json).at_path('defaultDoneRatio')
+ expect(subject).to be_json_eql(status.default_done_ratio.to_json).at_path("defaultDoneRatio")
}
end
end
- describe '_links' do
- it { is_expected.to have_json_type(Object).at_path('_links') }
+ describe "_links" do
+ it { is_expected.to have_json_type(Object).at_path("_links") }
- describe 'self' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "self" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { "/api/v3/statuses/#{status.id}" }
let(:title) { status.name }
end
end
end
- describe 'caching' do
- it 'is based on the representer\'s cache_key' do
+ describe "caching" do
+ it "is based on the representer's cache_key" do
expect(OpenProject::Cache)
.to receive(:fetch)
.with(representer.json_cache_key)
@@ -82,22 +82,22 @@
representer.to_json
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let!(:former_cache_key) { representer.json_cache_key }
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'Statuses', 'StatusRepresenter')
+ .to include("API", "V3", "Statuses", "StatusRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
I18n.with_locale(:fr) do
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
end
- it 'changes when the status is updated' do
+ it "changes when the status is updated" do
status.updated_at = Time.now + 20.seconds
expect(representer.json_cache_key)
diff --git a/spec/lib/api/v3/support/api_v3_collection.rb b/spec/lib/api/v3/support/api_v3_collection.rb
index 8d4ac347148d..cb52fdb9d3c3 100644
--- a/spec/lib/api/v3/support/api_v3_collection.rb
+++ b/spec/lib/api/v3/support/api_v3_collection.rb
@@ -26,96 +26,96 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.shared_examples_for 'generic APIv3 collection' do
- describe '_links' do
- it 'has a self link' do
- expect(collection).to be_json_eql(self_link.to_json).at_path('_links/self/href')
+RSpec.shared_examples_for "generic APIv3 collection" do
+ describe "_links" do
+ it "has a self link" do
+ expect(collection).to be_json_eql(self_link.to_json).at_path("_links/self/href")
end
end
- it 'has a collection type' do
- expected_type = defined?(collection_type) ? collection_type : 'Collection'
- expect(collection).to be_json_eql(expected_type.to_json).at_path('_type')
+ it "has a collection type" do
+ expected_type = defined?(collection_type) ? collection_type : "Collection"
+ expect(collection).to be_json_eql(expected_type.to_json).at_path("_type")
end
- describe 'elements are typed correctly' do
+ describe "elements are typed correctly" do
it do
expect(collection).to be_json_eql(collection_inner_type.to_json)
- .at_path('_embedded/elements/0/_type')
+ .at_path("_embedded/elements/0/_type")
end
end
end
-RSpec.shared_examples_for 'unpaginated APIv3 collection' do |count, self_link, type|
- it_behaves_like 'generic APIv3 collection' do
+RSpec.shared_examples_for "unpaginated APIv3 collection" do |count, self_link, type|
+ it_behaves_like "generic APIv3 collection" do
let(:self_link) { "/api/v3/#{self_link}" }
let(:collection_inner_type) { type }
end
- describe 'quantities' do
- it { expect(collection).to be_json_eql(count.to_json).at_path('total') }
+ describe "quantities" do
+ it { expect(collection).to be_json_eql(count.to_json).at_path("total") }
- it { expect(collection).to be_json_eql(count.to_json).at_path('count') }
+ it { expect(collection).to be_json_eql(count.to_json).at_path("count") }
- it { expect(collection).to have_json_size(count).at_path('_embedded/elements') }
+ it { expect(collection).to have_json_size(count).at_path("_embedded/elements") }
end
end
-RSpec.shared_examples_for 'offset-paginated APIv3 collection' do
+RSpec.shared_examples_for "offset-paginated APIv3 collection" do
def make_link_for(page:, page_size:)
page = ERB::Util::url_encode(page)
page_size = ERB::Util::url_encode(page_size)
"#{self_base_link}?offset=#{page}&pageSize=#{page_size}"
end
- it_behaves_like 'generic APIv3 collection' do
+ it_behaves_like "generic APIv3 collection" do
let(:self_link) { make_link_for(page:, page_size:) }
end
- describe '_links' do
- it_behaves_like 'has a templated link' do
- let(:link) { 'jumpTo' }
- let(:href) { make_link_for(page: '{offset}', page_size:) }
+ describe "_links" do
+ it_behaves_like "has a templated link" do
+ let(:link) { "jumpTo" }
+ let(:href) { make_link_for(page: "{offset}", page_size:) }
end
- it_behaves_like 'has a templated link' do
- let(:link) { 'changeSize' }
- let(:href) { make_link_for(page:, page_size: '{size}') }
+ it_behaves_like "has a templated link" do
+ let(:link) { "changeSize" }
+ let(:href) { make_link_for(page:, page_size: "{size}") }
end
end
- it 'indicates the page number as offset' do
- expect(collection).to be_json_eql(page.to_json).at_path('offset')
+ it "indicates the page number as offset" do
+ expect(collection).to be_json_eql(page.to_json).at_path("offset")
end
- it 'indicates the expected pageSize' do
- expect(collection).to be_json_eql(page_size.to_json).at_path('pageSize')
+ it "indicates the expected pageSize" do
+ expect(collection).to be_json_eql(page_size.to_json).at_path("pageSize")
end
- it 'indicates the total amount of elements (over all pages)' do
- expect(collection).to be_json_eql(total.to_json).at_path('total')
+ it "indicates the total amount of elements (over all pages)" do
+ expect(collection).to be_json_eql(total.to_json).at_path("total")
end
- it 'indicates the number of elements on this page' do
- expect(collection).to be_json_eql(actual_count.to_json).at_path('count')
+ it "indicates the number of elements on this page" do
+ expect(collection).to be_json_eql(actual_count.to_json).at_path("count")
end
- it 'embeds the expected number of elements' do
- expect(collection).to have_json_size(actual_count).at_path('_embedded/elements')
+ it "embeds the expected number of elements" do
+ expect(collection).to have_json_size(actual_count).at_path("_embedded/elements")
end
- shared_examples_for 'links to previous page by offset' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'previousByOffset' }
+ shared_examples_for "links to previous page by offset" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "previousByOffset" }
let(:href) { make_link_for(page: page - 1, page_size:) }
end
end
- shared_examples_for 'links to next page by offset' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'nextByOffset' }
+ shared_examples_for "links to next page by offset" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "nextByOffset" }
let(:href) { make_link_for(page: page + 1, page_size:) }
end
end
diff --git a/spec/lib/api/v3/support/api_v3_digest.rb b/spec/lib/api/v3/support/api_v3_digest.rb
index 7df836c39eef..e79fa8b3c1f0 100644
--- a/spec/lib/api/v3/support/api_v3_digest.rb
+++ b/spec/lib/api/v3/support/api_v3_digest.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.shared_examples_for 'API V3 digest' do
- it 'defines an algorithm' do
+RSpec.shared_examples_for "API V3 digest" do
+ it "defines an algorithm" do
expect(subject).to be_json_eql(algorithm.to_json).at_path("#{path}/algorithm")
end
- it 'has a hash' do
+ it "has a hash" do
expect(subject).to be_json_eql(hash.to_json).at_path("#{path}/hash")
end
end
diff --git a/spec/lib/api/v3/support/api_v3_filter_dependency.rb b/spec/lib/api/v3/support/api_v3_filter_dependency.rb
index df69a4507bc8..d74e6b39722d 100644
--- a/spec/lib/api/v3/support/api_v3_filter_dependency.rb
+++ b/spec/lib/api/v3/support/api_v3_filter_dependency.rb
@@ -26,68 +26,68 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-RSpec.shared_examples_for 'filter dependency' do
- it_behaves_like 'has basic schema properties' do
- let(:name) { 'Values' }
+RSpec.shared_examples_for "filter dependency" do
+ it_behaves_like "has basic schema properties" do
+ let(:name) { "Values" }
let(:required) { true }
let(:writable) { true }
let(:has_default) { false }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
- context 'when embedding' do
+ context "when embedding" do
let(:form_embedded) { true }
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
end
end
-RSpec.shared_examples_for 'filter dependency with allowed link' do
- it_behaves_like 'has basic schema properties' do
- let(:name) { 'Values' }
+RSpec.shared_examples_for "filter dependency with allowed link" do
+ it_behaves_like "has basic schema properties" do
+ let(:name) { "Values" }
let(:required) { true }
let(:writable) { true }
let(:has_default) { false }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
- context 'when embedding' do
+ context "when embedding" do
let(:form_embedded) { true }
- it_behaves_like 'links to allowed values via collection link'
+ it_behaves_like "links to allowed values via collection link"
end
end
-RSpec.shared_examples_for 'filter dependency with allowed value link collection' do
- it_behaves_like 'has basic schema properties' do
- let(:name) { 'Values' }
+RSpec.shared_examples_for "filter dependency with allowed value link collection" do
+ it_behaves_like "has basic schema properties" do
+ let(:name) { "Values" }
let(:required) { true }
let(:writable) { true }
let(:has_default) { false }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
- context 'when embedding' do
+ context "when embedding" do
let(:form_embedded) { true }
- it_behaves_like 'links to allowed values directly'
+ it_behaves_like "links to allowed values directly"
end
end
-RSpec.shared_examples_for 'filter dependency empty' do
- it 'is an empty object' do
+RSpec.shared_examples_for "filter dependency empty" do
+ it "is an empty object" do
expect(subject)
.to be_json_eql({}.to_json)
end
end
-RSpec.shared_examples_for 'relation filter dependency' do
+RSpec.shared_examples_for "relation filter dependency" do
include API::V3::Utilities::PathHelper
let(:project) { build_stubbed(:project) }
@@ -102,49 +102,49 @@
subject(:generated) { instance.to_json }
- context 'generation' do
- context 'properties' do
- describe 'values' do
- context 'within project' do
- let(:path) { 'values' }
- let(:type) { '[]WorkPackage' }
+ context "generation" do
+ context "properties" do
+ describe "values" do
+ context "within project" do
+ let(:path) { "values" }
+ let(:type) { "[]WorkPackage" }
let(:href) { api_v3_paths.work_packages_by_project(project.id) }
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
end
- context 'outside of a project' do
+ context "outside of a project" do
let(:project) { nil }
- let(:path) { 'values' }
- let(:type) { '[]WorkPackage' }
+ let(:path) { "values" }
+ let(:type) { "[]WorkPackage" }
let(:href) { api_v3_paths.work_packages }
context "for operator 'Queries::Operators::Equals'" do
let(:operator) { Queries::Operators::Equals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
context "for operator 'Queries::Operators::NotEquals'" do
let(:operator) { Queries::Operators::NotEquals }
- it_behaves_like 'filter dependency with allowed link'
+ it_behaves_like "filter dependency with allowed link"
end
end
end
end
- describe 'caching' do
+ describe "caching" do
let(:operator) { Queries::Operators::Equals }
let(:other_project) { build_stubbed(:project) }
@@ -153,14 +153,14 @@
instance.to_json
end
- it 'is cached' do
+ it "is cached" do
expect(instance)
.not_to receive(:to_hash)
instance.to_json
end
- it 'busts the cache on a different operator' do
+ it "busts the cache on a different operator" do
instance.send(:operator=, Queries::Operators::NotEquals)
expect(instance)
@@ -169,7 +169,7 @@
instance.to_json
end
- it 'busts the cache on a different project' do
+ it "busts the cache on a different project" do
query.project = other_project
expect(instance)
@@ -178,7 +178,7 @@
instance.to_json
end
- it 'busts the cache on changes to the locale' do
+ it "busts the cache on changes to the locale" do
expect(instance)
.to receive(:to_hash)
@@ -187,7 +187,7 @@
end
end
- it 'busts the cache on different form_embedded' do
+ it "busts the cache on different form_embedded" do
embedded_instance = described_class.new(filter,
operator,
form_embedded: !form_embedded)
diff --git a/spec/lib/api/v3/support/api_v3_formattable.rb b/spec/lib/api/v3/support/api_v3_formattable.rb
index 05edf52cd12a..c27f490f5770 100644
--- a/spec/lib/api/v3/support/api_v3_formattable.rb
+++ b/spec/lib/api/v3/support/api_v3_formattable.rb
@@ -26,20 +26,20 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.shared_examples_for 'API V3 formattable' do |property|
+RSpec.shared_examples_for "API V3 formattable" do |property|
it { is_expected.to have_json_path(property) }
- it { is_expected.to be_json_eql(format.to_json).at_path(property + '/format') }
+ it { is_expected.to be_json_eql(format.to_json).at_path(property + "/format") }
- it_behaves_like 'formattable property', property do
+ it_behaves_like "formattable property", property do
let(:value) { raw }
end
it do
if defined?(html)
- expect(subject).to be_json_eql(html.to_json).at_path(property + '/html')
+ expect(subject).to be_json_eql(html.to_json).at_path(property + "/html")
end
end
end
diff --git a/spec/lib/api/v3/support/collection_examples.rb b/spec/lib/api/v3/support/collection_examples.rb
index a57f98ee39e8..0d632e2f3b6b 100644
--- a/spec/lib/api/v3/support/collection_examples.rb
+++ b/spec/lib/api/v3/support/collection_examples.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-RSpec.shared_examples_for 'collection' do |name|
+RSpec.shared_examples_for "collection" do |name|
it "has the #{name} property" do
represented_elements = value.map { |v| element_decorator.call(v) }
diff --git a/spec/lib/api/v3/support/date_time_examples.rb b/spec/lib/api/v3/support/date_time_examples.rb
index 79a0516fab76..ece25fd3770d 100644
--- a/spec/lib/api/v3/support/date_time_examples.rb
+++ b/spec/lib/api/v3/support/date_time_examples.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.shared_examples_for 'has ISO 8601 date only' do
- it 'exists' do
+RSpec.shared_examples_for "has ISO 8601 date only" do
+ it "exists" do
expect(subject).to have_json_path(json_path)
end
- it 'indicates date only as ISO 8601' do
+ it "indicates date only as ISO 8601" do
allow(API::V3::Utilities::DateTimeFormatter).to receive(:format_date)
subject
@@ -45,12 +45,12 @@
end
end
-RSpec.shared_examples_for 'has UTC ISO 8601 date and time' do
- it 'exists' do
+RSpec.shared_examples_for "has UTC ISO 8601 date and time" do
+ it "exists" do
expect(subject).to have_json_path(json_path)
end
- it 'indicates date and time as ISO 8601' do
+ it "indicates date and time as ISO 8601" do
allow(API::V3::Utilities::DateTimeFormatter).to receive(:format_datetime)
subject
diff --git a/spec/lib/api/v3/support/link_examples.rb b/spec/lib/api/v3/support/link_examples.rb
index f085aaed860e..be3c6b5f442f 100644
--- a/spec/lib/api/v3/support/link_examples.rb
+++ b/spec/lib/api/v3/support/link_examples.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.shared_context 'action link shared' do
+RSpec.shared_context "action link shared" do
let(:all_permissions) { OpenProject::AccessControl.permissions.map(&:name) }
let(:permissions) { all_permissions }
let(:action_link_user) do
@@ -47,7 +47,7 @@
end
end
- it 'indicates the desired method' do
+ it "indicates the desired method" do
verb = begin
# the standard method #method on an object interferes
# with the let named 'method' conditionally defined
@@ -66,60 +66,60 @@
end
end
- describe 'without permission' do
+ describe "without permission" do
let(:permissions) { all_permissions - Array(permission) }
- it_behaves_like 'has no link'
+ it_behaves_like "has no link"
end
end
-RSpec.shared_examples_for 'has an untitled action link' do
- include_context 'action link shared'
+RSpec.shared_examples_for "has an untitled action link" do
+ include_context "action link shared"
- it_behaves_like 'has an untitled link'
+ it_behaves_like "has an untitled link"
end
-RSpec.shared_examples_for 'has a titled action link' do
- include_context 'action link shared'
+RSpec.shared_examples_for "has a titled action link" do
+ include_context "action link shared"
- it_behaves_like 'has a titled link'
+ it_behaves_like "has a titled link"
end
-RSpec.shared_examples_for 'has a titled link' do
+RSpec.shared_examples_for "has a titled link" do
it { is_expected.to be_json_eql(href.to_json).at_path("_links/#{link}/href") }
it { is_expected.to be_json_eql(title.to_json).at_path("_links/#{link}/title") }
end
-RSpec.shared_examples_for 'has an untitled link' do
+RSpec.shared_examples_for "has an untitled link" do
it { is_expected.to be_json_eql(href.to_json).at_path("_links/#{link}/href") }
it { is_expected.not_to have_json_path("_links/#{link}/title") }
end
-RSpec.shared_examples_for 'has a templated link' do
+RSpec.shared_examples_for "has a templated link" do
it { is_expected.to be_json_eql(href.to_json).at_path("_links/#{link}/href") }
it { is_expected.to be_json_eql(true.to_json).at_path("_links/#{link}/templated") }
end
-RSpec.shared_examples_for 'has an empty link' do
+RSpec.shared_examples_for "has an empty link" do
it { is_expected.to be_json_eql(nil.to_json).at_path("_links/#{link}/href") }
- it 'has no embedded resource' do
+ it "has no embedded resource" do
expect(subject).not_to have_json_path("_embedded/#{link}")
end
end
-RSpec.shared_examples_for 'has an empty link collection' do
+RSpec.shared_examples_for "has an empty link collection" do
it { is_expected.to be_json_eql([].to_json).at_path("_links/#{link}") }
end
-RSpec.shared_examples_for 'has a link collection' do
+RSpec.shared_examples_for "has a link collection" do
it { is_expected.to be_json_eql(hrefs.to_json).at_path("_links/#{link}") }
end
-RSpec.shared_examples_for 'has no link' do
+RSpec.shared_examples_for "has no link" do
it { is_expected.not_to have_json_path("_links/#{link}") }
- it 'has no embedded resource' do
+ it "has no embedded resource" do
expect(subject).not_to have_json_path("_embedded/#{link}")
end
end
diff --git a/spec/lib/api/v3/support/property_examples.rb b/spec/lib/api/v3/support/property_examples.rb
index 3eb25d14e53e..4854832d89e7 100644
--- a/spec/lib/api/v3/support/property_examples.rb
+++ b/spec/lib/api/v3/support/property_examples.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-RSpec.shared_examples_for 'property' do |name|
+RSpec.shared_examples_for "property" do |name|
it "has the #{name} property" do
expect(subject)
.to be_json_eql(value.to_json)
@@ -34,13 +34,13 @@
end
end
-RSpec.shared_examples_for 'no property' do |name|
+RSpec.shared_examples_for "no property" do |name|
it "does not have the #{name} property" do
expect(subject).not_to have_json_path(name.to_s)
end
end
-RSpec.shared_examples_for 'formattable property' do |name|
+RSpec.shared_examples_for "formattable property" do |name|
it "has the #{name} property" do
expect(subject)
.to be_json_eql(value.to_s.to_json)
@@ -48,15 +48,15 @@
end
end
-RSpec.shared_examples_for 'date property' do |name|
- it_behaves_like 'has ISO 8601 date only' do
+RSpec.shared_examples_for "date property" do |name|
+ it_behaves_like "has ISO 8601 date only" do
let(:json_path) { name.to_s }
let(:date) { value }
end
end
-RSpec.shared_examples_for 'datetime property' do |name|
- it_behaves_like 'has UTC ISO 8601 date and time' do
+RSpec.shared_examples_for "datetime property" do |name|
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:json_path) { name.to_s }
let(:date) { value }
end
diff --git a/spec/lib/api/v3/support/schema_examples.rb b/spec/lib/api/v3/support/schema_examples.rb
index 118f26879617..b6e34a1bba80 100644
--- a/spec/lib/api/v3/support/schema_examples.rb
+++ b/spec/lib/api/v3/support/schema_examples.rb
@@ -26,30 +26,30 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.shared_examples_for 'has basic schema properties' do
- it 'exists' do
+RSpec.shared_examples_for "has basic schema properties" do
+ it "exists" do
expect(subject).to have_json_path(path)
end
- it 'has a type' do
+ it "has a type" do
expect(subject).to be_json_eql(type.to_json).at_path("#{path}/type")
end
- it 'has a name' do
+ it "has a name" do
expect(subject).to be_json_eql(name.to_json).at_path("#{path}/name")
end
- it 'indicates if it is required' do
+ it "indicates if it is required" do
expect(subject).to be_json_eql(required.to_json).at_path("#{path}/required")
end
- it 'indicates if it is writable' do
+ it "indicates if it is writable" do
expect(subject).to be_json_eql(writable.to_json).at_path("#{path}/writable")
end
- it 'indicates if it has default' do
+ it "indicates if it has default" do
expected_has_default = if defined?(has_default)
has_default
else
@@ -61,7 +61,7 @@
.at_path("#{path}/hasDefault")
end
- it 'indicates if it has a location' do
+ it "indicates if it has a location" do
if defined?(location)
expect(subject)
.to be_json_eql(location.to_json)
@@ -71,7 +71,7 @@
end
end
- it 'indicates if it has a description' do
+ it "indicates if it has a description" do
if defined?(description)
expect(subject)
.to be_json_eql(description.to_json)
@@ -82,8 +82,8 @@
end
end
-RSpec.shared_examples_for 'indicates length requirements' do
- it 'indicates its minimum length' do
+RSpec.shared_examples_for "indicates length requirements" do
+ it "indicates its minimum length" do
if defined?(min_length)
expect(subject)
.to be_json_eql(min_length.to_json)
@@ -94,7 +94,7 @@
end
end
- it 'indicates its maximum length' do
+ it "indicates its maximum length" do
if defined?(max_length)
expect(subject)
.to be_json_eql(max_length.to_json)
@@ -106,12 +106,12 @@
end
end
-RSpec.shared_examples_for 'links to allowed values directly' do
- it 'has the expected number of links' do
+RSpec.shared_examples_for "links to allowed values directly" do
+ it "has the expected number of links" do
expect(subject).to have_json_size(hrefs.size).at_path("#{path}/_links/allowedValues")
end
- it 'contains links to the allowed values' do
+ it "contains links to the allowed values" do
index = 0
hrefs.each do |href|
href_path = "#{path}/_links/allowedValues/#{index}/href"
@@ -121,14 +121,14 @@
end
end
-RSpec.shared_examples_for 'links to and embeds allowed values directly' do
- it_behaves_like 'links to allowed values directly'
+RSpec.shared_examples_for "links to and embeds allowed values directly" do
+ it_behaves_like "links to allowed values directly"
- it 'has the expected number of embedded values' do
+ it "has the expected number of embedded values" do
expect(subject).to have_json_size(hrefs.size).at_path("#{path}/_embedded/allowedValues")
end
- it 'embeds the allowed values' do
+ it "embeds the allowed values" do
index = 0
hrefs.each do |href|
href_path = "#{path}/_embedded/allowedValues/#{index}/_links/self/href"
@@ -138,18 +138,18 @@
end
end
-RSpec.shared_examples_for 'links to allowed values via collection link' do
- it 'contains the link to the allowed values' do
+RSpec.shared_examples_for "links to allowed values via collection link" do
+ it "contains the link to the allowed values" do
expect(subject).to be_json_eql(href.to_json).at_path("#{path}/_links/allowedValues/href")
end
end
-RSpec.shared_examples_for 'does not link to allowed values' do
- it 'contains no link to the allowed values' do
+RSpec.shared_examples_for "does not link to allowed values" do
+ it "contains no link to the allowed values" do
expect(subject).not_to have_json_path("#{path}/_links/allowedValues")
end
- it 'does not embed allowed values' do
+ it "does not embed allowed values" do
expect(subject).not_to have_json_path("#{path}/_embedded/allowedValues")
end
end
diff --git a/spec/lib/api/v3/types/type_representer_spec.rb b/spec/lib/api/v3/types/type_representer_spec.rb
index d0f81073a330..99fdc3c9e4d8 100644
--- a/spec/lib/api/v3/types/type_representer_spec.rb
+++ b/spec/lib/api/v3/types/type_representer_spec.rb
@@ -26,85 +26,85 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Types::TypeRepresenter do
let(:type) { build_stubbed(:type, color: build_stubbed(:color)) }
- let(:representer) { described_class.new(type, current_user: double('current_user')) }
+ let(:representer) { described_class.new(type, current_user: double("current_user")) }
include API::V3::Utilities::PathHelper
- context 'generation' do
+ context "generation" do
subject { representer.to_json }
- describe 'links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.type(type.id) }
let(:title) { type.name }
end
end
- it 'indicates its id' do
- expect(subject).to be_json_eql(type.id.to_json).at_path('id')
+ it "indicates its id" do
+ expect(subject).to be_json_eql(type.id.to_json).at_path("id")
end
- it 'indicates its name' do
- expect(subject).to be_json_eql(type.name.to_json).at_path('name')
+ it "indicates its name" do
+ expect(subject).to be_json_eql(type.name.to_json).at_path("name")
end
- it 'indicates its color' do
- expect(subject).to be_json_eql(type.color.hexcode.to_json).at_path('color')
+ it "indicates its color" do
+ expect(subject).to be_json_eql(type.color.hexcode.to_json).at_path("color")
end
- context 'no color set' do
+ context "no color set" do
let(:type) { build_stubbed(:type, color: nil) }
- it 'indicates a missing color' do
- expect(subject).to be_json_eql(nil.to_json).at_path('color')
+ it "indicates a missing color" do
+ expect(subject).to be_json_eql(nil.to_json).at_path("color")
end
end
- it 'indicates its position' do
- expect(subject).to be_json_eql(type.position.to_json).at_path('position')
+ it "indicates its position" do
+ expect(subject).to be_json_eql(type.position.to_json).at_path("position")
end
- it 'indicates that it is not the default type' do
- expect(subject).to be_json_eql(false.to_json).at_path('isDefault')
+ it "indicates that it is not the default type" do
+ expect(subject).to be_json_eql(false.to_json).at_path("isDefault")
end
- context 'as default type' do
+ context "as default type" do
let(:type) { build_stubbed(:type, is_default: true) }
- it 'indicates that it is the default type' do
- expect(subject).to be_json_eql(true.to_json).at_path('isDefault')
+ it "indicates that it is the default type" do
+ expect(subject).to be_json_eql(true.to_json).at_path("isDefault")
end
end
- it 'indicates that it is not a milestone' do
- expect(subject).to be_json_eql(false.to_json).at_path('isMilestone')
+ it "indicates that it is not a milestone" do
+ expect(subject).to be_json_eql(false.to_json).at_path("isMilestone")
end
- context 'as milestone' do
+ context "as milestone" do
let(:type) { build_stubbed(:type, is_milestone: true) }
- it 'indicates that it is a milestone' do
- expect(subject).to be_json_eql(true.to_json).at_path('isMilestone')
+ it "indicates that it is a milestone" do
+ expect(subject).to be_json_eql(true.to_json).at_path("isMilestone")
end
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { type.created_at }
- let(:json_path) { 'createdAt' }
+ let(:json_path) { "createdAt" }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { type.updated_at }
- let(:json_path) { 'updatedAt' }
+ let(:json_path) { "updatedAt" }
end
- describe 'caching' do
- it 'is based on the representer\'s cache_key' do
+ describe "caching" do
+ it "is based on the representer's cache_key" do
expect(OpenProject::Cache)
.to receive(:fetch)
.with(representer.json_cache_key)
@@ -113,22 +113,22 @@
representer.to_json
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let!(:former_cache_key) { representer.json_cache_key }
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'Types', 'TypeRepresenter')
+ .to include("API", "V3", "Types", "TypeRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
I18n.with_locale(:fr) do
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
end
- it 'changes when the type is updated' do
+ it "changes when the type is updated" do
type.updated_at = Time.now + 20.seconds
expect(representer.json_cache_key)
diff --git a/spec/lib/api/v3/user_preferences/notification_setting_representer_rendering_spec.rb b/spec/lib/api/v3/user_preferences/notification_setting_representer_rendering_spec.rb
index f8f8c5f025f8..ead492a84976 100644
--- a/spec/lib/api/v3/user_preferences/notification_setting_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/user_preferences/notification_setting_representer_rendering_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::UserPreferences::NotificationSettingRepresenter, 'rendering' do
+RSpec.describe API::V3::UserPreferences::NotificationSettingRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
subject(:generated) { representer.to_json }
@@ -46,73 +46,73 @@
current_user { build_stubbed(:user) }
- describe '_links' do
- describe 'self' do
+ describe "_links" do
+ describe "self" do
# No self link as the representer is rendered as part of the user preferences.
- it_behaves_like 'has no link' do
- let(:link) { 'self' }
+ it_behaves_like "has no link" do
+ let(:link) { "self" }
end
end
- describe 'project' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'project' }
+ describe "project" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "project" }
let(:href) { api_v3_paths.project(project.id) }
let(:title) { project.name }
end
end
end
- describe 'properties' do
- it 'has no _type' do
+ describe "properties" do
+ it "has no _type" do
expect(generated)
- .not_to have_json_path('_type')
+ .not_to have_json_path("_type")
end
(NotificationSetting.all_settings - NotificationSetting.date_alert_settings).each do |property|
- it_behaves_like 'property', property.to_s.camelize(:lower) do
+ it_behaves_like "property", property.to_s.camelize(:lower) do
let(:value) do
notification_setting.send property
end
end
end
- context 'without enterprise' do
- it 'does not have the date alert settings in the resulting json' do
+ context "without enterprise" do
+ it "does not have the date alert settings in the resulting json" do
expect(subject).not_to have_json_path("startDate")
expect(subject).not_to have_json_path("dueDate")
expect(subject).not_to have_json_path("overdue")
end
end
- context 'with enterprise', with_ee: %i[date_alerts] do
- it_behaves_like 'property', :startDate do
- let(:value) { 'P1D' }
+ context "with enterprise", with_ee: %i[date_alerts] do
+ it_behaves_like "property", :startDate do
+ let(:value) { "P1D" }
end
- it_behaves_like 'property', :dueDate do
- let(:value) { 'P1D' }
+ it_behaves_like "property", :dueDate do
+ let(:value) { "P1D" }
end
- it_behaves_like 'property', :overdue do
- let(:value) { 'P3D' }
+ it_behaves_like "property", :overdue do
+ let(:value) { "P3D" }
end
end
end
- describe '_embedded' do
- describe 'project' do
- it 'skips embedding the project' do
+ describe "_embedded" do
+ describe "project" do
+ it "skips embedding the project" do
expect(generated)
- .not_to have_json_path('_embedded/project')
+ .not_to have_json_path("_embedded/project")
end
end
end
- context 'when duration settings are all nil' do
+ context "when duration settings are all nil" do
let(:notification_setting) do
build_stubbed(:notification_setting, project:, start_date: nil, due_date: nil, overdue: nil)
end
- it 'does not represent them in the resulting json' do
+ it "does not represent them in the resulting json" do
expect(subject).not_to have_json_path("startDate")
expect(subject).not_to have_json_path("dueDate")
expect(subject).not_to have_json_path("overdue")
diff --git a/spec/lib/api/v3/user_preferences/user_preference_representer_parsing_spec.rb b/spec/lib/api/v3/user_preferences/user_preference_representer_parsing_spec.rb
index 5ce1548920c7..71c7f25ab223 100644
--- a/spec/lib/api/v3/user_preferences/user_preference_representer_parsing_spec.rb
+++ b/spec/lib/api/v3/user_preferences/user_preference_representer_parsing_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::UserPreferences::UserPreferenceRepresenter,
- 'parsing' do
+ "parsing" do
subject(:parsed) { representer.from_hash request_body }
include API::V3::Utilities::PathHelper
@@ -38,26 +38,26 @@
let(:user) { build_stubbed(:user) }
let(:representer) { described_class.new(preference, current_user: user) }
- describe 'notification_settings' do
+ describe "notification_settings" do
let(:request_body) do
{
- 'notifications' => [
+ "notifications" => [
{
- 'assignee' => true,
- 'responsible' => true,
- '_links' => {
- 'project' => {
- 'href' => '/api/v3/projects/1'
+ "assignee" => true,
+ "responsible" => true,
+ "_links" => {
+ "project" => {
+ "href" => "/api/v3/projects/1"
}
}
},
{
- 'assignee' => false,
- 'responsible' => false,
- 'mentioned' => true,
- '_links' => {
- 'project' => {
- 'href' => nil
+ "assignee" => false,
+ "responsible" => false,
+ "mentioned" => true,
+ "_links" => {
+ "project" => {
+ "href" => nil
}
}
}
@@ -65,7 +65,7 @@
}
end
- it 'parses them into an array of structs' do
+ it "parses them into an array of structs" do
expect(subject.notification_settings).to be_a Array
expect(subject.notification_settings.length).to eq 2
in_project, global = subject.notification_settings
@@ -82,7 +82,7 @@
end
end
- describe 'daily_reminders' do
+ describe "daily_reminders" do
let(:request_body) do
{
"dailyReminders" => {
@@ -92,7 +92,7 @@
}
end
- it 'parses the times into full iso8601 time format' do
+ it "parses the times into full iso8601 time format" do
expect(parsed.daily_reminders)
.to eql({
"enabled" => true,
@@ -101,7 +101,7 @@
end
end
- describe 'pause_reminders' do
+ describe "pause_reminders" do
let(:request_body) do
{
"pauseReminders" => {
@@ -112,11 +112,11 @@
}
end
- context 'with all set' do
- let(:first_day) { '2021-10-10' }
- let(:last_day) { '2021-10-20' }
+ context "with all set" do
+ let(:first_day) { "2021-10-10" }
+ let(:last_day) { "2021-10-20" }
- it 'sets both dates' do
+ it "sets both dates" do
expect(parsed.pause_reminders)
.to eql({
"enabled" => true,
@@ -126,11 +126,11 @@
end
end
- context 'with first only set' do
- let(:first_day) { '2021-10-10' }
+ context "with first only set" do
+ let(:first_day) { "2021-10-10" }
let(:last_day) { nil }
- it 'uses the first day for the last day' do
+ it "uses the first day for the last day" do
expect(parsed.pause_reminders)
.to eql({
"enabled" => true,
@@ -140,11 +140,11 @@
end
end
- context 'with last only set' do
+ context "with last only set" do
let(:first_day) { nil }
- let(:last_day) { '2021-10-10' }
+ let(:last_day) { "2021-10-10" }
- it 'uses the first day for the last day' do
+ it "uses the first day for the last day" do
expect(parsed.pause_reminders)
.to eql({
"enabled" => true,
diff --git a/spec/lib/api/v3/user_preferences/user_preference_representer_rendering_spec.rb b/spec/lib/api/v3/user_preferences/user_preference_representer_rendering_spec.rb
index b92a087eb6bc..ce1c2c9e9af0 100644
--- a/spec/lib/api/v3/user_preferences/user_preference_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/user_preferences/user_preference_representer_rendering_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::UserPreferences::UserPreferenceRepresenter,
- 'rendering' do
+ "rendering" do
include API::V3::Utilities::PathHelper
let(:preference) do
@@ -52,34 +52,34 @@
subject(:generated) { representer.to_json }
- it { expect(subject).to have_json_path('hideMail') }
- it { expect(subject).to have_json_path('timeZone') }
- it { expect(subject).to have_json_path('commentSortDescending') }
- it { expect(subject).to have_json_path('warnOnLeavingUnsaved') }
- it { expect(subject).to have_json_path('autoHidePopups') }
+ it { expect(subject).to have_json_path("hideMail") }
+ it { expect(subject).to have_json_path("timeZone") }
+ it { expect(subject).to have_json_path("commentSortDescending") }
+ it { expect(subject).to have_json_path("warnOnLeavingUnsaved") }
+ it { expect(subject).to have_json_path("autoHidePopups") }
- describe 'timeZone' do
- context 'without a timezone set' do
- let(:preference) { build(:user_preference, time_zone: '') }
+ describe "timeZone" do
+ context "without a timezone set" do
+ let(:preference) { build(:user_preference, time_zone: "") }
- it 'shows the timeZone as nil' do
- expect(subject).to be_json_eql(nil.to_json).at_path('timeZone')
+ it "shows the timeZone as nil" do
+ expect(subject).to be_json_eql(nil.to_json).at_path("timeZone")
end
end
- context 'with a timezone set' do
- let(:preference) { build(:user_preference, time_zone: 'Europe/Paris') }
+ context "with a timezone set" do
+ let(:preference) { build(:user_preference, time_zone: "Europe/Paris") }
- it 'shows the canonical time zone' do
- expect(subject).to be_json_eql('Europe/Paris'.to_json).at_path('timeZone')
+ it "shows the canonical time zone" do
+ expect(subject).to be_json_eql("Europe/Paris".to_json).at_path("timeZone")
end
end
end
- describe 'notification_settings', with_ee: %i[date_alerts] do
- it 'renders them as a nested array' do
- expect(subject).to have_json_type(Array).at_path('notifications')
- expect(subject).to be_json_eql(nil.to_json).at_path('notifications/0/_links/project/href')
+ describe "notification_settings", with_ee: %i[date_alerts] do
+ it "renders them as a nested array" do
+ expect(subject).to have_json_type(Array).at_path("notifications")
+ expect(subject).to be_json_eql(nil.to_json).at_path("notifications/0/_links/project/href")
date_keys = [NotificationSetting::START_DATE, NotificationSetting::DUE_DATE, NotificationSetting::OVERDUE]
NotificationSetting.all_settings.each do |key|
@@ -95,15 +95,15 @@
end
end
- describe 'properties' do
- describe '_type' do
- it_behaves_like 'property', :_type do
- let(:value) { 'UserPreferences' }
+ describe "properties" do
+ describe "_type" do
+ it_behaves_like "property", :_type do
+ let(:value) { "UserPreferences" }
end
end
- describe 'dailyReminders' do
- it_behaves_like 'property', :dailyReminders do
+ describe "dailyReminders" do
+ it_behaves_like "property", :dailyReminders do
let(:value) do
{
"enabled" => true,
@@ -114,26 +114,26 @@
end
end
- describe '_links' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.user_preferences(user.id) }
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'user' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "user" }
let(:title) { user.name }
let(:href) { api_v3_paths.user(user.id) }
end
- describe 'immediate update' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'updateImmediately' }
+ describe "immediate update" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "updateImmediately" }
let(:href) { api_v3_paths.user_preferences(user.id) }
end
- it 'is a patch link' do
- expect(subject).to be_json_eql('patch'.to_json).at_path('_links/updateImmediately/method')
+ it "is a patch link" do
+ expect(subject).to be_json_eql("patch".to_json).at_path("_links/updateImmediately/method")
end
end
end
diff --git a/spec/lib/api/v3/users/unpaginated_user_collection_representer_spec.rb b/spec/lib/api/v3/users/unpaginated_user_collection_representer_spec.rb
index f38e086f3e62..bb71a3540d4f 100644
--- a/spec/lib/api/v3/users/unpaginated_user_collection_representer_spec.rb
+++ b/spec/lib/api/v3/users/unpaginated_user_collection_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Users::UnpaginatedUserCollectionRepresenter do
let(:users) do
@@ -35,13 +35,13 @@
end
let(:representer) do
described_class.new(users,
- self_link: '/api/v3/work_package/1/watchers',
+ self_link: "/api/v3/work_package/1/watchers",
current_user: users.first)
end
- context 'generation' do
+ context "generation" do
subject(:collection) { representer.to_json }
- it_behaves_like 'unpaginated APIv3 collection', 3, 'work_package/1/watchers', 'User'
+ it_behaves_like "unpaginated APIv3 collection", 3, "work_package/1/watchers", "User"
end
end
diff --git a/spec/lib/api/v3/users/user_collection_representer_spec.rb b/spec/lib/api/v3/users/user_collection_representer_spec.rb
index 44b9655e97b6..0595c98cfc3b 100644
--- a/spec/lib/api/v3/users/user_collection_representer_spec.rb
+++ b/spec/lib/api/v3/users/user_collection_representer_spec.rb
@@ -26,11 +26,11 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Users::UserCollectionRepresenter do
- let(:self_base_link) { '/api/v3/users' }
- let(:collection_inner_type) { 'User' }
+ let(:self_base_link) { "/api/v3/users" }
+ let(:collection_inner_type) { "User" }
let(:total) { 3 }
let(:page) { 1 }
let(:page_size) { 2 }
@@ -58,15 +58,15 @@
let(:representer) do
described_class.new(users,
- self_link: '/api/v3/users',
+ self_link: "/api/v3/users",
per_page: page_size,
page:,
current_user: users.first)
end
- context 'generation' do
+ context "generation" do
subject(:collection) { representer.to_json }
- it_behaves_like 'offset-paginated APIv3 collection'
+ it_behaves_like "offset-paginated APIv3 collection"
end
end
diff --git a/spec/lib/api/v3/users/user_representer_spec.rb b/spec/lib/api/v3/users/user_representer_spec.rb
index fe12cac792ad..76344665c759 100644
--- a/spec/lib/api/v3/users/user_representer_spec.rb
+++ b/spec/lib/api/v3/users/user_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Users::UserRepresenter do
let(:status) { Principal.statuses[:active] }
@@ -36,202 +36,202 @@
include API::V3::Utilities::PathHelper
- describe 'generation' do
+ describe "generation" do
subject(:generated) { representer.to_json }
it do
- expect(subject).to include_json('User'.to_json).at_path('_type')
+ expect(subject).to include_json("User".to_json).at_path("_type")
end
- context 'as regular user' do
- it 'hides as much information as possible' do
- expect(subject).to have_json_path('id')
- expect(subject).to have_json_path('name')
-
- expect(subject).not_to have_json_path('login')
- expect(subject).not_to have_json_path('firstName')
- expect(subject).not_to have_json_path('lastName')
- expect(subject).not_to have_json_path('admin')
- expect(subject).not_to have_json_path('updatedAt')
- expect(subject).not_to have_json_path('createdAt')
- expect(subject).not_to have_json_path('status')
- expect(subject).not_to have_json_path('email')
- expect(subject).not_to have_json_path('language')
+ context "as regular user" do
+ it "hides as much information as possible" do
+ expect(subject).to have_json_path("id")
+ expect(subject).to have_json_path("name")
+
+ expect(subject).not_to have_json_path("login")
+ expect(subject).not_to have_json_path("firstName")
+ expect(subject).not_to have_json_path("lastName")
+ expect(subject).not_to have_json_path("admin")
+ expect(subject).not_to have_json_path("updatedAt")
+ expect(subject).not_to have_json_path("createdAt")
+ expect(subject).not_to have_json_path("status")
+ expect(subject).not_to have_json_path("email")
+ expect(subject).not_to have_json_path("language")
end
end
- context 'as the represented user' do
+ context "as the represented user" do
let(:current_user) { user }
- it 'shows the information of the user' do
- expect(subject).to have_json_path('id')
- expect(subject).to have_json_path('name')
- expect(subject).to have_json_path('login')
- expect(subject).to have_json_path('firstName')
- expect(subject).to have_json_path('lastName')
- expect(subject).to have_json_path('updatedAt')
- expect(subject).to have_json_path('createdAt')
- expect(subject).to have_json_path('status')
- expect(subject).to have_json_path('email')
- expect(subject).to have_json_path('language')
-
- expect(subject).not_to have_json_path('admin')
+ it "shows the information of the user" do
+ expect(subject).to have_json_path("id")
+ expect(subject).to have_json_path("name")
+ expect(subject).to have_json_path("login")
+ expect(subject).to have_json_path("firstName")
+ expect(subject).to have_json_path("lastName")
+ expect(subject).to have_json_path("updatedAt")
+ expect(subject).to have_json_path("createdAt")
+ expect(subject).to have_json_path("status")
+ expect(subject).to have_json_path("email")
+ expect(subject).to have_json_path("language")
+
+ expect(subject).not_to have_json_path("admin")
end
end
- context 'as admin' do
+ context "as admin" do
let(:current_user) { build_stubbed(:admin) }
- it 'shows everything' do
- expect(subject).to have_json_path('id')
- expect(subject).to have_json_path('login')
- expect(subject).to have_json_path('firstName')
- expect(subject).to have_json_path('lastName')
- expect(subject).to have_json_path('name')
- expect(subject).to have_json_path('status')
- expect(subject).to have_json_path('email')
- expect(subject).to have_json_path('admin')
- expect(subject).to have_json_path('language')
+ it "shows everything" do
+ expect(subject).to have_json_path("id")
+ expect(subject).to have_json_path("login")
+ expect(subject).to have_json_path("firstName")
+ expect(subject).to have_json_path("lastName")
+ expect(subject).to have_json_path("name")
+ expect(subject).to have_json_path("status")
+ expect(subject).to have_json_path("email")
+ expect(subject).to have_json_path("admin")
+ expect(subject).to have_json_path("language")
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { user.created_at }
- let(:json_path) { 'createdAt' }
+ let(:json_path) { "createdAt" }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { user.updated_at }
- let(:json_path) { 'updatedAt' }
+ let(:json_path) { "updatedAt" }
end
end
- describe 'email' do
+ describe "email" do
let(:user) { build_stubbed(:user, status: 1, preference:) }
- shared_examples_for 'shows the users E-Mail address' do
+ shared_examples_for "shows the users E-Mail address" do
it do
- expect(subject).to be_json_eql(user.mail.to_json).at_path('email')
+ expect(subject).to be_json_eql(user.mail.to_json).at_path("email")
end
end
- context 'if user shows his E-Mail address' do
+ context "if user shows his E-Mail address" do
let(:preference) { build(:user_preference, hide_mail: false) }
- it_behaves_like 'shows the users E-Mail address'
+ it_behaves_like "shows the users E-Mail address"
end
- context 'if user hides his E-Mail address' do
+ context "if user hides his E-Mail address" do
let(:preference) { build(:user_preference, hide_mail: true) }
- it 'does not render the users E-Mail address' do
+ it "does not render the users E-Mail address" do
expect(subject)
- .not_to have_json_path('email')
+ .not_to have_json_path("email")
end
- context 'if an admin inquires' do
+ context "if an admin inquires" do
let(:current_user) { build_stubbed(:admin) }
- it_behaves_like 'shows the users E-Mail address'
+ it_behaves_like "shows the users E-Mail address"
end
- context 'if the user inquires himself' do
+ context "if the user inquires himself" do
let(:current_user) { user }
- it_behaves_like 'shows the users E-Mail address'
+ it_behaves_like "shows the users E-Mail address"
end
end
end
- describe 'status' do
+ describe "status" do
# as only admin or self can see the status
let(:current_user) { user }
- it 'contains the name of the account status' do
- expect(subject).to be_json_eql('active'.to_json).at_path('status')
+ it "contains the name of the account status" do
+ expect(subject).to be_json_eql("active".to_json).at_path("status")
end
end
- describe '_links' do
- it 'links to self' do
- expect(subject).to have_json_path('_links/self/href')
+ describe "_links" do
+ it "links to self" do
+ expect(subject).to have_json_path("_links/self/href")
end
- describe 'showUser' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'showUser' }
+ describe "showUser" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "showUser" }
let(:href) { "/users/#{user.id}" }
end
- context 'with a locked user' do
+ context "with a locked user" do
let(:status) { Principal.statuses[:locked] }
- it_behaves_like 'has no link' do
- let(:link) { 'showUser' }
+ it_behaves_like "has no link" do
+ let(:link) { "showUser" }
end
end
end
- context 'when regular current_user' do
- it 'has no lock-related links' do
- expect(subject).not_to have_json_path('_links/lock/href')
- expect(subject).not_to have_json_path('_links/unlock/href')
- expect(subject).not_to have_json_path('_links/update/href')
+ context "when regular current_user" do
+ it "has no lock-related links" do
+ expect(subject).not_to have_json_path("_links/lock/href")
+ expect(subject).not_to have_json_path("_links/unlock/href")
+ expect(subject).not_to have_json_path("_links/update/href")
end
end
- context 'when current_user is admin' do
+ context "when current_user is admin" do
let(:current_user) { build_stubbed(:admin) }
- it 'links to lock and update' do
- expect(subject).to have_json_path('_links/lock/href')
- expect(subject).to have_json_path('_links/updateImmediately/href')
+ it "links to lock and update" do
+ expect(subject).to have_json_path("_links/lock/href")
+ expect(subject).to have_json_path("_links/updateImmediately/href")
end
- context 'when account is locked' do
- it 'links to unlock' do
+ context "when account is locked" do
+ it "links to unlock" do
user.lock
- expect(subject).to have_json_path('_links/unlock/href')
+ expect(subject).to have_json_path("_links/unlock/href")
end
end
- context 'when deletion is allowed' do
+ context "when deletion is allowed" do
before do
allow(Users::DeleteContract).to receive(:deletion_allowed?)
.with(user, current_user)
.and_return(true)
end
- it 'links to delete' do
- expect(subject).to have_json_path('_links/delete/href')
+ it "links to delete" do
+ expect(subject).to have_json_path("_links/delete/href")
end
end
end
- context 'when deletion is allowed' do
+ context "when deletion is allowed" do
before do
allow(Users::DeleteContract).to receive(:deletion_allowed?)
.with(user, current_user)
.and_return(true)
end
- it 'links to delete' do
- expect(subject).to have_json_path('_links/delete/href')
+ it "links to delete" do
+ expect(subject).to have_json_path("_links/delete/href")
end
end
- context 'when deletion is not allowed' do
+ context "when deletion is not allowed" do
before do
allow(Users::DeleteContract).to receive(:deletion_allowed?)
.with(user, current_user)
.and_return(false)
end
- it 'does not link to delete' do
- expect(subject).not_to have_json_path('_links/delete/href')
+ it "does not link to delete" do
+ expect(subject).not_to have_json_path("_links/delete/href")
end
end
- describe 'memberships' do
+ describe "memberships" do
before do
mock_permissions_for(current_user) do |mock|
mock.allow_in_project *permissions, project: build_stubbed(:project) # any project
@@ -239,44 +239,44 @@
end
let(:href) do
- filters = [{ 'principal' => {
- 'operator' => '=',
- 'values' => [user.id.to_s]
+ filters = [{ "principal" => {
+ "operator" => "=",
+ "values" => [user.id.to_s]
} }]
api_v3_paths.path_for(:memberships, filters:)
end
- context 'if the user has the :view_members permissions' do
+ context "if the user has the :view_members permissions" do
let(:permissions) { [:view_members] }
- it_behaves_like 'has a titled link' do
- let(:link) { 'memberships' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "memberships" }
let(:title) { I18n.t(:label_membership_plural) }
end
end
- context 'if the user has the :manage_members permissions' do
+ context "if the user has the :manage_members permissions" do
let(:permissions) { [:manage_members] }
- it_behaves_like 'has a titled link' do
- let(:link) { 'memberships' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "memberships" }
let(:title) { I18n.t(:label_membership_plural) }
end
end
- context 'if the user lacks permissions' do
+ context "if the user lacks permissions" do
let(:permissions) { [] }
- it_behaves_like 'has no link' do
- let(:link) { 'memberships' }
+ it_behaves_like "has no link" do
+ let(:link) { "memberships" }
end
end
end
end
- describe 'caching' do
- it 'is based on the representer\'s cache_key' do
+ describe "caching" do
+ it "is based on the representer's cache_key" do
allow(OpenProject::Cache)
.to receive(:fetch)
.and_call_original
@@ -288,7 +288,7 @@
.with(representer.json_cache_key)
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let(:auth_source) { build_stubbed(:ldap_auth_source) }
let(:former_cache_key) { representer.json_cache_key }
@@ -298,53 +298,53 @@
former_cache_key
end
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'Users', 'UserRepresenter')
+ .to include("API", "V3", "Users", "UserRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
I18n.with_locale(:fr) do
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
end
- it 'changes when the user is updated' do
+ it "changes when the user is updated" do
user.updated_at = 20.seconds.from_now
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
- it 'changes when user format setting changes' do
+ it "changes when user format setting changes" do
allow(Setting)
.to receive(:user_format)
- .and_return 'something else'
+ .and_return "something else"
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
- it 'changes when the avatars plugin settings change' do
+ it "changes when the avatars plugin settings change" do
allow(Setting)
.to receive(:plugin_openproject_avatars)
- .and_return 'something else'
+ .and_return "something else"
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
- it 'changes when the protocol settings change' do
+ it "changes when the protocol settings change" do
allow(Setting)
.to receive(:protocol)
- .and_return 'something else'
+ .and_return "something else"
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
- it 'changes when the user\'s auth_source is updated' do
+ it "changes when the user's auth_source is updated" do
user.ldap_auth_source.updated_at = 20.seconds.from_now
expect(representer.json_cache_key)
diff --git a/spec/lib/api/v3/users/user_sql_representer_rendering_spec.rb b/spec/lib/api/v3/users/user_sql_representer_rendering_spec.rb
index e2e26cdc67ed..f760b6052e16 100644
--- a/spec/lib/api/v3/users/user_sql_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/users/user_sql_representer_rendering_spec.rb
@@ -24,9 +24,9 @@
#
# See COPYRIGHT and LICENSE files for more details.
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Users::UserSqlRepresenter, 'rendering' do
+RSpec.describe API::V3::Users::UserSqlRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
subject(:json) do
@@ -45,13 +45,13 @@
let(:rendered_user) { current_user }
- let(:select) { { '*' => {} } }
+ let(:select) { { "*" => {} } }
current_user do
create(:user)
end
- context 'when rendering all supported properties' do
+ context "when rendering all supported properties" do
let(:expected) do
{
_type: "User",
@@ -68,15 +68,15 @@
}
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql(expected.to_json)
end
end
- describe 'name property' do
- shared_examples_for 'name property depending on user format setting' do
- let(:select) { { 'name' => {} } }
+ describe "name property" do
+ shared_examples_for "name property depending on user format setting" do
+ let(:select) { { "name" => {} } }
let(:expected) do
{
@@ -84,38 +84,38 @@
}
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql(expected.to_json)
end
end
- context 'when user_format is set to firstname', with_settings: { user_format: :firstname } do
- it_behaves_like 'name property depending on user format setting'
+ context "when user_format is set to firstname", with_settings: { user_format: :firstname } do
+ it_behaves_like "name property depending on user format setting"
end
- context 'when user_format is set to lastname_firstname', with_settings: { user_format: :lastname_firstname } do
- it_behaves_like 'name property depending on user format setting'
+ context "when user_format is set to lastname_firstname", with_settings: { user_format: :lastname_firstname } do
+ it_behaves_like "name property depending on user format setting"
end
- context 'when user_format is set to lastname_coma_firstname', with_settings: { user_format: :lastname_coma_firstname } do
- it_behaves_like 'name property depending on user format setting'
+ context "when user_format is set to lastname_coma_firstname", with_settings: { user_format: :lastname_coma_firstname } do
+ it_behaves_like "name property depending on user format setting"
end
- context 'when user_format is set to lastname_n_firstname', with_settings: { user_format: :lastname_n_firstname } do
- it_behaves_like 'name property depending on user format setting'
+ context "when user_format is set to lastname_n_firstname", with_settings: { user_format: :lastname_n_firstname } do
+ it_behaves_like "name property depending on user format setting"
end
- context 'when user_format is set to username', with_settings: { user_format: :username } do
- it_behaves_like 'name property depending on user format setting'
+ context "when user_format is set to username", with_settings: { user_format: :username } do
+ it_behaves_like "name property depending on user format setting"
end
end
- describe 'firstname property' do
- let(:select) { { 'firstname' => {} } }
+ describe "firstname property" do
+ let(:select) { { "firstname" => {} } }
- context 'when the user is the current user' do
- it 'renders the firstname' do
+ context "when the user is the current user" do
+ it "renders the firstname" do
expect(json)
.to be_json_eql(
{
@@ -125,20 +125,20 @@
end
end
- context 'when the user is a user not having manage_user permission' do
+ context "when the user is a user not having manage_user permission" do
let(:rendered_user) { create(:user) }
- it 'hides the firstname' do
+ it "hides the firstname" do
expect(json)
.to be_json_eql({}.to_json)
end
end
- context 'when the user is a user having manage_user permission' do
+ context "when the user is a user having manage_user permission" do
let(:current_user) { create(:user, global_permissions: [:manage_user]) }
let(:rendered_user) { create(:user) }
- it 'renders the firstname' do
+ it "renders the firstname" do
expect(json)
.to be_json_eql(
{
@@ -149,11 +149,11 @@
end
end
- describe 'lastname property' do
- let(:select) { { 'lastname' => {} } }
+ describe "lastname property" do
+ let(:select) { { "lastname" => {} } }
- context 'when the user is the current user' do
- it 'renders the lastname' do
+ context "when the user is the current user" do
+ it "renders the lastname" do
expect(json)
.to be_json_eql(
{
@@ -163,20 +163,20 @@
end
end
- context 'when the user is a user not having manage_user permission' do
+ context "when the user is a user not having manage_user permission" do
let(:rendered_user) { create(:user) }
- it 'hides the lastname' do
+ it "hides the lastname" do
expect(json)
.to be_json_eql({}.to_json)
end
end
- context 'when the user is a user having manage_user permission' do
+ context "when the user is a user having manage_user permission" do
let(:current_user) { create(:user, global_permissions: [:manage_user]) }
let(:rendered_user) { create(:user) }
- it 'renders the lastname' do
+ it "renders the lastname" do
expect(json)
.to be_json_eql(
{
diff --git a/spec/lib/api/v3/utilities/custom_field_injector_spec.rb b/spec/lib/api/v3/utilities/custom_field_injector_spec.rb
index f388e8c00b0b..76d1d23f431c 100644
--- a/spec/lib/api/v3/utilities/custom_field_injector_spec.rb
+++ b/spec/lib/api/v3/utilities/custom_field_injector_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Utilities::CustomFieldInjector do
include API::V3::Utilities::PathHelper
let(:cf_path) { custom_field.attribute_name(:camel_case) }
- let(:field_format) { 'bool' }
+ let(:field_format) { "bool" }
let(:custom_field) do
build(:custom_field,
id: 1,
@@ -40,15 +40,15 @@
is_required: true)
end
- describe 'TYPE_MAP' do
- it 'supports all available formats' do
+ describe "TYPE_MAP" do
+ it "supports all available formats" do
OpenProject::CustomFieldFormat.available_formats.each do |format|
expect(described_class::TYPE_MAP[format]).not_to be_nil
end
end
end
- describe '#inject_schema' do
+ describe "#inject_schema" do
let(:base_class) { Class.new(API::Decorators::SchemaRepresenter) }
let(:modified_class) { described_class.create_schema_representer([custom_field], base_class) }
let(:schema_writable) { true }
@@ -63,22 +63,22 @@
subject { modified_class.new(schema, current_user: nil, form_embedded: true).to_json }
- describe 'basic custom field' do
+ describe "basic custom field" do
let(:path) { cf_path }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Boolean' }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Boolean" }
let(:name) { custom_field.name }
let(:required) { true }
let(:writable) { true }
let(:has_default) { false }
end
- context 'with schema not writable' do
+ context "with schema not writable" do
let(:schema_writable) { false }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Boolean' }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Boolean" }
let(:name) { custom_field.name }
let(:required) { true }
let(:writable) { false }
@@ -86,17 +86,17 @@
end
end
- context 'with default set' do
+ context "with default set" do
let(:custom_field) do
build(:custom_field,
id: 1,
- field_format: 'string',
- default_value: 'foo',
+ field_format: "string",
+ default_value: "foo",
is_required: true)
end
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'String' }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "String" }
let(:name) { custom_field.name }
let(:required) { true }
let(:writable) { true }
@@ -104,47 +104,47 @@
end
end
- it 'indicates no regular expression' do
+ it "indicates no regular expression" do
expect(subject).not_to have_json_path("#{cf_path}/regularExpression")
end
# meaning they won't as no values are specified
- it_behaves_like 'indicates length requirements'
+ it_behaves_like "indicates length requirements"
- context 'when custom field is not required' do
+ context "when custom field is not required" do
let(:custom_field) { build(:custom_field, is_required: false) }
- it 'marks the field as not required' do
+ it "marks the field as not required" do
expect(subject).to be_json_eql(false.to_json).at_path("#{cf_path}/required")
end
end
- context 'when custom field has regex' do
- let(:custom_field) { build(:custom_field, regexp: 'Foo+bar') }
+ context "when custom field has regex" do
+ let(:custom_field) { build(:custom_field, regexp: "Foo+bar") }
- it 'renders the regular expression' do
- expect(subject).to be_json_eql('Foo+bar'.to_json).at_path("#{cf_path}/regularExpression")
+ it "renders the regular expression" do
+ expect(subject).to be_json_eql("Foo+bar".to_json).at_path("#{cf_path}/regularExpression")
end
end
- context 'when custom field has minimum length' do
+ context "when custom field has minimum length" do
let(:custom_field) { build(:custom_field, min_length: 5) }
- it_behaves_like 'indicates length requirements' do
+ it_behaves_like "indicates length requirements" do
let(:min_length) { 5 }
end
end
- context 'when custom field has maximum length' do
+ context "when custom field has maximum length" do
let(:custom_field) { build(:custom_field, max_length: 5) }
- it_behaves_like 'indicates length requirements' do
+ it_behaves_like "indicates length requirements" do
let(:max_length) { 5 }
end
end
end
- describe 'version custom field' do
+ describe "version custom field" do
let(:custom_field) do
build(:version_wp_custom_field,
is_required: true)
@@ -161,34 +161,34 @@
allow(API::V3::Versions::VersionRepresenter).to receive(:create).and_return(double)
end
- it_behaves_like 'has basic schema properties' do
+ it_behaves_like "has basic schema properties" do
let(:path) { cf_path }
- let(:type) { 'Version' }
+ let(:type) { "Version" }
let(:name) { custom_field.name }
let(:required) { true }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- context 'with schema not writable' do
+ context "with schema not writable" do
let(:schema_writable) { false }
- it_behaves_like 'has basic schema properties' do
+ it_behaves_like "has basic schema properties" do
let(:path) { cf_path }
- let(:type) { 'Version' }
+ let(:type) { "Version" }
let(:name) { custom_field.name }
let(:required) { true }
let(:writable) { false }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
end
- it_behaves_like 'links to allowed values directly' do
+ it_behaves_like "links to allowed values directly" do
let(:path) { cf_path }
let(:hrefs) { assignable_versions.map { |version| api_v3_paths.version version.id } }
end
- it 'embeds allowed values' do
+ it "embeds allowed values" do
# N.B. we do not use the stricter 'links to and embeds allowed values directly' helper
# because this would not allow us to easily mock the VersionRepresenter away
expect(subject)
@@ -197,7 +197,7 @@
end
end
- describe 'list custom field' do
+ describe "list custom field" do
before do
allow(schema)
.to receive(:assignable_custom_field_values)
@@ -213,31 +213,31 @@
)
end
- let(:values) { ['foo', 'bar', 'baz'] }
+ let(:values) { ["foo", "bar", "baz"] }
- it_behaves_like 'has basic schema properties' do
+ it_behaves_like "has basic schema properties" do
let(:path) { cf_path }
- let(:type) { 'CustomOption' }
+ let(:type) { "CustomOption" }
let(:name) { custom_field.name }
let(:required) { true }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- context 'with schema not writable' do
+ context "with schema not writable" do
let(:schema_writable) { false }
- it_behaves_like 'has basic schema properties' do
+ it_behaves_like "has basic schema properties" do
let(:path) { cf_path }
- let(:type) { 'CustomOption' }
+ let(:type) { "CustomOption" }
let(:name) { custom_field.name }
let(:required) { true }
let(:writable) { false }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
end
- it_behaves_like 'links to and embeds allowed values directly' do
+ it_behaves_like "links to and embeds allowed values directly" do
let(:path) { cf_path }
let(:hrefs) do
custom_field.possible_values.map do |value|
@@ -247,42 +247,42 @@
end
end
- describe 'user custom field' do
+ describe "user custom field" do
let(:custom_field) do
build(:custom_field,
- field_format: 'user',
+ field_format: "user",
is_required: true)
end
- it_behaves_like 'has basic schema properties' do
+ it_behaves_like "has basic schema properties" do
let(:path) { cf_path }
- let(:type) { 'User' }
+ let(:type) { "User" }
let(:name) { custom_field.name }
let(:required) { true }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- context 'with schema not writable' do
+ context "with schema not writable" do
let(:schema_writable) { false }
- it_behaves_like 'has basic schema properties' do
+ it_behaves_like "has basic schema properties" do
let(:path) { cf_path }
- let(:type) { 'User' }
+ let(:type) { "User" }
let(:name) { custom_field.name }
let(:required) { true }
let(:writable) { false }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
end
- it_behaves_like 'links to allowed values via collection link' do
+ it_behaves_like "links to allowed values via collection link" do
let(:path) { cf_path }
let(:href) do
params = [
- { status: { operator: '!', values: [Principal.statuses[:locked].to_s] } },
- { type: { operator: '=', values: %w[User Group PlaceholderUser] } },
- { member: { operator: '=', values: [schema.project_id.to_s] } }
+ { status: { operator: "!", values: [Principal.statuses[:locked].to_s] } },
+ { type: { operator: "=", values: %w[User Group PlaceholderUser] } },
+ { member: { operator: "=", values: [schema.project_id.to_s] } }
]
query = CGI.escape(JSON.dump(params))
@@ -292,7 +292,7 @@
end
end
- describe 'user custom field on new project' do
+ describe "user custom field on new project" do
let(:schema) do
instance_double(API::V3::WorkPackages::Schema::SpecificWorkPackageSchema,
id: nil,
@@ -301,17 +301,17 @@
end
let(:custom_field) do
build(:custom_field,
- field_format: 'user',
+ field_format: "user",
is_required: true)
end
- it_behaves_like 'links to allowed values via collection link' do
+ it_behaves_like "links to allowed values via collection link" do
let(:path) { cf_path }
let(:href) do
params = [
- { status: { operator: '!', values: [Principal.statuses[:locked].to_s] } },
- { type: { operator: '=', values: %w[User Group PlaceholderUser] } },
- { member: { operator: '*', values: [] } }
+ { status: { operator: "!", values: [Principal.statuses[:locked].to_s] } },
+ { type: { operator: "=", values: %w[User Group PlaceholderUser] } },
+ { member: { operator: "*", values: [] } }
]
query = CGI.escape(JSON.dump(params))
@@ -322,13 +322,13 @@
end
end
- describe '#inject_value' do
- shared_examples_for 'injects property custom field' do
- it 'has a readable value' do
+ describe "#inject_value" do
+ shared_examples_for "injects property custom field" do
+ it "has a readable value" do
expect(subject).to be_json_eql(json_value.to_json).at_path(cf_path)
end
- it 'on writing it sets on the represented' do
+ it "on writing it sets on the represented" do
allow(represented).to receive(custom_field.attribute_setter)
modified_class
.new(represented, current_user: nil)
@@ -349,14 +349,14 @@ def self.custom_field_injector_config
end
let(:modified_class) { described_class.create_value_representer([custom_field], base_class) }
let(:represented) do
- double('represented',
+ double("represented",
available_custom_fields: [custom_field],
custom_field.attribute_name => value)
end
let(:custom_value) { instance_double(CustomValue, value: raw_value, typed_value:) }
let(:raw_value) { nil }
let(:typed_value) { raw_value }
- let(:value) { '' }
+ let(:value) { "" }
let(:current_user) { build(:user) }
subject { modified_class.new(represented, current_user:, embed_links: true).to_json }
@@ -366,99 +366,99 @@ def self.custom_field_injector_config
allow(represented).to receive(:custom_value_for).with(custom_field).and_return(custom_value)
end
- context 'for user custom field' do
+ context "for user custom field" do
let(:raw_value) { value.id.to_s }
let(:typed_value) { value }
- let(:field_format) { 'user' }
+ let(:field_format) { "user" }
%w[user group placeholder_user].each do |type|
describe "#{type} assignment" do
let(:value) { build(type, id: 2) }
- it_behaves_like 'has a titled link' do
+ it_behaves_like "has a titled link" do
let(:link) { cf_path }
let(:href) { api_v3_paths.send type, 2 }
let(:title) { value.name }
end
- it 'has the user embedded' do
+ it "has the user embedded" do
expect(subject).to be_json_eql(type.classify.to_json).at_path("_embedded/#{cf_path}/_type")
expect(subject).to be_json_eql(value.name.to_json).at_path("_embedded/#{cf_path}/name")
end
end
end
- context 'when value is nil' do
+ context "when value is nil" do
let(:value) { nil }
- let(:raw_value) { '' }
+ let(:raw_value) { "" }
- it_behaves_like 'has an empty link' do
+ it_behaves_like "has an empty link" do
let(:link) { cf_path }
end
end
end
- context 'for version custom field' do
+ context "for version custom field" do
let(:value) { build_stubbed(:version, id: 2) }
let(:raw_value) { value.id.to_s }
let(:typed_value) { value }
- let(:field_format) { 'version' }
+ let(:field_format) { "version" }
- it_behaves_like 'has a titled link' do
+ it_behaves_like "has a titled link" do
let(:link) { cf_path }
let(:href) { api_v3_paths.version 2 }
let(:title) { value.name }
end
- it 'has the version embedded' do
- expect(subject).to be_json_eql('Version'.to_json).at_path("_embedded/#{cf_path}/_type")
+ it "has the version embedded" do
+ expect(subject).to be_json_eql("Version".to_json).at_path("_embedded/#{cf_path}/_type")
expect(subject).to be_json_eql(value.name.to_json).at_path("_embedded/#{cf_path}/name")
end
- context 'when value is nil' do
+ context "when value is nil" do
let(:value) { nil }
- let(:raw_value) { '' }
+ let(:raw_value) { "" }
- it_behaves_like 'has an empty link' do
+ it_behaves_like "has an empty link" do
let(:link) { cf_path }
end
end
end
- context 'for list custom field' do
+ context "for list custom field" do
let(:value) { build_stubbed(:custom_option) }
let(:typed_value) { value.value }
let(:raw_value) { value.id.to_s }
- let(:field_format) { 'list' }
+ let(:field_format) { "list" }
- it_behaves_like 'has a titled link' do
+ it_behaves_like "has a titled link" do
let(:link) { cf_path }
let(:href) { api_v3_paths.custom_option(value.id) }
let(:title) { value.value }
end
- context 'when value is nil' do
+ context "when value is nil" do
let(:value) { nil }
- let(:raw_value) { '' }
- let(:typed_value) { '' }
+ let(:raw_value) { "" }
+ let(:typed_value) { "" }
- it_behaves_like 'has an empty link' do
+ it_behaves_like "has an empty link" do
let(:link) { cf_path }
end
end
- context 'when value is some invalid string' do
- let(:value) { 'some invalid string' }
- let(:raw_value) { 'some invalid string' }
- let(:typed_value) { 'some invalid string not found' }
+ context "when value is some invalid string" do
+ let(:value) { "some invalid string" }
+ let(:raw_value) { "some invalid string" }
+ let(:typed_value) { "some invalid string not found" }
- it 'has an empty href' do
+ it "has an empty href" do
expect(subject)
.to be_json_eql(nil.to_json)
.at_path("_links/#{cf_path}/href")
end
- it 'has the invalid value as title' do
+ it "has the invalid value as title" do
expect(subject)
.to be_json_eql(typed_value.to_json)
.at_path("_links/#{cf_path}/title")
@@ -466,58 +466,58 @@ def self.custom_field_injector_config
end
end
- context 'for string custom field' do
- it_behaves_like 'injects property custom field' do
- let(:field_format) { 'string' }
- let(:value) { 'Foobar' }
- let(:json_value) { 'Foobar' }
+ context "for string custom field" do
+ it_behaves_like "injects property custom field" do
+ let(:field_format) { "string" }
+ let(:value) { "Foobar" }
+ let(:json_value) { "Foobar" }
let(:expected_setter) { json_value }
end
end
- context 'for int custom field' do
- it_behaves_like 'injects property custom field' do
- let(:field_format) { 'int' }
+ context "for int custom field" do
+ it_behaves_like "injects property custom field" do
+ let(:field_format) { "int" }
let(:value) { 42 }
let(:json_value) { 42 }
let(:expected_setter) { json_value }
end
end
- context 'for float custom field' do
- it_behaves_like 'injects property custom field' do
- let(:field_format) { 'float' }
+ context "for float custom field" do
+ it_behaves_like "injects property custom field" do
+ let(:field_format) { "float" }
let(:value) { 3.14 }
let(:json_value) { 3.14 }
let(:expected_setter) { json_value }
end
end
- context 'for bool custom field' do
- it_behaves_like 'injects property custom field' do
- let(:field_format) { 'bool' }
+ context "for bool custom field" do
+ it_behaves_like "injects property custom field" do
+ let(:field_format) { "bool" }
let(:value) { true }
let(:json_value) { true }
let(:expected_setter) { json_value }
end
end
- context 'for date custom field' do
- it_behaves_like 'injects property custom field' do
- let(:field_format) { 'date' }
+ context "for date custom field" do
+ it_behaves_like "injects property custom field" do
+ let(:field_format) { "date" }
let(:value) { Date.current }
let(:json_value) { value.to_date.iso8601 }
let(:expected_setter) { json_value }
end
end
- context 'for text custom field' do
- it_behaves_like 'injects property custom field' do
- let(:field_format) { 'text' }
- let(:value) { '**Foobar**' }
+ context "for text custom field" do
+ it_behaves_like "injects property custom field" do
+ let(:field_format) { "text" }
+ let(:value) { "**Foobar**" }
let(:json_value) do
{
- format: 'markdown',
+ format: "markdown",
raw: value,
html: '
Foobar
'
}
@@ -527,7 +527,7 @@ def self.custom_field_injector_config
end
end
- describe '#inject_patchable_link_value' do
+ describe "#inject_patchable_link_value" do
let(:base_class) do
Class.new(API::Decorators::Single) do
def self.custom_field_injector_config
@@ -539,10 +539,10 @@ def self.custom_field_injector_config
described_class.create_value_representer([custom_field], base_class)
end
let(:represented) do
- double('represented', available_custom_fields: [custom_field])
+ double("represented", available_custom_fields: [custom_field])
end
let(:custom_value) { instance_double(CustomValue, value:, typed_value:) }
- let(:value) { '' }
+ let(:value) { "" }
let(:user) { build_stubbed(:user) }
let(:typed_value) { value }
@@ -553,15 +553,15 @@ def self.custom_field_injector_config
allow(represented).to receive(custom_field.attribute_getter).and_return(typed_value)
end
- context 'for reading' do
- let(:value) { '2' }
- let(:field_format) { 'user' }
+ context "for reading" do
+ let(:value) { "2" }
+ let(:field_format) { "user" }
%w[user group placeholder_user].each do |type|
describe "#{type} reading" do
let(:typed_value) { build(type, id: 2) }
- it_behaves_like 'has a titled link' do
+ it_behaves_like "has a titled link" do
let(:link) { cf_path }
let(:href) { api_v3_paths.send type, 2 }
let(:title) { typed_value.name }
@@ -569,25 +569,25 @@ def self.custom_field_injector_config
end
end
- context 'when value is nil' do
+ context "when value is nil" do
let(:value) { nil }
let(:typed_value) { nil }
- it_behaves_like 'has an empty link' do
+ it_behaves_like "has an empty link" do
let(:link) { cf_path }
end
end
end
- context 'for writing' do
+ context "for writing" do
let(:value) { nil }
- let(:field_format) { 'user' }
+ let(:field_format) { "user" }
%w[user group placeholder_user].each do |type|
it "accepts a valid link of type #{type}" do
path = api_v3_paths.send type, 2
json = { cf_path => { href: path } }.to_json
- expected = ['2']
+ expected = ["2"]
allow(represented).to receive(custom_field.attribute_setter)
modified_class.new(represented, current_user: nil).from_json(json)
@@ -596,7 +596,7 @@ def self.custom_field_injector_config
end
end
- it 'accepts an empty link' do
+ it "accepts an empty link" do
json = { cf_path => { href: nil } }.to_json
expected = []
diff --git a/spec/lib/api/v3/utilities/date_time_formatter_spec.rb b/spec/lib/api/v3/utilities/date_time_formatter_spec.rb
index 54e9430fdfab..e8c0a1787381 100644
--- a/spec/lib/api/v3/utilities/date_time_formatter_spec.rb
+++ b/spec/lib/api/v3/utilities/date_time_formatter_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Utilities::DateTimeFormatter do
subject { described_class }
@@ -34,128 +34,128 @@
let(:date) { Time.zone.today }
let(:datetime) { DateTime.now }
- shared_examples_for 'can format nil' do
- it 'accepts nil if asked to' do
+ shared_examples_for "can format nil" do
+ it "accepts nil if asked to" do
expect(subject.send(method, nil, allow_nil: true)).to be_nil
end
- it 'returns usual result for non-nils' do
+ it "returns usual result for non-nils" do
expected = subject.send(method, input)
expect(subject.send(method, input, allow_nil: true)).to eq(expected)
end
end
- shared_examples_for 'can parse nil' do
- it 'accepts nil if asked to' do
- expect(subject.send(method, nil, 'prop', allow_nil: true)).to be_nil
+ shared_examples_for "can parse nil" do
+ it "accepts nil if asked to" do
+ expect(subject.send(method, nil, "prop", allow_nil: true)).to be_nil
end
- it 'returns usual result for non-nils' do
- expected = subject.send(method, input, 'prop')
- expect(subject.send(method, input, 'prop', allow_nil: true)).to eq(expected)
+ it "returns usual result for non-nils" do
+ expected = subject.send(method, input, "prop")
+ expect(subject.send(method, input, "prop", allow_nil: true)).to eq(expected)
end
end
- shared_examples_for 'rejects durations with parsing errors' do
- it 'rejects parsing non sense' do
+ shared_examples_for "rejects durations with parsing errors" do
+ it "rejects parsing non sense" do
expect do
- subject.send(method, 'foo', 'prop')
+ subject.send(method, "foo", "prop")
end.to raise_error(API::Errors::PropertyFormatError)
end
- it 'rejects parsing pure number strings' do
+ it "rejects parsing pure number strings" do
expect do
- subject.send(method, '5', 'prop')
+ subject.send(method, "5", "prop")
end.to raise_error(API::Errors::PropertyFormatError)
end
- it 'rejects parsing pure numbers' do
+ it "rejects parsing pure numbers" do
expect do
- subject.send(method, 5, 'prop')
+ subject.send(method, 5, "prop")
end.to raise_error(API::Errors::PropertyFormatError)
end
end
- describe 'format_date' do
- it 'formats dates' do
+ describe "format_date" do
+ it "formats dates" do
expect(subject.format_date(date)).to eq(date.iso8601)
end
- it 'formats datetimes' do
+ it "formats datetimes" do
expect(subject.format_date(datetime)).to eq(datetime.to_date.iso8601)
end
- it_behaves_like 'can format nil' do
+ it_behaves_like "can format nil" do
let(:method) { :format_date }
let(:input) { date }
end
end
- describe 'parse_date' do
- it 'parses ISO 8601 dates' do
- expect(subject.parse_date(date.iso8601, 'prop')).to eq(date)
+ describe "parse_date" do
+ it "parses ISO 8601 dates" do
+ expect(subject.parse_date(date.iso8601, "prop")).to eq(date)
end
- it 'rejects parsing non ISO date formats' do
- bad_format = date.strftime('%d.%m.%Y')
+ it "rejects parsing non ISO date formats" do
+ bad_format = date.strftime("%d.%m.%Y")
expect do
- subject.parse_date(bad_format, 'prop')
+ subject.parse_date(bad_format, "prop")
end.to raise_error(API::Errors::PropertyFormatError) do |error| # rubocop:disable Style/MultilineBlockChain
expect(error.message).to include("Invalid format for property 'prop'")
expect(error.message).to include("Expected format like 'YYYY-MM-DD (ISO 8601 date only)'")
end
end
- it 'rejects parsing ISO 8601 date + time formats' do
+ it "rejects parsing ISO 8601 date + time formats" do
bad_format = datetime.iso8601
expect do
- subject.parse_date(bad_format, 'prop')
+ subject.parse_date(bad_format, "prop")
end.to raise_error(API::Errors::PropertyFormatError) do |error| # rubocop:disable Style/MultilineBlockChain
expect(error.message).to include("Invalid format for property 'prop'")
expect(error.message).to include("Expected format like 'YYYY-MM-DD (ISO 8601 date only)'")
end
end
- it_behaves_like 'can parse nil' do
+ it_behaves_like "can parse nil" do
let(:method) { :parse_date }
let(:input) { date.iso8601 }
end
end
- describe 'format_datetime' do
- it 'formats dates' do
+ describe "format_datetime" do
+ it "formats dates" do
expect(subject.format_datetime(date)).to eq(date.to_datetime.utc.iso8601(3))
end
- it 'formats datetimes' do
+ it "formats datetimes" do
expect(subject.format_datetime(datetime)).to eq(datetime.utc.iso8601(3))
end
- it_behaves_like 'can format nil' do
+ it_behaves_like "can format nil" do
let(:method) { :format_datetime }
let(:input) { datetime }
end
end
- describe 'parse_datetime' do
- it 'parses ISO 8601 datetimes' do
- expect(subject.parse_datetime(datetime.utc.iso8601(9), 'prop')).to eq(datetime)
- expect(subject.parse_datetime('1999-12-31T14:15:16', 'prop'))
+ describe "parse_datetime" do
+ it "parses ISO 8601 datetimes" do
+ expect(subject.parse_datetime(datetime.utc.iso8601(9), "prop")).to eq(datetime)
+ expect(subject.parse_datetime("1999-12-31T14:15:16", "prop"))
.to eq(DateTime.new(1999, 12, 31, 14, 15, 16))
- expect(subject.parse_datetime('1999-12-31', 'prop'))
+ expect(subject.parse_datetime("1999-12-31", "prop"))
.to eq(DateTime.new(1999, 12, 31, 0, 0, 0))
- expect(subject.parse_datetime('1999-12-31T14:15:16Z', 'prop'))
- .to eq(DateTime.new(1999, 12, 31, 14, 15, 16, '+00:00'))
- expect(subject.parse_datetime('1999-12-31T14:15:16+02:30', 'prop'))
- .to eq(DateTime.new(1999, 12, 31, 11, 45, 16, '+00:00'))
- expect(subject.parse_datetime('1999-12-31T14:15:16.4242', 'prop'))
+ expect(subject.parse_datetime("1999-12-31T14:15:16Z", "prop"))
+ .to eq(DateTime.new(1999, 12, 31, 14, 15, 16, "+00:00"))
+ expect(subject.parse_datetime("1999-12-31T14:15:16+02:30", "prop"))
+ .to eq(DateTime.new(1999, 12, 31, 11, 45, 16, "+00:00"))
+ expect(subject.parse_datetime("1999-12-31T14:15:16.4242", "prop"))
.to eq(DateTime.new(1999, 12, 31, 14, 15, 16.4242))
end
- it 'rejects parsing non ISO date formats' do
- bad_format = datetime.strftime('%d.%m.%Y')
+ it "rejects parsing non ISO date formats" do
+ bad_format = datetime.strftime("%d.%m.%Y")
expect do
- subject.parse_datetime(bad_format, 'prop')
+ subject.parse_datetime(bad_format, "prop")
end.to raise_error(API::Errors::PropertyFormatError) do |error| # rubocop:disable Style/MultilineBlockChain
expect(error.message).to include("Invalid format for property 'prop'")
expect(error.message).to include("Expected format like 'YYYY-MM-DDThh:mm:ss[.lll][+hh:mm] " +
@@ -163,101 +163,101 @@
end
end
- it_behaves_like 'can parse nil' do
+ it_behaves_like "can parse nil" do
let(:method) { :parse_datetime }
let(:input) { datetime.iso8601(9) }
end
end
- describe 'format_duration_from_hours' do
- it 'formats floats' do
- expect(subject.format_duration_from_hours(5.0)).to eq('PT5H')
+ describe "format_duration_from_hours" do
+ it "formats floats" do
+ expect(subject.format_duration_from_hours(5.0)).to eq("PT5H")
end
- it 'formats fractional floats' do
- expect(subject.format_duration_from_hours(5.5)).to eq('PT5H30M')
+ it "formats fractional floats" do
+ expect(subject.format_duration_from_hours(5.5)).to eq("PT5H30M")
end
- it 'includes seconds' do
- expect(subject.format_duration_from_hours(5.501)).to eq('PT5H30M3S')
+ it "includes seconds" do
+ expect(subject.format_duration_from_hours(5.501)).to eq("PT5H30M3S")
end
- it 'formats ints' do
- expect(subject.format_duration_from_hours(5)).to eq('PT5H')
+ it "formats ints" do
+ expect(subject.format_duration_from_hours(5)).to eq("PT5H")
end
- it_behaves_like 'can format nil' do
+ it_behaves_like "can format nil" do
let(:method) { :format_duration_from_hours }
let(:input) { 5 }
end
end
- describe 'parse_duration_to_hours' do
- it 'parses ISO 8601 durations of full hours' do
- expect(subject.parse_duration_to_hours('PT5H', 'prop')).to eq(5.0)
+ describe "parse_duration_to_hours" do
+ it "parses ISO 8601 durations of full hours" do
+ expect(subject.parse_duration_to_hours("PT5H", "prop")).to eq(5.0)
end
- it 'parses ISO 8601 durations of fractional hours' do
- expect(subject.parse_duration_to_hours('PT5H30M', 'prop')).to eq(5.5)
+ it "parses ISO 8601 durations of fractional hours" do
+ expect(subject.parse_duration_to_hours("PT5H30M", "prop")).to eq(5.5)
end
- it 'parses ISO 8601 durations of days' do
- expect(subject.parse_duration_to_hours('P1D', 'prop')).to eq(24.0)
+ it "parses ISO 8601 durations of days" do
+ expect(subject.parse_duration_to_hours("P1D", "prop")).to eq(24.0)
end
- it_behaves_like 'rejects durations with parsing errors' do
+ it_behaves_like "rejects durations with parsing errors" do
let(:method) { :parse_duration_to_hours }
end
- it_behaves_like 'can parse nil' do
+ it_behaves_like "can parse nil" do
let(:method) { :parse_duration_to_hours }
- let(:input) { 'PT5H' }
+ let(:input) { "PT5H" }
end
end
- describe 'format_duration_from_days' do
- it 'formats floats' do
- expect(subject.format_duration_from_days(5.0)).to eq('P5D')
+ describe "format_duration_from_days" do
+ it "formats floats" do
+ expect(subject.format_duration_from_days(5.0)).to eq("P5D")
end
- it 'formats fractional floats' do
- expect(subject.format_duration_from_days(5.5)).to eq('P5DT12H')
+ it "formats fractional floats" do
+ expect(subject.format_duration_from_days(5.5)).to eq("P5DT12H")
end
- it 'includes minutes and seconds' do
- expect(subject.format_duration_from_days(5.501)).to eq('P5DT12H1M26S')
+ it "includes minutes and seconds" do
+ expect(subject.format_duration_from_days(5.501)).to eq("P5DT12H1M26S")
end
- it 'formats ints' do
- expect(subject.format_duration_from_days(5)).to eq('P5D')
+ it "formats ints" do
+ expect(subject.format_duration_from_days(5)).to eq("P5D")
end
- it_behaves_like 'can format nil' do
+ it_behaves_like "can format nil" do
let(:method) { :format_duration_from_days }
let(:input) { 5 }
end
end
- describe 'parse_duration_to_days' do
- it 'parses ISO 8601 durations of full days' do
- expect(subject.parse_duration_to_days('P5D', 'prop')).to eq(5)
+ describe "parse_duration_to_days" do
+ it "parses ISO 8601 durations of full days" do
+ expect(subject.parse_duration_to_days("P5D", "prop")).to eq(5)
end
- it 'parses ISO 8601 durations of fractional days as whole' do
- expect(subject.parse_duration_to_days('P5DT18H30M', 'prop')).to eq(5)
+ it "parses ISO 8601 durations of fractional days as whole" do
+ expect(subject.parse_duration_to_days("P5DT18H30M", "prop")).to eq(5)
end
- it 'parses ISO 8601 durations of hours as 0 days' do
- expect(subject.parse_duration_to_days('PT1H30M', 'prop')).to eq(0)
+ it "parses ISO 8601 durations of hours as 0 days" do
+ expect(subject.parse_duration_to_days("PT1H30M", "prop")).to eq(0)
end
- it_behaves_like 'rejects durations with parsing errors' do
+ it_behaves_like "rejects durations with parsing errors" do
let(:method) { :parse_duration_to_days }
end
- it_behaves_like 'can parse nil' do
+ it_behaves_like "can parse nil" do
let(:method) { :parse_duration_to_days }
- let(:input) { 'PT5H' }
+ let(:input) { "PT5H" }
end
end
end
diff --git a/spec/lib/api/v3/utilities/path_helper_spec.rb b/spec/lib/api/v3/utilities/path_helper_spec.rb
index cb9b6c3debe4..e028b911e9a3 100644
--- a/spec/lib/api/v3/utilities/path_helper_spec.rb
+++ b/spec/lib/api/v3/utilities/path_helper_spec.rb
@@ -26,19 +26,19 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Utilities::PathHelper do
let(:helper) { Class.new.tap { |c| c.extend(API::V3::Utilities::PathHelper) }.api_v3_paths }
- shared_examples_for 'path' do |url|
- it 'provides the path' do
+ shared_examples_for "path" do |url|
+ it "provides the path" do
expect(subject).to match(url)
end
- it 'prepends the sub uri if configured' do
+ it "prepends the sub uri if configured" do
allow(OpenProject::Configuration).to receive(:rails_relative_url_root)
- .and_return('/open_project')
+ .and_return("/open_project")
expect(subject).to match("/open_project#{url}")
end
@@ -52,623 +52,623 @@
RequestStore.clear!
end
- shared_examples_for 'api v3 path' do |url|
- it_behaves_like 'path', "/api/v3#{url}"
+ shared_examples_for "api v3 path" do |url|
+ it_behaves_like "path", "/api/v3#{url}"
end
- shared_examples_for 'index' do |name|
+ shared_examples_for "index" do |name|
plural_name = name.to_s.pluralize
describe "##{plural_name}" do
subject { helper.send(plural_name) }
- it_behaves_like 'api v3 path', "/#{plural_name}"
+ it_behaves_like "api v3 path", "/#{plural_name}"
end
end
- shared_examples_for 'show' do |name|
+ shared_examples_for "show" do |name|
describe "##{name}" do
subject { helper.send(:"#{name}", 42) }
- it_behaves_like 'api v3 path', "/#{name.to_s.pluralize}/42"
+ it_behaves_like "api v3 path", "/#{name.to_s.pluralize}/42"
end
end
- shared_examples_for 'create form' do |name|
+ shared_examples_for "create form" do |name|
describe "#create_#{name}_form" do
subject { helper.send(:"create_#{name}_form") }
- it_behaves_like 'api v3 path', "/#{name.to_s.pluralize}/form"
+ it_behaves_like "api v3 path", "/#{name.to_s.pluralize}/form"
end
end
- shared_examples_for 'update form' do |name|
+ shared_examples_for "update form" do |name|
describe "##{name}_form" do
subject { helper.send(:"#{name}_form", 42) }
- it_behaves_like 'api v3 path', "/#{name.to_s.pluralize}/42/form"
+ it_behaves_like "api v3 path", "/#{name.to_s.pluralize}/42/form"
end
end
- shared_examples_for 'schema' do |name|
+ shared_examples_for "schema" do |name|
describe "##{name}_schema" do
subject { helper.send(:"#{name}_schema") }
- it_behaves_like 'api v3 path', "/#{name.to_s.pluralize}/schema"
+ it_behaves_like "api v3 path", "/#{name.to_s.pluralize}/schema"
end
end
- shared_examples_for 'resource' do |name, except: []|
- it_behaves_like('index', name) unless except.include?(:index)
- it_behaves_like('show', name) unless except.include?(:show)
- it_behaves_like('update form', name) unless except.include?(:update_form)
- it_behaves_like('create form', name) unless except.include?(:create_form)
- it_behaves_like('schema', name) unless except.include?(:schema)
+ shared_examples_for "resource" do |name, except: []|
+ it_behaves_like("index", name) unless except.include?(:index)
+ it_behaves_like("show", name) unless except.include?(:show)
+ it_behaves_like("update form", name) unless except.include?(:update_form)
+ it_behaves_like("create form", name) unless except.include?(:create_form)
+ it_behaves_like("schema", name) unless except.include?(:schema)
end
- describe '#root' do
+ describe "#root" do
subject { helper.root }
- it_behaves_like 'api v3 path'
+ it_behaves_like "api v3 path"
end
- context 'actions paths' do
- it_behaves_like 'index', :action
- it_behaves_like 'show', :action
+ context "actions paths" do
+ it_behaves_like "index", :action
+ it_behaves_like "show", :action
end
- context 'activities paths' do
- it_behaves_like 'index', :activities
- it_behaves_like 'show', :activity
+ context "activities paths" do
+ it_behaves_like "index", :activities
+ it_behaves_like "show", :activity
end
- context 'attachments paths' do
- it_behaves_like 'index', :attachment
- it_behaves_like 'show', :attachment
+ context "attachments paths" do
+ it_behaves_like "index", :attachment
+ it_behaves_like "show", :attachment
- describe '#attachment_content' do
+ describe "#attachment_content" do
subject { helper.attachment_content 1 }
- it_behaves_like 'api v3 path', '/attachments/1/content'
+ it_behaves_like "api v3 path", "/attachments/1/content"
end
- describe '#attachments_by_post' do
+ describe "#attachments_by_post" do
subject { helper.attachments_by_post 1 }
- it_behaves_like 'api v3 path', '/posts/1/attachments'
+ it_behaves_like "api v3 path", "/posts/1/attachments"
end
- describe '#attachments_by_work_package' do
+ describe "#attachments_by_work_package" do
subject { helper.attachments_by_work_package 1 }
- it_behaves_like 'api v3 path', '/work_packages/1/attachments'
+ it_behaves_like "api v3 path", "/work_packages/1/attachments"
end
- describe '#attachments_by_wiki_page' do
+ describe "#attachments_by_wiki_page" do
subject { helper.attachments_by_wiki_page 1 }
- it_behaves_like 'api v3 path', '/wiki_pages/1/attachments'
+ it_behaves_like "api v3 path", "/wiki_pages/1/attachments"
end
end
- context 'category paths' do
- it_behaves_like 'index', :category
- it_behaves_like 'show', :category
+ context "category paths" do
+ it_behaves_like "index", :category
+ it_behaves_like "show", :category
- describe '#categories_by_project' do
+ describe "#categories_by_project" do
subject { helper.categories_by_project 42 }
- it_behaves_like 'api v3 path', '/projects/42/categories'
+ it_behaves_like "api v3 path", "/projects/42/categories"
end
end
- context 'capabilities paths' do
- it_behaves_like 'index', :capability
- it_behaves_like 'show', :capability
+ context "capabilities paths" do
+ it_behaves_like "index", :capability
+ it_behaves_like "show", :capability
- describe '#capabilties_contexts_global' do
+ describe "#capabilties_contexts_global" do
subject { helper.capabilities_contexts_global }
- it_behaves_like 'api v3 path', '/capabilities/contexts/global'
+ it_behaves_like "api v3 path", "/capabilities/contexts/global"
end
end
- context 'configuration paths' do
- describe '#configuration' do
+ context "configuration paths" do
+ describe "#configuration" do
subject { helper.configuration }
- it_behaves_like 'api v3 path', '/configuration'
+ it_behaves_like "api v3 path", "/configuration"
end
end
- context 'custom action paths' do
- it_behaves_like 'show', :custom_action
+ context "custom action paths" do
+ it_behaves_like "show", :custom_action
- describe '#custom_action_execute' do
+ describe "#custom_action_execute" do
subject { helper.custom_action_execute 42 }
- it_behaves_like 'api v3 path', '/custom_actions/42/execute'
+ it_behaves_like "api v3 path", "/custom_actions/42/execute"
end
- it_behaves_like 'show', :custom_option
+ it_behaves_like "show", :custom_option
end
- describe 'memberships paths' do
- it_behaves_like 'resource', :membership
+ describe "memberships paths" do
+ it_behaves_like "resource", :membership
- describe '#memberships_available_projects' do
+ describe "#memberships_available_projects" do
subject { helper.memberships_available_projects }
- it_behaves_like 'api v3 path', '/memberships/available_projects'
+ it_behaves_like "api v3 path", "/memberships/available_projects"
end
end
- describe 'messages paths' do
- it_behaves_like 'index', :message
- it_behaves_like 'show', :message
+ describe "messages paths" do
+ it_behaves_like "index", :message
+ it_behaves_like "show", :message
end
- describe 'news paths' do
- describe '#newses' do
+ describe "news paths" do
+ describe "#newses" do
subject { helper.newses }
- it_behaves_like 'api v3 path', '/news'
+ it_behaves_like "api v3 path", "/news"
end
- it_behaves_like 'show', :news
+ it_behaves_like "show", :news
end
- describe 'notifications paths' do
- it_behaves_like 'index', :notifications
- it_behaves_like 'show', :notification
+ describe "notifications paths" do
+ it_behaves_like "index", :notifications
+ it_behaves_like "show", :notification
- describe '#notification_bulk_read_ian' do
+ describe "#notification_bulk_read_ian" do
subject { helper.notification_bulk_read_ian }
- it_behaves_like 'api v3 path', '/notifications/read_ian'
+ it_behaves_like "api v3 path", "/notifications/read_ian"
end
- describe '#notification_bulk_unread_ian' do
+ describe "#notification_bulk_unread_ian" do
subject { helper.notification_bulk_unread_ian }
- it_behaves_like 'api v3 path', '/notifications/unread_ian'
+ it_behaves_like "api v3 path", "/notifications/unread_ian"
end
- describe '#notification_read_ian' do
+ describe "#notification_read_ian" do
subject { helper.notification_read_ian(42) }
- it_behaves_like 'api v3 path', '/notifications/42/read_ian'
+ it_behaves_like "api v3 path", "/notifications/42/read_ian"
end
- describe '#notification_unread_ian' do
+ describe "#notification_unread_ian" do
subject { helper.notification_unread_ian(42) }
- it_behaves_like 'api v3 path', '/notifications/42/unread_ian'
+ it_behaves_like "api v3 path", "/notifications/42/unread_ian"
end
- describe '#notification_detail' do
+ describe "#notification_detail" do
subject { helper.notification_detail(42, 0) }
- it_behaves_like 'api v3 path', '/notifications/42/details/0'
+ it_behaves_like "api v3 path", "/notifications/42/details/0"
end
end
- describe 'markup paths' do
- describe '#render_markup' do
- subject { helper.render_markup(link: 'link-ish') }
+ describe "markup paths" do
+ describe "#render_markup" do
+ subject { helper.render_markup(link: "link-ish") }
- it_behaves_like 'api v3 path', '/render/markdown?context=link-ish'
+ it_behaves_like "api v3 path", "/render/markdown?context=link-ish"
- context 'no link given' do
+ context "no link given" do
subject { helper.render_markup }
- it { is_expected.to eql('/api/v3/render/markdown') }
+ it { is_expected.to eql("/api/v3/render/markdown") }
end
end
end
- describe 'placeholder_users path' do
- it_behaves_like 'index', :placeholder_user
- it_behaves_like 'show', :placeholder_user
+ describe "placeholder_users path" do
+ it_behaves_like "index", :placeholder_user
+ it_behaves_like "show", :placeholder_user
end
- describe 'posts paths' do
- it_behaves_like 'index', :post
- it_behaves_like 'show', :post
+ describe "posts paths" do
+ it_behaves_like "index", :post
+ it_behaves_like "show", :post
end
- describe 'principals paths' do
- it_behaves_like 'index', :principals
+ describe "principals paths" do
+ it_behaves_like "index", :principals
end
- describe 'priorities paths' do
- it_behaves_like 'index', :priority
- it_behaves_like 'show', :priority
+ describe "priorities paths" do
+ it_behaves_like "index", :priority
+ it_behaves_like "show", :priority
end
- describe 'projects paths' do
- it_behaves_like 'resource', :project
+ describe "projects paths" do
+ it_behaves_like "resource", :project
- describe '#projects_available_parents' do
+ describe "#projects_available_parents" do
subject { helper.projects_available_parents }
- it_behaves_like 'api v3 path', '/projects/available_parent_projects'
+ it_behaves_like "api v3 path", "/projects/available_parent_projects"
end
end
- describe 'project status paths' do
- it_behaves_like 'show', :project_status
+ describe "project status paths" do
+ it_behaves_like "show", :project_status
end
- describe 'query paths' do
- it_behaves_like 'resource', :query
+ describe "query paths" do
+ it_behaves_like "resource", :query
- describe '#query_default' do
+ describe "#query_default" do
subject { helper.query_default }
- it_behaves_like 'api v3 path', '/queries/default'
+ it_behaves_like "api v3 path", "/queries/default"
end
- describe '#query_project_default' do
+ describe "#query_project_default" do
subject { helper.query_project_default(42) }
- it_behaves_like 'api v3 path', '/projects/42/queries/default'
+ it_behaves_like "api v3 path", "/projects/42/queries/default"
end
- describe '#query_star' do
+ describe "#query_star" do
subject { helper.query_star 1 }
- it_behaves_like 'api v3 path', '/queries/1/star'
+ it_behaves_like "api v3 path", "/queries/1/star"
end
- describe '#query_unstar' do
+ describe "#query_unstar" do
subject { helper.query_unstar 1 }
- it_behaves_like 'api v3 path', '/queries/1/unstar'
+ it_behaves_like "api v3 path", "/queries/1/unstar"
end
- describe '#query_column' do
- subject { helper.query_column 'updated_at' }
+ describe "#query_column" do
+ subject { helper.query_column "updated_at" }
- it_behaves_like 'api v3 path', '/queries/columns/updated_at'
+ it_behaves_like "api v3 path", "/queries/columns/updated_at"
end
- describe '#query_group_by' do
- subject { helper.query_group_by 'status' }
+ describe "#query_group_by" do
+ subject { helper.query_group_by "status" }
- it_behaves_like 'api v3 path', '/queries/group_bys/status'
+ it_behaves_like "api v3 path", "/queries/group_bys/status"
end
- describe '#query_sort_by' do
- subject { helper.query_sort_by 'status', 'desc' }
+ describe "#query_sort_by" do
+ subject { helper.query_sort_by "status", "desc" }
- it_behaves_like 'api v3 path', '/queries/sort_bys/status-desc'
+ it_behaves_like "api v3 path", "/queries/sort_bys/status-desc"
end
- describe '#query_filter' do
- subject { helper.query_filter 'status' }
+ describe "#query_filter" do
+ subject { helper.query_filter "status" }
- it_behaves_like 'api v3 path', '/queries/filters/status'
+ it_behaves_like "api v3 path", "/queries/filters/status"
end
- describe '#query_filter_instance_schemas' do
+ describe "#query_filter_instance_schemas" do
subject { helper.query_filter_instance_schemas }
- it_behaves_like 'api v3 path', '/queries/filter_instance_schemas'
+ it_behaves_like "api v3 path", "/queries/filter_instance_schemas"
end
- describe '#query_filter_instance_schema' do
- subject { helper.query_filter_instance_schema('bogus') }
+ describe "#query_filter_instance_schema" do
+ subject { helper.query_filter_instance_schema("bogus") }
- it_behaves_like 'api v3 path', '/queries/filter_instance_schemas/bogus'
+ it_behaves_like "api v3 path", "/queries/filter_instance_schemas/bogus"
end
- describe '#query_project_form' do
+ describe "#query_project_form" do
subject { helper.query_project_form(42) }
- it_behaves_like 'api v3 path', '/projects/42/queries/form'
+ it_behaves_like "api v3 path", "/projects/42/queries/form"
end
- describe '#query_project_filter_instance_schemas' do
+ describe "#query_project_filter_instance_schemas" do
subject { helper.query_project_filter_instance_schemas(42) }
- it_behaves_like 'api v3 path', '/projects/42/queries/filter_instance_schemas'
+ it_behaves_like "api v3 path", "/projects/42/queries/filter_instance_schemas"
end
- describe '#query_operator' do
- subject { helper.query_operator '=' }
+ describe "#query_operator" do
+ subject { helper.query_operator "=" }
- it_behaves_like 'api v3 path', '/queries/operators/='
+ it_behaves_like "api v3 path", "/queries/operators/="
end
- describe '#query_project_schema' do
- subject { helper.query_project_schema('42') }
+ describe "#query_project_schema" do
+ subject { helper.query_project_schema("42") }
- it_behaves_like 'api v3 path', '/projects/42/queries/schema'
+ it_behaves_like "api v3 path", "/projects/42/queries/schema"
end
- describe '#query_available_projects' do
+ describe "#query_available_projects" do
subject { helper.query_available_projects }
- it_behaves_like 'api v3 path', '/queries/available_projects'
+ it_behaves_like "api v3 path", "/queries/available_projects"
end
end
- describe 'relations paths' do
- it_behaves_like 'index', :relation
- it_behaves_like 'show', :relation
+ describe "relations paths" do
+ it_behaves_like "index", :relation
+ it_behaves_like "show", :relation
end
- describe 'revisions paths' do
- it_behaves_like 'show', :revision
+ describe "revisions paths" do
+ it_behaves_like "show", :revision
- describe '#show_revision' do
- subject { helper.show_revision 'foo', 1234 }
+ describe "#show_revision" do
+ subject { helper.show_revision "foo", 1234 }
- it_behaves_like 'path', '/projects/foo/repository/revision/1234'
+ it_behaves_like "path", "/projects/foo/repository/revision/1234"
end
end
- describe 'roles paths' do
- it_behaves_like 'index', :role
- it_behaves_like 'show', :role
+ describe "roles paths" do
+ it_behaves_like "index", :role
+ it_behaves_like "show", :role
end
- describe 'statuses paths' do
- it_behaves_like 'index', :status
- it_behaves_like 'show', :status
+ describe "statuses paths" do
+ it_behaves_like "index", :status
+ it_behaves_like "show", :status
end
- describe 'grids paths' do
- it_behaves_like 'resource', :grid
+ describe "grids paths" do
+ it_behaves_like "resource", :grid
end
- describe 'string object paths' do
- describe '#string_object' do
- subject { helper.string_object 'foo' }
+ describe "string object paths" do
+ describe "#string_object" do
+ subject { helper.string_object "foo" }
- it_behaves_like 'api v3 path', '/string_objects?value=foo'
+ it_behaves_like "api v3 path", "/string_objects?value=foo"
- it 'escapes correctly' do
- value = 'foo/bar baz'
- expect(helper.string_object(value)).to eql('/api/v3/string_objects?value=foo%2Fbar%20baz')
+ it "escapes correctly" do
+ value = "foo/bar baz"
+ expect(helper.string_object(value)).to eql("/api/v3/string_objects?value=foo%2Fbar%20baz")
end
end
end
- context 'status paths' do
- it_behaves_like 'show', :status
+ context "status paths" do
+ it_behaves_like "show", :status
end
- context 'time_entry paths' do
- it_behaves_like 'resource', :time_entry
+ context "time_entry paths" do
+ it_behaves_like "resource", :time_entry
- describe '#time_entries_activity' do
+ describe "#time_entries_activity" do
subject { helper.time_entries_activity 42 }
- it_behaves_like 'api v3 path', '/time_entries/activities/42'
+ it_behaves_like "api v3 path", "/time_entries/activities/42"
end
- describe '#time_entries_available_projects' do
+ describe "#time_entries_available_projects" do
subject { helper.time_entries_available_projects }
- it_behaves_like 'api v3 path', '/time_entries/available_projects'
+ it_behaves_like "api v3 path", "/time_entries/available_projects"
end
end
- describe 'types paths' do
- it_behaves_like 'index', :type
- it_behaves_like 'show', :type
+ describe "types paths" do
+ it_behaves_like "index", :type
+ it_behaves_like "show", :type
- describe '#types_by_project' do
+ describe "#types_by_project" do
subject { helper.types_by_project 12 }
- it_behaves_like 'api v3 path', '/projects/12/types'
+ it_behaves_like "api v3 path", "/projects/12/types"
end
end
- describe 'users paths' do
- it_behaves_like 'index', :user
- it_behaves_like 'show', :user
+ describe "users paths" do
+ it_behaves_like "index", :user
+ it_behaves_like "show", :user
end
- describe 'user_preferences path' do
+ describe "user_preferences path" do
subject { helper.user_preferences(42) }
- it_behaves_like 'api v3 path', '/users/42/preferences'
+ it_behaves_like "api v3 path", "/users/42/preferences"
end
- describe 'group paths' do
- it_behaves_like 'index', :group
- it_behaves_like 'show', :group
+ describe "group paths" do
+ it_behaves_like "index", :group
+ it_behaves_like "show", :group
end
- describe 'values paths' do
- describe '#values_schema' do
- subject { helper.value_schema('bogus_value') }
+ describe "values paths" do
+ describe "#values_schema" do
+ subject { helper.value_schema("bogus_value") }
- it_behaves_like 'api v3 path', '/values/schemas/bogus_value'
+ it_behaves_like "api v3 path", "/values/schemas/bogus_value"
end
end
- describe 'version paths' do
- it_behaves_like 'resource', :version
+ describe "version paths" do
+ it_behaves_like "resource", :version
- describe '#versions_available_projects' do
+ describe "#versions_available_projects" do
subject { helper.versions_available_projects }
- it_behaves_like 'api v3 path', '/versions/available_projects'
+ it_behaves_like "api v3 path", "/versions/available_projects"
end
- describe '#versions_by_project' do
+ describe "#versions_by_project" do
subject { helper.versions_by_project 42 }
- it_behaves_like 'api v3 path', '/projects/42/versions'
+ it_behaves_like "api v3 path", "/projects/42/versions"
end
- describe '#projects_by_version' do
+ describe "#projects_by_version" do
subject { helper.projects_by_version 42 }
- it_behaves_like 'api v3 path', '/versions/42/projects'
+ it_behaves_like "api v3 path", "/versions/42/projects"
end
end
- describe 'view paths' do
- it_behaves_like 'show', :view
- it_behaves_like 'index', :view
+ describe "view paths" do
+ it_behaves_like "show", :view
+ it_behaves_like "index", :view
- describe '#views_type' do
- subject { helper.views_type('work_packages_table') }
+ describe "#views_type" do
+ subject { helper.views_type("work_packages_table") }
- it_behaves_like 'api v3 path', '/views/work_packages_table'
+ it_behaves_like "api v3 path", "/views/work_packages_table"
end
end
- describe 'wiki pages paths' do
- it_behaves_like 'show', :wiki_page
+ describe "wiki pages paths" do
+ it_behaves_like "show", :wiki_page
end
- describe 'work packages paths' do
- it_behaves_like 'resource', :work_package, except: [:schema]
+ describe "work packages paths" do
+ it_behaves_like "resource", :work_package, except: [:schema]
# The simple case (with an id) is already covered by the 'it_behaves_like'
- describe '#work_package with an historic timestamp' do
+ describe "#work_package with an historic timestamp" do
subject { helper.work_package 42, timestamps: Timestamp.parse("2020-02-02T02:02:02Z") }
- it_behaves_like 'api v3 path', '/work_packages/42?timestamps=2020-02-02T02%3A02%3A02Z'
+ it_behaves_like "api v3 path", "/work_packages/42?timestamps=2020-02-02T02%3A02%3A02Z"
end
- describe '#work_package with a NOW timestamp' do
+ describe "#work_package with a NOW timestamp" do
subject { helper.work_package 42, timestamps: Timestamp.now }
- it_behaves_like 'api v3 path', '/work_packages/42'
+ it_behaves_like "api v3 path", "/work_packages/42"
end
- describe '#work_package_activities' do
+ describe "#work_package_activities" do
subject { helper.work_package_activities 42 }
- it_behaves_like 'api v3 path', '/work_packages/42/activities'
+ it_behaves_like "api v3 path", "/work_packages/42/activities"
end
- describe '#work_package_relations' do
+ describe "#work_package_relations" do
subject { helper.work_package_relations 42 }
- it_behaves_like 'api v3 path', '/work_packages/42/relations'
+ it_behaves_like "api v3 path", "/work_packages/42/relations"
end
- describe '#work_package_relation' do
+ describe "#work_package_relation" do
subject { helper.work_package_relation 1, 42 }
- it_behaves_like 'api v3 path', '/work_packages/42/relations/1'
+ it_behaves_like "api v3 path", "/work_packages/42/relations/1"
end
- describe '#work_package_revisions' do
+ describe "#work_package_revisions" do
subject { helper.work_package_revisions 42 }
- it_behaves_like 'api v3 path', '/work_packages/42/revisions'
+ it_behaves_like "api v3 path", "/work_packages/42/revisions"
end
- describe '#work_package_watchers' do
+ describe "#work_package_watchers" do
subject { helper.work_package_watchers 1 }
- it_behaves_like 'api v3 path', '/work_packages/1/watchers'
+ it_behaves_like "api v3 path", "/work_packages/1/watchers"
end
- describe '#work_packages_by_project' do
+ describe "#work_packages_by_project" do
subject { helper.work_packages_by_project 42 }
- it_behaves_like 'api v3 path', '/projects/42/work_packages'
+ it_behaves_like "api v3 path", "/projects/42/work_packages"
end
- describe '#create_project_work_package_form' do
+ describe "#create_project_work_package_form" do
subject { helper.create_project_work_package_form 42 }
- it_behaves_like 'api v3 path', '/projects/42/work_packages/form'
+ it_behaves_like "api v3 path", "/projects/42/work_packages/form"
end
- describe '#watcher' do
+ describe "#watcher" do
subject { helper.watcher 1, 42 }
- it_behaves_like 'api v3 path', '/work_packages/42/watchers/1'
+ it_behaves_like "api v3 path", "/work_packages/42/watchers/1"
end
- describe 'available ... paths' do
- describe '#available_assignees_in_project' do
+ describe "available ... paths" do
+ describe "#available_assignees_in_project" do
subject { helper.available_assignees_in_project 42 }
- it_behaves_like 'api v3 path', '/projects/42/available_assignees'
+ it_behaves_like "api v3 path", "/projects/42/available_assignees"
end
- describe '#available_assignees_in_work_package' do
+ describe "#available_assignees_in_work_package" do
subject { helper.available_assignees_in_work_package 42 }
- it_behaves_like 'api v3 path', '/work_packages/42/available_assignees'
+ it_behaves_like "api v3 path", "/work_packages/42/available_assignees"
end
- describe '#available_responsibles' do
+ describe "#available_responsibles" do
subject { helper.available_responsibles 42 }
- it_behaves_like 'api v3 path', '/projects/42/available_responsibles'
+ it_behaves_like "api v3 path", "/projects/42/available_responsibles"
end
- describe '#available_watchers' do
+ describe "#available_watchers" do
subject { helper.available_watchers 42 }
- it_behaves_like 'api v3 path', '/work_packages/42/available_watchers'
+ it_behaves_like "api v3 path", "/work_packages/42/available_watchers"
end
- describe '#available_projects_on_edit' do
+ describe "#available_projects_on_edit" do
subject { helper.available_projects_on_edit 42 }
- it_behaves_like 'api v3 path', '/work_packages/42/available_projects'
+ it_behaves_like "api v3 path", "/work_packages/42/available_projects"
end
- describe '#available_projects_on_create' do
+ describe "#available_projects_on_create" do
subject { helper.available_projects_on_create }
- it_behaves_like 'api v3 path', '/work_packages/available_projects'
+ it_behaves_like "api v3 path", "/work_packages/available_projects"
end
end
- describe 'schemas paths' do
- describe '#work_package_schema' do
+ describe "schemas paths" do
+ describe "#work_package_schema" do
subject { helper.work_package_schema 1, 2 }
- it_behaves_like 'api v3 path', '/work_packages/schemas/1-2'
+ it_behaves_like "api v3 path", "/work_packages/schemas/1-2"
end
- describe '#work_package_schemas' do
+ describe "#work_package_schemas" do
subject { helper.work_package_schemas }
- it_behaves_like 'api v3 path', '/work_packages/schemas'
+ it_behaves_like "api v3 path", "/work_packages/schemas"
end
- describe '#work_package_schemas with filters' do
+ describe "#work_package_schemas with filters" do
subject { helper.work_package_schemas [1, 2], [3, 4] }
def self.filter
- CGI.escape([{ id: { operator: '=', values: ['1-2', '3-4'] } }].to_s)
+ CGI.escape([{ id: { operator: "=", values: ["1-2", "3-4"] } }].to_s)
end
- it_behaves_like 'api v3 path',
+ it_behaves_like "api v3 path",
"/work_packages/schemas?filters=#{filter}"
end
- describe '#work_package_sums_schema' do
+ describe "#work_package_sums_schema" do
subject { helper.work_package_sums_schema }
- it_behaves_like 'api v3 path', '/work_packages/schemas/sums'
+ it_behaves_like "api v3 path", "/work_packages/schemas/sums"
end
end
end
- describe '.timestamps_to_param_value' do
+ describe ".timestamps_to_param_value" do
subject { helper.timestamps_to_param_value(timestamps) }
- context 'for a single relative iso8601 string' do
- let(:timestamps) { 'PT0S' }
+ context "for a single relative iso8601 string" do
+ let(:timestamps) { "PT0S" }
- it 'returns the value as an absolute value in ISO8601 format' do
+ it "returns the value as an absolute value in ISO8601 format" do
Timecop.freeze(Time.current) do
expect(subject)
.to eql Time.current.iso8601
@@ -676,19 +676,19 @@ def self.filter
end
end
- context 'for a single absolute iso8601 string' do
- let(:timestamps) { '2023-01-31T21:34:11Z' }
+ context "for a single absolute iso8601 string" do
+ let(:timestamps) { "2023-01-31T21:34:11Z" }
- it 'returns the value unchanged' do
+ it "returns the value unchanged" do
expect(subject)
.to eql timestamps
end
end
- context 'for a single timestamp (NOW)' do
+ context "for a single timestamp (NOW)" do
let(:timestamps) { Timestamp.now }
- it 'returns the value unchanged' do
+ it "returns the value unchanged" do
Timecop.freeze(Time.current) do
expect(subject)
.to eql Time.current.iso8601
@@ -696,10 +696,10 @@ def self.filter
end
end
- context 'for an array in different formats' do
- let(:timestamps) { ['2023-01-31T21:34:11Z', Timestamp.new('2022-04-30T21:34:11Z'), 'PT0S'] }
+ context "for an array in different formats" do
+ let(:timestamps) { ["2023-01-31T21:34:11Z", Timestamp.new("2022-04-30T21:34:11Z"), "PT0S"] }
- it 'returns the value unchanged' do
+ it "returns the value unchanged" do
Timecop.freeze(Time.current) do
expect(subject)
.to eql "2023-01-31T21:34:11Z,2022-04-30T21:34:11Z,#{Time.current.iso8601}"
diff --git a/spec/lib/api/v3/utilities/resource_link_generator_spec.rb b/spec/lib/api/v3/utilities/resource_link_generator_spec.rb
index f59a8f84e88c..2e612169a440 100644
--- a/spec/lib/api/v3/utilities/resource_link_generator_spec.rb
+++ b/spec/lib/api/v3/utilities/resource_link_generator_spec.rb
@@ -26,40 +26,40 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Utilities::ResourceLinkGenerator do
include API::V3::Utilities::PathHelper
subject { described_class }
- describe ':make_link' do
- it 'supports work packages' do
+ describe ":make_link" do
+ it "supports work packages" do
wp = build_stubbed(:work_package)
expect(subject.make_link(wp)).to eql api_v3_paths.work_package(wp.id)
end
- it 'supports priorities' do
+ it "supports priorities" do
prio = build_stubbed(:priority)
expect(subject.make_link(prio)).to eql api_v3_paths.priority(prio.id)
end
- it 'supports statuses' do
+ it "supports statuses" do
status = build_stubbed(:status)
expect(subject.make_link(status)).to eql api_v3_paths.status(status.id)
end
- it 'supports the anonymous user' do
+ it "supports the anonymous user" do
user = build_stubbed(:anonymous)
expect(subject.make_link(user)).to eql api_v3_paths.user(user.id)
end
- it 'returns nil for unsupported records' do
+ it "returns nil for unsupported records" do
record = create(:custom_field)
expect(subject.make_link(record)).to be_nil
end
- it 'returns nil for non-AR types' do
+ it "returns nil for non-AR types" do
record = Object.new
expect(subject.make_link(record)).to be_nil
end
diff --git a/spec/lib/api/v3/values/property_date_representer_rendering_spec.rb b/spec/lib/api/v3/values/property_date_representer_rendering_spec.rb
index da638f76193a..9141ade7c5a7 100644
--- a/spec/lib/api/v3/values/property_date_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/values/property_date_representer_rendering_spec.rb
@@ -26,56 +26,56 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Values::PropertyDateRepresenter, 'rendering' do
+RSpec.describe API::V3::Values::PropertyDateRepresenter, "rendering" do
subject(:generated) { representer.to_json }
- let(:property) { 'abc' }
+ let(:property) { "abc" }
let(:date_value) { Date.current }
let(:key_value) { Struct.new(:property, :value, keyword_init: true).new(property:, value: date_value) }
- let(:self_link) { 'api/bogus/value' }
+ let(:self_link) { "api/bogus/value" }
let(:representer) do
described_class.new key_value, self_link:
end
- describe 'self link' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ describe "self link" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { self_link }
end
end
- describe 'properties' do
- describe '_type' do
- it_behaves_like 'property', :_type do
- let(:value) { 'Values::Property' }
+ describe "properties" do
+ describe "_type" do
+ it_behaves_like "property", :_type do
+ let(:value) { "Values::Property" }
end
end
- describe 'property' do
- it_behaves_like 'property', :property do
+ describe "property" do
+ it_behaves_like "property", :property do
let(:value) { property }
end
- context 'with a snake_case property' do
- let(:property) { 'snake_case' }
+ context "with a snake_case property" do
+ let(:property) { "snake_case" }
- it_behaves_like 'property', :property do
- let(:value) { 'snakeCase' }
+ it_behaves_like "property", :property do
+ let(:value) { "snakeCase" }
end
end
end
- describe 'value' do
- it_behaves_like 'date property', :value do
+ describe "value" do
+ it_behaves_like "date property", :value do
let(:value) { date_value }
end
- context 'with an empty value' do
+ context "with an empty value" do
let(:date_value) { nil }
- it_behaves_like 'date property', :value do
+ it_behaves_like "date property", :value do
let(:value) { nil }
end
end
diff --git a/spec/lib/api/v3/values/schemas/property_schema_representer_rendering_spec.rb b/spec/lib/api/v3/values/schemas/property_schema_representer_rendering_spec.rb
index 25a406ddc37b..2d006d23ad86 100644
--- a/spec/lib/api/v3/values/schemas/property_schema_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/values/schemas/property_schema_representer_rendering_spec.rb
@@ -26,19 +26,19 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Values::Schemas::PropertySchemaRepresenter, 'rendering' do
+RSpec.describe API::V3::Values::Schemas::PropertySchemaRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
let(:current_user) { build_stubbed(:user) }
- let(:self_link) { '/a/self/link' }
+ let(:self_link) { "/a/self/link" }
let(:model) do
API::V3::Values::Schemas::Model
- .new('The start date to that object',
- 'ADate')
+ .new("The start date to that object",
+ "ADate")
end
let(:representer) do
@@ -49,29 +49,29 @@
subject(:generated) { representer.to_json }
- describe '_type' do
- it 'is indicated as Schema' do
+ describe "_type" do
+ it "is indicated as Schema" do
expect(subject)
- .to be_json_eql('Schema'.to_json)
- .at_path('_type')
+ .to be_json_eql("Schema".to_json)
+ .at_path("_type")
end
end
- describe 'property' do
- let(:path) { 'property' }
+ describe "property" do
+ let(:path) { "property" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'String' }
- let(:name) { I18n.t(:'api_v3.attributes.property') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "String" }
+ let(:name) { I18n.t(:"api_v3.attributes.property") }
let(:required) { true }
let(:writable) { false }
end
end
- describe 'value' do
- let(:path) { 'value' }
+ describe "value" do
+ let(:path) { "value" }
- it_behaves_like 'has basic schema properties' do
+ it_behaves_like "has basic schema properties" do
let(:type) { model.type }
let(:name) { model.name }
let(:required) { true }
@@ -79,10 +79,10 @@
end
end
- describe '_links' do
- describe 'self' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ describe "self" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { self_link }
end
end
diff --git a/spec/lib/api/v3/values/schemas/value_schema_factory_spec.rb b/spec/lib/api/v3/values/schemas/value_schema_factory_spec.rb
index 1672fd93b7c6..0ffdaef94346 100644
--- a/spec/lib/api/v3/values/schemas/value_schema_factory_spec.rb
+++ b/spec/lib/api/v3/values/schemas/value_schema_factory_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Values::Schemas::ValueSchemaFactory do
include API::V3::Utilities::PathHelper
- describe '.for' do
+ describe ".for" do
let!(:representer_instance) do
instance_double(API::V3::Values::Schemas::PropertySchemaRepresenter)
end
@@ -41,67 +41,67 @@
.and_return(representer_instance)
end
- context 'for the start_date property' do
- let(:property) { 'start_date' }
+ context "for the start_date property" do
+ let(:property) { "start_date" }
- it 'returns a schema representer' do
+ it "returns a schema representer" do
expect(described_class.for(property))
.to eq representer_instance
end
- it 'instantiates the representer with the proper params' do
+ it "instantiates the representer with the proper params" do
described_class.for(property)
expect(API::V3::Values::Schemas::PropertySchemaRepresenter)
.to have_received(:new)
- .with(API::V3::Values::Schemas::Model.new(I18n.t('attributes.start_date'), 'Date'),
+ .with(API::V3::Values::Schemas::Model.new(I18n.t("attributes.start_date"), "Date"),
current_user: nil,
self_link: api_v3_paths.value_schema(property.camelcase(:lower)))
end
end
- context 'for the due_date property' do
- let(:property) { 'due_date' }
+ context "for the due_date property" do
+ let(:property) { "due_date" }
- it 'returns a schema representer' do
+ it "returns a schema representer" do
expect(described_class.for(property))
.to eq representer_instance
end
- it 'instantiates the representer with the proper params' do
+ it "instantiates the representer with the proper params" do
described_class.for(property)
expect(API::V3::Values::Schemas::PropertySchemaRepresenter)
.to have_received(:new)
- .with(API::V3::Values::Schemas::Model.new(I18n.t('attributes.due_date'), 'Date'),
+ .with(API::V3::Values::Schemas::Model.new(I18n.t("attributes.due_date"), "Date"),
current_user: nil,
self_link: api_v3_paths.value_schema(property.camelcase(:lower)))
end
end
- context 'for the date property (for milestones)' do
- let(:property) { 'date' }
+ context "for the date property (for milestones)" do
+ let(:property) { "date" }
- it 'returns a schema representer' do
+ it "returns a schema representer" do
expect(described_class.for(property))
.to eq representer_instance
end
- it 'instantiates the representer with the proper params' do
+ it "instantiates the representer with the proper params" do
described_class.for(property)
expect(API::V3::Values::Schemas::PropertySchemaRepresenter)
.to have_received(:new)
- .with(API::V3::Values::Schemas::Model.new(I18n.t('attributes.date'), 'Date'),
+ .with(API::V3::Values::Schemas::Model.new(I18n.t("attributes.date"), "Date"),
current_user: nil,
self_link: api_v3_paths.value_schema(property.camelcase(:lower)))
end
end
- context 'for another property' do
- let(:property) { 'bogus' }
+ context "for another property" do
+ let(:property) { "bogus" }
- it 'returns nil' do
+ it "returns nil" do
expect(described_class.for(property))
.to be_nil
end
diff --git a/spec/lib/api/v3/versions/schemas/version_schema_representer_spec.rb b/spec/lib/api/v3/versions/schemas/version_schema_representer_spec.rb
index 5fe277f2959f..2c2fbaea7696 100644
--- a/spec/lib/api/v3/versions/schemas/version_schema_representer_spec.rb
+++ b/spec/lib/api/v3/versions/schemas/version_schema_representer_spec.rb
@@ -26,14 +26,14 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Versions::Schemas::VersionSchemaRepresenter do
include API::V3::Utilities::PathHelper
let(:current_user) { build_stubbed(:user) }
- let(:self_link) { '/a/self/link' }
+ let(:self_link) { "/a/self/link" }
let(:embedded) { true }
let(:new_record) { true }
let(:allowed_sharings) { %w(tree system) }
@@ -53,7 +53,7 @@
writable = %w(name description start_date due_date status sharing)
if new_record
- writable << 'project'
+ writable << "project"
end
writable.include?(attribute.to_s)
@@ -82,173 +82,173 @@
current_user:)
end
- context 'generation' do
+ context "generation" do
subject(:generated) { representer.to_json }
- describe '_type' do
- it 'is indicated as Schema' do
- expect(subject).to be_json_eql('Schema'.to_json).at_path('_type')
+ describe "_type" do
+ it "is indicated as Schema" do
+ expect(subject).to be_json_eql("Schema".to_json).at_path("_type")
end
end
- describe 'id' do
- let(:path) { 'id' }
+ describe "id" do
+ let(:path) { "id" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Integer' }
- let(:name) { I18n.t('attributes.id') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Integer" }
+ let(:name) { I18n.t("attributes.id") }
let(:required) { true }
let(:writable) { false }
end
end
- describe 'createdAt' do
- let(:path) { 'createdAt' }
+ describe "createdAt" do
+ let(:path) { "createdAt" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'DateTime' }
- let(:name) { Version.human_attribute_name('created_at') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "DateTime" }
+ let(:name) { Version.human_attribute_name("created_at") }
let(:required) { true }
let(:writable) { false }
end
end
- describe 'updatedAt' do
- let(:path) { 'updatedAt' }
+ describe "updatedAt" do
+ let(:path) { "updatedAt" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'DateTime' }
- let(:name) { Version.human_attribute_name('updated_at') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "DateTime" }
+ let(:name) { Version.human_attribute_name("updated_at") }
let(:required) { true }
let(:writable) { false }
end
end
- describe 'name' do
- let(:path) { 'name' }
+ describe "name" do
+ let(:path) { "name" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'String' }
- let(:name) { Version.human_attribute_name('name') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "String" }
+ let(:name) { Version.human_attribute_name("name") }
let(:required) { true }
let(:writable) { true }
end
- it_behaves_like 'indicates length requirements' do
+ it_behaves_like "indicates length requirements" do
let(:min_length) { 1 }
let(:max_length) { 60 }
end
end
- describe 'description' do
- let(:path) { 'description' }
+ describe "description" do
+ let(:path) { "description" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Formattable' }
- let(:name) { Version.human_attribute_name('description') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Formattable" }
+ let(:name) { Version.human_attribute_name("description") }
let(:required) { false }
let(:writable) { true }
end
end
- describe 'int custom field' do
+ describe "int custom field" do
let(:path) { custom_field.attribute_name(:camel_case) }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Integer' }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Integer" }
let(:name) { custom_field.name }
let(:required) { false }
let(:writable) { false }
end
end
- describe 'startDate' do
- let(:path) { 'startDate' }
+ describe "startDate" do
+ let(:path) { "startDate" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Date' }
- let(:name) { Version.human_attribute_name('start_date') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Date" }
+ let(:name) { Version.human_attribute_name("start_date") }
let(:required) { false }
let(:writable) { true }
end
end
- describe 'endDate' do
- let(:path) { 'endDate' }
+ describe "endDate" do
+ let(:path) { "endDate" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Date' }
- let(:name) { Version.human_attribute_name('due_date') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Date" }
+ let(:name) { Version.human_attribute_name("due_date") }
let(:required) { false }
let(:writable) { true }
end
end
- describe 'definingProject' do
- let(:path) { 'definingProject' }
+ describe "definingProject" do
+ let(:path) { "definingProject" }
- context 'if having a new record' do
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Project' }
- let(:name) { Version.human_attribute_name('project') }
+ context "if having a new record" do
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Project" }
+ let(:name) { Version.human_attribute_name("project") }
let(:required) { true }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- context 'if embedding' do
+ context "if embedding" do
let(:embedded) { true }
- it_behaves_like 'links to allowed values via collection link' do
+ it_behaves_like "links to allowed values via collection link" do
let(:href) do
api_v3_paths.versions_available_projects
end
end
end
- context 'if not embedding' do
+ context "if not embedding" do
let(:embedded) { false }
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
end
end
- context 'if having a persisted record' do
+ context "if having a persisted record" do
let(:new_record) { false }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'Project' }
- let(:name) { Version.human_attribute_name('project') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "Project" }
+ let(:name) { Version.human_attribute_name("project") }
let(:required) { true }
let(:writable) { false }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- context 'if embedding' do
+ context "if embedding" do
let(:embedded) { true }
- it_behaves_like 'does not link to allowed values'
+ it_behaves_like "does not link to allowed values"
end
end
end
- describe 'status' do
- let(:path) { 'status' }
+ describe "status" do
+ let(:path) { "status" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'String' }
- let(:name) { Version.human_attribute_name('status') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "String" }
+ let(:name) { Version.human_attribute_name("status") }
let(:required) { true }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- it 'contains no link to the allowed values' do
+ it "contains no link to the allowed values" do
expect(subject)
.not_to have_json_path("#{path}/_links/allowedValues")
end
- it 'embeds the allowed values' do
+ it "embeds the allowed values" do
allowed_path = "#{path}/_embedded/allowedValues"
expect(subject)
@@ -257,23 +257,23 @@
end
end
- describe 'sharing' do
- let(:path) { 'sharing' }
+ describe "sharing" do
+ let(:path) { "sharing" }
- it_behaves_like 'has basic schema properties' do
- let(:type) { 'String' }
- let(:name) { Version.human_attribute_name('sharing') }
+ it_behaves_like "has basic schema properties" do
+ let(:type) { "String" }
+ let(:name) { Version.human_attribute_name("sharing") }
let(:required) { true }
let(:writable) { true }
- let(:location) { '_links' }
+ let(:location) { "_links" }
end
- it 'contains no link to the allowed values' do
+ it "contains no link to the allowed values" do
expect(subject)
.not_to have_json_path("#{path}/_links/allowedValues")
end
- it 'embeds the allowed values' do
+ it "embeds the allowed values" do
allowed_path = "#{path}/_embedded/allowedValues"
expect(subject)
@@ -282,18 +282,18 @@
end
end
- context '_links' do
- describe 'self link' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ context "_links" do
+ describe "self link" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { self_link }
end
- context 'embedded in a form' do
+ context "embedded in a form" do
let(:self_link) { nil }
- it_behaves_like 'has no link' do
- let(:link) { 'self' }
+ it_behaves_like "has no link" do
+ let(:link) { "self" }
end
end
end
diff --git a/spec/lib/api/v3/versions/version_collection_representer_spec.rb b/spec/lib/api/v3/versions/version_collection_representer_spec.rb
index 95cbbd571522..52b4c69e8ecd 100644
--- a/spec/lib/api/v3/versions/version_collection_representer_spec.rb
+++ b/spec/lib/api/v3/versions/version_collection_representer_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::Versions::VersionCollectionRepresenter do
- let(:self_link) { '/api/v3/projects/1/versions' }
+ let(:self_link) { "/api/v3/projects/1/versions" }
let(:versions) { build_stubbed_list(:version, 3) }
let(:user) { build_stubbed(:user) }
let(:representer) { described_class.new(versions, self_link:, current_user: user) }
@@ -37,48 +37,48 @@
include API::V3::Utilities::PathHelper
- context 'generation' do
+ context "generation" do
subject(:collection) { representer.to_json }
- it_behaves_like 'unpaginated APIv3 collection', 3, 'projects/1/versions', 'Version'
+ it_behaves_like "unpaginated APIv3 collection", 3, "projects/1/versions", "Version"
- context '_links' do
+ context "_links" do
before do
mock_permissions_for(user) do |mock|
mock.allow_in_project *permissions, project: build_stubbed(:project) # any project
end
end
- describe 'createVersionImmediately' do
- context 'if the user is allowed to' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'createVersionImmediately' }
+ describe "createVersionImmediately" do
+ context "if the user is allowed to" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "createVersionImmediately" }
let(:href) { api_v3_paths.versions }
end
end
- context 'if the user is not allowed to' do
+ context "if the user is not allowed to" do
let(:permissions) { [] }
- it_behaves_like 'has no link' do
- let(:link) { 'createVersionImmediately' }
+ it_behaves_like "has no link" do
+ let(:link) { "createVersionImmediately" }
end
end
end
- describe 'createVersion' do
- context 'if the user is allowed to' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'createVersion' }
+ describe "createVersion" do
+ context "if the user is allowed to" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "createVersion" }
let(:href) { api_v3_paths.create_version_form }
end
end
- context 'if the user is not allowed to' do
+ context "if the user is not allowed to" do
let(:permissions) { [] }
- it_behaves_like 'has no link' do
- let(:link) { 'createVersion' }
+ it_behaves_like "has no link" do
+ let(:link) { "createVersion" }
end
end
end
diff --git a/spec/lib/api/v3/versions/version_representer_rendering_spec.rb b/spec/lib/api/v3/versions/version_representer_rendering_spec.rb
index 9e47139f6116..486a47816a2b 100644
--- a/spec/lib/api/v3/versions/version_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/versions/version_representer_rendering_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Versions::VersionRepresenter, 'rendering' do
+RSpec.describe API::V3::Versions::VersionRepresenter, "rendering" do
let(:version) { build_stubbed(:version) }
let(:permissions) { [:manage_versions] }
let(:user) { build_stubbed(:user) }
@@ -44,95 +44,95 @@
end
end
- it { is_expected.to include_json('Version'.to_json).at_path('_type') }
+ it { is_expected.to include_json("Version".to_json).at_path("_type") }
- describe 'links' do
- it { is_expected.to have_json_type(Object).at_path('_links') }
+ describe "links" do
+ it { is_expected.to have_json_type(Object).at_path("_links") }
- describe 'to self' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "to self" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.version(version.id) }
let(:title) { version.name }
end
end
- describe 'to schema' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'schema' }
+ describe "to schema" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "schema" }
let(:href) { api_v3_paths.version_schema }
end
end
- describe 'to update' do
- context 'if manage versions permissions are granted' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'update' }
+ describe "to update" do
+ context "if manage versions permissions are granted" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "update" }
let(:href) { api_v3_paths.version_form(version.id) }
end
end
- describe 'if manage versions permissions are lacking' do
+ describe "if manage versions permissions are lacking" do
let(:permissions) { [] }
- it_behaves_like 'has no link' do
- let(:link) { 'update' }
+ it_behaves_like "has no link" do
+ let(:link) { "update" }
end
end
end
- describe 'to updateImmediately' do
- context 'if manage versions permissions are granted' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'updateImmediately' }
+ describe "to updateImmediately" do
+ context "if manage versions permissions are granted" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "updateImmediately" }
let(:href) { api_v3_paths.version(version.id) }
end
end
- describe 'if manage versions permissions are lacking' do
+ describe "if manage versions permissions are lacking" do
let(:permissions) { [] }
- it_behaves_like 'has no link' do
- let(:link) { 'updateImmediately' }
+ it_behaves_like "has no link" do
+ let(:link) { "updateImmediately" }
end
end
end
- describe 'to the defining project' do
- context 'if the user has the permission to see the project' do
+ describe "to the defining project" do
+ context "if the user has the permission to see the project" do
before do
allow(version.project).to receive(:visible?).with(user).and_return(true)
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'definingProject' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "definingProject" }
let(:href) { api_v3_paths.project(version.project.id) }
let(:title) { version.project.name }
end
end
- context 'if the user lacks the permission to see the project' do
+ context "if the user lacks the permission to see the project" do
before do
allow(version.project).to receive(:visible?).with(user).and_return(false)
end
- it_behaves_like 'has no link' do
- let(:link) { 'definingProject' }
+ it_behaves_like "has no link" do
+ let(:link) { "definingProject" }
end
end
end
- describe 'to available projects' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'availableInProjects' }
+ describe "to available projects" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "availableInProjects" }
let(:href) { api_v3_paths.projects_by_version(version.id) }
end
end
- context 'custom value' do
+ context "custom value" do
let(:custom_field) { build_stubbed(:version_custom_field, :list) }
let(:custom_value) do
- build_stubbed(:custom_value, custom_field:, value: '1')
+ build_stubbed(:custom_value, custom_field:, value: "1")
end
before do
@@ -154,52 +154,52 @@
end
end
- describe 'properties' do
- it { is_expected.to be_json_eql(version.id.to_json).at_path('id') }
- it { is_expected.to be_json_eql(version.name.to_json).at_path('name') }
+ describe "properties" do
+ it { is_expected.to be_json_eql(version.id.to_json).at_path("id") }
+ it { is_expected.to be_json_eql(version.name.to_json).at_path("name") }
- it_behaves_like 'API V3 formattable', 'description' do
- let(:format) { 'plain' }
+ it_behaves_like "API V3 formattable", "description" do
+ let(:format) { "plain" }
let(:raw) { version.description }
end
- it_behaves_like 'has ISO 8601 date only' do
+ it_behaves_like "has ISO 8601 date only" do
let(:date) { version.start_date }
- let(:json_path) { 'startDate' }
+ let(:json_path) { "startDate" }
end
- it_behaves_like 'has ISO 8601 date only' do
+ it_behaves_like "has ISO 8601 date only" do
let(:date) { version.due_date }
- let(:json_path) { 'endDate' }
+ let(:json_path) { "endDate" }
end
- it 'has a status' do
+ it "has a status" do
expect(subject)
.to be_json_eql(version.status.to_json)
- .at_path('status')
+ .at_path("status")
end
- it 'has a sharing' do
+ it "has a sharing" do
expect(subject)
.to be_json_eql(version.sharing.to_json)
- .at_path('sharing')
+ .at_path("sharing")
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { version.created_at }
- let(:json_path) { 'createdAt' }
+ let(:json_path) { "createdAt" }
end
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { version.updated_at }
- let(:json_path) { 'updatedAt' }
+ let(:json_path) { "updatedAt" }
end
- context 'custom value' do
+ context "custom value" do
let(:custom_field) { build_stubbed(:version_custom_field) }
let(:custom_value) do
CustomValue.new(custom_field:,
- value: '1234',
+ value: "1234",
customized: version)
end
@@ -227,8 +227,8 @@
end
end
- describe 'caching' do
- it 'is based on the representer\'s cache_key' do
+ describe "caching" do
+ it "is based on the representer's cache_key" do
expect(OpenProject::Cache)
.to receive(:fetch)
.with(representer.json_cache_key)
@@ -237,36 +237,36 @@
representer.to_json
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let!(:former_cache_key) { representer.json_cache_key }
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'Versions', 'VersionRepresenter')
+ .to include("API", "V3", "Versions", "VersionRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
I18n.with_locale(:fr) do
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
end
- it 'changes when the version is updated' do
+ it "changes when the version is updated" do
version.updated_at = Time.now + 20.seconds
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
- it 'changes when the version\'s project is updated' do
+ it "changes when the version's project is updated" do
version.project.updated_at = Time.now + 20.seconds
expect(representer.json_cache_key)
.not_to eql former_cache_key
end
- context 'custom fields' do
+ context "custom fields" do
let(:version) do
build_stubbed(:version).tap do |_v|
# Use this to force the custom field to be defined before the former_cache_key is calculated
@@ -282,10 +282,10 @@
allow(version)
.to receive(custom_field.attribute_getter)
- .and_return('123')
+ .and_return("123")
end
- it 'changes when a custom field changes' do
+ it "changes when a custom field changes" do
custom_field.updated_at = Time.now + 20.seconds
expect(representer.json_cache_key)
diff --git a/spec/lib/api/v3/views/view_representer_rendering_spec.rb b/spec/lib/api/v3/views/view_representer_rendering_spec.rb
index 83709d38aed9..be2fc35945fc 100644
--- a/spec/lib/api/v3/views/view_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/views/view_representer_rendering_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::Views::ViewRepresenter, 'rendering' do
+RSpec.describe API::V3::Views::ViewRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
subject(:generated) { representer.to_json }
@@ -47,89 +47,89 @@
embed_links:
end
- describe 'properties' do
- describe '_type' do
- it_behaves_like 'property', :_type do
- let(:value) { 'Views::WorkPackagesTable' }
+ describe "properties" do
+ describe "_type" do
+ it_behaves_like "property", :_type do
+ let(:value) { "Views::WorkPackagesTable" }
end
end
- describe 'id' do
- it_behaves_like 'property', :id do
+ describe "id" do
+ it_behaves_like "property", :id do
let(:value) { view.id }
end
end
- describe 'public' do
- context 'with the query being public' do
- it_behaves_like 'property', :public do
+ describe "public" do
+ context "with the query being public" do
+ it_behaves_like "property", :public do
let(:value) { true }
end
end
- context 'with the query being private' do
+ context "with the query being private" do
let(:query_public) { false }
- it_behaves_like 'property', :public do
+ it_behaves_like "property", :public do
let(:value) { false }
end
end
end
- describe 'starred' do
- context 'with the query being starred' do
- it_behaves_like 'property', :starred do
+ describe "starred" do
+ context "with the query being starred" do
+ it_behaves_like "property", :starred do
let(:value) { true }
end
end
- context 'without the query being starred' do
+ context "without the query being starred" do
let(:query_starred) { false }
- it_behaves_like 'property', :starred do
+ it_behaves_like "property", :starred do
let(:value) { false }
end
end
end
- describe 'name' do
- context 'with the query being name' do
- it_behaves_like 'property', :name do
+ describe "name" do
+ context "with the query being name" do
+ it_behaves_like "property", :name do
let(:value) { query.name }
end
end
end
- describe 'timestamps' do
- it_behaves_like 'datetime property', :createdAt do
+ describe "timestamps" do
+ it_behaves_like "datetime property", :createdAt do
let(:value) { view.created_at }
end
- it_behaves_like 'datetime property', :updatedAt do
+ it_behaves_like "datetime property", :updatedAt do
let(:value) { view.updated_at }
end
end
end
- describe '_links' do
- describe 'self' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ describe "self" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.view view.id }
end
end
- describe 'query' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'query' }
+ describe "query" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "query" }
let(:href) { api_v3_paths.query query.id }
let(:title) { query.name }
end
end
- describe 'project' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'project' }
+ describe "project" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "project" }
let(:href) { api_v3_paths.project query.project_id }
let(:title) { query.project.name }
end
diff --git a/spec/lib/api/v3/wiki_pages/wiki_page_representer_rendering_spec.rb b/spec/lib/api/v3/wiki_pages/wiki_page_representer_rendering_spec.rb
index 7934983f299f..d9d3a00f21e7 100644
--- a/spec/lib/api/v3/wiki_pages/wiki_page_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/wiki_pages/wiki_page_representer_rendering_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::WikiPages::WikiPageRepresenter, 'rendering' do
+RSpec.describe API::V3::WikiPages::WikiPageRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
let(:wiki_page) do
@@ -46,24 +46,24 @@
subject { representer.to_json }
- describe '_links' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.wiki_page wiki_page.id }
end
- it_behaves_like 'has an untitled link' do
+ it_behaves_like "has an untitled link" do
let(:link) { :attachments }
let(:href) { api_v3_paths.attachments_by_wiki_page wiki_page.id }
end
- it_behaves_like 'has a titled link' do
+ it_behaves_like "has a titled link" do
let(:link) { :project }
let(:title) { project.name }
let(:href) { api_v3_paths.project project.id }
end
- it_behaves_like 'has an untitled action link' do
+ it_behaves_like "has an untitled action link" do
let(:link) { :addAttachment }
let(:href) { api_v3_paths.attachments_by_wiki_page wiki_page.id }
let(:method) { :post }
@@ -71,25 +71,25 @@
end
end
- describe 'properties' do
- it_behaves_like 'property', :_type do
- let(:value) { 'WikiPage' }
+ describe "properties" do
+ it_behaves_like "property", :_type do
+ let(:value) { "WikiPage" }
end
- it_behaves_like 'property', :id do
+ it_behaves_like "property", :id do
let(:value) { wiki_page.id }
end
- it_behaves_like 'property', :title do
+ it_behaves_like "property", :title do
let(:value) { wiki_page.title }
end
end
- describe '_embedded' do
- it 'has project embedded' do
+ describe "_embedded" do
+ it "has project embedded" do
expect(subject)
.to be_json_eql(project.name.to_json)
- .at_path('_embedded/project/name')
+ .at_path("_embedded/project/name")
end
end
end
diff --git a/spec/lib/api/v3/work_packages/create_form_representer_spec.rb b/spec/lib/api/v3/work_packages/create_form_representer_spec.rb
index 331e657b26ce..ced35654e028 100644
--- a/spec/lib/api/v3/work_packages/create_form_representer_spec.rb
+++ b/spec/lib/api/v3/work_packages/create_form_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++require 'rspec'
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::WorkPackages::CreateFormRepresenter do
include API::V3::Utilities::PathHelper
@@ -49,109 +49,109 @@
subject(:generated) { representer.to_json }
- describe '_links' do
- it 'links to the create form api' do
+ describe "_links" do
+ it "links to the create form api" do
expect(generated)
.to be_json_eql(api_v3_paths.create_work_package_form.to_json)
- .at_path('_links/self/href')
+ .at_path("_links/self/href")
end
- it 'is a post' do
+ it "is a post" do
expect(generated)
.to be_json_eql(:post.to_json)
- .at_path('_links/self/method')
+ .at_path("_links/self/method")
end
- describe 'validate' do
- it 'links to the create form api' do
+ describe "validate" do
+ it "links to the create form api" do
expect(generated)
.to be_json_eql(api_v3_paths.create_work_package_form.to_json)
- .at_path('_links/validate/href')
+ .at_path("_links/validate/href")
end
- it 'is a post' do
+ it "is a post" do
expect(generated)
.to be_json_eql(:post.to_json)
- .at_path('_links/validate/method')
+ .at_path("_links/validate/method")
end
end
- describe 'preview markup' do
- it 'links to the markup api' do
+ describe "preview markup" do
+ it "links to the markup api" do
path = api_v3_paths.render_markup(link: api_v3_paths.project(work_package.project_id))
expect(generated)
.to be_json_eql(path.to_json)
- .at_path('_links/previewMarkup/href')
+ .at_path("_links/previewMarkup/href")
end
- it 'is a post' do
+ it "is a post" do
expect(generated)
.to be_json_eql(:post.to_json)
- .at_path('_links/previewMarkup/method')
+ .at_path("_links/previewMarkup/method")
end
- it 'contains link to work package' do
+ it "contains link to work package" do
expected_preview_link =
api_v3_paths.render_markup(link: "/api/v3/projects/#{work_package.project_id}")
expect(subject)
.to be_json_eql(expected_preview_link.to_json)
- .at_path('_links/previewMarkup/href')
+ .at_path("_links/previewMarkup/href")
end
end
- describe 'commit' do
+ describe "commit" do
before do
mock_permissions_for(current_user) do |mock|
mock.allow_in_project :add_work_packages, project:
end
end
- context 'for a valid work package' do
- it 'links to the work package create api' do
+ context "for a valid work package" do
+ it "links to the work package create api" do
expect(generated)
.to be_json_eql(api_v3_paths.work_packages.to_json)
- .at_path('_links/commit/href')
+ .at_path("_links/commit/href")
end
- it 'is a post' do
+ it "is a post" do
expect(generated)
.to be_json_eql(:post.to_json)
- .at_path('_links/commit/method')
+ .at_path("_links/commit/method")
end
end
- context 'for an invalid work package' do
- let(:errors) { [API::Errors::Validation.new(:subject, 'it is broken')] }
+ context "for an invalid work package" do
+ let(:errors) { [API::Errors::Validation.new(:subject, "it is broken")] }
- it 'has no link' do
- expect(generated).not_to have_json_path('_links/commit/href')
+ it "has no link" do
+ expect(generated).not_to have_json_path("_links/commit/href")
end
end
- context 'for a user with insufficient permissions' do
+ context "for a user with insufficient permissions" do
before do
mock_permissions_for(current_user, &:forbid_everything)
end
- it 'has no link' do
- expect(generated).not_to have_json_path('_links/commit/href')
+ it "has no link" do
+ expect(generated).not_to have_json_path("_links/commit/href")
end
end
end
- describe 'customFields' do
+ describe "customFields" do
before do
mock_permissions_for(current_user, &:forbid_everything)
end
- context 'with the permission to select custom fields' do
+ context "with the permission to select custom fields" do
before do
mock_permissions_for(current_user) do |mock|
mock.allow_in_project :select_custom_fields, project:
end
end
- it 'has a link to set the custom fields for that project' do
+ it "has a link to set the custom fields for that project" do
expected = {
href: project_settings_custom_fields_path(work_package.project),
type: "text/html",
@@ -160,23 +160,23 @@
expect(generated)
.to be_json_eql(expected.to_json)
- .at_path('_links/customFields')
+ .at_path("_links/customFields")
end
end
- context 'without the permission to select custom fields' do
- it 'has no link to set the custom fields for that project' do
- expect(generated).not_to have_json_path('_links/customFields')
+ context "without the permission to select custom fields" do
+ it "has no link to set the custom fields for that project" do
+ expect(generated).not_to have_json_path("_links/customFields")
end
end
end
- describe 'configureForm' do
+ describe "configureForm" do
before do
mock_permissions_for(current_user, &:allow_everything)
end
- context 'for an admin and with type' do
+ context "for an admin and with type" do
let(:type) { build_stubbed(:type) }
let(:current_user) { build_stubbed(:admin) }
let(:work_package) do
@@ -187,7 +187,7 @@
type:)
end
- it 'has a link to configure the form' do
+ it "has a link to configure the form" do
expected = {
href: "/types/#{type.id}/edit?tab=form_configuration",
type: "text/html",
@@ -196,24 +196,24 @@
expect(generated)
.to be_json_eql(expected.to_json)
- .at_path('_links/configureForm')
+ .at_path("_links/configureForm")
end
end
- context 'for an admin and without type' do
+ context "for an admin and without type" do
before do
allow(work_package).to receive(:type).and_return(nil)
allow(work_package).to receive(:type_id).and_return(nil)
end
- it 'has no link to configure the form' do
- expect(generated).not_to have_json_path('_links/configureForm')
+ it "has no link to configure the form" do
+ expect(generated).not_to have_json_path("_links/configureForm")
end
end
- context 'for a nonadmin' do
- it 'has no link to configure the form' do
- expect(generated).not_to have_json_path('_links/configureForm')
+ context "for a nonadmin" do
+ it "has no link to configure the form" do
+ expect(generated).not_to have_json_path("_links/configureForm")
end
end
end
diff --git a/spec/lib/api/v3/work_packages/create_project_form_representer_spec.rb b/spec/lib/api/v3/work_packages/create_project_form_representer_spec.rb
index 38972e528dbe..a34da6d38309 100644
--- a/spec/lib/api/v3/work_packages/create_project_form_representer_spec.rb
+++ b/spec/lib/api/v3/work_packages/create_project_form_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++require 'rspec'
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::WorkPackages::CreateProjectFormRepresenter do
include API::V3::Utilities::PathHelper
@@ -53,89 +53,89 @@
subject(:generated) { representer.to_json }
- describe '_links' do
+ describe "_links" do
it do
expect(generated).to be_json_eql(
api_v3_paths.create_project_work_package_form(work_package.project_id).to_json
)
- .at_path('_links/self/href')
+ .at_path("_links/self/href")
end
it do
- expect(generated).to be_json_eql(:post.to_json).at_path('_links/self/method')
+ expect(generated).to be_json_eql(:post.to_json).at_path("_links/self/method")
end
- describe 'validate' do
+ describe "validate" do
it do
expect(generated).to be_json_eql(
api_v3_paths.create_project_work_package_form(work_package.project_id).to_json
)
- .at_path('_links/validate/href')
+ .at_path("_links/validate/href")
end
it do
- expect(generated).to be_json_eql(:post.to_json).at_path('_links/validate/method')
+ expect(generated).to be_json_eql(:post.to_json).at_path("_links/validate/method")
end
end
- describe 'preview markup' do
+ describe "preview markup" do
it do
expect(generated).to be_json_eql(
api_v3_paths.render_markup(
link: api_v3_paths.project(work_package.project_id)
).to_json
)
- .at_path('_links/previewMarkup/href')
+ .at_path("_links/previewMarkup/href")
end
it do
- expect(generated).to be_json_eql(:post.to_json).at_path('_links/previewMarkup/method')
+ expect(generated).to be_json_eql(:post.to_json).at_path("_links/previewMarkup/method")
end
- it 'contains link to work package' do
+ it "contains link to work package" do
expected_preview_link =
api_v3_paths.render_markup(link: "/api/v3/projects/#{work_package.project_id}")
expect(subject).to be_json_eql(expected_preview_link.to_json)
- .at_path('_links/previewMarkup/href')
+ .at_path("_links/previewMarkup/href")
end
end
- describe 'commit' do
- context 'with a valid work package' do
+ describe "commit" do
+ context "with a valid work package" do
it do
expect(generated).to be_json_eql(
api_v3_paths.work_packages_by_project(work_package.project_id).to_json
)
- .at_path('_links/commit/href')
+ .at_path("_links/commit/href")
end
it do
- expect(generated).to be_json_eql(:post.to_json).at_path('_links/commit/method')
+ expect(generated).to be_json_eql(:post.to_json).at_path("_links/commit/method")
end
end
- context 'with an invalid work package' do
- let(:errors) { [API::Errors::Validation.new(:subject, 'it is broken')] }
+ context "with an invalid work package" do
+ let(:errors) { [API::Errors::Validation.new(:subject, "it is broken")] }
it do
- expect(generated).not_to have_json_path('_links/commit/href')
+ expect(generated).not_to have_json_path("_links/commit/href")
end
end
- context 'with the user having insufficient permissions' do
+ context "with the user having insufficient permissions" do
let(:permissions) { [] }
it do
- expect(generated).not_to have_json_path('_links/commit/href')
+ expect(generated).not_to have_json_path("_links/commit/href")
end
end
end
- describe 'customFields' do
- context 'with the permission to select custom fields' do
+ describe "customFields" do
+ context "with the permission to select custom fields" do
let(:permissions) { [:select_custom_fields] }
- it 'has a link to set the custom fields for that project' do
+ it "has a link to set the custom fields for that project" do
expected = {
href: project_settings_custom_fields_path(work_package.project),
type: "text/html",
@@ -144,22 +144,22 @@
expect(generated)
.to be_json_eql(expected.to_json)
- .at_path('_links/customFields')
+ .at_path("_links/customFields")
end
end
- context 'without the permission to select custom fields' do
- it 'has no link to set the custom fields for that project' do
- expect(generated).not_to have_json_path('_links/customFields')
+ context "without the permission to select custom fields" do
+ it "has no link to set the custom fields for that project" do
+ expect(generated).not_to have_json_path("_links/customFields")
end
end
end
- describe 'configureForm' do
+ describe "configureForm" do
context "for an admin and with a type" do
let(:user) { build_stubbed(:user, admin: true) }
- it 'has a link to configure the form' do
+ it "has a link to configure the form" do
expected = {
href: "/types/#{type.id}/edit?tab=form_configuration",
type: "text/html",
@@ -168,23 +168,23 @@
expect(generated)
.to be_json_eql(expected.to_json)
- .at_path('_links/configureForm')
+ .at_path("_links/configureForm")
end
end
- context 'for an admin and without type' do
+ context "for an admin and without type" do
let(:type) { nil }
let(:user) { build_stubbed(:user, admin: true) }
- it 'has no link to configure the form' do
- expect(generated).not_to have_json_path('_links/configureForm')
+ it "has no link to configure the form" do
+ expect(generated).not_to have_json_path("_links/configureForm")
end
end
- context 'for a non admin' do
- it 'has no link to configure the form' do
- expect(generated).not_to have_json_path('_links/configureForm')
+ context "for a non admin" do
+ it "has no link to configure the form" do
+ expect(generated).not_to have_json_path("_links/configureForm")
end
end
end
diff --git a/spec/lib/api/v3/work_packages/eager_loading/cache_checksum_integration_spec.rb b/spec/lib/api/v3/work_packages/eager_loading/cache_checksum_integration_spec.rb
index f0ebbf238428..5519a7e381e7 100644
--- a/spec/lib/api/v3/work_packages/eager_loading/cache_checksum_integration_spec.rb
+++ b/spec/lib/api/v3/work_packages/eager_loading/cache_checksum_integration_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++require 'rspec'
-require 'spec_helper'
-require_relative 'eager_loading_mock_wrapper'
+require "spec_helper"
+require_relative "eager_loading_mock_wrapper"
RSpec.describe API::V3::WorkPackages::EagerLoading::Checksum do
let(:project) { create(:project) }
@@ -47,7 +47,7 @@
end
let!(:type) { work_package.type }
- describe '.apply' do
+ describe ".apply" do
let!(:orig_checksum) do
EagerLoadingMockWrapper
.wrap(described_class, [work_package])
@@ -62,7 +62,7 @@
.cache_checksum
end
- it 'produces a different checksum on changes to the status id' do
+ it "produces a different checksum on changes to the status id" do
new_status = create(:status)
WorkPackage.where(id: work_package.id).update_all(status_id: new_status.id)
@@ -71,70 +71,70 @@
.not_to eql orig_checksum
end
- it 'produces a different checksum on changes to the status' do
+ it "produces a different checksum on changes to the status" do
work_package.status.update_attribute(:updated_at, 10.seconds.from_now)
expect(new_checksum)
.not_to eql orig_checksum
end
- it 'produces a different checksum on changes to the author id' do
+ it "produces a different checksum on changes to the author id" do
WorkPackage.where(id: work_package.id).update_all(author_id: 0)
expect(new_checksum)
.not_to eql orig_checksum
end
- it 'produces a different checksum on changes to the author' do
+ it "produces a different checksum on changes to the author" do
work_package.author.update_attribute(:updated_at, 10.seconds.from_now)
expect(new_checksum)
.not_to eql orig_checksum
end
- it 'produces a different checksum on changes to the assigned_to id' do
+ it "produces a different checksum on changes to the assigned_to id" do
WorkPackage.where(id: work_package.id).update_all(assigned_to_id: 0)
expect(new_checksum)
.not_to eql orig_checksum
end
- it 'produces a different checksum on changes to the assigned_to' do
+ it "produces a different checksum on changes to the assigned_to" do
work_package.assigned_to.update_attribute(:updated_at, 10.seconds.from_now)
expect(new_checksum)
.not_to eql orig_checksum
end
- it 'produces a different checksum on changes to the responsible id' do
+ it "produces a different checksum on changes to the responsible id" do
WorkPackage.where(id: work_package.id).update_all(responsible_id: 0)
expect(new_checksum)
.not_to eql orig_checksum
end
- it 'produces a different checksum on changes to the responsible' do
+ it "produces a different checksum on changes to the responsible" do
work_package.responsible.update_attribute(:updated_at, 10.seconds.from_now)
expect(new_checksum)
.not_to eql orig_checksum
end
- it 'produces a different checksum on changes to the version id' do
+ it "produces a different checksum on changes to the version id" do
WorkPackage.where(id: work_package.id).update_all(version_id: 0)
expect(new_checksum)
.not_to eql orig_checksum
end
- it 'produces a different checksum on changes to the version' do
+ it "produces a different checksum on changes to the version" do
work_package.version.update_attribute(:updated_at, 10.seconds.from_now)
expect(new_checksum)
.not_to eql orig_checksum
end
- it 'produces a different checksum on changes to the type id' do
+ it "produces a different checksum on changes to the type id" do
new_type = create(:type)
WorkPackage.where(id: work_package.id).update_all(type_id: new_type.id)
@@ -142,49 +142,49 @@
.not_to eql orig_checksum
end
- it 'produces a different checksum on changes to the type' do
+ it "produces a different checksum on changes to the type" do
work_package.type.update_attribute(:updated_at, 10.seconds.from_now)
expect(new_checksum)
.not_to eql orig_checksum
end
- it 'produces a different checksum on changes to the priority id' do
+ it "produces a different checksum on changes to the priority id" do
WorkPackage.where(id: work_package.id).update_all(priority_id: 0)
expect(new_checksum)
.not_to eql orig_checksum
end
- it 'produces a different checksum on changes to the priority' do
+ it "produces a different checksum on changes to the priority" do
work_package.priority.update_attribute(:updated_at, 10.seconds.from_now)
expect(new_checksum)
.not_to eql orig_checksum
end
- it 'produces a different checksum on changes to the category id' do
+ it "produces a different checksum on changes to the category id" do
WorkPackage.where(id: work_package.id).update_all(category_id: 0)
expect(new_checksum)
.not_to eql orig_checksum
end
- it 'produces a different checksum on changes to the category' do
+ it "produces a different checksum on changes to the category" do
work_package.category.update_attribute(:updated_at, 10.seconds.from_now)
expect(new_checksum)
.not_to eql orig_checksum
end
- it 'produces a different checksum on changes to the budget id' do
+ it "produces a different checksum on changes to the budget id" do
WorkPackage.where(id: work_package.id).update_all(budget_id: 0)
expect(new_checksum)
.not_to eql orig_checksum
end
- it 'produces a different checksum on changes to the budget' do
+ it "produces a different checksum on changes to the budget" do
work_package.budget.update_attribute(:updated_at, 10.seconds.from_now)
expect(new_checksum)
diff --git a/spec/lib/api/v3/work_packages/eager_loading/cost_eager_loading_integration_spec.rb b/spec/lib/api/v3/work_packages/eager_loading/cost_eager_loading_integration_spec.rb
index e89e434aed63..6114d77c6bf4 100644
--- a/spec/lib/api/v3/work_packages/eager_loading/cost_eager_loading_integration_spec.rb
+++ b/spec/lib/api/v3/work_packages/eager_loading/cost_eager_loading_integration_spec.rb
@@ -26,9 +26,9 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::WorkPackages::WorkPackageEagerLoadingWrapper, 'cost eager loading', type: :model do
+RSpec.describe API::V3::WorkPackages::WorkPackageEagerLoadingWrapper, "cost eager loading", type: :model do
let(:project) do
work_package.project
end
@@ -105,15 +105,15 @@
time_entry2
end
- it 'correctly calculates spent time' do
+ it "correctly calculates spent time" do
expect(scope.to_a.first.hours).to eql time_entry1.hours + time_entry2.hours
end
- it 'correctly calculates labor costs' do
+ it "correctly calculates labor costs" do
expect(scope.first.labor_costs).to eql (user_rates.rate * (time_entry1.hours + time_entry2.hours)).to_f
end
- it 'correctly calculates material costs' do
+ it "correctly calculates material costs" do
expect(scope.first.material_costs).to eql (cost_entry1.costs + cost_entry2.costs).to_f
end
end
diff --git a/spec/lib/api/v3/work_packages/eager_loading/custom_actions_integration_spec.rb b/spec/lib/api/v3/work_packages/eager_loading/custom_actions_integration_spec.rb
index 1f888d132ff0..12b4cb180597 100644
--- a/spec/lib/api/v3/work_packages/eager_loading/custom_actions_integration_spec.rb
+++ b/spec/lib/api/v3/work_packages/eager_loading/custom_actions_integration_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++require 'rspec'
-require 'spec_helper'
-require_relative 'eager_loading_mock_wrapper'
+require "spec_helper"
+require_relative "eager_loading_mock_wrapper"
RSpec.describe API::V3::WorkPackages::EagerLoading::CustomAction do
let!(:work_package1) { create(:work_package) }
@@ -50,8 +50,8 @@
login_as(user)
end
- describe '.apply' do
- it 'preloads the correct custom_actions' do
+ describe ".apply" do
+ it "preloads the correct custom_actions" do
wrapped = EagerLoadingMockWrapper.wrap(described_class, [work_package1, work_package2])
expect(work_package1)
diff --git a/spec/lib/api/v3/work_packages/eager_loading/project_integration_spec.rb b/spec/lib/api/v3/work_packages/eager_loading/project_integration_spec.rb
index 0cd8c7814852..4953c0afd86b 100644
--- a/spec/lib/api/v3/work_packages/eager_loading/project_integration_spec.rb
+++ b/spec/lib/api/v3/work_packages/eager_loading/project_integration_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++require 'rspec'
-require 'spec_helper'
-require_relative 'eager_loading_mock_wrapper'
+require "spec_helper"
+require_relative "eager_loading_mock_wrapper"
RSpec.describe API::V3::WorkPackages::EagerLoading::Project do
let!(:parent_work_package1) { create(:work_package, project: parent_project) }
@@ -39,8 +39,8 @@
let!(:parent_project) { create(:project) }
let!(:child_project) { create(:project) }
- describe '.apply' do
- it 'preloads the projects of the work packages, their parents and children' do
+ describe ".apply" do
+ it "preloads the projects of the work packages, their parents and children" do
wrapped = EagerLoadingMockWrapper.wrap(described_class, [work_package1, work_package2])
wrapped.each do |w|
diff --git a/spec/lib/api/v3/work_packages/form_representer_spec.rb b/spec/lib/api/v3/work_packages/form_representer_spec.rb
index 3ee21d19a613..66edecbf4c68 100644
--- a/spec/lib/api/v3/work_packages/form_representer_spec.rb
+++ b/spec/lib/api/v3/work_packages/form_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::WorkPackages::FormRepresenter do
include API::V3::Utilities::PathHelper
@@ -45,19 +45,19 @@
described_class.new(work_package, current_user:, errors:)
end
- context 'generation' do
+ context "generation" do
subject(:generated) { representer.to_json }
- it { is_expected.to be_json_eql('Form'.to_json).at_path('_type') }
+ it { is_expected.to be_json_eql("Form".to_json).at_path("_type") }
- describe 'validation errors' do
- context 'w/o errors' do
- it { is_expected.to be_json_eql({}.to_json).at_path('_embedded/validationErrors') }
+ describe "validation errors" do
+ context "w/o errors" do
+ it { is_expected.to be_json_eql({}.to_json).at_path("_embedded/validationErrors") }
end
- context 'with errors' do
- let(:subject_error_message) { 'Subject can\'t be blank!' }
- let(:status_error_message) { 'Status can\'t be blank!' }
+ context "with errors" do
+ let(:subject_error_message) { "Subject can't be blank!" }
+ let(:status_error_message) { "Status can't be blank!" }
let(:errors) { [subject_error, status_error] }
let(:subject_error) { API::Errors::Validation.new(:subject, subject_error_message) }
let(:status_error) { API::Errors::Validation.new(:status, status_error_message) }
@@ -65,11 +65,11 @@
let(:api_status_error) { API::V3::Errors::ErrorRepresenter.new(status_error) }
let(:api_errors) { { subject: api_subject_error, status: api_status_error } }
- it { is_expected.to be_json_eql(api_errors.to_json).at_path('_embedded/validationErrors') }
+ it { is_expected.to be_json_eql(api_errors.to_json).at_path("_embedded/validationErrors") }
end
end
- it { is_expected.to have_json_path('_embedded/payload') }
- it { is_expected.to have_json_path('_embedded/schema') }
+ it { is_expected.to have_json_path("_embedded/payload") }
+ it { is_expected.to have_json_path("_embedded/schema") }
end
end
diff --git a/spec/lib/api/v3/work_packages/schema/work_package_sums_schema_representer_spec.rb b/spec/lib/api/v3/work_packages/schema/work_package_sums_schema_representer_spec.rb
index a27aaebc7173..9668be23d3c8 100644
--- a/spec/lib/api/v3/work_packages/schema/work_package_sums_schema_representer_spec.rb
+++ b/spec/lib/api/v3/work_packages/schema/work_package_sums_schema_representer_spec.rb
@@ -26,15 +26,15 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::WorkPackages::Schema::WorkPackageSumsSchemaRepresenter do
include API::V3::Utilities::PathHelper
let(:custom_field) { build_stubbed(:issue_custom_field, :integer) }
let(:available_custom_fields) { [custom_field] }
- let(:schema) { double('wp_schema', available_custom_fields:) }
- let(:current_user) { double('user', admin?: false) }
+ let(:schema) { double("wp_schema", available_custom_fields:) }
+ let(:current_user) { double("user", admin?: false) }
let(:representer) do
described_class.create(schema, current_user:)
@@ -42,80 +42,80 @@
subject { representer.to_json }
- context 'self link' do
- it 'has a self link' do
+ context "self link" do
+ it "has a self link" do
expected = {
href: api_v3_paths.work_package_sums_schema
}
- expect(subject).to be_json_eql(expected.to_json).at_path('_links/self')
+ expect(subject).to be_json_eql(expected.to_json).at_path("_links/self")
end
end
- context 'estimated_time' do
- it_behaves_like 'has basic schema properties' do
- let(:path) { 'estimatedTime' }
- let(:type) { 'Duration' }
- let(:name) { I18n.t('attributes.estimated_hours') }
+ context "estimated_time" do
+ it_behaves_like "has basic schema properties" do
+ let(:path) { "estimatedTime" }
+ let(:type) { "Duration" }
+ let(:name) { I18n.t("attributes.estimated_hours") }
let(:required) { false }
let(:writable) { false }
end
end
- describe 'storyPoints' do
- it_behaves_like 'has basic schema properties' do
- let(:path) { 'storyPoints' }
- let(:type) { 'Integer' }
- let(:name) { I18n.t('activerecord.attributes.work_package.story_points') }
+ describe "storyPoints" do
+ it_behaves_like "has basic schema properties" do
+ let(:path) { "storyPoints" }
+ let(:type) { "Integer" }
+ let(:name) { I18n.t("activerecord.attributes.work_package.story_points") }
let(:required) { false }
let(:writable) { false }
end
end
- describe 'remainingTime' do
- it_behaves_like 'has basic schema properties' do
- let(:path) { 'remainingTime' }
- let(:type) { 'Duration' }
- let(:name) { I18n.t('activerecord.attributes.work_package.remaining_hours') }
+ describe "remainingTime" do
+ it_behaves_like "has basic schema properties" do
+ let(:path) { "remainingTime" }
+ let(:type) { "Duration" }
+ let(:name) { I18n.t("activerecord.attributes.work_package.remaining_hours") }
let(:required) { false }
let(:writable) { false }
end
end
- describe 'overallCosts' do
- it_behaves_like 'has basic schema properties' do
- let(:path) { 'overallCosts' }
- let(:type) { 'String' }
- let(:name) { I18n.t('activerecord.attributes.work_package.overall_costs') }
+ describe "overallCosts" do
+ it_behaves_like "has basic schema properties" do
+ let(:path) { "overallCosts" }
+ let(:type) { "String" }
+ let(:name) { I18n.t("activerecord.attributes.work_package.overall_costs") }
let(:required) { false }
let(:writable) { false }
end
end
- describe 'laborCosts' do
- it_behaves_like 'has basic schema properties' do
- let(:path) { 'laborCosts' }
- let(:type) { 'String' }
- let(:name) { I18n.t('activerecord.attributes.work_package.labor_costs') }
+ describe "laborCosts" do
+ it_behaves_like "has basic schema properties" do
+ let(:path) { "laborCosts" }
+ let(:type) { "String" }
+ let(:name) { I18n.t("activerecord.attributes.work_package.labor_costs") }
let(:required) { false }
let(:writable) { false }
end
end
- describe 'materialCosts' do
- it_behaves_like 'has basic schema properties' do
- let(:path) { 'materialCosts' }
- let(:type) { 'String' }
- let(:name) { I18n.t('activerecord.attributes.work_package.material_costs') }
+ describe "materialCosts" do
+ it_behaves_like "has basic schema properties" do
+ let(:path) { "materialCosts" }
+ let(:type) { "String" }
+ let(:name) { I18n.t("activerecord.attributes.work_package.material_costs") }
let(:required) { false }
let(:writable) { false }
end
end
- context 'custom field x' do
- it_behaves_like 'has basic schema properties' do
+ context "custom field x" do
+ it_behaves_like "has basic schema properties" do
let(:path) { "customField#{custom_field.id}" }
- let(:type) { 'Integer' }
+ let(:type) { "Integer" }
let(:name) { custom_field.name }
let(:required) { false }
let(:writable) { false }
diff --git a/spec/lib/api/v3/work_packages/schema/work_package_sums_schema_spec.rb b/spec/lib/api/v3/work_packages/schema/work_package_sums_schema_spec.rb
index 40d85854f72d..31d45708cc18 100644
--- a/spec/lib/api/v3/work_packages/schema/work_package_sums_schema_spec.rb
+++ b/spec/lib/api/v3/work_packages/schema/work_package_sums_schema_spec.rb
@@ -26,19 +26,19 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::WorkPackages::Schema::WorkPackageSumsSchema do
- let(:current_user) { double('current user') }
+ let(:current_user) { double("current user") }
subject { described_class.new }
- describe '#available_custom_fields' do
+ describe "#available_custom_fields" do
let(:cf1) { double }
let(:cf2) { double }
let(:cf3) { double }
- it 'returns all custom fields listed as summable' do
+ it "returns all custom fields listed as summable" do
allow(WorkPackageCustomField)
.to receive(:summable) { [cf1, cf2, cf3] }
diff --git a/spec/lib/api/v3/work_packages/update_form_representer_spec.rb b/spec/lib/api/v3/work_packages/update_form_representer_spec.rb
index 2e52b256999c..98a19232938a 100644
--- a/spec/lib/api/v3/work_packages/update_form_representer_spec.rb
+++ b/spec/lib/api/v3/work_packages/update_form_representer_spec.rb
@@ -25,7 +25,7 @@
#
# See COPYRIGHT and LICENSE files for more details.
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::WorkPackages::UpdateFormRepresenter do
include API::V3::Utilities::PathHelper
@@ -49,51 +49,51 @@
end
end
- context 'generation' do
+ context "generation" do
subject(:generated) { representer.to_json }
- describe '_links' do
- it { is_expected.to have_json_path('_links') }
+ describe "_links" do
+ it { is_expected.to have_json_path("_links") }
- it { is_expected.to have_json_path('_links/self/href') }
+ it { is_expected.to have_json_path("_links/self/href") }
- describe 'validate' do
- it { is_expected.to have_json_path('_links/validate/href') }
+ describe "validate" do
+ it { is_expected.to have_json_path("_links/validate/href") }
- it { is_expected.to be_json_eql(:post.to_json).at_path('_links/validate/method') }
+ it { is_expected.to be_json_eql(:post.to_json).at_path("_links/validate/method") }
end
- describe 'preview markup' do
- it { is_expected.to have_json_path('_links/previewMarkup/href') }
+ describe "preview markup" do
+ it { is_expected.to have_json_path("_links/previewMarkup/href") }
- it { is_expected.to be_json_eql(:post.to_json).at_path('_links/previewMarkup/method') }
+ it { is_expected.to be_json_eql(:post.to_json).at_path("_links/previewMarkup/method") }
- it 'contains link to work package' do
+ it "contains link to work package" do
body = parse_json(subject)
- actual_preview_link = body['_links']['previewMarkup']['href']
- expected_preview_link = api_v3_paths.render_markup link: body['_links']['commit']['href']
+ actual_preview_link = body["_links"]["previewMarkup"]["href"]
+ expected_preview_link = api_v3_paths.render_markup link: body["_links"]["commit"]["href"]
expect(actual_preview_link).to eq(expected_preview_link)
end
end
- describe 'commit' do
- context 'valid work package' do
- it { is_expected.to have_json_path('_links/commit/href') }
+ describe "commit" do
+ context "valid work package" do
+ it { is_expected.to have_json_path("_links/commit/href") }
- it { is_expected.to be_json_eql(:patch.to_json).at_path('_links/commit/method') }
+ it { is_expected.to be_json_eql(:patch.to_json).at_path("_links/commit/method") }
end
- context 'invalid work package' do
- let(:errors) { [API::Errors::Validation.new(:subject, 'it is broken')] }
+ context "invalid work package" do
+ let(:errors) { [API::Errors::Validation.new(:subject, "it is broken")] }
- it { is_expected.not_to have_json_path('_links/commit/href') }
+ it { is_expected.not_to have_json_path("_links/commit/href") }
end
- context 'user with insufficient permissions' do
+ context "user with insufficient permissions" do
let(:permissions) { [] }
- it { is_expected.not_to have_json_path('_links/commit/href') }
+ it { is_expected.not_to have_json_path("_links/commit/href") }
end
end
end
diff --git a/spec/lib/api/v3/work_packages/work_package_at_timestamp_representer_rendering_spec.rb b/spec/lib/api/v3/work_packages/work_package_at_timestamp_representer_rendering_spec.rb
index e88059b1f395..3f51f419ea84 100644
--- a/spec/lib/api/v3/work_packages/work_package_at_timestamp_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/work_packages/work_package_at_timestamp_representer_rendering_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
# Note: The specs in this file do not attempt to test the properties themselves with all their possible
# variations. This is done in length in the work_package_representer_spec.rb. Instead, the focus of the tests
# here are on the selection of properties.
-RSpec.describe API::V3::WorkPackages::WorkPackageAtTimestampRepresenter, 'rendering' do
+RSpec.describe API::V3::WorkPackages::WorkPackageAtTimestampRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
let(:current_user) { build_stubbed(:user) }
@@ -57,7 +57,7 @@
let(:project) { build_stubbed(:project) }
let(:custom_field) do
build_stubbed(:string_wp_custom_field,
- name: 'String CF',
+ name: "String CF",
types: project.types,
projects: [project])
end
@@ -66,7 +66,7 @@
let(:custom_value) do
build_stubbed(:custom_value,
custom_field:,
- value: 'This is a string value')
+ value: "This is a string value")
end
let(:work_package) do
@@ -134,169 +134,169 @@
subject(:generated) { representer.to_json }
- context 'with all supported properties requested' do
+ context "with all supported properties requested" do
let(:expected_json) do
{
- 'subject' => work_package.subject,
- 'startDate' => work_package.start_date,
- 'dueDate' => work_package.due_date,
- "customField#{custom_field.id}" => 'This is a string value',
- '_meta' => {
- 'matchesFilters' => true,
- 'exists' => true,
- 'timestamp' => timestamp.to_s
+ "subject" => work_package.subject,
+ "startDate" => work_package.start_date,
+ "dueDate" => work_package.due_date,
+ "customField#{custom_field.id}" => "This is a string value",
+ "_meta" => {
+ "matchesFilters" => true,
+ "exists" => true,
+ "timestamp" => timestamp.to_s
},
- '_links' => {
- 'assignee' => {
- 'href' => api_v3_paths.user(assigned_to.id),
- 'title' => assigned_to.name
+ "_links" => {
+ "assignee" => {
+ "href" => api_v3_paths.user(assigned_to.id),
+ "title" => assigned_to.name
},
- 'responsible' => {
- 'href' => api_v3_paths.user(responsible.id),
- 'title' => responsible.name
+ "responsible" => {
+ "href" => api_v3_paths.user(responsible.id),
+ "title" => responsible.name
},
- 'project' => {
- 'href' => api_v3_paths.project(project.id),
- 'title' => project.name
+ "project" => {
+ "href" => api_v3_paths.project(project.id),
+ "title" => project.name
},
- 'status' => {
- 'href' => api_v3_paths.status(status.id),
- 'title' => status.name
+ "status" => {
+ "href" => api_v3_paths.status(status.id),
+ "title" => status.name
},
- 'type' => {
- 'href' => api_v3_paths.type(type.id),
- 'title' => type.name
+ "type" => {
+ "href" => api_v3_paths.type(type.id),
+ "title" => type.name
},
- 'priority' => {
- 'href' => api_v3_paths.priority(priority.id),
- 'title' => priority.name
+ "priority" => {
+ "href" => api_v3_paths.priority(priority.id),
+ "title" => priority.name
},
- 'version' => {
- 'href' => api_v3_paths.version(version.id),
- 'title' => version.name
+ "version" => {
+ "href" => api_v3_paths.version(version.id),
+ "title" => version.name
},
- 'parent' => {
- 'href' => api_v3_paths.work_package(parent.id),
- 'title' => parent.subject
+ "parent" => {
+ "href" => api_v3_paths.work_package(parent.id),
+ "title" => parent.subject
},
- 'self' => {
- 'href' => api_v3_paths.work_package(work_package.id, timestamps: timestamp),
- 'title' => work_package.subject
+ "self" => {
+ "href" => api_v3_paths.work_package(work_package.id, timestamps: timestamp),
+ "title" => work_package.subject
},
- 'schema' => {
- 'href' => api_v3_paths.work_package_schema(work_package.project_id, work_package.type_id)
+ "schema" => {
+ "href" => api_v3_paths.work_package_schema(work_package.project_id, work_package.type_id)
}
}
}.to_json
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(subject)
.to be_json_eql(expected_json)
end
end
- context 'with a subset of supported properties' do
+ context "with a subset of supported properties" do
let(:attributes_changed_to_baseline) { %w[start_date assigned_to_id version_id] }
let(:expected_json) do
{
- 'startDate' => work_package.start_date,
- '_meta' => {
- 'matchesFilters' => true,
- 'exists' => true,
- 'timestamp' => timestamp.to_s
+ "startDate" => work_package.start_date,
+ "_meta" => {
+ "matchesFilters" => true,
+ "exists" => true,
+ "timestamp" => timestamp.to_s
},
- '_links' => {
- 'assignee' => {
- 'href' => api_v3_paths.user(assigned_to.id),
- 'title' => assigned_to.name
+ "_links" => {
+ "assignee" => {
+ "href" => api_v3_paths.user(assigned_to.id),
+ "title" => assigned_to.name
},
- 'version' => {
- 'href' => api_v3_paths.version(version.id),
- 'title' => version.name
+ "version" => {
+ "href" => api_v3_paths.version(version.id),
+ "title" => version.name
},
- 'self' => {
- 'href' => api_v3_paths.work_package(work_package.id, timestamps: timestamp),
- 'title' => work_package.subject
+ "self" => {
+ "href" => api_v3_paths.work_package(work_package.id, timestamps: timestamp),
+ "title" => work_package.subject
},
- 'schema' => {
- 'href' => api_v3_paths.work_package_schema(work_package.project_id, work_package.type_id)
+ "schema" => {
+ "href" => api_v3_paths.work_package_schema(work_package.project_id, work_package.type_id)
}
}
}.to_json
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(subject)
.to be_json_eql(expected_json)
end
end
- context 'without a linked property' do
+ context "without a linked property" do
let(:attributes_changed_to_baseline) { %w[subject start_date] }
let(:expected_json) do
{
- 'subject' => work_package.subject,
- 'startDate' => work_package.start_date,
- '_meta' => {
- 'matchesFilters' => true,
- 'exists' => true,
- 'timestamp' => timestamp.to_s
+ "subject" => work_package.subject,
+ "startDate" => work_package.start_date,
+ "_meta" => {
+ "matchesFilters" => true,
+ "exists" => true,
+ "timestamp" => timestamp.to_s
},
- '_links' => {
- 'self' => {
- 'href' => api_v3_paths.work_package(work_package.id, timestamps: timestamp),
- 'title' => work_package.subject
+ "_links" => {
+ "self" => {
+ "href" => api_v3_paths.work_package(work_package.id, timestamps: timestamp),
+ "title" => work_package.subject
},
- 'schema' => {
- 'href' => api_v3_paths.work_package_schema(work_package.project_id, work_package.type_id)
+ "schema" => {
+ "href" => api_v3_paths.work_package_schema(work_package.project_id, work_package.type_id)
}
}
}.to_json
end
- it 'renders with only `self` in links' do
+ it "renders with only `self` in links" do
expect(subject)
.to be_json_eql(expected_json)
end
end
- context 'with a nil value for a linked property' do
+ context "with a nil value for a linked property" do
let(:assigned_to) { nil }
let(:attributes_changed_to_baseline) { %w[assigned_to_id] }
let(:expected_json) do
{
- '_meta' => {
- 'matchesFilters' => true,
- 'exists' => true,
- 'timestamp' => timestamp.to_s
+ "_meta" => {
+ "matchesFilters" => true,
+ "exists" => true,
+ "timestamp" => timestamp.to_s
},
- '_links' => {
- 'assignee' => {
- 'href' => nil
+ "_links" => {
+ "assignee" => {
+ "href" => nil
},
- 'self' => {
- 'href' => api_v3_paths.work_package(work_package.id, timestamps: timestamp),
- 'title' => work_package.subject
+ "self" => {
+ "href" => api_v3_paths.work_package(work_package.id, timestamps: timestamp),
+ "title" => work_package.subject
},
- 'schema' => {
- 'href' => api_v3_paths.work_package_schema(work_package.project_id, work_package.type_id)
+ "schema" => {
+ "href" => api_v3_paths.work_package_schema(work_package.project_id, work_package.type_id)
}
}
}.to_json
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(subject)
.to be_json_eql(expected_json)
end
end
- context 'without the timestamp being in the attributes_by_timestamp collection' do
+ context "without the timestamp being in the attributes_by_timestamp collection" do
let(:attributes_changed_to_baseline) { %w[] }
let(:exists_at_timestamp) { false }
@@ -305,21 +305,21 @@
let(:expected_json) do
{
- '_meta' => {
- 'matchesFilters' => false,
- 'exists' => false,
- 'timestamp' => timestamp.to_s
+ "_meta" => {
+ "matchesFilters" => false,
+ "exists" => false,
+ "timestamp" => timestamp.to_s
}
}.to_json
end
- it 'has only the meta noting that the wp did not exist' do
+ it "has only the meta noting that the wp did not exist" do
expect(subject)
.to be_json_eql(expected_json)
end
end
- context 'with a milestone typed work package' do
+ context "with a milestone typed work package" do
let(:type) { build_stubbed(:type_milestone) }
# On a milestone, both dates will be the same
let(:start_date) { due_date }
@@ -327,31 +327,31 @@
let(:expected_json) do
{
- 'date' => work_package.start_date,
- '_meta' => {
- 'matchesFilters' => true,
- 'exists' => true,
- 'timestamp' => timestamp.to_s
+ "date" => work_package.start_date,
+ "_meta" => {
+ "matchesFilters" => true,
+ "exists" => true,
+ "timestamp" => timestamp.to_s
},
- '_links' => {
- 'self' => {
- 'href' => api_v3_paths.work_package(work_package.id, timestamps: timestamp),
- 'title' => work_package.subject
+ "_links" => {
+ "self" => {
+ "href" => api_v3_paths.work_package(work_package.id, timestamps: timestamp),
+ "title" => work_package.subject
},
- 'schema' => {
- 'href' => api_v3_paths.work_package_schema(work_package.project_id, work_package.type_id)
+ "schema" => {
+ "href" => api_v3_paths.work_package_schema(work_package.project_id, work_package.type_id)
}
}
}.to_json
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(subject)
.to be_json_eql(expected_json)
end
end
- context 'with only one attribute changed to baseline but with the work package not existing (not visible) at current time' do
+ context "with only one attribute changed to baseline but with the work package not existing (not visible) at current time" do
# Note that while the work package in this test is configured to not exist at the current time (not visible),
# the timestamp passed in isn't the current time. So this represents a case where the work package is no longer
# visible but was visible at the timestamp provided.
@@ -399,59 +399,59 @@
let(:expected_json) do
{
- 'subject' => work_package.subject,
- 'startDate' => work_package.start_date,
- 'dueDate' => work_package.due_date,
- '_meta' => {
- 'matchesFilters' => true,
- 'exists' => true,
- 'timestamp' => timestamp.to_s
+ "subject" => work_package.subject,
+ "startDate" => work_package.start_date,
+ "dueDate" => work_package.due_date,
+ "_meta" => {
+ "matchesFilters" => true,
+ "exists" => true,
+ "timestamp" => timestamp.to_s
},
- '_links' => {
- 'assignee' => {
- 'href' => api_v3_paths.user(assigned_to.id),
- 'title' => assigned_to.name
+ "_links" => {
+ "assignee" => {
+ "href" => api_v3_paths.user(assigned_to.id),
+ "title" => assigned_to.name
},
- 'responsible' => {
- 'href' => api_v3_paths.user(responsible.id),
- 'title' => responsible.name
+ "responsible" => {
+ "href" => api_v3_paths.user(responsible.id),
+ "title" => responsible.name
},
- 'project' => {
- 'href' => api_v3_paths.project(project.id),
- 'title' => project.name
+ "project" => {
+ "href" => api_v3_paths.project(project.id),
+ "title" => project.name
},
- 'status' => {
- 'href' => api_v3_paths.status(status.id),
- 'title' => status.name
+ "status" => {
+ "href" => api_v3_paths.status(status.id),
+ "title" => status.name
},
- 'type' => {
- 'href' => api_v3_paths.type(type.id),
- 'title' => type.name
+ "type" => {
+ "href" => api_v3_paths.type(type.id),
+ "title" => type.name
},
- 'priority' => {
- 'href' => api_v3_paths.priority(priority.id),
- 'title' => priority.name
+ "priority" => {
+ "href" => api_v3_paths.priority(priority.id),
+ "title" => priority.name
},
- 'version' => {
- 'href' => api_v3_paths.version(version.id),
- 'title' => version.name
+ "version" => {
+ "href" => api_v3_paths.version(version.id),
+ "title" => version.name
},
- 'parent' => {
- 'href' => api_v3_paths.work_package(parent.id),
- 'title' => parent.subject
+ "parent" => {
+ "href" => api_v3_paths.work_package(parent.id),
+ "title" => parent.subject
},
- 'self' => {
- 'href' => api_v3_paths.work_package(work_package.id, timestamps: timestamp),
- 'title' => work_package.subject
+ "self" => {
+ "href" => api_v3_paths.work_package(work_package.id, timestamps: timestamp),
+ "title" => work_package.subject
},
- 'schema' => {
- 'href' => api_v3_paths.work_package_schema(work_package.project_id, work_package.type_id)
+ "schema" => {
+ "href" => api_v3_paths.work_package_schema(work_package.project_id, work_package.type_id)
}
}
}.to_json
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(subject)
.to be_json_eql(expected_json)
end
diff --git a/spec/lib/api/v3/work_packages/work_package_collection_representer_spec.rb b/spec/lib/api/v3/work_packages/work_package_collection_representer_spec.rb
index 96f317f3b805..3b9889dc8726 100644
--- a/spec/lib/api/v3/work_packages/work_package_collection_representer_spec.rb
+++ b/spec/lib/api/v3/work_packages/work_package_collection_representer_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::WorkPackages::WorkPackageCollectionRepresenter do
include API::V3::Utilities::PathHelper
create_shared_association_defaults_for_work_package_factory
- let(:self_base_link) { '/api/v3/example' }
+ let(:self_base_link) { "/api/v3/example" }
let(:work_packages) do
created_work_packages
WorkPackage.all
@@ -72,7 +72,7 @@
query:
)
end
- let(:collection_inner_type) { 'WorkPackage' }
+ let(:collection_inner_type) { "WorkPackage" }
current_user { user }
@@ -88,78 +88,78 @@
subject(:collection) { representer.to_json }
- describe '_links' do
- describe 'self' do
- describe 'when providing timestamps' do
+ describe "_links" do
+ describe "self" do
+ describe "when providing timestamps" do
let(:timestamps) { [Timestamp.parse("2022-01-01T00:00:00Z"), Timestamp.parse("PT0S")] }
let(:absolute_timestamp_strings) { timestamps.collect(&:absolute) }
let(:absolute_timestamps_query_param) { { timestamps: absolute_timestamp_strings.join(",") }.to_query }
- it 'has the absolute timestamps within the self link' do
+ it "has the absolute timestamps within the self link" do
Timecop.freeze do
expect(subject)
.to include_json(absolute_timestamps_query_param.to_json)
- .at_path('_links/self/href')
+ .at_path("_links/self/href")
end
end
end
- describe 'when providing only the current timestamp' do
+ describe "when providing only the current timestamp" do
let(:timestamps) { [Timestamp.parse("PT0S")] }
- it 'has no timestamps within the self link' do
+ it "has no timestamps within the self link" do
Timecop.freeze do
expect(subject)
.not_to include_json("timestamps".to_json)
- .at_path('_links/self/href')
+ .at_path("_links/self/href")
end
end
end
end
- describe 'representations' do
- context 'when outside of a project and the user has the export_work_packages permission' do
- let(:query_params) { { foo: 'bar' } }
+ describe "representations" do
+ context "when outside of a project and the user has the export_work_packages permission" do
+ let(:query_params) { { foo: "bar" } }
let(:expected) do
expected_query_params = query_params.merge(pageSize: 30, offset: 1)
JSON.parse([
{
- href: work_packages_path({ format: 'pdf' }.merge(expected_query_params)),
- type: 'application/pdf',
- identifier: 'pdf',
- title: I18n.t('export.format.pdf_overview_table')
+ href: work_packages_path({ format: "pdf" }.merge(expected_query_params)),
+ type: "application/pdf",
+ identifier: "pdf",
+ title: I18n.t("export.format.pdf_overview_table")
},
{
- href: work_packages_path({ format: 'pdf', show_images: true, show_report: true }
+ href: work_packages_path({ format: "pdf", show_images: true, show_report: true }
.merge(expected_query_params)),
- identifier: 'pdf-with-descriptions',
- type: 'application/pdf',
- title: I18n.t('export.format.pdf_report_with_images')
+ identifier: "pdf-with-descriptions",
+ type: "application/pdf",
+ title: I18n.t("export.format.pdf_report_with_images")
},
{
- href: work_packages_path({ format: 'pdf', show_report: true }.merge(expected_query_params)),
- identifier: 'pdf-descr',
- type: 'application/pdf',
- title: I18n.t('export.format.pdf_report')
+ href: work_packages_path({ format: "pdf", show_report: true }.merge(expected_query_params)),
+ identifier: "pdf-descr",
+ type: "application/pdf",
+ title: I18n.t("export.format.pdf_report")
},
{
- href: work_packages_path({ format: 'csv' }.merge(expected_query_params)),
- type: 'text/csv',
- identifier: 'csv',
- title: I18n.t('export.format.csv')
+ href: work_packages_path({ format: "csv" }.merge(expected_query_params)),
+ type: "text/csv",
+ identifier: "csv",
+ title: I18n.t("export.format.csv")
},
{
- href: work_packages_path({ format: 'atom' }.merge(expected_query_params)),
- identifier: 'atom',
- type: 'application/atom+xml',
- title: I18n.t('export.format.atom')
+ href: work_packages_path({ format: "atom" }.merge(expected_query_params)),
+ identifier: "atom",
+ type: "application/atom+xml",
+ title: I18n.t("export.format.atom")
}
].to_json)
end
- it 'has a collection of export formats' do
- actual = JSON.parse(subject).dig('_links', 'representations')
+ it "has a collection of export formats" do
+ actual = JSON.parse(subject).dig("_links", "representations")
# As plugins might extend the representation, we only
# check for a subset
@@ -168,48 +168,48 @@
end
end
- context 'when inside of a project and the user has the export_work_packages permission' do
+ context "when inside of a project and the user has the export_work_packages permission" do
let(:project) { build_stubbed(:project) }
let(:expected) do
expected_query_params = query_params.merge(pageSize: 30, offset: 1)
JSON.parse([
{
- href: project_work_packages_path(project, { format: 'pdf' }.merge(expected_query_params)),
- type: 'application/pdf',
- identifier: 'pdf',
- title: I18n.t('export.format.pdf_overview_table')
+ href: project_work_packages_path(project, { format: "pdf" }.merge(expected_query_params)),
+ type: "application/pdf",
+ identifier: "pdf",
+ title: I18n.t("export.format.pdf_overview_table")
},
{
- href: project_work_packages_path(project, { format: 'pdf', show_images: true, show_report: true }
+ href: project_work_packages_path(project, { format: "pdf", show_images: true, show_report: true }
.merge(expected_query_params)),
- type: 'application/pdf',
- identifier: 'pdf-with-descriptions',
- title: I18n.t('export.format.pdf_report_with_images')
+ type: "application/pdf",
+ identifier: "pdf-with-descriptions",
+ title: I18n.t("export.format.pdf_report_with_images")
},
{
- href: project_work_packages_path(project, { format: 'pdf', show_report: true }.merge(expected_query_params)),
- type: 'application/pdf',
- identifier: 'pdf-descr',
- title: I18n.t('export.format.pdf_report')
+ href: project_work_packages_path(project, { format: "pdf", show_report: true }.merge(expected_query_params)),
+ type: "application/pdf",
+ identifier: "pdf-descr",
+ title: I18n.t("export.format.pdf_report")
},
{
- href: project_work_packages_path(project, { format: 'csv' }.merge(expected_query_params)),
- identifier: 'csv',
- type: 'text/csv',
- title: I18n.t('export.format.csv')
+ href: project_work_packages_path(project, { format: "csv" }.merge(expected_query_params)),
+ identifier: "csv",
+ type: "text/csv",
+ title: I18n.t("export.format.csv")
},
{
- href: project_work_packages_path(project, { format: 'atom' }.merge(expected_query_params)),
- identifier: 'atom',
- type: 'application/atom+xml',
- title: I18n.t('export.format.atom')
+ href: project_work_packages_path(project, { format: "atom" }.merge(expected_query_params)),
+ identifier: "atom",
+ type: "application/atom+xml",
+ title: I18n.t("export.format.atom")
}
].to_json)
end
- it 'has a project scoped collection of export formats if inside a project' do
- actual = JSON.parse(subject).dig('_links', 'representations')
+ it "has a project scoped collection of export formats if inside a project" do
+ actual = JSON.parse(subject).dig("_links", "representations")
# As plugins might extend the representation, we only
# check for a subset
@@ -218,29 +218,29 @@
end
end
- context 'when the user lacks the export_work_packages permission' do
+ context "when the user lacks the export_work_packages permission" do
before do
mock_permissions_for(user, &:forbid_everything)
end
- it 'has no export links' do
+ it "has no export links" do
expect(collection)
- .not_to have_json_path('_links/representations')
+ .not_to have_json_path("_links/representations")
end
end
end
- describe 'customFields' do
+ describe "customFields" do
let(:project) { build_stubbed(:project) }
- context 'with the permission to select custom fields' do
+ context "with the permission to select custom fields" do
before do
mock_permissions_for(user) do |mock|
mock.allow_in_project :select_custom_fields, project:
end
end
- it 'has a link to set the custom fields for that project' do
+ it "has a link to set the custom fields for that project" do
expected = {
href: project_settings_custom_fields_path(project),
type: "text/html",
@@ -249,73 +249,73 @@
expect(collection)
.to be_json_eql(expected.to_json)
- .at_path('_links/customFields')
+ .at_path("_links/customFields")
end
end
- context 'without the permission to select custom fields' do
+ context "without the permission to select custom fields" do
before do
mock_permissions_for(user, &:forbid_everything)
end
- it 'has no link to set the custom fields for that project' do
- expect(collection).not_to have_json_path('_links/customFields')
+ it "has no link to set the custom fields for that project" do
+ expect(collection).not_to have_json_path("_links/customFields")
end
end
- context 'when not in a project' do
+ context "when not in a project" do
let(:project) { nil }
- it 'has no link to set the custom fields for that project' do
- expect(collection).not_to have_json_path('_links/customFields')
+ it "has no link to set the custom fields for that project" do
+ expect(collection).not_to have_json_path("_links/customFields")
end
end
end
end
- describe '_embedded' do
- describe 'elements' do
- context 'for a work package that is not visible' do
+ describe "_embedded" do
+ describe "elements" do
+ context "for a work package that is not visible" do
let(:total) { 1 }
let(:permissions) { [] }
let(:project) { created_work_packages.first.project }
- it 'renders a reduced WorkPackage element' do
+ it "renders a reduced WorkPackage element" do
expect(collection)
.to be_json_eql(
{
- _type: 'WorkPackage',
+ _type: "WorkPackage",
_links: {
self: {
href: api_v3_paths.work_package(first_wp.id)
}
}
}.to_json
- ).at_path('_embedded/elements/0')
+ ).at_path("_embedded/elements/0")
end
end
end
end
- it 'does not render groups' do
- expect(collection).not_to have_json_path('groups')
+ it "does not render groups" do
+ expect(collection).not_to have_json_path("groups")
end
- it 'does not render sums' do
- expect(collection).not_to have_json_path('totalSums')
+ it "does not render sums" do
+ expect(collection).not_to have_json_path("totalSums")
end
- it 'has a schemas link' do
+ it "has a schemas link" do
# All work packages in the collection are from the same project and have the same type
path = api_v3_paths.work_package_schemas [first_wp.project_id, first_wp.type_id]
expect(collection)
.to be_json_eql(path.to_json)
- .at_path('_links/schemas/href')
+ .at_path("_links/schemas/href")
end
- describe 'ancestors' do
- it 'are being eager loaded' do
+ describe "ancestors" do
+ it "are being eager loaded" do
representer.represented.each do |wp|
expect(wp.work_package_ancestors).to be_a(Array)
expect(wp.ancestors).to eq(wp.work_package_ancestors)
@@ -323,219 +323,219 @@
end
end
- context 'when the user has the edit_work_package permission in any project' do
+ context "when the user has the edit_work_package permission in any project" do
before do
mock_permissions_for(user) do |mock|
mock.allow_in_project *permissions, project: build_stubbed(:project) # any project
end
end
- context 'when allowed' do
+ context "when allowed" do
let(:permissions) { [:edit_work_packages] }
- it 'has a link to templated edit work_package' do
+ it "has a link to templated edit work_package" do
expect(collection)
- .to be_json_eql(api_v3_paths.work_package_form('{work_package_id}').to_json)
- .at_path('_links/editWorkPackage/href')
+ .to be_json_eql(api_v3_paths.work_package_form("{work_package_id}").to_json)
+ .at_path("_links/editWorkPackage/href")
end
end
- context 'when not allowed' do
+ context "when not allowed" do
let(:permissions) { [] }
- it 'has no link to templated edit work_package' do
- expect(collection).not_to have_json_path('_links/editWorkPackage')
+ it "has no link to templated edit work_package" do
+ expect(collection).not_to have_json_path("_links/editWorkPackage")
end
end
end
- context 'when the user has the add_work_package permission in any project' do
+ context "when the user has the add_work_package permission in any project" do
before do
mock_permissions_for(user) do |mock|
mock.allow_in_project :add_work_packages, project: build_stubbed(:project) # any project
end
end
- it 'has a link to create work_packages' do
+ it "has a link to create work_packages" do
expect(collection)
.to be_json_eql(api_v3_paths.create_work_package_form.to_json)
- .at_path('_links/createWorkPackage/href')
+ .at_path("_links/createWorkPackage/href")
end
- it 'declares to use POST to create work_packages' do
+ it "declares to use POST to create work_packages" do
expect(collection)
.to be_json_eql(:post.to_json)
- .at_path('_links/createWorkPackage/method')
+ .at_path("_links/createWorkPackage/method")
end
- it 'has a link to create work_packages immediately' do
+ it "has a link to create work_packages immediately" do
expect(collection)
.to be_json_eql(api_v3_paths.work_packages.to_json)
- .at_path('_links/createWorkPackageImmediate/href')
+ .at_path("_links/createWorkPackageImmediate/href")
end
- it 'declares to use POST to create work_packages immediately' do
+ it "declares to use POST to create work_packages immediately" do
expect(collection)
.to be_json_eql(:post.to_json)
- .at_path('_links/createWorkPackageImmediate/method')
+ .at_path("_links/createWorkPackageImmediate/method")
end
- context 'when in project context' do
+ context "when in project context" do
let(:project) { build_stubbed(:project) }
- it 'has no link to create work_packages' do
+ it "has no link to create work_packages" do
expect(collection)
- .not_to have_json_path('_links/createWorkPackage')
+ .not_to have_json_path("_links/createWorkPackage")
end
- it 'has no link to create work_packages immediately' do
+ it "has no link to create work_packages immediately" do
expect(collection)
- .not_to have_json_path('_links/createWorkPackageImmediate')
+ .not_to have_json_path("_links/createWorkPackageImmediate")
end
end
end
- context 'when the user lacks the add_work_package permission' do
+ context "when the user lacks the add_work_package permission" do
before do
mock_permissions_for(user, &:forbid_everything)
end
- it 'has no link to create work_packages' do
+ it "has no link to create work_packages" do
expect(collection)
- .not_to have_json_path('_links/createWorkPackage')
+ .not_to have_json_path("_links/createWorkPackage")
end
- it 'has no link to create work_packages immediately' do
+ it "has no link to create work_packages immediately" do
expect(collection)
- .not_to have_json_path('_links/createWorkPackageImmediate')
+ .not_to have_json_path("_links/createWorkPackageImmediate")
end
end
- context 'with a magic page size' do
+ context "with a magic page size" do
let(:page_size_parameter) { -1 }
- it_behaves_like 'offset-paginated APIv3 collection' do
+ it_behaves_like "offset-paginated APIv3 collection" do
let(:page) { 1 }
let(:page_size) { Setting.apiv3_max_page_size }
let(:actual_count) { 5 }
- let(:collection_type) { 'WorkPackageCollection' }
+ let(:collection_type) { "WorkPackageCollection" }
end
end
- context 'with a limited page size' do
+ context "with a limited page size" do
let(:page_size_parameter) { 2 }
- context 'when on the first page' do
- it_behaves_like 'offset-paginated APIv3 collection' do
+ context "when on the first page" do
+ it_behaves_like "offset-paginated APIv3 collection" do
let(:page) { 1 }
let(:page_size) { page_size_parameter }
let(:actual_count) { page_size_parameter }
- let(:collection_type) { 'WorkPackageCollection' }
+ let(:collection_type) { "WorkPackageCollection" }
- it_behaves_like 'links to next page by offset'
+ it_behaves_like "links to next page by offset"
end
- it_behaves_like 'has no link' do
- let(:link) { 'previousByOffset' }
+ it_behaves_like "has no link" do
+ let(:link) { "previousByOffset" }
end
end
- context 'when on the last page' do
+ context "when on the last page" do
let(:page_parameter) { 3 }
- it_behaves_like 'offset-paginated APIv3 collection' do
+ it_behaves_like "offset-paginated APIv3 collection" do
let(:page) { 3 }
let(:page_size) { page_size_parameter }
let(:actual_count) { 1 }
- let(:collection_type) { 'WorkPackageCollection' }
+ let(:collection_type) { "WorkPackageCollection" }
- it_behaves_like 'links to previous page by offset'
+ it_behaves_like "links to previous page by offset"
end
- it_behaves_like 'has no link' do
- let(:link) { 'nextByOffset' }
+ it_behaves_like "has no link" do
+ let(:link) { "nextByOffset" }
end
end
end
- context 'when passing a query_params hash' do
- let(:query_params) { { a: 'b', b: 'c' } }
+ context "when passing a query_params hash" do
+ let(:query_params) { { a: "b", b: "c" } }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'self' }
- let(:href) { '/api/v3/example?a=b&b=c&offset=1&pageSize=30' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "self" }
+ let(:href) { "/api/v3/example?a=b&b=c&offset=1&pageSize=30" }
end
end
- context 'when passing groups' do
+ context "when passing groups" do
let(:groups) do
- group = { 'custom' => 'object' }
+ group = { "custom" => "object" }
allow(group).to receive(:has_sums?).and_return false
[group]
end
- it 'renders the groups object as json' do
- expect(collection).to be_json_eql(groups.to_json).at_path('groups')
+ it "renders the groups object as json" do
+ expect(collection).to be_json_eql(groups.to_json).at_path("groups")
end
end
- context 'when passing groups with sums' do
+ context "when passing groups with sums" do
let(:groups) do
- group = { 'sums' => {} }
+ group = { "sums" => {} }
allow(group).to receive(:has_sums?).and_return true
[group]
end
- it 'renders the groups object as json' do
- expect(collection).to be_json_eql(groups.to_json).at_path('groups')
+ it "renders the groups object as json" do
+ expect(collection).to be_json_eql(groups.to_json).at_path("groups")
end
- it 'has a link to the sums schema' do
+ it "has a link to the sums schema" do
expected = {
href: api_v3_paths.work_package_sums_schema
}
- expect(collection).to be_json_eql(expected.to_json).at_path('_links/sumsSchema')
+ expect(collection).to be_json_eql(expected.to_json).at_path("_links/sumsSchema")
end
end
- context 'when passing sums' do
+ context "when passing sums" do
let(:total_sums) { OpenStruct.new(estimated_hours: 1) }
- it 'renders the groups object as json' do
- expected = { 'estimatedTime' => 'PT1H',
- 'remainingTime' => nil,
- 'storyPoints' => nil }
- expect(collection).to be_json_eql(expected.to_json).at_path('totalSums')
+ it "renders the groups object as json" do
+ expected = { "estimatedTime" => "PT1H",
+ "remainingTime" => nil,
+ "storyPoints" => nil }
+ expect(collection).to be_json_eql(expected.to_json).at_path("totalSums")
end
- it 'has a link to the sums schema' do
+ it "has a link to the sums schema" do
expected = {
href: api_v3_paths.work_package_sums_schema
}
- expect(collection).to be_json_eql(expected.to_json).at_path('_links/sumsSchema')
+ expect(collection).to be_json_eql(expected.to_json).at_path("_links/sumsSchema")
end
end
- context 'when passing schemas' do
+ context "when passing schemas" do
let(:embed_schemas) { true }
- it 'embeds a schema collection', :aggregate_failures do
+ it "embeds a schema collection", :aggregate_failures do
expected_path = api_v3_paths.work_package_schema(first_wp.project.id,
first_wp.type.id)
expect(collection)
.to be_json_eql(expected_path.to_json)
- .at_path('_embedded/schemas/_embedded/elements/0/_links/self/href')
+ .at_path("_embedded/schemas/_embedded/elements/0/_links/self/href")
# All work packages share the same project and type
expect(collection)
.to have_json_size(1)
- .at_path('_embedded/schemas/_embedded/elements')
+ .at_path("_embedded/schemas/_embedded/elements")
end
- context 'when having timestamps leads to a different schema at the baseline time (because of a different type)',
+ context "when having timestamps leads to a different schema at the baseline time (because of a different type)",
with_settings: { journal_aggregation_time_minutes: 0 } do
let(:other_type) { create(:type) }
let(:timestamps) { [Timestamp.parse("2023-01-01T00:00:00Z"), Timestamp.parse("PT0S")] }
@@ -550,34 +550,34 @@
# another schema and set the creation date to be before the baseline time.
create_list(:work_package,
1,
- subject: 'Some new subject',
+ subject: "Some new subject",
journals: {
DateTime.parse("2022-01-01T00:00:00Z") => { type_id: other_type.id },
1.day.ago => {}
})
end
- it 'embeds a schema collection', :aggregate_failures do
+ it "embeds a schema collection", :aggregate_failures do
expect(collection)
.to have_json_size(2)
- .at_path('_embedded/schemas/_embedded/elements')
+ .at_path("_embedded/schemas/_embedded/elements")
expected_former_path = api_v3_paths.work_package_schema(first_wp.project.id,
other_type.id)
expect(collection)
.to be_json_eql(expected_former_path.to_json)
- .at_path('_embedded/schemas/_embedded/elements/0/_links/self/href')
+ .at_path("_embedded/schemas/_embedded/elements/0/_links/self/href")
expected_current_path = api_v3_paths.work_package_schema(first_wp.project.id,
first_wp.type.id)
expect(collection)
.to be_json_eql(expected_current_path.to_json)
- .at_path('_embedded/schemas/_embedded/elements/1/_links/self/href')
+ .at_path("_embedded/schemas/_embedded/elements/1/_links/self/href")
end
end
end
- context 'when passing timestamps' do
+ context "when passing timestamps" do
let(:work_package) do
create(:work_package,
subject: "The current work package",
@@ -595,103 +595,103 @@
let(:project) { create(:project) }
let(:current_user) do
create(:user,
- firstname: 'user',
- lastname: '1',
+ firstname: "user",
+ lastname: "1",
member_with_permissions: { project => %i[view_work_packages] })
end
- shared_examples_for 'includes the properties of the current work package' do
- it 'includes the properties of the current work package' do
+ shared_examples_for "includes the properties of the current work package" do
+ it "includes the properties of the current work package" do
expect(collection)
.to be_json_eql("The current work package".to_json)
- .at_path('_embedded/elements/0/subject')
+ .at_path("_embedded/elements/0/subject")
end
end
- shared_examples_for 'embeds the properties of the baseline work package' do
- it 'embeds the properties of the baseline work package in attributesByTimestamp' do
+ shared_examples_for "embeds the properties of the baseline work package" do
+ it "embeds the properties of the baseline work package in attributesByTimestamp" do
expect(collection)
.to be_json_eql("The original work package".to_json)
.at_path("_embedded/elements/0/_embedded/attributesByTimestamp/0/subject")
end
- it 'embeds the link to the baseline work package in attributesByTimestamp' do
+ it "embeds the link to the baseline work package in attributesByTimestamp" do
expect(collection)
.to be_json_eql(api_v3_paths.work_package(work_package.id, timestamps: timestamps.first).to_json)
.at_path("_embedded/elements/0/_embedded/attributesByTimestamp/0/_links/self/href")
end
end
- shared_examples_for 'has the absolute timestamps within the self link' do
+ shared_examples_for "has the absolute timestamps within the self link" do
let(:absolute_timestamp_strings) { timestamps.collect(&:absolute) }
let(:absolute_timestamps_query_param) { { timestamps: absolute_timestamp_strings.join(",") }.to_query }
- it 'has the absolute timestamps within the self link' do
+ it "has the absolute timestamps within the self link" do
expect(subject)
.to include_json(absolute_timestamps_query_param.to_json)
- .at_path('_embedded/elements/0/_links/self/href')
+ .at_path("_embedded/elements/0/_links/self/href")
end
end
- context 'with baseline and current timestamps' do
+ context "with baseline and current timestamps" do
let(:timestamps) { [Timestamp.parse("2022-01-01T00:00:00Z"), Timestamp.parse("PT0S")] }
- it_behaves_like 'includes the properties of the current work package'
- it_behaves_like 'embeds the properties of the baseline work package'
- it_behaves_like 'has the absolute timestamps within the self link'
+ it_behaves_like "includes the properties of the current work package"
+ it_behaves_like "embeds the properties of the baseline work package"
+ it_behaves_like "has the absolute timestamps within the self link"
end
- context 'with current timestamp only' do
+ context "with current timestamp only" do
let(:timestamps) { [Timestamp.parse("PT0S")] }
- it_behaves_like 'includes the properties of the current work package'
+ it_behaves_like "includes the properties of the current work package"
- it 'has no timestamps within the self link' do
+ it "has no timestamps within the self link" do
expect(subject)
.not_to include_json("timestamps".to_json)
- .at_path('_embedded/elements/0/_links/self/href')
+ .at_path("_embedded/elements/0/_links/self/href")
end
end
- context 'with baseline timestamp only' do
+ context "with baseline timestamp only" do
let(:timestamps) { [Timestamp.parse("2022-01-01T00:00:00Z")] }
- it 'includes the properties of the baseline work package' do
+ it "includes the properties of the baseline work package" do
expect(collection)
.to be_json_eql("The original work package".to_json)
- .at_path('_embedded/elements/0/subject')
+ .at_path("_embedded/elements/0/subject")
end
- it_behaves_like 'has the absolute timestamps within the self link'
+ it_behaves_like "has the absolute timestamps within the self link"
end
- context 'with empty timestamp' do
+ context "with empty timestamp" do
let(:timestamps) { [] }
- it_behaves_like 'includes the properties of the current work package'
+ it_behaves_like "includes the properties of the current work package"
- it 'has no timestamps within the self link' do
+ it "has no timestamps within the self link" do
expect(subject)
.not_to include_json("timestamps".to_json)
- .at_path('_embedded/elements/0/_links/self/href')
+ .at_path("_embedded/elements/0/_links/self/href")
end
end
- context 'when passing a query' do
- let(:search_term) { 'original' }
+ context "when passing a query" do
+ let(:search_term) { "original" }
let(:query) do
build(:query, user: current_user, project: nil).tap do |query|
query.filters.clear
- query.add_filter 'subject', '~', search_term
+ query.add_filter "subject", "~", search_term
query.timestamps = timestamps
end
end
- context 'with baseline and current timestamps', with_ee: %i[baseline_comparison] do
+ context "with baseline and current timestamps", with_ee: %i[baseline_comparison] do
let(:timestamps) { [Timestamp.parse("2022-01-01T00:00:00Z"), Timestamp.parse("PT0S")] }
- describe 'attributesByTimestamp' do
- it 'states whether the work package matches the query filters at the timestamp' do
+ describe "attributesByTimestamp" do
+ it "states whether the work package matches the query filters at the timestamp" do
expect(subject)
.to be_json_eql(true.to_json)
.at_path("_embedded/elements/0/_embedded/attributesByTimestamp/0/_meta/matchesFilters")
diff --git a/spec/lib/api/v3/work_packages/work_package_representer_spec.rb b/spec/lib/api/v3/work_packages/work_package_representer_spec.rb
index c6d90efec6a0..89b590260ab1 100644
--- a/spec/lib/api/v3/work_packages/work_package_representer_spec.rb
+++ b/spec/lib/api/v3/work_packages/work_package_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::WorkPackages::WorkPackageRepresenter do
include API::V3::Utilities::PathHelper
@@ -120,720 +120,720 @@
end
end
- describe '.new' do
- it 'is prevented as .create is to be used' do
+ describe ".new" do
+ it "is prevented as .create is to be used" do
expect { described_class.new(work_package, current_user:, embed_links:) }
.to raise_error NoMethodError
end
end
- include_context 'eager loaded work package representer'
+ include_context "eager loaded work package representer"
- describe 'generation' do
+ describe "generation" do
subject(:generated) { representer.to_json }
- it { is_expected.to include_json('WorkPackage'.to_json).at_path('_type') }
+ it { is_expected.to include_json("WorkPackage".to_json).at_path("_type") }
- describe 'work_package' do
- it { is_expected.to have_json_path('id') }
+ describe "work_package" do
+ it { is_expected.to have_json_path("id") }
- it_behaves_like 'API V3 formattable', 'description' do
- let(:format) { 'markdown' }
+ it_behaves_like "API V3 formattable", "description" do
+ let(:format) { "markdown" }
let(:raw) { work_package.description }
let(:html) { "
#{work_package.description}
" }
end
- describe 'scheduleManually' do
- context 'when no value' do
- it 'renders as false (default value)' do
- expect(subject).to be_json_eql(false.to_json).at_path('scheduleManually')
+ describe "scheduleManually" do
+ context "when no value" do
+ it "renders as false (default value)" do
+ expect(subject).to be_json_eql(false.to_json).at_path("scheduleManually")
end
end
- context 'when false' do
+ context "when false" do
let(:schedule_manually) { false }
- it 'renders as false' do
- expect(subject).to be_json_eql(false.to_json).at_path('scheduleManually')
+ it "renders as false" do
+ expect(subject).to be_json_eql(false.to_json).at_path("scheduleManually")
end
end
- context 'when true' do
+ context "when true" do
let(:schedule_manually) { true }
- it 'renders as true' do
- expect(subject).to be_json_eql(true.to_json).at_path('scheduleManually')
+ it "renders as true" do
+ expect(subject).to be_json_eql(true.to_json).at_path("scheduleManually")
end
end
end
- describe 'startDate' do
- it_behaves_like 'has ISO 8601 date only' do
+ describe "startDate" do
+ it_behaves_like "has ISO 8601 date only" do
let(:date) { start_date }
- let(:json_path) { 'startDate' }
+ let(:json_path) { "startDate" }
end
- context 'when it\'s nil' do
+ context "when it's nil" do
let(:start_date) { nil }
- it 'renders as null' do
- expect(subject).to be_json_eql(nil.to_json).at_path('startDate')
+ it "renders as null" do
+ expect(subject).to be_json_eql(nil.to_json).at_path("startDate")
end
end
- context 'when the work package has a milestone type' do
+ context "when the work package has a milestone type" do
let(:type_milestone) { true }
- it 'has no startDate' do
- expect(subject).not_to have_json_path('startDate')
+ it "has no startDate" do
+ expect(subject).not_to have_json_path("startDate")
end
end
end
- describe 'dueDate' do
- context 'with a non milestone type' do
- it_behaves_like 'has ISO 8601 date only' do
+ describe "dueDate" do
+ context "with a non milestone type" do
+ it_behaves_like "has ISO 8601 date only" do
let(:date) { work_package.due_date }
- let(:json_path) { 'dueDate' }
+ let(:json_path) { "dueDate" }
end
- context 'with no finish date' do
+ context "with no finish date" do
let(:due_date) { nil }
- it 'renders as null' do
- expect(subject).to be_json_eql(nil.to_json).at_path('dueDate')
+ it "renders as null" do
+ expect(subject).to be_json_eql(nil.to_json).at_path("dueDate")
end
end
end
- context 'with a milestone type' do
+ context "with a milestone type" do
let(:type_milestone) { true }
- it 'with no startDate' do
- expect(subject).not_to have_json_path('dueDate')
+ it "with no startDate" do
+ expect(subject).not_to have_json_path("dueDate")
end
end
end
- describe 'date' do
- context 'with a milestone type' do
+ describe "date" do
+ context "with a milestone type" do
let(:type_milestone) { true }
- it_behaves_like 'has ISO 8601 date only' do
+ it_behaves_like "has ISO 8601 date only" do
let(:date) { due_date } # could just as well be start_date
- let(:json_path) { 'date' }
+ let(:json_path) { "date" }
end
- context 'with no finish date' do
+ context "with no finish date" do
let(:due_date) { nil }
- it 'renders as null' do
- expect(subject).to be_json_eql(nil.to_json).at_path('date')
+ it "renders as null" do
+ expect(subject).to be_json_eql(nil.to_json).at_path("date")
end
end
end
- context 'with not a milestone type' do
- it 'with no date' do
- expect(subject).not_to have_json_path('date')
+ context "with not a milestone type" do
+ it "with no date" do
+ expect(subject).not_to have_json_path("date")
end
end
end
- describe 'derivedStartDate' do
- it_behaves_like 'has ISO 8601 date only' do
+ describe "derivedStartDate" do
+ it_behaves_like "has ISO 8601 date only" do
let(:date) { derived_start_date }
- let(:json_path) { 'derivedStartDate' }
+ let(:json_path) { "derivedStartDate" }
end
- context 'with no derived start date' do
+ context "with no derived start date" do
let(:derived_start_date) { nil }
- it 'renders as null' do
+ it "renders as null" do
expect(subject)
.to be_json_eql(nil.to_json)
- .at_path('derivedStartDate')
+ .at_path("derivedStartDate")
end
end
- context 'when the work package has a milestone type' do
+ context "when the work package has a milestone type" do
let(:type_milestone) { true }
- it 'with no derivedStartDate' do
+ it "with no derivedStartDate" do
expect(subject)
- .not_to have_json_path('derivedStartDate')
+ .not_to have_json_path("derivedStartDate")
end
end
end
- describe 'derivedDueDate' do
- it_behaves_like 'has ISO 8601 date only' do
+ describe "derivedDueDate" do
+ it_behaves_like "has ISO 8601 date only" do
let(:date) { derived_due_date }
- let(:json_path) { 'derivedDueDate' }
+ let(:json_path) { "derivedDueDate" }
end
- context 'with no derived due date' do
+ context "with no derived due date" do
let(:derived_due_date) { nil }
- it 'renders as null' do
+ it "renders as null" do
expect(subject)
.to be_json_eql(nil.to_json)
- .at_path('derivedDueDate')
+ .at_path("derivedDueDate")
end
end
- context 'when the work package has a milestone type' do
+ context "when the work package has a milestone type" do
let(:type_milestone) { true }
- it 'with no derivedDueDate' do
+ it "with no derivedDueDate" do
expect(subject)
- .not_to have_json_path('derivedDueDate')
+ .not_to have_json_path("derivedDueDate")
end
end
end
- describe 'duration' do
+ describe "duration" do
let(:duration) { 6 }
- it { is_expected.to be_json_eql('P6D'.to_json).at_path('duration') }
+ it { is_expected.to be_json_eql("P6D".to_json).at_path("duration") }
- context 'with no duration' do
+ context "with no duration" do
let(:duration) { nil }
- it 'renders as null' do
- expect(subject).to be_json_eql(nil.to_json).at_path('duration')
+ it "renders as null" do
+ expect(subject).to be_json_eql(nil.to_json).at_path("duration")
end
end
- context 'when the work_package is a milestone' do
+ context "when the work_package is a milestone" do
let(:type_milestone) { true }
- it 'with no duration' do
- expect(subject).not_to have_json_path('duration')
+ it "with no duration" do
+ expect(subject).not_to have_json_path("duration")
end
end
end
- describe 'ignoreNonWorkingDays' do
+ describe "ignoreNonWorkingDays" do
let(:ignore_non_working_days) { true }
- context 'with the value being `true`' do
- it { is_expected.to be_json_eql(true.to_json).at_path('ignoreNonWorkingDays') }
+ context "with the value being `true`" do
+ it { is_expected.to be_json_eql(true.to_json).at_path("ignoreNonWorkingDays") }
end
- context 'with the value being `false`' do
+ context "with the value being `false`" do
let(:ignore_non_working_days) { false }
- it { is_expected.to be_json_eql(false.to_json).at_path('ignoreNonWorkingDays') }
+ it { is_expected.to be_json_eql(false.to_json).at_path("ignoreNonWorkingDays") }
end
end
- describe 'createdAt' do
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ describe "createdAt" do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { work_package.created_at }
- let(:json_path) { 'createdAt' }
+ let(:json_path) { "createdAt" }
end
end
- describe 'updatedAt' do
- it_behaves_like 'has UTC ISO 8601 date and time' do
+ describe "updatedAt" do
+ it_behaves_like "has UTC ISO 8601 date and time" do
let(:date) { work_package.updated_at }
- let(:json_path) { 'updatedAt' }
+ let(:json_path) { "updatedAt" }
end
end
- it { is_expected.to have_json_path('subject') }
+ it { is_expected.to have_json_path("subject") }
- describe 'lock version' do
- it { is_expected.to have_json_path('lockVersion') }
+ describe "lock version" do
+ it { is_expected.to have_json_path("lockVersion") }
- it { is_expected.to have_json_type(Integer).at_path('lockVersion') }
+ it { is_expected.to have_json_type(Integer).at_path("lockVersion") }
- it { is_expected.to be_json_eql(work_package.lock_version.to_json).at_path('lockVersion') }
+ it { is_expected.to be_json_eql(work_package.lock_version.to_json).at_path("lockVersion") }
end
- describe 'readonly' do
- context 'with no status' do
+ describe "readonly" do
+ context "with no status" do
let(:status) { nil }
- it 'renders nothing' do
- expect(subject).not_to have_json_path('readonly')
+ it "renders nothing" do
+ expect(subject).not_to have_json_path("readonly")
end
end
- context 'when false', with_ee: %i[readonly_work_packages] do
+ context "when false", with_ee: %i[readonly_work_packages] do
let(:status) { build_stubbed(:status, is_readonly: false) }
- it 'renders as false' do
- expect(subject).to be_json_eql(false.to_json).at_path('readonly')
+ it "renders as false" do
+ expect(subject).to be_json_eql(false.to_json).at_path("readonly")
end
end
- context 'when true', with_ee: %i[readonly_work_packages] do
+ context "when true", with_ee: %i[readonly_work_packages] do
let(:status) { build_stubbed(:status, is_readonly: true) }
- it 'renders as true' do
- expect(subject).to be_json_eql(true.to_json).at_path('readonly')
+ it "renders as true" do
+ expect(subject).to be_json_eql(true.to_json).at_path("readonly")
end
end
end
end
- describe 'estimatedTime' do
+ describe "estimatedTime" do
let(:estimated_hours) { 6.5 }
- it { is_expected.to be_json_eql('PT6H30M'.to_json).at_path('estimatedTime') }
+ it { is_expected.to be_json_eql("PT6H30M".to_json).at_path("estimatedTime") }
end
- describe 'derivedEstimatedTime' do
+ describe "derivedEstimatedTime" do
let(:derived_estimated_hours) { 3.75 }
- it { is_expected.to be_json_eql('PT3H45M'.to_json).at_path('derivedEstimatedTime') }
+ it { is_expected.to be_json_eql("PT3H45M".to_json).at_path("derivedEstimatedTime") }
end
- xdescribe 'spentTime' do
+ xdescribe "spentTime" do
# spentTime is completely overwritten by costs
# TODO: move specs from costs to here
end
- describe 'percentageDone' do
- describe 'work package done ratio setting behavior' do
- context 'when setting enabled' do
- it { expect(parse_json(subject)['percentageDone']).to eq(50) }
+ describe "percentageDone" do
+ describe "work package done ratio setting behavior" do
+ context "when setting enabled" do
+ it { expect(parse_json(subject)["percentageDone"]).to eq(50) }
end
- context 'when setting disabled' do
+ context "when setting disabled" do
before do
allow(Setting)
.to receive(:work_package_done_ratio)
- .and_return('disabled')
+ .and_return("disabled")
end
- it { is_expected.not_to have_json_path('percentageDone') }
+ it { is_expected.not_to have_json_path("percentageDone") }
end
end
end
- describe 'custom fields' do
+ describe "custom fields" do
let(:available_custom_fields) { [build_stubbed(:integer_wp_custom_field)] }
- it 'uses a CustomFieldInjector' do
+ it "uses a CustomFieldInjector" do
allow(API::V3::Utilities::CustomFieldInjector).to receive(:create_value_representer).and_call_original
representer.to_json
expect(API::V3::Utilities::CustomFieldInjector).to have_received(:create_value_representer)
end
end
- describe '_links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { "/api/v3/work_packages/#{work_package.id}" }
let(:title) { work_package.subject }
end
- describe 'update links' do
- describe 'update by form' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'update' }
+ describe "update links" do
+ describe "update by form" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "update" }
let(:href) { api_v3_paths.work_package_form(work_package.id) }
end
- it 'is a post link' do
- expect(subject).to be_json_eql('post'.to_json).at_path('_links/update/method')
+ it "is a post link" do
+ expect(subject).to be_json_eql("post".to_json).at_path("_links/update/method")
end
end
- describe 'immediate update' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'updateImmediately' }
+ describe "immediate update" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "updateImmediately" }
let(:href) { api_v3_paths.work_package(work_package.id) }
end
- it 'is a patch link' do
- expect(subject).to be_json_eql('patch'.to_json).at_path('_links/updateImmediately/method')
+ it "is a patch link" do
+ expect(subject).to be_json_eql("patch".to_json).at_path("_links/updateImmediately/method")
end
end
- context 'when user is not allowed to edit work packages' do
+ context "when user is not allowed to edit work packages" do
let(:permissions) { all_permissions - [:edit_work_packages] }
- it_behaves_like 'has no link' do
- let(:link) { 'update' }
+ it_behaves_like "has no link" do
+ let(:link) { "update" }
end
- it_behaves_like 'has no link' do
- let(:link) { 'updateImmediately' }
+ it_behaves_like "has no link" do
+ let(:link) { "updateImmediately" }
end
end
- context 'when user lacks edit permission but has assign_versions' do
+ context "when user lacks edit permission but has assign_versions" do
let(:permissions) { all_permissions - [:edit_work_packages] + [:assign_versions] }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'update' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "update" }
let(:href) { api_v3_paths.work_package_form(work_package.id) }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'updateImmediately' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "updateImmediately" }
let(:href) { api_v3_paths.work_package(work_package.id) }
end
end
- context 'when user lacks edit permission but has change_work_package_status' do
+ context "when user lacks edit permission but has change_work_package_status" do
let(:permissions) { all_permissions - [:edit_work_packages] + [:change_work_package_status] }
- it_behaves_like 'has an untitled link' do
- let(:link) { 'update' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "update" }
let(:href) { api_v3_paths.work_package_form(work_package.id) }
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'updateImmediately' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "updateImmediately" }
let(:href) { api_v3_paths.work_package(work_package.id) }
end
end
end
- describe 'status' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'status' }
+ describe "status" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "status" }
let(:href) { "/api/v3/statuses/#{work_package.status_id}" }
let(:title) { work_package.status.name }
end
end
- describe 'type' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'type' }
+ describe "type" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "type" }
let(:href) { "/api/v3/types/#{work_package.type_id}" }
let(:title) { work_package.type.name }
end
end
- describe 'author' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'author' }
+ describe "author" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "author" }
let(:href) { "/api/v3/users/#{work_package.author.id}" }
let(:title) { work_package.author.name }
end
end
- describe 'assignee' do
- context 'as a user' do
+ describe "assignee" do
+ context "as a user" do
let(:assignee) { build_stubbed(:user) }
- it_behaves_like 'has a titled link' do
- let(:link) { 'assignee' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "assignee" }
let(:href) { "/api/v3/users/#{work_package.assigned_to.id}" }
let(:title) { work_package.assigned_to.name }
end
end
- context 'as a group' do
+ context "as a group" do
let(:assignee) { build_stubbed(:group) }
- it_behaves_like 'has a titled link' do
- let(:link) { 'assignee' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "assignee" }
let(:href) { "/api/v3/groups/#{work_package.assigned_to.id}" }
let(:title) { work_package.assigned_to.name }
end
end
- context 'as a placeholder user' do
+ context "as a placeholder user" do
let(:assignee) { build_stubbed(:placeholder_user) }
- it_behaves_like 'has a titled link' do
- let(:link) { 'assignee' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "assignee" }
let(:href) { "/api/v3/placeholder_users/#{work_package.assigned_to.id}" }
let(:title) { work_package.assigned_to.name }
end
end
- context 'as a deleted user' do
+ context "as a deleted user" do
let(:assignee) { build_stubbed(:deleted_user) }
- it_behaves_like 'has a titled link' do
- let(:link) { 'assignee' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "assignee" }
let(:href) { "/api/v3/users/#{work_package.assigned_to.id}" }
let(:title) { work_package.assigned_to.name }
end
end
- context 'as not set' do
- it_behaves_like 'has an empty link' do
- let(:link) { 'assignee' }
+ context "as not set" do
+ it_behaves_like "has an empty link" do
+ let(:link) { "assignee" }
end
end
end
- describe 'responsible' do
- context 'as a user' do
+ describe "responsible" do
+ context "as a user" do
let(:responsible) { build_stubbed(:user) }
- it_behaves_like 'has a titled link' do
- let(:link) { 'responsible' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "responsible" }
let(:href) { "/api/v3/users/#{work_package.responsible.id}" }
let(:title) { work_package.responsible.name }
end
end
- context 'as a group' do
+ context "as a group" do
let(:responsible) { build_stubbed(:group) }
- it_behaves_like 'has a titled link' do
- let(:link) { 'responsible' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "responsible" }
let(:href) { "/api/v3/groups/#{work_package.responsible.id}" }
let(:title) { work_package.responsible.name }
end
end
- context 'as a placeholder user' do
+ context "as a placeholder user" do
let(:responsible) { build_stubbed(:placeholder_user) }
- it_behaves_like 'has a titled link' do
- let(:link) { 'responsible' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "responsible" }
let(:href) { "/api/v3/placeholder_users/#{work_package.responsible.id}" }
let(:title) { work_package.responsible.name }
end
end
- context 'as a deleted user' do
+ context "as a deleted user" do
let(:responsible) { build_stubbed(:deleted_user) }
- it_behaves_like 'has a titled link' do
- let(:link) { 'responsible' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "responsible" }
let(:href) { "/api/v3/users/#{work_package.responsible.id}" }
let(:title) { work_package.responsible.name }
end
end
- context 'as not set' do
- it_behaves_like 'has an empty link' do
- let(:link) { 'responsible' }
+ context "as not set" do
+ it_behaves_like "has an empty link" do
+ let(:link) { "responsible" }
end
end
end
- describe 'revisions' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'revisions' }
+ describe "revisions" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "revisions" }
let(:href) do
api_v3_paths.work_package_revisions(work_package.id)
end
end
- context 'when user lacks the view_changesets permission' do
+ context "when user lacks the view_changesets permission" do
let(:permissions) { all_permissions - [:view_changesets] }
- it_behaves_like 'has no link' do
- let(:link) { 'revisions' }
+ it_behaves_like "has no link" do
+ let(:link) { "revisions" }
end
end
end
- describe 'version' do
- let(:embedded_path) { '_embedded/version' }
- let(:href_path) { '_links/version/href' }
+ describe "version" do
+ let(:embedded_path) { "_embedded/version" }
+ let(:href_path) { "_links/version/href" }
- context 'when no version set' do
- it_behaves_like 'has an empty link' do
- let(:link) { 'version' }
+ context "when no version set" do
+ it_behaves_like "has an empty link" do
+ let(:link) { "version" }
end
end
- context 'when version is set' do
+ context "when version is set" do
let!(:version) { create(:version, project:) }
before do
work_package.version = version
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'version' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "version" }
let(:href) { api_v3_paths.version(version.id) }
let(:title) { version.to_s }
end
- it 'has the version embedded' do
- expect(subject).to be_json_eql('Version'.to_json).at_path("#{embedded_path}/_type")
+ it "has the version embedded" do
+ expect(subject).to be_json_eql("Version".to_json).at_path("#{embedded_path}/_type")
expect(subject).to be_json_eql(version.name.to_json).at_path("#{embedded_path}/name")
end
end
end
- describe 'project' do
- let(:embedded_path) { '_embedded/project' }
- let(:href_path) { '_links/project/href' }
+ describe "project" do
+ let(:embedded_path) { "_embedded/project" }
+ let(:href_path) { "_links/project/href" }
- it_behaves_like 'has a titled link' do
- let(:link) { 'project' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "project" }
let(:href) { api_v3_paths.project(project.id) }
let(:title) { project.name }
end
- it 'has the project embedded' do
- expect(subject).to be_json_eql('Project'.to_json).at_path("#{embedded_path}/_type")
+ it "has the project embedded" do
+ expect(subject).to be_json_eql("Project".to_json).at_path("#{embedded_path}/_type")
expect(subject).to be_json_eql(project.name.to_json).at_path("#{embedded_path}/name")
end
end
- describe 'category' do
- let(:embedded_path) { '_embedded/category' }
- let(:href_path) { '_links/category/href' }
+ describe "category" do
+ let(:embedded_path) { "_embedded/category" }
+ let(:href_path) { "_links/category/href" }
- context 'when no category set' do
- it_behaves_like 'has an empty link' do
- let(:link) { 'category' }
+ context "when no category set" do
+ it_behaves_like "has an empty link" do
+ let(:link) { "category" }
end
end
- context 'when category is set' do
+ context "when category is set" do
let!(:category) { build_stubbed(:category) }
before do
work_package.category = category
end
- it_behaves_like 'has a titled link' do
- let(:link) { 'category' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "category" }
let(:href) { api_v3_paths.category(category.id) }
let(:title) { category.name }
end
- it 'has the category embedded' do
- expect(subject).to have_json_type(Hash).at_path('_embedded/category')
- expect(subject).to be_json_eql('Category'.to_json).at_path("#{embedded_path}/_type")
+ it "has the category embedded" do
+ expect(subject).to have_json_type(Hash).at_path("_embedded/category")
+ expect(subject).to be_json_eql("Category".to_json).at_path("#{embedded_path}/_type")
expect(subject).to be_json_eql(category.name.to_json).at_path("#{embedded_path}/name")
end
end
end
- describe 'priority' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'priority' }
+ describe "priority" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "priority" }
let(:href) { api_v3_paths.priority(priority.id) }
let(:title) { priority.name }
end
- it 'has the priority embedded' do
- expect(subject).to be_json_eql('Priority'.to_json).at_path('_embedded/priority/_type')
- expect(subject).to be_json_eql(priority.name.to_json).at_path('_embedded/priority/name')
+ it "has the priority embedded" do
+ expect(subject).to be_json_eql("Priority".to_json).at_path("_embedded/priority/_type")
+ expect(subject).to be_json_eql(priority.name.to_json).at_path("_embedded/priority/name")
end
end
- describe 'budget' do
- context 'with the user having the view_budgets permission' do
+ describe "budget" do
+ context "with the user having the view_budgets permission" do
let(:permissions) { [:view_budgets] }
- it_behaves_like 'has a titled link' do
- let(:link) { 'budget' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "budget" }
let(:href) { "/api/v3/budgets/#{budget.id}" }
let(:title) { budget.subject }
end
- it 'has the budget embedded' do
+ it "has the budget embedded" do
expect(subject)
.to be_json_eql(budget.subject.to_json)
- .at_path('_embedded/budget/subject')
+ .at_path("_embedded/budget/subject")
end
end
- context 'with the user lacking the view_budgets permission' do
- it 'has no link to the budget' do
+ context "with the user lacking the view_budgets permission" do
+ it "has no link to the budget" do
expect(subject)
- .not_to have_json_path('_links/budget')
+ .not_to have_json_path("_links/budget")
end
- it 'has no budget embedded' do
+ it "has no budget embedded" do
expect(subject)
- .not_to have_json_path('_embedded/budget')
+ .not_to have_json_path("_embedded/budget")
end
end
end
- describe 'schema' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'schema' }
+ describe "schema" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "schema" }
let(:href) do
api_v3_paths.work_package_schema(work_package.project.id, work_package.type.id)
end
end
end
- describe 'attachments' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'attachments' }
+ describe "attachments" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "attachments" }
let(:href) { api_v3_paths.attachments_by_work_package(work_package.id) }
end
- it 'embeds the attachments as collection' do
- expect(subject).to be_json_eql('Collection'.to_json).at_path('_embedded/attachments/_type')
+ it "embeds the attachments as collection" do
+ expect(subject).to be_json_eql("Collection".to_json).at_path("_embedded/attachments/_type")
end
- it_behaves_like 'has an untitled link' do
- let(:link) { 'addAttachment' }
+ it_behaves_like "has an untitled link" do
+ let(:link) { "addAttachment" }
let(:href) { api_v3_paths.attachments_by_work_package(work_package.id) }
end
- context 'when work package blocked' do
+ context "when work package blocked" do
before do
allow(work_package).to receive(:readonly_status?).and_return true
end
- it_behaves_like 'has no link' do
- let(:link) { 'addAttachment' }
+ it_behaves_like "has no link" do
+ let(:link) { "addAttachment" }
end
end
- it 'addAttachments is a post link' do
- expect(subject).to be_json_eql('post'.to_json).at_path('_links/addAttachment/method')
+ it "addAttachments is a post link" do
+ expect(subject).to be_json_eql("post".to_json).at_path("_links/addAttachment/method")
end
- context 'when user is not allowed to edit work packages' do
+ context "when user is not allowed to edit work packages" do
let(:permissions) { all_permissions - %i[edit_work_packages] }
- it_behaves_like 'has no link' do
- let(:link) { 'addAttachment' }
+ it_behaves_like "has no link" do
+ let(:link) { "addAttachment" }
end
end
end
- describe 'fileLinks' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'fileLinks' }
+ describe "fileLinks" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "fileLinks" }
let(:href) { api_v3_paths.file_links(work_package.id) }
end
- it_behaves_like 'has an untitled action link' do
+ it_behaves_like "has an untitled action link" do
let(:permission) { :manage_file_links }
- let(:link) { 'addFileLink' }
+ let(:link) { "addFileLink" }
let(:href) { api_v3_paths.file_links(work_package.id) }
- let(:method) { 'post' }
+ let(:method) { "post" }
end
- context 'when user has no permission to view file links' do
+ context "when user has no permission to view file links" do
let(:permissions) { all_permissions - %i[view_file_links] }
- it_behaves_like 'has no link' do
- let(:link) { 'fileLinks' }
+ it_behaves_like "has no link" do
+ let(:link) { "fileLinks" }
end
end
end
- context 'when the user is not watching the work package' do
- it 'has a link to watch' do
+ context "when the user is not watching the work package" do
+ it "has a link to watch" do
expect(subject)
.to be_json_eql(api_v3_paths.work_package_watchers(work_package.id).to_json)
- .at_path('_links/watch/href')
+ .at_path("_links/watch/href")
end
- it 'does not have a link to unwatch' do
- expect(subject).not_to have_json_path('_links/unwatch/href')
+ it "does not have a link to unwatch" do
+ expect(subject).not_to have_json_path("_links/unwatch/href")
end
end
- context 'when the user is watching the work package' do
+ context "when the user is watching the work package" do
let(:watchers) { [build_stubbed(:watcher, watchable: work_package, user: current_user)] }
before do
@@ -842,138 +842,138 @@
.and_return(watchers)
end
- it 'has a link to unwatch' do
+ it "has a link to unwatch" do
expect(subject)
.to be_json_eql(api_v3_paths.watcher(current_user.id, work_package.id).to_json)
- .at_path('_links/unwatch/href')
+ .at_path("_links/unwatch/href")
end
- it 'does not have a link to watch' do
- expect(subject).not_to have_json_path('_links/watch/href')
+ it "does not have a link to watch" do
+ expect(subject).not_to have_json_path("_links/watch/href")
end
end
- context 'when the user has permission to add comments' do
- it 'has a link to add comment' do
- expect(subject).to have_json_path('_links/addComment')
+ context "when the user has permission to add comments" do
+ it "has a link to add comment" do
+ expect(subject).to have_json_path("_links/addComment")
end
end
- context 'when the user does not have the permission to add comments' do
+ context "when the user does not have the permission to add comments" do
let(:permissions) { all_permissions - [:add_work_package_notes] }
- it 'does not have a link to add comment' do
- expect(subject).not_to have_json_path('_links/addComment/href')
+ it "does not have a link to add comment" do
+ expect(subject).not_to have_json_path("_links/addComment/href")
end
end
- context 'when the user has the permission to add and remove watchers' do
- it 'has a link to add watcher' do
+ context "when the user has the permission to add and remove watchers" do
+ it "has a link to add watcher" do
expect(subject).to be_json_eql(
api_v3_paths.work_package_watchers(work_package.id).to_json
)
- .at_path('_links/addWatcher/href')
+ .at_path("_links/addWatcher/href")
end
- it 'has a link to remove watcher' do
+ it "has a link to remove watcher" do
expect(subject).to be_json_eql(
- api_v3_paths.watcher('{user_id}', work_package.id).to_json
+ api_v3_paths.watcher("{user_id}", work_package.id).to_json
)
- .at_path('_links/removeWatcher/href')
+ .at_path("_links/removeWatcher/href")
end
end
- context 'when the user does not have the permission to add watchers' do
+ context "when the user does not have the permission to add watchers" do
let(:permissions) { all_permissions - [:add_work_package_watchers] }
- it 'does not have a link to add watcher' do
- expect(subject).not_to have_json_path('_links/addWatcher/href')
+ it "does not have a link to add watcher" do
+ expect(subject).not_to have_json_path("_links/addWatcher/href")
end
end
- context 'when the user does not have the permission to remove watchers' do
+ context "when the user does not have the permission to remove watchers" do
let(:permissions) { all_permissions - [:delete_work_package_watchers] }
- it 'does not have a link to remove watcher' do
- expect(subject).not_to have_json_path('_links/removeWatcher/href')
+ it "does not have a link to remove watcher" do
+ expect(subject).not_to have_json_path("_links/removeWatcher/href")
end
end
- describe 'watchers link' do
- context 'when the user is allowed to see watchers' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'watchers' }
+ describe "watchers link" do
+ context "when the user is allowed to see watchers" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "watchers" }
let(:href) { api_v3_paths.work_package_watchers work_package.id }
end
end
- context 'when the user is not allowed to see watchers' do
+ context "when the user is not allowed to see watchers" do
let(:permissions) { all_permissions - [:view_work_package_watchers] }
- it_behaves_like 'has no link' do
- let(:link) { 'watchers' }
+ it_behaves_like "has no link" do
+ let(:link) { "watchers" }
end
end
end
- describe 'relations' do
- it_behaves_like 'has an untitled link' do
- let(:link) { 'relations' }
+ describe "relations" do
+ it_behaves_like "has an untitled link" do
+ let(:link) { "relations" }
let(:href) { "/api/v3/work_packages/#{work_package.id}/relations" }
end
- context 'when the user has the permission to manage relations' do
- it 'has a link to add relation' do
- expect(subject).to have_json_path('_links/addRelation/href')
+ context "when the user has the permission to manage relations" do
+ it "has a link to add relation" do
+ expect(subject).to have_json_path("_links/addRelation/href")
end
end
- context 'when the user does not have the permission to manage relations' do
+ context "when the user does not have the permission to manage relations" do
let(:permissions) { all_permissions - [:manage_work_package_relations] }
- it 'does not have a link to add relation' do
- expect(subject).not_to have_json_path('_links/addRelation/href')
+ it "does not have a link to add relation" do
+ expect(subject).not_to have_json_path("_links/addRelation/href")
end
end
end
- context 'when the user has the permission to add work packages' do
- it 'has a link to add child' do
+ context "when the user has the permission to add work packages" do
+ it "has a link to add child" do
expect(subject).to be_json_eql("/api/v3/projects/#{project.identifier}/work_packages".to_json)
- .at_path('_links/addChild/href')
+ .at_path("_links/addChild/href")
end
end
- context 'when the user does not have the permission to add work packages' do
+ context "when the user does not have the permission to add work packages" do
let(:permissions) { all_permissions - [:add_work_packages] }
- it 'does not have a link to add child' do
- expect(subject).not_to have_json_path('_links/addChild/href')
+ it "does not have a link to add child" do
+ expect(subject).not_to have_json_path("_links/addChild/href")
end
end
- describe 'timeEntries' do
- context 'when the user has the permission to view time entries' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'timeEntries' }
+ describe "timeEntries" do
+ context "when the user has the permission to view time entries" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "timeEntries" }
let(:href) do
api_v3_paths.path_for(:time_entries,
filters: [{ work_package_id: { operator: "=", values: [work_package.id.to_s] } }])
end
- let(:title) { 'Time entries' }
+ let(:title) { "Time entries" }
end
end
- context 'when the user does not have the permission to view time entries' do
+ context "when the user does not have the permission to view time entries" do
let(:permissions) { all_permissions - [:view_time_entries] }
- it 'does not have a link to timeEntries' do
- expect(subject).not_to have_json_path('_links/timeEntries/href')
+ it "does not have a link to timeEntries" do
+ expect(subject).not_to have_json_path("_links/timeEntries/href")
end
end
end
- describe 'linked relations' do
+ describe "linked relations" do
let(:project) { create(:project, public: false) }
let(:forbidden_project) { create(:project, public: false) }
let(:user) { create(:user, member_with_permissions: { project => %i[view_work_packages edit_work_packages] }) }
@@ -983,7 +983,7 @@
allow(Setting).to receive(:cross_project_work_package_relations?).and_return(true)
end
- describe 'parent' do
+ describe "parent" do
let(:visible_parent) do
build_stubbed(:work_package) do |wp|
allow(wp)
@@ -999,67 +999,67 @@
end
end
- context 'with no parent' do
- it_behaves_like 'has an empty link' do
- let(:link) { 'parent' }
+ context "with no parent" do
+ it_behaves_like "has an empty link" do
+ let(:link) { "parent" }
end
end
- context 'when parent is visible' do
+ context "when parent is visible" do
let(:parent) { visible_parent }
- it_behaves_like 'has a titled link' do
- let(:link) { 'parent' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "parent" }
let(:href) { api_v3_paths.work_package(visible_parent.id) }
let(:title) { visible_parent.subject }
end
end
- context 'when parent not visible' do
+ context "when parent not visible" do
let(:parent) { invisible_parent }
- it_behaves_like 'has an empty link' do
- let(:link) { 'parent' }
+ it_behaves_like "has an empty link" do
+ let(:link) { "parent" }
end
end
end
- describe 'ancestors' do
+ describe "ancestors" do
let(:root) { build_stubbed(:work_package, project:) }
let(:intermediate) do
build_stubbed(:work_package, parent: root, project:)
end
- context 'when ancestors are visible' do
+ context "when ancestors are visible" do
before do
allow(work_package).to receive(:visible_ancestors)
.and_return([root, intermediate])
end
- it 'renders two items in ancestors' do
- expect(subject).to have_json_size(2).at_path('_links/ancestors')
- expect(parse_json(subject)['_links']['ancestors'][0]['title'])
+ it "renders two items in ancestors" do
+ expect(subject).to have_json_size(2).at_path("_links/ancestors")
+ expect(parse_json(subject)["_links"]["ancestors"][0]["title"])
.to eq(root.subject)
- expect(parse_json(subject)['_links']['ancestors'][1]['title'])
+ expect(parse_json(subject)["_links"]["ancestors"][1]["title"])
.to eq(intermediate.subject)
expect(work_package).to have_received(:visible_ancestors)
end
end
- context 'when ancestors are invisible' do
+ context "when ancestors are invisible" do
before do
allow(work_package).to receive(:visible_ancestors)
.and_return([])
end
- it 'renders empty ancestors' do
- expect(subject).to have_json_size(0).at_path('_links/ancestors')
+ it "renders empty ancestors" do
+ expect(subject).to have_json_size(0).at_path("_links/ancestors")
expect(work_package).to have_received(:visible_ancestors)
end
end
end
- describe 'children' do
+ describe "children" do
let(:work_package) { create(:work_package, project:) }
let!(:forbidden_work_package) do
create(:work_package,
@@ -1067,89 +1067,89 @@
parent: work_package)
end
- it { expect(subject).not_to have_json_path('_links/children') }
+ it { expect(subject).not_to have_json_path("_links/children") }
- describe 'visible and invisible children' do
+ describe "visible and invisible children" do
let!(:child) do
create(:work_package,
project:,
parent: work_package)
end
- it { expect(subject).to have_json_size(1).at_path('_links/children') }
+ it { expect(subject).to have_json_size(1).at_path("_links/children") }
it do
- expect(parse_json(subject)['_links']['children'][0]['title']).to eq(child.subject)
+ expect(parse_json(subject)["_links"]["children"][0]["title"]).to eq(child.subject)
end
end
end
end
- it_behaves_like 'has an untitled action link' do
- let(:link) { 'delete' }
+ it_behaves_like "has an untitled action link" do
+ let(:link) { "delete" }
let(:href) { api_v3_paths.work_package(work_package.id) }
let(:method) { :delete }
let(:permission) { :delete_work_packages }
end
- describe 'logTime' do
- it_behaves_like 'has a titled action link' do
- let(:link) { 'logTime' }
+ describe "logTime" do
+ it_behaves_like "has a titled action link" do
+ let(:link) { "logTime" }
let(:permission) { %i(log_time log_own_time) }
let(:href) { api_v3_paths.time_entries }
let(:title) { "Log time on #{work_package.subject}" }
end
end
- describe 'move' do
- it_behaves_like 'has a titled action link' do
- let(:link) { 'move' }
- let(:href) { work_package_path(work_package, 'move/new') }
+ describe "move" do
+ it_behaves_like "has a titled action link" do
+ let(:link) { "move" }
+ let(:href) { work_package_path(work_package, "move/new") }
let(:permission) { :move_work_packages }
let(:title) { "Move #{work_package.subject}" }
end
end
- describe 'copy' do
- it_behaves_like 'has a titled action link' do
- let(:link) { 'copy' }
- let(:href) { work_package_path(work_package, 'copy') }
+ describe "copy" do
+ it_behaves_like "has a titled action link" do
+ let(:link) { "copy" }
+ let(:href) { work_package_path(work_package, "copy") }
let(:permission) { :add_work_packages }
let(:title) { "Copy #{work_package.subject}" }
end
end
- describe 'pdf' do
- it_behaves_like 'has a titled action link' do
- let(:link) { 'pdf' }
+ describe "pdf" do
+ it_behaves_like "has a titled action link" do
+ let(:link) { "pdf" }
let(:permission) { :export_work_packages }
let(:href) { "/work_packages/#{work_package.id}.pdf" }
let(:title) { "Export as PDF" }
end
end
- describe 'atom' do
- context 'with feeds enabled', with_settings: { feeds_enabled?: true } do
- it_behaves_like 'has a titled action link' do
- let(:link) { 'atom' }
+ describe "atom" do
+ context "with feeds enabled", with_settings: { feeds_enabled?: true } do
+ it_behaves_like "has a titled action link" do
+ let(:link) { "atom" }
let(:permission) { :export_work_packages }
let(:href) { "/work_packages/#{work_package.id}.atom" }
let(:title) { "Atom feed" }
end
end
- context 'with feeds disabled', with_settings: { feeds_enabled?: false } do
+ context "with feeds disabled", with_settings: { feeds_enabled?: false } do
let(:permissions) { all_permissions + [:export_work_packages] }
- it_behaves_like 'has no link' do
- let(:link) { 'atom' }
+ it_behaves_like "has no link" do
+ let(:link) { "atom" }
end
end
end
- describe 'changeParent' do
- it_behaves_like 'has a titled action link' do
- let(:link) { 'changeParent' }
+ describe "changeParent" do
+ it_behaves_like "has a titled action link" do
+ let(:link) { "changeParent" }
let(:href) { api_v3_paths.work_package(work_package.id) }
let(:permission) { :manage_subtasks }
let(:title) { "Change parent of #{work_package.subject}" }
@@ -1157,46 +1157,46 @@
end
end
- describe 'availableWatchers' do
- it_behaves_like 'has an untitled action link' do
- let(:link) { 'availableWatchers' }
+ describe "availableWatchers" do
+ it_behaves_like "has an untitled action link" do
+ let(:link) { "availableWatchers" }
let(:href) { api_v3_paths.available_watchers(work_package.id) }
let(:permission) { :add_work_package_watchers }
end
end
- describe 'customFields' do
- it_behaves_like 'has a titled action link' do
- let(:link) { 'customFields' }
+ describe "customFields" do
+ it_behaves_like "has a titled action link" do
+ let(:link) { "customFields" }
let(:permission) { :select_custom_fields }
let(:href) { project_settings_custom_fields_path(work_package.project.identifier) }
- let(:title) { 'Custom fields' }
+ let(:title) { "Custom fields" }
end
end
- describe 'formConfiguration' do
- context 'when not admin' do
- it_behaves_like 'has no link' do
- let(:link) { 'formConfiguration' }
+ describe "formConfiguration" do
+ context "when not admin" do
+ it_behaves_like "has no link" do
+ let(:link) { "formConfiguration" }
end
end
- context 'when admin' do
+ context "when admin" do
let(:current_user) { build_stubbed(:admin) }
- it_behaves_like 'has a titled link' do
- let(:link) { 'configureForm' }
- let(:href) { edit_type_path(work_package.type_id, tab: 'form_configuration') }
- let(:title) { 'Configure form' }
+ it_behaves_like "has a titled link" do
+ let(:link) { "configureForm" }
+ let(:href) { edit_type_path(work_package.type_id, tab: "form_configuration") }
+ let(:title) { "Configure form" }
end
end
end
- describe 'customActions' do
- it 'has a collection of customActions' do
+ describe "customActions" do
+ it "has a collection of customActions" do
unassign_action = build_stubbed(:custom_action,
actions: [CustomActions::Actions::AssignedTo.new(value: nil)],
- name: 'Unassign')
+ name: "Unassign")
allow(work_package)
.to receive(:custom_actions)
.and_return([unassign_action])
@@ -1210,33 +1210,33 @@
expect(subject)
.to be_json_eql(expected.to_json)
- .at_path('_links/customActions')
+ .at_path("_links/customActions")
end
end
end
- describe '_embedded' do
- it { is_expected.to have_json_type(Object).at_path('_embedded') }
+ describe "_embedded" do
+ it { is_expected.to have_json_type(Object).at_path("_embedded") }
- describe 'status' do
- it { is_expected.to have_json_path('_embedded/status') }
+ describe "status" do
+ it { is_expected.to have_json_path("_embedded/status") }
- it { is_expected.to be_json_eql('Status'.to_json).at_path('_embedded/status/_type') }
+ it { is_expected.to be_json_eql("Status".to_json).at_path("_embedded/status/_type") }
- it { is_expected.to be_json_eql(status.name.to_json).at_path('_embedded/status/name') }
+ it { is_expected.to be_json_eql(status.name.to_json).at_path("_embedded/status/name") }
it {
- expect(subject).to be_json_eql(status.is_closed.to_json).at_path('_embedded/status/isClosed')
+ expect(subject).to be_json_eql(status.is_closed.to_json).at_path("_embedded/status/isClosed")
}
end
- describe 'activities' do
- it 'is not embedded' do
- expect(subject).not_to have_json_path('_embedded/activities')
+ describe "activities" do
+ it "is not embedded" do
+ expect(subject).not_to have_json_path("_embedded/activities")
end
end
- describe 'relations' do
+ describe "relations" do
let(:relation) do
build_stubbed(:relation,
from: work_package)
@@ -1254,30 +1254,30 @@
.and_return([relation])
end
- it 'embeds a collection' do
+ it "embeds a collection" do
expect(subject)
- .to be_json_eql('Collection'.to_json)
- .at_path('_embedded/relations/_type')
+ .to be_json_eql("Collection".to_json)
+ .at_path("_embedded/relations/_type")
end
- it 'embeds with an href containing the work_package' do
+ it "embeds with an href containing the work_package" do
expect(subject)
.to be_json_eql(api_v3_paths.work_package_relations(work_package.id).to_json)
- .at_path('_embedded/relations/_links/self/href')
+ .at_path("_embedded/relations/_links/self/href")
end
- it 'embeds the visible relations' do
+ it "embeds the visible relations" do
expect(subject)
.to be_json_eql(1.to_json)
- .at_path('_embedded/relations/total')
+ .at_path("_embedded/relations/total")
expect(subject)
.to be_json_eql(api_v3_paths.relation(relation.id).to_json)
- .at_path('_embedded/relations/_embedded/elements/0/_links/self/href')
+ .at_path("_embedded/relations/_embedded/elements/0/_links/self/href")
end
end
- describe 'fileLinks' do
+ describe "fileLinks" do
let(:storage) { build_stubbed(:nextcloud_storage) }
let(:file_link) { build_stubbed(:file_link, storage:, container: work_package) }
@@ -1285,45 +1285,45 @@
allow(work_package).to receive(:file_links).and_return([file_link])
end
- it 'embeds a collection' do
+ it "embeds a collection" do
expect(subject)
- .to be_json_eql('Collection'.to_json)
- .at_path('_embedded/fileLinks/_type')
+ .to be_json_eql("Collection".to_json)
+ .at_path("_embedded/fileLinks/_type")
end
- it 'embeds with an href containing the work_package' do
+ it "embeds with an href containing the work_package" do
expect(subject)
.to be_json_eql(api_v3_paths.file_links(work_package.id).to_json)
- .at_path('_embedded/fileLinks/_links/self/href')
+ .at_path("_embedded/fileLinks/_links/self/href")
end
- it 'embeds the visible file links' do
+ it "embeds the visible file links" do
expect(subject)
.to be_json_eql(1.to_json)
- .at_path('_embedded/fileLinks/total')
+ .at_path("_embedded/fileLinks/total")
expect(subject)
.to be_json_eql(api_v3_paths.file_link(file_link.id).to_json)
- .at_path('_embedded/fileLinks/_embedded/elements/0/_links/self/href')
+ .at_path("_embedded/fileLinks/_embedded/elements/0/_links/self/href")
end
end
- describe 'customActions' do
- it 'has an array of customActions' do
+ describe "customActions" do
+ it "has an array of customActions" do
unassign_action = build_stubbed(:custom_action,
actions: [CustomActions::Actions::AssignedTo.new(value: nil)],
- name: 'Unassign')
+ name: "Unassign")
allow(work_package)
.to receive(:custom_actions)
.and_return([unassign_action])
expect(subject)
- .to be_json_eql('Unassign'.to_json)
- .at_path('_embedded/customActions/0/name')
+ .to be_json_eql("Unassign".to_json)
+ .at_path("_embedded/customActions/0/name")
end
end
- context 'when passing timestamps' do
+ context "when passing timestamps" do
let(:timestamps) { [Timestamp.new(baseline_time), Timestamp.now] }
let(:baseline_time) { Time.zone.parse("2022-01-01") }
let(:work_pacakges) { WorkPackage.where(id: work_package.id) }
@@ -1341,8 +1341,8 @@
current_user do
create(:user,
- firstname: 'user',
- lastname: '1',
+ firstname: "user",
+ lastname: "1",
member_with_permissions: { project => %i[view_work_packages view_file_links] })
end
@@ -1356,25 +1356,25 @@
.and_call_original
end
- describe 'attributesByTimestamp' do
- it 'has an array' do
- expect(JSON.parse(subject)['_embedded']['attributesByTimestamp']).to be_an Array
+ describe "attributesByTimestamp" do
+ it "has an array" do
+ expect(JSON.parse(subject)["_embedded"]["attributesByTimestamp"]).to be_an Array
end
- it 'has the historic attributes for each timestamp when they differ from the current attributes' do
+ it "has the historic attributes for each timestamp when they differ from the current attributes" do
expect(subject)
- .to be_json_eql('The original work package'.to_json)
+ .to be_json_eql("The original work package".to_json)
.at_path("_embedded/attributesByTimestamp/0/subject")
end
- it 'skips the historic attributes when they are the same as the current attributes' do
+ it "skips the historic attributes when they are the same as the current attributes" do
expect(subject)
.to have_json_path("_embedded/attributesByTimestamp/1")
expect(subject)
.not_to have_json_path("_embedded/attributesByTimestamp/1/subject")
end
- it 'has a link to the work package at the timestamp' do
+ it "has a link to the work package at the timestamp" do
expect(subject)
.to be_json_eql(api_v3_paths.work_package(work_package.id, timestamps: [timestamps[0]]).to_json)
.at_path("_embedded/attributesByTimestamp/0/_links/self/href")
@@ -1383,8 +1383,8 @@
.at_path("_embedded/attributesByTimestamp/1/_links/self/href")
end
- it 'has no information about whether the work package matches the query filters at the timestamp ' \
- 'because there are no filters without a query' do
+ it "has no information about whether the work package matches the query filters at the timestamp " \
+ "because there are no filters without a query" do
expect(subject)
.not_to have_json_path("_embedded/attributesByTimestamp/0/_meta/matchesFilters")
expect(subject)
@@ -1392,27 +1392,27 @@
end
end
- describe '_meta' do
- describe 'matchesFilters' do
- it 'does not have this meta field without a query given' do
+ describe "_meta" do
+ describe "matchesFilters" do
+ it "does not have this meta field without a query given" do
expect(subject)
- .not_to have_json_path('_meta/matchesFilters')
+ .not_to have_json_path("_meta/matchesFilters")
end
end
end
- context 'when passing a query' do
- let(:search_term) { 'original' }
+ context "when passing a query" do
+ let(:search_term) { "original" }
let(:query) do
build(:query, user: current_user, project: nil).tap do |query|
query.filters.clear
- query.add_filter 'subject', '~', search_term
+ query.add_filter "subject", "~", search_term
query.timestamps = timestamps
end
end
- describe 'attributesByTimestamp', with_ee: %i[baseline_comparison] do
- it 'states whether the work package matches the query filters at the timestamp' do
+ describe "attributesByTimestamp", with_ee: %i[baseline_comparison] do
+ it "states whether the work package matches the query filters at the timestamp" do
expect(subject)
.to be_json_eql(true.to_json)
.at_path("_embedded/attributesByTimestamp/0/_meta/matchesFilters")
@@ -1422,35 +1422,35 @@
end
end
- describe '_links' do
- it_behaves_like 'has a titled link' do
- let(:link) { 'self' }
+ describe "_links" do
+ it_behaves_like "has a titled link" do
+ let(:link) { "self" }
let(:href) { api_v3_paths.work_package(work_package.id, timestamps:) }
let(:title) { work_package.name }
end
- context 'when changing timestamps it updates the link' do
- it_behaves_like 'has a titled link' do
+ context "when changing timestamps it updates the link" do
+ it_behaves_like "has a titled link" do
before do
representer.to_json
representer.timestamps = []
end
- let(:link) { 'self' }
+ let(:link) { "self" }
let(:href) { api_v3_paths.work_package(work_package.id) }
let(:title) { work_package.name }
end
end
end
- describe '_meta' do
- describe 'matchesFilters' do
- it 'states whether the work package matches the query filters at the last timestamp' do
+ describe "_meta" do
+ describe "matchesFilters" do
+ it "states whether the work package matches the query filters at the last timestamp" do
# If this value is false, it means that the work package has been found by the query
# at another of the given timestamps, e.g. the baseline timestamp.
expect(subject)
.to be_json_eql(false.to_json)
- .at_path('_meta/matchesFilters')
+ .at_path("_meta/matchesFilters")
end
end
end
@@ -1458,8 +1458,8 @@
end
end
- describe 'caching' do
- it 'is based on the representer\'s cache_key' do
+ describe "caching" do
+ it "is based on the representer's cache_key" do
allow(OpenProject::Cache)
.to receive(:fetch)
.and_return({ _links: {} }.to_json)
@@ -1475,7 +1475,7 @@
.to have_received(:fetch).with(representer.json_cache_key)
end
- describe '#json_cache_key' do
+ describe "#json_cache_key" do
let(:category) { build_stubbed(:category) }
let(:assigned_to) { build_stubbed(:user) }
let(:responsible) { build_stubbed(:user) }
@@ -1486,18 +1486,18 @@
work_package.responsible = responsible
end
- it 'includes the name of the representer class' do
+ it "includes the name of the representer class" do
expect(representer.json_cache_key)
- .to include('API', 'V3', 'WorkPackages', 'WorkPackageRepresenter')
+ .to include("API", "V3", "WorkPackages", "WorkPackageRepresenter")
end
- it 'changes when the locale changes' do
+ it "changes when the locale changes" do
expect(
I18n.with_locale(:fr) { representer.json_cache_key }
).not_to eq(representer.json_cache_key)
end
- it 'changes when the feeds_enabled? setting is switched' do
+ it "changes when the feeds_enabled? setting is switched" do
expect do
allow(Setting)
.to receive(:feeds_enabled?)
@@ -1505,21 +1505,21 @@
end.to change(representer, :json_cache_key)
end
- it 'changes when the work_package_done_ratio setting is changes' do
+ it "changes when the work_package_done_ratio setting is changes" do
expect do
allow(Setting)
.to receive(:work_package_done_ratio)
- .and_return('status')
+ .and_return("status")
end.to change(representer, :json_cache_key)
end
- it 'changes when the work_package is updated' do
+ it "changes when the work_package is updated" do
expect do
work_package.updated_at = 20.seconds.from_now
end.to change(representer, :json_cache_key)
end
- it 'factors in the eager loaded cache_checksum' do
+ it "factors in the eager loaded cache_checksum" do
allow(work_package)
.to receive(:cache_checksum)
.and_return(srand)
@@ -1533,12 +1533,12 @@
end
end
- describe 'parsing' do
- describe 'duration' do
+ describe "parsing" do
+ describe "duration" do
subject { representer }
- it 'parses form iso8601 format' do
- subject.duration = 'P6D'
+ it "parses form iso8601 format" do
+ subject.duration = "P6D"
expect(subject.represented.duration).to eq(6)
end
end
diff --git a/spec/lib/api/v3/work_packages/work_package_sql_representer_rendering_spec.rb b/spec/lib/api/v3/work_packages/work_package_sql_representer_rendering_spec.rb
index 08e8c0caff49..3a82a1dfb20e 100644
--- a/spec/lib/api/v3/work_packages/work_package_sql_representer_rendering_spec.rb
+++ b/spec/lib/api/v3/work_packages/work_package_sql_representer_rendering_spec.rb
@@ -24,9 +24,9 @@
#
# See COPYRIGHT and LICENSE files for more details.
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe API::V3::WorkPackages::WorkPackageSqlRepresenter, 'rendering' do
+RSpec.describe API::V3::WorkPackages::WorkPackageSqlRepresenter, "rendering" do
include API::V3::Utilities::PathHelper
subject(:json) do
@@ -56,14 +56,14 @@
let(:author) { create(:user) }
let(:responsible) { nil }
- let(:select) { { '*' => {} } }
+ let(:select) { { "*" => {} } }
current_user do
create(:user)
end
- context 'when rendering all supported properties' do
- context 'for a work_package' do
+ context "when rendering all supported properties" do
+ context "for a work_package" do
let(:expected) do
{
_type: "WorkPackage",
@@ -94,13 +94,13 @@
}
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql(expected.to_json)
end
end
- context 'for a milestone work_package' do
+ context "for a milestone work_package" do
let(:is_milestone) { true }
let(:expected) do
{
@@ -131,16 +131,16 @@
}
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(json).to be_json_eql(expected.to_json)
end
end
end
- shared_examples_for 'principal link' do |link_name, only_user: false|
+ shared_examples_for "principal link" do |link_name, only_user: false|
let(:select) { { link_name => {} } }
- context 'with a user' do
+ context "with a user" do
let(:principal_object) { create(:user) }
let(:expected) do
@@ -154,14 +154,14 @@
}
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql(expected.to_json)
end
end
unless only_user
- context 'with a group' do
+ context "with a group" do
let(:principal_object) { create(:group) }
let(:expected) do
@@ -175,13 +175,13 @@
}
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql(expected.to_json)
end
end
- context 'with a placeholder user' do
+ context "with a placeholder user" do
let(:principal_object) { create(:placeholder_user) }
let(:expected) do
@@ -195,7 +195,7 @@
}
end
- it 'renders as expected' do
+ it "renders as expected" do
expect(json)
.to be_json_eql(expected.to_json)
end
@@ -203,20 +203,20 @@
end
end
- describe 'assignee link' do
- it_behaves_like 'principal link', 'assignee' do
+ describe "assignee link" do
+ it_behaves_like "principal link", "assignee" do
let(:assignee) { principal_object }
end
end
- describe 'responsible link' do
- it_behaves_like 'principal link', 'responsible' do
+ describe "responsible link" do
+ it_behaves_like "principal link", "responsible" do
let(:responsible) { principal_object }
end
end
- describe 'author link' do
- it_behaves_like 'principal link', 'author', only_user: true do
+ describe "author link" do
+ it_behaves_like "principal link", "author", only_user: true do
let(:author) { principal_object }
end
end
diff --git a/spec/lib/api/v3/work_packages/work_package_sums_representer_spec.rb b/spec/lib/api/v3/work_packages/work_package_sums_representer_spec.rb
index e2c7ff6254dd..732a48bb2cab 100644
--- a/spec/lib/api/v3/work_packages/work_package_sums_representer_spec.rb
+++ b/spec/lib/api/v3/work_packages/work_package_sums_representer_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe API::V3::WorkPackages::WorkPackageSumsRepresenter do
let(:custom_field) do
@@ -37,7 +37,7 @@
end
end
let(:sums) do
- double('sums',
+ double("sums",
story_points: 5,
remaining_hours: 10,
estimated_hours: 5,
@@ -54,50 +54,50 @@
subject { representer.to_json }
- context 'estimated_time' do
- it 'is represented' do
- expected = 'PT5H'
- expect(subject).to be_json_eql(expected.to_json).at_path('estimatedTime')
+ context "estimated_time" do
+ it "is represented" do
+ expected = "PT5H"
+ expect(subject).to be_json_eql(expected.to_json).at_path("estimatedTime")
end
end
- context 'remainingTime' do
- it 'is represented' do
- expected = 'PT10H'
- expect(subject).to be_json_eql(expected.to_json).at_path('remainingTime')
+ context "remainingTime" do
+ it "is represented" do
+ expected = "PT10H"
+ expect(subject).to be_json_eql(expected.to_json).at_path("remainingTime")
end
end
- context 'storyPoints' do
- it 'is represented' do
- expect(subject).to be_json_eql(sums.story_points.to_json).at_path('storyPoints')
+ context "storyPoints" do
+ it "is represented" do
+ expect(subject).to be_json_eql(sums.story_points.to_json).at_path("storyPoints")
end
end
- context 'materialCosts' do
- it 'is represented' do
+ context "materialCosts" do
+ it "is represented" do
expected = "5.00 EUR"
- expect(subject).to be_json_eql(expected.to_json).at_path('materialCosts')
+ expect(subject).to be_json_eql(expected.to_json).at_path("materialCosts")
end
end
- context 'laborCosts' do
- it 'is represented' do
+ context "laborCosts" do
+ it "is represented" do
expected = "10.00 EUR"
- expect(subject).to be_json_eql(expected.to_json).at_path('laborCosts')
+ expect(subject).to be_json_eql(expected.to_json).at_path("laborCosts")
end
end
- context 'overallCosts' do
- it 'is represented' do
+ context "overallCosts" do
+ it "is represented" do
expected = "15.00 EUR"
- expect(subject).to be_json_eql(expected.to_json).at_path('overallCosts')
+ expect(subject).to be_json_eql(expected.to_json).at_path("overallCosts")
end
end
- context 'custom field x' do
- it 'is represented' do
- expect(subject).to be_json_eql(sums.custom_field_1.to_json).at_path('customField1')
+ context "custom field x" do
+ it "is represented" do
+ expect(subject).to be_json_eql(sums.custom_field_1.to_json).at_path("customField1")
end
end
end
diff --git a/spec/lib/core_extensions/squish_sql_spec.rb b/spec/lib/core_extensions/squish_sql_spec.rb
index cd61de0b655e..0a7d9e16cc22 100644
--- a/spec/lib/core_extensions/squish_sql_spec.rb
+++ b/spec/lib/core_extensions/squish_sql_spec.rb
@@ -26,12 +26,12 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe CoreExtensions::SquishSql do
using described_class
- it 'removes single line SQL comments' do
+ it "removes single line SQL comments" do
sql = <<~SQL.squish
-- select existing users from given IDs
--
diff --git a/spec/lib/core_extensions/to_localized_slug_spec.rb b/spec/lib/core_extensions/to_localized_slug_spec.rb
index 1a4f90526331..956060b16716 100644
--- a/spec/lib/core_extensions/to_localized_slug_spec.rb
+++ b/spec/lib/core_extensions/to_localized_slug_spec.rb
@@ -1,46 +1,46 @@
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe CoreExtensions::String, '#to_localized_slug' do
+RSpec.describe CoreExtensions::String, "#to_localized_slug" do
let(:input) { "dübelbädel! ..." }
let(:slug) { input.to_localized_slug }
- it 'uses english by default' do
- expect(slug).to eq 'dubelbadel-dot-dot-dot'
+ it "uses english by default" do
+ expect(slug).to eq "dubelbadel-dot-dot-dot"
end
- context 'with a limit and german locale' do
+ context "with a limit and german locale" do
let(:slug) { input.to_localized_slug(locale: :de, limit: 4) }
- it 'limits the localized string' do
- expect(slug).to eq 'dueb'
+ it "limits the localized string" do
+ expect(slug).to eq "dueb"
end
end
- context 'with a limit and english locale' do
+ context "with a limit and english locale" do
let(:slug) { input.to_localized_slug(locale: :en, limit: 4) }
- it 'limits the localized string' do
- expect(slug).to eq 'dube'
+ it "limits the localized string" do
+ expect(slug).to eq "dube"
end
end
- context 'with a different I18n.locale' do
+ context "with a different I18n.locale" do
before do
I18n.locale = :de
end
- it 'uses that locale but does not change the backend locale' do
+ it "uses that locale but does not change the backend locale" do
expect { slug }.not_to change { Stringex::Localization.locale }
- expect(slug).to eq 'duebelbaedel-punkt-punkt-punkt'
+ expect(slug).to eq "duebelbaedel-punkt-punkt-punkt"
end
end
- context 'passing in the locale' do
+ context "passing in the locale" do
let(:slug) { input.to_localized_slug(locale: :de) }
- it 'uses that locale but does not change the backend locale' do
+ it "uses that locale but does not change the backend locale" do
expect { slug }.not_to change { Stringex::Localization.locale }
- expect(slug).to eq 'duebelbaedel-punkt-punkt-punkt'
+ expect(slug).to eq "duebelbaedel-punkt-punkt-punkt"
end
end
end
diff --git a/spec/lib/custom_field_form_builder_spec.rb b/spec/lib/custom_field_form_builder_spec.rb
index a8f7a299a4be..200a666147a4 100644
--- a/spec/lib/custom_field_form_builder_spec.rb
+++ b/spec/lib/custom_field_form_builder_spec.rb
@@ -25,13 +25,13 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'ostruct'
+require "spec_helper"
+require "ostruct"
RSpec.describe CustomFieldFormBuilder do
include Capybara::RSpecMatchers
- let(:helper) { ActionView::Base.new(ActionView::LookupContext.new(''), {}, @controller) }
+ let(:helper) { ActionView::Base.new(ActionView::LookupContext.new(""), {}, @controller) }
let(:builder) { described_class.new(:user, resource, helper, builder_options) }
let(:builder_options) do
{
@@ -40,8 +40,8 @@
}
end
- describe '#custom_field' do
- let(:options) { { class: 'custom-class' } }
+ describe "#custom_field" do
+ let(:options) { { class: "custom-class" } }
let(:custom_field) do
build_stubbed(:custom_field)
@@ -67,37 +67,37 @@
builder.cf_form_field options
end
- it_behaves_like 'labelled by default'
- it_behaves_like 'wrapped in field-container by default' do
+ it_behaves_like "labelled by default"
+ it_behaves_like "wrapped in field-container by default" do
let(:container_count) { 2 }
end
- context 'for a bool custom field' do
- it_behaves_like 'wrapped in container', 'check-box-container' do
+ context "for a bool custom field" do
+ it_behaves_like "wrapped in container", "check-box-container" do
let(:container_count) { 2 }
end
- it 'outputs element' do
+ it "outputs element" do
expect(output).to be_html_eql(%{
- }).at_path('input:nth-of-type(2)')
+ }).at_path("input:nth-of-type(2)")
end
end
- context 'for a date custom field' do
+ context "for a date custom field" do
before do
- custom_field.field_format = 'date'
+ custom_field.field_format = "date"
end
- it_behaves_like 'wrapped in container', 'field-container' do
+ it_behaves_like "wrapped in container", "field-container" do
let(:container_count) { 2 }
end
- it 'outputs element' do
+ it "outputs element" do
expect(output).to be_html_eql(
<<~HTML
HTML
- ).at_path('op-basic-single-date-picker')
+ ).at_path("op-basic-single-date-picker")
end
end
- context 'for a text custom field' do
+ context "for a text custom field" do
before do
- custom_field.field_format = 'text'
+ custom_field.field_format = "text"
end
- it_behaves_like 'wrapped in container', 'text-area-container' do
+ it_behaves_like "wrapped in container", "text-area-container" do
let(:container_count) { 2 }
end
- it 'outputs element' do
+ it "outputs element" do
expect(output).to be_html_eql(%{
- }).at_path('textarea')
+ }).at_path("textarea")
end
end
- context 'for a string custom field' do
+ context "for a string custom field" do
before do
- custom_field.field_format = 'string'
+ custom_field.field_format = "string"
end
- it_behaves_like 'wrapped in container', 'text-field-container' do
+ it_behaves_like "wrapped in container", "text-field-container" do
let(:container_count) { 2 }
end
- it 'outputs element' do
+ it "outputs element" do
expect(output).to be_html_eql(%{
- }).at_path('input')
+ }).at_path("input")
end
end
- context 'for an int custom field' do
+ context "for an int custom field" do
before do
- custom_field.field_format = 'int'
+ custom_field.field_format = "int"
end
- it_behaves_like 'wrapped in container', 'text-field-container' do
+ it_behaves_like "wrapped in container", "text-field-container" do
let(:container_count) { 2 }
end
- it 'outputs element' do
+ it "outputs element" do
expect(output).to be_html_eql(%{
- }).at_path('input')
+ }).at_path("input")
end
end
- context 'for a float custom field' do
+ context "for a float custom field" do
before do
- custom_field.field_format = 'float'
+ custom_field.field_format = "float"
end
- it_behaves_like 'wrapped in container', 'text-field-container' do
+ it_behaves_like "wrapped in container", "text-field-container" do
let(:container_count) { 2 }
end
- it 'outputs element' do
+ it "outputs element" do
expect(output).to be_html_eql(%{
- }).at_path('input')
+ }).at_path("input")
end
end
- context 'for a list custom field' do
+ context "for a list custom field" do
let(:custom_field) do
create(:list_wp_custom_field,
custom_options: [custom_option])
end
let(:custom_option) do
- create(:custom_option, value: 'my_option')
+ create(:custom_option, value: "my_option")
end
- it_behaves_like 'wrapped in container', 'select-container' do
+ it_behaves_like "wrapped in container", "select-container" do
let(:container_count) { 2 }
end
- it 'outputs element' do
+ it "outputs element" do
expect(output).to be_html_eql(%{
- }).at_path('select')
+ }).at_path("select")
end
- context 'which is required and has no default value' do
+ context "which is required and has no default value" do
before do
custom_field.update(is_required: true)
end
- it 'outputs element' do
+ it "outputs element" do
expect(output).to be_html_eql(%{
- }).at_path('select')
+ }).at_path("select")
end
end
- context 'which is required and a default value' do
+ context "which is required and a default value" do
before do
custom_field.update(is_required: true)
custom_option.update(default_value: true)
end
- it 'outputs element' do
+ it "outputs element" do
expect(output).to be_html_eql(%{
- }).at_path('select')
+ }).at_path("select")
end
end
end
- context 'for a user custom field' do
+ context "for a user custom field" do
let(:project) { build_stubbed(:project) }
let(:user1) { build_stubbed(:user) }
let(:user2) { build_stubbed(:user) }
@@ -257,7 +257,7 @@
let(:resource) { project }
before do
- custom_field.field_format = 'user'
+ custom_field.field_format = "user"
allow(project)
.to receive(custom_field.attribute_getter)
@@ -268,11 +268,11 @@
.and_return([user1, user2])
end
- it_behaves_like 'wrapped in container', 'select-container' do
+ it_behaves_like "wrapped in container", "select-container" do
let(:container_count) { 2 }
end
- it 'outputs element' do
+ it "outputs element" do
expect(output).to be_html_eql(%{
- }).at_path('select')
+ }).at_path("select")
end
- context 'which is required and has no default value' do
+ context "which is required and has no default value" do
before do
custom_field.is_required = true
end
- it 'outputs element' do
+ it "outputs element" do
expect(output).to be_html_eql(%{
- }).at_path('select')
+ }).at_path("select")
end
end
end
- context 'for a version custom field' do
+ context "for a version custom field" do
let(:project) { build_stubbed(:project) }
let(:version1) { build_stubbed(:version) }
let(:version2) { build_stubbed(:version) }
@@ -313,7 +313,7 @@
let(:resource) { project }
before do
- custom_field.field_format = 'version'
+ custom_field.field_format = "version"
allow(project)
.to receive(custom_field.attribute_getter)
.and_return typed_value
@@ -323,11 +323,11 @@
.and_return([version1, version2])
end
- it_behaves_like 'wrapped in container', 'select-container' do
+ it_behaves_like "wrapped in container", "select-container" do
let(:container_count) { 2 }
end
- it 'outputs element' do
+ it "outputs element" do
expect(output).to be_html_eql(%{
- }).at_path('select')
+ }).at_path("select")
end
- context 'which is required and has no default value' do
+ context "which is required and has no default value" do
before do
custom_field.is_required = true
end
- it 'outputs element' do
+ it "outputs element" do
expect(output).to be_html_eql(%{
- }).at_path('select')
+ }).at_path("select")
end
end
end
diff --git a/spec/lib/database_spec.rb b/spec/lib/database_spec.rb
index 6fdb8b535be4..c2d46ed9d080 100644
--- a/spec/lib/database_spec.rb
+++ b/spec/lib/database_spec.rb
@@ -25,7 +25,7 @@
#
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::Database do
before do
@@ -36,24 +36,24 @@
described_class.instance_variable_set(:@version, nil)
end
- it 'returns the correct identifier' do
- allow(OpenProject::Database).to receive(:adapter_name).and_return 'PostgresQL'
+ it "returns the correct identifier" do
+ allow(OpenProject::Database).to receive(:adapter_name).and_return "PostgresQL"
expect(OpenProject::Database.name).to equal(:postgresql)
end
- it 'is able to use the helper methods' do
- allow(OpenProject::Database).to receive(:adapter_name).and_return 'PostgresQL'
+ it "is able to use the helper methods" do
+ allow(OpenProject::Database).to receive(:adapter_name).and_return "PostgresQL"
expect(OpenProject::Database.postgresql?).to equal(true)
end
- it 'returns a version string for PostgreSQL' do
- allow(OpenProject::Database).to receive(:adapter_name).and_return 'PostgreSQL'
- raw_version = 'PostgreSQL 8.3.11 on x86_64-pc-linux-gnu, compiled by GCC gcc-4.3.real (Debian 4.3.2-1.1) 4.3.2'
+ it "returns a version string for PostgreSQL" do
+ allow(OpenProject::Database).to receive(:adapter_name).and_return "PostgreSQL"
+ raw_version = "PostgreSQL 8.3.11 on x86_64-pc-linux-gnu, compiled by GCC gcc-4.3.real (Debian 4.3.2-1.1) 4.3.2"
allow(ActiveRecord::Base.connection).to receive(:select_value).and_return raw_version
- expect(OpenProject::Database.version).to eq('8.3.11')
+ expect(OpenProject::Database.version).to eq("8.3.11")
expect(OpenProject::Database.version(true)).to eq(raw_version)
end
end
diff --git a/spec/lib/deprecated_alias_spec.rb b/spec/lib/deprecated_alias_spec.rb
index 0098b49775bd..c1f07c2b0359 100644
--- a/spec/lib/deprecated_alias_spec.rb
+++ b/spec/lib/deprecated_alias_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe DeprecatedAlias do
let(:clazz) do
@@ -34,7 +34,7 @@
extend DeprecatedAlias
def secret_key
- 'happiness'
+ "happiness"
end
deprecated_alias :special_key, :secret_key
end
@@ -55,7 +55,7 @@ def secret_key
.with(deprecation_warning, an_instance_of(Array))
end
- it 'aliases the method' do
- expect(object.special_key).to eq('happiness')
+ it "aliases the method" do
+ expect(object.special_key).to eq("happiness")
end
end
diff --git a/spec/lib/i18n/pluralization_spec.rb b/spec/lib/i18n/pluralization_spec.rb
index 089e93056246..e723654d5c1e 100644
--- a/spec/lib/i18n/pluralization_spec.rb
+++ b/spec/lib/i18n/pluralization_spec.rb
@@ -26,10 +26,10 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
-RSpec.describe I18n, 'pluralization', type: :helper do
- describe 'with slowenian language and the :two plural key missing' do
+RSpec.describe I18n, "pluralization", type: :helper do
+ describe "with slowenian language and the :two plural key missing" do
before do
I18n.locale = :sl
allow(I18n.backend)
@@ -42,16 +42,16 @@
.and_return({ one: "1 projekt", other: "%s projektov", zero: "Brez projektov" })
end
- it 'allows to pluralize without exceptions (Regression #37607)', :aggregate_failures do
- expect(I18n.t(:label_x_projects, count: 0)).to eq 'Brez projektov'
- expect(I18n.t(:label_x_projects, count: 1)).to eq '1 projekt'
- expect(I18n.t(:label_x_projects, count: 2)).to eq '2 projektov'
- expect(I18n.t(:label_x_projects, count: 10)).to eq '10 projektov'
- expect(I18n.t(:label_x_projects, count: 20)).to eq '20 projektov'
+ it "allows to pluralize without exceptions (Regression #37607)", :aggregate_failures do
+ expect(I18n.t(:label_x_projects, count: 0)).to eq "Brez projektov"
+ expect(I18n.t(:label_x_projects, count: 1)).to eq "1 projekt"
+ expect(I18n.t(:label_x_projects, count: 2)).to eq "2 projektov"
+ expect(I18n.t(:label_x_projects, count: 10)).to eq "10 projektov"
+ expect(I18n.t(:label_x_projects, count: 20)).to eq "20 projektov"
end
end
- describe 'with slowenian language and the :other plural key missing' do
+ describe "with slowenian language and the :other plural key missing" do
before do
I18n.locale = :sl
allow(I18n.backend)
@@ -64,12 +64,12 @@
.and_return({ one: "1 projekt", zero: "Brez projektov" })
end
- it 'falls back to english translation (Regression #37607)', :aggregate_failures do
- expect(I18n.t(:label_x_projects, count: 0)).to eq 'Brez projektov'
- expect(I18n.t(:label_x_projects, count: 1)).to eq '1 projekt'
- expect(I18n.t(:label_x_projects, count: 2)).to eq '2 projects'
- expect(I18n.t(:label_x_projects, count: 10)).to eq '10 projects'
- expect(I18n.t(:label_x_projects, count: 20)).to eq '20 projects'
+ it "falls back to english translation (Regression #37607)", :aggregate_failures do
+ expect(I18n.t(:label_x_projects, count: 0)).to eq "Brez projektov"
+ expect(I18n.t(:label_x_projects, count: 1)).to eq "1 projekt"
+ expect(I18n.t(:label_x_projects, count: 2)).to eq "2 projects"
+ expect(I18n.t(:label_x_projects, count: 10)).to eq "10 projects"
+ expect(I18n.t(:label_x_projects, count: 20)).to eq "20 projects"
end
end
end
diff --git a/spec/lib/journal_formatter/active_status_spec.rb b/spec/lib/journal_formatter/active_status_spec.rb
index 3fee81b05161..9afa81479351 100644
--- a/spec/lib/journal_formatter/active_status_spec.rb
+++ b/spec/lib/journal_formatter/active_status_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::JournalFormatter::ActiveStatus do
let(:instance) { described_class.new(build(:project_journal)) }
diff --git a/spec/lib/journal_formatter/attachment_spec.rb b/spec/lib/journal_formatter/attachment_spec.rb
index fc5c7d00b86d..9affb4a9a669 100644
--- a/spec/lib/journal_formatter/attachment_spec.rb
+++ b/spec/lib/journal_formatter/attachment_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::JournalFormatter::Attachment do
include ApplicationHelper
@@ -47,37 +47,37 @@ def self.default_url_options
subject(:instance) { described_class.new(journal) }
- describe '#render' do
- describe 'WITH the first value being nil, and the second an id as string' do
- it 'adds an attachment added text' do
+ describe "#render" do
+ describe "WITH the first value being nil, and the second an id as string" do
+ it "adds an attachment added text" do
link = "#{Setting.protocol}://#{Setting.host_name}/api/v3/attachments/#{attachment.id}/content"
expect(instance.render(key, [nil, attachment.filename.to_s]))
.to eq(I18n.t(:text_journal_attachment_added,
- label: "#{I18n.t(:'activerecord.models.attachment')}",
+ label: "#{I18n.t(:"activerecord.models.attachment")}",
value: "#{attachment.filename}"))
end
- context 'WITH a relative_url_root' do
+ context "WITH a relative_url_root" do
before do
allow(OpenProject::Configuration)
.to receive(:rails_relative_url_root)
- .and_return('/blubs')
+ .and_return("/blubs")
end
- it 'adds an attachment added text' do
+ it "adds an attachment added text" do
link = "#{Setting.protocol}://#{Setting.host_name}/blubs/api/v3/attachments/#{attachment.id}/content"
expect(instance.render(key, [nil, attachment.filename.to_s]))
.to eq(I18n.t(:text_journal_attachment_added,
- label: "#{I18n.t(:'activerecord.models.attachment')}",
+ label: "#{I18n.t(:"activerecord.models.attachment")}",
value: "#{attachment.filename}"))
end
end
end
- describe 'WITH the first value being an id as string, and the second nil' do
+ describe "WITH the first value being an id as string, and the second nil" do
let(:expected) do
I18n.t(:text_journal_attachment_deleted,
- label: "#{I18n.t(:'activerecord.models.attachment')}",
+ label: "#{I18n.t(:"activerecord.models.attachment")}",
old: "#{attachment.filename}")
end
@@ -88,7 +88,7 @@ def self.default_url_options
WITH specifying not to output html" do
let(:expected) do
I18n.t(:text_journal_attachment_added,
- label: I18n.t(:'activerecord.models.attachment'),
+ label: I18n.t(:"activerecord.models.attachment"),
value: attachment.filename)
end
@@ -99,7 +99,7 @@ def self.default_url_options
WITH specifying not to output html" do
let(:expected) do
I18n.t(:text_journal_attachment_deleted,
- label: I18n.t(:'activerecord.models.attachment'),
+ label: I18n.t(:"activerecord.models.attachment"),
old: attachment.filename)
end
diff --git a/spec/lib/journal_formatter/attribute_spec.rb b/spec/lib/journal_formatter/attribute_spec.rb
index 3557819e87d5..fb79a7e7cd56 100644
--- a/spec/lib/journal_formatter/attribute_spec.rb
+++ b/spec/lib/journal_formatter/attribute_spec.rb
@@ -28,26 +28,26 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe JournalFormatter::Attribute do
- describe '.render' do
+ describe ".render" do
let(:journal) { build_stubbed(:work_package_journal) }
let(:instance) { described_class.new(journal) }
- context 'with two string values where one is longer than 100 characters' do
- let(:old_value) { 'For strings longer than 100 characters, a line break is added between values for a better readability' }
- let(:new_value) { 'Hello, World!' }
+ context "with two string values where one is longer than 100 characters" do
+ let(:old_value) { "For strings longer than 100 characters, a line break is added between values for a better readability" }
+ let(:new_value) { "Hello, World!" }
- it 'adds a newline between values' do
- expect(instance.render('name', [old_value, new_value]))
+ it "adds a newline between values" do
+ expect(instance.render("name", [old_value, new_value]))
.to eq(I18n.t(:text_journal_changed_plain,
label: "Name",
linebreak: " ",
old: "#{old_value}",
new: "#{new_value}"))
- expect(instance.render('name', [old_value, new_value], html: false))
+ expect(instance.render("name", [old_value, new_value], html: false))
.to eq(I18n.t(:text_journal_changed_plain,
label: "Name",
linebreak: "\n",
diff --git a/spec/lib/journal_formatter/cause_spec.rb b/spec/lib/journal_formatter/cause_spec.rb
index 8f134e473d44..213a7e80ad99 100644
--- a/spec/lib/journal_formatter/cause_spec.rb
+++ b/spec/lib/journal_formatter/cause_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::JournalFormatter::Cause do
include ApplicationHelper
@@ -45,7 +45,7 @@
subject { instance.render("cause", [nil, cause], html:) }
- context 'when the change was caused by a change to the parent' do
+ context "when the change was caused by a change to the parent" do
let(:cause) do
{
"type" => "work_package_parent_changed_times",
@@ -53,10 +53,10 @@
}
end
- context 'when rendering HTML variant' do
+ context "when rendering HTML variant" do
let(:html) { true }
- context 'when the user is able to access the related work package' do
+ context "when the user is able to access the related work package" do
before do
allow(WorkPackage).to receive(:visible).with(User.current).and_return(WorkPackage.where(id: work_package.id))
end
@@ -67,7 +67,7 @@
end
end
- context 'when the user is not able to access the related work package' do
+ context "when the user is not able to access the related work package" do
before do
allow(WorkPackage).to receive(:visible).with(User.current).and_return(WorkPackage.none)
end
@@ -79,10 +79,10 @@
end
end
- context 'when rendering raw variant' do
+ context "when rendering raw variant" do
let(:html) { false }
- context 'when the user is able to access the related work package' do
+ context "when the user is able to access the related work package" do
before do
allow(WorkPackage).to receive(:visible).with(User.current).and_return(WorkPackage.where(id: work_package.id))
end
@@ -95,7 +95,7 @@
end
end
- context 'when the user is not able to access the related work package' do
+ context "when the user is not able to access the related work package" do
before do
allow(WorkPackage).to receive(:visible).with(User.current).and_return(WorkPackage.none)
end
@@ -108,7 +108,7 @@
end
end
- context 'when the change was caused by a change to a predecessor' do
+ context "when the change was caused by a change to a predecessor" do
let(:cause) do
{
"type" => "work_package_predecessor_changed_times",
@@ -116,10 +116,10 @@
}
end
- context 'when rendering HTML variant' do
+ context "when rendering HTML variant" do
let(:html) { true }
- context 'when the user is able to access the related work package' do
+ context "when the user is able to access the related work package" do
before do
allow(WorkPackage).to receive(:visible).with(User.current).and_return(WorkPackage.where(id: work_package.id))
end
@@ -130,7 +130,7 @@
end
end
- context 'when the user is not able to access the related work package' do
+ context "when the user is not able to access the related work package" do
before do
allow(WorkPackage).to receive(:visible).with(User.current).and_return(WorkPackage.none)
end
@@ -142,10 +142,10 @@
end
end
- context 'when rendering raw variant' do
+ context "when rendering raw variant" do
let(:html) { false }
- context 'when the user is able to access the related work package' do
+ context "when the user is able to access the related work package" do
before do
allow(WorkPackage).to receive(:visible).with(User.current).and_return(WorkPackage.where(id: work_package.id))
end
@@ -158,7 +158,7 @@
end
end
- context 'when the user is not able to access the related work package' do
+ context "when the user is not able to access the related work package" do
before do
allow(WorkPackage).to receive(:visible).with(User.current).and_return(WorkPackage.none)
end
@@ -171,7 +171,7 @@
end
end
- context 'when the change was caused by a change to a child' do
+ context "when the change was caused by a change to a child" do
let(:cause) do
{
"type" => "work_package_children_changed_times",
@@ -179,10 +179,10 @@
}
end
- context 'when rendering HTML variant' do
+ context "when rendering HTML variant" do
let(:html) { true }
- context 'when the user is able to access the related work package' do
+ context "when the user is able to access the related work package" do
before do
allow(WorkPackage).to receive(:visible).with(User.current).and_return(WorkPackage.where(id: work_package.id))
end
@@ -193,7 +193,7 @@
end
end
- context 'when the user is not able to access the related work package' do
+ context "when the user is not able to access the related work package" do
before do
allow(WorkPackage).to receive(:visible).with(User.current).and_return(WorkPackage.none)
end
@@ -205,10 +205,10 @@
end
end
- context 'when rendering raw variant' do
+ context "when rendering raw variant" do
let(:html) { false }
- context 'when the user is able to access the related work package' do
+ context "when the user is able to access the related work package" do
before do
allow(WorkPackage).to receive(:visible).with(User.current).and_return(WorkPackage.where(id: work_package.id))
end
@@ -221,7 +221,7 @@
end
end
- context 'when the user is not able to access the related work package' do
+ context "when the user is not able to access the related work package" do
before do
allow(WorkPackage).to receive(:visible).with(User.current).and_return(WorkPackage.none)
end
@@ -234,10 +234,10 @@
end
end
- context 'when the change was caused by working day changes' do
+ context "when the change was caused by working day changes" do
let(:cause) do
{
- "type" => 'working_days_changed',
+ "type" => "working_days_changed",
"changed_days" => {
"working_days" => {
"2" => false,
@@ -252,7 +252,7 @@
}
end
- context 'when rendering HTML variant' do
+ context "when rendering HTML variant" do
let(:html) { true }
it do
@@ -267,7 +267,7 @@
end
end
- context 'when rendering raw variant' do
+ context "when rendering raw variant" do
let(:html) { false }
it do
@@ -283,15 +283,15 @@
end
end
- context 'when the change was caused by a system update' do
+ context "when the change was caused by a system update" do
let(:cause) do
{
- "type" => 'system_update',
- "feature" => 'file_links_journal'
+ "type" => "system_update",
+ "feature" => "file_links_journal"
}
end
- context 'when rendering HTML variant' do
+ context "when rendering HTML variant" do
let(:html) { true }
it do
@@ -300,7 +300,7 @@
end
end
- context 'when rendering raw variant' do
+ context "when rendering raw variant" do
let(:html) { false }
it do
diff --git a/spec/lib/journal_formatter/custom_field_spec.rb b/spec/lib/journal_formatter/custom_field_spec.rb
index d812570eef4c..32f6c7b422c3 100644
--- a/spec/lib/journal_formatter/custom_field_spec.rb
+++ b/spec/lib/journal_formatter/custom_field_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::JournalFormatter::CustomField do
include CustomFieldsHelper
@@ -51,9 +51,9 @@
"custom_fields_#{custom_field.id}"
end
- describe 'a multi-select user field' do
- let(:user1) { build_stubbed(:user, firstname: 'Foo', lastname: 'Bar') }
- let(:user2) { build_stubbed(:user, firstname: 'Bla', lastname: 'Blub') }
+ describe "a multi-select user field" do
+ let(:user1) { build_stubbed(:user, firstname: "Foo", lastname: "Bar") }
+ let(:user2) { build_stubbed(:user, firstname: "Bla", lastname: "Blub") }
let(:custom_field) do
build_stubbed(:user_wp_custom_field).tap do |cf|
@@ -79,7 +79,7 @@
.and_return(visible_users)
end
- context 'with two visible users' do
+ context "with two visible users" do
let(:visible_users) { [user1, user2] }
let(:formatted_value) do
@@ -91,11 +91,11 @@
value: "#{formatted_value}")
end
- it 'outputs both formatted names' do
+ it "outputs both formatted names" do
expect(rendered).to eq expected
end
- context 'with only one visible user' do
+ context "with only one visible user" do
let(:visible_users) { [user1] }
let(:formatted_value) do
@@ -107,15 +107,15 @@
value: "#{formatted_value}")
end
- it 'outputs the one visible formatted name' do
+ it "outputs the one visible formatted name" do
expect(rendered).to eq expected
end
end
end
end
- describe 'WITH the first value being nil, and the second a valid value as string' do
- let(:values) { [nil, '1'] }
+ describe "WITH the first value being nil, and the second a valid value as string" do
+ let(:values) { [nil, "1"] }
let(:formatted_value) { format_value(values.last, custom_field) }
let(:expected) do
@@ -127,7 +127,7 @@
it { expect(instance.render(key, values)).to eq(expected) }
end
- describe 'WITH the first value being a valid value as a string, and the second being a valid value as a string' do
+ describe "WITH the first value being a valid value as a string, and the second being a valid value as a string" do
let(:values) { %w[0 1] }
let(:old_formatted_value) { format_value(values.first, custom_field) }
let(:new_formatted_value) { format_value(values.last, custom_field) }
@@ -135,7 +135,7 @@
let(:expected) do
I18n.t(:text_journal_changed_plain,
label: "#{custom_field.name}",
- linebreak: '',
+ linebreak: "",
old: "#{old_formatted_value}",
new: "#{new_formatted_value}")
end
@@ -143,8 +143,8 @@
it { expect(instance.render(key, values)).to eq(expected) }
end
- describe 'WITH the first value being a valid value as a string, and the second being nil' do
- let(:values) { ['0', nil] }
+ describe "WITH the first value being a valid value as a string, and the second being nil" do
+ let(:values) { ["0", nil] }
let(:formatted_value) { format_value(values.first, custom_field) }
let(:expected) do
@@ -158,7 +158,7 @@
describe "WITH the first value being nil, and the second a valid value as string " \
"and WITH no html requested" do
- let(:values) { [nil, '1'] }
+ let(:values) { [nil, "1"] }
let(:expected) do
I18n.t(:text_journal_set_to,
@@ -177,7 +177,7 @@
I18n.t(:text_journal_changed_plain,
label: custom_field.name,
old: format_value(values.first, custom_field),
- linebreak: '',
+ linebreak: "",
new: format_value(values.last, custom_field))
end
@@ -186,7 +186,7 @@
describe "WITH the first value being a valid value as a string, and the second being nil " \
"and WITH no html requested" do
- let(:values) { ['0', nil] }
+ let(:values) { ["0", nil] }
let(:expected) do
I18n.t(:text_journal_deleted,
@@ -199,8 +199,8 @@
describe "WITH the first value being nil, and the second a valid value as string " \
"and WITH the custom field being deleted" do
- let(:values) { [nil, '1'] }
- let(:key) { 'custom_values0' }
+ let(:values) { [nil, "1"] }
+ let(:key) { "custom_values0" }
let(:expected) do
I18n.t(:text_journal_set_to,
@@ -214,12 +214,12 @@
describe "WITH the first value being a valid value as a string, and the second being a valid value as a string " \
"and WITH the custom field being deleted" do
let(:values) { %w[0 1] }
- let(:key) { 'custom_values0' }
+ let(:key) { "custom_values0" }
let(:expected) do
I18n.t(:text_journal_changed_plain,
label: "#{I18n.t(:label_deleted_custom_field)}",
- linebreak: '',
+ linebreak: "",
old: "#{values.first}",
new: "#{values.last}")
end
@@ -229,8 +229,8 @@
describe "WITH the first value being a valid value as a string, and the second being nil " \
"and WITH the custom field being deleted" do
- let(:values) { ['0', nil] }
- let(:key) { 'custom_values0' }
+ let(:values) { ["0", nil] }
+ let(:key) { "custom_values0" }
let(:expected) do
I18n.t(:text_journal_deleted,
@@ -241,7 +241,7 @@
it { expect(instance.render(key, values)).to eq(expected) }
end
- context 'for a multi list cf' do
+ context "for a multi list cf" do
let(:custom_field) do
build_stubbed(:list_wp_custom_field, multi_value: true).tap do |cf|
allow(CustomField)
@@ -249,9 +249,9 @@
.with(id: cf.id)
.and_return(cf)
- cf_options = double('custom_options')
- old_options = double('selected options')
- new_options = double('selected options')
+ cf_options = double("custom_options")
+ old_options = double("selected options")
+ new_options = double("selected options")
allow(cf)
.to receive(:custom_options)
@@ -288,8 +288,8 @@
.and_return(new_custom_option_names)
end
end
- let(:old_custom_option_names) { [[1, 'cf 1'], [2, 'cf 2']] }
- let(:new_custom_option_names) { [[3, 'cf 3'], [4, 'cf 4']] }
+ let(:old_custom_option_names) { [[1, "cf 1"], [2, "cf 2"]] }
+ let(:new_custom_option_names) { [[3, "cf 3"], [4, "cf 4"]] }
describe "WITH the first value being a comma separated list of ids, " \
"and the second being a comma separated list of ids" do
@@ -298,7 +298,7 @@
let(:expected) do
I18n.t(:text_journal_changed_plain,
label: "#{custom_field.name}",
- linebreak: '',
+ linebreak: "",
old: "cf 1, cf 2",
new: "cf 3, cf 4")
end
@@ -309,12 +309,12 @@
describe "WITH the first value being a comma separated list of ids, " \
"and the second being a comma separated list of ids that no longer exist" do
let(:values) { %w[1,2 3,4] }
- let(:new_custom_option_names) { [[4, 'cf 4']] }
+ let(:new_custom_option_names) { [[4, "cf 4"]] }
let(:expected) do
I18n.t(:text_journal_changed_plain,
label: "#{custom_field.name}",
- linebreak: '',
+ linebreak: "",
old: "cf 1, cf 2",
new: "(deleted option), cf 4")
end
diff --git a/spec/lib/journal_formatter/day_count_spec.rb b/spec/lib/journal_formatter/day_count_spec.rb
index 52476252b01d..0d2dc22e1984 100644
--- a/spec/lib/journal_formatter/day_count_spec.rb
+++ b/spec/lib/journal_formatter/day_count_spec.rb
@@ -37,34 +37,34 @@
let(:instance) { klass.new(journal) }
let(:key) { :duration }
- describe '#render' do
- describe 'when setting the old value to 1 day, and the new value to 3 days' do
+ describe "#render" do
+ describe "when setting the old value to 1 day, and the new value to 3 days" do
let(:expected) do
I18n.t(:text_journal_changed_plain,
label: "Duration",
- old: '1 day',
- new: '3 days',
- linebreak: '')
+ old: "1 day",
+ new: "3 days",
+ linebreak: "")
end
it { expect(instance.render(key, [1, 3])).to eq(expected) }
end
- describe 'when setting the initial value to 3 days' do
+ describe "when setting the initial value to 3 days" do
let(:expected) do
I18n.t(:text_journal_set_to,
label: "Duration",
- value: '3 days')
+ value: "3 days")
end
it { expect(instance.render(key, [nil, 3])).to eq(expected) }
end
- describe 'when deleting the initial value of 3 days' do
+ describe "when deleting the initial value of 3 days" do
let(:expected) do
I18n.t(:text_journal_deleted,
label: "Duration",
- old: '3 days')
+ old: "3 days")
end
it { expect(instance.render(key, [3, nil])).to eq(expected) }
diff --git a/spec/lib/journal_formatter/diff_spec.rb b/spec/lib/journal_formatter/diff_spec.rb
index 2e6bb1d07241..46e7051342c2 100644
--- a/spec/lib/journal_formatter/diff_spec.rb
+++ b/spec/lib/journal_formatter/diff_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::JournalFormatter::Diff do
include ActionView::Helpers::TagHelper
@@ -42,7 +42,7 @@ def url_helper
let(:id) { 1 }
let(:work_package) do
build_stubbed(:work_package,
- subject: 'Test subject',
+ subject: "Test subject",
status_id: 1,
type_id: 1,
project_id: 1)
@@ -59,7 +59,7 @@ def url_helper
project_id: work_package.project_id))
end
let(:instance) { klass.new(journal) }
- let(:key) { 'description' }
+ let(:key) { "description" }
let(:path) do
url_helper.diff_journal_path(id: journal.id,
@@ -71,35 +71,35 @@ def url_helper
protocol: Setting.protocol,
host: Setting.host_name)
end
- let(:link) { link_to(I18n.t(:label_details), path, class: 'description-details') }
- let(:full_url_link) { link_to(I18n.t(:label_details), url, class: 'description-details') }
+ let(:link) { link_to(I18n.t(:label_details), path, class: "description-details") }
+ let(:full_url_link) { link_to(I18n.t(:label_details), url, class: "description-details") }
- describe '#render' do
- describe 'WITH the first value being nil, and the second a string' do
+ describe "#render" do
+ describe "WITH the first value being nil, and the second a string" do
let(:expected) do
I18n.t(:text_journal_set_with_diff,
label: "#{key.camelize}",
link:)
end
- it { expect(instance.render(key, [nil, 'new value'])).to eq(expected) }
+ it { expect(instance.render(key, [nil, "new value"])).to eq(expected) }
end
- describe 'WITH the first value being a string, and the second a string' do
+ describe "WITH the first value being a string, and the second a string" do
let(:expected) do
I18n.t(:text_journal_changed_with_diff,
label: "#{key.camelize}",
link:)
end
- it { expect(instance.render(key, ['old value', 'new value'])).to eq(expected) }
+ it { expect(instance.render(key, ["old value", "new value"])).to eq(expected) }
end
describe "WITH the first value being a string, and the second a string
WITH de as locale" do
let(:expected) do
I18n.t(:text_journal_changed_with_diff,
- label: 'Beschreibung',
+ label: "Beschreibung",
link:)
end
@@ -111,17 +111,17 @@ def url_helper
I18n.locale = :en
end
- it { expect(instance.render(key, ['old value', 'new value'])).to eq(expected) }
+ it { expect(instance.render(key, ["old value", "new value"])).to eq(expected) }
end
- describe 'WITH the first value being a string, and the second nil (with link)' do
+ describe "WITH the first value being a string, and the second nil (with link)" do
let(:expected) do
I18n.t(:text_journal_deleted_with_diff,
label: "#{key.camelize}",
link:)
end
- it { expect(instance.render(key, ['old_value', nil])).to eq(expected) }
+ it { expect(instance.render(key, ["old_value", nil])).to eq(expected) }
end
describe "WITH the first value being nil, and the second a string
@@ -132,7 +132,7 @@ def url_helper
link: path)
end
- it { expect(instance.render(key, [nil, 'new value'], html: false)).to eq(expected) }
+ it { expect(instance.render(key, [nil, "new value"], html: false)).to eq(expected) }
end
describe "WITH the first value being a string, and the second a string
@@ -143,7 +143,7 @@ def url_helper
link: path)
end
- it { expect(instance.render(key, ['old value', 'new value'], html: false)).to eq(expected) }
+ it { expect(instance.render(key, ["old value", "new value"], html: false)).to eq(expected) }
end
describe "WITH the first value being a string, and the second a string
@@ -154,17 +154,17 @@ def url_helper
link: full_url_link)
end
- it { expect(instance.render(key, ['old value', 'new value'], only_path: false)).to eq(expected) }
+ it { expect(instance.render(key, ["old value", "new value"], only_path: false)).to eq(expected) }
end
- describe 'WITH the first value being a string, and the second nil (with url)' do
+ describe "WITH the first value being a string, and the second nil (with url)" do
let(:expected) do
I18n.t(:text_journal_deleted_with_diff,
label: key.camelize,
link: path)
end
- it { expect(instance.render(key, ['old_value', nil], html: false)).to eq(expected) }
+ it { expect(instance.render(key, ["old_value", nil], html: false)).to eq(expected) }
end
end
end
diff --git a/spec/lib/journal_formatter/file_link_spec.rb b/spec/lib/journal_formatter/file_link_spec.rb
index 8adaca32b850..ce381e2fe18d 100644
--- a/spec/lib/journal_formatter/file_link_spec.rb
+++ b/spec/lib/journal_formatter/file_link_spec.rb
@@ -28,7 +28,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::JournalFormatter::FileLink do
let(:work_package) { build(:work_package) }
@@ -40,11 +40,11 @@
subject(:instance) { described_class.new(journal) }
- describe '#render' do
- context 'having the origin_name as nil' do
+ describe "#render" do
+ context "having the origin_name as nil" do
let(:changes) { { "link_name" => file_link.origin_name, "storage_name" => nil } }
- it 'if the storage name is nil it tries to find it out looking at the file link' do
+ it "if the storage name is nil it tries to find it out looking at the file link" do
link = "#{Setting.protocol}://#{Setting.host_name}/api/v3/file_links/#{file_link.id}/open"
expect(instance.render(key, [nil, changes]))
@@ -55,20 +55,20 @@
end
it 'if the storage name is nil and the file link does not exist, "Unknown storage" is used' do
- expect(instance.render('file_links_12', [changes, nil]))
+ expect(instance.render("file_links_12", [changes, nil]))
.to eq(I18n.t(:text_journal_file_link_deleted,
label: "#{I18n.t('activerecord.models.file_link')}",
old: "#{file_link.origin_name}",
storage: I18n.t(
- 'unknown_storage',
- scope: 'my_account.access_tokens.storages'
+ "unknown_storage",
+ scope: "my_account.access_tokens.storages"
)))
end
end
- context 'having the first value being nil, and the second an hash of properties' do
- context 'as HTML' do
- it 'adds a file link added text' do
+ context "having the first value being nil, and the second an hash of properties" do
+ context "as HTML" do
+ it "adds a file link added text" do
link = "#{Setting.protocol}://#{Setting.host_name}/api/v3/file_links/#{file_link.id}/open"
expect(instance.render(key, [nil, changes]))
.to eq(I18n.t(:text_journal_file_link_added,
@@ -77,10 +77,10 @@
storage: file_link.storage.name))
end
- context 'with a configured relative url root' do
- before { allow(OpenProject::Configuration).to receive(:rails_relative_url_root).and_return('/blubs') }
+ context "with a configured relative url root" do
+ before { allow(OpenProject::Configuration).to receive(:rails_relative_url_root).and_return("/blubs") }
- it 'adds an file link added text' do
+ it "adds an file link added text" do
link = "#{Setting.protocol}://#{Setting.host_name}/blubs/api/v3/file_links/#{file_link.id}/open"
expect(instance.render(key, [nil, changes]))
.to eq(I18n.t(:text_journal_file_link_added,
@@ -91,10 +91,10 @@
end
end
- context 'as plain text' do
- it 'adds a file link added text' do
+ context "as plain text" do
+ it "adds a file link added text" do
message = I18n.t(:text_journal_file_link_added,
- label: I18n.t('activerecord.models.file_link'),
+ label: I18n.t("activerecord.models.file_link"),
value: file_link.origin_name,
storage: file_link.storage.name)
@@ -103,9 +103,9 @@
end
end
- context 'having the first value being an props hash, and the second nil' do
- context 'as HTML' do
- it 'adds a file link remove text' do
+ context "having the first value being an props hash, and the second nil" do
+ context "as HTML" do
+ it "adds a file link remove text" do
message = I18n.t(:text_journal_file_link_deleted,
label: "#{I18n.t('activerecord.models.file_link')}",
old: "#{file_link.origin_name}",
@@ -115,10 +115,10 @@
end
end
- context 'as plain text' do
- it 'adds a file link removed' do
+ context "as plain text" do
+ it "adds a file link removed" do
message = I18n.t(:text_journal_file_link_deleted,
- label: I18n.t('activerecord.models.file_link'),
+ label: I18n.t("activerecord.models.file_link"),
old: file_link.origin_name,
storage: file_link.storage.name)
diff --git a/spec/lib/journal_formatter/ignore_non_working_days_spec.rb b/spec/lib/journal_formatter/ignore_non_working_days_spec.rb
index 484b068fde72..b4da6bf65e84 100644
--- a/spec/lib/journal_formatter/ignore_non_working_days_spec.rb
+++ b/spec/lib/journal_formatter/ignore_non_working_days_spec.rb
@@ -37,8 +37,8 @@
let(:instance) { klass.new(journal) }
let(:key) { :ignore_non_working_days }
- describe '#render' do
- context 'when setting the old value to false, and the new value to true' do
+ describe "#render" do
+ context "when setting the old value to false, and the new value to true" do
let(:expected) do
I18n.t(:text_journal_set_to,
label: "Working days",
@@ -48,7 +48,7 @@
it { expect(instance.render(key, [false, true])).to eq(expected) }
end
- context 'when setting the old value to true, and the new value to false' do
+ context "when setting the old value to true, and the new value to false" do
let(:expected) do
I18n.t(:text_journal_set_to,
label: "Working days",
diff --git a/spec/lib/journal_formatter/project_status_code_spec.rb b/spec/lib/journal_formatter/project_status_code_spec.rb
index e9325f057f09..08e785e98ce2 100644
--- a/spec/lib/journal_formatter/project_status_code_spec.rb
+++ b/spec/lib/journal_formatter/project_status_code_spec.rb
@@ -28,21 +28,21 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::JournalFormatter::ProjectStatusCode do
def status_code_as_integer(status)
Project.status_codes.fetch(status, nil)
end
- describe '#render' do
+ describe "#render" do
let(:journal) { build_stubbed(:project_journal) }
let(:instance) { described_class.new(journal) }
- let(:status_code_key) { 'status_code' }
+ let(:status_code_key) { "status_code" }
- context 'when setting a status' do
+ context "when setting a status" do
let(:old_value) { nil }
- let(:new_value) { status_code_as_integer('off_track') }
+ let(:new_value) { status_code_as_integer("off_track") }
let(:expected) do
I18n.t(:text_journal_set_to,
label: "Project status",
@@ -52,8 +52,8 @@ def status_code_as_integer(status)
it { expect(instance.render(status_code_key, [old_value, new_value])).to eq(expected) }
end
- context 'when deleting a status' do
- let(:old_value) { status_code_as_integer('discontinued') }
+ context "when deleting a status" do
+ let(:old_value) { status_code_as_integer("discontinued") }
let(:new_value) { nil }
let(:expected) do
I18n.t(:text_journal_deleted,
@@ -64,9 +64,9 @@ def status_code_as_integer(status)
it { expect(instance.render(status_code_key, [old_value, new_value])).to eq(expected) }
end
- context 'when modifying a status' do
- let(:old_value) { status_code_as_integer('off_track') }
- let(:new_value) { status_code_as_integer('on_track') }
+ context "when modifying a status" do
+ let(:old_value) { status_code_as_integer("off_track") }
+ let(:new_value) { status_code_as_integer("on_track") }
let(:expected) do
I18n.t(:text_journal_changed_plain,
label: "Project status",
diff --git a/spec/lib/journal_formatter/schedule_manually_spec.rb b/spec/lib/journal_formatter/schedule_manually_spec.rb
index 3f3c69074158..9440f8016785 100644
--- a/spec/lib/journal_formatter/schedule_manually_spec.rb
+++ b/spec/lib/journal_formatter/schedule_manually_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::JournalFormatter::ScheduleManually do
let(:klass) { described_class }
@@ -35,24 +35,24 @@
OpenStruct.new(id:, journable: WorkPackage.new)
end
let(:instance) { klass.new(journal) }
- let(:key) { 'schedule_manually' }
+ let(:key) { "schedule_manually" }
- describe '#render' do
- describe 'with the first value being true, and the second false' do
+ describe "#render" do
+ describe "with the first value being true, and the second false" do
let(:expected) do
I18n.t(:text_journal_label_value,
label: "Manual scheduling",
- value: 'deactivated')
+ value: "deactivated")
end
it { expect(instance.render(key, [true, false])).to eq(expected) }
end
- describe 'with the first value being false, and the second true' do
+ describe "with the first value being false, and the second true" do
let(:expected) do
I18n.t(:text_journal_label_value,
label: "Manual scheduling",
- value: 'activated')
+ value: "activated")
end
it { expect(instance.render(key, [false, true])).to eq(expected) }
diff --git a/spec/lib/journal_formatter/template_spec.rb b/spec/lib/journal_formatter/template_spec.rb
index fecb3075a003..1f258d0945eb 100644
--- a/spec/lib/journal_formatter/template_spec.rb
+++ b/spec/lib/journal_formatter/template_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::JournalFormatter::Template do
let(:instance) { described_class.new(build(:project_journal)) }
diff --git a/spec/lib/journal_formatter/wiki_diff_spec.rb b/spec/lib/journal_formatter/wiki_diff_spec.rb
index a2ad4fa69e36..7bd8cee86739 100644
--- a/spec/lib/journal_formatter/wiki_diff_spec.rb
+++ b/spec/lib/journal_formatter/wiki_diff_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::JournalFormatter::WikiDiff do
include ActionView::Helpers::TagHelper
@@ -42,7 +42,7 @@ def url_helper
let(:project) { build_stubbed(:project) }
let(:wiki) { build_stubbed(:wiki, project:) }
let(:wiki_page) do
- build_stubbed(:wiki_page, wiki:, slug: 'test-slug', text: '').tap do |page|
+ build_stubbed(:wiki_page, wiki:, slug: "test-slug", text: "").tap do |page|
allow(page).to receive(:project).and_return(project)
end
end
@@ -52,7 +52,7 @@ def url_helper
version: 1)
end
let(:wiki_instance) { klass.new(wiki_journal) }
- let(:wiki_key) { 'text' }
+ let(:wiki_key) { "text" }
let(:path) do # path
url_helper.wiki_diff_compare_project_wiki_path(id: wiki_page.slug,
project_id: project.identifier,
@@ -67,18 +67,18 @@ def url_helper
protocol: Setting.protocol,
host: Setting.host_name)
end
- let(:link) { link_to(I18n.t(:label_details), path, class: 'description-details') }
- let(:full_url_link) { link_to(I18n.t(:label_details), url, class: 'description-details') }
+ let(:link) { link_to(I18n.t(:label_details), path, class: "description-details") }
+ let(:full_url_link) { link_to(I18n.t(:label_details), url, class: "description-details") }
- describe '#render' do
- describe 'a wiki diff for a wiki journal correctly' do
+ describe "#render" do
+ describe "a wiki diff for a wiki journal correctly" do
let(:expected) do
I18n.t(:text_journal_changed_with_diff,
label: "#{wiki_key.camelize}",
link:)
end
- it { expect(wiki_instance.render(wiki_key, ['old value', 'new value'])).to eq(expected) }
+ it { expect(wiki_instance.render(wiki_key, ["old value", "new value"])).to eq(expected) }
end
end
end
diff --git a/spec/lib/open_project/access_control/permission_spec.rb b/spec/lib/open_project/access_control/permission_spec.rb
index 195f5cd71ae7..de9eb7ea7b59 100644
--- a/spec/lib/open_project/access_control/permission_spec.rb
+++ b/spec/lib/open_project/access_control/permission_spec.rb
@@ -26,31 +26,31 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::AccessControl::Permission do
- describe '#dependencies' do
- context 'for a permission with a dependency' do
+ describe "#dependencies" do
+ context "for a permission with a dependency" do
subject { OpenProject::AccessControl.permission(:edit_work_packages) }
- it 'denotes the pre-requisites' do
+ it "denotes the pre-requisites" do
expect(subject.dependencies)
.to contain_exactly(:view_work_packages)
end
end
- context 'for a permission without a dependency' do
+ context "for a permission without a dependency" do
subject { OpenProject::AccessControl.permission(:view_work_packages) }
- it 'is empty' do
+ it "is empty" do
expect(subject.dependencies)
.to be_empty
end
end
end
- describe '#work_package?' do
- context 'when marked as permissible on work package roles' do
+ describe "#work_package?" do
+ context "when marked as permissible on work package roles" do
subject(:permission) do
described_class.new(:perm, { cont: [:action] }, permissible_on: :work_package)
end
@@ -59,8 +59,8 @@
end
end
- describe '#project?' do
- context 'when marked as permissible on project roles' do
+ describe "#project?" do
+ context "when marked as permissible on project roles" do
subject(:permission) do
described_class.new(:perm, { cont: [:action] }, permissible_on: :project)
end
@@ -69,8 +69,8 @@
end
end
- describe '#global?' do
- context 'when marked as permissible on global roles' do
+ describe "#global?" do
+ context "when marked as permissible on global roles" do
subject(:permission) do
described_class.new(:perm, { cont: [:action] }, permissible_on: :global)
end
@@ -79,7 +79,7 @@
end
end
- describe 'marking it as permissible on multiple role types' do
+ describe "marking it as permissible on multiple role types" do
subject(:permission) do
described_class.new(:perm, { cont: [:action] }, permissible_on: %i[work_package project])
end
@@ -88,7 +88,7 @@
it { expect(permission).to be_project }
end
- context 'without :permissible_on as an argument' do
+ context "without :permissible_on as an argument" do
it do
expect do
described_class.new(:perm, { cont: [:action] })
@@ -96,8 +96,8 @@
end
end
- describe '#grant_to_admin?' do
- context 'when it is marked as grant-able to admin' do
+ describe "#grant_to_admin?" do
+ context "when it is marked as grant-able to admin" do
subject(:permission) do
described_class.new(:perm, {}, permissible_on: :project, grant_to_admin: true)
end
@@ -105,7 +105,7 @@
it { expect(permission).to be_grant_to_admin }
end
- context 'when it is marked as non-grant-able to admin' do
+ context "when it is marked as non-grant-able to admin" do
subject(:permission) do
described_class.new(:perm, {}, permissible_on: :project, grant_to_admin: false)
end
@@ -113,12 +113,12 @@
it { expect(permission).not_to be_grant_to_admin }
end
- context 'without specifying whether the permissions is grant-able to admin or not' do
+ context "without specifying whether the permissions is grant-able to admin or not" do
subject(:permission) do
described_class.new(:perm, {}, permissible_on: :project)
end
- it 'defaults to grant-able to admin' do
+ it "defaults to grant-able to admin" do
expect(permission).to be_grant_to_admin
end
end
diff --git a/spec/lib/open_project/access_control_spec.rb b/spec/lib/open_project/access_control_spec.rb
index 5c88ade2d34c..f7857bd958da 100644
--- a/spec/lib/open_project/access_control_spec.rb
+++ b/spec/lib/open_project/access_control_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::AccessControl do
def setup_permissions
@@ -87,8 +87,8 @@ def setup_permissions
end
end
- describe '.disable_modules_permissions' do
- include_context 'with blank access control state'
+ describe ".disable_modules_permissions" do
+ include_context "with blank access control state"
before do
setup_permissions
@@ -105,126 +105,126 @@ def setup_permissions
described_class
end
- it 'removes from permissions' do
+ it "removes from permissions" do
expect(subject.permissions)
.to all(not_belong_to_project_module(:project_module))
end
- it 'removes from global permissions' do
+ it "removes from global permissions" do
expect(subject.global_permissions)
.to all(not_belong_to_project_module(:project_module))
end
- it 'removes from public permissions' do
+ it "removes from public permissions" do
expect(subject.public_permissions)
.to all(not_belong_to_project_module(:project_module))
end
- it 'removes from members-only permissions' do
+ it "removes from members-only permissions" do
expect(subject.members_only_permissions)
.to all(not_belong_to_project_module(:project_module))
end
- it 'removes from loggedin-only permissions' do
+ it "removes from loggedin-only permissions" do
expect(subject.loggedin_only_permissions)
.to all(not_belong_to_project_module(:project_module))
end
- it 'disables repository module' do
+ it "disables repository module" do
expect(subject.available_project_modules)
.not_to include(:project_module)
end
- it 'lists the permissions in the disabled_permissions' do
+ it "lists the permissions in the disabled_permissions" do
expect(subject.disabled_permissions.map(&:name))
.to include :project_module_project_permission_with_contract_actions,
:project_module_project_permission
end
- it 'returns true on disabled_permission?' do
+ it "returns true on disabled_permission?" do
expect(subject.disabled_permission?(:project_module_project_permission))
.to be true
end
end
- describe '.permissions' do
+ describe ".permissions" do
subject(:permissions) { described_class.permissions }
- it 'returns an array permissions' do
+ it "returns an array permissions" do
expect(permissions)
.to all(be_instance_of(OpenProject::AccessControl::Permission))
end
- it 'returns only enabled permissions' do
+ it "returns only enabled permissions" do
expect(permissions)
.to all(be_enabled)
end
end
- describe '.permission' do
- context 'for a project module permission' do
+ describe ".permission" do
+ context "for a project module permission" do
subject { described_class.permission(:view_work_packages) }
- it 'is a permission' do
+ it "is a permission" do
expect(subject)
.to be_a(OpenProject::AccessControl::Permission)
end
- it 'is the permission with the queried-for name' do
+ it "is the permission with the queried-for name" do
expect(subject.name)
.to eq(:view_work_packages)
end
- it 'belongs to a project module' do
+ it "belongs to a project module" do
expect(subject.project_module)
.to eq(:work_package_tracking)
end
end
- context 'for a non module permission' do
+ context "for a non module permission" do
subject { described_class.permission(:edit_project) }
- it 'is a permission' do
+ it "is a permission" do
expect(subject)
.to be_a(OpenProject::AccessControl::Permission)
end
- it 'is the permission with the queried-for name' do
+ it "is the permission with the queried-for name" do
expect(subject.name)
.to eq(:edit_project)
end
- it 'does not belong to a project module' do
+ it "does not belong to a project module" do
expect(subject.project_module)
.to be_nil
end
- it 'includes actions' do
+ it "includes actions" do
expect(subject.controller_actions)
- .to include('projects/settings/general/show')
+ .to include("projects/settings/general/show")
end
end
- describe '#dependencies' do
- context 'for a permission with a pre-requisite' do
+ describe "#dependencies" do
+ context "for a permission with a pre-requisite" do
subject(:dependencies) do
described_class.permission(:edit_work_packages)
.dependencies
end
- it 'denotes the pre-requisites' do
+ it "denotes the pre-requisites" do
expect(dependencies)
.to contain_exactly(:view_work_packages)
end
end
- context 'for a permission without a pre-requisite' do
+ context "for a permission without a pre-requisite" do
subject(:dependencies) do
described_class.permission(:view_work_packages)
.dependencies
end
- it 'denotes no pre-requisites' do
+ it "denotes no pre-requisites" do
expect(dependencies)
.to be_empty
end
@@ -232,8 +232,8 @@ def setup_permissions
end
end
- describe '.modules' do
- include_context 'with blank access control state'
+ describe ".modules" do
+ include_context "with blank access control state"
before do
setup_permissions
@@ -244,14 +244,14 @@ def setup_permissions
.find { _1[:name] == :dependent_module }[:dependencies]
end
- it 'can store specified dependencies' do
+ it "can store specified dependencies" do
expect(dependencies)
.to contain_exactly(:project_module)
end
end
- describe '.work_package_permissions' do
- include_context 'with blank access control state'
+ describe ".work_package_permissions" do
+ include_context "with blank access control state"
before do
setup_permissions
@@ -261,7 +261,7 @@ def setup_permissions
described_class.work_package_permissions
end
- describe 'size' do
+ describe "size" do
it { expect(work_package_permissions.size).to eq(2) }
end
@@ -272,8 +272,8 @@ def setup_permissions
end
end
- describe '.project_permissions' do
- include_context 'with blank access control state'
+ describe ".project_permissions" do
+ include_context "with blank access control state"
before do
setup_permissions
@@ -283,7 +283,7 @@ def setup_permissions
described_class.project_permissions
end
- describe 'size' do
+ describe "size" do
it { expect(project_permissions.size).to eq(7) }
end
@@ -299,8 +299,8 @@ def setup_permissions
end
end
- describe '.global_permissions' do
- include_context 'with blank access control state'
+ describe ".global_permissions" do
+ include_context "with blank access control state"
before do
setup_permissions
@@ -310,7 +310,7 @@ def setup_permissions
described_class.global_permissions
end
- describe 'size' do
+ describe "size" do
it { expect(global_permissions.size).to eq(3) }
end
@@ -322,8 +322,8 @@ def setup_permissions
end
end
- describe '.available_project_modules' do
- include_context 'with blank access control state'
+ describe ".available_project_modules" do
+ include_context "with blank access control state"
before do
setup_permissions
@@ -336,7 +336,7 @@ def setup_permissions
it { expect(available_project_modules).to include(:project_module, :mixed_module, :dependent_module) }
it { expect(available_project_modules).not_to include(:global_module) }
- context 'when a module specifies :if' do
+ context "when a module specifies :if" do
before do
described_class.map do |map|
map.project_module :dynamic_module, if: if_proc do |mod|
@@ -345,27 +345,27 @@ def setup_permissions
end
end
- context 'with if: true' do
+ context "with if: true" do
let(:if_proc) { ->(*) { true } }
- it 'is considered available' do
+ it "is considered available" do
expect(available_project_modules).to include(:dynamic_module)
end
end
- context 'with if: false' do
+ context "with if: false" do
let(:if_proc) { ->(*) { false } }
- it 'is not considered available anymore' do
+ it "is not considered available anymore" do
expect(available_project_modules).not_to include(:dynamic_module)
end
end
- context 'with if: dynamically changing' do
+ context "with if: dynamically changing" do
let(:if_proc) { ->(*) { if_state[:available] } }
let(:if_state) { { available: true } }
- it 'reevaluates module availability each time', :aggregate_failures do
+ it "reevaluates module availability each time", :aggregate_failures do
if_state[:available] = true
expect(described_class.available_project_modules).to include(:dynamic_module)
@@ -376,8 +376,8 @@ def setup_permissions
end
end
- describe '.contract_actions_map' do
- include_context 'with blank access control state'
+ describe ".contract_actions_map" do
+ include_context "with blank access control state"
before do
setup_permissions
@@ -387,7 +387,7 @@ def setup_permissions
described_class.contract_actions_map
end
- it 'contains all contract actions grouped by the permission name' do
+ it "contains all contract actions grouped by the permission name" do
expect(contract_actions_map)
.to eql(mixed_module_global_permission_with_contract_actions: {
actions: { baz: [:destroy] },
@@ -413,44 +413,44 @@ def setup_permissions
end
end
- describe '.grant_to_admin?' do
- include_context 'with blank access control state'
+ describe ".grant_to_admin?" do
+ include_context "with blank access control state"
before do
setup_permissions
end
- context 'without specifying whether the permission is granted to admins' do
- it 'is granted' do
+ context "without specifying whether the permission is granted to admins" do
+ it "is granted" do
expect(described_class)
.to be_grant_to_admin(:no_module_project_permission_with_contract_actions)
end
end
- context 'for an explicitly granted permission' do
- it 'is granted' do
+ context "for an explicitly granted permission" do
+ it "is granted" do
expect(described_class)
.to be_grant_to_admin(:mixed_module_project_permission_granted_to_admin)
end
end
- context 'for an explicitly non-granted permission' do
- it 'is not granted' do
+ context "for an explicitly non-granted permission" do
+ it "is not granted" do
expect(described_class)
.not_to be_grant_to_admin(:dependent_module_project_permission_not_granted_to_admin)
end
end
- context 'for a non existing permission' do
- it 'is granted' do
+ context "for a non existing permission" do
+ it "is granted" do
expect(described_class)
.to be_grant_to_admin(:not_existing)
end
end
end
- describe '.disabled_permission?' do
- include_context 'with blank access control state'
+ describe ".disabled_permission?" do
+ include_context "with blank access control state"
before do
described_class.map do |map|
@@ -473,27 +473,27 @@ def setup_permissions
end
end
- it 'is false for enabled permissions' do
+ it "is false for enabled permissions" do
expect(subject)
.not_to be_disabled_permission(:enabled_permission)
end
- it 'is true for disabled permission' do
+ it "is true for disabled permission" do
expect(subject)
.to be_disabled_permission(:disabled_permission1)
end
- it 'is true for action hash where permissions granting are disabled' do
+ it "is true for action hash where permissions granting are disabled" do
expect(subject)
- .to be_disabled_permission(controller: 'some', action: 'action')
+ .to be_disabled_permission(controller: "some", action: "action")
end
- it 'is false for action hash where not all permissions granting are disabled (but some can)' do
+ it "is false for action hash where not all permissions granting are disabled (but some can)" do
expect(subject)
- .not_to be_disabled_permission(controller: 'another', action: 'action')
+ .not_to be_disabled_permission(controller: "another", action: "action")
end
- it 'is false for an unknown permission' do
+ it "is false for an unknown permission" do
expect(subject)
.not_to be_disabled_permission(:unknown_permission)
end
diff --git a/spec/lib/open_project/authentication/strategies/warden/global_basic_auth_spec.rb b/spec/lib/open_project/authentication/strategies/warden/global_basic_auth_spec.rb
index 1b7c96067370..38e34b095195 100644
--- a/spec/lib/open_project/authentication/strategies/warden/global_basic_auth_spec.rb
+++ b/spec/lib/open_project/authentication/strategies/warden/global_basic_auth_spec.rb
@@ -26,13 +26,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
Strategies = OpenProject::Authentication::Strategies::Warden
RSpec.describe Strategies::GlobalBasicAuth do
- let(:user) { 'someuser' }
- let(:password) { 'somepassword' }
+ let(:user) { "someuser" }
+ let(:password) { "somepassword" }
let(:config) do
lambda do
@@ -44,23 +44,23 @@
let(:user) { Strategies::UserBasicAuth.user }
before do
- allow(Strategies::UserBasicAuth).to receive(:user).and_return('schluessel')
+ allow(Strategies::UserBasicAuth).to receive(:user).and_return("schluessel")
end
- it 'raises an error' do
+ it "raises an error" do
expect(&config).to raise_error("global user must not be 'schluessel'")
end
end
- context 'with an empty pasword' do
- let(:password) { '' }
+ context "with an empty pasword" do
+ let(:password) { "" }
- it 'raises an error' do
- expect(&config).to raise_error('password must not be empty')
+ it "raises an error" do
+ expect(&config).to raise_error("password must not be empty")
end
end
- context 'with digits-only password' do
+ context "with digits-only password" do
let(:password) { 1234 }
let(:strategy) { Strategies::GlobalBasicAuth.new nil }
@@ -68,8 +68,8 @@
config.call
end
- it 'must authenticate successfully' do
- expect(strategy.authenticate_user(user, '1234')).to be_truthy
+ it "must authenticate successfully" do
+ expect(strategy.authenticate_user(user, "1234")).to be_truthy
end
end
end
diff --git a/spec/lib/open_project/changed_by_system_spec.rb b/spec/lib/open_project/changed_by_system_spec.rb
index 2cf365d177c0..daa2d3290a17 100644
--- a/spec/lib/open_project/changed_by_system_spec.rb
+++ b/spec/lib/open_project/changed_by_system_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::ChangedBySystem do
subject(:model) do
@@ -35,62 +35,62 @@
model
end
- describe '#changed_by_user' do
- context 'when an attribute is changed' do
+ describe "#changed_by_user" do
+ context "when an attribute is changed" do
before do
- model.title = 'abc'
+ model.title = "abc"
end
- it 'returns the attribute' do
+ it "returns the attribute" do
expect(model.changed_by_user)
- .to contain_exactly('title')
+ .to contain_exactly("title")
end
end
- context 'when an attribute is changed by the system' do
+ context "when an attribute is changed by the system" do
before do
model.change_by_system do
- model.title = 'abc'
+ model.title = "abc"
end
end
- it 'returns no attributes' do
+ it "returns no attributes" do
expect(model.changed_by_user)
.to be_empty
end
end
- context 'when an attribute is changed by the system first and then by the user to a different value' do
+ context "when an attribute is changed by the system first and then by the user to a different value" do
before do
model.change_by_system do
- model.title = 'abc'
+ model.title = "abc"
end
- model.title = 'xyz'
+ model.title = "xyz"
end
- it 'returns the attribute' do
+ it "returns the attribute" do
expect(model.changed_by_user)
- .to contain_exactly('title')
+ .to contain_exactly("title")
end
end
- context 'when an attribute is changed by the system first and then by the user to the same value' do
+ context "when an attribute is changed by the system first and then by the user to the same value" do
before do
model.change_by_system do
- model.title = 'abc'
+ model.title = "abc"
end
- model.title = 'abc'
+ model.title = "abc"
end
- it 'returns no attribute' do
+ it "returns no attribute" do
expect(model.changed_by_user)
.to be_empty
end
end
- context 'when the model has the acts_as_customizable plugin included' do
+ context "when the model has the acts_as_customizable plugin included" do
subject(:model) do
create(:work_package, project:).tap do |wp|
wp.extend(described_class)
@@ -106,8 +106,8 @@
type.custom_fields << cf1
end
- it 'returns the custom fields too' do
- model.custom_field_values = { cf1.id => 'test' }
+ it "returns the custom fields too" do
+ model.custom_field_values = { cf1.id => "test" }
expect(model.changed_by_user)
.to include(cf1.attribute_name)
end
diff --git a/spec/lib/open_project/configuration/helpers_spec.rb b/spec/lib/open_project/configuration/helpers_spec.rb
index dd9a51529061..de6d7df72f57 100644
--- a/spec/lib/open_project/configuration/helpers_spec.rb
+++ b/spec/lib/open_project/configuration/helpers_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'open_project/configuration/helpers'
+require "spec_helper"
+require "open_project/configuration/helpers"
RSpec.describe OpenProject::Configuration::Helpers do
let(:config) do
@@ -36,54 +36,54 @@
end
end
- describe '#array' do
+ describe "#array" do
def array(value)
config.send :array, value
end
- context 'with single string value' do
- it 'returns an array containing the value' do
- arr = array 'test'
+ context "with single string value" do
+ it "returns an array containing the value" do
+ arr = array "test"
- expect(arr).to eq ['test']
+ expect(arr).to eq ["test"]
end
end
- context 'with an array' do
- it 'returns the array' do
- arr = ['arrgh']
+ context "with an array" do
+ it "returns the array" do
+ arr = ["arrgh"]
expect(array(arr)).to eq arr
end
end
- context 'with a space separated string' do
- it 'returns an array of the values' do
- value = 'one two three'
+ context "with a space separated string" do
+ it "returns an array of the values" do
+ value = "one two three"
- expect(array(value)).to eq ['one', 'two', 'three']
+ expect(array(value)).to eq ["one", "two", "three"]
end
end
end
- describe '#hidden_menu_items' do
+ describe "#hidden_menu_items" do
before do
- items = config['hidden_menu_items'] = {}
- items['admin_menu'] = 'users colors'
- items['project_menu'] = 'info'
- items['top_menu'] = []
+ items = config["hidden_menu_items"] = {}
+ items["admin_menu"] = "users colors"
+ items["project_menu"] = "info"
+ items["top_menu"] = []
end
- it 'works with arrays' do
- expect(config.hidden_menu_items['top_menu']).to eq []
+ it "works with arrays" do
+ expect(config.hidden_menu_items["top_menu"]).to eq []
end
- it 'works with single string values' do
- expect(config.hidden_menu_items['project_menu']).to eq ['info']
+ it "works with single string values" do
+ expect(config.hidden_menu_items["project_menu"]).to eq ["info"]
end
- it 'work with space separated string values' do
- expect(config.hidden_menu_items['admin_menu']).to eq ['users', 'colors']
+ it "work with space separated string values" do
+ expect(config.hidden_menu_items["admin_menu"]).to eq ["users", "colors"]
end
end
end
diff --git a/spec/lib/open_project/configuration_spec.rb b/spec/lib/open_project/configuration_spec.rb
index c28b0326588d..1d52854c320c 100644
--- a/spec/lib/open_project/configuration_spec.rb
+++ b/spec/lib/open_project/configuration_spec.rb
@@ -26,77 +26,77 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::Configuration, :settings_reset do
- describe '.[setting]' do
- it 'fetches the value' do
+ describe ".[setting]" do
+ it "fetches the value" do
expect(described_class.app_title)
- .to eql('OpenProject')
+ .to eql("OpenProject")
end
end
- describe '.[setting]?' do
- it 'fetches the value' do
+ describe ".[setting]?" do
+ it "fetches the value" do
expect(described_class.smtp_enable_starttls_auto?)
.to be false
end
- it 'works for non boolean settings as well (deprecated)' do
+ it "works for non boolean settings as well (deprecated)" do
expect(described_class.app_title?)
.to be false
end
end
- describe '.[setting]=' do
- it 'raises an error' do
+ describe ".[setting]=" do
+ it "raises an error" do
expect { described_class.smtp_enable_starttls_auto = true }
.to raise_error NoMethodError
end
end
- describe '.cache_store_configuration' do
+ describe ".cache_store_configuration" do
subject { described_class.cache_store_configuration }
- context 'without cache store already set' do
- context 'with additional cache store configuration', with_config: { 'rails_cache_store' => 'bar' } do
- it 'changes the cache store' do
+ context "without cache store already set" do
+ context "with additional cache store configuration", with_config: { "rails_cache_store" => "bar" } do
+ it "changes the cache store" do
expect(subject).to eq([:bar])
end
end
- context 'without additional cache store configuration', with_config: { 'rails_cache_store' => nil } do
+ context "without additional cache store configuration", with_config: { "rails_cache_store" => nil } do
before do
- described_class['rails_cache_store'] = nil
+ described_class["rails_cache_store"] = nil
end
- it 'defaults the cache store to :file_store' do
+ it "defaults the cache store to :file_store" do
expect(subject.first).to eq(:file_store)
end
end
- context 'setting rails cache to redis', with_config: { 'rails_cache_store' => 'redis' } do
- context 'when setting the URL', with_config: { 'cache_redis_url' => 'redis://localhost:1234' } do
- it 'sets the cache to :redis_cache_store' do
+ context "setting rails cache to redis", with_config: { "rails_cache_store" => "redis" } do
+ context "when setting the URL", with_config: { "cache_redis_url" => "redis://localhost:1234" } do
+ it "sets the cache to :redis_cache_store" do
expect(subject.first).to eq(:redis_cache_store)
end
end
- it 'raises an error trying to set redis without an URL' do
+ it "raises an error trying to set redis without an URL" do
expect { subject }.to raise_error(ArgumentError, /CACHE_REDIS_URL is not set/)
end
end
end
end
- describe '#direct_uploads?' do
+ describe "#direct_uploads?" do
let(:value) { described_class.direct_uploads? }
- it 'is false by default' do
+ it "is false by default" do
expect(value).to be false
end
- context 'with remote storage' do
+ context "with remote storage" do
def self.storage(provider)
{
attachments_storage: :fog,
@@ -108,14 +108,14 @@ def self.storage(provider)
}
end
- context 'with AWS', with_config: storage('AWS') do
- it 'is true' do
+ context "with AWS", with_config: storage("AWS") do
+ it "is true" do
expect(value).to be true
end
end
- context 'with Azure', with_config: storage('azure') do
- it 'is false' do
+ context "with Azure", with_config: storage("azure") do
+ it "is false" do
expect(value).to be false
end
end
diff --git a/spec/lib/open_project/content_type_detector_spec.rb b/spec/lib/open_project/content_type_detector_spec.rb
index 98b69faf6764..f6e929f72cb1 100644
--- a/spec/lib/open_project/content_type_detector_spec.rb
+++ b/spec/lib/open_project/content_type_detector_spec.rb
@@ -54,53 +54,53 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::ContentTypeDetector do
- it 'gives a sensible default when the name is empty' do
- expect(OpenProject::ContentTypeDetector.new('').detect).to eq('application/binary')
+ it "gives a sensible default when the name is empty" do
+ expect(OpenProject::ContentTypeDetector.new("").detect).to eq("application/binary")
end
- it 'returns the empty content type when the file is empty' do
- tempfile = Tempfile.new('empty')
- expect(OpenProject::ContentTypeDetector.new(tempfile.path).detect).to eq('inode/x-empty')
+ it "returns the empty content type when the file is empty" do
+ tempfile = Tempfile.new("empty")
+ expect(OpenProject::ContentTypeDetector.new(tempfile.path).detect).to eq("inode/x-empty")
tempfile.close
end
- it 'returns content type of file if it is an acceptable type' do
- allow(MIME::Types).to receive(:type_for).and_return([MIME::Type.new('application/mp4'), MIME::Type.new('video/mp4'),
- MIME::Type.new('audio/mp4')])
- allow(Open3).to receive(:capture2).and_return(['video/mp4', 0])
- @filename = 'my_file.mp4'
- expect(OpenProject::ContentTypeDetector.new(@filename).detect).to eq('video/mp4')
+ it "returns content type of file if it is an acceptable type" do
+ allow(MIME::Types).to receive(:type_for).and_return([MIME::Type.new("application/mp4"), MIME::Type.new("video/mp4"),
+ MIME::Type.new("audio/mp4")])
+ allow(Open3).to receive(:capture2).and_return(["video/mp4", 0])
+ @filename = "my_file.mp4"
+ expect(OpenProject::ContentTypeDetector.new(@filename).detect).to eq("video/mp4")
end
- it 'returns the default when exitcode > 0' do
- allow(MIME::Types).to receive(:type_for).and_return([MIME::Type.new('application/mp4'), MIME::Type.new('video/mp4'),
- MIME::Type.new('audio/mp4')])
- allow(Open3).to receive(:capture2).and_return(['', 1])
- @filename = 'my_file.mp4'
- expect(OpenProject::ContentTypeDetector.new(@filename).detect).to eq('application/binary')
+ it "returns the default when exitcode > 0" do
+ allow(MIME::Types).to receive(:type_for).and_return([MIME::Type.new("application/mp4"), MIME::Type.new("video/mp4"),
+ MIME::Type.new("audio/mp4")])
+ allow(Open3).to receive(:capture2).and_return(["", 1])
+ @filename = "my_file.mp4"
+ expect(OpenProject::ContentTypeDetector.new(@filename).detect).to eq("application/binary")
end
- it 'finds the right type in the list via the file command' do
+ it "finds the right type in the list via the file command" do
@filename = "#{Dir.tmpdir}/something.hahalolnotreal"
- File.open(@filename, 'w+') do |file|
- file.puts 'This is a text file.'
+ File.open(@filename, "w+") do |file|
+ file.puts "This is a text file."
file.rewind
- expect(OpenProject::ContentTypeDetector.new(file.path).detect).to eq('text/plain')
+ expect(OpenProject::ContentTypeDetector.new(file.path).detect).to eq("text/plain")
end
FileUtils.rm @filename
end
- it 'returns a sensible default if something is wrong, like the file is gone' do
- @filename = '/path/to/nothing'
- expect(OpenProject::ContentTypeDetector.new(@filename).detect).to eq('application/binary')
+ it "returns a sensible default if something is wrong, like the file is gone" do
+ @filename = "/path/to/nothing"
+ expect(OpenProject::ContentTypeDetector.new(@filename).detect).to eq("application/binary")
end
- it 'returns a sensible default when the file command is missing' do
- allow(Open3).to receive(:capture2).and_raise 'o noes!'
- @filename = '/path/to/something'
- expect(OpenProject::ContentTypeDetector.new(@filename).detect).to eq('application/binary')
+ it "returns a sensible default when the file command is missing" do
+ allow(Open3).to receive(:capture2).and_raise "o noes!"
+ @filename = "/path/to/something"
+ expect(OpenProject::ContentTypeDetector.new(@filename).detect).to eq("application/binary")
end
end
diff --git a/spec/lib/open_project/enterprise_spec.rb b/spec/lib/open_project/enterprise_spec.rb
index b47f8d8a71cf..6036add8bf58 100644
--- a/spec/lib/open_project/enterprise_spec.rb
+++ b/spec/lib/open_project/enterprise_spec.rb
@@ -26,8 +26,8 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'open_project/passwords'
+require "spec_helper"
+require "open_project/passwords"
RSpec.describe OpenProject::Enterprise do
# create 3 built-in users, only 2 of which are active
diff --git a/spec/lib/open_project/events_spec.rb b/spec/lib/open_project/events_spec.rb
index 80713097a8b0..14d968e6e069 100644
--- a/spec/lib/open_project/events_spec.rb
+++ b/spec/lib/open_project/events_spec.rb
@@ -26,7 +26,7 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::Events do
def fire_event(event_constant_name)
@@ -48,7 +48,7 @@ def fire_event(event_constant_name)
describe(event) do
subject { fire_event(event) }
- context 'when payload is empty' do
+ context "when payload is empty" do
let(:payload) { {} }
it do
@@ -57,7 +57,7 @@ def fire_event(event_constant_name)
end
end
- context 'when payload contains automatic project_folder_mode' do
+ context "when payload contains automatic project_folder_mode" do
let(:payload) { { project_folder_mode: :automatic } }
it do
@@ -95,10 +95,10 @@ def fire_event(event_constant_name)
end
end
- describe 'OAUTH_CLIENT_TOKEN_CREATED' do
- subject { fire_event('OAUTH_CLIENT_TOKEN_CREATED') }
+ describe "OAUTH_CLIENT_TOKEN_CREATED" do
+ subject { fire_event("OAUTH_CLIENT_TOKEN_CREATED") }
- context 'when payload is empty' do
+ context "when payload is empty" do
let(:payload) { {} }
it do
@@ -107,8 +107,8 @@ def fire_event(event_constant_name)
end
end
- context 'when payload contains storage integration type' do
- let(:payload) { { integration_type: 'Storages::Storage' } }
+ context "when payload contains storage integration type" do
+ let(:payload) { { integration_type: "Storages::Storage" } }
it do
subject
@@ -117,10 +117,10 @@ def fire_event(event_constant_name)
end
end
- describe 'ROLE_UPDATED' do
- subject { fire_event('ROLE_UPDATED') }
+ describe "ROLE_UPDATED" do
+ subject { fire_event("ROLE_UPDATED") }
- context 'when payload is empty' do
+ context "when payload is empty" do
let(:payload) { {} }
it do
@@ -129,7 +129,7 @@ def fire_event(event_constant_name)
end
end
- context 'when payload contains some nextcloud related permissions as a diff' do
+ context "when payload contains some nextcloud related permissions as a diff" do
let(:payload) { { permissions_diff: [:read_files] } }
it do
@@ -139,10 +139,10 @@ def fire_event(event_constant_name)
end
end
- describe 'ROLE_DESTROYED' do
- subject { fire_event('ROLE_DESTROYED') }
+ describe "ROLE_DESTROYED" do
+ subject { fire_event("ROLE_DESTROYED") }
- context 'when payload is empty' do
+ context "when payload is empty" do
let(:payload) { {} }
it do
@@ -151,7 +151,7 @@ def fire_event(event_constant_name)
end
end
- context 'when payload contains some nextcloud related permissions' do
+ context "when payload contains some nextcloud related permissions" do
let(:payload) { { permissions: [:read_files] } }
it do
diff --git a/spec/lib/open_project/feature_decisions_spec.rb b/spec/lib/open_project/feature_decisions_spec.rb
index 493cf216b851..308d05d97f82 100644
--- a/spec/lib/open_project/feature_decisions_spec.rb
+++ b/spec/lib/open_project/feature_decisions_spec.rb
@@ -25,68 +25,68 @@
#
# See COPYRIGHT and LICENSE files for more details.
# ++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::FeatureDecisions, :settings_reset do
let(:flag_name) { :example_flag }
- include_context 'with clean feature decisions'
+ include_context "with clean feature decisions"
- shared_context 'when adding without env variable' do
+ shared_context "when adding without env variable" do
before do
described_class.add flag_name
end
end
- shared_context 'when adding the given feature flag' do
+ shared_context "when adding the given feature flag" do
before do
described_class.add flag_name
end
end
- describe '`flag_name`_active?' do
- context 'without an ENV variable' do
- include_context 'when adding without env variable'
+ describe "`flag_name`_active?" do
+ context "without an ENV variable" do
+ include_context "when adding without env variable"
- it 'is false by default' do
+ it "is false by default" do
expect(described_class.send(:"#{flag_name}_active?"))
.to be false
end
end
- context 'with an ENV variable (set to true)',
- with_env: { 'OPENPROJECT_FEATURE_EXAMPLE_FLAG_ACTIVE' => 'true' } do
- include_context 'when adding the given feature flag'
+ context "with an ENV variable (set to true)",
+ with_env: { "OPENPROJECT_FEATURE_EXAMPLE_FLAG_ACTIVE" => "true" } do
+ include_context "when adding the given feature flag"
- it 'is true' do
+ it "is true" do
expect(described_class.send(:"#{flag_name}_active?"))
.to be true
end
end
end
- describe 'active' do
- context 'without any flags defined' do
- it 'returns an empty array' do
+ describe "active" do
+ context "without any flags defined" do
+ it "returns an empty array" do
expect(described_class.active)
.to eq []
end
end
- context 'with a flag defined but not enabled' do
- include_context 'when adding without env variable'
+ context "with a flag defined but not enabled" do
+ include_context "when adding without env variable"
- it 'returns an empty array' do
+ it "returns an empty array" do
expect(described_class.active)
.to eq []
end
end
- context 'with a flag defined that is enabled via env',
- with_env: { 'OPENPROJECT_FEATURE_EXAMPLE_FLAG_ACTIVE' => 'true' } do
- include_context 'when adding the given feature flag'
+ context "with a flag defined that is enabled via env",
+ with_env: { "OPENPROJECT_FEATURE_EXAMPLE_FLAG_ACTIVE" => "true" } do
+ include_context "when adding the given feature flag"
- it 'returns an empty array' do
+ it "returns an empty array" do
expect(described_class.active)
.to eq [flag_name.to_s]
end
diff --git a/spec/lib/open_project/file_command_content_type_detector_spec.rb b/spec/lib/open_project/file_command_content_type_detector_spec.rb
index d22cf03f0eec..f7407dc0f110 100644
--- a/spec/lib/open_project/file_command_content_type_detector_spec.rb
+++ b/spec/lib/open_project/file_command_content_type_detector_spec.rb
@@ -54,27 +54,27 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::FileCommandContentTypeDetector do
- it 'returns a content type based on the content of the file' do
- tempfile = Tempfile.new('something')
- tempfile.write('This is a file.')
+ it "returns a content type based on the content of the file" do
+ tempfile = Tempfile.new("something")
+ tempfile.write("This is a file.")
tempfile.rewind
- expect(OpenProject::FileCommandContentTypeDetector.new(tempfile.path).detect).to eq('text/plain')
+ expect(OpenProject::FileCommandContentTypeDetector.new(tempfile.path).detect).to eq("text/plain")
tempfile.close
end
- it 'returns a sensible default when the file command is missing' do
- allow(Open3).to receive(:capture2).and_raise 'o noes!'
- @filename = '/path/to/something'
- expect(OpenProject::FileCommandContentTypeDetector.new(@filename).detect).to eq('application/binary')
+ it "returns a sensible default when the file command is missing" do
+ allow(Open3).to receive(:capture2).and_raise "o noes!"
+ @filename = "/path/to/something"
+ expect(OpenProject::FileCommandContentTypeDetector.new(@filename).detect).to eq("application/binary")
end
- it 'returns a sensible default on the odd chance that run returns nil' do
+ it "returns a sensible default on the odd chance that run returns nil" do
allow(Open3).to receive(:capture2).and_return [nil, 0]
- expect(OpenProject::FileCommandContentTypeDetector.new('windows').detect).to eq('application/binary')
+ expect(OpenProject::FileCommandContentTypeDetector.new("windows").detect).to eq("application/binary")
end
end
diff --git a/spec/lib/open_project/files_spec.rb b/spec/lib/open_project/files_spec.rb
index a87233b1ea84..8ef991f0401a 100644
--- a/spec/lib/open_project/files_spec.rb
+++ b/spec/lib/open_project/files_spec.rb
@@ -54,46 +54,46 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::Files do
- describe 'build_uploaded_file' do
- let(:original_filename) { 'test.png' }
- let(:content_type) { 'image/png' }
+ describe "build_uploaded_file" do
+ let(:original_filename) { "test.png" }
+ let(:content_type) { "image/png" }
let(:file) do
OpenProject::Files.create_temp_file(name: original_filename)
end
subject { OpenProject::Files.build_uploaded_file(file, content_type) }
- it 'has the original file name' do
+ it "has the original file name" do
expect(subject.original_filename).to eql(original_filename)
end
- it 'has the given content type' do
+ it "has the given content type" do
expect(subject.content_type).to eql(content_type)
end
- context 'with custom file name' do
- let(:file_name) { 'my-custom-filename.png' }
+ context "with custom file name" do
+ let(:file_name) { "my-custom-filename.png" }
subject { OpenProject::Files.build_uploaded_file(file, content_type, file_name:) }
- it 'has the custom file name' do
+ it "has the custom file name" do
expect(subject.original_filename).to eql(file_name)
end
end
end
- describe 'create_uploaded_file' do
- context 'without parameters' do
+ describe "create_uploaded_file" do
+ context "without parameters" do
let(:file) { OpenProject::Files.create_uploaded_file }
it 'creates a file with the default name "test.txt"' do
- expect(file.original_filename).to eq 'test.txt'
+ expect(file.original_filename).to eq "test.txt"
end
- it 'creates distinct files even with identical names' do
+ it "creates distinct files even with identical names" do
file_2 = OpenProject::Files.create_uploaded_file
expect(file.original_filename).to eq file_2.original_filename
@@ -101,18 +101,18 @@
end
it 'writes some default content "test content"' do
- expect(file.read).to eq 'test content'
+ expect(file.read).to eq "test content"
end
it 'set default content type "text/plain"' do
- expect(file.content_type).to eq 'text/plain'
+ expect(file.content_type).to eq "text/plain"
end
end
- context 'with a custom name, content and content type' do
- let(:name) { 'foo.jpg' }
- let(:content) { 'not-really-a-jpg' }
- let(:content_type) { 'image/jpeg' }
+ context "with a custom name, content and content type" do
+ let(:name) { "foo.jpg" }
+ let(:content) { "not-really-a-jpg" }
+ let(:content_type) { "image/jpeg" }
let(:file) do
OpenProject::Files.create_uploaded_file name:,
@@ -124,7 +124,7 @@
expect(file.original_filename).to eq name
end
- it 'writes the custom content' do
+ it "writes the custom content" do
expect(file.read).to eq content
end
@@ -133,19 +133,19 @@
end
end
- context 'with binary content' do
+ context "with binary content" do
let(:content) { "\xD1\x9B\x86".b }
let(:binary) { false }
let(:file) { OpenProject::Files.create_uploaded_file content:, binary: }
- it 'fails when the content is not marked as binary' do
+ it "fails when the content is not marked as binary" do
expect { file }.to raise_error(Encoding::UndefinedConversionError)
end
- context 'with the file denoted as binary' do
+ context "with the file denoted as binary" do
let(:binary) { true }
- it 'succeeds' do
+ it "succeeds" do
expect(file.read).to eq content
end
end
diff --git a/spec/lib/open_project/footer_spec.rb b/spec/lib/open_project/footer_spec.rb
index 2923f6a51ca0..392e37793274 100644
--- a/spec/lib/open_project/footer_spec.rb
+++ b/spec/lib/open_project/footer_spec.rb
@@ -26,30 +26,30 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
-require 'open_project/footer'
+require "spec_helper"
+require "open_project/footer"
RSpec.describe OpenProject::Footer do
- describe '.add_content' do
- context 'empty content' do
+ describe ".add_content" do
+ context "empty content" do
before do
OpenProject::Footer.content = nil
- OpenProject::Footer.add_content('OpenProject', 'footer')
+ OpenProject::Footer.add_content("OpenProject", "footer")
end
it { expect(OpenProject::Footer.content.class).to eq(Hash) }
- it { expect(OpenProject::Footer.content['OpenProject']).to eq('footer') }
+ it { expect(OpenProject::Footer.content["OpenProject"]).to eq("footer") }
end
- context 'existing content' do
+ context "existing content" do
before do
OpenProject::Footer.content = nil
- OpenProject::Footer.add_content('OpenProject', 'footer')
- OpenProject::Footer.add_content('footer_2', 'footer 2')
+ OpenProject::Footer.add_content("OpenProject", "footer")
+ OpenProject::Footer.add_content("footer_2", "footer 2")
end
it { expect(OpenProject::Footer.content.count).to eq(2) }
- it { expect(OpenProject::Footer.content).to eq('OpenProject' => 'footer', 'footer_2' => 'footer 2') }
+ it { expect(OpenProject::Footer.content).to eq("OpenProject" => "footer", "footer_2" => "footer 2") }
end
end
end
diff --git a/spec/lib/open_project/form_tag_helper_spec.rb b/spec/lib/open_project/form_tag_helper_spec.rb
index 53e0505b5274..706864cd5426 100644
--- a/spec/lib/open_project/form_tag_helper_spec.rb
+++ b/spec/lib/open_project/form_tag_helper_spec.rb
@@ -26,21 +26,21 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-require 'spec_helper'
+require "spec_helper"
RSpec.describe OpenProject::FormTagHelper, type: :helper do
let(:options) { {} }
- describe '#styled_form_tag' do
+ describe "#styled_form_tag" do
subject(:output) do
- helper.styled_form_tag('/feedback', options) do
- content_tag(:p, 'Form content')
+ helper.styled_form_tag("/feedback", options) do
+ content_tag(:p, "Form content")
end
end
- it_behaves_like 'not wrapped in container', 'form-container'
+ it_behaves_like "not wrapped in container", "form-container"
- it 'outputs element' do
+ it "outputs element" do
expect(output).to be_html_eql(%{