Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-interactive editing of State and Signaling diagrams #9

Open
vareb opened this issue Nov 13, 2024 · 3 comments
Open

Support non-interactive editing of State and Signaling diagrams #9

vareb opened this issue Nov 13, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@vareb
Copy link
Contributor

vareb commented Nov 13, 2024

Goal: be at least as good as the official PlantUML online tool for editing state diagrams. That is, no right-side interactivity, but at least we shouldn't crash or hang.
For example, we produce an error if we have the following diagram:

@startuml
state Identify_GTP_C_message
@enduml

Hovering over the participants also displays an error.

Solution proposal: identify if the diagram is currently an Activity diagram and then enable all the right-side features, otherwise disable them all. PlantUML itself does this identification when converting the diagrams, so it is possible.

@vareb vareb added the enhancement New feature or request label Nov 13, 2024
vareb added a commit that referenced this issue Nov 19, 2024
@vareb vareb closed this as completed Nov 22, 2024
vareb added a commit that referenced this issue Nov 28, 2024
@Godsmith
Copy link
Contributor

Godsmith commented Dec 4, 2024

@Godsmith Godsmith reopened this Dec 4, 2024
@Godsmith
Copy link
Contributor

Godsmith commented Dec 4, 2024

Nevermind, I ran into #5 >_< We should prioritize that.

@Godsmith Godsmith closed this as completed Dec 4, 2024
@Godsmith
Copy link
Contributor

Godsmith commented Dec 4, 2024

Reopening this again. This signaling diagram still gives errors:

https://pdupc-pcsmplantuml.sero.wh.rnd.internal.ericsson.com/?SoWkIImgAStDuKhCAL58r5F8J5F8orS8BKX9B4dbIbJGjLD8uahDIr40IdCv01b0fG0=

@startuml
alt a. if no Update
a -> b
end alt
@enduml

"end" should not be a inclusion criteria here: https://github.com/Ericsson/PlantUML-Interactive-Editor/blob/main/src/plantuml_gui/static/script.js#L3545C5-L3545C103 ; it is actually used in both sequence diagram (for blocks), use case diagrams and state diagrams (for notes)

"start" seems to still be fine though.

@Godsmith Godsmith reopened this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants