-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support non-interactive editing of State and Signaling diagrams #9
Comments
@vareb I deployed, but still get the error popups? https://pdupc-pcsmplantuml.sero.wh.rnd.internal.ericsson.com/?SoWkIImgAStDuG8oIb8LF5DIyqeoqohZtKC2uftZSrEBYnFJKxaSKlDIW8e0 |
Nevermind, I ran into #5 >_< We should prioritize that. |
Reopening this again. This signaling diagram still gives errors:
"end" should not be a inclusion criteria here: https://github.com/Ericsson/PlantUML-Interactive-Editor/blob/main/src/plantuml_gui/static/script.js#L3545C5-L3545C103 ; it is actually used in both sequence diagram (for blocks), use case diagrams and state diagrams (for notes) "start" seems to still be fine though. |
Goal: be at least as good as the official PlantUML online tool for editing state diagrams. That is, no right-side interactivity, but at least we shouldn't crash or hang.
For example, we produce an error if we have the following diagram:
Hovering over the participants also displays an error.
Solution proposal: identify if the diagram is currently an Activity diagram and then enable all the right-side features, otherwise disable them all. PlantUML itself does this identification when converting the diagrams, so it is possible.
The text was updated successfully, but these errors were encountered: