Migrate to DSharpPlus.Commands #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Text command names are in the format "commandtextcmd", like "bantextcmd"; the original name ("ban") is now the first alias
# Conflicts: # Cliptok.csproj # Commands/InteractionCommands/BanInteractions.cs # Commands/InteractionCommands/RoleInteractions.cs # Commands/InteractionCommands/RulesInteractions.cs # Commands/InteractionCommands/TrackingInteractions.cs # Commands/InteractionCommands/WarningInteractions.cs # Commands/Warnings.cs # Program.cs
# Conflicts: # Commands/InteractionCommands/ClearInteractions.cs
# Conflicts: # Commands/InteractionCommands/DebugInteractions.cs # Commands/ListCmds.cs
Erisa
reviewed
Nov 22, 2024
There was a problem hiding this comment.
Adding from chat:
- Text help command needed for feature parity, currently looks like we'd need to implement our own
- Context commands dont register due to warning:
The first parameter of '"Show Avatar"' does not implement SlashCommandContext. Since this command is being registered as a user context menu command, it's first parameter must inherit the SlashCommandContext class. - Invalid command syntax error is missing the human-friendly "This usually means you used the command incorrectly" section
…otential DSharpPlus bug
Nightly 02426 resolves the bug that was present in DSharpPlus
# Conflicts: # Commands/DebugCmds.cs
Show correct command names & permissions in RequireHomeserverPerm failure messages, properly honor OwnerOverride
# Conflicts: # Commands/NicknameLockCmds.cs
Fixes aliases not showing for some commands + help failing to show for commands that are not suffixed with 'textcmd'
Erisa
approved these changes
Jan 13, 2025
|
Those changes make sense to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #202.
textcmd—the original name withouttextcmdis added as an alias, andtextcmdis also stripped out of the command name in things like error handlingCommandsnamespace—Commands.InteractionCommandsno longer exists[SlashRequireHomeserverPerm]no longer exists and is merged with[RequireHomeserverPerm]