Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT Marketplace #1696

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

JIT Marketplace #1696

wants to merge 9 commits into from

Conversation

tbro
Copy link
Contributor

@tbro tbro commented Jul 11, 2024 •
edited
Loading

Supersedes #1633 and #1659, bringing in FullNetworkTx and multiple fees per block changes.

This PR:

Adds types and implementations for JIT marketplace. It includes changes for multiple fees per block. It doesn't currently compile due to pending changes in traits defined in HotShot.

Key places to review:

  • auction.rs (impl and v0_3 type)
  • header.rs (impl and v0_3 type)
  • v0_3/chain_config.rs
  • impls/state.rs

How to test this PR:

Currently untestable due to unsatisfied external dependencies.

@tbro tbro requested a review from imabdulbasit July 11, 2024 16:45
@tbro tbro mentioned this pull request Jul 11, 2024
Closed
@tbro tbro closed this Jul 11, 2024
@tbro tbro reopened this Jul 11, 2024
@tbro tbro mentioned this pull request Jul 11, 2024
Closed
imabdulbasit
imabdulbasit reviewed Jul 11, 2024
View reviewed changes
types/src/v0/v0_1/chain_config.rs Outdated
@@ -40,6 +40,9 @@ pub struct ChainConfig {
/// regardless of whether or not their is a `fee_contract` deployed. Once deployed, the fee
/// contract can decide what to do with tokens locked in this account in Espresso.
pub fee_recipient: FeeAccount,

/// Account that receives sequencing bids.
pub bid_recipient: FeeAccount,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change so shouldn't we create a new v3 chain config and use that ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

originally fixed in fd74b19 and kinks mostly worked out in f1be763

tbro added 6 commits July 17, 2024 15:07
@tbro
Iterable FeeInfo
b03d349 
Closes #1659.
@tbro
Add marketplace types
99cba4a 
`BidTx` as a varian of `FullNetworkTx`. Includes some tests.

Closes #1633
@tbro
add v3 version of ChainConfig
0e98712
@tbro
enable full_network_txs field on Header
19ce4f0
@tbro
fixes for chain_config v3
2bc3b5a 
  * move NodeState and ValidatedState to `impl`
  * wrap `bid_reciepient` in an `Option`
  * Implement from `v0_1::ResolvableChainConfig` for `v0_3::ResolvableChainConfig`
@tbro
remove TODO since there is now constructor and friends
4a47b7f
tbro
tbro commented Jul 17, 2024
View reviewed changes
types/src/v0/v0_3/chain_config.rs
chain_config: Either::Left(ChainConfig::from(chain_config)),
},
// TODO does this work? is there a better way?
Either::Right(c) => ResolvableChainConfig {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think @jbearer ?

This was referenced Jul 24, 2024
Closed
Closed
tbro added a commit that referenced this pull request Jul 25, 2024
@tbro
Update to hotshot rc-0.5.66
3214997 
Most changes are being brought in from #1696. Also includes changes
from #1781. Most compile errors are fixed. Depends on
`hotshot-query-service` pointing to the same hotshot tab (see
Cargo.tmol patch).
@tbro tbro mentioned this pull request Jul 25, 2024
Merged
tbro added a commit that referenced this pull request Jul 26, 2024
@tbro
Update to hotshot rc-0.5.66
e5507e3 
Most changes are being brought in from #1696. Also includes changes
from #1781. Most compile errors are fixed. Depends on
`hotshot-query-service` pointing to the same hotshot tab (see
Cargo.tmol patch).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imabdulbasit imabdulbasit imabdulbasit left review comments

@philippecamacho philippecamacho Awaiting requested review from philippecamacho philippecamacho will be requested when the pull request is marked ready for review philippecamacho is a code owner

@ImJeremyHe ImJeremyHe Awaiting requested review from ImJeremyHe ImJeremyHe will be requested when the pull request is marked ready for review ImJeremyHe is a code owner

@sveitser sveitser Awaiting requested review from sveitser sveitser will be requested when the pull request is marked ready for review sveitser is a code owner

@jbearer jbearer Awaiting requested review from jbearer jbearer will be requested when the pull request is marked ready for review jbearer is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbro @imabdulbasit