Forward OP transactions to sequencer #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nomaxg <[email protected]>
Signed-off-by: nomaxg <[email protected]>
Signed-off-by: nomaxg <[email protected]>
jbearer
requested changes
Aug 9, 2023
Signed-off-by: nomaxg <[email protected]>
Signed-off-by: nomaxg <[email protected]>
jbearer
requested changes
Aug 9, 2023
op-geth-proxy/geth-proxy.go
Outdated
| @@ -36,11 +37,20 @@ type rpcMessage struct { | |||
| } | |||
|
|
|||
| func ForwardToSequencer(message rpcMessage) { | |||
| var hexString string | |||
| if err := json.Unmarshal(message.Params[0], &hexString); err != nil { | |||
| panic(err) | |||
There was a problem hiding this comment.
We should not panic based on user input. Better to log the error and do nothing, the client can then retry and the server will still be alive
There was a problem hiding this comment.
Seems like there is some panic recovery built in to this http request handler (sending invalid bytes doesn't kill the server). Still, I think the stack trace is unnecessary here, so I'll switch to logging
Signed-off-by: nomaxg <[email protected]>
jbearer
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple proxy service that parses payload data from an
eth_sendRawTransactonRPC request and forwards it to Espresso sequencer.Note that this will still forward txns to the op-geth mempool (I wanted to keep the RPC API intact completely), but we can prevent mempool bloat by adjusting TRANSACTION POOL settings here: https://geth.ethereum.org/docs/fundamentals/command-line-options.
Closes #1