Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focused dropdown item loses ring when hovered #10335

Closed
2 of 6 tasks
nwhittaker opened this issue Sep 17, 2024 · 3 comments
Closed
2 of 6 tasks

Focused dropdown item loses ring when hovered #10335

nwhittaker opened this issue Sep 17, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. good first issue Issues that can be worked on by contributors new to calcite-components. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-12-17 - Dec ...

Comments

@nwhittaker
Copy link
Contributor

Check existing issues

Actual Behavior

The focused dropdown-item loses its focus ring when it's hovered.

Screen.Recording.2024-09-17.at.3.26.07.PM.mov

Expected Behavior

The focus ring is maintained on hover.

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/dropdown/#sample

Reproduction Steps

  1. Visit the dropdown doc sample.
  2. Move the pointer over the dropdown items.

Reproduction Version

2.12.2

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

Impact is on usability. Losing the focus ring is confusing as it implies focus was shifted somewhere else.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Field Apps
@nwhittaker nwhittaker added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 17, 2024
@github-actions github-actions bot added ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Sep 17, 2024
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. good first issue Issues that can be worked on by contributors new to calcite-components. and removed needs triage Planning workflow - pending design/dev review. labels Nov 5, 2024
@DitwanP DitwanP added this to the 2025-07-29 - 3.3.0 Jul Release milestone Dec 2, 2024
@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Dec 2, 2024
@jcfranco jcfranco mentioned this issue Dec 3, 2024
Merged
@jcfranco
Copy link
Member

jcfranco commented Dec 3, 2024

@geospatialem @DitwanP Fixed this locally as I was working on #7688. Submitted a PR, so we can move this to an upcoming milestone.

@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Dec 3, 2024
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 3, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 3, 2024
@geospatialem
Copy link
Member

Verified on 3.0.0-next.46:

verify-drowndown-focus-hover

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. good first issue Issues that can be worked on by contributors new to calcite-components. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

No branches or pull requests
4 participants
@jcfranco @nwhittaker @geospatialem @DitwanP