Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[List] padding corrections to new scales #10940

Open
5 of 12 tasks
ashetland opened this issue Dec 2, 2024 · 0 comments
Open
5 of 12 tasks

[List] padding corrections to new scales #10940

ashetland opened this issue Dec 2, 2024 · 0 comments
Assignees
Labels
2 - in development Issues that are actively being worked on. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality visual changes Issues with visual changes that are added for consistency, but are not backwards compatible

Comments

@ashetland
Copy link

ashetland commented Dec 2, 2024

Check existing issues

Actual Behavior

There are some padding discrepancies on medium and large scale when comparing to the design spec.

Medium scale:

  • When drag-enabled and display-mode="nested", the selection-container only has right padding.

Large scale:

  • The content-container has 20px of right padding
  • The row-container has 20px of left padding

All scales:

  • There is extra left padding on drag-enabled display-mode="nested" selection-appearance="icon"

Expected Behavior

Small scale:

  • When drag-enabled display-mode="nested" selection-appearance="icon", row-container padding-inline-start should be 0px

Medium scale:

  • When drag-enabled and display-mode="nested", the selection-container has 4px padding-inline (space.xxs)
  • When drag-enabled display-mode="nested" selection-appearance="icon", row-container padding-inline-start should be 4px

Large scale:

  • content-container padding-inline-end should be 16px (space.lg)
  • row-container padding-inline-start should be 16px (space.lg)
  • When drag-enabled display-mode="nested" selection-appearance="icon", row-container padding-inline-start should be 4px

Reproduction Sample

https://esri.github.io/calcite-design-system/?path=/story/components-list--scales

Reproduction Steps

Inspect elements as noted above.

Reproduction Version

v3.0.0-next.41

Relevant Info

Follow up to PR #10853.
cc @eriklharper

Regression?

No response

Priority impact

impact - p1 - need for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)

@ashetland ashetland added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 2, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Dec 2, 2024
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality 1 - assigned Issues that are assigned to a sprint and a team member. estimate - 2 Small fix or update, may require updates to tests. and removed 0 - new New issues that need assignment. labels Dec 2, 2024
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Dec 2, 2024
@eriklharper eriklharper added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Dec 3, 2024
@eriklharper eriklharper added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - in development Issues that are actively being worked on. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Projects
None yet
Development

No branches or pull requests

3 participants