Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: [calcite-tree] add selection-mode "none" #3121

Closed
caripizza opened this issue Sep 28, 2021 · 9 comments
Closed

Enhancement: [calcite-tree] add selection-mode "none" #3121

caripizza opened this issue Sep 28, 2021 · 9 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. enhancement Issues tied to a new feature or request.

Comments

@caripizza
Copy link
Contributor

Description

Support a calcite-tree selection-mode of "none", for displaying a hierarchical list of tree-items which display no icons on hover/focus, and do not allow any items to be selected.

Acceptance Criteria

A new selection-mode of "none" is added to the TreeSelectionMode type values. When a tree has selection-mode "none", no child tree-items can be selected, and no icons appear on :hover or :focus.

Relevant Info

Related issue tied to this request: #2210 (cc @bpatterson88)

Which Component

calcite-tree, calcite-tree-item

Example Use Case

(See screenshots provided in #2210)

@caripizza caripizza added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 28, 2021
@caripizza
Copy link
Contributor Author

Here's one example I found in the wild of "none" selection-mode with IntegralUI's TreeView component for Angular:
https://www.lidorsystems.com/support/articles/angular/treeview/treeview-multi-select.aspx

@macandcheese
Copy link
Contributor

This implementation from SAP also uses "none": https://sap.github.io/ui5-webcomponents/playground/components/Tree/

@ellenupp
Copy link

Use case for Dashboards:
We are using a tree to represent the layout of the elements in the dashboard. The tree does not need a selection state. Clicking a tree item should place focus on that item but not otherwise change its state. Tree items don't need bullet point and instead child items have a custom icon.
image

@jcfranco
Copy link
Member

Please add your planning poker estimate with ZenHub @caripizza

@paulcpederson
Copy link
Member

We also have a use case for this. Seems pretty straight forward, I could try to add this?

@benelan
Copy link
Member

benelan commented Jul 19, 2022

Sure, @paulcpederson, we always appreciate your help!

@benelan benelan added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jul 19, 2022
@benelan benelan added this to the Sprint 07/25 - 08/05 milestone Jul 19, 2022
@jcfranco jcfranco removed the needs triage Planning workflow - pending design/dev review. label Aug 10, 2022
@jcfranco
Copy link
Member

Stealing this one... 👿

@jcfranco jcfranco assigned jcfranco and unassigned paulcpederson Aug 10, 2022
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 10, 2022
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 16, 2022
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 18, 2022
@geospatialem
Copy link
Member

Verified in beta.92 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. enhancement Issues tied to a new feature or request.
Projects
None yet
Development

No branches or pull requests

7 participants