-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: [calcite-tree-item] limit padding-y CSS var to top/bottom spacing, remove end indent #3223
Labels
4 - verified
Issues that have been released and confirmed resolved.
enhancement
Issues tied to a new feature or request.
Milestone
Comments
caripizza
added
enhancement
Issues tied to a new feature or request.
0 - new
New issues that need assignment.
needs triage
Planning workflow - pending design/dev review.
labels
Oct 13, 2021
sure thing! |
caripizza
added
1 - assigned
Issues that are assigned to a sprint and a team member.
2 - in development
Issues that are actively being worked on.
and removed
0 - new
New issues that need assignment.
1 - assigned
Issues that are assigned to a sprint and a team member.
labels
Oct 13, 2021
caripizza
added a commit
that referenced
this issue
Oct 13, 2021
jcfranco
pushed a commit
that referenced
this issue
Nov 17, 2021
…emove end indentation (#3237) #3223 Co-authored-by: Ben Elan <[email protected]>
jcfranco
added
3 - installed
Issues that have been merged to master branch and are ready for final confirmation.
and removed
2 - in development
Issues that are actively being worked on.
labels
Nov 17, 2021
Installed and assigned for verification. |
@macandcheese can you please help me verify this installed design issue? |
LGTM although I don't believe that css variable should be customizable, teams can just adjust padding themselves with divs they slot. Oh well, it's fine for now and we can re-visit when these get refactored with the list-item slot paradigm. |
benelan
added
4 - verified
Issues that have been released and confirmed resolved.
and removed
3 - installed
Issues that have been merged to master branch and are ready for final confirmation.
labels
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4 - verified
Issues that have been released and confirmed resolved.
enhancement
Issues tied to a new feature or request.
Description
Pr #3001 refactored tree-item to match latest Figma designs. In doing so, I repurposed a
--calcite-tree-padding-y
CSS var for the item's margin-inline styles as well. However, it came up recently with the Dashboards team that they'd like to fine-tune the top/bottom item spacing independently of the left/right spacing. cc @ellenuppThis issue should:
Acceptance Criteria
a ) Updating the
--calcite-tree-padding-y
CSS var value on calcite-tree-item only changes its top/bottom spacingb) There are no more margin-inline-end styles (end-indentation) on tree-items
Relevant Info
n/a
Which Component
calcite-tree-item
Example Use Case
See issues #2210 and #3127 for more details on the related designs driving this request.
The text was updated successfully, but these errors were encountered: