Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: [calcite-tree-item] limit padding-y CSS var to top/bottom spacing, remove end indent #3223

Closed
caripizza opened this issue Oct 13, 2021 · 5 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. enhancement Issues tied to a new feature or request.

Comments

@caripizza
Copy link
Contributor

caripizza commented Oct 13, 2021

Description

Pr #3001 refactored tree-item to match latest Figma designs. In doing so, I repurposed a --calcite-tree-padding-y CSS var for the item's margin-inline styles as well. However, it came up recently with the Dashboards team that they'd like to fine-tune the top/bottom item spacing independently of the left/right spacing. cc @ellenupp

This issue should:

  • refactor tree-item to derive it's margin-inline styles from the TW config instead of the padding-y var, so consumers can set the padding-y CSS var value to something different without affecting the left/right margins on a tree-item.
  • remove the margin-inline-end style from the children-container's tree-items.

Acceptance Criteria

a ) Updating the --calcite-tree-padding-y CSS var value on calcite-tree-item only changes its top/bottom spacing
b) There are no more margin-inline-end styles (end-indentation) on tree-items

Relevant Info

n/a

Which Component

calcite-tree-item

Example Use Case

See issues #2210 and #3127 for more details on the related designs driving this request.

@caripizza caripizza added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Oct 13, 2021
@caripizza
Copy link
Contributor Author

@benelan and @jcfranco - can we add this one to the current sprint?

@benelan benelan removed the needs triage Planning workflow - pending design/dev review. label Oct 13, 2021
@benelan benelan added this to the Sprint 10/11 – 10/22 milestone Oct 13, 2021
@benelan
Copy link
Member

benelan commented Oct 13, 2021

sure thing!

@caripizza caripizza self-assigned this Oct 13, 2021
@caripizza caripizza added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 13, 2021
jcfranco pushed a commit that referenced this issue Nov 17, 2021
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 17, 2021
@github-actions github-actions bot assigned benelan and unassigned caripizza Nov 17, 2021
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@benelan
Copy link
Member

benelan commented Dec 6, 2021

@macandcheese can you please help me verify this installed design issue?

@macandcheese
Copy link
Contributor

LGTM although I don't believe that css variable should be customizable, teams can just adjust padding themselves with divs they slot. Oh well, it's fine for now and we can re-visit when these get refactored with the list-item slot paradigm.

@benelan benelan closed this as completed Dec 7, 2021
@benelan benelan added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. enhancement Issues tied to a new feature or request.
Projects
None yet
Development

No branches or pull requests

4 participants