Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[calcite-filter] Add support for custom filter function #3454

Open
jcfranco opened this issue Nov 9, 2021 · 4 comments
Open

[calcite-filter] Add support for custom filter function #3454

jcfranco opened this issue Nov 9, 2021 · 4 comments
Labels
0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library

Comments

@jcfranco
Copy link
Member

jcfranco commented Nov 9, 2021

Description

There is a need to support custom filtering for end-users (see #2208, #2209).

Acceptance Criteria

Allow users to pass a custom filter function to calcite-filter. This still needs more details, but a few items to consider:

cc @ffaubry, @dhrumil83, @AdelheidF, @benelan for additional requirement gathering

Relevant Info

Which Component

calcite-filter

Example Use Case

See linked issues from description.

@jcfranco jcfranco added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. discussion Issues relating to a conversation where feedback is optional. labels Nov 9, 2021
@jcfranco jcfranco self-assigned this May 10, 2022
@jcfranco jcfranco added the need more info Issues that are missing information and/or a clear, actionable description. label May 10, 2022
@jcfranco jcfranco removed their assignment Jun 3, 2023
@jcfranco jcfranco removed the need more info Issues that are missing information and/or a clear, actionable description. label Jun 3, 2023
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Aug 21, 2023
@geospatialem
Copy link
Member

@ffaubry @AdelheidF Calcite is considering this effort for a future milestone, and wanted to get your expertise with current and future workflows to help determine prioritization and need. Could you both speak to the impact and what you would expect CC would support?

@geospatialem geospatialem added the need more info Issues that are missing information and/or a clear, actionable description. label Aug 22, 2023
@ffaubry
Copy link
Member

ffaubry commented Aug 22, 2023

We would like to have two features:

  • a way to say what property of the list item we would like to filter on: label or description or both
  • pass a function that would be invoked for each list item with the filter value and the list item itself

@geospatialem is it what you are looking for?

@AdelheidF
Copy link

I think the discussion in the issue that Dhrumil submitted is still valid. We still would like to add a second filter, e.g. field type, to a list with a text filter. See #2209 (comment).

@geospatialem
Copy link
Member

Thank you both, that helps us with prioritization. Will be assigning to a future milestone in the next few weeks.

@geospatialem geospatialem removed the need more info Issues that are missing information and/or a clear, actionable description. label Aug 22, 2023
@geospatialem geospatialem added this to the 2024 April Priorities milestone Dec 6, 2023
@geospatialem geospatialem removed needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. discussion Issues relating to a conversation where feedback is optional. labels Dec 6, 2023
@brittneytewks brittneytewks added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Mar 25, 2024
@brittneytewks brittneytewks removed this from the 2024-04-30 - Apr Release milestone Mar 25, 2024
@geospatialem geospatialem added this to the 2024-12-17 - Dec Release milestone Apr 3, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 3, 2024
@geospatialem geospatialem added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label May 28, 2024
@geospatialem geospatialem removed this from the 2024-12-17 - Dec Release milestone May 28, 2024
@geospatialem geospatialem added this to the 2025-01-28 - Jan Release milestone May 31, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Development

No branches or pull requests

6 participants