Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to hide selection-mode from calcite trees #5186

Closed
ade10176 opened this issue Aug 18, 2022 · 9 comments
Closed

Option to hide selection-mode from calcite trees #5186

ade10176 opened this issue Aug 18, 2022 · 9 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. enhancement Issues tied to a new feature or request.

Comments

@ade10176
Copy link

ade10176 commented Aug 18, 2022

Description

The bullet indicator on a selected/hovered state of a calcite tree conflicts with the pending changes indicator that we've been using in Field Maps. We're looking for a way to relax the appearance of these states to the degree that the bullet is not present.

image

cc: @nwhittaker

Acceptance Criteria

Provide a way (possibly an appearance or selection-mode option) that has, or includes, the effect of suppressing the bullet for selected/hovered states of tree items.

Relevant Info

No response

Which Component

calcite-tree

Example Use Case

No response

@ade10176 ade10176 added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Aug 18, 2022
@jcfranco
Copy link
Member

jcfranco commented Sep 7, 2022

Would the none selection mode help here? Otherwise, we'll design to review this. cc @macandcheese

@nwhittaker
Copy link
Contributor

Thanks, I do think this new selection mode does get us most of the way there. One difference is that the disclosure arrows are no longer outdented.

A "blank" selection mode none selection mode
Screen Shot 2022-09-08 at 10 00 22 AM Screen Shot 2022-09-08 at 9 59 39 AM

Not sure if that's a bug or by design, though, but I imagine we can work with or around it (@ade10176?).

@ade10176
Copy link
Author

ade10176 commented Sep 8, 2022

Thanks @jcfranco I think the relationships are a bit confusing in the none selection mode. I'd expect all children to be aligned regardless whether they have a grand child or not. Are you able to clarify if that's by design or a bug @jcfranco?

@jcfranco
Copy link
Member

jcfranco commented Sep 8, 2022

@macandcheese @ashetland WDYT about ☝️? If we did want to preserve alignment, we can use the blank icon for none-selection. Luckily, we have a old commit with this that we can reapply.

@macandcheese
Copy link
Contributor

Agree w @ade10176 on this one :)

@ashetland
Copy link
Contributor

Agree w/ @ade10176 as well, alignment should be preserved. 😁

@jcfranco
Copy link
Member

jcfranco commented Sep 8, 2022

Triaging to this sprint. cc @benelan @geospatialem

@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 8, 2022
@Elijbet Elijbet added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Sep 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and unassigned Elijbet Sep 9, 2022
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 4, 2022
@geospatialem
Copy link
Member

Verified the child tree item alignment is preserved where selection-mode="none" in beta.95.

verified child tree item alignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. enhancement Issues tied to a new feature or request.
Projects
None yet
Development

No branches or pull requests

8 participants