Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Epic: Audit and update indentations and nested hierarchy across components #6632

Closed
5 tasks done
geospatialem opened this issue Mar 22, 2023 · 2 comments
Closed
5 tasks done

Epic: Audit and update indentations and nested hierarchy across components #6632

geospatialem opened this issue Mar 22, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. design Issues that need design consultation prior to development. epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Milestone
2024-12-17 - Dec ...

Comments

@geospatialem
Copy link
Member

geospatialem commented Mar 22, 2023 •
edited by ashetland
Loading

Background

Perform an audit across components to determine consistency and if needed update indentation for consistency across the design system, in particular within the nested hierarchy of the component.

Resulted from discussion in #6384

Components to address indentations

Audited list of components from research (completed on 6/2/23):

  • accordion (does not apply)
  • accordion-item (does not apply)
  • action (does not apply)
  • action-bar (does not apply)
  • action-group (does not apply)
  • action-menu (does not apply)
  • action-pad (does not apply)
  • alert (does not apply)
  • avatar (does not apply)
  • block (does not apply)
  • block-section (does not apply)
  • button (does not apply)
  • card (does not apply)
  • checkbox (does not apply)
  • chip (does not apply)
  • color-picker (does not apply)
  • combobox
  • combobox-item
  • combobox-item-group
  • date-picker (does not apply)
  • dropdown (no nesting, but including for icon spacing)
  • dropdown-group (no nesting, but including for icon spacing)
  • dropdown-item (no nesting, but including for icon spacing)
  • fab (does not apply)
  • filter (does not apply)
  • flow (does not apply)
  • flow-item (does not apply)
  • icon (does not apply)
  • inline-editable (does not apply)
  • input (does not apply)
  • input-date-picker (does not apply)
  • input-message (does not apply)
  • input-time-picker (does not apply)
  • label (does not apply)
  • link (does not apply)
  • list
  • list-item
  • list-item-group
  • loader (does not apply)
  • menu
  • menu item
  • modal (does not apply)
  • notice (does not apply)
  • option (does not apply)
  • option-group (does not apply)
  • pagination (does not apply)
  • panel (does not apply)
  • pick-list (deprecated)
  • pick-list-group (deprecated)
  • pick-list-item (deprecated)
  • popover (does not apply)
  • progress (does not apply)
  • radio-button (does not apply)
  • radio-button-group (does not apply)
  • radio-group (does not apply)
  • radio-group-item (does not apply)
  • rating (does not apply)
  • scrim (does not apply)
  • select (does not apply)
  • shell (does not apply)
  • shell-center-row (does not apply)
  • shell-panel (does not apply)
  • slider (does not apply)
  • split-button (does not apply)
  • stepper (does not apply)
  • stepper-item (does not apply)
  • switch (does not apply)
  • tab (does not apply)
  • tab-nav (does not apply)
  • tab-title (does not apply)
  • tabs (does not apply)
  • textarea(does not apply)
  • tile (does not apply)
  • tile-select (does not apply)
  • tile-select-group (does not apply)
  • time-picker (does not apply)
  • tip (does not apply)
  • tip-group (does not apply)
  • tip-manager (does not apply)
  • tooltip (does not apply)
  • tree
  • tree-item
  • value-list (deprecated)
  • value-list-item (deprecated)
@geospatialem geospatialem added design Issues that need design consultation prior to development. research Issues that require more in-depth research or multiple team members to resolve or make decision. 1 - assigned Issues that are assigned to a sprint and a team member. p - medium Issue is non core or affecting less that 60% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. labels Mar 22, 2023
@geospatialem geospatialem added this to the 2023 May Priorities milestone Mar 22, 2023
@ashetland ashetland mentioned this issue May 9, 2023
Open
@SkyeSeitz
Copy link

Linking issue #7076 for hover/click area considerations.

@geospatialem geospatialem mentioned this issue Jun 1, 2023
Closed
@geospatialem geospatialem changed the title Research indentations and nested heirarchy across components Audit and update indentations and nested hierarchy across components Jun 2, 2023
@geospatialem geospatialem added epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. and removed research Issues that require more in-depth research or multiple team members to resolve or make decision. labels Jun 2, 2023
@geospatialem geospatialem changed the title Audit and update indentations and nested hierarchy across components Epic: Audit and update indentations and nested hierarchy across components Jun 2, 2023
This was referenced Jun 2, 2023
Closed
Closed
Closed
Closed
Closed
@ashetland ashetland added ready for dev Issues ready for development implementation. and removed design Issues that need design consultation prior to development. labels Jun 2, 2023
@ashetland ashetland removed their assignment Jun 2, 2023
@geospatialem geospatialem added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 2, 2023
@ashetland ashetland added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Jun 2, 2023
@geospatialem geospatialem added this to the 2023 December Priorities milestone Jul 26, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Jul 26, 2023
@geospatialem geospatialem self-assigned this Jul 26, 2023
@brittneytewks brittneytewks added design Issues that need design consultation prior to development. and removed figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists labels Dec 11, 2023
@geospatialem geospatialem added the ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. label Jan 12, 2024
@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Dec 12, 2024
@geospatialem
Copy link
Member Author

All issues verified 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. design Issues that need design consultation prior to development. epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

No branches or pull requests
4 participants
@geospatialem @SkyeSeitz @ashetland @brittneytewks