Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dropdown, dropdown-item, dropdown-group update icon spacing #7095

Closed
Tracked by #6632
ashetland opened this issue Jun 2, 2023 · 2 comments
Closed
Tracked by #6632

dropdown, dropdown-item, dropdown-group update icon spacing #7095

ashetland opened this issue Jun 2, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Milestone
2024-05-28 - May ...

Comments

@ashetland
Copy link

ashetland commented Jun 2, 2023 •
edited
Loading

Description

Update icon spacing to make more consistent with the rest of Calcite. This was outlined as part of the work to audit and update nested indentations to improve visual hierarchy across components (Epic #6632).

Acceptance Criteria

image

Relevant Info

Figma file also available for additional details and a comparison to the current build.

Which Component

Dropdown Item

Example Use Case

No response

Priority impact

p4 - not time sensitive

Esri team

Calcite (design)
@ashetland ashetland added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 2, 2023
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jun 2, 2023
@ashetland ashetland added the ready for dev Issues ready for development implementation. label Jun 2, 2023
@ashetland ashetland mentioned this issue Jun 2, 2023
Closed
5 tasks
@ashetland ashetland added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Jun 2, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Jul 26, 2023
@geospatialem geospatialem added this to the 2023 December Priorities milestone Jul 26, 2023
@brittneytewks brittneytewks added the p - medium Issue is non core or affecting less that 60% of people using the library label Oct 24, 2023
@brittneytewks brittneytewks added design Issues that need design consultation prior to development. and removed figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists labels Dec 11, 2023
@brittneytewks brittneytewks added the estimate - 3 A day or two of work, likely requires updates to tests. label Jan 29, 2024
@anveshmekala anveshmekala self-assigned this May 13, 2024
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels May 13, 2024
@anveshmekala anveshmekala mentioned this issue May 14, 2024
Merged
anveshmekala added a commit that referenced this issue May 17, 2024
@anveshmekala
feat(dropdown-item): update spacing of icons (#9330)
c2e5a99 
**Related Issue:** #7095 

## Summary

Updates spacing of icons in `calcite-dropdown-item`.
@geospatialem geospatialem added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels May 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned anveshmekala May 23, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels May 23, 2024
@geospatialem
Copy link
Member

geospatialem commented May 23, 2024 •
edited
Loading

Verified spacing across scales in 2.9.0-next.18 with https://codepen.io/geospatialem/pen/bGyeZwM, where:

  • s is 8px
  • m is 12px
  • l is 16px

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2024-05-28 - May Main Release
Development

No branches or pull requests
5 participants
@geospatialem @DitwanP @anveshmekala @ashetland @brittneytewks