Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

menu, menu-item vertical layout: update indentation padding and icon spacing #7105

Closed
3 tasks done
Tracked by #6632
ashetland opened this issue Jun 2, 2023 · 2 comments
Closed
3 tasks done
Tracked by #6632

menu, menu-item vertical layout: update indentation padding and icon spacing #7105

ashetland opened this issue Jun 2, 2023 · 2 comments
Assignees
@geospatialem @SkyeSeitz @ashetland @brittneytewks
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. ready for dev Issues ready for development implementation.
Milestone
2023 July Priorities

Comments

@ashetland
Copy link

ashetland commented Jun 2, 2023 •
edited by macandcheese
Loading

Description

For menu-item layout=vertical, update indentation padding when nesting menu-items and update icon spacing for consistency. This was outlined as part of the work to audit and update nested indentations to improve visual hierarchy across components (Epic #6632).

See Figma file for full spec and additional context.

Acceptance Criteria

For vertical layout:

  • Update indentation padding of menu-items
  • Update icon spacing in menu-items
  • Adjust position of arrow-right when href is populated

Relevant Info

No response

Which Component

Menu Item

Example Use Case

No response

Priority impact

p3 - want for upcoming milestone

Esri team

Calcite (design)
@ashetland ashetland added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 2, 2023
@github-actions github-actions bot added p3 - want for upcoming milestone Calcite (design) Issues logged by Calcite designers. labels Jun 2, 2023
@ashetland ashetland added the ready for dev Issues ready for development implementation. label Jun 2, 2023
@ashetland ashetland mentioned this issue Jun 2, 2023
Closed
5 tasks
@ashetland ashetland added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Jun 2, 2023
@macandcheese macandcheese self-assigned this Jun 26, 2023
@macandcheese macandcheese added this to the 2023 July Priorities milestone Jun 26, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Jun 27, 2023
@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jul 25, 2023
@macandcheese macandcheese mentioned this issue Jul 26, 2023
Merged
macandcheese added a commit that referenced this issue Jul 28, 2023
@macandcheese
feat(menu-item): Update spacing and icon layout (#7381)
5659671 
**Related Issue:** #7105 

## Summary
Updates Menu Item to reflect Figma designs for complex combinations of
props:
<img width="330" alt="Screenshot 2023-07-26 at 3 22 06 PM"
src="https://github.com/Esri/calcite-design-system/assets/4733155/9a5da692-7698-4739-b984-e61409521eb4">
@macandcheese macandcheese added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 28, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 28, 2023
@geospatialem
Copy link
Member

Verified in 1.5.0-next.28

benelan pushed a commit that referenced this issue Aug 3, 2023
@macandcheese @benelan
feat(menu-item): Update spacing and icon layout (#7381)
1b19ce9 
**Related Issue:** #7105 

## Summary
Updates Menu Item to reflect Figma designs for complex combinations of
props:
<img width="330" alt="Screenshot 2023-07-26 at 3 22 06 PM"
src="https://github.com/Esri/calcite-design-system/assets/4733155/9a5da692-7698-4739-b984-e61409521eb4">
@SkyeSeitz SkyeSeitz removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Oct 27, 2023
@brittneytewks brittneytewks added the design Issues that need design consultation prior to development. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@SkyeSeitz SkyeSeitz

@ashetland ashetland

@brittneytewks brittneytewks

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2023 July Priorities
Development

No branches or pull requests
5 participants
@macandcheese @geospatialem @SkyeSeitz @ashetland @brittneytewks