Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Epic: Consistent expand/collapse states #7703

Closed
5 tasks done
geospatialem opened this issue Sep 8, 2023 · 3 comments
Closed
5 tasks done

Epic: Consistent expand/collapse states #7703

geospatialem opened this issue Sep 8, 2023 · 3 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Milestone
2024-04-30 - Apr ...

Comments

@geospatialem
Copy link
Member

geospatialem commented Sep 8, 2023 •
edited by ashetland
Loading

Description

Implement consistent expand/collapse states across components. Based on a design audit, the designs unify input behaviors, where:

  • No background color change on hover
  • Collapsed and expanded/open chevrons should use the ui-text-3
  • Hover and pressed chevrons should be ui-text-1

Existing behavior codepen

https://codepen.io/ashetland/pen/MWZpgRd

Relevant Info

Figma file includes fixes for all the components listed. The issue below all reference the same file and codepen.

Which Component

  • accordion-item
  • combobox
  • input-date-picker
  • input-time-picker
  • select

Esri team

Calcite (design)
@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. design Issues that need design consultation prior to development. 1 - assigned Issues that are assigned to a sprint and a team member. epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. p - medium Issue is non core or affecting less that 60% of people using the library Calcite (design) Issues logged by Calcite designers. estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. ready for dev Issues ready for development implementation. labels Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

It looks like this issue is missing some information:

  • A codepen, codesandbox, or jsbin that reproduces the issue. Alternatively, a documentation sample can be used if the issue is reproducible. If you are experiencing build or Node related errors, please provide a GitHub repo for the sample.

Issues without reproduction samples may not be prioritized. If you were unable to create a sample, please try to answer any questions that arise once development begins. Thanks for your understanding.

@github-actions github-actions bot added incomplete issue report New issues missing important information, and unless provided, they will be closed after 5 days. 0 - new New issues that need assignment. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Sep 8, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Sep 8, 2023
@Esri Esri deleted a comment from github-actions bot Sep 8, 2023
@geospatialem
Copy link
Member Author

Came up while conducting work for the #7181 epic.

@github-actions github-actions bot removed the incomplete issue report New issues missing important information, and unless provided, they will be closed after 5 days. label Sep 8, 2023
@ashetland ashetland changed the title Epic: Consistent states for Inputs Epic: Consistent expand/collapse states Sep 8, 2023
@ashetland ashetland assigned geospatialem and unassigned ashetland Sep 8, 2023
@ashetland ashetland mentioned this issue Sep 11, 2023
Open
@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@geospatialem geospatialem added this to the 2024 March Priorities milestone Nov 22, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Nov 22, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 12, 2023
@geospatialem geospatialem removed this from the 2024-03-26 - Mar Release milestone Mar 25, 2024
@geospatialem geospatialem added this to the 2024-04-30 - Apr Release milestone Mar 25, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels May 3, 2024
@geospatialem
Copy link
Member Author

Verified in 2.8.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2024-04-30 - Apr Release
Development

No branches or pull requests
3 participants
@geospatialem @ashetland @brittneytewks