Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip calcite-action-menu › Keyboard navigation tests #9000

Closed
jcfranco opened this issue Mar 26, 2024 · 3 comments
Closed

Unskip calcite-action-menu › Keyboard navigation tests #9000

jcfranco opened this issue Mar 26, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 5 A few days of work, definitely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality testing Issues related to automated or manual testing.
Milestone
2024-12-17 - Dec ...

Comments

@jcfranco
Copy link
Member

jcfranco commented Mar 26, 2024 •
edited
Loading

Test type

Unstable test

Which Component(s)

calcite-action-menu

Unstable Tests

  • should click the active action when clicked and close the menu
  • should click the active action on Enter key and close the menu
  • should handle TAB navigation

Test error, if applicable

@esri/calcite-components:test: FAIL src/components/action-menu/action-menu.e2e.ts (19.748 s)
@esri/calcite-components:test:   ● calcite-action-menu › Keyboard navigation › should click the active action when clicked and close the menu
@esri/calcite-components:test: 
@esri/calcite-components:test:     expect(received).toBe(expected) // Object.is equality
@esri/calcite-components:test: 
@esri/calcite-components:test:     Expected: false
@esri/calcite-components:test:     Received: true
@esri/calcite-components:test: 
@esri/calcite-components:test:       523 |       await page.$eval("calcite-action", (el: HTMLCalciteActionElement) => el.click());
@esri/calcite-components:test:       524 |
@esri/calcite-components:test:     > 525 |       expect(await actionMenu.getProperty("open")).toBe(false);
@esri/calcite-components:test:           |                                                    ^
@esri/calcite-components:test:       526 |       expect(clickSpy).toHaveReceivedEventTimes(1);
@esri/calcite-components:test:       527 |     });
@esri/calcite-components:test:       528 |   });
@esri/calcite-components:test: 
@esri/calcite-components:test:       at Object.<anonymous> (src/components/action-menu/action-menu.e2e.ts:525:52)

@esri/calcite-components:test: FAIL src/components/action-menu/action-menu.e2e.ts (18.704 s)
@esri/calcite-components:test:   ● calcite-action-menu › Keyboard navigation › should click the active action on Enter key and close the menu
@esri/calcite-components:test: 
@esri/calcite-components:test:     expect(received).toBe(expected) // Object.is equality
@esri/calcite-components:test: 
@esri/calcite-components:test:     Expected: false
@esri/calcite-components:test:     Received: true
@esri/calcite-components:test: 
@esri/calcite-components:test:       487 |       await page.waitForChanges();
@esri/calcite-components:test:       488 |
@esri/calcite-components:test:     > 489 |       expect(await actionMenu.getProperty("open")).toBe(false);
@esri/calcite-components:test:           |                                                    ^
@esri/calcite-components:test:       490 |       expect(clickSpy).toHaveReceivedEventTimes(1);
@esri/calcite-components:test:       491 |     });
@esri/calcite-components:test:       492 |
@esri/calcite-components:test: 
@esri/calcite-components:test:       at Object.<anonymous> (src/components/action-menu/action-menu.e2e.ts:489:52)

PR skipped, if applicable

#8999

Additional Info

No response
@jcfranco jcfranco added testing Issues related to automated or manual testing. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Mar 26, 2024
@jcfranco jcfranco mentioned this issue Mar 26, 2024
Merged
@jcfranco jcfranco changed the title Unskip calcite-action-menu › Keyboard navigation › should click the active action when clicked and close the menu test Unskip calcite-action-menu › Keyboard navigation tests Mar 26, 2024
jcfranco added a commit that referenced this issue Mar 26, 2024
@jcfranco
test(action-menu): skip unstable tests (#8999)
ee72777 
**Related Issue:** #9000

## Summary

```
 Summary of all failing tests
@esri/calcite-components:test: FAIL src/components/action-menu/action-menu.e2e.ts (19.748 s)
@esri/calcite-components:test:   ● calcite-action-menu › Keyboard navigation › should click the active action when clicked and close the menu
@esri/calcite-components:test: 
@esri/calcite-components:test:     expect(received).toBe(expected) // Object.is equality
@esri/calcite-components:test: 
@esri/calcite-components:test:     Expected: false
@esri/calcite-components:test:     Received: true
@esri/calcite-components:test: 
@esri/calcite-components:test:       523 |       await page.$eval("calcite-action", (el: HTMLCalciteActionElement) => el.click());
@esri/calcite-components:test:       524 |
@esri/calcite-components:test:     > 525 |       expect(await actionMenu.getProperty("open")).toBe(false);
@esri/calcite-components:test:           |                                                    ^
@esri/calcite-components:test:       526 |       expect(clickSpy).toHaveReceivedEventTimes(1);
@esri/calcite-components:test:       527 |     });
@esri/calcite-components:test:       528 |   });
@esri/calcite-components:test: 
@esri/calcite-components:test:       at Object.<anonymous> (src/components/action-menu/action-menu.e2e.ts:525:52)
```

```
@esri/calcite-components:test: FAIL src/components/action-menu/action-menu.e2e.ts (18.704 s)
@esri/calcite-components:test:   ● calcite-action-menu › Keyboard navigation › should click the active action on Enter key and close the menu
@esri/calcite-components:test: 
@esri/calcite-components:test:     expect(received).toBe(expected) // Object.is equality
@esri/calcite-components:test: 
@esri/calcite-components:test:     Expected: false
@esri/calcite-components:test:     Received: true
@esri/calcite-components:test: 
@esri/calcite-components:test:       487 |       await page.waitForChanges();
@esri/calcite-components:test:       488 |
@esri/calcite-components:test:     > 489 |       expect(await actionMenu.getProperty("open")).toBe(false);
@esri/calcite-components:test:           |                                                    ^
@esri/calcite-components:test:       490 |       expect(clickSpy).toHaveReceivedEventTimes(1);
@esri/calcite-components:test:       491 |     });
@esri/calcite-components:test:       492 |
@esri/calcite-components:test: 
@esri/calcite-components:test:       at Object.<anonymous> (src/components/action-menu/action-menu.e2e.ts:489:52)
```
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 3, 2024
@geospatialem geospatialem added the estimate - 5 A few days of work, definitely requires updates to tests. label Aug 12, 2024
@jcfranco jcfranco mentioned this issue Dec 2, 2024
Merged
@jcfranco
Copy link
Member Author

jcfranco commented Dec 2, 2024

Related to #8586.

@jcfranco jcfranco self-assigned this Dec 2, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Dec 2, 2024
jcfranco added a commit that referenced this issue Dec 3, 2024
@jcfranco
test(action-menu): restore tests (#10921)
f571c99 
**Related Issue:** #8586, #9000

## Summary

✨🧪🔨✨
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 3, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 3, 2024
@geospatialem
Copy link
Member

Verified the tests on the dev branch 🧪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 5 A few days of work, definitely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality testing Issues related to automated or manual testing.
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @DitwanP