Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dropdown-item): update selection state according to spec #10950

Closed
wants to merge 1 commit into from
Closed

feat(dropdown-item): update selection state according to spec #10950

wants to merge 1 commit into from

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Dec 3, 2024 •
edited
Loading

Related Issue: #7688 #10775

Summary

This updates dropdown-item to:

  • use bullet-point-large when single selection + large scale
  • always show icon when multiple selection
    • square when unselected
    • check-square when hovered
    • check-square-f when selected

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Dec 3, 2024
@jcfranco jcfranco force-pushed the jcfranco/7688-update-dropdown-item-selection-icons branch from 34fc36e to c009da7 Compare December 3, 2024 02:40
@jcfranco jcfranco changed the title feat(combobox): update selection state according to spec feat(dropdown-item): update selection state according to spec Dec 3, 2024
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 3, 2024
aPreciado88
aPreciado88 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@aPreciado88 aPreciado88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ashetland
Copy link

Closed issue #7688 in favor of #10775

@jcfranco
Copy link
Member Author

jcfranco commented Dec 3, 2024

Closed issue #7688 in favor of #10775

This PR is no longer valid as dropdown updates will be handled in 10775. Closing!

@jcfranco jcfranco closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aPreciado88 aPreciado88 aPreciado88 approved these changes

@ashetland ashetland Awaiting requested review from ashetland

@anveshmekala anveshmekala Awaiting requested review from anveshmekala

Assignees

@jcfranco jcfranco

Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcfranco @ashetland @aPreciado88