-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(actions): add action to omit PR from changelog #10984
Merged
DitwanP
merged 9 commits into
dev
from
dit13711/10936-add-action-to-omit-pr-from-changelog
Dec 10, 2024
Merged
ci(actions): add action to omit PR from changelog #10984
DitwanP
merged 9 commits into
dev
from
dit13711/10936-add-action-to-omit-pr-from-changelog
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DitwanP
requested review from
benelan,
jcfranco and
geospatialem
as code owners
December 4, 2024 22:30
github-actions
bot
added
the
chore
Issues with changes that don't modify src or test files.
label
Dec 4, 2024
DitwanP
added
the
skip visual snapshots
Pull requests that do not need visual regression testing.
label
Dec 4, 2024
benelan
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! If someone were to toggle the no changelog entry
label it would add additional commit override blocks. I'm not sure how release-please would handle that, but it should be fine. Just something to keep an eye on.
…nto dit13711/10936-add-action-to-omit-pr-from-changelog
DitwanP
deleted the
dit13711/10936-add-action-to-omit-pr-from-changelog
branch
December 10, 2024 18:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Issues with changes that don't modify src or test files.
skip visual snapshots
Pull requests that do not need visual regression testing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10936
Summary
Adds an action that will edit the PR body to include the necessary comments to omit a PR from the changelog (when the
no changelog entry
label is added to PR).Tested on personal repo: