Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(actions): add action to omit PR from changelog #10984

Merged
merged 9 commits into from
Dec 10, 2024

Conversation

DitwanP
Copy link
Contributor

@DitwanP DitwanP commented Dec 4, 2024

Related Issue: #10936

Summary

Adds an action that will edit the PR body to include the necessary comments to omit a PR from the changelog (when the no changelog entry label is added to PR).

Tested on personal repo:
image

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Dec 4, 2024
@DitwanP DitwanP added the skip visual snapshots Pull requests that do not need visual regression testing. label Dec 4, 2024
@DitwanP DitwanP removed the request for review from geospatialem December 4, 2024 22:33
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If someone were to toggle the no changelog entry label it would add additional commit override blocks. I'm not sure how release-please would handle that, but it should be fine. Just something to keep an eye on.

.github/scripts/omitPrFromChangelog.js Outdated Show resolved Hide resolved
.github/scripts/omitPrFromChangelog.js Outdated Show resolved Hide resolved
@DitwanP DitwanP merged commit 56281b6 into dev Dec 10, 2024
10 checks passed
@DitwanP DitwanP deleted the dit13711/10936-add-action-to-omit-pr-from-changelog branch December 10, 2024 18:19
@github-actions github-actions bot added this to the 2024-12-17 - Dec Milestone milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants