feat(tree,tree-item): update indentation #10990
Open
+143
−417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anveshmekala
commented
Dec 5, 2024
| {checkbox ? ( | ||
| <label class={CSS.checkboxLabel}>{defaultSlotNode}</label> | ||
| ) : ( | ||
| defaultSlotNode |
There was a problem hiding this comment.
No impact for AT users with VoiceOver. Adding @geospatialem for review.
anveshmekala
added
the
pr ready for visual snapshots
anveshmekala
added
pr ready for visual snapshots
anveshmekala
added
pr ready for visual snapshots
anveshmekala
added
pr ready for visual snapshots
anveshmekala
added
pr ready for visual snapshots
|
This PR made changes to stories to include all |
driskull
approved these changes
Dec 9, 2024
| @@ -1,80 +1,53 @@ | |||
| :host([scale="s"]) { | |||
| --calcite-internal-tree-item-spacing-unit: 0.25rem; | |||
There was a problem hiding this comment.
Shouldn't these values use calcite tokens?
There was a problem hiding this comment.
IIRC, it is recommended to leave them as rem or px for now and update them to tokens in a separate effort once tokenization is complete. Please correct me if wrong @alisonailea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7096
Summary
Updates padding indentation for
tree-item's intree