Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(text-area): add new string for when character length is tooShort #11006

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

chore(text-area): add new string for when character length is tooShort #11006

wants to merge 2 commits into from
+4 −2

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Dec 7, 2024

Related Issue: #10970

Summary

Check in new string.

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Dec 7, 2024
@Elijbet Elijbet added the skip visual snapshots Pull requests that do not need visual regression testing. label Dec 7, 2024
@Elijbet Elijbet marked this pull request as ready for review December 7, 2024 01:23
benelan
benelan approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco
Copy link
Member

@Elijbet Why is this separate from #10970?

@Elijbet
Copy link
Contributor Author

Elijbet commented Dec 11, 2024

@Elijbet Why is this separate from #10970?

From what I understood I could check in new strings and request translations while that PR is being reviewed.

@jcfranco
Copy link
Member

Gotcha. We might not need to submit this separately since #10970 looks close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan approved these changes

@jcfranco jcfranco Awaiting requested review from jcfranco jcfranco is a code owner

Assignees

@Elijbet Elijbet

Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Elijbet @jcfranco @benelan