poc: add associations logic #1314
Conversation
| listAssociations(type: AssociationType): IAssociationInfo[] { | ||
| return listAssociations(this.entity, type); | ||
| } | ||
| // async requestAssociation(type: HubEntityType, id: string): Promise<void> { |
There was a problem hiding this comment.
these association methods are commented out for now because I'm seeing a weird console error that I'm trying to resolve
| * @param info | ||
| * @param entity | ||
| */ | ||
| export function addAssociation( |
There was a problem hiding this comment.
I can deprecate this rather than removing it and have it call requestAssociation. addAssociation just didn't feel like the correct naming since it's only establishing half of the connection.
| * @param entity | ||
| * @returns | ||
| */ | ||
| export function removeAssociation( |
There was a problem hiding this comment.
Similarly, I can deprecate this rather than removing it and have it call breakAssociation.
juliannemarik
force-pushed
the
poc/associations
branch
from
af541f7 to
8307849
Compare
|
There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label. |
github-actions
bot
added
Stale
juliannemarik
force-pushed
the
poc/associations
branch
from
e0b97ce to
12d3554
Compare
|
There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label. |
juliannemarik
added
Draft
|
closing this out - this logic was implemented in a separate PR |
Description:
Instructions for testing:
Closes Issues: # (if appropriate)
Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide
used semantic commit messages
PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)
updated
peerDependenciesas needed. CRITICAL our automated release system can not be counted on to updatepeerDependenciesso we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.