From 6119b3ae43802ed05a7c91e4b16c1447c704eb86 Mon Sep 17 00:00:00 2001 From: Julianna Apicella <42875581+juliannaeapicella@users.noreply.github.com> Date: Fri, 24 May 2024 11:03:45 -0400 Subject: [PATCH 01/10] feat(hub-common): add register button --- packages/common/src/core/types/ActionLinks.ts | 2 ++ packages/common/src/events/HubEvent.ts | 13 +++++++++++++ packages/common/src/events/defaults.ts | 3 +++ 3 files changed, 18 insertions(+) diff --git a/packages/common/src/core/types/ActionLinks.ts b/packages/common/src/core/types/ActionLinks.ts index fde5b8edd80..404a3fe5dcf 100644 --- a/packages/common/src/core/types/ActionLinks.ts +++ b/packages/common/src/core/types/ActionLinks.ts @@ -29,6 +29,8 @@ interface IHubBaseActionLink { description?: string; /** action icon */ icon?: string; + /** whether or not to disable the button */ + disabled?: string; } /** diff --git a/packages/common/src/events/HubEvent.ts b/packages/common/src/events/HubEvent.ts index 88ac817fe9c..2a4be4385b3 100644 --- a/packages/common/src/events/HubEvent.ts +++ b/packages/common/src/events/HubEvent.ts @@ -236,6 +236,19 @@ export class HubEvent */ async fromEditor(editor: IHubEventEditor): Promise { const entity = cloneObject(editor) as IHubEvent; + // map allowRegistration to heroActions + if (entity.allowRegistration) { + entity.view.heroActions = [ + { + kind: "external", + label: "Register", + href: "", + disabled: "true", + }, + ]; + } else { + entity.view.heroActions = []; + } this.entity = entity; await this.save(); return this.entity; diff --git a/packages/common/src/events/defaults.ts b/packages/common/src/events/defaults.ts index 7db8e697394..4b6a893950b 100644 --- a/packages/common/src/events/defaults.ts +++ b/packages/common/src/events/defaults.ts @@ -35,6 +35,9 @@ export function buildDefaultEventEntity(): Partial { readGroupIds: [], editGroupIds: [], ...dates, + view: { + heroActions: [], + }, }; } From 6e0fa9f1262cd89ab545ebd6756772b0a281ff25 Mon Sep 17 00:00:00 2001 From: Julianna Apicella <42875581+juliannaeapicella@users.noreply.github.com> Date: Fri, 24 May 2024 12:55:50 -0400 Subject: [PATCH 02/10] feat(hub-common): disable button if cancelled --- packages/common/src/events/HubEvent.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/common/src/events/HubEvent.ts b/packages/common/src/events/HubEvent.ts index 2a4be4385b3..5d4ba478aad 100644 --- a/packages/common/src/events/HubEvent.ts +++ b/packages/common/src/events/HubEvent.ts @@ -243,7 +243,7 @@ export class HubEvent kind: "external", label: "Register", href: "", - disabled: "true", + disabled: entity.isCanceled ? null : "true", }, ]; } else { From 479345f003b4a51c3c4cf5ac6bc880e0f6fd6a1f Mon Sep 17 00:00:00 2001 From: Julianna Apicella <42875581+juliannaeapicella@users.noreply.github.com> Date: Tue, 28 May 2024 11:08:09 -0400 Subject: [PATCH 03/10] fix(hub-common): set view in property mapper --- packages/common/src/events/HubEvent.ts | 13 ------------- .../src/events/_internal/PropertyMapper.ts | 16 ++++++++++++++++ 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/packages/common/src/events/HubEvent.ts b/packages/common/src/events/HubEvent.ts index 5d4ba478aad..88ac817fe9c 100644 --- a/packages/common/src/events/HubEvent.ts +++ b/packages/common/src/events/HubEvent.ts @@ -236,19 +236,6 @@ export class HubEvent */ async fromEditor(editor: IHubEventEditor): Promise { const entity = cloneObject(editor) as IHubEvent; - // map allowRegistration to heroActions - if (entity.allowRegistration) { - entity.view.heroActions = [ - { - kind: "external", - label: "Register", - href: "", - disabled: entity.isCanceled ? null : "true", - }, - ]; - } else { - entity.view.heroActions = []; - } this.entity = entity; await this.save(); return this.entity; diff --git a/packages/common/src/events/_internal/PropertyMapper.ts b/packages/common/src/events/_internal/PropertyMapper.ts index 610beb601ed..20ab57ecaae 100644 --- a/packages/common/src/events/_internal/PropertyMapper.ts +++ b/packages/common/src/events/_internal/PropertyMapper.ts @@ -5,6 +5,7 @@ import { } from "../../core/_internal/PropertyMapper"; import { IHubEvent } from "../../core/types/IHubEvent"; import { SettableAccessLevel } from "../../core/types/types"; +import { setProp } from "../../objects/set-prop"; import { cloneObject } from "../../util"; import { EventAccess, @@ -90,6 +91,21 @@ export class EventPropertyMapper extends PropertyMapper< obj.links = computeLinks(store as IEvent); obj.slug = getEventSlug(store as IEvent); + store.allowRegistration + ? setProp( + "view.heroActions", + [ + { + kind: "external", + label: "{{arcgis-hub-entity-hero.actions.register}}", + href: "", + disabled: entity.isCanceled ? null : "true", + }, + ], + obj + ) + : setProp("view.heroActions", [], obj); + return obj; } From 476607711f90c04a7cd4f2daec0c6dee50e0b3b3 Mon Sep 17 00:00:00 2001 From: Julianna Apicella <42875581+juliannaeapicella@users.noreply.github.com> Date: Tue, 28 May 2024 12:11:50 -0400 Subject: [PATCH 04/10] fix(hub-common): format string --- packages/common/src/events/_internal/PropertyMapper.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/common/src/events/_internal/PropertyMapper.ts b/packages/common/src/events/_internal/PropertyMapper.ts index 20ab57ecaae..ed850c4c3dc 100644 --- a/packages/common/src/events/_internal/PropertyMapper.ts +++ b/packages/common/src/events/_internal/PropertyMapper.ts @@ -97,7 +97,7 @@ export class EventPropertyMapper extends PropertyMapper< [ { kind: "external", - label: "{{arcgis-hub-entity-hero.actions.register}}", + label: "{{arcgis-hub-entity-hero.actions.register:translate}}", href: "", disabled: entity.isCanceled ? null : "true", }, From 4e8c1fc7084f8cab3b206ffee0b8fe7ab3c173d6 Mon Sep 17 00:00:00 2001 From: Julianna Apicella <42875581+juliannaeapicella@users.noreply.github.com> Date: Tue, 28 May 2024 12:21:06 -0400 Subject: [PATCH 05/10] fix(hub-common): adjust string --- packages/common/src/events/_internal/PropertyMapper.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/common/src/events/_internal/PropertyMapper.ts b/packages/common/src/events/_internal/PropertyMapper.ts index ed850c4c3dc..21046297900 100644 --- a/packages/common/src/events/_internal/PropertyMapper.ts +++ b/packages/common/src/events/_internal/PropertyMapper.ts @@ -97,7 +97,7 @@ export class EventPropertyMapper extends PropertyMapper< [ { kind: "external", - label: "{{arcgis-hub-entity-hero.actions.register:translate}}", + label: "{{actions.register:translate}}", href: "", disabled: entity.isCanceled ? null : "true", }, From 2eacdd801aa9ce7996b9f2fdc85563640d655580 Mon Sep 17 00:00:00 2001 From: Julianna Apicella <42875581+juliannaeapicella@users.noreply.github.com> Date: Tue, 28 May 2024 15:15:15 -0400 Subject: [PATCH 06/10] feat(hub-common): add thumbnail --- packages/common/src/events/_internal/PropertyMapper.ts | 3 ++- packages/common/src/events/_internal/computeLinks.ts | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/common/src/events/_internal/PropertyMapper.ts b/packages/common/src/events/_internal/PropertyMapper.ts index 21046297900..440b0863bb4 100644 --- a/packages/common/src/events/_internal/PropertyMapper.ts +++ b/packages/common/src/events/_internal/PropertyMapper.ts @@ -90,7 +90,8 @@ export class EventPropertyMapper extends PropertyMapper< obj.updatedDateSource = "updatedAt"; obj.links = computeLinks(store as IEvent); obj.slug = getEventSlug(store as IEvent); - + obj.thumbnailUrl = + "https://hubqacdn.arcgis.com/opendata-ui/assets/ember-arcgis-opendata-components/assets/images/placeholders/event.png"; store.allowRegistration ? setProp( "view.heroActions", diff --git a/packages/common/src/events/_internal/computeLinks.ts b/packages/common/src/events/_internal/computeLinks.ts index a84ac9c599f..20ce14b40b6 100644 --- a/packages/common/src/events/_internal/computeLinks.ts +++ b/packages/common/src/events/_internal/computeLinks.ts @@ -18,7 +18,7 @@ export function computeLinks(event: IEvent): IHubEntityLinks { siteRelative, siteRelativeEntityType: getHubRelativeUrl("event"), workspaceRelative: getRelativeWorkspaceUrl("Event", event.id), - // TODO - // thumbnail: "", + thumbnail: + "https://hubqacdn.arcgis.com/opendata-ui/assets/ember-arcgis-opendata-components/assets/images/placeholders/event.png", }; } From 20fc81a60055fde6d0899e60c584649e7ed3b072 Mon Sep 17 00:00:00 2001 From: Julianna Apicella <42875581+juliannaeapicella@users.noreply.github.com> Date: Tue, 28 May 2024 16:15:12 -0400 Subject: [PATCH 07/10] fix(hub-common): update tests --- .../src/events/_internal/PropertyMapper.ts | 2 +- .../events/_internal/PropertyMapper.test.ts | 23 +++++++++++++++++++ .../events/_internal/computeLinks.test.ts | 2 ++ packages/common/test/events/defaults.test.ts | 3 +++ .../eventToSearchResult.test.ts | 4 ++++ 5 files changed, 33 insertions(+), 1 deletion(-) diff --git a/packages/common/src/events/_internal/PropertyMapper.ts b/packages/common/src/events/_internal/PropertyMapper.ts index 440b0863bb4..0f1cecada40 100644 --- a/packages/common/src/events/_internal/PropertyMapper.ts +++ b/packages/common/src/events/_internal/PropertyMapper.ts @@ -100,7 +100,7 @@ export class EventPropertyMapper extends PropertyMapper< kind: "external", label: "{{actions.register:translate}}", href: "", - disabled: entity.isCanceled ? null : "true", + disabled: obj.isCanceled ? "true" : null, }, ], obj diff --git a/packages/common/test/events/_internal/PropertyMapper.test.ts b/packages/common/test/events/_internal/PropertyMapper.test.ts index 23323d2a57f..b64a3646ac8 100644 --- a/packages/common/test/events/_internal/PropertyMapper.test.ts +++ b/packages/common/test/events/_internal/PropertyMapper.test.ts @@ -152,8 +152,15 @@ describe("PropertyMapper", () => { siteRelative: "/events/event-title-31c", siteRelativeEntityType: "", workspaceRelative: "/workspace/events/31c", + thumbnail: + "https://hubqacdn.arcgis.com/opendata-ui/assets/ember-arcgis-opendata-components/assets/images/placeholders/event.png", }, slug: "event-title-31c", + thumbnailUrl: + "https://hubqacdn.arcgis.com/opendata-ui/assets/ember-arcgis-opendata-components/assets/images/placeholders/event.png", + view: { + heroActions: [], + }, }); }); @@ -195,6 +202,22 @@ describe("PropertyMapper", () => { const res = propertyMapper.storeToEntity(eventRecord, {}); expect(res.attendanceType).toEqual(HubEventAttendanceType.Both); }); + + it("disables registration if canceled", () => { + eventRecord.allowRegistration = true; + eventRecord.status = EventStatus.CANCELED; + const res = propertyMapper.storeToEntity(eventRecord, {}); + expect(res.view).toEqual({ + heroActions: [ + { + kind: "external", + label: "{{actions.register:translate}}", + href: "", + disabled: "true", + }, + ], + }); + }); }); describe("entityToStore", () => { diff --git a/packages/common/test/events/_internal/computeLinks.test.ts b/packages/common/test/events/_internal/computeLinks.test.ts index 2e2ae2ceed1..70a58aae83f 100644 --- a/packages/common/test/events/_internal/computeLinks.test.ts +++ b/packages/common/test/events/_internal/computeLinks.test.ts @@ -13,6 +13,8 @@ describe("computeLinks", () => { siteRelative: "/events/my-events-are-awesome-123-31c", siteRelativeEntityType: "", workspaceRelative: "/workspace/events/31c", + thumbnail: + "https://hubqacdn.arcgis.com/opendata-ui/assets/ember-arcgis-opendata-components/assets/images/placeholders/event.png", }); }); }); diff --git a/packages/common/test/events/defaults.test.ts b/packages/common/test/events/defaults.test.ts index 6c61ec9032d..650c1e8dccb 100644 --- a/packages/common/test/events/defaults.test.ts +++ b/packages/common/test/events/defaults.test.ts @@ -47,6 +47,9 @@ describe("HubEvent defaults:", () => { tags: [], readGroupIds: [], editGroupIds: [], + view: { + heroActions: [], + }, ...datesAndTimes, }); expect(getDefaultEventDatesAndTimesSpy).toHaveBeenCalledTimes(1); diff --git a/packages/common/test/search/_internal/hubEventsHelpers/eventToSearchResult.test.ts b/packages/common/test/search/_internal/hubEventsHelpers/eventToSearchResult.test.ts index 6a035cc3746..cabc8991b69 100644 --- a/packages/common/test/search/_internal/hubEventsHelpers/eventToSearchResult.test.ts +++ b/packages/common/test/search/_internal/hubEventsHelpers/eventToSearchResult.test.ts @@ -61,6 +61,8 @@ describe("eventToSearchResult", () => { siteRelative: `/events/my-event-title-${event.id}`, siteRelativeEntityType: "", workspaceRelative: `/workspace/events/${event.id}`, + thumbnail: + "https://hubqacdn.arcgis.com/opendata-ui/assets/ember-arcgis-opendata-components/assets/images/placeholders/event.png", }, tags: event.tags, categories: event.categories, @@ -96,6 +98,8 @@ describe("eventToSearchResult", () => { siteRelative: `/events/my-event-title-${event.id}`, siteRelativeEntityType: "", workspaceRelative: `/workspace/events/${event.id}`, + thumbnail: + "https://hubqacdn.arcgis.com/opendata-ui/assets/ember-arcgis-opendata-components/assets/images/placeholders/event.png", }, tags: event.tags, categories: event.categories, From 3e871c1ffb43201ca1cabfeb1993d2882cd42b10 Mon Sep 17 00:00:00 2001 From: Julianna Apicella <42875581+juliannaeapicella@users.noreply.github.com> Date: Tue, 28 May 2024 16:33:17 -0400 Subject: [PATCH 08/10] feat(hub-common): pr feedback --- packages/common/src/core/types/ActionLinks.ts | 2 +- .../src/events/_internal/PropertyMapper.ts | 30 +++++++++---------- .../src/events/_internal/computeLinks.ts | 4 +-- .../src/events/_internal/getEventThumbnail.ts | 3 ++ .../events/_internal/PropertyMapper.test.ts | 13 ++++---- .../events/_internal/computeLinks.test.ts | 4 +-- .../eventToSearchResult.test.ts | 7 ++--- 7 files changed, 31 insertions(+), 32 deletions(-) create mode 100644 packages/common/src/events/_internal/getEventThumbnail.ts diff --git a/packages/common/src/core/types/ActionLinks.ts b/packages/common/src/core/types/ActionLinks.ts index 404a3fe5dcf..3a0d56fa1dd 100644 --- a/packages/common/src/core/types/ActionLinks.ts +++ b/packages/common/src/core/types/ActionLinks.ts @@ -30,7 +30,7 @@ interface IHubBaseActionLink { /** action icon */ icon?: string; /** whether or not to disable the button */ - disabled?: string; + disabled?: boolean; } /** diff --git a/packages/common/src/events/_internal/PropertyMapper.ts b/packages/common/src/events/_internal/PropertyMapper.ts index 0f1cecada40..36bc52df4e5 100644 --- a/packages/common/src/events/_internal/PropertyMapper.ts +++ b/packages/common/src/events/_internal/PropertyMapper.ts @@ -3,6 +3,7 @@ import { mapEntityToStore, mapStoreToEntity, } from "../../core/_internal/PropertyMapper"; +import { HubActionLink } from "../../core/types/ActionLinks"; import { IHubEvent } from "../../core/types/IHubEvent"; import { SettableAccessLevel } from "../../core/types/types"; import { setProp } from "../../objects/set-prop"; @@ -17,6 +18,7 @@ import { import { HubEventAttendanceType, HubEventOnlineCapacityType } from "../types"; import { computeLinks } from "./computeLinks"; import { getEventSlug } from "./getEventSlug"; +import { getEventThumbnail } from "./getEventThumbnail"; /** * @private @@ -90,22 +92,18 @@ export class EventPropertyMapper extends PropertyMapper< obj.updatedDateSource = "updatedAt"; obj.links = computeLinks(store as IEvent); obj.slug = getEventSlug(store as IEvent); - obj.thumbnailUrl = - "https://hubqacdn.arcgis.com/opendata-ui/assets/ember-arcgis-opendata-components/assets/images/placeholders/event.png"; - store.allowRegistration - ? setProp( - "view.heroActions", - [ - { - kind: "external", - label: "{{actions.register:translate}}", - href: "", - disabled: obj.isCanceled ? "true" : null, - }, - ], - obj - ) - : setProp("view.heroActions", [], obj); + obj.thumbnailUrl = getEventThumbnail(); + + const heroActions: HubActionLink[] = []; + if (store.allowRegistration) { + heroActions.push({ + kind: "well-known", + action: "register", + label: "{{actions.register:translate}}", + disabled: obj.isCanceled, + }); + } + obj.view = { heroActions }; return obj; } diff --git a/packages/common/src/events/_internal/computeLinks.ts b/packages/common/src/events/_internal/computeLinks.ts index 20ce14b40b6..7993f4e246b 100644 --- a/packages/common/src/events/_internal/computeLinks.ts +++ b/packages/common/src/events/_internal/computeLinks.ts @@ -3,6 +3,7 @@ import { getRelativeWorkspaceUrl } from "../../core/getRelativeWorkspaceUrl"; import { getHubRelativeUrl } from "../../content/_internal/internalContentUtils"; import { IEvent } from "../api/orval/api/orval-events"; import { getEventSlug } from "./getEventSlug"; +import { getEventThumbnail } from "./getEventThumbnail"; /** * Compute the links that get appended to a Hub Event @@ -18,7 +19,6 @@ export function computeLinks(event: IEvent): IHubEntityLinks { siteRelative, siteRelativeEntityType: getHubRelativeUrl("event"), workspaceRelative: getRelativeWorkspaceUrl("Event", event.id), - thumbnail: - "https://hubqacdn.arcgis.com/opendata-ui/assets/ember-arcgis-opendata-components/assets/images/placeholders/event.png", + thumbnail: getEventThumbnail(), }; } diff --git a/packages/common/src/events/_internal/getEventThumbnail.ts b/packages/common/src/events/_internal/getEventThumbnail.ts new file mode 100644 index 00000000000..cef908d7b9d --- /dev/null +++ b/packages/common/src/events/_internal/getEventThumbnail.ts @@ -0,0 +1,3 @@ +export function getEventThumbnail(): string { + return "https://hubqacdn.arcgis.com/opendata-ui/assets/ember-arcgis-opendata-components/assets/images/placeholders/event.png"; +} diff --git a/packages/common/test/events/_internal/PropertyMapper.test.ts b/packages/common/test/events/_internal/PropertyMapper.test.ts index b64a3646ac8..d965e645131 100644 --- a/packages/common/test/events/_internal/PropertyMapper.test.ts +++ b/packages/common/test/events/_internal/PropertyMapper.test.ts @@ -1,5 +1,6 @@ import { IHubEvent } from "../../../src/core/types/IHubEvent"; import { EventPropertyMapper } from "../../../src/events/_internal/PropertyMapper"; +import { getEventThumbnail } from "../../../src/events/_internal/getEventThumbnail"; import { getPropertyMap } from "../../../src/events/_internal/getPropertyMap"; import { IOnlineMeeting } from "../../../src/events/api/orval/api/orval-events"; import { @@ -152,12 +153,10 @@ describe("PropertyMapper", () => { siteRelative: "/events/event-title-31c", siteRelativeEntityType: "", workspaceRelative: "/workspace/events/31c", - thumbnail: - "https://hubqacdn.arcgis.com/opendata-ui/assets/ember-arcgis-opendata-components/assets/images/placeholders/event.png", + thumbnail: getEventThumbnail(), }, slug: "event-title-31c", - thumbnailUrl: - "https://hubqacdn.arcgis.com/opendata-ui/assets/ember-arcgis-opendata-components/assets/images/placeholders/event.png", + thumbnailUrl: getEventThumbnail(), view: { heroActions: [], }, @@ -210,10 +209,10 @@ describe("PropertyMapper", () => { expect(res.view).toEqual({ heroActions: [ { - kind: "external", + kind: "well-known", + action: "register", label: "{{actions.register:translate}}", - href: "", - disabled: "true", + disabled: true, }, ], }); diff --git a/packages/common/test/events/_internal/computeLinks.test.ts b/packages/common/test/events/_internal/computeLinks.test.ts index 70a58aae83f..e88e1805882 100644 --- a/packages/common/test/events/_internal/computeLinks.test.ts +++ b/packages/common/test/events/_internal/computeLinks.test.ts @@ -1,5 +1,6 @@ import { IEvent } from "../../../src/events/api/orval/api/orval-events"; import { computeLinks } from "../../../src/events/_internal/computeLinks"; +import { getEventThumbnail } from "../../../src/events/_internal/getEventThumbnail"; describe("computeLinks", () => { it("should compute links for an event", () => { @@ -13,8 +14,7 @@ describe("computeLinks", () => { siteRelative: "/events/my-events-are-awesome-123-31c", siteRelativeEntityType: "", workspaceRelative: "/workspace/events/31c", - thumbnail: - "https://hubqacdn.arcgis.com/opendata-ui/assets/ember-arcgis-opendata-components/assets/images/placeholders/event.png", + thumbnail: getEventThumbnail(), }); }); }); diff --git a/packages/common/test/search/_internal/hubEventsHelpers/eventToSearchResult.test.ts b/packages/common/test/search/_internal/hubEventsHelpers/eventToSearchResult.test.ts index cabc8991b69..e1585a8489b 100644 --- a/packages/common/test/search/_internal/hubEventsHelpers/eventToSearchResult.test.ts +++ b/packages/common/test/search/_internal/hubEventsHelpers/eventToSearchResult.test.ts @@ -3,6 +3,7 @@ import { AccessLevel } from "../../../../src/core/types/types"; import { EventAccess, IEvent } from "../../../../src/events/api/types"; import { eventToSearchResult } from "../../../../src/search/_internal/hubEventsHelpers/eventToSearchResult"; import { IHubSearchOptions } from "../../../../src/search/types/IHubSearchOptions"; +import { getEventThumbnail } from "../../../../src/events/_internal/getEventThumbnail"; describe("eventToSearchResult", () => { const options = { @@ -61,8 +62,7 @@ describe("eventToSearchResult", () => { siteRelative: `/events/my-event-title-${event.id}`, siteRelativeEntityType: "", workspaceRelative: `/workspace/events/${event.id}`, - thumbnail: - "https://hubqacdn.arcgis.com/opendata-ui/assets/ember-arcgis-opendata-components/assets/images/placeholders/event.png", + thumbnail: getEventThumbnail(), }, tags: event.tags, categories: event.categories, @@ -98,8 +98,7 @@ describe("eventToSearchResult", () => { siteRelative: `/events/my-event-title-${event.id}`, siteRelativeEntityType: "", workspaceRelative: `/workspace/events/${event.id}`, - thumbnail: - "https://hubqacdn.arcgis.com/opendata-ui/assets/ember-arcgis-opendata-components/assets/images/placeholders/event.png", + thumbnail: getEventThumbnail(), }, tags: event.tags, categories: event.categories, From b521ff414a717e68f3ee02756dd3529e3f403d2b Mon Sep 17 00:00:00 2001 From: Julianna Apicella <42875581+juliannaeapicella@users.noreply.github.com> Date: Tue, 28 May 2024 16:34:12 -0400 Subject: [PATCH 09/10] refactor(hub-common): remove unused import --- packages/common/src/events/_internal/PropertyMapper.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/common/src/events/_internal/PropertyMapper.ts b/packages/common/src/events/_internal/PropertyMapper.ts index 36bc52df4e5..bc4a128e16e 100644 --- a/packages/common/src/events/_internal/PropertyMapper.ts +++ b/packages/common/src/events/_internal/PropertyMapper.ts @@ -6,7 +6,6 @@ import { import { HubActionLink } from "../../core/types/ActionLinks"; import { IHubEvent } from "../../core/types/IHubEvent"; import { SettableAccessLevel } from "../../core/types/types"; -import { setProp } from "../../objects/set-prop"; import { cloneObject } from "../../util"; import { EventAccess, From 67de11ba7fda01c1d8b5b17a2110cdb8bdbef521 Mon Sep 17 00:00:00 2001 From: Julianna Apicella <42875581+juliannaeapicella@users.noreply.github.com> Date: Wed, 29 May 2024 11:55:52 -0400 Subject: [PATCH 10/10] feat(hub-common): update url --- packages/common/src/events/_internal/getEventThumbnail.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/common/src/events/_internal/getEventThumbnail.ts b/packages/common/src/events/_internal/getEventThumbnail.ts index cef908d7b9d..b58c1c63325 100644 --- a/packages/common/src/events/_internal/getEventThumbnail.ts +++ b/packages/common/src/events/_internal/getEventThumbnail.ts @@ -1,3 +1,3 @@ export function getEventThumbnail(): string { - return "https://hubqacdn.arcgis.com/opendata-ui/assets/ember-arcgis-opendata-components/assets/images/placeholders/event.png"; + return "https://hubcdn.arcgis.com/opendata-ui/assets/ember-arcgis-opendata-components/assets/images/placeholders/event.png"; }