Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add private message toggle. #870

Closed
vLuckyyy opened this issue Oct 15, 2024 · 0 comments · Fixed by #896
Closed

Add private message toggle. #870

vLuckyyy opened this issue Oct 15, 2024 · 0 comments · Fixed by #896
Assignees
@CitralFlo

Comments

@vLuckyyy
Copy link
Member

/msgtoggle Toggles receiving private messages. This is not the same as /ignore.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in EternalCore Oct 15, 2024
@CitralFlo CitralFlo linked a pull request Jan 22, 2025 that will close this issue
GH-870 Add /msgtoggle command #896
Merged
CitralFlo added a commit that referenced this issue Feb 14, 2025
@CitralFlo @coderabbitai @Rollczi
GH-870 Add /msgtoggle command (#896)
67101c8 
* Innit commit

* In progress: add messages, setup methods and commands

* Add msgToggle repo, service, API and commands

* Fix logic

* Fix logic, rename messages

* Remove comments

* Delete duplicated message.

* Update eternalcore-api/src/main/java/com/eternalcode/core/feature/msgtoggle/MsgToggle.java

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Delete duplicated message.

* Fix coderabbit issue

* Fix naming and logic.

* Resolve @imDMK review

* Add comments to api

* Resolve Rollcz's review

* Resolve coderabbit review

* Update README.md

* Fix logic: enable -> enable priv messages.

* Resolve @coderabbitai nitpick comment, simplify command and api

* Refactor names of variables following vLuckyyy comment

* Change name from toggleState to State

* Simplify logic (i hope @Rollczi will like it) refactor to PrivateChatState instead of toggle

* Resolve master changes

* Resolve @coderabbitai 's review

* Cleanup method and parameters names. Remove unused classes.

* Simplify commands

* Fix command messages

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Rollczi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CitralFlo CitralFlo

Labels
None yet
Projects
EternalCore
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-870 Add /msgtoggle command EternalCodeTeam/EternalCore
2 participants
@vLuckyyy @CitralFlo