Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio file formats are using item_play_duration as pictures #2

Open
laice opened this issue Feb 19, 2019 · 8 comments
Open

Audio file formats are using item_play_duration as pictures #2

laice opened this issue Feb 19, 2019 · 8 comments

Comments

@laice
Copy link

laice commented Feb 19, 2019

I'm using this to queue .mp3 files, and I noticed instead of treating item_play_duration like a video when not set - playing until the end and changing - it's treating it like an image and repeating/restarting the .mp3 for 60 seconds if its shorter, or cutting it off early if its longer

@EugeneDae
Copy link
Owner

EugeneDae commented Feb 19, 2019

I was able to reproduce this, but not consistently. Thank you @laice

The program has to sleep for 0.25 seconds before it can retrieve the length of the media file from VLC (code, ). Maybe raising the sleep duration might help.

What OS are you on?

@laice
Copy link
Author

laice commented Feb 19, 2019 via email

@EugeneDae
Copy link
Owner

I've built a macOS version for you, please give it a shot.
https://github.com/EugeneDae/VLC-Scheduler/releases/tag/v0.3.3-alpha

@laice
Copy link
Author

laice commented Feb 20, 2019

E: After some testing I realized I had item_play_duration set wrong. It seems to be adding and playing fine now except for a couple things:

For some reason a 3+ min music mp3 gets shortened to the length of the previous 11 second clip. It was added to the folder during playback but for some reason still gets reduced to the previous mp3s length after restarting the program. Going to play around with this more with other mp3s and durations

When the watched directory is added to while the scheduler is running, the playlist resets back to the beginning of the first mp3

Let me know if there's any other way I can help! Thanks for your work

@laice
Copy link
Author

laice commented Feb 20, 2019

I'm also getting the new mp3 added to folder during playback resets the playlist issue in Windows

@EugeneDae
Copy link
Owner

Unfortunately, it is by design that the playback resets when something changes in the watched folders. I plan to change this when I have time (it might turn out harder than it seems).

Speaking of the lengths, I'm sure we can fix this. Would you mind emailing those mp3 to me? ([email protected]) If you'd rather not share, I'll find a way, no probs. Thanks!

@laice
Copy link
Author

laice commented Feb 21, 2019

Oh I see, I didn't realize that's intended functionality. Having that at least be optional so the list can be updated live without interference would be really helpful in my use case. I sent you an email with some example mp3s

@laice
Copy link
Author

laice commented Feb 25, 2019

After further testing, it seems that setting the source_media_function to "chain" stops the initial repeating issue, however it seems periodically the playlist is "locking in" a duration and it forces several subsequent mp3s to adhere to this duration - either repeating if shorter, or cutting it off if longer.

EugeneDae pushed a commit that referenced this issue Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants