#1893 [Control] add: progress bar of different colors #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-eoxia
requested changes
Oct 30, 2024
| @@ -896,7 +896,18 @@ | |||
| <div class="progress-info"> | |||
| <span class="badge badge-info" style="margin-right: 10px;"><?php print $answerCounter . '/' . $questionCounter; ?></span> | |||
| <div class="progress-bar" style="margin-right: 10px;"> | |||
| <div class="progress progress-bar-success" style="width:<?php print ($questionCounter > 0 ? ($answerCounter / $questionCounter) * 100 : 0) . '%'; ?>;" title="<?php print($questionCounter > 0 ? $answerCounter . '/' . $questionCounter : 0); ?>"></div> | |||
| <?php | |||
| $percentage = ($answerCounter / $questionCounter) * 100; | |||
There was a problem hiding this comment.
Ici il y a un problème structurel
Le code ne protège pas de la division par 0
C'est pas de ton fait car c'est pas check plus haut mais si tu fait rien ca reste une fatal possible
Comment on lines
+901
to
+910
| if ($percentage == 0) { | ||
| print ('<div class="progress progress-bar-danger" style="width: 0%;" title="' . ($questionCounter > 0 ? $answerCounter . '/' . $questionCounter : 0) . '"></div>'); | ||
| } | ||
| if ($percentage > 0 && $percentage < 100) { | ||
| print ('<div class="progress progress-bar-warning" style="width:' . ($questionCounter > 0 ? ($answerCounter / $questionCounter) * 100 : 0) . '%;" title="' . ($questionCounter > 0 ? $answerCounter . '/' . $questionCounter : 0) . '"></div>'); | ||
| } | ||
| if ($percentage == 100) { | ||
| print ('<div class="progress progress-bar-success" style="width: 100%;" title="' . ($questionCounter > 0 ? $answerCounter . '/' . $questionCounter : 0) . '"></div>'); | ||
| } | ||
| ?> |
There was a problem hiding this comment.
Ca passe en soit mais pourquoi ne pas utiliser l'attribut html progress car la c'est pas posssible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.