Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openfast 4.0 coupling #1476

Open
marchdf opened this issue Feb 3, 2025 · 8 comments
Open

Openfast 4.0 coupling #1476

marchdf opened this issue Feb 3, 2025 · 8 comments
Assignees
@ndevelder @marchdf @lawrenceccheung
Labels
bug:amr-wind Something isn't working

Comments

@marchdf
Copy link
Contributor

marchdf commented Feb 3, 2025

Bug description

Openfast 4.0 coupling seems to be giving different answers than when using Openfast 3.5.
@marchdf marchdf added the bug:amr-wind Something isn't working label Feb 3, 2025
@marchdf
Copy link
Contributor Author

marchdf commented Feb 3, 2025

Running standalone openfast 3.5 and 4.0 with the same inflow gives the same answers:

Image
Image
Image
Image

@marchdf
Copy link
Contributor Author

marchdf commented Feb 10, 2025

Good news, we found the bug. It is in openfast: https://github.com/OpenFAST/openfast/blob/89358f1843b62071ee1a8ca943c1b5277bcbd45a/modules/externalinflow/src/ExternalInflow.f90#L426. Should be 9+1 not 9_1. Openfast devs are working on it.

@marchdf
Copy link
Contributor Author

marchdf commented Feb 10, 2025

Openfast bug fix: OpenFAST/openfast#2628

@lawrenceccheung
Copy link
Contributor

lawrenceccheung commented Feb 10, 2025 •
edited
Loading

Latest results using OpenFAST ExtInflow with 9+1 instead of 9_1.

TL;DR: Blade position now looks correct and the wakes look reasonable, but the turbine performance should be a closer match than this.

Image
Image
Image

Image

Image

Details for test case setup at https://gist.github.com/lawrenceccheung/aba7ae79738d9a08270648a0ca8eb07a

@lawrenceccheung
Copy link
Contributor

False alarm with my previous results. I forgot that the WakeMod parameter is now called Wake_Mod. After fixing that, everything lines up!

Image

Image

Image

Image

@marchdf
Copy link
Contributor Author

marchdf commented Feb 11, 2025

Nice!!

@marchdf
Copy link
Contributor Author

marchdf commented Feb 11, 2025

Spack update: spack/spack#48994

@andrew-platt
Copy link

OpenFAST release 4.0.2 with fix: https://github.com/OpenFAST/openfast/releases/tag/v4.0.2

Thanks for testing it and verifying the fix works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndevelder ndevelder

@marchdf marchdf

@lawrenceccheung lawrenceccheung

Labels
bug:amr-wind Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ndevelder @andrew-platt @marchdf @lawrenceccheung