Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use XPathEvaluators for PT property evaluation #8

Open
LandingEllipse opened this issue Apr 27, 2021 · 1 comment
Open

Use XPathEvaluators for PT property evaluation #8

LandingEllipse opened this issue Apr 27, 2021 · 1 comment
Labels
feature New feature or request performance Improvements or issues with the performance

Comments

@LandingEllipse
Copy link
Contributor

PTState._eval_prop() should use XPathEvaluator instances instead of the sources' .xpath() method, as this promises to speed things up quite a bit.

Not high on the list, but logging it here so it's not forgotten.
@LandingEllipse LandingEllipse added performance Improvements or issues with the performance feature New feature or request labels Apr 27, 2021
@LandingEllipse
Copy link
Contributor Author

Should also set up an xpath evaluator on Template (i.e. Template.xpath), as we could avoid the hassle on the processor side of having to use e.g. partial.label.xpath("...", namespaces=partial.nsmap).

Related enough, so I'm not going to split this into two issues. We'll just sort this all out in a single feature branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request performance Improvements or issues with the performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LandingEllipse