👍 fixs recovery data in api/v2 jhu #316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* formatting (120 length -> 100) * csbs to/from Redis * nyt to/from Redis * ignore locustfile * unused coordinates
* add sentry-asgi * sentry middleware
codedawi
force-pushed
the
master
branch
2 times, most recently
from
6a0bea5
to
761f62d
Compare
|
@codedawi Hey thanks for this! 😄 I'll take a look at this ASAP. |
This was
linked to
issues
May 20, 2020
Closed
|
@codedawi It definitely appears to have fixed the recoveries of many locations (US, AU, etc), but many other locations that are not showing up in the logs as having a "merge error" (DE, CN, CA etc) still show zero recoveries (for me locally). I'm almost inclined to merge it anyways 😄 . Any API users please feel free to chime in. {
"latest": {
"confirmed": 250138,
"deaths": 35422,
"recovered": 1067
},
"locations": [
{
"id": 217,
"country": "United Kingdom",
"country_code": "GB",
"country_population": 66488991,
"province": "Bermuda",
"last_updated": "2020-05-20T20:52:14.791765Z",
"coordinates": {
"latitude": "32.3078",
"longitude": "-64.7505"
},
"latest": {
"confirmed": 125,
"deaths": 9,
"recovered": 78
}
},
...
{
"id": 223,
"country": "United Kingdom",
"country_code": "GB",
"country_population": 66488991,
"province": "",
"last_updated": "2020-05-20T20:52:14.806740Z",
"coordinates": {
"latitude": "55.3781",
"longitude": "-3.436"
},
"latest": {
"confirmed": 248818,
"deaths": 35341,
"recovered": 0
}
},
...
{
"id": 257,
"country": "United Kingdom",
"country_code": "GB",
"country_population": 66488991,
"province": "Falkland Islands (Malvinas)",
"last_updated": "2020-05-20T20:52:14.884740Z",
"coordinates": {
"latitude": "-51.7963",
"longitude": "-59.5236"
},
"latest": {
"confirmed": 13,
"deaths": 0,
"recovered": 0
}
}
]
}I think I would like to merge this immediately to the US hosted version of the API that's based off my own fork. |
|
Any update on getting this merged in? If not we can just close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_category("recovered")methods injhuservice.Sierra LeoneNetherlands,Bonaire, Sint Eustatius and SabaMalawiFrance,Saint Pierre and MiquelonUnited Kingdom,Falkland Islands (Malvinas)South SudanWestern SaharaSao Tome and PrincipeYemenComorosTajikistanLesothoWhile reviewing the
jhuservice code I uncovered at critical bug that could expose this service to data & uptime issues in the future. In the PR the functionparse_historyis implemented as a temporary fix which will prevent the service from going down and providing consumers inaccurate data.Add note to code:
Potential address in @Kilo59's refactor mentioned.
FIXES: #161 #276 #113
FIXES: codedawi/covid19-badges#1
