[$1000] Web - Messages in thread are lost when sending many messages

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1.Open any chat
2. Chat a message
3. Go Reply in thread
4. Send many message (about > 40 messages or more), Observe that the thread does not display all the messages

Expected Result:

Thread show all message

Actual Result:

Thread does not display all the messages

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.47-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-29.at.13.48.00.2.mov

Recording.4005.mp4

Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690613255443729

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0154d84cddbf95e721
• Upwork Job ID: 1686824255957950464
• Last Price Increase: 2023-08-02

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[michaelhaxhiu]

This bug seems legit (I can reproduced) but it may already be captured in another ongoing GH. I will ask a C+ to help me determine that aspect.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0154d84cddbf95e721

[melvin-bot]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[Crystalian0322]

How can I submit proposal

[melvin-bot]

📣 @Crystalian0322! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Crystalian0322]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01f76925f200af331f

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[Crystalian0322]

how can i write proposal?

[fahad-islam]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01b12bc7773753485d

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[fahad-islam]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01b12bc7773753485d

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[fahad-islam]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01b12bc7773753485d

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[fahad-islam]

@thesahindia

Proposal

Please re-state the problem that we are trying to solve in this issue.

Action Performed:
1.Open any chat
2. Chat a message
3. Go Reply in thread
4. Send many message (about > 40 messages or more), Observe that the thread does not display all the messages

Expected Result:
Thread show all message

Actual Result:
Thread does not display all the messages

Workaround:

For me there is no such issue. But When I added new messages every-time application got hangs because I think so the state of application for handling newly added messages is very poorly managed.

And it seems like input field for adding new message is slow too... Maybe this is the only reason when we add new message it is not able to handle the load. Sometimes stay still at it's position visually for the time when all of the messages from it's Bucket are added successfully.

FOR ME kbecciv, threads are showing all of the messages.

Here's how it looks like for me when I reload threads *pretty-fast.

screen-capture.webm

If I am wrong, then please correct me!

Maybe I am skipping some step If the problem still exists for some users.

Actual Problem

Input is handling data poorly. That's why when list of messages updates it self all of the stuff goes wrong way

screen-capture.1.webm

What changes do you think we should make in order to solve the problem?

1. If we can optimize the input onChange function as well as all those that are monitoring input. Then we can overcome this problem.

2. It seems like input is attached with some API that is also making it a bit slower in response. If we detach them then we can make the input add new messages into the List of messages faster.

Conclusion, We need to optimize input field bindings to overcome this problem.

Why optimizing Input field is the Solution?

"Error for you and me seems to be a little different but both are from same cause. Flow of Data around Input and List of messages is handled in a wrong manner. Difference between my machine and your machine is that for me tab got hang up when this happen. User Interface of App does not response for that period. And for you due to Good Machine, Tab does not Hang up but you can clearly see the slow movement of data clearly."

[fahad-islam]

If you guys have any question, then do let me know!

[fahad-islam]

@MelvinBot What's next step

[michaelhaxhiu]

@fahad-islam please give 1-2 days for the assigned C+ member to review your proposal.

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[michaelhaxhiu]

Note: I'm preparing to go OOO for ~2 weeks and need a BZ buddy to watch over this in the meantime. 🙏

Next step: Please ensure that we push this forward and double price if no winning proposal in the next week (by 8/8).

Thanks in advance @stephanieelliott, I can take this back when I get back if it's not complete before then.

[bernhardoj]

Dupe of #15116 #17306

[stephanieelliott]

Thanks @bernhardoj! Agree this is a dupe of #15116 which was closed in favor of #12054 (comment)