Deploy Checklist: New Expensify 2024-01-25

[github-actions]

Release Version: 1.4.32-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Fix workspace money request is archived when we delete the workspace #31900
• fix workspace avatar issue on deletion #32986
• [TS migration] Migrate 'StatePicker' component to TypeScript #33352
• Don't treat muted reports as unread in LHN #33779
• Make referral banner dismissible #33925
• Display the message for last requests with foreign currency that are created in offline mode #34011
• [Refactor] Add UpdateMoneyRequestDistance command #34107
• fix IOU - Amount is not preserved in Manual page when the amount is changed in confirmation page #34131
• [TS migration] Migrate 'ThreeDotsMenu' component to TypeScript #34143
• [No QA] [Reassure] Sign in base perf flow #34228
• Fix - include current user in group chat members list #34237
• [TS migration] AvatarCropModal #34238
• fix: Workspace - User is scrolled down in Workspace invite page #34290
• fix: compose box is shown after tapping header and returning back #34404
• [TS migration] Migrate 'ReportActionItemCreated.js' component to TypeScript #34463
• [No QA] chore: add metrics for SearchPage #34489
• [TS migration] Migrate '[Remaining Group 3]' lib to TypeScript #34496
• Fix - Mark the chat as "read" immediately upon switching to the tab #34537
• 34265 update emoji offset #34589
• [TS migration] Migrate 'PrivateNotes' page to TypeScript #34656
• [TS migration] Migrate 'SelectionList' component to TypeScript #34794
• [No QA] Create helper to get the latest business day of a month #34887
• feat: allow policy admins to edit the report fields of a non-settled report #34889
• Fix some translations #34892
• [No QA] Add approval mode for policies #35047
• Update Set-Up-the-Card-for-Your-Company.md #35057
• [NoQA] Fix flaky search page reassure tests #35059
• Update copy for receipt scan #35096
• [CP Staging] Fix CMD+Enter in SelectionList #35241
• [CP Staging] Fix missing context menu options on money request preview #35285
• [CP Staging] Revert "Merge pull request #34537 from FitseTLT/fix-mark-as-read-on-v… #35308

Internal QA:

• Add logging and loading checks for short lived authToken sign-ins #34930 - @arosiclair

Deploy Blockers:

• [HOLD for payment 2024-02-05] [HOLD for payment 2024-02-01] Workspace - Workspace section loads infinitely after returning from Connect bank account #35071
• [HOLD for payment 2024-02-05] [HOLD for payment 2024-02-01] Notifications - Unable to save notification preference #35076
• [$500] mWeb/Chrome-Login-FAB menu is not opened after closing the engagement modal for new account #35148
• Workspace - Custom avatar uploaded offline is inconsistent after deleting workspace #35177
• Distance - Preview amount after edit distance not update, incorrect report calculations #35178
• Distance - No error message when saving duplicate points #35193
• Distance - "Out of pocket" and "Company spend" appear in report after changing distance #35194
• [HOLD for payment 2024-02-07] [HOLD for payment 2024-02-05] IOU - CMD+Enter command does not work when selecting currency #35235
• [HOLD for payment 2024-02-07] [$500] IOU - Options missing from context menu when long tap IOU report #35244
• Sign In - Sign In with google/apple web page not loaded when user click on google/apple icon #35250
• [HOLD for payment 2024-02-07] [HOLD for payment 2024-02-05] Desktop - Unread marker remains after opening chat with new messages #35251
• [HOLD for payment 2024-02-07] [HOLD for payment 2024-02-05] [$500] Desktop - Unread chat becomes unbolded in LHN without opening unread messages #35254
• Room - System message for room name change shows "renamed from #B to #B" #35323

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.32-2 🚀

[arosiclair]

#34930 passes QA

[rlinoz]

Demoting #35177

[kbecciv]

Regression is 50% left

#33779 - pending validation
#34107 is failing #35178
#34889 - pending validation
#34892 - checking off per comment #34892 (comment)

Deploy Blockers:

#35178
#35193
#35194

[francoisl]

Checking off 35193, a backend fix was merged. It's a minor issue so we'll let it get deployed as usual over the next few days.

[thienlnam]

Checked off the rest of the blockers - the only remaining one is #35178, which will be resolved when the next Auth deploy happens. Though I don't think we're deploying Auth again this week so we may be held until Monday

[kbecciv]

Regression is completed

#33779 is failing in Desktop with #35251 and #35254
#34107 is failing #35178
#34889 is failing #34690 (comment), repro in prod, checking off

Deploy Blockers:
#35178
#35235
#35244
#35250
#35251
#35254

[francoisl]

Current status on blockers:

• Sign In - Sign In with google/apple web page not loaded when user click on google/apple icon #35250: can't repro, checking it off
• [HOLD for payment 2024-02-07] [$500] IOU - Options missing from context menu when long tap IOU report #35244: fix being CP'ed now
• [HOLD for payment 2024-02-07] [HOLD for payment 2024-02-05] IOU - CMD+Enter command does not work when selecting currency #35235: fix being CP'ed now
• Room - System message for room name change shows "renamed from #B to #B" #35323: backend issue, removing blocker label

---

• [Refactor] Add UpdateMoneyRequestDistance command #34107: going to check based on Aldo's comment below
• Don't treat muted reports as unread in LHN #33779: offending PR was reverted, checking

Will update this comment with status of other blockers in a bit.

[aldo-expensify]

#35178 completed

[francoisl]

All CP's are complete, I'm going to test them and then we should be ready to close this checklist if all is well.

[francoisl]