Airship starts RN in headless mode on initial launch

[jnowakow]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: lastest main
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: no
Email or phone of affected tester (no customers):
Logs:
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation (hyperlinked to channel name):

Action Performed:

1. Remove app from phone
2. Install app
3. Open app

Expected Result:

Describe what you think should've happened

RN should be bundled only when ND is opened.

Actual Result:

Describe what actually happened

In metro one can observe that RN is bundled when app is started and OD login screen is displayed.

It's caused by Airship's ReactAutopilot here. It can cause problems like #54988 which are hard to debug.

We have two options to solve this problem. We can create a patch for version 19.2.1 that removes the problematic code. Or we can update ua/react-native-airship lib to latest version 21.0.0 where @rlepinski added option to disable that call.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[jnowakow]

cc @Julesssss

[OfstadC]

Will take a look at this tomorrow AM 😃

[rlepinski]

if you are updating to latest Airship release you may want to hold off until 21.0.1. A swift 6 related issue popped up with network connection not being available that causes a crash in the app - urbanairship/ios-library#420. We should have it patched today.

[melvin-bot]

📣 @rlepinski! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[jnowakow]

@Julesssss would be nice if you had a moment to take a look at this one

[Julesssss]

I think we can get this merged. Just needs some tests.

[melvin-bot]

@Julesssss, @OfstadC, @jnowakow Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Julesssss]

@jnowakow can you add some more detailed tests to the github issue please (for qa)

[Julesssss]

Recommenting to remove overdue